[00:01:39] (03PS1) 10Bmansurov: Filter out retired WikiGrok tags from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) [00:58:26] (03CR) 10Krinkle: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (owner: 10Jdlrobson) [00:58:28] (03CR) 10jenkins-bot: [V: 04-1] Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (owner: 10Jdlrobson) [00:59:03] (03PS3) 10Krinkle: Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [00:59:05] (03CR) 10jenkins-bot: [V: 04-1] Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [02:23:16] (03PS1) 10Mhurd: Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 [02:26:20] (03PS2) 10Mhurd: Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 [03:12:57] (03CR) 10Krinkle: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [03:14:00] (03CR) 10jenkins-bot: [V: 04-1] Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [05:55:56] (03PS1) 10Jdlrobson: lstprop=owner and a few bug fixes [extensions/Gather] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/201118 [05:56:08] (03PS1) 10Jdlrobson: lstprop=owner and a few bug fixes [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201119 [08:14:30] good morning! [09:23:39] (03PS3) 10Jhernandez: Add pagination to Special:GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200943 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [09:27:08] (03CR) 10Jhernandez: [C: 032] "Merging. I've added some styling to the button." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200943 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [09:27:58] (03PS5) 10Jhernandez: Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 (owner: 10Jdlrobson) [09:28:34] (03PS6) 10Jhernandez: Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [09:29:38] (03Merged) 10jenkins-bot: Add pagination to Special:GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200943 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [10:04:02] (03CR) 10Jhernandez: [C: 031] "Gonna fix up the docs and will merge" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [10:06:51] (03PS7) 10Jhernandez: Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [10:12:10] (03CR) 10Jhernandez: [C: 032] Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [10:12:23] (03PS4) 10Jhernandez: Pagination of collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201046 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [10:14:52] (03Merged) 10jenkins-bot: Add pagination on Special:Gather for list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201045 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [10:20:40] (03CR) 10Jhernandez: "Docs copypasta mistakes. Fixin' & mergin'" (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201046 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [10:21:43] (03PS5) 10Jhernandez: Pagination of collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201046 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [10:21:59] (03CR) 10Jhernandez: [C: 032] Pagination of collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201046 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [10:22:46] yo phuedx whatever you need from gather count me in [10:23:06] i'm eager to get the fucker deployed finally [10:24:50] (03Merged) 10jenkins-bot: Pagination of collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201046 (https://phabricator.wikimedia.org/T94515) (owner: 10Jdlrobson) [11:01:05] (03CR) 10Jhernandez: [C: 032] "Works good. Also now it is basically instant, so it is almost impossible to click the watchstar before the CTA appears." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200077 (owner: 10Robmoen) [11:03:53] (03Merged) 10jenkins-bot: Prevent tutorial from showing if user clicks watchstar prior to load [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200077 (owner: 10Robmoen) [11:03:56] i forgot to open up irc cloud :/ [11:04:00] hey joakino [11:04:11] hellow phuedx! šŸ˜€ [11:04:14] cool, just need to make sure the deployment branch is in working order, right? [11:04:31] phuedx: i'm not sure what's going on :) [11:04:33] xD [11:05:16] phuedx: in the email there are patches to cherry pick I guess to the deployment branch [11:05:38] phuedx: so probably try that, deploy to test wiki and see if there are fatals or something [11:05:49] ^ classic mobile web team [11:05:55] jdlrobson should be up in a few hours, he probably has a clear idea of what's going on [11:05:57] hahah [11:09:01] joakino: given that there's no clear message in that thread, i'll wait for jdlrobson [11:09:19] sounds reasonable :) [11:31:25] tneed coffee [11:34:18] (03CR) 10Florianschmidtwelzow: [C: 032] Fix notices on bogus language codes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199177 (https://phabricator.wikimedia.org/T93500) (owner: 10MaxSem) [11:39:15] (03Merged) 10jenkins-bot: Fix notices on bogus language codes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199177 (https://phabricator.wikimedia.org/T93500) (owner: 10MaxSem) [11:44:31] (03CR) 10Florianschmidtwelzow: Re-start versioning the extension (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [12:19:38] (03PS4) 10Phuedx: Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 [12:20:14] (03CR) 10jenkins-bot: [V: 04-1] Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (owner: 10Phuedx) [12:45:13] (03CR) 10Phuedx: [C: 031] "This looks alright to me. We're going to need to come up with a plan to test all of this when it's tied together." (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [13:10:35] lining up things for the gather ploy later [13:25:24] as the guy who started this channel, long, long agoā€¦ I did this for April fools today: http://www.wordset.org [13:41:45] (03PS1) 10Dbrant: Handle more general errors when making network requests. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/201186 (https://phabricator.wikimedia.org/T94559) [14:04:36] (03CR) 10Bgerstle: [C: 031] "I agree with corey's comments and i left one non-blocking comment about isTransparent. however, +1'ing since IMO the API is reasonably cle" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [14:25:35] (03PS1) 10Dbrant: Fix possible crash(es) when highlighting text to share. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201195 (https://phabricator.wikimedia.org/T94311) [14:28:12] hey jdlrobson [14:31:38] (03CR) 10Bgerstle: [C: 04-1] "see comments in savedpagesVC, also please add a phab ticket w/ design & functionality requirements so we can do runtime review." (0310 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [14:32:45] (03CR) 10Bgerstle: "rebase then i'll +1" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200893 (owner: 10Mhurd) [14:34:34] yyooo baby! [14:36:08] yoooo [14:36:40] * jdlrobson high fives phuedx [14:36:47] jdlrobson: testwiki is running 1.25wmf23, so i suggest we derploy that one first [14:37:15] jdlrobson: are https://gerrit.wikimedia.org/r/#/c/201119/ and https://gerrit.wikimedia.org/r/#/c/201118/ good to go? [14:37:30] * phuedx high fives jdlrobson right back [14:37:36] i am nervous though [14:37:40] phuedx: sounds good. And here's some inspiration http://googlepress.blogspot.com/2004/04/google-gets-message-launches-gmail.html [14:37:55] apparently they launched to beta haaha [14:38:18] lol!!! [14:38:35] phuedx: yeh makes sese. provided you know how to check the logs for exceptions we'll be fine :) [14:38:45] i'm just grabbing coffee so i'm 100% useful to you [14:43:23] phuedx https://instagram.com/p/0qf7oPM2K8/?taken-by=jdlrobson [14:43:58] \o/ [14:44:12] jdlrobson: if you're happy widdem patches then let's get 'em merged [14:44:21] then i can prep the core submodule updates [14:44:30] want to do this cleanly [14:44:38] so i'm not able to +2 [14:44:53] (03CR) 10Jdlrobson: [C: 031] lstprop=owner and a few bug fixes [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201119 (owner: 10Jdlrobson) [14:45:07] only +1 sadly [14:45:17] jdlrobson: ? [14:45:24] the gather changes? [14:45:30] yeh on wmf branches [14:45:38] guess cos i don't deploy? [14:45:50] probs [14:45:54] let me check! [14:45:57] ;) [14:46:12] (03CR) 10Phuedx: [C: 032] lstprop=owner and a few bug fixes [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201119 (owner: 10Jdlrobson) [14:46:17] jdlrobson: ^ [14:46:25] BOOM! [14:47:00] you want to do the 22 one too or you wanna wait until it's out on testwiki? [14:49:12] i'll check test wiki first [14:49:13] safer [14:49:29] (03Merged) 10jenkins-bot: lstprop=owner and a few bug fixes [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201119 (owner: 10Jdlrobson) [14:49:45] gotta wait and see if https://test.m.wikipedia.org/wiki/Special:Gather/by/Jdlrobson/1 stops throwing exceptions [14:49:51] it did locally [14:50:27] phuedx: how long does this usually take? [14:50:38] jdlrobson: i'm not sure -- this is the first time i've done it [14:50:43] :D [14:51:04] having everything lined up is probably a useful first step though :) [14:53:52] jdlrobson: https://gerrit.wikimedia.org/r/#/c/201201/1 [14:54:17] phuedx: is that the commit to enable it? [14:54:32] that's the commit to update the extension submodule [14:54:32] actually you might as well merge wmf/1.25wmf24 too [14:54:59] wait, aren't we running wmf/1.25wmf22 and 23? [14:55:10] oh sorry my bad yeh just those 2 [14:55:28] i meant 22 :)\ [14:55:47] mmm the patch isn't kicking in on testwiki yet [14:56:53] phuedx: sure you don't need to do anything else? [14:57:29] can you check the logs there and see if they are throwing the same exception? [14:58:14] jdlrobson: i'll actually need to pull the code onto tin [14:58:20] ooh [14:58:21] but the swat window isn't open yet :) [14:59:08] (03CR) 10Phuedx: [C: 032] lstprop=owner and a few bug fixes [extensions/Gather] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/201118 (owner: 10Jdlrobson) [15:00:05] haha [15:01:43] (03Merged) 10jenkins-bot: lstprop=owner and a few bug fixes [extensions/Gather] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/201118 (owner: 10Jdlrobson) [15:01:52] (03CR) 10Bgerstle: "since this doesn't actually interpolate

tags as newlines in the resulting string, we end up with one really long string: https://www.d" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (owner: 10Mhurd) [15:02:07] (03PS7) 10Bgerstle: Collapse image gallery description whitespace. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (https://phabricator.wikimedia.org/T93662) (owner: 10Mhurd) [15:07:12] yo jdlrobson phuedx [15:07:18] whats going on [15:07:24] see #wikimedia-operations [15:08:04] yoo babbby [15:09:06] joakino, jdlrobson: waiting on core submodule updates to merge on release branches [15:09:14] * phuedx taps keyboard nervously [15:10:40] testwiki? [15:10:53] phuedx: it takes a long time i've been told [15:11:04] joakino: i'll update testwiki first [15:11:35] joakino: afaict all of the required patches have been lined up if everything's ok [15:12:28] ok 22 is down [15:12:30] waiting on 23 [15:14:06] bearND: i just added your email address to the tech role. you should be receiving an email relatively soon, sometimes it takes up to an hour, for confirmation of the email address. would you please let me know once you've followed the confirmation step? [15:16:22] and 23 is testwiki? [15:17:08] dr0ptp4kt: Just got an iTunes Connect email, and activated it. I see the three WP apps, and TWN and commons apps [15:17:10] testwiki is running 23 je think [15:17:39] bearND: k, one moment [15:18:31] phuedx: mm..correct https://test.m.wikipedia.org/wiki/Special:Version [15:18:38] but still exception on https://test.m.wikipedia.org/wiki/Special:Gather/by/Jalexander-WMF/7 [15:18:44] did you tin it? [15:19:00] or is that the one we are still waiting on [15:20:04] bearND: ok, now there should be invitation emails for the stable (for testing upgrades ) and the beta channels. you want to open the links on the ios 8 device where you installed testflight to entitle the TestFlight/device for installation [15:22:53] mholloway: got a couple minutes for hangout? [15:23:10] sure [15:26:41] jdlrobson, pls review the autoimage patch because it changes the code structure a bit [15:26:54] yurik: not right now doing a deployment :) [15:27:13] nothing else is thus important yet :) [15:28:27] jdlrobson: phuedx: need me to check something? [15:29:25] sec [15:33:33] jdlrobson: https://test.m.wikipedia.org/wiki/Special:Gather/by/Jalexander-WMF/7 works now [15:39:20] dbrant: lol, i like that we have a SaneAsyncTask [15:39:34] mholloway: yep! [15:42:19] mholloway: btw, if you're working on that task, you can edit the Phab bug and add it to the current sprint ("associate" it with the project called "Mobile-App-Sprint-54-Android"). [15:42:39] mholloway: and then move it to the "doing" column [15:43:36] dbrant: great, i was wondering about that [15:45:19] Krenair: hey there! who do we see about providing OTRS access to our new Android dev (mholloway)? [15:45:42] I think Deskana should ask RD? [15:45:49] probably [15:46:11] or otrs-admins@lists.wm.o [15:46:21] dbrant: what makes our SaneAsyncTask sane? [15:48:27] phuedx lemme know if you need to postpone our chat until it's safe for you to take your derployment helmet off, I'm flexible. [15:49:15] kristenlans: i didn't see your invitation -- hrrrm [15:49:23] aww crap [15:49:23] 15 minutes until the window is closed anyway [15:49:45] did i do the old "make an invite but not invite the person" trick? [15:50:02] mholloway: mostly the fact that it funnels any exceptions thrown during the task into a convenient "onCatch" callback. And you can specify a "concurrency level", which will make it execute on different executors, if necessary. [15:50:27] kristenlans: i love that trick [15:50:55] kristenlans: ha, joke's on them! [15:51:09] LOL! [15:51:27] April Fool's? [15:54:06] kristenlans: we're deploying on april fools [15:54:22] til gmail launched on april fools to a 1000 person beta [15:54:28] which is reassuring to me [15:55:06] jdlrobson: Genius. If anything goes wrong, you just be all "APRIL FOOL'S GUYS!!!" [15:55:34] that's what i figured! the perfect excuse ;-) [15:57:31] https://com.google/ [15:57:48] wat?? [15:57:55] take a look ) [15:58:56] phuedx anyhoo, I actually added you to invite now for meeting in 2 minutes, but take your time OR we can reschedule. I'll just talk to myself in the hangout if I need to wait a bit. [16:00:59] (03CR) 10Bgerstle: "responding to coreyfloyd's comments" (0317 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [16:07:04] phuedx: so nothing till evening? [16:07:15] joakino: yeah -- sorry [16:07:35] i got the patches prepped to slowly [16:07:55] waaa? [16:08:25] *too [16:08:58] jdlrobson, joakino: it was my first time, so i was slow [16:09:11] i also didn't know that those changes were going to take ~10 minutes to merge [16:09:15] it's out on testwiki and working [16:09:30] :-( no worries.. it wasn't your fault the whole process takes too long. [16:09:31] if we schedule the config change to go out in the evening window that's cool, right? [16:09:45] at least we have more confidence it will not blow up when we push to production at 4pm. [16:09:49] ^ that [16:10:11] yeh that should be fine. I just hope Max/Kaldari can do it earlier this time round - last 2 days i've had to rush out at 5pm and not been around for that [16:10:30] it was worth a go [16:10:40] phuedx: where's the config change? [16:10:52] i'll put it on the calendar [16:11:08] jdlrobson: https://gerrit.wikimedia.org/r/#/c/201065/1 [16:11:28] remove kaldari's -2 remarking that it's fixed on testwiki (we think) [16:12:57] https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=151627&oldid=151626 < phuedx [16:14:33] jdlrobson: great :) [16:14:37] i'll be faster next time [16:17:24] ok update sent [16:17:29] thanks for everything phuedx-meeting [16:32:44] (03CR) 10Jdlrobson: [C: 04-1] "Doesn't work for the list of collections" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200754 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [16:32:53] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (owner: 10Jdlrobson) [16:35:16] (03PS3) 10Bgerstle: paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) [16:35:25] coreyfloyd: ^ cleanup comments (should be) mostly addressed [16:35:37] going to make ImageInfoController API modifications now [16:35:44] bgerstle: cool - you want to talk real quick about your amendment to my patch? [16:35:54] coreyfloyd: i'd rather get this merged first if that's OK [16:36:02] bgerstle: np [16:36:03] context switching FTL [16:36:09] (as in, for the loss, not faster than light) [16:36:12] I'm on it [16:36:22] oh almost forgot [16:36:34] (03CR) 10Bgerstle: "responses" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [16:36:44] coreyfloyd: responded to your comments on the old patch set ^ [16:36:54] my last patch also involved rebasing [16:37:34] so if you do patch v. patch diffing.. you might be in for an unpleasant surprise [16:37:51] yay gerrit :-P [16:38:01] still need to do that github experiment i talked about last week [16:39:20] grrr unit tests are brokennnn [16:39:46] maybe a clean will fix it [16:41:44] nope, coreyfloyd the different configurations & product names are missing up teh unit tests [16:41:51] that's why the test lane is broken [16:41:53] fixing now.. [16:42:09] or wait [16:42:41] i just can't run specific tests from the test file [16:43:09] or... now i can... WTF i don't know what happened [16:46:37] (03CR) 10Fjalapeno: "responses" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [16:49:25] (03CR) 10Fjalapeno: "one moreā€¦" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [16:50:13] bgerstle: yeah - was going to start looking into the testing todayā€¦ [16:57:07] (03CR) 10Bgerstle: paginate image info requests (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [16:59:46] (03CR) 10Bmansurov: Re-start versioning the extension (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [17:11:50] (03CR) 10Jhernandez: [C: 032] Fix meta tags for collections (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200745 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [17:11:57] (03CR) 10Jdlrobson: Re-start versioning the extension (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [17:12:01] ok i'm heading into the office [17:12:40] cya in 30 [17:18:31] (03CR) 10jenkins-bot: [V: 04-1] Fix meta tags for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200745 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [17:30:05] Deskana I forgot to mention in standup...did you hear the new about Phabricator? :-| [17:30:19] kristenlans: What's that? [17:30:35] Bought by Microsoft and going to be paid subscription only [17:30:50] kristenlans: Oh, so you've not heard the newer news then? [17:30:55] kristenlans: The WMF is officially migrating to Trello. [17:31:05] kristenlans: Wait, do Americans clap awkwardly? [17:31:07] Deskana: kristenlans can we use pivotal tracker now???? [17:31:13] Dang it, are you on to me!?!?!? [17:31:31] April PHOOLS!!! [17:31:33] https://www.pivotaltracker.com/help/faq#istrackerreallyfreeforpublicprojectsindividualusenonprofitsandeducators [17:31:46] ahhhh kristenlans i got so excited :'''( [17:31:53] sorry bgerstle ;-) [17:32:05] * bgerstle starts nagging MS to buy Phab [17:32:13] bgerstle: lol [17:32:18] (but seriously, we could use pivotal tracker...) [17:32:55] bgerstle: I fear we would be the scourge of WMF if we did that... [17:33:06] or brave pioneers and explorers... [17:33:12] dbrant: do you know if there's any lower bound (other than zero) on the size of images Face Detector will work on? I haven't found any. Just trying to find out if there's a better way than picking a number out of thin air to resize to [17:33:50] mholloway: at our recent quarterly planning, at the end of our morning session everyone started clapping and Deskana was like "WTF? is this a thing? why are we clapping?" [17:34:08] kristenlans: ha, i see [17:34:15] mholloway: I was just like "...seriously? We do this now?" [17:34:21] Deskana: hahaha [17:34:45] Clappingā„¢, the coolest new team practice [17:35:33] mholloway: i'm not aware of a lower bound. let's start with a hardcoded value (e.g. 120) and see how it performs. It might take a little experimenting to get it right. [17:35:55] kristenlans: Deskana: sometime when I'm not supposed to be working I'll have to try to look up the origins of the practice of clapping. [17:36:29] dbrant: sounds good. [17:36:51] mholloway: looking it up on wikipedia techincaly coutns as working, maybe? http://en.wikipedia.org/wiki/Clapping [17:37:31] actually: http://en.wikipedia.org/wiki/Applause [17:37:32] mholloway: as a minnesotan, i suspect clapping's origin was "mosquitogenic" [17:37:41] dr0ptp4kt: ^ [17:38:06] mhurd: ha, i bet! [17:38:15] mhurd: or takes care of two birds with one stone [17:40:46] dr0ptp4kt: what do you think is the best way for me to share my thoughts on the release cadence stuff? this page? https://www.mediawiki.org/wiki/Talk:Wikimedia_Apps/Team/Release_process#iOS_Release_Process [17:41:36] kristenlans: yeah, that would be swell [17:43:18] bgerstle: coreyfloyd great feedback on the loading indicator patch... amending [17:43:38] (03PS1) 10Deskana: Update credits to include new team members. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201236 [17:44:39] (03CR) 10Fjalapeno: Hide loading spinner when using back-forward. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [17:44:48] mhurd: np [17:45:22] mhurd: good work in getting it up and running! [17:45:44] coreyfloyd: ya just changed it to isShowing. isVisible works too [17:46:29] mhurd: cool [17:49:47] coreyfloyd: the cut tomorrow will be on the alpha channel only, right? no risk of overwriting the stable that's under review or the beta that's released to external testers, right? [17:49:57] dr0ptp4kt: yep [17:50:02] coreyfloyd: word [17:50:10] dr0ptp4kt: can you give me a list of people to cut alpha to? [17:50:20] dr0ptp4kt: like just all internal testers? [17:51:37] gonna take a break [17:52:52] bgerstle: I found a wonderful little thing you added to the app. [17:52:55] bgerstle: I quote... [17:52:56] #warning TOOD: refactor into separate crash-reporting class [17:52:58] TOOD [17:53:47] http://www.urbandictionary.com/define.php?term=Tood [17:55:23] Deskana: you know what i meant [17:55:31] also, you *had* to do git-blame to figure out the culprit? [17:56:00] Deskana: while you're there, feel like doing some refactoring? ;-) ;-) [17:56:18] bgerstle: You can blame mhurd for showing me how to find out who added it. :-p [17:56:26] hehe [17:57:18] Deskana: you git-savvy product manager, you [17:57:33] * bgerstle rewrites git history to anonymize all of its commits [17:57:46] LOL [17:58:12] (03PS1) 10Deskana: Fix a typo in AppDelegate.m [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201239 [17:58:24] * coreyfloyd creates new gerrit account for his dog to cover his tracks [17:58:32] (03CR) 10Bgerstle: [C: 04-1] Fix a typo in AppDelegate.m [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201239 (owner: 10Deskana) [17:58:41] (03CR) 10Bgerstle: [C: 031] "APRIL FOOLS" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201239 (owner: 10Deskana) [17:58:51] * Deskana sighs [17:59:07] Deskana do you "celebrate" April Fools in UK? [17:59:23] bgerstle: As with many things... yes we do, but Americans do it bigger. [17:59:28] either way, get ready for a lot of this: http://gifs.gifbin.com/062009/1243937143_supplies.gif [17:59:45] Deskana: damn right we do [18:02:01] (03PS1) 10Deskana: Update credits to include new team members. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201241 [18:02:57] (03CR) 10Bgerstle: "should we just put a link to the team wiki?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201241 (owner: 10Deskana) [18:03:03] kristenlans: we were thinking to request an iOS-Lyon-Hackathon-Prep project for tracking prerequisites for the lyon hackathon (e.g., making it seamless for people to setup their mac). but would it make more sense to use the existing project https://phabricator.wikimedia.org/tag/wikimedia-hackathon-2015/ and have another column on the workboard? i see there's an 'organization' column, but it seems like we may overwhelm that column, so hen [18:03:04] potentially another column. cc bgerstle coreyfloyd mhurd [18:03:22] dr0ptp4kt: i was also thinking a "tag" project would work [18:04:00] or we can add it to the existing hackathon project (unless that's reserved for hacks and not infra to support hacking) [18:10:06] (03PS4) 10Bgerstle: paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) [18:10:07] coreyfloyd: image info controller API modified to include range, plus added a NSIndexSet+BlocksKit extension [18:10:12] dr0ptp4kt: it seems like the Organization column makes the most sense (there are tasks in there that are "prep" for specific projects). I'd check with Quim and Rachel Farrand to see if they care how many tasks are in there. They also might have some good insight on how other people are tracking prep stuff. [18:10:14] now for some functional testing.. [18:10:53] kristenlans: thx [18:12:05] still seems good [18:15:19] hey joakino rmoen back [18:16:03] (03PS10) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [18:16:13] bgerstle: coreyfloyd ^ [18:17:50] (03CR) 10Mhurd: Hide loading spinner when using back-forward. (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [18:18:28] (03PS11) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [18:20:23] (03PS1) 10Jdlrobson: Fix PHP error for non-initialized variable [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201243 (https://phabricator.wikimedia.org/T94722) [18:22:23] (03PS3) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [18:23:27] (03PS5) 10Jdlrobson: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 [18:24:48] (03PS2) 10Jdlrobson: Fix meta tags for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200745 (https://phabricator.wikimedia.org/T91696) [18:25:00] Deskana: check out the super helpful wikidata description on enwiki "mineral" [18:25:05] (03CR) 10Jdlrobson: [C: 032] "rebbbasseerrr" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200745 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [18:25:32] What. [18:25:34] Deskana: https://www.youtube.com/watch?v=KM-CguGXWk8 [18:25:45] did we do that? [18:26:15] jdlrobson: Yes! [18:26:22] ahhh cool. now i know why i was confused https://twitter.com/andrewjordan/status/583326616476094464 [18:26:24] (03CR) 10jenkins-bot: [V: 04-1] Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (owner: 10Jdlrobson) [18:26:26] he did the music i think? [18:26:30] i thought he'd made the video [18:27:29] (03Merged) 10jenkins-bot: Fix meta tags for collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200745 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [18:27:33] Deskana: what hash tag should i be following to see all the people using it? [18:27:57] jdlrobson: We couldn't put a hashtag in because then it'd also put hashtags in places where they shouldn't go. [18:28:13] ahhh anything i can search for on twitter? [18:28:45] jdlrobson: Nothing that doesn't have false positives it seems. [18:28:59] jdlrobson: This might help: https://twitter.com/search?q=%40wikipedia&src=typd&mode=photos [18:29:06] Deskana: :-( [18:29:19] any chance you can get a hash tag of some sort in - would be really good to get a good idea for usage [18:29:45] MaxSem: is there another way in php to add a module to a page other than using the onBeforePageDisplay hook? [18:30:37] bmansurov: where are you trying to add a module? [18:30:43] there are many ways [18:30:50] (too many ways) [18:31:11] jdlrobson: I want to add a cirrus search javascript file page to a page [18:31:20] what kind of page? [18:31:36] jdlrobson: any desktop page [18:32:27] jdlrobson: my concern is the slow deployment when I use onBeforePageDisplay [18:32:44] what does the file do? [18:32:48] can you defer load it [18:33:06] bmansurov: use RL hooks :) [18:33:09] jdlrobson: yeah, it listens to some tracking events from core and logs them to the server [18:33:15] FlorianSW: which one? [18:33:23] bmansurov: but i assume it kicks in when you interact with search? [18:33:31] yeah [18:33:39] have you run this by ori ? [18:34:01] and is it sampled? [18:34:16] jdlrobson: haven't run by ori, but yes, sampled [18:34:45] jdlrobson: so what other ways are there? i can read up myself [18:34:52] BeforePageDisplay is the normal way to do this or you'll have to bundle it in an existing module [18:35:06] it's difficult for a reason as you'll adding new JS to the page load [18:35:50] it needs to get into the html somehow [18:35:53] i would recommend quickly running this pass ori to avoid any surprises. [18:36:06] jdlrobson: I think he's one of the reviewers [18:36:51] bmansurov: i'm not sure, but try https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderRegisterModules (i'm not sure, if it's possible to load modules via RL, i misread you, i thought you mean config variables, sorry) [18:37:42] FlorianSW: np, you're right, I'm using a hook to register a module, but I need to add it to a page too [18:37:57] yeh he's busy though bmansurov so it's worth poking him over e-mail [18:38:08] FlorianSW: that hook only registers modules [18:38:10] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8251440 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8131126 and https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8123646 - very similar... dbrant , FlorianSW [18:38:12] you still need to get them on the page HTML [18:38:21] or add some js to pull them in [18:38:54] same device, same exception... very similar domains too [18:38:57] bmansurov: you'll avoid reverts if you poke ori for a sanity check :) [18:39:05] jdlrobson: ok thanks [18:39:19] I wonder why the last one has no m. in the api url [18:42:02] brings back memories http://chrome.blogspot.com/2015/03/introducing-chromeselfie.html [18:43:04] lololol https://twitter.com/Pinboard/status/583336330907635712 [18:43:57] MaxSem, answering https://phabricator.wikimedia.org/T94718 ? -- my thoughts - osmbeta, osmstage [18:44:56] osm4realz :P [18:45:00] Krenair: they're all using an oudated version of the app? [18:56:52] (03PS1) 10Jdlrobson: Correct the title used in Special:CheckUser for abuse filter rule matches [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201249 [18:58:44] (03CR) 10jenkins-bot: [V: 04-1] Correct the title used in Special:CheckUser for abuse filter rule matches [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201249 (owner: 10Jdlrobson) [19:00:52] (03PS2) 10Jdlrobson: Correct the title used in Special:CheckUser for abuse filter rule matches [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201249 [19:01:41] (03PS3) 10Jdlrobson: Correct the title used in Special:CheckUser for abuse filter rule matches [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201249 (https://phabricator.wikimedia.org/T94730) [19:02:13] MaxSem, sure, osm4real is good ) [19:04:33] yurik, but seriously... maps-team? [19:04:49] MaxSem, do we have "maps"? [19:05:06] yes [19:05:42] maposm... [19:05:48] osmap [19:05:59] short is better ) [19:06:11] osmap is best i think ) [19:06:30] you will not really need to type it later ;) [19:06:30] osmtile [19:06:44] still ambiguous [19:06:51] true. osm-team is ok [19:06:54] osmteam [19:07:14] maps-team [19:07:29] sure [19:07:34] ok [19:14:45] deskana mhurd https://etherpad.wikimedia.org/p/iosappcadencenojoke [19:55:05] mhurd: around? [19:56:07] mhurd: would you be able to do the ios 6 & ios 7 overlay upgrades with andy around 4-5 PM? [19:56:32] Ya! [19:56:45] Overlay? [19:56:53] dr0ptp4kt: ^ [19:57:27] mhurd: that is, install the org.wikimedia.wikipedia with that git tag (git checkout ) i listed in the email [19:57:38] mhurd: he said he'll be there 4-4:30 [19:58:03] this is to enable him to do upgrade testing on ios 6 & ios 7 before launching into the regression & other tests on them [19:58:35] 'overlay' maybe not a good choice of term :) [19:58:53] 'org.wikimedia.wikipedia upgrade' more accurate [20:05:29] mholloway: https://lists.wikimedia.org/mailman/listinfo/mobile-l [20:08:57] mholloway: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team [20:16:04] (03PS5) 10Bgerstle: paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) [20:16:10] coreyfloyd: let me know when you get a chance to review ^ [20:16:17] i'm going to have a snack and step out for a bit, though [20:16:54] bearND: when do you think we could push through the WebView patch(es) (as well as the other bugfixes), and push out a beta? [20:22:20] bgerstle: ok - have a meeting in a few, so probably afterā€¦ [20:22:32] coreyfloyd: ok [20:22:38] maybe we can wrap that up and do some CI stuff afterwards? [20:28:19] yurik, added you to project admins on maps-team. you might still need to adjust your sudo rights in https://wikitech.wikimedia.org/wiki/Special:NovaSudoer [20:28:35] thx [20:29:33] MaxSem, not sure what i would change there, seems fien [20:29:35] fine [20:30:17] we'll see, I remember not being able to use sudo until manually tweakig something in the past [20:30:55] coreyfloyd: restarting to pickup the camera [20:31:57] MaxSem, is 2GB RAM / 20GB root enough? [20:35:06] yurik, 2g ram is enough for experimentation. not sure how much would be needed if we want to recompile something locally. as of disk space, I recommend grabbing as much as possible [20:35:59] ok, will create "huge" [20:36:24] MaxSem, 16GB, 160GB root [20:36:33] MaxSem, debien 8 jesse [20:36:45] 8cpu [20:36:50] 4g is prolly enogh [20:36:55] yup [20:37:00] will take a while [20:37:09] can't - its preconfigured [20:37:17] RAM attached to space [20:37:25] we can always kill it later ) [20:37:52] mhurd i left a comment on https://gerrit.wikimedia.org/r/#/c/200748/ [20:38:04] can you follow up w/ vibha or someone else in prod/design to verify the behavior on the jellyfish article? [20:38:50] the only potential thing i would change is storing the HTML and setting it w/ an attributed string on iOS 7+ [20:38:55] otherwise seems fine [20:39:20] mhurd: bgerstle coreyfloyd bearND dbrant kristenlans Deskana|Away, would you please add social links to your pics on https://www.mediawiki.org/w/index.php?title=Draft:Wikimedia_Hackathon_2015/Mobile_apps ? i'll email vibha and elena...i think they're not on irc [20:39:34] mhurd also https://gerrit.wikimedia.org/r/#/c/200893/ needs to be rebased [20:39:51] mhurd unless you want me and corey to incorporate it into the follow-on patches we had planned [20:40:13] TIL dr0ptp4kt has a blog [20:40:16] * bgerstle subsribes [20:40:21] * bgerstle then, subscribes [20:40:22] MaxSem, done, osm1 works, sudo works [20:40:37] dr0ptp4kt: can't we link to our user page, and put the info there? [20:41:02] bgerstle: you could, your call. i'm thinking the more direct we can make it, the more compelling, but it's personal taste [20:41:08] i see [20:41:58] k, going afk for a bit [20:46:03] dr0ptp4kt: done [20:46:05] (w/ links) [20:48:13] bgerstle_afk: thx [20:48:57] mhurd: coreyfloyd bearND dbrant kristenlans Deskana|Away btw, double click in ve on that page is pretty nice [20:50:40] dr0ptp4kt: social links added [20:50:47] mhurd: thx [20:57:21] 6Mobile-Web, 10Analytics: Instrument ā€œtagsā€ and anonymous gather pages to track engagement with browse. - https://phabricator.wikimedia.org/T94744#1171999 (10JKatzWMF) [20:57:22] 10Gather, 6Mobile-Web, 3Mobile-Web-Sprint-44-R_________: Spike: figure out how to relate a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1172000 (10JKatzWMF) [20:57:44] (03PS4) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [20:58:10] 6Mobile-Web: Identify initial wikidata properties to be used for 'category' test - https://phabricator.wikimedia.org/T94714#1172003 (10KLans_WMF) [20:58:12] 6Mobile-Web: (2) Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1172002 (10KLans_WMF) [20:58:14] 6Mobile-Web: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1172004 (10kaldari) [20:58:32] (03CR) 10Mhurd: Added wikidata descriptions to saved pages entries. (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [20:59:16] 6Mobile-Web, 3Mobile-Web-Sprint-44-R_________: Spike: figure out the simplest possible way to apply tags to a large group of articles on en wikipedia - https://phabricator.wikimedia.org/T94755#1172014 (10KLans_WMF) [20:59:18] 6Mobile-Web: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1172013 (10KLans_WMF) [20:59:19] (03CR) 10Mhurd: "Replied to / addressed some comments. Working on remaining comments now..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [20:59:30] 6Mobile-Web: (2) Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1171366 (10KLans_WMF) [20:59:32] 6Mobile-Web: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1171871 (10KLans_WMF) [20:59:41] 6Mobile-Web: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1171871 (10KLans_WMF) [20:59:43] 6Mobile-Web: (3) Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1172018 (10KLans_WMF) [21:00:04] 6Mobile-Web, 7Epic: Continuously measure mobile site speed - https://phabricator.wikimedia.org/T94752#1172019 (10Krenair) [21:01:55] dr0ptp4kt: nice! [21:03:30] (03PS2) 10Mhurd: Only generate dSYM file with release config. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200893 [21:04:37] bgerstle_afk: coreyfloyd dr0ptp4kt ^ i rebased the dwarf patch [21:06:20] bgerstle_afk: coreyfloyd dr0ptp4kt the loading indicator patch is ready for another review pass as well https://gerrit.wikimedia.org/r/#/c/200251/ [21:07:08] (03PS8) 10Mhurd: Collapse image gallery description whitespace. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (https://phabricator.wikimedia.org/T93662) [21:09:17] (03CR) 10Mhurd: "Brian, can your comment be addressed in a follow on patch? I feel the "

" tag issue is much more of an edge case than the many extra spa" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (https://phabricator.wikimedia.org/T93662) (owner: 10Mhurd) [21:16:34] (03PS5) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [21:17:59] (03PS1) 10Fjalapeno: Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 [21:18:20] (03CR) 10Mhurd: "Brian, I added phab ticket to the commit message. For design, I sat with Vibha and she had me tweak the font sizes/colors/spacing so it's " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [21:18:56] (03CR) 10Fjalapeno: [C: 04-1] "@bgerstle can you help me solve this nokogiri system libraries issue with the make file?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 (owner: 10Fjalapeno) [21:19:13] (03CR) 10Mhurd: Added wikidata descriptions to saved pages entries. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [21:19:49] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: Fix Wikipedia logo on Share-a-fact images. - https://phabricator.wikimedia.org/T94760#1172076 (10MSyed) 3NEW a:3bearND [21:19:59] (03CR) 10Fjalapeno: [C: 031] Only generate dSYM file with release config. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200893 (owner: 10Mhurd) [21:22:29] (03CR) 10Fjalapeno: "sorryā€¦ one thingā€¦" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [21:22:54] (03CR) 10Fjalapeno: "bgerstle are you complete now or is this another interim patch set?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [21:24:29] mhurd: bgerstle dr0ptp4kt out for a bit -dog walk [21:24:36] coreyfloyd: k, just got back from mine :-P [21:25:23] (03CR) 10Mhurd: Hide loading spinner when using back-forward. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [21:25:27] coreyfloyd: ^ [21:25:43] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: Fix Wikipedia logo on Share-a-fact images. - https://phabricator.wikimedia.org/T94760#1172096 (10bearND) Thanks, Moiz. Yes, we can probably reuse the PNG image we use for the onboarding screen. Your comments when we talked earlier prompted me to chec... [21:29:38] (03CR) 10Fjalapeno: "reply" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [21:31:07] (03CR) 10Mhurd: Hide loading spinner when using back-forward. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [21:31:20] coreyfloyd: ^ amending [21:31:44] mhurd: looking at https://gerrit.wikimedia.org/r/#/c/200893. just trying to make sure everything is good with the crash reporting facilities with the change in place [21:32:28] dr0ptp4kt: should be. it's just for the debug config [21:32:29] (03CR) 10Bgerstle: "one comment not redundant to corey's response (show/hideAnimated)" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [21:32:59] (03CR) 10Mhurd: Hide loading spinner when using back-forward. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [21:33:10] bgerstle: gotcha. amending [21:33:37] (03CR) 10Bgerstle: [C: 031] "merrrrgeee iiiitttt" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200893 (owner: 10Mhurd) [21:34:34] mhurd bgerstle dr0ptp4kt ok - really taking my dog for a walk nowā€¦ before he bites my leg off [21:35:19] coreyfloyd: you have a spare leg. do you really need more than one? it seems so inefficient to have 2... [21:35:27] ;) [21:35:49] 10Gather: API: Allow sorting of a users collections by last modified - https://phabricator.wikimedia.org/T94762#1172105 (10Jdlrobson) 3NEW a:3Yurik [21:36:23] mhurd hangout about https://gerrit.wikimedia.org/r/#/c/200748/ ? [21:36:59] bgerstle: sure. ok if i finish this amendment first? [21:37:05] yeah, ofc [21:37:11] sorry, i'm jumping between patches [21:37:17] (03PS1) 10Jdlrobson: paginate the content overlay list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201354 (https://phabricator.wikimedia.org/T94523) [21:37:19] (03PS1) 10Jdlrobson: Up limit of collections listed in overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201355 [21:37:31] bgerstle: no worry [21:37:51] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather events are logged incorrectly against the Gather page in the main namespace rather than special page namespace - https://phabricator.wikimedia.org/T94730#1172130 (10Jdlrobson) a:3Jdlrobson [21:38:27] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1172135 (10Jdlrobson) @jhernandez since you know the most about the image handling feel free to take over ownership of this bug and look at https://gerrit.wikimedia.org/r/20... [21:39:11] 10Gather, 3Gather Sprint Enwiki: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1172145 (10Jdlrobson) a:3Jdlrobson [21:39:44] (03CR) 10jenkins-bot: [V: 04-1] Up limit of collections listed in overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201355 (owner: 10Jdlrobson) [21:39:45] (03CR) 10jenkins-bot: [V: 04-1] paginate the content overlay list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201354 (https://phabricator.wikimedia.org/T94523) (owner: 10Jdlrobson) [21:40:38] jdlrobson, have you had a chance to check https://gerrit.wikimedia.org/r/#/c/200798/ [21:41:31] 10Gather, 3Gather Sprint Enwiki: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1172157 (10Jdlrobson) @JKatzWMF @MSyed this seems to be the case already see http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/by/Jdlrobson/5 I can't cli... [21:44:17] (03CR) 10Dr0ptp4kt: [C: 032] Only generate dSYM file with release config. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200893 (owner: 10Mhurd) [21:44:26] dr0ptp4kt: woohoo! [21:46:21] 10Gather, 3Gather Sprint Enwiki: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1172208 (10MSyed) You can still use copy paste if you press and hold to select a link. Also, I would argue that copy and pasting the snippet is a very small use... [21:47:49] MaxSem, if you play with osm1, could you keep a record of every package you install, etc. We can even use the task for all note taking - https://phabricator.wikimedia.org/T92674 [21:55:18] yurik, /root/.bash_history ;) [21:55:38] MaxSem, it tends to get weird very fast ;) [21:55:51] grep apt-get [21:57:13] MaxSem, its not there :) [22:01:17] dr0ptp4kt: hey! re: gerrit permissions and whatnot, I see a bunch of mentions on mobile-tech. Anything I can help with? [22:02:14] kristenlans: joining us ? [22:04:03] (03PS1) 10Robmoen: WIP: Add to collection from search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 [22:07:05] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add to collection from search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 (owner: 10Robmoen) [22:07:37] (03CR) 10Fjalapeno: [C: 031] Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [22:07:42] (03PS1) 10Jdlrobson: Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) [22:08:07] YuviPanda: sorry, got distracted in gerrit [22:08:15] coreyfloyd: i'm amending the spinner business to simplify / clarify a bit more based on brian's comments [22:08:28] coreyfloyd: almost done... [22:08:30] mhurd: ok - well my +1 standsā€¦ [22:08:51] coreyfloyd: it might not once you see what i've done ;) [22:08:56] LOL [22:08:56] hehe [22:08:59] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200934 (https://phabricator.wikimedia.org/T94593) (owner: 10TheDJ) [22:09:27] YuviPanda: this https://phabricator.wikimedia.org/T94587 [22:10:07] dr0ptp4kt: ah, cool. I shall get to it shortly [22:10:18] (unless someone else does) [22:10:42] YuviPanda: thx [22:11:48] (03Abandoned) 10Jdlrobson: Delegate main menu generation to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197998 (https://phabricator.wikimedia.org/T93257) (owner: 10Jdlrobson) [22:11:59] 10Gather, 6Mobile-Web, 10WikiGrok: SkinMinerva should makes it own decisions about rendering the main menu - https://phabricator.wikimedia.org/T93257#1172297 (10Jdlrobson) [22:12:15] dr0ptp4kt: try now [22:12:26] (03CR) 10jenkins-bot: [V: 04-1] Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) (owner: 10Jdlrobson) [22:12:29] 6Mobile-Web, 10MobileFrontend-Feature-requests, 5Patch-For-Review: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1172298 (10Jdlrobson) a:5Florian>3Jdlrobson [22:12:41] 10MobileFrontend-Feature-requests: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1007848 (10Jdlrobson) [22:13:32] (03Merged) 10jenkins-bot: Limit hiding of sideboxes to sister sites [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200934 (https://phabricator.wikimedia.org/T94593) (owner: 10TheDJ) [22:13:45] 6Mobile-Web, 10Wikipedia-App-Android-App, 5Patch-For-Review: Sound clips generated by the {{listen}} template do not appear to be in the Android app - https://phabricator.wikimedia.org/T94593#1172303 (10Jdlrobson) 5Open>3Resolved [22:13:56] dr0ptp4kt: I gave you ownership of apps-ios, which should be inherited by the others. [22:14:15] (03CR) 10Jdlrobson: [C: 031] "Someone else should verify. Looks fine though." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200030 (https://phabricator.wikimedia.org/T93786) (owner: 10Bmansurov) [22:14:29] (03PS10) 10Jdlrobson: Hygiene: Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [22:15:13] 3Gather Sprint Enwiki, 6Mobile-Web, 5Patch-For-Review: MobileWebUIClickTracking main menu event logging can leak into desktop (EventLogging exception on Special:Gather in Vector) - https://phabricator.wikimedia.org/T94504#1172308 (10Jdlrobson) p:5Triage>3Normal Note this bug is pretty serious for #Gather... [22:15:20] (03PS2) 10Jdlrobson: Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) [22:15:24] YuviPanda: i see that, although it looks like i can't add members. i tried logging out and logging back in. [22:15:35] dr0ptp4kt: hmm, ok. I also added you to the android one :) [22:15:51] (03PS3) 10Jdlrobson: Hygiene: Align watchstars correctly in SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [22:15:59] (03CR) 10Jdlrobson: "ping? :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [22:16:03] 6Mobile-Web, 5Patch-For-Review: Watchstars not aligned in search - https://phabricator.wikimedia.org/T91178#1172319 (10Jdlrobson) ping? :) [22:17:35] YuviPanda: same on the android one. oh gerrit [22:18:16] (03CR) 10Jdlrobson: [C: 04-1] "Baha will you update your script?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [22:18:22] dr0ptp4kt: sigh. I can add people directly, if youā€™d like [22:19:05] (03CR) 10Bmansurov: "@Jdlrobson, yes, but later when I'm freer." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [22:19:07] (03CR) 10Jdlrobson: [C: 031] "Kaldari should take a look at this since he knows templates the best..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [22:19:14] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-54-iOS: Follow-up for fastlane & CI config - https://phabricator.wikimedia.org/T94769#1172339 (10BGerstle-WMF) [22:19:22] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: Don't ever show WikiGrok on disambig pages - https://phabricator.wikimedia.org/T91300#1172341 (10Jdlrobson) 5Open>3Resolved [22:19:51] (03CR) 10jenkins-bot: [V: 04-1] Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) (owner: 10Jdlrobson) [22:19:52] YuviPanda: You could add me to the Android repos [22:19:56] YuviPanda: sorry! okay, on the ios projects: mhurd, Fjalapeno, and bgerstle. looks like Fjalapeno may have gotten membership in apps-ios-wikipedia already [22:19:58] (03CR) 10Bmansurov: "@Jdlrobson, I think you and others should, because @Kaldari wrote the patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [22:20:07] dr0ptp4kt: yeah, I *just* did that [22:20:13] YuviPanda: oh, hah [22:20:18] YuviPanda: thx [22:20:19] dr0ptp4kt: added bgerstle [22:20:20] too [22:20:43] bearND: yeah, added [22:20:47] bgerstle: coreyfloyd (Fjalapeno) ^ thank the venerable YuviPanda [22:21:03] thanks YuviPanda ! [22:21:21] YuviPanda: Thanks! :) [22:21:25] :) [22:21:33] bgerstle: coreyfloyd can you check if you see the +2 option? [22:21:33] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1172347 (10Jdlrobson) [22:21:36] 10MobileFrontend-Feature-requests, 10Wikidata, 5Patch-For-Review: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1172345 (10Jdlrobson) 5Open>3Resolved Looks good to me. Thanks a bunch! :) [22:21:45] bgerstle: coreyfloyd, usually, you can use the "+2 code review" and then hit Publish & Submit. no need to touch the reviewed piece...unless gerrit tells you you need to do so [22:21:56] k [22:22:42] YuviPanda: yep - thanks [22:23:51] yw :) [22:24:01] dr0ptp4kt: do poke me in the future as well if you need any such help [22:24:15] * bgerstle pokes YuviPanda just for fun [22:24:18] YuviPanda: ok! [22:24:41] * YuviPanda mixes coke in bgerstleā€™s coffee [22:24:54] oh you monster [22:25:00] if i had coffee, that would've been atrocious [22:25:14] itā€™s also coke thatā€™s warm [22:25:31] * bgerstle reports YuviPanda for human rights violations [22:25:44] :D [22:25:48] although i'm not sure if warm would be worse than cold, TBH [22:25:59] only one way to find out... [22:26:03] it's like wondering if being punched or kicked in the same place is worse [22:26:09] bgerstle: mhurd dr0ptp4kt dbrant|bbl bearND kristenlans Deskana mholloway This is fantastic: https://com.google [22:26:18] hahaha [22:26:20] coreyfloyd: genius [22:26:34] LOL how'd they do it?! [22:26:40] wow [22:27:00] doesn't it just happen for free if you reverse your domain? [22:27:03] moc.elgoog [22:27:03] :P [22:27:08] :) [22:27:10] isn't there a css transform prop u can use to flip all? [22:27:13] yeah [22:27:17] and they own .google.. [22:27:59] oh the fancy new 100k tld's [22:28:08] ok and now to eat breakfastā€¦ a man can't live on coffee alone [22:28:23] coreyfloyd: breakfast! wat! [22:28:52] ah, I see coreyfloyd follows my diet plan... [22:29:34] i use caffeine and frustration to get me through the first half of the day [22:29:55] is it caffeine and rage for the next half? [22:30:23] no - alcohol and rage [22:30:44] haha [22:32:42] kaldari: you there? [22:33:44] mhurd: coreyfloyd bgerstle, so, shall i have gerrit bot auto add us four to changes? then of course as usual follow up on irc to request code reviews [22:33:51] 10MobileFrontend-Feature-requests, 10Wikidata, 5Patch-For-Review: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1130019 (10Jdlrobson) [22:33:59] dr0ptp4kt: sounds good [22:34:20] dr0ptp4kt: sho enuf [22:34:39] yes [22:34:43] plz [22:34:44] we are going to automate ourselves out of jobs! [22:34:50] woohoo! [22:35:10] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#831845 (10Jdlrobson) I've now setup https://phabricator.wikimedia.org/project/profile/1158/ so we can start s... [22:38:23] jdlrobson: hey [22:38:38] coreyfloyd: shhh you're not supposed to say that [22:38:49] WHAT HE REALLY MEANS IS THAT WE'LL HAVE TO MAINTAIN THE AUTOMATION [22:40:07] LOL [22:41:17] bgerstle: did you see last my comment on your patch? [22:41:59] mhurd: i think andy is there? [22:42:24] coreyfloyd: oh yeah, i meant to say yes, but you went for a dog walk [22:42:27] figured we'd sync when you got back [22:42:32] it should be "final" now [22:42:39] at least ,as a first iteration :-P [22:42:50] i need to hop off in a bit though [22:43:45] bgerstle: ok cool - are you going to do something with the delegate methods at another time then? [22:44:11] dr0ptp4kt: you around? [22:44:16] mhurd: i am [22:44:29] dr0ptp4kt: batcave? [22:44:32] mhurd: k [22:44:35] coreyfloyd: that should be in there [22:44:41] maybe i forgot to re-review [22:44:49] mhurd: you broke bgerstle's rule of using an animated gif [22:44:58] * bgerstle gasp [22:45:02] coreyfloyd: yeah it's in there [22:45:21] https://gerrit.wikimedia.org/r/#/c/200905/5/wikipedia/View+Controllers/Image+Gallery/WMFImageInfoController.h,cm [22:45:22] bgerstle: ok i must have been looking at an old patch /me facepalm [22:45:50] jdlrobson: greg says we can go ahead and deploy our config change, so Iā€™m going to do it now [22:46:03] kaldari: thanks [22:46:37] (03CR) 10Fjalapeno: [C: 031] "Looks good - left a comment for a possible future improvement." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [22:46:55] (03PS1) 10BearND: WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) [22:47:08] brb need to eat some lunch finally [22:47:25] mhurd: you still working here: https://gerrit.wikimedia.org/r/#/c/200280/ ? [22:47:42] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) (owner: 10BearND) [22:48:03] bgerstle: did you see my comment here: https://gerrit.wikimedia.org/r/#/c/201351/ [22:48:04] (03CR) 10Bgerstle: "NO IMPROVEMENTS FOR YOU" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [22:48:27] bgerstle: there had better be a soup natzi gif in there when i click that linkā€¦ [22:48:38] coreyfloyd: yeah i can take a look, was working on my follow-on thing [22:48:48] coreyfloyd: sorry i didn't take the time to add it.. [22:49:06] here's the whole scene https://www.youtube.com/watch?v=svSGKJFSl-8 [22:49:16] that'll do [22:49:24] forgiven [22:49:47] bgerstle: you want tests? $3! [22:50:05] LOL [22:50:43] jdlrobson: ready to test? [22:50:54] about to sync [22:52:47] whereā€™d everybody go? :) [22:53:55] MaxSem: is Jon there? [22:54:16] kaldari, don't see him. his laptop's here [22:56:29] kaldari: yup here [22:57:00] coolio [22:57:10] syncing now [22:57:31] jdlrobson: OK, please test on enwiki [22:57:43] kaldari: on it! [22:58:15] kaldari: testing the crap out of it no issues so far [22:58:22] security issue no longer there [22:58:50] 10Wikipedia-App-iOS-App: A page has a "hidden" leading image - https://phabricator.wikimedia.org/T94775#1172432 (10Etonkovidova) 3NEW [22:58:50] mhurd dr0ptp4kt coreyfloyd signing off for a while o/ [22:59:56] a few caching problems which i guess will be cleared in 5 [23:00:02] and nothing major [23:00:24] kaldari are the logs clean? [23:00:33] jdlrobson: yep, logs look clear [23:00:56] (03CR) 10Fjalapeno: "reeeeeeeeeeeeeply" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [23:01:09] bgerstle_afk: later [23:02:59] 10Wikipedia-App-iOS-App: The image "Text document with red question mark.svg" is used as a thumbnail img on Saved and Recent pages - https://phabricator.wikimedia.org/T94775#1172442 (10Etonkovidova) [23:03:17] kaldari: still clear? [23:03:37] yep, nothing from Gather in the error logs still [23:04:09] jdlrobson: howā€™s it looking on the UI side? [23:04:16] kaldari: looking great so far! [23:07:11] (03CR) 10BearND: [C: 032] Update credits to include new team members. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201236 (owner: 10Deskana) [23:07:22] Apple watch tear down! https://www.ifixit.com/Teardown/Apple+Watch+Teardown/38659 [23:07:47] kaldari: tested it like crazy. i think we are good [23:08:03] sweet [23:12:28] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-54-iOS: Create change log for CI builds - https://phabricator.wikimedia.org/T94423#1172451 (10Fjalapeno) [23:13:57] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-54-iOS: Follow-up for fastlane & CI config - https://phabricator.wikimedia.org/T94769#1172454 (10Fjalapeno) Hey hit me up in the morning so we can go over everything - maybe we can start by breaking this up into 2 patchesā€¦ xcode improvements fastlane improvements [23:17:13] 10Gather, 3Gather Sprint Enwiki: Removing articles with Gather api doesn't always remove them from Watchlist - https://phabricator.wikimedia.org/T94776#1172461 (10Jdlrobson) 3NEW [23:17:19] (03Merged) 10jenkins-bot: Update credits to include new team members. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201236 (owner: 10Deskana) [23:17:47] (03PS2) 10BearND: Fix possible crash(es) when highlighting text to share. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201195 (https://phabricator.wikimedia.org/T94311) (owner: 10Dbrant) [23:17:54] (03CR) 10BearND: [C: 032] Fix possible crash(es) when highlighting text to share. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201195 (https://phabricator.wikimedia.org/T94311) (owner: 10Dbrant) [23:23:21] (03Merged) 10jenkins-bot: Fix possible crash(es) when highlighting text to share. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201195 (https://phabricator.wikimedia.org/T94311) (owner: 10Dbrant) [23:23:21] 10Gather, 3Gather Sprint Enwiki: Collection icon not appearing in menu. - https://phabricator.wikimedia.org/T94777#1172471 (10MSyed) 3NEW a:3Jdlrobson [23:24:05] 10Gather, 3Gather Sprint Enwiki: Removing articles with Gather api doesn't always remove them from Watchlist - https://phabricator.wikimedia.org/T94776#1172480 (10Jdlrobson) Having same issue with another page. When I try to remove it via our api I get this response: {"batchcomplete":"","editlist":{"status":"n... [23:24:23] 10Gather, 3Gather Sprint Enwiki: Collection icon not appearing in menu. - https://phabricator.wikimedia.org/T94777#1172481 (10Jdlrobson) [23:24:26] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1172482 (10Jdlrobson) [23:24:38] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1146710 (10Jdlrobson) I think something might have happened with the ResourceLoader image module. [23:29:32] moushira: i wish we had thanks on collections... !! [23:29:34] https://en.m.wikipedia.org/wiki/Special:Gather/by/Moshirah/81 lol :) [23:29:41] :) [23:29:57] 10Gather, 3Gather Sprint Enwiki: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1172488 (10MSyed) Attached the mock here. The overlay appears, and once the user clicks on the menu item, a... [23:30:04] I wish we had dedication on lists jdlrobson :) [23:31:21] 10Gather, 10Wikimedia-Site-requests, 5Patch-For-Review: Add gather-hidelist as available right for global groups - https://phabricator.wikimedia.org/T94652#1172489 (10Jalexander) 5Open>3Resolved Done and verified [23:35:11] (03CR) 10MaxSem: "So, let's merge? :)" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [23:35:56] (03CR) 10BearND: [C: 032 V: 032] Handle more general errors when making network requests. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/201186 (https://phabricator.wikimedia.org/T94559) (owner: 10Dbrant) [23:36:47] 10Gather, 3Gather Sprint Enwiki: Removing articles with Gather api doesn't always remove them from Watchlist - https://phabricator.wikimedia.org/T94776#1172493 (10Jdlrobson) It seems to be related to redirects and renames... for example Snow Piercer is appearing in my Watchlist but the article is Snowpiercer n... [23:36:56] 10Gather, 3Gather Sprint Enwiki: Removing articles with redirects with Gather api doesn't always remove them from Watchlist - https://phabricator.wikimedia.org/T94776#1172494 (10Jdlrobson) [23:39:07] (03PS1) 10BearND: Bump version [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/201380 [23:39:09] (03PS1) 10BearND: Prepare for next development iteration [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/201381 [23:44:25] idea: Create a category or something for files on commons where you can label an image as OK for use as header images (I'd prefer opt-in, but I suspect you folks would want opt-out, i.e. category for images unsuitable as header images) and take that into consideration when displaying images in search results, android article headers, Special:Gather, etc. [23:45:22] wctaiwan: I think the way to fix inappropriate images is to basically allow onwiki overrides. [23:45:36] override how? [23:46:40] wctaiwan: *shrug*. template thatā€™s read into pageprop? definitely infinitely simpler than categories on commons [23:47:08] I think it should be associated with images.. easier to catch for people more likely to be working with media files. [23:47:10] etc. [23:49:05] wctaiwan: wikivoyage also wants something like this for their headerimage, for example. pick up from wikidata but override locally. [23:49:28] wctaiwan: plus, if you look at an article with, uh, ā€˜objectionable contentā€™, and are surprised to find objectionable content... [23:49:34] yes, wikivoyage is a perfect use case. [23:49:34] see also Personal Image Filter :P [23:49:51] YuviPanda: as I was saying, it's not only article view that picks up the images.. [23:50:01] I donā€™t think itā€™s that different [23:50:06] principle of least astonishment and all that [23:50:28] I donā€™t think itā€™s astonishing :P [23:50:40] but really, I think the problem is that the community doesnā€™t have the ability to override it... [23:51:04] and they should. if the community thinks a particular image is ā€˜inappropriateā€™ for a page image, they should put something else in... [23:51:08] yeah. It's whether to associate the override with articles or with the media. [23:51:17] right. I think it should be with the article [23:51:25] whatā€™s inappropriate in enwiki might not be in ruwiki [23:51:28] if the override is to reside with the article, there should be an option for "none" [23:51:48] and whatā€™s inapprorpiate in tawiki is *totally* probably appropriate in enwiki :P [23:55:27] (03CR) 10Bgerstle: "reply to the reply" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle)