[00:12:32] 10Gather: Convert collections into "wiki pages" - https://phabricator.wikimedia.org/T94782#1172594 (10Yurik) [00:35:13] bearND, common feedback seems to be that people can't load pages through the app [00:35:34] maybe they are getting exceptions when they try to connect? [00:36:32] (03CR) 10BearND: [C: 032 V: 032] "Already deployed to Maven repo" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/201380 (owner: 10BearND) [00:37:39] (03CR) 10BearND: [C: 032 V: 032] Prepare for next development iteration [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/201381 (owner: 10BearND) [00:38:00] Krenair: Ouch. Is thid from OTRS? [00:38:03] this [00:38:21] I've seen a few of them in android otrs feedback, yes [00:39:16] Krenair: Can you provide some details? I have not seen that [00:39:50] (03PS1) 10Bmansurov: Alpha: Improved search form for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) [00:42:18] Deskana: mind if I move some bugs from the triage column to the current sprint? [00:45:46] bearND: Absolutely, Mr Tech lead! [00:46:00] (03PS2) 10Bmansurov: Alpha: Improved search form for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) [00:46:04] Deskana: Thank you, Sir! [00:47:42] Deskana: I'll mark frequent crashes as High prio [00:48:08] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1172659 (10bearND) p:5Triage>3High [00:48:14] bearND, thanks! [00:48:21] (from: my inbox) [00:49:03] bearND, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8255783 [00:49:19] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8236132 [00:49:55] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8200040 is unrelated, but I think it would have a quick reply? [00:50:26] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8149149 [00:50:50] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8153383 [00:50:57] and probably more [00:56:16] kaldari, yt? [00:59:17] Krenair: thank you. I'll check them out shortly [01:02:53] (03PS1) 10BearND: Update Java MW API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201405 (https://phabricator.wikimedia.org/T94559) [01:04:19] 10Gather: Can create collection with user pages, but they do not show up - https://phabricator.wikimedia.org/T94786#1172672 (10JKatzWMF) 3NEW [01:09:38] Krenair: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8236132 is already fixed in latest release and I've responded [01:09:59] Krenair: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8200040 is probably easier for dbrant|bbl to answer [01:12:09] bmansurov: would it be possible in search.js to update the comment so that "their searches logged" is replaced with "metadata about interaction with the search form (absent search terms) is event logged" and then on the next line have a comment pointing out the URL for the search schema? sorry you're having to deal with double digits worth of revisions! [01:12:11] bearND: :) funnily I was using the android-maven repo to test and that’s why you got all that spam. sorry :) should work now [01:12:31] dr0ptp4kt: sure [01:12:57] bmansurov: does that latest patchset mean that for a user her search form interaction will still be observed "end-to-end"? [01:14:14] bmansurov: i suppose in theory because that javascript runs once per page and because the interaction occurs on a given page, that should be the case [01:14:52] dr0ptp4kt: what do you mean by "be observed "end-to-end""? [01:16:20] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: "IllegalStateException: No deadline" from somewhere beneath org.mediawiki.api.json.ApiResult.extractResponseHeaders - https://phabricator.wikimedia.org/T94559#1172709 (10bearND) @Dbrant Once my patch to update Java MW API is merge... [01:17:05] YuviPanda: lol, and I was thinking it was because I just uploaded a newer version of the Java MW API to it. [01:17:15] coincidence :D [01:18:44] dr0ptp4kt: does the following sound good? [01:18:50] // For 1 in a 1000 users the metadata about interaction [01:18:50] // with the search form (absent search terms) is event logged. [01:18:50] // See https://meta.wikimedia.org/wiki/Schema:Search [01:18:51] bmansurov: that is to say, the full event sequence for a given user would still be captured. that is, for example, going fully through through session-start + impression-results + click-result. it seems like https://gerrit.wikimedia.org/r/#/c/199179/11/resources/loggingSchema/search.js is suggesting that sendBeacon support (which is not part of ie or safari, and is not supported on any major mobile browser) will be sufficient on supporti [01:18:52] browsers [01:19:07] bmansurov: those comment lines make sense [01:20:14] dr0ptp4kt: so, on browsers where Beacon is not supported the last event, which is 'click-result' won't be recorded [01:20:42] dr0ptp4kt: from what I understood, that's not a problem, because analytics folks know which browsers support beacon [01:21:14] 10Gather: Can create collection with user pages, but they do not show up - https://phabricator.wikimedia.org/T94786#1172728 (10Jdlrobson) Yeh we need to think about how this works... [01:24:30] bmansurov: that's okay, but we should probably make it an explicit assumption that we're willing to sacrifice measurement of clickthroughs for everything but later versions of chrome and firefox desktop. okay if i get an email going on this topic? [01:24:53] dr0ptp4kt: sure [01:25:15] bmansurov: alright, will do, then gotta run... [01:25:25] dr0ptp4kt: cool [01:59:41] MaxSem: hello [01:59:43] 10Wikipedia-App-Android-App: User subpages are shown as "Read more" entries for the main page when opening the Android app - https://phabricator.wikimedia.org/T94794#1172771 (10gpaumier) 3NEW [05:13:00] (03CR) 10Fjalapeno: [C: 04-1] "Sorry" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [05:13:00] coreyfloyd lol no worry [05:13:00] oh your still on? [05:13:00] mhurd: you want to discus real quick? [05:13:02] (03CR) 10Mhurd: [C: 031] Fix the build - need to remove extraneous provision profiles to keep the build from getting confused [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201411 (owner: 10Fjalapeno) [05:13:33] 10Gather: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1172968 (10JKatzWMF) 3NEW [05:18:26] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1172979 (10JKatzWMF) 3NEW [05:50:46] (03CR) 10Florianschmidtwelzow: Hygiene: Align watchstars correctly in SearchOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [05:51:55] 6Mobile-Web, 5Patch-For-Review: Watchstars not aligned in search - https://phabricator.wikimedia.org/T91178#1173006 (10Florian) Sorry, forgot to save my comment in the change :( I'm a bit busy at the moment, i'll try to take a deeper look, but i don't want to block this task, if another one wants to work on i... [06:02:20] (03CR) 10MaxSem: [C: 04-1] "Why a variable? Because this message is always used in content language, customizing it by editing one page is much easier than by going a" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201409 (https://phabricator.wikimedia.org/T94446) (owner: 10Kaldari) [08:11:53] good morning! [08:42:29] 6Mobile-Web, 7Performance, 7Wikimedia-log-errors: ResourceLoader timestamp for mobile.usermodule changes constantly - https://phabricator.wikimedia.org/T90411#1173111 (10Krinkle) [08:42:56] 6Mobile-Web, 7Performance, 7Wikimedia-log-errors: ResourceLoader timestamp for mobile.usermodule changes constantly - https://phabricator.wikimedia.org/T90411#1058132 (10Krinkle) Fresh sample: ``` 2015-04-02 08:40:18 mw1258 enwiki: ResourceLoaderModule::getDefinitionMtime: New definition for module mobile.us... [09:19:54] morning [09:27:41] hi phuedx [09:27:45] we're live! [09:27:46] :) [09:30:02] joakino: !!! [09:30:02] woo [09:30:10] gratzzz!!! [09:30:24] phuedx: look at this beauty https://en.m.wikipedia.org/wiki/Special:Gather/by/Jdlrobson/23 [10:05:49] 10Wikipedia-App-Android-App, 10Wikimania-Hackathon-2015, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1173306 (10Pginer-WMF) As a broader approach, instead of allowing to switch the search results languages, we ca... [10:32:55] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1173339 (10Nemo_bis) > Wikivoyage uses the concept of pagebanners and horizontal table of contents on each of its page Wikivoyage in what l... [10:33:19] (03CR) 10Phuedx: [C: 04-1] "This funcitons and looks as expected. Nice work!" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) (owner: 10Bmansurov) [10:33:41] joakino: <3 [10:34:02] joakino: just verifying but resizing the browser hangs [10:34:07] on that collection [10:34:25] joakino: nope [10:34:29] can't reproduce -- ignore me [10:37:48] (03PS2) 10Phuedx: Filter out retired WikiGrok tags from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [10:38:04] (03CR) 10Phuedx: "Rebase to kick Jerkins." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [11:32:32] (03CR) 10Phuedx: [C: 04-1] "This kind of approach will definitely work. However, rather than running the query every time the OutputPageParserOutput hook fires (every" (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [11:37:24] 6Mobile-Web, 6operations, 3Mobile-Web-Sprint-44-R_________: Spike: figure out the simplest possible way to apply tags to a large group of articles on en wikipedia - https://phabricator.wikimedia.org/T94755#1173425 (10phuedx) a:3phuedx [11:41:59] actually -- before i start on that i'm going to make myself some lunch [11:43:51] 6Mobile-Web, 7Browser-Tests: update Mobile tests to run against local envs as well as beta - https://phabricator.wikimedia.org/T56349#1173438 (10zeljkofilipin) #mobile-web, @jdlrobson: is this still a problem, or can this task be resolved? [11:48:19] 10Gather: Convert collections into "wiki pages" - https://phabricator.wikimedia.org/T94782#1173459 (10He7d3r) Looks better with regards to conflicts with existing terminology, but the whole problem will be solved better by providing watchlist grouping (T22444), so that people can have a list of topics they favor... [11:48:45] 10Gather: Convert Gather collections into "wiki pages" - https://phabricator.wikimedia.org/T94782#1173461 (10He7d3r) [12:08:57] 6Mobile-Web, 6operations, 3Mobile-Web-Sprint-44-R_________: Spike: figure out the simplest possible way to apply tags to a large group of articles on en wikipedia - https://phabricator.wikimedia.org/T94755#1173496 (10phuedx) It's worth noting that the lists are static. [12:25:31] 6Mobile-Web, 6operations, 3Mobile-Web-Sprint-44-R_________: Spike: figure out the simplest possible way to apply tags to a large group of articles on en wikipedia - https://phabricator.wikimedia.org/T94755#1173531 (10phuedx) Depending on the size of the list, parsing a massive configuration variable on every... [12:41:11] 6Mobile-Web, 10Wikimedia-Site-requests, 3Roadmap, 7notice, 7user-notice: Set $wgMFEditorOptions['anonymousEditing'] = true by default for all wikis - https://phabricator.wikimedia.org/T93210#1173548 (10Glaisher) 5Open>3Resolved [13:13:29] (03CR) 10Krinkle: paginate the content overlay list of collections (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201354 (https://phabricator.wikimedia.org/T94523) (owner: 10Jdlrobson) [13:58:35] (03PS1) 10Mholloway: Reduce size of face detection image copies for performance [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) [14:01:01] (03PS2) 10Mholloway: Reduce size of face detection image copies for performance [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) [14:15:31] 6Mobile-Web, 6operations, 3Mobile-Web-Sprint-44-R_________: Spike: figure out the simplest possible way to apply tags to a large group of articles on en wikipedia - https://phabricator.wikimedia.org/T94755#1173699 (10phuedx) @kaldari: since the lists are static, are there any advantages to storing 'em in JSO... [14:42:10] (03CR) 10Dbrant: [C: 04-1] "See inline." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) (owner: 10Mholloway) [14:42:17] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1173780 (10Wrh2) >>! In T93106#1173339, @Nemo_bis wrote: > Wikivoyage in what language? What language editions have been contacted about thi... [14:46:34] (03CR) 10Mholloway: "See response inline." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) (owner: 10Mholloway) [14:57:21] fortunately today i've got a decent internet connect [14:57:40] virtualbox appears to have dropped a vhd again :/ [14:57:45] rebuilding super-quick [15:07:59] phuedx: \o [15:08:06] yo [15:08:31] hey joakino [15:08:44] got up early as my mum is off to yosemite. [15:08:54] Hacked up Gather for desktop :-) https://en.m.wikipedia.org/wiki/User:Jdlrobson/vector.js [15:17:15] bgerstle_afk: let me know when you are around want to push that patch through for fixing the build [15:19:16] phuedx: coreyfloyd phuedx i think i stepped up my coffee game [15:19:27] reusable metal chemex filter + super fine grind = more flavor [15:19:43] less sediment than before, but still some [15:20:43] 10Gather, 3Gather Sprint Enwiki: Collection icon not appearing in menu. - https://phabricator.wikimedia.org/T94777#1174155 (10Jdlrobson) a:5Jdlrobson>3Jhernandez [15:20:45] total brew time with the finer grind? [15:20:55] * thedj switched to Turkish/Greek coffee. Basically only sediment :) [15:21:03] damnit now i need coffee [15:22:15] thedj: i'm never sure whether or not i like turkish/greek coffee [15:22:25] on the other hand, i like the buzz i get from it :) [15:23:15] i love it. Its quick, it's old school, it's powerful. Also annoys my friends, which I think is funny :) [15:24:11] bgerstle: phuedx yeah consistent grind is super important. As important as the bean, if not more so. [15:24:26] i like vietnamese coffee surprisingly [15:24:30] i just have a thing for condensed milk [15:24:38] condensed milk on toast! [15:24:48] phuedx: gross [15:25:11] coreyfloyd: you can get away with an inconsistent grind with a filter though [15:25:16] within tolerances obvs [15:25:41] espresso demands a consistent grind [15:25:56] my flatmate, she used to make me indian kardamom thee and coffee... [15:26:06] ^ that sounds amazing [15:26:27] i always thought it was too sweet. but as a change, it was nice. [15:26:58] coreyfloyd: that's why i have this guy: http://amzn.com/B00LW8122Y [15:27:18] phuedx:it solves the sediment problem, but may still turn out bitter because the grinds are too different in size, and some will brew too long and others will brew too short. [15:28:19] i'm super picky about my coffee, but then at work I have accepted it will always be crap and still drink tons of whatever comes out of the machine. [15:28:28] perhaps that is why i got so picky at home :) [15:28:32] bgerstle: nice - yeah i grabbed this one when my last broke: http://www.amazon.com/Bodum-Bistro-Electric-Coffee-Grinder/dp/B0043095WW/ [15:29:01] coreyfloyd: SACRILEGE! YOU HAVE GONE AGAINST THE TENETS OF THE THEWIRECUTTER.COM [15:29:07] 10Gather, 3Gather Sprint Enwiki: Adding or removing items to my Gather list has no impact on last updated time - https://phabricator.wikimedia.org/T94843#1174165 (10Jdlrobson) 3NEW [15:29:25] lol - i disagreed with them on that one [15:30:00] which clearly state: "Should thou require a coffee grinder, go with the Baratza Encore. If thou find a used one, that should take preference. Those who worship False Coffee Grinders shall be stoned." [15:30:16] 10Gather: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1174184 (10Jdlrobson) [15:30:57] i'm a huge fan of the baratza vario 886 [15:31:11] does this too violate the tenets? [15:31:12] hi jdlrobson! [15:31:15] hi all [15:31:19] hey joakino [15:31:21] bgerstle: yeah, i looked at there article when I was replacing, but this is something I actually knew the tradeoffs of. This one performs much better when not grinding super fine or super course - which I don't do [15:31:27] jdlrobson: stop producing that much [15:32:07] hm, interesting [15:32:14] i would love a plastic shield to muffle the noise [15:32:18] bgerstle: phuedx: the truth is if you are grinding for french press or expresso, you really need to better class of grinder [15:32:23] 10Gather, 3Gather Sprint Enwiki, 7I18n: missing qqq documentation for Gather - https://phabricator.wikimedia.org/T94545#1174211 (10Jdlrobson) [15:32:47] joakino: \o [15:34:03] coreyfloyd: i agree in general, on the other hand i'm not made of money ;) [15:34:04] 👋😀 [15:34:19] jdlrobson: so happy to see gather deployed when I woke up [15:34:30] btw, collections view includes tiles for non-existing (deleted) articles... [15:34:40] notice this on my watchlist. [15:35:50] phuedx: you used to be when the £ was worth like $10 [15:35:57] inorite [15:36:25] dollars are still monopoly money to me [15:36:26] obvs [15:36:34] LOL [15:36:51] so not to offend anyone who reads this, but the 2nd tile in my collections view is a redlink to: "A faggot of epic proportions who gets perfectly good images deleted and should have his tiny balls mutilated." :( [15:37:10] i guess i'll open a ticket ? [15:37:21] ROFL [15:38:19] joakino: it's been in a while [15:38:28] thedj: :-( [15:38:35] thedj: yeh we're still trying to work out deletion handling [15:38:40] thedj: please open a ticket on gather? [15:38:42] latest idea is to push it to the end of the list [15:38:57] i'm preparing an announcement to wikitech [15:39:02] (for gather in general) [15:39:14] great [15:39:26] i'm hoping even if people don't agree with the idea they will get excited about lists as a first class citizen [15:39:51] joakino: also if you get a chance multiple watchlists first pass in https://gerrit.wikimedia.org/r/200181 [15:39:55] ^ css thedj :) [15:40:58] jdlrobson: i'll have a look in a bit [15:41:37] (03PS6) 10Jdlrobson: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 [15:45:01] 10Gather: Deleted entries show up in Gather lists - https://phabricator.wikimedia.org/T94847#1174260 (10TheDJ) 3NEW [15:46:06] perhaps someone can expand the watchlist api to return not only if an item is redlinked, but also if it has existed in the past. [15:46:12] just an idea [15:46:20] mhurd if you're around, would appreciate a final +2 on https://gerrit.wikimedia.org/r/#/c/200905/ [15:47:08] (03CR) 10Bgerstle: "should these be added to the .gitignore since they're downloaded every time fastlane runs?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201411 (owner: 10Fjalapeno) [15:47:34] (03CR) 10Bgerstle: Fix the build - need to remove extraneous provision profiles to keep the build from getting confused (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201411 (owner: 10Fjalapeno) [15:55:56] 10Gather, 3Gather Sprint Enwiki: Deleted entries show up in Gather lists - https://phabricator.wikimedia.org/T94847#1174311 (10Jdlrobson) [15:56:20] 10Gather, 3Gather Sprint Enwiki: Deleted entries show up in Gather lists - https://phabricator.wikimedia.org/T94847#1174260 (10Jdlrobson) Note: this is specific to the watchlist Jon Katz, we may want to have different behaviour for gather lists compared to watchlists. [15:59:22] 10Gather: API: Log when list gets hidden by an admin - https://phabricator.wikimedia.org/T93705#1174328 (10Jdlrobson) [16:00:50] 10Gather: A user visiting a list via the collections screen generates the event "view_list" - https://phabricator.wikimedia.org/T91018#1174332 (10Jdlrobson) You have this information in access logs. I'm not sure this needs to be done? [16:03:07] 10Gather: Creating EL Schema - https://phabricator.wikimedia.org/T90987#1174350 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Not clear nor actionable. Existence of this card is confusing. [16:03:12] (03PS2) 10Fjalapeno: Fix the build - need to remove extraneous provision profiles to keep the build from getting confused [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201411 [16:03:49] 10Gather, 5Patch-For-Review: Missing label text for Gather special pages - https://phabricator.wikimedia.org/T94362#1174355 (10Jdlrobson) 5Open>3Resolved [16:03:51] (03CR) 10Bgerstle: [C: 032] Fix the build - need to remove extraneous provision profiles to keep the build from getting confused [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201411 (owner: 10Fjalapeno) [16:04:18] 10Gather: Event logging for collection creation (placeholder) - https://phabricator.wikimedia.org/T92780#1174356 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Not clear nor actionable. Existence of this card is confusing. Let's reevaluate based on what data we are now collecting. [16:06:05] YuviPanda: ping [16:06:21] (03CR) 10Fjalapeno: [V: 032] Fix the build - need to remove extraneous provision profiles to keep the build from getting confused [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201411 (owner: 10Fjalapeno) [16:06:22] i +2'd something in gerrit, do i need to "Verify+2" so it gets merged? [16:06:55] coreyfloyd: just V+2'd it... [16:07:44] i don't see a "submit" button, but it says "ready to submit [16:09:17] (03CR) 10Bgerstle: [V: 032] Fix the build - need to remove extraneous provision profiles to keep the build from getting confused [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201411 (owner: 10Fjalapeno) [16:09:57] phuedx: hey what button do you need to hit in gerrit to merge the patch after +2ing? [16:10:20] hrrm [16:10:25] (03CR) 10Jdlrobson: "word of caution" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 (owner: 10Robmoen) [16:10:36] phuedx: specifically on this pathc: https://gerrit.wikimedia.org/r/#/c/201411/ [16:10:38] there should be a manual submit button -- c +2 v +2 -> sbmit [16:10:45] *submit [16:10:59] phuedx neither of us see the "submit" button [16:11:02] submit patch set 2 [16:11:02] we've both c/v +2'd [16:11:12] just after the review button [16:11:12] is jenkins not merging it? [16:11:14] (03CR) 10Jdlrobson: paginate the content overlay list of collections (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201354 (https://phabricator.wikimedia.org/T94523) (owner: 10Jdlrobson) [16:11:24] Krenair: apparently not? i don't think it ever was [16:11:32] could drop the jenkins review and your review -- recheck -- re c+2? [16:11:35] adam & monte had to merge stuff manually IIRC [16:11:39] sometimes jerkins needs a push [16:12:25] (03PS2) 10Jdlrobson: paginate the content overlay list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201354 (https://phabricator.wikimedia.org/T94523) [16:12:33] You guys don't see a "Publish and Submit" button? [16:12:41] (03PS2) 10Jdlrobson: Up limit of collections listed in overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201355 [16:13:08] bgerstle, ^ [16:13:40] phuedx [16:13:47] i do [16:13:51] use it [16:13:53] but i'm not apps :) [16:13:57] oh [16:14:10] coreyfloyd [16:15:14] Krenair no, neither of us do [16:15:24] weird [16:15:37] probably one of my random permissions lets me do that [16:15:54] you guys own this repo... [16:16:19] bgerstle, coreyfloyd this is at https://gerrit.wikimedia.org/r/#/c/201411/2,publish right? [16:17:13] Krenair: yeah, how'd you get to the publish page? [16:17:25] by pressing R [16:17:28] oh that's just publish comments [16:17:31] i.e. "reply' [16:17:38] which IIRC we've already done [16:17:47] but there's still no "publish patch set" button, just publish our comments [16:17:49] There's three buttons [16:17:54] right but you probably only pressed the publish comments button [16:17:55] i.e. all those radio buttons are already set to +2 for us [16:17:56] bgerstle: coreyfloyd: I think it's because you're using the "New Screen" view in your Gerrit settings [16:18:00] "Publish Comments", "Publish and Submit", "Cancel" [16:18:03] you are looking for the "Publish and Submit" button [16:18:10] yeah, not seeing it [16:18:23] What about "Submit Patch Set 2" on the PS? [16:18:36] https://i.imgur.com/dGGpD44.png [16:18:58] bgerstle: coreyfloyd: use the "Old screen" view [16:19:17] in https://gerrit.wikimedia.org/r/#/settings/preferences [16:19:25] actually, wait [16:19:28] in the new screen [16:19:36] you should have a blue "Submit" button [16:19:39] at https://gerrit.wikimedia.org/r/#/c/201411/ [16:20:02] in line with "Cherry Pick" and "Abandon" [16:20:46] Krenair: looks like Deskana merged it [16:20:55] oh [16:21:19] I was curious what would happen if I hit the "Publish and Submit" button [16:21:49] >_> [16:21:53] what did you expect to happen? [16:21:56] it merges the change [16:22:00] it's always merged the change [16:23:24] (03CR) 10BearND: Reduce size of face detection image copies for performance (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) (owner: 10Mholloway) [16:23:40] Krenair: Unlike you, I am not an engineer and therefore do not know all the things. :-) [16:23:42] dbrant: ^ this comment is more for you [16:24:08] I meant mine in the CR, not Deskana's lol [16:24:20] Haha [16:24:22] lol got it [16:25:43] hahahaha [16:26:02] IRC SERENDIPITY!!! [16:26:19] want me to merge it? i'll merge it! i'm a maverick merging machine! [16:26:35] Krenair: we only saw Cherry-Pick and Abandon buttons [16:26:39] next time we'll try the old UI [16:26:50] strange :/ [16:30:35] (03PS1) 10Phuedx: [WIP] [Alpha] Minor Special:MobileMenu improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201484 (https://phabricator.wikimedia.org/T94458) [16:31:05] (03CR) 10Phuedx: "WIP because we don't appear to have the light search icon." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201484 (https://phabricator.wikimedia.org/T94458) (owner: 10Phuedx) [16:41:27] How could I have missed StackEgg yesterday (http://meta.stackoverflow.com/questions/289032/whats-stackegg) ?! Arrr, too late. [16:41:48] ha! [16:42:33] 10Wikipedia-App-Android-App: article content not equal in landscap and normal mode in latest alpha 31.3.15 - https://phabricator.wikimedia.org/T94853#1174478 (10Matanya) 3NEW [16:46:12] bbs [16:47:46] joakino: hangout? [16:48:29] $george = new Child(); $bed = new ThomasTheTankEngineBed(); $bedPutterInner = new BedPutterInner(); $bedPutterInner->putIn( $george, $bed ); [16:48:39] (03CR) 10Dbrant: Reduce size of face detection image copies for performance (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) (owner: 10Mholloway) [16:50:27] phuedx: you wish it was that easy? [16:50:36] writing a few lines of code [16:51:55] (03CR) 10BearND: Reduce size of face detection image copies for performance (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) (owner: 10Mholloway) [16:52:43] 10Wikipedia-App-Android-App: article content not equal in landscap and normal mode in latest alpha 31.3.15 - https://phabricator.wikimedia.org/T94853#1174524 (10bearND) @Matanya Looks the same to me on my device. Would you add screenshots and specify the Android version you are using? Thanks! [17:00:16] phuedx, https://gerrit.wikimedia.org/r/#/c/197760/ ? :P [17:09:34] aharoni: \o [17:09:44] alohaloha [17:10:08] aharoni: https://twitter.com/rakugojon/status/583664017337552897 when you going to make me some interesting language related lists?! :D [17:10:10] jdlrobson: thoughts on the search overlay. Should we have 1 api request on close, or 1 for each search result toggle ? [17:10:29] aha [17:10:33] I should make some [17:10:37] in a meeting now. [17:10:42] i'll play with it later [17:11:16] aharoni: meetings are the perfect time to make them!! ;-) [17:11:25] rmoen: context? what's the api request for? [17:11:33] adding to collection [17:11:49] current searchOverlay has watchstar and it fires a request per click [17:12:37] rmoen: confused.. the collection add workflow should have nothing to do with the search overlay.. [17:12:52] (i mean you'll probably want to copy ideas from it) [17:14:21] you'll need to do an api request for search obviously within the editor overlay, but when you click the watchstar it will just add to the collection you are editing [17:14:23] jdlrobson: I will try to be more clear. The collection search overlay has page results in it. With the icon, slightly different than searchOverlay. [17:14:57] the icon being the tick? [17:15:01] Yes [17:15:16] Could we have a quick hangout ? [17:15:22] yeh that will be easier [17:17:11] Deskana [17:17:42] HANGOUUUUUUTS [17:18:37] kristenlans: Hangouts is fucked. [17:19:08] lol yep [17:24:48] sorry Krenair was deep in thought… but yeah what bgerstle was saying [17:28:14] (03PS3) 10Mholloway: Reduce size of face detection image copies for performance [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) [17:28:41] (03PS6) 10Bgerstle: paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) [17:28:47] mhurd ^ [17:29:14] mhurd if you could +1, i'll have coreyfloyd +2 & submit when he gets back from making coffee [17:29:57] 10Gather: API: Log when list gets hidden by an admin - https://phabricator.wikimedia.org/T93705#1174690 (10JKatzWMF) @jdlrobson, I think this might be different from the check user requirements. I think it should appear here (though for sensitive topics you would want to hide the content of the article): https:... [17:31:30] (03CR) 10Mholloway: "see inline..." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) (owner: 10Mholloway) [17:35:04] mhurd: dr0ptp4kt coreyfloyd FYI i'm adding my @wikimedia.org apple ID as a developer because i'm having issues with having different IDs for the dev portal and iTC [17:35:16] also i shouldn't really need my personal apple ID for WMF stuff [17:35:41] (03PS3) 10Bmansurov: Alpha: Improved search form for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) [17:35:52] (03CR) 10Bmansurov: Alpha: Improved search form for non-js users (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) (owner: 10Bmansurov) [17:35:59] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1174715 (10Jdlrobson) [17:36:03] bgerstle: cool. the testflight invitation email link should be opened up on the ios 8 device where you have tf installed. you may want to uninstall tf from that ios 8 device [17:36:08] before starting this process [17:36:21] dr0ptp4kt: what process? [17:36:55] (03CR) 10Mhurd: [C: 031] paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [17:37:05] mhurd: bgerstle back [17:37:18] coreyfloyd: try to +2 & merge ^ [17:37:18] bgerstle: the process of using your @wikimedia.org email address. nothing more [17:37:39] bgerstle: lemme know if merge of that thing coreyfloyd mentions works [17:37:58] (03CR) 10Fjalapeno: [C: 032] paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [17:38:15] (03CR) 10Bmansurov: "Thanks for the review. Your suggestion seems more reasonable. I wonder what @kaldari has to say." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [17:38:25] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1174720 (10JKatzWMF) user clicks create on this screen: {F108178} and gets to these screens (in order): {F108176} Existing toast is moved to the top of the screen? @msyed chime in please. [17:38:42] dr0ptp4kt: ok I CR+2 but now there is no other button… [17:38:47] Krenair: mhurd ^ [17:38:52] dr0ptp4kt: let me switch to the old UI [17:39:01] coreyfloyd: just 'publish', not 'publish and submit', right? [17:39:06] bgerstle: ? [17:39:11] bgerstle: ^^ you [17:39:16] dr0ptp4kt: ditto [17:39:21] wat [17:39:23] lol [17:39:31] YuviPanda: you around? [17:39:34] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1174723 (10JKatzWMF) @mysed is there an interim page that congratulates them on setting up collection, link to the collection? instead of this? [17:39:58] (03CR) 10Fjalapeno: [V: 032] paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [17:39:59] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1174725 (10Jdlrobson) Should this be an optional step? Taking up the whole screen may be a little jarring if unexpected. Should it say "congratulations! do you want to add more pages to it?" [17:40:33] dr0ptp4kt: i dont see anything about publish [17:40:56] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1174727 (10Jdlrobson) a:3MSyed [17:41:03] dr0ptp4kt: do I need to do the "Verified +2" as well? [17:41:11] coreyfloyd: try that [17:41:20] coreyfloyd: normally, you shouldn't need to, though [17:41:37] dr0ptp4kt: i did just now ^ [17:41:40] coreyfloyd: (except when gerrit gripes that you have to, which has some determinism...that i'm unable to ascertain) [17:42:36] dr0ptp4kt: yeah looks like it is permission problem… tried both UIs and publish is never an option [17:42:59] mhurd: you wanna do the honors on https://gerrit.wikimedia.org/r/#/c/200905/ ? [17:43:06] dr0ptp4kt: sure [17:43:18] mhurd: for some definition of 'wanna' [17:43:32] (03CR) 10Mhurd: [C: 032] paginate image info requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200905 (https://phabricator.wikimedia.org/T91124) (owner: 10Bgerstle) [17:43:49] mhurd so you ended up merging? [17:43:53] how come coreyfloyd couldn't merge? [17:44:01] bgerstle: it won't let him [17:44:06] * bgerstle sighs [17:44:07] bgerstle: oops was i not supposed to? [17:44:09] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1174743 (10JKatzWMF) @mysed: Another concern--this is a full overlay and should we really hide the article without warning. [17:44:33] mhurd i mentioned in standup that coreyfloyd and i aren't able to merge, and we're trying to figure out why [17:44:37] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1174744 (10JKatzWMF) @msyed : Another concern--this is a full overlay and should we really hide the article without warning. [17:44:53] bgerstle: i pinged YuviPanda here on irc. he'll get back to us when he's available cc coreyfloyd [17:45:04] mhurd: you were okay to merge [17:45:32] ok [17:45:37] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1174758 (10Jdlrobson) [17:45:38] bgerstle: is https://gerrit.wikimedia.org/r/#/c/200748/ good to go? [17:45:51] bgerstle: that is, want to provide feedback on the question on that one? [17:46:01] bgerstle: for some definition of "want to" [17:46:40] dr0ptp4kt: i was going to chat w/ mhurd about it yesterday but we never got together [17:46:43] 10Gather: Refine what success looks like - https://phabricator.wikimedia.org/T94241#1174761 (10Jdlrobson) [17:46:54] dr0ptp4kt: the TL;DR; is, it fixes the problem in one case, but not another that's specified in the ticket [17:47:18] we can add another workaround for

elements either to this patch for a follow-on, but IMO we should look into use attributed strings for a more comprehensive solution on iOS 7+ [17:47:26] (not exactly a TL;DR; but there you have it) [17:47:33] (03CR) 10MaxSem: [C: 04-1] Filter out retired WikiGrok tags from WikiGrok pages (034 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [17:47:39] bgerstle: dr0ptp4kt anyone want to +1 this? [17:47:40] https://gerrit.wikimedia.org/r/#/c/200748/ [17:47:53] coreyfloyd: that's what we're talking about [17:47:58] GET YOUR HEAD IN THE GAME, MAN [17:48:12] not enough coffe yet [17:48:40] 10Gather: Refine what success looks like - https://phabricator.wikimedia.org/T94241#1158068 (10Jdlrobson) [17:48:50] kaldari, phuedx i can haaaz merge? [17:49:13] 10Gather: Refine what success looks like - https://phabricator.wikimedia.org/T94241#1174771 (10Jdlrobson) a:3JKatzWMF [17:49:38] mhurd: ^^^^^^^ https://gerrit.wikimedia.org/r/#/c/200748/ feedback from bgerstle. are you wanting badly to do the follow-on patch or to do the workaround in that patch? [17:50:07] MaxSem: there’s still one comment from phuedx in the current patch [17:50:10] dr0ptp4kt: just on way to office from new place [17:50:20] dr0ptp4kt: IMO it's up to prod/QA if this behavior meets acceptance criteria. the code is OK [17:50:35] oops [17:50:38] 1 sec [17:50:52] (03Abandoned) 10Fjalapeno: Fix Bug T93662 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/199324 (owner: 10Fjalapeno) [17:50:55] bgerstle: okay, you wanna +2 it? [17:51:08] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Description text is not normalized in galleries. - https://phabricator.wikimedia.org/T93662#1174783 (10Fjalapeno) a:5Fjalapeno>3Mhurd [17:52:00] https://en.wikipedia.org/wiki/List_of_lists_of_lists [17:52:08] bgerstle: for some definition of 'wanna' [17:52:27] (03PS12) 10MaxSem: Submission to Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 [17:52:41] kaldari, ^ [17:53:10] dr0ptp4kt: sure [17:53:19] (03CR) 10Bgerstle: [C: 032] Collapse image gallery description whitespace. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (https://phabricator.wikimedia.org/T93662) (owner: 10Mhurd) [17:53:26] bgerstle: okay, to the ceremony. [17:53:28] k, now i'm at the "i can't submit" point [17:53:48] (03PS9) 10Dr0ptp4kt: Collapse image gallery description whitespace. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (https://phabricator.wikimedia.org/T93662) (owner: 10Mhurd) [17:54:23] 10Gather: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1174795 (10Jdlrobson) [17:54:29] 10Gather: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1172968 (10Jdlrobson) [17:54:45] (03CR) 10Kaldari: [C: 032] Submission to Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [17:54:52] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Description text is not normalized in galleries. - https://phabricator.wikimedia.org/T93662#1142843 (10Fjalapeno) [17:54:58] wee:) [17:55:13] * MaxSem proceeds to check everything over again [17:56:43] (03Merged) 10jenkins-bot: Submission to Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/197760 (owner: 10MaxSem) [18:01:13] (03Abandoned) 10Kaldari: Making the WikiGrok FAQ page configurable [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201409 (https://phabricator.wikimedia.org/T94446) (owner: 10Kaldari) [18:01:37] 10Gather: (8) Flag a collection - https://phabricator.wikimedia.org/T90988#1174821 (10Jdlrobson) Open question: Where do we send flagged collections to? [18:02:22] 10Gather: (8) Flag a collection - https://phabricator.wikimedia.org/T90988#1174825 (10JKatzWMF) [18:02:27] Deskana retro? [18:02:53] kristenlans: Yep! [18:03:25] (03PS2) 10MaxSem: Adding some comments to Aggregator::aggregate() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201064 (owner: 10Kaldari) [18:05:46] 10Gather: Flag a collection - https://phabricator.wikimedia.org/T90988#1174837 (10Jdlrobson) [18:06:00] 10Gather: Flag a collection - https://phabricator.wikimedia.org/T90988#1072304 (10Jdlrobson) Can we use Wikigrok in some way @kaldari [18:07:07] 10Gather: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1174843 (10Jdlrobson) [18:07:08] 10Gather: Record the user who hid a list - https://phabricator.wikimedia.org/T94260#1174841 (10Jdlrobson) [18:08:44] YuviPanda: double checking that your about today [18:09:17] 10Gather: Analytics to see number of bad lists created - https://phabricator.wikimedia.org/T94240#1174849 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson We will just use the API to manually obtain this. [18:11:33] yo [18:11:41] phuedx: yo yo [18:12:08] woo -- aggregator went down! [18:12:17] by that i mean: it got merged [18:12:42] phuedx: be careful about using the phrase ‘went down’ :) [18:13:08] tfinc: yup am [18:13:15] phuedx: so I have this crazy thought related to https://phabricator.wikimedia.org/T94755 [18:13:23] YuviPanda: excellent. Stanford students should be here at noon [18:13:39] tfinc: yup. I should be there before that. At Bart now [18:13:40] YuviPanda: is Francis about today? [18:13:44] kaldari: store the lists as tattoos on your arms? [18:13:58] phuedx: actually it’s too crazy, nevermind [18:14:09] Let me check [18:15:32] 10Gather, 3Gather Sprint Enwiki: No way to moderate a certain collection from the collection itself - https://phabricator.wikimedia.org/T94228#1174869 (10Jdlrobson) a:3MSyed [18:15:38] kaldari: i'd be happy with a serialized array (map in this case) or redis [18:16:02] i guess the latter requires a script though [18:16:23] phuedx: I was thinking if we put the articles in a JSON page in MediaWiki namespace, we could just build the entire tag interface in MediaWiki:Minerva.js, but this would almost certainly cause a flash of unstyled content if we’re loading the tags at the top of the page :( [18:16:33] :( [18:16:43] that'd actually be neat [18:16:50] since you can’t control when Minerva.js is loaded [18:16:52] MaxSem: jerkins needs kicking: https://gerrit.wikimedia.org/r/#/c/201064/ [18:17:32] kicked [18:17:45] where art thou, grrrit-wm? [18:24:28] (03CR) 10Bmansurov: Hygiene: Align watchstars correctly in SearchOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [18:24:58] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) (owner: 10Jdlrobson) [18:25:14] 10Gather: Data to fuel heuristics for flagging - https://phabricator.wikimedia.org/T94871#1174892 (10Jdlrobson) 3NEW a:3MSyed [18:25:27] phuedx: er sorry, I meant MediaWiki:Mobile.js. Minerva.js is just for per-user customization (User:Kaldari/Minerva.js). It’s confusing I know :P [18:25:41] 10Gather: Data to fuel heuristics for flagging - https://phabricator.wikimedia.org/T94871#1174901 (10Jdlrobson) [18:27:22] wtf yahoo https://smallbusiness.yahoo.com/geocities [18:27:28] 10Gather: Feature flag to turn off - https://phabricator.wikimedia.org/T94232#1174923 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson I don't think we need this on second thoughts. AbuseFilter can be used to block creation of all collections. This should be enough to deal with troublesome collections. [18:27:39] 10Gather, 3Gather Sprint Enwiki: No way to moderate a certain collection from the collection itself - https://phabricator.wikimedia.org/T94228#1174928 (10Jdlrobson) [18:30:12] 10Gather: Reader analytics on collections pages and user collections page - https://phabricator.wikimedia.org/T94245#1174942 (10Jdlrobson) @nuria and @JKatzWMF are chatting about Hive to do this. [18:30:43] 10Gather: Analytics to see measure number of lists created - https://phabricator.wikimedia.org/T94237#1174945 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson We can use API to manually work this out. [18:30:48] (03CR) 10Jhernandez: [C: 032] Fix PHP error for non-initialized variable [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201243 (https://phabricator.wikimedia.org/T94722) (owner: 10Jdlrobson) [18:30:54] 3Gather Sprint Enwiki: PM Spike: talk to wikigrok team about using backend for flag heuristics - https://phabricator.wikimedia.org/T94875#1174948 (10JKatzWMF) 3NEW [18:31:50] 10Gather: Flagged collection appears in public log - https://phabricator.wikimedia.org/T91000#1174956 (10Jdlrobson) [18:33:34] (03CR) 10Jhernandez: [C: 032] Correct the title used in Special:CheckUser for abuse filter rule matches [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201249 (https://phabricator.wikimedia.org/T94730) (owner: 10Jdlrobson) [18:33:36] (03PS1) 10Aude: Fix overriding of vector styles in resources definition [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201501 (https://phabricator.wikimedia.org/T93050) [18:34:17] (03CR) 10jenkins-bot: [V: 04-1] Fix overriding of vector styles in resources definition [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201501 (https://phabricator.wikimedia.org/T93050) (owner: 10Aude) [18:34:38] gha [18:36:45] aude: eek sorry about that [18:36:50] i'll help you get that merged and swatted asap [18:37:04] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201501 (https://phabricator.wikimedia.org/T93050) (owner: 10Aude) [18:37:23] what difference a + sign makes.. :-S [18:37:39] and quiddity i'm sorry i might have been wrong [18:37:53] hmm? [18:38:09] quiddity: that bug you pointed me at which you thought might be gather - could possibly be same as https://phabricator.wikimedia.org/T93050 [18:38:25] aude: why is jenkins upset? [18:38:37] fixing [18:38:51] aude: ahh Fatal error: Invalid operand type was used: cannot perform this operation with arrays [18:39:15] (03Merged) 10jenkins-bot: Fix PHP error for non-initialized variable [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201243 (https://phabricator.wikimedia.org/T94722) (owner: 10Jdlrobson) [18:39:24] ahh, ok. That was https://phabricator.wikimedia.org/T94518 in case it helps to have handy. :) [18:39:28] (03Merged) 10jenkins-bot: Correct the title used in Special:CheckUser for abuse filter rule matches [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201249 (https://phabricator.wikimedia.org/T94730) (owner: 10Jdlrobson) [18:40:33] aude: i'll add to deployment swat window [18:41:20] ok [18:41:26] just taking care to get it right [18:41:29] jdlrobson3: the difference of plus equals: http://php.net/manual/de/language.operators.array.php :) [18:41:31] 6Mobile-Web, 6operations, 3Mobile-Web-Sprint-44-R_________: Spike: figure out the simplest possible way to apply tags to a large group of articles on en wikipedia - https://phabricator.wikimedia.org/T94755#1175003 (10kaldari) I was thinking about the left-field possibility (does that translate into British E... [18:41:44] phuedx: replied at https://phabricator.wikimedia.org/T94755 [18:41:50] FlorianSW: :) [18:43:36] aude: well done working out the connection :) [18:43:59] 10Gather, 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175009 (10Jdlrobson) [18:45:00] jdlrobson3: what does enwiki + beta have in common? :) [18:45:16] aude: detective! :) [18:45:38] 10Gather, 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175019 (10Jdlrobson) a:3Jdlrobson I've put this on the swat deploy calendar: https://wi... [18:45:49] (03CR) 10Bartosz Dziewoński: "Ugh, you're not supposed to use $wgResourceModuleSkinStyles in extensions… it's for skins. I'm not sure if this will even work, adding $wg" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201501 (https://phabricator.wikimedia.org/T93050) (owner: 10Aude) [18:45:52] dr0ptp4kt: how are we doing instrumenting our search analytics changes? [18:45:53] aude: new patch posted yet? [18:46:33] 10Gather, 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175029 (10matmarex) Ugh, you're not supposed to use $wgResourceModuleSkinStyles in extens... [18:48:04] jdlrobson3, should I merge my bug into that one? [18:48:24] 10Gather, 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175039 (10Jdlrobson) Yay hooks and globals! ;-) Sounds like another task to prevent exten... [18:48:37] quiddity: not yet let's see if the fix makes it go away firs [18:48:41] (03CR) 10TheDJ: "Most likely you will want to use skinStyles option:" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201501 (https://phabricator.wikimedia.org/T93050) (owner: 10Aude) [18:48:46] kk, I'll leave to you. :) [18:49:01] jdlrobson3: i'm lookign at doing like https://github.com/wmde/WikibaseClient/blob/46d863609dcb32b41b6e36363448349b5397bcfa/resources/Resources.php#L22 [18:49:16] instead of wgResourceModuleSkinStyles [18:49:19] 10Gather, 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175041 (10matmarex) MobileFrontend is probably within its rights to do it, since it has t... [18:49:34] want to make sure it works right [18:51:01] 10Gather, 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175044 (10Jdlrobson) ... yeh but we should at least have some kind of wrapper for this. I... [18:51:46] 10Gather, 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175046 (10matmarex) [18:53:05] think it works [18:53:11] (03PS2) 10Aude: Fix overriding of vector styles in resources definition [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201501 (https://phabricator.wikimedia.org/T93050) [18:53:25] that approach has worked for us, for skin specific styles [18:53:36] please check [18:53:55] (03CR) 10Jhernandez: [C: 032] paginate the content overlay list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201354 (https://phabricator.wikimedia.org/T94523) (owner: 10Jdlrobson) [18:55:17] 10Gather, 10Vector, 5Patch-For-Review, 7Regression: Some styles specific to Vector skin missing (Special:Preferences, mediawiki.notification bubbles, jQuery UI) - https://phabricator.wikimedia.org/T93050#1175063 (10matmarex) [18:55:57] (03Merged) 10jenkins-bot: paginate the content overlay list of collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201354 (https://phabricator.wikimedia.org/T94523) (owner: 10Jdlrobson) [18:56:51] wtf browser [18:57:56] 10Gather, 10Vector, 5Patch-For-Review, 7Regression: Some styles specific to Vector skin missing (Special:Preferences, mediawiki.notification bubbles, jQuery UI) - https://phabricator.wikimedia.org/T93050#1175069 (10aude) [18:58:48] 6Mobile-Web: Page save spinner misplaced in beta - https://phabricator.wikimedia.org/T94881#1175071 (10kaldari) 3NEW [18:59:30] 10Gather, 10Vector, 5Patch-For-Review, 7Regression: Some styles specific to Vector skin missing (Special:Preferences, mediawiki.notification bubbles, jQuery UI) - https://phabricator.wikimedia.org/T93050#1175078 (10matmarex) Well, stuff breaks when you clobber globals, news at eleven. It's a chicken-and-eg... [18:59:40] (03CR) 10Jdlrobson: [C: 032] Fix overriding of vector styles in resources definition [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201501 (https://phabricator.wikimedia.org/T93050) (owner: 10Aude) [19:00:13] (03PS1) 10Jdlrobson: Fix overriding of vector styles in resources definition [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201503 (https://phabricator.wikimedia.org/T93050) [19:00:38] thanks an aude! [19:00:48] sure :) [19:01:00] (03CR) 10Bartosz Dziewoński: [C: 031] Fix overriding of vector styles in resources definition [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201501 (https://phabricator.wikimedia.org/T93050) (owner: 10Aude) [19:01:02] i'll make sure it gets swatted at 4 [19:01:09] thanks [19:02:07] (03Merged) 10jenkins-bot: Fix overriding of vector styles in resources definition [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201501 (https://phabricator.wikimedia.org/T93050) (owner: 10Aude) [19:04:42] scrummasterflash: that is just fantastic [19:05:32] tfinc: https://gerrit.wikimedia.org/r/#/c/199178/ and https://gerrit.wikimedia.org/r/#/c/199179/ are moving along, due to bmansurov doing thorough patchset updates. there was one potential issue around data on non-Chrome/non-Firefox yesterday, and i raised that on an email thread. nuria helped to fill in details; dario and Deskana can weigh in if the current state of the art is ok [19:05:57] tfinc: i think it's on track, that is to say [19:33:16] dbrant: what do you say if I merged https://gerrit.wikimedia.org/r/#/c/197346/ and your follow-up patch? [19:33:36] dbrant: should that be included inthe next release? [19:33:58] bearND: i would say "full speed ahead"! [19:34:17] bearND: and absolutely, it should (barring any serious issues). [19:36:06] (03PS4) 10Mholloway: Reduce size of face detection image copies for performance [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) [19:36:55] dbrant: Alright. Let's try to wrap some more outstanding crashes and get a new beta out. I want us to publish a bug fix release tomorrow, and have that pushed to production sometime next week. [19:37:13] 10Wikipedia-App-Android-App: article content not equal in landscap and normal mode in latest alpha 31.3.15 - https://phabricator.wikimedia.org/T94853#1175236 (10Matanya) Android 4.4.4. please see attached screen shots. {F108217} {F108218} [19:37:18] 10Wikipedia-App-iOS-App: Cannot tweet, even though I am logged into twitter - https://phabricator.wikimedia.org/T94888#1175237 (10Vibhabamba) 3NEW a:3dr0ptp4kt [19:37:19] bearND: that would be great [19:37:38] 10Wikipedia-App-iOS-App: Cannot tweet, even though I am logged into twitter - https://phabricator.wikimedia.org/T94888#1175245 (10Vibhabamba) {F108221} [19:39:19] bearND: do you need help to tell the diff between the screenshots i posted ? [19:40:13] matanya: no, I see it. Thank you. Before I thought you were referring to lead images [19:40:44] MaxSem: who was mainly responsible for developing the "pageterms" api? [19:41:20] I didn't understand Deskana's comment, but it was working fine in prev versions [19:41:40] and works well for most articles [19:42:00] matanya: his comment was also due to the fact that we thought you were referring to lead images, I think [19:42:40] hmm, i said "article content" in the subject :) [19:42:55] matanya: this is more that text is moved around or missing. Sorry I don't read Hebrew very well [19:43:21] the first paragraph in missing [19:44:04] see source: https://he.wikipedia.org/w/index.php?title=%D7%A4%D7%AA%D7%99%D7%97%D7%94_%D7%A8%D7%95%D7%A1%D7%99%D7%AA&action=edit [19:45:49] i'm out for today [19:45:53] bye bye! [19:45:53] matanya: didn't it just move around? In portrait mode I believe it has the same paragraph under the chess board picture [19:46:18] matanya: in landscape mode that's the first paragraph [19:46:50] 10Gather, 3Gather Sprint Enwiki, 10Wikimedia-Extension-setup, 5Patch-For-Review, and 3 others: Enable Extension:Gather (article lists) on English Wikipedia Mobile Beta - https://phabricator.wikimedia.org/T91341#1175254 (10Jdlrobson) 5Open>3Resolved This is now enabled again as of yesterday: https://en.... [19:46:51] yes, the order is flipped [19:47:28] the bold text should be the first paragraph [19:48:32] the way it is no makes the paragraph totally not understandable [19:48:37] *now [19:49:07] matanya: do you remember the last version when it was still working? [19:49:31] i can roll back and check, please hold [19:49:35] (03PS3) 10Jdlrobson: Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) [19:49:41] MaxSem: about your comment at https://gerrit.wikimedia.org/r/#/c/201071/2/WikiGrok.php the card says that we need a configurable variable [19:50:23] matanya: I also see the same behavior in the production app we released (code from 3/23) [19:52:05] on prod 2.0-r-2014-10-14 it is correct [19:52:56] (03CR) 10jenkins-bot: [V: 04-1] Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) (owner: 10Jdlrobson) [19:55:35] matanya: bearND: it may have something to do with CSS (mobile web styles) [19:55:52] matanya: how does that article look in your mobile browser? (in portrait and landscape) [19:56:06] dbrant: looking [19:56:55] dbrant: looks ok in both modes [19:57:06] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1175279 (10Jdlrobson) @Wrh2 thanks for sharing the links and @Nemo_bis thanks for the poke, super keen to set @sumit up for success! [19:57:14] curious [19:57:48] dbrant: sounds more like the JS code that shifts the first paragraph up is behaving differently in this case on landscape [19:57:58] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice: Next production release for iOS Wikipedia app - https://phabricator.wikimedia.org/T86692#1175282 (10Eloquence) @Deskana, can we project a revised release date yet? [19:59:54] dbrant: but it's unclear how orientation would have an effect on this [20:00:31] quite unclear [20:01:35] dbrant: maybe this part: if (p.offsetHeight < minHeight) [20:01:42] in transforms.js [20:01:58] bearND: dbrant doing a lion in the desert: [20:02:15] 2014-12-27 is ok [20:02:16] ? [20:02:24] moving next [20:02:43] kaldari: thanks for the reply [20:02:50] not sure what else to do with that spike [20:03:14] 6Mobile-Web, 7Performance, 7Wikimedia-log-errors: ResourceLoader timestamp for mobile.usermodule changes constantly - https://phabricator.wikimedia.org/T90411#1175303 (10Jdlrobson) Any ideas what is going on here @krinkle I took another look and it's basically doing the same as the ResourceLoaderWikiModule [... [20:03:23] jdlrobson3: somehow you broke the deployment schedule: https://wikitech.wikimedia.org/wiki/Deployments [20:03:37] 2015-01-30 is ok as well [20:04:59] 2015-03-02 is broken [20:05:55] 6Mobile-Web, 7Browser-Tests: update Mobile tests to run against local envs as well as beta - https://phabricator.wikimedia.org/T56349#1175304 (10Jdlrobson) I have no idea what this bug means so probably..:) [20:06:51] matanya: there is no 2015-03-02 beta or stable release [20:07:08] bearND: i'm checking the alphas [20:07:25] 2015-20-02 is ok [20:07:29] matanya: ah, you storing the old alpha apks locally? [20:07:31] scrummasterflash: (love the new handle) where can i add a task/ticket for my "explore phab measurability" action item? [20:07:38] yes bearND [20:07:46] matanya: ok, got it [20:08:07] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice: Next production release for iOS Wikipedia app - https://phabricator.wikimedia.org/T86692#1175308 (10dr0ptp4kt) @Deskana can weigh in, as there may be factors beyond the following. Here's some info from my side: * https://www.mediawik... [20:08:13] ^ Eloquence [20:08:45] (03CR) 10Bmansurov: Filter out retired WikiGrok tags from WikiGrok pages (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [20:09:29] thanks adam [20:09:46] 2015-24-02 is ok [20:11:27] fount it [20:11:33] 2015-28-02 [20:11:54] bmansurov, $wgWikiGrokAggregation [20:12:10] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice: Next production release for iOS Wikipedia app - https://phabricator.wikimedia.org/T86692#1175336 (10dr0ptp4kt) Note, TSG is working on iOS 6 & iOS 7 - see the Google Sheet. [20:12:21] MaxSem: ok [20:12:45] dr0ptp4kt: Deskana https://phabricator.wikimedia.org/T86692 is great [20:13:49] bgerstle: good deal. i gotta disconnect for a few minutes. brb cc mhurd coreyfloyd Deskana [20:14:03] matanya: dbrant: my guess is still https://gerrit.wikimedia.org/r/#/c/192452/ which was merged on 2/25 [20:14:04] 10Wikipedia-App-Android-App: article content not equal in landscap and normal mode in latest alpha 31.3.15 - https://phabricator.wikimedia.org/T94853#1175347 (10Matanya) The behavior changed in alpha version 2015-28-02. previous versions are ok, newer are broken. [20:14:16] bearND: dbrant i [20:14:19] 'll bbl [20:14:21] (03PS14) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [20:14:28] coreyfloyd: ^ [20:14:28] matanya: thank you! [20:14:37] :) [20:16:07] (03CR) 10Dbrant: [C: 04-1] "Looking great; just one thing." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) (owner: 10Mholloway) [20:16:24] bgerstle: you *should* add it in the App imporvement backlog...but it doesn't exist yet! :P I have set aside time on Tuesday to create it. In the meantime.... [20:16:28] (03PS15) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [20:18:02] (03CR) 10Fjalapeno: [C: 031] Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [20:18:06] 10Gather, 7Browser-Tests: Styles not alway loading - https://phabricator.wikimedia.org/T94891#1175367 (10Jdlrobson) 3NEW [20:18:25] coreyfloyd: woohoo! [20:18:40] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice: Next production release for iOS Wikipedia app - https://phabricator.wikimedia.org/T86692#1175374 (10Deskana) @Eloquence I feel comfortable setting the date at Monday 13th April. I will update this task to reflect that. As noted by @d... [20:19:10] bgerstle: i amended https://gerrit.wikimedia.org/r/#/c/200251/ if you have a few minutes for CR [20:19:26] 10Wikipedia-App-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice: Production release for iOS Wikipedia app on Monday 13th April 2015 (provisional) - https://phabricator.wikimedia.org/T86692#1175375 (10Deskana) [20:20:13] mhurd sure, 1 sec [20:20:18] 6Mobile-Web: Generate mockups of how tags will look on mobile article pages - https://phabricator.wikimedia.org/T94736#1175378 (10KLans_WMF) Per design review 04/02: tags on bottom! [20:20:25] (03PS1) 10Bgerstle: update Gemfile and ignore fastflane artifacts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201571 [20:20:27] (03PS1) 10Bgerstle: remove extra schemes and double check old data model inclusion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201572 [20:20:29] (03PS1) 10Bgerstle: clean up FastFile and set vim filetype [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201573 [20:20:31] (03PS1) 10Bgerstle: remove beta.xcconfig [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201574 [20:20:33] ohhh boy [20:20:33] (03PS1) 10Bgerstle: remove conflict markers [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201575 [20:20:35] (03PS1) 10Bgerstle: re-add schemes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201576 [20:20:37] (03PS1) 10Bgerstle: ignore mobileprovision and fix early return [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201577 [20:20:39] (03PS1) 10Bgerstle: makefile: fix clean goal [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201578 [20:20:41] (03PS1) 10Bgerstle: Merge PR#9 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201579 (https://phabricator.wikimedia.org/T94769) [20:20:45] Deskana: thanks for updating the ticket [20:20:48] mhurd dr0ptp4kt haha will, didn't think that would happen [20:20:49] but should've known [20:20:52] Deskana: on the provisional date [20:20:58] dr0ptp4kt: mhurd we're doing an experiment! [20:21:14] bgerstle: no worry [20:21:15] bgerstle: i just came back on irc [20:21:18] what did i miss? [20:21:28] a bajillion gerrit notifs for the commits in my github PR [20:21:34] 10Wikipedia-App-iOS-App: Cannot tweet, even though I am logged into twitter - https://phabricator.wikimedia.org/T94888#1175392 (10Vibhabamba) IOS 6 Device IOS 8 On Wi-fi Using version wikipedia Beta 4.0.7.10 [20:21:35] bgerstle: oh, yeah. ha [20:21:41] merge commit patchset: https://gerrit.wikimedia.org/r/#/c/201579/ GH PR: https://github.com/wikimedia/apps-ios-wikipedia/pull/9 [20:22:56] (03PS6) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [20:23:57] kaldari w00t! https://phabricator.wikimedia.org/T94454 [20:24:38] 6Mobile-Web: Generate mockups of how tags will look on mobile article pages - https://phabricator.wikimedia.org/T94736#1175397 (10phuedx) @MSyed @KHammerstein: if there are tags available for the page, then should we hide the Categories button? [20:24:48] (03PS5) 10Mholloway: Reduce size of face detection image copies for performance [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) [20:31:40] (03PS4) 10Jdlrobson: Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) [20:35:22] (03CR) 10Bgerstle: [C: 04-1] "plz remove redundant block typedef. also, let's chat about the API and put the final nail in the coffin on this one." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [20:35:44] mhurd coreyfloyd have you guys had a hangout to discuss the loading indicator view API? [20:35:50] or just been going back and forth via gerrit? [20:37:41] (03CR) 10Dbrant: [C: 032] Reduce size of face detection image copies for performance [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201463 (https://phabricator.wikimedia.org/T94702) (owner: 10Mholloway) [20:38:33] (03PS1) 10Jdlrobson: Fix overriding of vector styles in resources definition [extensions/Gather] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/201581 (https://phabricator.wikimedia.org/T93050) [20:40:16] 6Mobile-Web, 3Mobile Web Design: Generate mockups of how tags will look on mobile article pages - https://phabricator.wikimedia.org/T94736#1175491 (10KLans_WMF) [20:40:20] mhurd: just doing a spot check on the simulator for https://gerrit.wikimedia.org/r/#/c/200748/ after the rebase i did earlier, then will +2 [20:41:08] bgerstle: yeah hung out [20:41:09] 10Gather, 3Gather Sprint Enwiki: Illustrations are flakey - https://phabricator.wikimedia.org/T94513#1175499 (10Jdlrobson) [20:41:16] 10Wikipedia-App-Android-App, 7Easy, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Perform face detection on a lower-resolution version of the lead image. - https://phabricator.wikimedia.org/T94702#1175501 (10Dbrant) As expected, this had a very good effect on performance: On my test device, face detect... [20:41:17] k [20:41:46] i thought the API was OK a few revisions ok, but since we decided to keep iterating, i thought we should take a moment and just settle this together [20:42:02] maybe incorporate the designs into our best practices doc (if they're not already) [20:42:05] 10Wikipedia-App-Android-App, 7Easy, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Perform face detection on a lower-resolution version of the lead image. - https://phabricator.wikimedia.org/T94702#1175505 (10Deskana) >>! In T94702#1175501, @Dbrant wrote: > As expected, this had a very good effect on pe... [20:42:16] mhurd: dbrant: \o/ [20:42:39] bearND: dbrant that is genius ^ [20:42:40] bearND: ? [20:42:42] Its ironic to post it here… but I am fighting for us to at least try slack out… https://office.wikimedia.org/w/index.php?title=Topic:Seeb9zdx1j39p867&topic_showPostId=sel3cvuumlpe2im0&fromnotif=1#flow-post-sel3cvuumlpe2im0 [20:42:54] coreyfloyd: and for that, i salute you [20:42:55] o> [20:43:20] g'night folks <3 [20:43:26] o/ [20:43:31] hello hello [20:43:44] vbamba: ohai [20:44:06] Im on adium. It doesn't autostart. Kind developers, please recommend an autostart client? [20:44:22] mhurd: Greetings in IRC Land! [20:44:51] vbamba: I reccomend free trial of IRC cloud [20:45:03] (03CR) 10Mhurd: Added wikidata descriptions to saved pages entries. (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [20:45:42] phuedx: later [20:46:09] vbamba: Grettings! :) I used Adium before but converted to LimeChat. Had to move the text entry bar down to the bottom, though [20:46:25] (03PS7) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [20:46:48] IRC Cloud, Limechat, Slack : Recommendations thus far [20:47:07] bb in a few - then will check brians stuff… need to get my dog from the groomer [20:47:10] vbamba i used to use textual, but switched to IRC cloud [20:47:14] bgerstle: dr0ptp4kt mhurd ^ [20:47:19] coreyfloyd: k [20:47:31] vbamba what do you mean by autostart? [20:47:53] it doesnt log in with my saved credentials when i open my machine [20:48:02] bgerstle: vbamba: I think joining chanells automatically [20:48:46] correct, that also. [20:48:49] vbamba: ah [20:48:51] adium can do that [20:48:59] in the preferences, under accounts i think? [20:49:03] vbamba is checking preferences now [20:49:15] and speaking in the 3rd person, apparently :-P [20:49:19] IRCCloud! yessss :D I think you can expense the 5$ if youw ant [20:49:21] *want [20:49:23] vbamba: regarding https://phabricator.wikimedia.org/T94888 , does that happen frequently or always? does 'try again' ever fix the problem? [20:49:27] YuviPanda: you can? tell me how :-P [20:49:33] dr0ptp4kt: she's offline [20:49:38] oh now she's back [20:49:46] bgerstle: Just email Tomasz! [20:49:47] vbamba: regarding https://phabricator.wikimedia.org/T94888 , does that happen frequently or always? does 'try again' ever fix the problem? [20:49:52] vbamba: there's also a section in the prefs for "commands to run on connect" [20:50:13] for that you'll want to add "/join #wikimedia-mobile" and other lines with "/join #some-other-channel" [20:50:18] (w/o quotes) [20:50:18] (03CR) 10Mhurd: Hide loading spinner when using back-forward. (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [20:50:27] dr0ptp4kt: I tried 4 times. Always failed. (also is this adam baso?) [20:50:40] bgerstle: there’s this ‘reimbursement form’ thingy you can fill out. I used to do that for my internet connection, I’d do it once every X months and it worked out ok [20:50:42] (03PS16) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [20:50:48] bgerstle: ^ amended [20:51:00] vbamba: it is. [20:51:18] vbamba: lemme give a try here from my phone [20:51:31] We are now on the google play store! [20:51:53] w00t [20:52:20] vbamba: gotta disconnect from internet on comp. when i get back will let you know what i find out [20:53:51] dbrant: W0000t! [20:55:32] vbamba: where?? i don't see [20:55:54] dbrant: https://play.google.com/store/recommended?sp=CAEwAFopCiNwcm9tb3Rpb25fMzAwMDc5Ml9uZXdfcmVsZWFzZXNfYXBwcxAHGAM%3D:S:ANO1ljKFWtg&c=apps [20:56:18] :D [20:56:22] nice! [20:56:28] niiice :D [20:56:38] We did it! [20:56:43] wait I don’t actually see us there [20:56:43] ah! under New+Updated [20:57:23] mhurd: hello hello! [20:57:24] but maybe my account is still set to India or something like that? [20:57:29] Next up, Editor's Choice. [20:57:36] bearND, dbrant, mholloway: ^ [20:57:38] ;-) [20:57:44] yep! [20:58:43] mhurd: http://appalachiantrials.com/wp-content/uploads/2015/02/Batsignal.png [20:59:40] Deskana: yep. [21:01:05] * bgerstle is sitting in the bat cave all alone [21:01:34] (03PS1) 10Jdlrobson: Hygiene: Remove empty anchor tag [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201589 [21:01:36] (03PS1) 10Jdlrobson: Make all the card link to the page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201590 (https://phabricator.wikimedia.org/T92664) [21:01:45] 10Gather, 3Gather Sprint Enwiki: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1117669 (10Jdlrobson) k. don't like it though.. :P [21:01:57] (03PS2) 10Jdlrobson: Make all the card link to the page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201590 (https://phabricator.wikimedia.org/T92664) [21:02:01] bgerstle: sorry i sec [21:02:04] 1 sec [21:04:21] (03CR) 10Dr0ptp4kt: [C: 032] Collapse image gallery description whitespace. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200748 (https://phabricator.wikimedia.org/T93662) (owner: 10Mhurd) [21:05:34] vibha: are you vibha bamba? [21:05:39] mhurd: bgerstle dr0ptp4kt back [21:05:57] i'm back, too [21:06:01] coreyfloyd: k, lemme know when you're good w/ the fastlane stuff [21:06:17] bgerstle: did you accidentally push multiple commits? [21:06:29] coreyfloyd: it was intentional [21:06:34] hanging out w/ monte right now, can discuss in a bit [21:06:39] k [21:07:03] dr0ptp4kt: yes I ma vibhabamba [21:07:05] am* [21:07:38] 6Mobile-Web, 3Mobile Web Design: Move infobox below lead section in article - https://phabricator.wikimedia.org/T91712#1175631 (10KHammerstein) [21:07:57] (03PS1) 10Jdlrobson: Abuse the hook to add all icons to Minerva [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201592 (https://phabricator.wikimedia.org/T93813) [21:09:22] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1175644 (10Jdlrobson) It was showing only on special pages. I'm abusing the hook in this patchset but it will do the job for the time being. See T93257 [21:09:56] vibha: able to hop on the batcave? [21:10:10] (google hangout url) [21:10:45] 10Gather, 3Gather Sprint Enwiki: Error handling broken on edit workflow - https://phabricator.wikimedia.org/T94106#1175658 (10Jdlrobson) a:3Jdlrobson [21:10:56] what do you guys call the "More information' block for infoboxes and wikidata ? [21:12:21] (03PS1) 10Jdlrobson: Fix error handling for edit workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201594 (https://phabricator.wikimedia.org/T94106) [21:12:45] 10Gather, 3Gather Sprint Enwiki: Keyboard masks description textarea - https://phabricator.wikimedia.org/T94526#1175678 (10Jdlrobson) a:3Jdlrobson [21:16:53] 6Mobile-Web: WikiData More information.. block is not translatable - https://phabricator.wikimedia.org/T94910#1175698 (10TheDJ) 3NEW [21:23:04] (03PS15) 10BearND: Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [21:23:17] dbrant: drum roll please.... [21:23:26] (03CR) 10BearND: [C: 032] Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [21:23:33] * dbrant faints [21:23:54] :) [21:24:26] thx!! [21:24:49] (03Merged) 10jenkins-bot: Reuse the same WebView for article navigation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/197346 (owner: 10Dbrant) [21:27:23] (03CR) 10Kaldari: [C: 032] Hygiene: Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [21:28:20] (03PS3) 10BearND: Fix a couple issues with single WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200166 (owner: 10Dbrant) [21:28:27] (03CR) 10BearND: [C: 032] Fix a couple issues with single WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200166 (owner: 10Dbrant) [21:29:57] (03Merged) 10jenkins-bot: Hygiene: Remove dependency on mobile.templates where hogan is used [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/195803 (owner: 10Krinkle) [21:30:01] (03Merged) 10jenkins-bot: Fix a couple issues with single WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200166 (owner: 10Dbrant) [21:30:23] Deskana: noticing a good amount of play store reviews citing account creation issues. what is our error rate and do we have alarming in place to catch when it spikes ? [21:30:23] 10Wikipedia-App-Android-App: article content not equal in landscap and normal mode in latest alpha 31.3.15 - https://phabricator.wikimedia.org/T94853#1175766 (10bearND) Nothing got merged on Feb 28. So, I assume that's the date you downloaded the alpha apk. So it's probably a patch slightly before then but after... [21:30:55] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: article content not equal in landscap and normal mode in latest alpha 31.3.15 - https://phabricator.wikimedia.org/T94853#1175774 (10bearND) p:5Triage>3Normal [21:31:50] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: Fix Wikipedia logo on Share-a-fact images. - https://phabricator.wikimedia.org/T94760#1175781 (10bearND) p:5Triage>3Normal [21:32:18] tfinc: We've got eventlogging for that. I'll check the rates. [21:32:33] Deskana: do we have any alarming in place to catch large deltas ? [21:32:45] tfinc: No, I'm not sure how possible that is for EL data. [21:32:54] tfinc: That'd be a good feature request for Analytics I think. [21:33:12] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: NPE from inside savedpages.RefreshPagesHandler call in savedpages.SavedPagesFragment.refreshSelected - https://phabricator.wikimedia.org/T94435#1175790 (10bearND) p:5Triage>3High [21:33:20] Deskana: having to check it by hand means that we only check if we know there is a problem and we're trying to validate it [21:33:24] we want to get infront of that [21:34:11] tfinc: Agreed. I'll file a task once I get to see if the rate's changed. [21:35:59] Deskana: tfinc: what do you think about temporarily disabling the onboarding activity for new users (which draws people to sign up/log in) until the issues are fixed? [21:36:29] bearND: do we know what the issues are ? [21:36:46] first i want to see the numbers of how pervasive this is [21:36:59] and prioritize it relative to the rest of our workload [21:37:05] tfinc: I'm not seeing any significant change in account creation error rate. [21:37:39] tfinc: Deskana: Isn't it https://phabricator.wikimedia.org/T88083 [21:37:53] (03PS17) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [21:38:10] bgerstle: ^ [21:38:34] bearND: i took the version numbers from the app itself [21:38:55] the download dates have nothing to do with that [21:40:13] matanya: ok, thanks. It could be that the alpha build was recreated a day later for some reason. I had to get used to your format though, since you had it YYYY-DD-MM. [21:41:20] bearND: i want to about wikipedia app and copied the date [21:41:43] i.e 2.0-alpha-2015-03-31 [21:42:14] (03CR) 10Fjalapeno: "So I heard about the convo going on:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [21:42:40] matanya: The format you just mentioned is good/clear. [21:42:59] matanya: I think you had it 2015-31-03 [21:43:05] coreyfloyd: batcave? [21:43:18] oh, sorry [21:43:30] tfinc: Wait... [21:43:34] tfinc: I've found an anomaly. [21:43:41] matanya: If you include the front part we automatically know if you are using alpha, beta, or production (r) [21:43:44] the last known good version is 2015-02-28 [21:43:57] of the alpha, ofc [21:44:27] matanya: yup, that was clarified on IRC earlier. I'm just saying for future bug reports [21:44:38] ok [21:44:57] tfinc: There has been a gigantic spike in the number of captcha failures today. [21:45:38] Deskana: is it site wide ? [21:46:02] tfinc: This is just apps data. [21:46:10] 10Gather: A user visiting a list via the collections screen generates the event "view_list" - https://phabricator.wikimedia.org/T91018#1175840 (10JKatzWMF) Agreed. [21:46:36] bd808: Do you know if anything is going on with the captcha today? We're noticing a massive spike in the number of captcha failures in the app. [21:46:49] bd808: It's an order of magnitude higher than normal. [21:46:50] Deskana: i know. how does it compare to desktop/mobile captcha failure rates? do we have those ? [21:46:57] tfinc: Not to my knowledge. [21:47:21] Deskana: I haven't heard anything [21:47:30] but that doesn't mean much [21:47:48] (03CR) 10Bgerstle: "If we need more "HUD"-like functionality, then I would agree w/ using a third-party component." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [21:47:54] dr0ptp4kt: thanks for the patch sets, when do you think we'll have the data streaming in ? [21:48:30] Deskana: I'm not seeing especially strange in fatalmonitor [21:48:59] According to EventLogging, nobody has managed to create an account on the app today. At all. [21:50:39] (03CR) 10Bgerstle: "at this point, we're conflating a larger best-practices discussion with this patch. unless it's resolved in the next 5 minutes, let's merg" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [21:50:59] 10Wikipedia-App-Android-App: Account creation appears to be completely broken in the Android Wikipedia app - https://phabricator.wikimedia.org/T94915#1175855 (10Deskana) 3NEW [21:51:08] 10Wikipedia-App-Android-App: Account creation appears to be completely broken in the Android Wikipedia app - https://phabricator.wikimedia.org/T94915#1175862 (10Deskana) p:5Triage>3Unbreak! [21:51:23] bearND, dbrant, mholloway: All hands on deck. ^ [21:51:37] Deskana: thanks [21:51:47] Deskana: looking... [21:51:53] bearND, dbrant, mholloway: EventLogging reports that 0 accounts have been registered today on the Android app. Please investigate! [21:52:04] tfinc: it missed this week's code cutoff. assuming things can be merged in the next 2-3 business days, it should be onto sister projects by the 15th and wikipedias by the 22nd. i'm using https://wikitech.wikimedia.org/wiki/Deployments/One_week as the basis [21:52:52] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: Account creation appears to be completely broken in the Android Wikipedia app - https://phabricator.wikimedia.org/T94915#1175863 (10bearND) [21:53:15] yes, i just tried creating an account, failed 5 captchas i should not have. [21:54:51] Deskana: looks like there is a 3/4 pass rate happening on enwiki right now [21:54:59] Not sure what any basline would be [21:55:03] *baseline [21:55:24] bd808: It appears to be completely impossible to create an account on the app. If there are *any* passes happening elsewhere, then there's likely a problem with the app itself. [21:55:40] bd808: Does that include requests done via the API? [21:56:10] Last 10K lines of captcha.log has 7201 presented; 1545 passed; 1254 failed [21:56:32] Deskana: does the iOS app work? [21:56:45] dbrant: Checking. [21:56:51] (03CR) 10Bgerstle: [C: 032] Fix a typo in AppDelegate.m [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201239 (owner: 10Deskana) [21:56:53] Deskana: Were pass rates normal through yesterday? [21:56:54] There are all confirmedit I think in the log on fluorine [21:57:09] enwiki got a new version yesterday [21:57:18] dr0ptp4kt, mhurd, bgerstle, coreyfloyd: We're having an "unbreak now!" situation at the minute. Please drop everything and all try to create accounts on the iOS app. Thank you. [21:57:23] not sure if it had any captcha or api changes [21:57:29] Deskana: rodger [21:57:31] CreateAccountFunnel: Sending event, event_action = captchaFailure [21:57:41] from logcat ^ [21:57:52] Deskana: current store release or some other release? cc mhurd bgerstle coreyfloyd [21:58:07] Let's split it up. [21:58:12] dr0ptp4kt: Current store release [21:58:20] mhurd: Latest alpha [21:58:24] bgerstle: Latest beta [21:58:27] coreyfloyd: Master [21:58:47] 10Gather, 3Gather Sprint Enwiki: Keyboard masks description textarea - https://phabricator.wikimedia.org/T94526#1175887 (10Jdlrobson) a:5Jdlrobson>3None Had a mess around with this. Basically overflow scroll only works when it the element has height. Tried using the microAutoSize module in MobileFrontend b... [21:58:48] just downloaded Wikipedia Mobile from TF (4.1.0.2) [21:58:49] bd808: It's also broken on the iOS production app which hasn't had a release for months. This appears to be an API issue. [21:58:55] *nod* [21:59:24] what's the api call? [22:00:08] bearND: Can you answer that? ^ [22:01:10] anomie is my go to api guy but he's probably done for the day (EDT) [22:01:15] Deskana: can't seem to get through on 4.1.0.2 [22:01:23] Deskana: i'm in an endless captcha solving loop. appropriately, the latest one i solved is 'citymorns' [22:02:03] legoktm: got a few minutes to help debug captcha failures from iOS app [22:02:04] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup, and 2 others: Account creation via API appears to be broken - https://phabricator.wikimedia.org/T94915#1175907 (10Deskana) [22:02:47] Deskana: i can't get through on 4.1.0.2 [22:03:10] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup, and 2 others: Account creation via API appears to be broken - https://phabricator.wikimedia.org/T94915#1175855 (10Deskana) This is looking like an API issue, because the iOS app hasn't even had any... [22:03:14] I failed 5 in a row on what I think is the latest beta [22:05:53] bd808: Deskana: still looking. It's a POST request to the api. Got an exception: org.mediawiki.api.json.ApiException: java.io.IOException: unexpected end of stream on Connection{en.m.wikipedia.org:443, proxy=DIRECT@ hostAddress=208.80.154.236 cipherSuite=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 protocol=http/1.1} (recycle count=0) [22:06:28] dr0ptp4kt: Can you check if you're getting a similar exception on iOS? [22:06:55] bearND: which url is this? [22:07:03] Deskana: yeah, i'm firing up the debugger on master [22:07:09] dr0ptp4kt: Thank you! [22:07:23] dr0ptp4kt: https://en.m.wikipedia.org/w/api.php [22:07:40] bearND: i mean, which api endpoint [22:07:46] bearND: params and such [22:07:47] mhurd, bgerstle, coreyfloyd: Thanks all. I think we've sufficiently confirmed there's an issue. dr0ptp4kt and I will continue, otherwise you're free to resume what you were doing before. [22:08:04] Deskana: is it iOS only? [22:08:32] mhurd: All versions of the app, on both platforms. [22:08:54] Deskana: so it the app at all or did the api's break/change? [22:08:57] dr0ptp4kt: That's the thing. There are no query parameters in the URL. Looking int he payload [22:09:06] bearND: huh? [22:09:18] *is it the app* [22:09:39] ApiCreateAccount hasn't had a change since 02/27 [22:10:16] mhurd: still works on the desktop (i just verified) but not on either app [22:10:44] It would be this api call from iOS I think -- https://github.com/wikimedia/apps-ios-wikipedia/blob/f88b84ac46c355d159a1f24e46e20f33427891bf/wikipedia/Networking/Fetchers/AccountCreator.m#L115-L140 [22:10:57] Deskana: mholloway bd808 did app account creations cease on or about 02/27 ? [22:12:33] is this i0S only or also android? [22:12:45] greg-g: both [22:12:47] k [22:14:06] bd808: yes, that's the api the iOS app calls for account creation. first step, i think, is to confirm that api actually still works [22:14:18] dr0ptp4kt: bd808: request paramater example: {action=createaccount, format=json, name=xxx, password=xxx, token=6dcdfb5221e37c865643b01cf952cdab, captchaid=23272803, captchaword=pegsheet} [22:15:02] bd808: given that both apps can't create accounts i suspect the api is having an issue as opposed to both apps coincidentally breaking [22:15:11] agreed [22:15:11] Deskana: ^ [22:15:34] and probably something about how captchaid is stored or matched to captchaword [22:15:47] mhurd: We're narrowing it down in #wikimedia-operations. [22:16:08] Deskana: yay! [22:16:52] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup, and 2 others: Account creation via API appears to be broken - https://phabricator.wikimedia.org/T94915#1175957 (10Deskana) This issue appears to have begun at around 20150401230000 UTC (11pm Wednes... [22:20:08] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather events are logged incorrectly against the Gather page in the main namespace rather than special page namespace - https://phabricator.wikimedia.org/T94730#1175998 (10JKatzWMF) @jdlrobson not sure how to review this--feel free to sign off. [22:23:43] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Page action tutorial should be force closed by clicking the watchstar - https://phabricator.wikimedia.org/T94113#1176028 (10JKatzWMF) 5Open>3Resolved overlay loads so fast I can't really test...either way, issue resolved to satisfaction. [22:24:06] (03PS1) 10Jdlrobson: Add missing QQQ codes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201601 (https://phabricator.wikimedia.org/T94545) [22:24:20] 10Gather, 3Gather Sprint Enwiki, 7I18n, 5Patch-For-Review: missing qqq documentation for Gather - https://phabricator.wikimedia.org/T94545#1176042 (10Jdlrobson) a:3Jdlrobson [22:24:45] 3Gather Sprint Enwiki: Watchstar doesn't reflect real status - https://phabricator.wikimedia.org/T94508#1176047 (10Jdlrobson) a:3Jdlrobson [22:33:40] 10Gather, 7Mobile: Article opened on Safari brower via iPhone froze app - https://phabricator.wikimedia.org/T94923#1176092 (10Rdicerb) 3NEW [22:35:01] (good timing eh? with the app being featured...) [22:35:12] (03PS1) 10Jdlrobson: Update watchstar correctly [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201604 (https://phabricator.wikimedia.org/T94508) [22:35:28] (03PS18) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [22:35:37] 10Gather, 3Gather Sprint Enwiki: Watchstar doesn't reflect real status - https://phabricator.wikimedia.org/T94508#1165381 (10Jdlrobson) [22:35:41] 10Gather, 7Mobile: Article opened on Safari brower via iPhone froze app - https://phabricator.wikimedia.org/T94923#1176102 (10Rdicerb) {F108270} I tried to add to a collections to try it out, and it froze. iPhone 6 version 8.1.3 [22:36:01] 10Gather, 3Gather Sprint Enwiki, 6Mobile-Web: Blue tutorial indicator positioned incorrectly in Chrome when pointing at a transformed element e.g. green watchstar - https://phabricator.wikimedia.org/T93987#1176104 (10Jdlrobson) a:3Jdlrobson [22:37:55] bgerstle: coreyfloyd ^ amended [22:38:29] (03CR) 10Kaldari: [C: 04-1] Do not load Minerva modules outside Minerva (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) (owner: 10Jdlrobson) [22:39:12] (03Abandoned) 10Bgerstle: makefile: fix clean goal [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201578 (owner: 10Bgerstle) [22:39:24] (03Abandoned) 10Bgerstle: Merge PR#9 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201579 (https://phabricator.wikimedia.org/T94769) (owner: 10Bgerstle) [22:39:54] (03Abandoned) 10Bgerstle: ignore mobileprovision and fix early return [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201577 (owner: 10Bgerstle) [22:40:02] (03Abandoned) 10Bgerstle: re-add schemes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201576 (owner: 10Bgerstle) [22:40:12] (03Abandoned) 10Bgerstle: remove conflict markers [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201575 (owner: 10Bgerstle) [22:40:20] (03Abandoned) 10Bgerstle: remove beta.xcconfig [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201574 (owner: 10Bgerstle) [22:40:36] (03Abandoned) 10Bgerstle: clean up FastFile and set vim filetype [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201573 (owner: 10Bgerstle) [22:40:53] jdlrobson3: I can’t +2 https://gerrit.wikimedia.org/r/#/c/199780/ since I wrote the last version of the patch. [22:41:06] 10Gather, 3Gather Sprint Enwiki: Pagination of all the things - https://phabricator.wikimedia.org/T93426#1176134 (10JKatzWMF) @jdlrobson When I added more than 50 collections on betawmflabs, I just saw thie gatherLists page grow...did not see evidence of pagination. Can you confirm the limit per page? [22:41:18] kaldari: why not? [22:41:30] oh wait [22:41:36] (03Abandoned) 10Bgerstle: remove extra schemes and double check old data model inclusion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201572 (owner: 10Bgerstle) [22:41:40] jdlrobson3: I mean I could, but it’s bad form :) [22:41:49] (03Abandoned) 10Bgerstle: update Gemfile and ignore fastflane artifacts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201571 (owner: 10Bgerstle) [22:41:51] oh i see.. bmansurov wrote first one threw me [22:41:59] whhy doesn't owner update... [22:42:07] mm, i don't understand what you are trying to do, maybe ask phuedx tomorrow to +2 then? [22:42:29] sure [22:42:29] (03PS1) 10Bgerstle: cleanup project & fastfile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201608 (https://phabricator.wikimedia.org/T94769) [22:42:32] (03CR) 10Jdlrobson: "I thus entrust @phuedx with that power. I don't really know what the end goal is and whether this is correct." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [22:42:50] kaldari: can you take a look at Krinkle patch [22:42:59] jdlrobson3: which one? [22:43:16] oh wait you did already :) [22:43:16] thx [22:43:18] (03CR) 10Fjalapeno: [C: 031] Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [22:43:28] (03CR) 10Fjalapeno: [C: 031] cleanup project & fastfile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201608 (https://phabricator.wikimedia.org/T94769) (owner: 10Bgerstle) [22:44:53] (03PS5) 10Jdlrobson: Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) [22:46:15] dr0ptp4kt: can you merge ^ [22:51:06] bgerstle: not right now. i'm in the middle of an emergency with this login stuff [22:51:51] dr0ptp4kt: no problem mhurd will get it [22:51:52] 10Gather, 6Mobile-Web, 3Mobile-Web-Sprint-44-R_________: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1176147 (10kaldari) [22:52:25] Mhurd every time I type your handle I think of Perd Hapley from Parks & Rec (cc coreyfloyd) [22:52:53] MaxSem: do you know what the deal is with "Exception Caught: Attempt to get non-existing setting "internalEntitySerializerClass""? [22:53:07] MaxSem: happens when saving a wikigrok claim [22:53:49] jdlrobson3, rmoen: At some point someone from team xtreme will need to talk with someone from team gather to figure out this spike: https://phabricator.wikimedia.org/T94737 . Any suggestions for who and when? [22:54:55] bmansuro_: Does it happen with a particular claim or all claims? [22:55:16] kaldari: i've tested with one only, but I think it happens when aggregation kicks in [22:55:55] bmansuro_, trace? [22:56:09] is wikidata up to date? [22:56:15] MaxSem: yes, "#0 /vagrant/mediawiki/extensions/WikidataBuildResources/extensions/Wikibase/repo/includes/WikibaseRepo.php(852): Wikibase\SettingsArray->getSetting(string)#1 /vagrant/mediawiki/extensions/WikidataBuildResources/extensions/Wikibase/repo/includes/WikibaseRepo.php(838): Wikibase\Repo\WikibaseRepo->getInternalEntitySerializer()#2 /vagrant/mediawiki/extensions/WikidataBuildResources/extensions/Wikibase/r [22:56:15] epo/includes/WikibaseRepo.php(490): Wikibase\Repo\WikibaseRepo->getEntityContentDataCodec()#3 /vagrant/mediawiki/extensions/WikidataBuildResources/extensions/Wikibase/repo/includes/WikibaseRepo.php(358): Wikibase\Repo\WikibaseRepo->getStore()#4 /vagrant/mediawiki/extensions/WikiGrok/includes/WikibaseRepoConnector.php(36): Wikibase\Repo\WikibaseRepo->getEntityLookup()#5 /vagrant/mediawiki/extensions/WikiGrok/inclu [22:56:15] des/Aggregator.php(135): WikiGrok\WikibaseRepoConnector->addClaims(array, User)#6 /vagrant/mediawiki/extensions/WikiGrok/includes/Aggregator.php(61): WikiGrok\Aggregator->commitChanges(WikiGrok\WikibaseRepoConnector)#7 /vagrant/mediawiki/extensions/WikiGrok/includes/api/ApiResponse.php(146): WikiGrok\Aggregator->aggregate(array, WikiGrok\ResponseStoreDB, WikiGrok\WikibaseRepoConnector)#8 /vagrant/mediawiki/includ [22:56:18] es/api/ApiMain.php(1037): WikiGrok\Api\ApiResponse->execute()#9 /vagrant/mediawiki/includes/api/ApiMain.php(394): ApiMain->executeAction()#10 /vagrant/mediawiki/includes/api/ApiMain.php(367): ApiMain->executeActionWithErrorHandling()#11 /vagrant/mediawiki/api.php(88): ApiMain->execute()#12 /var/www/w/api.php(5): include(string)#13 {main}" [22:56:21] ooops, sorry [22:57:53] good one bmansuro_ ;-) [22:58:04] coreyfloyd: I forgot to mention that I was glad you referenced libs in your feedback. That's a good reality check for these kinds of discussions. That being said, I'm going to spend some personal time [22:58:11] oh haha, guess I'll change my nick back now [22:58:18] Investigating hidden and alpha's relationship [22:58:42] scrummasterflash: what's your real nick? [22:58:48] I'll report my findings at tomorrow's code review [22:59:02] Baha it's me, K-Phab! < - bmansuro_ [22:59:11] aka scrummasterflash [22:59:26] hey there [22:59:31] so many nicknames [22:59:50] you should create a unified nickname which includes all of your usernames [23:00:00] that way any one will be highlighted [23:00:03] ;)) [23:00:25] bgerstle: yeah - i wanted to sanity check myself - sometimes with internal discussions you lose sight of the rest of the world [23:00:47] scrummasterflash has left the building [23:01:01] bearND quick question for you [23:01:12] (03CR) 10Kaldari: [C: 032] Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) (owner: 10Jdlrobson) [23:02:31] coreyfloyd: https://gerrit.wikimedia.org/r/#/c/201092/ [23:03:52] (03CR) 10Fjalapeno: [C: 031] Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [23:03:54] kaldari, MaxSem: any ideas? [23:03:58] (03Merged) 10jenkins-bot: Do not load Minerva modules outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201364 (https://phabricator.wikimedia.org/T94504) (owner: 10Jdlrobson) [23:04:50] (03PS19) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [23:04:59] coreyfloyd: ^ [23:06:01] bmansuro_: lemme try in my instance... [23:06:21] (03CR) 10Fjalapeno: [C: 031] Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:06:27] need to update everything first.... [23:06:48] kaldari: ok, steps to reproduce: set a low number for $wgWikiGrokAggregation->'100% agreement' [23:06:48] 10Wikipedia-App-iOS-App: Cannot tweet, even though I am logged into twitter - https://phabricator.wikimedia.org/T94888#1176198 (10Vibhabamba) Ok, This is resolved. I guess users can have twitter issues in settings. No way to know that. [23:06:52] bgerstle can you +1 monte? ^ [23:06:58] kaldari: then submit [23:07:47] 10Wikipedia-App-iOS-App: Cannot tweet, even though I am logged into twitter - https://phabricator.wikimedia.org/T94888#1176202 (10Vibhabamba) 5Open>3Resolved [23:08:42] vibha: yes? [23:09:04] hi! [23:09:06] qq [23:09:18] what is the release cadence for Android? [23:09:37] When do the current set of changes which are in alpha/beta go to the app play store? [23:09:45] (03PS1) 10Jdlrobson: Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 [23:09:47] (03PS1) 10Jdlrobson: WIP: Redo watchstar creation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) [23:09:51] Sorry I'm afk [23:09:53] MaxSem: I added you t a pageimages patch [23:10:28] (03CR) 10Catrope: [C: 032] Fix overriding of vector styles in resources definition [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201503 (https://phabricator.wikimedia.org/T93050) (owner: 10Jdlrobson) [23:10:48] vibha: currently beta and production are roughly the same (minus the feature flagged things). This will change once we publish a new beta (hopefully tomorrow or Monday) [23:10:59] (03CR) 10Catrope: [C: 032] Fix overriding of vector styles in resources definition [extensions/Gather] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/201581 (https://phabricator.wikimedia.org/T93050) (owner: 10Jdlrobson) [23:11:12] bmansuro_: hmm, my vagrant install is now hosed for some reason…. [23:11:26] vibha: I hope that we can followup with a production release shortly thereafter since we only did bugfixes [23:11:33] kaldari: ok, nm. I just changed the code to get past the error message. thans [23:11:34] thanks [23:11:36] like a week later or so [23:11:37] 3Gather Sprint Enwiki, 6Mobile-Web, 5Patch-For-Review: MobileWebUIClickTracking main menu event logging can leak into desktop (EventLogging exception on Special:Gather in Vector) - https://phabricator.wikimedia.org/T94504#1176208 (10Jdlrobson) 5Open>3Resolved thanks guys! [23:11:58] So the parenthesis in first sentences will be available in production in a week's time? [23:12:24] *Removed Parenthesis [23:12:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Redo watchstar creation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) (owner: 10Jdlrobson) [23:13:44] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 (owner: 10Jdlrobson) [23:13:54] The parenthesis feature is feature flagged to only appear on enwiki for alpha/beta [23:13:59] vibha: ^ [23:14:01] (03PS3) 10Mhurd: Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 [23:14:19] vibha: So, basically the answer is no [23:14:40] vibha: you won't see that in production next week [23:15:13] I need to understand this release process a bit better for project specific flagged features [23:15:39] (03PS2) 10Jdlrobson: Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 [23:16:08] 10Gather, 3Gather Sprint Enwiki: Pagination of all the things - https://phabricator.wikimedia.org/T93426#1176230 (10Jdlrobson) Try now. Created 50 new ones for you: http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:GatherLists&lstcontinue=20150402223923%7C144&continue=-%7C%7C [23:16:08] bmansuro_, so are you up to date? [23:16:19] MaxSem: yes [23:16:29] vibha: We look for guidance from Deskana for the feature-flagged items, like this. It's up to him [23:16:55] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather events are logged incorrectly against the Gather page in the main namespace rather than special page namespace - https://phabricator.wikimedia.org/T94730#1176231 (10Jdlrobson) 5Open>3Resolved [23:17:16] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: : Undefined property: Gather\models\Collection::$continue in L127 - https://phabricator.wikimedia.org/T94722#1176233 (10Jdlrobson) 5Open>3Resolved [23:17:42] vibha: Once Deskana announces that we promote a flagged feature then we make a change in our code to do so. Then it'll be included in the next release [23:18:14] Deskana the ultimate force [23:18:20] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 (owner: 10Jdlrobson) [23:18:57] coreyfloyd: you can act as my proxy on mhurds patch [23:19:55] bearND - did share a fact get approval for removing parenthesis in other languages yet? [23:20:13] was that announced anywhere? I would like to take a look [23:20:35] 3Gather Sprint Enwiki, 5Patch-For-Review: [code] Hygiene: improve isOwner on collection - https://phabricator.wikimedia.org/T94556#1176259 (10Jdlrobson) 5Open>3Resolved [23:21:31] (03PS4) 10Fjalapeno: Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 (owner: 10Mhurd) [23:21:50] (03CR) 10Bgerstle: [C: 032] Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:22:28] coreyfloyd: mhurd ^ [23:22:55] Still can't merge :-: [23:25:04] vibha: It's a different story for ShareAFact. Might also be different on iOS. (cc: dr0ptp4kt). On Android we get rid of [] but not (). The only exception being that we remove a semicolon if it's right after (, since that's a remnant from an IPA icon. [23:25:50] vibha: ShareAFact [] (; treatment is NOT feature-flagged [23:26:12] (03Merged) 10jenkins-bot: Fix overriding of vector styles in resources definition [extensions/Gather] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201503 (https://phabricator.wikimedia.org/T93050) (owner: 10Jdlrobson) [23:26:12] hmm, that confuses me. [23:26:14] (03Merged) 10jenkins-bot: Fix overriding of vector styles in resources definition [extensions/Gather] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/201581 (https://phabricator.wikimedia.org/T93050) (owner: 10Jdlrobson) [23:26:41] i'll chat with dbrant tomorrow to clairify [23:27:37] Also this will apply to link previews :) [23:27:54] we need some consistent approach to practices like this. [23:28:56] vibha: i agree. Currently they are separate. The main reason is that ShareAFact is done in Java, and the first paragraph changes are done in JavaScript [23:30:03] vibha: but technically they *could* behave the same [23:31:15] 10Wikipedia-App-Android-App: Banner Image for Google Play Store is inconsistent with branding. - https://phabricator.wikimedia.org/T94936#1176287 (10Vibhabamba) 3NEW a:3bearND [23:33:48] 10Gather, 6Mobile-Web, 3Mobile Web Design, 3Mobile-Web-Sprint-44-R_________: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1176299 (10KLans_WMF) [23:34:45] MaxSem: Talking about retiring questions, if I remove a question from the DB, won't removed questions be re-added on onLinksUpdate? [23:36:40] bmansuro_, you don't remove from DB. you remove it from LinksUpdste results;) [23:37:02] 10Wikipedia-App-Android-App: Banner Image for Google Play Store is inconsistent with branding. - https://phabricator.wikimedia.org/T94936#1176315 (10bearND) @Vibhabamba Please point us to the correct image, and we're happy to use it [23:37:09] MaxSem: look at my patch! look at my patch! https://gerrit.wikimedia.org/r/#/c/201613/ :) [23:37:14] I wrote PHPEE! :) [23:37:44] MaxSem: so the code should live in QuestionStore and not in ResponseStore? [23:37:46] YuviPanda, you're scaring me! :P [23:38:04] MaxSem: oh, that's just PHP said loudly, not PHP EE like JEE [23:38:25] YuviPanda: sure it wasn't PytHonPeee? [23:38:36] bearND: sadly. it was a patch to PageImages. [23:40:21] YuviPanda: what's ifttt? [23:40:49] in your Phab task related to that [23:40:57] bearND: ifttt.com [23:41:18] YuviPanda: ah, cool [23:41:47] moizsyed: kaity your new workboard is starting to fill out nicely! https://phabricator.wikimedia.org/tag/mobile_web_design/board/ [23:42:00] kristenlans: yay [23:42:05] (03CR) 10Fjalapeno: "bgerstle +1 in spirit" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [23:42:06] kristenlans: thanks for all the help on this :) [23:42:47] moizsyed: no problemo, I'm excited to see how this works out [23:43:36] bmansuro_, yes, checks should be in QS [23:43:57] bmansuro_, err [23:44:38] all access to submitted claims should be from one place - ResponseStore [23:45:04] then QS or Hooks should use these results for filtering [23:45:12] bmansuro_, something like this ^^^ [23:45:38] MaxSem: thanks [23:47:12] (03PS5) 10Mhurd: Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 [23:47:17] coreyfloyd: ^ amended [23:49:56] (03PS6) 10Mhurd: Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 [23:50:38] (03CR) 10Fjalapeno: [C: 031] Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 (owner: 10Mhurd) [23:55:06] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1176395 (10KLans_WMF) [23:55:24] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Paginate all the things - https://phabricator.wikimedia.org/T94515#1176397 (10JKatzWMF) 5Open>3Resolved [23:55:34] (03CR) 10Mhurd: [C: 032] cleanup project & fastfile [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201608 (https://phabricator.wikimedia.org/T94769) (owner: 10Bgerstle) [23:55:43] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Paginate all the things - https://phabricator.wikimedia.org/T94515#1165488 (10JKatzWMF) [23:55:46] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: No way to moderate a certain collection from the collection itself - https://phabricator.wikimedia.org/T94228#1176403 (10KLans_WMF) [23:56:02] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1176405 (10KLans_WMF) [23:56:14] (03CR) 10Fjalapeno: [C: 032] Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 (owner: 10Mhurd) [23:56:19] 3Gather Sprint Enwiki, 3Mobile Web Design: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1176406 (10KLans_WMF) [23:56:33] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Paginate all the things - https://phabricator.wikimedia.org/T94515#1165488 (10JKatzWMF) Just removed points from this (3) since it appears to be identical to T93426 (which has 3 points)