[00:01:43] (03PS7) 10Mhurd: Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 [00:02:01] (03PS2) 10Fjalapeno: Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 [00:03:05] (03CR) 10Fjalapeno: [C: 031] Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 (owner: 10Mhurd) [00:04:16] coreyfloyd: https://github.com/montehurd/apps-ios-wikipedia/commit/70f64e957efda13e016508c3c325c0d0436e6677 [00:08:11] (03PS8) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [00:08:42] (03PS20) 10Mhurd: Hide loading spinner when using back-forward. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 [00:11:34] quiddity hi there [00:11:38] are you around? [00:11:54] hi, yup [00:12:07] I took some screenshots, just sent you an email. [00:12:19] hovercards in Greek and Chinese wikipedia. [00:12:30] omg - Chinese Wikipedia is beautiful. [00:12:35] =) [00:12:50] vibha, could you upload them to Commons, please? That's the hardest step. [00:12:51] Im logging the phab task for text changes - could you help me with where and how to arrange the screenshots on the talk page? [00:12:53] please ? [00:13:03] yes! uploading them to commons now. [00:13:05] heh - agree [00:13:14] can I send you links once uploaded to commons? [00:13:42] Yup, perfect :) I'm happy to fiddle with the page layout, once we have assets. :) [00:14:15] (03CR) 10Mhurd: [C: 032] "This has been been +1'ed by both Corey and Brian." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200251 (owner: 10Mhurd) [00:14:53] quiddity: 'These files are not my own work' - Is that the right option on commons? [00:15:16] these are screenshots, not mockups [00:15:19] (03PS9) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [00:15:31] (03PS8) 10Mhurd: Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 [00:15:49] but then, who should be listed as the source and the author? [00:17:08] vibha, I have to look it up every dang time I do it, and I'm never sure if I'm right... >.< I use https://en.wikipedia.org/wiki/Wikipedia:Screenshots_of_Wikipedia - but the Design Team ought to have this well-documented (and practiced!). [00:17:43] heading out [00:17:44] also, I've just saved the task about improving the docs https://phabricator.wikimedia.org/T94945 - howver, I've been working straight since i woke up, and I desperately need lunch. [00:18:38] quiddity: please go ahead. I'll add the links to email/phab [00:18:51] you should definitely eat lunch. Food first! [00:25:00] quiddity: Done. I added links to paste screenshots into a wiki. 5 or more from Greek and Chinese Wikipedia each. [00:35:10] any idea who Ricordisamoa is? [00:41:49] volunteer dev [00:47:25] (03PS1) 10Dbrant: Reverse the Ken Burns effect on lead images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201633 (https://phabricator.wikimedia.org/T94529) [00:50:54] (03PS3) 10Bmansurov: Filter out retired WikiGrok tags from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) [00:51:48] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App, 6MediaWiki-API-Team, 10MediaWiki-User-login-and-signup, and 2 others: Account creation via API appears to be broken - https://phabricator.wikimedia.org/T94915#1176581 (10Deskana) 5Open>3Resolved a:3Deskana Account creation was broken by this patch... [00:52:05] (03CR) 10Bmansurov: "Haven't been able to test it yet. Also, I'm not sure how I should handle already retired claims since currently questions are updated on l" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [01:01:57] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: "ken burns effect" on image loads should be reversed - https://phabricator.wikimedia.org/T94529#1176618 (10Dbrant) [01:07:03] Going for dinner now the account creation problem is fixed. Be back afterwards. [01:18:36] vibha: send you and moiz some ShareAFact cards with updated WP wordmark [01:18:39] sent [01:23:20] looks like it should be half that size. But best to wait for Moiz to comment. [01:26:02] ok [01:32:55] (03PS1) 10BearND: WIP: ShareAFact: use static image for English WP wordmark [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201641 (https://phabricator.wikimedia.org/T94760) [01:45:06] bearND still looks too big [01:47:00] vibha: k, will wait for some sizes from you or moizsyed [01:47:19] bearND: hey [01:47:23] bearND: whats up [01:47:43] moizsyed: sent you some ShareAFact images with updated WP logo [01:47:56] in your email inbox [01:48:06] bearND: oh i see it [01:48:11] bearND: yeah this needs to be smaller [01:48:20] bearND: let me reply to the email [01:48:39] moizsyed: the last image I reduced the size. vibha said it should be even smaller [01:48:48] great, you guys are on it. [01:51:33] 10Wikipedia-App-Android-App, 6CA-team, 10MediaWiki-API, 6MediaWiki-API-Team, and 2 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1176736 (10Krenair) I tested my instructions again on 2.0-beta-2015-03-23. It definitely results in a logged out edit, an... [02:13:58] 10Wikipedia-App-Android-App, 10Wikipedia-App-iOS-App: EPIC: As a mobile reader, I would like links that I tap on to show quick previews so that I can choose whether to navigate to it or not. - https://phabricator.wikimedia.org/T94630#1176767 (10Vibhabamba) Breakup of Epic **Content and Card Layout:** The firs... [02:19:17] (03PS2) 10BearND: WIP: ShareAFact: use static image for English WP wordmark [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201641 (https://phabricator.wikimedia.org/T94760) [02:32:51] (03PS3) 10BearND: ShareAFact: use static image for English WP wordmark [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201641 (https://phabricator.wikimedia.org/T94760) [04:18:24] 10Gather, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1176887 (10Krenair) 3NEW [04:22:41] 10Gather, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1176894 (10MZMcBride) I made the account "I literally can't even" on test.m.wikipedia.org and tried to use Special:Gather. Special:Gather loaded, but I wasn't able to figure out how to create a list. Th... [04:28:16] 6Mobile-Web, 10MobileFrontend: MobileFrontend's Special:EditWatchlist has red links and I'm not sure why - https://phabricator.wikimedia.org/T94966#1176896 (10MZMcBride) 3NEW [04:48:03] 10Gather: Special:Gather uses "articles" instead of "pages" or a more generic term - https://phabricator.wikimedia.org/T94967#1176906 (10MZMcBride) 3NEW [04:49:49] 10Gather: Special:Gather collection page counts should use number separators - https://phabricator.wikimedia.org/T94968#1176913 (10MZMcBride) 3NEW [04:51:39] (03PS4) 10BearND: ShareAFact: use static image for English WP wordmark [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201641 (https://phabricator.wikimedia.org/T94760) [04:56:03] 10Gather: Special:Gather interface overlaps with MediaWiki tagline in skins such as MonoBook - https://phabricator.wikimedia.org/T94970#1176929 (10MZMcBride) 3NEW [04:56:36] 10Gather: Gather should fail more gracefully if MobileFrontend is not installed - https://phabricator.wikimedia.org/T94969#1176936 (10Deskana) [04:58:22] (03PS2) 10BearND: Reverse the Ken Burns effect on lead images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201633 (https://phabricator.wikimedia.org/T94529) (owner: 10Dbrant) [04:58:28] (03CR) 10BearND: [C: 032] Reverse the Ken Burns effect on lead images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201633 (https://phabricator.wikimedia.org/T94529) (owner: 10Dbrant) [04:58:58] (03Merged) 10jenkins-bot: Reverse the Ken Burns effect on lead images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201633 (https://phabricator.wikimedia.org/T94529) (owner: 10Dbrant) [04:58:59] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: "ken burns effect" on image loads should be reversed - https://phabricator.wikimedia.org/T94529#1176939 (10bearND) p:5Triage>3Normal [05:04:15] 10Gather: Gather should explain to users why they're required to log in if they go to Special:Gather - https://phabricator.wikimedia.org/T94971#1176952 (10Deskana) 3NEW [05:05:10] 10Gather: Gather should explain to users why they're required to log in if they go to Special:Gather or Special:GatherLists - https://phabricator.wikimedia.org/T94971#1176960 (10Deskana) [05:07:42] 10Gather: GatherLists table should not simply be a totally empty if there are no collections - https://phabricator.wikimedia.org/T94972#1176967 (10Deskana) 3NEW [05:13:03] 10Gather: GatherLists first column should be collection name, not author - https://phabricator.wikimedia.org/T94973#1176979 (10Deskana) 3NEW [05:18:17] (03PS1) 10Deskana: Swap ordering of Owner and Title columns in GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 [05:20:44] (03CR) 10jenkins-bot: [V: 04-1] Swap ordering of Owner and Title columns in GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 (owner: 10Deskana) [05:23:22] (03PS2) 10Deskana: Swap ordering of columns in GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 [05:24:46] 10Wikipedia-App-Android-App: Search should be hidden from the Saved Pages and History sections of the app if there are no saved pages or history entries - https://phabricator.wikimedia.org/T94974#1176998 (10Deskana) 3NEW [05:25:43] (03CR) 10jenkins-bot: [V: 04-1] Swap ordering of columns in GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 (owner: 10Deskana) [05:29:21] 10Gather, 10Vector, 5Patch-For-Review, 7Regression: Some styles specific to Vector skin missing (Special:Preferences, mediawiki.notification bubbles, jQuery UI) - https://phabricator.wikimedia.org/T93050#1177014 (10Krinkle) 5Open>3Resolved [05:29:30] 10Gather, 10Vector, 7Regression: Some styles specific to Vector skin missing (Special:Preferences, mediawiki.notification bubbles, jQuery UI) - https://phabricator.wikimedia.org/T93050#1127937 (10Krinkle) [05:33:59] (03CR) 10Deskana: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 (owner: 10Deskana) [05:41:16] (03CR) 10Deskana: "Maybe I'm just stupid but from how I'm reading it, it seems like this test failure has nothing to do with my patch. I'm not sure what to d" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 (owner: 10Deskana) [05:44:32] phuedx: Are you actually awake? :-) [05:45:09] he has a baby, so he may be [05:45:18] Deskana: I'm fighting with your country's visa form [05:45:23] it's asking me for my dad's place of birth... [05:46:24] YuviPanda: You didn't need that last time? [05:46:32] Deskana: don't remember... [05:46:44] Deskana: also only place in the entire US that grants UK visas is in New YOrk.... [05:47:31] :-( [05:52:05] YuviPanda: Do you know how to read QUnit tests? [05:52:19] sadly no... [05:52:27] YuviPanda: I don't know why Jerkins gave my patch a -1. [05:52:43] Deskana: legoktm or Krenair or krinkle (not here but in -dev) might be able to help [05:52:49] hi [05:53:04] Hi! [05:53:10] I'm trying to figure out why this got a -1: https://gerrit.wikimedia.org/r/#/c/201665/ [05:53:11] Deskana: you can go to Special:JavaScriptTest in your browser to run them with a hopefully more clear error message [05:53:28] Oh, yeah, I did that. [05:53:29] I got this. [05:53:35] Modules in error state@ 1 ms [05:53:35] Expected: [05:53:35] [] [05:53:37] Result: [05:53:39] [ [05:53:41] "ext.gather.watchstar", [05:53:43] "ext.gather.watchstar.tests" [05:53:45] ] [05:53:47] Diff: [05:53:49] [] [ [05:53:51] "ext.gather.watchstar", [05:53:53] "ext.gather.watchstar.tests" [05:53:55] ] [05:53:59] That seems abnormal. [05:54:07] if you revert your change locally, do the tests pass? [05:54:10] But I don't know what any of this really means. [05:54:20] Let me see. [05:54:44] No. I'm on master. [05:54:58] Wait, I fucked that up. [05:55:25] Nope, now I really am on master and they fail. [05:55:32] I guess I got my answer. Thanks. :-) [05:57:12] (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201668 [05:58:41] Deskana: you should probably file a bug about qunit tests on master being broken [05:58:46] https://integration.wikimedia.org/ci/job/mwext-Gather-qunit/120/console [05:59:25] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201668 (owner: 10Legoktm) [06:01:33] 10Gather: Unit tests in master branch appear to be broken - https://phabricator.wikimedia.org/T94975#1177047 (10Deskana) 3NEW [06:02:53] 10Gather: Gather qunit tests broken - https://phabricator.wikimedia.org/T94975#1177057 (10Legoktm) [06:05:38] 10Gather: Gather qunit tests broken - https://phabricator.wikimedia.org/T94975#1177062 (10Krinkle) ``` 05:58:10 Chromium 41.0.2272 (Ubuntu) LOG: 'Exception in module-execute in module ext.gather.watchstar:' 05:58:10 Chromium 41.0.2272 (Ubuntu) ERROR: 'Error: Module not found: settings', Error{} 05:58:10 .. 05:58... [06:16:41] Deskana: 500$ Visa fee for the UK >_> ;_; [06:28:06] 10Wikipedia-App-General-or-Unknown, 10MediaWiki-API: Tracking: API/backend issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#1177093 (10Tgr) [06:28:10] 10Wikipedia-App-Android-App, 10MediaWiki-extensions-CommonsMetadata, 6Multimedia, 5Patch-For-Review: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#1177091 (10Tgr) 5Open>3Resolved Assuming this works now, please reopen... [06:30:29] 10Wikipedia-App-Android-App, 10MediaWiki-extensions-CommonsMetadata, 6Multimedia, 5Patch-For-Review: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#1177097 (10Tgr) [08:58:57] good morning [09:22:09] hey joakino [09:22:15] hey yop [09:37:00] millions of emails [09:44:51] 3Gather Sprint Diplodocus, 5Patch-For-Review: Heading spacing is off on vector - https://phabricator.wikimedia.org/T94069#1177369 (10Jhernandez) 5Open>3Resolved [09:44:59] joakino: inorite [09:45:06] i liked your summary of dhh's talk :D [09:49:23] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Responsive design for tiling Special:Gather list of collections - https://phabricator.wikimedia.org/T91384#1177378 (10Jhernandez) a:3Jhernandez [09:49:48] hah yeah [10:00:15] (03PS1) 10Jhernandez: Tablet styles for Special:Gather/by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) [10:00:43] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Responsive design for tiling Special:Gather list of collections - https://phabricator.wikimedia.org/T91384#1177384 (10Jhernandez) Collections list tablet styles on previous patch ⬆️ [10:02:32] (03CR) 10jenkins-bot: [V: 04-1] Tablet styles for Special:Gather/by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [10:03:26] i'm going to go out on a limb here [10:03:39] i don't like a lot of browser tests [10:04:37] phuedx: wat? [10:04:42] because the email? [10:05:27] they give me extreme confidence when they work, and extreme frustration when they are running (slow) or when they fail (random unrelated failures not related to code failures) [10:06:42] no not because of the email [10:06:45] :P [10:06:54] they give me some confidence when they work [10:07:00] and otherwise frustrate me [10:08:21] (03CR) 10Jhernandez: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [10:11:35] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1177398 (10Jhernandez) a:5Jdlrobson>3Jhernandez [10:12:16] agreed [10:12:24] because they operate on the whole system rather than a specific part of it [10:12:37] having said that, i'm keen to get started writing more browser tests [10:13:00] *-browser [10:13:04] just more tests [10:14:24] (03PS2) 10Jhernandez: Use images rather than background-image for page images in collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200754 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [10:16:53] (03CR) 10jenkins-bot: [V: 04-1] Use images rather than background-image for page images in collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200754 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [10:20:28] joakino: gather unit tests appear borked [10:21:12] i know :( i have to get to it, but did a grunt and it hanged there forever, not sure [10:21:41] thx for the report phuedx, so annoying [10:21:41] :/ [10:21:49] Deskana|Away reported it first [10:21:55] i'll have a look when I finish what I'm doing now [10:22:01] you'd better! [10:22:05] i'll be watching [10:22:13] yessir TECHLEAD sir [10:22:29] btw why xtreme? xd [10:22:40] i said it [10:22:44] and it seems to have stuck [10:22:47] it's a BAD joke [10:24:58] 6Mobile-Web, 7Browser-Tests: update Mobile tests to run against local envs as well as beta - https://phabricator.wikimedia.org/T56349#1177412 (10zeljkofilipin) @jdlrobson: in that case, resolving the bug as invalid. Please reopen if needed. [10:25:06] 6Mobile-Web, 7Browser-Tests: update Mobile tests to run against local envs as well as beta - https://phabricator.wikimedia.org/T56349#1177413 (10zeljkofilipin) 5Open>3Invalid [11:07:45] (03PS3) 10Jhernandez: Include collection image in html for sharing [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200754 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [11:10:03] (03CR) 10jenkins-bot: [V: 04-1] Include collection image in html for sharing [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200754 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [11:15:16] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1177468 (10Jhernandez) Plz review > (PS3) Jhernandez: Include collection image in html for sharing [extensions/Gather] - https://gerrit.wikimedia.org/r/200754 (https://phab... [11:19:00] hey phuedx [11:19:15] do you know what is this karma nonsense? https://integration.wikimedia.org/ci/job/mwext-Gather-qunit/124/consoleFull [11:19:29] locally I open http://127.0.0.1:8080/wiki/Special:JavaScriptTest/qunit?useformat=mobile&debug=true&hidepassed and all the tests pass [11:20:39] joakino: http://karma-runner.github.io/0.12/index.html [11:20:45] ye ye i know [11:20:49] infrastructure not running tests the same way we do? [11:20:52] but who uses that [11:20:52] \o/ [11:20:58] apparently jerkins [11:21:03] hmm seems like core runs qunit tests with that too [11:21:52] joakino: it looks like it's failing on a module definition [11:22:13] joakino: are you testing with debug enabled locally? [11:22:50] (03CR) 10Phuedx: [C: 032] Alpha: Improved search form for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) (owner: 10Bmansurov) [11:23:17] (03PS1) 10Jhernandez: Qunit core tests borked b/c missing resource dependency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201697 [11:23:24] phuedx: yes [11:23:30] maybe [11:23:33] no [11:23:43] but now yes and they pass to [11:23:44] too [11:24:08] go go power rangers [11:24:14] i mean, jerkins [11:25:31] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Improved search form for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) (owner: 10Bmansurov) [11:27:42] (03PS4) 10Phuedx: Alpha: Improved search form for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) (owner: 10Bmansurov) [11:27:43] phuedx: alright this fixes that https://gerrit.wikimedia.org/r/#/c/201697/ can u merge? [11:28:02] i'm guessing that in mobile settings was already there implicitly so there was no problem [11:28:11] the tests actually caught something :D [11:28:22] (03CR) 10Phuedx: [C: 032] Qunit core tests borked b/c missing resource dependency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201697 (owner: 10Jhernandez) [11:28:28] :D [11:28:29] thx! [11:28:59] i intensely dislike this manual dependency management [11:29:59] ➕💯 [11:30:51] (03Merged) 10jenkins-bot: Qunit core tests borked b/c missing resource dependency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201697 (owner: 10Jhernandez) [11:31:22] (03PS4) 10Jhernandez: Include collection image in html for sharing [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200754 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [11:31:59] (03PS2) 10Jhernandez: Tablet styles for Special:Gather/by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) [11:34:26] (03CR) 10Phuedx: [C: 032] Alpha: Improved search form for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) (owner: 10Bmansurov) [11:34:33] let's try this again jerkins [11:34:56] for most of today i've been listening to a spanish post-rock/metal band called toundra [11:35:01] and it's been a really good day [11:38:12] joakino: do you think we could just create 3 resource loader entry points (stable, beta, and alpha) and wire up a commonjs loader thingemy [11:38:24] (i've used requirejs, i'm not sure of the others) [11:38:53] JUST MERGE THE DAMNED PATCH JERKINS [11:39:04] that would be ideal IMO, but go implement commonjs parsing on php :( i don't think we can use node for these things [11:41:16] (03PS2) 10Jhernandez: Abuse the hook to add all icons to Minerva [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201592 (https://phabricator.wikimedia.org/T93813) (owner: 10Jdlrobson) [11:41:27] (03CR) 10Jhernandez: [C: 032] Abuse the hook to add all icons to Minerva [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201592 (https://phabricator.wikimedia.org/T93813) (owner: 10Jdlrobson) [11:41:50] (03Merged) 10jenkins-bot: Alpha: Improved search form for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201399 (https://phabricator.wikimedia.org/T94459) (owner: 10Bmansurov) [11:42:30] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1177490 (10Jhernandez) Had to change addModuleStyles to addModules to get it to work actually. But it seems to work now. (Patch is merging, ) can you confirm @jdlrobson? [11:44:22] (03Merged) 10jenkins-bot: Abuse the hook to add all icons to Minerva [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201592 (https://phabricator.wikimedia.org/T93813) (owner: 10Jdlrobson) [11:45:07] (03CR) 10Jhernandez: [C: 032] Add missing QQQ codes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201601 (https://phabricator.wikimedia.org/T94545) (owner: 10Jdlrobson) [11:45:36] 10Gather, 3Gather Sprint Enwiki, 7I18n, 5Patch-For-Review: missing qqq documentation for Gather - https://phabricator.wikimedia.org/T94545#1177501 (10Jhernandez) Thanks @amire80, patch is merging. [11:47:07] (03PS2) 10Jhernandez: Update watchstar correctly [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201604 (https://phabricator.wikimedia.org/T94508) (owner: 10Jdlrobson) [11:47:25] (03Merged) 10jenkins-bot: Add missing QQQ codes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201601 (https://phabricator.wikimedia.org/T94545) (owner: 10Jdlrobson) [11:47:44] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Watchstar doesn't reflect real status - https://phabricator.wikimedia.org/T94508#1177512 (10Jhernandez) @gerritbot is a delicate flower and wont link to patch if there is no new line before the line Bug:XXX .... [11:48:14] (03CR) 10Jhernandez: [C: 032] Update watchstar correctly [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201604 (https://phabricator.wikimedia.org/T94508) (owner: 10Jdlrobson) [11:50:35] (03Merged) 10jenkins-bot: Update watchstar correctly [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201604 (https://phabricator.wikimedia.org/T94508) (owner: 10Jdlrobson) [11:53:09] (03PS2) 10Jhernandez: Fix error handling for edit workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201594 (https://phabricator.wikimedia.org/T94106) (owner: 10Jdlrobson) [11:56:43] (03PS3) 10Jhernandez: Fix error handling for edit workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201594 (https://phabricator.wikimedia.org/T94106) (owner: 10Jdlrobson) [11:56:53] gonna go get some lunch [11:57:23] (03CR) 10Jhernandez: [C: 04-1] "Had typo" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201594 (https://phabricator.wikimedia.org/T94106) (owner: 10Jdlrobson) [11:58:32] (03CR) 10Jhernandez: [C: 032] "The -1 was for PS2... PS3 is fine." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201594 (https://phabricator.wikimedia.org/T94106) (owner: 10Jdlrobson) [12:00:43] (03Merged) 10jenkins-bot: Fix error handling for edit workflow [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201594 (https://phabricator.wikimedia.org/T94106) (owner: 10Jdlrobson) [12:10:12] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove empty anchor tag [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201589 (owner: 10Jdlrobson) [12:12:34] (03Merged) 10jenkins-bot: Hygiene: Remove empty anchor tag [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201589 (owner: 10Jdlrobson) [12:13:51] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1177575 (10Jhernandez) @jdlrobson I'd rather have the card wrapped in a link like with the collection card on the list of lists than do the JS... [12:15:37] (03CR) 10Jhernandez: [C: 04-1] "Needs more discussion (plz?)" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201590 (https://phabricator.wikimedia.org/T92664) (owner: 10Jdlrobson) [12:17:35] 10Gather, 3Gather Sprint Enwiki: Illustrations are flakey - https://phabricator.wikimedia.org/T94513#1177579 (10Jhernandez) Today testing the sharing-image I realized that it's like a on-off switch. Visit the page, gets an image, visit it again, it is removed... I'll investigate later. [12:39:56] 6Mobile-Web, 6operations, 3Mobile-Web-Sprint-44-R_________: Spike: figure out the simplest possible way to apply tags to a large group of articles on en wikipedia - https://phabricator.wikimedia.org/T94755#1177653 (10phuedx) I feel that the simplest solution would be storing the `serialize`d lists in files i... [12:50:53] 10Wikipedia-App-General-or-Unknown: Make Share-a-fact available on desktop - https://phabricator.wikimedia.org/T94998#1177668 (10Elitre) 3NEW [12:51:29] 10Wikipedia-App-General-or-Unknown: Make Share-a-fact available on desktop - https://phabricator.wikimedia.org/T94998#1177675 (10Elitre) [13:44:36] morning WMF, any Phoenix fans in the house? [13:47:44] yo [13:47:52] any phuedx fans in the house? [13:50:09] phuedx: i guess they have 4 letters in common—practically the same thing [13:50:24] that's exactly how it works [14:19:25] (03PS1) 10Phuedx: Hygiene: Make ResponseStore an interface [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201708 [14:45:04] (03CR) 10Phuedx: [C: 04-1] "See inline for a couple of minor minors." (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [14:51:44] a post-rock album about two foxes escaping from a burning forest [14:52:42] (03CR) 10Deskana: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 (owner: 10Deskana) [14:56:32] (03PS3) 10Deskana: Swap ordering of columns in GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 (https://phabricator.wikimedia.org/T94973) [15:01:38] 10Gather: Gather qunit tests broken - https://phabricator.wikimedia.org/T94975#1177964 (10Deskana) 5Open>3Resolved a:3Deskana Fixed by https://gerrit.wikimedia.org/r/#/c/201697/ [15:05:03] (03PS1) 10Phuedx: [WIP] Client-side face detection in lead images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201716 [15:05:17] Deskana, bgerstle, joakino ^ [15:05:20] i'm a monster [15:06:23] I looked at that and said to myself "Wow, how did he do that in so few lines of code?" [15:06:33] phuedx: did you see my response to the "lead image" thread? [15:06:34] Then I realised there are lines that are 20,000 characters long [15:06:49] Deskana: the power of uglification :-P [15:07:22] Deskana: as with most things we should be doing these days: i did the hard bit of wiring up one of the many existing solutions to problems we're trying to solve [15:07:25] :D [15:07:28] DEVELOPIN'!!! [15:07:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Client-side face detection in lead images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201716 (owner: 10Phuedx) [15:07:39] phuedx: HAHAHA [15:08:10] phuedx: jenkins right now: http://i.imgur.com/8knRayb.gif [15:08:37] wow [15:08:45] he likes that sign a lot [15:08:49] lol [15:08:59] yeah, i probably shouldn't make jerkins do face detection in javascript [15:09:13] nevertheless, you guys wanna know how long that took me to do? do you? [15:09:17] want me to tell you? [15:09:21] because i will [15:09:23] clearly you want us to hear it [15:09:23] i'll tell you [15:09:29] PLEASE PHUEDX ENLIGHTEN US [15:09:31] i'll tell you right now if you want me to [15:09:42] well i typed "javascript face detection" into google [15:10:03] phuedx only if you express the time in archaic units [15:11:28] http://lmgtfy.com/?q=javascript+face+detection [15:12:51] i read the docs for a few libraries [15:12:57] downloaded tracking.js master [15:13:04] extracted it [15:13:17] battled with our resource loader modules for a little while [15:13:21] .... [15:13:23] anyway [15:13:29] bgerstle: 225000 atomus [15:13:50] an atomus is, apparently, the twinkling of an eye [15:14:25] phuedx: 👍 [15:14:34] phuedx: Deskana seriously though, can we add that button? [15:14:39] the "this image looks bad" button [15:14:48] doo it [15:14:51] instead of talking about face detection and cropping methods? [15:14:58] we can add the button in the browser too :D [15:15:02] unless we're just gonna go ahead and solve the problem, which i also think is fine [15:15:09] phuedx: but does the browser have this problem? [15:15:14] i guess you do in gather, but not in the article view [15:15:30] bgerstle: on beta -- yes [15:15:31] but yeah, whatever is the cheapest way to quickly get data on the extent of this problem [15:15:48] IMO we should do it in apps because i think it will be particularly prevalent there [15:15:49] and i think if we want to move lead images out of beta then we're going to have an ok approach [15:16:01] bgerstle: sure [15:16:19] you've got the larger reach atm -- i'm just saying, we can help :) [15:17:16] phuedx: i don't see any reason it should all be done in parallel [15:17:24] i mean, they can even be the same event in EventLogging [15:17:47] all we want to know is, how many times does a user encounter an image is bad enough that they want to make it better? [15:18:10] does that number get sufficiently decreased by using facial detection? [15:18:44] if not, let's explore other ways to improve the situation, and measure the improvement with metrics! [15:18:56] wait [15:19:01] hold on [15:19:26] if we do that we might know what impact our potential solutions are having [15:19:35] sorry, i'm just now coming off an acid trip and re-reading what i wrote. it's clearly the talk of a crazy person. [15:25:17] phuedx: awesome hahaha [15:25:34] bgerstle: that's my favourite gif as of today, close to wining the internet [15:25:58] joakino: lol the "bilbo's bird" gif? [15:26:08] i was pretty happy when i found it [15:27:02] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1178005 (10Jdlrobson) So I did a bit more research and hidden image only works for Facebook... There is an interesting thread on wikitech about exposing og:image meta tag ... [15:31:35] gahh [15:32:02] i don't know the proper term, but how do put an "info" callout/sidebar/box in a MW article? [15:34:40] bgerstle: black magic, you don't want to know [15:34:48] this is a pretty cool collection :D https://en.m.wikipedia.org/wiki/Special:Gather/by/Bd808/227 [15:35:29] changing cities, I'll be back in a couple of hours [15:35:34] Is it intended that GatherLists only displays 10 collections? [15:35:54] Deskana: nope, we got pagination in place but need to redeploy [15:36:01] in fact it is a big concern [15:36:02] joakino: Ah, cool. [15:36:18] gonna walk to the shop to get cake ingredients [15:41:21] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: article content not equal in landscap and normal mode in latest alpha 31.3.15 - https://phabricator.wikimedia.org/T94853#1178020 (10Dbrant) a:3Dbrant [16:18:09] mholloway: Morning, sir! [16:18:23] mholloway: I filed a bug last night that might be a good one for you to take a look at: https://phabricator.wikimedia.org/T94974 [16:19:07] 10Wikipedia-App-Android-App: Search should be hidden from the Saved Pages and History sections of the app if there are no saved pages or history entries - https://phabricator.wikimedia.org/T94974#1178125 (10Deskana) [16:19:46] Deskana: ^ yes! i was just about to suggest it, too [16:20:09] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-54-iOS: [EPIC] Provision Mac mini as iOS build server - https://phabricator.wikimedia.org/T91786#1096336 (10BGerstle-WMF) [16:20:11] 10Wikipedia-App-iOS-App, 3Mobile-App-Sprint-54-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1178133 (10BGerstle-WMF) [16:23:32] good call [16:24:59] bearND: Good job with this, by the way: https://phabricator.wikimedia.org/T94853 [16:25:02] bearND: I totally misunderstood him. [16:26:00] Thank you, Sir! I'm glad dbrant is taking care of it. [16:30:48] (03CR) 10Jdlrobson: [C: 032] "GTD" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200030 (https://phabricator.wikimedia.org/T93786) (owner: 10Bmansurov) [16:32:21] (03CR) 10Jdlrobson: [C: 032] "Seems a good idea" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 (https://phabricator.wikimedia.org/T94973) (owner: 10Deskana) [16:32:33] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: GatherLists first column should be collection name, not author - https://phabricator.wikimedia.org/T94973#1178172 (10Jdlrobson) [16:33:32] (03CR) 10Jdlrobson: Abuse the hook to add all icons to Minerva (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201592 (https://phabricator.wikimedia.org/T93813) (owner: 10Jdlrobson) [16:33:36] (03Merged) 10jenkins-bot: Ignore multicolumn layouts on small devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200030 (https://phabricator.wikimedia.org/T93786) (owner: 10Bmansurov) [16:34:50] (03Merged) 10jenkins-bot: Swap ordering of columns in GatherList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201665 (https://phabricator.wikimedia.org/T94973) (owner: 10Deskana) [16:36:04] jdlrobson, hi, have you had a chance to review image patch? [16:36:50] (03PS1) 10Fjalapeno: Fix the build - scheme were pointing to the wrong config [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201726 [16:37:13] bgerstle dr0ptp4kt ^ quick review to fix the build [16:37:28] mhurd: ^ [16:37:32] 10Gather, 3Gather Sprint Enwiki: Icon styles loaded twice on Gather special pages - https://phabricator.wikimedia.org/T95014#1178208 (10Jdlrobson) 3NEW [16:37:46] yurik: today, my plan is to focus on image stuff since there is a bug that needs fixing and it is a good excuse [16:37:52] yurik: did you get my email about bugs we've found? [16:38:07] jdlrobson, yes, haven't had a chance t owork on them though - busy with zero [16:38:13] can you try to repo it with a unit test? [16:38:24] yurik: yeh i assumed i just wanted to check you were following the Gather board still [16:38:25] (03CR) 10Dr0ptp4kt: [C: 032] Fix the build - scheme were pointing to the wrong config [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201726 (owner: 10Fjalapeno) [16:38:33] ^ coreyfloyd [16:38:36] if you poke the bugs I know :) [16:38:45] coreyfloyd: do you have hotword detection on 'Fjalapeno'? [16:38:47] for irc/ [16:38:47] yurik: yeh i'm sure i can get some unit tests on those to help fix them if necessary [16:38:52] thx [16:38:56] dr0ptp4kt: yep [16:39:02] would help and would also be a good way to check that they got fixed ) [16:39:14] coreyfloyd: thx [16:39:20] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1178222 (10Jdlrobson) @jhernandez see T95014 [16:39:25] with autoimage i expect issues, haven't figured out a good way to test yet [16:39:45] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1178225 (10Jdlrobson) 5Open>3Resolved [16:40:05] yurik: yeh it's complicated gonna have to take a close look at how you see it working ;) [16:40:31] coreyfloyd: bgerstle, what's the current state for github related things with respect to the ios wikipedia repo? i'm writing an email about gerrit, github, and differential / arcanist to mobile-tech [16:41:06] dr0ptp4kt: merging GH PR's through gerrit is too painful [16:41:11] w/o squashing, i mean [16:41:28] and squashing means you have to manually close the PR anyway [16:41:36] at this point i'm thinking that it's essentially all-or-nothing [16:42:30] dr0ptp4kt: thats actually one of the things we i wanted to talk about today - during code review or tech backlog [16:42:59] bgerstle: coreyfloyd, would you like me to hold off sending the email until we've talked? [16:43:08] dr0ptp4kt: yeah if its ok [16:43:33] coreyfloyd: no problem here. i'll email the draft to you guys and then we can discuss further so that the email is more useful to other mobile-tech users. [16:44:46] 6Mobile-Web, 5Patch-For-Review: Multiple column layouts should be ignored on mobile - https://phabricator.wikimedia.org/T93786#1178236 (10bmansurov) 5Open>3Resolved [16:44:48] (03CR) 10Jdlrobson: [C: 04-1] Tablet styles for Special:Gather/by/User (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [16:45:35] (03CR) 10Jdlrobson: "Also remind me to talk to you about https://gerrit.wikimedia.org/r/#/c/129032/ at some point" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [16:47:57] 6Mobile-Web, 10MobileFrontend: MobileFrontend's Special:EditWatchlist has red links and I'm not sure why - https://phabricator.wikimedia.org/T94966#1178243 (10Jdlrobson) [16:47:59] 6Mobile-Web: Infinite scrolling Special:EditWatchlist on mobile incorrectly identifies pages as not existing. - https://phabricator.wikimedia.org/T94505#1178244 (10Jdlrobson) [16:48:15] 6Mobile-Web: Infinite scrolling Special:EditWatchlist on mobile incorrectly identifies pages as not existing. - https://phabricator.wikimedia.org/T94505#1165345 (10Jdlrobson) [16:50:34] 10MobileFrontend-Feature-requests, 6WMF-Design, 7Design: Summary of activity at the top of mobile history page - https://phabricator.wikimedia.org/T94297#1178265 (10Jdlrobson) [16:50:54] 10MobileFrontend-Feature-requests, 6WMF-Design, 7Design: Summary of activity at the top of mobile history page - https://phabricator.wikimedia.org/T94297#1159198 (10Jdlrobson) It's a good idea. Designers what do you think? [16:55:40] dr0ptp4kt: thanks for the merge [16:56:49] coreyfloyd: yw [16:57:55] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Blue tutorial indicator positioned incorrectly in Chrome when pointing at a transformed element e.g. green watchstar - https://phabricator.wikimedia.org/T93987#1151840 (10Jdlrobson) [16:58:46] vibha: Have you seen my comment on https://phabricator.wikimedia.org/T94936? [17:00:23] (03PS3) 10Jdlrobson: Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 [17:03:07] phuedx [17:03:13] stand with us in solidarity [17:03:26] kristenlans: sec [17:04:09] Deskana: excellent, looking now. [17:04:29] phuedx 5.5 GBP [17:06:39] 10Wikipedia-App-Android-App: Search should be hidden from the Saved Pages and History sections of the app if there are no saved pages or history entries - https://phabricator.wikimedia.org/T94974#1178298 (10Mholloway) a:3Mholloway [17:07:00] bearND: yes! I have a follow up question about landscape mode for the banner asset [17:08:07] bearND: Will follow up soon on the banner image task. [17:12:46] vibha: good [17:13:19] vibha: is irc cloud treating you well so far? [17:14:08] (03PS3) 10Mhurd: Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 (owner: 10Fjalapeno) [17:14:16] coreyfloyd: ^ rebased it [17:14:30] coreyfloyd: testing... oh wait, standup [17:15:45] as i said in stand up -- i'm going to head off a little early to do some baking with george [17:15:49] <3 [17:15:54] have a lovely weekend folks [17:16:04] i'll probably be around during [17:16:17] (03PS1) 10BearND: ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201732 [17:16:20] (making double chocolate carrot and walnut brownies) [17:16:23] (nom) [17:18:14] phuedx, re "now to actually test it" - that's what I've been doing yesterday and will continue today [17:20:36] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: Search should be hidden from the Saved Pages and History sections of the app if there are no saved pages or history entries - https://phabricator.wikimedia.org/T94974#1178319 (10Mholloway) [17:23:03] (03PS2) 10Jdlrobson: Redo watchstar creation so inside container [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) [17:25:19] (03CR) 10jenkins-bot: [V: 04-1] Redo watchstar creation so inside container [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) (owner: 10Jdlrobson) [17:26:22] (03PS3) 10Jdlrobson: Redo watchstar creation so inside container [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) [17:27:59] dbrant: Forgot to mention some patches I wrote for the WP logo in ShareAFact, ready for CR. [17:28:29] bearND: yep, will look [17:28:37] dbrant: ty [17:30:26] Deskana|Away: I assum you will want a SPritn 55 board for story prior meetign today? [17:30:42] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: OutOfMemoryError in commonSectionFetchOnCatch - https://phabricator.wikimedia.org/T94700#1178362 (10bearND) Should be rechecked since https://gerrit.wikimedia.org/r/#/c/197346/ is merged now. [17:32:23] 10Wikipedia-App-Android-App, 3Mobile-App-Sprint-54-Android: NPE from inside savedpages.RefreshPagesHandler call in savedpages.SavedPagesFragment.refreshSelected - https://phabricator.wikimedia.org/T94435#1178369 (10bearND) a:3bearND [17:33:39] 10MobileFrontend-Feature-requests, 10Wikidata: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1178373 (10Ricordisamoa) [17:33:48] 10Gather: bug: funky scroll on add to collection overlay - https://phabricator.wikimedia.org/T95018#1178380 (10JKatzWMF) [17:33:59] kristenlans: Yes please! [17:36:43] Deskana: iOS https://phabricator.wikimedia.org/project/board/1164/ [17:36:50] 10Gather: GatherLists table should not simply be a totally empty if there are no collections - https://phabricator.wikimedia.org/T94972#1178388 (10Deskana) p:5Triage>3Lowest Practically this will never be empty unless it's a totally new wiki. Given that this is (right now) being developed explicitly for Wiki... [17:37:36] Deskana: Android https://phabricator.wikimedia.org/project/board/1165/ [17:38:39] 10Gather, 3Gather Sprint Enwiki: Special:GatherLists should use views and models - https://phabricator.wikimedia.org/T93422#1178391 (10Jdlrobson) a:3Jdlrobson [17:39:42] kristenlans: Thank you! [17:41:00] Deskana, can I ask you questions about the iOS app? [17:41:14] There are 262 open tickets with no one really responding to them [17:43:05] 6Mobile-Web, 6Services: Image-positioning service - https://phabricator.wikimedia.org/T88633#1178401 (10kaldari) I like Brion's idea of implementing this as a parser function (at least until Commons has some solution for storing image metadata). [17:44:31] Deskana: where can i find the most up to date info on logging to our analytics servers and seeing the event logging streams ? [17:45:04] tfinc: https://www.mediawiki.org/wiki/Extension:EventLogging/Guide may help [17:45:10] tfinc: I'm not sure how up to date it is... [17:45:56] tfinc: Also... [17:46:06] Deskana: that doesn't seem to capture where the data actually lives [17:46:35] tfinc: https://phabricator.wikimedia.org/T95019 [17:46:56] tfinc: Yes, I have no idea about any of that. I'd suggest reaching out to Kevin. [17:47:00] Krenair: Absolutely! [17:51:02] Deskana: thanks for the link. i'll comment [17:54:54] I can't find the bug for stripping brackets from first sentences. Does anyone know where it is? [17:54:59] bearND, dbrant ^ [17:55:15] bearND, dbrant: Got it, never mind. [17:57:24] Deskana: I'm going to change the title of that one [17:57:40] Deskana, Is it available in the UK store? [17:57:58] Krenair: It should be available everywhere. [17:58:20] ok... interesting [17:59:30] Deskana, would it work on iOS 5.1.1? [18:05:21] fyi mhurd here's the link to the attributed string docs https://developer.apple.com/library/ios/documentation/UIKit/Reference/NSAttributedString_UIKit_Additions/#//apple_ref/doc/constant_group/Document_Types [18:08:41] kristenlans: https://phabricator.wikimedia.org/T94630#1176767 [18:16:59] (03PS10) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [18:17:10] (03PS9) 10Mhurd: Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 [18:17:47] bmansurov: where’s an example of a button with a spinner in it I can look at? [18:18:00] kaldari: error report module that you did [18:18:11] thanks! [18:22:34] MaxSem, kaldari: how can I do a batch db update in php? any links? [18:25:00] bmansurov: There are some examples in various maintanence scripts in the maintanence dir [18:25:12] kaldari: ok thanks [18:25:27] bmansurov: like updateRestrictions.php [18:25:34] great [18:25:45] (03PS1) 10Jdlrobson: Hygiene: Introduce ReportTableRow view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201744 [18:25:47] (03PS1) 10Jdlrobson: Make Special:GatherLists render through a view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201745 (https://phabricator.wikimedia.org/T93422) [18:26:29] 3Gather Sprint Enwiki, 3Mobile Web Design: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1178621 (10Jdlrobson) @MSyed ping. [18:27:38] 3Gather Sprint Enwiki, 3Mobile Web Design: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1178635 (10MSyed) @Jdlrobson Will provide mock by today [18:28:22] bgerstle: would it be ok to revisit your comments on https://gerrit.wikimedia.org/r/#/c/200280 as follow-ons later? [18:28:33] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce ReportTableRow view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201744 (owner: 10Jdlrobson) [18:28:39] (03CR) 10jenkins-bot: [V: 04-1] Make Special:GatherLists render through a view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201745 (https://phabricator.wikimedia.org/T93422) (owner: 10Jdlrobson) [18:28:54] mhurd i'd have to see which ones are left after your amendments [18:29:23] bgerstle: i amended to use category as both you and corey recommended. i think that's it [18:30:10] mhurd what about my comment on prepareForReuse? [18:31:48] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1178643 (10MSyed) I agree with @Jhernandez, lets wrap the cards with a link. [18:32:26] bgerstle: ah will amend [18:33:59] * jdlrobson heads for lunch [18:35:00] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1178645 (10MSyed) I made two more gifs... one of how we're doing card links and another of how we did them on How Wrong You Are. The entire c... [18:36:20] mhurd dr0ptp4kt coreyfloyd getting lunch [18:38:25] mholloway: Hi Michael, Since you are in the office next week. Can I re-schedule our 1:1 around design process for next week? [18:38:41] vibha: sure! [18:38:43] Doing this in person would be rad [18:38:45] cool cool [18:42:27] bgerstle: mhurd dr0ptp4kt : https://github.com/KrauseFx/fastlane/issues/176 [18:42:30] may try to fix it later [18:45:32] https://phabricator.wikimedia.org/T94646 [18:46:02] bearND: https://phabricator.wikimedia.org/T94646 [18:46:06] bearND: https://trello.com/c/p8PJu3d1/113-use-a-higher-res-image-if-available-and-set-it-to-the-width-of-the-column-text [18:46:56] (03PS11) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [18:47:48] (03CR) 10Mhurd: Added wikidata descriptions to saved pages entries. (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [18:48:18] bgerstle: coreyfloyd ^ amended to address some of brian's comments [18:48:48] (03PS1) 10Fjalapeno: Fix build [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201749 [18:49:00] mhurd: bgerstle dr0ptp4kt ^ [18:49:04] coreyfloyd: why not just fix it? :-P [18:49:19] bgerstle: as soon as our shit is fixed [18:49:21] (03CR) 10Bgerstle: [C: 032] Fix build [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201749 (owner: 10Fjalapeno) [18:49:29] i hear ya, just teasing [18:51:02] coreyfloyd: bgerstle should i merge https://gerrit.wikimedia.org/r/#/c/201749/ ? [18:51:15] coreyfloyd: bgerstle i see brian +2'ed it [18:51:37] mhurd sorry i guess i should've +1'd [18:51:41] bgerstle: This patch is in the stalled state, btw: https://gerrit.wikimedia.org/r/#/c/201239/ [18:51:43] it's still weird that i don't see "submit" button [18:51:47] bgerstle: You gave it +2 but it's not merged yet [18:51:53] Deskana: because i can't merge [18:51:58] (see above) [18:51:59] bgerstle: If you want to test it a bit more. [18:52:11] Deskana: ask mhurd or dr0ptp4kt to merge, i already +1'd [18:52:37] (03PS2) 10Mhurd: Fix a typo in AppDelegate.m [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201239 (owner: 10Deskana) [18:52:43] (03CR) 10Mhurd: [C: 032] Fix a typo in AppDelegate.m [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201239 (owner: 10Deskana) [18:52:47] bgerstle: Oh, I can finalise it myself, that's fine. I just wanted to tell you in case you wanted to take a look, I thought you mentioned you did. [18:52:51] CODE REVIEW +4 [18:52:54] lol [18:52:55] lol [18:53:14] (03PS2) 10Mhurd: Fix build [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201749 (owner: 10Fjalapeno) [18:53:14] Deskana: you don't remember i -1'd it as an April Fool's :-P [18:53:31] (03CR) 10Mhurd: [C: 032] Fix build [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201749 (owner: 10Fjalapeno) [18:53:39] MERGEITSHIPIT! [18:55:19] (03CR) 10Mhurd: [C: 04-1] "Let's abandon this for now based on my earlier comments." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/197437 (owner: 10Nirzar) [18:55:48] (03PS12) 10Mhurd: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 [18:56:42] coreyfloyd: did you have another amending planned for "Create environment specific icons at build time" or should i review now? [18:58:43] mhurd: you can review test… -save your +1 until i get with brian [19:00:18] coreyfloyd: mhurd dr0ptp4kt wrapping up lunch, be in the meeting in a sec [19:09:15] 6Mobile-Web, 10Wikimedia-Extension-setup: Deploy CodeMirror extension to beta labs - https://phabricator.wikimedia.org/T95041#1178819 (10Florian) 3NEW [19:09:35] jdlrobson: ^ :) [19:15:03] (03PS12) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [19:15:43] (03CR) 10Florianschmidtwelzow: "ping? :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 (owner: 10Florianschmidtwelzow) [19:17:27] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [19:21:25] ... Why do I not get an edit button on the main page? [19:21:29] FlorianSW [19:21:58] I seem to get it on other pages I can edit. Just not the main page [19:22:39] Krenair: we don't support editing on main page :) (we doesn't touch the whole main page at all, main pages are special handled, because they are "special" ;)) [19:22:57] Krenair: you don't have collapsed sections, too [19:23:04] whaaaat [19:23:16] The Main Page is special in a few ways with regard to deletion. But editing? [19:23:22] No [19:24:30] it is, unfortunately. Let me look, if we have a task for it (i remember, that we have one) [19:25:41] Krenair: ah, yap, see: https://phabricator.wikimedia.org/T32405 [19:38:08] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add Swipe module and use it in ImageOverlayNew (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [19:38:50] FlorianSW, does MF do anything weird with the 'user' module? [19:39:04] Krenair: yap, adding some stuff [19:39:14] or 'site' [19:39:33] Krenair: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/user.js [19:39:36] because VE's new TargetLoader requires them to work. But they do not appear to be registered if I switch to minerva? [19:39:42] or what do you mean? [19:40:01] well "new" [19:40:03] do they have target mobile? [19:41:07] (03PS7) 10Florianschmidtwelzow: Add Swipe module and use it in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 [19:41:22] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1178872 (10Jdlrobson) We can't link a link within a link so if we do it this way we'll have to rethink the styling of the read more anchor to... [19:41:53] FlorianSW, ah... no [19:42:01] Krenair: :) [19:42:16] these are MW core modules, ResourceLoaderSiteModule and ResourceLoaderUserModule [19:42:29] both inherit from ResourceLoaderModule which is just: protected $targets = array( 'desktop' ); [19:42:38] (03PS4) 10Florianschmidtwelzow: Hygiene: Align watchstars correctly in SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) [19:42:47] (from ResourceLoaderModule) [19:43:26] ok, thanks FlorianSW [19:43:38] Krenair: ah, you mean these modules :) I thought you mean mw.user :) np :P [19:43:43] no [19:43:56] Deskana dbrant Krenair: hmmm, lots of reports of "no internet" error on play store review today. [19:44:04] that's actually mediawiki.user [19:45:41] bearND: Good catch. One user mentioned 4.4.2. Do you have a 4.4.2 device? [19:45:45] dbrant, mholloway ^ [19:46:24] don't have one [19:46:27] Deskana: nope, 4.4.4 here [19:46:41] mholloway: Can you test the production app on it to make sure everything's working? [19:46:47] mholloway: Browse around a few pages, and such? [19:46:49] mholloway: close enough [19:47:00] sure [19:47:24] i hope it's not another okhttp issue... [19:47:44] i've been on it a few times today without issues, but i'll play with it [19:47:52] Krenair: dbrant: mholloway: Deskana: I think this is related [19:47:54] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=8153383 [19:48:15] mholloway: Do you have access to OTRS? [19:48:39] Wasn't there an API outage earlier? [19:48:41] for like 20 minutes? [19:48:44] bearND: i don't believe so [19:48:47] that would cause the apps to be completely dead [19:49:22] https://wikitech.wikimedia.org/wiki/Incident_documentation/20150403-API [19:49:33] (03PS2) 10Jdlrobson: Hygiene: Introduce ReportTableRow view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201744 [19:50:01] I already saw one of these tickets from the android app, sent right after the outage. Just told them stuff was broken at that time and asked if they could try again [19:50:01] (03PS2) 10Jdlrobson: Make Special:GatherLists render through a view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201745 (https://phabricator.wikimedia.org/T93422) [19:52:03] 10Gather, 3Gather Sprint Enwiki: Illustrations are flakey - https://phabricator.wikimedia.org/T94513#1178898 (10Jdlrobson) a:3Jdlrobson [19:52:18] bearND, mholloway: someone will be dealing with that access problem... think managers need to be emailed [19:52:41] (03CR) 10jenkins-bot: [V: 04-1] Make Special:GatherLists render through a view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201745 (https://phabricator.wikimedia.org/T93422) (owner: 10Jdlrobson) [19:53:41] jdlrobson, hey [19:53:46] you around? [19:53:51] Krenair: Thank you. I was not aware of the access issue. So, I hope it's just temporary. Is it fixed already, since I can't repro? (cc: Deskana dbrant mholloway) [19:54:03] 10Gather, 3Gather Sprint Enwiki: Illustrations are flakey - https://phabricator.wikimedia.org/T94513#1178905 (10Jdlrobson) $collection->getFile() sometimes returns null. Investigating. [19:54:18] the API issue, you mean? :p [19:54:27] it was just temporary. see the incident documentation link I posted [19:54:37] it was on the ops list [19:55:10] Krenair: Someone reported this issue a few hours ago, though. [19:55:19] Krenair: Sorry, missed that. Got it now [19:55:32] bearND: No luck reproducing here either. /cc: Deskana bearND dbrant [19:55:49] (sorry, I'm attempting to have about 3 different conversations on the same channel here) [19:55:52] yeah, most likely related to the outage :( [19:56:06] Deskana, ok... how many hours? [19:56:25] Krenair: Wait, no, I misunderstood what he said. [19:56:33] :) [19:56:58] (03CR) 10Dbrant: [C: 032] ShareAFact: use static image for English WP wordmark [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201641 (https://phabricator.wikimedia.org/T94760) (owner: 10BearND) [19:58:04] bearND: as for OTRS access, I'm meeting with Tomasz in half an hour or so, should I mention it to him? /dbrant Krenair [19:59:41] Deskana is the one who's usually involved with that queue, I don't think tfinc is [20:00:12] mholloway: ^ [20:00:27] k [20:02:31] coreyfloyd: dr0ptp4kt bgerstle i'm back! [20:02:53] mhurd: welcome back [20:03:21] dr0ptp4kt: all fixed [20:06:13] mhurd: good :-) [20:06:16] (03PS1) 10Jdlrobson: Don't go flaking my heart on images [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201831 (https://phabricator.wikimedia.org/T94513) [20:06:38] mhurd i'm going to do a quick table-ization of the source code stuff we discussed, then send it out to you guys for further review while i go back to reviewing your patch [20:06:39] sound ok? [20:07:00] 10Gather, 3Gather Sprint Enwiki: Deleted entries in Watchlist show up in Gather lists - https://phabricator.wikimedia.org/T94847#1178940 (10Jdlrobson) [20:11:42] Deskana, bearND https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8259661 [20:12:07] I screwed up the response slightly and wrote "the API" instead of "the app" [20:15:42] 10Gather: bug: funky scroll on add to collection overlay - https://phabricator.wikimedia.org/T95018#1178959 (10Jdlrobson) Mmm.. scrolling shouldn't be possible at all when open. Which version of iOS is this? [20:15:48] (03PS5) 10Florianschmidtwelzow: Hygiene: Align watchstars correctly in SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) [20:15:56] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: GatherLists first column should be collection name, not author - https://phabricator.wikimedia.org/T94973#1178960 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [20:16:44] 10Gather: GatherLists table should not simply be a totally empty if there are no collections - https://phabricator.wikimedia.org/T94972#1178963 (10Jdlrobson) We're also not sure about the future of this page but yeah at some point we'll want to look at this. [20:17:53] 10Gather: Gather should explain to users why they're required to log in if they go to Special:Gather or Special:GatherLists - https://phabricator.wikimedia.org/T94971#1178966 (10Jdlrobson) [20:17:55] 10Gather: Login page is not showing our custom i18n messages - https://phabricator.wikimedia.org/T90684#1178965 (10Jdlrobson) [20:18:27] 10Gather: Gather should fail more gracefully if MobileFrontend is not installed - https://phabricator.wikimedia.org/T94969#1176921 (10Jdlrobson) Related: T94100 [20:19:53] vibha: so the twitter error resolved itself? [20:20:58] 10Gather: Special:Gather uses "articles" instead of "pages" or a more generic term - https://phabricator.wikimedia.org/T94967#1178977 (10Jdlrobson) Yeh this is an oversight. [20:21:14] (03PS1) 10Jdlrobson: i18n: articles -> pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201837 (https://phabricator.wikimedia.org/T94967) [20:21:25] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Special:Gather uses "articles" instead of "pages" or a more generic term - https://phabricator.wikimedia.org/T94967#1178981 (10Jdlrobson) [20:21:59] 10Gather, 3Gather Sprint Enwiki, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1178985 (10Jdlrobson) [20:23:14] (03CR) 10Florianschmidtwelzow: [C: 031] i18n: articles -> pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201837 (https://phabricator.wikimedia.org/T94967) (owner: 10Jdlrobson) [20:24:34] jdlrobson, hi [20:24:52] hey Krenair saw your bug about exception about to take a look at it [20:25:05] cool, thanks [20:25:18] I actually came to ask you about some VE-MF issues [20:25:38] MobileFrontend does not expect 'site' and 'user' to be loaded, right? [20:26:05] (the MW core RL modules) [20:26:20] correct. MobileFrontend has some equivalents [20:26:23] mobile.user and mobile.site [20:26:36] what's happening? [20:26:40] right. in some newer VE code we try to load those modules [20:26:43] and they're not going to work in mobile [20:26:47] so we need to fix that [20:27:14] 10Gather, 7Mobile: Article opened on Safari brower via iPhone froze app - https://phabricator.wikimedia.org/T94923#1179001 (10Jdlrobson) Hi @Rdicerb sorry to hear this. Could you do me a favour and check if http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=beta exhibits the same problem? I sus... [20:27:26] (this is why mobile ve is broken in even group2 wikis at the moment) [20:27:33] (at least, part of why) [20:27:48] (03PS1) 10Jdlrobson: Debounce resize events [extensions/MobileFrontend] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201840 (https://phabricator.wikimedia.org/T93988) [20:29:22] Krenair: why do you load those modules? [20:29:35] (03PS4) 10Bmansurov: Filter out retired WikiGrok tags from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) [20:29:49] Why do we try to load these separately anyway? [20:29:49] Well the theory is that they could fail and we don't want to be held up by that [20:29:49] In practice they don't fail but just stay pending forever instead, that's a bug in RL [20:29:54] common.js and common.css are completely incompatible with the mobile skin. [20:29:59] they cause JS issues all over the place [20:30:09] and css regressions [20:30:13] they do fail in practice [20:30:22] also they bump up the page load drastically [20:31:37] Will work with Roan to make sure we don't attempt to load those under mobile targets. Thanks jdlrobson [20:31:58] mholloway: going to restart to pickup my camera [20:32:00] yeh the targets stuff is a pain but there's reason behind all the madness [20:32:10] tfinc: ok [20:32:31] https://www.mediawiki.org/wiki/Requests_for_comment/Allow_styling_in_templates will unblock a lot of the targets stuff (at least for css) [20:33:14] coreyfloyd: bgerstle batcave? [20:33:38] 10Gather: Special:Gather collection page counts should use number separators - https://phabricator.wikimedia.org/T94968#1179024 (10Jdlrobson) Reasoning? Is this an i18n issue for example? [20:34:12] 10Gather, 3Gather Sprint Enwiki, 7Browser-Tests: Styles not alway loading - https://phabricator.wikimedia.org/T94891#1179027 (10Jdlrobson) [20:34:20] mhurd yeah be there in ajiff [20:34:27] 10Gather, 3Gather Sprint Enwiki, 7Browser-Tests, 7Jenkins: Browser tests failing regularly due to styles not alway loading - https://phabricator.wikimedia.org/T94891#1179029 (10Jdlrobson) [20:34:33] Deskana: it will probably worth it to spend a bit of time on getting more accurate errors to present to the user. [20:35:42] there is a big difference between no connection, timeout, and server temporarily not available and other server errors. [20:35:46] 10Gather: A user visiting a list via the collections screen generates the event "view_list" - https://phabricator.wikimedia.org/T91018#1179039 (10Jdlrobson) 5Open>3declined a:3Jdlrobson [20:36:44] giving users different dialogs for those 4 different situations will probably pay off, because they will be able to put the blame better (connection, app, server). saving you from those negative reviews [20:37:36] 10Gather: A user visiting a list via a url/share is tracked measured...(either EL or traditional pageview) - https://phabricator.wikimedia.org/T91019#1179044 (10Jdlrobson) Does any work need to be done to make this possible? Can we use traditional page views here (EL won't work here since the event originates fr... [20:37:41] 6Mobile-Web, 10MobileFrontend, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1179045 (10Krenair) 3NEW a:3Krenair [20:37:58] bgerstle: coreyfloyd https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [20:38:00] 6Mobile-Web, 10MobileFrontend, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1179055 (10Krenair) [20:38:11] 10Gather: Track when user clicks on article from collection - https://phabricator.wikimedia.org/T90998#1179056 (10Jdlrobson) Would page views suffice for this sort of thing? Please close as declined if so, if not please expand the card. [20:39:42] 10Gather: A list creator is able to designate a list as hidden (which means it can only be viewed by someone with the specific url), to prevent the general public from seeing it on their profile, etc. - https://phabricator.wikimedia.org/T91039#1179059 (10Jdlrobson) So this is a more specific form of sharing - sh... [20:39:58] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1179060 (10MSyed) @Jdlrobson You're right. We can take the "read more" links out. I'm attaching the mocks here for how cards will look like... [20:42:40] bmansurov, do you need help testing https://gerrit.wikimedia.org/r/#/c/201071 ? [20:42:50] because it doesn't seem to be able to work:) [20:42:51] 3Gather Sprint Enwiki, 3Mobile Web Design: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1179071 (10MSyed) Heres a mock for how the spinner will show in the button. If we dont have a transparent spinner like the one in the mock, I can make a gif spinner if you w... [20:43:11] MaxSem: yes, and code review would be nice, it's getting complicated [20:44:38] 10Gather, 3Gather Sprint Enwiki, 7Mobile: Article opened on Safari brower via iPhone froze app - https://phabricator.wikimedia.org/T94923#1179099 (10Jdlrobson) [20:45:35] jdlrobson: sorry about the mobilefrontend doc publishing :/ [20:45:49] jdlrobson: went at the end of the backlog ! [20:48:45] (03PS1) 10Alex Monk: VisualEditorOverlay: Call TargetLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201843 (https://phabricator.wikimedia.org/T95044) [20:48:59] (03CR) 10MaxSem: [C: 04-1] Filter out retired WikiGrok tags from WikiGrok pages (039 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [20:49:32] (03PS3) 10Jdlrobson: Make Special:GatherLists render through a view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201745 (https://phabricator.wikimedia.org/T93422) [20:50:30] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Align watchstars correctly in SearchOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [20:52:04] bmansurov, ok. so did you try to get the pipeline to work without your patch and repro the problem? [20:52:32] MaxSem: no, the last time I checked aggregation was causing a backend error [20:54:26] 10Gather, 3Gather Sprint Enwiki, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1179133 (10Jdlrobson) Have been trying to troubleshoot this but can't on master. Could this be something to do with single user login? Is this happening often in the logs @krenair? [20:55:21] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1179146 (10Jdlrobson) @msyed ^ [20:56:58] (03CR) 10Bmansurov: Add Swipe module and use it in ImageOverlayNew (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [20:57:02] 10Gather, 3Mobile Web Design: No way to moderate a certain collection from the collection itself - https://phabricator.wikimedia.org/T94228#1179151 (10Jdlrobson) [20:58:45] (03PS13) 10Bgerstle: Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [20:58:51] 10Gather, 3Gather Sprint Enwiki, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1179169 (10Krenair) No, it only happened 16 times. >>! In T94965#1176894, @MZMcBride wrote: > it said the user account didn't exist. But on refresh, it's now showing user profi... [20:59:05] 10Gather: User A who clicks on the name of the creator of a list (User B) is able to see a the list of lists created by User B, so that they can find more content from a source they like. - https://phabricator.wikimedia.org/T91037#1179170 (10Jdlrobson) Didn't @jhernandez suggest making the username link to their... [21:00:01] 6Mobile-Web, 10MobileFrontend, 10VisualEditor, 10VisualEditor-MediaWiki, and 3 others: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1179179 (10Krenair) [21:00:37] MaxSem: can you explain to me how I can retire a question once an aggregation is done if questions are on multiple wikis? [21:01:19] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Change the "Collections" icon in left nav menu - https://phabricator.wikimedia.org/T93813#1179187 (10Jdlrobson) [21:01:20] 10Gather: Collection's have their own icon--separated out from Watchlist. - https://phabricator.wikimedia.org/T91356#1179186 (10Jdlrobson) [21:01:36] kristenlans: Coming. Had to kick kaldari out of a room. :-( [21:02:05] wfGetDB( DB_*, array(), wiki id ) [21:04:34] (03CR) 10Bgerstle: [C: 031] Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [21:05:15] YuviPanda: ping [21:05:23] I *HEARD THAT!* [21:05:28] do you have time to help me (and possibly coreyfloyd) figure out how to "submit" patches? [21:05:31] we can +2, but not submit/merge [21:05:32] sure [21:05:35] ah I see [21:05:40] well that's probably just missing some bits somewher [21:05:42] let me poke around moment [21:05:47] k [21:05:57] mhurd: just got out of the interview [21:06:08] need anything? [21:06:26] coreyfloyd: batcave? [21:06:40] mhurd: sure [21:06:41] coreyfloyd: bgerstle try now? [21:06:43] apparently there aren't any emoji for bats :-( [21:07:00] 10Gather, 3Gather Sprint Enwiki, 7Mobile: Article opened on Safari browser via iPhone froze app - https://phabricator.wikimedia.org/T94923#1179210 (10Moushira) [21:07:19] (03CR) 10Bgerstle: [C: 032] Update credits to include new team members. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201241 (owner: 10Deskana) [21:07:24] (03PS2) 10Bgerstle: Update credits to include new team members. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201241 (owner: 10Deskana) [21:07:45] YuviPanda: BOOM! ^ [21:08:09] ✊ [21:08:14] o/ [21:08:29] YuviPanda: what was it? [21:08:47] coreyfloyd: https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [21:08:57] bgerstle: mysterious ways of gerrit. I had already added you guys as 'owner' but for some reason it wasn't letting you submit, so I specifically also told gerrit to let you two submit and it now does. [21:09:07] lol ofc [21:09:20] bgerstle: https://gerrit.wikimedia.org/r/#/admin/projects/apps/ios/wikipedia,access [21:09:38] ah ha [21:10:59] (03CR) 10Fjalapeno: [C: 031] Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [21:11:02] (03CR) 10Fjalapeno: [C: 032] Added wikidata descriptions to saved pages entries. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/200280 (owner: 10Mhurd) [21:11:13] WE'RE UNSTOPPABLE [21:14:05] (03PS1) 10Mholloway: Hide search bar on saved pages and history sections if none exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) [21:14:36] bgerstle: http://fanreact.com/wp-content/uploads/2014/10/Ghostbusters-Stay-Puft-Man-04.gif [21:17:55] 10Gather, 3Gather Sprint Enwiki, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1179251 (10Jdlrobson) @krenair 15 times in a short period of time or spread out over a longer period? When was the most recent occurrence (also any chance I could get the urls t... [21:20:13] 10Gather: Track when user clicks on article from collection - https://phabricator.wikimedia.org/T90998#1179259 (10JKatzWMF) 5Open>3declined Pageviews will suffice [21:24:27] 10Gather: A user visiting a list via a url/share is tracked measured...(either EL or traditional pageview) - https://phabricator.wikimedia.org/T91019#1179262 (10JKatzWMF) we would want to make it so shares via fb/tw/etc had an appended url--can we possibly do that through metatags? or only the fb button? the p... [21:24:49] jdlrobson, any thoughts about image? i heard you had issues with the other image code, so wouldn't it be good to consolidate it inside api? [21:27:11] MaxSem: On https://gerrit.wikimedia.org/r/#/c/201071/4/includes/QuestionStore.php do you mean I should not update questions at all? or just not do selecting myself? [21:28:33] the former. QS needs no change at all [21:29:32] MaxSem: in order to filter I need to hit the db right? which was the reason to change questions [21:29:34] 10Gather, 3Gather Sprint Enwiki, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1179270 (10Krenair) Short period. The only log entries I could find were the 16 starting at 04:04:15 (today) and ending at 04:13:12. I don't have the URLs. [21:30:06] bmansurov, filter before saving to the db [21:30:44] MaxSem: you mean on links update, right? But what if links update doesn't get triggerred for a page for a long time [21:31:00] live with it [21:31:07] yurik: i'm not sure about it... plus it will need some tests. more detailed report later. [21:31:39] the issue with existing setup was minor [21:31:49] MaxSem: ohh man, that was the reason of these changes because sam wasn't quite happy with it [21:31:54] Deskana, hey [21:31:56] also, remeber that there's http caching anyway [21:32:06] MaxSem: ok thanks [21:32:58] accessing one central db on every [ageview is not a good thing even though the cluster will probably survive it [21:33:06] Krenair: Hey! What's up? [21:33:16] dbrant|food: i'm trying out our app in Arc Welder. It seems to run pretty well [21:33:28] Deskana, so mholloway probably should have mobile otrs access. can you email RD about that? [21:33:34] tfinc: nice! [21:33:44] bearND: mholloway --^ [21:34:03] Krenair: Sure. [21:34:11] their is a slight performance hit but nothing major [21:34:14] and the APK just worked [21:34:18] (apparently someone else asked, but it needs to be you) [21:34:20] (03CR) 10Jdlrobson: [C: 04-1] "Minor feedback... but this really needs tests." (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200798 (https://phabricator.wikimedia.org/T93912) (owner: 10Yurik) [21:34:34] NearyBy worked without issue too [21:34:40] tfinc: nice! [21:34:41] tfinc: sweet! [21:35:30] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1179307 (10Jdlrobson) I worry it might not be obvious they are clickable... someone commented to me as a first reaction that they didn't reali... [21:37:37] MaxSem: how can I connect to the repo database from client wikis in ResponseStoreDB? [21:38:16] third parameter to wfGetDB [21:38:32] cool [21:40:31] 10Gather: Infinite scrolling for all the things - https://phabricator.wikimedia.org/T94628#1179315 (10Jdlrobson) [21:41:50] i just can't seem to trigger the hardware back button, wonder if they got rid of it [21:44:21] 10Gather, 3Gather Sprint Enwiki, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1179323 (10Jdlrobson) thanks @krenair i will keep poking around [21:45:16] 10Gather, 3Gather Sprint Enwiki, 7Browser-Tests, 7Jenkins: Browser tests failing regularly due to styles not alway loading - https://phabricator.wikimedia.org/T94891#1175367 (10Jdlrobson) I can't replicate this locally when I run against beta labs [21:47:47] coreyfloyd: i had to do this to get homebrew updates working : http://stackoverflow.com/a/5112493/135557 [21:49:34] http://www.orlandosentinel.com/entertainment/tv/tv-guy/os-wikipedia-opens-up-on-60-minutes-20150402-post.html < does that mean i'll be famous on sunday? [21:53:20] * jdlrobson doesn't get how tv works any more [21:54:23] MaxSem: so, how do I get the name of the wiki for the repo? [21:54:45] create a config variable [21:55:33] (03PS1) 10Kaldari: Make width of buttons not change when label is replaced with spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 [21:55:36] MaxSem: what's a reasonable default name? [21:56:36] wikidatawiki [21:56:48] works for both vagrant and prod [21:56:50] tweet a fact works flawlessly too when generating an image. well done team. i'm curious to see where they take this at I/O [21:57:08] (03CR) 10jenkins-bot: [V: 04-1] Make width of buttons not change when label is replaced with spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [21:57:09] ta [21:57:12] (03CR) 10Florianschmidtwelzow: [C: 04-1] Make width of buttons not change when label is replaced with spinner (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [21:58:39] (03CR) 10Jdlrobson: [C: 04-1] Make width of buttons not change when label is replaced with spinner (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [22:01:17] 10Gather: User A who clicks on the name of the creator of a list (User B) is able to see a the list of lists created by User B, so that they can find more content from a source they like. - https://phabricator.wikimedia.org/T91037#1179361 (10JKatzWMF) Agree with jhernandez's idea...the current profile is essenti... [22:01:44] 10Gather, 3Gather Sprint Enwiki: User A who clicks on the name of the creator of a list (User B) is able to see a the list of lists created by User B, so that they can find more content from a source they like. - https://phabricator.wikimedia.org/T91037#1179362 (10JKatzWMF) [22:01:47] mhurd: ok - glad you found it - may put a not about brew doctor in the readme [22:02:32] (03CR) 10Mhurd: [C: 031] Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 (owner: 10Fjalapeno) [22:05:03] (03CR) 10Kaldari: Make width of buttons not change when label is replaced with spinner (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [22:05:04] mhurd: so thats a good thing? [22:05:31] coreyfloyd: ? [22:05:32] (03PS2) 10Kaldari: Make width of buttons not change when label is replaced with spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 [22:05:50] mhurd: the +1, i guess the icons worked? [22:05:57] coreyfloyd: ya! [22:06:05] (03PS4) 10Bgerstle: Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 (owner: 10Fjalapeno) [22:06:13] just rebased ^ [22:08:07] (03CR) 10jenkins-bot: [V: 04-1] Make width of buttons not change when label is replaced with spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [22:08:13] wait, how did the xcconfig files get added again? [22:08:30] bgerstle: coreyfloyd bat cave again? [22:08:34] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1179374 (10MSyed) If that's the case, then keep the 'read more' text in there in the same color, but make the whole card a link. [22:09:14] (03PS5) 10Fjalapeno: Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 [22:09:19] mhurd: sure [22:09:37] coreyfloyd: bgerstle just figured it'd be easier as we wrap up [22:10:00] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [22:13:25] (03PS6) 10Fjalapeno: Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 [22:16:20] (03PS5) 10Bmansurov: Filter out retired WikiGrok claims from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) [22:18:45] (03CR) 10Bgerstle: [C: 031] Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 (owner: 10Mhurd) [22:19:50] (03CR) 10Fjalapeno: [C: 032] Reuse of NSRegularExpression objects in string formatting method. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201092 (owner: 10Mhurd) [22:20:08] (03PS7) 10Mhurd: Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 (owner: 10Fjalapeno) [22:21:19] (03CR) 10Bgerstle: [C: 031] Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 (owner: 10Fjalapeno) [22:21:52] (03CR) 10Mhurd: [C: 032] Create environment specific icons at build time Bug T94534 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201351 (owner: 10Fjalapeno) [22:26:47] whoa [22:27:04] @Jdlrobson is a star [22:27:09] http://www.orlandosentinel.com/entertainment/tv/tv-guy/os-wikipedia-opens-up-on-60-minutes-20150402-post.html [22:35:47] (03CR) 10Florianschmidtwelzow: Make width of buttons not change when label is replaced with spinner (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [22:48:30] (03CR) 10Bmansurov: Make width of buttons not change when label is replaced with spinner (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [22:49:05] moizsyed: jdlrobson never wanted to be a star [22:54:51] (03CR) 10Kaldari: Make width of buttons not change when label is replaced with spinner (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [23:06:06] Deskana: winning wikidata description of the day - article, "crystallinity" [23:06:46] 10Gather, 3Gather Sprint Enwiki, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1179494 (10MZMcBride) Given that it seems to have gone away, my guess was either some of kind of replication lag or possibly caching. It was a very new account and I hopped from... [23:11:48] are APKs for stable, beta, etc. downloadable somwhere? I'm aware of android-builds.wmflabs.org but it seems to have only the latest builds [23:12:18] Eloquence: https://releases.wikimedia.org/mobile/android/wikipedia/ [23:12:27] oh shiny [23:13:44] apks'r'us [23:14:06] mh, arc welder doesn't work for me in chromium, maybe it needs chrome [23:17:35] indeed it does [23:18:06] good to know [23:18:17] I only got Chrome atm [23:18:26] wow that thing is fast [23:19:12] yeah, pretty slick, hehe :) [23:19:36] (03PS5) 10Bmansurov: Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) [23:20:23] (03PS6) 10Bmansurov: Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) [23:20:55] 6Mobile-Web, 10MobileFrontend: Email confirmation workflow doesn't work correctly from a Mobile device - https://phabricator.wikimedia.org/T95065#1179535 (10kaldari) 3NEW [23:21:52] (03CR) 10MaxSem: "Note that in I019a6118c58c8204a88c3e5e7ca97c428276af43 it will need to become aware of wiki it operates against, so this change is probabl" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201708 (owner: 10Phuedx) [23:22:42] 10Gather, 3Gather Sprint Enwiki, 7Mobile: Article opened on Safari browser via iPhone froze app - https://phabricator.wikimedia.org/T94923#1179542 (10Rdicerb) Hi @Jdlrobson - I didn't have problem when I tried it in Beta. Thanks! [23:24:27] (03PS1) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [23:25:52] (03PS2) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [23:28:26] (03CR) 10Bmansurov: [C: 031] Make width of buttons not change when label is replaced with spinner (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [23:28:28] (03PS1) 10Mhurd: Fix for missing recent thumb images. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201863 [23:30:14] coreyfloyd: bgerstle ^ [23:31:06] Deskana: I'm going to push out another beta [23:31:26] bearND: Excellent! [23:32:12] bearND: Does this include the new web view loading mechanism? [23:33:04] Deskana: Do you mean using a single WebView or the experimental service stuff? [23:33:20] bearND: I meant the single web view. [23:33:32] Deskana: yes, single webView is included [23:34:15] just running a TWN sync [23:35:22] (03PS2) 10Mhurd: Fix for missing recent thumb images. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201863 [23:37:05] (03CR) 10Bmansurov: [C: 04-1] "The mock of the first step and the implementation look different." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [23:38:46] bmansurov: ? looks the same to me. What’s different? [23:38:48] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201865 [23:38:55] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201866 [23:39:33] kaldari: 'tell me more' is before the buttons on the same line [23:39:39] kaldari: buttons should be above it [23:39:56] kaldari: wait, sorry [23:40:00] kaldari: wrong branch [23:43:01] (03CR) 10Bmansurov: "Sorry, the first step looks fine. However, I don't see these changes:" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [23:44:02] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201865 (owner: 10BearND) [23:44:30] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201865 (owner: 10BearND) [23:47:07] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201869 [23:47:37] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201869 (owner: 10BearND) [23:47:50] (03CR) 10Kaldari: "@Bmansurov: Haven't done the spinner part yet (waiting for the MF change to be merged)." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [23:47:55] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201869 (owner: 10BearND) [23:49:41] (03PS3) 10Kaldari: Make width of buttons not change when label is replaced with spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 [23:53:16] coreyfloyd: bgerstle heading out [23:56:34] (03CR) 10Bmansurov: [C: 032] Make width of buttons not change when label is replaced with spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201851 (owner: 10Kaldari) [23:57:19] 10Gather, 3Gather Sprint Enwiki: Assorted string replacements - https://phabricator.wikimedia.org/T93817#1179585 (10JKatzWMF)