[02:04:37] Hello! n00b here. I recently signed up for the Wikitech-l mailing list. Are any others recommended for Wikipedia Android app devs? [02:32:34] niedzielski, mobile-l [02:33:03] don't think there are any other public ones [02:34:43] if you want to contribute you'll need to know about gerrit and phabricator [02:35:36] Krenair, thanks. will sign up for mobile-l [02:37:30] the page for new mobile apps staff is at https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Onboarding - I think only some of it is relevant to volunteers but it might give you a good idea about how the foundation apps teams work and some random details [02:43:19] thanks for the link! this is great [03:08:50] (03PS1) 10Deskana: Make enter key submit request when the user is filling in a captcha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201989 (https://phabricator.wikimedia.org/T95145) [03:28:39] (03PS1) 10Deskana: More aggressively disable autocomplete suggestions for captcha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201990 [07:06:36] (03PS2) 10Rahdev: Automatically dismiss keyboard on fast scroll when in edit mode. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190960 [07:32:53] (03CR) 10Rahdev: "If I implement Bgerstle suggestions, does this replace the scrollview delegate method entirely? Thanks." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190960 (owner: 10Rahdev) [08:01:14] 6Mobile-Web, 5Patch-For-Review: Unclickable "Next" button as unregistered user - https://phabricator.wikimedia.org/T94419#1181553 (10Nemo_bis) VERIFIED. The number of edits went back to normal level on it.wiki after the fix was deployed: ``` MariaDB [itwiki_p]> SELECT LEFT(rev_timestamp, 8) AS DATE, COUNT(*) F... [08:01:33] 6Mobile-Web, 5Patch-For-Review: Unclickable "Next" button as unregistered user - https://phabricator.wikimedia.org/T94419#1181561 (10Nemo_bis) [09:11:05] good morning [10:10:55] 6Mobile-Web, 10MobileFrontend: In MobileBeta front end, clicking in TOC does not go to a subsection whose parent section is unexpanded on the page. - https://phabricator.wikimedia.org/T95122#1181766 (10Jhernandez) I can confirm, Firefox 37.0.1 on Nexus 5, Android 5 Lollipop. Clicking the first time on the TOC... [10:17:03] 6Mobile-Web, 10MobileFrontend: In MobileBeta front end, clicking in TOC does not go to a subsection whose parent section is unexpanded on the page. - https://phabricator.wikimedia.org/T95122#1181780 (10Jhernandez) For some reason only Firefox for Android is showing the TOC, Chrome for Android does not show the... [10:23:16] 6Mobile-Web: Jittery placeholder text in search input field on alpha - https://phabricator.wikimedia.org/T95078#1181793 (10Jhernandez) The 1px focus gap strikes back. Confirmed it happens everywhere (chrome/firefox) and in all modes (stable/beta/alpha) [10:23:32] 6Mobile-Web: Jittery placeholder text in search input field - https://phabricator.wikimedia.org/T95078#1181794 (10Jhernandez) [10:30:45] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1181801 (10Jhernandez) Moved to -1 **TODO?** - Wrap whole card with link (or make it one) - Make //Read More// not a link, but retain st... [10:34:44] 10Gather, 3Gather Sprint Enwiki: User A who clicks on the name of the creator of a list (User B) is able to see a the list of lists created by User B, so that they can find more content from a source they like. - https://phabricator.wikimedia.org/T91037#1181819 (10Jhernandez) +100 to this. Changes needed:... [10:45:05] 10Gather, 3Gather Sprint Enwiki: Icon styles loaded twice on Gather special pages - https://phabricator.wikimedia.org/T95014#1181855 (10Jhernandez) Proposed solution of splitting the menu icon to a new module and add it via hook sounds good. Should remove also loading the icons from the hook ``` // FIXME: a... [10:50:58] (03CR) 10Jhernandez: [C: 032] "Seems to work consistently" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201831 (https://phabricator.wikimedia.org/T94513) (owner: 10Jdlrobson) [10:52:43] (03CR) 10Jhernandez: [C: 032] i18n: articles -> pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201837 (https://phabricator.wikimedia.org/T94967) (owner: 10Jdlrobson) [10:53:20] (03Merged) 10jenkins-bot: Don't go flaking my heart on images [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201831 (https://phabricator.wikimedia.org/T94513) (owner: 10Jdlrobson) [10:53:21] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Special:Gather uses "articles" instead of "pages" or a more generic term - https://phabricator.wikimedia.org/T94967#1181871 (10Jhernandez) a:3Jdlrobson [10:54:55] (03Merged) 10jenkins-bot: i18n: articles -> pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201837 (https://phabricator.wikimedia.org/T94967) (owner: 10Jdlrobson) [11:10:35] (03CR) 10Jhernandez: Tablet styles for Special:Gather/by/User (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [11:11:46] (03PS3) 10Jhernandez: Tablet styles for Special:Gather/by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) [11:13:00] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Responsive design for tiling Special:Gather list of collections - https://phabricator.wikimedia.org/T91384#1081510 (10Jhernandez) @jdlrobson Addressed your concerns. The css analysis thingy seems like a good topic for the dev pow pow maybe. Let's not forget... [11:24:17] (03PS1) 10Jhernandez: Hygiene: Merge .collection-cards and .collection-items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202018 (https://phabricator.wikimedia.org/T91384) [11:24:19] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Merge .collection-cards and .collection-items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202018 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [11:25:08] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Responsive design for tiling Special:Gather list of collections - https://phabricator.wikimedia.org/T91384#1182000 (10Jhernandez) ⬆️ Follow up patch that merges the selectors b/c behavior is the same. [12:40:03] y'know what i did? [12:40:10] i forgot to open up irccloud again [12:40:51] hey joakino [13:11:24] (03CR) 10Anomie: Debounce resize events (031 comment) [extensions/MobileFrontend] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201840 (https://phabricator.wikimedia.org/T93988) (owner: 10Jdlrobson) [13:38:03] lunch [14:19:49] (03CR) 10Bgerstle: [C: 04-1] "+1 for smallestCachedVariant stuff (tests would be nice). however, would like to discuss history/savedpagesVC not fetching images." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201863 (owner: 10Mhurd) [14:41:34] phuedx: are you around? [14:45:34] joakino: i'm around [14:46:31] phuedx: regarding the deployment of this afternoon (Jon's email) I'll hangout in wikimedia-operations in about 1 hour, this is the patch I have to see deployed [14:46:32] https://gerrit.wikimedia.org/r/#/c/201840/ [14:46:50] phuedx: should I merge it? is there anything specific I have to do? [14:47:24] joakino: you should respond to anomie's comment [14:47:37] and can you merge it? [14:47:58] also, short answer: no -- the deployer will do the thing [14:48:08] phuedx: crap, i don't know the answer [14:51:14] :/ [14:52:06] if you're unsure, then you should drop the patch from the swat list [14:52:15] (or ping jon as hard as you can) [14:57:20] (03PS1) 10Bgerstle: fix pod install warnings [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202037 [15:02:29] (03CR) 10Fjalapeno: [C: 031] fix pod install warnings [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202037 (owner: 10Bgerstle) [15:03:12] (03CR) 10Jhernandez: Debounce resize events (031 comment) [extensions/MobileFrontend] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201840 (https://phabricator.wikimedia.org/T93988) (owner: 10Jdlrobson) [15:03:55] coreyfloyd: i did some fn'l swift this weekend: https://twitter.com/b_gerstle/status/584733494078742529 [15:03:59] also some c++11 :-P [15:05:29] bgerstle: ha - keep practicing for Objective-C++ [15:06:14] coreyfloyd: i actually did some (IMO) clever stuff [15:06:33] templates which allow you to combine hashes of primitive & NSObject variables [15:06:42] nice [15:06:52] i dare say i had an easier time w/ ObjC++ than swift [15:07:07] i mean... lldb is broken for swift [15:07:19] yeah… [15:07:27] ive been avoiding swift until the tooling is there [15:07:36] i already lived through xcode 4 and 5 [15:07:38] yeah, until then, everyone basically has to http://www.blogcdn.com/www.urlesque.com/media/2010/12/deal-with-it.jpg [15:07:43] lol [15:08:29] bgerstle: seriously my productivity was at least cut in half for like 2 years after Xcode 3 [15:08:41] i also crashed my PC running some tests which took up all remaining disk & RAM :-P [15:08:56] (not sure if it's the tests' fault or the framework's fault) [15:09:07] (03PS2) 10Jhernandez: Debounce resize and scroll events [extensions/MobileFrontend] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201840 (https://phabricator.wikimedia.org/T93988) (owner: 10Jdlrobson) [15:09:39] phuedx: ^ is that ok? [15:10:13] phuedx: I've added the lost feature, but it wasn't actually used anywhere [15:10:33] joakino: that's fine -- you in -operations? [15:10:34] phuedx: or are we not supposed to send new patchsets to those changes [15:10:44] yes [15:11:00] joakino: hrrm, now master is out of sync with the release branch? [15:11:30] phuedx: until I send a new patchset to master yes [15:11:58] yeah, 'course [15:12:09] you've got a 3 (?) week window to fix that as well, so you're good :) [15:17:22] phuedx: can you lend me a hand in operations? [15:20:55] (03CR) 10Phuedx: [C: 032] Debounce resize and scroll events [extensions/MobileFrontend] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201840 (https://phabricator.wikimedia.org/T93988) (owner: 10Jdlrobson) [15:22:45] phuedx: so it goes to testwiki now, i test it there, and later to enwiki? [15:23:08] joakino: might be able to go quicker 'n that since manybubbles is on the case :D [15:23:15] (03PS1) 10Jhernandez: Bring back the scroll event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202038 (https://phabricator.wikimedia.org/T94923) [15:23:23] just waiting for the cherry pick to get merge [15:23:25] d [15:23:30] k [15:23:41] omg the merge is slow v.v [15:26:56] zomg jerkins HURRY UP [15:27:16] (03Merged) 10jenkins-bot: Debounce resize and scroll events [extensions/MobileFrontend] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201840 (https://phabricator.wikimedia.org/T93988) (owner: 10Jdlrobson) [15:27:42] 10Gather, 3Gather Sprint Enwiki, 7Mobile, 5Patch-For-Review: Article opened on Safari browser via iPhone froze app - https://phabricator.wikimedia.org/T94923#1182264 (10Jhernandez) @jdlrobson Don't you think we would want to throttle the resize/scroll events instead of debouncing? There's no rush right now... [15:28:01] phuedx: mergeedd [15:29:18] phuedx: i have no idea what's going on [15:35:51] so phuedx ping? [15:35:56] (03PS1) 10Bgerstle: commit Pods folder [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202040 (https://phabricator.wikimedia.org/T94039) [15:38:45] 6Mobile-Web, 10Phabricator-Upstream, 7Mobile: Ability to designate sub-workboards in Phabricator - https://phabricator.wikimedia.org/T78225#1182308 (10Qgil) 5Open>3declined a:3Qgil >>! In T78225#1058378, @Qgil wrote: > I would either decline this task, or convert it in a request for subprojects. Subpr... [15:40:32] joakino: i've uploaded the patch for anomie and we'll see -- there seems to be something that hasn't been deployed laying around afaict [15:40:47] phuedx: that's the submodule updated? [15:40:51] the diff is weird [15:40:58] joakino: yeah [15:41:17] diff should just be a new sha [15:42:00] which points to head of MF/wmf/1.25wmf23 [15:42:04] aha [15:42:05] joakino: http://git.wikimedia.org/log/mediawiki%2Fextensions%2FMobileFrontend.git/refs%2Fheads%2Fwmf%2F1.25wmf23 [15:42:30] i see [15:43:17] phuedx: so what happens now? we wait for anomie to deploy? [15:43:24] yarrrp [15:43:28] are we going to make it? [15:43:47] not sure, there seems to be some hoohah [15:44:10] joakino: this is the second time i've watched a patch go out [15:44:28] but it /seems/ like we should pre-merge the cherry-picks to the branches that we control [15:44:35] and then line up the submodule updates in core [15:46:22] (03CR) 10Phuedx: [C: 032] "We'll review the hook function later." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198290 (owner: 10Yurik) [15:46:37] phuedx: should I say something in ops? xd [15:46:45] yeah ping 'em [15:47:54] joakino: wanna hangout? [15:48:18] sure [15:48:50] (03Merged) 10jenkins-bot: In phpunit, mobile frontend crashes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198290 (owner: 10Yurik) [16:10:47] any ideas for https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8264759 bearND? [16:11:54] 10Gather, 3Gather Sprint Enwiki, 7Mobile, 5Patch-For-Review: Article opened on Safari browser via iPhone froze app - https://phabricator.wikimedia.org/T94923#1182471 (10Jhernandez) Change deployed. @jdlrobson see ⬆️ that other patch that adds back the scroll event (it was removed by the previous patch, do... [16:13:50] Krenair: hmmm, just thinking it might be similar to https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8153383#9671340 [16:20:46] (03CR) 10BearND: [C: 04-1] Hide search bar on saved pages and history sections if none exist (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) (owner: 10Mholloway) [16:27:26] To the office! [16:30:09] (03CR) 10Mholloway: Hide search bar on saved pages and history sections if none exist (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) (owner: 10Mholloway) [16:32:49] 10Gather, 3Gather Sprint Enwiki, 7Mobile, 5Patch-For-Review: Article opened on Safari browser via iPhone froze app - https://phabricator.wikimedia.org/T94923#1182529 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson @Rdicerb are you able to verify the fix? [16:34:11] gonna get the kids to bed [16:38:17] joakino: Hey I have to take off for a bit for an appointment so I'll miss the standup. Just sent an email with my update. brb [16:38:55] JonKatz: ^^ [16:38:57] (03CR) 10BearND: Hide search bar on saved pages and history sections if none exist (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) (owner: 10Mholloway) [16:39:14] k rmoen :) [16:39:43] k gotta go, be back around 10:30 [16:46:54] (03CR) 10Mholloway: Hide search bar on saved pages and history sections if none exist (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) (owner: 10Mholloway) [16:54:38] (03PS1) 10Bgerstle: makefile: add "easy button" to install dependencies [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202051 (https://phabricator.wikimedia.org/T94229) [17:06:54] (03PS1) 10Jdlrobson: Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 [17:06:56] (03PS1) 10Jdlrobson: Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 [17:06:58] (03PS1) 10Jdlrobson: WIP: Add support for ContentOverlay in Vector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202054 [17:08:31] 3Gather Sprint Enwiki: PM Spike: talk to wikigrok team about using backend for flag heuristics - https://phabricator.wikimedia.org/T94875#1182612 (10Jdlrobson) a:3JKatzWMF [17:08:49] 10Gather, 7Wikimedia-log-errors: UsageException on Special:Gather - https://phabricator.wikimedia.org/T94965#1182615 (10Jdlrobson) [17:09:00] 10Gather: Adding or removing items to my Gather list has no impact on last updated time - https://phabricator.wikimedia.org/T94843#1182616 (10Jdlrobson) [17:09:16] 10Gather: Watchstar content overlay should make page content transparent - https://phabricator.wikimedia.org/T93287#1182618 (10Jdlrobson) [17:09:32] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 (owner: 10Jdlrobson) [17:09:59] (03CR) 10Florianschmidtwelzow: "i'm wondering, why our MobileContext doesn't has a Title object, but SkinTemplate (which inherits (I)ContextSource) has one? Why is Mobile" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198290 (owner: 10Yurik) [17:10:04] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 (owner: 10Jdlrobson) [17:10:30] 10Gather, 3Gather Sprint Enwiki: Deleted entries in Watchlist show up in Gather lists - https://phabricator.wikimedia.org/T94847#1182620 (10Jdlrobson) Talking to @msyed - We probably shouldn't show deleted pages at all in the Watchlist collections. We have a card to move these to the bottom in the next sprint... [17:10:36] 10Gather: Deleted entries in Watchlist show up in Gather lists - https://phabricator.wikimedia.org/T94847#1182624 (10Jdlrobson) [17:11:41] 10Gather, 3Gather Sprint Enwiki, 10MediaWiki-Database, 7database: DB gather_list.gl_id autonumber is always odd - https://phabricator.wikimedia.org/T94512#1182629 (10Jdlrobson) Unable to reproduce locally. We should have a quick investigation of this and maybe do a spike next sprint and pull in people like... [17:11:46] 10Gather, 10MediaWiki-Database, 7database: DB gather_list.gl_id autonumber is always odd - https://phabricator.wikimedia.org/T94512#1182631 (10Jdlrobson) [17:11:57] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add support for ContentOverlay in Vector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202054 (owner: 10Jdlrobson) [17:13:05] 10Gather: Allow autopatrolled users to contribute in list moderation. - https://phabricator.wikimedia.org/T94641#1182639 (10Jdlrobson) a:5Jdlrobson>3None [17:13:22] (03CR) 10BearND: [C: 04-1] Make enter key submit request when the user is filling in a captcha. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201989 (https://phabricator.wikimedia.org/T95145) (owner: 10Deskana) [17:13:35] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Illustrations are flakey - https://phabricator.wikimedia.org/T94513#1182651 (10Jdlrobson) 5Open>3Resolved [17:14:05] 10Gather: Dismissing login drawer after clicking watchstar breaks watchstar - https://phabricator.wikimedia.org/T94682#1182656 (10Jdlrobson) I can reproduce this. Big edge case but should get fixed sooner rather than later. [17:16:15] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Paginate all the things - https://phabricator.wikimedia.org/T94515#1182684 (10Jdlrobson) [17:16:17] 10Gather: List of all collectoins (projectwide) is paginated - https://phabricator.wikimedia.org/T93620#1182683 (10Jdlrobson) [17:16:29] jdlrobson: we should talk icons [17:17:01] JonKatz: i'm fine finishing up the alpha stuff but we should discuss it on the mailing list and at the retro with design [17:17:55] hey phuedx yeehhhh [17:17:57] fricking icons [17:18:21] phuedx agreed--we talked about it a bit last week at the retro. I'm trying to be sensitive to the fact that this thing was bascially in the envelope on the way tot he post when I got here...and I don't want to squash something I don't totally understand first. [17:18:49] JonKatz: cool -- then we'll finish up this round of tweaks and chat again? [17:18:57] joakino: any issues with moving media query to bottom of https://gerrit.wikimedia.org/r/#/c/201690/3/resources/ext.gather.styles/collections.less ? [17:18:58] jdlrobson: what's the status of mw-ui-icon vs icon? [17:19:12] 10Gather: Allow autopatrolled users to contribute in list moderation. - https://phabricator.wikimedia.org/T94641#1182701 (10Florian) Some platforms provide such a function and show reported items (if many users reported an item) as "possible unconstructive content" and it is still visible, but the user needs a c... [17:19:38] (03CR) 10Jdlrobson: [C: 031] Tablet styles for Special:Gather/by/User (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [17:19:52] phuedx: soooooo. [17:19:55] phuedx I think so. In the meantime I am going to talk to Kaity about alternatives/modifications that take into account desktop and allow for a future "Search in page" feature. Those are my two beefs. [17:20:00] jdlrobson: sure thang [17:20:28] 10Gather: Gather should explain to users why they're required to log in if they go to Special:Gather or Special:GatherLists - https://phabricator.wikimedia.org/T94971#1182713 (10Florian) a:3Florian [17:20:30] phuedx: so now oojs-ui is the thang, i worry mediawiki.ui.icon won't get any maintenance [17:20:47] (unless we provide it) [17:20:50] jdlrobson: in the following patch https://gerrit.wikimedia.org/r/#/c/202018/ I've moved the common section up top [17:20:52] jdlrobson: gotcha [17:20:54] so we have two options - 1) we move mw-ui-icon everywhere [17:21:07] 2) we explore pulling out the icons part from oojs ui and using them. [17:21:27] https://gerrit.wikimedia.org/r/#/c/202018/1/resources/ext.gather.styles/collections.less [17:21:51] joakino: so we have this kinda undocumented convention where the media queries are at the bottom of the file [17:21:54] makes it easy to find them [17:22:05] and stops you introducing more than 1 media query [17:22:24] what do you think about formalising that a bit more? [17:22:44] jdlrobson: i'm sorta in favour of 1 followed by 2 [17:22:53] but i'm not sure how much of a thing oojs-ui [17:22:54] sounds good to me [17:23:00] is [17:23:10] let's kill the icon crap.. so the only thing we have to be careful with is cached pages [17:23:22] break 'em [17:23:27] phuedx: :-O [17:23:27] who cares [17:23:30] i don't care [17:23:33] i'm a maverick [17:23:36] phuedx: if you want me to i can own that [17:23:43] jdlrobson: ah ok, i'll touch both patches [17:23:52] yeah -- cached pages are a thing [17:24:00] phuedx: i can do a patch today [17:24:18] 10Gather: after user adds page to collection, there is a one-click way to immediately visit that collection to edit - https://phabricator.wikimedia.org/T93165#1182723 (10JKatzWMF) @msyed--want to put this on the docket for todays 1:1 [17:24:18] jdlrobson: i personally like to have the media queries close to where the component is defined and where they make sense, since less allow's that (and css doesn't :p) but I don't mind other solutions [17:24:24] jdlrobson: i think the effort should be something like: replace icons everywhere, move all icon css into one file, delete the file later [17:25:42] joakino: we should chat about it on mailing list. i don't want to block your patch, i'd just like some consistency [17:25:50] phuedx: yeh it's pretty trivial to do [17:25:56] let me prepare a patch before you go to sleep [17:25:58] jdlrobson: sure! i'm on it [17:26:02] jdlrobson: <3 [17:26:10] brb getting cereal [17:26:20] breakfast for dinner is /the/ best [17:26:34] (03PS4) 10Jhernandez: Tablet styles for Special:Gather/by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) [17:28:37] (03PS2) 10Jhernandez: Hygiene: Merge .collection-cards and .collection-items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202018 (https://phabricator.wikimedia.org/T91384) [17:28:39] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Merge .collection-cards and .collection-items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202018 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [17:28:42] (03PS1) 10Jdlrobson: Hygiene: Correction to ext.gather.api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 [17:28:44] (03PS1) 10Jdlrobson: Hygiene: Create separate module for initialisation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202060 [17:28:46] (03PS1) 10Jdlrobson: WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 [17:28:48] (03PS2) 10Jdlrobson: Add support for ContentOverlay in Vector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202054 [17:29:33] coreyfloyd: need any help w/ testing stuff? [17:29:57] also, is there anything else we can do to tighten up the current build setup? e.g. get your email etc. out of the fastfile? [17:30:48] (03PS1) 10Florianschmidtwelzow: Add gather-anon-view-lists to valid login-error messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202062 (https://phabricator.wikimedia.org/T94971) [17:32:26] (03CR) 10jenkins-bot: [V: 04-1] Add support for ContentOverlay in Vector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202054 (owner: 10Jdlrobson) [17:33:08] (03PS5) 10Jhernandez: Tablet styles for Special:Gather/by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) [17:33:10] (03PS3) 10Jhernandez: Hygiene: Merge .collection-cards and .collection-items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202018 (https://phabricator.wikimedia.org/T91384) [17:33:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correction to ext.gather.api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 (owner: 10Jdlrobson) [17:33:35] jdlrobson: ^ fixed comments and rebased [17:36:41] bgerstle: I’m about to get lunch [17:36:57] bgerstle: if you want to start on it, have at it and I can join up in a bit [17:37:44] K, I'm heating up my lunch now. Maybe we can go over my patches when you get back? [17:40:46] gonna take a break for 10 minutes [17:41:02] (03CR) 10MaxSem: "Florianschmidtwelzow, actually MobileContext inherits from ContextSource. However, the context itself doesn't always have title set." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198290 (owner: 10Yurik) [17:41:53] coreyfloyd: bgerstle - how many *hours* do you want to assign to the spike "Research Spike to remove MWKLocalizedString " for sprint 55? [17:42:58] (03CR) 10Florianschmidtwelzow: "@MaxSem: Right, but it should use wgTitle, if self::title is null (no title set yet)?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198290 (owner: 10Yurik) [17:43:20] dr0ptp4kt: i don't know, it will probably involve some back and forth w/ brion and bearnd about localization stuff [17:43:51] maybe 2-4? i don't think it really matters as long as you don't spend all day trying to hack at it w/o first touching base w/ the knowledgeable people [17:44:10] dr0ptp4kt: we added estimations on the backlog doc… i think we estimated at 1-2 [17:44:15] either is fine with me [17:44:36] bgerstle: coreyfloyd bgerstle ok, 2 hours [17:44:38] okay? [17:44:45] if all we're doing is research it should be quick [17:44:54] send an email, do a little hacking.. [17:46:43] dr0ptp4kt: yeah sounds fine [17:50:36] (03CR) 10Bmansurov: [C: 032] "In a follow up patch it would be good to detect whether a browser supports a touch event, and if it does, then load the Swipe module on de" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [17:50:52] (03CR) 10Jdlrobson: [C: 032] Tablet styles for Special:Gather/by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [17:51:00] (03CR) 10Jdlrobson: [C: 032] Hygiene: Merge .collection-cards and .collection-items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202018 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [17:52:55] (03CR) 10Deskana: Make enter key submit request when the user is filling in a captcha. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201989 (https://phabricator.wikimedia.org/T95145) (owner: 10Deskana) [17:52:59] (03PS1) 10Florianschmidtwelzow: Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 [17:54:00] bgerstle: https://phabricator.wikimedia.org/T91124 - 4.0.6.3 Image Gallery - some images displayed in low resolution - is ready to be checked? Patch-For-Review is not removed... [17:54:11] (03PS2) 10Deskana: Make enter key submit request when the user is filling in a captcha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201989 (https://phabricator.wikimedia.org/T95145) [17:55:59] (03Merged) 10jenkins-bot: Add Swipe module and use it in ImageOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198763 (owner: 10Florianschmidtwelzow) [17:56:01] (03Merged) 10jenkins-bot: Tablet styles for Special:Gather/by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201690 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [17:56:04] (03Merged) 10jenkins-bot: Hygiene: Merge .collection-cards and .collection-items [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202018 (https://phabricator.wikimedia.org/T91384) (owner: 10Jhernandez) [17:56:18] 10Gather: Sending notification for users with 1 article in their collections in beta? - https://phabricator.wikimedia.org/T94525#1182851 (10Florian) Hmm, i'm wondering if this would is more disturbing for most people? I would be :P if i see a notice to use the collection feature, than i do it and i get another b... [17:56:34] phuedx: mw-ui-icon makes our code soooo clean [18:00:11] etonkovi_: yeah, it's ready [18:00:22] (03CR) 10Bmansurov: [C: 04-1] "typos" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [18:06:21] 6Mobile-Web: Find new position for Font changer in alpha mode - https://phabricator.wikimedia.org/T95198#1182918 (10Florian) 3NEW [18:08:12] jdlrobson: inorite!? [18:09:59] (03PS1) 10Florianschmidtwelzow: Disable mobile.fontchanger after it is useful again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202077 (https://phabricator.wikimedia.org/T95198) [18:10:36] (03CR) 10Florianschmidtwelzow: Add support to deprecate a module (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [18:13:08] (03PS2) 10Florianschmidtwelzow: Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 [18:25:57] 6Mobile-Web, 10MobileFrontend-Feature-requests: Make MobileFrontend add a mobile rel=alternative to the desktop version instead of noindexing mobile pages - https://phabricator.wikimedia.org/T91183#1183007 (10Florian) a:5Florian>3None [18:26:23] (03PS13) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [18:28:18] kaldari: hey i remember you brought up some issue with this card https://phabricator.wikimedia.org/T91712 [18:28:28] something about the content loading at different times? [18:28:37] bgerstle: coreyfloyd: would you please (1) add 'rationale' for each card for sprint 54 & 55 from the engineering backlog, then (2) create cards (copy paste of the info should be fine) at the top of the engineering backlog column on the ios board? [18:28:44] bgerstle: coreyfloyd i'm gonna grab some lunch [18:28:52] before the showcase meeting [18:29:16] bgerstle: coreyfloyd of course put those cards in priority order on the engineering backlog column [18:29:33] 10MobileFrontend-Feature-requests: configuration variable to turn on or off particular footer links (both on desktop and mobile) - https://phabricator.wikimedia.org/T66275#1183021 (10Florian) a:5Florian>3None I got this task assigned, because i closed it. Now it's reopened, but i will not work on it. [18:30:33] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [18:31:08] dr0ptp4kt: you're talking about the stuff we roughly scoped last week? [18:31:12] the "cleanup" stuff? [18:37:31] 6Mobile-Web, 5Patch-For-Review: Watchstars not aligned in search - https://phabricator.wikimedia.org/T91178#1183040 (10Jdlrobson) a:5Florian>3Jdlrobson [18:38:48] (03PS1) 10Bgerstle: fix case of Wikipedia folder [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202086 [18:38:50] (03PS1) 10Bgerstle: commit web assets and remove build scripts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202087 (https://phabricator.wikimedia.org/T94231) [18:38:57] (03PS1) 10Jdlrobson: Hygiene: Don't add watchstar styles twice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202088 [18:38:58] ^ phuedx phheww [18:38:59] (03PS1) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T91178) [18:39:04] (03CR) 10jenkins-bot: [V: 04-1] commit web assets and remove build scripts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202087 (https://phabricator.wikimedia.org/T94231) (owner: 10Bgerstle) [18:39:33] (03PS2) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T91178) [18:40:13] kaity: hope that all made sense. let me know if I need to add some clarification to the card [18:40:21] Krenair: hey, so we're committing some generated JS code to the repo (so that we don't need to continuously generate code that doesn't change) [18:40:22] (03CR) 10Jdlrobson: "Note nearby refresh icon still broken - https://phabricator.wikimedia.org/T85578" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T91178) (owner: 10Jdlrobson) [18:40:28] is there an easy to prevent Jenkins from linting it? [18:40:34] easy way* [18:40:54] bgerstle, .jshintignore, I think? [18:40:57] kaldari: I was trying to sum it up on the card but maybe it would be better if you wrote it, sorry! [18:40:58] or something like that [18:41:12] hmm [18:41:18] see https://github.com/wikimedia/mediawiki/blob/master/.jshintignore for example [18:44:21] kaldari: how is the infobox removed in alpha? [18:44:32] (03PS2) 10Bgerstle: commit web assets and remove build scripts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202087 (https://phabricator.wikimedia.org/T94231) [18:44:46] how 'bout 'dem apples, jenkins? [18:45:24] kaity: Good question. I don’t remember. jdlrobson: is the infobox in alpha replaced on the client-side or server-side? [18:45:45] I’m guessing client-side [18:46:38] bgerstle: yeah, the stuff listed under 'sprint 54' and 'sprint 55' in the ios eng backlog google doc. if you & coreyfloyd want to shuffle stuff around between weeks given the real current state here for monday in the middle of sprint 54 (e.g., something actually needs to get bumped to sprint 55), cool [18:46:54] gotchya [18:47:13] Krenair: hasn't reported back yet... *shrug* [18:47:17] (03PS3) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T91178) [18:47:30] bgerstle, looks OK to me? [18:48:05] (03CR) 10BearND: [C: 032] Make enter key submit request when the user is filling in a captcha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201989 (https://phabricator.wikimedia.org/T95145) (owner: 10Deskana) [18:48:08] Krenair: we'll see, i guess [18:48:34] bgerstle, well jenkins gave V+2 [18:48:37] so [18:48:41] oh ok [18:48:46] i didn't see the IRC notif [18:48:54] That's because there wasn't one [18:49:32] jenkins-bot is too spammy to let into irc [18:51:02] (03CR) 10Fjalapeno: "Can we do this with sync instead?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202086 (owner: 10Bgerstle) [18:51:29] jdlrobson: i'll take a look tomo morning [18:51:32] :) [18:51:37] thanks for the patcheeezzzz [18:51:40] (03PS1) 10Bmansurov: Alpha: better parsing for a link title for quickLookup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 [18:51:53] MaxSem are you mandapanda7601? [18:52:08] (03CR) 10Bgerstle: "we could, but this was a quick change for something that's been annoying me for a while. also, i thought synx stuff was blocked on localiz" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202086 (owner: 10Bgerstle) [18:52:31] kaldari, not sure if you can merge ^ before the showcase. [18:54:45] JonKatz, no [18:55:12] bmansurov: no, won’t be able to merge that before showcase. Sorry! [18:55:19] np [18:55:26] bmansurov: can you show it from your local instance? [18:55:37] kaldari: yes, i'll do that [18:57:00] 6Mobile-Web: Page issues and wikidata description text too large - https://phabricator.wikimedia.org/T95206#1183134 (10KHammerstein) 3NEW [18:57:36] 6Mobile-Web: Page issues and wikidata description text too large - https://phabricator.wikimedia.org/T95206#1183141 (10KHammerstein) Hey Sam I think we talked about this before, I'm not sure if it got resolved? [18:57:47] MaxSem okay, cool! Thanks [19:05:26] Hi dbrant. Do you want to show the items? [19:05:32] or should i [19:05:48] Deskana: bearND: my friends' internet went out, so I had to book it to the hotel down the street lol [19:06:02] (hello from Sydney, btw!) [19:06:17] Haha [19:07:33] bearND: feel free to take care of those, and i have a special one to add myself after you're done [19:08:32] 6Mobile-Web: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1183162 (10KHammerstein) The width of the image should match the width of the content, with a minimum width of 768 - so that its fills the screen in iPad portrait mode. But I forgot that... [19:08:56] 6Mobile-Web: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1183163 (10KHammerstein) [19:17:19] joakino: so we pay 3x the cost for 1 feature because the text overlay problem was too hard to solve? [19:17:38] bgerstle: what do you mean? [19:17:42] i dunno, i'm not crazy about the fragmentation [19:17:59] gather vs. watched vs. saved [19:18:10] lead image done 3x (web, iOS, android) [19:18:20] different platforms? [19:18:37] they render it in a webview anyway [19:18:55] as long as articles need to be presented via HTML, i think we should try to converge, not diverge [19:19:37] bgerstle: agree [19:19:44] we do NOT plan on sticking with the WebView on Android in the long term... [19:20:25] dbrant: right, but in the meantime, why not reuse as much mobile-web stuff as possible? [19:20:59] dbrant or explore more native designs that don't rely as much on HTML [19:21:59] all i'm saying is, it *seems* like there's work that could be reused [19:22:17] e.g. if mobile-web optimizes page load times, there's no reason we shouldn't also benefit from that [19:22:37] Lead images aren't even in production on mobile web right now. [19:23:03] again, just saying we should keep an eye on it [19:23:31] Well, then do that, and bring it to me when it's actionable. :-) [19:24:33] Deskana: sure will [19:25:34] 10Gather: Prevent e-mail addresses being used in list titles/descriptions - https://phabricator.wikimedia.org/T95208#1183177 (10Jdlrobson) 3NEW [19:28:45] 6Mobile-Web, 5Patch-For-Review: Unclickable "Next" button as unregistered user - https://phabricator.wikimedia.org/T94419#1183188 (10Jdlrobson) Thanks for the investigatory work @nemo_bis ! :-) [19:31:03] bearND: so you'll hook up TOC using structured data provided from your service? [19:31:20] 10Gather, 6Mobile-Web, 3Mobile Web Design, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1183189 (10Jdlrobson) Gather us... [19:32:11] (03Merged) 10jenkins-bot: Make enter key submit request when the user is filling in a captcha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201989 (https://phabricator.wikimedia.org/T95145) (owner: 10Deskana) [19:35:39] dbrant are you making a separate request to get the "preview" data? or is it the same request you use to get the entire article [19:40:39] (03PS2) 10Bmansurov: Alpha: better parsing for a link title for quickLookup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 [19:40:54] bgerstle: it is indeed a separate request. i would imagine it could be rolled up into a single one (either using the existing API, or the new Node service). [19:41:45] 10Gather, 3Gather Sprint Enwiki: bug: funky scroll on add to collection overlay - https://phabricator.wikimedia.org/T95018#1183209 (10JKatzWMF) @jdlrobson. yest it is still happening. IOS 8.1.2, safari [19:44:57] dbrant right, was curious if you were able to avoid fetching the entire article payload [19:44:59] 3Gather Sprint Enwiki: long collection names create horizontal scrolling on creation overlay - https://phabricator.wikimedia.org/T95209#1183210 (10JKatzWMF) 3NEW [19:45:40] bgerstle: oh no, it's not the entire article. The "Extracts" extension just gives you the number of sentences that you ask for. [19:45:44] bgerstle: you can download individual sections from the API [19:46:02] dbrant and you ask for some other page property to get the lead image, i'm assuming [19:46:51] 10Gather, 3Gather Sprint Enwiki: long collection names create horizontal scrolling on creation overlay - https://phabricator.wikimedia.org/T95209#1183221 (10Jdlrobson) [19:47:10] bgerstle: yep, it's a single query with "pageimages|pageterms|extracts" [19:47:18] cool [19:50:57] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1183240 (10Jdlrobson) See https://lists.wikimedia.org/pipermail/wikitech-l/2015-April/081443.html Let's just add og:image [19:51:28] yurik: was it hard to add a page property? is that in prod already? [19:52:09] bgerstle, it is in production - see extension:graph [19:52:12] cool [19:52:13] it was fairly easy [19:52:22] dr0ptp4kt: did we already consider asking for something along these lines for lead image? [19:52:27] bgerstle, page props are very straightforward [19:53:32] yurik sorry, can i have a link? [19:54:19] (03CR) 10Florianschmidtwelzow: [C: 04-1] Alpha: better parsing for a link title for quickLookup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [19:54:52] coreyfloyd: let me know if you want to hang out and discuss my makefile/proj changes (i saw you commented on the wikipedia -> Wikipedia rename, i can revert that if you feel strongly about it) [19:55:02] bgerstle, http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGraph.git/a3a1b38f3f7ad25b99b697a7e7d9109c3396338a/Graph.body.php [19:55:34] bgerstle, more specifically - http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGraph.git/a3a1b38f3f7ad25b99b697a7e7d9109c3396338a/Graph.body.php#L56 [19:55:55] and also http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGraph.git/a3a1b38f3f7ad25b99b697a7e7d9109c3396338a/Graph.body.php#L115 [19:56:15] yurik any high-level docs? [19:56:21] about what? [19:56:54] how it was built, i guess [19:57:08] just curious [19:57:13] how what was built? Graph extension? or how to use setProperty ? [19:57:23] the graph extension [19:57:53] bgerstle, not yet, but hopefully soon :) https://www.mediawiki.org/wiki/Extension:Graph [19:58:24] ahh [19:58:32] i tried to go to wikipedia/wiki/Extension... [19:58:36] (d'oh) [20:01:36] jdlrobson: joakino will you hurry up and "launch" Gather so we can port it to native? kthxbai [20:03:14] (03CR) 10Dbrant: [C: 04-1] "When I switch my device language to Russian and share an article, the wordmark appears shifted too much to the right, and is cut off at th" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201732 (owner: 10BearND) [20:08:55] jdlrobson: what's "EL"? [20:09:18] oh duh event logging [20:11:32] (03CR) 10Bmansurov: Alpha: better parsing for a link title for quickLookup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [20:13:41] 10Gather: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1183276 (10Jdlrobson) 3NEW [20:17:05] 10Gather: API: Log when list gets hidden by an admin - https://phabricator.wikimedia.org/T93705#1183293 (10Jdlrobson) Can you investigate and open a new bug if that's the case? I'd rather we didn't have vague/unclear tasks like this lying around. [20:18:22] 10Gather: API: Log when list gets hidden by an admin - https://phabricator.wikimedia.org/T93705#1183300 (10JKatzWMF) @yurik can you verify my above assumption? [20:19:40] phuedx: you around still? [20:19:48] yeah a litle [20:19:53] about to start feeding harry [20:20:29] JonKatz, not sure which assumption? [20:21:01] jdlrobson: ^^ [20:21:17] hey phuedx so yeh the icon patch is in but basically we need the nearby refresh icon [20:21:26] and obviously need to test the crap out of it [20:21:35] might be worth merging it early in the week to allow time to pick up other issues [20:22:36] (03CR) 10Jdlrobson: [C: 032] Add gather-anon-view-lists to valid login-error messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202062 (https://phabricator.wikimedia.org/T94971) (owner: 10Florianschmidtwelzow) [20:23:13] jdlrobson: agreed [20:23:35] you really need the nearby refresh icon? [20:23:42] 10Gather, 5Patch-For-Review: Gather should explain to users why they're required to log in if they go to Special:Gather or Special:GatherLists - https://phabricator.wikimedia.org/T94971#1183332 (10Jdlrobson) 5Open>3Resolved [20:24:01] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather should explain to users why they're required to log in if they go to Special:Gather or Special:GatherLists - https://phabricator.wikimedia.org/T94971#1176952 (10Jdlrobson) [20:24:57] (03PS3) 10Jdlrobson: Up limit of collections listed in overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201355 [20:25:30] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Up paginationation limit - https://phabricator.wikimedia.org/T95219#1183352 (10Jdlrobson) 3NEW a:3Jdlrobson [20:25:40] (03PS4) 10Jdlrobson: Up limit of collections listed in overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201355 (https://phabricator.wikimedia.org/T95219) [20:26:08] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Up pagination limit - https://phabricator.wikimedia.org/T95219#1183366 (10Jdlrobson) [20:26:15] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Up pagination limit in collections content overlay - https://phabricator.wikimedia.org/T95219#1183352 (10Jdlrobson) [20:26:46] phuedx: without refresh icon the nearby page has no icon ;) [20:26:54] w/e [20:26:57] kill it ;) [20:27:00] okie poke [20:27:03] mw-ui-icon requires svgs [20:27:09] actually wait [20:27:11] i could do a hack [20:27:14] jdlrobson: don't hack [20:27:25] create a task for design in their backlog! [20:27:26] phuedx: well we are already hacking [20:27:27] :D [20:27:32] no jdlrobson [20:27:37] YOU are already hacking ;) [20:27:39] there is a bunch of icons that need svgs [20:27:55] to the design task cave! [20:28:19] phuedx: i'll create a task for all of them [20:28:39] (03Merged) 10jenkins-bot: Add gather-anon-view-lists to valid login-error messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202062 (https://phabricator.wikimedia.org/T94971) (owner: 10Florianschmidtwelzow) [20:30:05] (03PS4) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) [20:36:21] phuedx: BOOOM https://phabricator.wikimedia.org/T95224 [20:36:43] jdlrobson: \o/ [20:36:47] gonna feed harry [20:38:04] (03Abandoned) 10Jdlrobson: Kill onPersonalTools hook as this is being removed on MF [extensions/Gather] - 10https://gerrit.wikimedia.org/r/199159 (owner: 10Robmoen) [20:38:29] (03PS4) 10Jdlrobson: Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 [20:38:35] (03PS4) 10Jdlrobson: Redo watchstar creation so inside container [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) [20:38:41] (03PS2) 10Jdlrobson: Hygiene: Correction to ext.gather.api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 [20:40:28] (03PS3) 10Jdlrobson: Hygiene: Correction to ext.gather.api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 [20:41:08] (03CR) 10Florianschmidtwelzow: Alpha: better parsing for a link title for quickLookup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [20:41:41] (03PS2) 10Jdlrobson: Hygiene: Create separate module for initialisation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202060 [20:42:25] (03PS2) 10Jdlrobson: WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 [20:42:43] 10Gather, 3Gather Sprint Enwiki: Expose Gather as desktop beta feature - https://phabricator.wikimedia.org/T95227#1183633 (10Jdlrobson) 3NEW [20:43:04] 10Gather, 3Gather Sprint Enwiki: [Experimental] Expose Special:Watchlist type view of Gather lists - https://phabricator.wikimedia.org/T95228#1183641 (10Jdlrobson) 3NEW [20:43:24] (03PS3) 10Jdlrobson: WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T95227) [20:43:46] (03CR) 10Catrope: [C: 032] VisualEditorOverlay: Call TargetLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201843 (https://phabricator.wikimedia.org/T95044) (owner: 10Alex Monk) [20:44:26] (03CR) 10Bmansurov: [C: 04-1] Add support to deprecate a module (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [20:45:26] (03PS7) 10Jdlrobson: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) [20:45:31] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: [Experimental] Expose Special:Watchlist type view of Gather lists - https://phabricator.wikimedia.org/T95228#1183668 (10Jdlrobson) @kaldari would love some of your experimental time looking at this! :) [20:45:37] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Create separate module for initialisation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202060 (owner: 10Jdlrobson) [20:45:43] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Expose Gather as desktop beta feature - https://phabricator.wikimedia.org/T95227#1183671 (10Jdlrobson) a:3Jdlrobson [20:45:45] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add support to deprecate a module (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [20:45:52] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: [Experimental] Expose Special:Watchlist type view of Gather lists - https://phabricator.wikimedia.org/T95228#1183672 (10Jdlrobson) a:3Jdlrobson [20:46:06] (03Merged) 10jenkins-bot: VisualEditorOverlay: Call TargetLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201843 (https://phabricator.wikimedia.org/T95044) (owner: 10Alex Monk) [20:47:07] (03CR) 10jenkins-bot: [V: 04-1] WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T95227) (owner: 10Jdlrobson) [20:48:16] (03CR) 10jenkins-bot: [V: 04-1] Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) (owner: 10Jdlrobson) [20:48:38] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: [Experimental] Expose Special:Watchlist type view of Gather lists - https://phabricator.wikimedia.org/T95228#1183696 (10kaldari) @jdlrobson: Not sure I understand exactly what this is. Is this just a view of a Gather list using the typical page-list layout?... [20:48:41] (03CR) 10Jdlrobson: [C: 04-1] "I'm not sure about this approach." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [20:49:41] (03CR) 10Jdlrobson: "Another idea I have is having deprecated attribute on the class itself.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [20:50:21] (03CR) 10BearND: Hide search bar on saved pages and history sections if none exist (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) (owner: 10Mholloway) [20:51:34] kaldari: hey if you get a chance can you write a short summary of what we talked about - loading the infobox with js in beta? https://phabricator.wikimedia.org/T91712 [21:00:08] (03PS3) 10Bmansurov: Alpha: better parsing for a link title for quickLookup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 [21:00:22] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1183734 (10Jdlrobson) a:5MSyed>3Jdlrobson [21:00:36] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1183736 (10Jdlrobson) a:5Jhernandez>3Jdlrobson [21:02:42] 6Mobile-Web, 3Mobile Web Design: Move infobox below lead section in article - https://phabricator.wikimedia.org/T91712#1183740 (10kaldari) To avoid a flash of unstyled content, we may want to hide the infobox by default (in some top-loaded CSS), move the infobox below the lead, and then unhide it. If the lead... [21:04:34] kaldari: thank you!! [21:05:32] 6Mobile-Web: Page save spinner misplaced in beta - https://phabricator.wikimedia.org/T94881#1183764 (10bmansurov) a:3bmansurov [21:05:42] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: [Experimental] Implement an interface for multiple watchlists using Gather - https://phabricator.wikimedia.org/T95228#1183766 (10kaldari) [21:10:38] bearND: https://phabricator.wikimedia.org/T95080 [21:11:31] bearND: just got on irc. https://phabricator.wikimedia.org/T91510 [21:13:49] 6Mobile-Web, 10MobileFrontend, 10VisualEditor, 10VisualEditor-MediaWiki, and 3 others: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1183783 (10Krenair) 5Open>3Resolved Seems to be working now. [21:19:16] 6Mobile-Web, 10Browser-Tests, 6Collaboration-Team, 10Echo, and 2 others: Move user_agent string manipulation to the Ruby gem - https://phabricator.wikimedia.org/T678#1183813 (10Mattflaschen) [21:19:19] 6Mobile-Web, 10Browser-Tests, 6Collaboration-Team, 10Echo, 10Flow: Move user agent assignment to Ruby gem - https://phabricator.wikimedia.org/T73531#1183814 (10Mattflaschen) [21:19:55] yurik that card https://phabricator.wikimedia.org/T93705 that you created is about showing up in Special:Log [21:21:17] JonKatz, well, it could log the change to the logs table or to the RC table - up to you [21:21:37] don't admin actions go to logs generally? [21:22:58] JonKatz, AFAIK, Logs get anything where one person did something to another person - e.g. blocked, hidden, etc - so yes, admin actions [21:23:16] okay, thanks! [21:23:16] but i think theer was one exceptoin to that [21:24:37] JonKatz, for example, review log - https://en.wikipedia.org/w/index.php?title=Special%3ALog&type=review&user=&page=&year=&month=-1&tagfilter=&hide_patrol_log=1&hide_review_log=1&hide_thanks_log=1 [21:25:50] JonKatz, so i guess its not about "admin", but rather changes to content vs changes/viewing of non-content [21:26:16] a very shaky diff [21:26:33] yurik I think I see now :) [21:29:25] (03CR) 10Jdlrobson: [C: 032] Bring back the scroll event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202038 (https://phabricator.wikimedia.org/T94923) (owner: 10Jhernandez) [21:30:14] (03PS1) 10Jdlrobson: Hygiene: Move cancel-light icon into skins.minerva.icons.images module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202244 [21:31:53] (03Merged) 10jenkins-bot: Bring back the scroll event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202038 (https://phabricator.wikimedia.org/T94923) (owner: 10Jhernandez) [21:35:27] (03PS1) 10Dbrant: Fix issue with ToC onboarding when visiting subsequent pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202245 (https://phabricator.wikimedia.org/T95201) [21:48:17] (03PS1) 10Jdlrobson: Add ogimage tag [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202250 (https://phabricator.wikimedia.org/T91696) [21:49:25] 3Gather Sprint Enwiki: Sharing all your public collections - https://phabricator.wikimedia.org/T95239#1184003 (10Jdlrobson) 3NEW [21:51:58] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1184038 (10Jdlrobson) @bmansurov is the new icon reusable? Is it in MobileFrontend? Any... [21:52:26] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1184042 (10Jdlrobson) @msyed @jkatzwmf can you clarify when this shows? Is it after you... [21:54:12] (03PS1) 10Dbrant: Fix issue with moving the first paragraph in some articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202253 (https://phabricator.wikimedia.org/T94853) [21:55:11] coreyfloyd: have you been able to look at my other patches? [21:57:50] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1184072 (10bmansurov) @jdlrobson, it's in WikiGrok. It's not reusable though. See links... [22:01:18] bgerstle: looked but out for a bit longer. We can talk when I get back. [22:04:45] coreyfloyd: let's just slate it for tomorrow morning then [22:04:51] i'll be heading out shortly i think [22:17:24] 10Gather: API: Log when list gets hidden by an admin - https://phabricator.wikimedia.org/T93705#1184110 (10Yurik) @Jkatzwmf, Per IRC: logs are everything that is NOT wiki page edits. At this point, we treat gather lists as a special thing, whereas if we implement T94782, they will become data just like everythi... [22:17:40] JonKatz, ^ [22:18:31] understood. thank you. [22:18:49] yurik ^ [22:25:36] (03CR) 10Jdlrobson: [C: 04-1] "This is taken care of in https://gerrit.wikimedia.org/r/202089" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [22:26:57] (03PS1) 10Jdlrobson: Hygiene: Make confirm button optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 [22:29:44] (03PS2) 10Jdlrobson: Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 [22:29:47] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make confirm button optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [22:30:46] (03PS2) 10Jdlrobson: Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 [22:31:23] (03PS3) 10Jdlrobson: Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 [22:31:34] (03PS3) 10Jdlrobson: Add support for ContentOverlay in Vector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202054 [22:31:40] (03PS2) 10Jdlrobson: Hygiene: Make confirm button optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 [22:34:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make confirm button optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [22:37:17] (03CR) 10jenkins-bot: [V: 04-1] Add support for ContentOverlay in Vector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202054 (owner: 10Jdlrobson) [22:38:04] (03PS3) 10Jdlrobson: Hygiene: Create separate module for initialisation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202060 [22:38:06] (03PS1) 10Jdlrobson: Point at hamburger icon when a collection has been setup. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) [22:38:49] (03PS4) 10Jdlrobson: Add support for ContentOverlay in Vector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202054 [22:41:13] (03CR) 10jenkins-bot: [V: 04-1] Point at hamburger icon when a collection has been setup. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) (owner: 10Jdlrobson) [22:44:42] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: Add a new icon to collections in main menu - https://phabricator.wikimedia.org/T95245#1184173 (10Jdlrobson) 3NEW a:3Jdlrobson [22:48:01] bmansurov: how do i get the new icon to show? [22:48:22] jdlrobson: inserting it into the dom should do it [22:48:29] it's just a span [22:48:31] bmansurov: but how do i do it on bet labs [22:48:37] i'm not seeing it [22:48:38] jdlrobson: oh [22:48:48] jdlrobson: 1 sec, let me double check something [22:49:01] i really think this should be in MobileFrontend SkinMinervaBeta [22:49:49] also curious how you are doing i18n for it [22:50:54] jdlrobson: https://phabricator.wikimedia.org/diffusion/EWGR/browse/master/resources/dialog/WikiGrokDialog.js;2ae663389e6bc648b37ab2b668cfedf296338f03$348 [22:50:59] i18n [22:51:23] jdlrobson: do you have a link on beta labs that shows a wikigrok dialog/ [22:51:24] ? [22:51:47] bmansurov: so i'm expecting when i click on left menu http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=beta [22:51:50] next to contribute i see a new icon [22:51:55] that doesn't seem to be the case? [22:52:03] jdlrobson: to get the new to show, you need to answer the question, and at the end of the workflow click on tell me more [22:52:11] jdlrobson: after that you'll see the icon [22:52:15] huh? [22:52:22] where can i find a question [22:52:39] jdlrobson: that's what i'm trying to find, we need a page that has a wikigrok item on it [22:52:57] overriding the url isn't working on beta, maybe wikigrok is turned off there? [22:54:21] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: Add a new icon to collections in main menu - https://phabricator.wikimedia.org/T95245#1184173 (10Jdlrobson) @msyed does this show all the time or only when I click the hamburger icon after following the pointer? (The former is easiest)... [22:56:56] 10Gather, 3Gather Sprint Enwiki, 10Browser-Tests, 7Jenkins: Browser tests failing regularly due to styles not alway loading - https://phabricator.wikimedia.org/T94891#1175367 (10Jdlrobson) Dan... Zeljko.. any ideas why this might be happening? [23:04:18] jdlrobson: i can't get it working on beta labs, but i can tell you how to get it working locally if you're interested [23:08:02] (03PS1) 10Jdlrobson: Link tweakage - point name to user's collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202276 (https://phabricator.wikimedia.org/T91037) [23:08:40] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1184211 (10Jdlrobson) a:5MSyed>3Jdlrobson [23:12:47] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1184214 (10Jdlrobson) @msyed this is a hell of a lot easier if I stick it below the title. I'll do that for the time being. If you really nee... [23:29:13] (03PS1) 10BearND: ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202283 [23:31:30] (03PS2) 10BearND: ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201732 [23:32:20] (03PS3) 10BearND: ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201732 [23:32:34] (03Abandoned) 10BearND: ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202283 (owner: 10BearND) [23:38:15] (03PS1) 10Jdlrobson: Hygiene: Add support to Collection model for hidden status [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202286 [23:38:17] (03PS1) 10Jdlrobson: WIP: Add a tag showing privacy status [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202287 (https://phabricator.wikimedia.org/T93828) [23:38:34] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: User A who clicks on the name of the creator of a list (User B) is able to see a the list of lists created by User B, so that they can find more content from a source they like. - https://phabricator.wikimedia.org/T91037#1184282 (10Jdlrobson) a:3Jdlrobson [23:39:32] (03CR) 10BearND: [C: 032] Fix issue with ToC onboarding when visiting subsequent pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202245 (https://phabricator.wikimedia.org/T95201) (owner: 10Dbrant) [23:40:55] (03Merged) 10jenkins-bot: Fix issue with ToC onboarding when visiting subsequent pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202245 (https://phabricator.wikimedia.org/T95201) (owner: 10Dbrant) [23:41:14] dbrant: Hey! Can you get your prototype into gerrit? [23:41:27] dbrant: Also, can you change the long press to onClick? [23:45:02] Deskana: I've asked him earlier about that via email, and he said yes. We'll feature flag it for Alpha initially so designers and UX testers can check it out first. [23:45:12] bearND: Oh, sweet! Thanks. [23:50:02] 10Gather: API: Add event to "Logs" when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1184316 (10JKatzWMF) 3NEW [23:50:29] 10Gather: API: Add event to "Logs" when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1184323 (10JKatzWMF) @risker can you confirm that this card is an adequate way to display hide/unhide admin functions in the log? [23:50:42] 10Gather: API: Add event to "Logs" when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1184324 (10JKatzWMF) [23:50:58] (03PS1) 10Bmansurov: Alpha, beta: Fix page save spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202288 (https://phabricator.wikimedia.org/T94881) [23:54:54] 10Gather, 3Gather Sprint Enwiki: Removing articles with redirects with Gather api doesn't always remove them from Watchlist - https://phabricator.wikimedia.org/T94776#1184344 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson So I investigated this and there is nothing wrong with our API. The problem is the redir... [23:56:03] 10Gather: Unable to remove redirected pages from my collection - https://phabricator.wikimedia.org/T95251#1184348 (10Jdlrobson) 3NEW [23:56:22] 10Gather, 3Gather Sprint Enwiki: Removing articles with redirects with Gather api doesn't always remove them from Watchlist - https://phabricator.wikimedia.org/T94776#1172461 (10Jdlrobson) See T95251 [23:58:16] (03PS2) 10Jdlrobson: WIP: Add a tag showing privacy status [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202287 (https://phabricator.wikimedia.org/T93828) [23:58:22] 10Gather: Sending notification for users with 1 article in their collections in beta? - https://phabricator.wikimedia.org/T94525#1184365 (10JKatzWMF) Good call Florian and thanks for looking out.. we should think about ways to hint that aren't disturbing. [23:59:26] (03CR) 10Jdlrobson: [C: 04-1] "Don't comment out code. Either remove it altogether or use a hook to add it conditionally with a boolean. Commented out code is more dange" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202077 (https://phabricator.wikimedia.org/T95198) (owner: 10Florianschmidtwelzow)