[00:03:08] (03CR) 10Jdlrobson: [C: 04-1] "i18n is so easy you should just do it." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [00:08:35] (03CR) 10Jdlrobson: [C: 032] Alpha, beta: Fix page save spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202288 (https://phabricator.wikimedia.org/T94881) (owner: 10Bmansurov) [00:09:28] (03PS3) 10Jdlrobson: Hygiene: Make confirm button optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 [00:09:40] (03PS4) 10Jdlrobson: Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 [00:10:12] (03CR) 10Jdlrobson: [C: 032] "Well.. someone needs to move this along ;-) you only have yourself to blame if stuff breaks! :P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [00:10:24] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1184408 (10Jdlrobson) 5Open>3Resolved [00:11:04] (03Merged) 10jenkins-bot: Alpha, beta: Fix page save spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202288 (https://phabricator.wikimedia.org/T94881) (owner: 10Bmansurov) [00:11:51] 6Mobile-Web, 5Patch-For-Review: Page save spinner misplaced in beta - https://phabricator.wikimedia.org/T94881#1184415 (10Jdlrobson) 5Open>3Resolved Shoot this causes a regression in stable. I'd suggest getting https://gerrit.wikimedia.org/r/#/c/202089/ merged asap before thursday to avoid this going out t... [00:11:55] (03CR) 10jenkins-bot: [V: 04-1] Fix wikitable table borders [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [00:12:57] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: [Blocked] No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1184417 (10Jdlrobson) [00:14:10] (03PS8) 10Jdlrobson: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) [00:15:06] matanya: quick question for you on https://phabricator.wikimedia.org/T94853 [00:16:26] (03CR) 10Bmansurov: [C: 032] Hygiene: Don't add watchstar styles twice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202088 (owner: 10Jdlrobson) [00:16:53] (03PS2) 10BearND: More aggressively disable autocomplete suggestions for captcha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201990 (owner: 10Deskana) [00:18:56] (03CR) 10jenkins-bot: [V: 04-1] Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) (owner: 10Jdlrobson) [00:19:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't add watchstar styles twice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202088 (owner: 10Jdlrobson) [00:21:53] (03CR) 10BearND: [C: 032] More aggressively disable autocomplete suggestions for captcha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201990 (owner: 10Deskana) [00:24:23] (03PS3) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [00:25:48] (03CR) 10jenkins-bot: [V: 04-1] Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [00:31:11] (03CR) 10Bmansurov: [C: 04-1] "This is a lot of stuff. It maybe better to split it up into multiple patches. But, the -1 is for my inline comment." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [00:31:30] (03CR) 10Bmansurov: Hygiene: Don't add watchstar styles twice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202088 (owner: 10Jdlrobson) [00:31:41] (03CR) 10Bmansurov: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202088 (owner: 10Jdlrobson) [00:35:21] (03Merged) 10jenkins-bot: More aggressively disable autocomplete suggestions for captcha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201990 (owner: 10Deskana) [00:42:42] It is not comfortable that you guys don't have a flow-enabled page at mw.org where I can pipe feedback to. I wanted to say 2 things, one is that the 'star' icon better be a 'watch/eye' icon to avoid confusion, and another that the mobile menu thing contains no 'help' or 'contact, feedback, etc (pick a word)' sections which is bad. [00:49:29] (03Merged) 10jenkins-bot: Hygiene: Don't add watchstar styles twice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202088 (owner: 10Jdlrobson) [00:51:51] (03PS4) 10Bmansurov: Alpha: better parsing for a link title for quickLookup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 [00:52:55] 10Gather, 3Gather Sprint Enwiki, 10Browser-Tests, 7Jenkins: Browser tests failing regularly due to styles not alway loading - https://phabricator.wikimedia.org/T94891#1184474 (10dduvall) Interrupting the SauceLabs session and inspecting the console shows that the there are intermittent 403s ("Method Not Al... [00:53:03] (03CR) 10Bmansurov: [C: 032] "I'll blame kaldari. hah" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [01:03:48] (03Merged) 10jenkins-bot: Fix wikitable table borders [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199780 (https://phabricator.wikimedia.org/T92913) (owner: 10Bmansurov) [01:23:21] vibha: do you have a link to the asset in https://phabricator.wikimedia.org/T94936? Phab doesn't let me download it [02:08:16] (03PS2) 10BearND: WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) [02:10:38] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) (owner: 10BearND) [02:57:38] (03PS3) 10BearND: WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) [02:57:59] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) (owner: 10BearND) [03:00:30] (03PS1) 10BearND: Add private L10nUtils constructor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202314 [03:00:46] dbrant|food: u around? [03:01:20] bearND: yep! [03:01:33] dbrant: great. Just wanted a quick CR https://gerrit.wikimedia.org/r/#/c/202314/ [03:01:55] It's trivial enough that I would have self-merged almost, but since you are around it's better if you could [03:01:55] bearND: looking [03:02:14] just to get checkstyle behaving [03:03:55] (03CR) 10Dbrant: [C: 032] Add private L10nUtils constructor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202314 (owner: 10BearND) [03:04:02] dbrant: thanks [03:04:15] (03Merged) 10jenkins-bot: Add private L10nUtils constructor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202314 (owner: 10BearND) [03:06:35] (03PS4) 10BearND: ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201732 [03:07:54] (03PS5) 10BearND: ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201732 [03:08:52] (03PS4) 10BearND: WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) [03:09:11] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) (owner: 10BearND) [03:10:37] arrrg, why does this only happen on my patch? [03:12:43] (03PS1) 10BearND: Make L10nUtils final [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202317 [03:13:35] dbrant: one more please ^ [03:14:06] bearND: looking [03:15:03] (03CR) 10Dbrant: [C: 032] Make L10nUtils final [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202317 (owner: 10BearND) [03:15:10] ty [03:15:21] (03Merged) 10jenkins-bot: Make L10nUtils final [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202317 (owner: 10BearND) [03:18:59] (03PS5) 10BearND: WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) [03:29:44] /? [03:30:48] 10Gather: API: Add event to "Logs" when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1184576 (10Risker) @JKatzWMF - you've managed to confuse me already, because there are two separate types of "collection". (I've made some suggestions on the mailing list for different names that... [03:32:03] 10Gather: API: Add event to "Logs" when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1184577 (10Deskana) [03:33:06] niedzielski: Something up? :-) [03:35:11] 10Gather: Log when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1184578 (10Krenair) [03:35:28] https://www.mediawiki.org/w/index.php?title=Extension_talk:MobileFrontend&action=edit bugzilla works no more, please update the URL - I have no idea how to make such URLs in the new system. [03:42:50] 10Gather: API: Log when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1184579 (10Yurik) [03:49:12] This bot is annoying. It should use notices for readability of channel. [03:50:08] Pff, it's only logging mobile-related stuff [03:50:43] mobile things just happen to be particularly active right now [03:53:11] Deskana: sorry :) still getting used to this irc client [03:53:34] Krenair: my line is hard to distinguish from bot lines. [03:53:46] I spent quite a bit of time looking for my text among that stuff. [03:54:25] Hey niedzielski. How are you? What IRC client are you using? [03:55:22] hey bernd! i'm trying out a new workflow using weechat. still a bit on the fence about it [03:56:33] k [03:57:19] oh, hi niedzielski [03:58:27] weechat is cool. especially if you don't lag between you and the box weechat is on. it has a pretty qt client to it too :) [03:58:45] heyy Krenair! [03:59:08] how's it going? [03:59:22] svetlana i'm using weechat from a tmux window. i'll have to check out the qt client [04:00:06] qweechat; easy to install iirc [04:02:26] krenair, going well! forgive me, i'm sure we've met but i'm having a hard time placing the username to person :) [04:02:36] svetlana will check out. thanks! [04:03:13] I was talking to you yesterday about mobile stuff here [04:03:13] :-) [04:03:24] mailing lists and things [04:04:45] oh, right. yes! sorry about that [04:04:57] well the good news is i got on the mailing list :) [04:23:13] (03PS1) 10Fjalapeno: Fixing unit tests and running tests in alpha lane T94421 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 [04:26:51] (03PS1) 10Fjalapeno: Update readme for tip on nokogiri [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202324 [05:03:58] (03PS2) 10Jdlrobson: Point at hamburger icon when a collection has been setup. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) [05:05:20] (03PS9) 10Jdlrobson: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) [05:21:04] vibha: how do you download the asset from https://phabricator.wikimedia.org/T94936#1184720? [05:22:18] vibha: looks like only email worked [05:22:37] bearND: oh good [05:22:48] ya - phabricator can be strange sometimes [05:23:51] bearND: any idea about the other phab bug > navigation? [05:23:55] bearND: Click on the image, then look at the bottom right of the screen for the download button [05:24:16] bearND: Because putting the button in a sensible, viewable place would make sense, so we decided not to do that. #justphabricatorthings [05:24:36] Deskana: Yes, I've used the Download link at the bottom but it always told me server error [05:24:58] Oh, weird. It worked fine for me, so I just assumed you hadn't seen it since it's a really stupid place to put it. [05:25:06] Sorry about that. [05:25:10] 10Gather: API: Log when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1184721 (10JKatzWMF) Hi Risker--yes, I apologize. I am trying to refer to this as a 'Gather collection' to make it a little less confusing. The naming of Gather items as "collections" is a case where we made th... [05:25:32] Deskana: are you able to download it successfully? [05:25:36] bearND: Yeah [05:25:44] https://phabricator.wikimedia.org/T95067 [05:25:56] 10Gather: API: Log when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1184722 (10JKatzWMF) [05:26:03] Deskana: are you using Chrome? [05:26:17] bearND: Oh... [05:26:26] bearND: So when I click it, it opens full screen in my browser. [05:26:36] Deskana: yes, I got that far [05:26:38] bearND: Then when I right click and "Save image as...", I get that problem. Server error. [05:26:44] Bingo [05:26:55] * Deskana sighs [05:26:59] #justphabricatorthings [05:27:25] Deskana: Anyways Vinha sent me the file via email. So, it's uploaded to the store for the main app now [05:27:38] will take a few hours to populate [05:27:39] Great. [05:27:55] probably should do the same for beta [05:31:38] Deskana: wow, that was a very quick move to "resolved". Let's hope it was not premature. I would prefer to wait for validation next time. [05:34:14] I can un-close. [05:35:51] omg, I just saw the lead image for the snoopy article [05:37:22] I'm going to make a collection of articles which have better high res images in the gallery, but they are just not lead images. [05:37:45] bearND: any way to test how the composition looks on play store? [05:38:03] (referring to the banner image) [05:39:01] vibha: I guess we'll have to wait until it's propagated. I haven't seen a preview option in the store listing UI [05:39:24] This will come into effect only when we submit the new beta build right? [05:40:19] vibha: No. This is become effective once it's propagated (in a few hours). I've done it for the production app since that's the one that was off the most. [05:41:02] oh perfect. I'll take a look in the morning then! [05:41:07] thanks bearND [05:41:37] Let's hope this works, because I don't have a backup of the old image, or an alternate image. [05:41:50] vibha: ^ There's no undo option [05:42:06] only submit, and that's it [05:48:57] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Use mw-ui-icon in stable (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [06:13:12] (03PS2) 10Mholloway: Hide search bar on saved pages and history sections if none exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) [06:20:27] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [06:24:48] (03PS2) 10Phuedx: [Alpha] Minor Special:MobileMenu improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201484 (https://phabricator.wikimedia.org/T94458) [06:27:52] phuedx: ygm [06:28:02] hey YuviPanda [06:28:08] you in sf yet? [06:28:15] Yessssss [06:28:17] :D [06:28:30] Hiccuping for the last26h tho [06:30:42] wha!? [06:30:45] 26 hours!? [06:30:52] Ya [06:30:55] Insane [06:31:30] you need a few jump scares or something [06:31:51] watch a few "five nights at freddy's" play through videos [06:53:01] 6Mobile-Web: Page issues and wikidata description text too large - https://phabricator.wikimedia.org/T95206#1184803 (10phuedx) @KHammerstein: Hrrrm. Honestly, I don't remember discussing it. Regardless, page issues and the Wikidata description have a font size of 1.05 em in alpha and beta. [07:05:38] (03PS1) 10Phuedx: [Alpha|Beta] Wikidata description/issues to 0.8em [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202330 (https://phabricator.wikimedia.org/T95206) [07:09:06] (03CR) 10jenkins-bot: [V: 04-1] [Alpha|Beta] Wikidata description/issues to 0.8em [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202330 (https://phabricator.wikimedia.org/T95206) (owner: 10Phuedx) [07:15:42] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202330 (https://phabricator.wikimedia.org/T95206) (owner: 10Phuedx) [08:09:08] morning [09:10:50] 3Gather Sprint Enwiki: Hygiene: use global php classes without front \ - https://phabricator.wikimedia.org/T95270#1184996 (10Jhernandez) 3NEW a:3Jhernandez [09:11:07] (03PS1) 10Jhernandez: Hygiene: Consistent use of global php classes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202355 (https://phabricator.wikimedia.org/T95270) [09:15:59] hey joakino [09:16:30] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: [Experimental] Implement an interface for multiple watchlists using Gather - https://phabricator.wikimedia.org/T95228#1185015 (10Jhernandez) This is awesome, ☑️ Multiple watchlists [09:16:39] morning phuedx [09:28:59] YuviPanda: yt? [09:41:34] (03PS1) 10Pastakhov: fix mwextModes property of CodeMirror editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202360 (https://phabricator.wikimedia.org/T91796) [09:46:15] phuedx: YuviPanda is Pacific Time now… [09:46:23] yeah [09:46:28] i was chatting with him a little earlier [09:46:33] ta prtksxna [09:47:30] phuedx: o/ [09:49:47] (03CR) 10Florianschmidtwelzow: [C: 032] fix mwextModes property of CodeMirror editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202360 (https://phabricator.wikimedia.org/T91796) (owner: 10Pastakhov) [10:03:07] (03Merged) 10jenkins-bot: fix mwextModes property of CodeMirror editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202360 (https://phabricator.wikimedia.org/T91796) (owner: 10Pastakhov) [10:23:25] (03CR) 10Phuedx: [C: 04-1] "To avoid repeating yerself too much you could make a MobileFrontendSchema base class, which is MF-specific, and all MF schemas would exten" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 (owner: 10Jdlrobson) [10:53:16] (03CR) 10Phuedx: [C: 032] "LGTM and works as expected." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 (owner: 10Jdlrobson) [11:00:53] (03CR) 10Phuedx: [C: 04-1] "Minor documentation tweaks required." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202054 (owner: 10Jdlrobson) [11:01:50] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202330 (https://phabricator.wikimedia.org/T95206) (owner: 10Phuedx) [11:03:18] (03CR) 10Phuedx: [C: 032] Hygiene: Move cancel-light icon into skins.minerva.icons.images module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202244 (owner: 10Jdlrobson) [11:08:21] (03CR) 10Jhernandez: [C: 04-1] "Awesome patch." (0339 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) (owner: 10Jdlrobson) [11:18:00] (03CR) 10Phuedx: [C: 04-1] "Two teeny-tiny minors and a discussion point inline." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [11:18:31] (03CR) 10Phuedx: "I'm happy to merge this once the minors are fixed by the way. We can fiddle with wording separately." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [11:21:03] (03CR) 10Jhernandez: Special Edit feed (0333 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) (owner: 10Jdlrobson) [11:21:58] (03PS10) 10Jhernandez: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) (owner: 10Jdlrobson) [11:23:30] (03CR) 10Jhernandez: [C: 04-1] "Alrighty I've fixed most of the comments (the hygiene annoyances), so basically this is what I'd like you to have a look at:" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) (owner: 10Jdlrobson) [11:25:49] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: [Experimental] Implement an interface for multiple watchlists using Gather - https://phabricator.wikimedia.org/T95228#1185203 (10Jhernandez) Been reviewin', left a bunch of comments, fixed a bunch of stuff later, and left the comments that need comment on a... [11:30:18] (03CR) 10Jhernandez: [C: 032] Link tweakage - point name to user's collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202276 (https://phabricator.wikimedia.org/T91037) (owner: 10Jdlrobson) [11:31:36] (03CR) 10Florianschmidtwelzow: [C: 04-1] "except from this minor-minor thing: +1" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [11:32:48] (03Merged) 10jenkins-bot: Link tweakage - point name to user's collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202276 (https://phabricator.wikimedia.org/T91037) (owner: 10Jdlrobson) [11:40:03] 6Mobile-Web, 10MobileFrontend, 10VisualEditor, 10VisualEditor-MediaWiki, and 3 others: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1185233 (10Jdforrester-WMF) p:5Triage>3Unbreak! [11:42:15] 10Gather: API: Log when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1185237 (10Risker) >>! In T95250#1184721, @JKatzWMF wrote: > The naming of Gather items as "collections" is a case where we made things harder for everyone close to the project, including WMF, in order to make i... [11:44:50] werdna: your meld of May's icon info with matmarex's was a thing of beauty in a slough of confusion. When will it be on http://livingstyleguide.wmflabs.org/wiki/Main_Page [11:45:02] sorry [11:51:01] (03PS2) 10Jhernandez: Add ogimage tag [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202250 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [11:51:33] (03CR) 10Jhernandez: Add ogimage tag (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202250 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [11:52:29] (03CR) 10Jhernandez: [C: 032] "* Fixed the problems" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202250 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [11:55:51] (03CR) 10Jhernandez: [C: 032] Up limit of collections listed in overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201355 (https://phabricator.wikimedia.org/T95219) (owner: 10Jdlrobson) [12:01:45] (03Merged) 10jenkins-bot: Add ogimage tag [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202250 (https://phabricator.wikimedia.org/T91696) (owner: 10Jdlrobson) [12:01:47] (03Merged) 10jenkins-bot: Up limit of collections listed in overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201355 (https://phabricator.wikimedia.org/T95219) (owner: 10Jdlrobson) [12:38:09] yo [12:38:17] back from lunch [12:52:49] brb -- talking to builder [13:19:51] out to lunch [13:30:43] that was not a bb [13:30:45] *brb [14:25:04] (03CR) 10Phuedx: [C: 04-1] Filter out retired WikiGrok claims from WikiGrok pages (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [14:26:29] (03CR) 10Phuedx: "This is looking good. A minor to tidy up and then it's on to testing this out!" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [14:27:02] 6Mobile-Web, 10Browser-Tests: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1185778 (10Krinkle) [14:40:12] coreyfloyd: let me know when you're around. would like to go through my patches when you're ready to review [14:42:39] (03CR) 10Bgerstle: [C: 031] "+1...x10^9999999" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [14:43:10] 6Mobile-Web: Window on leave code in editor overlay should be reusable or dropped - https://phabricator.wikimedia.org/T94194#1185897 (10phuedx) See @Florian's efforts over at T88949. [14:43:36] (03PS2) 10Phuedx: Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [14:50:12] bgerstle: walking the dog. Bb in a bit [14:51:04] 6Mobile-Web: Investigate existing site speed metrics - https://phabricator.wikimedia.org/T95296#1185940 (10phuedx) 3NEW [14:53:29] 6Mobile-Web: Design and review site speed schemas - https://phabricator.wikimedia.org/T95297#1185964 (10phuedx) 3NEW [14:53:41] 6Mobile-Web: Design site speed schemas - https://phabricator.wikimedia.org/T95297#1185964 (10phuedx) [14:54:31] (03CR) 10Bgerstle: [C: 031] "I'm a little ambivalent about having CI-related stuff on the README, as we're the only ones who should be messing with that. But, until we" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202324 (owner: 10Fjalapeno) [14:55:11] (03CR) 10Bgerstle: "also, you're a better man than me for fixing the tests, i would've just disabled them :-P" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [14:55:19] 6Mobile-Web, 7Epic: Instrument the schemas designed in T95297 - https://phabricator.wikimedia.org/T95299#1185987 (10phuedx) 3NEW [14:55:34] (03CR) 10MaxSem: [C: 04-1] Filter out retired WikiGrok claims from WikiGrok pages (034 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [14:57:02] 6Mobile-Web: Create a mobile site speed dashboard - https://phabricator.wikimedia.org/T95300#1185993 (10phuedx) 3NEW [15:01:06] 6Mobile-Web: Send regular mobile site speed reports - https://phabricator.wikimedia.org/T95301#1186007 (10phuedx) 3NEW [15:01:47] 6Mobile-Web: Send regular mobile site speed reports - https://phabricator.wikimedia.org/T95301#1186007 (10phuedx) [15:02:27] 6Mobile-Web, 7Epic: Continuously measure mobile site speed - https://phabricator.wikimedia.org/T94752#1186025 (10phuedx) [15:03:09] MaxSem: when are you travelling again? [15:03:28] last saturday [15:05:01] kristenlans: i just reordered the mobile-web columns because i'm creating a load of feature request sub tasks and i can't bulk move tasks :( [15:10:45] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1186057 (10Tvx1) 5Resolved>3Open [15:12:09] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1123758 (10Tvx1) This is not resolved. If you take a look at the tables that use the border= paramater in this link: [https://en.m.wikipedia.org/wiki/2014_Formula_One_season... [15:18:42] 10Gather: API: Log when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1186072 (10JKatzWMF) @risker. Thank you for your input on logs, name and name space, and I am sorry my attempts at addressing your concerns had the opposite effect. I would like to continue this conversation, as... [15:19:51] (03CR) 10Phuedx: [C: 031] "Ping @Jdlrobson, @Florianschmidtwelzow." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [15:20:32] 10Gather: Convert Gather collections into "wiki pages" - https://phabricator.wikimedia.org/T94782#1186075 (10Risker) I strongly support moving these out of the "Special" namespace because administrators need to be able to delete them. I personally can foresee these pages being easily abused, and also foresee th... [15:22:17] phuedx: I *believe* you can get special permission to bulk move tasks y requesting membership in the Phab project "Triagers": https://phabricator.wikimedia.org/tag/triagers/ and https://www.mediawiki.org/wiki/Phabricator/Help#Batch_Edits [15:23:11] I actually more than believe it; I know it. [15:25:43] 6Mobile-Web: Rephrase "Last edited..." in mobile web UI and link only to page history - https://phabricator.wikimedia.org/T94298#1186081 (10Qgil) What data is needed? [15:27:37] (03PS2) 10Phuedx: Alpha, Beta: Wikidata description/issues to 0.8em [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202330 (https://phabricator.wikimedia.org/T95206) [15:31:50] 6Mobile-Web: If a user is blocked from editing a page (due to the false group), there should be a link to the history - https://phabricator.wikimedia.org/T95305#1186101 (10Florian) 3NEW a:3Florian [15:31:53] bgerstle: ready to hang? [15:32:03] sure [15:32:52] coreyfloyd: direct call or http://appalachiantrials.com/wp-content/uploads/2015/02/Batsignal.png ? [15:33:16] just call me… never know the that permanent url anyways [15:34:01] ring ring [15:34:06] 10Gather, 6Mobile-Web, 3Mobile Web Design, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1186120 (10phuedx) a:5MSyed>... [15:35:00] FlorianSW: you've got a lot of open patches -- is there anything i can help with? [15:36:26] phuedx: currently working on it, i thought i got some time at easter, but not as much as i thought. So, if you have some time you can give me? :D I hope i can reduce the number of open patches in the next time :) [15:37:22] 10Gather, 6Mobile-Web, 3Mobile Web Design, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1186139 (10phuedx) @Jdlrobson:... [15:37:47] FlorianSW: i'll think all of your stuff is reviewed [15:37:50] me looks [15:38:20] phuedx: i think so, too [15:38:28] FlorianSW: that's probably quite a small change: https://gerrit.wikimedia.org/r/#/c/202077/ ;) [15:38:56] :P [15:40:29] bgerstle: coreyfloyd just wanted to mention that i haven't forgotten about the release or source code review wiki updates and emails. i got started on the release wiki update yesterday, and also talked with YuviPanda and gwicke yesterday about the source code control to get more info and also give a heads up. [15:41:02] bgerstle: coreyfloyd forgive me if i'm delayed in responding on irc. using the web interface today. no, i'm not yet signing up for third party bouncers ;) [15:46:10] 10Gather, 6Mobile-Web, 3Mobile Web Design, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1186167 (10Jdlrobson) A collect... [15:50:19] (03PS1) 10Pastakhov: Lets CodeMirror automatically resize to fit its content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202421 (https://phabricator.wikimedia.org/T91796) [15:54:51] 10Gather, 10MediaWiki-extensions-PageImages, 10WikiGrok: Cropped images generated by PageImages don't always include main subject - https://phabricator.wikimedia.org/T94256#1186197 (10Nemo_bis) p:5Triage>3Low [15:57:42] (03PS1) 10Florianschmidtwelzow: Add link to history page, if the user can't edit a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202424 (https://phabricator.wikimedia.org/T95305) [15:58:26] (03CR) 10Pastakhov: [C: 04-1] Lets CodeMirror automatically resize to fit its content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202421 (https://phabricator.wikimedia.org/T91796) (owner: 10Pastakhov) [15:58:58] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1186220 (10Jdlrobson) 5Open>3Resolved @tvx1 the patch has not been deployed yet (it will go out when the site is next updated (this doesn't happen instantaneous) you can... [15:59:02] (03PS2) 10Florianschmidtwelzow: Disable mobile.fontchanger after it is useful again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202077 (https://phabricator.wikimedia.org/T95198) [15:59:58] 10Gather, 6Mobile-Web, 3Mobile Web Design, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1186226 (10phuedx) OK. So I thi... [16:00:35] (03CR) 10Florianschmidtwelzow: "Hmm, i'm not sure, if we need to complicate this thing so much :) But let's talk on mobile-l about that." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [16:01:14] (03CR) 10Fjalapeno: [C: 031] fix case of Wikipedia folder [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202086 (owner: 10Bgerstle) [16:01:33] (03CR) 10Fjalapeno: [C: 031] commit web assets and remove build scripts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202087 (https://phabricator.wikimedia.org/T94231) (owner: 10Bgerstle) [16:01:45] (03CR) 10Fjalapeno: [C: 031] makefile: add "easy button" to install dependencies [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202051 (https://phabricator.wikimedia.org/T94229) (owner: 10Bgerstle) [16:01:55] (03CR) 10Fjalapeno: [C: 031] commit Pods folder [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202040 (https://phabricator.wikimedia.org/T94039) (owner: 10Bgerstle) [16:01:57] FlorianSW: /me waits for jerkins to v+2 that patch ;) [16:02:00] thanks dr0ptp4kt_cold, might ask for some +2's on project stuff ^ [16:02:14] phuedx: which one? oO :D [16:02:25] FlorianSW: 202077 [16:02:46] ok, great! Thanks [16:02:49] phuedx: ^ [16:03:26] (03CR) 10Fjalapeno: "Yep - if you use a gesture recognizer you no longer need the scroll vie delegate." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/190960 (owner: 10Rahdev) [16:05:07] (03CR) 10Fjalapeno: "bgerstle is putting this in his upcoming readme patch… abandoning…" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202324 (owner: 10Fjalapeno) [16:05:11] (03Abandoned) 10Fjalapeno: Update readme for tip on nokogiri [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202324 (owner: 10Fjalapeno) [16:06:42] (03CR) 10Phuedx: [C: 032] Disable mobile.fontchanger after it is useful again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202077 (https://phabricator.wikimedia.org/T95198) (owner: 10Florianschmidtwelzow) [16:09:02] (03PS2) 10Pastakhov: Lets CodeMirror automatically resize to fit its content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202421 (https://phabricator.wikimedia.org/T91796) [16:09:59] (03CR) 10Pastakhov: [C: 031] Lets CodeMirror automatically resize to fit its content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202421 (https://phabricator.wikimedia.org/T91796) (owner: 10Pastakhov) [16:15:10] 10Gather: Use extension.json, deprecate use of Gather.php for registering config - https://phabricator.wikimedia.org/T91802#1186288 (10Legoktm) [16:18:26] (03Merged) 10jenkins-bot: Disable mobile.fontchanger after it is useful again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202077 (https://phabricator.wikimedia.org/T95198) (owner: 10Florianschmidtwelzow) [16:25:19] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1186365 (10Deskana) @Mholloway You're right to ask this question. It's a careful balancing act between giving them information that we can understand (which error codes are not u... [16:27:28] (03PS3) 10Florianschmidtwelzow: Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) [16:28:02] jdlrobson: can you recheck https://gerrit.wikimedia.org/r/#/c/199640/ ? :) [16:28:06] phuedx: ^ [16:28:09] ? [16:28:41] FlorianSW: i forget.. what was the issue with it before? [16:28:55] 6Mobile-Web, 10VisualEditor: None of the toolbar buttons work when editing using VE in mobile view - https://phabricator.wikimedia.org/T94425#1186404 (10Jdforrester-WMF) 5Open>3Resolved [16:29:02] 6Mobile-Web, 10VisualEditor: None of the toolbar buttons work when editing using VE in mobile view - https://phabricator.wikimedia.org/T94425#1162977 (10Jdforrester-WMF) Dealt with in other tickets. [16:29:58] jdlrobson: you said, that mobile.notifications needs to be moved to the hook, too. But the module doesn't depend on Echo :) [16:30:15] (03CR) 10Jdlrobson: Hygiene: Don't add Echo modules, if Echo isn't installed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 (owner: 10Florianschmidtwelzow) [16:30:18] (03CR) 10jenkins-bot: [V: 04-1] Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [16:30:52] FlorianSW: but it does.. [16:30:53] loadModuleScript( 'mobile.notifications.overlay' ) [16:31:04] it binds the route [16:31:09] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1186412 (10Tvx1) I'm not able to test it on the test cluster, because the border= parameter doesn't seem to work there at all. [16:31:19] does anyone know, why jenkins doesn't love this change? https://gerrit.wikimedia.org/r/#/c/197693/ :/ [16:31:57] https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit/12920/consoleFull [16:32:00] jdlrobson: yes, but it is only loaded, if Echo is installed (somewhere in SkinMinerva). The module itself _could_ be loaded without Echo without a failing ResourceLoader :) [16:32:06] Notice: Undefined variable: wgMFContentNamespace in /mnt/jenkins-workspace/workspace/mwext-MobileFrontend-qunit/src/extensions/MobileFrontend/includes/MobileFrontend.hooks.php on line 375 [16:32:49] FlorianSW: that's very confusing... the sooner we move this stuff to Echo the better :-/ there is another issue with the patch if you look again [16:33:07] jdlrobson: argh, thanks, haven't seen this :D [16:33:13] jdlrobson: what issue you mean? [16:35:01] (03PS14) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [16:37:39] 6Mobile-Web, 10Browser-Tests, 6Collaboration-Team, 10Echo, 10Flow: Move user agent assignment to Ruby gem - https://phabricator.wikimedia.org/T73531#1186439 (10dduvall) We should try to name the step to be clearer to its intention. What about "my browser doesn't support JavaScript", or "I have JavaScript... [16:37:43] (03Abandoned) 10Florianschmidtwelzow: Hygiene: Align watchstars correctly in SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/193657 (https://phabricator.wikimedia.org/T91178) (owner: 10Florianschmidtwelzow) [16:39:35] (03PS2) 10Florianschmidtwelzow: Hygiene: Don't add Echo modules, if Echo isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 [16:39:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't add Echo modules, if Echo isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 (owner: 10Florianschmidtwelzow) [16:40:57] (03CR) 10Fjalapeno: "comments" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [16:41:58] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1186464 (10Jdlrobson) @Tvx1 I assume this is the page you are testing on: https://en.m.wikipedia.org/wiki/2015_Formula_One_season ? If so I have imported the page to the tes... [16:42:05] (03PS3) 10Florianschmidtwelzow: Hygiene: Don't add Echo modules, if Echo isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 [16:43:23] 10Wikipedia-Android-App: Paragraph should not be moved to top on definition pages - https://phabricator.wikimedia.org/T95312#1186465 (10bearND) 3NEW [16:44:00] (03PS2) 10Fjalapeno: Fixing unit tests and running tests in alpha lane T94421 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 [16:44:20] 10Wikipedia-Android-App: Paragraph should not be moved to top on definition pages - https://phabricator.wikimedia.org/T95312#1186472 (10bearND) [16:44:43] 10Wikipedia-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice, 7user-notice: Production release for iOS Wikipedia app on Monday 13th April 2015 - https://phabricator.wikimedia.org/T86692#1186474 (10dr0ptp4kt) TSG findings not blockers, per @Deskana. [16:45:30] (03PS4) 10Florianschmidtwelzow: Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) [16:48:33] (03CR) 10jenkins-bot: [V: 04-1] Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [16:48:46] jdlrobson: gonna be a little bit late to the pow pow pow [16:48:50] wow wow wow [16:48:52] yippie yo [16:48:54] etc [16:49:00] lisa's had to go to the doctor [16:49:12] just helping george with his dinner [16:50:26] (03CR) 10Florianschmidtwelzow: [C: 031] Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [16:56:44] hey bearND, no rush but i sent you a message about the server error issue [16:58:24] mholloway: ah, i see now [16:59:22] bearND: didn't want to disturb you if you were breaking for lunch or something [17:00:23] 10Gather, 3Gather Sprint Enwiki, 10Browser-Tests, 7Jenkins: Browser tests failing regularly due to styles not alway loading - https://phabricator.wikimedia.org/T94891#1186563 (10Jdlrobson) @dduval thanks for the explanation! So has the Gather job been switched to Chrome version 41 now? Can I call this clo... [17:03:41] phuedx: pow WOW [17:04:34] rmoen: ^ [17:05:32] mholloway: no worries. It's not lunch time for me yet. And even if it was I would probably change my nick to reflect that [17:05:33] jdlrobso_: Running a little bit late [17:06:02] mholloway: you can ping me anytime, you may just get the response a bit later [17:06:42] Oh yeah, you're on Mountain time. For some reason this morning I was putting you in Eastern time. [17:08:47] (03PS5) 10Bmansurov: Alpha: better parsing for a link title for quickLookup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 [17:11:09] (03CR) 10BearND: [C: 04-1] "Almost there." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) (owner: 10Mholloway) [17:16:37] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Text flow is wrong in landscape but not portrait orientation - https://phabricator.wikimedia.org/T94853#1186615 (10bearND) [17:17:24] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Text flow is wrong in landscape but not portrait orientation - https://phabricator.wikimedia.org/T94853#1174478 (10bearND) @Matanya Thank you. I've updated the title and description to reflect this. [17:19:17] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Text flow is wrong in landscape but not portrait orientation - https://phabricator.wikimedia.org/T94853#1186619 (10bearND) [17:19:23] (03PS3) 10Mholloway: Hide search bar on saved pages and history sections if none exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) [17:22:54] (03PS4) 10BearND: Hide search bar on saved pages and history sections if none exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) (owner: 10Mholloway) [17:26:24] coreyfloyd: https://phabricator.wikimedia.org/T95318 . i think having a 'crash app' button in the More... menu is out of scope for that card, but for extra credit that might be nice for assurance that the crash reporting is working. of course with asserts in force, using an image gallery is almost currently like a surefire way to initiate a crash lol [17:27:03] (03PS1) 10Fjalapeno: Enable crash reporting for Alpha builds T95318 Also cleanup and encapsulate crash reporting logic - boyscout rule [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202444 [17:27:13] dr0ptp4kt_cold: thanks ^ [17:29:04] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Text flow is wrong in landscape but not portrait orientation - https://phabricator.wikimedia.org/T94853#1186674 (10bearND) [17:29:06] 10Wikipedia-Android-App: Paragraph should not be moved to top on definition pages - https://phabricator.wikimedia.org/T95312#1186673 (10bearND) [17:29:25] (03PS2) 10BearND: Fix issue with moving the first paragraph in some articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202253 (https://phabricator.wikimedia.org/T94853) (owner: 10Dbrant) [17:29:53] (03CR) 10BearND: [C: 032] Hide search bar on saved pages and history sections if none exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) (owner: 10Mholloway) [17:30:22] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Select icon file based on build type (alpha, beta, etc) on build server - https://phabricator.wikimedia.org/T94534#1165857 (10Fjalapeno) [17:32:02] 10Gather, 3Gather Sprint Enwiki, 10Browser-Tests, 7Jenkins: Browser tests failing regularly due to styles not alway loading - https://phabricator.wikimedia.org/T94891#1186703 (10dduvall) 5Open>3Resolved a:3dduvall Right, it looks like the builder has since been refactored to not explicitly specify th... [17:32:15] Deskana bgerstle kristenlans vibha dr0ptp4kt_cold FYI shuffled some cards into the Qa sign off column [17:32:22] (03Merged) 10jenkins-bot: Hide search bar on saved pages and history sections if none exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201849 (https://phabricator.wikimedia.org/T94974) (owner: 10Mholloway) [17:32:33] (03PS3) 10BearND: Fix issue with moving the first paragraph in some articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202253 (https://phabricator.wikimedia.org/T94853) (owner: 10Dbrant) [17:32:59] coreyfloyd: thanks, I see normalized text may be fixed [17:33:17] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: Add a new icon to collections in main menu - https://phabricator.wikimedia.org/T95245#1186722 (10MSyed) I think for now, it should only show up after following the pointer. [17:33:55] (03CR) 10BearND: [C: 032] Fix issue with moving the first paragraph in some articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202253 (https://phabricator.wikimedia.org/T94853) (owner: 10Dbrant) [17:34:13] (03Merged) 10jenkins-bot: Fix issue with moving the first paragraph in some articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202253 (https://phabricator.wikimedia.org/T94853) (owner: 10Dbrant) [17:36:25] bmansurov: hallo. [17:36:30] I need a tiny bit of Uzbek help. [17:36:36] aharoni: good day, sure [17:37:12] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Banner Image for Google Play Store is inconsistent with branding. - https://phabricator.wikimedia.org/T94936#1186735 (10bearND) a:5Vibhabamba>3bearND [17:37:36] bmansurov: to translate three messages for ContentTranslation: [17:37:39] https://translatewiki.net/w/i.php?title=MediaWiki:Cx-campaign-newarticle-notice/uz&action=edit [17:37:43] https://translatewiki.net/w/i.php?title=MediaWiki:Cx-campaign-try/uz&action=edit [17:37:45] https://translatewiki.net/w/i.php?title=MediaWiki:Cx-campaign-no-thanks/uz&action=edit [17:38:30] aharoni: ok, after this meeting ;) [17:38:37] thanks [17:39:13] np [17:39:41] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Banner Image for Google Play Store is inconsistent with branding. - https://phabricator.wikimedia.org/T94936#1186742 (10bearND) @Vibhabamba Uploaded for production app. You may need to clear the Play Store cache to see the update on your client. I did. No... [17:44:24] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Text flow is wrong in landscape but not portrait orientation - https://phabricator.wikimedia.org/T94853#1186801 (10Rita2008) In Artikel https://de.wikipedia.org/wiki/Gilde Text "Gilde ist der Familienname folgender Personen" is on To... [17:47:45] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile, 7Tracking: Intermittent problem with navigating between topics with TOC - https://phabricator.wikimedia.org/T93502#1186836 (10EBernhardson) [18:03:51] Dear mobile team, this is my appreciation hug !!! [18:04:04] o_0 [18:04:18] :O [18:04:19] :) [18:04:45] some days i read the mailinglist, and i'm so glad that we at least have SOME people willing to look for trouble and to fight status quo a bit :) [18:05:26] don't let the nay sayers let you lot got down :) [18:05:49] thank you thedj:) [18:07:13] Thanks thedj :D truly appreciated [18:08:02] joakino: the vertlet thing was awesome :) [18:08:07] goes unsaid too often, too easily. :) [18:08:18] <3 thedj [18:08:35] phuedx: https://github.com/joakin/canvas-playground [18:08:42] i'm pretty sure "making trouble" is the mobile team's super power [18:08:56] phuedx: feel free to clone it and create your own folders, really easy to get started [18:09:07] phuedx: or poke around the existing demos, they are short [18:09:23] aharoni: done [18:09:48] thanks thedj! [18:09:57] 👏🍻 [18:10:04] etonkovidova: don't know if you saw this mention earlier or talked abotu it in standup, but coreyfloyd said "FYI shuffled some cards into the Qa sign off column". [18:10:35] kristenlans etonkovidova yeah sorry Elena you weren’t on IRC… [18:11:20] kristenlans etonkovidova basically we had already moved things before we added the new columns… wanted to give you a change to do QA signoff [18:13:21] bgerstle: chat this afternoon (sf time) about that patch of mine? [18:13:23] coreyfloyd: etonkovidova indeed, good practice for when s*%t gets real in our structured sprint 55! [18:13:39] mhurd sure [18:13:46] (03PS1) 10Deskana: Hygiene: reorder XML for views so that the android:id is on the first line [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202458 [18:13:48] bgerstle: yay [18:13:55] coreyfloyd: i'm wrapping up readme stuff. dr0ptp4kt_cold when would you be available for some testing? [18:14:09] i was thinking about setting up virtualbox/vagrant w/ an OSX image, but if you have a fresh machine that's better :-P [18:15:11] (03CR) 10Bmansurov: Filter out retired WikiGrok claims from WikiGrok pages (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [18:16:13] (03CR) 10Jdlrobson: [C: 04-1] "A few minor tweaks needed here but apart from that looks fine! :)" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202421 (https://phabricator.wikimedia.org/T91796) (owner: 10Pastakhov) [18:17:17] FlorianSW: i still think for completeness sake in the Echo change the init script should also be conditionally added.. [18:17:59] (03CR) 10Jdlrobson: [C: 032] Alpha: better parsing for a link title for quickLookup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [18:18:28] jdlrobson: ok, i will do it later, ok? :) [18:18:45] (03CR) 10Jdlrobson: [C: 032] Alpha, Beta: Wikidata description/issues to 0.8em [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202330 (https://phabricator.wikimedia.org/T95206) (owner: 10Phuedx) [18:20:11] bgerstle: cool [18:20:29] coreyfloyd: just breaking out different sections now [18:20:52] mhurd: you mind taking a looksy at my patches? [18:20:59] coreyfloyd: ok if i get the releases and code review wiki pages and emails done first? cc bgerstle mhurd [18:21:51] dr0ptp4kt_cold: np here - thanks for hopping on it! [18:22:38] (03PS3) 10Jdlrobson: Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 [18:23:14] (03PS4) 10Jdlrobson: Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 [18:23:22] (03CR) 10Jdlrobson: [C: 032] "cherry picked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 (owner: 10Jdlrobson) [18:23:27] (03CR) 10jenkins-bot: [V: 04-1] Alpha: better parsing for a link title for quickLookup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [18:23:57] (03CR) 10Bmansurov: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [18:24:17] (03PS2) 10Jdlrobson: Hygiene: Move cancel-light icon into skins.minerva.icons.images module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202244 [18:24:25] (03CR) 10Jdlrobson: [C: 032] "cherry picked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202244 (owner: 10Jdlrobson) [18:24:46] (03PS5) 10Jdlrobson: Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 [18:24:54] (03CR) 10Jdlrobson: [C: 032] "cherry picked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [18:25:26] (03Merged) 10jenkins-bot: Alpha, Beta: Wikidata description/issues to 0.8em [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202330 (https://phabricator.wikimedia.org/T95206) (owner: 10Phuedx) [18:25:56] (03CR) 10Jdlrobson: "For completeness let's add the initialisation module conditionally here too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 (owner: 10Florianschmidtwelzow) [18:26:02] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Don't add Echo modules, if Echo isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/199640 (owner: 10Florianschmidtwelzow) [18:26:19] dr0ptp4kt_cold: yeah ofcs [18:26:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 (owner: 10Jdlrobson) [18:27:12] coreyfloyd: would you please add testing steps for qa (& if needed, design - if design not needed, mark as much) to the Description field for https://phabricator.wikimedia.org/T94534 ? [18:27:17] etonkovidova: ^ fyi [18:27:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 (owner: 10Jdlrobson) [18:28:20] (03Merged) 10jenkins-bot: Alpha: better parsing for a link title for quickLookup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202092 (owner: 10Bmansurov) [18:28:31] etonkovidova: https://phabricator.wikimedia.org/T93170 should be ready to be tested on 4.1.1 alpha [18:28:41] (03CR) 10Jdlrobson: [C: 04-1] "The toast shouldn't have links in it. It was not designed for this purpose. It's effectively a non-obstrusive version of the JavaScript al" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202424 (https://phabricator.wikimedia.org/T95305) (owner: 10Florianschmidtwelzow) [18:29:01] etonkovidova: https://phabricator.wikimedia.org/T94653 should also be able to be tested on 4.1.1 alpha [18:29:16] (03CR) 10Jdlrobson: [C: 032] Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [18:29:33] etonkovidova: https://phabricator.wikimedia.org/T93662 should also be able to be tested on 4.1.1 alpha [18:29:50] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Make schema MobileFrontend agnostic (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 (owner: 10Jdlrobson) [18:30:14] dr0ptp4kt_cold: are you checking their presence in 4.1.1 individually? :) [18:30:17] (03CR) 10Jdlrobson: [C: 04-2] "1s" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [18:30:44] (03Merged) 10jenkins-bot: Hygiene: Move cancel-light icon into skins.minerva.icons.images module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202244 (owner: 10Jdlrobson) [18:30:49] etonkovidova: https://phabricator.wikimedia.org/T91124 could also be checked on 4.1.1 as well, although it seems your latest comment suggests it was already verified [18:30:50] (03CR) 10Jdlrobson: [C: 04-1] "I guess we need to redo the release notes since they are not accurate now?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [18:30:51] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [18:31:09] dr0ptp4kt_cold: thx! Looking... [18:31:20] (03CR) 10Jdlrobson: [C: 031] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [18:31:24] etonkovidova: :) sorta...looking at the merge dates on the gerrit patches. the new code becomes part of the alpha each morning [18:31:28] (03CR) 10Jdlrobson: [C: 032] Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [18:31:47] dr0ptp4kt_cold: hmm... right [18:33:08] (03PS4) 10Jdlrobson: Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 [18:33:20] dr0ptp4kt_cold: sure [18:34:16] rmoen: could do with some help on code review today. Also we really need to get that card you're working on wrapped up since we have a bunch of stuff next iteration that depends on it. Why is it taking so long? Is it just because of your absences or is it because of problems in the code? [18:34:27] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Select icon file based on build type (alpha, beta, etc) on build server - https://phabricator.wikimedia.org/T94534#1187020 (10Fjalapeno) [18:34:30] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [18:34:37] (03PS7) 10Bmansurov: Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) [18:35:00] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 (owner: 10Jdlrobson) [18:36:07] dr0ptp4kt_cold: done… also kicking off a manual build to get the icon updated… no automatic build was kicked off since I installed the dependencies on the build server [18:36:25] jdlrobson: Yes, I was pretty much out yesterday, I didn't realize my vision was going to be impaired for nearly the entire day. In regards to the search: I was having issues with it last week. Had it sort of working then had to flip mode after our discussion. [18:36:29] (03CR) 10Jdlrobson: [C: 032] "@bmansurov could you look at getting Jenkins via our Grunt file running the release note script generation post build? Manually committing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [18:36:32] bgerstle: should we have the build server automatically install dependencies as part of the build process? [18:36:56] rmoen: are you going to be able to wrap it up today? i could really do with your help on all the other things [18:38:41] jdlrobson: I should be able to. I may need your help, was stuck on an inheritance issue. I will assess where it is and push it in gerrit. [18:39:25] (03CR) 10Bmansurov: "@jdlrobson, ok, let's explore ways of maintaining this file. I personally don't think this file should be generated automatically, because" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [18:39:35] coreyfloyd: maybe.. hangout? [18:39:41] coreyfloyd: thx [18:39:42] sure [18:39:58] etonkovidova: note coreyfloyd is doing a fresh build for the icon-related thing [18:40:37] dr0ptp4kt_cold: looking forward to it ;0 [18:40:54] dr0ptp4kt_cold: sorry, I meant :) [18:41:48] bmansurov: i'll raise a phabricator task about the release notes [18:41:57] ok thanks [18:41:59] but basically they are not always going to be completely accurate. [18:42:15] jdlrobson: that's fine imo, as long as we convey the most important changes [18:43:31] coreyfloyd: dr0ptp4kt_cold mhurd made some big changes to the readme to reflect upcoming project changes. would appreciate review [18:43:32] https://github.com/btgerst/apps-ios-wikipedia/tree/update-readme#wikipedia-for-ios [18:43:42] (03PS1) 10Bgerstle: readme: WIP [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202463 [18:43:49] 6Mobile-Web: Generating release notes automatically - https://phabricator.wikimedia.org/T95324#1187028 (10Jdlrobson) 3NEW [18:43:53] ^ bmansurov [18:45:13] (03PS2) 10Bgerstle: readme: update to be more user-friendly [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202463 [18:46:44] 6Mobile-Web: Generating release notes automatically - https://phabricator.wikimedia.org/T95324#1187041 (10bmansurov) Another alternative is to update this file manually with every patch. I don't see much value in listing commit message titles as release notes. If we do it manually, the problem Jon described won'... [18:49:59] (03CR) 10jenkins-bot: [V: 04-1] Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [18:50:26] (03CR) 10Bmansurov: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [18:50:49] 10Gather, 6Mobile-Web, 3Mobile Web Design, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1187049 (10Jdlrobson) Put somet... [18:52:47] (03CR) 10Bmansurov: [C: 031] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 (owner: 10Jdlrobson) [18:53:10] (03CR) 10jenkins-bot: [V: 04-1] Re-start versioning the extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198382 (https://phabricator.wikimedia.org/T93423) (owner: 10Bmansurov) [18:56:35] (03CR) 10BearND: [C: 032] Hygiene: reorder XML for views so that the android:id is on the first line [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202458 (owner: 10Deskana) [18:56:49] (03CR) 10Fjalapeno: [C: 031] "Super nice update to the docs!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202463 (owner: 10Bgerstle) [18:56:56] (03Merged) 10jenkins-bot: Hygiene: reorder XML for views so that the android:id is on the first line [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202458 (owner: 10Deskana) [18:57:57] 10Wikipedia-iOS-App: Fix for missing recent thumb images. Mostly happened when navigating via links. - https://phabricator.wikimedia.org/T95066#1187059 (10Fjalapeno) @mhurd can you update this ticket with our bug reporting template? [18:59:06] (03CR) 10Fjalapeno: [C: 04-1] "left this in the bug ticket as well… but we need the ticket to be documented with our bug requirements so we know how and what to test (al" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201863 (owner: 10Mhurd) [19:01:01] Deskana: I'm downstairs [19:02:10] (03CR) 10Fjalapeno: "Also I agree with @bgerstle - I think it is a good time to make the saved pages and history download the icon on demand instead of relyin" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201863 (owner: 10Mhurd) [19:03:04] (03PS3) 10Fjalapeno: Fixing unit tests and running tests in alpha lane T94421 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 [19:03:32] joakino phuedx so next pow wow i'm going to invite a few new faces (not everyone) I think this will not upset the format too much [19:03:53] i'm still not sure if what we want is a general meet up or a frontend/backend/tools focussed meet up [19:05:17] mhurd: lunchtime! [19:06:07] JonKatz: that meeting got scary quickly :/ [19:06:17] mholloway: I'm at fang [19:06:42] jdlrobson: cool, looking forward to it [19:06:45] mhurd: oh! heading your way [19:07:01] jdlrobson: iterate! if we feel that a meeting didn't work, we'll try and figure out why and do better next time [19:07:03] mhurd: is tomasz there? cc Deskana [19:07:37] mholloway: yes [19:08:03] coreyfloyd: hangout time? [19:08:26] 6Mobile-Web, 5Patch-For-Review: Find new position for Font changer in alpha mode - https://phabricator.wikimedia.org/T95198#1187069 (10JKatzWMF) @florian can you confirm that this is resolved? Thanks! [19:08:51] sure [19:09:08] (03CR) 10Bgerstle: Fixing unit tests and running tests in alpha lane T94421 (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [19:11:04] 6Mobile-Web, 7Mobile: Broken upper bar/search bar on the experimental version of mobile. - https://phabricator.wikimedia.org/T94397#1187073 (10JKatzWMF) 5Open>3declined This will be fixed by https://trello.com/c/1CKPSyuM/252-once-design-has-signed-off-on-new-mobilemenu-interface-create-js-overlay-version-a... [19:11:59] 6Mobile-Web: Page issues and wikidata description text too large - https://phabricator.wikimedia.org/T95206#1187075 (10phuedx) [19:12:06] 6Mobile-Web: Page issues and wikidata description text too large - https://phabricator.wikimedia.org/T95206#1187077 (10phuedx) 5Open>3Resolved a:3phuedx [19:12:34] (03CR) 10Jdlrobson: [C: 032] Hygiene: Consistent use of global php classes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202355 (https://phabricator.wikimedia.org/T95270) (owner: 10Jhernandez) [19:13:21] 10Gather, 3Gather Sprint Enwiki, 6Mobile-Web: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1187088 (10Jdlrobson) a:3Jdlrobson [19:13:27] phuedx: can we move this to code review column? https://phabricator.wikimedia.org/T94194 [19:13:41] (03PS5) 10Jdlrobson: Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 [19:13:45] kristenlans: yarrrp [19:13:47] (03PS5) 10Jdlrobson: Redo watchstar creation so inside container [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) [19:13:50] sorry i didn't move it earlier [19:14:07] (03CR) 10Jdlrobson: [C: 04-1] "rebase needed" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 (owner: 10Jdlrobson) [19:14:22] phuedx: any chance you can jump in a kwik hangout w/me and JK? [19:14:35] kristenlans: sure [19:14:40] https://plus.google.com/hangouts/_/wikimedia.org/jkatz-klans?authuser=0 [19:14:46] jus hangin out [19:15:27] chilin' [19:16:04] dr0ptp4kt_cold: ping [19:17:10] (03Merged) 10jenkins-bot: Hygiene: Consistent use of global php classes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202355 (https://phabricator.wikimedia.org/T95270) (owner: 10Jhernandez) [19:17:28] 10Gather, 3Gather Sprint Enwiki: Gather incorrectly pulls down editor api - https://phabricator.wikimedia.org/T95327#1187100 (10Jdlrobson) 3NEW [19:17:35] 10Gather, 3Gather Sprint Enwiki: Gather incorrectly pulls down editor api - https://phabricator.wikimedia.org/T95327#1187108 (10Jdlrobson) a:3Jdlrobson [19:18:31] (03PS4) 10Jdlrobson: Correction to ext.gather.api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 (https://phabricator.wikimedia.org/T95327) [19:18:42] (03PS4) 10Jdlrobson: Hygiene: Create separate module for initialisation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202060 [19:20:00] 6Mobile-Web, 3Mobile Web Design, 5Patch-For-Review: Find new position for Font changer in alpha mode - https://phabricator.wikimedia.org/T95198#1187121 (10KLans_WMF) [19:21:07] 6Mobile-Web, 3Mobile Web Design, 5Patch-For-Review: Find new position for Font changer in alpha mode - https://phabricator.wikimedia.org/T95198#1182918 (10KLans_WMF) @khammerstein @msyed needs design <3 [19:24:47] (03PS2) 10Robmoen: WIP: Add to collection from search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 [19:26:00] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Add image attribution info to the image metadata of Share a Fact images - https://phabricator.wikimedia.org/T91821#1187154 (10JeanFred) There has been some related discussion on #T71941. [19:27:07] (03CR) 10MaxSem: Filter out retired WikiGrok claims from WikiGrok pages (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [19:27:19] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add to collection from search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 (owner: 10Robmoen) [19:33:30] 6Mobile-Web, 7Mobile: MobileFrontend doesn't do URL updating for redirects - https://phabricator.wikimedia.org/T93262#1187170 (10KLans_WMF) a:3phuedx [19:33:45] (03PS11) 10Jdlrobson: Special Edit feed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) [19:33:59] (03CR) 10Jdlrobson: "Thanks for all the help! :D" (035 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) (owner: 10Jdlrobson) [19:34:08] dr0ptp4kt_cold: have time for code review? [19:34:27] 3Gather Sprint Enwiki, 3Mobile Web Design: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1187173 (10Jdlrobson) a:5MSyed>3None [19:34:47] 3Gather Sprint Enwiki, 3Mobile Web Design: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1136830 (10Jdlrobson) Note in MobileFrontend there is now ButtonWithSpinner [19:34:59] 6Mobile-Web: Mobile Beta completely blocks TOC on talk pages - https://phabricator.wikimedia.org/T93551#1187177 (10Thnidu) [19:35:32] phuedx: kaldari any idea why icons are no longer loading for me in mobile beta [19:35:34] ^ FlorianSW ? [19:35:43] hamburger icon has disappeared [19:35:45] cant' work out why [19:36:01] ohh crap - http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=beta here too [19:36:03] bmansurov: bug? [19:36:45] looking into it [19:36:49] 6Mobile-Web: Mobile Beta completely blocks TOC on talk pages - https://phabricator.wikimedia.org/T93551#1139769 (10Thnidu) [19:37:14] 6Mobile-Web: Hamburger in beta completely disappeared - https://phabricator.wikimedia.org/T95331#1187187 (10Jdlrobson) 3NEW [19:37:20] ^ bmansurov [19:37:51] bmansurov: and shit [19:37:56] seems like i introduced it exception 'MWException' with message 'File '/srv/mediawiki/php-master/extensions/MobileFrontend/images/icons/cancel-light.svg' does not exist' [19:38:13] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1187199 (10JeanFred) >> Could we embed attribution data as EXIF? > > Nice idea. I've heard that Twitter strips image metadata,... [19:38:15] bmansurov: want me to fix? [19:38:20] jdlrobson: sure [19:40:12] 6Mobile-Web: Hamburger in beta completely disappeared - https://phabricator.wikimedia.org/T95331#1187203 (10Jdlrobson) a:3Jdlrobson [19:40:33] (03PS1) 10Jdlrobson: Use correct image icon path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202475 (https://phabricator.wikimedia.org/T95331) [19:40:39] 6Mobile-Web, 5Patch-For-Review: Hamburger in beta completely disappeared - https://phabricator.wikimedia.org/T95331#1187207 (10Jdlrobson) seems like i introduced it exception 'MWException' with message 'File '/srv/mediawiki/php-master/extensions/MobileFrontend/images/icons/cancel-light.svg' does not exist' [19:40:47] (03CR) 10Bmansurov: Filter out retired WikiGrok claims from WikiGrok pages (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [19:40:59] (03PS2) 10Jdlrobson: Use correct image icon path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202475 (https://phabricator.wikimedia.org/T95331) [19:41:01] ^ bmansurov [19:41:06] ok [19:42:06] (03CR) 10Bmansurov: [C: 032] Use correct image icon path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202475 (https://phabricator.wikimedia.org/T95331) (owner: 10Jdlrobson) [19:42:33] bgerstle: ok if i do the release and code review wiki pages and emails first? i realize the irony in that [19:42:56] dr0ptp4kt_cold: sorry, forgot you were working on that. how close are you to being done? [19:43:19] dr0ptp4kt_cold: also you might want to take a look at the Gerrit section of the README which i added [19:43:29] bgerstle: probably 90 minutes [19:43:41] bgerstle: sneak attack to do code review, nice [19:43:55] dr0ptp4kt_cold: lol not exactly, but sure :-P [19:44:11] dr0ptp4kt_cold: https://github.com/btgerst/apps-ios-wikipedia/tree/update-readme#gerrit [19:44:17] (03Merged) 10jenkins-bot: Use correct image icon path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202475 (https://phabricator.wikimedia.org/T95331) (owner: 10Jdlrobson) [19:45:25] thanks bmansurov [19:45:37] 6Mobile-Web, 5Patch-For-Review: Hamburger in beta completely disappeared - https://phabricator.wikimedia.org/T95331#1187225 (10Jdlrobson) 5Open>3Resolved phew [19:46:12] jdlrobson: i still don't see it [19:46:26] bmansurov: mm? [19:46:35] MaxSem, after long and hard thinking, we should start writing )) I think the *master* plan should be 1) snapshot service 2) overlays over #1, 3) publicly expose tile server [19:46:37] jdlrobson: do you see the hamburger icon now? [19:46:42] in beta labs [19:46:46] bmansurov: locally yes but not beta labs [19:46:51] will be updated shortly i hope :) [19:46:55] ok [19:47:00] anyway me grabbing lunch now [19:47:01] biab [19:47:04] k [20:04:29] bgerstle: coreyfloyd dr0ptp4kt_cold https://gerrit.wikimedia.org/r/#/c/202463 looks good - merge it? [20:04:49] mhurd we need to merge the ones before it first [20:04:57] starting with https://gerrit.wikimedia.org/r/#/c/202040/1 [20:05:00] bgerstle: AH [20:05:03] oops [20:05:29] mhurd: it's all up on GH if you'd rather review there: https://github.com/btgerst/apps-ios-wikipedia/tree/update-readme#wikipedia-for-ios [20:05:43] (you can see the previous commits in the history) [20:06:00] bgerstle: yeah i pushed to my github repo already for easy reading [20:06:28] :-P [20:08:19] (03CR) 10Mhurd: "Will this play nice with incoming i18n? (Such as in https://gerrit.wikimedia.org/r/#/c/201866/)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202086 (owner: 10Bgerstle) [20:09:43] mhurd ^ there's one way to find out, there's a chance it won't be. but should be easy to fix [20:09:56] bgerstle: hehe sounds good [20:11:20] mhurd it's easy to revert, either way [20:11:25] that's why it's discrete [20:11:42] we're looking to revamp all of that in the near term anyway [20:11:49] bgerstle: ya [20:12:08] bgerstle: batcave? [20:12:13] TBH i shouldn't have conflated that w/ this patch, but i did some other stuff that need to reference the file path, and i wanted to do it w/ "W" since i knew that would be more future-proof [20:12:14] sure [20:12:19] ...if you use the GIF [20:13:11] bgerstle: hahah one sec [20:13:50] bgerstle: http://i.imgur.com/oxEvxwL.gif [20:14:51] mhurd https://gerrit.wikimedia.org/r/#/c/202037/ [20:14:55] (03CR) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [20:15:52] (03CR) 10Mhurd: [C: 032] Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201866 (owner: 10BearND) [20:16:02] (03CR) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [20:17:42] (03PS2) 10Mhurd: fix pod install warnings [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202037 (owner: 10Bgerstle) [20:17:53] (03CR) 10Mhurd: [C: 032] fix pod install warnings [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202037 (owner: 10Bgerstle) [20:18:17] (03PS2) 10Mhurd: commit Pods folder [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202040 (https://phabricator.wikimedia.org/T94039) (owner: 10Bgerstle) [20:19:07] (03CR) 10Mhurd: [C: 032] commit Pods folder [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202040 (https://phabricator.wikimedia.org/T94039) (owner: 10Bgerstle) [20:19:34] (03PS2) 10Mhurd: makefile: add "easy button" to install dependencies [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202051 (https://phabricator.wikimedia.org/T94229) (owner: 10Bgerstle) [20:20:52] (03CR) 10Mhurd: [C: 032] makefile: add "easy button" to install dependencies [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202051 (https://phabricator.wikimedia.org/T94229) (owner: 10Bgerstle) [20:21:22] (03PS6) 10Robmoen: Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 (owner: 10Jdlrobson) [20:24:13] (03CR) 10Robmoen: [C: 032] Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 (owner: 10Jdlrobson) [20:24:29] (03PS6) 10Robmoen: Redo watchstar creation so inside container [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) (owner: 10Jdlrobson) [20:26:38] (03PS2) 10Bgerstle: fix case of Wikipedia folder [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202086 [20:26:40] (03PS3) 10Bgerstle: commit web assets and remove build scripts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202087 (https://phabricator.wikimedia.org/T94231) [20:26:42] (03PS3) 10Bgerstle: readme: update to be more user-friendly [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202463 [20:27:20] coreyfloyd: bgerstle mhurd is your preference to do a soft launch tomorrow/thursday, followed by any additional comms next week? there's a very low probability comms could be done sooner, even if Eloquence and juliet were okay with this. but i wanted your opinion before i email Eloquence and juliet about this, in response to Deskana noting who else needs to chime in [20:27:40] dr0ptp4kt_cold: 1 sec going through code review w/ mhurd [20:28:44] dr0ptp4kt_cold: off the cuff: we just want to try to avoid the situation where we have to context switching between current master and hot-fixes on the release tag. iOS 8 coverage should be pretty good based on TF beta testers, but we've only had ourselves and TSG hammering on 6/7 [20:29:32] doing a soft launch could help us mitigate the effect of any post-release fire-fighting on the upcoming sprint [20:31:15] dr0ptp4kt_cold: i agree with you on not releasing on Friday though [20:31:48] bgerstle: that said, what's your thumbs up/down on a soft launch tomorrow or thursday morning? mhurd, what say you? coreyfloyd, i get the impression you strongly prefer soft launch. [20:33:41] (03CR) 10Mhurd: [C: 032] "Corey has already +1'ed this." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202086 (owner: 10Bgerstle) [20:34:27] (03CR) 10Bmansurov: Hygiene: Use mw-ui-icon in stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [20:35:51] dr0ptp4kt_cold: i'm pretty sure i'm feeling like a +1, but i would prefer to see the pros & cons clearly laid out so we can all try to come to consensus [20:36:10] rather, i'd prefer to see pros & cons for me to feel more comfortable about my +1 [20:37:12] (03Merged) 10jenkins-bot: Hygiene: Remove dependency on mobile watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201614 (owner: 10Jdlrobson) [20:37:58] that being said i still feel relatively good about the latest RC in terms of stability [20:38:24] etonkovidova: what say you? ^ [20:38:53] (03CR) 10Mhurd: [C: 032] "Corey +1'd this already." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202087 (https://phabricator.wikimedia.org/T94231) (owner: 10Bgerstle) [20:38:55] (03PS5) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) [20:38:57] (03PS1) 10Jdlrobson: Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 [20:39:30] (03CR) 10Mhurd: [C: 032] "Merge time." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202463 (owner: 10Bgerstle) [20:39:57] bmansurov: can you take a look at https://gerrit.wikimedia.org/r/202583 ? [20:40:10] it seems to be working around mw-ui-icon and needs to be fixed [20:40:28] (03CR) 10Jdlrobson: [C: 04-1] "not working correctly. Can someone take a look?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [20:40:45] 6Mobile-Web, 6Services: Image-positioning service - https://phabricator.wikimedia.org/T88633#1187463 (10bearND) @Mhurd I think having a method to just get a single aggregated rectangle, which represents the outer bounds of potentially multiple smaller focal areas, would be good. No need to transfer all the dat... [20:41:08] (03CR) 10Jdlrobson: "I'll think about how to split it up but it's not that easy.... this is a big change thus is a big patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [20:41:13] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [20:41:13] coreyfloyd: hey i merged brian's outstanding patches - can you rebase yours? [20:42:28] dr0ptp4kt_cold: 4.1.1 when installed shows as Wikipedia 74? is it ok? [20:43:28] etonkovidova: yes, that's an internal number. so next time around it should say 75. cc coreyfloyd [20:44:00] (03CR) 10Robmoen: [C: 032] Redo watchstar creation so inside container [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) (owner: 10Jdlrobson) [20:44:14] (03PS5) 10Robmoen: Correction to ext.gather.api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 (https://phabricator.wikimedia.org/T95327) (owner: 10Jdlrobson) [20:45:13] (03CR) 10Kaldari: [C: 04-1] "reworking event binding" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [20:45:58] (03PS6) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) [20:46:00] (03PS2) 10Jdlrobson: Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 [20:46:02] (03PS1) 10Jdlrobson: Hygiene: Don't use icon class for removing uploads link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202586 [20:46:37] (03CR) 10Jdlrobson: "still has issues.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [20:47:24] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: ShareAFact: Wikipedia logo is not correctly aligned on Hebrew devices - https://phabricator.wikimedia.org/T95345#1187474 (10bearND) 3NEW a:3bearND [20:47:24] (03Merged) 10jenkins-bot: Redo watchstar creation so inside container [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201615 (https://phabricator.wikimedia.org/T93987) (owner: 10Jdlrobson) [20:47:49] dr0ptp4kt_cold: thx - never seen it before... ok [20:49:12] dr0ptp4kt_cold: I'm unclear what you mean by "soft launch". [20:49:13] (03PS6) 10BearND: ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201732 (https://phabricator.wikimedia.org/T95345) [20:49:32] (03PS7) 10BearND: ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201732 (https://phabricator.wikimedia.org/T95345) [20:50:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [20:52:01] (03CR) 10Bmansurov: "Also, I don't see the icon, even after hard refresh." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [20:52:37] (03CR) 10Robmoen: "I see the follow up patch removes resources/ext.gather.init/init.js, will merge after testing child patch." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 (https://phabricator.wikimedia.org/T95327) (owner: 10Jdlrobson) [20:52:39] mhurd https://phabricator.wikimedia.org/T95114 [20:53:31] (03CR) 10Bmansurov: [C: 04-1] "In addition to my comments to patchset 1, please update the commit message too since the patch is not only about the search icon anymore." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [20:53:47] (03PS5) 10Robmoen: Hygiene: Create separate module for initialisation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202060 (owner: 10Jdlrobson) [20:54:35] (03CR) 10Jdlrobson: "bmansurov: i don't understand.. this /is/ about the search icon. bmansurov and you missed my comment on irc - i know this is broken. I nee" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [20:54:58] (03PS6) 10Robmoen: Correction to ext.gather.api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 (https://phabricator.wikimedia.org/T95327) (owner: 10Jdlrobson) [20:55:06] (03CR) 10Robmoen: [C: 032] Correction to ext.gather.api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 (https://phabricator.wikimedia.org/T95327) (owner: 10Jdlrobson) [20:55:22] (03PS6) 10Robmoen: Hygiene: Create separate module for initialisation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202060 (owner: 10Jdlrobson) [20:56:19] (03CR) 10Robmoen: [C: 032] Hygiene: Create separate module for initialisation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202060 (owner: 10Jdlrobson) [20:56:45] (03CR) 10Bmansurov: "Sorry, I see you rebased. I saw javascripts/modules/uploads/init.js and some other file in patchset 2 compared to patchset 1. Can you poin" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [20:56:59] (03PS3) 10Mhurd: Fix for missing recent thumb images. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201863 [21:01:05] jdlrobson: basically the workaround is there because we're dealing with an input#submit, which doesn't support pseudo elements afaik [21:01:38] mhurd: etonkovidova vibha your feedback on the email i just sent would be most appreciated [21:02:03] bmansurov: then wrap it in a div :) [21:02:07] we do the same with the upload icon [21:02:08] moizsyed_: ^^ fyi [21:02:23] jdlrobson: sure [21:02:26] let me take a look [21:03:47] the image is also too big [21:08:49] (03PS3) 10Robmoen: Point at hamburger icon when a collection has been setup. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) (owner: 10Jdlrobson) [21:09:02] (03Merged) 10jenkins-bot: Correction to ext.gather.api module [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202059 (https://phabricator.wikimedia.org/T95327) (owner: 10Jdlrobson) [21:09:04] (03Merged) 10jenkins-bot: Hygiene: Create separate module for initialisation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202060 (owner: 10Jdlrobson) [21:09:48] mhurd reprodued the issue on master, but didn't happen on your branch [21:11:50] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1187576 (10Tvx1) @Jdlrobson No that's no the page I was testing on. It's [http://en.m.wikipedia.org/wiki/2014_Formula_One_season#Teams_and_drivers]. That page has some wikit... [21:13:21] yurik, sorry - still deep in wikigrok's vagrant [21:13:36] (03PS7) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) [21:13:38] (03PS3) 10Jdlrobson: Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 [21:14:15] coreyfloyd: would you move https://phabricator.wikimedia.org/T94769 out of "sign off" if you think it's good? (we merged it, and builds went out) [21:14:19] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1187595 (10Etonkovidova) Checked on iPad mini 4.1.1(Wikipedia 74) - Saved pages display the same description text that is displayed on an article's leading image. When there... [21:15:38] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather incorrectly pulls down editor api - https://phabricator.wikimedia.org/T95327#1187600 (10Jdlrobson) 5Open>3Resolved [21:15:55] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Blue tutorial indicator positioned incorrectly in Chrome when pointing at a transformed element e.g. green watchstar - https://phabricator.wikimedia.org/T93987#1187602 (10Jdlrobson) 5Open>3Resolved [21:16:06] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1187605 (10Etonkovidova) 5Open>3Resolved [21:17:15] (03CR) 10Jdlrobson: [C: 031] Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [21:17:19] (03PS6) 10Jdlrobson: Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 [21:17:24] (03CR) 10Jdlrobson: [C: 032] Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [21:17:35] (03PS1) 10Robmoen: Remove outline from collections watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202596 [21:17:51] bgerstle: thats dans column for sign off - we should rename that to PM Signoff to be specific [21:17:53] (03PS5) 10Jdlrobson: Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 [21:17:59] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [21:18:25] true [21:18:29] kristenlans: ^ can we rename "Ready for Signoff" to "PM Signoff" so its clear? [21:18:59] coreyfloyd: kristenlans should engineer stuff skip "Ready for Signoff" if there aren't product-related acceptance criteria? (though most tasks should have product-related acceptance criteria) [21:19:48] bgerstle: good point, but even if - this specific task is still verifiable by Dan [21:20:10] 10Wikipedia-iOS-App: Standardize image fetch/cache/fallback logic - https://phabricator.wikimedia.org/T95350#1187611 (10BGerstle-WMF) 3NEW [21:20:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [21:20:32] (03CR) 10Bgerstle: [C: 031] "Fixes the issue, let's DRY up the image fallback/fetch/cache logic for these and VCs in another patch for the tech debt: T95350" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201863 (owner: 10Mhurd) [21:21:04] coreyfloyd: sorry, i meant for that comment to *not* apply to your build patch [21:21:14] or, my fastlane patch, rather [21:21:22] coreyfloyd: there was another ticket in there about regex stuff [21:21:34] which ideally should've had Instruments screenshots or something that dan could've signed off on [21:22:03] mhurd: have you been able to look at my patches? [21:22:17] bgerstle: np -just wanted to be clear - thanks [21:22:26] bgerstle: generally as a rule, yes (see last bullet item here: https://www.mediawiki.org/wiki/Mobile_web/Team/Roles_and_responsibilities#Engineer) [21:22:36] coreyfloyd: are they ready for review? the fastlane testing one didn't seem ready [21:22:47] coreyfloyd: the hockeyapp one i think need to rebased as well [21:22:49] bgerstle: what was wrong? [21:23:50] coreyfloyd: i left a comment on the testing one [21:23:53] coreyfloyd: i tried to rebase them w/o luck [21:25:02] coreyfloyd: i +1'd mhurd's patch. we're in the bat cave if you want to discuss [21:25:16] http://appalachiantrials.com/wp-content/uploads/2015/02/Batsignal.png [21:26:55] bgerstle: link? [21:27:31] how about we use slack so you can do “/hangout" [21:27:36] coreyfloyd: I see where your going with the idea of changing Ready for Signoff to PM Signoff. I wonder if it's clear enough that PM signoff is the ultimate signoff. cc Deskana [21:28:19] (03PS2) 10Fjalapeno: Enable crash reporting for Alpha builds T95318 Also cleanup and encapsulate crash reporting logic - boyscout rule [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202444 [21:29:09] kristenlans: “Penultimate Signoff? [21:29:28] kristenlans: for vibha? [21:29:35] coreyfloyd: Ultramegaproductoverlord Signoff? [21:30:25] coreyfloyd I guess for any person in the world who chooses to follow our phab boards [21:30:32] * kristenlans shrugs [21:31:24] coreyfloyd: hey, watch that crazy talk [21:31:30] coreyfloyd: sorry missed the mention: https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [21:31:38] lol [21:31:40] BOOKMARK IT [21:31:52] otherwise, http://i.imgur.com/48rmo.jpg [21:31:59] WHOOPS NSFW [21:32:00] lol [21:33:16] oh dear… i had better leave this room to keep from being implicated… [21:34:14] 10Wikipedia-iOS-App: [Regression 4.1.1] a user gets kicked out of the apps from Image gallery - https://phabricator.wikimedia.org/T95352#1187637 (10Etonkovidova) 3NEW [21:34:19] 10Wikipedia-iOS-App: Standardize image fetch/cache/fallback logic - https://phabricator.wikimedia.org/T95350#1187644 (10BGerstle-WMF) [21:35:06] https://phabricator.wikimedia.org/T95352 is very entertaining too :) [21:41:31] jdlrobson: I’m still not having any luck binding events to OOjs UI objects. If you have any time I would love some help debugging it. [21:44:45] mholloway: how's your time in SF going? [21:45:19] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Select icon file based on build type (alpha, beta, etc) on build server - https://phabricator.wikimedia.org/T94534#1187676 (10Etonkovidova) Hmm... Are those images for alpha builds(4.1.1) are satisfactory? {F109791} {F109794} [21:45:22] dbrant: it's great! [21:45:45] dbrant: just had a group lunch at fang's [21:46:13] dbrant: good place if you haven't been [21:46:39] dbrant: there was some indecision when we first arrived and the guy taking orders (which it turned out was the owner) just quietly walked away [21:46:40] coreyfloyd: https://phabricator.wikimedia.org/T94534 - a new icon for alpha build is not used for 4.1.1? [21:46:46] dbrant: it was pretty funny [21:47:07] mholloway: yep! it's a great place [21:47:17] dbrant: how's australia? [21:47:48] coreyfloyd: I guess the icon is not in that release - sorryyy... [21:48:10] mholloway: it's surreal! [21:48:15] MaxSem, I want to write some thoughts down about the architecture and pending questions - what would be the best location? [21:48:40] etonkovidova: looking now! [21:51:11] (03CR) 10Fjalapeno: [C: 031] Fix for missing recent thumb images. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201863 (owner: 10Mhurd) [21:52:07] dbrant: how so? [21:52:14] (03CR) 10Mhurd: [C: 032] "Brian and Corey +1'ed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/201863 (owner: 10Mhurd) [21:53:26] mholloway: doesn't feel like I'm really here yet! [21:54:43] I need to find better wifi... :( [21:55:47] jdlrobson, hey [21:55:49] 3Gather Sprint Enwiki: Add to collection tutorial should not show on main page - https://phabricator.wikimedia.org/T95355#1187714 (10rmoen) 3NEW a:3rmoen [21:57:52] (03PS4) 10Fjalapeno: Fixing unit tests and running tests in alpha lane T94421 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 [21:59:28] (03PS1) 10Robmoen: Don't show collection tutorial on the main page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202600 [21:59:30] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1187736 (10Krenair) So I tried VE on mobile using the latest MobileFrontend master with "Experimental" (alpha) enabled. It looks to me like it's still ge... [22:00:20] etonkovidova: try running the app [22:00:26] kk [22:00:32] etonkovidova and then going back to the home screen [22:00:42] (never mind jdlrobson, I think I figured it out) [22:01:45] etonkovidova: i think it is working on iPhones and not iPads… [22:02:11] coreyfloyd: ah... will check that [22:02:12] 3Gather Sprint Enwiki: Collection watchstar has outline - https://phabricator.wikimedia.org/T95357#1187742 (10rmoen) 3NEW a:3rmoen [22:02:29] (03PS2) 10Robmoen: Remove outline from collections watchstar [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202596 [22:03:59] 3Gather Sprint Enwiki: Collection watchstar has outline - https://phabricator.wikimedia.org/T95357#1187742 (10rmoen) https://gerrit.wikimedia.org/r/#/c/202596/ [22:05:28] etonkovidova: found the bug… fixing now [22:05:58] kk [22:07:19] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Standardize image fetch/cache/fallback logic - https://phabricator.wikimedia.org/T95350#1187760 (10BGerstle-WMF) [22:07:21] (03PS3) 10Mhurd: Enable crash reporting for Alpha builds T95318 Also cleanup and encapsulate crash reporting logic - boyscout rule [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202444 (owner: 10Fjalapeno) [22:07:38] coreyfloyd: ^ i just pushed "rebase" [22:09:06] coreyfloyd: tests failed to build. fixing locally [22:11:45] MaxSem: YuviPanda: Any ideas on creating a situation in the MW API where it returns a 503 predictably (for automated testing)? [22:11:55] uh... [22:11:56] hmmmm [22:12:13] * YuviPanda thinks [22:13:01] coreyfloyd: think i've got it. will amend shortly (w/ a 1 line change to remove pod install from fastfaile) [22:13:08] fastfile* [22:13:27] (03CR) 10Mhurd: [C: 031] Enable crash reporting for Alpha builds T95318 Also cleanup and encapsulate crash reporting logic - boyscout rule [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202444 (owner: 10Fjalapeno) [22:13:27] tests are failing, i guess that's a good sign [22:13:46] 10Gather, 3Gather Sprint Enwiki: Assorted string replacements - https://phabricator.wikimedia.org/T93817#1187774 (10rmoen) a:3rmoen [22:13:53] MaxSem: YuviPanda: am wondering if there are special test endpoints to return certain HTTP codes [22:14:37] bearND: hmm, not that I know of, no... [22:14:50] bearND: I’m not sure if that’s a general good idea, since we generally get alerted to 503 spikes. [22:15:15] bearND: however, if all you want is for something to return 503, you can hit https://httpbin.org/ [22:15:33] bearND: you're doing network I/O in a unit test? [22:15:41] bearND: why not mock the network layer to fake it? [22:15:53] you can get it to return whatever response (and payload) you want [22:16:19] YuviPanda: Thanks. I'm thinking more along the lines of detecting it in the app and and presenting a special message instead of lying to the user and telling him that there he's got no internet connection (well, one of the many cases) [22:16:24] :) [22:16:27] yeah, true. [22:16:36] bearND: no way to test that on prod cluster, I’m afraid [22:17:03] how about testwiki? [22:17:49] bearND: hmm, we could setup a small test-only extension that does the equivalent of httpbin.org. [22:18:00] bearND: but definitely not very quickly, no... [22:18:19] (03CR) 10Mhurd: [C: 031] Fixing unit tests and running tests in alpha lane T94421 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [22:18:28] bearND: YuviPanda mocking?... anyone? [22:18:40] bgerstle: calling these ‘unit tests’ is a bit wrong, I think. [22:18:49] bgerstle: these test the ‘entire stack’ including the MW parts. [22:19:00] bgerstle: not strictly unit test, more instrumentation test [22:19:04] but if bearND is testing a specific behavior in the app [22:19:08] (And I personally think these are more useful than pure unit tests when you have limited time tests) [22:19:08] sounds like it should be a unit test [22:19:25] err, limited time *for* tests [22:19:35] IOW: mock the "fetcher" or whatever they're called using something like mockito: https://code.google.com/p/mockito/ [22:19:36] bgerstle: you're welcome to add one [22:20:04] :) [22:20:40] bearND: just making a suggestion :-) [22:21:46] IMO back-end behavior (return a 503 in this case) should be tested separately from how the android app handles it [22:22:17] and based on what you're saying, it sounds like you don't care what the back-end's actual behavior is, you just want to test how the android app handles a 503 [22:22:34] thought it might be easier to mock it [22:24:30] bgerstle: yes, ideally that would be nice. Not sure if I'd call using Mockito easy, though. That can get very messy coding. [22:25:32] it's not the _ most_ elegant API, but i don't know many other mocking libs for java [22:26:04] bgerstle: YuviPanda: Thanks for the suggestions! httpbin.org is pretty cool [22:26:24] shouldn't be too bad, though. we're doing some similar stuff to test paginated requests on iOS: https://github.com/wikimedia/apps-ios-wikipedia/blob/master/WikipediaUnitTests/WMFImageInfoControllerTests.m#L173 [22:26:55] kaldari: how are wikibase_item properties are added to pages? do you know? [22:27:01] we're actually using an Objective-C port of Mockito [22:27:15] kaldari: I mean 'when? [22:28:36] bmansurov: when the wikipedia article is added to the item within wikidata.org, it gets the wikibase_item prop. [22:29:08] kaldari: how can I reproduce this on my local instance? inserting into mysql doesn't do it. [22:29:15] kaldari: it gets deleted on next page save [22:29:37] bearND: this looks relevant, if you're interested: http://www.mdswanson.com/blog/2013/12/16/reliable-android-http-testing-with-retrofit-and-mockito.html [22:30:22] need to walk the dog - bgerstle hit me up if you need anything else to +1 my patches [22:30:24] bmansurov: if you’re running the wikigrok role in vagrant, you should have a local wikidata repo and you can link it from there. [22:30:37] kaldari: ok thanks [22:30:51] coreyfloyd: the tests were failing. disabling a couple and made some changes to add missing stuff that wasn't being compiled for the test [22:30:54] after that should be good to go [22:31:04] bmansurov: in my vagrant install, I’m running the centralauth, mobilefrontend, and wikigrok roles [22:31:08] i'm going to head out shortly as well [22:31:41] bmansurov: after you reprovision, you should be able to load your local wikidata repo at http://wikidata.wiki.local.wmftest.net:8080/wiki/Main_Page [22:31:47] in fact, i'll head out now, we can wrap this up tomorrow or maybe later tonight [22:31:57] bgerstle: Thanks. Probably later. I hate to admit but the main issue I have right now with our tests is that they don't run automatically in CI, hence the motivation to invest more into is pretty low. The first step for us would be to get the running automatically first. [22:32:04] bgerstle_afk: ^ [22:32:10] bgerstle: did you push that or are you saying that's what I need to do? [22:32:13] kaldari: thanks [22:32:17] bmansurov: You have to manually create the needed properties and items though, like ‘instance of’, ‘occupation’, ‘writer’, etc. [22:32:20] coreyfloyd: i have local changes that do it [22:32:27] was just running now to see if it fixed it [22:32:28] kaldari: ok [22:32:40] bearND: ours don't run automatically either, but we still write them [22:33:00] faster/cheaper for testing certain things (data migration, paginated requests, etc.) [22:33:11] bearND: i hear you though, lack of CI sucks [22:33:27] maybe you guys should setup a build agent in WMF labs ;-) [22:33:33] or use travis *cough* [22:33:42] bmansurov: once the properties and items are created in your local repo, you’ll need to recreate the wikigrok campaign definitions in your local configs to use whatever IDs were assigned by your local repo, like ‘instance of’ might be ‘P2’ instead of ‘P31’. [22:34:07] coreyfloyd: need more time to fix this up. if you get around to it i can have another look when i get back [22:34:08] o/ [22:34:16] kaldari: can't I just export P31 from wikidata.org and import it? Would it not preserve the id? [22:35:30] bmansurov: hmm, no idea. [22:35:41] kaldari: i'll try and let you know [22:41:49] (03PS1) 10Robmoen: Hygiene: Fancy string generation on collection tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202606 [22:46:36] coreyfloyd: i get a missing separator error when i try to run make... do you? [22:52:38] coreyfloyd: bgerstle_afk did this accidentally revert some bits of the makefile? https://github.com/montehurd/apps-ios-wikipedia/commit/f7a462d7ef2efd9b209e6514847d7706e89b93e1 [22:53:07] kaldari: how can I link my local wiki to my local wikidata? Is it the $wgMFWikiDataEndpoint config variable? [22:54:37] probably not [22:55:45] bmansurov: put $wgWikiGrokRepo = 'wikidatawiki'; in a config file in settings.d/wikis/enwiki/settings.d/ [22:56:10] I have a file in that dir called 10-WikiGrok.php that I use [22:56:41] bgerstle_afk: coreyfloyd Deskana|Away etonkovidova kristenlans mhurd just sent a meeting invitation for 1030 am sf time tomorrow to go over the releases document. [22:56:56] kaldari: thaks, anything else? [22:59:27] bmansurov: Here’s what I have in my settings.d/wikis/enwiki/settings.d/10-WikiGrok.php : http://pastebin.com/b18ShHip [22:59:59] bmansurov: some of those are outdated though [23:00:04] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Disambiguation Pages should not appear in Read More - https://phabricator.wikimedia.org/T95365#1187886 (10Vibhabamba) 3NEW a:3Deskana [23:00:20] mhurd: sorry was walking the dog [23:00:33] kaldari: thanks, say I created a wikidata page, Q2, called brad pitt, and I already have a wiki page called 'brad pitt' too, will they be automatically connected? [23:00:39] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Disambiguation Pages should not appear in Read More - https://phabricator.wikimedia.org/T95365#1187895 (10Vibhabamba) [23:01:32] bmansurov: also, you’ll need to add $wgCrossSiteAJAXdomains = array( '*.wiki.local.wmftest.net:8080' ); into settings.d/02-configs.php [23:01:46] ok [23:01:52] coreyfloyd: no worry. i think that diff i linked to left the css update script a bit broken [23:01:58] or some global config file for your wikis [23:02:26] kaldari: i had a '*' ;) [23:02:49] bmansurov: that’ll work too :) [23:03:56] mhurd: yeah - brian was just mentioning that he had to fix it I think… [23:04:25] 10Wikipedia-iOS-App: [Regression 4.1.1] a user gets kicked out of the apps from Image gallery - https://phabricator.wikimedia.org/T95352#1187914 (10Etonkovidova) Maybe related to this: when the last image in the Image Gallery is reached, swipe to the right(like going to the next one) - you'll be kicked out of th... [23:04:59] 10Wikipedia-iOS-App: [Regression 4.1.1] a user gets kicked out of the apps from Image gallery - https://phabricator.wikimedia.org/T95352#1187923 (10Etonkovidova) [23:05:13] coreyfloyd: ah cool. i may wait on diving back into https://phabricator.wikimedia.org/T91702 until the morning then... [23:05:36] mhurd: np - I think I am going to break now anyways… [23:05:58] coreyfloyd: sounds good. see ya tomorrow! [23:06:45] (03PS1) 10Robmoen: Better explanations in error messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202612 [23:06:56] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Disambiguation Pages should not appear in Read More - https://phabricator.wikimedia.org/T95365#1187929 (10Vibhabamba) Some titles are bolded and others (Disambiguation pages and list pages) are not bolded in the read more section. @mhurde @bearnd - Is that the defa... [23:07:07] mhurd: thanks (I’ll be lurking for a bit) otherwise catch you later cc dr0ptp4kt_cold [23:08:12] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: 4.0.6.3 Image Gallery - some images displayed in low resolution - https://phabricator.wikimedia.org/T91124#1187937 (10Etonkovidova) I was checking it on iPad mini(8.2) with 4.1.1 There are still two images that still displayed as blurred in... [23:09:41] (03PS4) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [23:10:12] jdlrobso_: https://gerrit.wikimedia.org/r/#/c/201862/ [23:11:13] (03CR) 10jenkins-bot: [V: 04-1] Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [23:13:11] Deskana: was just scrolling through the chat log. realized i missed your question. by 'soft launch' i meant releasing the software without comms [23:13:54] dr0ptp4kt_cold: Right. That's something that needs Juliet's input. [23:14:05] Deskana: agreed [23:14:20] (03PS1) 10Dbrant: [WIP] Link previews. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [23:14:20] dr0ptp4kt_cold: This is part of the reason I didn't try to bite this off myself. Trying to wrangle everyone and get everyone's opinions will likely take as long as waiting would've done. [23:14:36] Deskana: lol, the thought occurred to me [23:15:00] (03PS6) 10Bmansurov: WIP: Filter out retired WikiGrok claims from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) [23:17:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Link previews. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [23:17:29] It was kind of soothing [23:19:18] Wrong window. [23:19:30] (03PS2) 10Dbrant: [WIP] Link previews. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [23:19:36] Deskana: dr0ptp4kt_cold heading out a bit early [23:19:51] kaldari: how can I get an importer right to http://en.m.wikipedia.beta.wmflabs.org? [23:19:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Link previews. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [23:20:02] * YuviPanda kind of soothes Deskana [23:22:26] (03CR) 10Dr0ptp4kt: [C: 04-1] "If I'm not mistaken, the category methods should be renamed with the wmf_ prefix." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202444 (owner: 10Fjalapeno) [23:23:01] 6Mobile-Web, 5Patch-For-Review: Table border parameter does not display right border on mobile - https://phabricator.wikimedia.org/T92913#1187957 (10bmansurov) @Tvx1, you can see the same page at http://en.m.wikipedia.beta.wmflabs.org/wiki/2014_Formula_One_season where the issue is fixed. [23:23:17] coreyfloyd:^^^ relatively minor and simple gripe. not urgent, i think [23:23:44] dr0ptp4kt_cold: good catch. Will amend in the morning [23:24:26] (03PS3) 10Dbrant: [WIP] Link previews. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [23:24:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Link previews. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [23:28:08] (03CR) 10Dr0ptp4kt: "Quick question inline." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [23:28:25] coreyfloyd: ^^ quick question on that one [23:29:04] (03PS4) 10Dbrant: [WIP] Link previews. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [23:29:50] 10Wikipedia-Android-App: android rendering missing period at end of first sentence - https://phabricator.wikimedia.org/T95236#1187972 (10Dbrant) a:3Dbrant [23:30:04] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: android rendering missing period at end of first sentence - https://phabricator.wikimedia.org/T95236#1183867 (10Dbrant) [23:30:25] (03CR) 10Fjalapeno: [C: 032] Fixing unit tests and running tests in alpha lane T94421 (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [23:30:37] Whoops [23:30:43] Wrong button [23:30:53] dr0ptp4kt_cold: can you fix that? [23:31:04] (03CR) 10Deskana: [C: 04-2] Fixing unit tests and running tests in alpha lane T94421 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [23:31:21] coreyfloyd: That should stop it. [23:31:44] coreyfloyd: I think now if you remove your +2, and I remove my -2, it'll be okay. [23:31:59] dr0ptp4kt_cold: Deskana thanks. And that's why you don't comment on gerrit patch sets from your iPhone. [23:32:56] (03CR) 10Deskana: "I gave this a -2 very quickly to block the merging upon request of Fjalapeno, who accidentally gave this a +2. Apologies for not leaving a" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [23:34:23] coreyfloyd: I removed your +2 by removing you as a reviewer. [23:34:47] (03CR) 10Deskana: "Removing my -2 now that Fjalapeno's +2 has been removed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202321 (owner: 10Fjalapeno) [23:34:56] coreyfloyd: Should be fine now. [23:35:23] Deskana: dunka! [23:35:44] (03PS1) 10Jdlrobson: Hygiene: Rename misleading module name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202619 [23:35:55] (03CR) 10Dbrant: [C: 032] ShareAFact: correctly align WP wordmark for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201732 (https://phabricator.wikimedia.org/T95345) (owner: 10BearND) [23:36:13] coreyfloyd: you were just trying to avoid self merge, right? no further patchiest on that patch required, right? [23:36:20] (03CR) 10Jdlrobson: [C: 031] Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 (owner: 10Jdlrobson) [23:36:25] (03CR) 10Jdlrobson: [C: 032] Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 (owner: 10Jdlrobson) [23:36:27] thx Deskana for the save [23:36:40] (03CR) 10Jdlrobson: [C: 031] Hygiene: Make confirm button in PageActionOverlay optional [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [23:36:59] (03PS5) 10Jdlrobson: Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 [23:37:16] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202261 (owner: 10Jdlrobson) [23:37:41] (03PS5) 10Jdlrobson: Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [23:39:14] 6Mobile-Web: Increase page image size in search [alpha] - https://phabricator.wikimedia.org/T95370#1188000 (10Jdlrobson) 3NEW [23:40:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 (owner: 10Jdlrobson) [23:40:24] 6Mobile-Web: In alpha desktop table of contents should appear in top right - https://phabricator.wikimedia.org/T95371#1188010 (10Jdlrobson) 3NEW [23:40:34] 6Mobile-Web: Increase page image size in search [alpha] - https://phabricator.wikimedia.org/T95370#1188018 (10Jdlrobson) [23:40:51] bgerstle_afk: coreyfloyd Deskana mhurd i'm gonna wrap up [23:40:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: ContentOverlay is in mobile.overlays module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202053 (owner: 10Jdlrobson) [23:41:46] dr0ptp4kt_cold: hope your cold is better tomorrow [23:41:48] (03PS5) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [23:42:01] mhurd: thx, peace out [23:43:08] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1188024 (10Jdlrobson) I'm waiting for a reply here: https://phabricator.wikimedia.org/T86366#1136772 [23:44:28] (03CR) 10Bmansurov: Hygiene: Rename misleading module name (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202619 (owner: 10Jdlrobson) [23:44:42] (03PS1) 10Dbrant: Fix missing period at the end of first sentence in some articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202620 (https://phabricator.wikimedia.org/T95236) [23:44:44] (03CR) 10Kaldari: [C: 031] "Code looks fine, but need PM approval on the messaging changes. Added Jon Katz as a reviewer." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200526 (owner: 10Ricordisamoa) [23:47:50] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: OutOfMemoryError in commonSectionFetchOnCatch - https://phabricator.wikimedia.org/T94700#1188055 (10Dbrant) 5Open>3Resolved This can be considered resolved as of the above-mentioned patch. We can reopen if we get additional reports after deploying. [23:50:31] a new dawn of vandalism.. https://en.m.wikipedia.org/wiki/Special:MobileDiff/655422864 [23:57:53] kaldari: https://gerrit.wikimedia.org/r/#/c/198691/ [23:58:48] JonKatz: Were you aware of this? ^ [23:59:26] Deskana just found out. [23:59:54] JonKatz: Are you okay with it? It seems like your comment was misunderstood to me.