[00:01:45] mholloway: is this ready for review: https://gerrit.wikimedia.org/r/202767 [00:03:08] dbrant: actually there's one small change i should correct (5 mins if that), but then yes [00:03:53] dbrant: actually you can look at it now. i was going to strip out a todo comment but it actually still applies [00:05:00] dbrant: this patch only checks for network connectivity, we're going to do that piece first and then work on getting/displaying the server error codes in a subsequent patch. [00:05:52] dbrant: (checks for network connectivity and displays an appropriate message, that is.) [00:10:02] (03PS2) 10Jdlrobson: WIP: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 [00:12:20] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (owner: 10Jdlrobson) [00:15:24] (03PS7) 10Bmansurov: Filter out retired WikiGrok claims from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) [00:16:29] (03CR) 10Bmansurov: "Tested it, filtering works correctly. The problem is with inserting. The "IGNORE" flag is ignoring filtered data so old data stays intact." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [00:18:09] (03PS8) 10Bmansurov: Filter out retired WikiGrok claims from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) [00:21:51] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Further improve design of "Read in other languages" in the Android app - https://phabricator.wikimedia.org/T95213#1192678 (10bearND) Does this mean you don't want to show the English name of the language anymore? I don't have any issues getting rid of t... [00:26:42] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1192682 (10kaldari) Also reproducable in the iPhone emulator in the latest Chrome. [00:27:13] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Further improve design of "Read in other languages" in the Android app - https://phabricator.wikimedia.org/T95213#1192686 (10Dbrant) I kind of like the way it looks in the screenshot attached above, and I agree that it looks confusing when the title is in... [00:29:45] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Further improve design of "Read in other languages" in the Android app - https://phabricator.wikimedia.org/T95213#1192697 (10bearND) Forgot to comment on sorting the languages list. We already sort the language list in MRU order. Detecting the user's pr... [00:30:48] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Further improve design of "Read in other languages" in the Android app - https://phabricator.wikimedia.org/T95213#1192706 (10Vibhabamba) @dbrant Just confirming - So you are in agreement with the execution which @Mholloway has? [00:31:59] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Further improve design of "Read in other languages" in the Android app - https://phabricator.wikimedia.org/T95213#1192708 (10Dbrant) @vibhabamba correct! [00:32:16] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Further improve design of "Read in other languages" in the Android app - https://phabricator.wikimedia.org/T95213#1192709 (10Vibhabamba) @BearND If we think about the user base here - Users who speak a certain language can obviously read that language i... [00:35:20] (03CR) 10Dbrant: [C: 04-1] "see inline" (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway) [00:36:20] kaldari: sorry, wrong channel [00:36:22] kaldari: not sure if you saw my comment related to your patch. just wanted to remind [00:36:35] bmansurov: ? [00:36:50] i left this comment by accident to another channel for you [00:37:02] kaldari: i uploaded screenshots showing the padding [00:37:25] kaldari: https://gerrit.wikimedia.org/r/#/c/201862/5/resources/dialog/WikiGrokDialog.less [00:38:42] (03CR) 10BearND: [C: 04-1] "Did the review around the same time Dbrant did, so most comments were the same and therefore dropped. Only a few extra comments remain." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway) [00:38:46] bmansurov: your default font size seems much bigger than mine [00:39:03] hmm [00:40:58] bmansurov: does this change make a difference for that particular issue, or is it still an issue regardless of this change? [00:44:37] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1192748 (10kaldari) Also reproducable in iOS 6. Seems to have been introduced before March 21. Haven't tracked it down yet though. [00:46:46] (03CR) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [00:47:50] kaldari: which change? [00:48:41] kaldari: oh, right, no, this change doesn't cause the issue, but i thought you may have missed it [00:48:56] kaldari: you can submit another patch as you said [00:49:06] let me review the remaining parts [00:49:11] bmansurov: thanks :) [00:52:41] (03CR) 10Bmansurov: [C: 04-1] Fixing styling of intro and thanks panes in WikiGrok (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [00:54:13] (03CR) 10Bmansurov: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 (owner: 10Jdlrobson) [00:58:05] (03CR) 10Mholloway: Detect network connectivity and display appropriate error message to user (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway) [01:03:49] 6Mobile-Web, 3Mobile Web Design: Generate mockups of how tags will look on mobile article pages - https://phabricator.wikimedia.org/T94736#1192820 (10KHammerstein) [01:04:00] (03Merged) 10jenkins-bot: Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202052 (owner: 10Jdlrobson) [01:04:29] a bit off topic, but i just noticed something neat with the shazaam android app. it can publish cards to the google now launcher. it'd be pretty cool to try something similar with wikipedia cards. i'll have to look into that sometime [01:07:29] niedzielski: Yes, that would be awesome. [01:15:19] 10Wikipedia-Android-App: Add a screen dimmer lock - https://phabricator.wikimedia.org/T94677#1192834 (10Dbrant) Just a quick note that this would //not// require a new permission in the app, as was previously thought [citation needed], and implementing this wouldn't be more than a few lines of code. However, he... [01:17:56] niedzielski: hey there stephen! [01:22:51] (03PS5) 10Dbrant: [WIP] Link previews. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [01:37:15] (03PS1) 10Mhurd: Fix for some images causing entire section to scroll horizontally. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202977 [01:40:03] (03PS2) 10Mhurd: Fix for some images causing entire section to scroll horizontally. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202977 [01:40:54] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1192851 (10Mhurd) Fix: https://gerrit.wikimedia.org/r/#/c/202977 [01:42:31] (03CR) 10Mhurd: "The bulk of this diff is crustify silliness and upstream css updates." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202977 (owner: 10Mhurd) [01:44:07] coreyfloyd: bgerstle_afk https://gerrit.wikimedia.org/r/#/c/202977/ seems ready to go [01:46:25] mhurd: cool - will check out [01:48:02] coreyfloyd: thx! heading out. have a good night! [01:48:22] mhurd: np - catch you tomorrow [01:50:18] 6Mobile-Web: VisualEditorOverlay should be written as an OO.ui.Dialog - https://phabricator.wikimedia.org/T88559#1192859 (10Jdlrobson) @rmoen can you own this and make this happen? I've had @Moushira and @jkatzwmf ask me about this numerous times today and it would be great to get a deployment in tomorrow and ma... [01:50:41] 3Gather Sprint Enwiki: Get Gather updated on English Wikipedia - https://phabricator.wikimedia.org/T95454#1192861 (10Jdlrobson) @rmoen can you own this and make this happen? I've had @Moushira and @JKatzWMF ask me about this numerous times today and it would be great to get a deployment in tomorrow and make this... [01:52:14] (03PS7) 10Jdlrobson: Edit collection overlay allows you to manage existing members [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 (owner: 10Robmoen) [01:52:34] (03PS3) 10Jdlrobson: WIP: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 [01:55:41] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (owner: 10Jdlrobson) [01:56:20] 10Wikipedia-Android-App, 7I18n: Wikipedia app should not use Android's built-in localization system for the footer "Last edited" text - https://phabricator.wikimedia.org/T69431#1192865 (10jeremyb-phone) [01:56:38] 10Wikipedia-iOS-App: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1192867 (10Fjalapeno) 3NEW [01:57:06] 3Gather Sprint Enwiki: Get Gather updated on English Wikipedia - https://phabricator.wikimedia.org/T95454#1192874 (10Jdlrobson) @rmoen just saw your IRC reply :-) @phuedx may be able to help. I think things would be greatly simplified if we just fast forward MobileFrontend too since I know various things are in... [01:58:11] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1192879 (10Jdlrobson) [01:59:01] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1192881 (10Jdlrobson) This is an issue in the MathJax extension. If you find a maintainer of it I'll be able to help out. [02:03:21] 10Wikipedia-iOS-App: Bogus intermittent network connection loss - https://phabricator.wikimedia.org/T95514#1192885 (10Fjalapeno) 3NEW [02:06:08] 10Gather: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95515#1192895 (10Jdlrobson) 3NEW a:3Jdlrobson [02:06:41] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1192904 (10Jdlrobson) 3NEW a:3Jdlrobson [02:06:57] 10Gather: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1192904 (10Jdlrobson) [02:07:33] 10Gather: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1192904 (10Jdlrobson) [02:07:34] 10Gather: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95515#1192895 (10Jdlrobson) [02:07:36] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1192913 (10Jdlrobson) [02:07:53] 10Gather: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1192904 (10Jdlrobson) [02:07:55] 10Gather: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95515#1192895 (10Jdlrobson) [02:07:57] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: [Spike 2hrs] Audit fetchers to enable us to sunset iOS 6 support - https://phabricator.wikimedia.org/T91789#1192918 (10Fjalapeno) Not sure if this actually needs to be done and seems a little nebulous. Why do we have to audit network support to drop iOS 6? We don... [02:08:12] (03PS4) 10Jdlrobson: Add EventLogging to the watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) [02:08:33] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [02:08:51] (03PS2) 10Jdlrobson: Border box no longer default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202760 (https://phabricator.wikimedia.org/T86366) [02:08:59] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1192921 (10Fjalapeno) @dr0ptp4kt can we make this a step on the release wiki page? That way we could just kill this here. [02:10:45] (03CR) 10jenkins-bot: [V: 04-1] Add EventLogging to the watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) (owner: 10Jdlrobson) [02:11:19] (03PS5) 10Jdlrobson: Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 [02:14:30] (03CR) 10Fjalapeno: [C: 031] "Looks good!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202977 (owner: 10Mhurd) [02:14:40] (03PS5) 10Jdlrobson: Add EventLogging to the watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) [02:14:51] (03CR) 10Fjalapeno: "Oh, and nice commit message…" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202977 (owner: 10Mhurd) [02:15:59] (03PS8) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) [02:20:09] 10Wikipedia-Android-App: birth, death dates in bios are missing - https://phabricator.wikimedia.org/T95517#1192933 (10jeremyb-phone) 3NEW [02:21:54] 10Wikipedia-Android-App: birth, death dates in bios are missing - https://phabricator.wikimedia.org/T95517#1192940 (10jeremyb-phone) [02:36:36] 10Wikipedia-Android-App: birth, death dates in bios are missing - https://phabricator.wikimedia.org/T95517#1192953 (10wctaiwan) I think this is intentional. See the thread starting with https://lists.wikimedia.org/pipermail/mobile-l/2015-March/008761.html [02:45:18] hey dmitry! :) [02:45:36] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1192964 (10Physikerwelt) >>! In T95498#1192881, @Jdlrobson wrote: > This is an issue in the MathJax extension. If you find a maintainer of it I'll be able to help out. Do you... [02:46:02] 10Wikipedia-Android-App: birth, death dates in bios are missing - https://phabricator.wikimedia.org/T95517#1192967 (10Deskana) 5Open>3Invalid a:3Deskana This is intentional, as wctaiwan noted. [02:46:04] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1192970 (10Physikerwelt) p:5Triage>3Normal [03:07:22] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1192983 (10Jdlrobson) I meant MathJax sorry. Where should Mathjax bugs get filed? Mathjax will need to test itself out in the mobile skin (many client side code are incompatibl... [03:21:10] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: [Spike 2hrs] Audit fetchers to enable us to sunset iOS 6 support - https://phabricator.wikimedia.org/T91789#1192996 (10Deskana) @dr0ptp4kt Comments on Corey's proposal? [03:30:30] 10Wikipedia-Android-App: birth, death dates in bios are missing - https://phabricator.wikimedia.org/T95517#1193005 (10Legoktm) 5Invalid>3Open Just because it is intentional doesn't make it invalid :) [03:33:39] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1193018 (10Legoktm) https://www.mathjax.org/ --> https://github.com/mathjax/MathJax [04:03:37] 10Wikipedia-Android-App, 7user-notice: birth, death dates in bios are missing - https://phabricator.wikimedia.org/T95517#1193027 (10jeremyb-phone) @Deskana ok, responded to the thread. is there a planned release date? while discussion and notifications take place we should hide the stripping behind a feature... [04:52:24] 10Wikipedia-Android-App, 7user-notice: birth, death dates in bios are missing - https://phabricator.wikimedia.org/T95517#1193058 (10Deskana) 5Open>3declined >>! In T95517#1193027, @jeremyb-phone wrote: > @Deskana ok, responded to the thread. > > is there a planned release date? Not right now. We're still... [05:37:42] (03CR) 10Legoktm: "Please don't copy code without attribution, it's probably a copyright violation and makes code review significantly more difficult." (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/200181 (https://phabricator.wikimedia.org/T95228) (owner: 10Jdlrobson) [05:46:02] 10Wikipedia-Android-App: Add a screen dimmer lock - https://phabricator.wikimedia.org/T94677#1193077 (10Mdann52) I'm aware of this - as far as I see, I just pass along feedback as opposed to analysing it too much. I guess some people set a short timeout (to save battery or whatever), however they are too slow to... [05:48:38] 10Wikipedia-Android-App: Add a screen dimmer lock - https://phabricator.wikimedia.org/T94677#1193078 (10Mdann52) (I forgot to mention this was mentioned in 2 or 3 emails is seen come in through OTRS) [06:41:37] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1193123 (10Pkra) Duplicate of https://phabricator.wikimedia.org/T47816, I think. [07:31:10] (03PS1) 10Yurik: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) [07:34:02] (03CR) 10jenkins-bot: [V: 04-1] Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [07:36:31] (03PS2) 10Yurik: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) [08:26:13] 10Wikimedia-Mobile-Retired-(Ruby)-Gateway: Creating mobile homepage for Kurdish Wikipedia - https://phabricator.wikimedia.org/T29457#1193381 (10Ghybu) 5Resolved>3Open [08:37:43] 10Wikimedia-Mobile-Retired-(Ruby)-Gateway: Creating mobile homepage for Kurdish Wikipedia - https://phabricator.wikimedia.org/T29457#1193396 (10MaxSem) 5Open>3Invalid a:3MaxSem These are now under your control: https://www.mediawiki.org/wiki/Mobile_Gateway/Mobile_homepage_formatting [08:53:48] morning [09:05:06] hey joakino [09:05:15] morning phuedx [09:18:38] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1193490 (10phuedx) a:3phuedx [09:23:10] 3Gather Sprint Enwiki: Get Gather updated on English Wikipedia - https://phabricator.wikimedia.org/T95454#1193495 (10phuedx) No objections from our side – that I can think of right now, anyway. Be sure to get the green light from either @kaldari or myself before y'all actually push the button though! [10:58:13] 6Mobile-Web, 7I18n, 7Mobile, 5Patch-For-Review, 7Regression: Broken unicode character in mobile footer (ZERO WIDTH NON-JOINER) - https://phabricator.wikimedia.org/T86281#1193696 (10aude) we also have this issue in wikidata http://snag.gy/7R1aQ.jpg not sure we can / want to work around it here with css,... [10:58:51] 6Mobile-Web, 7I18n, 7Mobile, 5Patch-For-Review, 7Regression: Broken unicode character in mobile footer (ZERO WIDTH NON-JOINER) - https://phabricator.wikimedia.org/T86281#1193700 (10aude) on https://www.wikidata.org/wiki/Q76?uselang=fa {F110419} [11:51:17] (03PS16) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [11:55:52] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [12:37:44] (03CR) 10Jhernandez: [C: 032] Hygiene: Introduce ReportTableRow view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201744 (owner: 10Jdlrobson) [12:40:23] (03Merged) 10jenkins-bot: Hygiene: Introduce ReportTableRow view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201744 (owner: 10Jdlrobson) [12:52:32] (03CR) 10Jhernandez: [C: 04-1] "Some little problems and a big one with breaking error. Gonna submit patch now and merge." (035 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201745 (https://phabricator.wikimedia.org/T93422) (owner: 10Jdlrobson) [12:53:11] (03PS5) 10Jhernandez: Make Special:GatherLists render through a view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201745 (https://phabricator.wikimedia.org/T93422) (owner: 10Jdlrobson) [12:53:44] (03CR) 10Jhernandez: [C: 032] Make Special:GatherLists render through a view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201745 (https://phabricator.wikimedia.org/T93422) (owner: 10Jdlrobson) [12:55:09] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Special:GatherLists should use views and models - https://phabricator.wikimedia.org/T93422#1193882 (10Jhernandez) Merged patches. @jdlrobson If you can have a look at the php files you touch on phpstorm, it catches dumb mistakes and serious ones like undef... [12:57:45] (03Merged) 10jenkins-bot: Make Special:GatherLists render through a view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201745 (https://phabricator.wikimedia.org/T93422) (owner: 10Jdlrobson) [13:10:00] i need coffee [13:36:14] ugh [14:10:46] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1194133 (10TheDJ) I would say that if MathJax is not supported on mobile (it's a beast, we better not load it), we should ignore the user selected preference and fall back to a... [14:11:32] 10Wikipedia-iOS-App, 10Analytics-EventLogging, 6Analytics-Kanban, 3Mobile App Sprint 52 - iOS: Some events not validating for MobileWikiAppSavedPages schema - https://phabricator.wikimedia.org/T91290#1194136 (10Nuria) 5Open>3Resolved [14:15:57] 10Wikipedia-Android-App: App unexpectedly closes on Samsung Galaxy Ace II X (S7560M) - https://phabricator.wikimedia.org/T76279#1194151 (10Florian) @dbrant: Will the related changes be in alpha the builds? https://android-builds.wmflabs.org/ (i see the last successful build was 2.4.2015 :/) [14:21:00] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1194168 (10phuedx) In the Wikitext editor, this is caused by the textarea being expanded to the height of the content, so it ain't scrollable, rather than the height of the phone. [14:30:02] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1194199 (10phuedx) I'm guessing it's caused by the `.microAutosize();` line in https://gerrit.wikimedia.org/r/#/c/195995/2/javascripts/modules/editor/EditorOverlay.js. [14:33:24] hallo [14:33:39] In gather-editfeed-title, what do "feeds" refer to exactly? [14:36:31] 10Gather, 7I18n: Gather-add-to-collection-summary needs gender support - https://phabricator.wikimedia.org/T95547#1194231 (10Amire80) 3NEW [14:36:51] hi aharoni [14:36:53] let me see [14:37:13] I mean, I kinda guess what it is, but the qqq could make it clearer. [14:37:19] 10Wikimedia-Mobile-Retired-(Ruby)-Gateway: Creating mobile homepage for Kurdish Wikipedia - https://phabricator.wikimedia.org/T29457#1194247 (10MarkAHershberger) ----- Original Message ----- > MaxSem added a subscriber: MaxSem. > MaxSem closed this task as "Invalid". > MaxSem claimed this task. > MaxSem added a... [14:37:34] And what does "my" refer to - "my feeds" or "my edit(s)"? [14:38:39] aharoni: so this view is equivalent to the watchlist on mobile, when you click on modified at the top [14:38:44] 10Gather, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1194260 (10Amire80) [14:38:59] aharoni: it is exactly the same as that, but with support for choosing among your gather collections [14:39:19] aharoni: i'm guessing JonR came up with the title, and it is totally open to improvements, sounds weird to me too [14:39:33] Are you sure that "feed" is the best word to use here?.. I'm not even sure that it's good in English. [14:39:48] (I'm very nitpicky about translatable message, you'll get used to me :) ) [14:39:54] s/message/messages/ [14:39:56] aharoni: i'm guessing he chose that because the view is called "feed" internally [14:40:00] aharoni: what could we name it [14:40:26] "Watchlist" :) [14:40:30] Collection edits [14:40:39] "Edits to pages in my collections" [14:40:56] aharoni: if we do that they'll kill us, but I think that's the ultimate objective (shhh dont tell) [14:42:18] aharoni: does it look good? http://i.imgur.com/SMDtVE8.png [14:42:27] Estimem aquestes comunitats molt, oi? :) [14:42:36] Looks good to me [14:42:52] aharoni: I'm not sure about collections, since there is All, talk, other, in the options [14:43:26] do you think you can send a patch+task https://phabricator.wikimedia.org/tag/gather_sprint_enwiki/ and put it in code review? [14:43:32] if you cant i can do it for you [14:43:41] I can :) [14:43:50] i'm fine with the change and it is an experimental "feature" so lets do it [14:44:30] joakino: what's the "watchlist" element exactly? [14:44:36] is it an input box? a dropdown? [14:44:38] something else? [14:44:57] aharoni: a select box, the styling is a bit off [14:45:08] ok [14:46:19] (03CR) 10Jhernandez: [C: 032] Hygiene: Add support to Collection model for hidden status [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202286 (owner: 10Jdlrobson) [14:46:38] 10Gather, 7I18n: Reconsider the usage of "feed" in Gather's UI - https://phabricator.wikimedia.org/T95548#1194282 (10Amire80) 3NEW [14:46:53] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1194290 (10Physikerwelt) >>! In T95498#1194133, @TheDJ wrote: > I would say that if MathJax is not supported on mobile (it's a beast, we better not load it), we should ignore t... [14:47:58] (03PS1) 10Amire80: Change "feeds" to "Edits to pages in my collections" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203077 (https://phabricator.wikimedia.org/T95548) [14:48:34] 10Gather, 7Design, 7I18n, 5Patch-For-Review: Reconsider the usage of "feed" in Gather's UI - https://phabricator.wikimedia.org/T95548#1194303 (10Amire80) [14:48:46] joakino: done, can you add it to the sprint? [14:48:55] sure [14:48:58] thanks [14:50:32] 10Gather, 3Gather Sprint Enwiki, 7Design, 7I18n, 5Patch-For-Review: Reconsider the usage of "feed" in Gather's UI - https://phabricator.wikimedia.org/T95548#1194334 (10Jhernandez) [14:51:03] 10Gather, 3Gather Sprint Enwiki, 7Design, 7I18n, 5Patch-For-Review: Reconsider the usage of "feed" in Gather's UI - https://phabricator.wikimedia.org/T95548#1194341 (10Jhernandez) a:3Amire80 [14:51:12] (03CR) 10Jhernandez: [C: 032] Change "feeds" to "Edits to pages in my collections" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203077 (https://phabricator.wikimedia.org/T95548) (owner: 10Amire80) [14:51:14] (03PS1) 10Jdlrobson: Avoid fatals on Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203078 [14:53:49] (03CR) 10Jdlrobson: [C: 04-1] Use button with spinner for create collection button (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202923 (owner: 10Robmoen) [14:54:52] (03Merged) 10jenkins-bot: Hygiene: Add support to Collection model for hidden status [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202286 (owner: 10Jdlrobson) [14:55:25] (03Merged) 10jenkins-bot: Change "feeds" to "Edits to pages in my collections" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203077 (https://phabricator.wikimedia.org/T95548) (owner: 10Amire80) [15:01:50] git gerrit is being really slow today [15:04:27] joakino: which phab board should I use for filing tasks for mobile web? [15:05:34] dr0ptp4kt_cold: Mobile-Web mainly, but i think if you file against MobileFrontend then Mobile-web is added automagically [15:08:28] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1194412 (10Florian) I don't have an iPhone and Mac, so i have to ask :) Can you scroll the textarea with two fingers (two-finger-scroll)? [15:09:17] joakino: thanks! [15:16:35] (03CR) 10Jhernandez: [C: 04-1] "I agree with florian that if it is called like that, if it exists then it should be used for the header (effectively allowing you to add h" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202636 (owner: 10Jdlrobson) [15:17:43] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: [Blocked] No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1194482 (10Jhernandez) @jdlrobson I've been investigating about not showing the header html if there was no ti... [15:18:33] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1194484 (10DoRD) >>! In T95465#1194412, @Florian wrote: > I don't have an iPhone and Mac, so i have to ask :) Can you scroll the textarea with two fingers (two-finger-scroll)? I tried that and... [15:18:43] 6Mobile-Web: On iOS 8.3 iPhone 5c in Private mode Safari, sometimes dragging/flicking doesn't scroll in modals - https://phabricator.wikimedia.org/T95561#1194485 (10dr0ptp4kt) 3NEW [15:18:56] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1194493 (10phuedx) @Florian: as @kaldari pointed out, you can reproduce this bug with the device emulator in Chrome (see https://developer.chrome.com/devtools/docs/device-mode). [15:21:52] 6Mobile-Web: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1194502 (10Jhernandez) [15:21:53] 10Gather: Promote Gather to stable - https://phabricator.wikimedia.org/T94233#1194501 (10Jhernandez) [15:22:32] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1194505 (10phuedx) I have a WIP patch for this, which fixes the Wikitext editor. I'm currently installing VE so that I can provisionally fix that too. I spent some time `git bisect`ing to try... [15:22:54] 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1194508 (10Jhernandez) Added blocking task in T94233 [15:24:22] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1194511 (10Florian) >>! In T95465#1194493, @phuedx wrote: > @Florian: as @kaldari pointed out, you can reproduce this bug with the device emulator in Chrome (see https://developer.chrome.com/de... [15:29:19] (03PS4) 10Jdlrobson: WIP: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 [15:29:50] 10Gather, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1194531 (10phuedx) [15:32:11] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (owner: 10Jdlrobson) [15:35:24] 10Gather, 3Gather Sprint Enwiki: Icon styles loaded twice on Gather special pages - https://phabricator.wikimedia.org/T95014#1194556 (10Jhernandez) a:3Jhernandez [15:35:56] 10Gather, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1194561 (10phuedx) This task came out of the discussion of T94737 between @Jdlrobson and myself. As part of the Browse experiment, the Readership team wants to be abl... [15:36:50] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: Add 'new' icon to collections in main menu - https://phabricator.wikimedia.org/T95245#1194566 (10Jhernandez) What's this about? No clues or description in the task... [15:37:27] 10Gather, 3Gather Sprint Enwiki: long collection names create horizontal scrolling on creation overlay - https://phabricator.wikimedia.org/T95209#1194568 (10Jhernandez) a:3Jhernandez [15:44:14] 6Mobile-Web: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1194587 (10phuedx) [15:44:59] (03PS1) 10Jhernandez: Don't load icons twice [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203088 (https://phabricator.wikimedia.org/T95014) [15:45:44] 6Mobile-Web: Make a Gather list that cannot be hidden by anyone - https://phabricator.wikimedia.org/T94757#1194601 (10phuedx) This might fall out of the implementation of T95457. [15:46:42] 6Mobile-Web: PM task: Create anonymous gather lists for all tags identified in T94714 - https://phabricator.wikimedia.org/T94740#1194611 (10phuedx) 5Open>3Resolved a:3phuedx This is superseded by T95446. [15:47:34] 10Gather, 6Mobile-Web, 3Mobile Web Design, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1194619 (10phuedx) As a result... [15:48:29] 10Gather, 6Mobile-Web, 3Mobile Web Design, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out how to create a special anonymous gather list that has no identifiable creator/owner, but can be edited just like any other. - https://phabricator.wikimedia.org/T94737#1194624 (10phuedx) @Jdlrobson a... [15:49:44] wow [15:49:58] s/n ratio is super low right now [15:51:09] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1194645 (10dr0ptp4kt) It's already [[ https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Releases | there ]], but I'd rather that we keep the card so that it is hard... [15:51:14] (03PS1) 10Jhernandez: Fix long collection names without spaces breaking overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203090 (https://phabricator.wikimedia.org/T95209) [15:51:24] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1194650 (10dr0ptp4kt) [15:52:55] (03PS5) 10Jdlrobson: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) [15:53:25] (03CR) 10Jdlrobson: [C: 032] Fix long collection names without spaces breaking overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203090 (https://phabricator.wikimedia.org/T95209) (owner: 10Jhernandez) [15:53:51] phuedx: lol [15:54:00] phuedx: irc is getting to be unusable [15:54:07] oh be quiet [15:54:11] it's not /that/ bad [15:54:16] :P [15:54:29] bugzilla wasn't this noisy [15:54:48] (03CR) 10Jdlrobson: [C: 04-1] Don't load icons twice (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203088 (https://phabricator.wikimedia.org/T95014) (owner: 10Jhernandez) [15:55:07] jdlrobson doesn't sleep, he's perpetually working [15:55:13] joakino: that might be because it was harder to have conversations via bugzilla ;) [15:55:19] joakino: inorite [15:55:38] phuedx: maybe but doesn't mean we have to log everything that happens to irc [15:55:41] 6Mobile-Web, 3Mobile Web Design: Stop serving menu in the page HTML - https://phabricator.wikimedia.org/T95332#1194669 (10phuedx) [15:55:49] joakino: i agree [15:56:03] (03CR) 10jenkins-bot: [V: 04-1] Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) (owner: 10Jdlrobson) [15:56:21] i'm just saying harking back to the gloriously quiet days of bugzilla might not be fair ;) [15:56:33] imagine what this place would be like if we were on github and logging to irc! [15:56:38] (03Merged) 10jenkins-bot: Fix long collection names without spaces breaking overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203090 (https://phabricator.wikimedia.org/T95209) (owner: 10Jhernandez) [15:56:52] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: Add 'new' icon to collections in main menu - https://phabricator.wikimedia.org/T95245#1194678 (10Jdlrobson) [15:57:00] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: Add 'new' icon to collections in main menu - https://phabricator.wikimedia.org/T95245#1184173 (10Jdlrobson) Updated @jhernandez - sorry! [15:57:24] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: Add 'new' icon to collections in main menu - https://phabricator.wikimedia.org/T95245#1194687 (10Jdlrobson) [15:57:30] 6Mobile-Web: Initial banner image should be delivered as part of the initial response - https://phabricator.wikimedia.org/T90698#1194688 (10phuedx) [15:58:11] 10Gather, 3Gather Sprint Enwiki, 7Design, 7I18n, 5Patch-For-Review: Reconsider the usage of "feed" in Gather's UI - https://phabricator.wikimedia.org/T95548#1194692 (10Jdlrobson) 5Open>3Resolved Only worry is this is too long a title... but we can iterate on it! :) [15:58:47] 10Gather, 3Gather Sprint Enwiki: GatherEditFeed throwing server errors - https://phabricator.wikimedia.org/T95568#1194695 (10Jdlrobson) 3NEW [15:59:03] arggg [15:59:04] (03PS2) 10Jdlrobson: Avoid fatals on Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203078 (https://phabricator.wikimedia.org/T95568) [15:59:10] anyone got ve installed locally? [15:59:17] can't get it working on vagrant for some reason [15:59:23] 10Gather, 3Gather Sprint Enwiki, 7Design, 7I18n, 5Patch-For-Review: Reconsider the usage of "feed" in Gather's UI - https://phabricator.wikimedia.org/T95548#1194706 (10Jhernandez) @jdlrobson Certainly long, but at least it explains well what the page does until we can name this watchlist 😉 [15:59:44] 10Gather, 3Gather Sprint Enwiki: Prevent e-mail addresses being used in list titles/descriptions - https://phabricator.wikimedia.org/T95208#1194708 (10Jdlrobson) [15:59:52] 10Gather, 3Gather Sprint Enwiki, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1194710 (10Jdlrobson) [15:59:53] phuedx: i had it but disabled it because it made vagrant a whole lot slower [15:59:55] 10Wikipedia-Android-App: App unexpectedly closes on Samsung Galaxy Ace II X (S7560M) - https://phabricator.wikimedia.org/T76279#1194712 (10Deskana) @Florian @bearND @dbrant We probably just need to restart the service [16:00:14] joakino: that [16:00:34] unfortunately, this: https://phabricator.wikimedia.org/T95465 [16:01:10] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: [Spike 2hrs] Audit fetchers to enable us to sunset iOS 6 support - https://phabricator.wikimedia.org/T91789#1194713 (10dr0ptp4kt) That's fine with me if it's fine with @mhurd and @bgerstle. The purpose of the task was to determine where to add more graceful degra... [16:01:20] dr0ptp4kt -- I am starting the testflight process [16:01:27] thanks for the email :) [16:01:45] (03CR) 10Jdlrobson: "yeh this is super hacky. I'm still tryin to work out a nicer way we can do this... if you have any bright ideas please go for it :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202636 (owner: 10Jdlrobson) [16:01:55] (03PS2) 10Jhernandez: Don't load icons twice [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203088 (https://phabricator.wikimedia.org/T95014) [16:02:20] (03Abandoned) 10Phuedx: [WIP] Client-side face detection in lead images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/201716 (owner: 10Phuedx) [16:02:45] (03CR) 10Jdlrobson: "time to use server side templates in some way..?!!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202636 (owner: 10Jdlrobson) [16:03:21] (03CR) 10Jdlrobson: [C: 032] Don't load icons twice [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203088 (https://phabricator.wikimedia.org/T95014) (owner: 10Jhernandez) [16:07:34] (03CR) 10Phuedx: [C: 032] Add page_id and ns to X-Analytics header for action=mobileview requests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202802 (https://phabricator.wikimedia.org/T92875) (owner: 10Legoktm) [16:08:57] (03Merged) 10jenkins-bot: Don't load icons twice [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203088 (https://phabricator.wikimedia.org/T95014) (owner: 10Jhernandez) [16:10:11] (03CR) 10jenkins-bot: [V: 04-1] Add page_id and ns to X-Analytics header for action=mobileview requests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202802 (https://phabricator.wikimedia.org/T92875) (owner: 10Legoktm) [16:10:53] (03PS1) 10Phuedx: WIP: Don't let the Wikitext editor over-expand [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203095 (https://phabricator.wikimedia.org/T95465) [16:11:47] 6Mobile-Web, 5Patch-For-Review: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1194737 (10phuedx) Still trying to install VE on MWV… [16:13:41] Good morning bearND, question for you: where can I find values-qq/strings.xml? I don't see a /values-qq folder under /res. [16:15:48] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1194754 (10Fjalapeno) @dr0ptp4kt my feedback here is that we should make a process and stick to it. I understand you want to make sure it gets done, but when we track... [16:18:50] (03PS1) 10Florianschmidtwelzow: Don't add empty title tags if no page title set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203099 [16:19:20] (03PS1) 10Florianschmidtwelzow: Do not show title at top of Gather pages. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203100 [16:20:39] (03CR) 10Florianschmidtwelzow: "> if you have any bright ideas please go for it :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202636 (owner: 10Jdlrobson) [16:20:43] mholloway: Good morning. Yes, there is a values-qq directly under wikipedia/res [16:21:27] mholloway: https://github.com/wikimedia/apps-android-wikipedia/tree/master/wikipedia/res/values-qq [16:21:55] bearND: ah, for some reason it didn't get imported into studio. [16:22:09] bearND: thanks. [16:22:25] mholloway: are you in the Project or in the Android perspective? [16:22:57] I was in the Android perspective. [16:23:53] bearND: I see it now in the Project perspective. [16:23:58] mholloway: Yeah, that one shows the folders in a different hierarchy (not necessarily the same as on the file system) [16:24:03] phuedx: https://phabricator.wikimedia.org/T95465 where is the problem? Can i help? :) [16:24:11] mholloway: more like a logical hierarchy [16:27:55] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1194817 (10NiharikaKohli) @Nicolas_Raoul you too need to sign up on Melange. :) [16:37:01] FlorianSW: currently you can't scroll the wikitext editor or ve on ios8 (maybe 6/7) [16:37:46] seems like the microAutosize library is over-sizing the editor [16:37:51] ^ current theory [16:38:01] phuedx: i mean with your VE installation :) [16:38:05] oh [16:38:07] it just isn't working [16:38:20] but it has worked for the last time :/ [16:38:40] ^ microAutosize (and scrolling at all) [16:38:54] 10Wikipedia-Android-App: Tabbed browsing - https://phabricator.wikimedia.org/T69251#1194842 (10Krenair) [16:39:21] 10Wikipedia-Android-App: Tabbed browsing - https://phabricator.wikimedia.org/T69251#1194847 (10Krenair) 5duplicate>3Open [16:40:39] (03CR) 10Jhernandez: [C: 04-1] "Please address issues before merge. Easy stuff :D" (0312 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 (owner: 10Robmoen) [16:41:51] FlorianSW: moreover, microAutosize hasn't changed recently [16:42:00] like, at all [16:42:01] bearND: I moved that network connection check function to Utils.java. Were you thinking I should log an error to the console when the check returns false? [16:42:29] phuedx: maybe there is somewhere a problem with my CodeMirror implementation? Have you tested to revert it locally? :/ [16:42:34] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202802 (https://phabricator.wikimedia.org/T92875) (owner: 10Legoktm) [16:42:56] FlorianSW: yeah but it didn't change anything [16:43:12] hmm :/ [16:43:21] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1194862 (10dr0ptp4kt) >>! In T93692#1194754, @Fjalapeno wrote: > @dr0ptp4kt my feedback here is that we should make a process and stick to it. Agreed. > I understand... [16:44:24] coreyfloyd: dr0ptp4kt_cold the current alpha crashed 10-12 times for me this morning. [16:44:30] Anyone else seeing this? [16:45:01] (03PS3) 10Florianschmidtwelzow: Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 [16:45:03] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1194875 (10Jhernandez) @MSyed @JKatzWMF @jdlrobson @rmoen re: consistency when saving results. If I'm understanding right what we are doing, the title/descripti... [16:46:04] FlorianSW: i think my fix is reasonable [16:46:17] but i'm really not sure what's changed around the editor recently [16:46:17] phuedx: testing it now :) [16:46:33] but i need a ve install so that i can mirror the styling [16:47:35] 6Mobile-Web, 10MobileFrontend, 10Browser-Tests: add metadata to ChunkyPNG image - https://phabricator.wikimedia.org/T67274#1194885 (10greg) @jdlrobson: can you give some background here and/or let me know if this is still needed? [16:47:46] phuedx: i can't see any change that would result in such a problem: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commits/master/javascripts/modules/editor [16:47:58] (03CR) 10Phuedx: [C: 032] "One more time for the cheap seats in the back!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202802 (https://phabricator.wikimedia.org/T92875) (owner: 10Legoktm) [16:47:59] FlorianSW: I thought we were doing M.define( 'current/valid/path', Ass ).deprecate( 'old/crappy/path' ) ? maybe I missunderstood [16:48:53] joakino: uhm, that's correct, that's what i've uploaded :) (have i overlooked something :o) [16:49:23] mholloway: fyi, in Android perspective the file variants don't show up as different folders but different files. So, there are many strings.xml files shown under vales/strings.xml. You want the one that has (qq) at the end. [16:49:24] FlorianSW: neither in the less folder [16:49:58] bearND: ahh, yes, there itis [16:50:48] FlorianSW: wait -- there's churn on the microAutosize module [16:50:53] (03Merged) 10jenkins-bot: Add page_id and ns to X-Analytics header for action=mobileview requests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202802 (https://phabricator.wikimedia.org/T92875) (owner: 10Legoktm) [16:51:27] FlorianSW: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commits/master/javascripts/externals/micro.autosize.js [16:51:32] missed that the first time around [16:52:51] phuedx: what do you mean? The commits are from last year? [16:53:27] vibha: in the gallery, right? [16:53:27] yup but they mention broken editing in ios8 and fixing the expanding-past-the-size-of-the-window problem [16:54:02] dr0ptp4kt_cold: yes - all crashes occur with gallery [16:54:33] phuedx: maybe apple has fixed the problem and now introduced another problem for us? [16:54:49] dr0ptp4kt_cold: Is this a known issue that was introduced afterward our submission? [16:55:16] vibha: we currently have the 'assertion' crashing stuff turned on for alpha, which causes crashes when 'things that shouldn't happen' happen. coreyfloyd, would it be possible to turn off the assertion crashes for the alpha builds that get uploaded to test flight? it's fine i think for us as developers to have to deal with that stuff, but i think for the sign off from etonkovidova and vibha it actually may impede t [16:55:37] coreyfloyd: of why we may have the assertion crashing in alpha test flight, but it seems the practice may be more problematic [16:55:45] (03CR) 10Phuedx: "It seems Jerkins likes odd code review messages…" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202802 (https://phabricator.wikimedia.org/T92875) (owner: 10Legoktm) [16:56:27] gonna take 5 while i'm eating my dinner [16:56:34] (03CR) 10Legoktm: "Actually that's a zuul bug..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202802 (https://phabricator.wikimedia.org/T92875) (owner: 10Legoktm) [16:56:35] dr0ptp4kt_cold: I think bgerstle_afk wanted those turned on - so we know when we have issues in our alpha builds and get crash reports. [16:56:43] legoktm: lolol [16:56:49] :P [16:56:54] phuedx: thanks for the merge though! :) [16:56:57] bearND: So, what did you have in mind in terms of an error message in the isNetworkConnectionPresent function? [16:57:02] phuedx: i have a working VE installation on one of my servers, but i can't give you ssh or ftp access :/ [16:58:07] dr0ptp4kt_cold: I think bgerstle_afk is probably right there… we now have reports from vibha on her crash and can probably address it today [17:00:48] coreyfloyd: ok. vibha, are you blocked on anything due to the crashing? you may be able to survive by visiting different image galleries for different articles where the "isn't supposed to happen" stuff won't happen. [17:01:30] FlorianSW: as you said that, ve somehow enabled itself \o/ [17:01:32] right [17:01:34] gonna food [17:01:54] legoktm: np -- patch was good and it Enables Things™ [17:02:01] phuedx: lol :D bon appetit [17:02:49] dr0ptp4kt_cold: coreyfloyd I am blocked, trying to test normalized text in galleries. [17:02:54] bearND: I'm ready to resubmit the patch otherwise [17:04:40] dr0ptp4kt -- I just sent you my email for TestFlight [17:04:43] vibha: if no galleries work I think you need to kick the task back to us and we need to fix the issue so you can test. [17:04:43] mholloway: You've already got a string for that, don't you? Did Vibha have any suggestions? [17:05:05] vibha: oh, the penguin article :) [17:05:09] vibha: right? [17:05:12] (03PS7) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [17:05:13] dr0ptp4kt_cold - sorry for the confusion, I just sent you an email with my TestFlight email. [17:05:32] dr0ptp4kt_cold: all articles actually [17:06:08] vibha: yeah sounds like we need to correct that today. [17:07:01] I'm in an offsite - no access to phab [17:07:11] dr0ptp4kt_cold: I think this will actually end up falling on bgerstle_afk even though it was mhurds ticket. [17:07:23] Can someone move the task back to development? [17:07:27] vibha: I can bring it up at standup [17:07:33] vibha: yeah [17:07:52] vibha: and I will coment on the card and note yiu [17:08:52] bearND: Yes, Here I think the old "there is no network connection" string is fine when that's actually the case. But I thought you meant I should the function in Utils.java return a message rather than handling the result after calling it from PageViewFragmentInternal.showNetworkError() [17:08:52] Your crash report [17:09:48] bearND: I haven't asked vibha about the strings here aside from adding her to the cc's on the Phabricator task [17:10:42] mholloway: in the other case you've got generic_page_error: There was a problem handling your request. [17:10:50] vibha: you would make a good security tester if you can crash everything ;) [17:11:28] I sent 4 successive crash reports :) [17:11:28] ASherman: thanks, will get you lined up [17:11:48] vibha: you're a l33t h4x0r! [17:12:20] mholloway: can you mention me in the phab comment or send me the task name ( for comment on strings ) ? [17:12:40] bearND: Should I change that to be more specific (since we've eliminated the possibility of the network connection being the problem)? [17:13:02] vibha: would you be able to have mhurd push the alpha build to your device without the crashing? he'll need to ensure he's using a 'release scheme' that doesn't crash on those asserts [17:13:15] hrrm [17:13:23] gotta go give the kids a bath [17:13:35] vibha: that is to say, mhurd, or even nirzar may be able to use Xcode to get it on your phone [17:13:43] dr0ptp4kt_cold: will do [17:13:51] they just need to check out the 'tip of master'. cool vibha [17:14:05] mholloway: sure, improvements to the message are welcome [17:14:11] bearND: I guess the way I envisioned this heading (though I'm certainly not committed to it) is to give the general "problem handling your request" message when it's not a user network connection problem, and down the road add a textview to display (in smaller text) the actual server error code [17:14:22] vibha: will do, one sec [17:14:23] 6Mobile-Web, 5Patch-For-Review: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1194984 (10phuedx) Done. Investigating the VE-side of things… [17:15:03] mholloway: Yes, that sounds reasonable. [17:15:53] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [17:16:07] mholloway: If you need to make it return more than one value consider creating a class representing the structure data [17:16:16] structured [17:17:12] bearND: Yes, that seems like the right way to go. [17:17:55] sorry FlorianSW had a meeting [17:18:01] joakino: np :) [17:18:15] FlorianSW: so in the commit message it says M.define( 'context', context ).deprecate( 'contextNew' ) instead of M.define( 'current/valid/path', Ass ).deprecate( 'old/crappy/path' ) [17:18:25] (03CR) 10Ottomata: "Awesooome! Let me know when this gets deployed and I'll check it out on analytics' end." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202802 (https://phabricator.wikimedia.org/T92875) (owner: 10Legoktm) [17:19:06] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1195028 (10Mholloway) Pinging @vibhabamba for comment, as requested. :) What do you think of these error messages? When the user has no network connection:... [17:19:24] vibha: ^ [17:19:43] joakino: the path doesn't matter, it's the id, the name of the module. Our modules like page, context or Skin (which can or are used in several othe rmodules, doesn't have a path. Modules like ediotr, talk or something else, which does a specific function, has a path, like modules/editor/wikitext, or something else :) [17:20:08] joakino: so you could write M.define( 'global/context', context ).deprecate( 'global/contextNew' ) too :) [17:20:50] FlorianSW: ye ye, the thing is, when you remove deprecation, the idea would be to remove the path on the .deprecate function, right? [17:21:29] i know we can do it any way, the difference comes when we need to remove a deprecated path, what do we remove from the code, only the .deprecate() or exchange paths and then remove the .deprecate() [17:22:08] also the difference is what path gives you the deprecation error [17:22:26] FlorianSW: that's why i'm insisting on where you put the new module and where you leave the old one [17:22:29] joakino: ah, now i understand what you mean :D My change would require, that you write two lines, one for deprecation and one for the new module :) I think you mean, that you combine both? [17:22:40] mholloway: Wanted to mention that it would be good to create a new util class for network related things, e.g. NetworkUtils. See other util classes in the util package. [17:23:25] mholloway: Note the marking of the class as final and adding the private constructor. If they don't exist checkstyle will be unhappy. [17:23:56] joakino: so, if i understand you correct, you mean (e.g.): M.define( 'newModule', module ).deprecate( 'oldModule' ); and you can use M.require( 'newModule' ); and M.require( 'oldModule' ), where the second one logs a deprecation warning? [17:24:22] FlorianSW: no, sorry I'm not explaining myself. I'd like to write M.define( 'global/contextNew', context ).deprecate( 'global/context' ) so that M.require( 'global/context' ) gives you the deprecated method, and so that when we want to remove it we just leave M.define( 'global/contextNew', context ) removing the last part as a whole [17:24:32] yes FlorianSW [17:24:39] exactly that, what do you think [17:24:43] mholloway: I'd like to get away from this big monolithic Utils class. We can distribute the methods there into different related buckets. [17:25:03] vibha: so the theory of crashing like that is that if "something that shouldn't happen" happens, then the build is broken and someone needs to jump on it stat. it's a "stop the presses" sort of moment. in practice, we have maybe more places causing crashes than strictly necessary - for example, we know server apis don't behave the way we want [17:25:13] (03CR) 10BearND: [C: 032] Fix missing period at the end of first sentence in some articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202620 (https://phabricator.wikimedia.org/T95236) (owner: 10Dbrant) [17:25:23] joakino: ah, ok, that sounds like a reasonable way :) But we should implement "my" solution, too, if you want to deprecate a module without any replacement? [17:25:35] rmoen: Lemme know if you want a wingman for the deployment today [17:26:00] bearND: Ahh, I see. I guess I did the opposite of what you had in mind here :) [17:26:25] FlorianSW: you can also by doing M.deprecate( right? [17:27:00] https://gerrit.wikimedia.org/r/203078 < fatal joakino rmoen.. [17:27:12] (03CR) 10Bmansurov: [C: 04-1] Fixing styling of intro and thanks panes in WikiGrok (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [17:27:49] (03CR) 10Jhernandez: [C: 032] Avoid fatals on Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203078 (https://phabricator.wikimedia.org/T95568) (owner: 10Jdlrobson) [17:27:59] kaldari: i do want a wingman [17:28:01] bearND: Will address that before I resubmit [17:28:08] joakino: ah, right (i think, let me test, but should, and if not, we need to implement it :P) [17:28:42] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1195062 (10KLans_WMF) 5Resolved>3Open [17:29:23] (03CR) 10Jdlrobson: [C: 032] Don't add empty title tags if no page title set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203099 (owner: 10Florianschmidtwelzow) [17:29:25] kaldari: Just re-reading the deployment page now. Want to have a hangout during ? [17:29:38] rmoen: sure [17:29:40] jdlrobson: https://phabricator.wikimedia.org/T95568 is on -1? should it be on codereview? [17:29:41] kaldari: cool [17:30:04] (03CR) 10Florianschmidtwelzow: [C: 04-1] "talked to joakino, there is an easier way." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [17:30:09] i need some coffee brb in 5 mins [17:30:42] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Commit "Pods" folder to git - https://phabricator.wikimedia.org/T94039#1195065 (10KLans_WMF) @bgerstle I think we can move this straight to done (no QA, Design, or PM signoff needed). [17:30:53] (03CR) 10Jdlrobson: Add support to deprecate a module (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [17:30:55] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Commit web "assets" folder to to git - https://phabricator.wikimedia.org/T94231#1195069 (10KLans_WMF) @bgerstle I think we can move this straight to done (no QA, Design, or PM signoff needed). [17:30:57] (03Merged) 10jenkins-bot: Fix missing period at the end of first sentence in some articles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202620 (https://phabricator.wikimedia.org/T95236) (owner: 10Dbrant) [17:30:59] (03Merged) 10jenkins-bot: Avoid fatals on Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203078 (https://phabricator.wikimedia.org/T95568) (owner: 10Jdlrobson) [17:32:13] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1195085 (10bearND) 3NEW [17:32:31] Is it a known issue - 4.1.1(76) crashes every time after switching *from* offline mode? [17:32:41] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1195095 (10bearND) a:3bearND [17:32:57] 10Wikipedia-iOS-App: 4.1.1(76) - clicking links in offline mode saved them in Recent - https://phabricator.wikimedia.org/T95585#1195098 (10Etonkovidova) 3NEW [17:33:13] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1195107 (10Deskana) How about tacking it on the end? 2.0-beta-2015-04-09-v100 [17:33:36] ASherman: okay i clicked the 'invite' button. [17:33:54] (03PS1) 10BearND: WIP: Change version number format to include versionCode as subminor number [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203156 (https://phabricator.wikimedia.org/T95584) [17:34:07] joakino: CollectionSearchPanel is used by CollectionEditOverlay [17:34:54] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1195117 (10KLans_WMF) @vbamba this card was accidentally closed. Still needs design signoff [17:36:33] 6Mobile-Web: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1195135 (10bmansurov) > remove the OOjs UI dependency The point of creating was to slowly start switching to oojs-ui. [17:37:30] (03CR) 10Jhernandez: "So, let's clarify the API:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [17:37:49] FlorianSW: ^ posted trying to clarify all the api use cases [17:38:00] jdlrobson: let me see again [17:38:28] dr0ptp4kt_cold: I got the email and it works! thank you so much for your help. [17:39:55] jdlrobson: woops so the CollectionSearchPanel is actually the panel with the list of items [17:39:57] coreyfloyd: dr0ptp4kt_cold ooooh Xcode update... [17:40:24] joakino: yeh you'll see when i push the fix :) [17:41:14] jdlrobson: oh yes, so CollectionPageList is the list of items, the CollectionSearchPanel wraps that up and will provide the search and manage the CollectionPageList [17:41:19] okk [17:42:20] 6Mobile-Web: Generating release notes automatically - https://phabricator.wikimedia.org/T95324#1195179 (10bmansurov) @JHernandez, great idea. The script already does what you're trying to do. You can change it to skip lines that match a certain string. Also, I don't see much value in outputting commit SHA in rel... [17:42:31] (03PS2) 10BearND: WIP: Change version number format to include versionCode as subminor number [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203156 (https://phabricator.wikimedia.org/T95584) [17:43:19] joakino: do you know a way to append additional arguments to $.proxy, instead of prepend them? :/ [17:43:42] mhurd: iOS 8.3 dropped the other day [17:44:48] coreyfloyd: updating... [17:44:51] mhurd: do you have access to hockey app website? [17:45:04] coreyfloyd: hmm i don't recall [17:45:13] hehe no? [17:45:33] FlorianSW: just do on line 48 deprecate: function(deprecatedId) { M.deprecate( deprecatedId, obj ) } :p [17:45:39] mhurd: ok will invite you [17:45:50] joakino: *facepalm* right :D [17:45:55] thanks :P [17:46:32] FlorianSW: if you were doing some functional programming you could do flip(this.deprecate).bind(this, obj) [17:46:43] which is fairly elegant imo :p [17:47:11] joakino: wouldn't this flip the correct call (deprecate(id, obj)), too? [17:47:38] FlorianSW: true dat, with the new signature no flipping [17:50:36] FlorianSW: then with functional programming just partialR(this.deprecate, obj) [17:50:43] using something like https://lodash.com/docs#partialRight [17:52:04] 10Wikipedia-Android-App: birth, death dates in bios are missing - https://phabricator.wikimedia.org/T95517#1195276 (10gpaumier) [17:52:18] (03PS8) 10Jdlrobson: Edit collection overlay allows you to manage existing members [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 (owner: 10Robmoen) [17:52:24] 10Wikipedia-Android-App: Highlighting text in search view makes text invisible - https://phabricator.wikimedia.org/T95591#1195279 (10bearND) 3NEW [17:52:24] joakino: boom [17:52:41] 10Wikipedia-Android-App: Highlighting text in search view makes search text invisible - https://phabricator.wikimedia.org/T95591#1195286 (10bearND) [17:52:57] (03PS3) 10Mholloway: Detect network connectivity and display appropriate error message to user [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) [17:53:09] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: GatherEditFeed throwing server errors - https://phabricator.wikimedia.org/T95568#1195288 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Back online = http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:GatherEditFeed [17:53:49] (03CR) 10Jdlrobson: Edit collection overlay allows you to manage existing members (0312 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 (owner: 10Robmoen) [17:55:27] (03PS6) 10Jdlrobson: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) [17:55:46] 3Gather Sprint Enwiki: Get Gather updated on English Wikipedia - https://phabricator.wikimedia.org/T95454#1195308 (10Jdlrobson) a:3rmoen [17:55:51] jdlrobson: headshot http://media.giphy.com/media/11duMLMvh7XW3C/giphy.gif [17:56:03] (03PS6) 10Jdlrobson: Add EventLogging to the watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) [17:56:14] (03PS2) 10Jdlrobson: Don't add empty title tags if no page title set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203099 (owner: 10Florianschmidtwelzow) [17:57:07] (03CR) 10jenkins-bot: [V: 04-1] Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) (owner: 10Jdlrobson) [17:57:08] 3Gather Sprint Enwiki: Get Gather updated on English Wikipedia - https://phabricator.wikimedia.org/T95454#1191030 (10Jdlrobson) If we have time we should also apply the fix for T93628 [17:57:32] (03PS4) 10Florianschmidtwelzow: Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 [17:57:43] joakino: ^ i used your api explanation :D [18:00:14] jdlrobson, joakino - i'm almost done with the prop=listmembership, please start testing. Unit tests will be added to the patch shortly [18:00:14] mhurd: you should have an invite [18:01:51] coreyfloyd: got it! [18:02:20] (03CR) 10Jhernandez: [C: 032] Edit collection overlay allows you to manage existing members [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 (owner: 10Robmoen) [18:03:24] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1195339 (10Jhernandez) Even though this is merged, I still want to talk about the consistency of the editing actions (live / deferred) [18:04:24] (03CR) 10jenkins-bot: [V: 04-1] Add EventLogging to the watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) (owner: 10Jdlrobson) [18:04:39] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Keyboard masks description textarea - https://phabricator.wikimedia.org/T94526#1195342 (10Jhernandez) @jdlrobson patch is merged, is this fixed then? [18:05:25] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1195344 (10Jhernandez) Moving to -1 because of the next patch : https://gerrit.wikimedia.org/r/#/c/202935/ [18:05:51] (03CR) 10jenkins-bot: [V: 04-1] Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [18:07:39] tfinc, do you know what happened with https://graphite.wikimedia.org/render?from=-6months&until=now&width=500&height=380&target=legendValue%28integral%28stats.mobile_opt_in_cookie_set.count%29%2C%22max%22%29&lineMode=connected&lineWidth=3&title=MobileBetaOptIns which used to track the mobile beta users? JonKatz is looking for up-to-date totals [18:08:10] bearND: hey! [18:10:34] 10Gather, 3Gather Sprint Enwiki: Prevent e-mail addresses being used in list titles/descriptions - https://phabricator.wikimedia.org/T95208#1183177 (10Jhernandez) I think this is why we integrated abuse filter, I've created T95593 as a more generic and future proof version of this. [18:11:37] Eloquence: i do not, does ops still own graphite ? [18:11:51] (03CR) 10Florianschmidtwelzow: [C: 04-1] "damn git add --all" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [18:12:30] (03PS5) 10Florianschmidtwelzow: Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 [18:14:39] coreyfloyd: i can see the alpha, store and beta now on hockeyapp on my phone, but the icons for store and beta are the dev icon not your new overlay... [18:16:21] (03PS1) 10Bmansurov: Alpha, Beta: Correctly align the edit icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203184 [18:17:14] phuedx: can we get mw-ui-icon work wrapped up? [18:17:49] i see lots of icon bug patches and i can't help but wonder if we were exclusively using mw-ui-icon these would go away [18:18:05] (03PS6) 10Jdlrobson: Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 [18:18:11] (03PS9) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) [18:18:17] jdlrobson: maybe -- i've been working on a higher priority thing, namely: https://gerrit.wikimedia.org/r/#/c/203095/ [18:18:44] mhurd: don't worry about that too much now. Try going to rink.hockeyapp.net [18:18:46] i see that you tackled a similar wikitext editor sizing issue a while ago [18:18:58] mhurd: and download the Mac app [18:18:59] ergg more ios bugs? [18:19:00] (03CR) 10jenkins-bot: [V: 04-1] Alpha, Beta: Correctly align the edit icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203184 (owner: 10Bmansurov) [18:19:16] be careful with that - you may find you'll break ios 6/7 in the process [18:19:20] im leaving! [18:19:25] \o joakino [18:19:25] coreyfloyd: ah. didn't know there was a mac app! was looking at the crashes via web interface [18:19:26] have a nice day people! [18:20:05] jdlrobson: feedback appreciated [18:20:08] joakino: later [18:20:19] collaboration welcomed [18:20:57] phuedx: i suspect the issue is the microAutoSize [18:21:05] in fact, i've got to pick up my mum and dad in about 30 minutes -- they've just got back from india -- so i'm hoping that one o' y'all can pick it up [18:21:09] jdlrobson: i'm positive it is [18:21:26] although, at the same time, microAutosize works as expected [18:21:40] (03Merged) 10jenkins-bot: Edit collection overlay allows you to manage existing members [extensions/Gather] - 10https://gerrit.wikimedia.org/r/201362 (owner: 10Robmoen) [18:21:45] it's just that the iphone doesn't see that an element which is larger than the page requires scrolling [18:21:53] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [18:21:57] git status [18:22:01] ^ professional [18:22:47] 10Gather: Inconsistencies in edit collection interface - https://phabricator.wikimedia.org/T95598#1195467 (10Jdlrobson) 3NEW [18:22:50] s/page/window [18:23:07] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1195476 (10Jdlrobson) I setup T95598 to discuss @jhernandez concerns. [18:25:32] (03CR) 10jenkins-bot: [V: 04-1] Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [18:25:56] mhurd: or here is a direct link: http://hockeyapp.net/releases/mac/ [18:25:57] (03CR) 10BearND: [C: 04-1] Detect network connectivity and display appropriate error message to user (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway) [18:26:02] (03PS2) 10Phuedx: Don't let the Wikitext editor over-expand [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203095 (https://phabricator.wikimedia.org/T95465) [18:26:19] coreyfloyd: already using it. pretty neat [18:26:50] mhurd: cool - do you see the crash report? [18:26:59] coreyfloyd: ya and found the assert too [18:27:20] line 149 of WMFImageInfoController.m [18:27:29] coreyfloyd: testing... [18:27:35] mhurd: coolio [18:27:44] coreyfloyd: pretty slick stuff [18:27:55] mhurd - the other apps / icons - we haven’t uploaded anything there yet [18:28:04] coreyfloyd: ah [18:30:55] (03PS1) 10Jdlrobson: Tools: Don't force tests to validate to JSDoc rules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203190 [18:34:56] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203184 (owner: 10Bmansurov) [18:35:21] 10Gather: Order collections on creation overlay by last edited - https://phabricator.wikimedia.org/T95600#1195521 (10JKatzWMF) 3NEW [18:35:29] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: more pagination issues: I can't add to my favourite collections - https://phabricator.wikimedia.org/T94523#1195529 (10JKatzWMF) @jdlrobson I don't see the order changing, but it's a good suggestion. Created another ticket for it. [18:35:38] coreyfloyd: looks like the assert is related to this: https://github.com/montehurd/apps-ios-wikipedia/commit/0458a5d6efacf4c836e6a2b36033269dbb8cc7de [18:35:41] jdlrobson: gonna take a look at the icon stuff now [18:35:52] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: more pagination issues: I can't add to my favourite collections - https://phabricator.wikimedia.org/T94523#1195531 (10JKatzWMF) 5Open>3Resolved [18:36:26] jdlrobson, kaldari It seems we cannot use the events map in View on OO-UI elements because they are anti-pattern to our view -> templates event binding / the elements do not exist at the time of construction of the view. Thoughts on this? Perhaps this is a good example/reason not to introduce widgets in MF? [18:36:59] rmoen: https://phabricator.wikimedia.org/T95490 [18:37:21] Right, I'm noting that in my change [18:38:48] etonkovidova: do you know if there's aleady a phab ticket for that image gallery crash? [18:39:03] mhurd: which file line? [18:39:19] coreyfloyd: line 149 of WMFImageInfoController.m [18:39:29] mhurd: I did no file any tickets for crashes [18:39:41] etonkovidova: no worry i'll make one [18:39:50] mhurd: ok - thx1 [18:39:56] 6Mobile-Web: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1195538 (10Jdlrobson) @bmansurov I think this totally the wrong way to do it. It makes it really difficult for us to move things to stable and it doesn't actually progress us in an way - we cannot load all our View code... [18:40:34] coreyfloyd: think i'll create a ticket and tag brian so he can sort it out tomorrow. sound ok? [18:40:53] rmoen, jdlrobson: I think the long-term solution would be to have OOjs UI somehow integrate with views and templates, but I think this would require some architectural changes on the OOjs UI side. The main problem is that OOjs UI just doesn’t have any concept of ‘view’. The HTML is integral to the widget and you can’t turn a DOM element into a widget (unlike jQuery UI) [18:41:00] mhurd: ok it like looks like we need to return the wnfrangenakenotfound in that instance [18:41:13] kaldari: agreed [18:41:35] mhurd: naaa let's fix it. We can't let Brian be the bottle neck on image gallery work [18:41:52] coreyfloyd: cool. i'll try your suggestion [18:42:08] kaldari: i beg to differ, let me find a patch where they were working on it [18:42:26] (03PS7) 10Jdlrobson: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) [18:42:44] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1072316 (10Jdlrobson) https://gerrit.wikimedia.org/r/#/c/202935/ handles the rest [18:42:56] bmansurov: that would be awesome if it’s possible. I tried asking Trevor about it, but he never responds to my questions. [18:43:09] (03PS4) 10Jdlrobson: Point at hamburger icon when a collection has been setup. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) [18:43:37] kaldari: i remember seeing a patch where we can even create widgets in php on page load and control them with javascript [18:44:09] mhurd: in this case I would remove the assert as well, and line 159 will handle our new range. [18:44:12] coreyfloyd: that seems to fix it [18:44:25] mhurd: woohoo! [18:44:45] kaldari, jdlrobson is there a phab task for introducing oo-ui widgets in MF besides https://phabricator.wikimedia.org/T95490 [18:44:59] not that I know of [18:45:03] kaldari: https://www.mediawiki.org/wiki/OOjs_UI/PHP_Examples [18:45:26] mhurd: if we can get it reviewed we can cut a new build and Adam won't need to cut a special build for vibha [18:45:29] 6Mobile-Web: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1195549 (10rmoen) The problem with introducing OO-UI widgets into MF code is that it is a complete anti-pattern to the existing framework. MF's strongest pattern is the view/template/events map. Constructing widgets... [18:45:36] kaldari: so we can turn a DOM element into a view, but it has to be constructed in a specific way [18:46:06] coreyfloyd: cool will submit shortly [18:46:38] bmansurov: Hmm, interesting. [18:46:52] bmansurov: Yeah, looks like it just has to be “infusable” [18:47:29] FlorianSW: you there :) [18:47:37] (03CR) 10Robmoen: Use button with spinner for create collection button (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202923 (owner: 10Robmoen) [18:47:52] (03PS2) 10Jdlrobson: Do not show title at top of Gather pages. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203100 (owner: 10Florianschmidtwelzow) [18:48:09] (03PS7) 10Robmoen: Use button with spinner for create collection button [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202923 [18:48:29] 10Gather, 3Gather Sprint Enwiki, 7Design, 7I18n, 5Patch-For-Review: Reconsider the usage of "feed" in Gather's UI - https://phabricator.wikimedia.org/T95548#1195552 (10JKatzWMF) @jdlrobson hey, where can I see this in the UX? [18:48:41] (03CR) 10Jdlrobson: [C: 032] "Florian you are my hero :D" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203100 (owner: 10Florianschmidtwelzow) [18:48:51] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1195554 (10Jdlrobson) [18:49:25] (03Abandoned) 10Jdlrobson: WIP: Do not show title at top of Gather pages. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202635 (owner: 10Jdlrobson) [18:49:35] (03Abandoned) 10Jdlrobson: Allow special pages to suppress the default header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202636 (owner: 10Jdlrobson) [18:50:23] 10Gather, 3Gather Sprint Enwiki, 7Design, 7I18n, 5Patch-For-Review: Reconsider the usage of "feed" in Gather's UI - https://phabricator.wikimedia.org/T95548#1195555 (10Jdlrobson) http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:GatherEditFeed [18:50:51] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1195559 (10Jdlrobson) @Florian has made this possible :D [18:51:59] (03CR) 10jenkins-bot: [V: 04-1] Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) (owner: 10Jdlrobson) [18:52:23] jdlrobson: yep, but maybe i'll need some time to answer you :) [18:54:10] rmoen: So do we have a plan for this deployment today? I don’t see anything on the deployment schedule yet. [18:54:28] (03PS3) 10Jdlrobson: Add a tag showing privacy status [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202287 (https://phabricator.wikimedia.org/T93828) [18:54:37] (03PS1) 10Mhurd: Fix for image info pagination crash. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203197 [18:54:45] I can add it to the schedule. 4pm is the general plan [18:54:51] kaldari ^ [18:55:24] jdlrobson: is there anything that needs to go out that isn't merged yet ? [18:55:39] coreyfloyd: https://gerrit.wikimedia.org/r/203197 [18:56:01] rmoen: merge whatever you can - the more we can push out the better :) [18:56:42] (03CR) 10Fjalapeno: [C: 031] "Neato Burrito!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203197 (owner: 10Mhurd) [18:57:00] jdlrobson, kaldari so we will wait to make the extension update until more things are merged [18:57:06] (03CR) 10Jdlrobson: [C: 032] Use button with spinner for create collection button [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202923 (owner: 10Robmoen) [18:57:07] coreyfloyd: mhurd heads up, looks like there may be a slight delay on the actual store release. product and comms working out the message. it shouldn't be more than a day or two extra from what i gather. [18:57:08] mhurd: BTW was this happening on you at every load of the image gallery [18:57:46] jdlrobson: going through the code review column [18:58:08] * coreyfloyd grumbles… [18:58:26] (03PS8) 10Jdlrobson: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) [18:58:30] dr0ptp4kt_cold: not cool [18:58:39] greg-g: Hey greg, there used to be a dedicated deployment window for mobile every week, but this seems to have disappeared. Know anything about that? Would you oppose recreating it? [18:58:44] (03PS6) 10BearND: WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) [18:58:50] dr0ptp4kt_cold: can you look at mhurd patch set so we can cut a new build for vibha? [18:58:55] 3Gather Sprint Enwiki: Spike: How can we stop Gather depending on MobileFrontend - https://phabricator.wikimedia.org/T94100#1195580 (10Jdlrobson) a:3Jdlrobson [18:59:26] kaldari: no opposition (especially given current email thread), probably accidental (stupid copy/paste processes) [19:00:49] (03Merged) 10jenkins-bot: Do not show title at top of Gather pages. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203100 (owner: 10Florianschmidtwelzow) [19:01:16] coreyfloyd: yeah, will do. one moment, on it [19:01:26] vibha: mhurd ^ gonna look at a patch [19:02:13] mholloway: food? [19:02:26] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 4 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1195594 (10DarTar) @dr0ptp4kt, @deskana: are there related plans for appending an oldid parameter and reviewing the cach... [19:03:30] gonna go pick up my parents [19:03:32] (03Merged) 10jenkins-bot: Use button with spinner for create collection button [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202923 (owner: 10Robmoen) [19:04:04] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 4 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1195610 (10Deskana) >>! In T90606#1195594, @DarTar wrote: > @dr0ptp4kt, @deskana: are there related plans for appending... [19:04:06] 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: More design tweaks to collections content overlay - https://phabricator.wikimedia.org/T93424#1195611 (10Jdlrobson) 5Open>3Resolved [19:04:12] greg-g: OK, I’ll just add it back then. Feel free to tweak if needed. [19:05:07] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) (owner: 10Jdlrobson) [19:05:56] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 4 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1195618 (10DarTar) @Deskana got it, I'd like to run past you some ideas about the backlink that I discussed with Moiz an... [19:07:02] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Analytics, 6Scrum-of-Scrums, and 4 others: Avoid cache fragmenting URLs for Share a Fact shares - https://phabricator.wikimedia.org/T90606#1195619 (10Deskana) @DarTar That sounds great. Putting it in an email or a Phab task would be ideal, as I'm really overl... [19:08:39] mhurd: so do you like the hockey stuff? [19:11:24] (03CR) 10Dr0ptp4kt: [C: 032] Fix for image info pagination crash. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203197 (owner: 10Mhurd) [19:11:39] ^ coreyfloyd, done [19:12:37] dr0ptp4kt_cold: thanks - vibha kicking off a new build - should have it like 15 minutes [19:12:49] Deskana: whenever it works for you, I jotted down some ideas on my whiteboard, let’s chat with Moiz some time next week? [19:13:44] coreyfloyd: i noticed in the alpha scheme in the simulator i'm getting a prompt from hockey to upgrade the app. is that happening to you, too? mhurd ? [19:14:06] dr0ptp4kt_cold: yeah - that should happen - you should use the “Wikipedia” scheme for local development [19:14:42] coreyfloyd: ok, so test flight users aren't going to start being prompted on their test flight installations via the alpha channel [19:14:43] dr0ptp4kt_cold: the alpha and release schemes should be used to to a local archive or if you need to do development on deployment scripts (or things like the icon badging) [19:14:57] dr0ptp4kt_cold: good question! [19:15:49] coreyfloyd: it didn't happen to me on the 75/74 build or whatever it was, and naturally it's not prompting me n the 76 build that i just installed via testflight [19:15:55] (alpha) [19:16:00] dr0ptp4kt_cold: let me look - the should not be prompted (i know we went through this the other week) but if you see it than maybe they will [19:16:13] DarTar: Sure. Thanks. [19:16:15] bmansurov: salom [19:16:19] any news about Moses? [19:16:29] (03PS3) 10Dr0ptp4kt: Fix for some images causing entire section to scroll horizontally. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202977 (owner: 10Mhurd) [19:20:16] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Disable hockey update checking - https://phabricator.wikimedia.org/T95602#1195648 (10Fjalapeno) 3NEW a:3Fjalapeno [19:21:02] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1195658 (10dr0ptp4kt) For me the horizontal scrolling only surfaces when I actually horizontal scroll the tables first. But no matter, I'm testing t... [19:21:11] dr0ptp4kt_cold: i have a feeling it prompts just the devs, but disabling it in the app code explicitly. ^ [19:22:09] aharoni: salom, sorry, haven't had a chance to work on it, have been busy with MF stuff [19:22:39] aharoni: will try to find some time this friday [19:22:45] thanks [19:23:00] aharoni: but i don't want to promise anything; you've seen what happened to my last promise [19:23:05] np :) [19:23:10] cool [19:23:57] (03PS1) 10Fjalapeno: Disabling update prompts. Task T95602 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203207 [19:24:02] dr0ptp4kt_cold: mhurd ^ [19:28:56] dr0ptp4kt_cold: coreyfloyd sry finishing up lunch [19:35:52] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather incorrectly pulls down editor api - https://phabricator.wikimedia.org/T95327#1195705 (10JKatzWMF) @jdlrobson, I can't sign off on this per our agreed upon process (moving forward, if you have resolved a technical one, can I just sign off?) [19:37:55] mhurd coreyfloyd nice job on the image gallery crash fix and unblocking that piece of our sprint flow :-) [19:38:03] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Keyboard masks description textarea - https://phabricator.wikimedia.org/T94526#1195714 (10Jdlrobson) 5Open>3Resolved [19:39:57] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: long collection names create horizontal scrolling on creation overlay - https://phabricator.wikimedia.org/T95209#1195716 (10JKatzWMF) 5Open>3Resolved [19:41:17] (03CR) 10Dr0ptp4kt: [C: 032] "+2'ing. Note for potential follow on patch inline." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202977 (owner: 10Mhurd) [19:42:36] 3Gather Sprint Enwiki, 5Patch-For-Review: Add to collection tutorial should not show on main page - https://phabricator.wikimedia.org/T95355#1195720 (10JKatzWMF) 5Open>3Resolved [19:44:33] 10Gather, 3Gather Sprint Enwiki, 7Design, 7I18n, 5Patch-For-Review: Reconsider the usage of "feed" in Gather's UI - https://phabricator.wikimedia.org/T95548#1195724 (10JKatzWMF) @jdlrobson, you are a god among men. [19:45:24] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design: Add 'new' icon to collections in main menu - https://phabricator.wikimedia.org/T95245#1195728 (10Jdlrobson) a:3Jdlrobson [19:45:27] rmoen: any luck with api stuff? [19:45:47] jdlrobson: not yet, just about to grab some lunch [19:46:05] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fancy string generation on collection tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202606 (owner: 10Robmoen) [19:46:49] jdlrobson: been obsessing over the deployment. Will take a look when I get back [19:47:14] (03PS7) 10BearND: WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) [19:50:09] 10Gather, 3Gather Sprint Enwiki: Edit validation blocks changes but does not inform user - https://phabricator.wikimedia.org/T95607#1195737 (10JKatzWMF) 3NEW [19:50:34] (03Merged) 10jenkins-bot: Hygiene: Fancy string generation on collection tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202606 (owner: 10Robmoen) [19:51:33] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Assorted string replacements - https://phabricator.wikimedia.org/T93817#1146816 (10JKatzWMF) [19:51:34] 10Gather, 3Gather Sprint Enwiki: Edit validation blocks changes but does not inform user - https://phabricator.wikimedia.org/T95607#1195750 (10JKatzWMF) [19:52:08] (03PS2) 10Dr0ptp4kt: Disabling update prompts. Task T95602 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203207 (owner: 10Fjalapeno) [19:52:49] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Assorted string replacements - https://phabricator.wikimedia.org/T93817#1195754 (10JKatzWMF) blocked on T95607 which means edit validation notifications no longer show. otherwise ready for signoff. [19:54:44] kristenlans: np! [19:55:53] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather should explain to users why they're required to log in if they go to Special:Gather or Special:GatherLists - https://phabricator.wikimedia.org/T94971#1195769 (10JKatzWMF) I don't see any messaging when I go to: http://en.m.wikipedia.beta.wmflabs.org/... [19:57:49] 3Gather Sprint Enwiki, 5Patch-For-Review: Collection watchstar has outline - https://phabricator.wikimedia.org/T95357#1195771 (10JKatzWMF) 5Open>3Resolved can't replicate [19:58:18] (03CR) 10Dr0ptp4kt: [C: 032] Disabling update prompts. Task T95602 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203207 (owner: 10Fjalapeno) [19:58:28] (03CR) 10Dr0ptp4kt: [V: 032] Disabling update prompts. Task T95602 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203207 (owner: 10Fjalapeno) [19:59:00] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather should explain to users why they're required to log in if they go to Special:Gather or Special:GatherLists - https://phabricator.wikimedia.org/T94971#1195785 (10JKatzWMF) 5Resolved>3Open see ^ (maybe I'm missing something) [20:00:23] 10Wikipedia-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice, 7user-notice: Production release for iOS Wikipedia app on Monday 13th April 2015 - https://phabricator.wikimedia.org/T86692#1195791 (10gpaumier) I'm going to wait until next week to announce this in Tech News since I'd prefer to be able... [20:01:28] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Watchstar doesn't reflect real status - https://phabricator.wikimedia.org/T94508#1195798 (10JKatzWMF) 5Open>3Resolved can't replicate [20:02:10] (03PS3) 10Yurik: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) [20:02:20] jdlrobson, finished ^ [20:05:46] 10Wikipedia-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice, 7user-notice: Production release for iOS Wikipedia app on Monday 13th April 2015 - https://phabricator.wikimedia.org/T86692#1195819 (10Deskana) The release date is being pushed back two days so Communications has a little bit more time... [20:05:57] 10Wikipedia-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice, 7user-notice: Production release for iOS Wikipedia app on Wednesday 15th April 2015 - https://phabricator.wikimedia.org/T86692#1195821 (10Deskana) [20:06:42] (03PS4) 10Mholloway: Detect network connectivity and display appropriate error message to user; refactor networking-related utility functions out of Util.java and into new NetworkUtils class. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) [20:12:04] (03PS4) 10Yurik: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) [20:13:33] (03PS9) 10Robmoen: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) (owner: 10Jdlrobson) [20:20:24] (03CR) 10Robmoen: [C: 032] Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) (owner: 10Jdlrobson) [20:21:20] (03PS4) 10Robmoen: Add a tag showing privacy status [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202287 (https://phabricator.wikimedia.org/T93828) (owner: 10Jdlrobson) [20:21:45] rmoen, are you implementing search addition? [20:22:35] yurik: it has been implemented https://gerrit.wikimedia.org/r/202935 [20:22:53] rmoen, could you +2 https://gerrit.wikimedia.org/r/#/c/203003/ [20:23:09] rmoen, this way you can show which pages are in a list [20:23:11] coreyfloyd: so can i just download new alpha from testflight? [20:23:25] yurik: I saw that but haven't read through it yet [20:24:29] yurik: do we have anything that uses it yet ? I'm hesitant to merge is as we are deploying today at 4pm. So if it is not urgent, I'd rather wait [20:24:55] deploying master* [20:25:44] (03Merged) 10jenkins-bot: Add ability to remove/add new members to a collection via search [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202935 (https://phabricator.wikimedia.org/T90991) (owner: 10Jdlrobson) [20:25:55] vibha: yep [20:27:54] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather should explain to users why they're required to log in if they go to Special:Gather or Special:GatherLists - https://phabricator.wikimedia.org/T94971#1195887 (10Florian) Arghhh, our own login page... I'll take a look, sorry. [20:28:38] rmoen, not urgent, jdlrobson was asking for this feature in order to show which pages already in a list [20:29:24] yurik: yes i know it is desired, but if nothing is consuming it, I'd rather let it simmer for a while to let it get proper feedback [20:29:35] (03PS5) 10Jdlrobson: Point at hamburger icon when a collection has been setup. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) [20:29:37] (03PS1) 10Jdlrobson: Hygiene: Correctly identify the RL module name for plus icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203214 [20:29:39] (03PS1) 10Jdlrobson: When a user clicks on hamburger after adding to a collection show new icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203215 (https://phabricator.wikimedia.org/T95245) [20:29:54] rmoen, obviously nothing ueses it - it didn't exist, you can't use it until its written :)))) [20:30:12] its a justification [20:30:33] 10Gather, 3Gather Sprint Enwiki, 6Mobile-Web, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2, 5Patch-For-Review: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1195893 (10Jdlrobson) [20:31:38] 10Gather, 3Gather Sprint Enwiki, 6Mobile-Web, 5Patch-For-Review: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1163497 (10Jdlrobson) [20:32:27] 10Gather, 3Gather Sprint Enwiki, 6Mobile-Web, 5Patch-For-Review: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1163497 (10Jdlrobson) Pinging @kaldari @phuedx @bmansurov for help getting this reviewed [20:32:48] (03CR) 10Jdlrobson: [C: 031] Don't add empty title tags if no page title set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203099 (owner: 10Florianschmidtwelzow) [20:32:52] (03CR) 10Jdlrobson: [C: 032] Don't add empty title tags if no page title set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203099 (owner: 10Florianschmidtwelzow) [20:33:28] (03PS1) 10Bmansurov: Make sure the upload button cursor is a pointer in firefox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203218 [20:35:08] (03PS1) 10Kaldari: Moving CSS for .oo-ui-indicator-spinner from iconsNew to icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203219 [20:36:06] (03Merged) 10jenkins-bot: Don't add empty title tags if no page title set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203099 (owner: 10Florianschmidtwelzow) [20:36:18] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1195905 (10rmoen) @Msyed @Jdlrobson Isn't the title of the collection more important? Seems like tags could easily go... [20:36:29] (03PS8) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [20:36:59] (03CR) 10jenkins-bot: [V: 04-1] Make sure the upload button cursor is a pointer in firefox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203218 (owner: 10Bmansurov) [20:38:32] mhurd: dr0ptp4kt_cold popping out for an hour - need anything before i go? [20:38:55] coreyfloyd: i'm good! [20:39:09] (03PS1) 10Florianschmidtwelzow: Add description of Gather for Special:UserLogin [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203220 (https://phabricator.wikimedia.org/T94971) [20:39:39] (03CR) 10jenkins-bot: [V: 04-1] Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [20:40:14] (03PS1) 10Florianschmidtwelzow: Add Special:Gather messages on Special:UserLogin/Special:CreateAccount [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203221 (https://phabricator.wikimedia.org/T94971) [20:40:24] (03CR) 10jenkins-bot: [V: 04-1] Moving CSS for .oo-ui-indicator-spinner from iconsNew to icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203219 (owner: 10Kaldari) [20:40:44] (03PS2) 10Florianschmidtwelzow: Add Special:Gather messages on Special:UserLogin/Special:CreateAccount [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203221 (https://phabricator.wikimedia.org/T94971) [20:41:03] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203219 (owner: 10Kaldari) [20:42:25] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [20:44:07] 3Gather Sprint Enwiki: EventLogging broken on GatherClicks - https://phabricator.wikimedia.org/T95615#1195929 (10Jdlrobson) 3NEW a:3Jdlrobson [20:45:11] (03CR) 10Bmansurov: "There is a watchstar in QuickLookupDrawer.js to which you should add a 'funnel'." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) (owner: 10Jdlrobson) [20:45:41] (03PS9) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [20:46:31] (03CR) 10Robmoen: "I left comments on the phab page for this, perhaps a little too late to complain? Basically, I don't agree with the design on this. Is " [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202287 (https://phabricator.wikimedia.org/T93828) (owner: 10Jdlrobson) [20:48:17] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1195946 (10Jdlrobson) @rmoen design can be iterated on. I think showing that a person's list has been hidden or is priva... [20:48:24] bearND: hey do you have a minute? [20:48:46] mhurd: hey, what's up? [20:48:57] bearND: batcave? [20:49:16] 3Gather Sprint Enwiki: EventLogging broken on GatherClicks - https://phabricator.wikimedia.org/T95615#1195929 (10Jdlrobson) [20:49:36] 10Gather, 3Gather Sprint Enwiki, 3Mobile Web Design, 5Patch-For-Review: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1195959 (10rmoen) @Jdlrobson I agree it is important to have this indicator. I'm fine with making it look better later. [20:50:14] (03PS1) 10Jdlrobson: Fix schema for GatherClicks [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203224 (https://phabricator.wikimedia.org/T95615) [20:50:55] bearND: https://github.com/montehurd/apps-ios-wikipedia/commit/7bb1f3b555d91b2d9f9e823c5bf0e3b8c1c3f698 [20:51:57] (03CR) 10Bmansurov: [C: 032] Moving CSS for .oo-ui-indicator-spinner from iconsNew to icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203219 (owner: 10Kaldari) [20:52:33] (03CR) 10Robmoen: [C: 032] "Not a blocker. I'm fine with iterating on this design." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202287 (https://phabricator.wikimedia.org/T93828) (owner: 10Jdlrobson) [20:55:20] jdlrobson: testing https://gerrit.wikimedia.org/r/#/c/203224/ [20:55:41] sweet [20:56:13] (03Merged) 10jenkins-bot: Moving CSS for .oo-ui-indicator-spinner from iconsNew to icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203219 (owner: 10Kaldari) [20:57:10] jdlrobson: https://gerrit.wikimedia.org/r/#/c/201862/ [20:57:12] bmansurov: nooooo [20:57:43] jdlrobson: what did I do this time? [20:58:34] coreyfloyd: bgerstle_afk Deskana sent you guys the laternate mocks that were reviewed yesterday during design review along with the rationale [20:58:36] (03CR) 10Bmansurov: [C: 031] Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [20:58:44] (03Merged) 10jenkins-bot: Add a tag showing privacy status [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202287 (https://phabricator.wikimedia.org/T93828) (owner: 10Jdlrobson) [20:58:46] please send comments, I am available to chat after 4 pm PST [21:00:46] (03CR) 10Robmoen: Fix schema for GatherClicks (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203224 (https://phabricator.wikimedia.org/T95615) (owner: 10Jdlrobson) [21:00:47] vibha any chance that you coudl send those mocks to mobile-tech [app] so everyone is in the loop for tomorrow's estimation meeting? [21:01:42] sure [21:03:13] (03CR) 10Jdlrobson: [C: 04-1] "Please can you take a look at how this impacts a page load. As I've said numerous times we really cannot load oojs ui and all our View cod" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [21:03:15] (03PS2) 10Robmoen: Fix schema for GatherClicks [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203224 (https://phabricator.wikimedia.org/T95615) (owner: 10Jdlrobson) [21:03:25] (03CR) 10Jdlrobson: "I will do a follow up..." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203219 (owner: 10Kaldari) [21:03:27] (03PS3) 10Robmoen: Fix schema for GatherClicks [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203224 (https://phabricator.wikimedia.org/T95615) (owner: 10Jdlrobson) [21:03:28] kristenlans: can you link to the sprint 55 board please? [21:03:49] (03CR) 10Robmoen: [C: 032] Fix schema for GatherClicks [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203224 (https://phabricator.wikimedia.org/T95615) (owner: 10Jdlrobson) [21:05:07] vibha: https://phabricator.wikimedia.org/project/view/1164/ and https://phabricator.wikimedia.org/tag/mobile-app-sprint-55-android/ [21:05:31] kristenlans: thank you thank you [21:07:03] (03Merged) 10jenkins-bot: Fix schema for GatherClicks [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203224 (https://phabricator.wikimedia.org/T95615) (owner: 10Jdlrobson) [21:07:39] mhurd: dr0ptp4kt_cold Are we going to get the default references treatment that is now in the mobile web view https://en.m.wikipedia.org/wiki/Ulysses_S._Grant#References [21:08:25] 6Mobile-Web, 10MobileFrontend: Promote mw-ui-icon to stable - https://phabricator.wikimedia.org/T95619#1196030 (10Jdlrobson) 3NEW [21:08:46] (03PS10) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [21:08:47] (03PS1) 10Jdlrobson: Hygiene: Move buttonWithSpinner css to more natural place [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203227 [21:09:24] vibha: it looks like it. did you try bringing that article up on the app [21:10:19] jdlrobson: what was the problem? [21:12:14] mhurd: they look slightly different - we have a carrot/chevron like character in a superscript to the left of every reference which mobile web doesn't have [21:12:28] i do see the leading change in the most recent alpha [21:12:47] (03CR) 10Bmansurov: Moving CSS for .oo-ui-indicator-spinner from iconsNew to icons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203219 (owner: 10Kaldari) [21:12:52] vibha: it should change in the app as soon as that change moves from alpha to stable [21:13:34] jdlrobson: would you be able to line up my access for https://wikitech.wikimedia.org/wiki/EventLogging/Testing/BetaLabs ? yuvi's away from his comp and said you may be able to help [21:15:51] kaldari: want to talk about deployment really quick ? hangout? [21:20:51] 10Gather, 3Gather Sprint Enwiki: API: Unexpected results - https://phabricator.wikimedia.org/T94600#1196081 (10Yurik) Hi, could someone write a unit test (or modify testListEditAndPages) to demo this bug? I will try to look at it soonish [21:23:30] dr0ptp4kt_cold: coreyfloyd hmmm look like styles.css got messed up in https://github.com/montehurd/apps-ios-wikipedia/commit/7bb1f3b555d91b2d9f9e823c5bf0e3b8c1c3f698#diff-9ec12d171cdd9fbf1fc1344723cdaa57 [21:23:54] dr0ptp4kt_cold: coreyfloyd noticed in obama article - the pronunciation keys are white [21:24:17] mhurd: ha. you on it? [21:24:20] dr0ptp4kt_cold: coreyfloyd the diff i linked to above looks fishy [21:24:50] dr0ptp4kt_cold: ya. i think the "make web" command may be doing something wonky when it requests the css [21:26:30] bmansurov: you got access to the server on https://wikitech.wikimedia.org/wiki/EventLogging/Testing/BetaLabs for verifying events are coming through? i'm able to make the client fire events just fine (intercepting proxy to modify js sampling ratio value to always be true, not sure what your technique of choice is) [21:27:15] dr0ptp4kt_cold: i think I do have access to the server, haven't tested it client-side though. [21:27:28] dr0ptp4kt_cold: agree, we should have built an override query parameter [21:28:05] bmansurov: lol, closures! [21:28:40] dr0ptp4kt_cold: do you want me to check the db? [21:28:53] bmansurov: yeah, if you could. [21:29:00] ok [21:30:05] bmansurov: you will probably see me searching 'a', 'ab'...and clicking through [21:30:13] bmansurov: at least that's what my intercepting proxy says [21:30:57] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1196108 (10Etonkovidova) The charts in 'Tel Aviv'(Hebrew) article do not require horizontal scroll. The 'Goatfish' article - Timeline chart does n... [21:31:39] dr0ptp4kt_cold: I don't see the Search_11670541 table [21:32:12] dr0ptp4kt_cold: maybe it takes time, maybe the data is not going through [21:32:27] dr0ptp4kt_cold: afaik, the table will be create when data comes in [21:33:38] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1196111 (10Etonkovidova) 5Open>3Resolved [21:37:21] dr0ptp4kt_cold: btw, I don't think the search terms are being recorded [21:37:34] dr0ptp4kt_cold: i think i found the issue [21:38:36] bearND: hey there's a slight problem with that image div wrapping i did - it's causing tiny icons (like the IPA speaker icon) to wrap to next line [21:38:39] bearND: fixing [21:39:03] mhurd: ok, thanks for the heads-up [21:41:45] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203218 (owner: 10Bmansurov) [21:45:03] (03CR) 10Bmansurov: [C: 032] Hygiene: Move buttonWithSpinner css to more natural place [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203227 (owner: 10Jdlrobson) [21:46:15] (03CR) 10Bmansurov: [C: 04-1] Add EventLogging to the watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) (owner: 10Jdlrobson) [21:47:37] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: 4.0.7.10 articles in Recent do not display thumbnail images - https://phabricator.wikimedia.org/T95114#1196141 (10Etonkovidova) Checked on iPad 2 mini(iOS 8.2) with 4.1.1(76). At least, the previously known cases of missing thumbnail imgs have been checked. As... [21:48:09] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: 4.0.7.10 articles in Recent do not display thumbnail images - https://phabricator.wikimedia.org/T95114#1196142 (10Etonkovidova) 5Open>3Resolved [21:49:32] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move buttonWithSpinner css to more natural place [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203227 (owner: 10Jdlrobson) [21:50:40] (03PS5) 10Jdlrobson: WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T95227) [21:50:42] (03PS1) 10Jdlrobson: Reflect some upstream changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203229 [21:50:44] (03PS1) 10Jdlrobson: WIP: Make collection editor work in desktop [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203230 (https://phabricator.wikimedia.org/T94063) [21:50:46] (03CR) 10jenkins-bot: [V: 04-1] WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T95227) (owner: 10Jdlrobson) [21:50:48] (03CR) 10jenkins-bot: [V: 04-1] Reflect some upstream changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203229 (owner: 10Jdlrobson) [21:50:50] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make collection editor work in desktop [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203230 (https://phabricator.wikimedia.org/T94063) (owner: 10Jdlrobson) [21:53:05] 10Wikipedia-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice, 7user-notice: Production release for iOS Wikipedia app on Wednesday 15th April 2015 - https://phabricator.wikimedia.org/T86692#1196157 (10gpaumier) >>! In T86692#1195819, @Deskana wrote: > The release date is being pushed back two days... [21:58:53] bmansurov: the search terms themselves of course shouldn't be logging [21:58:59] bmansurov: but... [21:59:00] 6Mobile-Web: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1196178 (10Ragesoss) 3NEW [21:59:47] bmansurov: if you do the following on deployment-eventlogging02.eqiad.wmflabs [22:00:10] tail -f | grep impression [22:00:33] bmansurov: in that case i think events ought to show up. of course i'm going to need to be firing evens live. [22:00:41] mhurd: good to hear you caught it! [22:00:45] bmansurov: able to get on video? [22:01:12] dr0ptp4kt_cold: yes sure [22:01:23] bmansurov: okay, i'll hop on video shortly [22:01:28] ok [22:02:29] bmansurov: you on chat? [22:02:35] logging in [22:02:35] for hangouts? [22:02:39] bmansurov: cool [22:06:37] 6Mobile-Web: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1196202 (10Ragesoss) 3NEW [22:07:19] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: 4.0.6.3 Image Gallery - some images displayed in low resolution - https://phabricator.wikimedia.org/T91124#1196209 (10Etonkovidova) Re-checked the previous cases - look fine. [22:08:17] 10Gather: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1196215 (10Moushira) [22:10:40] 10Gather: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1196226 (10Ragesoss) Okay, so now I see that the little modal is scrollable, but not big enough to show very much of the Gather interface at once. When I scroll the Gather modal, it also scrolls the content underneath... [22:20:23] 10Gather: Private collection is disabled? - https://phabricator.wikimedia.org/T95630#1196257 (10Moushira) 3NEW [22:25:49] (03PS6) 10Jdlrobson: WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T95227) [22:25:51] (03PS2) 10Jdlrobson: Reflect some upstream changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203229 [22:26:57] 10Gather, 3Gather Sprint Enwiki, 3Mobile-Web-Design: Desktop beta feature for Gather needs illustration - https://phabricator.wikimedia.org/T95632#1196281 (10Jdlrobson) 3NEW a:3Jdlrobson [22:27:52] (03CR) 10Jdlrobson: [C: 04-1] Add description of Gather for Special:UserLogin (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203220 (https://phabricator.wikimedia.org/T94971) (owner: 10Florianschmidtwelzow) [22:28:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T95227) (owner: 10Jdlrobson) [22:29:25] (03PS7) 10Jdlrobson: WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T95227) [22:31:39] 10Gather: Gather "+" icon doesn't show up in mobile menu except on Special:Gather - https://phabricator.wikimedia.org/T95634#1196305 (10Ragesoss) 3NEW [22:32:05] (03CR) 10jenkins-bot: [V: 04-1] WIP: Gather as desktop beta feature [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T95227) (owner: 10Jdlrobson) [22:32:11] 10Gather, 3Gather Sprint F, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1196312 (10Jdlrobson) [22:32:43] mhurd: did you find the issue? [22:32:49] 10Gather, 3Gather Sprint F, 10MediaWiki-Database, 7database: DB gather_list.gl_id autonumber is always odd - https://phabricator.wikimedia.org/T94512#1196314 (10Jdlrobson) [22:32:55] 10Gather, 3Gather Sprint F: On edit collection overlay, the box is labeled "public" instead of private - https://phabricator.wikimedia.org/T93391#1196315 (10Jdlrobson) [22:33:06] coreyfloyd: ya fixing now [22:33:11] mhurd: cool [22:33:12] 10Gather, 3Gather Sprint F: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1196318 (10Jdlrobson) [22:33:31] 10Gather, 3Gather Sprint F: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1133825 (10Jdlrobson) [22:33:41] 10Gather, 3Gather Sprint F: new collection entry design tweak - https://phabricator.wikimedia.org/T93651#1196320 (10Jdlrobson) [22:33:47] 10Gather, 3Gather Sprint F: new collection entry design tweak - https://phabricator.wikimedia.org/T93651#1142699 (10Jdlrobson) [22:34:03] 10Gather, 3Gather Sprint F: Toast should clip long collection titles - https://phabricator.wikimedia.org/T93797#1196322 (10Jdlrobson) [22:34:20] 10Gather, 3Gather Sprint F: On edit collection overlay, the box is labeled "public" instead of private - https://phabricator.wikimedia.org/T93391#1136059 (10Jdlrobson) [22:35:03] 10Gather: Reader analytics on collections pages and user collections page - https://phabricator.wikimedia.org/T94245#1196325 (10Jdlrobson) @jkatzwmf if you want us to work on this in #gather_sprint_f you'll need to flesh this out asap. [22:35:55] 10Gather, 3Mobile-Web-Design: No way to moderate a certain collection from the collection itself - https://phabricator.wikimedia.org/T94228#1196326 (10Jdlrobson) @msyed if we need to work on this next sprint please prepare a mock asap. [22:36:04] 10Gather, 3Gather Sprint F, 3Mobile-Web-Design: No way to moderate a certain collection from the collection itself - https://phabricator.wikimedia.org/T94228#1196327 (10Jdlrobson) [22:36:42] 10Gather, 3Gather Sprint F: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1196330 (10Jdlrobson) [22:37:04] 10Gather, 3Gather Sprint F: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1196331 (10Jdlrobson) a:3JKatzWMF @JKatzWMF we need those questions in TODO answered. [22:37:16] 10Gather, 3Gather Sprint F: Dismissing login drawer after clicking watchstar breaks watchstar - https://phabricator.wikimedia.org/T94682#1196333 (10Jdlrobson) [22:37:21] 10Gather, 3Gather Sprint F: Bug: Dismissing login drawer after clicking watchstar breaks watchstar - https://phabricator.wikimedia.org/T94682#1196334 (10Jdlrobson) [22:37:51] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Icon styles loaded twice on Gather special pages - https://phabricator.wikimedia.org/T95014#1196335 (10Jdlrobson) 5Open>3Resolved [22:39:21] 10Gather: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1196339 (10Jdlrobson) a:5MSyed>3JKatzWMF This really needs clarifying. Please rewrite with "As a... When I... Then..." story. Is this about the watchstar on pages or a new interface on Special:Ga... [22:39:27] 10Gather, 3Gather Sprint F: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1196341 (10Jdlrobson) [22:40:12] 10Gather: Data to fuel heuristics for flagging - https://phabricator.wikimedia.org/T94871#1196343 (10Jdlrobson) Mock still needed @msyed... [22:41:50] 10Gather, 3Gather Sprint F: Data to fuel heuristics for flagging - https://phabricator.wikimedia.org/T94871#1196344 (10Jdlrobson) [22:42:07] 10Gather: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1196346 (10Moushira) {F110730} Happened to me as well. While adding an article to an existing collection, the pop up freezes all of a sudden and doesn't scroll [22:42:10] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: User A who clicks on the name of the creator of a list (User B) is able to see a the list of lists created by User B, so that they can find more content from a source they like. - https://phabricator.wikimedia.org/T91037#1196347 (10Jdlrobson) 5Open>3Reso... [22:43:52] 10Gather: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1196348 (10Jdlrobson) [22:44:13] 10Gather: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1196350 (10Jdlrobson) a:3JKatzWMF Something we want to work on for #gather_sprint_f ? If so can you flesh out and get mocks? [22:44:20] 10Gather: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1196352 (10Jdlrobson) [22:47:44] (03PS1) 10Jdlrobson: Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 [22:51:08] (03CR) 10jenkins-bot: [V: 04-1] Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 (owner: 10Jdlrobson) [22:55:35] (03PS2) 10Jdlrobson: Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 [22:56:25] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1196362 (10Jdlrobson) a:5Jdlrobson>3None @jhernandez do you want to pick this one up. Probably going to run out of time today... [22:57:48] (03CR) 10Kaldari: [C: 032] Don't let the Wikitext editor over-expand [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203095 (https://phabricator.wikimedia.org/T95465) (owner: 10Phuedx) [22:58:03] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-53-Android, 3Mobile-App-Sprint-55-iOS: As a user, I'd like lead sentences to be concise so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1196365 (10Fjalapeno) I just brought my previous point... [22:58:25] bearND: is it just me, or do you feel like we've been getting abnormally "few" crash reports? [22:58:37] (never thought i'd say that) [22:59:45] (03CR) 10jenkins-bot: [V: 04-1] Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 (owner: 10Jdlrobson) [23:00:19] 10Gather: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1196367 (10JKatzWMF) 3NEW [23:00:59] (03CR) 10Bmansurov: Hygiene: Move buttonWithSpinner css to more natural place [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203227 (owner: 10Jdlrobson) [23:01:07] (03CR) 10Bmansurov: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203227 (owner: 10Jdlrobson) [23:08:40] (03CR) 10jenkins-bot: [V: 04-1] Don't let the Wikitext editor over-expand [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203095 (https://phabricator.wikimedia.org/T95465) (owner: 10Phuedx) [23:08:42] (03Merged) 10jenkins-bot: Hygiene: Move buttonWithSpinner css to more natural place [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203227 (owner: 10Jdlrobson) [23:10:03] dbrant: Nope, same here. I only see a few crash reports lately. [23:10:42] bearND: i hope it's not an issue with acra... was that updated recently? [23:11:29] (03PS1) 10Mholloway: Improve design of language list entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203244 (https://phabricator.wikimedia.org/T95213) [23:12:17] dbrant: no. We actually got quite a few OutOfMemoryError reports when we first released the last prod version. [23:12:34] hmm, right [23:13:00] dbrant: sorry, got to go, bb in ~ 20min [23:13:03] 3Gather Sprint Enwiki, 5Patch-For-Review: Hygiene: use global php classes without front \ - https://phabricator.wikimedia.org/T95270#1196390 (10Jdlrobson) 5Open>3Resolved [23:14:03] (03PS1) 10Robmoen: Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203245 [23:14:49] (03PS2) 10Mholloway: Improve design of language list entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203244 (https://phabricator.wikimedia.org/T95213) [23:16:38] (03PS3) 10Mholloway: Improve design of language list entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203244 (https://phabricator.wikimedia.org/T95213) [23:19:02] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Further improve design of "Read in other languages" in the Android app - https://phabricator.wikimedia.org/T95213#1196400 (10Mholloway) I just submitted a patch containing these changes for review; I also added code to right-align ent... [23:19:05] 10Gather: Flag a collection - https://phabricator.wikimedia.org/T90988#1196401 (10Jdlrobson) a:3JKatzWMF @JKatzWMF this story needs breaking down... [23:19:09] dbrant: mholloway: Deskana: Android app downloads have jumped from 22k/day to 74k/day as a result of being featured. well done [23:19:27] tfinc: \o/ [23:19:44] now lets figure out how to make it grown even faster [23:19:49] grow* [23:23:01] (03PS1) 10Robmoen: Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203247 [23:23:41] 10Gather, 3Gather Sprint F: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1196416 (10Jdlrobson) [23:23:50] (03CR) 10Kaldari: [C: 032] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203245 (owner: 10Robmoen) [23:24:05] (03CR) 10Kaldari: [C: 032] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203247 (owner: 10Robmoen) [23:25:18] mhurd: dr0ptp4kt_cold you want to just talk about the server stuff tomorrow during the day o meetings? I can get stuff up for you to review tonight and then you can tell me if it is poorly written or not. [23:25:51] coreyfloyd: ya tomorrow is better for me [23:26:02] 10Gather, 3Gather Sprint Enwiki: Infinite spinner when editing empty collections - https://phabricator.wikimedia.org/T95637#1196418 (10Jdlrobson) 3NEW [23:27:07] 10Gather, 3Gather Sprint F, 10MediaWiki-Database, 7database: DB gather_list.gl_id autonumber is always odd - https://phabricator.wikimedia.org/T94512#1196431 (10aaron) See http://www.percona.com/blog/2011/11/29/avoiding-auto-increment-holes-on-innodb-with-insert-ignore/ Also the code: ``` $row = $this->g... [23:27:18] (03Merged) 10jenkins-bot: Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203247 (owner: 10Robmoen) [23:27:31] 10Wikipedia-iOS-App, 6Project-Creators: Create "Wikimedia-Hackathon-2015-App-Prep" sprint project - https://phabricator.wikimedia.org/T95638#1196432 (10dr0ptp4kt) 3NEW [23:27:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203245 (owner: 10Robmoen) [23:28:36] (03CR) 10Robmoen: "recheck" [extensions/MobileFrontend] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203245 (owner: 10Robmoen) [23:32:10] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-53-Android, 3Mobile-App-Sprint-55-iOS: As a user, I'd like lead sentences to be concise so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1196448 (10Vibhabamba) **The information in brackets i... [23:33:47] coreyfloyd: dr0ptp4kt_cold finally got a fix. will put patch up soon [23:33:51] brb [23:35:24] mhurd: ok [23:37:19] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-53-Android, 3Mobile-App-Sprint-55-iOS: As a user, I'd like lead sentences to be concise so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1196456 (10Vibhabamba) Also - responding to this with... [23:38:45] (03PS1) 10Jdlrobson: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 [23:38:48] (03PS1) 10Jdlrobson: Hygiene: Simplify PageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 [23:39:23] 10Wikipedia-Android-App: Highlighting text in search view makes search text invisible - https://phabricator.wikimedia.org/T95591#1196459 (10Dbrant) Isn't this a duplicate of T88768? The CAB is simply overlapping on top of the search field (the text color isn't the problem). [23:41:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify PageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 (owner: 10Jdlrobson) [23:45:31] coreyfloyd: yeah, tomorrow works just fine [23:49:26] 10Gather: Remove "public" icon from gather headers and redesign - https://phabricator.wikimedia.org/T95639#1196462 (10JKatzWMF) 3NEW a:3MSyed [23:50:19] dr0ptp4kt_cold: np [23:50:53] 10Wikipedia-Android-App: Highlighting text in search view makes search text invisible - https://phabricator.wikimedia.org/T95591#1196474 (10bearND) Good point. I'll merge it. [23:51:02] 10Gather, 3Gather Sprint Enwiki, 3Mobile-Web-Design, 5Patch-For-Review: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1196477 (10JKatzWMF) @rmoen and @jdlrobson, had talked to @msyed about this earlier in the week. He is working on an im... [23:51:11] 10Wikipedia-Android-App: Highlighting text in search view makes search text invisible - https://phabricator.wikimedia.org/T95591#1196479 (10bearND) [23:51:13] 10Wikipedia-Android-App: Double-tap search text hides it behind buttons - https://phabricator.wikimedia.org/T88768#1196480 (10bearND) [23:54:07] 10Gather: Remove "public" icon from gather headers and redesign - https://phabricator.wikimedia.org/T95639#1196487 (10JKatzWMF) [23:56:48] mhurd: coreyfloyd about to wrap up. you guys have a good night. talk to you tomorrow [23:57:51] dr0ptp4kt_cold: u too. I'm taking a break soon and will bb later