[00:02:22] (03CR) 10Robmoen: [C: 032] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203245 (owner: 10Robmoen) [00:02:38] (03CR) 10Robmoen: [V: 032] Hygiene: Make schema MobileFrontend agnostic [extensions/MobileFrontend] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203245 (owner: 10Robmoen) [00:05:09] (03CR) 10Dbrant: [C: 04-1] Improve design of language list entries (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203244 (https://phabricator.wikimedia.org/T95213) (owner: 10Mholloway) [00:09:05] dbrant: Sure, if you want to do things the simple way... :) [00:09:35] mholloway: i'm old-fashioned like that. [00:22:20] (03CR) 10Bmansurov: [C: 04-1] "Cannot get it to work on IE8. I'm getting the following error:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [00:24:58] jdlrobson: Notice: Undefined property: Gather\models\Collection::$continue in /srv/mediawiki/php-1.25wmf24/extensions/Gather/includes/models/Collection.php on line 127 [00:25:39] Old ^^ [00:28:16] 10Wikipedia-Android-App: Several enhancement requests - https://phabricator.wikimedia.org/T69351#1196499 (10Dbrant) 5Open>3Invalid a:3Dbrant The formatting of this task isn't really actionable (there are multiple requests that are very different), so let's go through each item one by one, and see if they'v... [00:33:17] kaldari want to talk to us about wikigrok at wikimania? [00:33:26] in diderot 3rd floor [00:33:39] (03PS4) 10Mholloway: Improve design of language list entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203244 (https://phabricator.wikimedia.org/T95213) [00:35:01] moizsyed: deployment is running late [00:35:08] kaldari: ok [00:35:27] moizsyed: should be done in a couple minutes [00:35:41] kaldari: ok come to the room [00:35:52] (03CR) 10jenkins-bot: [V: 04-1] Improve design of language list entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203244 (https://phabricator.wikimedia.org/T95213) (owner: 10Mholloway) [00:36:49] (03PS1) 10Jdlrobson: Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 [00:37:11] jdlrobson hey, just saw that the gather eventlogging had a bug--does that mean I can't trust the data or just that it had a missing column? [00:37:20] (03PS5) 10Mholloway: Improve design of language list entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203244 (https://phabricator.wikimedia.org/T95213) [00:42:20] (03CR) 10Bmansurov: [C: 031] Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [00:42:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (owner: 10Jdlrobson) [00:43:17] rmoen: https://en.m.wikipedia.org/wiki/Special:Gather/by/Moshirah/595 [00:44:46] 10Wikipedia-Android-App, 7Easy: Do not display "Read in other languages" when there're no other languages available - https://phabricator.wikimedia.org/T68198#1196511 (10Dbrant) hint: the mobileview API has a parameter called "languagecount" [00:46:41] 10Gather, 3Gather Sprint Enwiki, 3Mobile-Web-Design, 5Patch-For-Review: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1196513 (10Jdlrobson) @msyed says this tag shouldn't show on public lists. [00:54:06] (03CR) 10Dbrant: [C: 032] Improve design of language list entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203244 (https://phabricator.wikimedia.org/T95213) (owner: 10Mholloway) [00:55:03] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1196514 (10Fjalapeno) >>! In T93692#1194862, @dr0ptp4kt wrote: >>>! In T93692#1194754, @Fjalapeno wrote: >> @dr0ptp4kt my feedback here is that we should make a process... [00:59:22] 10Wikipedia-Android-App: NullPointerException from android.app.ActivityThread.handleStopActivity? - https://phabricator.wikimedia.org/T69736#1196517 (10Dbrant) 5Open>3Resolved a:3Dbrant Haven't seen these in a good long time. [01:04:20] dbrant, oh thank you for https://phabricator.wikimedia.org/T69351 [01:04:32] I really really dislike people shoving as many issues as they can think of into one ticket [01:05:10] Krenair: np! me too. [01:05:10] I'm slowly grooming other ones, as well [01:05:14] I am reminded of https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7590660 [01:05:21] (03PS2) 10Jdlrobson: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 [01:05:48] (03PS2) 10Jdlrobson: Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 [01:05:50] (03PS3) 10Jdlrobson: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 [01:06:03] Krenair: lolol that's a good one [01:07:01] 15 points, at the time that would've been a large fraction of the total open tickets against the app [01:07:43] I would love to be able to ask them to file each one separately... but at that point they've already done so much it feels rude and potentially counterproductive [01:10:48] (03Merged) 10jenkins-bot: Improve design of language list entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203244 (https://phabricator.wikimedia.org/T95213) (owner: 10Mholloway) [01:10:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (owner: 10Jdlrobson) [01:19:23] 10Wikipedia-Android-App, 7Easy: Use thumbwidth instead of thumbsize when fetching lead image. - https://phabricator.wikimedia.org/T91144#1196535 (10Dbrant) [01:20:01] 10Wikipedia-Android-App: NullPointerException from android.app.ActivityThread.handleStopActivity? - https://phabricator.wikimedia.org/T69736#1196538 (10Krenair) Ooh, yes. I wonder what you guys did that mysteriously fixed the issue. Thanks anyway! [01:40:23] bearND: is it a good time to look at play store data tomorrow? [01:40:57] bearND: we have a meeting scheduled tomorrow - wondering if we need more time. [01:44:11] 3Gather Sprint Enwiki: Get Gather updated on English Wikipedia - https://phabricator.wikimedia.org/T95454#1196561 (10Jdlrobson) 5Open>3Resolved @rmoen sorted this like a boss! \o/ [01:44:55] vibha: depends on what you want to do with the data. I see a nice uptake since last release [01:44:59] rmoen, want to merge it now? [02:02:28] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Responsive design for tiling Special:Gather list of collections - https://phabricator.wikimedia.org/T91384#1196597 (10JKatzWMF) 5Open>3Resolved [02:02:45] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1196598 (10Nicolas_Raoul) @NiharikaKohli I already had an account (nicolas_raoul) so I have sent a connection... [02:03:31] 10Gather: Special:Gather page has no title - https://phabricator.wikimedia.org/T95640#1196601 (10Deskana) 3NEW [02:04:17] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Special:Gather uses "articles" instead of "pages" or a more generic term - https://phabricator.wikimedia.org/T94967#1196609 (10JKatzWMF) I still see articles... {F110777} [02:05:40] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1196610 (10JKatzWMF) 5Open>3declined @jdlrobson, looks good on FB. this still doesn't work on twitter [02:06:04] bearND: Great! The main things were - New downloads. [02:06:41] bearND: 2 Main things I wanted to look at - New downloads since app launch && which users on which version of the app. [02:21:11] vibha: Sure, we can check those out together. [02:23:29] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Special:Gather uses "articles" instead of "pages" or a more generic term - https://phabricator.wikimedia.org/T94967#1196619 (10Jdlrobson) Needs a scap. Test on beta labs [02:24:43] bearND: great [02:34:19] 10Wikipedia-Android-App: Crashes caused by android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#1196636 (10Dbrant) There may be some theoretical basis that these errors are due to out-of-memory conditions. We'll have to monitor the rate of these reports after we deploy our... [02:42:32] 10Wikipedia-Android-App: Bundle fonts for languages that are not supported natively. - https://phabricator.wikimedia.org/T71184#1196640 (10Dbrant) [02:57:48] 10Wikipedia-Android-App: User subpages are shown as "Read more" entries for the main page when opening the Android app - https://phabricator.wikimedia.org/T94794#1196669 (10bearND) This is related to T92787 but for the main page handling. [03:00:09] 10Wikipedia-Android-App, 7Easy: 'Tap here to expand' - the label should change when the section is expanded? - https://phabricator.wikimedia.org/T86860#1196673 (10bearND) [03:03:59] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Portal template displays an additional element instead of being rendered as just links - https://phabricator.wikimedia.org/T92659#1196677 (10bearND) 5Open>3Invalid a:3bearND This is not a bug. The desktop version also shows this box. [03:11:27] 10Wikipedia-Android-App: Scroll position for image description is preserved while moving through images, hiding some of them - https://phabricator.wikimedia.org/T87191#1196681 (10bearND) [03:11:29] 10Wikipedia-Android-App: Image description, when hidden, sometimes is still visible right at the bottom of the page - https://phabricator.wikimedia.org/T86577#1196682 (10bearND) [03:26:11] 10Wikipedia-Android-App, 10Wikimedia-Search: the app doesn't tell that no matching titles were found - https://phabricator.wikimedia.org/T91973#1196697 (10bearND) p:5Low>3Normal [03:42:28] 10Wikipedia-Android-App: Inconsistent image file info/display on 'Go to file page' - https://phabricator.wikimedia.org/T89191#1196720 (10bearND) @Etonkovidova: As far as the layout itself is concerned Android and iOs are on the same level ATM. Comparing tablets vs. phones is not a fair comparison. Of course it f... [03:43:16] 10Wikipedia-Android-App: Inconsistent image file info/display on 'Go to file page' - https://phabricator.wikimedia.org/T89191#1196721 (10bearND) p:5Triage>3Low [03:47:35] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Continuous-Integration: Jenkins should run tests for the Wikipedia app before merge - https://phabricator.wikimedia.org/T62720#1196734 (10bearND) p:5Lowest>3High [03:53:33] 10Gather, 3Gather Sprint Enwiki: API: Unexpected results - https://phabricator.wikimedia.org/T94600#1196737 (10Yurik) 5Open>3Invalid a:3Yurik Never mind, looked at it closer. Everything seems as expected, please look at the general API docs. ``` ...&list=lists&lstids=7&lstowner=Jdlrobson & generator=l... [05:16:38] (03CR) 10Florianschmidtwelzow: Add description of Gather for Special:UserLogin (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203220 (https://phabricator.wikimedia.org/T94971) (owner: 10Florianschmidtwelzow) [05:21:47] (03PS2) 10Florianschmidtwelzow: Add description of Gather for Special:UserLogin [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203220 (https://phabricator.wikimedia.org/T94971) [05:30:17] (03CR) 10Florianschmidtwelzow: [C: 032] "Come on, Jenkins :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203095 (https://phabricator.wikimedia.org/T95465) (owner: 10Phuedx) [05:32:59] (03Merged) 10jenkins-bot: Don't let the Wikitext editor over-expand [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203095 (https://phabricator.wikimedia.org/T95465) (owner: 10Phuedx) [05:47:18] (03CR) 10Florianschmidtwelzow: [C: 04-1] "hmm, for some reason, the toast needs some time to appear (it seems that's why the tests are failing, if you wrap the "toast is shown" ass" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 (owner: 10Jdlrobson) [05:52:10] (03PS7) 10Florianschmidtwelzow: Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [05:52:18] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [05:54:05] (03PS2) 10Florianschmidtwelzow: Make sure the upload button cursor is a pointer in firefox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203218 (owner: 10Bmansurov) [05:54:46] (03CR) 10Florianschmidtwelzow: [C: 032] Make sure the upload button cursor is a pointer in firefox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203218 (owner: 10Bmansurov) [05:54:48] (03Merged) 10jenkins-bot: Hygiene: Correct the image used in alpha for search icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202583 (owner: 10Jdlrobson) [05:58:36] (03CR) 10Florianschmidtwelzow: [C: 04-1] "the edit buttons for non-toggleable sections looks (more) misplaced (as before) :/" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203184 (owner: 10Bmansurov) [05:58:53] (03Merged) 10jenkins-bot: Make sure the upload button cursor is a pointer in firefox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203218 (owner: 10Bmansurov) [06:04:21] (03PS6) 10Florianschmidtwelzow: Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 [06:26:55] (03PS17) 10Florianschmidtwelzow: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) [06:27:49] (03PS11) 10Florianschmidtwelzow: Promote TalkOverlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/190728 (https://phabricator.wikimedia.org/T54165) [06:30:15] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [06:39:34] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Continuous-Integration: Jenkins should run tests for the Wikipedia app before merge - https://phabricator.wikimedia.org/T62720#1196857 (10Legoktm) Are there more details about what needs to be done for this? does the jenkins plugin need to be installed? or can... [06:45:28] 6Mobile-Web: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1196862 (10Florian) [08:25:06] morning! [08:48:29] 10Gather: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1197035 (10Jhernandez) cc/ @MSyed @JKatzWMF The current spacing and desing of the modal produces this results, it is not very friendly on small screens. I would suggest changing the current spacing (1em left/right, 4... [09:00:42] 6Mobile-Web: Make a Gather list that cannot be hidden by anyone - https://phabricator.wikimedia.org/T94757#1197059 (10Jhernandez) As long as the collection isn't stored by using the gather api, it won't be listed on all the lists nor the api will be able to do anything with it for hiding it. [09:03:41] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [09:11:32] morning all [09:13:24] 6Mobile-Web: Make a Gather list that cannot be hidden by anyone - https://phabricator.wikimedia.org/T94757#1197072 (10phuedx) @Jhernandez, @Jdlrobson: So if we do use the hook mechanism – this actually seems like a reasonable use of the hook mechanism – then we get hidden lists for free? [09:16:02] (03CR) 10Phuedx: "So the BannerImage module is broken on master in IE8?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [09:16:15] hey joakino :) [09:19:22] hi phuedx [09:19:24] how are you dong [09:19:27] oops [09:19:30] doing xD [09:23:02] good and ok thanks :) [09:23:04] busy [09:23:15] having fun trying to organise work :) [09:23:17] how's so [09:26:15] 10Gather, 3Gather Sprint F, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1197097 (10phuedx) Collaboration! 🎉 [09:33:30] more massaging of phab tasks generally [09:33:31] joakino: ^ [09:33:41] i now have quite a hefty code review backlog :/ [09:33:45] that's my job for today [09:34:03] phuedx: how is it? i find that very tedious and slow with phabricator [09:34:25] joakino: could be better -- i haven't yet found any serious pain points [09:34:30] though there are several minors [09:34:57] dealing with blockers is annoying [09:35:02] aha [12:00:17] (03PS1) 10Phuedx: Fix WikiGrok event logging [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203312 [12:15:06] 10Gather: Support mobile friendly view for Special:Gatherlists - https://phabricator.wikimedia.org/T95676#1197446 (10Moushira) 3NEW [12:15:37] 10Gather: Support mobile friendly view for Special:Gatherlists - https://phabricator.wikimedia.org/T95676#1197453 (10Moushira) [12:43:13] 10Wikipedia-iOS-App, 6Project-Creators: Create "Wikimedia-Hackathon-2015-App-Prep" sprint project - https://phabricator.wikimedia.org/T95638#1197548 (10Aklapper) 5Open>3Resolved a:3Aklapper Requested project #Wikimedia-Hackathon-2015-App-Prep has been created: https://phabricator.wikimedia.org/project/pr... [14:37:30] (03CR) 10Phuedx: "I've also proven that the filtering works as expected." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [14:39:17] (03PS1) 10Bgerstle: gallery: re-add out of bounds assertion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) [14:41:49] (03CR) 10Phuedx: "Sorry, the database has a wrapper for upserting (see Database#upsert)." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [14:42:36] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1197994 (10BGerstle-WMF) [14:43:32] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review, 3Wikimedia-Hackathon-2015-App-Prep: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1157959 (10BGerstle-WMF) [14:44:59] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review, 3Wikimedia-Hackathon-2015-App-Prep: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1198000 (10BGerstle-WMF) This is difficult to test, but if anyone has a... [14:50:16] 10Wikipedia-iOS-App, 7Documentation, 3Wikimedia-Hackathon-2015-App-Prep: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1198036 (10BGerstle-WMF) [15:07:51] (03PS1) 10Phuedx: Upsert WikiGrok questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203345 [15:09:33] (03CR) 10Phuedx: "See my follow-on patch f'rinstance." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [15:39:26] (03CR) 10Jhernandez: [C: 04-1] "Dependency is merged, but I've updated mobile frontend and I can't get this to show up (incognito window, new user just signed up or logge" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) (owner: 10Jdlrobson) [15:45:19] (03PS2) 10Jhernandez: Hygiene: Correctly identify the RL module name for plus icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203214 (owner: 10Jdlrobson) [15:45:51] (03CR) 10Jhernandez: [C: 032] Hygiene: Correctly identify the RL module name for plus icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203214 (owner: 10Jdlrobson) [15:47:39] (03PS2) 10Jhernandez: When a user clicks on hamburger after adding to a collection show new icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203215 (https://phabricator.wikimedia.org/T95245) (owner: 10Jdlrobson) [15:52:29] (03Merged) 10jenkins-bot: Hygiene: Correctly identify the RL module name for plus icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203214 (owner: 10Jdlrobson) [15:52:43] (03CR) 10jenkins-bot: [V: 04-1] When a user clicks on hamburger after adding to a collection show new icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203215 (https://phabricator.wikimedia.org/T95245) (owner: 10Jdlrobson) [15:56:09] (03PS3) 10Jhernandez: When a user clicks on hamburger after adding to a collection show new icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203215 (https://phabricator.wikimedia.org/T95245) (owner: 10Jdlrobson) [15:57:24] (03CR) 10Jhernandez: [C: 032] "Fixed some jshint/jscs errors." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203215 (https://phabricator.wikimedia.org/T95245) (owner: 10Jdlrobson) [16:00:19] (03CR) 10Phuedx: "Vague comments inline – rather than anything critical, minor, or trivial." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [16:21:43] Hello JonKatz. [16:23:47] Krenair: i think JonKatz is in a meeting right now [16:24:03] he should be finished in 55 minutes [16:25:17] Okay. [16:26:40] Thanks phuedx [16:26:59] Krenair: was it JK you wanted specifically? [16:27:06] Yes. [16:27:12] ok cool [16:27:14] just checking :) [16:33:44] (03PS1) 10Phuedx: Ignore WikiGrok not being configured to push data [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203365 [16:44:47] (03CR) 10Phuedx: [C: 031] "This works like a charm. Nice work!" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [16:45:16] brb [16:45:33] (03PS2) 10Phuedx: Ignore WikiGrok not being configured to push data [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203365 (https://phabricator.wikimedia.org/T95304) [16:49:52] 6Mobile-Web, 10MobileFrontend, 10Browser-Tests: add metadata to ChunkyPNG image - https://phabricator.wikimedia.org/T67274#1198354 (10Jdlrobson) This was needed back in the days we supported photo uploads. When uploading a photo without meta data an alert would show reminding the user that they should be upl... [16:51:19] 6Mobile-Web, 10MobileFrontend, 10Browser-Tests, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: add metadata to ChunkyPNG image - https://phabricator.wikimedia.org/T67274#1198365 (10greg) MediaViewer folks: Is this something you want? [16:52:04] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Special:Gather uses "articles" instead of "pages" or a more generic term - https://phabricator.wikimedia.org/T94967#1198368 (10Jdlrobson) 5Open>3Resolved Verified as fixed on betalabs and enwiki [16:53:15] 6Mobile-Web, 10MobileFrontend, 10Browser-Tests, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: Should be possible in browser tests to use images with meta data or without meta data - https://phabricator.wikimedia.org/T67274#1198370 (10Jdlrobson) [16:54:24] 10Wikipedia-Android-App: Investigate why users are reporting that they're getting "no internet connection" errors - https://phabricator.wikimedia.org/T95043#1198373 (10Deskana) [16:55:02] kristenlans: you around? [16:55:23] yes joakino [16:56:09] joakino intently listening to this breakfast with terry [16:56:13] kristenlans: i've been following and learning about kanban from the teampractices list and I was wondering if it would be possible to try it for a bit on gather? [16:56:18] kristenlans: yep me too, sorry [16:56:22] (03CR) 10Florianschmidtwelzow: Filter out retired WikiGrok claims from WikiGrok pages (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [16:56:48] joakino no worries, I can multitask ;-) [16:59:09] hi krenair! I have standup in 2 minutes, but can half-pay attention [16:59:11] 6Mobile-Web: Make a Gather list that cannot be hidden by anyone - https://phabricator.wikimedia.org/T94757#1198393 (10Jdlrobson) @phuedx am a little confused. Why would you want hidden lists? Hidden lists require an entry in the database. You would be requiring the data for this list... Collection does have a m... [17:04:21] dr0ptp4kt_cold: running a bit behind this morning. I emailed standup status [17:04:39] moiz is awesome [17:04:47] coreyfloyd: bgerstle ^ [17:04:53] (03CR) 10Bmansurov: Alpha, Beta: Correctly align the edit icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203184 (owner: 10Bmansurov) [17:05:48] mhurd ok [17:06:04] 6Mobile-Web, 10MediaWiki-User-login-and-signup: Watermark and no default message not shown in alpha version of login form - https://phabricator.wikimedia.org/T87261#1198408 (10Jdlrobson) [17:06:07] 6Mobile-Web, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Alpha captcha styling different from stable - https://phabricator.wikimedia.org/T87256#1198409 (10Jdlrobson) [17:06:09] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] Getting rid of own login page - https://phabricator.wikimedia.org/T74910#775077 (10Jdlrobson) [17:07:22] (03CR) 10Jdlrobson: [C: 032] "Merged on basis that one day https://phabricator.wikimedia.org/T74910 will get resolved" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203221 (https://phabricator.wikimedia.org/T94971) (owner: 10Florianschmidtwelzow) [17:08:32] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Gather should explain to users why they're required to log in if they go to Special:Gather or Special:GatherLists - https://phabricator.wikimedia.org/T94971#1198419 (10Jdlrobson) 5Open>3Resolved [17:13:14] 6Mobile-Web: Make a Gather list that cannot be hidden by anyone - https://phabricator.wikimedia.org/T94757#1198429 (10phuedx) @Jdlrobson: What I mean to say is, I don't think this is a thing because of the way we're going to be generating the Gather lists. [17:13:26] (03CR) 10BearND: [C: 04-1] "Have not looked at the rest yet, but please keep the subject line of your commit message to < 80 chars" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway) [17:14:16] 6Mobile-Web: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1198431 (10KLans_WMF) a:3bmansurov [17:15:31] (03Merged) 10jenkins-bot: Add Special:Gather messages on Special:UserLogin/Special:CreateAccount [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203221 (https://phabricator.wikimedia.org/T94971) (owner: 10Florianschmidtwelzow) [17:19:51] 6Mobile-Web: Initial banner image should be delivered as part of the initial response - https://phabricator.wikimedia.org/T90698#1198445 (10JKatzWMF) lets show low res image as default before load [17:21:24] 6Mobile-Web: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1198449 (10bmansurov) Initially, I thought it was related to [[ https://bugzilla.mozilla.org/show_bug.cgi?id=735806 | a bug in Firefox ]], but it looks like it maybe on our end. [17:25:23] 6Mobile-Web: On iOS 8.3 iPhone 5c in Private mode Safari, sometimes dragging/flicking doesn't scroll in modals - https://phabricator.wikimedia.org/T95561#1198473 (10phuedx) This is a fire bucket ticket. [17:26:52] 6Mobile-Web: Make a Gather list that cannot be hidden by anyone - https://phabricator.wikimedia.org/T94757#1198475 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson If a list is user created then it by definition has the ability to be hidden If you are creating lists programmatically, hiding is irrelevant (since t... [17:29:32] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7I18n: the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages - https://phabricator.wikimedia.org/T91886#1198484 (10Jdlrobson) [17:29:42] 6Mobile-Web, 6Collaboration-Team, 10Flow: On mobile, the Flow notification's link takes you to the desktop version of the Flow page, even though the main (background) link takes you to the mobile one - https://phabricator.wikimedia.org/T93035#1198486 (10Jdlrobson) [17:29:47] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7I18n: wgRevisionId is 0 for Flow pages - https://phabricator.wikimedia.org/T92296#1198489 (10Jdlrobson) [17:30:36] 10Gather: Render categories through Gather - https://phabricator.wikimedia.org/T95460#1198503 (10phuedx) [17:31:19] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1198508 (10bearND) @Deskana My intention was to use the versionCode as the subminor version number. [17:32:24] 6Mobile-Web, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown, and 2 others: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#1198518 (10Jdlrobson) [17:33:45] 6Mobile-Web: mwext-MobileFrontend-qunit-mobile issues again - https://phabricator.wikimedia.org/T95430#1198531 (10phuedx) Ping @Krinkle, @hashar. [17:33:58] 6Mobile-Web, 6Release-Engineering: mwext-MobileFrontend-qunit-mobile issues again - https://phabricator.wikimedia.org/T95430#1198535 (10phuedx) [17:36:11] 6Mobile-Web: Search workflow in alpha needs non-JavaScript fallback - https://phabricator.wikimedia.org/T92675#1198547 (10Jdlrobson) [17:36:13] 6Mobile-Web, 10MobileFrontend: Examine discoverability and usability of search on low-JS devices - https://phabricator.wikimedia.org/T66926#1198548 (10Jdlrobson) [17:36:57] 6Mobile-Web, 10WikiGrok: WikiGrok save error - https://phabricator.wikimedia.org/T95721#1198551 (10bmansurov) 3NEW [17:36:59] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: EPIC: As a mobile reader, I would like links that I tap on to show quick previews so that I can choose whether to navigate to it or not. - https://phabricator.wikimedia.org/T94630#1198558 (10KLans_WMF) a... [17:37:35] 6Mobile-Web, 10MobileFrontend: Examine discoverability and usability of search on low-JS devices - https://phabricator.wikimedia.org/T66926#701560 (10Jdlrobson) This is an old bug, but we should re-explore this as we explore redesigning the header. cc @kaldari @khammerstein @jkatzwmf [17:39:46] 6Mobile-Web, 10WikiGrok: WikiGrok must not load when there are no suggestions. - https://phabricator.wikimedia.org/T95722#1198574 (10bmansurov) 3NEW [17:40:22] 6Mobile-Web, 10MobileFrontend-Feature-requests: Allow feedback for mobile beta features like Desktop - https://phabricator.wikimedia.org/T67078#1198585 (10Jdlrobson) [17:40:47] (03CR) 10Bmansurov: [C: 031] "Tested, works!" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203345 (owner: 10Phuedx) [17:40:49] 6Mobile-Web, 10MobileFrontend-Feature-requests: Allow feedback for mobile beta features like Desktop - https://phabricator.wikimedia.org/T67078#688055 (10Jdlrobson) This is not a bug. It requires substantial work thus is a new feature request. Not sure why it was moved here. [17:41:58] 6Mobile-Web, 10Continuous-Integration, 6Release-Engineering: mwext-MobileFrontend-qunit-mobile issues again - https://phabricator.wikimedia.org/T95430#1198592 (10greg) [17:43:40] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: As a user I want to get quick context about a link. A combination of text and image will help me learn. (Prototype 1) - https://phabricator.wikimedia.org/T95030#1198620 (10KLans_WMF) [17:43:48] (03CR) 10Bmansurov: [C: 032] Fix WikiGrok event logging [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203312 (owner: 10Phuedx) [17:44:54] (03CR) 10Legoktm: "The changes in the XAnalytics extension need to be merged first before this will work." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202802 (https://phabricator.wikimedia.org/T92875) (owner: 10Legoktm) [17:45:13] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: As a user I want to get quick context about a link. A combination of text and image will help me learn. (Prototype 1) - https://phabricator.wikimedia.org/T95030#1198631 (10Deskana) Prototype 1 is basical... [17:45:47] (03Merged) 10jenkins-bot: Fix WikiGrok event logging [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203312 (owner: 10Phuedx) [17:46:04] 6Mobile-Web, 10MobileFrontend: Adds specific support for ProofreadPage Page: namespace - https://phabricator.wikimedia.org/T67165#1198644 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson As Florian says you can disable editing using that config change. I've setup a sub task for you to do that. [17:47:30] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Standardize image fetch/cache/fallback logic - https://phabricator.wikimedia.org/T95350#1198655 (10dr0ptp4kt) [17:47:41] 6Mobile-Web, 10MobileFrontend: MobileFrontend extension should stop special-casing main page - https://phabricator.wikimedia.org/T32405#355934 (10Jdlrobson) @Maxsem you did some analytics around comparing the reduced page size vs the processing time Would it make sense to make the main page formatter more gene... [17:48:43] bmansurov: the problem with the upsert patch is that it changes 1 query into (potentially) 2N queries [17:49:15] however, as i understand it, n is more than often 1 or 2 [17:49:46] phuedx: maybe you can delay hitting the db and do a batch upsert? [17:50:41] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1198677 (10KLans_WMF) [17:50:44] kristenlans: Can you relink the phab card for the second prototype to this link > https://trello.com/c/OAzhMOZ8/114-prototypes [17:51:19] bmansurov: we might have to craft a sql statement by hand [17:51:24] I have updated the files on the trello card [17:52:01] phuedx: I don't see why we shouldn't if that helps [17:52:06] 6Mobile-Web, 10MobileFrontend: MobileFrontend extension should stop special-casing main page - https://phabricator.wikimedia.org/T32405#1198680 (10MaxSem) Not in present state where it can add a considerable slowdown on every request that reaches appservers. It would definitely be possible with Parsoid pagevi... [17:52:46] 6Mobile-Web, 10MobileFrontend, 10Math, 7Mobile: MathJax does not work on MobileFrontend - https://phabricator.wikimedia.org/T95498#1198689 (10Jdlrobson) This bug keeps coming up so I'd be super happy to resolve this in some satisfactory way once and for all. Alas I've never had the time to look into this e... [17:52:55] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1198691 (10KLans_WMF) [17:53:39] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1198697 (10KLans_WMF) [17:53:49] http://media.giphy.com/media/14lD03Sf5jQTeg/giphy.gif [17:53:51] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: EventLogging to evaluate success/failure of link hovering prototype - https://phabricator.wikimedia.org/T95726#1198698 (10Deskana) 3NEW [17:53:54] oops sorry [17:56:24] 6Mobile-Web, 10MobileFrontend: no path to Special:SpecialPages - https://phabricator.wikimedia.org/T65419#1198711 (10Jdlrobson) [17:56:26] 6Mobile-Web, 10MobileFrontend: Allow configuration of the mobilefrontend menu - https://phabricator.wikimedia.org/T65459#1198712 (10Jdlrobson) [17:56:58] 6Mobile-Web, 10MobileFrontend: no path to Special:SpecialPages - https://phabricator.wikimedia.org/T65419#679437 (10Jdlrobson) There are no plans to add Special:SpecialPages to the left menu on Wikimedia sites since space is restricted but adding a level of customisation to the wiki would allow people to tweak... [17:57:12] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1198722 (10KLans_WMF) a:5Dbrant>3None [17:58:25] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1179597 (10KLans_WMF) [17:59:09] 6Mobile-Web, 10MobileFrontend-Feature-requests, 7Design: Feature request: Cannot view source of old revisions - https://phabricator.wikimedia.org/T56484#1198744 (10Jdlrobson) [17:59:16] 6Mobile-Web, 10MobileFrontend, 10MobileFrontend-Feature-requests, 7Design: Feature request: Cannot view source of old revisions - https://phabricator.wikimedia.org/T56484#1198747 (10Jdlrobson) [17:59:31] 6Mobile-Web, 10MobileFrontend, 10MobileFrontend-Feature-requests, 7Design: Feature request: Cannot view source of old revisions - https://phabricator.wikimedia.org/T56484#1198748 (10Jdlrobson) [17:59:59] 6Mobile-Web, 10MobileFrontend-Feature-requests, 7Design: Feature request: Cannot view source of old revisions - https://phabricator.wikimedia.org/T56484#1198750 (10Jdlrobson) [18:01:02] 10MobileFrontend-Feature-requests, 10MediaWiki-extensions-Collection, 6Wikisource, 7Mobile: A link should be provided to create a book from mobile - https://phabricator.wikimedia.org/T62249#1198752 (10Jdlrobson) [18:01:18] 10MobileFrontend-Feature-requests, 7Design: Feature request: Cannot view source of old revisions - https://phabricator.wikimedia.org/T56484#591697 (10Jdlrobson) [18:02:08] 10Gather: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1198758 (10JKatzWMF) @jhernandez, I agree!! @msyed, does this work for you? [18:02:40] 10MobileFrontend-Feature-requests: Allow feedback for mobile beta features like Desktop - https://phabricator.wikimedia.org/T67078#1198759 (10Jdlrobson) [18:04:36] dr0ptp4kt_cold: bgerstle coreyfloyd http://hatjitsu.wmflabs.org/18751 [18:05:28] 6Mobile-Web, 6Collaboration-Team, 10Continuous-Integration, 10Flow, and 2 others: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1198773 (10Jdlrobson) [18:05:45] 6Mobile-Web: [Tracking] Features in MobileFrontend beta site - https://phabricator.wikimedia.org/T86961#1198784 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Well this didn't work.. :) [18:05:51] 6Mobile-Web: [Tracking] Features in alpha - https://phabricator.wikimedia.org/T86964#1198789 (10Jdlrobson) Well this didn't work.. :) [18:07:25] 6Mobile-Web: [Tracking] Features in alpha - https://phabricator.wikimedia.org/T86964#1198797 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson [18:07:50] https://trello.com/c/OAzhMOZ8/114-prototypes [18:08:40] 6Mobile-Web, 10Analytics-EventLogging: MobileWebClickTracking table is huge and thus querying too slow - https://phabricator.wikimedia.org/T76671#1198805 (10Jdlrobson) 5Open>3declined we're no longer using this table. We split into multiple tables. [18:08:57] 3Gather Sprint Enwiki: string replacement for watchstar login page - https://phabricator.wikimedia.org/T95729#1198811 (10JKatzWMF) 3NEW [18:10:20] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] MobileFrontend should use mw-ui-icon - https://phabricator.wikimedia.org/T73181#756520 (10Jdlrobson) [18:10:22] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Promote mw-ui-icon to stable - https://phabricator.wikimedia.org/T95619#1198843 (10Jdlrobson) [18:11:19] 6Mobile-Web, 7Technical-Debt: API: Sensible mobileview defaults - https://phabricator.wikimedia.org/T62485#1198857 (10Jdlrobson) 5Open>3Invalid This is never going to happen so no point in keeping this around. [18:11:21] 3Gather Sprint Enwiki, 5Patch-For-Review: EventLogging broken on GatherClicks - https://phabricator.wikimedia.org/T95615#1198859 (10JKatzWMF) 5Open>3Resolved [18:11:41] gonna take a break for dinner [18:11:48] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Proper collection sharing format/content - https://phabricator.wikimedia.org/T91696#1198865 (10JKatzWMF) 5declined>3Open [18:11:55] back in 24 [18:12:02] to work on the upsert query for wikigrok [18:12:13] because i want to see bmansurov's patch merged :) [18:12:30] that's what's up [18:12:54] i'll actually more likely be back in 14 [18:12:57] with tea in hand [18:14:23] 6Mobile-Web: Filename scraping for image viewer should support ugly URLs - https://phabricator.wikimedia.org/T86467#1198889 (10Jdlrobson) I still don't really understand this... Can you provide some clear steps to replicate? [18:14:58] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: EPIC: As a mobile reader, I would like links that I tap on to show quick previews so that I can choose whether to navigate to it or not. - https://phabricator.wikimedia.org/T94630#1198899 (10BGerstle-WMF) [18:15:12] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Add members to a collection using a search interface - https://phabricator.wikimedia.org/T90991#1198904 (10JKatzWMF) 5Open>3Resolved [18:15:43] 6Mobile-Web, 10MobileFrontend, 10Browser-Tests, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: Should be possible in browser tests to use images with meta data or without meta data - https://phabricator.wikimedia.org/T67274#1198908 (10Tgr) It's not clear to me what this task is about. As for Chunk... [18:15:53] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: As a user I want to get quick context about a link. A combination of text and image will help me learn. (Prototype 1) - https://phabricator.wikimedia.org/T95030#1198910 (10KLans_WMF) [18:17:30] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: EPIC: As a Mobile Apps Team, I would like to be alerted when something is going catastrophically wrong with the app in production, so we can fix it for ou... - https://phabricator.wikimedia.org/T95019#1198914 [18:17:40] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: As a user I want to get quick context about a link. A combination of text and image will help me learn. (Prototype 1) - https://phabricator.wikimedia.org/T95030#1198917 (10BGerstle-WMF) [18:17:42] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: EPIC: As a mobile reader, I would like links that I tap on to show quick previews so that I can choose whether to navigate to it or not. - https://phabricator.wikimedia.org/T94630#1198916 (10BGerstle-WMF) [18:17:44] 10Gather: Remove delete button from collection page and fix behavior so it does not send you back to collection when you click it. - https://phabricator.wikimedia.org/T95732#1198920 (10JKatzWMF) 3NEW [18:18:03] jdlrobso_, haven't heard back from you re prop=listmembership [18:18:07] is that what you need? [18:18:21] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Update localization script so we can move files in the project without breaking importing localized strings - https://phabricator.wikimedia.org/T95733#1198930 (10Fjalapeno) 3NEW [18:18:26] yurik: possibly i haven't had a chance to look at it closely. been wrapped up in other stuff [18:18:35] we are working around it in the meantime so it's not a top priority [18:19:53] jdlrobso_, it is already done, with extensive unit testing - all you need to do is generate=search & prop=listmembership & lsmid=### [18:20:20] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Analytics, 6Language-Engineering, and 4 others: there should be a comparison of clicks count on interlanguage links on different platforms - https://phabricator.wikimedia.org/T78351#1198952 (10Jdlrobson) [18:21:00] yurik: i mean.. i wrote a patch before your patch came in. i will look when i can. today i'm planning to do some experimenting [18:21:04] jdlrobso_, all pages that are part of a list will be marked as such. Please don't implement it via additional queries, as they would be very inefficient [18:21:28] jdlrobso_, my patch was in the same day you asked about it )) [18:22:20] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1198958 (10KLans_WMF) [18:22:26] 6Mobile-Web, 10MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1198960 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Sounds like there is no work to do on our side here. [18:22:51] 6Mobile-Web, 5Patch-For-Review: Display coordinates in mobile version - https://phabricator.wikimedia.org/T91481#1198966 (10KHammerstein) @bmansurov @jdlrobson I agree, lets keep them hidden as they are not mobile-friendly [18:24:09] 6Mobile-Web, 5Patch-For-Review: Deemphasise wikitext markup in editor - https://phabricator.wikimedia.org/T91796#1198980 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Done in alpha with CodeMirror installed. Let's iterate on this. [18:24:47] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1198990 (10KLans_WMF) [18:27:31] 6Mobile-Web, 10MobileFrontend: Provide a TOC on pages (devices) without JavaScript - https://phabricator.wikimedia.org/T55454#1199012 (10Jdlrobson) 5Open>3declined a:3Jdlrobson I worry the clutter created by this will do more harm than good. Something similar to this should fall out of T90867 so keep wat... [18:27:37] Deskana https://phabricator.wikimedia.org/T95736 [18:28:21] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-53-Android, 3Mobile-App-Sprint-55-iOS: As a user, I'd like lead sentences to be concise so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1199020 (10Deskana) Here's the code from Android: http... [18:28:33] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be concise so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1199022 (10KLans_WMF) [18:28:49] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-53-Android: As a user, I'd like lead sentences to be concise so I can get an overview of the topic I'm reading about. - https://phabricator.wikimedia.org/T91792#1199024 (10Deskana) And the bit that calls it: https://github.com/wikimedia/apps-an... [18:29:12] 6Mobile-Web, 10MobileFrontend: top of article messy on phones and inconsistent with tablet - https://phabricator.wikimedia.org/T73450#1199029 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Not sure what good this bug is doing without being actionable and seems like it's covered in various other tasks. [18:29:32] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7I18n: wgRevisionId is 0 for Flow pages - https://phabricator.wikimedia.org/T92296#1199035 (10Mattflaschen) Likely a duplicate of {T95581} / {T95595}, but we need to verify after the fix has propagated to production and the script has been run. [18:31:02] 6Mobile-Web, 10MobileFrontend: top of article messy on phones and inconsistent with tablet - https://phabricator.wikimedia.org/T73450#1199051 (10KHammerstein) @jdlrobson You're right this is out-of-date, covered by other tasks [18:34:04] bgerstle: dr0ptp4kt_cold coreyfloyd gah! sorry i missed review/estimation meeting - i was head's down and didn't notice the calendar alert :( [18:34:14] np [18:34:19] figured you were sick [18:34:30] JonKatz: https://phabricator.wikimedia.org/project/board/1185/ [18:34:39] mhurd dr0ptp4kt_cold: coreyfloyd if you have a chance, would appreciate code review on my outstanding patches [18:34:46] kristenlans thanks! [18:37:13] 6Mobile-Web: On MobileFrontend, wikipedia:en:Template:sfrac introduces an extra/incorrect slash - https://phabricator.wikimedia.org/T92472#1199068 (10Jdlrobson) 5Open>3stalled Needs feedback [18:41:54] (03PS1) 10Mhurd: Fix for extra whitespace around small images regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203382 [18:43:27] (03CR) 10Mhurd: [C: 031] gallery: re-add out of bounds assertion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) (owner: 10Bgerstle) [18:43:28] mhurd: coreyfloyd dr0ptp4kt_cold fyi i dropped my "Travis + Coveralls" email on the source code review options email thread if you care to take a look [18:44:13] bgerstle: will do [18:44:32] bgerstle: i fixed the image whitespace regression: https://gerrit.wikimedia.org/r/#/c/203382/ [18:44:52] 10Gather, 3Gather Sprint Enwiki: Infinite spinner when editing empty collections - https://phabricator.wikimedia.org/T95637#1199123 (10Jdlrobson) a:3Jdlrobson [18:45:44] mhurd, can you please add repro steps, and perhaps screenshots to the ticket? [18:46:05] i'm not really familiar with what the original fix was for and it's nto clear what the regression is [18:46:14] (03CR) 10Jdlrobson: [C: 032] Add description of Gather for Special:UserLogin [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203220 (https://phabricator.wikimedia.org/T94971) (owner: 10Florianschmidtwelzow) [18:46:22] bgerstle: ah i thought i did in the gerrit commit msg - the obama IPA speaker icon... [18:46:27] ah [18:46:39] bgerstle: should i add to phab as well? [18:46:45] would you mind adding that to teh phab ticket anyway? then etonkovidova can see and verify [18:46:50] bgerstle: ya [18:49:35] (03Merged) 10jenkins-bot: Add description of Gather for Special:UserLogin [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203220 (https://phabricator.wikimedia.org/T94971) (owner: 10Florianschmidtwelzow) [18:50:00] 10Gather, 3Gather Sprint Enwiki: Change messaging for blank collections - https://phabricator.wikimedia.org/T95740#1199148 (10Jdlrobson) 3NEW [18:51:33] bgerstle: i added a screenshot to the phab ticket [18:52:03] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Description text is not normalized in galleries. - https://phabricator.wikimedia.org/T93662#1199165 (10Etonkovidova) Verified with Wikipedia Alpha 4.1.1 (78) on iPad 2 mini(8.2) [18:52:25] 3Gather Sprint Enwiki: API: Inconsistnet response for empty collections - https://phabricator.wikimedia.org/T95741#1199168 (10Jdlrobson) 3NEW a:3Yurik [18:52:26] mhurd sorry, what's IPA again? the pronounciation thing? [18:52:39] bgerstle: ya [18:53:15] bgerstle: oops had "guild" instead of "guide" in the descrip [18:53:18] mhurd that picture is of latest master, with the regression? [18:53:24] bgerstle: yes [18:53:40] bgerstle: was that not clear? [18:53:49] i just don't remember exactly what it's supposed to look like [18:54:05] bgerstle: k. amending the descrip... one sec... [18:55:00] mhurd running from the commit before your original fix to see what it looked like before [18:55:12] (03PS1) 10Jdlrobson: Deal with inconsistent API response and infinite spinner [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203387 (https://phabricator.wikimedia.org/T95637) [18:56:01] mhurd: echoing sentiment here: original fix commit msg & phab ticket are awesome [18:56:09] (getting up to speed now) [18:56:20] probably would've been easier if one of the other reviewers jumped on this one [18:57:14] bgerstle: i updated the image in the phab ticket [18:57:34] got it [18:58:45] 3Gather Sprint Enwiki: API: Inconsistnet response for empty collections - https://phabricator.wikimedia.org/T95741#1199198 (10Yurik) [18:59:30] mholloway: Finishing up my interview now [19:00:55] (03PS2) 10Phuedx: Upsert WikiGrok questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203345 (https://phabricator.wikimedia.org/T94445) [19:01:04] bmansurov: ^ much better way [19:01:08] bgerstle: updated phab w one more screenshot showing correct layout [19:01:17] phuedx: cool [19:01:37] bmansurov: Database#replace is overridden in the MySQL and SQLite implementations to use the native REPLACE functionality [19:01:43] so it's super clean [19:01:50] that's great [19:01:52] needs a test though :) [19:02:24] i see [19:02:56] runnnninnnngg [19:03:24] (03PS2) 10Mhurd: import imgs into xcassets and fix wikipedia group path [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202928 (owner: 10Bgerstle) [19:03:34] Deskana: cool, no rush! [19:05:18] bgerstle: reviewing your image xcassets patch - running to lunch brb [19:05:33] k [19:05:53] 6Mobile-Web: Filename scraping for image viewer should support ugly URLs - https://phabricator.wikimedia.org/T86467#1199225 (10MaxSem) Yes, try it on a wiki without pretty URLs, i.e. default MW install without rewrites. [19:05:58] (03CR) 10Bgerstle: "some questions" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203382 (owner: 10Mhurd) [19:06:33] bgerstle: cool. Will check after foods :) [19:07:21] (03CR) 10Bgerstle: [C: 031] "if you tested it, looks OK to me. although, this script is a bit large and difficult to understand. maybe we can look into refactoring at " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 (owner: 10Fjalapeno) [19:07:49] (03CR) 10Bgerstle: "seems to fix the issue, just wondering about any potential performance implications" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203382 (owner: 10Mhurd) [19:09:50] (03CR) 10Fjalapeno: "@bgerstle - can you tell me what part(s) of the script are difficult to work through - I can add more comments, just not sure what would h" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 (owner: 10Fjalapeno) [19:10:12] (03PS6) 10Jdlrobson: Point at hamburger icon when a collection has been setup. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) [19:10:40] coreyfloyd: it's just a long, complicated script [19:10:50] (03CR) 10Jdlrobson: "It wasn't completely working. Basically I was only checking existing logged in users but not newly registered. Added additional check." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) (owner: 10Jdlrobson) [19:10:54] i don't know what more could be done, really [19:11:05] it's as good as an image processing bash script could probably be [19:12:12] 3Gather Sprint Enwiki: Adding/removing to watchlist when new user causes window to reopen - https://phabricator.wikimedia.org/T95744#1199244 (10Jdlrobson) 3NEW [19:12:36] 6Mobile-Web, 3Mobile-Web-Design: Generate mockups of how tags will look on mobile article pages - https://phabricator.wikimedia.org/T94736#1199254 (10JKatzWMF) note to engineers: we may need to move this higher up on the page [19:13:05] etonkovidova: are you there? [19:13:12] yes [19:13:14] 6Mobile-Web: (3) Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1199256 (10KLans_WMF) [19:13:24] (03PS4) 10Jdlrobson: When a user clicks on hamburger after adding to a collection show new icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203215 (https://phabricator.wikimedia.org/T95245) [19:13:33] bgerstle: something? [19:13:49] etonkovidova: hi, i was looking at https://phabricator.wikimedia.org/T91702 [19:14:00] 6Mobile-Web, 3Mobile-Web-Design: Generate mockups of how tags will look on mobile article pages - https://phabricator.wikimedia.org/T94736#1199258 (10JKatzWMF) a:5KHammerstein>3None [19:14:16] when i noticed that the two graph images don't appear in the gallery and also aren't tappable (to show in the gallery) [19:14:38] bgerstle: was ok with 76... let me see [19:14:43] 6Mobile-Web, 3Mobile-Web-Design: Generate mockups of how tags will look on mobile article pages - https://phabricator.wikimedia.org/T94736#1199259 (10JKatzWMF) 5Open>3Resolved a:3KHammerstein [19:15:26] etonkovidova: i might be looking at different images [19:15:50] bgerstle: looking... [19:16:10] bgerstle: were you in Read in Hebrew? [19:16:45] 6Mobile-Web, 3Mobile-Web-Design: A user is able to see wikidata descriptions in mobile web search results (in order to learn better select from results) - https://phabricator.wikimedia.org/T94713#1199265 (10KLans_WMF) [19:16:47] bgerstle: I see [19:17:25] bgerstle: yes, graphs do not show up in the gallery. But there should be another bug filed somewhere - loking for the bug now [19:18:56] 10Wikipedia-iOS-App: "Quick facts" in collapsed tables is always in English - https://phabricator.wikimedia.org/T95745#1199266 (10BGerstle-WMF) 3NEW [19:19:10] ok [19:19:17] even though it's a "png" [19:21:01] bgrestle: there is https://gist.github.com/anonymous/01645194256bf58f545b - but it's not exactly what I thought [19:21:35] ok [19:22:07] bgerstle: I remember that some graphs were not displayed in the gallery. Well, I will keep checking - if I do not find [19:22:16] bgerstle: then will file a bug [19:22:49] etonkovidova: yeah, a separate bug for graphs would be good [19:23:42] it's an image derived from a map.. [19:23:51] oh joy [19:23:53] 6Mobile-Web: Identify initial wikidata properties to be used for 'category' test - https://phabricator.wikimedia.org/T94714#1199283 (10JKatzWMF) Using Wikipedia Categories for greater granularity 8 of them Using: http://tools.wmflabs.org/glamtools/treeviews/ Name # of articles https://en.wikipedia.org/wiki/Ca... [19:24:21] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: Spike (4 hours): Investigate existing site speed metrics - https://phabricator.wikimedia.org/T95296#1199284 (10KLans_WMF) [19:24:45] 6Mobile-Web: (2) Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1199287 (10JKatzWMF) [19:24:47] 6Mobile-Web: Identify initial wikidata properties to be used for 'category' test - https://phabricator.wikimedia.org/T94714#1199286 (10JKatzWMF) 5Open>3Resolved [19:26:22] (03PS4) 10Fjalapeno: Fix for T94534 not working on iPads [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 [19:26:26] 6Mobile-Web: Spike (4 hours): Design site speed schemas - https://phabricator.wikimedia.org/T95297#1199295 (10KLans_WMF) [19:26:41] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: Spike (8 hours): Design site speed schemas - https://phabricator.wikimedia.org/T95297#1185964 (10KLans_WMF) [19:26:49] bgerstle: added some more comments, removed a few more redundant lines and rebased on master ^ [19:29:30] mhurd: no worries. we estimated a 3 for the page issues & disambiguation. [19:30:39] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Disable hockey update checking - https://phabricator.wikimedia.org/T95602#1195648 (10Fjalapeno) [19:31:03] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Create change log for CI builds - https://phabricator.wikimedia.org/T94423#1199325 (10Fjalapeno) a:3Fjalapeno [19:31:52] etonkovidova: can you ping me w/ a link to the ticket once you've created it? [19:32:42] bgerstle: sure. But I am thinking... those "images" are very special [19:32:46] coreyfloyd: would it be easy to bail out if identify/converts/etc. aren't installed? otherwise you get a ton of "command not found" errors [19:32:56] etonkovidova: yes, but they are images :-) [19:32:59] a good image gallery shouldn't care [19:33:16] users will be confused when they're not shown, or when trying to see a bigger version, nothing happens [19:33:30] bgerstle: they are not displayed in mediaview and they cannot be edited in VE.. hm [19:33:53] etonkovidova: don't know about mediaview and dont think VE pertains to this [19:34:09] as a user, when i tap on "an image" i should be able to see it in the gallery [19:34:17] if i was confused when it didn't display, i'm sure users will be [19:34:18] bgerstle: agree [19:34:55] etonkovidova: Deskana it would be nice to know what our users are trying (and failing) to tap [19:35:03] 6Mobile-Web: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1199334 (10KLans_WMF) [19:35:07] would it be worthwhile adding an EL message for something like this? [19:35:23] although, the fix is probably straightforward enough it doesn't need EL [19:35:26] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1171366 (10KLans_WMF) [19:35:29] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1199336 (10JKatzWMF) using magnus's tool we can get depth (include items in subcategories). Let's do that!! [19:36:10] bgrestle: I was just comparing with other types of "images" - like imagemap etc [19:36:16] right [19:36:24] bgerstle: I image you could add a check at the beginning of the file: [19:36:25] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1199339 (10JKatzWMF) [19:36:26] if ! which identify > /dev/null; then [19:36:31] bgerstle: ^ [19:36:31] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1199340 (10KLans_WMF) [19:36:42] you want to test it out? [19:36:44] coreyfloyd: yeah, i'm doing something similar in the makefile [19:36:48] yeah, sure [19:36:52] that can be a follow-on though [19:36:57] 10Gather, 3Gather Sprint F, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1199345 (10phuedx) [19:36:57] i only noticed when doing travis stuff [19:36:58] 6Mobile-Web: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1199344 (10phuedx) [19:37:02] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1199346 (10KLans_WMF) [19:37:28] coreyfloyd: i'm just going through the script in vim now, because gerrit is awful [19:37:37] lol [19:37:48] bgerstle: mhurd dr0ptp4kt_cold need to break for lunch [19:37:59] k [19:38:41] [19:38:41] script [19:38:41] [19:38:45] bgerstle: it's "The EasyTimeline extension produces an embedded image from wikitext.." [19:39:03] bgrestle: https://www.mediawiki.org/wiki/Extension:EasyTimeline/syntax [19:39:11] should we accommodate it? [19:40:13] bgerstle: I mean, the Image Gallery should include ? [19:40:45] etonkovidova: well, whether or not we accommodate it is ultimately a question for Deskana [19:40:48] but i figured we should [19:41:01] it results in an tag [19:41:05] and it "looks" like an image [19:41:35] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1199368 (10KLans_WMF) [19:41:44] bgerstle: ok then. I am filing the bug and then let you know the number... [19:41:50] k [19:41:50] 6Mobile-Web: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1190681 (10KLans_WMF) [19:42:46] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1199377 (10phuedx) [19:43:20] coreyfloyd: bgerstle mhurd me too. hot chili [19:45:04] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: Initial banner image should be delivered as part of the initial response - https://phabricator.wikimedia.org/T90698#1199396 (10KLans_WMF) [19:46:21] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: (3) Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1199419 (10KLans_WMF) [19:47:21] 6Mobile-Web, 6operations, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out the simplest possible way to apply tags to a large group of articles on en wikipedia - https://phabricator.wikimedia.org/T94755#1199426 (10phuedx) This might even be a NOP as we're planning on using categories initially. [19:49:16] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1199441 (10KLans_WMF) [19:50:46] 6Mobile-Web: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1199446 (10JKatzWMF) [19:51:05] dr0ptp4kt_cold: good, clear those sinuses, man! [19:51:12] 10Wikipedia-iOS-App: Graphical timelines should be displayed in Image Galery - https://phabricator.wikimedia.org/T95748#1199447 (10Etonkovidova) 3NEW [19:51:24] bgerstle: batcave? [19:51:31] sure [19:51:50] bgerstle: https://phabricator.wikimedia.org/T95748 "Graphical timelines should be displayed in Image Galery" [19:52:03] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________, 3Mobile-Web-Design: A user is able to see wikidata descriptions in mobile web search results (in order to learn better select from results) - https://phabricator.wikimedia.org/T94713#1199456 (10KLans_WMF) [19:52:16] thanks etonkovidova [19:52:19] 10Wikipedia-iOS-App: Source code review options - https://phabricator.wikimedia.org/T95749#1199458 (10dr0ptp4kt) 3NEW [19:52:55] 10Wikipedia-iOS-App, 3App-Process-Improvement: Source code review options - https://phabricator.wikimedia.org/T95749#1199467 (10dr0ptp4kt) [19:53:14] 6Mobile-Web: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1199470 (10JKatzWMF) [19:54:11] 6Mobile-Web, 10WikiGrok, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: WikiGrok must not load when there are no suggestions. - https://phabricator.wikimedia.org/T95722#1199473 (10KLans_WMF) [19:54:27] 6Mobile-Web, 10WikiGrok, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: WikiGrok save error - https://phabricator.wikimedia.org/T95721#1199475 (10KLans_WMF) [19:55:04] 6Mobile-Web, 6operations, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: Spike: figure out the simplest possible way to apply tags to a large group of articles on en wikipedia - https://phabricator.wikimedia.org/T94755#1199481 (10JKatzWMF) 5Open>3Resolved [19:55:06] 6Mobile-Web: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1171871 (10JKatzWMF) [20:00:39] 10Gather, 3Gather Sprint Enwiki, 3Mobile-Web-Design: Desktop beta feature for Gather needs illustration - https://phabricator.wikimedia.org/T95632#1199535 (10Jdlrobson) [20:03:58] bgerstle: mhurd code review time! [20:04:10] whoops! brt [20:09:28] okie poke [20:09:30] night folks [20:09:39] see y'all monday [20:09:47] have lovely weekends [20:09:54] drink delicious coffee and report back [20:10:00] s/back/backsies/ [20:12:12] (03PS11) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [20:12:14] (03PS1) 10Jdlrobson: Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 [20:14:08] 6Mobile-Web: On MobileFrontend, wikipedia:en:Template:sfrac introduces an extra/incorrect slash - https://phabricator.wikimedia.org/T92472#1199567 (10Thnidu) Indeed, I don't see the problem either now. I don't know what changed. https://en.wikipedia.org/wiki/Special:History/Template:Sfrac shows that the last t... [20:14:35] (03PS12) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [20:14:37] (03PS1) 10Jdlrobson: Show refresh icon in alpha for Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203458 (https://phabricator.wikimedia.org/T85578) [20:17:56] 10Wikipedia-iOS-App: [Regression 4.1.1] a user gets kicked out of the apps from Image gallery - https://phabricator.wikimedia.org/T95352#1199570 (10Etonkovidova) Re-checked with 4.1.1(78) - the issue is resolved. [20:18:08] 10Wikipedia-iOS-App: [Regression 4.1.1] a user gets kicked out of the apps from Image gallery - https://phabricator.wikimedia.org/T95352#1199571 (10Etonkovidova) 5Open>3Resolved [20:18:29] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 (owner: 10Jdlrobson) [20:18:37] (03PS13) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [20:18:39] (03PS2) 10Jdlrobson: Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 [20:22:43] (03PS14) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [20:23:46] (03CR) 10Jdlrobson: "If this speeds up code review I can split these all out at some point.." (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [20:23:50] 10Gather, 3Gather Sprint Enwiki: API: Incorrect result for listpages module - https://phabricator.wikimedia.org/T94124#1199585 (10rmoen) a:3rmoen [20:25:18] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 (owner: 10Jdlrobson) [20:25:36] 6Mobile-Web: On MobileFrontend, wikipedia:en:Template:sfrac introduces an extra/incorrect slash - https://phabricator.wikimedia.org/T92472#1199601 (10Jdlrobson) 5stalled>3Resolved a:3Jdlrobson Please reopen this if the problem comes up again! [20:26:14] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [20:26:47] 6Mobile-Web, 10MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1199613 (10csteipp) >>! In T88860#1198960, @Jdlrobson wrote: > Sounds like there is no work to do on our side here. @Jdlrobson, is this work... [20:30:49] (03CR) 10Bmansurov: [C: 04-1] Show refresh icon in alpha for Nearby (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203458 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [20:31:39] 6Mobile-Web, 10MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1199617 (10Jdlrobson) 5declined>3Open Sorry I binge bug triaged and yes you're right nope.. still not working and I missed your last mess... [20:33:00] (03PS1) 10Robmoen: Fix jscs coding style issues [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203460 [20:33:33] (03PS2) 10Jdlrobson: Show refresh icon in alpha for Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203458 (https://phabricator.wikimedia.org/T85578) [20:39:15] (03CR) 10Bmansurov: [C: 04-1] Add support to deprecate a module (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [20:39:32] 6Mobile-Web, 10MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1199643 (10csteipp) No worries! CentralAuthHooks::onBeforePageDisplay() tries in two ways to auto-login anonymous users the first time they... [20:41:37] (03PS1) 10Robmoen: Return listpages results in query object [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 [20:44:20] (03CR) 10Jdlrobson: [C: 04-1] "See https://gerrit.wikimedia.org/r/203190" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203460 (owner: 10Robmoen) [20:45:08] (03CR) 10Jdlrobson: Fix jscs coding style issues (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203460 (owner: 10Robmoen) [20:48:27] 6Mobile-Web, 10MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1199672 (10Jdlrobson) There's your bug then - ext.centralauth.centralautologin needs to set 'targets' => array( 'desktop', 'mobile' ) on its... [20:48:30] (03CR) 10Yurik: [C: 04-1] Return listpages results in query object (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 (owner: 10Robmoen) [20:48:47] 6Mobile-Web, 10MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1199673 (10Jdlrobson) (which extension provides this module - that's where the bug needs to be fixed?) [20:50:04] 10Gather: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1199675 (10MSyed) @JKatzWMF @Jhernandez We can try it. It might still look weird on smaller screens. But lets try it. [20:53:39] (03CR) 10Bmansurov: [C: 032] Show refresh icon in alpha for Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203458 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [21:05:19] (03CR) 10Bgerstle: [C: 031] "my comments are more related to the original fix, so +1'ing since this fixes the regression." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203382 (owner: 10Mhurd) [21:05:19] mhurd can you file a follow-up on performance regression testing related to that card? ^ [21:05:20] bgerstle: ya [21:05:20] and make sure etonkovidova knows about possible issues w/ rotation [21:05:21] dr0ptp4kt_cold: coreyfloyd would one of you plz have a look at mhurd's patch and merge if possible? [21:05:21] bgerstle: [21:05:21] sure [21:05:21] lol [21:05:22] coreyfloyd: [21:05:22] coreyfloyd: [21:05:22] coreyfloyd: [21:05:22] haha [21:05:22] mhurd i'm reviewing ^ that guy's patch. then i'll look at my xcassets thing [21:05:23] bgerstle: sounds good [21:05:23] coreyfloyd: the issue with rotation? [21:05:24] etonkovidova: I’m looking at the fix for this: https://phabricator.wikimedia.org/T95738 [21:05:24] 6Mobile-Web, 5Patch-For-Review: No refresh icon on Special:Nearby in alpha - https://phabricator.wikimedia.org/T85578#1199678 (10bmansurov) 5Open>3Resolved a:3bmansurov [21:05:24] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Description text is not normalized in galleries. - https://phabricator.wikimedia.org/T93662#1199680 (10Vibhabamba) The normalization stuff looks fixed. Signed off by Design. [21:05:29] (03Merged) 10jenkins-bot: Show refresh icon in alpha for Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203458 (https://phabricator.wikimedia.org/T85578) (owner: 10Jdlrobson) [21:05:32] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: 4.0.6.3 Image Gallery - some images displayed in low resolution - https://phabricator.wikimedia.org/T91124#1199686 (10Vibhabamba) Nice work @BGerstle-WMF Verified reported instances only. Signed off by design. [21:05:36] (03CR) 10Fjalapeno: [C: 031] Fix for extra whitespace around small images regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203382 (owner: 10Mhurd) [21:05:37] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Saved pages can show Wikidata descriptions. - https://phabricator.wikimedia.org/T93170#1199689 (10Vibhabamba) Signedoff by Design. [21:05:40] (03CR) 10Fjalapeno: [C: 032] Fix for extra whitespace around small images regression. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203382 (owner: 10Mhurd) [21:05:41] 10Wikipedia-iOS-App: Graphical timelines should be displayed in Image Galery - https://phabricator.wikimedia.org/T95748#1199697 (10BGerstle-WMF) [21:06:41] (03CR) 10Bmansurov: [C: 031] "The commit message may need an update to reflect the change, but the patch is working for me." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203345 (https://phabricator.wikimedia.org/T94445) (owner: 10Phuedx) [21:06:53] (03CR) 10Fjalapeno: [C: 04-1] gallery: re-add out of bounds assertion (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) (owner: 10Bgerstle) [21:08:27] (03CR) 10Bgerstle: "response to coreyfloyd's comments" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) (owner: 10Bgerstle) [21:08:36] coreyfloyd: I see - ok [21:08:56] coreyfloyd: "The real problem causing T95601 was that the call to [21:08:56] "fetchBatchContainingIndex:withNthNeighbor:" was attempting to fetch out [21:08:56] of bounds." [21:09:04] (03CR) 10Fjalapeno: "To be clear - if this is to prevent programmer error - it sounds like we missed something - this shouldn't be asserting so frequently - w" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) (owner: 10Bgerstle) [21:10:07] (03PS2) 10Bgerstle: gallery: re-add out of bounds assertion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) [21:10:15] coreyfloyd: ^ added more info in commit msg [21:10:35] (03PS3) 10Bgerstle: gallery: re-add out of bounds assertion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) [21:10:42] bgerstle: thanks… looking [21:11:25] (03CR) 10Bgerstle: "added comment for test that verifies the main fix" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) (owner: 10Bgerstle) [21:11:43] (03CR) 10Fjalapeno: [C: 031] "Got it - sounds good - lets get QA to verify." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) (owner: 10Bgerstle) [21:11:47] (03CR) 10Fjalapeno: [C: 032] gallery: re-add out of bounds assertion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203339 (https://phabricator.wikimedia.org/T95601) (owner: 10Bgerstle) [21:12:49] (03CR) 10Fjalapeno: [C: 031] "nuf sed" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202928 (owner: 10Bgerstle) [21:13:25] mhurd: can you check out my patch when you get a chance? [21:14:39] coreyfloyd: ya! just a sec... [21:14:40] bgerstle: mhurd if we can get this and brian’s patch merged then we can cut a last build to etonkovidova [21:14:40] mhurd: also brians [21:14:40] coreyfloyd: which one of yours? [21:14:41] the process images? [21:15:02] bgerstle: yeah [21:15:20] bgerstle: oh did you try that fix? [21:15:34] If you did I can add it [21:17:45] coreyfloyd: no, been preoccupied w/ other stuff [21:17:50] i can do it in a minute [21:19:56] (03PS5) 10Fjalapeno: Fix for T94534 not working on iPads [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 [21:19:59] bgerstle: just run it ^ [21:20:21] (03PS1) 10Mhurd: Quick follow-on optimization to image scroll transform. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203465 [21:20:27] bgerstle: coreyfloyd dr0ptp4kt_cold ^ [21:21:07] hm, saving a page in VE doesn't update it w/ new content [21:21:25] not sure why i would expect that to work, it's such an edge case [21:21:43] mhurd: coreyfloyd dr0ptp4kt_cold i updated our "engineering review" page w/ minutes from today's meeting [21:21:45] https://www.mediawiki.org/w/index.php?title=Wikimedia_Apps/Team/iOS/Engineering_Review [21:22:05] bgerstle: lol [21:22:47] (03PS6) 10Mhurd: Fix for T94534 not working on iPads [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 (owner: 10Fjalapeno) [21:24:03] coreyfloyd: just did a clean build, checking icons.. [21:25:36] 10Gather: user who flags collection sees confirmation overlay - https://phabricator.wikimedia.org/T95767#1199800 (10JKatzWMF) 3NEW [21:25:59] 10Gather: user who flags collection sees confirmation overlay - https://phabricator.wikimedia.org/T95767#1199807 (10JKatzWMF) [21:29:16] 10Gather: A user who has flagged an article cannot flag the same collection so that they do not have disproportionate voice. - https://phabricator.wikimedia.org/T95768#1199810 (10JKatzWMF) 3NEW [21:29:30] 10Gather: A user who has flagged a collection cannot flag the same collection so that they do not have disproportionate voice. - https://phabricator.wikimedia.org/T95768#1199817 (10JKatzWMF) [21:29:33] mhurd: dr0ptp4kt_cold oh forgot about the build server stuff… meant to bring up during code review - you guys want to discus? [21:29:47] cc bgerstle but you are more familiar with it already… [21:31:33] coreyfloyd: i'm actually not seeing any images get processed for some reason [21:32:03] LOL [21:32:14] sounds like it isn’t working then… [21:32:18] coreyfloyd: i don't see the iPad get the overlay icons w your patch. it does on phone sim though... [21:32:20] 10Gather: If an article has been flagged 2x, it is listed in a special feed for administrators to monitor - https://phabricator.wikimedia.org/T95769#1199826 (10JKatzWMF) 3NEW [21:32:27] mhurd try w/ a clean build [21:32:34] bgerstle: k [21:32:37] coreyfloyd: i'm not seeing on iPhone 6 sim or the app bundle [21:32:45] (looking at all the AppIcon files" [21:33:51] 10Gather: A user monitoring the "flagged" feed can"unflag" it, so that it is removed from the queue and others do not have to review it. - https://phabricator.wikimedia.org/T95770#1199833 (10JKatzWMF) 3NEW [21:34:14] you know what [21:34:25] coreyfloyd: my executables don't live in /usr/local/bin :-( [21:34:38] bgerstle: coreyfloyd even on clean build no overlay icons w iPad :( [21:35:07] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: 4.0.7.8 - NSURLErrorDomain error code -999 with the first login - https://phabricator.wikimedia.org/T93789#1199848 (10dr0ptp4kt) a:3dr0ptp4kt [21:35:40] mhurd: yeah the fix i made for brian broke it [21:35:45] and didn’t fix it [21:36:06] coreyfloyd: how rude! ;) [21:36:12] coreyfloyd: i don't think mine would've even worked anyway [21:36:23] bgerstle: i guess thats ok - if you aren’t installing homebrew tools at the default location I guess no icons for you [21:36:26] 10Wikipedia-iOS-App: Image Gallery: Description text is cut off - https://phabricator.wikimedia.org/T95771#1199849 (10Etonkovidova) 3NEW [21:36:30] get it together hippies! [21:37:35] 10Gather: Edit page design tweaks - https://phabricator.wikimedia.org/T95772#1199863 (10JKatzWMF) 3NEW a:3MSyed [21:39:57] coreyfloyd: bgerstle does https://gerrit.wikimedia.org/r/#/c/202909/ need amendment then? [21:40:02] coreyfloyd: i've modified your script a little bit so it echoes an error when something isn't found [21:40:04] so at least you get feedback [21:40:09] shall i amend? [21:40:32] hrmph we shouldn't need to RELY on the PATH at all... but friggin' xcode changes it [21:40:42] the other option is to not run it from w/in the build script [21:41:00] (03PS7) 10Fjalapeno: Fix for T94534 not working on iPads [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 [21:41:33] bgerstle: i just amended to fix the check [21:41:40] what about identify? [21:41:41] mhurd: that should work for you again now [21:41:48] coreyfloyd: k checking... [21:42:00] bgerstle: convert and identify are both imagemagick [21:42:04] oh [21:43:00] bgerstle: it should be fine now and fail gracefully for you [21:43:24] bgerstle: I’m actually thinking about rewriting it as a fastlane action as well [21:44:08] just not today [21:44:36] yeah [21:46:10] coreyfloyd: so i symlinked imagemagick stuff into /usr/local/bin *shudder* [21:46:14] and now it seems to work [21:46:16] i hope you're happy [21:46:43] bgerstle: so is the issue that you don’t use hombrew or that you have it install to another location? [21:47:01] bgerstle: I’m never happy [21:47:29] coreyfloyd: you should see someone about that [21:47:49] bgerstle: lol [21:47:50] coreyfloyd: i see overlays on 57, 60, 72, & 76 (at various @Nx) [21:48:37] bgerstle: i do - Captain Morgan and Samuel Adams [21:48:47] neither are doctors though… [21:48:51] lol [21:49:00] bgerstle: coreyfloyd seems to work now [21:49:13] mo Horchata Rum mo problems [21:49:29] works on iPad & iPhone sim [21:49:33] (03CR) 10Bgerstle: [C: 031] "-1 for relying on /usr/local/bin... but +1 for working" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 (owner: 10Fjalapeno) [21:49:35] bgerstle: did you see my question? curios where your tools live… [21:49:42] hahah [21:49:48] coreyfloyd: you don't wanna know :-P [21:50:01] bgerstle: coreyfloyd mergeit? [21:50:03] (03CR) 10Fjalapeno: "bgerstle wouldn't that be a 0?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 (owner: 10Fjalapeno) [21:50:08] mhurd: yep [21:50:11] +0 [21:50:14] coreyfloyd: don't push your luck lol [21:50:25] coreyfloyd: https://github.com/btgerst/my-boxen [21:50:29] (03PS8) 10Mhurd: Fix for T94534 not working on iPads [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 (owner: 10Fjalapeno) [21:50:37] (03CR) 10Mhurd: [C: 032] Fix for T94534 not working on iPads [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202909 (owner: 10Fjalapeno) [21:50:50] it's a fork of GitHub's tool called Boxen [21:50:56] which puppetizes OSX setups [21:51:07] bgerstle: do you think we could do it in fastlane without relying on an image tool dependency? [21:51:13] bgerstle: coreyfloyd dr0ptp4kt_cold quick cr of https://gerrit.wikimedia.org/r/#/c/203465/ ? [21:51:20] bgerstle: oh - yeah - I’ve seen that stuff [21:51:26] coreyfloyd: that would be the best way, probably [21:51:34] since in FastLane you know the config per lane [21:51:43] and also, ruby :-P [21:52:39] Core Feature for Code Review Tool #123457245: HORIZONTAL SCROLLING [21:52:48] hahah [21:52:50] * bgerstle fumes endlessly about gerrit [21:53:51] (03CR) 10Fjalapeno: [C: 031] Quick follow-on optimization to image scroll transform. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203465 (owner: 10Mhurd) [21:54:01] joy [21:54:36] (03CR) 10Bgerstle: [C: 031] Quick follow-on optimization to image scroll transform. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203465 (owner: 10Mhurd) [21:54:55] (03CR) 10Fjalapeno: [C: 032] Quick follow-on optimization to image scroll transform. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203465 (owner: 10Mhurd) [21:55:16] mhurd i just noticed.. bundle.js doesn't really look "browserified" [21:55:58] i take that back [21:55:59] bgerstle: look at the last line - it seems to be... [21:56:10] the first line has the require compiled in too, i see it now [21:56:18] i thought we were uglifying our JS too [21:56:24] bgerstle: good point on the fastlane thing… ima looking into image frameworks… [21:56:47] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Lack of continuity between image captions and gallery descriptions in Android/IOS App - https://phabricator.wikimedia.org/T94495#1199890 (10Vibhabamba) Deskana, can we consider this for the next sprint? [21:57:35] bgerstle: https://www.ruby-toolbox.com/categories/image_processing [21:57:45] looks like a pure ruby solution is available [21:58:46] 6pm - time to transfer the workstation to the couch [21:59:08] sweet [21:59:16] mhurd was there an issue w/ my xcassets thingy? [21:59:22] i just pulled it down and am about to rebase [21:59:24] but it looks ok [21:59:29] i'm also going to head out very shortly [21:59:51] bgerstle: if you view it in Xcode you don't see files change? [21:59:59] bgerstle: re-checking... [22:00:26] mhurd what do you mean? [22:00:49] (03CR) 10BearND: "A few more comments inline. How are you testing the code?" (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway) [22:01:41] bgerstle: not seeing it happen anymore... weird! [22:01:54] coreyfloyd: here ya go http://www.rubydoc.info/github/wvanbergen/chunky_png/ChunkyPNG/Chunk/Text [22:02:11] (03CR) 10Mhurd: [C: 032] import imgs into xcassets and fix wikipedia group path [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/202928 (owner: 10Bgerstle) [22:02:15] or wait, might not be what i thought it was [22:02:26] bearND: sweet. to answer your questions about testing, i've been changing a couple of lines in Site.java and WikimediaApp.java to make the app hit httpstat.us/503 instead of our API [22:03:45] bearND: then i turn wifi/mobile networks off to ensure the "no network" message appears instead, as appropriate [22:04:00] alrighty that's all my patches [22:04:05] coreyfloyd mhurd need anything before i go? [22:04:19] bgerstle: no have a good weekend! [22:04:35] thanks you too! [22:04:38] I'm good. Later [22:08:32] (03PS1) 10Jdlrobson: WIP: Rewrite VisualEditorOverlay as a ProcessDialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203478 (https://phabricator.wikimedia.org/T88559) [22:08:42] bon weekend [22:11:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: Rewrite VisualEditorOverlay as a ProcessDialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203478 (https://phabricator.wikimedia.org/T88559) (owner: 10Jdlrobson) [22:11:49] etonkovidova: are you able to reproduce https://phabricator.wikimedia.org/T93789 ? [22:12:08] dr0ptp4kt_cold: looking... [22:13:04] dr0ptp4kt_cold: last time I saw it - was before alpha 78 build. Let me check. [22:15:20] 6Mobile-Web, 6Collaboration-Team, 10Continuous-Integration, 10Flow, and 2 others: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1199920 (10hashar) We have some utilities to do so. Namely Zuul cloner which let you clone mu... [22:16:18] 6Mobile-Web, 6Collaboration-Team, 10Continuous-Integration, 10Flow, and 2 others: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1199926 (10hashar) [22:17:23] 6Mobile-Web, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.Dialog - https://phabricator.wikimedia.org/T88559#1199930 (10Jdlrobson) @bmansurov, @esanders @matmarex, I spent a few hours on this today. There's a long way to go, but I learnt a lot about some subtle differences between Mobile... [22:18:44] (03CR) 10Jdlrobson: "Long way to go, but early feedback and help working out how to do the header would be much appreciated." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203478 (https://phabricator.wikimedia.org/T88559) (owner: 10Jdlrobson) [22:19:27] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: 4.0.7.8 - NSURLErrorDomain error code -999 with the first login - https://phabricator.wikimedia.org/T93789#1199935 (10Etonkovidova) The issue is still present in 4.1.1(78). [22:27:39] (03PS6) 10Dbrant: [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (https://phabricator.wikimedia.org/T95030) [22:31:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (https://phabricator.wikimedia.org/T95030) (owner: 10Dbrant) [22:40:02] (03PS1) 10Dbrant: Fix checkstyle (curly braces) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203480 [22:41:31] 10Gather, 3Gather Sprint F: Add a flag button - https://phabricator.wikimedia.org/T94871#1199992 (10Jdlrobson) [22:42:20] dbrant: hmm, that's weird that checkstyle complains about this now. Why did it not happen earlier? [22:42:40] bearND: no idea :( not the first time this has happened, though [22:43:29] dbrant: ok, i assume you want me to merge this [22:44:12] bearND: please! :) [22:44:35] (03CR) 10BearND: [C: 032] Fix checkstyle (curly braces) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203480 (owner: 10Dbrant) [22:44:44] that was easy [22:44:53] (03Merged) 10jenkins-bot: Fix checkstyle (curly braces) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203480 (owner: 10Dbrant) [22:45:06] 10Gather: This is a placeholder: Flag a collection - https://phabricator.wikimedia.org/T90988#1199994 (10JKatzWMF) [22:47:12] (03PS5) 10Mholloway: Display appropriate error message to user; create NetworkUtils class. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) [22:49:04] (03PS7) 10Dbrant: [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (https://phabricator.wikimedia.org/T95030) [22:49:07] thx! I see Alpha 4.1.1(79) :) [22:49:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (https://phabricator.wikimedia.org/T95030) (owner: 10Dbrant) [22:49:52] 10Gather: Make Special:GatherList responsive - https://phabricator.wikimedia.org/T93389#1199998 (10Jdlrobson) [22:49:54] 10Gather: Support mobile friendly view for Special:Gatherlists - https://phabricator.wikimedia.org/T95676#1199997 (10Jdlrobson) [22:51:24] (03PS8) 10Dbrant: [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (https://phabricator.wikimedia.org/T95030) [22:52:04] 10Gather: if user adds collection from edit screen then returns to the collection, the colleciton should reflect changes (without reload) - https://phabricator.wikimedia.org/T95775#1200005 (10JKatzWMF) 3NEW [22:54:33] 10Gather: Special:Gather page has no title - https://phabricator.wikimedia.org/T95640#1200014 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson this was a scap issue and is no longer a problem. [22:55:09] 10Gather: when user is on collection edit screen, there is a back button instead of an X in the top-left corner - https://phabricator.wikimedia.org/T95776#1200018 (10JKatzWMF) 3NEW [22:56:07] etonkovidova: i think i figured it out! [23:00:23] (03CR) 10Yurik: "Also, I'm pretty sure this change will break the tests - make sure you run them on your machine" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 (owner: 10Robmoen) [23:00:27] etonkovidova: the trick is to enter a valid username and password, then tap the Done button once, then about a eight tenths of a second later tap it again. i think this should be relatively simple to fix [23:01:40] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: 4.0.7.8 - NSURLErrorDomain error code -999 with the first login - https://phabricator.wikimedia.org/T93789#1200034 (10dr0ptp4kt) It appears this surfaces when a valid username and password are entered, then the user taps Done once, then a little under a second la... [23:02:10] dr0ptp4kt_cold: I think you're right -after all, the message is about two requests submitted - and the first one not cancelled or something... [23:02:39] dr0ptp4kt_cold: it's harmless - but may look alarming to a user :) [23:04:34] etonkovidova: forgot to tell you that we cut a build with todays fixes so you can look through it [23:04:56] coreyfloyd: I saw it - thx! [23:06:50] 10Gather, 3Gather Sprint F: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1200042 (10Jdlrobson) [23:08:25] 10Gather, 3Gather Sprint F: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1200018 (10Jdlrobson) [23:13:05] 3Gather Sprint F: Tweak the search in EditorOverlay behaviour - https://phabricator.wikimedia.org/T95778#1200056 (10Jdlrobson) 3NEW [23:14:30] 10Gather: Gather "+" icon doesn't show up in mobile menu except on Special:Gather - https://phabricator.wikimedia.org/T95634#1200077 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson works for me in beta and alpha. There were some scap issues last night so I suspect this is what went wrong (fixed this morning). [23:30:00] 10Gather: Private collection is disabled? - https://phabricator.wikimedia.org/T95630#1200124 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Yup, by design right now. The idea for now is to provide another indication that your collection is public. See T93391 [23:30:33] (03PS1) 10Dr0ptp4kt: Disallow double tap on Done login button [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203490 [23:30:40] 10Gather, 3Gather Sprint F: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1200130 (10Jdlrobson) [23:31:39] mhurd: would you please review https://gerrit.wikimedia.org/r/203490 ? [23:33:19] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: 4.0.7.8 - NSURLErrorDomain error code -999 with the first login - https://phabricator.wikimedia.org/T93789#1146165 (10dr0ptp4kt) https://gerrit.wikimedia.org/r/#/c/203490 submitted for code review [23:33:34] dr0ptp4kt_cold: if you close the login overlay does it get stuck in disabled mode? [23:37:26] (03CR) 10BearND: [C: 04-1] Display appropriate error message to user; create NetworkUtils class. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202767 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway) [23:38:01] 10Gather, 3Gather Sprint F: Tweak the search in EditorOverlay behaviour - https://phabricator.wikimedia.org/T95778#1200150 (10Jdlrobson) [23:38:05] 10Gather, 3Gather Sprint F: Tweak the search in EditorOverlay behaviour - https://phabricator.wikimedia.org/T95778#1200056 (10Jdlrobson) [23:39:10] 10Gather, 3Gather Sprint F: Do not show a "public" icon on Gather collections - https://phabricator.wikimedia.org/T95639#1200157 (10Jdlrobson) [23:39:16] 10Gather, 3Gather Sprint F: Do not show a "public" icon on Gather collections - https://phabricator.wikimedia.org/T95639#1196462 (10Jdlrobson) [23:40:23] 10Gather: if user adds collection from edit screen then returns to the collection, the colleciton should reflect changes (without reload) - https://phabricator.wikimedia.org/T95775#1200163 (10Jdlrobson) [23:40:25] 10Gather, 3Gather Sprint F: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1200018 (10Jdlrobson) [23:40:56] mhurd: not that i could tell. i tried a few permutations. you able to find any way to trick it to inactivate the button 'permanently'? [23:42:09] mhurd: how scared should i be to upgrade my ide? very or just mostly? [23:42:21] 10Gather: API: Allow sorting of a users collections by last modified - https://phabricator.wikimedia.org/T94762#1200167 (10Jdlrobson) [23:42:22] 10Gather: Order collections on creation overlay by last edited - https://phabricator.wikimedia.org/T95600#1200166 (10Jdlrobson) [23:42:25] dr0ptp4kt_cold: mostly :) [23:42:32] dr0ptp4kt_cold: so far so good here [23:42:38] mhurd: ok, i'm gonna do that [23:42:59] mhurd: i gotta restart, apparently [23:43:07] mhurd: i'll be bach [23:43:20] dr0ptp4kt_cold: k [23:44:34] 10Gather: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1200176 (10JKatzWMF) 3NEW [23:44:39] 10Gather: Collections should be sorted by modified time not alphabetically. - https://phabricator.wikimedia.org/T95786#1200184 (10Jdlrobson) 3NEW [23:45:35] 10Gather: API: support page reordering - https://phabricator.wikimedia.org/T94117#1200194 (10Jdlrobson) [23:45:36] 10Gather: Collections should be sorted by modified time not alphabetically. - https://phabricator.wikimedia.org/T95786#1200193 (10Jdlrobson) [23:45:49] 10Gather: API: support page reordering - https://phabricator.wikimedia.org/T94117#1155585 (10Jdlrobson) [23:45:51] 10Gather: UI for reordering collections - https://phabricator.wikimedia.org/T94255#1200195 (10Jdlrobson) [23:46:32] 10Gather: Placeholder: A user is able to reorder the collections in their list from the edit screen - https://phabricator.wikimedia.org/T93164#1200202 (10Jdlrobson) [23:46:34] 10Gather: UI for reordering collections - https://phabricator.wikimedia.org/T94255#1158249 (10Jdlrobson) [23:52:07] (03PS1) 10Dbrant: [WIP] Link previews (prototype 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) [23:52:45] 10Gather, 3Gather Sprint Enwiki: Change messaging for blank collections - https://phabricator.wikimedia.org/T95740#1200213 (10Jdlrobson) [23:52:57] 10Gather, 3Gather Sprint F: Change messaging for blank collections - https://phabricator.wikimedia.org/T95740#1199148 (10Jdlrobson) [23:53:51] 10Gather, 3Gather Sprint F: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1200220 (10Jdlrobson) a:3JKatzWMF Jon to provide mock and url. [23:53:59] 10Gather, 3Gather Sprint F: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1200222 (10Jdlrobson) [23:54:25] 10Gather, 3Gather Sprint F: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1200224 (10JKatzWMF) see screenshot {F111188} [23:55:16] 10Gather, 3Gather Sprint F: Bug: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1200226 (10Jdlrobson) [23:56:21] (03PS1) 10Mhurd: Fix for side to side scrolling of wide images with div overlays. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 [23:56:27] 10Gather, 3Gather Sprint Enwiki: Edit validation blocks changes but does not inform user - https://phabricator.wikimedia.org/T95607#1200231 (10Jdlrobson) [23:58:05] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Assorted string replacements - https://phabricator.wikimedia.org/T93817#1200235 (10JKatzWMF) 5Open>3Resolved [23:58:21] mhurd: turns out i also gotta update os. machine preparing to restart [23:58:57] 10Gather, 3Gather Sprint F: Bug: Long titles should not be clipped in EditorOverlay - https://phabricator.wikimedia.org/T95788#1200248 (10Jdlrobson) 3NEW [23:59:00] (03PS2) 10Mhurd: Fix for side to side scrolling of wide images with div overlays. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 [23:59:13] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Assorted string replacements - https://phabricator.wikimedia.org/T93817#1200261 (10Jdlrobson) [23:59:15] 10Gather, 3Gather Sprint Enwiki: Edit validation blocks changes but does not inform user - https://phabricator.wikimedia.org/T95607#1200256 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Doesn't seem to be an issue any more. However T95788