[02:50:16] 10Gather, 3Gather Sprint F, 3Mobile-Web-Design: No way to moderate a certain collection from the collection itself - https://phabricator.wikimedia.org/T94228#1202075 (10MSyed) Mock is attached here. When you click the "..." button on someone else's collection a drop down appears with "flag" and "hide" optio... [02:53:45] 10Gather, 3Gather Sprint Enwiki, 3Mobile-Web-Design, 5Patch-For-Review: No indication that a collection is private or hidden on the list itself - https://phabricator.wikimedia.org/T93828#1202078 (10MSyed) @JKatzWMF wanted the indicators to be a bit more subtle. I agree with him. Updated mock here: {F1120... [03:06:47] 10Gather, 3Gather Sprint F, 3Mobile-Web-Design: No way to moderate a certain collection from the collection itself - https://phabricator.wikimedia.org/T94228#1202088 (10MSyed) @jdlrobson ^ [05:13:50] 10Gather, 3Gather Sprint F: Add a flag button - https://phabricator.wikimedia.org/T94871#1202209 (10JKatzWMF) @jdlrobson. @msyed has added mock, here [05:59:17] 10Gather, 3Gather Sprint F: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1202215 (10JKatzWMF) a:5JKatzWMF>3None [06:00:04] 10Gather, 3Gather Sprint F: Do not show a "public" icon on Gather collections - https://phabricator.wikimedia.org/T95639#1202216 (10JKatzWMF) @mysed has added mock here: https://phabricator.wikimedia.org/T93828#1202078 [06:00:16] 10Gather, 3Gather Sprint F: Do not show a "public" icon on Gather collections - https://phabricator.wikimedia.org/T95639#1202217 (10JKatzWMF) a:5MSyed>3None [07:57:32] hey [08:19:02] (03CR) 10Phuedx: "Bmansurov: what does the current commit message miss out?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203345 (https://phabricator.wikimedia.org/T94445) (owner: 10Phuedx) [08:22:42] 6Mobile-Web, 3Mobile-Web-Design: Stop serving menu in the page HTML - https://phabricator.wikimedia.org/T95332#1202309 (10phuedx) According to the [page-ui-daily](http://mobile-reportcard.wmflabs.org/#other-graphs-tab) graph, search is clicked ~5 times more than the hamburger. Let's definitely render the menu... [08:31:36] (03PS5) 10Phuedx: Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) [08:31:38] (03CR) 10jenkins-bot: [V: 04-1] Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) (owner: 10Phuedx) [08:32:50] 6Mobile-Web, 7Epic: Deploy the latest version of WikiGrok (0.2? 0.3?) - https://phabricator.wikimedia.org/T95874#1202312 (10phuedx) 3NEW [08:33:42] 6Mobile-Web, 7Epic: Deploy the latest version of WikiGrok (0.2? 0.3?) - https://phabricator.wikimedia.org/T95874#1202324 (10phuedx) [08:34:49] (03PS3) 10Phuedx: Ignore WikiGrok not being configured to push data [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203365 (https://phabricator.wikimedia.org/T95304) [09:02:18] (03PS4) 10Phuedx: Ignore WikiGrok not being configured to push data [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203365 (https://phabricator.wikimedia.org/T95304) [09:17:28] good morning [09:43:36] (03PS15) 10Jhernandez: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [09:56:28] 10Gather, 3Gather Sprint F: Bug: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1202405 (10Jhernandez) I'll try a few styles and screenshot on different devices and post it here in the next sprint. [10:07:33] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Make Wikidata editable on mobile web - https://phabricator.wikimedia.org/T95878#1202437 (10Bene) 3NEW [10:08:25] hey joakino :) [10:08:29] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Getting Wikidata to render nicely on mobile web [Tracking] - https://phabricator.wikimedia.org/T78430#1202445 (10Bene) [10:08:33] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Make Wikidata editable on mobile web - https://phabricator.wikimedia.org/T95878#1202444 (10Bene) [10:08:35] hi phuedx! [10:08:40] ooh more wikidata cards [10:08:45] joakino: good weekend? [10:08:56] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Make Wikidata editable on mobile web [Tracking] - https://phabricator.wikimedia.org/T95878#1202446 (10Bene) [10:09:55] phuedx: pretty quiet, doing taxes crap [10:10:01] bleh same [10:10:04] worst [10:10:12] why? [10:11:06] phuedx: how's the house work, are you done with builders? [10:11:21] i dislike taxes crap [10:11:33] first window going in today [10:11:44] \o/ [10:11:56] staircase is being fabricated and installed at the end of the week [10:12:56] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1202457 (10Bene) 3NEW [10:12:59] cool [10:13:30] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1202457 (10Bene) [10:15:17] phuedx: are you going to lyon? [10:15:23] yeah [10:18:32] phuedx: gonna travel with the family? [10:18:59] joakino: not sure at the moment -- we're already going to france in june [10:19:02] which reminds me… [10:19:04] holiday request! [10:19:32] phuedx: how does the holiday/days off work for us now [10:19:45] is it emailing manager or is there anything else to do? [10:19:52] joakino: until safeguard is actually a thing, i guess it stays the same as it is now [10:19:58] email manager still? [10:20:26] ok, i'm asking because I haven't done any holiday/vacation yet [10:23:11] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1202480 (10Bene) [10:23:12] (03PS6) 10Phuedx: Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) [10:23:20] joakino: rly? [10:23:23] :/ [10:23:27] TAKE A BREAK [10:26:20] (03CR) 10Jhernandez: [C: 032] Point at hamburger icon when a collection has been setup. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) (owner: 10Jdlrobson) [10:26:55] (03CR) 10jenkins-bot: [V: 04-1] Add tests for WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) (owner: 10Phuedx) [10:27:43] phuedx: i know i know [10:31:01] (03Merged) 10jenkins-bot: Point at hamburger icon when a collection has been setup. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202265 (https://phabricator.wikimedia.org/T93628) (owner: 10Jdlrobson) [10:33:16] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Allow adding images as P18 using the upload image button - https://phabricator.wikimedia.org/T95881#1202487 (10Bene) 3NEW [10:33:34] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Allow adding images as P18 using the upload image button - https://phabricator.wikimedia.org/T95881#1202487 (10Bene) [10:34:37] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Allow adding images as P18 using the upload image button - https://phabricator.wikimedia.org/T95881#1202487 (10Bene) [10:34:41] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Getting Wikidata to render nicely on mobile web [Tracking] - https://phabricator.wikimedia.org/T78430#1202496 (10Bene) [10:35:08] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Allow adding images as P18 using the upload image button - https://phabricator.wikimedia.org/T95881#1202487 (10Bene) [10:35:12] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Make Wikidata editable on mobile web [Tracking] - https://phabricator.wikimedia.org/T95878#1202498 (10Bene) [10:35:34] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1202500 (10Bene) [10:36:29] (03CR) 10Jhernandez: [C: 032] When a user clicks on hamburger after adding to a collection show new icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203215 (https://phabricator.wikimedia.org/T95245) (owner: 10Jdlrobson) [10:42:48] (03PS7) 10Phuedx: Add tests for WikiGrok\WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) [10:44:52] (03Merged) 10jenkins-bot: When a user clicks on hamburger after adding to a collection show new icon [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203215 (https://phabricator.wikimedia.org/T95245) (owner: 10Jdlrobson) [10:47:26] (03CR) 10jenkins-bot: [V: 04-1] Add tests for WikiGrok\WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) (owner: 10Phuedx) [10:49:07] (03PS8) 10Phuedx: Add tests for WikiGrok\WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) [10:50:21] (03CR) 10jenkins-bot: [V: 04-1] Add tests for WikiGrok\WikibaseRepoConnector [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) (owner: 10Phuedx) [10:52:55] (03CR) 10Phuedx: "This is now blocked pending getting the WikidataBuildResources extension included in the build environment." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) (owner: 10Phuedx) [11:10:58] taking george out to play group [11:13:49] (03CR) 10Jhernandez: [C: 032] "Seems to work fine." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) (owner: 10Jdlrobson) [11:14:10] phuedx: when you have a bit of time can you have a look at https://gerrit.wikimedia.org/r/#/c/202628/ ^ [11:14:31] phuedx: seems fine, been testing it but my local event logging is not working [11:14:45] i'll test it out also later in beta labs to see it actually working [11:17:13] (03Merged) 10jenkins-bot: Add EventLogging to the watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202628 (https://phabricator.wikimedia.org/T94439) (owner: 10Jdlrobson) [11:17:20] 10Gather, 3Gather Sprint Enwiki, 6Mobile-Web, 5Patch-For-Review: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1202564 (10Jhernandez) Gonna test this again in beta labs when merged this afternoon [11:19:15] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1202577 (10Jhernandez) a:3Jhernandez [11:54:33] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Use different/new diff view for entity diffs - https://phabricator.wikimedia.org/T95883#1202612 (10Bene) 3NEW [11:54:46] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Use different/new diff view for entity diffs on mobile - https://phabricator.wikimedia.org/T95883#1202612 (10Bene) [11:58:09] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Tracking: Avoid having two h1 headings on Wikidata - https://phabricator.wikimedia.org/T93534#1202624 (10Bene) [11:59:51] 6Mobile-Web, 10MediaWiki-Search, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: search for Wikidata should use entity selector on mobile as well - https://phabricator.wikimedia.org/T85368#1202628 (10Bene) [12:24:06] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Decide how to use table of contents on mobile Wikidata - https://phabricator.wikimedia.org/T95884#1202649 (10Bene) 3NEW [12:26:15] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7JavaScript: sitelink section not shown on mobile - https://phabricator.wikimedia.org/T85363#1202659 (10Bene) @FriedhelmW Sitelinks are hidden in [[ https://www.wikidata.org/wiki/MediaWiki:Mobile.css | MediaWiki:Mobile.css ]] and thus they... [12:26:28] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: sitelink section not shown on mobile - https://phabricator.wikimedia.org/T85363#1202660 (10Bene) [14:02:50] whoops -- totally forgot to open irccloud again :/ [14:02:52] .back [14:03:26] joakino: what's yer setup for testing event logging? [14:12:53] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Show collapisble sections for Statements and Sitelinks - https://phabricator.wikimedia.org/T95889#1202790 (10Bene) 3NEW [14:17:40] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Show collapisble sections for Statements and Sitelinks - https://phabricator.wikimedia.org/T95889#1202798 (10Bene) [14:34:57] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: EPIC: As a Mobile Apps Team, I would like to be alerted when something is going catastrophically wrong with the app in production, so we can fix it for ou... - https://phabricator.wikimedia.org/T95019#1202864 [14:35:00] Good morning mholloway saw your email. Want to jump in the batcave? [14:35:19] kristenlans: Sure! [14:35:26] ok be there in 1 second.... [14:35:43] kristenlans: Might be a minute for me, need to find headphones, wont' be long [14:46:29] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 7Epic, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS: EPIC: As a Mobile Apps Team, I would like to be alerted when something is going catastrophically wrong with the app in production, so we can fix ... - https://phabricator.wikimedia.org/T95019#1202945 [14:52:28] (03CR) 10Bgerstle: "adding people from mobile-web for review" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 (owner: 10Mhurd) [14:52:55] phuedx: joakino hey! could i bother one or both of you web gurus for a review? [14:57:18] (03PS2) 10Jdlrobson: Deal with inconsistent API response and infinite spinner [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203387 (https://phabricator.wikimedia.org/T95637) [15:03:20] jdlrobson: would you be available to do some code review? [15:03:32] JS/web stuff [15:03:36] (in the native app) [15:04:08] (03Abandoned) 10Phuedx: Ignore WikiGrok not being configured to push data [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203365 (https://phabricator.wikimedia.org/T95304) (owner: 10Phuedx) [15:04:28] (03PS1) 10Fjalapeno: T94423 Adding Change log to builds [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 [15:05:17] bgerstle: later sure [15:05:29] jdlrobson: ok, i'll add you as a reviewer then [15:05:50] send me an email. I ignore gerrit emails [15:07:14] (03CR) 10Phuedx: "The correct way to do this would be to: have pushing to the Wikidata repo enabled by configuration and to insert a stub WikibaseRepoConnec" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203365 (https://phabricator.wikimedia.org/T95304) (owner: 10Phuedx) [15:08:46] bgerstle: sure -- but like jdlrobson: later :) [15:08:55] winding down our current sprint and then a load of meetings [15:09:09] phuedx: i cant make that 12.30 meeting [15:09:14] k [15:09:18] wanna chat now whilst i'm waiting for lightning deploy? [15:12:58] Good morning, mholloway. how's it going? [15:13:03] (03PS3) 10Jdlrobson: Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 [15:13:12] bearND: going well, how are you? [15:13:46] mholloway: good [15:14:36] 3Gather Sprint Enwiki: string replacement for watchstar login page - https://phabricator.wikimedia.org/T95729#1203037 (10Jdlrobson) a:3Jdlrobson [15:16:17] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1203041 (10bearND) p:5Triage>3Normal [15:23:33] bgerstle got this in: https://github.com/KrauseFx/fastlane/pull/188 [15:23:47] whoa, congrats dude!! [15:23:52] Fastlane contributor \o/ [15:23:52] thanks for the suggestion [15:23:55] ha [15:24:57] bgerstle: he seems to want the git changelog thing as an action too… so we could wrap that up in a custom action [15:25:35] jdlrobson: sure [15:26:34] 1s phuedx got called to swat [15:36:22] coreyfloyd: cool [15:36:30] coreyfloyd: did we ever do one? [15:36:39] 6Mobile-Web, 10Continuous-Integration, 6Release-Engineering: mwext-MobileFrontend-qunit-mobile issues again - https://phabricator.wikimedia.org/T95430#1203130 (10Krinkle) [15:36:46] coreyfloyd: you know what would be *really* cool [15:36:57] bgerstle: my patch in review now is change log, but no action [15:37:02] ah [15:37:03] 6Mobile-Web, 10Continuous-Integration, 6Release-Engineering: mwext-MobileFrontend-qunit-mobile issues again - https://phabricator.wikimedia.org/T95430#1189699 (10Krinkle) Intermittent snafu. [15:37:16] nice [15:37:17] hi there ! [15:38:12] 10Wikipedia-iOS-App: Send Phabricator Ticket titles and links in automated build change log - https://phabricator.wikimedia.org/T95902#1203141 (10Fjalapeno) 3NEW [15:38:56] phuedx: i thought I had the event logging role enabled but it turns out I don't [15:38:58] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Create change log for CI builds - https://phabricator.wikimedia.org/T94423#1162932 (10Fjalapeno) [15:39:02] gonna enable it [15:39:13] (03CR) 10Bgerstle: [C: 031] Disallow double tap on Done login button (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203490 (owner: 10Dr0ptp4kt) [15:39:16] phuedx: any advice on how to actually test it front to back? [15:41:21] bgerstle: you can test locally by setting the environment variable to a known commit sha [15:41:32] bgerstle: if you want to test [15:41:38] 6Mobile-Web: Should be possible for other extensions to register custom messages on MobileFrontend login and signup forms - https://phabricator.wikimedia.org/T95903#1203170 (10Jdlrobson) 3NEW [15:41:38] joakino: there's a server that'll cat whatever events it receives [15:41:54] joakino: go into EventLogging/server [15:41:56] (iirc) [15:41:57] 6Mobile-Web: Should be possible for other extensions to register custom messages on MobileFrontend login and signup forms - https://phabricator.wikimedia.org/T95903#1203187 (10Jdlrobson) [15:41:59] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] Getting rid of own login page - https://phabricator.wikimedia.org/T74910#1203186 (10Jdlrobson) [15:42:04] bgerstle: also you left me hanging on your cool comment [15:42:15] coreyfloyd: i got confused [15:42:32] coreyfloyd: i thought when you said the "patch you have up now is for changelog" i went to Fastlane PRs [15:42:35] i see it now, though [15:42:52] i was going to say, it would be cool to do ERB templating for changelog entries.. but i don't think it would be too useful [15:43:08] (03PS1) 10Jdlrobson: Update Gather messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) [15:43:29] (03PS1) 10Jdlrobson: Add i18n messages for login signup [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203836 (https://phabricator.wikimedia.org/T95729) [15:44:40] 3Gather Sprint Enwiki: Adding/removing to watchlist when new user causes window to reopen - https://phabricator.wikimedia.org/T95744#1203221 (10Jdlrobson) a:3Jdlrobson [15:47:12] (03CR) 10jenkins-bot: [V: 04-1] Add i18n messages for login signup [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203836 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [15:52:12] (03PS1) 10Jdlrobson: Prevent auto-reopening of collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203842 (https://phabricator.wikimedia.org/T95744) [15:52:13] jdlrobson: it seems like html5 allows links to wrap divs? https://css-tricks.com/snippets/jquery/make-entire-div-clickable/ [15:56:23] joakino: yup html5 for the win [15:56:36] just don't wrap the link in the link ;-) [15:57:16] (03CR) 10jenkins-bot: [V: 04-1] Prevent auto-reopening of collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203842 (https://phabricator.wikimedia.org/T95744) (owner: 10Jdlrobson) [15:59:44] (03CR) 10Bgerstle: "some comments while i get around to testing" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 (owner: 10Fjalapeno) [16:00:47] (03CR) 10Bgerstle: "Gemfile comment" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 (owner: 10Fjalapeno) [16:01:56] coreyfloyd: this is a good start, but i'm starting to wonder if we should just start manually curating a CHANGELOG file [16:02:17] and we can add that to the notes as well [16:02:58] jdlrobson: wrapping everything on a link fucks with text styling big ways... [16:02:59] dammit [16:03:25] coreyfloyd: also, should we grab the commit subjects instead of the messages? [16:06:01] (03CR) 10Bgerstle: "moar commentz" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 (owner: 10Fjalapeno) [16:06:08] joakino: that too [16:06:13] see my hacks not so bad!!! ;-0 [16:06:16] haha [16:06:20] yuup [16:06:36] joakino: looks like i'm gonna be late for standup at this rate [16:06:43] lightning deploy taking longer than i thought [16:06:57] not lightning at all [16:06:59] can you run it? hopefully i'll catch the end [16:09:04] jdlrobson: sure [16:17:48] (03CR) 10Fjalapeno: [C: 031] Disallow double tap on Done login button [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203490 (owner: 10Dr0ptp4kt) [16:18:25] (03PS1) 10Jdlrobson: Apply security fix adding CheckUser support [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203851 (https://phabricator.wikimedia.org/T94128) [16:20:43] (03CR) 10Jdlrobson: [C: 032] Apply security fix adding CheckUser support [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203851 (https://phabricator.wikimedia.org/T94128) (owner: 10Jdlrobson) [16:32:39] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203854 [16:33:05] (03CR) 10Fjalapeno: "Updating the patch to work as an action…" (035 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 (owner: 10Fjalapeno) [16:34:15] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1203411 (10bearND) [16:36:37] (03CR) 10Fjalapeno: [C: 031] Fix for side to side scrolling of wide images with div overlays. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 (owner: 10Mhurd) [16:37:55] bgerstle: did you see this? https://gerrit.wikimedia.org/r/#/c/203507/ [16:39:03] coreyfloyd: no [16:39:08] (i wasn't added as reviewer) [16:40:32] bgerstle: me neither… just added myself… popped up in my inbox somehow [16:41:02] k [16:41:22] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Update localization script so we can move files in the project without breaking importing localized strings - https://phabricator.wikimedia.org/T95733#1203440 (10Fjalapeno) [16:41:50] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Update localization script so we can move files in the project without breaking importing localized strings - https://phabricator.wikimedia.org/T95733#1198930 (10Fjalapeno) We have access now - just a gerrit project we need to change. [16:41:59] coreyfloyd: on the user of ENV stuff in the fastfile, i agree that using ENV is a good way to pass config between actions, but in our case we're just passing data around between functions [16:42:21] in interest of KISS, i think returning & passing values would be more intuitive and cleaner [16:42:38] s/user/using/ [16:44:12] bgerstle: https://phabricator.wikimedia.org/T95795 [16:45:32] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Update localization script so we can move files in the project without breaking importing localized strings - https://phabricator.wikimedia.org/T95733#1203459 (10Fjalapeno) Also see: https://phabricator.wikimedia.org/T95795 [16:45:53] coreyfloyd: nice, should be straightforward to relocate that stuff, then [16:47:35] bgerstle: agree to disagree? LOL - I would rather update the Hockey action to take the API key from the ENV when we add the enums - so then we no longer need to pass it to the hockey action. [16:48:22] coreyfloyd: let me dive into the hockeyapp action real quick.. [16:49:09] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1203473 (10JKatzWMF) This is not a high priority and challenging to do, so let's hold off for now. [16:49:35] (03Merged) 10jenkins-bot: Apply security fix adding CheckUser support [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203851 (https://phabricator.wikimedia.org/T94128) (owner: 10Jdlrobson) [16:50:35] coreyfloyd: i guess the option would be to patch this https://github.com/KrauseFx/fastlane/blob/master/lib/fastlane/actions/hockey.rb#L16 [16:50:44] to default to a value from ENV or "No notes given." [16:51:06] either env or a SharedLaneContext value [16:51:12] probably the latter would be easier [16:51:29] so you can have one or more "SharedLaneContext" values specific to changelog which other actions can easily incorporate [16:51:43] e.g. https://github.com/KrauseFx/fastlane/blob/master/lib/fastlane/actions/hockey.rb#L21 [16:52:12] in our case, it would be something like: SharedValues::CHANGELOG_OUTPUT_PATH [16:52:48] coreyfloyd: anyway, can be a follow-on [16:53:01] i'm just refactoring it real quick so i can test the git-related stuff outside fastlane [16:59:34] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1203528 (10dr0ptp4kt) > Yeah i don't mind one way or the other. If you like phab more for this that works for me - I feel like whatever works best for you since you are... [16:59:56] ^ bgerstle coreyfloyd 4 u [17:06:00] (03PS2) 10Jdlrobson: Prevent auto-reopening of collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203842 (https://phabricator.wikimedia.org/T95744) [17:06:32] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (owner: 10Jdlrobson) [17:07:24] (03CR) 10Jdlrobson: [C: 032] Use BaseTemplate instead of QuickTemplate to create UserLoginAndCreateTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203622 (https://phabricator.wikimedia.org/T95820) (owner: 10Florianschmidtwelzow) [17:09:22] coreyfloyd: let's do a hangout after standup, i think you'll like the change i made for debugging ruby stuff [17:10:32] (03CR) 10jenkins-bot: [V: 04-1] Prevent auto-reopening of collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203842 (https://phabricator.wikimedia.org/T95744) (owner: 10Jdlrobson) [17:10:51] (03Merged) 10jenkins-bot: Use BaseTemplate instead of QuickTemplate to create UserLoginAndCreateTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203622 (https://phabricator.wikimedia.org/T95820) (owner: 10Florianschmidtwelzow) [17:11:19] bgerstle: sure… sorry - heads down [17:11:56] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1203580 (10Jhernandez) A little analysis of different options I've been trying: - Html, converting the whole card into a `a` (link)... [17:13:53] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________, 7Epic: Deploy the latest version of WikiGrok (0.2? 0.3?) - https://phabricator.wikimedia.org/T95874#1203591 (10JKatzWMF) [17:14:06] (03CR) 10Jdlrobson: "Sorry I should have pointed out this is a WIP, I know there are lots of issues with it - right now I'm just focused on getting the visuals" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203478 (https://phabricator.wikimedia.org/T88559) (owner: 10Jdlrobson) [17:14:37] 10Gather, 3Gather Sprint Enwiki, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1203593 (10Jhernandez) a:3Jhernandez [17:16:44] 10Gather, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1203599 (10JKatzWMF) [17:17:33] 10Wikipedia-Android-App, 7Easy, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: the languages list shows the languages in a suboptimal way - https://phabricator.wikimedia.org/T68917#1203601 (10Deskana) 5Open>3Resolved [17:18:49] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1203606 (10Deskana) a:5Deskana>3None [17:22:51] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6CA-team, 10MediaWiki-API, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1203642 (10KLans_WMF) @etonkovidova can you help us repro/check this? [17:22:53] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Hook app up to experimental content service to test the service's viability - https://phabricator.wikimedia.org/T91798#1203644 (10bearND) [17:23:15] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1203647 (10bearND) [17:24:07] (03CR) 10Fjalapeno: [C: 032] Disallow double tap on Done login button [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203490 (owner: 10Dr0ptp4kt) [17:24:25] 10Gather, 3Gather Sprint Enwiki, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1203662 (10Jhernandez) a:5Jhernandez>3None [17:25:17] (03Abandoned) 10Jdlrobson: Hygiene: Rename misleading module name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202619 (owner: 10Jdlrobson) [17:25:35] (03PS1) 10Jdlrobson: Hygiene: Write ButtonWithSpinner as a View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) [17:27:20] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: 4.0.7.8 - NSURLErrorDomain error code -999 with the first login - https://phabricator.wikimedia.org/T93789#1203691 (10dr0ptp4kt) 5Open>3Resolved [17:27:43] 10Gather, 3Gather Sprint Enwiki, 3Mobile-Web-Design, 5Patch-For-Review: Add 'new' icon to collections in main menu - https://phabricator.wikimedia.org/T95245#1203694 (10JKatzWMF) 5Open>3Resolved [17:27:45] 10Gather, 3Gather Sprint Enwiki, 3Mobile-Web-Design, 5Patch-For-Review: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1203695 (10JKatzWMF) [17:27:49] 10Gather, 3Gather Sprint Enwiki, 6Mobile-Web, 5Patch-For-Review: Log events on 'watchstar' across mobile skin. - https://phabricator.wikimedia.org/T94439#1203696 (10JKatzWMF) 5Open>3Resolved [17:28:04] 10Gather, 3Gather Sprint Enwiki, 3Mobile-Web-Design, 5Patch-For-Review: user who creates a new collection is shown an overlay showing them to click on the hamburger menu to visit their collections. - https://phabricator.wikimedia.org/T93628#1203697 (10JKatzWMF) 5Open>3Resolved [17:28:21] (03PS2) 10Jdlrobson: Hygiene: Write ButtonWithSpinner as a View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) [18:00:46] coreyfloyd: hangout? [18:00:47] sure [18:00:47] @FlorianSW hey are you going to lyon hackathon? [18:00:47] (03Abandoned) 10Bmansurov: Alpha, Beta: Correctly align the edit icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203184 (owner: 10Bmansurov) [18:00:47] joakino: ! [18:00:47] coming [18:00:48] joakino: rmoen https://phabricator.wikimedia.org/tag/gather_sprint_f/ [18:00:48] & http://hatjitsu.wmflabs.org/65354 [18:00:48] bearND: OK, I guess since it was only a commit message change Gerrit didn't set an alert, but I pushed the new patch set for review [18:00:49] bearND: *send, not set [18:00:49] mholloway: ok, ty. I'll check it out shortly [18:00:49] dr0ptp4kt: coreyfloyd mholloway bearND mhurd Deskana|Away bgerstle I caught the whole standup, just didn't want to risk talking and distracting you guys with bad connection robot sounds [18:00:49] bmansurov, kaldari: you got a sec to hangout? [18:00:49] kristenlans: we like it when there are robot sounds [18:00:49] sure [18:00:49] Android sprint seems in good shape to flop over to 55, dr0ptp4kt we'll clean up iOS 54->55 at estimation mtg later [18:00:50] phuedx: yes [18:00:50] kristenlans: cool [18:00:50] baha: check yer hangout invites [18:00:51] dr0ptp4kt: hey what email address do we want beta feedback to go to? [18:00:51] Gradle sync going sooooo sloowwwwllllly [18:00:51] coreyfloyd: you can send it to me. i'll set a reminder to myself to have oit create a shared 'dead drop' account, though [18:00:51] coreyfloyd: my abaso email [18:00:51] bearND: Is something borked with our Gradle setup? This sync isn't working. [18:00:51] bearND: Also, the build server hasn't produced a build in two weeks now. [18:00:51] Hi JonKatz. [18:00:51] coreyfloyd: to date, i've been reading and responding to the feedback, then passing to Deskana + vibha (and any other designers) as necessary [18:00:51] (for testflight) [18:00:52] Deskana: what sync? You mean in AS on your local repo? [18:00:54] bearND: Yeah, it's been resolving dependencies for about 10 minutes now [18:00:54] Deskana: ok, I have not experienced that myself. Do you have a minute to show me via Hangout? [18:00:54] Deskana: like in the Batcave? [18:00:55] coreyfloyd: see updated patch: https://gerrit.wikimedia.org/r/#/c/203830/ (with docs on irb workflow) [18:00:55] coreyfloyd: bgerstle reading up on fastlane docs... cool stuff [18:00:55] Deskana|Away: I'm going to investigate the alpha build issue a bit later. Right now I can't log into the system since labs is experiencing some issues. [18:00:55] mhurd yes it is :-) [18:00:55] Deskana|Away: The maven repo for the java-mw api is also hosted on labs, so that may explain why you are seeing some issues (if you haven't build on your system in a while; this stuff should be cached) [18:08:16] coreyfloyd: not sure why gerrit notifs aren't bubbling up here, but https://gerrit.wikimedia.org/r/#/c/203830/ is ready for review [18:08:17] my amendments are, at any rate [18:08:18] adam's not online otherwise i'd ping him [18:08:18] lunch time! 🍕 [18:08:18] bearND: Sorry, had to run and do something. Thanks for the APK. :-) [18:08:18] Deskana: np [18:12:08] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: 4.0.7.10 articles in Recent do not display thumbnail images - https://phabricator.wikimedia.org/T95114#1203707 (10KLans_WMF) 5Resolved>3Open [18:12:08] 10Gather, 3Gather Sprint Enwiki, 5Patch-For-Review: Expose Gather as desktop beta feature - https://phabricator.wikimedia.org/T95227#1203709 (10JKatzWMF) hi @jdlrobson, I think this requires more discussion. Lets talk about tradeoffs before moving forward. [18:12:08] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1093698 (10KLans_WMF) on to you for design signoff @vibhabamba [18:12:08] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: 4.0.7.10 articles in Recent do not display thumbnail images - https://phabricator.wikimedia.org/T95114#1180658 (10KLans_WMF) pass to @vibhabamba for design signoff (if needed) [18:19:22] (03CR) 10Bmansurov: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [18:19:22] mhurd: dr0ptp4kt we never got to talk server stuff last week - do you want to do it today? [18:21:20] (03CR) 10Fjalapeno: [C: 031] Adding Change log to builds (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 (https://phabricator.wikimedia.org/T94423) (owner: 10Fjalapeno) [18:22:17] bgerstle_lunch: do you also want to +1 that patch when you get back - then we can have mhurd or dr0ptp4kt also +1 it since we both worked on it [18:24:27] 6Mobile-Web, 10MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1203741 (10csteipp) >>! In T88860#1199673, @Jdlrobson wrote: > (which extension provides this module - that's where the bug needs to be fixed... [18:24:29] 10Gather, 3Gather Sprint F: Do not show a "public" icon on Gather collections - https://phabricator.wikimedia.org/T95639#1203743 (10Jdlrobson) [18:24:31] 10Gather, 3Gather Sprint F: Do not show a "public" icon on Gather collections - https://phabricator.wikimedia.org/T95639#1196462 (10Jdlrobson) [18:24:41] 10Gather, 3Gather Sprint F: Add a flag button - https://phabricator.wikimedia.org/T94871#1203765 (10Jdlrobson) [18:24:49] 10Gather, 3Gather Sprint F: Add a flag button - https://phabricator.wikimedia.org/T94871#1174892 (10Jdlrobson) [18:24:51] 10Gather, 3Gather Sprint F: Add a flag button - https://phabricator.wikimedia.org/T94871#1203776 (10Jdlrobson) [18:24:55] 10Gather, 3Gather Sprint F: Add a flag button - https://phabricator.wikimedia.org/T94871#1174892 (10Jdlrobson) [18:25:44] 10Gather, 3Gather Sprint F: Add a flag button - https://phabricator.wikimedia.org/T94871#1203788 (10Jdlrobson) [18:25:46] 10Gather, 3Gather Sprint F, 3Mobile-Web-Design: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1203790 (10Jdlrobson) [18:25:48] 6Mobile-Web, 10WikiGrok, 3Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2: WikiGrok save error - https://phabricator.wikimedia.org/T95721#1203792 (10kaldari) [18:27:38] 10Gather, 3Gather Sprint F, 3Mobile-Web-Design: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1157951 (10Jdlrobson) [18:27:39] 10Gather, 3Gather Sprint F: Add a flag button - https://phabricator.wikimedia.org/T94871#1203797 (10MSyed) @Jdlrobson @JKatzWMF Since we dont have Follow and Share functionality built, just the flag icon in the corner is fine. Also, I'm putting a hide icon in the corner too for admins. {F112423} [18:27:41] 10Gather, 3Gather Sprint F: Add a flag button - https://phabricator.wikimedia.org/T94871#1203799 (10Jdlrobson) [18:27:43] 10Gather, 3Gather Sprint F, 3Mobile-Web-Design: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1203798 (10Jdlrobson) [18:27:45] 10Gather, 3Gather Sprint F, 3Mobile-Web-Design: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1157951 (10Jdlrobson) [18:28:04] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________, 7Epic: Deploy the latest version of WikiGrok (0.2? 0.3?) - https://phabricator.wikimedia.org/T95874#1203803 (10phuedx) [18:28:32] little late aren't ya wikibugs? [18:28:34] 10Gather, 3Gather Sprint F: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1203811 (10Jdlrobson) [18:49:47] coreyfloyd: sure [18:49:49] (03CR) 10Bgerstle: [C: 031] "also contributed to this, but +1" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 (https://phabricator.wikimedia.org/T94423) (owner: 10Fjalapeno) [18:49:49] where's vibha? [18:49:49] kristenlans: can we make a new $1 penalty if you're caught off IRC during business hours? :-P [18:49:50] bgerstle: but thats my style [18:49:50] bgerstle: coreyfloyd we're gonna be rich! [18:49:50] dr0ptp4kt mhurd do we have a place to list personal computers for sale in the organization? [18:49:50] :trollface: [18:49:51] coreyfloyd: macofalltrades.com [18:49:51] dbrant would you mind linking me to the API request you used for the link preview? [18:49:51] bgerstle: i pinged vibha on google chat... [18:49:52] mhurd i've pinged here there in the past, but if we're going to be buying people IRCCloud accounts we might as well get in the habit of having people on here [18:49:52] bgerstle: couldn't agree more [18:49:52] moizsyed: is on IRC! vibha has no excuse :-P [18:49:52] bgerstle: IRC FTW [18:49:52] moizsyed: is vibha off today? [18:49:52] well Slack FTW, IRC for-the-meh [18:49:53] coreyfloyd: amirite? [18:49:53] hahaha [18:49:53] mhurd: i dont know if vibha is off.. I'm on vacation tho [18:49:53] moizsyed: whoa! have fun! [18:49:53] moizsyed: then why are you on IRC?! [18:49:53] bgerstle: doing some work... too much Miami is not good for health [18:49:53] wait WHAT?! [18:49:53] you're in Miami?? [18:49:53] lol [18:49:53] moizsyed: you know i live in Miami, right? [18:49:53] bgerstle: thats why he was avoiding you [18:49:54] lol [18:49:54] it's all coming together now.. [18:49:54] 😭 [18:49:54] * Deskana waits for moizsyed to strategically disappear [18:49:54] lol [18:49:54] moizsyed: right now: http://media.tumblr.com/tumblr_lkclcvw5CG1qbej4j.gif [18:49:54] bgerstle: damn [18:49:54] bgerstle: that was... amazing [18:49:54] bgerstle: im in south beach right now [18:49:54] bgerstle: any places i should check out? [18:49:54] hahah [18:49:54] moizsyed: i live on SoBe ;-), and yes [18:49:54] (03PS1) 10Jhernandez: Fix scrolling of main page on iOS 8 modals [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203875 (https://phabricator.wikimedia.org/T95018) [18:49:54] also, ^ is why people need to be on IRC ;-D [18:49:54] (not the gerrit msg) [18:49:55] where are all the droids? [18:49:55] mholloway: get your comrades in here [18:49:55] mholloway: also, you wouldn't know where the link preview prototype code is, woudl you? [18:49:55] jdlrobson: hey [18:49:55] bgerstle: hmm, lemme look [18:49:55] dr0ptp4kt: we need a wikimedia.org email address for the build server… how do we request that? [18:49:55] https://phabricator.wikimedia.org/T94426 [18:49:55] coreyfloyd: in meeting. will get back to you afterward about irc messages here. sorry! [18:49:55] dr0ptp4kt: np [18:49:55] hey benestar [18:55:13] bgerstle: found it: https://gerrit.wikimedia.org/r/#/c/202615/ [18:55:13] mholloway: thanks! [18:55:13] bgerstle: no prob [18:55:13] 10Gather, 3Gather Sprint Forward: Remove delete button from collection page and fix behavior so it does not send you back to collection when you click it. - https://phabricator.wikimedia.org/T95732#1203818 (10Jdlrobson) [18:55:13] 10Gather, 3Gather Sprint Forward: Can create collection with non-main namespace pages but they do not show up - https://phabricator.wikimedia.org/T94786#1172672 (10Jdlrobson) [18:55:13] 10Gather, 3Gather Sprint Forward: Can create collection with non-main namespace pages but they do not show up - https://phabricator.wikimedia.org/T94786#1203841 (10Jdlrobson) [18:55:13] jdlrobson: I'm currently working on making Wikidata mobile friendly as you may have seen ;) I have a question for the sections on MobileFrontend [18:55:13] sure thing, what's the question? [18:55:13] currently mobile only recognizes sections which are direct descendants of the #content div [18:55:13] correct [18:55:13] however, Wikidata's

sections are wrapped in some divs [18:55:13] so MobileFrontend wont recognize them unless we remove that assumption [18:55:13] yeh.. ironically they need to be direct descendants so we can wrap them in divs haha [18:55:25] huh [18:59:05] but you can also allow other headings, can't you? [18:59:06] so in Wikidata we have maybe

blubb

Content...
[18:59:06] $firstHeading = $container.find( '> h1,> h2,> h3,> h4,> h5,> h6' ).eq( 0 ); [18:59:06] $firstHeading = $container.find( 'h1, h2, h3, h4, h5, h6' ).eq( 0 ); [18:59:06] --^ that is basically the change I propose jdlrobson [18:59:06] yeh there's problems with that though.. [18:59:33] as there can be can be nested headings [19:03:59] e.g. == h2 == text =h1= mahahaha == foo == text [19:03:59] have a nice day, gn o/ [19:04:00] night joakino :) [19:04:00] MobileFrontend does pre-parsing of sections to work out the logical grouping [19:04:00] i think wikidata and MobileFrontend should be able to set some standard classes though, so wikidata can explicitly say what it wants to be toggled [19:04:00] kaity kaldari JonKatz https://etherpad.wikimedia.org/p/S [19:04:00] maybe > h1,> h2,> h3,> h4,> h5,> h6, mw-collapsible-heading or something benestar ? [19:04:01] jdlrobson: that might be a good idea [19:04:01] JonKatz: wikitech-ambassadors@lists.wikimedia.org [19:04:01] mhurd: you have time to look this over? https://gerrit.wikimedia.org/r/#/c/203830/ [19:04:01] coreyfloyd: https://www.youtube.com/watch?v=M3iSlp4ML4g ? [19:04:01] jdlrobson: I will prepare a patch for that, ok? [19:04:01] kaldari: JonKatz https://etherpad.wikimedia.org/p/S [19:05:04] coreyfloyd: looks good [19:05:36] jdlrobson: can I just use the section-heading class or does that imply other things as well? [19:05:38] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Create change log for CI builds - https://phabricator.wikimedia.org/T94423#1204193 (10Fjalapeno) [19:06:05] mhurd: dunka [19:06:33] dr0ptp4kt: i keep forgetting to bookmark the url… [19:07:55] (03CR) 10Mhurd: [C: 032] Adding Change log to builds [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 (https://phabricator.wikimedia.org/T94423) (owner: 10Fjalapeno) [19:08:22] (03PS4) 10Mhurd: Adding Change log to builds [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 (https://phabricator.wikimedia.org/T94423) (owner: 10Fjalapeno) [19:08:47] (03CR) 10Mhurd: [V: 032] Adding Change log to builds [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203830 (https://phabricator.wikimedia.org/T94423) (owner: 10Fjalapeno) [19:09:37] 6Mobile-Web, 10Mobile-Web-Sprint-45-S_________, 5Patch-For-Review: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1204198 (10KLans_WMF) [19:10:14] benestar: i'm not sure if the section-heading class will work.. maybe, i'll keep my eyes out for your patch :) [19:10:42] great, I'll try section-heading [19:10:58] 3Gather Sprint Enwiki: Spike: How can we stop Gather depending on MobileFrontend - https://phabricator.wikimedia.org/T94100#1204199 (10Jdlrobson) 5Open>3Resolved Sent Removing MobileFrontend from Gather dependencies to mobile-l [19:11:37] jdlrobson: yeah, assigning section-heading works indeed \o/ [19:12:37] bgerstle_weekend: hi [19:12:42] Did you have a question? [20:15:03] hey Krenair you around? [20:15:04] (03PS1) 10Bene: Make all headings with class section-heading toggleable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) [20:15:04] hi JonKatz [20:15:04] Krenair whatsup? [20:15:04] ohai __nonnull, so happy to see you :-D dr0ptp4kt mhurd coreyfloyd [20:15:04] JonKatz, Apparently the mobile anonymous editing change had been approved by mobile [20:15:04] jdlrobson: you free now? i'm keen to get my meetings for the night over [20:15:04] i've got chores to do before i sit down [20:15:04] By Maryana, and by engineering management [20:15:04] mhurd i need to type out almost your entire handle now. i guess i have mholloway to blame for that [20:15:04] we need to stop hiring people with handles that start with the same first two letters as other org members' handles [20:15:04] bgerstle: hahahah! [20:15:05] krenair I am very uninterested in opening this up again, but if you really want to have this conversation can you point that out to me? [20:15:05] Well, given that you left me at fault for deploying it, and then apparently went around telling people I deploy things as staff, I would like you to clarify exactly what happened. [20:15:05] krenair fair enough. can you show me where you saw that maryana had approved it? [20:15:06] No, I've found out through private messages. [20:15:06] Krenair for what it is worth, I did not single you out in my email to management (I'll forward you a copy) [20:15:06] I want to know if you've been told the same thing. [20:15:06] krenair I definitely have not. In fact, I was chatting with Maryana the same day we discovered it was live (before we discovered it) and she was recommending we hold off just for a bit, at least on En. [20:15:07] krenair I have to run to lunch. feel free to reach out if you want to discuss more. [20:15:08] "The final merge was actually approved by an internal staff member" [20:15:08] sigh. [20:15:08] Deskana we await your presence [20:15:08] oh deskana nevermind [20:15:09] (03Abandoned) 10Bmansurov: WIP: Alpha experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/198450 (owner: 10Bmansurov) [20:15:09] mhurd: dr0ptp4kt http://hatjitsu.wmflabs.org/81959 [20:15:09] mhurd: dr0ptp4kt My computer is dying, sorry for not joining you guys in the room [20:15:09] (03PS1) 10Jdlrobson: WIP: Truncate collection titles in toast [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203884 (https://phabricator.wikimedia.org/T93797) [20:15:09] vibha no worry! [20:15:09] you both look lovely on hangouts [20:15:10] vibha: lol [20:15:10] vibha: how's irc cloud working for you? [20:15:10] (03CR) 10Jdlrobson: [C: 031] Fix scrolling of main page on iOS 8 modals (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203875 (https://phabricator.wikimedia.org/T95018) (owner: 10Jhernandez) [20:15:11] (03CR) 10Jdlrobson: "Please read bug.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) (owner: 10Jdlrobson) [20:15:11] (03PS3) 10Jdlrobson: Hygiene: Write ButtonWithSpinner as a View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) [20:15:12] (03CR) 10Florianschmidtwelzow: Make all headings with class section-heading toggleable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [20:15:12] (03PS1) 10Mhurd: Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 [20:15:12] (03PS2) 10Mhurd: Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 [20:15:12] benestar: you're from germany? :) [20:15:13] irc cloud is great. But sometimes it automatically disconnects and I'm not aware of it, so I miss messages. [20:15:14] (03CR) 10Bmansurov: "> Let's rewrite this as View and remove the OOjs UI dependency" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) (owner: 10Jdlrobson) [20:15:16] vibha: it'll disconnect you when you suspend yer laptop or yer connection drops [20:15:16] sometimes it doesn't auto-reconnect [20:15:16] And it doesnt automatically re-connect? [20:15:16] if you are on the same wifi? [20:15:16] ^ that [20:15:16] I see [20:15:17] it shouldn't vary by connection type [20:15:17] just that there's a connection [20:15:17] /sometimes/ it doesn't reconnect [20:15:18] (03PS2) 10Phuedx: Beta: Make banner image width match content width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) [20:15:19] see y'all tomorrow [20:15:19] have a nice day y'all [20:15:19] you too [20:15:22] (03CR) 10Bmansurov: "Yes, and not only it. OO.ui is also broken. So I wonder what the point of fixing this bug is, when the whole thing and other unrelated thi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [20:15:22] Hi mobilists! [20:15:22] FlorianSW: yes :) [20:15:22] benestar: super :D [20:15:22] why that? :D [20:15:22] benestar: darf ich fragen, wo du her kommst? [20:15:22] Why doesn't {{hidden}} work on mobile? [20:15:22] Pharos: what does hodden do? [20:15:22] it hides a long block of text that most ppl don't want to read [20:15:22] which should be especially useful on mobile [20:15:22] Pharos: perhaps because it uses local javascript code which is not loaded on mobile [20:15:22] https://en.m.wikipedia.org/wiki/Wikipedia:Meetup/NYC for example, hides the big list of meetups goes back to 2006 [20:15:22] Pharos: ok, sorry, i misspelled my question :) I meant, what does it do technically :) Is it this one: https://en.wikipedia.org/wiki/Template:Hidden?? [20:15:22] FlorianSW:yes [20:15:22] Pharos: "This template creates a dynamic navigation box using style sheet declarations in MediaWiki:Common.css and Javascript code in MediaWiki:Common.js." [20:15:22] both, MediaWiki:Common.css and MediaWiki:Common.js aren't loaded on mobile pages [20:15:22] technically, it uses https://en.wikipedia.org/wiki/Template:Hidden_begin and hiddenend [20:15:22] you could consider with an admin of enwiki, if the functions are essential and put it on MediaWiki:Mobile.css, too, but it shouldn't be done, if the functions are just a gimmick and not widely used, think about limited data plans :) [20:15:23] Pharos: ^ [20:15:23] (03PS10) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [20:15:23] hmm. is therea way I could display just skip that bit for mobile viewers? [20:15:23] *just skip that text for mobile viewers [20:15:23] Pharos: wrap it in a div wiht a class "nomobile" :) [20:15:23] (03CR) 10Bene: "Re" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [20:15:23] FlorianSW: nice [20:15:23] (03PS1) 10Florianschmidtwelzow: Add support for extensions to add custom login messages for mobile login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203893 (https://phabricator.wikimedia.org/T95903) [20:15:23] (03PS1) 10Florianschmidtwelzow: Login messages: Add support for MobileFrontend loginpage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203894 (https://phabricator.wikimedia.org/T95903) [20:15:23] 10Gather, 3Gather Sprint Forward, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1204219 (10Jdlrobson) @Jhernandez asked if you needed this to be integrated into the Special:Gather page. Right now you are able to create yo... [20:15:41] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1204291 (10Florian) @Bene: +1 :) [20:16:18] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Spike [1 hour]: As a Mobile Apps Team, I would like to be alerted when something is going catastrophically wrong with the app in production, so we can fix it for our users (Monitoring/Alerting) - https://phabricator.wikimedia.org/T95941#1204374 (10KLans_WMF) [20:16:20] 10Gather, 3Gather Sprint Forward, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1204376 (10Florian) I'm not sure, if i unsertand the problem correctly, but wouldn't it be possible to inherit SpecialGather, @phuedx, and ch... [20:16:27] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Update localization script so we can move files in the project without breaking importing localized strings - https://phabricator.wikimedia.org/T95733#1204380 (10KLans_WMF) [20:16:29] 6Mobile-Web, 5Patch-For-Review: Should be possible for other extensions to register custom messages on MobileFrontend login and signup forms - https://phabricator.wikimedia.org/T95903#1204384 (10Florian) Hmm, maybe reuse the LoginFormValidErrorMessages hook from LoginForm/Special:UserLogin? I think it wouldn't... [20:16:31] 6Mobile-Web, 5Patch-For-Review: Should be possible for other extensions to register custom messages on MobileFrontend login and signup forms - https://phabricator.wikimedia.org/T95903#1204385 (10Jdlrobson) ++++ [20:16:43] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1204411 (10Fjalapeno) a:5Fjalapeno>3dr0ptp4kt [20:16:45] 10Gather, 3Gather Sprint Forward: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1204413 (10rmoen) a:3rmoen [20:16:54] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1204434 (10KLans_WMF) [20:17:02] 10Wikipedia-iOS-App: Standardize image fetch/cache/fallback logic - https://phabricator.wikimedia.org/T95350#1204449 (10BGerstle-WMF) [20:18:21] (03PS11) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [20:21:41] (03CR) 10Phuedx: "Bmansurov: this isn't isolated to IE8, I just wanted the fix to work in a backwards compatible way." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [20:22:08] (03CR) 10Kaldari: [C: 032] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [20:22:20] (03CR) 10Phuedx: "It ain't even a bug. It's a feature request :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [20:22:40] kaldari: ^ yay :D Thanks [20:24:23] FlorianSW: Sorry it took so long :) [20:24:35] (03CR) 10Florianschmidtwelzow: [C: 032] Make all headings with class section-heading toggleable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [20:24:45] kaldari: good development takes time :) [20:28:38] bmansurov: what's our status on seeing prod search data traffic coming in ? [20:28:45] FlorianSW: I know your TalkOverlay to stable patch has also been sitting around for a while. The new PM is reluctant to green-light it, so it might sit for a while. Just FYI. [20:29:12] tfinc: there is a patch for review that enables tracking on prod. Once it's merged we should see data come in. [20:29:20] bmansurov: who do we need to approve it ? [20:29:24] Deskana: --^ [20:29:33] tfinc: https://gerrit.wikimedia.org/r/#/c/203250/ Anyone, Adam can do it. [20:31:04] kaldari: is there a reason why? Is there anything that needs to be improved? Just to be clear: Talk pages (i think you know that, but just to make clear :)) are essential in the wikipedia community world, and it's like a pain in the ass, that we're developing new features like WikiGrok, Gather and so on (which are cool features nontheless), and aren't able to get talk pages on mobile :( [20:31:04] bmansurov: as long as Deskana is ok with it then lets get it out ASAP [20:31:38] tfinc: sounds good [20:31:48] Deskana: here is the patch https://gerrit.wikimedia.org/r/#/c/203250/ [20:35:09] bgerstle: here is the link to the patch where my map function is broken… https://github.com/coreyfloyd/fastlane/tree/feature/xctest-report-paths [20:35:20] FlorianSW: did you write the comment on how to detect mobile without outputDocument context? [20:35:23] 6Mobile-Web, 10MobileFrontend, 7Mobile: Figure out how to determine if page is visited in mobile mode from onParserFirstCallInit - https://phabricator.wikimedia.org/T95918#1204536 (10TheDJ) You can just use the global $wgOut, but we are trying to get away from globals like that, so it's good that you bring i... [20:35:46] physikerwelt: jap [20:35:51] 10Gather, 3Gather Sprint Forward, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1204539 (10JKatzWMF) @phuedx, only user-facing implication is different url? works for me! let's call it Special:Tags [20:36:03] it does not seem to work for me [20:36:34] can you imagine a way to create a testcase for that [20:36:57] maybe in the context of the mobile extension... [20:37:12] FlorianSW: The main issues are that (1) it opens up a significant new area for maintanence and feature requests, and thus might impact existing work that has already been prioritized, and (2) we need to get a better idea of the timeframe for the implementation of Flow on mobile. So I think it isn’t so much that the feature isn’t wanted; It’s more a question of timing. Maybe the PM, JonKatz, can elaborate further. [20:37:20] physikerwelt: see the comment of thedj, i think he is right, but i don't know enough about the math extension :/ What does the user option control? Maybe that is a better point to work on? [20:38:14] kaldari: ok, thanks for the info :) [20:38:22] Can you give me a pointer to what you are referring [20:39:14] ^^https://gerrit.wikimedia.org/r/#/c/203857/3/Math.hooks.php that my test for detecting mobileview... but it never died in my tests [20:39:26] hi FlorianSW, just confirming what kaldari said. I'm not sure I even have anything to add. Kaldari is very eloquent [20:40:17] (03CR) 10Bmansurov: Beta: Make banner image width match content width (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [20:40:37] JonKatz: ok :P Fingers crossed, that we find a solution as soon as possible :) [20:40:41] coreyfloyd: y u no link to LOC? [20:41:01] huh? [20:41:14] FlorianSW can you ping me with the specific task? [20:41:30] coreyfloyd: is this it? https://github.com/coreyfloyd/fastlane/commit/ac08a5fd5e8950f3c9c2c055f1c267519d3f4274#diff-6068f34d3ade6167ee700963b4ace891R126 [20:41:36] coreyfloyd: also, y u no reduce? [20:41:48] JonKatz: sure: https://phabricator.wikimedia.org/T54165 [20:41:50] 10MobileFrontend-Feature-requests: Make minerva a presentable desktop skin - https://phabricator.wikimedia.org/T72142#1204576 (10kaldari) This should be made into a proper tracking bug with blocking bugs rather than listing all the blockers in the description. Many of the issues listed already have bugs filed. [20:42:01] JonKatz: it's a big deal for the community, at least dewiki :) [20:42:20] coreyfloyd: try doing "return reportString" at the end of the function [20:42:41] it's probably breaking because there's no return value if :screenshot isn't in the params [20:42:48] (03CR) 10Bmansurov: [C: 04-1] "Also, is there a phab ticket on the issue you worked on? It would be nice to link to the issue so that we know how this patch is solving t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) (owner: 10Jdlrobson) [20:43:40] bgerstle: i did - it didn’t work either [20:43:45] hrm.. [20:43:51] will look at reduce [20:44:36] coreyfloyd: http://ruby-doc.org/core-2.1.0/Enumerable.html#method-i-reduce [20:45:18] (03PS1) 10Mholloway: Right-align entries for RTL languages in Wikipedia language menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203947 (https://phabricator.wikimedia.org/T95895) [20:45:42] bmansurov: I can't +2 a config change, that's outside my area of expertise. :-) [20:46:22] Deskana: oh I see. Are you OK with the change though? [20:46:52] coreyfloyd: ahh, because you need to have the extension be on a per-report basis [20:46:54] hrm [20:47:01] still, could be done w/ reduce [20:47:08] 10MobileFrontend-Feature-requests, 7Tracking: [tracking] Make minerva a presentable desktop skin - https://phabricator.wikimedia.org/T72142#1204603 (10kaldari) [20:47:46] FlorianSW I am going to reveal my ignorance here: don't we have a talk button at the bottom of the page already? [20:49:23] JonKatz: only in beta/alpha, not in stable :) [20:49:23] (03CR) 10Bmansurov: [C: 04-1] "I don't think it depends on anything anymore, thus the commit message needs an update." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [20:49:23] so this is just pushing it to stable. are we tracking the usage? [20:49:23] FlorianSW^^ [20:49:23] JonKatz: correct, iirc yes, give me a minute to check [20:49:32] 6Mobile-Web, 10MobileFrontend, 7Mobile: Figure out how to determine if page is visited in mobile mode from onParserFirstCallInit - https://phabricator.wikimedia.org/T95918#1204615 (10Physikerwelt) @TheDJ: What is the MF reformatter. I did some tests https://gerrit.wikimedia.org/r/#/c/203857/3/Math.hooks.php... [20:49:39] (03PS12) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [20:49:53] bmansurov: Well, that depends what you mean with "OK"! [20:49:53] bmansurov: I'm definitely wanting the search data. But I haven't/can't review the relevant code. [20:49:53] bmansurov: I'm happy to note as such on the patch. [20:50:02] JonKatz: oops, nope we don't log the usage atm :/ [20:50:04] bmansurov: am really confused with https://gerrit.wikimedia.org/r/#/c/203863/2 - what's not clear? [20:50:31] Deskana: what kind of data do you need? I can get some data from the event logging server. [20:50:43] 3Gather Sprint Enwiki: PM Spike: talk to wikigrok team about using backend for flag heuristics - https://phabricator.wikimedia.org/T94875#1204617 (10JKatzWMF) no, this can definnitely wait. I will put it in backlog. [20:51:18] jdlrobson: it doesn't completely fix the bug it claims to fix [20:51:18] (03PS13) 10Kaldari: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) [20:51:19] 10Gather: PM Spike: talk to wikigrok team about using backend for flag heuristics - https://phabricator.wikimedia.org/T94875#1204618 (10JKatzWMF) [20:51:22] bmansurov: it does.. it rewrites it as a View [20:51:23] title is "ButtonWithSpinner is not a true View" [20:51:37] jdlrobson: what about removing oojs ui as a dependency? [20:51:39] bmansurov: Really? I thought this config change was meant to generate data for the Search schema? There's no data in EventLogging for that. [20:51:40] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6CA-team, 10MediaWiki-API, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1204620 (10Etonkovidova) I checked it with 2.0-alpha-2015-04-02. My steps: 1. I logged to the apps with my credentials. 2.... [20:51:49] bmansurov: that's a lot more hard and will require a follow up [20:52:08] (03PS1) 10Robmoen: Add moderation expectations to Special:GatherLists for admins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 [20:52:11] i'm chatting to phuedx some time this week about how we can sort out the oojs stuff [20:52:11] Deskana: yes, the search schema data. [20:52:33] jdlrobson: then you should update the commit message [20:53:40] bmansurov: the commit message doesn't say anything about oojs ui [20:53:40] jdlrobson: it links to the bug [20:53:40] so..? the commit message says exactly what this patch does. [20:53:40] the bug is just linked to for further information [20:53:40] it's an associated artifact [20:53:40] physikerwelt: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php that's the mobile reformatter (if i understand thedj correctly :)) [20:53:45] JonKatz: Did you ever get to talk with Danny about mobile Flow? [20:54:22] jdlrobson: ok, I see. I thought it was solving the problem in the bug as we usually do by linking to the bug. [20:54:29] 6Mobile-Web, 10MobileFrontend, 7Mobile: Figure out how to determine if page is visited in mobile mode from onParserFirstCallInit - https://phabricator.wikimedia.org/T95918#1204627 (10Florian) @Physikerwelt: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.... [20:54:40] (03CR) 10Bmansurov: Hygiene: Write ButtonWithSpinner as a View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) (owner: 10Jdlrobson) [20:54:44] bmansurov: not all patches completely solve a bug.. :) [20:54:56] jdlrobson: got it, thanks [20:55:01] i can create another bug if that makes things clearer [20:56:06] 6Mobile-Web, 5Patch-For-Review: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1204628 (10Jdlrobson) [20:56:37] https://phabricator.wikimedia.org/T95952 < bmansurov hope that's better [20:57:08] physikerwelt: sorry i missed your message did FlorianSW help you out? [20:58:24] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6CA-team, 10MediaWiki-API, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1204643 (10bearND) @Etonkovidova Good. I see it used the IP address. That means you can repro the issue with an apk from the... [20:58:59] Deskana: to clarify, we use the event logging extension to generate the data for the schema. [20:59:10] bmansurov: So what is this config change, then? The change to turn that on? [20:59:28] Deskana: yes, it will turn on collecting the data on prod. [20:59:34] 10MobileFrontend-Feature-requests, 7Tracking: [tracking] Make minerva a presentable desktop skin - https://phabricator.wikimedia.org/T72142#1204651 (10Jdlrobson) Agreed. Go for it :) This also needs a major update. Maybe consider creating a new task and replacing this one. [20:59:37] Deskana: currently, it's turned on on labs [20:59:53] bmansurov: Excellent, then I understand correctly. :-) [21:00:13] Deskana: do you know who may be able to +2 the patch? Adam? [21:00:37] bmansurov: That I do not know. :-) [21:00:51] Deskana: ok thanks [21:01:13] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1204653 (10Jdlrobson) @rmoen @JKatzWMF is the text "... for Gather Collections Moderation" or "... for collections" We shouldn't title case i18n message... [21:01:49] 10Gather, 3Gather Sprint Forward: Tweak the search in EditorOverlay behaviour - https://phabricator.wikimedia.org/T95778#1204656 (10Jdlrobson) a:3Jdlrobson [21:02:12] Deskana: so what kind of data do you need? I maybe able to get you some. [21:03:45] (03CR) 10Jdlrobson: [C: 04-1] Make all headings with class section-heading toggleable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:05:12] (03CR) 10Bene: Make all headings with class section-heading toggleable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:05:14] (03CR) 10Bmansurov: [C: 032] Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [21:05:29] hi floriansw, I am not using data to pause you...danny says flow as default enwp is a long ways off [21:05:33] (03PS1) 10Bene: Get rid of $wgMFPageSections config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) [21:06:07] gimme a couple of days to mull on it, again, I and my team are stretched very thin, so this isn't so much about not wanting to do it as not having the bandwidth. [21:06:39] JonKatz: ok, awaiting your thoughts :) [21:07:32] (03CR) 10Jdlrobson: [C: 032] "Not seeing any issues." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203875 (https://phabricator.wikimedia.org/T95018) (owner: 10Jhernandez) [21:07:35] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1204677 (10dr0ptp4kt) @Fjalapeno and I discussed on video. I've requested a Google Group for continuous integration stuff. For user feedback, the plan is to use the iOS OTRS queue email a... [21:07:38] (03PS2) 10Bene: Make all headings with class section-heading toggleable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) [21:09:00] (03CR) 10Robmoen: [C: 032] Tools: Don't force tests to validate to JSDoc rules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203190 (owner: 10Jdlrobson) [21:09:04] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1204684 (10Mholloway) a:3Mholloway [21:09:20] (03PS5) 10Mhurd: Fix for side to side scrolling of wide images with div overlays. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 [21:09:50] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Spike [1 hour]: As a Mobile Apps Team, I would like to be alerted when something is going catastrophically wrong with the app in production, so we can fix it for our users (Monitoring/Alerting) - https://phabricator.wikimedia.org/T95941#1204686 (10dr0ptp4kt) @Des... [21:09:54] (03PS2) 10Jdlrobson: Add i18n messages for login signup [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203836 (https://phabricator.wikimedia.org/T95729) [21:10:29] (03CR) 10Jdlrobson: [C: 032] Make all headings with class section-heading toggleable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:10:50] (03PS3) 10Jdlrobson: Prevent auto-reopening of collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203842 (https://phabricator.wikimedia.org/T95744) [21:10:58] 10Wikipedia-iOS-App, 6translatewiki.net, 5Patch-For-Review: Adjust TWN sync to new Wikipedia folder on iOS - https://phabricator.wikimedia.org/T95795#1204691 (10Deskana) 5Open>3Resolved [21:11:18] MaxSem: you about ? [21:11:30] yup, tfinc [21:11:42] (03CR) 10Florianschmidtwelzow: [C: 04-1] "two minor things" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [21:11:44] MaxSem: join us https://plus.google.com/hangouts/_/wikimedia.org/osm-wikipedia [21:11:48] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Spike [1 hour]: As a Mobile Apps Team, I would like to be alerted when something is going catastrophically wrong with the app in production, so we can fix it for our users (Monitoring/Alerting) - https://phabricator.wikimedia.org/T95941#1204698 (10bearND) See als... [21:11:58] (03PS2) 10Robmoen: Fix jscs coding style issues [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203460 [21:12:26] "This video call isn't available right now. Try again in a few minutes." [21:12:32] tfinc, ^ [21:12:41] (03CR) 10Jdlrobson: [C: 031] Add support for extensions to add custom login messages for mobile login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203893 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [21:12:47] MaxSem: invite sent [21:13:06] (03CR) 10jenkins-bot: [V: 04-1] Make all headings with class section-heading toggleable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:13:11] (03CR) 10Jdlrobson: [C: 032] Fix jscs coding style issues [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203460 (owner: 10Robmoen) [21:13:13] (03PS2) 10Robmoen: Return listpages results in query object [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 [21:13:18] (03CR) 10Florianschmidtwelzow: Make all headings with class section-heading toggleable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:13:46] bgerstle: coreyfloyd mhurd - Deskana is already looking into https://phabricator.wikimedia.org/T95941#1204686 , so no need to do anything with it right now [21:13:50] kristenlans: ^ fyi [21:13:59] (03CR) 10Florianschmidtwelzow: [C: 032] Make all headings with class section-heading toggleable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:14:01] 10Wikipedia-iOS-App: Image Gallery: Description text is cut off - https://phabricator.wikimedia.org/T95771#1204705 (10Deskana) The "one true solution" to this is T94495 [21:14:06] dr0ptp4kt: k [21:14:10] (03PS2) 10Bene: Get rid of $wgMFPageSections config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) [21:14:10] 10Wikipedia-iOS-App: Image Gallery: Description text is cut off - https://phabricator.wikimedia.org/T95771#1204707 (10Deskana) [21:14:16] thanks dr0ptp4kt [21:14:21] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Lack of continuity between image captions and gallery descriptions in Android/IOS App - https://phabricator.wikimedia.org/T94495#1165109 (10Deskana) [21:14:25] (03CR) 10Bene: Get rid of $wgMFPageSections config (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [21:15:30] jdlrobson FlorianSW: I didn't expect to get the patches on MobileFrontend merged faster then those on Wikibase :O [21:15:42] best developer experience ever :D [21:15:48] (03PS1) 10Jdlrobson: Make search feel smoother [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203955 [21:15:50] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1204712 (10rmoen) @Jdlrobson @JKatzWMF +1 changing to "Before hiding or un-hiding a list, please refer to the [[beta protocol]] for collections moderati... [21:15:52] 10Wikipedia-iOS-App: Graphical timelines should be displayed in Image Galery - https://phabricator.wikimedia.org/T95748#1204713 (10Deskana) p:5Triage>3Low [21:16:11] (03PS2) 10Robmoen: Add moderation expectations to Special:GatherLists for admins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 [21:16:27] yeah, that was the same experienced as i started here, big advantages of having jdlrobson :D [21:16:36] benestar: ^ [21:16:38] +1 [21:16:39] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: EventLogging to evaluate success/failure of link hovering prototype - https://phabricator.wikimedia.org/T95726#1204716 (10Deskana) a:3Deskana [21:16:45] * benestar gives kudos to jdlrobson [21:16:55] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: EventLogging to evaluate success/failure of link hovering prototype - https://phabricator.wikimedia.org/T95726#1198698 (10Deskana) This one is mine and I am working with @leila on it. [21:17:51] 6Mobile-Web, 10MobileFrontend, 7Mobile: Figure out how to determine if page is visited in mobile mode from onParserFirstCallInit - https://phabricator.wikimedia.org/T95918#1204721 (10Physikerwelt) See https://gerrit.wikimedia.org/r/#/c/203857/3/Math.hooks.php (line 100) the user has an option math, the next... [21:18:03] 10Wikipedia-iOS-App: 4.1.1(76) - clicking links in offline mode saved them in Recent - https://phabricator.wikimedia.org/T95585#1204723 (10Deskana) p:5Triage>3Normal We should take care of this one pretty soon. [21:18:11] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.1.1(76) - clicking links in offline mode saved them in Recent - https://phabricator.wikimedia.org/T95585#1204725 (10Deskana) [21:18:21] (03PS5) 10Robmoen: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [21:18:52] (03CR) 10Florianschmidtwelzow: [C: 031] Get rid of $wgMFPageSections config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [21:18:57] 10Wikipedia-iOS-App: Bogus intermittent network connection loss - https://phabricator.wikimedia.org/T95514#1204730 (10Deskana) 5Open>3stalled This is difficult to handle with no steps to reproduce. Marking as stalled. :-( [21:19:26] (03CR) 10Krinkle: [C: 032] "QUnit timed out due to heavy load on Jenkins slave's Apache." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:19:58] (03CR) 10Bmansurov: [C: 032] Filter out retired WikiGrok claims from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [21:20:14] (03CR) 10jenkins-bot: [V: 04-1] Make search feel smoother [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203955 (owner: 10Jdlrobson) [21:20:17] 10Wikipedia-iOS-App: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1204739 (10Deskana) These boxes are not there on Android. @etonkovidova will re-verify that this is still a problem on iOS. [21:21:08] (03PS2) 10Jdlrobson: Make search feel smoother [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203955 [21:21:30] (03Merged) 10jenkins-bot: Fixing styling of intro and thanks panes in WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201862 (https://phabricator.wikimedia.org/T94764) (owner: 10Kaldari) [21:21:32] (03CR) 10jenkins-bot: [V: 04-1] Fix scrolling of main page on iOS 8 modals [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203875 (https://phabricator.wikimedia.org/T95018) (owner: 10Jhernandez) [21:21:34] (03Merged) 10jenkins-bot: Tools: Don't force tests to validate to JSDoc rules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203190 (owner: 10Jdlrobson) [21:21:37] (03Merged) 10jenkins-bot: Fix jscs coding style issues [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203460 (owner: 10Robmoen) [21:21:45] (03CR) 10Jdlrobson: [C: 031] Fix scrolling of main page on iOS 8 modals [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203875 (https://phabricator.wikimedia.org/T95018) (owner: 10Jhernandez) [21:21:48] (03PS2) 10Jdlrobson: Fix scrolling of main page on iOS 8 modals [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203875 (https://phabricator.wikimedia.org/T95018) (owner: 10Jhernandez) [21:21:53] (03CR) 10Jdlrobson: [C: 032] Fix scrolling of main page on iOS 8 modals [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203875 (https://phabricator.wikimedia.org/T95018) (owner: 10Jhernandez) [21:21:59] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Disambiguation Pages should not appear in Read More - https://phabricator.wikimedia.org/T95365#1204749 (10Deskana) a:5Deskana>3None [21:22:03] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 10WikiGrok: WikiGrok must not load when there are no suggestions. - https://phabricator.wikimedia.org/T95722#1204751 (10bmansurov) a:3bmansurov [21:22:25] (03PS1) 10Kaldari: Don't let the Wikitext editor over-expand [extensions/MobileFrontend] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203959 (https://phabricator.wikimedia.org/T95465) [21:23:18] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Disambiguation Pages should not appear in Read More - https://phabricator.wikimedia.org/T95365#1187886 (10Deskana) This would be nice. Is there an API module that lets you resolve whether a page is a disambiguation page or not? @dbrant may know, I recall chatting t... [21:24:18] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 10WikiGrok: WikiGrok must not load when there are no suggestions. - https://phabricator.wikimedia.org/T95722#1204768 (10bmansurov) [21:24:18] good night all :) [21:25:11] vibha: Deskana i marked https://phabricator.wikimedia.org/T95736 to be blocked on design (sorry if i'm not supposed to to that!) could you check my comments on the card when you have a chance? [21:25:22] (03CR) 10jenkins-bot: [V: 04-1] Get rid of $wgMFPageSections config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [21:26:04] (03Merged) 10jenkins-bot: Filter out retired WikiGrok claims from WikiGrok pages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201071 (https://phabricator.wikimedia.org/T94445) (owner: 10Bmansurov) [21:26:05] 10Wikipedia-iOS-App: Bogus intermittent network connection loss - https://phabricator.wikimedia.org/T95514#1204772 (10Fjalapeno) @Deskana can we try do my suggested action to proactively try to track this down? [21:26:14] 10Wikipedia-iOS-App: iOS app jumps unexpectedly during scrolling on page linked with section hash - https://phabricator.wikimedia.org/T74797#1204774 (10Deskana) @etonkovidova Will verify this since it's so old. [21:26:48] 10Gather, 3Gather Sprint Forward: Do not show a "public" icon on Gather collections - https://phabricator.wikimedia.org/T95639#1204783 (10rmoen) a:3rmoen [21:26:50] 10Wikipedia-iOS-App: Bogus intermittent network connection loss - https://phabricator.wikimedia.org/T95514#1204784 (10Deskana) @Fjalapeno That sounds nice. Can you set up a card for that and put it in the backlog? [21:27:02] (03Merged) 10jenkins-bot: Fix scrolling of main page on iOS 8 modals [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203875 (https://phabricator.wikimedia.org/T95018) (owner: 10Jhernandez) [21:27:45] 10Wikipedia-iOS-App, 7I18n: iOS app: contributors and libraries lists in the credits screen must be forced to LTR direction - https://phabricator.wikimedia.org/T74608#1204789 (10Deskana) p:5Triage>3Low This is a very rarely accessed part of the app, so this isn't much of a priority. [21:27:54] 10Wikipedia-iOS-App, 7Easy, 7I18n: iOS app: contributors and libraries lists in the credits screen must be forced to LTR direction - https://phabricator.wikimedia.org/T74608#1204792 (10Deskana) [21:27:59] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Inform the user, when there is a new message on their talk page - https://phabricator.wikimedia.org/T95396#1204793 (10bearND) [21:28:07] mhurd: will do [21:28:11] looking at it now [21:28:46] 10Wikipedia-iOS-App: Bogus intermittent network connection loss - https://phabricator.wikimedia.org/T95514#1204801 (10Fjalapeno) @Deskana will do! I will just repurpose this card to make it work. [21:29:30] 6Mobile-Web, 10WikiGrok: Consolidate similar config variables - https://phabricator.wikimedia.org/T95956#1204805 (10bmansurov) 3NEW [21:30:18] 10Wikipedia-iOS-App: The page gets deleted from Recent sections too, if deleted for the "Saved Pages" section - https://phabricator.wikimedia.org/T74412#1204821 (10Deskana) This should've been fixed with the advent of the new file system. @etonkovidova will verify. [21:30:56] 10Wikipedia-iOS-App: Icons are too big for Tablet - https://phabricator.wikimedia.org/T74916#1204828 (10Deskana) [21:30:57] 10Wikipedia-iOS-App: UI/toolbar/button scaling too extreme on iPad - https://phabricator.wikimedia.org/T73759#1204827 (10Deskana) [21:32:10] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1204840 (10Mhurd) a:3Mhurd [21:34:32] 10Wikipedia-Android-App: IllegalStateException: Recursive entry to executePendingTransactions from page.gallery.GalleryActivity.onBackPressed - https://phabricator.wikimedia.org/T94726#1171155 (10Deskana) User was trying to pinch to zoom. [21:34:39] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: IllegalStateException: Recursive entry to executePendingTransactions from page.gallery.GalleryActivity.onBackPressed - https://phabricator.wikimedia.org/T94726#1204874 (10Deskana) [21:35:58] 10Wikipedia-Android-App: Add a screen dimmer lock - https://phabricator.wikimedia.org/T94677#1204887 (10Deskana) 5Open>3declined a:3Deskana I agree with @dbrant. This isn't something that should be handled by the app. It should be handled by the OS. [21:36:32] 10Wikipedia-Android-App: make lead image load faster from history - https://phabricator.wikimedia.org/T94633#1204890 (10Deskana) [21:36:43] 10Wikipedia-Android-App: make lead image load faster from history - https://phabricator.wikimedia.org/T94633#1168659 (10Deskana) I've changed the title of the bug to be more representative of the actual request. [21:37:04] (03PS1) 10Robmoen: Remove privacy tag from public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203966 [21:37:08] 6Mobile-Web, 10WikiGrok: WIkiGrok doesn't save when not logged in - https://phabricator.wikimedia.org/T95960#1204899 (10bmansurov) 3NEW [21:37:33] 10Wikipedia-iOS-App: [SPIKE] Investigate bogus intermittent network connection loss - https://phabricator.wikimedia.org/T95514#1204907 (10Fjalapeno) 5stalled>3Open [21:37:51] 10Wikipedia-iOS-App: Icons are too big for Tablet - https://phabricator.wikimedia.org/T74916#1204912 (10Mhurd) While we may need to tweak the icon scale a bit, which is easy to do, the reason the native chrome icons may seem a bit disproportionately large is this - at present on iOS we're not scaling the non-nat... [21:37:52] Deskana: what backlog do you want that in? [21:37:57] ^ [21:38:19] coreyfloyd: Hmm, bug backlog I think. [21:38:21] coreyfloyd: Thank you, sir. [21:38:33] Deskana: got it - np [21:39:15] 10Wikipedia-Android-App: Deep Linking to apps is buggy from google search results on chrome on Android Devices - https://phabricator.wikimedia.org/T94538#1204914 (10Deskana) 5Open>3Invalid It's my understanding that if you previously chose "Always open in Chrome" then it will always open in Chrome, even if y... [21:39:48] Deskana: i added a comment to https://phabricator.wikimedia.org/T74916 [21:40:58] 10Wikipedia-iOS-App: [SPIKE] Investigate bogus intermittent network connection loss - https://phabricator.wikimedia.org/T95514#1204920 (10Fjalapeno) [21:41:10] 10Wikipedia-Android-App: Android app shows old versions of articles - https://phabricator.wikimedia.org/T94406#1204921 (10Deskana) 5Open>3stalled @Thgoiter Can you give us specific steps to reproduce? @etonkovidova Can you check this for us and try to verify and give extra steps? [21:42:47] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1204925 (10rmoen) a:5MSyed>3rmoen [21:43:05] 10Wikipedia-Android-App: Android app shows old versions of articles - https://phabricator.wikimedia.org/T94406#1204926 (10Deskana) 5stalled>3Resolved a:3Deskana @etonkovidova actually tested this today and said there were no issues. Feel free to reopen if you're still experiencing this issue with the lates... [21:43:16] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1174892 (10rmoen) Thanks @MSyed. Stealing this from you now. Go back to vacationing ;) [21:43:59] (03CR) 10Jdlrobson: [C: 04-1] Remove privacy tag from public collection (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203966 (owner: 10Robmoen) [21:45:11] (03CR) 10Jdlrobson: [C: 04-1] Add moderation expectations to Special:GatherLists for admins (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 (owner: 10Robmoen) [21:46:30] Deskana: looks like I got some connection issues [21:46:39] bearND: o rly [21:46:45] bearND: Hah, we'll carry on in the mean time. :-) [21:46:47] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Create change log for CI builds - https://phabricator.wikimedia.org/T94423#1204947 (10KLans_WMF) [21:47:43] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Select icon file based on build type (alpha, beta, etc) on build server - https://phabricator.wikimedia.org/T94534#1204958 (10KLans_WMF) [21:48:54] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Fix for extra whitespace around small images regression - https://phabricator.wikimedia.org/T95738#1204966 (10KLans_WMF) [21:49:36] bearND: hi! [21:49:52] I used the alpha build expensively (in 15 minutes :) ) [21:49:56] Sent you a bunch of notes [21:50:08] vibha is bearND making you pay for alpha builds? :-P [21:50:12] (03PS3) 10Florianschmidtwelzow: Make all headings with class section-heading toggleable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:50:36] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Disable hockey update checking - https://phabricator.wikimedia.org/T95602#1204974 (10KLans_WMF) [21:52:25] 10Wikipedia-Android-App: SecurityException: Neither user nor current process has android.permission.WAKE_LOCK - https://phabricator.wikimedia.org/T86440#1204985 (10Deskana) 5Open>3stalled We have absolutely no idea what to do about this. We don't even require this permission. [21:52:30] bgerstle: lol [21:53:21] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review, 3Wikimedia-Hackathon-2015-App-Prep: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1204993 (10KLans_WMF) [21:54:00] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [21:54:04] (03CR) 10Florianschmidtwelzow: Make all headings with class section-heading toggleable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:54:12] (03CR) 10Florianschmidtwelzow: [C: 032] "resubmit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [21:54:55] 10Wikipedia-Android-App, 6Mobile-Apps: Suggestions to improve Saved pages function - https://phabricator.wikimedia.org/T85107#1204999 (10Deskana) @Florian Can we please break this up into separate items? [21:55:00] (03PS3) 10Robmoen: Add moderation expectations to Special:GatherLists for admins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 [21:55:42] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.0.7.8 - NSURLErrorDomain error code -999 with the first login - https://phabricator.wikimedia.org/T93789#1205001 (10KLans_WMF) [21:56:18] 10Wikipedia-Android-App: pages should indicate whether they have been saved no matter how you got there - https://phabricator.wikimedia.org/T85066#1205004 (10Deskana) >>! In T85066#966778, @Deskana wrote: > Tracked here: https://trello.com/c/B8ggC5RW/26-navigating-to-a-saved-page-should-always-try-using-cached-c... [21:56:37] 10Wikipedia-Android-App: navigating to a saved page should always try using cached copy as last resort before network error - https://phabricator.wikimedia.org/T85065#1205006 (10Deskana) p:5High>3Low [21:57:41] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1205019 (10KLans_WMF) [21:58:14] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.0.7.10 articles in Recent do not display thumbnail images - https://phabricator.wikimedia.org/T95114#1205023 (10KLans_WMF) [21:58:32] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1205025 (10Mholloway) Per Bernd's link above, Picasso will simply use OkHttp's disk cache, if configured, so limiting its size looks like a matter of adjusting... [21:58:51] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203893 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [21:58:58] (03PS2) 10Florianschmidtwelzow: Login messages: Add support for MobileFrontend loginpage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203894 (https://phabricator.wikimedia.org/T95903) [22:03:48] (03CR) 10jenkins-bot: [V: 04-1] Login messages: Add support for MobileFrontend loginpage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203894 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [22:06:26] (03CR) 10jenkins-bot: [V: 04-1] Add support for extensions to add custom login messages for mobile login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203893 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [22:08:51] (03Merged) 10jenkins-bot: Make all headings with class section-heading toggleable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203880 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [22:09:45] bgerstle: hah! I meant extensively [22:09:59] But its not a bad idea - honestly. [22:12:57] (03PS1) 10Kaldari: Fixing EventLogging Schema error on submission failure [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203971 [22:13:22] 6Mobile-Web: Merge OOJS UI and MobileFrontend View code - https://phabricator.wikimedia.org/T95952#1205068 (10Jdlrobson) [22:13:24] 6Mobile-Web: Merge OOJS UI and MobileFrontend View code - https://phabricator.wikimedia.org/T95952#1204634 (10Jdlrobson) Sigh no idea what happened there. [22:17:47] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1205105 (10bearND) @Mholloway I guess you want to browse to a lot of pages and see if the app cache stops growing at some point. It would be good to (at least... [22:18:46] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1205107 (10bearND) [22:18:58] (03PS1) 10Bmansurov: Do not load WikiGrok dialog if there are no suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203974 (https://phabricator.wikimedia.org/T95722) [22:19:31] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1179645 (10bearND) Moved this to sprint 55 since the previous patch was probably one the first step. We may want to add some more diagnostics if we can. [22:22:13] dr0ptp4kt: mhurd out for dinner and a dog walk. Will be back on a bit before 5. [22:22:21] coreyfloyd: k [22:22:22] ttfn coreyfloyd [22:24:17] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Initial banner image should be delivered as part of the initial response - https://phabricator.wikimedia.org/T90698#1205144 (10bmansurov) a:3bmansurov [22:25:31] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1205152 (10dr0ptp4kt) The CI email address is ticket 6701. [22:26:52] 6Mobile-Web, 3Mobile-Web-Design: Stop serving menu in the page HTML - https://phabricator.wikimedia.org/T95332#1205156 (10Jdlrobson) Exactly. It sounds like the design for the main menu is in flux but moving to templates will make this easier to manage in future. [22:27:32] kaldari: https://gerrit.wikimedia.org/r/#/c/203250/ this is the mediawiki-config patch i just mentioned. [22:27:44] 10Gather, 3Gather Sprint Forward, 10MediaWiki-Database, 7database: Bug: DB gather_list.gl_id autonumber is always odd - https://phabricator.wikimedia.org/T94512#1205157 (10Jdlrobson) Thanks for the detective work @aaron ! I'm sure this will help somewhat. [22:30:23] (03PS2) 10Robmoen: Remove privacy tag from public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203966 [22:31:52] (03PS3) 10Robmoen: Remove privacy tag from public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203966 [22:37:42] 10Gather, 3Gather Sprint Forward: When search returns no results no behaviour defined. - https://phabricator.wikimedia.org/T95966#1205174 (10Jdlrobson) 3NEW a:3Jdlrobson [22:38:18] (03PS1) 10Jdlrobson: Open search interface full screen when focused [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203978 (https://phabricator.wikimedia.org/T95778) [22:38:20] (03PS1) 10Jdlrobson: Add clear button to search within editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203979 (https://phabricator.wikimedia.org/T95778) [22:40:34] 10Gather, 3Gather Sprint Forward, 7Easy: Hidden collections show as private in my list of collections - https://phabricator.wikimedia.org/T95967#1205197 (10Jdlrobson) 3NEW [22:41:12] 10Gather, 3Gather Sprint Forward: Bug: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1205206 (10Jdlrobson) #easy [22:41:18] 10Gather, 3Gather Sprint Forward: Bug: When public user visits another users collections page the Page header says "[usernames] collections" - https://phabricator.wikimedia.org/T93618#1205208 (10Jdlrobson) #easy [22:41:21] 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1205210 (10Jdlrobson) #easy [22:41:49] (03CR) 10Jdlrobson: [C: 032] Remove privacy tag from public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203966 (owner: 10Robmoen) [22:42:51] (03CR) 10Jdlrobson: Add moderation expectations to Special:GatherLists for admins (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 (owner: 10Robmoen) [22:43:14] (03CR) 10jenkins-bot: [V: 04-1] Add clear button to search within editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203979 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [22:43:21] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review, 3Wikimedia-Hackathon-2015-App-Prep: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1205213 (10BGerstle-WMF) @dr0ptp4kt can you test this? after wiping you... [22:43:43] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review, 3Wikimedia-Hackathon-2015-App-Prep: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1205214 (10BGerstle-WMF) [22:44:49] dr0ptp4kt: fyi I pinged you in https://phabricator.wikimedia.org/T94229#1205213, if you can try it out after installing Yosemite we can move the card to "Done" [22:44:52] bgerstle: any chance i could try make bootstrap on my current machine, which has lots of this same kind of stuff? or is it guaranteed to break down. if i can avoid dirtying the new pristine os, that will be all for the better. if you're telling me i have no choice and will eventually have to direty the pristine os, well ho hum, so be it [22:44:55] HAHAHA [22:44:57] wow [22:45:00] what are the odds of that [22:45:13] oh wait [22:45:15] n/m [22:45:29] i thought you were asking me if you could try it on your machine *after* wiping (which is what i was suggesting) [22:45:45] dr0ptp4kt: it depends how your current machine is setup [22:45:56] the goal isn't designed to be run on a machine that's already setup [22:46:03] bgerstle: well, naturally, it has all of these things already installed in an incoherent fashion [22:46:17] dr0ptp4kt: right [22:46:25] dr0ptp4kt: i've been meaning to get a virtual OSX setup on my machine anyway [22:46:36] once i do that i can test this [22:46:53] might not be for a while though.. [22:47:12] dr0ptp4kt: we can move this card to "done" and file another ticket to "test make bootstrap" as part of the hackathon prep [22:47:25] bgerstle: yes, please [22:47:28] ok [22:47:29] jdlrobson, hi, any updates on my patch? [22:47:51] (03CR) 10Jdlrobson: [C: 04-1] Implements prop=listmembership (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [22:47:58] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review, 3Wikimedia-Hackathon-2015-App-Prep: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1205220 (10BGerstle-WMF) moving to done and filing another ticket to te... [22:48:04] LOLOLOL [22:48:13] 10Wikipedia-iOS-App, 7Documentation, 3Wikimedia-Hackathon-2015-App-Prep: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1205223 (10BGerstle-WMF) [22:48:15] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review, 3Wikimedia-Hackathon-2015-App-Prep: As a contributor, I can run a Make goal to install system dependencies. - https://phabricator.wikimedia.org/T94229#1205222 (10BGerstle-WMF) 5Open>3Resolved [22:48:17] seriously? 29 seconds? [22:48:50] jdlrobson, what dev is needed??? [22:49:09] oh, i see the review, sec [22:49:20] (03Restored) 10Bmansurov: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [22:49:28] (03PS11) 10Bmansurov: WIP: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [22:49:55] 10Gather, 3Gather Sprint Forward: Bug: Long titles should be clipped in EditorOverlay - https://phabricator.wikimedia.org/T95788#1205226 (10Jdlrobson) [22:50:05] 10Gather, 3Gather Sprint Forward: Bug: Long titles should be clipped in EditorOverlay - https://phabricator.wikimedia.org/T95788#1200248 (10Jdlrobson) a:3Jdlrobson [22:50:16] 10Wikipedia-iOS-App, 3Wikimedia-Hackathon-2015-App-Prep: iOS project Makefile's bootstrap goal on a clean OSX machine - https://phabricator.wikimedia.org/T95968#1205230 (10BGerstle-WMF) 3NEW [22:50:23] dr0ptp4kt: ^ [22:50:31] dr0ptp4kt: mhurd coreyfloyd heading out for the day o./ [22:50:36] bgerstle: thx. peace out [22:50:46] bgerstle_afk: see ya! [22:51:42] 10Wikipedia-iOS-App, 3Wikimedia-Hackathon-2015-App-Prep: iOS project Makefile's bootstrap goal on a clean OSX machine - https://phabricator.wikimedia.org/T95968#1205230 (10BGerstle-WMF) [22:51:43] 10Wikipedia-iOS-App, 7Documentation, 3Wikimedia-Hackathon-2015-App-Prep: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1205242 (10BGerstle-WMF) [22:52:00] 10Wikipedia-iOS-App, 7Documentation, 3Wikimedia-Hackathon-2015-App-Prep: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1133022 (10BGerstle-WMF) [22:52:02] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Commit "Pods" folder to git - https://phabricator.wikimedia.org/T94039#1205244 (10BGerstle-WMF) 5Open>3Resolved [22:52:14] 10Wikipedia-iOS-App, 7Documentation, 3Mobile-App-Sprint-54-iOS, 5Patch-For-Review: Commit web "assets" folder to to git - https://phabricator.wikimedia.org/T94231#1205246 (10BGerstle-WMF) 5Open>3Resolved [22:52:15] 10Wikipedia-iOS-App, 7Documentation, 3Wikimedia-Hackathon-2015-App-Prep: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1133022 (10BGerstle-WMF) [22:55:31] (03PS1) 10Jdlrobson: Truncate edit overlay title where necessary [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203982 (https://phabricator.wikimedia.org/T95788) [22:56:57] (03PS2) 10Jdlrobson: Truncate edit overlay title where necessary [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203982 (https://phabricator.wikimedia.org/T95788) [22:59:15] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1205254 (10rmoen) @JKatzWMF @Jdlrobson: For schema, value for "groups that the user belongs to" is a comma separated list? eg: "autoconfirmed, admin" [23:00:32] (03CR) 10jenkins-bot: [V: 04-1] Truncate edit overlay title where necessary [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203982 (https://phabricator.wikimedia.org/T95788) (owner: 10Jdlrobson) [23:02:47] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Releasing - https://phabricator.wikimedia.org/T95969#1205258 (10dr0ptp4kt) 3NEW a:3dr0ptp4kt [23:03:12] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1205271 (10rmoen) Should this be in its own schema (GatherFlags) ? Or add a flag option to GatherClicks? [23:03:26] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Releasing Sprint 54 Work Product - https://phabricator.wikimedia.org/T95969#1205274 (10dr0ptp4kt) [23:05:22] (03Merged) 10jenkins-bot: Remove privacy tag from public collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203966 (owner: 10Robmoen) [23:08:28] (03PS1) 10Kaldari: Prevent database error resulting from duplicate unique key [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203989 (https://phabricator.wikimedia.org/T95068) [23:08:53] (03PS2) 10Jdlrobson: Truncate collection titles in toast [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203884 (https://phabricator.wikimedia.org/T93797) [23:09:17] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Do not show a "public" icon on Gather collections - https://phabricator.wikimedia.org/T95639#1205294 (10Jdlrobson) 5Open>3Resolved [23:11:23] (03CR) 10Jdlrobson: [C: 031] "Doesn't seem to break anything (nothing seems to be directly using it - all existing uses using generator)." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 (owner: 10Robmoen) [23:11:48] 10Gather, 3Gather Sprint Forward, 3Mobile-Web-Design: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1205309 (10Jdlrobson) a:5MSyed>3None [23:12:47] (03CR) 10jenkins-bot: [V: 04-1] Truncate collection titles in toast [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203884 (https://phabricator.wikimedia.org/T93797) (owner: 10Jdlrobson) [23:12:59] 10Gather, 3Gather Sprint Forward: Can create collection with non-main namespace pages but they do not show up - https://phabricator.wikimedia.org/T94786#1205315 (10Jdlrobson) a:3Jdlrobson [23:14:03] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1205316 (10JKatzWMF) @rmoen. Good questions. Groups that a user belongs to is comma separated. I like having them in the same schema, but for scalability, let's put it in its own schema for now. [23:14:26] (03CR) 10Kaldari: [C: 032] Don't let the Wikitext editor over-expand [extensions/MobileFrontend] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203959 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [23:15:24] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1205319 (10rmoen) @JKatzWMF, @Jdlrobson, Schema created. Please review: https://meta.wikimedia.org/wiki/Schema:GatherFlags [23:17:38] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1205322 (10kaldari) [23:17:59] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1205324 (10kaldari) a:3kaldari [23:18:42] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1205325 (10Jdlrobson) @JKatzWMF comma separated may be a bad idea... how do you plan to use this information? If comma separated you cannot easily do queries such as "what % of users who reported were admins?" you'l... [23:21:09] (03CR) 10Yurik: "Please see my other comments. You are breaking unit tests (we should automate them at some point). And I am sure you will break javascrip" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 (owner: 10Robmoen) [23:21:13] (03CR) 10Yurik: [C: 04-1] Return listpages results in query object [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 (owner: 10Robmoen) [23:21:31] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1205326 (10JKatzWMF) I think it is much faster to search this table with like than doing a join against user table. Anytime I have had to join against user table it takes >30 minutes. [23:23:00] (03CR) 10Yurik: "Sorry didn't see your comment about generator - sure, than just fix unit tests." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 (owner: 10Robmoen) [23:23:25] (03CR) 10MaxSem: [C: 031] Prevent database error resulting from duplicate unique key [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203989 (https://phabricator.wikimedia.org/T95068) (owner: 10Kaldari) [23:24:20] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Releasing Sprint 54 Work Product - https://phabricator.wikimedia.org/T95969#1205327 (10dr0ptp4kt) [23:25:41] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Releasing Sprint 54 Work Product - https://phabricator.wikimedia.org/T95969#1205258 (10dr0ptp4kt) [23:26:08] (03PS1) 10Jdlrobson: Show pages outside main namespace [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203991 (https://phabricator.wikimedia.org/T94786) [23:26:37] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Releasing Sprint 54 Work Product - https://phabricator.wikimedia.org/T95969#1205346 (10dr0ptp4kt) [23:27:10] 10Gather: API: Support ordering by namespace - https://phabricator.wikimedia.org/T95972#1205347 (10Jdlrobson) 3NEW [23:27:25] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Can create collection with non-main namespace pages but they do not show up - https://phabricator.wikimedia.org/T94786#1205354 (10Jdlrobson) To show non-main namespace pages at the bottom will require some changes to the API. See bug T95972 [23:28:21] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1205357 (10Jdlrobson) Depends on the table size but okay! :) [23:31:41] (03CR) 10Bmansurov: [C: 04-1] "I am not able to get view event binding working. Also, if you inspect the rendered button, you'll notice that the enclosing tag is 'undefi" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) (owner: 10Jdlrobson) [23:33:05] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6CA-team, 10MediaWiki-API, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1205359 (10Etonkovidova) Re-checked with 2.0-alpha-2015-04-13 - all edits are attributed to a logged in user. {F112511} I w... [23:36:51] jdlrobson, JonKatz: I'm stepping away for a while but will be back later after an errand. [23:38:02] (03CR) 10Jdlrobson: [C: 04-1] "Please no! This will disable all section collapsing (it's used by toggle.js too)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [23:38:44] (03PS6) 10Yurik: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) [23:39:04] (03PS2) 10Jdlrobson: Add support for extensions to add custom login messages for mobile login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203893 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [23:40:07] (03CR) 10Yurik: Implements prop=listmembership (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [23:41:12] jdlrobson, ^ [23:48:23] (03CR) 10jenkins-bot: [V: 04-1] Add support for extensions to add custom login messages for mobile login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203893 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [23:55:42] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1205378 (10kaldari)