[00:03:04] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Releasing Sprint 54 Work Product - https://phabricator.wikimedia.org/T95969#1205385 (10dr0ptp4kt) Note, I still need to clean up the checklist some. [00:05:44] dr0ptp4kt: patch to mobileapp extension to use same css as android for pages issues/disambig: https://gerrit.wikimedia.org/r/#/c/203997/ [00:05:45] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6CA-team, 10MediaWiki-API, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1205386 (10Deskana) Elena checked with the APK that I sent her, which had @dbrant's patch in it. So I guess that fixes the pr... [00:06:19] (03CR) 10Deskana: [C: 031] "Elena reported that this patch fixes the problem: https://phabricator.wikimedia.org/T75086#1205359" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200567 (https://phabricator.wikimedia.org/T75086) (owner: 10Dbrant) [00:07:33] (03CR) 10Alex Monk: [V: 032] "I'm sure it'll be okay, Jenkins." [extensions/MobileFrontend] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203959 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [00:10:32] (03PS4) 10Jdlrobson: WIP: Hygiene: Write ButtonWithSpinner as a View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) [00:11:06] (03CR) 10Jdlrobson: [C: 04-1] "Mmm. This is far more complicated than I first expected... sigh." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) (owner: 10Jdlrobson) [00:13:16] (03PS16) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [00:17:06] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [00:17:28] (03CR) 10jenkins-bot: [V: 04-1] WIP: Hygiene: Write ButtonWithSpinner as a View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203863 (https://phabricator.wikimedia.org/T95490) (owner: 10Jdlrobson) [00:24:14] 10Gather, 3Gather Sprint Forward: String replace link - https://phabricator.wikimedia.org/T95975#1205409 (10JKatzWMF) 3NEW a:3rmoen [00:25:28] (03PS17) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [00:25:30] (03PS1) 10Jdlrobson: Hygiene: Use explicit classes on main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 [00:26:15] 10Gather, 3Gather Sprint Forward: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1205422 (10JKatzWMF) [00:26:32] 10Gather, 3Gather Sprint Forward: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1205424 (10JKatzWMF) a:5JKatzWMF>3None [00:29:06] (03PS18) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [00:32:27] kaldari: yt? [00:33:43] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1205433 (10Jdlrobson) [00:33:44] 10Gather, 3Gather Sprint Forward: String replace link - https://phabricator.wikimedia.org/T95975#1205432 (10Jdlrobson) [00:33:49] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1196367 (10Jdlrobson) [00:34:07] (03CR) 10Jdlrobson: [C: 04-1] Add moderation expectations to Special:GatherLists for admins (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 (owner: 10Robmoen) [00:42:22] (03PS1) 10Ori.livneh: Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 [00:42:26] (03CR) 10jenkins-bot: [V: 04-1] Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [00:44:16] 10Gather, 3Gather Sprint Forward: overlay showing user how to find collections is not limited to 1-user - https://phabricator.wikimedia.org/T95976#1205436 (10JKatzWMF) 3NEW [00:46:30] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Use explicit classes on main menu (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 (owner: 10Jdlrobson) [01:43:16] 6Mobile-Web, 10Continuous-Integration: Jenkins: Set up jsduck test and publish jobs for MobileFrontend - https://phabricator.wikimedia.org/T66374#1205535 (10Krinkle) p:5Normal>3Low [01:49:11] anyone have an Android IRC client they'd recommend? [02:34:15] 6Mobile-Web, 10Continuous-Integration: Jenkins: Set up jsduck test and publish jobs for MobileFrontend - https://phabricator.wikimedia.org/T66374#1205575 (10Krinkle) Since last year, the infrastructure improved and the process for extending doc.wikimedia.org has been simplified. Example: [mwext-GuidedTour-jsdu... [02:43:17] (03PS1) 10Fjalapeno: Run Synx [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204006 [02:51:29] (03PS2) 10Fjalapeno: Run Synx [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204006 [03:16:44] (03PS3) 10Fjalapeno: Run Synx [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204006 [03:43:20] (03PS2) 10BearND: Right-align entries for RTL languages in Wikipedia language menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203947 (https://phabricator.wikimedia.org/T95895) (owner: 10Mholloway) [04:03:44] 6Mobile-Web, 7Mobile: "Talk to foo" -button not fit for the lenght of the characters - https://phabricator.wikimedia.org/T95993#1205739 (10Josve05a) 3NEW [04:04:09] 6Mobile-Web, 7Mobile: "Talk to foo" -button not fit for the lenght of the characters - https://phabricator.wikimedia.org/T95993#1205748 (10Josve05a) https://en.m.wikipedia.org/wiki/Special:UserProfile/DangerousJXD [06:23:31] (03CR) 10Florianschmidtwelzow: "> it's used by toggle.js too" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [07:40:53] (03CR) 10Bene: "> This will disable all section collapsing." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [08:30:25] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Some_sort_of_presentation_bug [08:30:53] seems userprofile page has broken down due to some reason ? [08:48:24] good morning [09:18:41] morning [09:18:49] joakino ^ [09:19:15] hi phuedx [09:19:31] phuedx: i'm reading the slides for quarterly review [09:19:41] i thought we already did that at the allhands [09:22:38] joakino: it's a exectrospective [09:22:43] i just made that up [09:22:47] i'm awesome [09:22:58] that's the first positive thing i've done all week [09:22:59] phuedx: maybe Ctrospective? [09:23:05] mine's better [09:23:08] haha [09:23:18] (read: please don't take it away from me) [09:23:30] phuedx: still retrosprecfast trumps them all [09:23:37] <3 [09:25:25] 6Mobile-Web: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1206040 (10phuedx) [09:25:26] 10Gather, 3Gather Sprint Forward, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1206038 (10phuedx) 5Open>3Invalid I'll create a task for the Readership folks to create Special:Tags – or whatever we decide on. [09:44:44] 6Mobile-Web, 3Mobile-Web-Design: Stop serving menu in the page HTML - https://phabricator.wikimedia.org/T95332#1206067 (10phuedx) We'll see. I certainly think it'll make it easier to //change// the menu design in the future. [10:19:50] (03CR) 10Phuedx: [C: 032] "Nice!" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203974 (https://phabricator.wikimedia.org/T95722) (owner: 10Bmansurov) [10:22:46] (03Merged) 10jenkins-bot: Do not load WikiGrok dialog if there are no suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203974 (https://phabricator.wikimedia.org/T95722) (owner: 10Bmansurov) [10:24:42] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 10WikiGrok: WikiGrok must not load when there are no suggestions. - https://phabricator.wikimedia.org/T95722#1206130 (10phuedx) [10:33:22] phuedx: do you know where is the refresh icon defined? https://gerrit.wikimedia.org/r/#/c/202089/18/less/specials/nearby.less [10:33:44] i see that mw-ui-icon-refresh is the gpsrefresh icon, but I can't find it on includes/Resources.php [10:34:09] joakino: sc [10:34:11] *sec [10:34:12] i mean, it works, but I want to know why [10:34:14] sure [10:35:30] less/iconsNew.less [10:35:46] there's also one in less/specials/userlogin.less (which is interesting) [10:39:12] (03PS2) 10Phuedx: Prevent database error resulting from duplicate unique key [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203989 (https://phabricator.wikimedia.org/T95068) (owner: 10Kaldari) [10:39:14] (03PS2) 10Phuedx: Fixing EventLogging Schema error on submission failure [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203971 (owner: 10Kaldari) [10:40:18] (03CR) 10Phuedx: "PS2 flips the order of this commit and I86d7b2b33ce20f3beaf0250a72dd47fc21d1315e." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203989 (https://phabricator.wikimedia.org/T95068) (owner: 10Kaldari) [10:41:42] mrrhhhfd [10:41:42] so confusing [10:42:04] phuedx: if I create a task should i add the current sprint also or you guys triage from mobile-web too [10:42:22] i'm curious about this too [10:42:38] does it directly affect mobile-web [10:43:47] 6Mobile-Web, 10MobileFrontend: userprofile.less styles not loaded on minerva (or the user profile) - https://phabricator.wikimedia.org/T96011#1206152 (10Jhernandez) 3NEW [10:43:49] phuedx: ^ [10:44:50] 6Mobile-Web, 10MobileFrontend: userprofile.less styles not loaded on minerva (or the user profile) - https://phabricator.wikimedia.org/T96011#1206160 (10phuedx) This was also reported here: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Some_sort_of_presentation_bug. [10:44:52] joakino: ^ [10:45:04] yeah, i'm going to say "fix sharpish" [10:45:17] triaged! [10:45:43] heh [10:47:00] (03CR) 10Phuedx: [C: 032] "Nice fix!" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203989 (https://phabricator.wikimedia.org/T95068) (owner: 10Kaldari) [10:49:15] (03Merged) 10jenkins-bot: Prevent database error resulting from duplicate unique key [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203989 (https://phabricator.wikimedia.org/T95068) (owner: 10Kaldari) [10:50:34] 6Mobile-Web, 10Continuous-Integration, 10WikiGrok: Include WikidataBuildResources in the WikiGrok extensions build dependencies - https://phabricator.wikimedia.org/T96012#1206167 (10phuedx) 3NEW [10:51:52] (03CR) 10Phuedx: "… which is tracked here: https://phabricator.wikimedia.org/T96012" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200886 (https://phabricator.wikimedia.org/T95304) (owner: 10Phuedx) [10:55:26] 6Mobile-Web, 10Continuous-Integration, 10WikiGrok: Include WikidataBuildResources in the WikiGrok extensions build dependencies - https://phabricator.wikimedia.org/T96012#1206180 (10phuedx) [10:55:34] (03CR) 10Jhernandez: [C: 04-1] "There are a few issues to be fixed, should be easy enough." (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [10:59:28] (03CR) 10Phuedx: Beta: Make banner image width match content width (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [11:00:01] joakino: gonna re-look over the mw-ui-icon patch now that i'm happier about the bugs in wikigrok :) [11:01:16] phuedx: I've been with it for a while [11:01:22] yup [11:01:25] it seems it is mostly good, i've pointed out a few things [11:01:31] yeah, good spots :) [11:01:37] just needs many eyes [11:01:43] yep [11:01:49] i'm really grateful to jon for doing the work [11:02:12] but as soon as it is good enough it should be in and exposed to more eyes, it is the only way of getting it done and it is really time for it [11:02:32] agreed [11:02:55] i'm not so sure about a thursday deploy though [11:03:07] we've had problems detecting icon regressions in the past [11:03:13] but we're all aware of the change now, so [11:04:02] (03CR) 10Phuedx: [C: 04-1] "I missed this when I submitted I4872f8323c141a5f8e4927bc3406967b505db581." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203971 (owner: 10Kaldari) [11:05:57] phuedx: is the interactions with gather clear? [11:06:03] ? [11:06:08] which interactions with gather [11:06:08] do you want to talk about it? [11:06:18] we gonna rumble or something? [11:06:20] the Special:Tags and rendering collections of stuff [11:07:51] phuedx: i mean, if you want I can give you an overview of how it is mounted, so that you see the different components and know what tasks to create and orient the other devs [11:08:25] joakino: i'd appreciate a tour, yeah [11:08:31] wanna hangout? [11:09:16] the hook seemed like a simpler approach but it had a cost, which you and florian both pointed out :) [11:09:19] joakino: sec [11:10:16] joakino: also, i'm a coffee shop -- so you talk and i'll irc if necessary :) [11:10:25] i think the hook is a good idea, but it may not be necessary or make sense for what we are trying to do with the tags [11:10:34] oki [11:11:24] phuedx: call me when you're ready [11:14:55] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Getting Wikidata to render nicely on mobile web [Tracking] - https://phabricator.wikimedia.org/T78430#1206207 (10Bene) [11:17:01] (03CR) 10Phuedx: Fix for side to side scrolling of wide images with div overlays. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 (owner: 10Mhurd) [11:19:41] 6Mobile-Web, 7Mobile: "Talk to foo" -button not fit for the lenght of the characters - https://phabricator.wikimedia.org/T95993#1206215 (10Jhernandez) Note this doesn't happen in beta/alpha, only in stable. So it has to do with the icon styles that we are deprecating, so it should be automatically solved when... [11:20:21] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] MobileFrontend should use mw-ui-icon - https://phabricator.wikimedia.org/T73181#756520 (10Jhernandez) [11:20:23] 6Mobile-Web, 7Mobile: "Talk to foo" -button not fit for the lenght of the characters - https://phabricator.wikimedia.org/T95993#1206218 (10Jhernandez) [11:39:55] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create the Special:Tags special page - https://phabricator.wikimedia.org/T96015#1206255 (10phuedx) 3NEW [11:42:34] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create the Special:Tags special page - https://phabricator.wikimedia.org/T96015#1206266 (10phuedx) [11:42:41] joakino: ^ [11:42:49] gonna cycle back home [11:42:53] it's an incredibly day today [11:42:54] 👍 [11:42:57] i'm in shorts and a shirt [11:43:11] summer is coming [11:43:15] that task might be a little prescriptive so i'm going to shift the technical stuff into the discussion [11:43:24] k [11:43:34] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create the Special:Tags special page - https://phabricator.wikimedia.org/T96015#1206255 (10phuedx) [11:43:40] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create the Special:Tags special page - https://phabricator.wikimedia.org/T96015#1206255 (10phuedx) Create the Special:Tags page by following the template set out by the `Gather\SpecialGather` class – generate a `models\Collection` from the category that th... [11:44:27] better [11:44:36] alright [11:44:46] back in a bit [11:44:47] yep sounds good [11:44:48] bb [11:45:18] also, we can write browser tests for this (two easily testable scenarios!) [11:48:51] (03CR) 10Jhernandez: [C: 031] "Not sure what comment you want baha. Do you have an example of how would you document that return object in a way that makes sense?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [11:59:24] 10Wikipedia-Android-App: Android app shows old versions of articles - https://phabricator.wikimedia.org/T94406#1206283 (10Thgoiter) Thank you. I've asked the user who initially reported the problem to test this again ([[ https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Metrophil44&diff=prev&oldid=1... [12:05:55] 10Wikipedia-Android-App, 5Patch-For-Review: Playback of video in media gallery. - https://phabricator.wikimedia.org/T86558#1206296 (10TheDJ) [12:40:22] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1206328 (10TTO) [12:40:24] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1206255 (10TTO) The name `Special:Tags` is already taken... [12:55:13] back [12:55:38] had a tyre puncture on the way back [12:58:00] 10Wikipedia-Android-App: Android app shows old versions of articles - https://phabricator.wikimedia.org/T94406#1206344 (10Metrophil44) @Deskana I just tried it with dewiki WP:VM page and it happened again, but I don't know whether I have the latest version, my current one is 2015-04-02. [12:58:04] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1206345 (10phuedx) Thanks @TTO :) The name of the special page isn't set in stone or anything, it's just a placeholder. I shouldn't have been so specific. [12:59:42] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1206347 (10phuedx) … and wrong, obviously. [13:06:58] 10Gather, 3Gather Sprint Forward, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1206355 (10phuedx) [13:07:00] 6Mobile-Web: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1206353 (10phuedx) [13:07:02] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1206354 (10phuedx) [13:08:39] 6Mobile-Web: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1190681 (10phuedx) This is now blocked on the creation of the special page for tags (T96015). It could be merged with it… Regardless, now that this is no longer dependant on the Gather team... [13:11:25] brb [13:46:57] 6Mobile-Web: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1206418 (10phuedx) ^ @JKatzWMF and @KLans_WMF [13:49:45] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Make Wikidata editable on mobile web [Tracking] - https://phabricator.wikimedia.org/T95878#1206422 (10Florian) [13:49:49] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1206420 (10Florian) 5Open>3Resolved a:3Florian [13:50:02] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1202457 (10Florian) a:5Florian>3Bene [14:04:05] 10Wikipedia-Android-App: Android app shows old versions of articles - https://phabricator.wikimedia.org/T94406#1206444 (10Deskana) 5Resolved>3Open >>! In T94406#1206344, @Metrophil44 wrote: > @Deskana I just tried it with dewiki WP:VM page and it happened again, but I don't know whether I have the latest ver... [14:06:18] (03PS2) 10Phuedx: Let's be less Wikipedia-centric [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200526 (owner: 10Ricordisamoa) [14:06:20] (03PS1) 10Phuedx: WikiData -> Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204053 [14:07:07] (03CR) 10Phuedx: "Lydia: Agreed! See Iac7feb2f56f6e28e5cd64bbb232b42ea1a024cb9." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/200526 (owner: 10Ricordisamoa) [14:08:20] (03CR) 10Bmansurov: [C: 032] WikiData -> Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204053 (owner: 10Phuedx) [14:08:35] you move fast bmansurov [14:08:55] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 7Epic: Deploy the latest version of WikiGrok (0.2? 0.3?) - https://phabricator.wikimedia.org/T95874#1206462 (10phuedx) [14:08:56] phuedx: life is short [14:09:10] move fast and keep things running smoothly? [14:09:25] phuedx: yep [14:12:12] (03Merged) 10jenkins-bot: WikiData -> Wikidata [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204053 (owner: 10Phuedx) [14:14:35] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 10WikiGrok: WikiGrok must not load when there are no suggestions. - https://phabricator.wikimedia.org/T95722#1206463 (10bmansurov) 5Open>3Resolved [14:16:08] (03CR) 10Bmansurov: "@Kaldari, what do you say?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203345 (https://phabricator.wikimedia.org/T94445) (owner: 10Phuedx) [14:30:05] gonna make a cup of coffee [14:33:19] 6Mobile-Web, 10Continuous-Integration, 10WikiGrok: Include WikidataBuildResources in the WikiGrok extensions build dependencies - https://phabricator.wikimedia.org/T96012#1206514 (10JanZerebecki) This may alternatively be solved for non-wmf branches by T90303 and depending on the correct thing via composer.... [14:44:28] i'm still here -- just brewing [14:47:35] (03CR) 10Bmansurov: Beta: Make banner image width match content width (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [14:48:07] phuedx: too much coffee is bad, mkaaay? [14:50:16] bmansurov: w/e [14:56:17] (03CR) 10Phuedx: Beta: Make banner image width match content width (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [15:02:55] (03CR) 10Bmansurov: Beta: Make banner image width match content width (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [15:04:42] bmansurov: was that a +1 or not? i couldn't tell [15:05:06] phuedx: oh yeah, i forgot [15:05:31] (03CR) 10Bmansurov: [C: 031] Beta: Make banner image width match content width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [15:07:01] only +1? ;) [15:07:11] might solicit florian's help [15:07:11] :P [15:07:39] phuedx: I've used up my +2s for the sprint [15:08:09] there's a limit? oh dear [15:08:20] phuedx: planned economy [15:08:34] phuedx: what are your thoughts on using the img tag to show the banner image? [15:09:02] phuedx: that's what I'm thinking of doing to deliver the banner image as part of the html [15:09:28] how would you crop it and make it act like background-image: cover? [15:10:12] phuedx: I'm thinking about wrapping it in a div and making the div overflow: hidden and adding a negative margint to the img [15:11:16] phuedx: either way, we'll have to do some calculations to fix the image height [15:11:31] phuedx: so it may not be that different from the background-image solution we're using [15:11:46] yeah -- both solutions seem the same [15:11:58] set up the image and then tweak it's position once we know more [15:13:19] bmansurov: negative margins could be the same as position: absolute and applying top, right, bottom, left etc [15:13:22] etc? [15:13:26] there aren't any more [15:13:29] you're right [15:13:50] ok, let's see what i can come up with [15:13:53] ^ that [15:17:40] phuedx: oh boy, it sure is lonely here in the mornings [15:17:51] inorite [15:18:29] phuedx: now I understand why your eyes light up when you see us in a hangout chat [15:18:34] lol [15:18:38] lol [15:23:09] (03CR) 10Phuedx: [C: 04-1] "Given some workflows a good prod and tried to ensure that my cache is /actually/ clear, rather than reported as clear, which is a thing." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [15:25:43] lol :D [15:35:39] (03CR) 10Jdlrobson: [C: 04-1] "Thanks Ori! will make these slight tweaks and test. Looks a lot cleaner." (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [15:36:29] (03PS18) 10Jdlrobson: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [15:36:37] (03CR) 10Jdlrobson: [C: 032] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [15:39:49] Hi mholloway. I'm going to step out for a bit. Should be back in around 90 min. [15:40:25] bearND: OK, should we talk about stat1003 when you're back? [15:41:08] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Spike (4 hours): Investigate existing site speed metrics - https://phabricator.wikimedia.org/T95296#1206780 (10phuedx) The events logged by the NavigationTiming extension already include a mobileMode property ([description](https://meta.wikimedia.org/wiki/... [15:41:22] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Spike (4 hours): Investigate existing site speed metrics - https://phabricator.wikimedia.org/T95296#1206793 (10phuedx) [15:43:48] (03CR) 10Jdlrobson: Fix for side to side scrolling of wide images with div overlays. (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 (owner: 10Mhurd) [15:45:26] (03CR) 10Bgerstle: [C: 031] "more questions, but seems OK" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 (owner: 10Mhurd) [15:45:35] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1206819 (10Jdlrobson) In mobile web we force the image to go no bigger than the viewport. > max-width: 100% !important; > height: auto !important;... [15:47:45] (03CR) 10Bgerstle: [C: 031] "i guess we won't be able to test this until we do another localization update?" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204006 (owner: 10Fjalapeno) [15:49:57] (03CR) 10Fjalapeno: "yeah pretty much… we know how to update the localization script now, so there shouldn't be an issue - but doesn't mean it won't be fiddly…" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204006 (owner: 10Fjalapeno) [15:51:23] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [15:51:27] (03CR) 10Jdlrobson: Hygiene: Use explicit classes on main menu (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 (owner: 10Jdlrobson) [15:51:32] (03PS2) 10Jdlrobson: Hygiene: Use explicit classes on main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 [15:57:42] 10Wikipedia-iOS-App: Icons are too big for Tablet - https://phabricator.wikimedia.org/T74916#1206852 (10Fjalapeno) In general Apple does not recommend scaling buttons (sorry @mhurd). The touch points of 44x44 are supposed to remain the same across all iOS devices. iOS controls are optimized by Apple on each devi... [15:59:57] gonna give george an early bath before my meetings start [16:04:58] (03CR) 10Bmansurov: Hygiene: Use explicit classes on main menu (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 (owner: 10Jdlrobson) [16:06:09] phuedx: thanks for the phone-in review [16:06:55] phuedx: is there any process for resolving these kinds of markup/style issues at a lower level? e.g. the parser, perhaps? [16:07:59] 10Wikipedia-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice, 7user-notice: Production release for iOS Wikipedia app on Wednesday 15th April 2015 @ 9:15am Pacific - https://phabricator.wikimedia.org/T86692#1206896 (10Deskana) [16:08:26] (03CR) 10Jdlrobson: Hygiene: Use explicit classes on main menu (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 (owner: 10Jdlrobson) [16:10:57] 10Wikipedia-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice, 7user-notice: Production release for iOS Wikipedia app on Wednesday 15th April 2015 @ 9:15am Pacific - https://phabricator.wikimedia.org/T86692#1206913 (10Deskana) a:3Deskana [16:13:45] (03CR) 10Bmansurov: Hygiene: Use explicit classes on main menu (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 (owner: 10Jdlrobson) [16:18:14] hellowww [16:19:16] gonna make coffee for all these meetings [16:20:52] howdy, joakino [16:23:29] (03PS19) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [16:24:04] (03CR) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [16:27:22] 10Wikipedia-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1206934 (10Krenair) and https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8286268 [16:27:59] hi bmansurov [16:28:02] how are you doing! [16:28:05] (03PS3) 10Jdlrobson: Hygiene: Use explicit classes on main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 [16:28:48] (03CR) 10Jdlrobson: Hygiene: Use explicit classes on main menu (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 (owner: 10Jdlrobson) [16:30:37] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use explicit classes on main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 (owner: 10Jdlrobson) [16:30:46] phuedx: meeting? [16:30:52] FlorianSW: u coming to meeting? [16:32:22] joakino: excellento [16:34:47] sorry bgerstle: i was in the bath [16:35:06] phuedx: what, you can't work from there? [16:35:13] i think the parser is probably the best bet [16:35:14] joakino: damn, sorry, i totally missed that :/ I'm currently involved in another thing :( [16:35:17] you live a hard life, taking baths... eating cake... [16:35:20] juggling, climbing [16:35:21] FlorianSW: don't worry!! [16:35:29] 👍 [16:35:31] but then you can't ever control the templates! ;) [16:35:46] phuedx: wellll [16:35:51] phuedx: contraints are our friend :-) [16:35:55] constraints, even [16:36:30] yeah i guess -- or post-processing if all goes awry [16:36:40] but obviously that'd be a last resort [16:36:41] it's workarounds all the way down [16:37:02] the internet is made of hacks, workarounds, and the frustration of engineers [16:38:13] phuedx: so, who/where are the parser people? [16:38:29] i'm taking this all the way to the top (or bottom, whichever) [16:40:31] bgerstle: that's a good question [16:40:40] raise a task in the parsoid project maybe? :/ [16:41:18] phuedx: what's that quote/aphorism about doing the same thing and expecting different results? [16:41:33] bgerstle: i don't think there is one [16:42:29] there is, though the attribution is up for debate: the definition of stupidity/insanity is someone who does the same thing over and over again, expecting different results. [16:42:47] it was ben franklin or someone else [16:42:58] which can be true for essentially anything [16:43:05] _anyway_ [16:43:53] chalk another one up for the "it'll be fixed when we have a service for the apps" count [16:44:11] * bgerstle mumbles incoherently about functional teams [16:45:01] i'll just continue enjoying my (somewhat recently roasted) columbian coffee... [16:48:15] * phuedx watches bgerstle run out of puff from afar ;) [16:48:33] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Some_sort_of_presentation_bug [16:48:44] not sure if you guys noticed that :) [16:48:48] phuedx: i'm spending all my "puff" trying to get us to GitHub, Travis, & Coveralls, thank you very much :-P [16:49:11] phuedx: seriously though, i would like our two teams to work together on these sorts of things [16:49:40] thedj: thanks, yeah -- it was also reported by joakino [16:49:58] but then i totally forgot to respond to the user :/ [16:50:00] sec [16:50:43] i'd answer myself, but this is one area, where I think i'm not fully up to date myself. [16:50:54] thedj: https://phabricator.wikimedia.org/T96011 <- that's the tracking bug [16:51:55] phuedx: guess you could say i'm singing the markup/style blues: https://open.spotify.com/track/7qsjr6qMXd35OwkIJD2Xqt [16:52:11] (if we were on slack, that would've been inlined as a Spotify widget :-( ) [16:53:55] bgerstle: you may want to check on the #wikimedia-services channel about contacts in the parser. otherwise in the core repo, maybe do a git blame on the files in find . -name '*arse*' 2> /dev/null (no, seriously, that wildcard makes it easier to find files) [16:54:26] dr0ptp4kt: i like how the grep pattern just happens to be "arse" [16:54:34] and thanks, will do that [16:54:40] bgerstle: NO, SRSLY, WILDCARD WAS NECESSARY [16:54:44] dr0ptp4kt: surreeeee [16:55:05] coulda been [pP]arser? [16:55:10] :wink [16:55:13] gah 😉 [16:55:38] bgerstle: but then i'm sure i'd have to use some extra flag to ensure pcre compatibility. [16:55:53] ya ya, we know what you're up to, dr0ptp4kt [16:56:20] coreyfloyd: you around? [16:56:31] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Releasing Sprint 54 Work Product - https://phabricator.wikimedia.org/T95969#1207030 (10dr0ptp4kt) [16:56:37] ah SRV, why'd you have to leave us so soon... 🎸 [16:56:57] (that's Stevie Ray Vaughn for your DNS nerds, not service record...) [17:00:52] dr0ptp4kt: yep [17:01:37] coreyfloyd: https://encrypted-tbn1.gstatic.com/images?q=tbn:ANd9GcSf5-66oASdWDcez757Xfi_oA6E4XdFPw390AFAI7EJ8gmIWJfr ? [17:02:19] ok - makeup it is [17:07:07] (03CR) 10Bgerstle: "couple cleanup requests" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 (owner: 10Mhurd) [17:14:59] coreyfloyd: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process#iOS and https://www.mediawiki.org/wiki/Talk:Wikimedia_Apps/Team/Release_process [17:21:03] dr0ptp4kt: thanks [17:21:13] dr0ptp4kt: what's our status on getting https://gerrit.wikimedia.org/r/#/c/203250/ mergred for prod ? [17:26:47] 10Wikipedia-iOS-App: Automate Beta Distribution - https://phabricator.wikimedia.org/T96051#1207159 (10Fjalapeno) 3NEW a:3dr0ptp4kt [17:29:37] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6CA-team, 10MediaWiki-API, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1207171 (10Etonkovidova) Re-checked next day after the first edit. All edits were saved with my user name and 'Tags: Mobil... [17:29:49] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6CA-team, 10MediaWiki-API, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1207184 (10Etonkovidova) 5Open>3Resolved [17:31:17] tfinc: kaldari is having rmoen deploy https://gerrit.wikimedia.org/r/#/c/203250/ today [17:31:30] dr0ptp4kt: thanks. Deskana|Away --^ [17:31:37] tfinc: so tomorrow when the code is shipped to group 0 (mediawiki.org), then it will start taking effect [17:31:49] tfinc: next week it should be running across all of the wikis [17:32:09] i'm going to be eager to see the data steaming in [17:35:09] (03PS3) 10Kaldari: Fixing EventLogging Schema error on submission failure [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203971 [17:38:15] (03CR) 10jenkins-bot: [V: 04-1] Fixing EventLogging Schema error on submission failure [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203971 (owner: 10Kaldari) [17:39:18] (03PS4) 10Kaldari: Fixing EventLogging Schema error on submission failure [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203971 [17:39:37] 6Mobile-Web, 10MobileFrontend: userprofile.less styles not loaded on minerva (or the user profile) - https://phabricator.wikimedia.org/T96011#1207221 (10phuedx) [17:40:44] phuedx joakino https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2015/Mobile_web [17:40:53] <3 [17:41:08] thx jdlrobson [17:41:19] is that the same hat you're wearing now? jdlrobson [17:46:50] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile, 7Tracking: Intermittent problem with navigating between topics with TOC - https://phabricator.wikimedia.org/T93502#1207248 (10Mattflaschen) [17:46:57] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile, 7Tracking: Problem with navigating between topics with TOC - https://phabricator.wikimedia.org/T93502#1207250 (10Mattflaschen) [17:47:08] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile, 7Tracking: Problem with navigating between topics with TOC - https://phabricator.wikimedia.org/T93502#1138796 (10Mattflaschen) p:5Normal>3Unbreak! [17:47:21] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile, 7Tracking: Problem with navigating between topics with TOC - https://phabricator.wikimedia.org/T93502#1207255 (10Quiddity) [17:54:42] 6Mobile-Web, 10MobileFrontend: userprofile.less styles not loaded on minerva (or the user profile) - https://phabricator.wikimedia.org/T96011#1207315 (10Jdlrobson) Gather is nuking all Minerva's specific styles. On it. [17:54:52] 10Gather, 6Mobile-Web, 10MobileFrontend: userprofile.less styles not loaded on minerva (or the user profile) - https://phabricator.wikimedia.org/T96011#1207316 (10Jdlrobson) [18:13:01] 6Mobile-Web, 6Collaboration-Team, 10Collaboration-Team-Sprint-U-2015-04-22, 10Flow, and 2 others: Problem with navigating between topics with TOC - https://phabricator.wikimedia.org/T93502#1207370 (10SBisson) [18:13:09] 6Mobile-Web, 6Collaboration-Team, 10Collaboration-Team-Sprint-U-2015-04-22, 10Flow, and 2 others: Problem with navigating between topics with TOC - https://phabricator.wikimedia.org/T93502#1207371 (10SBisson) a:3SBisson [18:40:11] (03CR) 10Mhurd: Fix for side to side scrolling of wide images with div overlays. (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 (owner: 10Mhurd) [18:42:35] fun meetings [18:45:21] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [18:50:45] bgerstle: coreyfloyd batcave? [18:51:19] mhurd the health check tech talk is starting soon, was going to that [18:51:22] mhurd i have a few minutes, though [18:53:28] Deskana: Has the argument to the zsub command changed recently? I'm not getting anything. [18:53:47] for EL [18:54:45] DarTar: ^ [19:02:08] coreyfloyd: you around? [19:09:19] (03PS3) 10BearND: Avoid IP edits when user is logged [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200567 (https://phabricator.wikimedia.org/T75086) (owner: 10Dbrant) [19:09:31] (03PS4) 10BearND: Avoid IP edits when user is logged in [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200567 (https://phabricator.wikimedia.org/T75086) (owner: 10Dbrant) [19:09:40] (03PS5) 10BearND: Avoid IP edits when user is logged in [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200567 (https://phabricator.wikimedia.org/T75086) (owner: 10Dbrant) [19:10:33] (03CR) 10BearND: [C: 032] Avoid IP edits when user is logged in [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200567 (https://phabricator.wikimedia.org/T75086) (owner: 10Dbrant) [19:11:27] (03Merged) 10jenkins-bot: Avoid IP edits when user is logged in [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/200567 (https://phabricator.wikimedia.org/T75086) (owner: 10Dbrant) [19:14:36] mhurd: sorry - in deep thought - whats up? [19:17:49] coreyfloyd: adam's helping with a super weird git issue atm... [19:18:30] coreyfloyd: was trying to test the synx patch with incoming translations but git got wonky [19:24:59] heading off for the night [19:26:24] 10Gather, 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: userprofile.less styles not loaded on minerva (or the user profile) - https://phabricator.wikimedia.org/T96011#1207550 (10phuedx) When that patch is merged could you ping the folks over at the village pump? [19:26:32] toodles! [19:28:54] (03PS2) 10Mhurd: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203854 (owner: 10BearND) [19:30:25] Shalom [19:31:01] mhurd do you need to hangout? [19:31:03] kaldari, JonKatz - I just blocked the first mobile anon vandal ;) [19:31:29] mhurd: probabaly won’t work until we repatch the translations repo [19:31:45] coreyfloyd: batcave? [19:32:52] kaldari, JonKatz - is there a dashboard that shows how many mobile anons were reverted or blocked? [19:35:45] coreyfloyd: hey do you have a minute to help adam and i track down a git issue? [19:51:46] 6Mobile-Web: (3) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1207617 (10JKatzWMF) awesome, @phuedx! [19:52:25] coreyfloyd: bgerstle one of you around? [19:52:38] dr0ptp4kt: si [19:52:49] bgerstle: na na na na ? [19:52:58] dr0ptp4kt: ya [19:53:06] dr0ptp4kt: i see where you're going w/ this [19:53:11] "hey hey... good bye" [19:53:27] dr0ptp4kt: but seriously, batcave? [19:57:17] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1207630 (10Mholloway) I did some testing/logging. Under the hood, OkHttp's [[ https://github.com/square/okhttp/blob/master/okhttp/src/main/java/com/squareup/ok... [20:02:32] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1207647 (10KLans_WMF) [20:04:46] 6Mobile-Web, 6Collaboration-Team, 10Flow, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 7I18n: the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages - https://phabricator.wikimedia.org/T91886#1207650 (10KLans_WMF) [20:06:08] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: If a user is blocked from editing a page (due to the false group), there should be a link to the history - https://phabricator.wikimedia.org/T95305#1207652 (10KLans_WMF) [20:07:04] (03CR) 10Jkatz: "Hi Florian, can you include a screenshot of how this impacts the user? Thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202424 (https://phabricator.wikimedia.org/T95305) (owner: 10Florianschmidtwelzow) [20:07:52] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Window on leave code in editor overlay should be reusable or dropped - https://phabricator.wikimedia.org/T94194#1207659 (10KLans_WMF) [20:12:19] bearND|away: I don't know [20:16:42] (03PS2) 10Jdlrobson: Don't wipe out all the minerva specific styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204086 (https://phabricator.wikimedia.org/T96011) [20:17:03] ^ kaldari help merging? I'd like to get that swat deployed later [20:19:03] i quote: [20:19:07] I really, really try not to be one of those people who automatically poo-poo every new idea the WMF puts forward, but I cannot help but wonder how out-of-touch with the day to day realities here the staff has to be to come up with an idea this terrible, and then two weeks after they enable it ask us admins how we are going to police it for them. We aren't. Do it yourselves if it such a great idea. Don't dump new responsibilities on '''unpaid volu [20:20:09] jdlrobson, what's the scoop [20:20:26] i was gonna ask thedj the same question since i missed the beginning of the convo [20:22:04] it's feedback on Gather from en.wp somewhere [20:22:48] where can i read that? [20:23:56] 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1207705 (10KLans_WMF) [20:23:57] 6Mobile-Web, 10Continuous-Integration, 5Patch-For-Review, 7Technical-Debt: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1207711 (10JKatzWMF) moving to eng backlog, as hasn't been touched in awhile. [20:24:12] https://en.wikipedia.org/wiki/Wikipedia:Administrators%27_noticeboard#Moderation_of_Collections.3F [20:24:22] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: PLURAL support for MobileFrontend licensing messages - https://phabricator.wikimedia.org/T93058#1207720 (10KLans_WMF) [20:24:47] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: PLURAL support for MobileFrontend licensing messages - https://phabricator.wikimedia.org/T93058#1207723 (10JKatzWMF) moving to in review, as it is currently in sprint. [20:25:01] i suggest WMF proposes to delete all user pages as "not having encylopedia value" :) [20:25:12] but i guess that would be pointy :) [20:25:38] 6Mobile-Web, 5Patch-For-Review: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1207728 (10JKatzWMF) this looks like an eng backlog [20:25:46] still it proves that it would have been better under the User namespace. if only for purely sentiment reasons. [20:26:29] thedj: :-/ yeh [20:26:44] i mean that can still happen.. the problem is we want to be able to filter lists and make them discoverable [20:27:07] if we'd started this with public watchlists which have the same moderation problems i wonder how different the response would have been [20:28:06] (03PS12) 10Bmansurov: WIP: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [20:28:58] jdlrobson: it's the share and publish part... it's like gasoline on fire [20:29:16] yeh... but how is that different from public watchlist ? [20:29:21] mhurd: just finished hanging out with adam - you want to talk now? [20:29:45] for instance thedj here's my one of my collections of movies that i want to share with you publically - https://en.m.wikipedia.org/wiki/Special:GatherEditFeed?collection-id=39 [20:29:45] jdlrobson: actually public would also be something that would fall over [20:29:56] (03CR) 10Kaldari: [C: 032] Don't wipe out all the minerva specific styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204086 (https://phabricator.wikimedia.org/T96011) (owner: 10Jdlrobson) [20:30:01] mutliple watchlist yes: curated lists on user pages yes. [20:30:14] combining those two. problem :( [20:30:19] but they still need labels.. which is a moderation problem :-/ [20:30:33] you can just give them numbers :) [20:30:36] coreyfloyd: heading back from lunch. back at desk in ~15 min [20:31:11] and then wait until everyone has complained so much about the numbers and asked so much for display strings, then you give it to them, and there would be little resistence. [20:31:56] probably. you never rly know with wikipedians [20:32:29] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [20:32:32] thedj: yehhhh argggh. FWIW i'm still totally open to user pages for storing descriptions/titles - i still think there needs to be a database for the page items themselves though [20:32:58] yeah, you need at least a queryable proxy before it. [20:33:00] (with ids/user ids so we can join with recent changes / query in clever ways) [20:33:11] 6Mobile-Web, 10MediaWiki-Unit-tests: Make unit tests to check that our server-side mustache templates can be compiled without blowing up - https://phabricator.wikimedia.org/T93445#1207761 (10JKatzWMF) moving to eng backlog, as this is not actively being worked on, as far as I can tell. [20:33:13] mhurd: k [20:33:26] (03CR) 10jenkins-bot: [V: 04-1] Don't wipe out all the minerva specific styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204086 (https://phabricator.wikimedia.org/T96011) (owner: 10Jdlrobson) [20:34:12] bearND|away: when you're back, let's talk about making changes to apps-android-java-mwapi [20:35:11] 6Mobile-Web: Mobile search in Firefox repeats first letters - https://phabricator.wikimedia.org/T91771#1207767 (10JKatzWMF) @bmansurov is there anything we can do for this, or does it belong in "tracking"? [20:35:21] (03CR) 10Jdlrobson: [C: 032] Don't wipe out all the minerva specific styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204086 (https://phabricator.wikimedia.org/T96011) (owner: 10Jdlrobson) [20:37:24] 6Mobile-Web, 5Patch-For-Review: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1207774 (10Jdlrobson) yup. good catch :) [20:37:43] 6Mobile-Web: Mobile search in Firefox repeats first letters - https://phabricator.wikimedia.org/T91771#1207776 (10bmansurov) @JKatzWMF, I think at this stage it may belong to 'tracking', unless we decide to work around the browser bug. [20:38:48] (03Merged) 10jenkins-bot: Don't wipe out all the minerva specific styles [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204086 (https://phabricator.wikimedia.org/T96011) (owner: 10Jdlrobson) [20:40:54] (03CR) 10Jdlrobson: [C: 031] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [20:41:07] (03CR) 10Jdlrobson: [C: 032] Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [20:41:39] (03PS4) 10Jdlrobson: Hygiene: Use explicit classes on main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 [20:42:39] 10Gather, 3Gather Sprint Forward: Special:Gather/by should go somewhere - https://phabricator.wikimedia.org/T95791#1207807 (10Jdlrobson) a:3Jdlrobson [20:45:53] (03PS1) 10Jdlrobson: Revert "Don't wipe out all the minerva specific styles" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204147 [20:46:08] (03Merged) 10jenkins-bot: Fix problems with license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/197693 (https://phabricator.wikimedia.org/T93058) (owner: 10Florianschmidtwelzow) [20:48:03] (03PS1) 10Jdlrobson: Skin styles done the proper way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204148 (https://phabricator.wikimedia.org/T96011) [20:48:10] (03CR) 10Jdlrobson: [C: 032] Revert "Don't wipe out all the minerva specific styles" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204147 (owner: 10Jdlrobson) [20:48:51] (03CR) 10jenkins-bot: [V: 04-1] Revert "Don't wipe out all the minerva specific styles" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204147 (owner: 10Jdlrobson) [20:49:00] (03CR) 10Bmansurov: [C: 032] Hygiene: Use explicit classes on main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 (owner: 10Jdlrobson) [20:49:05] (03CR) 10Jdlrobson: [C: 031] Revert "Don't wipe out all the minerva specific styles" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204147 (owner: 10Jdlrobson) [20:49:14] (03PS2) 10Jdlrobson: Revert "Don't wipe out all the minerva specific styles" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204147 [20:49:20] (03CR) 10Jdlrobson: [C: 032] Revert "Don't wipe out all the minerva specific styles" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204147 (owner: 10Jdlrobson) [20:50:59] (03PS1) 10Jdlrobson: Add route for Special:Gather/by/ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) [20:51:33] coreyfloyd: imagemagick made me do it. i mean, who doesn't want pretty icons? i'm going to try the manual build on the ci server for the tf beta [20:51:48] coreyfloyd: i don't guess there will be any surprises, given it worked 20 minutes ago [20:52:04] 10Gather, 3Gather Sprint Forward: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1207846 (10Jdlrobson) a:3Jdlrobson [20:52:19] (03PS20) 10Bmansurov: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [20:52:52] 6Mobile-Web, 10MobileFrontend, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Email confirmation workflow doesn't work correctly from a Mobile device - https://phabricator.wikimedia.org/T95065#1179535 (10KLans_WMF) [20:53:31] 10Gather, 3Gather Sprint Forward: Pointer to collections should be shown whenever a new user adds a new collection. - https://phabricator.wikimedia.org/T95976#1207858 (10Jdlrobson) [20:53:52] 10Gather, 3Gather Sprint Forward, 6Mobile-Web: Provide a hook to allow other extensions to register routes on Special:Gather - https://phabricator.wikimedia.org/T95457#1191068 (10Jdlrobson) [20:53:54] 6Mobile-Web: Spike: how can we create diagnostic that VE team built? - https://phabricator.wikimedia.org/T95447#1207863 (10JKatzWMF) @phuedx is this task still needed or captured elsewhere? should the 3 of us meet or is this purely technical. [20:54:25] (03Merged) 10jenkins-bot: Hygiene: Use explicit classes on main menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204001 (owner: 10Jdlrobson) [20:54:27] (03Merged) 10jenkins-bot: Revert "Don't wipe out all the minerva specific styles" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204147 (owner: 10Jdlrobson) [20:54:32] jdlrobson: took another look at https://gerrit.wikimedia.org/r/#/c/203953/ ? [20:54:38] benestar: looking! [20:54:56] how do you think I want to remove section collapsing? :O [20:58:26] (03CR) 10Jdlrobson: [C: 032] "Sorry for the misunderstanding :-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [20:58:32] (03PS3) 10Jdlrobson: Get rid of $wgMFPageSections config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [20:59:05] jdlrobson: no problem, thanks :) [20:59:40] coreyfloyd: hey i'm back [21:00:32] mhurd: hey I’m still here [21:00:49] bgerstle: coreyfloyd either of you available to batcave? [21:00:51] 10Gather, 3Gather Sprint Forward: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1207897 (10Jdlrobson) a:3Jdlrobson [21:01:03] mhurd: sure [21:01:20] mhurd need one or both of us? [21:01:29] both if possible [21:01:46] k, brt [21:08:53] (03PS2) 10Jdlrobson: Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:08:55] (03CR) 10jenkins-bot: [V: 04-1] Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:11:33] (03PS3) 10Jdlrobson: Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:11:43] (03CR) 10Jdlrobson: [C: 032] Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:12:28] I've a small recommendation from someone trying to grok the WMF repos in GitHub, although I'm not sure this is the proper forum for it. It'd be pretty sweet if each repo had a proper one liner description. Right now they all have a pretty generic "this is a mirror" description and n00bs like myself have to manually dig into the README to even get a summary view. [21:12:51] (03CR) 10Yurik: [C: 04-1] Add route for Special:Gather/by/ (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [21:13:22] niedzielski: problem is mosly that we have some 200 of them :) [21:13:31] Right. That is the problem for me too! [21:15:03] (03CR) 10jenkins-bot: [V: 04-1] Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:15:19] niedzielski: you can file a ticket in phabricator :) [21:17:13] (03CR) 10Mhurd: [C: 032] Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203854 (owner: 10BearND) [21:20:25] (03PS2) 10Kaldari: Skin styles done the proper way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204148 (https://phabricator.wikimedia.org/T96011) (owner: 10Jdlrobson) [21:21:27] niedzielski: seriously btw. more tickets is better. [21:24:53] (03PS1) 10Mhurd: Fix for weird staged file from last incoming translation set. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204154 [21:25:44] (03CR) 10Fjalapeno: [C: 031] Fix for weird staged file from last incoming translation set. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204154 (owner: 10Mhurd) [21:26:23] (03CR) 10Bgerstle: [C: 032] Fix for weird staged file from last incoming translation set. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204154 (owner: 10Mhurd) [21:26:32] (03CR) 10Bgerstle: [V: 032] Fix for weird staged file from last incoming translation set. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204154 (owner: 10Mhurd) [21:28:56] jdlrobson: we’re tsting out your patch. looks good [21:28:59] cool [21:31:12] Deskana: if you still have issues with your Android build try removing the ~/.gradle/caches/modules-2/files-2.1/org.mediawiki.api/json folder [21:31:28] bearND: have a few minutes to talk about making/testing changes to apps-android-java-mwapi? [21:31:37] mholloway: sure [21:31:37] thedj: ok great! i've opened my first ticket, for better, worse, or flat out incorrect here: https://phabricator.wikimedia.org/T96085. thanks! [21:31:59] Is it a batcave-worthy convo? [21:32:09] mholloway: not sure. Have you cloned the repo? [21:32:16] bearND: yep [21:32:36] coreyfloyd: bgerstle , on the video hangout for the meeting [21:32:42] (03CR) 10Robmoen: [C: 032] Skin styles done the proper way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204148 (https://phabricator.wikimedia.org/T96011) (owner: 10Jdlrobson) [21:32:49] mholloway: where are you stuck? [21:32:53] niedzielski, hi, please make sure you add projects when creating tasks in phabricator [21:33:12] Deskana: hey corey noticed the card i worked on the other day ( https://phabricator.wikimedia.org/T95940 - presently in the code review column of current iOS sprint) is a dupe of https://phabricator.wikimedia.org/T95513 [21:33:21] otherwise you rely on people specifically looking for project-less tasks to guess [21:33:26] Krenair: since the issue effected all projects, i wasn't sure if i would be advisable to add them all [21:33:41] no, I think the appropriate one is probably Wikimedia-Git-or-Gerrit [21:34:26] Krenair: thanks (and thanks for updating) [21:34:26] Project-less tasks are generally useless because they won't come to the attention of anyone able to change much, until someone specifically hunting such tasks deals with it [21:34:27] bearND: ah, i cloned java-mwapi but not app-android-java-mwapi, so i'll do that, but anyway just wondering how to make Android Studio use my local copy. [21:34:49] bearND: I think you told me last week but the info got lost on my end somewhere between receipt and processing :-) [21:35:03] mholloway: hmm, there is only one java-mwapi. Not sure where you got the other one from [21:35:32] bearND: was looking here: https://github.com/wikimedia/apps-android-java-mwapi [21:35:38] mholloway: you can import it into AS as well, chose "Import from external model" then Maven [21:35:49] Deskana: should i close the latter and making a note? [21:35:54] *make* [21:36:52] mholloway: The next screen you can use the defaults. When it asks you for an SDK use you JDK 1.7 one [21:37:05] since this is a pure Java library [21:37:16] (03PS1) 10Robmoen: Skin styles done the proper way [extensions/Gather] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204158 (https://phabricator.wikimedia.org/T96011) [21:37:30] (03PS1) 10Robmoen: Skin styles done the proper way [extensions/Gather] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204159 (https://phabricator.wikimedia.org/T96011) [21:38:08] (03CR) 10Robmoen: [C: 032] Skin styles done the proper way [extensions/Gather] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204159 (https://phabricator.wikimedia.org/T96011) (owner: 10Robmoen) [21:38:23] mholloway: it's easy to run the build and the tests from commandline: mvn install [21:38:39] mholloway: or use "mvn clean install" if necessary [21:39:15] mholloway: But you can also you the IDE feature to run the build or tests, or individual tests [21:40:44] (03CR) 10Robmoen: [C: 032] Skin styles done the proper way [extensions/Gather] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204158 (https://phabricator.wikimedia.org/T96011) (owner: 10Robmoen) [21:44:47] 10Wikipedia-iOS-App: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1208027 (10Mhurd) Dupe of https://phabricator.wikimedia.org/T95940 [21:45:29] 10Wikipedia-iOS-App: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1208030 (10Mhurd) [21:45:34] bearND: Ah, I thought for some reason there was a separate Android-specific version of java-mwapi because it's apps-android-java-mwapi on GitHub (and there's a separate 'java-mwapi' with different contents on Yuvi's GitHub acct)... [21:46:02] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1192867 (10Mhurd) [21:46:39] (03Merged) 10jenkins-bot: Skin styles done the proper way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204148 (https://phabricator.wikimedia.org/T96011) (owner: 10Jdlrobson) [21:46:46] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1208039 (10Mhurd) a:3Mhurd [21:46:47] (03Merged) 10jenkins-bot: Skin styles done the proper way [extensions/Gather] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204159 (https://phabricator.wikimedia.org/T96011) (owner: 10Robmoen) [21:47:19] (03CR) 10Robmoen: [V: 032] Skin styles done the proper way [extensions/Gather] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204158 (https://phabricator.wikimedia.org/T96011) (owner: 10Robmoen) [21:47:29] 10Wikipedia-iOS-App: Prevent adding table collapsing chrome around "mbox-small" tables, which are never shown. - https://phabricator.wikimedia.org/T95940#1208049 (10Mhurd) [21:48:17] Deskana: i got the 2 merged [21:48:21] bearND: Ah, there you are! [21:48:34] mholloway: sorry about that. [21:48:45] mholloway: where were we? [21:49:53] bearND: I figured out my confusion over the java-mwapi naming [21:50:11] mholloway: ok, was just checking the log. Yeah, there is only one library [21:50:30] bearND: So if I import my local copy that will override in the gradle build file? [21:50:33] mholloway: We make changes in Gerrit, and they get automatically sunced to GH, like all other porjects [21:50:38] synced [21:51:32] bearND: Actually, a better question is: [21:51:35] mholloway: No. If you want to use a newer version (i.e. you make changes you first need to update the version number in the pom.xml file of the library [21:52:18] mholloway: Then you update the version number in the build.gradle file to use it. You need to have it built first (mvn install) [21:53:00] Ah, OK [21:53:25] bearND: I'll do this now, while we're talking [21:53:41] (03PS4) 10Jdlrobson: Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:53:43] (03PS1) 10Jdlrobson: Hygiene: Make it possible to edit a collection from any page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204162 [21:54:01] (03CR) 10Jdlrobson: [C: 032] Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:55:50] mholloway: The Maven integration in AS doesn't seem to be as good as IntelliJ's but it seems to good enough for editing and browsing [21:57:53] mholloway: For Maven projects the convention is to update the version numbers like this: 1.3.1 -> 1.3.2-SNAPSHOT (while under development) -> 1.3.2 (once released) [21:57:59] bearND: hey! quick question since you're chatting about it, what does the android team prefer for development-- AS, IntelliJ, Eclipse, ...? [21:58:20] bearND: Ah, was about to ask about that [21:58:21] niedzielski: AS for most of the Android code [21:58:32] niedzielski: I strongly prefer AS to Eclipse [21:58:57] niedzielski: haven't used IntelliJ aside from AS myself [21:59:14] niedzielski: but I sometimes switch over to IntelliJ when editing the Python stuff, and WebStorm for the JS [21:59:19] side of things [21:59:20] * thedj uses vim for everything, regardless of the platform :) [21:59:21] mholloway: +1 for Gradle-based dependency management (AS) [22:00:03] thanks! [22:00:11] meh, gradle has it's downsides too. like all those systems [22:00:40] thedj: I have kind of a half-vim, half-Android Studio system going [22:00:41] thedj: i'm sure google will reinvent the way we build android apps again at IO [22:00:42] niedzielski: We don't use Eclipse usually. I think the only time we did something with it was when dbrant ran the memory profiler [22:01:44] bearND: do we support non-standard contributor configurations (like eclipse)? [22:01:47] niedzielski: but any editor should be fine since you can run the build from command line if you wish. AS is usually the most convenient, though [22:01:56] i find gradle to be unreadable often. it's so over engineered. [22:02:03] niedzielski: you mean for the app? [22:02:11] bearND: right [22:03:10] bearND: for example, if i build and test from android studio / gradle and everything works fine, i don't (generally speaking) have to test eclipse / ant / other configs? [22:03:16] niedzielski: Not really. I haven't used Eclipse in a few years. But if you feel the need for it that's fine [22:03:30] niedzielski: oh, that one. [22:03:34] i see collegues writing 8 bash wrappers around the 8 different ways they need to call gradle, for 8 different configurations that are in use. [22:03:40] niedzielski: No, we don't support that officially [22:03:52] bearND: sweet [22:03:53] so now you have 9 buildscripts :) [22:04:10] thedj: AS generated a gradle wrapper script for use, which resides in our repo [22:04:27] thedj: so you don't need to have Gradle installed [22:04:28] thedj: even jake wharton recommends a gradlew wrapper to call the gradlew shell script when it exists and fall back on a local gradle install when it doesn't [22:05:07] no i man for the like 8 variants we build apps in [22:05:10] thedj: (not saying that's a good thing, just par for gradle) [22:05:30] dev/staging/acceptance/production [22:05:45] and then developer signing/enterprise signing/production signing. [22:06:08] etc etc [22:06:34] different push configs, different ad network configs, etc etc. [22:06:34] thedj: what project are you talking about? [22:07:07] thedj: from your day job? [22:07:17] yup, we write apps for other companies, and that tends to get you into config hell [22:07:48] :) [22:11:34] jdlrobson: 1.26wmf1 is live, we ran out of time so we scheduled the 1.25wmf24 for SWAT today. [22:12:30] jdlrobson: I had to make the deployment cherry picks and jenkins was slow, at least they are merged now for the swatter [22:13:19] thedj: The different build types should just be handled by Jenkins. I actually like Gradle flavors. They helped us simplify the way we do our beta, alpha and production builds. They get different Android application ids, and different icons. Plus we can use BuildConfig class in Android to inject different behavior. [22:15:01] yeah but you guys work in 'sustainable' long term configs. much of what we do is very short cycle stuff and a customer is gone (or more often out of money) [22:15:51] thedj: Are you writing Android apps? [22:15:57] everything [22:16:07] ios/android/cordova/wp8 [22:16:17] thedj: wow [22:16:30] we started with j2me way back in the 2000s [22:17:05] I don't miss the Ant days [22:17:15] no me neither :) [22:18:23] altough our j2ee environments still need ant and maven [22:18:25] +1. I felt like I was writing everything any stock CI installation would need and naively expected the android ant framework to deliver [22:18:56] mholloway: Hey, How's the java-mwapi build? [22:20:01] (03CR) 10jenkins-bot: [V: 04-1] Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [22:34:39] (03CR) 10Yurik: [C: 04-1] Hygiene: Make it possible to edit a collection from any page (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204162 (owner: 10Jdlrobson) [22:56:25] 6Mobile-Web, 6Collaboration-Team, 10Collaboration-Team-Sprint-U-2015-04-22, 10Flow, and 3 others: Problem with navigating between topics with TOC - https://phabricator.wikimedia.org/T93502#1208242 (10DannyH) 5Open>3Resolved Works on Beta [22:56:28] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Tracking: Flow issues on mobile web (tracking) - https://phabricator.wikimedia.org/T93430#1208244 (10DannyH) [22:58:40] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1208248 (10Etonkovidova) 'Tel Aviv' and 'Germanic peoples' articles' 'External links' have the same template indicated that it is "Generated from: commons category" -... [23:00:26] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1208250 (10Mhurd) Thanks Elaina! The patch here: https://gerrit.wikimedia.org/r/#/c/203887/ fixes the issue in both of those articles. [23:09:12] coreyfloyd: bgerstle_afk i'm going to actually push the button at 8:15 am pacific time tomorrow, as comms will go at 9:15 am. that way there won't be as much of a lag between comms and the moment it's actually available on the app store. Deskana okay'd and mhurd said cool. don't worry about hopping online early at 8:15 am. i know you guys are usually on by 9:15 am...good enough [23:11:46] 10Wikipedia-iOS-App: iOS app jumps unexpectedly during scrolling on page linked with section hash - https://phabricator.wikimedia.org/T74797#1208298 (10Etonkovidova) There is no more issue with "jumps" when scrolling through long tables(e.g. https://en.wikipedia.org/wiki/List_of_White_Collar_episodes#Season_3)... [23:11:53] 10Wikipedia-iOS-App: iOS app jumps unexpectedly during scrolling on page linked with section hash - https://phabricator.wikimedia.org/T74797#1208299 (10Etonkovidova) 5Open>3Resolved [23:16:17] dr0ptp4kt: I'll be online by then, that's 11 EDT [23:16:29] bgerstle_afk: i know, SOOOO early, need coffee [23:16:45] ;) [23:17:54] 10Wikipedia-iOS-App: The page gets deleted from Recent sections too, if deleted for the "Saved Pages" section - https://phabricator.wikimedia.org/T74412#1208311 (10Etonkovidova) Re-checked with 4.1.1(79) - the issue is resolved. Deleting Saved articles does not affect Recent; vice versa is also true. [23:18:01] 10Wikipedia-iOS-App: The page gets deleted from Recent sections too, if deleted for the "Saved Pages" section - https://phabricator.wikimedia.org/T74412#1208312 (10Etonkovidova) 5Open>3Resolved [23:32:36] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1208339 (10kaldari) [23:34:07] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Fix for extra whitespace around small images regression - https://phabricator.wikimedia.org/T95738#1208341 (10Etonkovidova) 4.1.1(79) Checked on iPad mini and iPhone 5 - no extra space around the IPA pronunciation icon. [23:49:20] 10Wikipedia-iOS-App: Image viewer image for lead image in "List of diplomatic missions in Russia" throws a 414 error - https://phabricator.wikimedia.org/T93462#1208414 (10Etonkovidova) Re-checked the issue on 4.1.1(79) - no 414 errors. [23:49:52] 10Wikipedia-iOS-App: Image viewer image for lead image in "List of diplomatic missions in Russia" throws a 414 error - https://phabricator.wikimedia.org/T93462#1208415 (10Etonkovidova) 5Open>3Resolved [23:56:30] dr0ptp4kt: sounds good thanks for the heads up [23:56:49] coreyfloyd: have a good night [23:56:50] jdlrobson: fixed on en.wiki: https://en.m.wikipedia.org/wiki/Special:UserProfile/Kaldari [23:57:03] dr0ptp4kt: are you heading out? [23:57:40] coreyfloyd: pretty soon, but more was hoping you'd be getting ready to rest up - lots of fun tomorrow :) [23:57:51] lol [23:58:15] ill be good - I got some work to do this week - so going to be hanging out a bit [23:58:45] kaldari: \o/ super star