[00:01:09] 10Gather, 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: userprofile.less styles not loaded on minerva (or the user profile) - https://phabricator.wikimedia.org/T96011#1208480 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Fixed on enwiki. I replied on the talk page [00:17:03] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1208497 (10kaldari) Here are the lists of articles that would have the tags... {F112957} [00:33:23] (03PS1) 10Robmoen: Add flag collection button and overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204201 [00:33:27] (03CR) 10jenkins-bot: [V: 04-1] Add flag collection button and overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204201 (owner: 10Robmoen) [00:41:40] 10Gather, 3Gather Sprint Forward: Add a flag button - https://phabricator.wikimedia.org/T94871#1208517 (10rmoen) Patch here: https://gerrit.wikimedia.org/r/#/c/204201/ The schema registration was a bit confusing. I think I got it all rigged up but needs tested. All that's left is schema testing and any riggin... [01:18:53] bearND, did you get an email from a letsufrn@gmail.com as well? [02:09:58] Krenair: no, i haven't seen one [04:48:20] 6Mobile-Web: Spike: how can we create diagnostic that VE team built? - https://phabricator.wikimedia.org/T95447#1208691 (10phuedx) This is purely technical. The functionality that I was talking about is already available to us in Chromium: https://commons.wikimedia.org/wiki/File:Demonstration_of_Chromium%27s_ti... [04:48:30] 6Mobile-Web: Spike: how can we create diagnostic that VE team built? - https://phabricator.wikimedia.org/T95447#1208692 (10phuedx) 5Open>3Invalid a:3phuedx [05:01:30] Are the Wikipedia Android app device metrics publicly available? These stats would be exportable from the Google Play developer console and are similar to those tracked in the platform dashboard (https://developer.android.com/about/dashboards/index.html). It would be wonderful to share the current app audience makeup. In particular, API level and screen dimensions offer insights for dev and design [05:01:32] changes, device testing, and roadmap vision. I apologize in advance if they are available and I'm just not seeing them. [05:06:08] niedzielski: AFAIK they are not. [05:06:39] niedzielski: I think in principle there's no issue with releasing them publicly but I would need to check with Legal since we are very protective of data privacy. :-) [05:09:31] hm, ok. i'm not sure it justifies a phrabicator ticket but it seems like it would be quite a useful thing. even just to say "this is why we support gingerbread" or "half our users have mdpi devices with 10cm screens" [05:11:26] Deskana: i'm also trying to understand some of the design goals of the app. material design seems a given but i think changes still have to be rooted (i.e., function) in the current user base as well [05:12:37] niedzielski: Can you give me an example of what you mean? [05:13:48] Deskana: an easy example might be, what image densities does the app have to support? another would be, what are the top tier devices to test on? [05:15:27] niedzielski: I suppose that depends what you mean by "design goals". :-) [05:17:02] niedzielski: Do you mean image densities in article content, or for UI icons and such? [05:19:25] (03PS3) 10Florianschmidtwelzow: Add support for extensions to add custom login messages for mobile login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203893 (https://phabricator.wikimedia.org/T95903) [05:19:32] (03PS3) 10Florianschmidtwelzow: Login messages: Add support for MobileFrontend loginpage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203894 (https://phabricator.wikimedia.org/T95903) [05:21:41] Deskana: i was thinking the prebaked ui icons at a minimum [05:23:20] (03CR) 10jenkins-bot: [V: 04-1] Login messages: Add support for MobileFrontend loginpage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203894 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [05:23:47] niedzielski: We have scripts that generate those from SVGs in the repo, so there's not much overhead for that. [05:26:25] Anyway, I have to go to bed. It was a looooong day. [05:26:34] Speak to you more soon. :-) [05:27:38] sounds good. me too. will bug you more another time :) [05:50:06] 10Gather, 6Mobile-Web, 10MobileFrontend: userprofile.less styles not loaded on minerva (or the user profile) - https://phabricator.wikimedia.org/T96011#1208705 (10phuedx) [06:03:50] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Window on leave code in editor overlay should be reusable or dropped - https://phabricator.wikimedia.org/T94194#1208725 (10phuedx) a:3Florian [09:16:34] 10Gather: Allow autopatrolled users to contribute in list moderation. - https://phabricator.wikimedia.org/T94641#1208908 (10Moushira) [09:24:54] g'morning y'all [09:39:56] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 7Epic: Deploy the latest version of WikiGrok (0.2? 0.3?) - https://phabricator.wikimedia.org/T95874#1208939 (10phuedx) [09:41:57] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: PLURAL support for MobileFrontend licensing messages - https://phabricator.wikimedia.org/T93058#1208944 (10phuedx) 5Open>3Resolved [10:24:34] hi hi [10:38:15] yo [10:38:58] 10Gather, 3Gather Sprint Forward: Remove delete button from collection page and fix behavior so it does not send you back to collection when you click it. - https://phabricator.wikimedia.org/T95732#1208993 (10Jhernandez) a:3Jhernandez [10:39:35] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1208995 (10phuedx) The VE behaviour appears to be because of a bug in Safari on iOS 8.2 related to the `-webkit-overflow-scrolli... [10:41:43] hey MaxSem [10:41:50] what are you doing up [10:46:21] maaaaps [10:48:44] 3Gather Sprint Forward: Link to collection on the toast when creating or adding item is sucessful - https://phabricator.wikimedia.org/T96133#1208997 (10Jhernandez) 3NEW [10:49:47] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1209005 (10phuedx) It's my understanding that this bug was the same for the Wikitext editor and my fix was simply a workaround.... [10:51:56] cool :D [10:52:46] (03PS1) 10Jhernandez: Don't show Delete button on a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204243 (https://phabricator.wikimedia.org/T95732) [10:53:53] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Remove delete button from collection page and fix behavior so it does not send you back to collection when you click it. - https://phabricator.wikimedia.org/T95732#1209009 (10Jhernandez) Patch removes the delete button from the collection page. The redirec... [10:54:35] 10Gather, 3Gather Sprint Forward: Meta tags for a users list of collections - https://phabricator.wikimedia.org/T95239#1209011 (10Jhernandez) a:3Jhernandez [11:04:08] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Spike (4 hours): Investigate existing site speed metrics - https://phabricator.wikimedia.org/T95296#1209013 (10phuedx) Google Analytics reports the average amount of time it takes the page to load, from the user clicking a link to that page being completel... [11:07:00] gonna take an early lunch [11:07:04] diy time [11:25:36] bb! [11:38:16] (03PS1) 10Jhernandez: Hygiene: Extract image to thumbnail to reusable method [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204245 (https://phabricator.wikimedia.org/T95239) [11:38:18] (03PS1) 10Jhernandez: Add meta tags for when sharing /by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204246 (https://phabricator.wikimedia.org/T95239) [11:43:44] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Extract image to thumbnail to reusable method [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204245 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [11:44:26] (03CR) 10jenkins-bot: [V: 04-1] Add meta tags for when sharing /by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204246 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [11:44:31] great... [11:44:39] damn jerkins [11:48:45] (03CR) 10Florianschmidtwelzow: [C: 032] "> Looking more closely I was confusing this with $wgMFCollapseSectionsByDefault" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [11:53:17] (03Merged) 10jenkins-bot: Get rid of $wgMFPageSections config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203953 (https://phabricator.wikimedia.org/T95884) (owner: 10Bene) [12:04:30] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Meta tags for a users list of collections - https://phabricator.wikimedia.org/T95239#1209033 (10Jhernandez) Verified with [[ https://developers.facebook.com/tools/debug/og/object/ | facebook's object debugger ]] and [[ https://ngrok.com/ | ngrok ]]. Looks... [12:12:40] (03CR) 10Jhernandez: [C: 032] Make search feel smoother [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203955 (owner: 10Jdlrobson) [12:16:57] (03CR) 10jenkins-bot: [V: 04-1] Make search feel smoother [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203955 (owner: 10Jdlrobson) [12:18:54] back [12:19:57] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203955 (owner: 10Jdlrobson) [12:24:05] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Spike (4 hours): Investigate existing site speed metrics - https://phabricator.wikimedia.org/T95296#1209039 (10phuedx) http://www.yottaa.com/bid/295062/Page-Load-Time-Is-Not-the-Only-Key-Performance-Metric argues that the time until the start of rendering... [12:24:28] (03CR) 10Jhernandez: [C: 04-1] Open search interface full screen when focused (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203978 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:24:36] (03PS2) 10Jhernandez: Open search interface full screen when focused [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203978 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:28:03] (03CR) 10Jhernandez: [C: 032] "Cool stuff. I may tackle renaming some of the edit name/desc methods to follow the search pane method names like in this patch which makes" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203978 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:29:10] (03PS2) 10Jhernandez: Add clear button to search within editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203979 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:30:17] jerkinnnnnnnnnnnnnnnnnnnnnnnnnns [12:31:18] jerkins karma and chrome have decided that no code will be merged today [12:31:33] https://en.wikipedia.org/wiki/Wikipedia_talk:Gather/Moderation_Criteria [12:31:40] i left some comments [12:32:30] (03PS3) 10Jhernandez: Add clear button to search within editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203979 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:34:10] (03CR) 10jenkins-bot: [V: 04-1] Add clear button to search within editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203979 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:34:23] (03Merged) 10jenkins-bot: Make search feel smoother [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203955 (owner: 10Jdlrobson) [12:34:26] (03Merged) 10jenkins-bot: Open search interface full screen when focused [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203978 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:37:53] (03CR) 10Jhernandez: [C: 04-1] "Seems like clicking the X blurs out of the input. We should avoid that or refocus on it. Gonna have a look and see if I can fix it." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203979 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:46:31] (03PS4) 10Jhernandez: Add clear button to search within editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203979 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:47:12] (03CR) 10Jhernandez: [C: 032] "Easy one line fix for the blur thingy. Mergin' since I haven't really done much on the patch" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203979 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:50:03] (03Merged) 10jenkins-bot: Add clear button to search within editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203979 (https://phabricator.wikimedia.org/T95778) (owner: 10Jdlrobson) [12:51:29] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Tweak the search in EditorOverlay behaviour - https://phabricator.wikimedia.org/T95778#1209084 (10Jhernandez) The criteria for this card is met and the patches are merged. But, I'd like to point out the lack of a spinner when searching. It may be importan... [12:55:28] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Spike (4 hours): Investigate existing site speed metrics - https://phabricator.wikimedia.org/T95296#1209088 (10phuedx) [12:56:34] (03CR) 10Jhernandez: [C: 032] "WTF. This requires an explanation. Will ask in the bug." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203842 (https://phabricator.wikimedia.org/T95744) (owner: 10Jdlrobson) [12:59:56] (03Merged) 10jenkins-bot: Prevent auto-reopening of collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203842 (https://phabricator.wikimedia.org/T95744) (owner: 10Jdlrobson) [13:00:15] 3Gather Sprint Forward, 5Patch-For-Review: Adding/removing to watchlist when new user causes window to reopen - https://phabricator.wikimedia.org/T95744#1209094 (10Jhernandez) @jdlrobson {F113173} Seriously though, shouldn't the `options` object always be the same as `this.options`? What's going on? [13:04:22] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Spike (8 hours): Design site speed schemas - https://phabricator.wikimedia.org/T95297#1209105 (10phuedx) AFAICT this is mostly done for us by the NavigationTiming extension, [Graphite](https://graphite.wikimedia.org/), and gdash – the graphs over at [WMF s... [13:04:32] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Spike (8 hours): Design site speed schemas - https://phabricator.wikimedia.org/T95297#1209106 (10phuedx) 5Open>3Invalid a:3phuedx [13:04:34] 6Mobile-Web, 7Epic, 7Performance: Continuously measure mobile site speed - https://phabricator.wikimedia.org/T94752#1209108 (10phuedx) [13:05:25] i love it when work is already done for us [13:05:27] \o/ [13:05:30] hah [13:06:34] the answer is "we already do, but it could be made a little more visible" [13:07:56] jshint jenkins task failed [13:08:02] * joakino opens up the log [13:08:06] 23:08:55 java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 [13:08:15] WAT [13:08:17] hah [13:11:34] :O [13:11:37] wtf? [13:14:43] (03CR) 10Jhernandez: "jshint error: resources/ext.gather.collection.base/CollectionsContentOverlayBase.js: line 30, col 24, '$' is not defined." (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203884 (https://phabricator.wikimedia.org/T93797) (owner: 10Jdlrobson) [13:14:53] (03CR) 10Jhernandez: [C: 04-1] Truncate collection titles in toast [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203884 (https://phabricator.wikimedia.org/T93797) (owner: 10Jdlrobson) [13:20:25] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Toast should clip long collection titles - https://phabricator.wikimedia.org/T93797#1209134 (10Jhernandez) Lol @ the description image. From the patch: > jshint error: resources/ext.gather.collection.base/CollectionsContentOverlayBase.js: line 30, col 2... [13:23:58] (03CR) 10Jhernandez: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203982 (https://phabricator.wikimedia.org/T95788) (owner: 10Jdlrobson) [13:24:16] out for lunch! [13:24:50] (03CR) 10Jhernandez: [C: 032] Truncate edit overlay title where necessary [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203982 (https://phabricator.wikimedia.org/T95788) (owner: 10Jdlrobson) [13:26:09] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Bug: Long titles should be clipped in EditorOverlay - https://phabricator.wikimedia.org/T95788#1209147 (10Jhernandez) As I mentioned on the other long titles bug, this is not a huge issue now that the titles are limited to 90 chars, but it is fine. It is... [13:28:08] (03Merged) 10jenkins-bot: Truncate edit overlay title where necessary [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203982 (https://phabricator.wikimedia.org/T95788) (owner: 10Jdlrobson) [13:55:51] (03CR) 10Anomie: [C: 04-1] "Needs i18n messages for API help. As do all the existing modules, for that matter." (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [14:03:25] 6Mobile-Web, 7Epic, 7Performance: Continuously measure mobile site speed - https://phabricator.wikimedia.org/T94752#1209216 (10phuedx) [14:03:27] 6Mobile-Web: (3) Instrument the schemas designed in T95297 - https://phabricator.wikimedia.org/T95299#1209211 (10phuedx) 5Open>3Invalid a:3phuedx See T95297. [14:04:46] 6Mobile-Web, 10Performance-Metrics-Dashboard: (3) Create a mobile site speed dashboard - https://phabricator.wikimedia.org/T95300#1209219 (10phuedx) [14:05:44] 6Mobile-Web, 10Performance-Metrics-Dashboard: (3) Create a mobile site speed dashboard - https://phabricator.wikimedia.org/T95300#1185993 (10phuedx) Given the result of T95296, I think this is now a 2. @kaldari, @bmansurov: what say ye? [14:07:08] 6Mobile-Web, 10Performance-Metrics-Dashboard: (3) Create a mobile site speed dashboard - https://phabricator.wikimedia.org/T95300#1209228 (10phuedx) [14:15:24] phuedx: is there a trick to logging into graphite? [14:15:32] it's telling me to use my wiki login, but all the ones i tried didn't work [14:15:41] bgerstle: wikitech [14:15:51] thought i tried that one.. [14:16:41] huh [14:16:55] bgerstle: any joy? [14:16:56] yeah, i can log in to wikitech [14:17:00] but not graphite [14:17:47] :/ [14:18:01] then i suspect this is a problem with my passwords rather than yours [14:18:14] that is, wikitech and "wiki login for http auth" are duplicated [14:19:43] says "WMF Labs use wiki login name not shell" [14:19:44] * bgerstle shrugs [14:19:59] :/ [14:20:05] maybe because my wikitech login uses my personal email...? [14:20:13] not my @wikimedia.org [14:20:59] when in doubt, try /all/ the combinations [14:21:05] maybe your password is your username? [14:21:24] brb [14:23:46] my wikitech login is just phuedx -- it ain't nothing special [14:23:51] i registered before i joined wmf i think [14:25:37] i'm gonna go for a short unicycle ride [14:25:44] wish me luck [14:25:48] glhf [14:25:49] o/ [14:25:49] i haven't done this for about 9 months [14:40:26] backsies [14:40:36] that was mostly successful [14:40:37] \o/ [14:40:40] nice [14:40:48] just a quick ride to get your circus fix? [14:41:54] the weather's great at the moment [14:42:04] felt like taking my old uni out for a spin [14:42:13] so yeah: fix [14:47:00] bgerstle: also, i bought myself an ice cream [14:47:02] so there's that [14:49:17] (03CR) 10Phuedx: "Florian: is there anything we can help with to get this merged?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow) [14:49:58] is this channel also about the Wikipedia App? [14:51:13] benestar: yes, it is [14:51:30] I got a bug on my Android phone, shareafact does not work :( [14:52:18] when selecting a text, only the native HTC Sense sharing appears but the top bar does not change as expected [14:52:22] benestar: yes it is [14:52:32] benestar: hm, interesting [14:52:39] bearND: mholloway ^^ [14:52:51] benestar: I'm one of the Android developers, so you've come to the right place [14:53:24] benestar: what's the Android version? [14:53:29] bearND: need a screenshot? or is there already a bug? [14:53:57] Android Version 4.1.1, HTC Sense Version 4+ [14:54:05] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1209341 (10phuedx) I'm happy with the lists. @JKatzWMF: whaddya think? [14:54:26] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1209351 (10phuedx) a:3phuedx [14:54:35] benestar: interesting [14:54:43] benestar: we don't have a bug for this one yet. Are you comfortable filing a bug on https://phabricator.wikimedia.org? Yes screenshot would be nice [14:54:49] will do [14:54:50] benestar: screenshots always helpful [14:54:59] benestar: thanks! [14:56:28] benestar: and the info about the version of the Android OS in this case is very helpful. Thank you! Sounds like something HTC specific. We're having to do some Android trickery to get the text of the selection and override the share button. [14:56:45] I mean "we're doing some..." [14:57:36] bearND mholloway: which project is the right one to assign? [14:57:41] benestar: What happens when you press the share button? [14:57:56] bearND: there is no share button, the header just does not change [14:58:04] benestar: wikipedia-android-app [14:58:28] benestar: hmm, that is strange [14:58:39] phuedx: since Special:Tags is already taken and this are Gather based tags, do you think we could use Special:Gags? 😂 [14:59:04] joakino: YES! [14:59:10] that's going on the mailing list [15:02:40] 10Wikipedia-Android-App: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1209359 (10Bene) 3NEW [15:02:58] bearND mholloway: https://phabricator.wikimedia.org/T96144 [15:04:01] benestar: Thanks! I see it. Wow, that's a very custom Contextual Action Bar. [15:04:15] Perhaps some HTC Sense feature... [15:04:17] benestar: What happens when you click on "Teilen" (share)? [15:05:13] just the default sharing dialog appears [15:05:20] and it only contains the text selected [15:05:37] 10Wikipedia-Android-App: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1209370 (10Deskana) @Bene What happens if you tap the share button? [15:12:22] 10Wikipedia-Android-App: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1209382 (10Bene) Just the default sharing dialog appears, and when selecting an option, it contains only the selected text. {F113226} [15:22:07] bgerstle: i finally bought a v60 [15:22:15] which i've been meaning to do for a while now [15:23:00] phuedx: my next coffee purchase would probably be a bonavita, TBH [15:23:11] (supposed to be a good drip machine) [15:23:20] how do you like the v60? [15:23:34] and why would you use the ever-amazing aeropress? [15:23:38] you not use* [15:23:56] does anybody know how much until the We are all remoties talk? cc phuedx bgerstle [15:25:14] jebus 9pm Spain [15:25:25] great time for a weareallremoties talk... [15:25:26] joakino: good Q lemme check [15:25:29] OH the irony [15:25:31] joakino: lol [15:25:48] -_-' always the same [15:26:10] joakino: well you could always do something amazingly spanish to make up for it [15:26:51] and obnoxiously bring it up in the meetings [15:26:53] bgerstle: the least will be beer [15:27:00] "sorry guys, was just having a siesta" [15:27:05] xD [15:27:07] "sorry i'm late, was just, you know, running with the bulls" [15:27:23] "ah, just having coffee where Hemmingway used to sit..." [15:27:39] bgerstle, joakino: lol ol [15:27:55] lolol [15:27:56] even [15:28:00] i'm a professional [15:28:05] joakino phuedx 1200 SF time/1900 UTC [15:28:05] bgerstle: it's fun to experiment [15:28:17] re why not use the aeropress [15:28:37] different brew methods emphasis/soften different parts of the brew [15:28:53] chemex -> sour/"acidy" parts and oh boy the fruit [15:29:07] aeropress -> you certainly get fruit but you also get more body [15:29:14] v60 seems to be roughly there [15:29:19] but i've only used it a couple of times [15:29:20] yeah i've noticed that... made a very tangy cup when i got my fine metal filter [15:29:24] http://media.giphy.com/media/Fivcrc8cPqE6c/giphy.gif [15:29:40] phuedx: are you a scotch/whiskey guy? [15:29:58] bgerstle: i rarely drink [15:30:21] and when i do it's mostly beer [15:30:28] because this conversation reminds me of this: https://www.youtube.com/watch?v=YVG1U-faqHY [15:30:31] however, i do have a bottle of whiskey in my house [15:30:49] i can imagine you tossing a cup of coffee over your shoulder in a show of snobbery [15:30:53] bgerstle: http://www.bruichladdich.com/whisky-shop/bruichladdich/cuvee-407 [15:31:00] bearND mholloway: do you have stats how many Wikipedia App users have HTC Sense installed on their devices? [15:31:22] TIL: some sites say "My Basket" instead of "My Cart" [15:31:26] thus how many users are affected by that bug [15:31:29] must be a UK thing [15:32:51] bgerstle: that video is amazing [15:33:01] friend of mine shared it who's into that stuff [15:33:11] and it's exactly how i drink my coffee [15:33:15] phuedx: joakino i don't see a link to the "remoties" talk [15:33:51] bgerstle: phuedx: as usual they'll do it 30 seconds before starting... [15:34:12] (03CR) 10Bgerstle: [C: 032] Fix for side to side scrolling of wide images with div overlays. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 (owner: 10Mhurd) [15:34:18] haha [15:34:26] by the way this is starting [15:34:27] GO GO GO [15:35:05] (03CR) 10Jhernandez: [C: 032] Show pages outside main namespace [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203991 (https://phabricator.wikimedia.org/T94786) (owner: 10Jdlrobson) [15:35:55] benestar: I haven't seen a breakdown like that. I only see the top 10 devices. [15:38:49] (03PS6) 10Bgerstle: Fix for side to side scrolling of wide images with div overlays. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 (owner: 10Mhurd) [15:39:17] (03Merged) 10jenkins-bot: Show pages outside main namespace [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203991 (https://phabricator.wikimedia.org/T94786) (owner: 10Jdlrobson) [15:41:27] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Can create collection with non-main namespace pages but they do not show up - https://phabricator.wikimedia.org/T94786#1209460 (10Jhernandez) As @jdlrobson said having two sort orders is more complicated. For now the non-main pages show with the main pages... [15:42:16] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Show a prompt with basic article data on link tap, which allows user to click through to the original link - https://phabricator.wikimedia.org/T95734#1209463 (10BGerstle-WMF) [15:46:48] (03CR) 10Jhernandez: [C: 032] Deal with inconsistent API response and infinite spinner [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203387 (https://phabricator.wikimedia.org/T95637) (owner: 10Jdlrobson) [15:48:38] phuedx: what is starting [15:48:48] joakino: nothing ;) [15:48:52] lol [15:48:56] don't scare me [15:56:29] (03CR) 10Jhernandez: Add route for Special:Gather/by/ (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [15:58:02] (03PS2) 10Jhernandez: Add route for Special:Gather/by/ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [16:01:22] (03Merged) 10jenkins-bot: Deal with inconsistent API response and infinite spinner [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203387 (https://phabricator.wikimedia.org/T95637) (owner: 10Jdlrobson) [16:04:03] 10Gather: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1209511 (10Jhernandez) 3NEW [16:04:57] (03CR) 10Jhernandez: [C: 032] "Mergin'. This is just a weird case that shouldn't usually happen. For concerns about the regex performances see T96150" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [16:08:42] 10Gather, 3Gather Sprint Forward: Redirect Special:Gather & friends to Special:Gather/by/User for sharing purposes - https://phabricator.wikimedia.org/T96151#1209521 (10Jhernandez) 3NEW [16:10:14] (03CR) 10Jhernandez: "Also I'm thinking that this if should be doing a redirect to /by/user instead of just showing it. I've created T96151 for discussion" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [16:11:50] (03PS3) 10Bgerstle: Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 (https://phabricator.wikimedia.org/T95513) (owner: 10Mhurd) [16:11:54] (03PS4) 10Bgerstle: Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 (https://phabricator.wikimedia.org/T95513) (owner: 10Mhurd) [16:12:04] (03CR) 10Bgerstle: "updated bug ref to original ticket and rebased" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 (https://phabricator.wikimedia.org/T95513) (owner: 10Mhurd) [16:13:27] (03CR) 10Jhernandez: Add route for Special:Gather/by/ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [16:13:37] (03CR) 10Jhernandez: [C: 032] Add route for Special:Gather/by/ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [16:13:45] (03PS3) 10Jhernandez: Add route for Special:Gather/by/ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [16:13:54] (03Abandoned) 10Fjalapeno: Run Synx [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204006 (owner: 10Fjalapeno) [16:14:06] dr0ptp4kt: are we actually joining the hangout for the "launch" meeting? [16:14:07] (03CR) 10Jhernandez: Add route for Special:Gather/by/ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [16:14:15] (03CR) 10Jhernandez: [C: 032] Add route for Special:Gather/by/ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [16:14:20] bgerstle: yeah, let's [16:14:38] you can't win jerkins, i wont give up [16:15:42] (03CR) 10Fjalapeno: [C: 031] Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 (https://phabricator.wikimedia.org/T95513) (owner: 10Mhurd) [16:23:27] (03Merged) 10jenkins-bot: Add route for Special:Gather/by/ [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [16:23:58] 6Mobile-Web, 6Collaboration-Team, 10VisualEditor, 10VisualEditor-EditingTools, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1209584 (10Jdlrobson) 3NEW [16:24:02] 6Mobile-Web, 6Collaboration-Team, 10VisualEditor, 10VisualEditor-EditingTools, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1209593 (10Jdlrobson) [16:24:12] moornning [16:30:55] (03CR) 10Jdlrobson: Fix for side to side scrolling of wide images with div overlays. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203495 (owner: 10Mhurd) [16:34:08] hey jdlrobson [16:34:31] jdlrobson: going over mw-ui-icon stuff again atm [16:34:40] but just about to break for dinner with the fam [16:34:42] before MEETINGS [16:36:08] phuedx: sure. we probably want to wait till the branch is cut to be honest [16:36:18] i would have liked a grace day at least to catch bugs on beta labs [16:36:21] 6Mobile-Web, 6Collaboration-Team, 10VisualEditor, 10VisualEditor-EditingTools, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1209648 (10Krinkle) Cookies should only be used for things that the server needs to read when handling an HTTP request. Anything... [17:00:31] 10Gather, 3Gather Sprint Forward: API: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1209722 (10Jdlrobson) [17:11:24] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1209736 (10Mholloway) Here's how I have it looking at the moment when a server error code is available. {F113283} [17:14:13] 6Mobile-Web, 10MobileFrontend, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: (2) Email confirmation workflow doesn't work correctly from a Mobile device - https://phabricator.wikimedia.org/T95065#1209738 (10kaldari) [17:18:30] an astonishingly beautiful post-rock-shoegaze-metal track: https://www.youtube.com/watch?v=yZPpjd5DsTA [17:18:36] if yer into that sort of thing, obvs [17:18:42] also, it's one guy [17:18:46] one guy [17:21:02] (03CR) 10Jdlrobson: [C: 032] Don't show Delete button on a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204243 (https://phabricator.wikimedia.org/T95732) (owner: 10Jhernandez) [17:21:32] rmoen: i worry that the deletion confirmation overlay we have is creating unnecessary complexity and we should just use a JavaScript confirm instead [17:21:32] thoughts? [17:21:36] ^ cc joakino [17:22:13] at very least it probably shouldn't have a route associated with it - especially given you now click delete within an overlay and its very jarring [17:22:16] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6CA-team, 10MediaWiki-API, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1209769 (10bearND) 5Resolved>3Open Reopening since it's probably not fixed on iOS yet. [17:22:22] (03PS5) 10Jdlrobson: Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [17:22:26] jdlrobson: rmoen: as you guys want [17:22:38] jdlrobson: rmoen: agree about not having the route [17:22:39] (03CR) 10Jdlrobson: [C: 031] Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [17:22:44] (03CR) 10Jdlrobson: [C: 032] Untested refactor of JS code to hide / show collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [17:23:11] (03PS6) 10Jdlrobson: Hygiene: Refactor JS code for hiding/showing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [17:23:26] (03CR) 10Jdlrobson: [C: 031] Hygiene: Refactor JS code for hiding/showing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [17:23:33] (03CR) 10Jdlrobson: [C: 032] Hygiene: Refactor JS code for hiding/showing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [17:24:24] 3Gather Sprint Forward: Deleting a collection should not have an associated route - https://phabricator.wikimedia.org/T96167#1209775 (10Jdlrobson) 3NEW [17:24:26] ^ rmoen joakino [17:24:43] 👍 [17:26:18] (03Merged) 10jenkins-bot: Don't show Delete button on a collection page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204243 (https://phabricator.wikimedia.org/T95732) (owner: 10Jhernandez) [17:27:42] bgerstle build failing because of the simulator destination renaming from Xcode 6.3 [17:29:18] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor JS code for hiding/showing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [17:29:32] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Remove delete button from collection page and fix behavior so it does not send you back to collection when you click it. - https://phabricator.wikimedia.org/T95732#1209789 (10Jdlrobson) 5Open>3Resolved [17:29:47] (03PS2) 10Jdlrobson: Hygiene: Extract image to thumbnail to reusable method [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204245 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [17:30:35] (03PS1) 10Fjalapeno: Fix unit tests - 8.3 is now the current version of the SDK [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204297 [17:30:47] dr0ptp4kt: bgerstle ^ [17:30:50] quick review [17:31:00] coreyfloyd: replace "destination: ..." with "sdk: 'iphonesimulator'" [17:31:02] (03CR) 10Jdlrobson: Hygiene: Extract image to thumbnail to reusable method (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204245 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [17:31:06] ^ joakino thoughts? [17:31:08] running it locally on my machine [17:31:42] (03PS2) 10Jdlrobson: Add meta tags for when sharing /by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204246 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [17:31:52] jdlrobson: sounds good, wanna change it and merge it yourself? [17:31:53] (03CR) 10Jdlrobson: [C: 031] "pending comment on dependency" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204246 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [17:32:03] joakino: can do - or i can do a follow up? [17:32:14] as you please [17:32:40] coreyfloyd: that fixes it for me [17:32:42] joakino: i'm still not 100% clear - why can't we use WithImage here? [17:32:45] coreyfloyd: shall i submit a patch? [17:33:04] it's an interface, so we're duplicating the method anywhere you want to use it [17:33:13] coreyfloyd: are you going to try it on the server or should i? [17:33:47] (03CR) 10Jdlrobson: [C: 032] Hygiene: Extract image to thumbnail to reusable method [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204245 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [17:33:54] feck it. [17:34:01] (03CR) 10Jdlrobson: [C: 032] Add meta tags for when sharing /by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204246 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [17:34:10] side note, our project seems to have more warnings due to new truncation warning settings in Xcode 6.3 [17:34:15] jdlrobson: the perfect solution would be that the file would be an Image and that would have the thumbnail methods so that we could do $collection->getFile()->getThumbnail() but right now the file is a File [17:34:20] jdlrobson: lol [17:38:51] (03Merged) 10jenkins-bot: Hygiene: Extract image to thumbnail to reusable method [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204245 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [17:38:53] (03Merged) 10jenkins-bot: Add meta tags for when sharing /by/User [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204246 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [17:40:37] dr0ptp4kt: so, you want to pair on the MobileAppSearch logging? [17:40:42] how do you want to split it up? [17:40:58] bgerstle: yeah, in the afternoon sf time [17:42:24] ok, in the meantime..? [17:42:32] mind if i get started? [17:42:35] or should i work on something else [17:45:10] coreyfloyd: see my suggestions about the destination error? [17:45:21] jdlrobson, joakino sorry i was relocating. So my work on the flag confirmation factors out the confirmation overlay and makes the code way less complex [17:45:33] 6Mobile-Web, 7Performance, 7Wikimedia-log-errors: (4 hrs) ResourceLoader timestamp for mobile.usermodule changes constantly - https://phabricator.wikimedia.org/T90411#1209847 (10JKatzWMF) [17:46:00] jdlrobson: i'm not sure what is wrong with the route. I guess I'll have to try deleting in the edit dialog to see what is jarring about this [17:47:01] 6Mobile-Web, 7Performance, 7Wikimedia-log-errors: (4 hrs) ResourceLoader timestamp for mobile.usermodule changes constantly - https://phabricator.wikimedia.org/T90411#1209851 (10Jdlrobson) Ping @krinkle ? [17:47:02] bgerstle: batcave? [17:47:21] mhurd about to hop on a hangout w/ etonkovidova to diagnose some xcode stuff [17:47:22] bgerstle: one sec… i think there is also a problem with the recent versions of fastlane… like the cert command seems broken [17:47:29] oh [17:47:33] well, that would suck [17:47:44] bgerstle: yeah… will know soon [17:48:02] bgerstle: yeah - it was a version thing… need to update the server [17:48:12] coreyfloyd: ok. either way i think my patch will fix the destination issue [17:48:13] bgerstle: ah cool. just trying to split that js statement on to multiple lines and pesky jshint is saying "oh no you don't" [17:48:14] 10Gather, 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1192033 (10JKatzWMF) [17:48:24] mhurd hrm, what's the error? [17:48:36] i forget, it might not actually be possible to have multi-line || statements in JS [17:48:43] jdlrobson: joakino is that the case? ^ [17:48:47] bgerstle: "Bad line breaking" bla bla bla [17:49:01] yeah, i must've forgotten you can't do that in JS. [17:49:15] bgerstle: link? [17:49:30] bgerstle: ^ Bad line breaking before '||' [17:49:34] is the exact msg [17:49:41] joakino: https://gerrit.wikimedia.org/r/#/c/203887/2/www/js/transforms.js,cm [17:50:05] mhurd joakino yeah, i think JS doesn't support that, come to think of it. gotta love significant whitespace ;-) [17:50:21] bgerstle: joakino :( [17:50:21] bgerstle: it does, but jshint complains depending on where you put the || [17:50:38] joakino: ah i'll try a couple things... [17:51:31] joakino: you're right - if i have trailing "||" it seems to not complain... [17:51:38] 6Mobile-Web: On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1209865 (10JKatzWMF) 3NEW [17:51:38] etonkovidova: sorry... My computer just crashed out of nowhere [17:51:52] lol [17:51:53] i had leading "||" [17:52:03] I have a meeting at 11:00 :) [17:52:28] 6Mobile-Web: Promote alpha header to beta - https://phabricator.wikimedia.org/T96173#1209873 (10JKatzWMF) 3NEW [17:52:43] etonkovidova: ok, my computer is coming back up now. You can ping me afterwards [17:52:54] joakino: thx for the tip! [17:53:00] mhurd: bgerstle: javascript supports whatever http://jsbin.com/novexapiga/1/edit?js,output but jshint is pickier :) [17:53:21] joakino: ya i thought it did [17:53:34] joakino: lalala I can't hear you its javascript's fault [17:53:41] hahaha [17:53:46] xD [17:54:14] Mhurd we could update our jshintrc, up to you. That might break other stuff that uses || [17:55:08] bgerstle: no strong preference [17:56:06] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1209913 (10bearND) @Vibhabamba What do you think? [17:57:14] 6Mobile-Web, 3Mobile-Web-Design: Update all PNG icons in MobileFrontend with SVGs - https://phabricator.wikimedia.org/T95224#1209924 (10JKatzWMF) a:3KHammerstein [17:58:01] bgerstle: mhurd: it is actually this one http://jshint.com/docs/options/#laxbreak [17:58:13] which is deprecated because it is style and not linting [17:58:31] wohoo freedom \o/ [18:01:04] bearND: time for batcave? quick question [18:01:41] mhurd done w/ helping elena if you need to talk. sounds like you've got it figured out [18:01:50] was going to break for lunch unless you need me [18:02:03] phuedx: Your wikigrok bot change looks good, although you might want to change the ‘wikidata’ variable to be ‘wikigrok’ instead. [18:02:10] bgerstle: grab lunch and i'll have the patch ready by the time you get back [18:02:22] 👍🏻 [18:02:45] bgerstle: good point about table[i] and dereferencing btw [18:02:47] 6Mobile-Web: Panel shouldn't automatically get added to the DOM - https://phabricator.wikimedia.org/T96176#1209934 (10Jdlrobson) 3NEW [18:02:59] (03PS1) 10Jdlrobson: Hygiene: Panels should not automatically be appended to DOM [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) [18:04:27] 10Gather, 3Gather Sprint Forward: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1209945 (10Jdlrobson) [18:04:28] 6Mobile-Web, 5Patch-For-Review: Panel shouldn't automatically get added to the DOM - https://phabricator.wikimedia.org/T96176#1209946 (10Jdlrobson) [18:04:33] .... [18:04:36] kaldari: ^ [18:04:40] yeah, i might want to do that ;) [18:05:27] (03PS5) 10Mhurd: Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 [18:05:37] (03PS6) 10Mhurd: Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 [18:07:01] JonKatz: i forgot to ask: do you still want to do story prioritization given that's half of what we just did? [18:07:03] (03PS7) 10Mhurd: Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 [18:07:13] (03PS8) 10Mhurd: Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 [18:08:13] phuedx good point...I think we're fine here and can sort out with KL later this week, unless you want to do rough estimates. [18:08:57] phuedx the main point is to idenitfy areas where we need more design/clarification. I think we have: its promoting header (design) [18:09:09] JonKatz: agreed [18:09:18] i'd prefer later in the week if that's alright with you [18:09:20] phuedx do you feel like you have a good handle on what is needed for the speed work? [18:09:34] phuedx lets push it then. [18:09:43] JonKatz: yeah -- i've updated the last card in the epic and given a provisional estimate [18:09:51] 3 -> 2 [18:09:58] phuedx muy bueno [18:10:12] JonKatz: i'd appreciate not having the meeting as it's 9-10pm ;) [18:10:18] if you think we need to then that's fine [18:10:25] but yeah, i'd like an evening :P [18:10:37] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Panels should not automatically be appended to DOM [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) (owner: 10Jdlrobson) [18:10:49] phuedx please spend time with your family :) I'll boot the meeting. [18:10:55]  \o/ [18:10:56] <3 [18:11:41] JonKatz: where should i send the chocolates/whiskey? [18:12:17] phuedx: if he doesn't want to i'll give you my address xD [18:12:21] (03PS2) 10Fjalapeno: Fix unit tests - 8.3 is now the current version of the SDK [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204297 [18:12:22] phuedx haha we can deduct it from my late jar fees [18:12:26] mhurd: i'm in the batcave now [18:12:34] bearND: ah one sec [18:12:47] yeah i owe like $20 [18:13:06] late jar fees went on beer and whiskey last time we were in sf [18:13:31] bearND: i don't see you... [18:13:31] i feel a repeat might be in order [18:13:37] mhurd: oops, forgot to click join [18:13:39] 6Mobile-Web: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1209958 (10phuedx) [18:15:04] dr0ptp4kt bgerstle mhurd ^ fix is ready - found a couple issues due to the breakneck pace of development on fastlane [18:15:43] 6Mobile-Web: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1209967 (10phuedx) Ping @Jdlrobson. What's going on with this card? Do you think that investigating alternative implementations might be worthwhile? Are you still unhappy with browser vendor's attitudes towa... [18:17:36] 6Mobile-Web, 10MobileFrontend, 10Browser-Tests, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: Should be possible in browser tests to use images with meta data or without meta data - https://phabricator.wikimedia.org/T67274#1209973 (10phuedx) Should this task be closed? @Jdlrobson: At the very le... [18:21:44] 6Mobile-Web, 10MobileFrontend, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Email confirmation workflow doesn't work correctly from a Mobile device - https://phabricator.wikimedia.org/T95065#1209982 (10phuedx) [18:22:05] 6Mobile-Web, 10MobileFrontend, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Email confirmation workflow doesn't work correctly from a Mobile device - https://phabricator.wikimedia.org/T95065#1179535 (10phuedx) @kaldari: It looks like @Florian is working on a related task: T95903 [18:26:11] 6Mobile-Web, 10MobileFrontend, 10Browser-Tests, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: Should be possible in browser tests to use images with meta data or without meta data - https://phabricator.wikimedia.org/T67274#1210005 (10Jdlrobson) It sounds like this is no longer needed by anyone so... [18:36:24] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1210065 (10Mhurd) [18:36:56] (03PS1) 10Mholloway: Display server status code & message to user in case of error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) [18:37:34] (03PS1) 10Mhurd: Removed comma from collapsed table chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204309 [18:37:48] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1210052 (10Mhurd) https://gerrit.wikimedia.org/r/204309 [18:38:04] (03PS2) 10Mhurd: Removed comma from collapsed table chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204309 [18:40:07] bearND: https://phabricator.wikimedia.org/T96179 [18:40:10] (03CR) 10jenkins-bot: [V: 04-1] Display server status code & message to user in case of error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway) [18:40:37] mhurd: thanks. Has vibha approved? [18:41:18] bearND: i chatted with adam and dan about the comma. dan agreed we could remove it now if we want and revert later if vibha objects [18:41:48] mhurd: ok, i'll add the Android project to it then, so we don't forget [18:42:04] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1210076 (10bearND) [18:43:21] mholloway: Would you be interested to get your feet wet in some JS code? See mhurd's Pha ticket ^ [18:43:25] Phab [18:44:04] bearND: Sure - the one immediately above your message? [18:44:32] bearND: btw, where can I find the reason for a maven-checkstyle failure? [18:45:24] coreyfloyd: bgerstle did a quick patch removing a comma... https://phabricator.wikimedia.org/T96179 [18:45:41] bearND: I suspect I know why in this case but it would be good to confirm [18:46:30] mholloway: yes, the one right above my previous post [18:47:25] mholloway: click on the link next to FAILURE. This will bring you to a Jenkins page [18:48:10] bearND: Yep, I'm there [18:48:12] mholloway: Then on the left you'll see "Checkstyle Warnings". Click on that. And then on Details on the following page [18:48:44] Ahh -- I ignored the left-hand menu and went straight for the logs :-) Thanks. [18:48:56] And my suspicions were indeed correct. [18:49:55] mholloway: the checkstyle task is only for the Java code. The "tox-flake8" task is for the Python scripts. [18:51:16] mholloway: if the commit has any JS changes it would also have a jshint task, BTW [18:51:40] mholloway: example: https://gerrit.wikimedia.org/r/#/c/202620/ [18:52:40] Just found out my internet is broken again :-( [18:56:53] aand it's back [18:58:05] bearND: so for mhurd's patch, just need the same changes on our side? [19:02:00] remote talk starting [19:02:15] bearND: is it only me or the new alpha release always takes you to the end of the article? [19:05:22] joakino did they send a link? [19:05:37] bgerstle: y check email in 'all' [19:05:46] mhurd: dr0ptp4kt bgerstle can i get some love here so I can get the build to elena? [19:05:47] bgerstle: can't post it here [19:05:48] https://gerrit.wikimedia.org/r/#/c/204297/ [19:06:25] coreyfloyd: no love for you [19:08:50] (03CR) 10Bgerstle: [C: 031] Fix unit tests - 8.3 is now the current version of the SDK (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204297 (owner: 10Fjalapeno) [19:09:46] but i need love… :( [19:15:16] coreyfloyd: are you amending? [19:15:41] coreyfloyd: conferences don't need love [19:15:47] (03CR) 10Bgerstle: [C: 031] Removed comma from collapsed table chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204309 (owner: 10Mhurd) [19:17:11] vibha: https://phabricator.wikimedia.org/T96179 [19:17:44] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1210169 (10Vibhabamba) Of course this is better! [19:18:09] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1210170 (10Vibhabamba) Double punctuation is strange. This is an improvement. Thanks @mhurd [19:18:18] mhurd: commented [19:18:30] vibha: thanks! [19:18:42] bearND: ^ [19:20:12] dr0ptp4kt: saw your comment on the search schema ticket... what's going on w/ a spike? [19:20:42] 10Wikipedia-Android-App: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1210179 (10Deskana) I wonder if this issue is related to this code: https://github.com/wikimedia/apps-android-wikipedia/blob/master/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSe... [19:25:08] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Implement Schema:MobileWikiAppSearch - https://phabricator.wikimedia.org/T90257#1210184 (10BGerstle-WMF) @Deskana @dr0ptp4kt can we get some more specific requirements for what messages you want for which user events? [19:25:25] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.1.1(76) - clicking links in offline mode saved them in Recent - https://phabricator.wikimedia.org/T95585#1210186 (10BGerstle-WMF) a:3BGerstle-WMF [19:29:25] 6Mobile-Web, 6Collaboration-Team, 10VisualEditor, 10VisualEditor-EditingTools, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1210199 (10matmarex) (By the way, what is the use case for settings which are not saved in MediaWiki user preferences, other tha... [19:31:57] mhurd: already did [19:32:12] and everyone needs love [19:33:33] (03CR) 10Bgerstle: [C: 031] Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 (owner: 10Mhurd) [19:35:20] 6Mobile-Web, 10MobileFrontend, 10VisualEditor, 10VisualEditor-MediaWiki, and 2 others: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1210210 (10Jdforrester-WMF) [19:35:20] coreyfloyd: oh just to double-check, i was talking about amending based on the comments brian left for https://gerrit.wikimedia.org/r/#/c/204297/ [19:35:27] coreyfloyd: did you see my comments on the test fix? [19:36:53] mhurd: bgerstle +1 so it didn’t look like any blockers… [19:37:02] coreyfloyd: k [19:37:13] (03CR) 10Mhurd: [C: 032] Fix unit tests - 8.3 is now the current version of the SDK [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204297 (owner: 10Fjalapeno) [19:38:37] coreyfloyd: if you have a minute my 2 patches are pretty straightforward [19:39:32] bgerstle: yeah saw them - didn’t get around to commenting yet - most are stylistic things… the only thing that seemed important was the simulator thing… we can do that if it works… but honestly, the idea i had was running the tests multiple times on specified OSs to make sure that tests pass across the all supported versions of iOS [19:40:01] mhurd: ya [19:40:19] bgerstle: the only reason i wasn’t doing it now, is i needed the path i submitted to fastlane [19:40:45] coreyfloyd: k, i did +1, just wanted to throw it out there [19:41:14] bgerstle: do you think we should run it on multiple OSes? [19:43:41] coreyfloyd: eventually, yes [19:44:13] i was thinking we would eventually run functional tests on mulitple OSes in parallel [19:44:23] hadn't really thought about running unit tests on multiple OSes [19:44:30] we could, but they should be quick to run [19:51:27] Deskana: etonkovidova hey, i'm picking up the offline/recent/saved bug [19:52:06] to be clear, the problem is that we're storing articles in recent/saved even if they fail to load? [19:52:42] Deskana: etonkovidova there aren't any expected/actual results defined in the bug [19:54:01] bgerstle: hmm... actually what should be done - not too sure... [19:54:52] bgerstle: but it feels alarming from the user's point of view: as a user I did not visit or save those articles, and yet they got stored [19:55:13] etonkovidova: to be clear, the problem is that the article fails to load, right? [19:55:23] so you're "on the article page," but nothing's showing? [19:55:38] (no screenshots) [19:56:03] bgerstle: the problem is: I am in offline mode - clicking on links in my saved articles - my clicks are stored in Recent [19:56:27] but what happens when you actually click a link in saved? (i'm about to run the app on my device to find out) [19:56:36] also, you *tried* to visit the article [19:57:06] are we saying we should distinguish between how the app behaves for specific error conditions? [19:57:20] e.g. "no internet connection" vs. "timeout" vs. "service unavailable" [19:57:27] bgerstle: when I click in offline mode - nothing happens; after I switch to online - my stored requests get processed [19:57:40] ahhh [19:57:41] that's interesting [19:57:43] bgerstle: so to say :( [19:57:58] bgerstle: right - so it's pure usablity issue [19:58:26] and unexpected behavior [19:58:38] if nothing actually happened, then it shouldn't save [19:58:44] but i figured the app would have tried to load it [19:58:56] i guess we check reachability and short-circuit link clicks? [20:00:23] bgerstle: could be, yeah [20:00:56] bgerstle: coreyfloyd hat tip. [20:01:57] jdlrobson: o/' [20:02:56] jdlrobson: np - thanks for bringing it up - yeah - we have a lot of work to do on our end before we catch up to your guys - and we need to make sure we do things that make wikipedia better, not any one platform. [20:03:21] jdlrobson: yeah, seriously, we should be tipping our hats to you [20:04:12] (03PS2) 10Mholloway: Display server status code & message to user in case of error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) [20:04:28] bgerstle: yo got time to help me in dependency hell? [20:04:29] jdlrobson: http://4.bp.blogspot.com/-9QjARWd5a84/T3OXHJJbe1I/AAAAAAAAA34/OVtLNvwpMvI/s190/nod-of-approval.gif [20:04:36] coreyfloyd: yeah [20:04:44] i'm in the "We're all remoties" hangout though [20:04:50] k [20:04:51] so will need to be limited to text messaging [20:05:03] bgerstle: coreyfloyd i think the middle ground is acceptable [20:06:04] jdlrobson: we should make a list of companies that have ideas we like [20:06:20] jdlrobson: when it comes to web and mobile integration - and steal some ideas [20:07:40] 10Wikipedia-Android-App: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1210301 (10Bene) It's rather related to this code I guess: https://github.com/wikimedia/apps-android-wikipedia/blob/8e6a483085490424f936e0b2347e600f7ffe0a82/wikipedia/src/main/java/org/wiki... [20:08:43] sorry coreyfloyd got disconnected [20:09:01] what i've been hearing about though is getting more app downloads [20:09:54] Vibha's email (subject: Download numbers for Wikipedia and other Android apps) [20:10:01] jdlrobson: yeah - i know people are concerned with that, but in my optioning we should worry about making the app better first [20:10:07] coreyfloyd: +1000 [20:10:13] the downloads will come when it is worthwhile to download [20:10:17] as i said i think we need to complement each other [20:10:31] e.g. if we have upload workflow - inform people there is a more complete upload workflow on apps [20:10:40] and in the app let someone know they can edit in VE [20:10:46] where we know VE is better [20:11:02] yeah - I’ve used seem good websites, app combinations that have good linking back and forth… [20:11:04] e.g. a strategy that plays to the strengths [20:11:17] right - i wouldn’t mind punting on editing in the mobile apps all together [20:11:17] but equally we should be looking to minimise those strengths and having a friendly healthy competition between web and apps [20:11:24] coreyfloyd: not a bad idea [20:11:42] we would have to reimplement sooooooooo much to get where VE is going [20:12:14] jdlrobson: don’t worry we use mobile web as trash talk fodder [20:14:01] (03CR) 10Raimond Spekking: "i18n review" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204246 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [20:14:56] 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1210306 (10Jdlrobson) [20:15:14] (03CR) 10Jdlrobson: Add meta tags for when sharing /by/User (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204246 (https://phabricator.wikimedia.org/T95239) (owner: 10Jhernandez) [20:16:52] 10Wikipedia-Android-App: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1210308 (10Bene) Possibly helpful links: * http://techiepulkit.blogspot.de/2014/02/android-overriding-default-contextual.html * http://stackoverflow.com/questions/15370047/overriding-the-d... [20:18:07] (03CR) 10Fjalapeno: [C: 031] Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 (owner: 10Mhurd) [20:18:11] (03CR) 10Fjalapeno: [C: 032] Prevent adding table collapsing chrome around "mbox-small" tables. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/203887 (owner: 10Mhurd) [20:18:45] (03CR) 10Fjalapeno: [C: 031] Removed comma from collapsed table chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204309 (owner: 10Mhurd) [20:18:48] (03CR) 10Fjalapeno: [C: 032] Removed comma from collapsed table chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204309 (owner: 10Mhurd) [20:24:47] (03PS1) 10Jdlrobson: New collection opens collection editor interface [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204332 (https://phabricator.wikimedia.org/T94803) [20:26:30] etonkovidova: sorry trying to bet the build server working with bgerstle - lots of sdks changes, and build tool changes [20:27:41] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Toast should clip long collection titles - https://phabricator.wikimedia.org/T93797#1210318 (10Jdlrobson) I think @JHernandez is right. Now limited to 90 characters. This is not so bad. JK can you sign off on this or do you think we still need to do someth... [20:27:57] (03Abandoned) 10Jdlrobson: Truncate collection titles in toast [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203884 (https://phabricator.wikimedia.org/T93797) (owner: 10Jdlrobson) [20:29:00] 6Mobile-Web, 6Collaboration-Team, 10VisualEditor, 10VisualEditor-EditingTools, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1210324 (10TheDJ) @matmarex, i can think of two things: * session specific settings (so sessionStorage over session cookies) * U... [20:31:06] jdlrobson and coreyfloyd the download numbers was a communications conversation about what channels/ languages we want to create awareness in The email i sent out was purely there is some perepective on usage around utility/messaging/news apps [20:32:16] argh, cant type [20:32:56] That email (subject: Download numbers for Wikipedia and other Android apps) was purely to create perspective. [20:33:13] We want to be an app that people use for looking information up [20:35:10] 10 million sounds like a large number until you learn that daily lookup/messaging/news apps have orders of users more. [20:35:36] For us, understanding the breakdown by language and country also helps, because we may want to create awareness in those channels. [20:36:04] In any case, daily/monthly actives is a better metric than total installs. [20:36:47] In general I agree with coreyfloyd, but I would also say that we need a more hollistic communications strategy from examining our usage breakdowns. [20:39:23] vibha: not sure if i saw the email, but sounds interesting [20:42:51] bgerstle: I think I know the email vibha's referring to, will forward it to you [20:43:31] i see it now, thanks. not sure why it didn't show up in subject search [20:50:16] vibha: yeah i didn’t see that email either… whats the subject? [20:50:32] I'll foward it to you guys [20:50:45] thnaks [20:51:00] vibha: also want to check in on the prototype - were you abel to instal? [20:56:54] (03CR) 10Jdlrobson: [C: 032] Add support for extensions to add custom login messages for mobile login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203893 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [20:57:31] 6Mobile-Web: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1210371 (10Jdlrobson) 3NEW [20:58:09] 6Mobile-Web: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1210383 (10Jdlrobson) [20:58:11] 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#1210382 (10Jdlrobson) [20:59:41] 6Mobile-Web: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1210371 (10Jdlrobson) [21:00:16] (03Merged) 10jenkins-bot: Add support for extensions to add custom login messages for mobile login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203893 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [21:00:42] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.Dialog - https://phabricator.wikimedia.org/T88559#1014685 (10Jdlrobson) [21:00:44] 6Mobile-Web: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1210394 (10Jdlrobson) [21:01:00] vibha: coreyfloyd it was actually from a while ago. i remember now because i agree MAU/DAU > downloads [21:01:16] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Rewrite VisualEditorOverlay header using oojs ui. - https://phabricator.wikimedia.org/T96187#1210396 (10Jdlrobson) 3NEW [21:01:26] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1210402 (10Jdlrobson) [21:02:51] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Rewrite the edit summary screen of VisualEditorOverlay in oojs ui - https://phabricator.wikimedia.org/T96188#1210403 (10Jdlrobson) 3NEW [21:03:17] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Rewrite VisualEditorOverlay header using oojs ui. - https://phabricator.wikimedia.org/T96187#1210409 (10Jdlrobson) [21:05:08] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1210411 (10Jdlrobson) [21:05:38] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1014685 (10Jdlrobson) [21:06:02] 6Mobile-Web: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1210414 (10Jdlrobson) [21:07:07] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1014685 (10Jdlrobson) [21:07:09] 6Mobile-Web: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1210371 (10Jdlrobson) [21:07:19] 6Mobile-Web: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1210371 (10Jdlrobson) [21:07:45] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1210426 (10Jdlrobson) [21:07:47] 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#967012 (10Jdlrobson) [21:10:03] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1210430 (10Jdlrobson) [21:10:05] 6Mobile-Web: Merge OOJS UI and MobileFrontend View code - https://phabricator.wikimedia.org/T95952#1204634 (10Jdlrobson) [21:11:26] (03CR) 10Jdlrobson: [C: 032] Beta: Make banner image width match content width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [21:13:18] (03PS4) 10Jdlrobson: Login messages: Add support for MobileFrontend loginpage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203894 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [21:13:29] (03CR) 10Jdlrobson: [C: 032] Login messages: Add support for MobileFrontend loginpage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203894 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [21:14:42] (03PS7) 10Jdlrobson: Hygiene: Refactor JS code for hiding/showing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:14:49] (03CR) 10Jdlrobson: [C: 031] Hygiene: Refactor JS code for hiding/showing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:15:05] (03Merged) 10jenkins-bot: Beta: Make banner image width match content width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202757 (https://phabricator.wikimedia.org/T91743) (owner: 10Phuedx) [21:17:04] (03Merged) 10jenkins-bot: Login messages: Add support for MobileFrontend loginpage [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203894 (https://phabricator.wikimedia.org/T95903) (owner: 10Florianschmidtwelzow) [21:18:33] (03PS1) 10Mholloway: Remove comma from collapsed table chrome (Android) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204339 (https://phabricator.wikimedia.org/T96179) [21:19:13] 10Wikipedia-iOS-App, 10MediaWiki-extensions-GeoData, 6Mobile-Apps: Geo coords still rounded if generator is used. - https://phabricator.wikimedia.org/T96189#1210465 (10Mhurd) 3NEW [21:19:42] (03CR) 10Jdlrobson: [C: 032] Hygiene: Refactor JS code for hiding/showing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:21:42] (03CR) 10Yurik: Add route for Special:Gather/by/ (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204150 (https://phabricator.wikimedia.org/T95791) (owner: 10Jdlrobson) [21:22:00] MaxSem: hey max! i filed a ticket: https://phabricator.wikimedia.org/T96189 [21:22:09] jdlrobson ^^, it should not have been merged [21:22:16] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1210476 (10Mholloway) [21:22:32] yurik: so fix it? [21:22:39] 10Wikipedia-iOS-App, 10MediaWiki-extensions-GeoData, 6Mobile-Apps: Geo coords still rounded if generator is used. - https://phabricator.wikimedia.org/T96189#1210477 (10Mhurd) [21:22:52] (03Merged) 10jenkins-bot: Hygiene: Refactor JS code for hiding/showing collections [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204002 (owner: 10Ori.livneh) [21:23:09] jdlrobson, your patch uses regex, i suspect you have made an incorrect assumption there, and i don't know what you actually tried to check [21:24:11] 10Wikipedia-iOS-App, 10MediaWiki-extensions-GeoData, 6Mobile-Apps: Geo coords still rounded if generator is used. - https://phabricator.wikimedia.org/T96189#1210480 (10MaxSem) 5Open>3Invalid a:3MaxSem Nobody ever claimed it's fixed in prod. T89986 [21:24:31] mhurd, ^ [21:25:30] 10Wikipedia-iOS-App, 10MediaWiki-extensions-GeoData, 6Mobile-Apps: Geo coords still rounded if generator is used. - https://phabricator.wikimedia.org/T96189#1210537 (10Mhurd) Ah! I see! [21:26:37] 10Wikipedia-iOS-App, 10MediaWiki-extensions-GeoData, 6Mobile-Apps: Geo coords still rounded if generator is used. - https://phabricator.wikimedia.org/T96189#1210539 (10Mhurd) Was the "second issue" I mentioned known / confirmed? [21:26:42] (03PS2) 10Jdlrobson: Update Gather messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) [21:28:36] MaxSem: i see. was the "second issue" i mentioned in the card known? [21:29:09] MaxSem: apologies for not checking w you first. i thought the fix had went to prod [21:29:34] 6Mobile-Web, 7Technical-Debt, 7Tracking: Login form should support custom messages based on returnto and returntoquery parameters - https://phabricator.wikimedia.org/T96191#1210548 (10Jdlrobson) 3NEW a:3Jdlrobson [21:29:54] (03CR) 10Jdlrobson: Update Gather messages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [21:30:30] (03PS3) 10Jdlrobson: Update Gather messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) [21:32:13] 6Mobile-Web, 10Browser-Tests: Issue with Chrome driver with resizing window - https://phabricator.wikimedia.org/T88288#1210559 (10Jdlrobson) Is this still an issue @zeljkofilipin ? [21:33:29] 6Mobile-Web, 10MediaWiki-API: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - https://phabricator.wikimedia.org/T69054#1210570 (10Jdlrobson) @MaxSem why was https://gerrit.wikimedia.org/r/#/c/141842/1 abandoned? It seems this could be done conditionally e.g.... [21:35:27] 6Mobile-Web, 10MediaWiki-API: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - https://phabricator.wikimedia.org/T69054#1210578 (10MaxSem) Anomie's ApiResult should make the fixage possible more reasonably once it's merged. [21:37:17] 6Mobile-Web, 10MediaWiki-API: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - https://phabricator.wikimedia.org/T69054#1210581 (10Jdlrobson) @MaxSem could you add that as a blocking task? [21:38:53] (03CR) 10jenkins-bot: [V: 04-1] Update Gather messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [21:41:23] 6Mobile-Web, 10MediaWiki-API: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - https://phabricator.wikimedia.org/T69054#1210588 (10Anomie) >>! In T69054#1210570, @Jdlrobson wrote: > @MaxSem why was https://gerrit.wikimedia.org/r/#/c/141842/1 abandoned? It see... [21:41:42] 6Mobile-Web, 10MediaWiki-API: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - https://phabricator.wikimedia.org/T69054#1210589 (10MaxSem) It doesn't seem to have a dedicated task, just watch https://gerrit.wikimedia.org/r/#/c/182858/ [21:42:30] 6Mobile-Web, 10MediaWiki-API: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - https://phabricator.wikimedia.org/T69054#1210591 (10Anomie) [21:54:20] (03PS1) 10Kaldari: Adding documentation for 'exists' value for wgc_status field [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204388 [21:54:42] 6Mobile-Web, 10MediaWiki-ResourceLoader, 3Editing Department 2014/15 Q4 blockers: ResourceLoaderImageModule does no cache invalidation after icons change - https://phabricator.wikimedia.org/T94733#1210635 (10matmarex) 5Open>3Resolved [21:55:55] coreyfloyd: sorry for delay. things. bgerstle, you're talking about https://phabricator.wikimedia.org/T90518 , right? [21:56:30] ah, that was an old comment [21:56:31] didn't realize [21:57:03] 6Mobile-Web: mw.mobileFrontend should have a minimal amount of methods - https://phabricator.wikimedia.org/T86245#1210643 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Let's call this done for the time being. I'll raise some clearer bugs later. [21:57:10] (03PS1) 10Jdlrobson: Hygiene: Rename application.js to init.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204389 [21:57:11] bgerstle: word. in any event, https://phabricator.wikimedia.org/T90518 should be on group 0 servers now (mediawiki.org, for example). i'm going to check the el table [21:57:30] * bgerstle nods uncomprehendingly [21:57:35] * bgerstle if that's even a word [21:57:47] i'm gonna go check the frobnicators then [21:59:00] dr0ptp4kt: on second thought, i think i might actually be done for the day [21:59:05] i'll catch ya later [21:59:07] (03PS2) 10Jdlrobson: Hygiene: Rename application.js and talk.js to init.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204389 [21:59:15] was going to tackle the offline bug first anyway [22:00:02] bgerstle: k. tomorrow, tomorrow [22:02:15] (03PS3) 10Jdlrobson: Hygiene: Reorganise some files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204389 [22:03:10] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] Getting rid of own login page - https://phabricator.wikimedia.org/T74910#1210674 (10Florian) [22:03:12] 6Mobile-Web, 5Patch-For-Review: Should be possible for other extensions to register custom messages on MobileFrontend login and signup forms - https://phabricator.wikimedia.org/T95903#1210673 (10Florian) 5Open>3Resolved [22:05:26] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1210682 (10Jdlrobson) 3NEW [22:05:42] 3Gather Sprint Forward, 5Patch-For-Review: Adding/removing to watchlist when new user causes window to reopen - https://phabricator.wikimedia.org/T95744#1210690 (10Jdlrobson) Agreed. https://phabricator.wikimedia.org/T96196 [22:05:46] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1210691 (10Jdlrobson) a:3Jdlrobson [22:11:02] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1210699 (10Jdlrobson) a:5Jdlrobson>3None [22:13:13] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1210704 (10Jdlrobson) [22:13:47] (03PS1) 10Jdlrobson: Pass options by references to pre and postRender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204396 (https://phabricator.wikimedia.org/T96196) [22:15:01] (03PS2) 10Jdlrobson: Hygiene: Panels should not automatically be appended to DOM [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) [22:25:17] (03PS3) 10Jdlrobson: Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 [22:28:11] (03PS4) 10Jdlrobson: Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 [22:28:52] 6Mobile-Web, 10Analytics-EventLogging, 6Analytics-Kanban: Follow up with mobile team on instrumentation sampling rate (%50) - https://phabricator.wikimedia.org/T88363#1210774 (10Jdlrobson) What needs to happen here? [22:30:41] 6Mobile-Web, 10MobileFrontend: Examine discoverability and usability of search on low-JS devices - https://phabricator.wikimedia.org/T66926#1210777 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Still not clear on the action needed here so closing. Please reopen with clearer asks. [22:33:33] 6Mobile-Web: Log common JavaScript exceptions - https://phabricator.wikimedia.org/T77931#1210782 (10Jdlrobson) This is currently not actionable and I'd suggest closing it. Anyone got any ideas? I think EL would be a bad idea, really we need some kind of module dependency checker. [22:35:14] (03PS2) 10Kaldari: Hygiene: Make ResponseStore an interface [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201708 (owner: 10Phuedx) [22:35:53] (03CR) 10Kaldari: [C: 032] Hygiene: Make ResponseStore an interface [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201708 (owner: 10Phuedx) [22:38:11] (03CR) 10Kaldari: [C: 032] Add i18n messages for login signup [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203836 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [22:39:57] Hey Droids. I see a weird issue in the alpha and beta (but not prod) Android builds on a couple of devices. If I go to an article and scroll to the bottom, none of the links or collapsible info boxes take action when clicked. For instance, the article on Nathaniel Green Taylor exhibits this problem but I haven't found an article that doesn't yet. Is this a known issue? I can't find it in Phabricator [22:40:49] A weird thing is that the links actually highlight properly when tapped, they just don't do anything. [22:41:12] coreyfloyd: the alpha you sent me will over write any other alphas? [22:41:38] vibha: yeah- the next one i sent won’t though [22:42:43] Ok [22:43:47] bearND: any update on the prototype yet? [22:44:19] mhurd: dr0ptp4kt vibha gotta go get a haircut… bb in an hour - i’m still troubleshooting alpha build server issue - let elena know i will work more on it when i get back [22:44:42] coreyfloyd: only an hour? [22:44:44] ;) [22:45:02] coreyfloyd: have fun [22:45:29] (03Merged) 10jenkins-bot: Hygiene: Make ResponseStore an interface [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/201708 (owner: 10Phuedx) [22:45:31] (03Merged) 10jenkins-bot: Add i18n messages for login signup [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203836 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [22:45:41] mhurd: lol [22:49:32] (03CR) 10Kaldari: [C: 04-1] "We should be using a hook for actionMessageHeaders like we are for pageMessageHeaders. Also I really wish these files had better comments." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [22:57:15] (03CR) 10Kaldari: [C: 032] Border box no longer default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202760 (https://phabricator.wikimedia.org/T86366) (owner: 10Jdlrobson) [23:01:19] (03PS1) 10Jdlrobson: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) [23:01:21] (03PS1) 10Jdlrobson: Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 [23:01:34] (03CR) 10jenkins-bot: [V: 04-1] Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [23:01:41] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 (owner: 10Jdlrobson) [23:02:24] hey all. please excuse some more n00b questions. i'm trying to get a handle on some of the javascript components in the apps (particularly for android). i see there's a bundle.js present in both android and ios apps. if i make changes to one, should i be making the same changes to the other? the files have some similarities but are distinct. in general, is there much shared code between apps? [23:05:45] (03Merged) 10jenkins-bot: Border box no longer default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202760 (https://phabricator.wikimedia.org/T86366) (owner: 10Jdlrobson) [23:08:33] (03PS21) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [23:09:47] (03CR) 10Jdlrobson: "Agreed Kaldari. We need to stop using the login page period. Sam and I are talking about this and other technical debt. In the mean time I" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [23:17:01] Elena - can you look at galleries in the latest alpha [23:17:13] Going from [23:17:27] Going from one image to the next is very jerky [23:18:12] Can someone tell me what Elena's Irc handle is? [23:20:08] (03PS22) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [23:20:10] (03PS1) 10Jdlrobson: Fix icon on Special:Uploads page when you have no edits. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204413 [23:20:20] dr0ptp4kt: what is Elenas Irc handle? [23:20:34] etonkovidova: vibha ^ ohai ohai [23:21:02] etonkovidova: hi! [23:21:08] dr0ptp4kt: hello [23:21:25] etonkovidova: when you have a chance, can you please look at galleries on latest alpha? [23:21:44] Swiping right to the next image feels very jerky [23:21:53] (03PS2) 10Jdlrobson: Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 [23:21:55] (03PS2) 10Jdlrobson: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) [23:21:57] (03PS4) 10Jdlrobson: Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 [23:21:59] vibha: checking... [23:22:28] It looks fine in production and beta. Looks broken in current alpha. [23:22:36] vibha: just a heads up, coreyfloyd is taking a little break and will be on later doing some stuff related to alpha builds. i let etonkovidova know, but wanted to mention to you as well [23:23:13] We might still need to file this issue for galleries. [23:23:34] dr0ptp4kt: got it. ^ [23:25:01] vibha: hmm... I saw it on Ukraine article - only first time when I flip through Gallery [23:25:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 (owner: 10Jdlrobson) [23:25:27] vibha: usual suspects - Monet, Pissarro - go smoothly [23:25:46] 6Mobile-Web, 7Mobile: "Talk to foo" -button not fit for the lenght of the characters - https://phabricator.wikimedia.org/T95993#1210860 (10Jdlrobson) [23:25:48] 10Gather, 6Mobile-Web, 10MobileFrontend: userprofile.less styles not loaded on minerva (or the user profile) - https://phabricator.wikimedia.org/T96011#1210861 (10Jdlrobson) [23:25:53] vibha: but definitely something is there - which article you were checking? [23:26:03] etonkovidova: are you sure it's smooth on the Claude Monet article? [23:26:54] vibha; iPad mini is ok [23:26:55] Claude monet [23:26:57] Jellyfish [23:27:14] (03CR) 10jenkins-bot: [V: 04-1] Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [23:27:14] Jellyfish is very jerky [23:27:44] 6Mobile-Web, 10Continuous-Integration: Jenkins: Set up jsduck test and publish jobs for MobileFrontend - https://phabricator.wikimedia.org/T66374#698417 (10Jdlrobson) So this is done and https://phabricator.wikimedia.org/T74794 is no longer blocked? [23:28:17] vibha: checking Jellyfish [23:28:50] vibha: yes - Jellyfish is jerky.. [23:29:00] vibha: interesting [23:30:07] 6Mobile-Web: On iOS 8.3 iPhone 5c in Private mode Safari, sometimes dragging/flicking doesn't scroll in modals - https://phabricator.wikimedia.org/T95561#1210869 (10Jdlrobson) Fire bucket ticket..? Is this still an issue? We had some issues with scroll events that this sounds related to - see T93988 [23:31:04] 6Mobile-Web, 7Upstream: Crashing with new mobile Mozilla Firefox - https://phabricator.wikimedia.org/T89608#1210882 (10Jdlrobson) Is this T93988 ? @Thnidu can you tell me if this is still an issue? [23:32:10] 6Mobile-Web, 10Continuous-Integration: Jenkins: Set up jsduck test and publish jobs for MobileFrontend - https://phabricator.wikimedia.org/T66374#1210884 (10Krinkle) >>! In T66374#1210863, @Jdlrobson wrote: > So this is done and https://phabricator.wikimedia.org/T74794 is no longer blocked? Indeed. Submit a p... [23:32:54] etonkovidova: can you please file a ticket and maybe add a video for jellyfish gallery [23:33:03] Showing how it looks jerky? [23:33:04] 6Mobile-Web, 10MobileFrontend: Fix style of Special:MobileDiff on desktop site - https://phabricator.wikimedia.org/T95828#1210887 (10Jdlrobson) Can you add a screenshot? It looks fine to me... [23:33:17] 6Mobile-Web, 10MobileFrontend: Fix style of Special:MobileDiff on desktop site - https://phabricator.wikimedia.org/T95828#1210888 (10Jdlrobson) a:3Tbayer [23:35:36] 6Mobile-Web, 10Continuous-Integration: Jenkins: Set up jsduck test and publish jobs for MobileFrontend - https://phabricator.wikimedia.org/T66374#1210898 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Okay we have https://gerrit.wikimedia.org/r/181693 open I guess we need to re-examine that now. [23:35:39] 6Mobile-Web, 10Continuous-Integration, 5Patch-For-Review, 7Technical-Debt: Publish MobileFrontend JS Documentation - https://phabricator.wikimedia.org/T74794#1210901 (10Jdlrobson) [23:36:15] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1210906 (10JKatzWMF) 2 quick notes 1. Can we drill down on politicians? The subcategories seem good here. 2. I didn't include... [23:37:45] 3Gather Sprint Forward, 5Patch-For-Review: string replacement for watchstar login page - https://phabricator.wikimedia.org/T95729#1198811 (10Jdlrobson) @Kaldari doesn't like https://gerrit.wikimedia.org/r/#/c/203835/ Let's find a way to move this forward and not be bogged down by our tech debt... [23:39:28] (03PS3) 10Jdlrobson: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) [23:39:54] vibha: I'll file a ticket [23:40:43] etonkovidova: danke! [23:41:06] (03PS4) 10Jdlrobson: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) [23:41:08] Really helpful [23:45:06] (03CR) 10jenkins-bot: [V: 04-1] Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [23:52:31] vibha: sorry about the late response. I wanted to check some more about implementing the swipe up/down gestures. If I don't get it soon, you'll get an update of prototpye 1 without it. [23:52:35] tomorrow [23:57:35] 10Wikipedia-iOS-App: [Regression 4.1.1(79)] Image Gallery - flipping through images is not smooth when images are viewed for the first time - https://phabricator.wikimedia.org/T96201#1210941 (10Etonkovidova) 3NEW [23:58:46] 10Wikipedia-iOS-App: [Regression 4.1.1(79)] Image Gallery - flipping through images is not smooth when images are viewed for the first time - https://phabricator.wikimedia.org/T96201#1210948 (10Etonkovidova)