[00:08:58] dr0ptp4kt: mhurd vibha back [00:09:13] yo. coreyfloyd i actually gotta wrap up [00:09:20] the current alpha is not up to date - need to fix the build server - working on it now [00:09:27] vibha^ [00:09:32] coreyfloyd: k [00:09:53] dr0ptp4kt: ok - you need anything? [00:09:54] (03PS5) 10Jdlrobson: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) [00:09:56] (03PS1) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [00:10:09] coreyfloyd: nah [00:10:16] dr0ptp4kt: ill be working late again - got feedback from vibha and need to get the server fixed [00:10:46] (03PS6) 10Jdlrobson: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) [00:10:55] (03PS2) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [00:11:19] 6Mobile-Web: Rewrite MobileFrontend frontend code in OOJS UI - https://phabricator.wikimedia.org/T96202#1210964 (10Jdlrobson) 3NEW [00:13:35] 6Mobile-Web, 5Patch-For-Review: Create Anchor abstraction - https://phabricator.wikimedia.org/T87253#1210973 (10Jdlrobson) [00:13:37] 6Mobile-Web: Rewrite MobileFrontend frontend code in OOJS UI - https://phabricator.wikimedia.org/T96202#1210972 (10Jdlrobson) [00:13:39] 6Mobile-Web: Create input abstraction - https://phabricator.wikimedia.org/T87255#1210976 (10Jdlrobson) [00:13:42] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Rewrite the edit summary screen of VisualEditorOverlay in oojs ui - https://phabricator.wikimedia.org/T96188#1210974 (10Jdlrobson) [00:13:44] 6Mobile-Web, 5Patch-For-Review: Create button abstraction - https://phabricator.wikimedia.org/T87254#1210975 (10Jdlrobson) [00:14:40] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] MobileFrontend should use mw-ui-icon - https://phabricator.wikimedia.org/T73181#1210978 (10Jdlrobson) [00:14:42] 6Mobile-Web: Rewrite MobileFrontend frontend code in OOJS UI - https://phabricator.wikimedia.org/T96202#1210964 (10Jdlrobson) [00:14:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [00:17:00] 6Mobile-Web: Rewrite MobileFrontend frontend code in OOJS UI - https://phabricator.wikimedia.org/T96202#1210985 (10Jdlrobson) [00:17:02] 6Mobile-Web, 3Mobile-Web-Design: Update all PNG icons in MobileFrontend with SVGs - https://phabricator.wikimedia.org/T95224#1210986 (10Jdlrobson) [00:18:20] 6Mobile-Web: Rewrite MobileFrontend frontend code in OOJS UI - https://phabricator.wikimedia.org/T96202#1210964 (10Jdlrobson) [00:18:24] 6Mobile-Web, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia, 7Mobile, and 2 others: [Tracking] Consolidate code for MediaViewer across desktop and mobile - https://phabricator.wikimedia.org/T65504#1210991 (10Jdlrobson) [00:19:03] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] Consolidate Special:Uploads and Special:UploadWizard code - https://phabricator.wikimedia.org/T64638#682787 (10Jdlrobson) [00:19:05] 6Mobile-Web: Rewrite MobileFrontend frontend code in OOJS UI - https://phabricator.wikimedia.org/T96202#1210997 (10Jdlrobson) [00:21:05] 6Mobile-Web, 10MobileFrontend-Feature-requests: Perhaps parse Mobile-frontend-generic-login‎ further to avoid raw HTML in login form - https://phabricator.wikimedia.org/T91636#1210998 (10Jdlrobson) [00:22:03] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] Getting rid of own login page - https://phabricator.wikimedia.org/T74910#1211001 (10Jdlrobson) [00:24:29] 6Mobile-Web: Rewrite MobileFrontend frontend code in OOJS UI - https://phabricator.wikimedia.org/T96202#1211010 (10Jdlrobson) [00:24:32] 6Mobile-Web, 10MediaWiki-extensions-GeoData, 7Technical-Debt, 7Tracking: [Tracking] Move Nearby code to Geodata extension - https://phabricator.wikimedia.org/T66316#691119 (10Jdlrobson) [00:32:19] 6Mobile-Web, 10MobileFrontend: Make MobileFrontend add a mobile rel=alternative to the desktop version instead of noindexing mobile pages - https://phabricator.wikimedia.org/T91183#1211102 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson This is working. If you want to enable it you'll need to flip the switch... [00:34:50] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (13 instances reported) SearchResultsController tableView:didSelectRowAtIndexPath - https://phabricator.wikimedia.org/T96204#1211112 (10dr0ptp4kt) [00:35:01] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (10 instances reported) MWKDataObject requiredNumber:dict - https://phabricator.wikimedia.org/T96205#1211113 (10dr0ptp4kt) [00:35:13] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (6 instances reported) MWKDataObject optionalNumber:dict - https://phabricator.wikimedia.org/T96203#1211115 (10dr0ptp4kt) [00:35:23] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (3 instances reported) MWKImageInfoFetcher fetchInfoForArticle - https://phabricator.wikimedia.org/T96206#1211116 (10dr0ptp4kt) [00:35:35] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (1 instance reported) MWKDataStore saveFile:atPath:byPerforming - https://phabricator.wikimedia.org/T96211#1211117 (10dr0ptp4kt) [00:35:49] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (1 instance reported) _os_lock_corruption_abort - https://phabricator.wikimedia.org/T96210#1211118 (10dr0ptp4kt) [00:35:59] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (1 instance reported) TabularScrollView viewTapped - https://phabricator.wikimedia.org/T96209#1211119 (10dr0ptp4kt) [00:36:09] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (1 instance reported) CA::AttrList::set(unsigned int, _CAValueType, void const*) - https://phabricator.wikimedia.org/T96208#1211121 (10dr0ptp4kt) [00:36:26] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (1 instance reported) main - https://phabricator.wikimedia.org/T96207#1211123 (10dr0ptp4kt) [01:08:36] 6Mobile-Web, 10MediaWiki-API: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - https://phabricator.wikimedia.org/T69054#1211164 (10Jdforrester-WMF) [01:13:26] https://twitter.com/asquare097/status/588497619468607488 << Fair usage image...Usign the share-a-fact function in mobile. Is there a bug/task/thing for this yet? [01:13:38] using* [01:16:13] Josve05a: That depends what "this" is. :-) [01:16:34] Josve05a: What is the problem you're reporting? That there is a copyright issue? [01:22:41] Deskana: yes. Might be technically allowed, but, yeah [01:23:29] Josve05a: More than "technically allowed". The feature has had full appraisal from WMF Legal at all stages of the development process and has full signoff. [01:23:49] Josve05a: There is this: https://phabricator.wikimedia.org/T95379 [01:23:56] Josve05a: But it is not something we're actively working on. [01:24:57] I'll look in to the things tomorrow.just choked we're spreading fair use online, but can't use the on more than 1 articles onwiki per our policies... [01:25:06] Chocked* [01:25:51] And adding a cc-by-as tag on the images, without attributing the images AT ALL [01:28:25] Josve05a: It is not easy, indeed. That said, I'm really excited that tons of people are sharing our content and spreading knowledge. That's our mission. :-) [01:29:39] Yeah, later to find out photographers suing them for spreading images not compatible with ccbysa under that license, per the tags on the cards... [01:31:12] Josve05a: Like I said, that is not an issue. I've been in close contact with WMF Legal, and there are no legal problems with our current implementation. [01:32:17] Josve05a: We don't push out features like this without getting extensive legal review. [01:32:42] I love the idea, but not the usage of fair use image, nor not credit the image at all... :/ Price to pay or something I guess (might not be a direct problem for us, but we should always think of our reusers...well-well... [01:33:43] Josve05a: Indeed, we should push towards getting these to be truly freely available cards. [01:34:01] Josve05a: But remember, you and I are in the tiny, tiny minority of people that actually know what this means. [01:34:06] Josve05a: Most people just want to share stuff. [01:35:21] Josve05a: We prioritised that. That means getting it out early so the majority of the user base can use and enjoy it, while we improve it for the minority of the user base. [01:36:10] yeah, and if someone vandalises a page, the using the card unction with a fair use image...trademark tarnishment..etc. :/ yeah..I'll drop it [01:36:23] Josve05a: Like I said, all things that WMF Legal considered. [01:37:04] Josve05a: If we never did anything for fear of vandalism or abuse, we'd never do anything. Wikipedia itself included! [01:38:08] true, but then wikimedia would get the blame, now the retweeters will or something...yeah...I'm tired. 03:37 am [01:41:35] Josve05a: That's not my understanding of the legal situation at all. Perhaps you should speak to WMF Legal if you think there's some legal issue they missed. [01:44:20] And, now, I have to go too. Home time! Thanks. :-) [01:44:22] Nah, I'm "small" and will see this play out. [01:44:43] Have a good time off-wiki/IRC :) [01:47:48] (03PS1) 10Mhurd: WIP - do not merge. See notes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [01:55:50] (03PS2) 10Mhurd: WIP - do not merge. See notes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [01:56:15] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1211263 (10Mhurd) https://gerrit.wikimedia.org/r/#/c/204433/ [02:00:07] coreyfloyd: bgerstle_afk ^ still a work in progress, but functional [02:00:32] mhurd: cool [02:02:07] coreyfloyd: i should prob put the individual transform files into a "transform" folder and remove "transform-" prefix from the file names... [02:02:30] coreyfloyd: gonna call it a night for now though [02:03:06] mhurd: you know better than me how to organize that web stuff! Enjoy the night [02:03:31] coreyfloyd: thx you too! [02:04:00] (03CR) 10Mhurd: "Comment from irc so I don't forget:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd) [02:24:54] 6Mobile-Web, 10MediaWiki-ResourceLoader, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): ResourceLoaderImageModule does no cache invalidation after icons change - https://phabricator.wikimedia.org/T94733#1171375 (10Jdforrester-WMF) [03:09:40] 6Mobile-Web, 7Upstream: Crashing with new mobile Mozilla Firefox - https://phabricator.wikimedia.org/T89608#1211348 (10Thnidu) No, I haven't had this problem lately. [03:39:41] Krenair: What's your useragent? [03:40:07] my useragent? on my phone? [03:40:53] no, on the browser you user when trying to reproduce T95135. [03:41:15] I'm compiling a list of confirmed/non confirmed brwosers affected [03:42:40] sorry, wrong channel, but... [04:33:17] 10Gather: Public collection feed filtered for quality - https://phabricator.wikimedia.org/T96222#1211394 (10JKatzWMF) 3NEW [04:34:05] 10Gather: Public collection feed filtered for quality - https://phabricator.wikimedia.org/T96222#1211402 (10JKatzWMF) Similar to: https://phabricator.wikimedia.org/T94272 [04:34:33] 10Gather: Public collection feed filtered for quality - https://phabricator.wikimedia.org/T96222#1211404 (10JKatzWMF) [04:35:03] 10Gather: Public collection feed filtered for quality - https://phabricator.wikimedia.org/T96222#1211394 (10JKatzWMF) [04:35:14] 10Gather: Public collection feed filtered for quality - https://phabricator.wikimedia.org/T96222#1211394 (10JKatzWMF) [04:35:25] 10Gather: Public collection feed filtered for quality - https://phabricator.wikimedia.org/T96222#1211394 (10JKatzWMF) [04:36:03] 10Gather: Public collection feed filtered for quality - https://phabricator.wikimedia.org/T96222#1211394 (10JKatzWMF) [04:36:05] 10Gather: Should be possible to see the most recent updated collections - https://phabricator.wikimedia.org/T94272#1211410 (10JKatzWMF) [04:40:04] 10Gather: A user can follow a collection - https://phabricator.wikimedia.org/T94243#1211417 (10JKatzWMF) [04:41:11] 10Gather: When a user follows a collection, they receive notifications if updates are made to the collection - https://phabricator.wikimedia.org/T96223#1211421 (10JKatzWMF) 3NEW [04:41:45] 10Gather: When a user follows a collection, the collection author is notified that the user is following it - https://phabricator.wikimedia.org/T96224#1211429 (10JKatzWMF) 3NEW [04:44:30] 6Mobile-Web: {{Main}} template not appearing in mobile web - https://phabricator.wikimedia.org/T91621#1211438 (10DarTar) I couldn't find a related app-specific bug report so I am posting this here (apologies if this exists elsewhere). {{main}} templates appear to be stripped from the rendered HTML in the app.... [04:48:29] 10Gather, 3Mobile-Web-Design: When a user follows a collection, the collection reflects this information - https://phabricator.wikimedia.org/T96225#1211439 (10JKatzWMF) 3NEW [04:49:13] (03PS3) 10Mhurd: WIP - do not merge. See notes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [04:49:25] 10Gather: Someone viewing a list they did not create can subscribe to/bookmark the list. - https://phabricator.wikimedia.org/T91034#1211449 (10JKatzWMF) [04:49:29] 10Gather: A user can follow a collection - https://phabricator.wikimedia.org/T94243#1211450 (10JKatzWMF) [04:50:56] 10Gather, 3Mobile-Web-Design: Desktop beta feature for Gather needs illustration - https://phabricator.wikimedia.org/T95632#1211455 (10JKatzWMF) @jdlrobson what do you mean a lack of screenshot? [04:52:53] 10Gather: It should be possible to see most followed collections - https://phabricator.wikimedia.org/T94270#1211459 (10JKatzWMF) [04:54:29] 10Gather: Should be able to get to list of collections belonging to a user from their collection - https://phabricator.wikimedia.org/T94264#1211465 (10JKatzWMF) 5Open>3Resolved a:3JKatzWMF This has been done with T91037 [04:55:47] 10Gather: If a user has collections, their last 3 collections show up on their mobile user profile - https://phabricator.wikimedia.org/T96226#1211471 (10JKatzWMF) 3NEW [04:57:27] 10Gather: A user can follow another user - https://phabricator.wikimedia.org/T96227#1211485 (10JKatzWMF) 3NEW [04:58:12] (03CR) 10Jdlrobson: Minerva Desktop: fix TOC (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [05:05:35] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: {{main}} template not showing in articles - https://phabricator.wikimedia.org/T96228#1211518 (10Deskana) [05:05:49] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: {{main}} template not showing in articles - https://phabricator.wikimedia.org/T96228#1211520 (10Deskana) p:5Triage>3High Needs fixing pretty quickly. [05:13:04] (03PS1) 10Jdlrobson: Simplify TOC replacement on desktop Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204454 (https://phabricator.wikimedia.org/T89223) [05:13:20] 10Gather, 3Mobile-Web-Design: Desktop beta feature for Gather needs illustration - https://phabricator.wikimedia.org/T95632#1211539 (10Jaredzimmerman-WMF) No, @Jdlrobson means a beta feature Illustration, like the other beta features. Please ping @violetto to see if Michelle or Gus has some cycles to create one. [05:16:01] (03CR) 10jenkins-bot: [V: 04-1] Simplify TOC replacement on desktop Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204454 (https://phabricator.wikimedia.org/T89223) (owner: 10Jdlrobson) [05:16:03] (03PS1) 10EBernhardson: Declaration of Tests\WikiGrok\Api\StubUser::load() should be compatible with that of User::load() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204455 (https://phabricator.wikimedia.org/T94137) [05:17:12] (03PS2) 10EBernhardson: Make StubUser::load() compatible with User::load() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204455 (https://phabricator.wikimedia.org/T94137) [05:17:17] (03CR) 10Legoktm: [C: 032] Make StubUser::load() compatible with User::load() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204455 (https://phabricator.wikimedia.org/T94137) (owner: 10EBernhardson) [05:17:19] (03PS2) 10Jdlrobson: Simplify TOC replacement on desktop Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204454 (https://phabricator.wikimedia.org/T89223) [05:17:43] (03CR) 10Legoktm: [C: 032] Make StubUser::load() compatible with User::load() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204455 (https://phabricator.wikimedia.org/T94137) (owner: 10EBernhardson) [05:18:15] (03PS3) 10EBernhardson: Make StubUser::load() compatible with User::load() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204455 (https://phabricator.wikimedia.org/T94137) [05:19:02] (03CR) 10Legoktm: [C: 032] Make StubUser::load() compatible with User::load() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204455 (https://phabricator.wikimedia.org/T94137) (owner: 10EBernhardson) [05:20:17] (03PS4) 10Jdlrobson: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 [05:20:47] (03PS5) 10Jdlrobson: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 [05:20:54] (03PS3) 10Jdlrobson: Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 [05:21:45] (03Merged) 10jenkins-bot: Make StubUser::load() compatible with User::load() [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204455 (https://phabricator.wikimedia.org/T94137) (owner: 10EBernhardson) [05:22:02] (03PS3) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [05:22:19] (03PS3) 10Jdlrobson: Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 [05:23:31] (03PS4) 10Jdlrobson: Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 [05:24:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (owner: 10Jdlrobson) [05:27:00] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [05:27:02] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 (owner: 10Jdlrobson) [05:28:09] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 (owner: 10Jdlrobson) [05:35:36] (03PS4) 10Jdlrobson: Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 [06:17:05] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1211620 (10bearND) [06:18:23] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Right-align right-to-left languages in Wikipedia language setting menu - https://phabricator.wikimedia.org/T95895#1211632 (10bearND) [06:29:52] (03CR) 10Florianschmidtwelzow: "Sorry @Krinkle, it seems i've missed your comments :/" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [06:43:15] (03PS1) 10Florianschmidtwelzow: Follow up I46d9a2ea [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204460 [06:43:53] (03CR) 10Florianschmidtwelzow: "-> I597aa816dc94c3de7bd808a5dd9c087044516cb9" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [06:47:16] (03CR) 10jenkins-bot: [V: 04-1] Follow up I46d9a2ea [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204460 (owner: 10Florianschmidtwelzow) [07:51:07] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1211693 (10phuedx) [07:51:58] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1095239 (10phuedx) This is now ready for design review and, if appropriate, sign off. Ping @KHammerstein, @MSyed. [08:43:18] morning [08:52:15] hey joakino [08:52:18] hey MaxSem [08:52:24] yo [08:52:26] hi! [09:53:37] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1211810 (10phuedx) @JKatzWMF: Rather than putting this behind a feature flag should we just develop this in alpha and beta? [10:45:55] I can't think clearly today [10:46:01] gonna head out to the gym [10:46:28] bbl [11:51:25] (03PS1) 10Phuedx: Beta: Add the "Tags" section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) [11:53:49] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1211948 (10phuedx) My patch is here: https://gerrit.wikimedia.org/r/#/c/204490/ [11:54:01] (03CR) 10jenkins-bot: [V: 04-1] Beta: Add the "Tags" section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [11:54:08] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1211949 (10phuedx) @JKatzWMF: I went ahead and implemented it as a beta feature. [11:56:22] (03PS2) 10Phuedx: Beta: Add the "Tags" section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) [12:15:43] (03CR) 10Phuedx: [C: 032] Adding documentation for 'exists' value for wgc_status field [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204388 (owner: 10Kaldari) [12:18:09] (03CR) 10Phuedx: [C: 032] Fixing EventLogging Schema error on submission failure [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203971 (owner: 10Kaldari) [12:21:33] (03Merged) 10jenkins-bot: Adding documentation for 'exists' value for wgc_status field [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204388 (owner: 10Kaldari) [12:22:18] (03Merged) 10jenkins-bot: Fixing EventLogging Schema error on submission failure [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203971 (owner: 10Kaldari) [12:22:43] 3Gather Sprint Forward, 5Patch-For-Review: Adding/removing to watchlist when new user causes window to reopen - https://phabricator.wikimedia.org/T95744#1211984 (10phuedx) Forgive my stupidity, but I still don't quite understand what's going on here. Context: I came here by way of the byref patch that you subm... [12:25:26] (03CR) 10Phuedx: "Future reviewer (yes you): hold off on merging this until whatever changes to WikiGrok have been made. Ta." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) (owner: 10Jdlrobson) [12:25:51] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: Panel shouldn't automatically get added to the DOM - https://phabricator.wikimedia.org/T96176#1211985 (10phuedx) [12:29:17] (03CR) 10Phuedx: [C: 031] "I agree with the talk- and uploads-related parts of this change. However, application is a reasonable name for the thing that /maybe/ repr" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204389 (owner: 10Jdlrobson) [12:31:55] (03CR) 10Phuedx: [C: 04-1] Fix icon on Special:Uploads page when you have no edits. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204413 (owner: 10Jdlrobson) [12:34:02] (03CR) 10Phuedx: [C: 032] Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 (owner: 10Jdlrobson) [12:35:32] gonna go have some lunch [12:35:33] away [12:35:37] !! [12:50:06] 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1211997 (10Jhernandez) I'm not a native english speaker nor translator so I don't understand very well what is the problem. Can somebody post any examples or explanation plea... [12:52:23] 10Gather, 3Gather Sprint Forward: Bug: When public user visits another users collections page the Page header says "[usernames] collections" - https://phabricator.wikimedia.org/T93618#1212002 (10Jhernandez) a:3Jhernandez [13:00:45] (03PS1) 10Jhernandez: Error in regex broke User lists pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204499 [13:00:53] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: Reorganise some files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204389 (owner: 10Jdlrobson) [13:03:52] 3Gather Sprint Forward: Url /by/User completely broken - https://phabricator.wikimedia.org/T96245#1212015 (10Jhernandez) 3NEW a:3Jhernandez [13:04:12] (03PS2) 10Jhernandez: Error in regex broke User lists pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204499 (https://phabricator.wikimedia.org/T96245) [13:04:31] (03Merged) 10jenkins-bot: Hygiene: Reorganise some files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204389 (owner: 10Jdlrobson) [13:04:56] (03PS3) 10Jhernandez: Error in regex broke User lists pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204499 (https://phabricator.wikimedia.org/T96245) [13:05:34] (03PS2) 10Florianschmidtwelzow: Follow up I46d9a2ea [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204460 [13:41:02] back [13:43:49] joakino, hehe [13:46:25] 10Gather, 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1192033 (10phuedx) Given the last comment on the patch and my recent conversation with @Jdlrobson about the best first step to integrating OOJS... [13:46:48] 10Gather, 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1212092 (10phuedx) a:3Jdlrobson [13:48:59] (03CR) 10Yurik: [C: 04-1] Error in regex broke User lists pages (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204499 (https://phabricator.wikimedia.org/T96245) (owner: 10Jhernandez) [13:49:04] joakino, ^ [13:49:13] 10Wikipedia-Android-App: Article Links Unclickable on Bottom of Page - https://phabricator.wikimedia.org/T96246#1212094 (10Niedzielski) 3NEW [13:49:31] joakino, btw, please add a link to the original patch - makes fixing things like that easier to track [13:49:56] 6Mobile-Web: On iOS 8.3 iPhone 5c in Private mode Safari, sometimes dragging/flicking doesn't scroll in modals - https://phabricator.wikimedia.org/T95561#1212102 (10phuedx) This might be somewhat related to T95465. During my research into the bug I've found that Apple tend to break things with new iOS Safari rel... [13:50:03] joakino, plus because there was a discussion about it, so it doesn't get lost [14:04:24] 10Wikipedia-Android-App: Article Links Unclickable on Bottom of Page - https://phabricator.wikimedia.org/T96246#1212124 (10Niedzielski) [14:38:33] 6Mobile-Web, 10Browser-Tests: Issue with Chrome driver with resizing window - https://phabricator.wikimedia.org/T88288#1212180 (10zeljkofilipin) @jdlrobson: I do not know. You are the one that reported the bug, I did not have the time to investigate. [15:00:24] 10Wikipedia-Android-App: Out of space errors causing app to crash - https://phabricator.wikimedia.org/T87073#1212229 (10Mholloway) To me it looks like the most likely cause here is that the device is out of space to create the temporary file (journal.tmp) used in the process of compacting & rebuilding the cache'... [15:02:01] 10Wikipedia-iOS-App: Crash when creating section objects after back/forward nav - https://phabricator.wikimedia.org/T96253#1212237 (10BGerstle-WMF) 3NEW [15:03:07] 10Wikipedia-iOS-App: Crash due to out-of-bounds exception in search - https://phabricator.wikimedia.org/T96254#1212251 (10BGerstle-WMF) 3NEW [15:04:04] 10Wikipedia-iOS-App: NSNull unrecognized selector when deserializing sections - https://phabricator.wikimedia.org/T96255#1212259 (10BGerstle-WMF) 3NEW [15:05:50] (03PS4) 10Jhernandez: Error in regex broke User lists pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204499 (https://phabricator.wikimedia.org/T96245) [15:06:49] yurik: ^ if you can merge it so that i can test beta labs before SF people wake up [15:07:08] i'm a bit worried the bug got into the train, we may have to cherry pick this before deployment [15:07:24] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1212284 (10bearND) p:5Triage>3Normal [15:13:17] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1212303 (10Mholloway) See my writeup in the task above. tl;dr: I don't think this limit applies to the series of events causing the crashes. [15:13:46] 10Wikipedia-iOS-App: Crash when creating section objects after back/forward nav - https://phabricator.wikimedia.org/T96253#1212306 (10BGerstle-WMF) Trying to get repro steps on this now. [15:14:29] 6Mobile-Web: Mobile Web Block Warning - https://phabricator.wikimedia.org/T96257#1212309 (10EoRdE6) 3NEW [15:24:13] (03CR) 10Yurik: [C: 032] Error in regex broke User lists pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204499 (https://phabricator.wikimedia.org/T96245) (owner: 10Jhernandez) [15:24:29] joakino, ^ [15:24:40] thx yurik! [15:25:50] joakino, np [15:29:37] (03Merged) 10jenkins-bot: Error in regex broke User lists pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204499 (https://phabricator.wikimedia.org/T96245) (owner: 10Jhernandez) [15:31:16] brb [15:32:09] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1212374 (10Mholloway) a:3Mholloway [15:32:10] Deskana: you around? [15:35:20] coreyfloyd: can you look into the search crash while i'm trying to repro the back button crash? [15:38:02] bgerstle: sure [15:40:46] hey yall is gerrit working for you? [15:40:46] joakino: does gerrit ever work? ;-P [15:40:46] i think it's down [15:41:11] anyone? [15:41:23] https://gerrit.wikimedia.org/r/ Service Temporarily Unavailable [15:42:28] seems to be working for me [15:42:28] joakino: fine for me too [15:42:28] wtfff [15:42:49] ok working back again [15:43:00] login expired [15:43:06] server has restarted or something [15:44:19] coreyfloyd: a few App Store reviews are carrying the same complaint [15:44:33] 10Gather, 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1212435 (10Jdlrobson) This is still a valid bug @phuedx ButtonWithSpinner not being a View is a problem as it blocks T94233: Promote Gather to stable. We can work... [15:44:34] joakino: ^d restartet gerrit, see https://wikitech.wikimedia.org/wiki/Server_Admin_Log :) [15:44:35] 10Gather, 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1212437 (10Jdlrobson) [15:44:53] coreyfloyd: app crashes and it gets stuck on 'updating local data' [15:45:12] see, I knew I wasn't crazy, thanks FlorianSW [15:45:19] :P [15:45:30] vibha: a "few," yes :-( [15:45:43] vibha: we're seeing crash reports in HockeyApp which we're currently investigating [15:46:13] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Article titles that should be italicised are not italicised in lead image - https://phabricator.wikimedia.org/T96262#1212442 (10Deskana) 3NEW [15:46:30] Is Mhurd around? [15:46:35] vibha: dunno [15:47:20] 6Mobile-Web, 10Browser-Tests: Issue with Chrome driver with resizing window - https://phabricator.wikimedia.org/T88288#1212451 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson @chrismcmahon was working on this - he said that this was the reason MobileFrontend's browser tests for overlays were failing. I can't... [15:48:11] 6Mobile-Web, 5Patch-For-Review: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212456 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [15:49:49] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Some article titles are randomly bolded in read more section - https://phabricator.wikimedia.org/T96263#1212461 (10Deskana) 3NEW [15:49:57] joakino: it's good that there's a message when they're taking down gerrit [15:50:51] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212468 (10phuedx) [15:52:23] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Read more sections with no results display the confusing text "No matches found for search term" - https://phabricator.wikimedia.org/T96265#1212479 (10Deskana) 3NEW [15:54:02] Deskana: if you're around, can you confirm that you saw my mail about crashes? [15:54:02] (and are aware of current app store rating situation) [15:54:02] 10Gather, 6Mobile-Web: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1212487 (10phuedx) I wouldn't say it's a bug for starters ;) Making the task a bit clearer might be useful. I'm not sure why it's in Mobile Web Sprint 45 though… [15:54:02] 10Gather, 6Mobile-Web: ButtonWithSpinner is not a true View - https://phabricator.wikimedia.org/T95490#1212496 (10phuedx) [15:54:02] 3Gather Sprint Forward, 5Patch-For-Review: Adding/removing to watchlist when new user causes window to reopen - https://phabricator.wikimedia.org/T95744#1212505 (10Jdlrobson) @phuedx no problems - it's really subtle and I'm confused now trying to explain it. So in render we were basically cloning options and t... [15:54:02] bgerstle: O hai. Yes, I did. What's "the current app store rating situation"? [15:54:04] 2 stars [15:54:19] data migration's not treating us well [15:54:34] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212520 (10Jdlrobson) Copying across discussion from other bug: @phuedx: Forgive my stupidity, but I still don't quite understand what's going on here. Context: I came here by way of the byref patch that y... [15:55:15] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212522 (10Jdlrobson) We may want to think about making render/preRender/postRender not take any parameters from now on to simplify this further. I'm not sure why you'd need to / should pass arguments that... [15:56:10] bgerstle: Are users complaining about that specifically? [15:56:16] bgerstle: Do we have our first reviews in yet? [15:57:02] Deskana: yes: https://itunes.apple.com/us/app/wikipedia-mobile/id324715238?mt=8 [15:57:20] can't see easily on web, i suggest you go to iTunes [15:57:49] bgerstle: Do we have any crash reports from the migration? People are saying it's crashing. [15:58:19] Deskana: the only crash reports i see are from other things that don't appear to be a direct result of migration [15:58:27] Hm, strange. [15:58:31] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212542 (10Jhernandez) Merged. @jdlrobson what do you think if we kill the options parameter on preRender and postRender? Right now there is two ways/patterns in the views - Getting it from the paramete... [15:58:35] Deskana: it could be that migration crashes are going unreported because crash submissions happen on the next app luanch [15:58:38] launch* [15:58:43] coreyfloyd: would you agree? ^ [15:59:28] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Header in article history that should display a date instead displays the current time, UTC - https://phabricator.wikimedia.org/T96268#1212543 (10Deskana) 3NEW [15:59:41] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212550 (10Jhernandez) I took too long to write this xD, +1 to no arguments [15:59:47] bgerstle: possible… but they could go through as long as there enough time before the crash [16:00:12] bgerstle: Deskana but if we don’t have the reports… that is a good guess why [16:00:36] bgerstle: Deskana do we have a button to initiate the migration? [16:00:44] or does it just start, i forget [16:01:11] coreyfloyd: it starts, and you can't stop it [16:01:14] 6Mobile-Web: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212560 (10phuedx) > We may want to think about making render/preRender/postRender not take any parameters from now on to simplify this further. I'm not sure why you'd need to / should pass arguments that a... [16:01:20] the "workaround" is to delete and reinstall [16:01:30] 3Gather Sprint Forward, 5Patch-For-Review: Adding/removing to watchlist when new user causes window to reopen - https://phabricator.wikimedia.org/T95744#1212561 (10phuedx) Thanks for the clarification @Jdlrobson. [16:01:51] coreyfloyd: i only see one crash report related to migration, but it's low-incidence: https://rink.hockeyapp.net/manage/apps/152731/app_versions/5/crash_reasons/32620834 [16:02:12] interesting.. " 'This NSPersistentStoreCoordinator has no persistent stores (corrupt file). It cannot perform a save operation.'" [16:02:39] not sure why we're even going through core data to "save" anything during migration. we should just nuke the .sqllite file and be done w/ it [16:04:48] 6Mobile-Web: Pre and post render functions on View should not take arguments - https://phabricator.wikimedia.org/T96269#1212581 (10Jdlrobson) 3NEW [16:05:21] 6Mobile-Web, 5Patch-For-Review: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212588 (10Jdlrobson) https://phabricator.wikimedia.org/T96269 [16:05:58] 6Mobile-Web, 5Patch-For-Review: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212589 (10Jhernandez) 5Resolved>3Open @jdlrobson @phuedx quick review of hygiene patch related to this ⬆️ Have you guys created the task for removing options as a parameter of pre... [16:09:19] 6Mobile-Web, 7Upstream: Crashing with new mobile Mozilla Firefox - https://phabricator.wikimedia.org/T89608#1212604 (10Jdlrobson) Thanks for the prompt reply! I highly suspect this was the issue we were seeing with Firefox crashing. It would happen whenever you scroll or resize. If the bug shows its ugly face... [16:09:45] 6Mobile-Web, 7Upstream: Crashing with new mobile Mozilla Firefox - https://phabricator.wikimedia.org/T89608#1212605 (10Jdlrobson) [16:12:42] 6Mobile-Web: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1212616 (10Jdlrobson) It's a lot of code simply to reverse engineer a thumbnail url. If we reverse engineer it using native browser code by all means that would be a huge win. what method were you thinking of? [16:16:19] coreyfloyd: working with the older project is so painful "Running 6 of 8 custom shell scripts" 😡 [16:16:57] lol [16:16:57] coreyfloyd: also i guess you fixed jenkins? [16:16:57] or the mac mini [16:16:58] what'd you do? [16:17:03] yeah - several things… [16:17:37] the last thing was that the script was not looking for the .git repo in the right place [16:17:55] hrm [16:17:56] but also some issues with constants [16:18:01] lovely [16:21:04] 10Gather, 3Gather Sprint Forward: Bug: When public user visits another users collections page the Page header says "[usernames] collections" - https://phabricator.wikimedia.org/T93618#1212636 (10Jhernandez) Actually, no other page than /Special:Gather/by/User/555 has a title. So I'm going to restore them all p... [16:29:50] 6Mobile-Web, 5Patch-For-Review: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1212673 (10Jhernandez) @jdlrobson is like the road runner. Before you post he's already addressed the question LOL {F114985} [16:35:03] 6Mobile-Web: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1212683 (10phuedx) There isn't one. I was being silly. How about we create an MobileWikidataInfobox API for doing the munging server side and let the client to the presentation? [16:38:48] 6Mobile-Web: Pre and post render functions on View should not take arguments - https://phabricator.wikimedia.org/T96269#1212689 (10Jhernandez) [16:39:14] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1212694 (10Jdlrobson) [16:39:16] 6Mobile-Web: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1212693 (10Jdlrobson) [16:40:40] 6Mobile-Web: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1133189 (10Jdlrobson) I think the url should be served in the page as a config variable, or returned by the api (see T76827) Right now the infobox is all that uses it so it's not a big deal and we have no pl... [16:42:28] 6Mobile-Web: Promote alpha header to beta - https://phabricator.wikimedia.org/T96173#1212706 (10Jdlrobson) Really? I thought we were completely overhauling this and redesigning this? If so, I'd hate us to waste energy pushing the existing alpha menu into beta. [16:43:37] 6Mobile-Web, 10MobileFrontend: In MobileBeta front end, clicking in TOC does not go to a subsection whose parent section is unexpanded on the page. - https://phabricator.wikimedia.org/T95122#1212712 (10Jdlrobson) I'm confused. The TOC should only show when sections are already expanded. There was a Firefox ups... [16:43:39] 6Mobile-Web: Promote alpha header to beta - https://phabricator.wikimedia.org/T96173#1212714 (10phuedx) This task needs more fleshing out before we commit to it. As it stands, it's a placeholder task. [16:45:00] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Bug: When public user visits another users collections page the Page header says "[usernames] collections" - https://phabricator.wikimedia.org/T93618#1212718 (10Jhernandez) Patch is here https://gerrit.wikimedia.org/r/#/c/204537/ for review. Not sure why g... [16:45:39] 6Mobile-Web: md5 library should be removed from MobileFrontend - https://phabricator.wikimedia.org/T93258#1212722 (10phuedx) … or just get the API to return it. [16:45:49] 10Gather, 3Gather Sprint Forward: When search returns no results no behaviour defined. - https://phabricator.wikimedia.org/T95966#1212723 (10Jdlrobson) a:5Jdlrobson>3MSyed [16:46:53] i have said it before and i'll say it again [16:47:48] kiasmos's eponymous album may have been released in 2014, but it's still my favourite album of 2015 [16:47:48] if only there were some way of tracking what i was listening to all the time… [16:48:19] dr0ptp4kt: coreyfloyd Deskana do we know how many people had versions older than 4.0.6? [16:48:53] AFAIK all of our migration testing was done from 4.0.6 -> 4.1.0. some of these issues/crashes could be coming from migrations from earlier versions. [16:49:04] and could be why i'm unable to produce them [16:50:09] bgerstle: i don't know. and you're right, that could very well be. recall, there was an explicit conversation about not needing to support users from pre 4.0.6 (most likely people jumping versions from phonegap) [16:50:09] dr0ptp4kt: yeah, just wondering what we expected [16:50:09] dr0ptp4kt: also, can you think of any reason why a mobileview response's "section" object wouldn't have an id? [16:50:33] bgerstle: yeah. hindsight is 20/20 :) i'm sorry i didn't think to give a cancel option sooner! and if anyone else suggested it, i'm sorry if it got filtered out of my brain [16:50:53] dr0ptp4kt: i only mentioned it in passing as we were wrapping up 4.1.0. didn't occur to me either [16:51:28] nor to any of our testers. a strange, but unfortunately critical oversight [16:51:28] bgerstle: not sure about the response thing. some guys familiar with that api are in standup. BUT, when they get back ask jdlrobson and pheudx . [16:51:30] ok [16:51:56] dr0ptp4kt: the weird thing is it only seems to happen when navigating "back" [16:51:57] bgerstle: as a famous canadian once said, 'you live, you learn' [16:52:32] yurik: you have two problems when you use a regex [16:52:36] yurik: i HEAR you [16:52:37] :) [16:54:58] 6Mobile-Web, 10MobileFrontend: In MobileBeta front end, clicking in TOC does not go to a subsection whose parent section is unexpanded on the page. - https://phabricator.wikimedia.org/T95122#1212757 (10Thnidu) @Jdlrobson: What is the expected behavior on first visiting a page? If the TOC doesn't appear till th... [17:07:25] 6Mobile-Web, 10MobileFrontend: In MobileBeta front end, clicking in TOC does not go to a subsection whose parent section is unexpanded on the page. - https://phabricator.wikimedia.org/T95122#1212810 (10Jdlrobson) To clarify: The table of contents should only show when the sections are /not/ collapsed on page l... [17:08:47] 6Mobile-Web: [placeholder] Promote alpha header to beta - https://phabricator.wikimedia.org/T96173#1212818 (10Jdlrobson) [17:09:24] phuedx: so... mw-ui-icon time!? [17:09:50] jdlrobson: release has been cut? [17:09:55] phuedx: yup [17:09:55] i swear if there any bugs we will discover them in the next 24 hours and i will have them fixed by end of week [17:10:12] phuedx: don't know if you saw but i have a bunch of abstractions for Button and Anchors [17:10:20] yeah… [17:10:22] should make switching to oojs ui even easier [17:10:38] i'm really not sure how i feel about all that [17:10:38] no? in what sense [17:10:56] but i can see what the Plan™ is [17:11:08] honestly, i quite like the dom [17:11:15] :P [17:11:40] jdlrobson: if you can wait like 20 minutes [17:11:44] sure thing [17:11:52] i've got to get george bathed before he goes to bed [17:11:55] and he's /tired/ [17:12:02] i actually prefer the template partial / options approach to the toHtmlString approach [17:12:06] aww [17:12:17] talk in a bit [17:12:26] that's a nice way of saying he's behaving badly for no apparent reason [17:12:27] ;) [17:13:22] To the Gather! [17:14:10] jdlrobson: the icon patch with the rebases is becoming hard to review gr [17:14:31] jdlrobson: im going to do a little fix to the mainmenu.js icon- thingy, i'll ping you [17:19:03] dr0ptp4kt: question about the 'upgrading local data' [17:19:07] What does it mean? [17:19:29] And why we are we saying that to a user? [17:21:07] dr0ptp4kt, were you in a standup? [17:22:16] vibha: there was an old version of the underlying database for the app (it used a technology called 'core data'), and then there was the new one (completed in december, and it uses flat files and directories). so when the app starts for the first time for a user, if she has Recent / Saved from a prior version, the app code tries to migrate the data from the old version of the database to the new version of the database. [17:22:42] vibha: as to why it is shown in the first place, i believe it had to do with complications around letting the user use the app but having an in-flight database migration going on that could result in corrupted data [17:23:22] vibha: we *believe* the data migration thing isn't super common (otherwise there would be more crash reports coming via the apple servers), but it of course really sucks for users who have it, and they're vocalizing that in their app store rations. [17:23:30] yurik: i was within earshot :) [17:23:46] hehe, didn't think it was loud [17:23:53] vibha: hey did you see the invite i sent you? [17:24:11] Mhurd yeah! [17:24:39] We can chat - little bit of a jam packed day though. [17:24:49] I'll accept the meeting [17:24:58] vibha: yeah i saw your calendar was pretty full [17:25:08] Deskana: hey dan! [17:25:36] joakino: that's why people should review it quicker - pull the band aid! I'll fix anything we discover in the aftermath :) [17:25:45] dr0ptp4kt: it's less annoying if it goes away. But we can make the message but more user friendly. [17:26:05] Bit more* [17:26:06] bearND: hey bernd, when the maven checkstyle tests on jenkins time out, do I need to trigger them again, or do they automatically run again after a period of time has passed? [17:26:59] mhurd: Hi Monte. Something up? Kinda swamped atm. [17:27:11] 6Mobile-Web: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1212917 (10Jdlrobson) [17:27:14] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1212918 (10Jdlrobson) [17:27:16] 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#1212916 (10Jdlrobson) 5Open>3Resolved [17:27:45] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#938000 (10Jdlrobson) Is this still a problem? [17:28:45] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1212928 (10Jdforrester-WMF) Yes. We're waiting for the stalled patch in Mobile to be merged. [17:28:53] mholloway: we need to trigger them again manually (add a "recheck" comment) [17:29:10] bearND: ok, thanks! [17:29:46] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1212933 (10Jdforrester-WMF) Belay that. now that T86366 is fixed, this is fixed too in master. Thanks! [17:29:50] Deskana: sent you an invite. if you don't have time that's fine though [17:30:06] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1212935 (10Jdforrester-WMF) 5Open>3Resolved [17:30:24] mhurd: Yeah, not at the minute. Sorry. :-( [17:30:51] Deskana: no worry. i'll take another pass at the app store descrip and send you email later today [17:30:58] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1212939 (10Jdforrester-WMF) [17:31:14] jdlrobson: Sorry, hadn't seen the change in Mobile. Thanks! [17:32:26] jdlrobso_, joakino: state of the icon patch atm? [17:32:41] phuedx: seems almost fine [17:32:50] almost? [17:32:52] ALMOST! [17:32:53] phuedx: i'm trying to get a little improvement for the replacing of old classes [17:32:55] mhurd coreyfloyd https://github.com/bgerstle/apps-ios-wikipedia/tree/release/4.1.1 [17:33:01] oh the space thing? [17:33:02] phuedx: at least almost IMO [17:33:06] yes [17:33:12] doooo iiiit [17:33:21] before i head off to the climbing wall [17:33:24] before meetinz [17:33:57] the space thing? [17:34:10] oh the reg ex crap [17:35:21] classic regex bullshit [17:35:34] joakino: HURRY UP [17:35:40] TYPE FASTER [17:35:45] WE'RE ALL WAITING FOR YOUUUUU [17:36:19] xDD [17:37:22] 10Gather, 3Gather Sprint Forward: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1212970 (10Jdlrobson) [17:39:34] 6Mobile-Web, 10Performance-Metrics-Dashboard: (3) Create a mobile site speed dashboard - https://phabricator.wikimedia.org/T95300#1212981 (10bmansurov) Not sure, a 3 still sounds good to me. [17:40:36] bearND: Like so? https://gerrit.wikimedia.org/r/#/c/204534/ [17:40:59] mholloway: yes, exactly [17:41:24] bearND: ok cool [17:41:39] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (10 instances reported) MWKDataObject requiredNumber:dict - https://phabricator.wikimedia.org/T96205#1212998 (10BGerstle-WMF) [17:41:41] 10Wikipedia-iOS-App: Crash when creating section objects after back/forward nav - https://phabricator.wikimedia.org/T96253#1212999 (10BGerstle-WMF) [17:41:50] mholloway: it'll take a bit for the tasks to be rerun. If you're curious you can check Zuul (https://integration.wikimedia.org/zuul/) [17:41:50] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when creating section objects after back/forward nav - https://phabricator.wikimedia.org/T96253#1212237 (10BGerstle-WMF) [17:41:58] mhurd coreyfloyd https://github.com/bgerstle/apps-ios-wikipedia/tree/release/4.1.1 [17:42:08] 10Gather: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1213010 (10Jdlrobson) [17:42:10] 3Gather Sprint Forward: Link to collection on the toast when creating or adding item is sucessful - https://phabricator.wikimedia.org/T96133#1213009 (10Jdlrobson) [17:42:18] mholloway: and look for "apps/android/wikipedia" there [17:43:52] phuedx: jdlrobso_: i've uploaded and rebased master, see https://gerrit.wikimedia.org/r/#/c/202089/25/javascripts/modules/mainMenu/MainMenu.js it's the only thing i've touched [17:43:54] 10Gather, 10Gather Sprint G: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1213016 (10Jdlrobson) a:3MSyed [17:44:18] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.1.1(76) - clicking links in offline mode saved them in Recent - https://phabricator.wikimedia.org/T95585#1213020 (10BGerstle-WMF) a:5BGerstle-WMF>3None [17:44:51] proof it works https://jsfiddle.net/ob5tb7Lt/ xd [17:44:53] 10Gather, 3Gather Sprint Forward: When search returns no results no behaviour defined. - https://phabricator.wikimedia.org/T95966#1213028 (10Jdlrobson) [17:45:14] 10Gather, 3Gather Sprint Forward: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1213035 (10phuedx) OK. So. Regular expression based routing performance. You want flexible: https://packagist.org/packages/symfony/routing You want fast: https://packagist.org/packages/nikic/f... [17:45:16] 10Gather, 10Gather Sprint G: When search returns no results no behaviour defined. - https://phabricator.wikimedia.org/T95966#1205174 (10Jdlrobson) [17:45:25] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when creating section objects after back/forward nav - https://phabricator.wikimedia.org/T96253#1213038 (10BGerstle-WMF) a:3BGerstle-WMF [17:45:38] 10Gather, 10Gather Sprint G: API: Inconsistent response for empty collections - https://phabricator.wikimedia.org/T95741#1213040 (10Jdlrobson) a:5Yurik>3None [17:47:20] 10Gather, 3Gather Sprint Forward: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1213047 (10phuedx) In the unlikely event that you find out that the routing part of your code is slower than, say, total time spent interacting with the database, then please, please, PLEASE do... [17:47:45] 10Gather, 10Gather Sprint G: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1205347 (10Jdlrobson) [17:47:51] 10Gather, 10Gather Sprint G: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1205347 (10Jdlrobson) @Yurik this should be trivial to do right? [17:48:00] 10Gather, 10Gather Sprint G: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1213059 (10Jdlrobson) [17:48:37] joakino: add mw-ui-icon-before and then remove it? [17:48:52] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (13 instances reported) SearchResultsController tableView:didSelectRowAtIndexPath - https://phabricator.wikimedia.org/T96204#1213060 (10Fjalapeno) a:3Fjalapeno [17:48:54] 10Gather, 10Gather Sprint G: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1213061 (10Yurik) Which query? please provide a sample api call [17:48:56] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (13 instances reported) SearchResultsController tableView:didSelectRowAtIndexPath - https://phabricator.wikimedia.org/T96204#1213062 (10BGerstle-WMF) [17:48:58] 10Wikipedia-iOS-App: Crash due to out-of-bounds exception in search - https://phabricator.wikimedia.org/T96254#1213063 (10BGerstle-WMF) [17:49:11] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash due to out-of-bounds exception in search - https://phabricator.wikimedia.org/T96254#1212251 (10BGerstle-WMF) [17:49:26] phuedx: yo wtf is that [17:49:28] xD [17:49:31] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (6 instances reported) MWKDataObject optionalNumber:dict - https://phabricator.wikimedia.org/T96203#1213070 (10BGerstle-WMF) [17:49:44] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: NSNull unrecognized selector when deserializing sections - https://phabricator.wikimedia.org/T96255#1212259 (10BGerstle-WMF) [17:49:48] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash due to out-of-bounds exception in search - https://phabricator.wikimedia.org/T96254#1213085 (10Fjalapeno) a:3Fjalapeno [17:49:50] joakino: line 58 of mainmenu.js ;) [17:49:58] phuedx: i know, it wasn't me [17:50:06] monster [17:50:10] i blame you though [17:50:55] jdlrobso_: ^? [17:51:05] oh he is in a meeting i think [17:51:07] i hope my folksy charm comes across in my phabricator comments [17:51:17] hmm [17:51:22] i'd hate for people to take me seriously [17:51:24] okie poke [17:51:28] i'm going for a climb [17:51:33] 10Gather: Public collection feed filtered for quality - https://phabricator.wikimedia.org/T96222#1213100 (10Jdlrobson) [17:51:41] i'll be back later for a meeting, so i'll work with jdlrobso_ to try and get it merged [17:51:43] joakino ^ [17:51:46] don't fret [17:51:50] cool [17:51:57] you'll wake up and you'll think it was all a dream [17:51:59] phuedx: i've been testing and I think it is good enough [17:52:06] we have to do it [17:52:07] joakino: agreed [17:52:15] right [17:52:18] AFK! [17:52:25] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Prompt user before starting data migration - https://phabricator.wikimedia.org/T96280#1213101 (10BGerstle-WMF) 3NEW a:3Mhurd [17:52:31] in case yer not around when i get back, g'night joakino [17:52:36] bb! [17:52:41] dr0ptp4kt: when are you guys thinking of submitting another build? [17:52:57] vibha: hopefully this afternoon. actually, are you in the office? [17:53:27] http://media.giphy.com/media/oOV6ACuwuGCXe/giphy.gif [17:53:34] I will be in - in a few minutes. Wfh in the morning. [17:54:45] 10Gather: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1213118 (10Jdlrobson) [17:56:02] 10Gather, 10Gather Sprint G: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1211394 (10Jdlrobson) [17:57:59] jdlrobso_, https://phabricator.wikimedia.org/T95972 [17:58:29] 10Gather, 10Gather Sprint G: Spike: How could we show a page listing most visited collections - https://phabricator.wikimedia.org/T94271#1213127 (10Jdlrobson) [18:00:39] 10Gather, 10Gather Sprint G: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1213137 (10Jdlrobson) a:3MSyed [18:03:00] 10Gather, 3Mobile-Web-Design: Desktop beta feature for Gather needs illustration - https://phabricator.wikimedia.org/T95632#1213146 (10MNguyen) I'm in. Just pinged you on gchat @jdlrobson // [18:04:12] 10Gather, 10Gather Sprint G: Spike: A user can follow a collection - https://phabricator.wikimedia.org/T94243#1213152 (10Jdlrobson) [18:04:16] 10Gather: If an article has been flagged 2x, it is listed in a special feed for 'someone' to monitor - https://phabricator.wikimedia.org/T95769#1213155 (10JKatzWMF) [18:06:10] 10Gather, 10Gather Sprint G: If a user has collections, their last 3 collections show up on their mobile user profile - https://phabricator.wikimedia.org/T96226#1213157 (10Jdlrobson) [18:07:34] 10Gather, 10Gather Sprint G: Spike: A user can follow a collection - https://phabricator.wikimedia.org/T94243#1213169 (10Jdlrobson) [18:07:35] 10Gather, 3Mobile-Web-Design: When a user follows a collection, the collection reflects this information - https://phabricator.wikimedia.org/T96225#1213168 (10Jdlrobson) [18:08:07] 10Gather, 10Gather Sprint G: Spike: A user can follow a collection - https://phabricator.wikimedia.org/T94243#1158084 (10Jdlrobson) [18:08:09] 10Gather: When a user follows a collection, the collection author is notified that the user is following it - https://phabricator.wikimedia.org/T96224#1211429 (10Jdlrobson) [18:08:34] 10Gather, 10Gather Sprint G: Spike: A user can follow a collection - https://phabricator.wikimedia.org/T94243#1158084 (10Jdlrobson) [18:08:36] 10Gather: When a user follows a collection, they receive notifications if updates are made to the collection - https://phabricator.wikimedia.org/T96223#1211421 (10Jdlrobson) [18:08:40] 10Gather, 10Gather Sprint G: Spike: A user can follow a collection - https://phabricator.wikimedia.org/T94243#1158084 (10Jdlrobson) [18:08:42] 10Gather: It should be possible to see most followed collections - https://phabricator.wikimedia.org/T94270#1158436 (10Jdlrobson) [18:10:20] jdlrobso_: JonKatz brb coffee [18:12:48] 10Gather: Spike: Storing flag clicks - https://phabricator.wikimedia.org/T96282#1213199 (10Jdlrobson) 3NEW [18:13:03] 10Gather, 10Gather Sprint G: Spike: Storing flag clicks - https://phabricator.wikimedia.org/T96282#1213207 (10Jdlrobson) [18:13:37] 10Gather, 10Gather Sprint G: Spike: Storing flag clicks - https://phabricator.wikimedia.org/T96282#1213199 (10Jdlrobson) [18:13:38] 10Gather: If an article has been flagged 2x, it is listed in a special feed for 'someone' to monitor - https://phabricator.wikimedia.org/T95769#1199826 (10Jdlrobson) [18:14:06] 10Gather, 10Gather Sprint G: Spike: Following - https://phabricator.wikimedia.org/T94243#1213222 (10Jdlrobson) [18:15:00] 10Gather: I can collect collections - https://phabricator.wikimedia.org/T94250#1213227 (10JKatzWMF) [18:15:04] 10Gather, 10Gather Sprint G: Spike: Following - https://phabricator.wikimedia.org/T94243#1213230 (10Jdlrobson) [18:15:40] 10Gather: Make Special:GatherList responsive - https://phabricator.wikimedia.org/T93389#1213236 (10Jdlrobson) [18:17:13] 10Gather: A user is able to indicate if they like a list so that the author and others can learn from their opinion - https://phabricator.wikimedia.org/T91035#1213248 (10Jdlrobson) @kaldari if we were to use thanks on this could we count the number of thanks? [18:17:20] 10Gather: A user is able to indicate if they like a list so that the author and others can learn from their opinion - https://phabricator.wikimedia.org/T91035#1213252 (10Jdlrobson) a:3kaldari [18:17:22] 10Gather, 3Mobile-Web-Design: Desktop beta feature for Gather needs illustration - https://phabricator.wikimedia.org/T95632#1213254 (10violetto) a:5Jdlrobson>3MNguyen @Mnguyen is on this. She'll get in touch @Jdlrobson. [18:18:16] 6Mobile-Web, 10MobileFrontend: In MobileBeta front end, clicking in TOC does not go to a subsection whose parent section is unexpanded on the page. - https://phabricator.wikimedia.org/T95122#1213258 (10Thnidu) When it gets to working right, are //all// the headers visible? Or only the top level (h2)? If all... [18:18:57] 10Gather: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1213261 (10Jdlrobson) a:5JKatzWMF>3MSyed [18:18:59] 10Gather: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1213263 (10JKatzWMF) @msyed lets talk through this when you get back [18:19:48] 10Gather: List last collection on profile - https://phabricator.wikimedia.org/T94263#1213268 (10JKatzWMF) [18:19:50] 10Gather, 10Gather Sprint G: If a user has collections, their last 3 collections show up on their mobile user profile - https://phabricator.wikimedia.org/T96226#1213269 (10JKatzWMF) [18:19:52] 10Gather: A user monitoring the "flagged" feed can"unflag" it, so that it is removed from the queue and others do not have to review it. - https://phabricator.wikimedia.org/T95770#1199833 (10Jdlrobson) [18:19:54] 10Gather, 10Gather Sprint G: Spike: Storing flag clicks - https://phabricator.wikimedia.org/T96282#1213272 (10Jdlrobson) [18:19:58] 10Gather: A user who has flagged a collection cannot flag the same collection so that they do not have disproportionate voice. - https://phabricator.wikimedia.org/T95768#1199810 (10Jdlrobson) [18:20:00] 10Gather, 10Gather Sprint G: Spike: Storing flag clicks - https://phabricator.wikimedia.org/T96282#1213199 (10Jdlrobson) [18:21:46] 10Gather, 10Gather Sprint G: Spike: Flagging - https://phabricator.wikimedia.org/T96282#1213276 (10Jdlrobson) [18:22:48] 10Gather, 10Gather Sprint G: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1213279 (10Jdlrobson) [18:22:50] 10Gather: No way to get to collection from "this page has been added to your collection" notice - https://phabricator.wikimedia.org/T94520#1213278 (10Jdlrobson) [18:23:26] 10Gather: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1213284 (10Jdlrobson) [18:25:37] 10Gather, 3Gather Sprint Forward: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1213287 (10Jhernandez) Thanks phuedx!!! [18:26:51] 3Gather Sprint Forward: Jon to reach out to WikiVoyage community about trialling collections. - https://phabricator.wikimedia.org/T96284#1213292 (10Jdlrobson) 3NEW a:3Jdlrobson [18:30:42] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: NSNull unrecognized selector when deserializing sections - https://phabricator.wikimedia.org/T96255#1213311 (10Fjalapeno) a:3Fjalapeno [18:30:59] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (6 instances reported) MWKDataObject optionalNumber:dict - https://phabricator.wikimedia.org/T96203#1213312 (10Fjalapeno) a:3Fjalapeno [18:33:41] 10Gather: Collections invite via mobile panel - https://phabricator.wikimedia.org/T96286#1213325 (10JKatzWMF) 3NEW [18:33:57] 10Gather: Collections (beta) invite via mobile panel - https://phabricator.wikimedia.org/T96286#1213336 (10JKatzWMF) [18:36:08] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.0.7.8 - NSURLErrorDomain error code -999 with the first login - https://phabricator.wikimedia.org/T93789#1146165 (10Etonkovidova) Checked the fix with 4.1.1(85). [18:44:37] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1213360 (10Etonkovidova) Checked the fix in 4.1.1(85). [18:45:18] jdlrobson: hey based on our meeting last week about getting minerva ready for desktop [18:45:32] jdlrobson: did you start any phab tasks related to that yet? [18:48:15] Deskana: mhurd dr0ptp4kt i suggest you guys talk about the migration prompt IRL or over hangout. i still advise that we avoid trying to implement pausing the migration, at least for now. [18:48:23] i can join if you want [18:48:44] mhurd was working on the task [18:48:48] s/was/is/ [19:01:13] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: IllegalStateException: Recursive entry to executePendingTransactions from page.gallery.GalleryActivity.onBackPressed - https://phabricator.wikimedia.org/T94726#1213386 (10Mholloway) I haven't had any luck reproducing this crash on my own device or in Geny... [19:01:30] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1213387 (10bearND) @Vibhabamba: Here is an updated apk of prototype 1 {F115174} DONE: * Removed the X button * Increased type size for page text extract to 1... [19:01:41] vibha: ^ [19:01:58] bearND: thanks! [19:02:14] I should download from the regular android builds site right? [19:05:08] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1213394 (10Etonkovidova) Checked the fix in 4.1.1(85). [19:09:33] bgerstle: you have luck having Xcode install the xcappdata for you? [19:09:41] yeah [19:09:46] on the device at least [19:09:52] for sim i manually copy/paste [19:10:55] ahh - so only works on the device… [19:11:06] bgerstle: dr0ptp4kt coreyfloyd corey's patch looks good. ok for me to merge? [19:11:11] coreyfloyd: for sim, do "Open Package Contents" [19:11:13] mhurd yep [19:11:23] 10Wikipedia-iOS-App: 4.1.1(85) Formatting issues in collapsing boxes - https://phabricator.wikimedia.org/T96288#1213402 (10Etonkovidova) 3NEW [19:11:33] yeah - i was doing that… wanted Xcode to be my bitch though [19:31:33] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1213475 (10bearND) Also wanted to mention that I consider the bug (preview missing text) not critical to the user testing. This one can wait until later IMO. [19:32:07] 6Mobile-Web, 10MobileFrontend: In MobileBeta front end, clicking in TOC does not go to a subsection whose parent section is unexpanded on the page. - https://phabricator.wikimedia.org/T95122#1213476 (10Thnidu) Oh, well... Has anyone considered treating the TOC somewhat like a section? Specifically: * initiall... [19:35:52] matanya: Do you still experience the issue with the alpha build you reported yesterday? I have not seen that myself or heard about that before you mentioned it. [19:36:11] yes bearND [19:36:25] i'll try to give steps for reporducing [19:36:56] + i have a question I can't define well but i'll try: [19:38:02] on some alpha's when i leave the app to do something else (e.g. read eamil) when i return to it, it takes me to the main page, but in some alpha i am taken back to the article i was reading [19:38:25] I can't tell exactly when is each behaviour. [19:39:33] bearND: found an example: go to the article: יעקב משה הלל in he.wiki [19:54:44] mhurd: any chance we can move out meeting to 4? [19:54:50] Our* [19:54:57] vibha: ya! [19:55:38] we have a team lunch and we will be given some team updates [19:55:54] Thanks. I'd like to not have to leave in the middle. [19:56:16] vibha: updated the invite [19:59:21] 6Mobile-Web: Mobile Web Block Warning - https://phabricator.wikimedia.org/T96257#1213501 (10Jdlrobson) Oh dear. Thanks for the heads up @EoRdE6. I suspect this is an oversight related to the anonymous editing change. Was the user anonymous at the time or logged in? cc @florian @nemo_bis [20:01:15] (03PS2) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [20:01:22] 10Gather, 3Gather Sprint Forward: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1213515 (10phuedx) But if you do want to write your own routing framework, then I suggest you take a look at Mongrel2's routing code which compiles the regular expressions to tries at startup t... [20:01:35] 6Mobile-Web, 10MediaWiki-User-login-and-signup, 7Technical-Debt, 7Tracking: Login form should support custom messages based on returnto and returntoquery parameters - https://phabricator.wikimedia.org/T96191#1213516 (10Jdlrobson) [20:02:05] (03CR) 10Robmoen: [C: 04-1] "Split this from previous commit. Reworking to not introduce route. Also finishing schema bit" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [20:02:22] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1196178 (10Jdlrobson) [20:02:33] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Image description is not inserted into the correct paragraph - https://phabricator.wikimedia.org/T93241#1213528 (10Jdlrobson) [20:02:40] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: On iOS 8.3 iPhone 5c in Private mode Safari, sometimes dragging/flicking doesn't scroll in modals - https://phabricator.wikimedia.org/T95561#1213529 (10Jdlrobson) [20:02:56] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Special:MobileOptions throwing JS error from mobile.watchstar in stable - https://phabricator.wikimedia.org/T92657#1213531 (10Jdlrobson) [20:03:32] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Mobile Web Block Warning - https://phabricator.wikimedia.org/T96257#1213537 (10Jdlrobson) [20:04:13] 3Gather Sprint Forward: Jon to reach out to WikiVoyage community about trialling collections. - https://phabricator.wikimedia.org/T96284#1213292 (10Jdlrobson) Done - https://en.wikivoyage.org/w/index.php?title=Wikivoyage%3ATravellers%27_pub&diff=2766750&oldid=2766692 @moushira @JKatzWMF [20:09:37] foods brb [20:09:53] (03PS5) 10Jdlrobson: Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 [20:10:01] (03CR) 10jenkins-bot: [V: 04-1] Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 (owner: 10Jdlrobson) [20:10:22] (03PS3) 10Jdlrobson: Hygiene: Panels should not automatically be appended to DOM [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) [20:10:26] (03CR) 10Jdlrobson: Hygiene: Panels should not automatically be appended to DOM (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) (owner: 10Jdlrobson) [20:10:34] (03PS6) 10Jdlrobson: Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 [20:10:41] (03CR) 10jenkins-bot: [V: 04-1] Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 (owner: 10Jdlrobson) [20:12:53] (03PS7) 10Jdlrobson: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) [20:13:01] (03CR) 10Jdlrobson: Add button abstraction (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [20:13:03] (03CR) 10jenkins-bot: [V: 04-1] Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [20:13:12] (03PS5) 10Jdlrobson: Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 [20:13:24] jdlrobson: the meeting that i had may have been cancelled [20:13:41] (03PS8) 10Jdlrobson: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) [20:13:44] so i'm gonna take a look at the mw-ui-icon patch tomorrow morning [20:13:49] and head off now [20:14:02] (03PS5) 10Jdlrobson: Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 [20:14:09] i don't foresee any issues [20:15:19] (03CR) 10jenkins-bot: [V: 04-1] Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [20:15:34] (03PS6) 10Jdlrobson: Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 [20:15:56] phuedx: thanks :D [20:16:25] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [20:17:00] we should also talk about how things keep getting added to the readership team's current to do list ;) [20:17:00] but i can send an email about it [20:17:02] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 (owner: 10Jdlrobson) [20:17:05] okie poke [20:17:07] g'night [20:17:43] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 (owner: 10Jdlrobson) [20:19:18] rmoen: oh dears. gonna need you to +2 a change from me in a minute! :) [20:19:38] 10Gather, 3Gather Sprint Forward: Redirect Special:Gather & friends to Special:Gather/by/User for sharing purposes - https://phabricator.wikimedia.org/T96151#1213554 (10Jdlrobson) a:3Jdlrobson [20:19:45] jdlrobson: no worries [20:21:43] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1213558 (10Mholloway) Well, sure enough, here's the trouble (in /android/support/v7/app/ActionBarActivityDelegate... [20:23:15] (03PS1) 10Jdlrobson: Make Special:Gather show pages for that user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204620 [20:23:16] ^ rmoen [20:24:09] gonna get that swatted as well [20:24:33] ok [20:24:35] sec [20:25:33] matanya: I think the back behavior is not specific to a particular alpha version (at least for now) [20:25:49] matanya: I mean the restarting [20:26:25] (03CR) 10Robmoen: [C: 032] Make Special:Gather show pages for that user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204620 (owner: 10Jdlrobson) [20:26:36] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1213568 (10bmansurov) a:5bmansurov>3None [20:27:31] (03PS1) 10Jdlrobson: Redirect to canonical url for Gather pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204624 (https://phabricator.wikimedia.org/T96151) [20:27:57] matanya: It would be good to have a Phab task about this as well. I think it has to do with the activity lifecycle. [20:28:01] (03PS4) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [20:28:17] (03PS4) 10Jdlrobson: Hygiene: Panels should not automatically be appended to DOM [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) [20:29:06] (03PS7) 10Jdlrobson: Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 [20:29:26] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1213579 (10Mholloway) a:3Mholloway [20:33:07] (03Merged) 10jenkins-bot: Make Special:Gather show pages for that user [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204620 (owner: 10Jdlrobson) [20:33:24] (03PS2) 10Jdlrobson: Hygiene: Make it possible to edit a collection from any page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204162 [20:33:33] (03PS3) 10Jdlrobson: Hygiene: Make it possible to edit a collection from any page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204162 [20:36:56] matanya: I've tried the article you mentioned but I don't see it go to the end of the article by itself. (I even switched my device to Hebrew). What device and OS version are you seeing this on? [20:37:08] 3Gather Sprint Forward: Deleting a collection doesn't close editor overlay - https://phabricator.wikimedia.org/T96294#1213591 (10Jdlrobson) 3NEW [20:37:25] (03CR) 10Jdlrobson: [C: 032] Split out dialog from collection delete overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204609 (owner: 10Robmoen) [20:37:31] (03PS3) 10Jdlrobson: Hygiene: Split out dialog from collection delete overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204609 (owner: 10Robmoen) [20:37:40] (03PS4) 10Jdlrobson: Hygiene: Split out dialog from collection delete overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204609 (owner: 10Robmoen) [20:37:44] (03CR) 10Jdlrobson: [C: 031] Hygiene: Split out dialog from collection delete overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204609 (owner: 10Robmoen) [20:37:49] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out dialog from collection delete overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204609 (owner: 10Robmoen) [20:38:28] rmoen: can you quickly get https://phabricator.wikimedia.org/T95635 wrapped up [20:38:29] seems super minor [20:38:41] ya [20:38:54] cheers dude [20:39:43] vibha: any comments for https://phabricator.wikimedia.org/T95070? [20:40:08] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split out dialog from collection delete overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204609 (owner: 10Robmoen) [20:41:04] (03PS4) 10Robmoen: Add moderation expectations to Special:GatherLists for admins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 [20:42:07] (03PS3) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [20:45:22] 3Gather Sprint Forward, 6Mobile-Web: Hide chrome status bar when overlays are open - https://phabricator.wikimedia.org/T96297#1213622 (10Jdlrobson) 3NEW a:3Jdlrobson [20:49:26] coreyfloyd: https://phabricator.wikimedia.org/T94534 "Select icon file based on build type (alpha, beta, etc) on build server" have actually seen the correct icon anywhere? [20:50:59] coreyfloyd: I checked 4..1.1(85) - first when I just updated, then I un-installed and installed again - the icon seems unchanged - sigh... [20:51:57] 10Wikipedia-iOS-App, 3Mobile App Sprint 52 - iOS, 3Roadmap, 7notice, 7user-notice: Production release for iOS Wikipedia app on Wednesday 15th April 2015 @ 9:15am Pacific - https://phabricator.wikimedia.org/T86692#1213646 (10gpaumier) 5Open>3Resolved Per [[ https://itunes.apple.com/us/app/id324715238... [21:02:37] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Mobile VE - Cite dialogue fields are buggy - https://phabricator.wikimedia.org/T91849#1213677 (10Jdforrester-WMF) a:3Mooeypoo [21:02:49] 6Mobile-Web: [placeholder] Promote alpha header to beta - https://phabricator.wikimedia.org/T96173#1213678 (10JKatzWMF) @jdlrobson 2 things have changed thinking here. 1. turns out we can launch the search+menu header without a new page load (this was the deal-breaker for current alpha header). Given that, I w... [21:11:49] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Mobile Web Block Warning - https://phabricator.wikimedia.org/T96257#1213705 (10EoRdE6) @Jdlrobson Anonymous at the time (thankfully I don't have a blocked account to test that). [21:16:37] (03PS2) 10Mholloway: Remove comma from collapsed table chrome [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204339 (https://phabricator.wikimedia.org/T96179) [21:17:30] (03CR) 10Mhurd: "Down with superfluous commas!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204339 (https://phabricator.wikimedia.org/T96179) (owner: 10Mholloway) [21:18:50] mhurd: if there's one thing i want people to say after they use the app, it's "i didn't see a single superfluous comma" [21:19:00] lol [21:19:35] lol [21:20:36] (03CR) 10BearND: [C: 032] Remove comma from collapsed table chrome [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204339 (https://phabricator.wikimedia.org/T96179) (owner: 10Mholloway) [21:20:40] 3Gather Sprint Forward, 6Mobile-Web: Hide chrome status bar when overlays are open - https://phabricator.wikimedia.org/T96297#1213779 (10Jdlrobson) It looks like as of iOS 7 the scrollTo hack stopped working. Not sure if this is actually possible anymore. Moiz do you know any web pages that seem to be pulling... [21:21:13] (03Merged) 10jenkins-bot: Remove comma from collapsed table chrome [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204339 (https://phabricator.wikimedia.org/T96179) (owner: 10Mholloway) [21:21:25] etonkovidova: sorry - been fixing bugs on the release… will look into that in a little while [21:21:31] etonkovidova: wtf! [21:21:55] coreyfloyd:exactly - sigh again... [21:22:03] etonkovidova: we made a lot of server changes… we probabaly need to reinstall the image tools [21:22:36] coreyfloyd: need to do another build for that? [21:22:59] etonkovidova: to install the tools? [21:26:02] (03PS4) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [21:27:12] (03PS1) 10Mooeypoo: Correctly use promise in .then() to load VE modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204634 [21:27:54] (03CR) 10Jdlrobson: [C: 031] Hygiene: Split out dialog from collection delete overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204609 (owner: 10Robmoen) [21:27:59] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out dialog from collection delete overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204609 (owner: 10Robmoen) [21:28:09] (03CR) 10Jforrester: [C: 032] Correctly use promise in .then() to load VE modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204634 (owner: 10Mooeypoo) [21:30:28] (03PS1) 10Jdlrobson: Swap X button for arrow for editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204635 (https://phabricator.wikimedia.org/T95776) [21:31:11] (03Merged) 10jenkins-bot: Hygiene: Split out dialog from collection delete overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204609 (owner: 10Robmoen) [21:31:13] (03Merged) 10jenkins-bot: Correctly use promise in .then() to load VE modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204634 (owner: 10Mooeypoo) [21:34:17] etonkovidova: its definitely broke - I know why - it works if we build locally, but not when we make builds for distribution - face/palm. I will fix, but will be later tonight, feel free to put back into the todo column [21:35:48] coreyfloyd: good that you know why it's broken :) Yes, moving it to Doing column [21:37:32] etonkovidova: thanks and sorry… should have tested that - duh [21:37:57] coreyfloyd: no worries :) [21:45:30] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1213868 (10Vibhabamba) Signed off by Design. Tested this single instance only. [21:52:38] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1213903 (10Vibhabamba) Good to go, signed off by Design. [21:54:32] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Stray info boxes at the bottom the tel aviv article - https://phabricator.wikimedia.org/T95513#1213914 (10Vibhabamba) Good to go, Signed off by Design. [21:57:41] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Fix for extra whitespace around small images regression - https://phabricator.wikimedia.org/T95738#1213930 (10Vibhabamba) Signedoff by Design. [22:01:37] (03PS1) 10Jdlrobson: Make edits to title and description instanenous [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204642 (https://phabricator.wikimedia.org/T95776) [22:01:39] (03PS1) 10Jdlrobson: Change button label for edit button in edit collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204643 (https://phabricator.wikimedia.org/T95776) [22:02:11] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Prompt user before starting data migration - https://phabricator.wikimedia.org/T96280#1213973 (10Mhurd) a:5Mhurd>3BGerstle-WMF [22:04:56] (03PS13) 10Bmansurov: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [22:05:21] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1213990 (10Vibhabamba) >>! In T95070#1195028, @Mholloway wrote: > Pinging @vibhabamba for comment, as requested. :) What do you think of these error message... [22:06:25] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [22:07:02] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1213994 (10Vibhabamba) >>! In T95070#1209736, @Mholloway wrote: > Here's how I have it looking at the moment when a server error code is available. > > {F11... [22:07:57] (03PS14) 10Bmansurov: Alpha: Load banner images on page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) [22:11:05] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1213998 (10bearND) @Vibhabamba The intention of the second line is to provide some more details and diagnostics. This should also help us when troubleshootin... [22:17:12] (03CR) 10Jdlrobson: "Why has this been restored. What has changed in the approach?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [22:19:46] (03PS2) 10BearND: Prevent action bar from reverting to black on new page load if lead image is available [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204534 (https://phabricator.wikimedia.org/T95067) (owner: 10Mholloway) [22:22:18] 10Wikipedia-iOS-App: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1214045 (10Etonkovidova) 3NEW [22:22:20] 10Wikipedia-iOS-App: Fact cards, which have no specific text selected, should always carry the first sentence of the article. - https://phabricator.wikimedia.org/T96312#1214052 (10Vibhabamba) 3NEW a:3dr0ptp4kt [22:22:44] (03CR) 10BearND: [C: 032] Prevent action bar from reverting to black on new page load if lead image is available [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204534 (https://phabricator.wikimedia.org/T95067) (owner: 10Mholloway) [22:23:27] (03CR) 10Bmansurov: "@jdlrobson, I was under impression that you and @phuedx had a conversation. As for what has changed, banner images now work for people wit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [22:23:27] 10Wikipedia-iOS-App: Fact cards, which have no specific text selected, should always carry the first sentence of the article. - https://phabricator.wikimedia.org/T96312#1214070 (10Vibhabamba) [22:23:29] (03Merged) 10jenkins-bot: Prevent action bar from reverting to black on new page load if lead image is available [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204534 (https://phabricator.wikimedia.org/T95067) (owner: 10Mholloway) [22:26:46] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: As a user I want to get quick context about a link. A combination of text and image will help me learn. (Prototype 1) - https://phabricator.wikimedia.org/T95030#1214081 (10bearND) a:... [22:27:11] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Remove comma from collapsed table chrome - https://phabricator.wikimedia.org/T96179#1214082 (10bearND) a:5Mhurd>3Mholloway [22:27:35] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6CA-team, 10MediaWiki-API, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1214084 (10bearND) a:3Dbrant [22:30:11] (03PS1) 10Fjalapeno: Fix change logs - git not using the proper path to the repo. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204651 [22:36:13] (03CR) 10Kaldari: [C: 032] "Seems to be a better idea. Wasn't able to test due to my vagrant instance being borked :(" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203345 (https://phabricator.wikimedia.org/T94445) (owner: 10Phuedx) [22:37:50] (03PS2) 10Jdlrobson: Make edits to title and description instanenous [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204642 (https://phabricator.wikimedia.org/T95776) [22:37:52] (03PS2) 10Jdlrobson: Change button label for edit button in edit collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204643 (https://phabricator.wikimedia.org/T95776) [22:37:54] (03PS1) 10Jdlrobson: Save changes to members of collection only when done clicked [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) [22:38:35] (03PS2) 10Jdlrobson: Save changes to members of collection only when done clicked [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) [22:39:53] (03Merged) 10jenkins-bot: Replace existing WikiGrok questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/203345 (https://phabricator.wikimedia.org/T94445) (owner: 10Phuedx) [22:40:43] (03PS1) 10Bmansurov: Aligh the version 'c' dialog in the middle of the page [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204660 [22:40:51] (03CR) 10jenkins-bot: [V: 04-1] Save changes to members of collection only when done clicked [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [22:41:50] (03CR) 10Bmansurov: "Corresponding change in WikiGrok: Ida0a26e59a6eef10855e9df83b635e104760f2ac" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) (owner: 10Jdlrobson) [22:43:00] (03CR) 10Bmansurov: [C: 031] "I can't merge the change in WikiGrok, and naturally I can't merge this either. But this patch looks good." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) (owner: 10Jdlrobson) [22:44:12] (03CR) 10Jdlrobson: [C: 031] Aligh the version 'c' dialog in the middle of the page [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204660 (owner: 10Bmansurov) [22:46:39] (03CR) 10Kaldari: [C: 04-1] "Breaks the spinning of the watchstar. (I assume that isn't intentional.)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [22:51:15] (03CR) 10Bmansurov: Add button abstraction (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [22:54:44] (03PS1) 10Jdlrobson: Hygiene: Refactor how watchstar works [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204662 [23:02:33] (03PS26) 10Jdlrobson: Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) [23:02:39] (03PS5) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [23:03:19] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 (owner: 10Jdlrobson) [23:03:45] jdlrobson, -operations [23:06:24] mhurd: looks like you guys are on a call [23:06:56] mhurd: I left mushroom kingdom - hanging on the couch next to you [23:07:26] vibha: ah! sorry! one minute [23:07:27] (03PS3) 10Robmoen: Return listpages results in query object [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 [23:09:08] (03PS1) 10Legoktm: Error in regex broke User lists pages [extensions/Gather] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204663 (https://phabricator.wikimedia.org/T96245) [23:09:19] (03CR) 10Legoktm: [C: 032] Error in regex broke User lists pages [extensions/Gather] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204663 (https://phabricator.wikimedia.org/T96245) (owner: 10Legoktm) [23:10:41] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [23:13:14] (03Merged) 10jenkins-bot: Error in regex broke User lists pages [extensions/Gather] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204663 (https://phabricator.wikimedia.org/T96245) (owner: 10Legoktm) [23:13:38] (03CR) 10Kaldari: [C: 032] Hygiene: Use mw-ui-icon in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [23:14:28] (03PS6) 10Kaldari: Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 (owner: 10Jdlrobson) [23:17:14] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 (owner: 10Jdlrobson) [23:17:31] 6Mobile-Web, 3Mobile-Web-Design: Give header a max-width so that it is more connected to content on tablet + desktop - https://phabricator.wikimedia.org/T96317#1214189 (10KHammerstein) 3NEW [23:18:04] (03PS4) 10Robmoen: Return listpages results in query object [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 [23:18:11] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 (owner: 10Jdlrobson) [23:19:59] (03PS1) 10Jdlrobson: Make the private checkbox to be a public checkbox [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204667 (https://phabricator.wikimedia.org/T93391) [23:20:01] (03PS1) 10Jdlrobson: Support making collections private [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204668 (https://phabricator.wikimedia.org/T94257) [23:20:08] 10Gather, 3Gather Sprint Forward: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1214210 (10Jdlrobson) [23:20:24] 10Gather, 3Gather Sprint Forward: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1214215 (10Jdlrobson) a:3Jdlrobson [23:20:28] 10Gather, 3Gather Sprint Forward: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1214216 (10rmoen) a:3rmoen [23:20:40] 10Gather, 3Gather Sprint Forward: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1158276 (10Jdlrobson) [23:21:09] 10Gather, 3Gather Sprint Forward: API: Log when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1214220 (10Jdlrobson) a:3Jdlrobson [23:22:51] (03CR) 10jenkins-bot: [V: 04-1] Support making collections private [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204668 (https://phabricator.wikimedia.org/T94257) (owner: 10Jdlrobson) [23:23:24] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1214223 (10Niedzielski) In addition to the described task, what about making the versionName largely derivable from the versionCode? Consid... [23:26:08] 3Gather Sprint Forward: Bug: Show/hide actions not showing correct toast message - https://phabricator.wikimedia.org/T96319#1214244 (10Jdlrobson) 3NEW [23:26:41] (03PS1) 10Jdlrobson: Correct error handling for hide/show admin actions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204670 (https://phabricator.wikimedia.org/T96319) [23:29:49] 6Mobile-Web: Identify initial wikidata properties to be used for 'category' test - https://phabricator.wikimedia.org/T94714#1214259 (10kaldari) San Francisco Landmarks: {F115331} 20th Century Politicians: {F115332} [23:30:01] (03PS1) 10Jdlrobson: Make Special:Gather show pages for that user [extensions/Gather] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204671 [23:30:30] (03CR) 10Legoktm: [C: 032] Make Special:Gather show pages for that user [extensions/Gather] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204671 (owner: 10Jdlrobson) [23:31:03] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: On edit collection overlay, the box is labeled "public" instead of private - https://phabricator.wikimedia.org/T93391#1214272 (10Jdlrobson) a:3Jdlrobson [23:31:35] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1214273 (10kaldari) 20th Century Politicians: {F115333} San Francisco Landmarks: {F115334} [23:32:44] (03Merged) 10jenkins-bot: Make Special:Gather show pages for that user [extensions/Gather] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204671 (owner: 10Jdlrobson) [23:44:30] (03CR) 10Kaldari: [C: 032] Hygiene: Remove dormant icon classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 (owner: 10Jdlrobson) [23:45:29] 6Mobile-Web: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1214327 (10JKatzWMF) [23:45:30] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Generate list of wikipedia entities (articles) for which identified tags T94714 apply - https://phabricator.wikimedia.org/T94732#1214325 (10JKatzWMF) 5Open>3Resolved Awesome! [23:49:07] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Right-align right-to-left languages in Wikipedia language setting menu - https://phabricator.wikimedia.org/T95895#1214333 (10bearND) @Mholloway We've got a task for the font issues: T71184. Please add your info regarding this to that... [23:51:26] 6Mobile-Web: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1214342 (10JKatzWMF) There are 4000 pages, in 8 groups, if that helps with the decision NBA All Stars 400 American Politicians 818 Object-Oriented Programming Langua... [23:53:09] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1214343 (10JKatzWMF) @phuedx, great! Do you need a list of tags? The desired display is slightly different than the category name in some places. Category:National Basketball Ass... [23:53:56] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203457 (owner: 10Jdlrobson) [23:54:05] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1214344 (10JKatzWMF) @khammerstein do you need to make a mock that shows the tags below the lead section? I think that location is probably what we wan to go with.