[00:01:33] jdlrobson: Here’s what I’m doing in Thanks: $target = $recipient->getUserPage(); $logEntry->setTarget( $target ); [00:01:56] jdlrobson: Then… [00:02:03] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.0.7.10 articles in Recent do not display thumbnail images - https://phabricator.wikimedia.org/T95114#1214361 (10Vibhabamba) Signed off by design [00:02:04] $logId = $logEntry->insert(); $logEntry->publish( $logId, 'udp' ); [00:04:40] jdlrobson: extensions/Thanks/ThanksLogFormatter.php [00:04:46] (03CR) 10BearND: [C: 04-1] "Almost there. I would like to see a layout issue fixed, though." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203947 (https://phabricator.wikimedia.org/T95895) (owner: 10Mholloway) [00:06:13] (03PS2) 10Jdlrobson: Correct error handling for hide/show admin actions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204670 (https://phabricator.wikimedia.org/T96319) [00:06:16] (03PS1) 10Jdlrobson: Add url Special:Gather/id/{id} number [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204679 [00:06:17] (03PS1) 10Jdlrobson: Write log entries for showlist and hidelist to Special:Log [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204680 (https://phabricator.wikimedia.org/T95250) [00:06:54] (03PS10) 10BearND: [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [00:07:02] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202089 (https://phabricator.wikimedia.org/T95619) (owner: 10Jdlrobson) [00:08:07] (03CR) 10Kaldari: [C: 032] Hygiene: Refactor how watchstar works [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204662 (owner: 10Jdlrobson) [00:08:54] (03CR) 10Yurik: Make Special:Gather show pages for that user (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204620 (owner: 10Jdlrobson) [00:10:49] (03Merged) 10jenkins-bot: Hygiene: Refactor how watchstar works [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204662 (owner: 10Jdlrobson) [00:16:54] (03PS2) 10Jdlrobson: Write log entries for showlist and hidelist to Special:Log [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204680 (https://phabricator.wikimedia.org/T95250) [00:18:21] 6Mobile-Web, 7Epic, 7Performance: Continuously measure mobile site speed - https://phabricator.wikimedia.org/T94752#1214407 (10JKatzWMF) [00:18:22] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Spike (4 hours): Investigate existing site speed metrics - https://phabricator.wikimedia.org/T95296#1214406 (10JKatzWMF) 5Open>3Resolved [00:18:29] (03PS3) 10Jdlrobson: Write log entries for showlist and hidelist to Special:Log [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204680 (https://phabricator.wikimedia.org/T95250) [00:19:44] (03PS2) 10Jdlrobson: Support making collections private [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204668 (https://phabricator.wikimedia.org/T94257) [00:19:58] (03PS5) 10Jdlrobson: Hygiene: Panels should not automatically be appended to DOM [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) [00:20:17] (03PS6) 10Jdlrobson: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 [00:20:24] (03PS5) 10Jdlrobson: Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 [00:23:53] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1214410 (10kaldari) I was able to confirm the bug in Firefox for Android. After typing a couple characters, it starts doing a search, and then... [00:23:58] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1214411 (10JKatzWMF) 3NEW [00:25:36] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1214419 (10kaldari) Best thing to try now would probably be a git bisect to see when the bug was introduced. [00:28:07] (03CR) 10Yurik: [C: 032] Return listpages results in query object [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 (owner: 10Robmoen) [00:28:57] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1214420 (10Ragesoss) My guess is that I first noticed it a month ago, or thereabouts. It took a while to crystallize in my mind as not just me... [00:29:25] (03CR) 10Jdlrobson: [C: 04-1] Add moderation expectations to Special:GatherLists for admins (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 (owner: 10Robmoen) [00:29:57] (03Merged) 10jenkins-bot: Return listpages results in query object [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203461 (owner: 10Robmoen) [00:30:45] 6Mobile-Web, 3Mobile-Web-Design: Search results max-width - https://phabricator.wikimedia.org/T96327#1214425 (10KHammerstein) 3NEW [00:32:42] 6Mobile-Web, 5Patch-For-Review: Watchstars not aligned in search - https://phabricator.wikimedia.org/T91178#1214437 (10Jdlrobson) 5Open>3Resolved [00:32:52] 10Gather: Promote Gather to stable - https://phabricator.wikimedia.org/T94233#1214440 (10Jdlrobson) [00:32:54] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Promote mw-ui-icon to stable - https://phabricator.wikimedia.org/T95619#1214438 (10Jdlrobson) 5duplicate>3Resolved a:3Jdlrobson [00:33:37] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Incorrect result for listpages module - https://phabricator.wikimedia.org/T94124#1214442 (10Jdlrobson) 5Open>3Resolved [00:34:33] 6Mobile-Web: Mobile search in Firefox repeats first letters - https://phabricator.wikimedia.org/T91771#1214452 (10JKatzWMF) @bmansurov Great, thanks! [00:39:19] 6Mobile-Web, 3Mobile-Web-Design: Max-width for overlays (search, talk) - https://phabricator.wikimedia.org/T96327#1214465 (10KHammerstein) [00:44:22] 6Mobile-Web, 3Mobile-Web-Design: Max width for special pages (watchlist, nearby) - https://phabricator.wikimedia.org/T96332#1214477 (10KHammerstein) 3NEW [00:44:37] 6Mobile-Web, 3Mobile-Web-Design: Give header a max-width so that it is more connected to content on tablet + desktop - https://phabricator.wikimedia.org/T96317#1214483 (10KHammerstein) [00:45:45] 6Mobile-Web, 3Mobile-Web-Design: Give header a max-width so that it is more connected to content on tablet + desktop - https://phabricator.wikimedia.org/T96317#1214189 (10KHammerstein) [00:46:22] 6Mobile-Web, 3Mobile-Web-Design: Max width for special pages (watchlist, nearby) - https://phabricator.wikimedia.org/T96332#1214477 (10KHammerstein) [00:47:03] 6Mobile-Web, 3Mobile-Web-Design: Max-width for overlays (search, talk) - https://phabricator.wikimedia.org/T96327#1214425 (10KHammerstein) [00:47:31] 6Mobile-Web, 3Mobile-Web-Design: Max width for special pages (watchlist, nearby) - https://phabricator.wikimedia.org/T96332#1214477 (10KHammerstein) [00:50:24] 6Mobile-Web, 3Mobile-Web-Design: Max-width for overlays (search, edit, talk) - https://phabricator.wikimedia.org/T96327#1214502 (10KHammerstein) [00:52:16] coreyfloyd: can't find the new stuff in the current alpha. [00:53:38] 10Gather: Escape out of overlays on desktop with escape key - https://phabricator.wikimedia.org/T96333#1214505 (10JKatzWMF) 3NEW [00:54:50] https://usercontent.irccloud-cdn.com/file/wKvutrTM/IMG_8512.PNG [00:55:01] coreyfloyd: ^ see this image [01:05:03] vibha: i responded on other channels… let me know if you can find the experimental build [01:06:06] coreyfloyd: [01:06:20] Searched my email, can't find anything [01:06:39] vibha: let me double check [01:08:08] vibha search for “iTunes connect" [01:08:32] 6Mobile-Web, 3Mobile-Web-Design: Max-width for overlays (search, edit, talk) - https://phabricator.wikimedia.org/T96327#1214563 (10KHammerstein) [01:08:46] vibha: you are listed as invited… i found the email for myself - from like noon est [01:09:02] vibha: while you are look I’m trying to figure out how to resent the invite [01:10:10] vibha: ok i resent the invite… old one may not work now [01:10:33] 6Mobile-Web: When using language overlay in minerva, selecting another language takes me to desktop wikipedia - https://phabricator.wikimedia.org/T96336#1214574 (10KHammerstein) 3NEW [01:11:33] https://usercontent.irccloud-cdn.com/file/NKe7EYlu/IMG_8513.PNG [01:11:40] coreyfloyd: ^ [01:11:46] invalid invite error [01:12:20] is this the new one? [01:12:25] or the old one? [01:12:29] vibha: ^ [01:23:30] New one [01:23:40] You sent it at 6:10 pm. [01:32:04] Strange [01:32:16] Wait! It worked [01:32:22] coreyfloyd: I have it now [01:37:21] vibha: cool [01:37:28] vibha: you want to hangout? [02:31:20] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1214643 (10NiharikaKohli) @Jdlrobson, @Nicolas_Raoul Not sure you're getting the melange emails. We need your... [02:39:20] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1214646 (10Nicolas_Raoul) I was receiving many emails about totally unrelated projects so I unsubscribed, thi... [02:51:45] 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1214652 (10NiharikaKohli) @Nicolas_Raoul This is a one time thing, I believe. You can see the relevant discus... [03:39:09] (03PS1) 10Fjalapeno: Fixing icons… again [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204703 [04:15:18] 10Gather, 3Gather Sprint Forward: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1214684 (10Yurik) Ahem, I didn't say the routing was slow, I only said that that specific code was slow compared to doing direct string comparison. I evaluate each operation by itself here )) I... [04:32:24] 10Wikipedia-Android-App: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1214685 (10Niedzielski) 3NEW [04:56:36] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Mobile Web Block Warning - https://phabricator.wikimedia.org/T96257#1214712 (10Rdicerb) Thank you so much for making this ticket @EoRdE6! Making sure this is on @Moushira's radar [05:42:27] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Mobile Web Block Warning - https://phabricator.wikimedia.org/T96257#1214744 (10Florian) a:3Florian If the user isn't logged in, the editor don't know, if the user is blocked from editing or not (it's a bit more difficult as it sounds because of another c... [05:42:37] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Mobile Web Block Warning - https://phabricator.wikimedia.org/T96257#1214746 (10Florian) p:5Normal>3High [08:23:04] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Mobile Web Block Warning - https://phabricator.wikimedia.org/T96257#1214879 (10Florian) With the change following, you will see a toast notice with the information, that your account was blocked with the info who made this block and with which reason. {F11... [08:43:24] (03PS1) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [08:44:06] (03CR) 10Jhernandez: [C: 032] Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [08:48:23] (03Merged) 10jenkins-bot: Add support to deprecate a module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202069 (owner: 10Florianschmidtwelzow) [08:48:24] (03CR) 10jenkins-bot: [V: 04-1] Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [08:55:12] (03Abandoned) 10Florianschmidtwelzow: Add link to history page, if the user can't edit a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202424 (https://phabricator.wikimedia.org/T95305) (owner: 10Florianschmidtwelzow) [08:57:19] 6Mobile-Web: MobileFrontend should show the correct reason, why a user can't edit a page - https://phabricator.wikimedia.org/T96352#1214896 (10Florian) 3NEW a:3Florian [08:59:16] (03CR) 10Jhernandez: [C: 032] Redirect to canonical url for Gather pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204624 (https://phabricator.wikimedia.org/T96151) (owner: 10Jdlrobson) [09:01:40] (03Merged) 10jenkins-bot: Redirect to canonical url for Gather pages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204624 (https://phabricator.wikimedia.org/T96151) (owner: 10Jdlrobson) [09:02:12] yo [09:10:58] BearND: nexus 5 android 4.4.4 [09:18:27] whatsaup [09:21:06] phuedx: i'm installing bare metal lamp mediawiki [09:21:11] living the crazy life [09:27:19] joakino: you're a rockstar [09:27:28] a ninja [09:27:46] gonna go have a quick pow wow with the builders [09:27:48] living la vida loca [09:27:50] brb [09:27:53] bb [09:27:53] HAHA [09:28:09] joakino: https://www.youtube.com/watch?v=p47fEXGabaY [09:28:36] haha [09:29:05] ricky reminds me to moiz [09:29:11] or the other way around haha [09:40:19] hahahaha [09:40:21] YES [09:41:20] mw-ui-icon got merged last night [09:41:23] when no one was looking! [09:41:25] j/k [09:41:26] \o/ [09:46:27] phuedx: lol [09:46:34] no issues right? [09:46:44] nobody cares [09:47:04] have you seen the remote email thread [09:47:07] chime in [09:47:20] i'm reading i'm reading [09:47:45] i'm still thinking about my response to the open web thread [09:47:54] haha [09:48:33] takes time [09:49:06] and it is mostly trying to spark a conversation before a decision is made with no tangible proof or idea of what the elite is thinking [09:56:19] a decision made with no feedback mechanism is dangerous, i agree [09:56:29] but i'm not sure that's the case here [09:56:56] i think that jdlrobson was right to get it off of his chest [09:57:01] and i'm glad we're having the conversation [09:57:15] but maybe the framing was a little off ;) [09:57:48] that won't be in my response b/c it's not relevant to the main content of the email [10:05:52] (03PS2) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [10:07:24] (03CR) 10jenkins-bot: [V: 04-1] Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [10:08:15] (03PS3) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [10:10:11] (03CR) 10jenkins-bot: [V: 04-1] Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [10:11:28] (03PS4) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [10:40:26] 6Mobile-Web, 10MobileFrontend, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Email confirmation workflow doesn't work correctly from a Mobile device - https://phabricator.wikimedia.org/T95065#1214976 (10phuedx) @kaldari: Did you start work on this? [11:32:38] gonna go have lunch with an old friend [11:34:53] 10Wikipedia-Android-App: app crashes when clicking the left hambuerger before main page is loaded - https://phabricator.wikimedia.org/T96358#1215029 (10Matanya) 3NEW [11:36:00] 10Wikipedia-Android-App: app crashes when clicking the left hambuerger (TOC) before main page is loaded - https://phabricator.wikimedia.org/T96358#1215036 (10Matanya) [11:39:21] 10Wikipedia-Android-App: Add css clear to "Read more" block - https://phabricator.wikimedia.org/T96359#1215041 (10liangent) 3NEW [13:29:24] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1215249 (10daniel) [13:32:39] backsies [13:33:14] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1215267 (10phuedx) [13:33:26] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1171571 (10phuedx) [13:36:42] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1215280 (10phuedx) @JKatzWMF: I can hard code the list but then I'll definitely have to stick it behind a feature flag. [13:39:25] (03PS3) 10Mholloway: Right-align entries for RTL languages in Wikipedia language menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203947 (https://phabricator.wikimedia.org/T95895) [13:42:59] 6Mobile-Web, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1215297 (10daniel) The thumbnail URL should probably not be part of the data value as such. I propo... [13:53:53] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1215316 (10Mholloway) @Vibhabamba If you look to the beginning of the comments on this task you'll see there's already been some discussion about this. I ha... [14:10:32] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Search should be hidden from the Saved Pages and History sections of the app if there are no saved pages or history entries - https://phabricator.wikimedia.org/T94974#1215359 (10Mholloway) 5Open>3Resolved [14:15:47] 10Wikipedia-Android-App: As a user, when I navigate to a page, I would like to see whether I have already saved that page. - https://phabricator.wikimedia.org/T96369#1215385 (10Mholloway) 3NEW [14:34:47] (03CR) 10Phuedx: [C: 032] Hygiene: Panels should not automatically be appended to DOM [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) (owner: 10Jdlrobson) [14:37:56] (03CR) 10Phuedx: [C: 032] Aligh the version 'c' dialog in the middle of the page [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204660 (owner: 10Bmansurov) [14:38:52] (03Merged) 10jenkins-bot: Hygiene: Panels should not automatically be appended to DOM [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204301 (https://phabricator.wikimedia.org/T96176) (owner: 10Jdlrobson) [14:39:43] (03Merged) 10jenkins-bot: Aligh the version 'c' dialog in the middle of the page [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204660 (owner: 10Bmansurov) [14:40:33] (03CR) 10Phuedx: [C: 032] Correctly identify the wikigrok version [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204556 (owner: 10Bmansurov) [14:42:20] (03Merged) 10jenkins-bot: Correctly identify the wikigrok version [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/204556 (owner: 10Bmansurov) [14:49:46] (03CR) 10Phuedx: "We haven't but we should. I should've reached out before now. Sorry Jon." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov) [14:53:46] 10Wikipedia-Android-App: app crashes when clicking the left hambuerger (TOC) before main page is loaded - https://phabricator.wikimedia.org/T96358#1215479 (10Krenair) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8263316 may be helpful [15:38:05] coffee time [15:49:43] 10Wikipedia-iOS-App: Support letting user save Share a Fact cards to their device - https://phabricator.wikimedia.org/T96381#1215642 (10Deskana) 3NEW [15:56:45] nom nom nom [16:06:21] (03CR) 10Phuedx: "I agree with Kaldari here. We all agreed that we shouldn't have a custom login page but have neither a plan nor a timeline for that. With " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [16:06:41] (03CR) 10Deskana: [C: 04-1] "Looking really nice. Good job!" (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway) [16:21:00] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Reuse image caption from the article in the image gallery, to increase continuity between article and image gallery - https://phabricator.wikimedia.org/T94495#1215771 (10Deskana) [16:33:36] 10Wikipedia-Android-App: Allow for more diagnostics of page loading issues - https://phabricator.wikimedia.org/T95182#1215798 (10bearND) OK, here are a few more thoughts about this. This could be a special build (alpha or a new flavor) we can send to specific people who experience issues. On the other end of the... [16:38:43] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (3 instances reported) MWKImageInfoFetcher fetchInfoForArticle - https://phabricator.wikimedia.org/T96206#1215819 (10BGerstle-WMF) [16:41:18] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (1 instance reported) main - https://phabricator.wikimedia.org/T96207#1215825 (10BGerstle-WMF) 5Open>3Invalid a:3BGerstle-WMF @dr0ptp4kt not sure which crash this refers to, please include a link to the report. [16:43:14] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash MWKImageInfoFetcher fetchInfoForArticle - https://phabricator.wikimedia.org/T96206#1215830 (10BGerstle-WMF) [16:51:28] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash MWKImageInfoFetcher fetchInfoForArticle - https://phabricator.wikimedia.org/T96206#1215911 (10BGerstle-WMF) a:3Fjalapeno [16:54:01] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash due to out-of-bounds exception in search - https://phabricator.wikimedia.org/T96254#1215933 (10BGerstle-WMF) [16:54:02] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash MWKImageInfoFetcher fetchInfoForArticle - https://phabricator.wikimedia.org/T96206#1215932 (10BGerstle-WMF) [16:54:04] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: NSNull unrecognized selector when deserializing sections - https://phabricator.wikimedia.org/T96255#1215934 (10BGerstle-WMF) [16:54:08] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when creating section objects after back/forward nav - https://phabricator.wikimedia.org/T96253#1215936 (10BGerstle-WMF) [16:54:10] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Prompt user before starting data migration - https://phabricator.wikimedia.org/T96280#1215935 (10BGerstle-WMF) [16:54:15] (03CR) 10Jkatz: "sounds good to me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/202424 (https://phabricator.wikimedia.org/T95305) (owner: 10Florianschmidtwelzow) [16:54:28] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [RELEASE] 4.1.1 hot-fix app update - https://phabricator.wikimedia.org/T96389#1215912 (10BGerstle-WMF) [16:56:05] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [RELEASE] 4.1.1 hot-fixes & migration tweaks - https://phabricator.wikimedia.org/T96389#1215943 (10BGerstle-WMF) [16:57:25] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [SPIKE] Reach out to users experiencing issues w/ 4.1.0 or who haven't updated yet - https://phabricator.wikimedia.org/T96391#1215946 (10BGerstle-WMF) 3NEW a:3dr0ptp4kt [16:58:21] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1215962 (10kaldari) a:3kaldari [17:01:31] (03PS4) 10BearND: Right-align entries for RTL languages in Wikipedia language menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203947 (https://phabricator.wikimedia.org/T95895) (owner: 10Mholloway) [17:02:33] (03CR) 10BearND: [C: 032] Right-align entries for RTL languages in Wikipedia language menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203947 (https://phabricator.wikimedia.org/T95895) (owner: 10Mholloway) [17:08:22] 10Wikipedia-Android-App: Bundle fonts for languages that are not supported natively. - https://phabricator.wikimedia.org/T71184#1215981 (10Mholloway) A couple of potentially helpful links from my looking into this issue over in T95895: Android: Find out which font file is appropriate for the characters I want t... [17:08:39] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [SPIKE] Try to reproduce crashes from 4.1.0 - https://phabricator.wikimedia.org/T96392#1215988 (10BGerstle-WMF) 3NEW a:3Etonkovidova [17:16:43] 10Wikipedia-iOS-App: Remove reference superscripts in share a fact cards. - https://phabricator.wikimedia.org/T95476#1216021 (10Deskana) p:5Triage>3High [17:16:52] 10Wikipedia-iOS-App: Remove reference superscripts in share a fact cards. - https://phabricator.wikimedia.org/T95476#1191718 (10Deskana) Let's fix this soon. :-) [17:17:06] 6Mobile-Web: MobileFrontend should show the correct reason, why a user can't edit a page - https://phabricator.wikimedia.org/T96352#1216025 (10phuedx) @Florian: Is this a dupe of T96257? [17:18:14] 6Mobile-Web: Image description is not inserted into the correct paragraph - https://phabricator.wikimedia.org/T93241#1216030 (10phuedx) [17:18:59] 6Mobile-Web: Image description is not inserted into the correct paragraph - https://phabricator.wikimedia.org/T93241#1132927 (10phuedx) I'm not sure why this got moved to the current sprint… [17:21:28] (03CR) 10Phuedx: "Jdlrobson: that's covered in SkinMinervaBeta#renderBrowseTags." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [17:22:24] 6Mobile-Web: MobileFrontend should show the correct reason, why a user can't edit a page - https://phabricator.wikimedia.org/T96352#1216046 (10Florian) @phuedx: Not directly, it sounds like the same, but in this task i will improve the error handling, mostly for logged in users, (to show the correct error for th... [17:23:10] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Editing block warning appears only after i tried to safe (for not-logged-in users) - https://phabricator.wikimedia.org/T96257#1216048 (10Florian) [17:23:35] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1216050 (10Deskana) What we have here is a massive improvement over what we had before, so it's got signoff from me. If the code's good, then let's merge, an... [17:24:42] Deskana: do you have any preference on where the "cancel migration" button should go? [17:25:58] (03CR) 10Phuedx: [C: 04-1] "This still needs to go behind a feature flag as it's an incomplete feature." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [17:26:47] bgerstle: Underneath the spinner and the "Upgrading local data" text is good. [17:27:03] gotchya [17:28:43] BRB [17:28:51] Or, be back soon [17:34:14] (03Merged) 10jenkins-bot: Right-align entries for RTL languages in Wikipedia language menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203947 (https://phabricator.wikimedia.org/T95895) (owner: 10Mholloway) [17:37:24] dr0ptp4kt did we move story prio to Monday? [17:37:45] Deskana: ^ [17:38:33] gonna break for 15 to have dinner [17:38:48] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1216119 (10phuedx) [17:48:15] vibha: Yep [17:48:43] Deskana: great. Thanks. [17:48:52] bearND: you had a question? [17:54:11] vibha: you got a sec? [17:54:33] Yeah [17:57:20] Hey Corey, I played with the prototype last night and this morning. [17:57:30] Prototype 1 is great [17:58:05] From the looks of it, you have a pretty decent fade in [17:58:26] the thing with prototype 2 is that since its lorem ipsum, im not actually reading the text, so I can't assess whether it is disruptive to fade the image in [17:58:41] Would it be possible to do any actual previews - even if its just one paragraph? [17:58:43] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7Mobile: action=history should not redirect to Special:History for Flow boards - https://phabricator.wikimedia.org/T93491#1216233 (10EBernhardson) p:5Triage>3High [17:58:49] I was putting all this in an email to send to you [17:58:49] vibha: yeah - i can get the previews in next [17:59:28] 10Wikipedia-iOS-App: Fact cards, which have no specific text selected, should always carry the first sentence of the article. - https://phabricator.wikimedia.org/T96312#1216241 (10Etonkovidova) Adding the share fact card from famous 'Barack Obama' article - beside the bug described by Vibhabamba, the text has &... [18:00:12] (03PS3) 10Mholloway: Display server status code & message to user in case of error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) [18:00:24] vibha: also you have a sec to hangout? I have something complicated to tell you [18:02:40] (03PS4) 10Mholloway: Display server status code & message to user in case of error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) [18:05:53] 10Wikipedia-iOS-App: Fact cards, which have no specific text selected, should always carry the first sentence of the article. - https://phabricator.wikimedia.org/T96312#1216267 (10Deskana) p:5Triage>3High [18:05:58] (03PS1) 10Florianschmidtwelzow: Improve error handling for "Editor not available" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) [18:07:21] coreyfloyd: Just give me one minute [18:07:29] responding to bearnd and then Ill ping you so we can hangout [18:07:49] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1216273 (10Mholloway) Screenshots with margins adjusted to address @Deskana's comments on Gerrit: {F116115} {F116117} [18:12:24] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1216280 (10Vibhabamba) Ok with us filing a separate task so we can track error message reporting. Improving this will take some time and you will miss your... [18:12:32] bearND: https://phabricator.wikimedia.org/T95070 [18:12:34] commented on this [18:12:47] vibha: thanks [18:13:33] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1216285 (10Deskana) 3NEW a:3Deskana [18:14:01] can you or mholloway set up a meeting for next week or whenever you guys think you will be ready with all current cases of error messaging? Doesn't have to be every single case but most of them would be good. [18:15:08] 6Mobile-Web: When using language overlay in minerva, selecting another language takes me to desktop wikipedia - bug - https://phabricator.wikimedia.org/T96336#1216296 (10KHammerstein) [18:15:19] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1216298 (10Vibhabamba) Proportionately decrease leading also - paste screenshots here and @msyed or I could comment. [18:15:22] (03PS1) 10Deskana: Slightly decrease minimum text size on Share a Fact cards. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204835 (https://phabricator.wikimedia.org/T96398) [18:16:31] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1216310 (10Deskana) After my patch (ignore the pixelation, that's the emulator I'm using): {F116125} [18:17:07] vibha: On this bug ^ [18:17:12] coreyfloyd: hangout now? [18:17:21] vibha: sure [18:17:33] vibha: I'm not sure what you meant by "Proportionately decrease leading also" [18:17:46] vibha: we really don't have much in the way of error messages now; just one an error on the user's network side ("could not reach the network, please try again") and one for a remote server error ("problem handling your request," now with error code/description if available). I think we'll have to discuss how specific and detailed we want to get when we meet. /cc bearND [18:18:14] mholloway: i see. ok. [18:18:28] Deskana: I have to meet coreyfloyd, get back to you after. [18:18:33] coreyfloyd: Sure. [18:19:40] 6Mobile-Web: When using language overlay in minerva, selecting another language takes me to desktop wikipedia - bug - https://phabricator.wikimedia.org/T96336#1216320 (10Florian) [18:19:42] 6Mobile-Web: "Read in another language" gives desktop site's links - https://phabricator.wikimedia.org/T67047#1216321 (10Florian) [18:24:54] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1216328 (10Deskana) >>! In T96398#1216298, @Vibhabamba wrote: > Proportionately decrease leading also I'm not sure what you mean. Ca... [18:25:36] bearND: do you have time to hop into the batcave and talk about https://phabricator.wikimedia.org/T94646? [18:26:17] mholloway: in a minute [18:26:26] bearND: k [18:27:51] bearND: i'm going to run and make myself a little more coffee, brb [18:28:01] mholloway: k [18:30:40] bearND: short question: It's intentional, that, if you logout from the android app, your saved pages will be deleted? (Haven't tested now, but there is a ticket in OTRS :)) [18:32:04] FlorianSW: No, it's definitely not intentional. If that's confirmed that's a bug. [18:32:18] bearND: ok, i'll test now :) [18:33:24] Deskana: regarding the type size bug. [18:33:59] iOS updates the line height automatically, but I just wanted to make sure leading/line height are proportionately reduced. [18:34:06] gonna head off for the evening folks -- i'm pooped [18:34:09] bearND: ah, ok, next time i test before i ask :D If i logout and login again (what the user describes), the saved pages are still saved :) [18:34:12] I'm not sure what the case is with the cards [18:34:38] vibha: I put a screenshot in the bug of how my patch changes things, does that look alright? [18:34:49] vibha: The line height will adjust with the font size. [18:35:44] Awesome [18:36:24] vibha: Here's an example: https://phabricator.wikimedia.org/T96398#1216310 [18:36:38] vibha: The quote fits in the card now. I changed the minimum the font size can go to from 38 to 32. [18:37:09] FlorianSW: No worries. It's ok to ask. Thanks for confirming. I do remember reading about this before in the store reviews. [18:37:13] dr0ptp4kt: Deskana do we have the 'strip reference superscript' bug fixed as well? [18:37:26] FlorianSW: It could be that it's specific to certain devices, but quite likely also to user behavior. If one hits "Clear data" in the app settings then saved pages are gone, too. [18:37:53] vibha: which ticket is this? [18:37:55] vibha: Not yet. They're working on fixing crashing bugs and issues with the data migration right now. But I've put the task in the "next sprint" column, and we may be able to get to it even sooner. [18:37:59] vibha: for which feature? [18:38:05] bearND: hmm, i suggested to reinstall the app from google play now, let's see, if this helps :) Ok, i'll ask that, if the problem is not solved :) [18:38:07] thanks [18:38:14] vibha, dr0ptp4kt: https://phabricator.wikimedia.org/T95476 [18:38:37] FlorianSW: This is why I keep pushing to be able to use Gather for apps saved pages. That way they would be synced with your account. [18:39:07] bearND: that would be a great thing! Isn't this possible with the watchlist api, too? [18:39:49] FlorianSW: Once the saved pages are associated with an account it's not a problem if the user hits clear data on a device. The list of saved pages still exists in the cloud and can be easily synced later. [18:40:22] Thanks Deskana [18:40:28] FlorianSW: Well, I hope we'll just use the same API for all kinds of collections [18:40:30] FlorianSW: Only if we muddle up the user's saved pages with their watchlist, which I really don't want to do. [18:40:34] vibha: the reference superscript is currently stripped for the default up arrow share button, but that heuristic is *not* applied for manual text selection shares...we should think about which of the heuristic components we'd want to use [18:40:56] vibha: for example, we may want to allow users to keep parens, but not reference brackets cc Deskana ^ [18:41:24] Deskana: hmm, yeah, that would be the problem, and maybe a user don't want to have all pages of the watchlist (which would be synchronized after logging in) on the local phoen storage [18:41:35] Reference brackets can definitely be removed [18:41:50] They are not actionable and they don't render like superscripts [18:41:58] 6Mobile-Web: Tapping on lead image should open image in mobile media viewer - https://phabricator.wikimedia.org/T96404#1216402 (10KHammerstein) 3NEW [18:41:58] vibha, dr0ptp4kt: Agreed, and I'd say strip brackets if they don't highlight anything, but don't strip brackets if they *do* highlight something [18:42:30] vibha, dr0ptp4kt: I'll note this in the task... [18:43:05] Wait, there's nothing for me to note. [18:43:06] Excellent. [18:56:48] kaldari: totally random question for you [18:58:42] kaldari: nvm, looks like you are busy [18:59:37] 10Wikipedia-iOS-App: Cannot share images using Messenger app - https://phabricator.wikimedia.org/T96420#1216529 (10Harej) 3NEW [19:01:00] vibha: ? [19:01:14] 10Wikipedia-iOS-App: Cannot share images using Messenger app - https://phabricator.wikimedia.org/T96420#1216537 (10Harej) [19:03:10] 10Wikipedia-iOS-App: Cannot share images using Messenger app - https://phabricator.wikimedia.org/T96420#1216542 (10Deskana) We've experienced issues similar to this on Android, where apps such as YouTube have improperly registered themselves as being able to handle images, and then they simply crash when they ge... [19:03:26] kaldari: if you have 5 mts can I discuss translation of last edited from mobile web with you? Have 2 quick questions. [19:04:04] Running into some translation challenges on hover cards [19:05:59] vibha: sure, I’ll come by your desk [19:08:04] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Allow for more diagnostics of page loading issues - https://phabricator.wikimedia.org/T95182#1216547 (10bearND) [19:21:13] kaldari: I'll talk to jk and kaity to file a ticket so web and desktop can be consistent. [19:29:40] Deskana|Away: vibha coreyfloyd dr0ptp4kt mhurd check out this PR for a GIF of the proof-of-concept cancellation flow: https://github.com/bgerstle/apps-ios-wikipedia/pull/10 [19:30:38] imma break for lunch o/ [19:39:47] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1216666 (10Ijon) Why does it mean we'd have to include a URL? Isn't the normal case more like adding "User:Kangaroo13" or "Tigla... [19:48:12] dr0ptp4kt: bgerstle_afk coreyfloyd grabbing lunch [19:48:32] k [19:48:52] mhurd: where are you on testing? and repros? [19:49:55] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1216714 (10Harej) Image attribution is harder than it sounds. This parallels a lot of the issues surrounding Commons metadata. W... [19:50:25] coreyfloyd: in the middle - have tested 2 of the old versions migrating to the current market release on 2 devices - no crashes thus far and over 100 pages migrated for each test on each device. will finish testing after foods [19:50:44] brb [19:50:52] mhurd: ok cool - thanks [19:51:03] dr0ptp4kt: any word on twitter peeps? [19:57:16] coreyfloyd: watchya up to? [19:58:28] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1216745 (10JeanFred) > This parallels a lot of the issues surrounding Commons metadata. Where would we draw the attribution data?... [20:01:13] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a user, I want to be able to cancel data migration - https://phabricator.wikimedia.org/T96429#1216755 (10BGerstle-WMF) 3NEW a:3BGerstle-WMF [20:01:15] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a user, I want to be able to cancel data migration - https://phabricator.wikimedia.org/T96429#1216755 (10BGerstle-WMF) PR's up here: https://github.com/bgerstle/apps-ios-wikipedia/pull/10 [20:03:09] 10Wikipedia-iOS-App: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1216768 (10BGerstle-WMF) Do you mean build 4.1.0? We haven't released 4.1.1 yet. If you intended to reference build 4.1.0, please update this and other tickets'... [20:04:51] 6Mobile-Web: Set button widths in drawers to be constrained to text instead of using block style - https://phabricator.wikimedia.org/T96430#1216788 (10KHammerstein) 3NEW [20:05:28] coreyfloyd: sorry, had to take a call [20:05:54] coreyfloyd: will look into it again. hadn't heard anything as of a half hour ago that i saw [20:05:57] heard/saw [20:07:58] bgerstle: looks good, is it better to leave comments here or on the github page? [20:08:17] everyone else is commenting on the github page, so i guess I'll go there so all the comments are in one place [20:08:29] vibha: depends, either is fine [20:08:37] vibha: if it's something requiring more back and forth, IRC works [20:08:46] but if it's a simple +1 or comment, GH works [20:08:54] * bgerstle side note: OMG DESIGN IS COMMENTING ON GH YOU GUYS [20:08:58] * bgerstle THEY WOULD NEVER DO THAT ON GERRIT!!! [20:11:23] so this is only when the user goes to Saved pages or Recent? [20:11:29] not when they download the app? [20:12:06] Copy could be more user friendly? Agree? [20:14:53] dr0ptp4kt: back! bat cave? [20:15:36] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6WMF-Legal: Share A Fact images do not include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1216833 (10Deskana) >>! In T91811#1216745, @JeanFred wrote: > Well, these questions have been hashed over and over with MediaView... [20:15:41] mhurd: good, elena there too? [20:15:52] dr0ptp4kt: ya [20:16:03] mhurd: word [20:27:08] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Editing block warning appears only after i tried to safe (for not-logged-in users) - https://phabricator.wikimedia.org/T96257#1216858 (10EoRdE6) @Florian Your screenshot says "You will not be able to safe your edit". Is that supposed t... [20:28:37] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Editing block warning appears only after i tried to safe (for not-logged-in users) - https://phabricator.wikimedia.org/T96257#1216874 (10Florian) @EoRdE6 You're right! My fault :) Thanks for the catch. [20:30:06] vibha you around? [20:39:09] Deskana: able to join the batcave? bgerstle, you able to come back? [20:42:26] dr0ptp4kt: I have 5 minutes, yeah. Joining. [20:49:41] Dentist time. Eugh. [21:00:06] coreyfloyd: back in 5, just had lunch meeting with jon Katz [21:02:23] coreyfloyd: here now [21:04:12] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [RELEASE] 4.1.1 hot-fixes & migration tweaks - https://phabricator.wikimedia.org/T96389#1217018 (10BGerstle-WMF) [21:04:14] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a user, I want to be able to cancel data migration - https://phabricator.wikimedia.org/T96429#1217019 (10BGerstle-WMF) [21:08:26] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [SPIKE] Try to reproduce crashes from 4.1.0 - https://phabricator.wikimedia.org/T96392#1217038 (10BGerstle-WMF) 5Open>3Resolved @Mhurd and @etonkovidova weren't able to reproduce any crashes. [21:08:28] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [RELEASE] 4.1.1 hot-fixes & migration tweaks - https://phabricator.wikimedia.org/T96389#1217041 (10BGerstle-WMF) [21:09:05] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1217043 (10kaldari) Looks like this bug was introduced by change Ibabfb5d (https://gerrit.wikimedia.org/r/#/c/185467/), which of course was a... [21:09:26] calling you on hangouts [21:09:41] coreyfloyd: old message, ignore [21:11:02] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1217060 (10bearND) @Deskana. I think she means the space between lines. I think we could do that by using a smaller spacing multiplie... [21:12:04] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [SPIKE] Try to reproduce crashes from 4.1.0 - https://phabricator.wikimedia.org/T96392#1217062 (10Mhurd) Aliana and I ran various data sets through the upgrade migration without being able to reproduce any of the crashes seen in HockeyApp. [21:14:01] coreyfloyd: is text color in the card (in prototype 2) determined by background white balance? [21:15:17] vibha: its a stock function i grabbed from elsewhere… basically it reduces the image down to a single pixel and then tajes that color, which should be the average. then it calculates the text color based on that [21:15:35] vibha: its something we could tweak [21:16:38] 6Mobile-Web, 10MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1217068 (10csteipp) @Jdlrobson, adding 'target' => array( 'desktop', 'mobile' ) is easy enough, but the autologin script eventually loads in... [21:20:07] rmoen jdlrobson on beta.wmflabs my collections are all private...whatsa going onna? [21:23:25] hi, is it possible to load minerva styles to external site? I can use the API to get the content itself with action=mobileview but it doesn't give minerva styles. I couldn't get it also from parse action [21:23:45] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Toast should clip long collection titles - https://phabricator.wikimedia.org/T93797#1217101 (10JKatzWMF) 5Open>3Resolved Good points! this is a non-issue [21:35:10] 3Gather Sprint Forward: when a user accidentally swipes left or right on the create collection overlay, the overlay freezes and they cannot scroll anymore - https://phabricator.wikimedia.org/T96445#1217167 (10JKatzWMF) 3NEW [21:36:34] coreyfloyd: got a few questions about prototype 2 - can we hangout quickly? [21:36:55] 3Gather Sprint Forward, 5Patch-For-Review: Url /by/User completely broken - https://phabricator.wikimedia.org/T96245#1217177 (10JKatzWMF) 5Open>3Resolved [21:37:25] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Redirect Special:Gather & friends to Special:Gather/by/User for sharing purposes - https://phabricator.wikimedia.org/T96151#1217181 (10JKatzWMF) 5Open>3Resolved [21:40:49] vibha: yeah [21:41:27] calling you [21:47:25] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1217205 (10kaldari) The two bugs fixed by change Ibabfb5d are T1159 and T1165. I tried reverting change Ibabfb5d and could no longer reproduce... [21:54:40] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [SPIKE] Reach out to users experiencing issues w/ 4.1.0 or who haven't updated yet - https://phabricator.wikimedia.org/T96391#1217239 (10BGerstle-WMF) @dr0ptp4kt would you write an update? i'm pretty sure we weren't able to get in touch w/ anyone, just want to be... [21:55:52] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Show a prompt with basic article data on link tap, which allows user to click through to the original link - https://phabricator.wikimedia.org/T95734#1217240 (10BGerstle-WMF) 5Open>3Resolved [21:57:06] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: HockeyApp crash reporting regression - https://phabricator.wikimedia.org/T96448#1217241 (10BGerstle-WMF) 3NEW a:3Fjalapeno [21:57:49] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [RELEASE] 4.1.1 hot-fixes & migration tweaks - https://phabricator.wikimedia.org/T96389#1217250 (10BGerstle-WMF) [21:59:30] (03PS1) 10Kaldari: Mostly reverting change Ibabfb5d [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204952 (https://phabricator.wikimedia.org/T95626) [22:00:24] coreyfloyd: switching context to work on the copy stuff. Will get back to you in 15 minutes [22:01:16] (03PS5) 10Mholloway: Display server status code & message to user in case of error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) [22:03:10] I'm alive! [22:03:12] Face not drilled in. Having mixed feelings about that. [22:03:24] Deskana: yay? [22:03:38] Deskana: batcave? [22:03:42] mhurd: Well, yes, but they also aren't really certain what the problem is. My symptoms are weird and inconsistent. [22:04:05] Deskana: it's scurvey [22:04:10] mhurd: Hah. [22:04:15] mhurd: Yes, to the batcave. [22:11:06] 10Wikipedia-iOS-App: Pull to refresh erases forward navigation history - https://phabricator.wikimedia.org/T96450#1217288 (10BGerstle-WMF) 3NEW [22:15:47] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Merge 4.1.1 hot-fixes into master - https://phabricator.wikimedia.org/T96452#1217311 (10BGerstle-WMF) 3NEW [22:16:10] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Merge 4.1.1 hot-fixes into master - https://phabricator.wikimedia.org/T96452#1217319 (10BGerstle-WMF) [22:16:12] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [RELEASE] 4.1.1 hot-fixes & migration tweaks - https://phabricator.wikimedia.org/T96389#1217320 (10BGerstle-WMF) [22:17:16] bgerstle: talk super quick? I have new copy for you [22:17:50] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Editing block warning appears only after i tried to save (for not-logged-in users) - https://phabricator.wikimedia.org/T96257#1217322 (10Nemo_bis) [22:20:23] vibha: sorry just stepped out. We're going to do the cancel thing next week after these crash fixes are out. It's the safe thing to do. Can you update the phab ticket or comment on the PR? [22:21:44] By PR you mean the github prototype? [22:21:50] So this isn't going out right now? [22:23:03] yes, ok. Agree with you. [22:28:10] mhurd: Did you call me again? [22:28:34] Deskana: no [22:28:57] mhurd: Weird. Google Hangouts does that sometimes. [22:29:20] Deskana: i don't think i accidentally re-called... [22:34:39] bgerstle: I'll update my notes on Github & Phab [22:34:55] dr0ptp4kt: batcave? [22:37:28] mhurd: still on call [22:37:30] Deskana: are you around in the office? [22:37:35] mhurd: new call [22:37:44] mhurd: what's the current status? [22:37:52] vibha: No, I'm at home. Had a dentist appointment. Want to hang out quickly? [22:38:12] yeah [22:38:27] dr0ptp4kt: new patch was merged into Brian's branch. Fixes the issue Alaina discovered. Good to go [22:38:54] vibha: Calling you. [22:40:33] mhurd: heck ya [22:41:33] dr0ptp4kt: ya just pull the latest and cut the release :) [22:43:52] dr0ptp4kt: https://github.com/bgerstle/apps-ios-wikipedia/pull/12 [22:44:01] dr0ptp4kt: quick text update form vibha [22:44:14] before you deploy [22:44:51] dr0ptp4kt: mhurd ol - im really stepping out for a bit this time… [22:45:02] dr0ptp4kt: hit me up if you need anything [22:45:06] coreyfloyd: k [22:45:09] coreyfloyd: thx! [22:45:26] vibha: i really like the changes to the update dialog copy! [22:45:40] nice thank you! [22:46:31] vibha just pushed your latest [22:46:52] thank you thank you [22:46:57] dr0ptp4kt: vibha had one more change, it is already up on github: https://github.com/bgerstle/apps-ios-wikipedia/pull/12 [22:47:32] Deskana: thanks for the quick review [22:47:40] http://truegif.com/pictures/gif/4302.gif [22:48:26] what a day [22:48:36] vibha: mhurd catch you on the flip side [22:50:18] coreyfloyd mhurd I earlier proposed 'Brewing sunshine and happiness' [22:50:33] vibha: +1 [22:50:47] dr0ptp4kt: "3446f80 2015-04-17 3 minutes ago Merge pull request #12 from bgerstle/feature/text-alert" [22:50:57] But then i figured that thought that copy was a little too cats and kittens [22:51:24] vibha: haha we should have used kitty emojii [22:51:49] omg! neat idea. Throw in an emoji someone. [22:52:23] vibha: this one for errors: 💩 [22:52:34] haha [22:52:58] Switching context to Hovercards. Call for help: Anyone who speaks greek on IRC right now? Hovercards team needs some help. [22:53:02] vibha: it has a "don't worry be happy" vibe. it's poo, but look, he's smiling! [22:53:35] heh, totally. [22:54:16] brb [22:56:41] vibha: Always. :-) [22:58:10] 6Mobile-Web, 10MobileFrontend, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Email confirmation workflow doesn't work correctly from a Mobile device - https://phabricator.wikimedia.org/T95065#1217385 (10kaldari) The first part of this bug is caused by the fact that we purposefully throw away all warning messages... [23:02:46] dr0ptp4kt: mhurd: coreyfloyd: bgerstle: ping me when the message changes are done, and I'll run a TWN sync [23:04:17] (= done and merged to master) [23:05:25] bearND: will do. we're going to cherry pick the changes from the hotfix branch onto master, probably the first few days of next week [23:07:43] dr0ptp4kt: so nothing today then. ok [23:07:56] yep. enjoy the weekend! [23:07:57] 6Mobile-Web, 10MobileFrontend, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Email confirmation workflow doesn't work correctly from a Mobile device - https://phabricator.wikimedia.org/T95065#1217399 (10kaldari) a:3kaldari [23:08:24] dr0ptp4kt: I wish. Not done yet. [23:08:37] bearND: make mhurd program in android java [23:08:53] dr0ptp4kt: lol [23:08:59] dr0ptp4kt: why? [23:09:17] bearND: it'll speed up stuff. "it's just like javascript, isn't it?" [23:09:35] riiiight [23:09:52] (03CR) 10Kaldari: "I just took a deeper look at the UserLoginAndCreateTemplate class and it made me want to run away screaming. Apparently we are purposely t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [23:11:29] kaldari: looking at this ^ code, too, and have the same feeling :D [23:11:49] (03CR) 10Florianschmidtwelzow: "> Unless anyone serious objects, I'm going to remove all this hackery and restore the original system (which will require neither hard-cod" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [23:12:15] (03CR) 10Kaldari: "ugg, actually it looks like we've built a lot of code around this system, so it's going to be a mess to change it :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [23:13:59] Deskana: btw i updated the wikidata description for enwiki "cattle" article... [23:14:12] FlorianSW: Yeah, it’s mind-boggling. I get the feeling I’m not going to be able to fix this all in the hour I have left at work this week :P [23:14:59] mhurd: What third (or two thirds of it) did you do? [23:15:08] :D i would be happy to merge any better solution :P [23:15:20] Deskana: i went the full three thirds [23:15:29] mhurd: Awww yiss. [23:15:36] lol [23:16:09] kaldari: maybe we can work on removing our own login form completly (or at least find out, what exactly blocks us, so we know, what we need to do) in Lyon? :) [23:16:34] when is Lyon? (I won’t be there) [23:17:05] kaldari: ah, ok :( 22 May to 25 May iirc [23:18:17] (03PS6) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [23:18:19] (03PS2) 10Florianschmidtwelzow: Improve error handling for "Editor not available" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) [23:27:35] kaldari: i'm willing to +2 this: https://gerrit.wikimedia.org/r/#/c/204952/1 but i can't reproduce the problem on enwiki (and locally) either with Firefox for Android or Chrome desktop with emulation :/ Is there any trick :) [23:29:02] Should be reproducable with Firefox for Android on en.wiki. Tap the search box, wait a second for it to load, type a letter, watch the letter disappear. [23:30:08] (03PS8) 10Florianschmidtwelzow: Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 (owner: 10Jdlrobson) [23:30:13] (03CR) 10Florianschmidtwelzow: [C: 032] Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 (owner: 10Jdlrobson) [23:31:43] kaldari: hmm, exactly what i did (tested it now again, with the same result). [23:32:12] (03Merged) 10jenkins-bot: Append drawers to body so they can work in other skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203242 (owner: 10Jdlrobson) [23:32:32] FlorianSW: It’s a finicky bug. Sometimes the letters just don’t show up, sometimes they disappear, and sometimes they render fine with no problems :P [23:33:25] FlorianSW: FWIW, it was a lot easier for me to reproduce it locally than on en.wiki [23:34:49] kaldari: :P Ok, testing it :) But the code looks good and there is nothing that prevents me from merging, so it should be ok merging it, right? [23:36:27] FlorianSW: on en.wiki, try typing a couple of letters as soon as the keyboard pops up. That seems to be more likely to show the bug on en.wiki. [23:37:03] FlorianSW: yeah, as long as there’s no obvious regression, should be OK to merge anyway [23:38:41] kaldari: ok, i defenitly can't reproduce the problem :D I'll merge it now [23:38:49] (03PS2) 10Florianschmidtwelzow: Mostly reverting change Ibabfb5d [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204952 (https://phabricator.wikimedia.org/T95626) (owner: 10Kaldari) [23:38:54] (03CR) 10Florianschmidtwelzow: [C: 032] Mostly reverting change Ibabfb5d [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204952 (https://phabricator.wikimedia.org/T95626) (owner: 10Kaldari) [23:40:56] FlorianSW: It seems to be some kind of race condition bug with mobile Firefox, so it might depend on the speed of your phone/device. [23:40:58] 6Mobile-Web: Set drawers to have a max-width of 500px - https://phabricator.wikimedia.org/T96459#1217447 (10KHammerstein) 3NEW [23:41:02] (03Merged) 10jenkins-bot: Mostly reverting change Ibabfb5d [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204952 (https://phabricator.wikimedia.org/T95626) (owner: 10Kaldari) [23:41:58] kaldari: hmm, possible, it should be fixed now with this change, i hope :D [23:44:39] 6Mobile-Web: Set drawers to have a max-width of 500px - https://phabricator.wikimedia.org/T96459#1217475 (10Florian) a:3Florian [23:48:33] (03PS1) 10Florianschmidtwelzow: Set max-width for drawers to 500px [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204971 (https://phabricator.wikimedia.org/T96459) [23:50:03] 6Mobile-Web, 5Patch-For-Review: Set drawers to have a max-width of 500px - https://phabricator.wikimedia.org/T96459#1217511 (10KHammerstein) [23:52:16] Deskana: you there? [23:52:20] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a user, I want to be able to cancel data migration - https://phabricator.wikimedia.org/T96429#1217529 (10Vibhabamba) {F116375} [23:53:01] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a user, I want to be able to cancel data migration - https://phabricator.wikimedia.org/T96429#1217530 (10Vibhabamba) @deskana Please note copy changes for the other screens. [23:57:49] dr0ptp4kt: Yep! [23:57:54] dr0ptp4kt: Sup? [23:58:20] Deskana: we're planning to submit to automatically release instead of manual. this will demonstrate intent for expedience. okay? cc mhurd [23:58:47] * Deskana thinks [23:59:09] dr0ptp4kt: Yes. [23:59:18] Deskana: thanks [23:59:43] dr0ptp4kt: One question though. [23:59:49] Deskana: yes?