[02:26:18] bearND, only you get those notifications [02:26:38] actually I should probably just reply to the email [02:26:45] Krenair: why is that? [02:26:57] only you signed up to receive them in your otrs preferences [02:27:23] well, I did as well, but it doesn't email me when I perform an action [02:27:31] Krenair: k. I see [02:28:12] I thought dbrant had signed up as well. [02:29:14] probably only for the feedback queue [02:29:27] it doesn't automatically include subqueues, you have to select them all separately [02:29:50] ok. Good to know. Thanks! [03:20:56] 6Mobile-Web, 10MobileFrontend: Fix style of Special:MobileDiff on desktop site - https://phabricator.wikimedia.org/T95828#1219359 (10Tbayer) a:5Tbayer>3None Here are two screenshots of the above example (https://en.wikipedia.org/wiki/Special:MobileDiff/656016868 ). Firefox:{F118314} Chromium:{F118315} (bo... [07:59:06] morning all [08:09:05] 6Mobile-Web: If a user is blocked from editing a page (due to the false group), there should be a link to the history - https://phabricator.wikimedia.org/T95305#1220111 (10phuedx) [08:10:01] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Add an option to disable save of recent search queries and articles - https://phabricator.wikimedia.org/T96546#1220112 (10Florian) 3NEW [08:11:00] (03CR) 10Phuedx: "Hrrm. That's a shame." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204952 (https://phabricator.wikimedia.org/T95626) (owner: 10Kaldari) [08:11:31] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1220120 (10phuedx) [08:11:39] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: When I tap search and start typing, the first few characters get lost. - https://phabricator.wikimedia.org/T95626#1220121 (10phuedx) 5Open>3Resolved [08:14:50] 10Wikipedia-Android-App: Tabbed browsing - https://phabricator.wikimedia.org/T69251#1220126 (10Florian) [08:21:11] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1220136 (10phuedx) [08:54:18] 6Mobile-Web, 5Patch-For-Review: MobileFrontend should show the correct reason, why a user can't edit a page - https://phabricator.wikimedia.org/T96352#1220169 (10Florian) p:5Triage>3Normal [09:34:20] (03CR) 10Phuedx: "Jdlrobson: mibad. I've just noticed that SkinMinervaBeta#renderBrowseTags cover everything. What a difference a weekend makes, eh?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [09:39:11] 10Wikipedia-iOS-App, 7Epic: [EPIC] Discontinue iOS 6 support - https://phabricator.wikimedia.org/T94045#1220234 (10Aklapper) [09:39:19] 10Wikipedia-iOS-App, 7Epic: [EPIC] Data Layer Improvements - https://phabricator.wikimedia.org/T94037#1220235 (10Aklapper) [10:51:45] (03PS3) 10Phuedx: Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) [10:53:51] (03CR) 10jenkins-bot: [V: 04-1] Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [10:55:44] bbiab [11:56:22] 10Wikipedia-Android-App: NPE from page.PageActivity$3.run when trying to call page.PageViewFragmentInternal.getTitle - https://phabricator.wikimedia.org/T96532#1220414 (10Dbrant) a:3Dbrant [11:56:56] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: NPE from page.PageActivity$3.run when trying to call page.PageViewFragmentInternal.getTitle - https://phabricator.wikimedia.org/T96532#1219083 (10Dbrant) [11:58:13] (03PS1) 10Dbrant: Fix possible crash on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205225 (https://phabricator.wikimedia.org/T96532) [12:06:15] MaxSem, tut? [12:09:50] aga [12:13:44] (03CR) 10Dbrant: Fix Script Interpreters and Clean Up (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205071 (owner: 10Niedzielski) [12:34:39] (03PS1) 10Dbrant: Disable pulling of ToC before page has finished loading. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205234 (https://phabricator.wikimedia.org/T96358) [12:35:32] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: NPE crash from page.ToCHandler$2.onDrawerOpened when opening the left hamburger (TOC) before page is loaded - https://phabricator.wikimedia.org/T96358#1220447 (10Dbrant) [12:35:40] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: NPE crash from page.ToCHandler$2.onDrawerOpened when opening the left hamburger (TOC) before page is loaded - https://phabricator.wikimedia.org/T96358#1220449 (10Dbrant) a:3Dbrant [13:03:52] (03CR) 10Mholloway: "Hey Stephen, I've actually been meaning to update/revamp this documentation for accuracy and to encourage external contributions, so this " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski) [13:56:34] (03PS4) 10Phuedx: Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) [14:08:30] (03PS2) 10Niedzielski: Fix Script Interpreters and Clean Up [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205071 [14:10:17] (03CR) 10Niedzielski: Fix Script Interpreters and Clean Up (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205071 (owner: 10Niedzielski) [14:16:37] (03CR) 10Niedzielski: "In terms of sentence-case, there was a little bit of a mix in the readme so I defaulted the titles to standard English capitalization. In " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski) [14:23:54] 10Wikipedia-iOS-App: Automate polling of ITC, HockeyApp stable channel 'released' toggling - https://phabricator.wikimedia.org/T96559#1220623 (10dr0ptp4kt) 3NEW [14:42:25] 10Wikipedia-iOS-App: Automate polling of ITC, HockeyApp stable channel 'released' toggling - https://phabricator.wikimedia.org/T96559#1220700 (10BGerstle-WMF) @dr0ptp4kt @mhurd @Fjalapeno FYI you can set your HockeyApp account notification settings. e.g. I have "individual" crash emails for the stable channel an... [14:44:54] (03CR) 10Phuedx: [C: 032] Remove mw-ui-block from CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205087 (https://phabricator.wikimedia.org/T96430) (owner: 10Florianschmidtwelzow) [14:45:17] 6Mobile-Web: Set button widths in drawers to be constrained to text instead of using block style - https://phabricator.wikimedia.org/T96430#1220705 (10phuedx) [14:45:32] 6Mobile-Web: Set button widths in drawers to be constrained to text instead of using block style - https://phabricator.wikimedia.org/T96430#1220707 (10phuedx) 5Open>3Resolved [14:50:31] (03Merged) 10jenkins-bot: Remove mw-ui-block from CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205087 (https://phabricator.wikimedia.org/T96430) (owner: 10Florianschmidtwelzow) [14:56:22] (03PS1) 10Aude: Add special page alias for Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 [14:57:47] (03PS2) 10Aude: Add special page alias for Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 [15:00:54] bearND: hi there [15:07:00] (03CR) 10Aude: [C: 04-1] "this is not sufficient" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 (owner: 10Aude) [15:25:07] (03CR) 10BearND: [C: 04-1] "According to her Phab task comment, Vibha would like the spacing multiplier of the text snippet to be reduced." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204835 (https://phabricator.wikimedia.org/T96398) (owner: 10Deskana) [15:30:57] bearND: meeting time? [15:31:12] mholloway: yes, I'm already in the cave [15:32:05] (03PS3) 10Aude: Add special page alias for Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 [15:37:34] (03PS2) 10Phuedx: Set max-width for drawers to 500px [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204971 (https://phabricator.wikimedia.org/T96459) (owner: 10Florianschmidtwelzow) [15:37:45] (03CR) 10Phuedx: [C: 031] Set max-width for drawers to 500px [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204971 (https://phabricator.wikimedia.org/T96459) (owner: 10Florianschmidtwelzow) [16:05:49] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Set drawers to have a max-width of 500px - https://phabricator.wikimedia.org/T96459#1220845 (10KLans_WMF) [16:06:16] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Merge 4.1.1 hot-fixes into master - https://phabricator.wikimedia.org/T96452#1220853 (10BGerstle-WMF) a:3BGerstle-WMF [16:07:03] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: MobileFrontend should show the correct reason, why a user can't edit a page - https://phabricator.wikimedia.org/T96352#1220857 (10KLans_WMF) [16:25:07] (03CR) 10Aude: Add special page alias for Special:GatherEditFeed (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 (owner: 10Aude) [16:26:57] 6Mobile-Web, 5Patch-For-Review: Icons missing/broken on old Nokia phones (X3, C3) - https://phabricator.wikimedia.org/T52326#1220946 (10JKatzWMF) @kaldari is this closable? :) [16:28:32] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] MobileFrontend should use mw-ui-icon - https://phabricator.wikimedia.org/T73181#1220955 (10JKatzWMF) @jdlrobson, is this closable? seems old, but saw you were in it recently. [16:30:33] 10Gather, 10MediaWiki-extensions-WikimediaMessages, 7I18n: global-gather-admin global group should be localised - https://phabricator.wikimedia.org/T96571#1220963 (10Florian) 3NEW a:3Florian [16:32:09] (03PS1) 10Bgerstle: merge release/4.1.1 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205287 [16:32:50] coreyfloyd: ^ you're welcome ;-P [16:36:45] 6Mobile-Web, 5Patch-For-Review: Icons missing/broken on old Nokia phones (X3, C3) - https://phabricator.wikimedia.org/T52326#1220994 (10Jdlrobson) [16:36:46] 6Mobile-Web: Icons in IE8 due to lack of support for background sizes - https://phabricator.wikimedia.org/T72961#1220993 (10Jdlrobson) [16:36:48] 6Mobile-Web: Rewrite MobileFrontend frontend code in OOJS UI - https://phabricator.wikimedia.org/T96202#1220995 (10Jdlrobson) [16:36:50] 6Mobile-Web, 7Mobile: "Talk to foo" -button not fit for the lenght of the characters - https://phabricator.wikimedia.org/T95993#1220996 (10Jdlrobson) [16:36:57] 6Mobile-Web, 5Patch-For-Review: Lots of background images not using data URI embedding - https://phabricator.wikimedia.org/T66101#1221005 (10Jdlrobson) [16:36:59] 6Mobile-Web, 7Technical-Debt, 7Tracking: [Tracking] MobileFrontend should use mw-ui-icon - https://phabricator.wikimedia.org/T73181#1220991 (10Jdlrobson) 5Open>3Resolved MobileFrontend is now using this as of Friday so yes :-) yay! [16:40:20] 6Mobile-Web: Icons in IE8 due to lack of support for background sizes - https://phabricator.wikimedia.org/T72961#1221012 (10Jdlrobson) [16:40:50] 6Mobile-Web: Icons in IE8 due to lack of support for background sizes - https://phabricator.wikimedia.org/T72961#760005 (10Jdlrobson) [16:40:52] 6Mobile-Web, 3Mobile-Web-Design: Update all PNG icons in MobileFrontend with SVGs - https://phabricator.wikimedia.org/T95224#1221014 (10Jdlrobson) [16:41:31] 6Mobile-Web, 5Patch-For-Review: Icons missing/broken on old Nokia phones (X3, C3) - https://phabricator.wikimedia.org/T52326#1221022 (10Jdlrobson) We need to find one of the listed devices and see if this is resolved. [16:43:29] 10Gather, 3Gather Sprint Forward, 10MediaWiki-extensions-WikimediaMessages, 7I18n, 5Patch-For-Review: global-gather-admin global group should be localised - https://phabricator.wikimedia.org/T96571#1221027 (10Jdlrobson) [16:43:50] 10Gather, 3Gather Sprint Forward, 7I18n: in Special:Gather the content is shown in the UI language - https://phabricator.wikimedia.org/T96497#1221029 (10Jdlrobson) [16:49:30] (03CR) 10Phuedx: [C: 032] Set max-width for drawers to 500px [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204971 (https://phabricator.wikimedia.org/T96459) (owner: 10Florianschmidtwelzow) [16:51:18] (03Merged) 10jenkins-bot: Set max-width for drawers to 500px [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204971 (https://phabricator.wikimedia.org/T96459) (owner: 10Florianschmidtwelzow) [16:58:13] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Set drawers to have a max-width of 500px - https://phabricator.wikimedia.org/T96459#1221071 (10phuedx) [16:58:19] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Set drawers to have a max-width of 500px - https://phabricator.wikimedia.org/T96459#1221073 (10phuedx) 5Open>3Resolved [17:03:31] (03PS6) 10Jdlrobson: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [17:10:31] * phuedx waits for kaldari [17:34:07] (03CR) 10Phuedx: [C: 04-1] "-1 because of the wording of the message and parameter order. The other comments are discussion points." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [17:36:41] (03CR) 10Jdlrobson: [C: 04-1] "* Flag padding is not like mock 0 is a bit cramped at top of screen" (035 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [17:37:55] (03CR) 10Jdlrobson: "oh wait.. it does disable. It just didn't look disabled - would expect different visual treatment for disabled (might be worth pinging moi" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [17:38:46] (03CR) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [17:39:50] 10Gather, 3Gather Sprint Forward: Change messaging for blank collections - https://phabricator.wikimedia.org/T95740#1221211 (10Jdlrobson) a:3Jdlrobson [17:40:07] gonna get the boys to bed and then come back [17:41:52] (03CR) 10Jdlrobson: [C: 04-1] Add special page alias for Special:GatherEditFeed (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 (owner: 10Aude) [17:42:23] oh noes [17:43:34] * aude hates naming [17:46:05] (03PS4) 10Aude: Add special page alias for Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 [17:46:19] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Remove reference superscripts in share a fact cards. - https://phabricator.wikimedia.org/T95476#1221228 (10Deskana) [17:46:26] (03PS7) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [17:46:37] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Fact cards, which have no specific text selected, should always carry the first sentence of the article. - https://phabricator.wikimedia.org/T96312#1221229 (10Deskana) [17:46:44] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Fact cards, which have no specific text selected, should always carry the first sentence of the article. - https://phabricator.wikimedia.org/T96312#1221232 (10Deskana) a:5dr0ptp4kt>3None [17:47:45] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Toggle flag in HockeyApp when iOS update goes live - https://phabricator.wikimedia.org/T93692#1221241 (10Deskana) 5Open>3Resolved a:3Deskana I'm assuming this is done. [17:48:21] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Implement Schema:MobileWikiAppSearch - https://phabricator.wikimedia.org/T90257#1221244 (10Deskana) [17:48:29] (03PS1) 10Jdlrobson: Adjust messages for empty collections based on user viewing it [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205296 (https://phabricator.wikimedia.org/T95740) [17:48:54] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Article titles that should be italicised are not italicised in lead image - https://phabricator.wikimedia.org/T96262#1221252 (10Deskana) [17:48:59] (03PS5) 10Aude: Add special page alias for Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 [17:49:39] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Header in article history that should display a date instead displays the current time, UTC - https://phabricator.wikimedia.org/T96268#1221254 (10Deskana) [17:49:49] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Some article titles are randomly bolded in read more section - https://phabricator.wikimedia.org/T96263#1221256 (10Deskana) [17:50:27] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Prompt user before starting data migration - https://phabricator.wikimedia.org/T96280#1221264 (10Deskana) 5Open>3Resolved This went out. [17:50:28] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [RELEASE] 4.1.1 hot-fixes & migration tweaks - https://phabricator.wikimedia.org/T96389#1221266 (10Deskana) [17:51:04] 10Gather, 3Gather Sprint Forward, 3Mobile-Web-Design: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1221271 (10Jdlrobson) [17:51:26] 10Gather, 3Gather Sprint Forward: API: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1221276 (10Jdlrobson) a:3Jdlrobson [17:51:49] (03CR) 10Aude: Add special page alias for Special:GatherEditFeed (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 (owner: 10Aude) [17:52:26] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Read more sections with no results display the confusing text "No matches found for search term" - https://phabricator.wikimedia.org/T96265#1221291 (10Deskana) [17:52:53] jdlrobson: if i try to visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/by/Diablanco/74 i get the error, that the page could not be found, is this correct? (I navigated to this list from Special:GatherLists) [17:54:26] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: "Quick facts" in collapsed tables is always in English - https://phabricator.wikimedia.org/T95745#1221302 (10Deskana) [17:54:39] (03PS1) 10Aude: Add isset checks for array in CollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 [17:54:44] FlorianSW: probably unrelated but got some php notices [17:54:49] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: "Quick facts" in collapsed tables is always in English - https://phabricator.wikimedia.org/T95745#1221309 (10Deskana) p:5Triage>3Normal [17:54:51] ^ [17:55:01] not totally sure my changes are correct [17:55:14] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Article titles that should be italicised are not italicised in lead image - https://phabricator.wikimedia.org/T96262#1221319 (10Deskana) p:5Low>3Normal [17:55:31] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Read more sections with no results display the confusing text "No matches found for search term" - https://phabricator.wikimedia.org/T96265#1221325 (10Deskana) p:5Low>3Normal [17:55:36] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Some article titles are randomly bolded in read more section - https://phabricator.wikimedia.org/T96263#1221327 (10Deskana) p:5Low>3Normal [17:55:43] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Header in article history that should display a date instead displays the current time, UTC - https://phabricator.wikimedia.org/T96268#1221329 (10Deskana) p:5Low>3Normal [17:55:57] PING PING [17:56:01] DESKANA'S DOING SOMETHING [17:56:41] aude: hmm, but non-existent index should be false. i'm not sure, if this is the problem :/ [17:57:21] 6Mobile-Web, 6Collaboration-Team, 10VisualEditor, 10VisualEditor-EditingTools, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1221347 (10EBernhardson) p:5Triage>3Normal [17:57:43] 10Gather: Undefined index 'image' and 'public' in CollectionsList - https://phabricator.wikimedia.org/T96585#1221354 (10aude) 3NEW [17:58:06] FlorianSW: maybe [17:58:38] (03PS2) 10Aude: Add isset checks for array in CollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) [17:59:35] (03CR) 10Florianschmidtwelzow: [C: 031] Add isset checks for array in CollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [18:00:18] i think just if ( isset( $list['public'] ) || $includePrivate ) [18:00:19] then [18:00:27] 10Gather, 3Gather Sprint Forward: API: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1221373 (10Jdlrobson) [18:00:29] 10Gather, 3Gather Sprint Forward, 10MediaWiki-extensions-WikimediaMessages, 7I18n, 5Patch-For-Review: global-gather-admin global group should be localised - https://phabricator.wikimedia.org/T96571#1221374 (10Krenair) 5Open>3Resolved [18:00:44] 10Gather, 3Gather Sprint Forward: API: Deleted pages should appear at bottom of the collection - https://phabricator.wikimedia.org/T93295#1133825 (10Jdlrobson) As @yurik notes putting deleted pages at end of list is not possible to do so I've removed that from description. [18:01:01] (03PS2) 10Bgerstle: merge release/4.1.1 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205287 [18:02:15] or maybe $list['public'] can be false [18:02:29] aude: possible, but i'm not sure, if public can contain "false" or not, have you looked into the api code? [18:02:36] :P [18:03:02] no, but think i will check both isset and that it's true [18:03:22] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: EventLogging to evaluate success/failure of link hovering prototype - https://phabricator.wikimedia.org/T95726#1221390 (10Deskana) [18:03:46] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: [Blocked - Needs schema] EventLogging to evaluate success/failure of link hovering prototype - https://phabricator.wikimedia.org/T95726#1221391 (10Deskana) [18:06:01] kristenlans: Have a moment for some batcaving? [18:06:56] (03PS3) 10Bgerstle: merge release/4.1.1 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205287 [18:07:26] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Allow for more diagnostics of page loading issues - https://phabricator.wikimedia.org/T95182#1221402 (10Deskana) [18:07:54] kristenlans: Oh, I see you're in meetings. [18:08:00] mhurd shouldn't have any xcasset stuff in the patch now [18:08:02] kristenlans: I'll send an email instead. [18:08:08] bgerstle: thx! [18:08:09] 10Gather, 3Gather Sprint Forward: Deleted pages in collections behaviour - https://phabricator.wikimedia.org/T93295#1221408 (10Jdlrobson) [18:09:24] (03CR) 10Aude: [C: 04-1] "don't think this is exactly correct" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [18:09:51] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Remove reference superscripts in share a fact cards. - https://phabricator.wikimedia.org/T95476#1221414 (10dr0ptp4kt) a:5dr0ptp4kt>3None [18:10:59] 10Gather, 3Gather Sprint Forward: Deleted pages in collections behaviour - https://phabricator.wikimedia.org/T93295#1221417 (10Yurik) @Jdlrobson, I didn't say it wasn't possible to do on the server, I said you should not do it on the client because that requires full list download. It is relatively easy (but m... [18:14:44] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [RELEASE] 4.1.1 hot-fixes & migration tweaks - https://phabricator.wikimedia.org/T96389#1221428 (10BGerstle-WMF) [18:14:45] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [SPIKE] Reach out to users experiencing issues w/ 4.1.0 or who haven't updated yet - https://phabricator.wikimedia.org/T96391#1221426 (10BGerstle-WMF) 5Open>3Resolved [18:15:11] (03PS3) 10Aude: Add isset checks for array in CollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) [18:19:21] (03PS1) 10Jdlrobson: Update how deleted pages behave [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) [18:19:23] (03PS1) 10Jdlrobson: WIP: Don't show deleted pages on collection view of watchlist [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205301 (https://phabricator.wikimedia.org/T93295) [18:19:40] 10Gather, 3Gather Sprint Forward: new collection entry design tweak - https://phabricator.wikimedia.org/T93651#1221442 (10Jdlrobson) a:3Jdlrobson [18:20:48] Deskana I have ten mins now if you want to batcave it [18:21:04] kristenlans: Yes! Joining. [18:23:22] kaldari: yt? [18:23:30] (03CR) 10Mhurd: [C: 031] merge release/4.1.1 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205287 (owner: 10Bgerstle) [18:24:05] phuedx: ya [18:24:24] phuedx: so how do you feel about running some wikigrok bot? [18:25:04] kaldari: i'm ok with it, provided that you have your mouse cursor over the REVERT ALL OF THIS BOTS EDITS button ;) [18:25:07] wanna hangout [18:25:11] ? [18:25:21] we can also chat wikigrok changes for the other task [18:25:25] I have a meeting in 5 :( [18:25:29] bleh [18:25:35] when's the meeting over? [18:25:49] it’s only half an hour [18:26:20] ok cool [18:26:32] phuedx: I can’t actually revert all the bot edits at once (my adminship on wikidata expired) [18:26:33] i'll be hear for another hour at least [18:26:58] 10Gather, 3Gather Sprint Forward: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1221509 (10rmoen) @JKatzWMF, @Jdlrobson Does this need to indicate the collection in question? Perhaps include the title of the hidden /unhidden collection somewher... [18:26:58] phuedx: but I can keep an eye on them :) [18:27:08] ok sec [18:27:45] phuedx: with the super conservative settings, it should only make about 100 edits [18:28:41] kaldari: yeah -- i dunno what i'm nervous for -- if it's bogus then it'll get reverted [18:37:47] 10Gather, 3Gather Sprint Forward: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1221602 (10JKatzWMF) @rmoen @jdlrobson Thank you for clarifying--this should indicate the collection in question (ideally linked). here is the reworded text: "Y... [18:38:21] 10Wikipedia-iOS-App: Crash when reading incomplete section list from disk - https://phabricator.wikimedia.org/T96597#1221605 (10BGerstle-WMF) 3NEW [18:38:39] (03PS1) 10Jdlrobson: Adjust input based on available size [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205305 (https://phabricator.wikimedia.org/T93651) [18:38:58] 10Wikipedia-iOS-App: Crash when reading incomplete section list from disk - https://phabricator.wikimedia.org/T96597#1221619 (10BGerstle-WMF) [18:39:01] 10Gather, 3Gather Sprint Forward, 7Easy: Hidden collections show as private in my list of collections - https://phabricator.wikimedia.org/T95967#1221621 (10Jdlrobson) a:3Jdlrobson [18:40:18] 10Gather, 3Gather Sprint Forward: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1221624 (10rmoen) @JKatzWMF Thanks for the quick followup. I believe the category name is hidden from the user. [18:41:23] (03CR) 10Yurik: [C: 04-1] "Don't use isKnown() - which calls Title::exists(). You effectivelly do a DB query for each page shown in the list. So that's N extra queri" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson) [18:41:33] (03CR) 10Yurik: [C: 04-1] "Don't use isKnown() - which calls Title::exists(). You effectivelly do a DB query for each page shown in the list. So that's N extra queri" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205301 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson) [18:41:50] (03CR) 10Jdlrobson: [C: 032] "Still not happy with the messaging but as you point out the php notice is the more important thing here :)" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 (owner: 10Aude) [18:42:57] 10Wikipedia-iOS-App: [EPIC] Replace MWK exceptions with assertions & nil fallbacks - https://phabricator.wikimedia.org/T96599#1221646 (10BGerstle-WMF) 3NEW [18:43:27] (03Merged) 10jenkins-bot: Add special page alias for Special:GatherEditFeed [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205255 (owner: 10Aude) [18:43:48] 10Wikipedia-iOS-App, 3App-Process-Improvement: Disable gerrit-to-github mirroring - https://phabricator.wikimedia.org/T96600#1221670 (10BGerstle-WMF) 3NEW [18:43:52] * aude also not entirely happy with the messages [18:45:04] 10Wikipedia-iOS-App, 3App-Process-Improvement: Source code review options - https://phabricator.wikimedia.org/T95749#1221680 (10BGerstle-WMF) [18:45:05] 10Wikipedia-iOS-App, 3App-Process-Improvement: Disable gerrit-to-github mirroring - https://phabricator.wikimedia.org/T96600#1221670 (10BGerstle-WMF) 5Open>3Invalid [18:45:11] (03PS1) 10Anomie: Update for core API change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205317 (https://phabricator.wikimedia.org/T96595) [18:45:23] (03PS1) 10Anomie: Further cleanup for core API change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) [18:45:39] 10Wikipedia-iOS-App, 3App-Process-Improvement: Source code review options - https://phabricator.wikimedia.org/T95749#1199458 (10BGerstle-WMF) [18:45:50] (03PS1) 10Anomie: Further cleanup for core API change [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/205334 (https://phabricator.wikimedia.org/T96595) [18:46:32] 10Wikipedia-iOS-App: Enable Travis & Coveralls for main GH Repo - https://phabricator.wikimedia.org/T96601#1221706 (10BGerstle-WMF) 3NEW [18:49:07] (03CR) 10jenkins-bot: [V: 04-1] Further cleanup for core API change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [18:50:27] (03CR) 10Dr0ptp4kt: [C: 032] "5S 8.2 simulator based upgrade from 4.0.6.0 (.xcodeproj) to this version succeeded." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205287 (owner: 10Bgerstle) [18:50:34] (03PS1) 10BearND: Add Event log URL for testing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205336 [18:50:44] ^^ bgerstle mhurd [18:50:49] +2'd [18:51:12] 10Wikipedia-iOS-App, 3App-Process-Improvement: Disable gerrit-to-github mirroring - https://phabricator.wikimedia.org/T96600#1221735 (10BGerstle-WMF) [18:51:13] 10Wikipedia-iOS-App, 3App-Process-Improvement: Source code review options - https://phabricator.wikimedia.org/T95749#1221733 (10BGerstle-WMF) [18:51:14] 10Wikipedia-iOS-App: Enable Travis & Coveralls for main GH Repo - https://phabricator.wikimedia.org/T96601#1221734 (10BGerstle-WMF) [18:53:19] (03CR) 10Jdlrobson: [C: 04-1] "hah! i love it when I hit a bug that someone has already written a patch for." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [18:54:45] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Android: 'Read more', 'More information', 'Quick facts' are not translated when switching to a different language - https://phabricator.wikimedia.org/T86387#1221741 (10Deskana) [18:55:21] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Undefined index 'image' and 'public' in CollectionsList - https://phabricator.wikimedia.org/T96585#1221742 (10Jdlrobson) [18:56:01] Deskana: ^^ is rather hard to do on Android without the nodejs service. Can we postpone that? [18:56:12] 10Gather, 3Gather Sprint Forward, 10MediaWiki-extensions-WikimediaMessages, 7I18n, 5Patch-For-Review: global-gather-admin global group should be localised - https://phabricator.wikimedia.org/T96571#1221746 (10Jdlrobson) Thanks @florian and @krenair! :) [18:56:35] 10Wikipedia-Android-App: Android: 'Read more', 'More information', 'Quick facts' are not translated when switching to a different language - https://phabricator.wikimedia.org/T86387#967638 (10Deskana) [18:56:39] (03CR) 10Legoktm: [C: 032] Further cleanup for core API change [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/205334 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [18:56:43] bearND: Sure. Sprint 56 is looking really light at the minute, though. I could use your help with that. [18:57:10] Deskana: ok, looking [18:57:28] 3Gather Sprint Forward: when a user accidentally swipes left or right on the create collection overlay, the overlay freezes and they cannot scroll anymore - https://phabricator.wikimedia.org/T96445#1221756 (10Jdlrobson) Unable to replicate. Any more details? * Which browser? * Which device? (including version) *... [18:57:31] Deskana: we can always pull in some more bugs [18:57:55] 3Gather Sprint Forward, 5Patch-For-Review: Bug: Show/hide actions not showing correct toast message - https://phabricator.wikimedia.org/T96319#1221757 (10Jdlrobson) a:3Jdlrobson [18:58:12] bearND: Any in particular that you'd recommend? [18:58:28] 10Gather: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1221763 (10Jdlrobson) [18:58:33] Oh, I know one that I wanted. [18:58:57] Deskana: can we get the galleries task in? [18:59:05] vibha: That's exactly the one I'm looking for. [18:59:10] Deskana: moving some bugs up in the list [18:59:13] Use captions instead of descriptions [18:59:18] Great [18:59:23] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: Reuse image caption from the article in the image gallery, to increase continuity between article and image gallery - https://phabricator.wikimedia.org/T94495#1221772 (10Deskana) [18:59:37] 3Gather Sprint Forward: when a user accidentally swipes left or right on the create collection overlay, the overlay freezes and they cannot scroll anymore - https://phabricator.wikimedia.org/T96445#1221778 (10JKatzWMF) @jdlrobson i will look into screenshot video in iphone, but for now it is safari on ios 8.1.2... [18:59:41] I suspect that'll be one of those "10% of the effort gets you 90% of the way" tasks [19:01:03] (03CR) 10Legoktm: [C: 04-1] Further cleanup for core API change (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:01:31] (03CR) 10Legoktm: [C: 032] Update for core API change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205317 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:02:19] 10Wikipedia-iOS-App: Crash when failing to read HTML for particular section from disk - https://phabricator.wikimedia.org/T96603#1221798 (10BGerstle-WMF) 3NEW [19:02:24] (03CR) 10jenkins-bot: [V: 04-1] Further cleanup for core API change [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/205334 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:02:35] 10Gather: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1221804 (10Jdlrobson) I'd suggest creating a card with specifics on what we want to know about performance. I'm not convinced this is an issue yet and this card is not really actionable. Is the concern performance or ho... [19:03:17] (03PS2) 10Anomie: Further cleanup for core API change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) [19:05:00] (03CR) 10jenkins-bot: [V: 04-1] Further cleanup for core API change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:05:47] (03CR) 10Anomie: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:06:04] (03CR) 10Anomie: "recheck" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/205334 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:06:06] (03Merged) 10jenkins-bot: Update for core API change [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205317 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:07:30] 10Wikipedia-iOS-App: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1221843 (10BGerstle-WMF) 3NEW [19:07:32] 10Wikipedia-iOS-App: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1221843 (10BGerstle-WMF) [19:09:41] (03PS2) 10Jdlrobson: Update how deleted pages behave [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) [19:09:42] (03CR) 10Jdlrobson: "thanks for the prop tip!" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson) [19:10:34] (03CR) 10Legoktm: [C: 032] Further cleanup for core API change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:10:40] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Double-tap search text hides it behind buttons - https://phabricator.wikimedia.org/T88768#1221884 (10bearND) [19:11:04] 10Wikipedia-Android-App, 7Easy, 3Mobile-App-Sprint-56-Android: 'Tap here to expand' - the label should change when the section is expanded? - https://phabricator.wikimedia.org/T86860#1221894 (10bearND) [19:11:36] (03CR) 10Jdlrobson: [C: 031] "I need to test but looks good." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [19:12:32] (03CR) 10Jdlrobson: [C: 031] "needs testing (can't help but wonder why done this way originally)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204972 (owner: 10Florianschmidtwelzow) [19:12:54] (03PS7) 10Jdlrobson: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 [19:13:22] (03PS1) 10Kaldari: Inclease WikiGrok sample size to 25% [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/205343 [19:13:35] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#1221912 (10bearND) [19:13:44] (03CR) 10jenkins-bot: [V: 04-1] Further cleanup for core API change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:13:52] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Crash when reading incomplete section list from disk - https://phabricator.wikimedia.org/T96597#1221915 (10KLans_WMF) [19:14:01] (03PS2) 10Phuedx: Increase WikiGrok sample size to 25% [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/205343 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [19:14:18] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Crash when failing to read HTML for particular section from disk - https://phabricator.wikimedia.org/T96603#1221917 (10KLans_WMF) [19:14:21] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1221919 (10KLans_WMF) [19:14:57] (03CR) 10jenkins-bot: [V: 04-1] Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 (owner: 10Jdlrobson) [19:14:57] 10Gather: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1221922 (10Yurik) @jdlrobson, we should continue to support non-js browsers by providing rudimentary functionality - see how gmail falls back to HTML version, not offer two competing services with identical functionalit... [19:15:08] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: NPE crashes from android.webkit.AccessibilityInjector$TextToSpeechWrapper$1.onInit - https://phabricator.wikimedia.org/T89077#1221925 (10bearND) [19:15:55] 10Wikipedia-iOS-App: The introduction for 'Save Pages' does not go away even if you switch articles. - https://phabricator.wikimedia.org/T96606#1221928 (10Vibhabamba) 3NEW a:3Deskana [19:16:21] (03CR) 10Legoktm: [C: 032] Further cleanup for core API change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:16:23] (03CR) 10Phuedx: [C: 032] Increase WikiGrok sample size to 25% [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/205343 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [19:17:06] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: NPE crash from android.view.SurfaceView.onAttachedToWindow - https://phabricator.wikimedia.org/T86441#1221948 (10bearND) [19:17:30] (03CR) 10Yurik: [C: 04-1] "Jon, please re-read my comment - this approach is fundamentally flawed - you are doing a query for each title, which will kill performance" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson) [19:17:59] (03CR) 10jenkins-bot: [V: 04-1] Further cleanup for core API change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:18:11] (03CR) 10jenkins-bot: [V: 04-1] Increase WikiGrok sample size to 25% [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/205343 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [19:18:43] 10Gather: Performance of routing on Special:Gather - https://phabricator.wikimedia.org/T96150#1221963 (10Jdlrobson) @yurik we are not duplicating efforts. Please chat to me outside this bug report if you think we are. This is about routing and urls... [19:19:09] (03CR) 10Phuedx: "Recheck." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/205343 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [19:19:14] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when reading incomplete section list from disk - https://phabricator.wikimedia.org/T96597#1221965 (10KLans_WMF) [19:19:21] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: Link Exclusions: Which words will not produce previews? - https://phabricator.wikimedia.org/T95035#1221967 (10bearND) [19:19:24] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when failing to read HTML for particular section from disk - https://phabricator.wikimedia.org/T96603#1221968 (10KLans_WMF) [19:19:31] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1221970 (10KLans_WMF) [19:23:31] (03PS2) 10Mhurd: Fixing icons… again [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204703 (owner: 10Fjalapeno) [19:23:31] (03PS2) 10Mhurd: Fix change logs - git not using the proper path to the repo. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204651 (owner: 10Fjalapeno) [19:23:31] rebased ^ [19:23:31] 10Wikipedia-Android-App, 7I18n, 3Mobile-App-Sprint-56-Android: Special case Traditional and Simplified Chinese in all language handling - https://phabricator.wikimedia.org/T62743#673611 (10bearND) [19:24:50] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: [Blocked - Needs schema] EventLogging to evaluate success/failure of link hovering prototype - https://phabricator.wikimedia.org/T95726#1221988 (10bearND) p:5Triage>3Normal [19:25:12] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: Link Exclusions: Which words will not produce previews? - https://phabricator.wikimedia.org/T95035#1221992 (10bearND) p:5Triage>3Normal [19:25:49] kaldari: could you email me a super quick update when it's out? [19:26:42] (03CR) 10Legoktm: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205323 (https://phabricator.wikimedia.org/T96595) (owner: 10Anomie) [19:29:47] (03PS5) 10Mhurd: WIP - do not merge. See notes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [19:29:56] rebased ^ [19:32:57] 10Wikipedia-iOS-App: "Quick facts" in collapsed tables is always in English - https://phabricator.wikimedia.org/T95745#1222023 (10Deskana) [19:41:31] 10Wikipedia-iOS-App: "Quick facts" in collapsed tables is always in English - https://phabricator.wikimedia.org/T95745#1222056 (10Mhurd) This is half true. If your device language is changed this "Quick facts" string will be too. This is the same issue we see in the TOC for its "Contents" string. The problems... [19:42:26] 6Mobile-Web, 10VisualEditor: Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1222077 (10Jdforrester-WMF) [19:42:46] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1222082 (10Jdforrester-WMF) p:5Triage>3High a:3Mooeypoo [19:42:55] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1097351 (10Jdforrester-WMF) [19:46:17] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Consolidate plain text extraction logic for article snippets - https://phabricator.wikimedia.org/T96610#1222094 (10BGerstle-WMF) 3NEW [19:46:25] bearND: dr0ptp4kt ^ [19:46:46] we could even bundle this under a more generic "make article HTML more mobile friendly" [19:47:07] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: Reuse image caption from the article in the image gallery, to increase continuity between article and image gallery - https://phabricator.wikimedia.org/T94495#1222106 (10KLans_WMF) @deskana @vbamba can you hook up with media viewer... [19:47:11] i.e. move all the transformations and stuff we do into a parser output stage, or something [19:48:04] notice i left the card intentionally vague so we can design the solution to the problem [19:50:09] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#1222119 (10Deskana) @mhurd may have some comments on this since he was working on image maps fairly recently. [19:51:03] (03PS4) 10Aude: Add isset checks for array in CollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) [19:51:08] (03CR) 10Aude: Add isset checks for array in CollectionsList (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [19:51:14] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1222135 (10Vibhabamba) Mholloway can we touch base today on how this is working out? Do you have any screenshots... [19:51:39] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1222139 (10Jdforrester-WMF) 5Open>3Resolved [19:51:59] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1097351 (10Jdforrester-WMF) [19:52:45] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1097351 (10Jdforrester-WMF) [19:53:28] (03CR) 10Aude: [C: 04-1] "i am looking at what 'perm' does and might need to tweak this more" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [19:53:49] 10Wikipedia-iOS-App: [EPIC] Replace MWK exceptions with assertions & nil fallbacks - https://phabricator.wikimedia.org/T96599#1222156 (10BGerstle-WMF) [19:54:25] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Merge 4.1.1 hot-fixes into master - https://phabricator.wikimedia.org/T96452#1222164 (10BGerstle-WMF) [19:54:26] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: [RELEASE] 4.1.1 hot-fixes & migration tweaks - https://phabricator.wikimedia.org/T96389#1222163 (10BGerstle-WMF) 5Open>3Resolved [19:54:48] mholloway: Just wanted to check in on this - https://phabricator.wikimedia.org/T94646. If you have any questions - we can chat about this today. [19:55:23] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1222172 (10BGerstle-WMF) [19:55:24] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (1 instance reported) MWKDataStore saveFile:atPath:byPerforming - https://phabricator.wikimedia.org/T96211#1222171 (10BGerstle-WMF) [19:55:47] mholloway No worries if you just need to stay heads down and working. [19:56:01] vibha: hey, one question, actually: we only want the width to match the paragraph text, and not to go all the way out to the edge of the screen, right? [19:56:16] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (1 instance reported) CA::AttrList::set(unsigned int, _CAValueType, void const*) - https://phabricator.wikimedia.org/T96208#1222178 (10BGerstle-WMF) [19:56:49] mholloway: yes [19:57:08] vibha: ok, good [19:57:54] vibha: i've adjusted the widths to look like the samples you attached but i'm still working on the logic for grabbing the higher-quality images [19:58:57] 10Wikipedia-iOS-App: Crash when WebCore parses HTML in background and accesses UIKit objects - https://phabricator.wikimedia.org/T96208#1222193 (10BGerstle-WMF) [19:59:01] bearnd vibha deskana design signoff column added to Android sprint 56 board (and will be added to all android sprint boards hereafter). Now we just need to see if etonkovidova wants us to add a QA signoff on android board :-) [19:59:39] OMG PHAB Y U SO AWFUL [19:59:50] "oh, you want to drag to an off-screen column? SORRY" [19:59:57] Deskana|Away: i'm sorry if i ever doubted you [20:00:00] kristenlans: ^ [20:00:58] kristenlans: I think QA signoff column for android sounds good. If we did not like it(or something) we can get rid of it [20:01:08] (03CR) 10Aude: "think this might be okay now." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [20:03:01] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Resolve HockeyApp crash (1 instance reported) TabularScrollView viewTapped - https://phabricator.wikimedia.org/T96209#1222205 (10BGerstle-WMF) p:5Triage>3Low [20:03:14] 10Wikipedia-iOS-App: Crash when WebCore parses HTML in background and accesses UIKit objects - https://phabricator.wikimedia.org/T96208#1222206 (10BGerstle-WMF) p:5Triage>3Low [20:04:02] 10Wikipedia-iOS-App: Resolve HockeyApp crash (1 instance reported) TabularScrollView viewTapped - https://phabricator.wikimedia.org/T96209#1211068 (10BGerstle-WMF) [20:04:59] kristenlans: thank you! [20:07:30] kristenlans: could we have a design review column for sprint 55 as well? [20:08:37] (03CR) 10Kaldari: "recheck" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/205343 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [20:14:12] 10Wikipedia-iOS-App: Low level networking crash - https://phabricator.wikimedia.org/T96210#1222240 (10BGerstle-WMF) p:5Triage>3Lowest [20:17:13] bgerstle: thx for making that extraction logic ticket [20:17:43] dr0ptp4kt: np, as the "de facto" BDFL for share-a-fact, when do you think we should discuss it more? [20:18:04] bgerstle: the act of upstreaming? [20:18:09] (03PS1) 10Kaldari: Increase WikiGrok sample size to 25% [extensions/WikiGrok] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/205409 (https://phabricator.wikimedia.org/T94444) [20:18:20] (03PS1) 10Jdlrobson: Correctly identify collections as hidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205411 (https://phabricator.wikimedia.org/T95967) [20:18:46] (03PS1) 10Kaldari: Increase WikiGrok sample size to 25% [extensions/WikiGrok] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205415 (https://phabricator.wikimedia.org/T94444) [20:18:53] bgerstle: sounds like Phab is being an asshole [20:20:05] kristenlans: as usual [20:20:27] dr0ptp4kt: actually, as i started to think about it more, putting it in a service *might* not be the best thing to do [20:20:52] bgerstle: it really should be part of the page response imo. maybe via a generator [20:20:53] the *core* problem, is that the HTML makes it hard to select just the text you want [20:21:17] dr0ptp4kt: right, but you probably want to avoid an extra round trip just to get a couple lines of plain text [20:21:31] bgerstle: yeah, you're right. if it's user selection based, it's done client side. if it's not, then making it part of a generator makes most sense [20:21:38] yeah [20:21:50] dr0ptp4kt: ideally that, or at the very least do the text extraction in JS [20:21:54] bgerstle: it would be possible to have a common piece of js if we really liked for user selection, right? bearND ? [20:22:02] dr0ptp4kt: QUIT READING MY MIND [20:22:22] dr0ptp4kt: but yeah, IMO that's a better stop-gap then 2 client-side impls [20:22:33] and this can go in the larger vein of "apps sharing JS" anyway [20:22:35] bgerstle: bearND not that we *have* to use JS, but yeah [20:22:55] dr0ptp4kt: yeah, that can be a decent plan B [20:23:08] but yeah, if the HTML was nicer overall, we could get rid of the problem completely [20:23:15] i.e. text selection would "just work" [20:23:32] (03CR) 10Jdlrobson: [C: 04-1] Add isset checks for array in CollectionsList (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [20:24:14] (03PS5) 10Jdlrobson: Add isset checks for array in CollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [20:24:25] dr0ptp4kt: bgerstle: What JS do you have in mind for text selection? [20:24:57] (03CR) 10Jdlrobson: [C: 032] Add isset checks for array in CollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [20:25:09] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Undefined index 'image' and 'public' in CollectionsList - https://phabricator.wikimedia.org/T96585#1222271 (10Jdlrobson) a:3aude [20:25:26] bearND: i'd prefer that we talk about what the parser can do for us first ;-) [20:25:58] e.g. something w/ how users see citations/refs on mobile that jives well w/ the text selection requirements of sharing [20:26:26] (03CR) 10Aude: Add isset checks for array in CollectionsList (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [20:26:36] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1222276 (10Jdlrobson) Ping. To get this moving you just need to blank the message. The patch to WikimediaMessages extension should be pretty trivial. [20:26:51] (03Merged) 10jenkins-bot: Add isset checks for array in CollectionsList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205297 (https://phabricator.wikimedia.org/T96585) (owner: 10Aude) [20:27:12] bearND: dr0ptp4kt barring any parser-based solutions, we can talk about how to port text extraction to JS—if we all agree the code reuse benefits will outweigh any performance (or other) drawbacks [20:27:15] 10Gather, 3Gather Sprint Forward: Bug: Dismissing login drawer after clicking watchstar breaks watchstar - https://phabricator.wikimedia.org/T94682#1222281 (10Jdlrobson) a:3Jdlrobson [20:28:45] bgerstle: On Android we get the selected text through some native hackery (invoke the copy to clipboard functionality). [20:29:16] bgerstle: After that we just use a few regex's to remove unwanted substrings [20:29:26] bearND: that's (AFAIK) what we're doing [20:29:34] bgerstle: There's no JS involved [20:30:00] bearND: right, i didn't think there was now [20:30:41] but the regex code we have in iOS is... let's say it's something you'd rather not maintain [20:30:51] regexes in general are hard to maintain [20:31:08] so if we can all share the same hacky stuff, we can save some effort, and have all the tests pass in one place [20:31:31] but, it might be more trouble than it's worth [20:31:40] or, maybe not [20:32:00] kristenlans: in hangout [20:32:01] bgerstle: On Android it's failry short: https://github.com/wikimedia/apps-android-wikipedia/blob/master/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java#L93-L95 [20:32:09] fairly [20:32:31] bgerstle: forgot to highlight L92 [20:33:42] 10Gather, 3Gather Sprint Forward: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1222285 (10rmoen) @JKatzWMF, Sorry last question: Do we want to include the username of the admin who hid the collection? eg: Your collection [title | link to... [20:34:13] bearND: k, so maybe sharing the code in this instance isn't highly beneficial (yet) [20:34:21] but, if you didn't have two do regex parsing at all... that would be even better [20:34:37] kristenlans: going to get back to work if this meeting isn't happening... [20:35:24] ah crap [20:35:25] mhurd [20:35:32] got sucked in to a Phab-hole [20:45:24] bgerstle: I think in general this code should be centralized, so it's consistent between at least ShareAFact, LinkPreviews, and the lead section transform for removing parens. Only the latter is in JS, the first two are in native code (and ShareAFact doesn't remove the parentheses yet). [20:46:49] bgerstle: I noticed that dbrant's code for removing parens in the LinkPreview prototype is basically the lead section transform code ported from JS to Java. [20:47:22] bearND: agreed, it seems like code reuse might facilitate development in those cases. but what do you think about solving the problem at the API/parser level as a long-term solution? [20:48:11] bgerstle: The link preview code is not merged yet, so I'll try to get him to use the JS code instead. [20:48:25] bearND: diesgn signoff in 55 now also [20:48:26] bgerstle: I think the long-term solution would be the content service [20:48:34] kristenlans: yeah! [20:49:26] kristenlans: vibha: filled the first spot in the design signoff column of https://phabricator.wikimedia.org/tag/mobile-app-sprint-55-android/ [20:49:26] bearND: this might be out of scope, but i don't understand the desire for having a transformation layer on top of the parser [20:49:50] bearND: thanks! [20:50:06] if we can just do it as part of rendering articles/mediawiki-text for mobile, seems like a one-stop-shop [20:50:19] bgerstle: When you say parser, what exactly are you referring to? MWAPI? [20:50:36] bearND: something like another endpoint in Parsoid, perhaps? [20:50:50] whatever turns wikitext/mediawiki/whatever-we-call-it to HTML [20:50:57] (or structured data) [20:50:57] (03PS2) 10Jdlrobson: Simplify Drawer hide listeners [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204972 (owner: 10Florianschmidtwelzow) [20:51:03] (03CR) 10Jdlrobson: [C: 032] Simplify Drawer hide listeners [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204972 (owner: 10Florianschmidtwelzow) [20:51:28] 10Gather, 3Gather Sprint Forward: Bug: Dismissing login drawer after clicking watchstar breaks watchstar - https://phabricator.wikimedia.org/T94682#1222339 (10Jdlrobson) a:5Jdlrobson>3Florian Fixed by https://gerrit.wikimedia.org/r/#/c/204972/ [20:51:47] it seems to me that the closer to the source we can specify our requirements, the more power we'll have to make the output exactly what we want [20:51:54] and have to resort to workarounds/hacks less [20:52:38] (03Merged) 10jenkins-bot: Simplify Drawer hide listeners [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204972 (owner: 10Florianschmidtwelzow) [20:52:55] bgerstle: as far as i understand Parsoid as of now is useful for for editing pages, not so much for page views [20:52:55] like i said, might be out of scope for this discussion, but either way i can't really talk too much more. i have 1:1 coming up that i have to prepare for [20:53:18] 10Gather, 3Gather Sprint Forward: Bug: Dismissing login drawer after clicking watchstar breaks watchstar - https://phabricator.wikimedia.org/T94682#1222345 (10Jdlrobson) 5Open>3Resolved [20:53:24] bearND: based on the name, and what of the API i saw, i inferred it as the "one place where format conversion happens" [20:53:25] bgerstle: The main desire for the content service was to remove unneeded content the apps are not displaying anyways [20:54:09] bearND: e.g. Parsoid is where we have all the "knowledge" about the MediaWiki DOM: https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec [20:54:16] why do we want another abstraction layer on top of that? [20:54:37] there will probably be a LOT of parsing logic/API w/in Parsoid that we'd want to use anyway [20:55:27] even stuff like "i want a list of all images that should be shown in the gallery , in order of appearance in the page" [20:55:59] 10Gather, 3Gather Sprint Forward, 10MediaWiki-Database, 7database: Bug: DB gather_list.gl_id autonumber is always odd - https://phabricator.wikimedia.org/T94512#1222351 (10Jdlrobson) @yurik any thoughts on this? [20:56:35] sorry, but i really should finish preparing for 1:1 now. bearND maybe we can pick this up another time. perhaps i can even get someone from the parsoid team to give me feedback on my idea [20:56:38] bgerstle: We could consider Parsoid output as the base layer for the service eventually, but for now it's probably too much to bite off [20:57:12] bgerstle: yeah, let's pick this up later. I've got another meeting coming up as well [20:57:37] sounds good [20:58:33] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Undefined index 'image' and 'public' in CollectionsList - https://phabricator.wikimedia.org/T96585#1222358 (10Jdlrobson) 5Open>3Resolved [20:59:49] 10Gather, 3Gather Sprint Forward, 3Mobile-Web-Design: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1222362 (10Jdlrobson) a:3Jdlrobson [21:00:12] bearND: kristenlans will be a little bit late for bugz [21:03:13] bearND, so I'm almost done cleaning up the mess from the junk merge [21:03:21] but got one major crash remaining [21:03:46] Specifically https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8303284 [21:03:54] Is that just https://phabricator.wikimedia.org/T94311 ? [21:04:37] anyone know if tfinc is around today? dr0ptp4kt kristenlans Deskana|Away ? [21:05:21] (03CR) 10Jdlrobson: Add flag collection button and confirm overlay (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [21:05:37] His calendar implies it [21:06:10] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Consolidate plain text extraction logic for article snippets - https://phabricator.wikimedia.org/T96610#1222368 (10bearND) p:5Triage>3Normal [21:06:32] bearND, dr0ptp4kt: Having hangout issues. :-( [21:06:41] Deskana: thx [21:07:15] (03CR) 10Jdlrobson: Add flag collection button and confirm overlay (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [21:07:34] bgerstle: I don't know [21:07:47] kristenlans: nvm i got him. thanks! [21:14:57] 10Wikipedia-Android-App: As a user, when I navigate to a page, I would like to see whether I have already saved that page. - https://phabricator.wikimedia.org/T96369#1222378 (10Deskana) What we could do with this is ensure that however the user gets to a page, the app tells the user that the page is saved in the... [21:15:34] 10Wikipedia-Android-App: As a user, when I navigate to a page, I would like to see whether I have already saved that page. - https://phabricator.wikimedia.org/T96369#1222382 (10KLans_WMF) p:5Triage>3Normal [21:15:52] bearND: I was actually wondering about the status of using Parsoid HTML for apps earlier [21:15:58] 10Wikipedia-Android-App: "Read more" block should not overlap with page content - https://phabricator.wikimedia.org/T96359#1222386 (10Deskana) [21:16:19] 10Wikipedia-Android-App: "Read more" block should not overlap with page content - https://phabricator.wikimedia.org/T96359#1222389 (10KLans_WMF) p:5Triage>3Normal [21:16:54] bgerstle, bearND: the rendering quality of Parsoid HTML is actually very high these days, and many of the legacy compat concerns that make it complex to phase it in on desktop don't really apply to apps [21:17:21] so I'd definitely encourage you to consider leveraging Parsoid output soon [21:17:52] 10Wikipedia-Android-App: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1222397 (10Deskana) @Niedzielski Do you want to write a patch to do this then? :-) [21:18:05] 10Wikipedia-Android-App: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1222400 (10Deskana) p:5Triage>3Normal [21:18:17] 10Wikipedia-Android-App: Added § symbol to 'See more' in the Image Gallery - https://phabricator.wikimedia.org/T93682#1222402 (10KLans_WMF) p:5Triage>3Normal [21:20:19] 10Wikipedia-Android-App: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1222414 (10Niedzielski) Heck yeah. I just didn't want to do it without product buy in (still learning my way around here! :) [21:20:29] 10Wikipedia-Android-App: Article Links Unclickable on Bottom of Page - https://phabricator.wikimedia.org/T96246#1222415 (10Deskana) @Etonkovidova Can you try to reproduce this? [21:20:35] 10Wikipedia-Android-App: Article Links Unclickable on Bottom of Page - https://phabricator.wikimedia.org/T96246#1222417 (10KLans_WMF) a:3Etonkovidova [21:21:14] (03PS7) 10Jdlrobson: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [21:21:16] (03PS1) 10Jdlrobson: Show hide button on collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205440 (https://phabricator.wikimedia.org/T94228) [21:21:29] 3Gather Sprint Forward, 5Patch-For-Review: Bug: Show/hide actions not showing correct toast message - https://phabricator.wikimedia.org/T96319#1222425 (10Jdlrobson) [21:21:30] 10Gather, 3Gather Sprint Forward, 3Mobile-Web-Design, 5Patch-For-Review: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1222424 (10Jdlrobson) [21:21:48] 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1222428 (10Jdlrobson) a:3Jdlrobson [21:22:58] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1222430 (10KLans_WMF) [21:23:32] 10Wikipedia-iOS-App: Automate polling of ITC, HockeyApp new+submitted+stable channel toggling - https://phabricator.wikimedia.org/T96559#1222433 (10dr0ptp4kt) [21:24:22] aharoni: you around? [21:24:38] bearND: Vandalismusmeldung [21:24:49] 10Wikipedia-Android-App, 3Mobile-App-Sprint-53-Android, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: android.content.res.Resources$NotFoundException: Unable to find resource ID #0x54e - https://phabricator.wikimedia.org/T94311#1222441 (10Krenair) Related? https://ticket.wikimedia.org/otrs/index.pl?Act... [21:24:55] aharoni: keen to get https://phabricator.wikimedia.org/T95547 resolved but not really sure how. [21:25:21] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Change messaging for blank collections - https://phabricator.wikimedia.org/T95740#1222444 (10Jdlrobson) [21:25:22] 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1222443 (10Jdlrobson) [21:25:42] 10Wikipedia-Android-App: Android app shows old versions of articles - https://phabricator.wikimedia.org/T94406#1222445 (10Deskana) 5Open>3stalled We're having trouble reproducing this, so we can't do much about it. :-( @Metrophil44 Can you try this once more with the latest alpha, and see if the problem is... [21:27:21] 10Gather, 3Gather Sprint Forward: Bug: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1222449 (10Jdlrobson) Some media queries would probably help here based on ios screen size. [21:28:09] bearND: I got an answer from @pginer [21:28:24] Mark Holmquist, Gilles or Gergo are people who could answer questions related to Mediaviewer [21:29:50] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#1222451 (10Deskana) 5Open>3stalled Marking as stalled because we are blocked on proceeding because of the lack of pagination in the geosearch API. [21:30:39] 6Mobile-Web: Hide chrome status bar when overlays are open - https://phabricator.wikimedia.org/T96297#1222458 (10Jdlrobson) [21:31:01] 6Mobile-Web: Hide chrome status bar when overlays are open - https://phabricator.wikimedia.org/T96297#1213622 (10Jdlrobson) cc @msyed @phuedx @kaldari @JKatzWMF [21:31:38] 10Wikipedia-iOS-App: The introduction for 'Save Pages' does not go away even if you switch articles. - https://phabricator.wikimedia.org/T96606#1222463 (10Deskana) p:5Triage>3Normal [21:34:51] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Merge 4.1.1 hot-fixes into master - https://phabricator.wikimedia.org/T96452#1222470 (10KLans_WMF) p:5Triage>3High [21:35:05] 10Wikipedia-iOS-App: Measure data upgrade behavior - https://phabricator.wikimedia.org/T96519#1222472 (10Deskana) 5Open>3declined a:3Deskana This won't actually deliver much user value now that the migration has happened and fewer and fewer people will see this, so I am marking this as declined. That said... [21:35:38] 10Wikipedia-iOS-App: Establish bolding for data migration alert view - https://phabricator.wikimedia.org/T96518#1222477 (10Deskana) 5Open>3declined a:3Deskana Thanks @deskana for your suggestion, but @deskana says no. This won't actually deliver much user value now that the migration has happened and fewe... [21:35:41] vibha: Thanks [21:35:50] 6Mobile-Web: Regression: Noticeable delay when rendering main menu - https://phabricator.wikimedia.org/T96617#1222480 (10Jdlrobson) 3NEW [21:36:40] 10Wikipedia-iOS-App: Pull to refresh erases forward navigation history - https://phabricator.wikimedia.org/T96450#1222488 (10KLans_WMF) p:5Triage>3Normal [21:37:06] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a user, I want to be able to cancel data migration - https://phabricator.wikimedia.org/T96429#1222492 (10KLans_WMF) [21:39:30] 10Wikipedia-iOS-App: Cannot share images using Messenger app - https://phabricator.wikimedia.org/T96420#1222497 (10Deskana) This is a problem with their app, not our app. @dr0ptp4kt is going to contact someone at Facebook to alert them to this problem. @etonkovidova is going to test this on Android to see if th... [21:41:48] 10Wikipedia-iOS-App: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1222503 (10Deskana) p:5Triage>3Normal [21:41:53] 10Wikipedia-iOS-App: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1222505 (10KLans_WMF) [21:43:14] (03CR) 10Kaldari: [C: 032] Increase WikiGrok sample size to 25% [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/205343 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [21:43:36] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1222509 (10Deskana) [21:44:26] (03CR) 10Kaldari: [C: 032] Increase WikiGrok sample size to 25% [extensions/WikiGrok] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/205409 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [21:44:37] (03CR) 10Kaldari: [C: 032] Increase WikiGrok sample size to 25% [extensions/WikiGrok] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205415 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [21:45:09] 10Wikipedia-iOS-App: 4.1.1(85) Formatting issues in collapsing boxes - https://phabricator.wikimedia.org/T96288#1222511 (10Deskana) The problem in the second screenshot is likely caused by the first column having a blank header, and the app is putting a comma after it. [21:45:18] 10Wikipedia-iOS-App: 4.1.1(85) Formatting issues in collapsing boxes - https://phabricator.wikimedia.org/T96288#1222513 (10KLans_WMF) p:5Triage>3Low [21:46:08] (03Merged) 10jenkins-bot: Increase WikiGrok sample size to 25% [extensions/WikiGrok] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/205409 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [21:46:15] (03Merged) 10jenkins-bot: Increase WikiGrok sample size to 25% [extensions/WikiGrok] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/205415 (https://phabricator.wikimedia.org/T94444) (owner: 10Kaldari) [21:47:45] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Releasing Sprint 54 Work Product - https://phabricator.wikimedia.org/T95969#1222525 (10KLans_WMF) p:5Triage>3Normal [21:47:56] gwicke: thanks for chiming in, I think you know I agree ;-) [21:48:50] 10Wikipedia-iOS-App: [Regression 4.1.1(79)] Image Gallery - flipping through images is not smooth when images are viewed for the first time - https://phabricator.wikimedia.org/T96201#1222537 (10Deskana) p:5Triage>3High [21:49:11] 10Wikipedia-Android-App, 3Mobile-App-Sprint-53-Android, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: android.content.res.Resources$NotFoundException: Unable to find resource ID #0x54e - https://phabricator.wikimedia.org/T94311#1222540 (10Dbrant) @Krenair Yep, and should be fixed once we release the ne... [21:50:18] bgerstle: yup, I know ;) Seriously, ping us any time re Parsoid HTML, more than happy to help you get started when it fits your priorities. [21:51:04] 10Gather, 3Gather Sprint Forward: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1222546 (10JKatzWMF) @rmoen we decided that including the blockers name might make it too personal. For the flyout, howabout: "Your collection [link to collection... [21:51:06] 10Wikipedia-iOS-App: App should allow pinch and zoom of article content (REDUX) - https://phabricator.wikimedia.org/T73004#1222547 (10KLans_WMF) p:5Triage>3Normal [21:51:12] 10Wikipedia-iOS-App: Cannot share images using Messenger app - https://phabricator.wikimedia.org/T96420#1222549 (10dr0ptp4kt) I emailed. [21:52:11] 10Wikipedia-iOS-App: Weird display of a Hebrew UI string on a Russian Wikipedia article - https://phabricator.wikimedia.org/T72490#1222551 (10Deskana) 5Open>3Resolved a:3Deskana We think this has been resolved since you filed it. @amire80, can you test and make sure if that's the case? [21:52:16] (03PS1) 10Robmoen: Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 [21:53:00] 6Mobile-Web: SearchOverlay should use View##events - https://phabricator.wikimedia.org/T96619#1222579 (10Jdlrobson) 3NEW [21:53:44] 10Wikipedia-iOS-App, 5Patch-For-Review: Clicking on a search result still shows previous content for a second or two - https://phabricator.wikimedia.org/T72422#1222589 (10Deskana) In spite of the above, I actually think this bug now exists in a different form; the lead image panel will continue to display the... [21:53:50] 10Wikipedia-iOS-App, 5Patch-For-Review: Clicking on a search result still shows previous content for a second or two - https://phabricator.wikimedia.org/T72422#1222590 (10KLans_WMF) p:5Triage>3Normal [21:53:57] (03CR) 10jenkins-bot: [V: 04-1] Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 (owner: 10Robmoen) [21:53:59] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1222592 (10rmoen) Screen cap of notification with the above patch {F121726} I think we could iterate on this and make it fancier. I'm still... [21:54:21] (03PS2) 10Robmoen: Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 [21:54:42] 10Wikipedia-iOS-App: iOS app: Little icons in articles should not be fuzzy (iOS 6 and 7) - https://phabricator.wikimedia.org/T72364#1222594 (10Deskana) 5Open>3Resolved a:3Deskana @etonkovidova will recheck quickly, but I'm pretty sure that this is resolved now. [21:55:10] Deskana: what do you have against fuzzy little icons? i think they're cute [21:55:13] 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1222598 (10Jdlrobson) Tests fail for the following reasons * Problem with the main menu rules When I click on "Nearby" in the main navigation... [21:55:34] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 7I18n: Find alternative solution for translating the app description other than using a single large message in our translation files - https://phabricator.wikimedia.org/T91971#1222601 (10Deskana) [21:55:43] jdlrobson: seriously i hate you guys for having cool sprint names [21:55:56] kristenlans: Deskana we gotta step it up and show them we can make cool code names for stuff too [21:55:59] 10Wikipedia-iOS-App: Put iOS store descriptions into localization files for TranslateWiki - https://phabricator.wikimedia.org/T71330#1222610 (10Deskana) [21:56:01] "link preview" i mean... COME ON [21:56:06] (03CR) 10jenkins-bot: [V: 04-1] Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 (owner: 10Robmoen) [21:56:12] http://www.withlove-rachel.com/wp-content/uploads/2013/06/gob-bluth.gif [21:56:38] 10Wikipedia-iOS-App, 7Easy: "Other" edit summary field should be a multi-line text box - https://phabricator.wikimedia.org/T71275#1222614 (10Deskana) p:5Triage>3Low [21:57:01] 10Wikipedia-iOS-App: iOS App: items too large in W menu on iPhone 4, causing menu to be scrollable - https://phabricator.wikimedia.org/T71703#1222617 (10Deskana) 5Open>3Resolved a:3Deskana This was resolved a long time ago. [21:58:44] 10Wikipedia-iOS-App, 7Easy: "Other" edit summary field should be a multi-line text box - https://phabricator.wikimedia.org/T71275#720093 (10KLans_WMF) @vbamba any thought on this from the design perspective? [22:00:44] bearND: running about 5 min behind [22:00:52] tfinc: ok [22:01:37] (03PS1) 10Jdlrobson: QA: Main menu is now a nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205447 (https://phabricator.wikimedia.org/T94156) [22:03:24] (03PS1) 10Jdlrobson: QA: Fix failing VisualEditor test due to toolbar changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205448 (https://phabricator.wikimedia.org/T94156) [22:03:31] 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1222640 (10Jdlrobson) a:3Jdlrobson [22:03:55] dbrant|food: Dmitry! Are you available for a hangout? [22:06:36] Deskana: hello!! can it be in ~1hr? [22:08:20] dbrant: Sure, I'll ping you again then [22:08:59] (03PS1) 10Jdlrobson: Don't expose the toggling init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205450 (https://phabricator.wikimedia.org/T94156) [22:13:42] mhurd dr0ptp4kt taking off for the day. hasta la manana [22:13:49] bgerstle: see ya! [22:15:04] peace bgerstle_afk [22:17:18] (03PS1) 10Jdlrobson: QA: Fix the browser tests to reflect anonymous editing on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205451 (https://phabricator.wikimedia.org/T94156) [22:22:49] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Special:MobileOptions throwing JS error from mobile.watchstar in stable - https://phabricator.wikimedia.org/T92657#1222703 (10Jdlrobson) a:3Jdlrobson [22:37:39] (03PS1) 10Jdlrobson: Don't pull in watchlist code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205455 (https://phabricator.wikimedia.org/T92657) [22:41:27] (03CR) 10jenkins-bot: [V: 04-1] Don't pull in watchlist code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205455 (https://phabricator.wikimedia.org/T92657) (owner: 10Jdlrobson) [22:45:34] dr0ptp4kt: batcave? [22:45:40] mhurd: in meeting [22:45:47] mhurd: until 4:30 [22:46:19] dr0ptp4kt: np. Gotta run a quick errand. Maybe hangout @4:30 then? [22:46:27] mhurd: plan! [22:46:35] Yay [22:55:12] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205455 (https://phabricator.wikimedia.org/T92657) (owner: 10Jdlrobson) [22:56:13] (03PS2) 10Jdlrobson: Don't pull in watchstar code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205455 (https://phabricator.wikimedia.org/T92657) [22:58:01] (03CR) 10jenkins-bot: [V: 04-1] Don't pull in watchstar code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205455 (https://phabricator.wikimedia.org/T92657) (owner: 10Jdlrobson) [23:00:25] dbrant: omw [23:03:00] (03PS3) 10Kaldari: Rewrite mobile login page to be less hacky and closer to core version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) [23:16:53] gwicke: Thanks for the info about Parsoid. I think it makes sense to check it out for the mobileapps nodejs service after we've got the basics working end-to-end from the apps. [23:17:06] gwicke: bgerstle_afk: Then we can just change the service implementation to use Parsoid without affecting the client compatibility. [23:17:51] gwicke: bgerstle_afk: On the apps side we should keep a list of features that we would take advantage of Parsoid functionality for. [23:18:06] gwicke: bgerstle_afk: The removal of parentheses is one example. Lead section transformation is another that comes to mind. [23:18:15] bearND: sounds good to me [23:18:28] template identification probably too [23:19:08] we are starting work on https://phabricator.wikimedia.org/T94890 (section retrieval / edit API) [23:19:36] just cc'ed you two [23:23:19] gwicke: Thank you! [23:25:32] jdlrobson: Can you explain the context of when gather-purpose would be used in https://gerrit.wikimedia.org/r/#/c/203836/2/i18n/en.json ? [23:26:10] jdlrobson: I don’t see any workflow that would actually lead to using it [23:26:35] hey bearND!! [23:26:47] dbrant: hello [23:27:16] bearND: would you have some time today/tomorrow to catch up via hangout? [23:27:38] dbrant: yes. Do you want a quick hangout now? [23:27:48] sure! [23:28:18] dbrant: pinging you [23:33:22] dr0ptp4kt: in batcave [23:33:40] mhurd: almost done with meeting [23:33:47] dr0ptp4kt: k no rush [23:38:34] (03PS1) 10Mhurd: Fix for too much whitespace beneath article title on landscape. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 [23:41:47] (03PS2) 10Mhurd: Fix for too much whitespace beneath article title on landscape. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 [23:52:48] (03CR) 10Jdlrobson: [C: 04-1] "Also consider cherry picking to master" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [23:55:30] (03CR) 10Jdlrobson: [C: 04-1] "The editor should be closed when user is blocked. The toast could be ignored - so better to bail out of the editor and show the toast to m" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [23:57:43] (03PS1) 10Kaldari: Making the Gather login and signup messages work in standard way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205473 [23:59:23] jdlrobson: Here’s the new login/signup page code and associated changes for Gather. Let me know what you think: https://gerrit.wikimedia.org/r/#/c/205473/ and https://gerrit.wikimedia.org/r/#/c/204977/ [23:59:46] jdlrobson: it has no hooks or hard-coded values in MF :)