[00:03:07] <grrrit-wm>	 (03PS3) 10Mhurd: Fix for too much whitespace beneath article title on landscape. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 
[00:17:54] <grrrit-wm>	 (03PS6) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 
[00:22:13] <grrrit-wm>	 (03PS7) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 
[00:25:04] <grrrit-wm>	 (03PS8) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 
[00:27:19] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Can't seem to get this working for some reason :-/" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx)
[00:36:57] <grrrit-wm>	 (03CR) 10BearND: "Some food for thought that came up during a discussion with bgerstle earlier." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant)
[00:47:50] <bearND>	 vibha: are you ook with the last screenshot on https://phabricator.wikimedia.org/T96398?
[00:47:54] <bearND>	 ok
[00:48:20] <grrrit-wm>	 (03PS11) 10Dbrant: [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 
[00:49:29] <vibha>	 bearND:  commented
[00:49:37] <bearND>	 dbrant: Cool Did you see my comment on that patch I submitted earlier?
[00:49:38] <vibha>	 https://phabricator.wikimedia.org/T96398
[00:49:44] <bearND>	 vibha: Thanks!
[00:49:54] <dbrant>	 bearND: yep! saw it / thinking about it
[00:50:15] <bearND>	 dbrant: ok, no rush, just wanted to make sure you saw it
[00:52:18] <bearND>	 vibha: ok, I'm adjusting the top margin since Deskana is away
[00:52:36] <vibha>	 bearND: thanks!
[00:59:58] <bearND>	 vibha: ok, https://phabricator.wikimedia.org/T96398 is updated now
[01:02:36] <grrrit-wm>	 (03PS2) 10BearND: Slightly decrease minimum text size on Share a Fact cards. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204835 (https://phabricator.wikimedia.org/T96398) (owner: 10Deskana)
[01:04:06] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Fix possible crash on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205225 (https://phabricator.wikimedia.org/T96532) (owner: 10Dbrant)
[01:04:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix possible crash on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205225 (https://phabricator.wikimedia.org/T96532) (owner: 10Dbrant)
[01:09:24] <grrrit-wm>	 (03PS2) 10BearND: Disable pulling of ToC before page has finished loading. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205234 (https://phabricator.wikimedia.org/T96358) (owner: 10Dbrant)
[01:09:31] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Disable pulling of ToC before page has finished loading. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205234 (https://phabricator.wikimedia.org/T96358) (owner: 10Dbrant)
[01:09:32] <vibha>	 bearND: commented
[01:09:33] <vibha>	 https://phabricator.wikimedia.org/T96398
[01:10:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Disable pulling of ToC before page has finished loading. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205234 (https://phabricator.wikimedia.org/T96358) (owner: 10Dbrant)
[01:11:02] <mhurd>	 vibha: Deskana|Away finally figured out that weird landscape white space bug - https://gerrit.wikimedia.org/r/205467
[01:11:11] <vibha>	 bearND:  https://phabricator.wikimedia.org/tag/mobile-app-sprint-55-android/
[01:11:17] <vibha>	 I moved some cards back to design signoff
[01:11:48] <vibha>	 I need to review them tomorrow. Once i review ill mark them as reviewed by design and move to the next column.
[01:12:07] <bearND>	 vibha: ok
[01:12:37] <vibha>	 Sorry, my punctuation is broken :)
[01:22:21] <Deskana>	 mhurd: Wait, what did I figure out?
[01:23:07] <mhurd>	 Deskana: lol sorry I meant to tag you
[01:48:18] <bearND|away>	 vibha: have you seen the ShareAFact email I sent you?
[02:09:13] <grrrit-wm>	 (03PS12) 10Dbrant: [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 
[03:39:27] <niedzielski>	 hey all. does ci run any android wikipedia tests? can someone point me to the jenkins job? i think it should be here but i'm not seeing it: https://integration.wikimedia.org/ci/view/Mobile/
[03:39:41] <legoktm>	 niedzielski: yep, one sec!
[03:39:49] <niedzielski>	 legoktm: thanks!
[03:40:21] <legoktm>	 https://github.com/wikimedia/integration-config/blob/master/jjb/job-templates.yaml#L343
[03:41:10] <legoktm>	 niedzielski: and https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/ is it on jenkins
[03:41:27] <legoktm>	 there's a bug open for converting it to gradle I think.
[03:42:22] <niedzielski>	 o man, that might explain some things. well thanks so much!
[04:04:33] <wikibugs>	 10Wikipedia-Android-App: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1223206 (10Niedzielski) a:3Niedzielski
[04:05:28] <grrrit-wm>	 (03PS1) 10Niedzielski: Tighten Up Drawer Drag Margins [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205522 
[04:17:21] <grrrit-wm>	 (03PS2) 10Niedzielski: Tighten Up Drawer Drag Margins [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205522 
[04:38:19] <grrrit-wm>	 (03CR) 10Niedzielski: Tighten Up Drawer Drag Margins (036 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205522 (owner: 10Niedzielski)
[04:42:49] <niedzielski>	 is there any way to open a review in gerrit, make changes and revisions _quietly_ until i push the "publish review" button? it seems to get published here pronto before i've been given the opportunity to add some annotation. worse, folks seem to be jumping at the chance to sign up to review the changes and add themselves before i've finished commenting.
[04:45:37] <bearND>	 niedzielski: are you talking about reviwers being added automatically when you push a new patch to gerrit?
[04:47:10] <niedzielski>	 bearND: i guess it's automatic. there seems to be a delay but maybe i just need to refresh
[04:49:07] <bearND>	 niedzielski: Yes, there's a delay. And yes, it's automatic. I'm not sure the delay is coming from. I guess it waits until jenkins-bot verifies the patch. But that's just a guess.
[04:49:25] <grrrit-wm>	 (03PS3) 10Niedzielski: Tighten Up Drawer Drag Margins [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205522 
[04:51:08] <niedzielski>	 bearND: hm, well yeah i wish i could make sure the diff translates to grrrit well and add a few comments before it gets published
[04:52:26] <bearND>	 niedzielski: We've got the convention here to add "WIP: " at the beginning of the commit message to indicate that the patch is not ready to be merged. Usually, then it doesn't get much review.
[04:52:33] <wikibugs>	 10Wikipedia-Android-App: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1223289 (10Niedzielski) Change is [[ https://gerrit.wikimedia.org/r/#/c/205522/ | in review ]].
[04:52:46] <legoktm>	 niedzielski: you can also use drafts
[04:53:01] <legoktm>	 but those are "private" to whoever you add as a reviewer until you publish them
[04:53:37] <legoktm>	 niedzielski: btw, have you read https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Auto-linking_and_cross-referencing ? :)
[04:55:57] <niedzielski>	 bearND: thanks, that's a little heavier weight than what i'm generally looking for but a good note for longer term work
[04:56:22] <niedzielski>	 legoktm: draft sounds perfect. thanks again
[04:56:31] <bearND>	 legoktm: How do you push a draft?
[04:57:39] <niedzielski>	 legoktm: i actually added the bug cross reference without the proper prefix looking at someone else's submission as an example :) i'll have to send them the same note. thanks for the tip!
[04:58:42] <grrrit-wm>	 (03PS4) 10Niedzielski: Tighten Up Drawer Drag Margins [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205522 (https://phabricator.wikimedia.org/T96341) 
[05:00:57] <wikibugs>	 10Wikipedia-Android-App, 5Patch-For-Review: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1223298 (10Niedzielski) ***RAISE THE ROOF***  Phabricator referenced the code review! Thanks, legoktm!  *Lowers roof back down gently.*
[05:02:09] <niedzielski>	 bearND: i haven't tried it yet but word on the web is it's "git review -D"
[05:02:24] <bearND>	 niedzielski: cool. Thanks.
[05:03:14] <niedzielski>	 bearND: if it works well, i'll probably do all my submissions that way and recommend a change to the grrrit readme
[05:04:46] <bearND>	 niedzielski: Sounds good. Let me know when you think this patch is ready to be reviewed. It's up to you. I can add it to this sprint (Mobile-App-Sprint-55-Android, which ends on Friday). Or we can wait until next sprint.
[05:05:40] <niedzielski>	 oh it's good to go now, thanks
[05:06:28] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1223300 (10bearND)
[05:07:21] <niedzielski>	 bearND: i would certainly hope it gets in by friday
[05:07:25] <bearND>	 niedzielski: it's now in the code review column of https://phabricator.wikimedia.org/tag/mobile-app-sprint-55-android/
[05:08:01] <bearND>	 niedzielski: I'll review it probably tomorrow
[05:08:25] <niedzielski>	 bearND: thanks!
[05:15:45] <bearND>	 niedzielski: Sure thing. Thank you for submitting the bug and also fixing it. :)
[05:16:07] <niedzielski>	 bearND: my pleasure! :)
[05:18:12] <legoktm>	 niedzielski: git push gerrit HEAD:refs/drafts/master
[05:19:32] <niedzielski>	 legoktm: thanks. i think i'll give "git review -D" a try unless you know that doesn't work
[05:20:40] <legoktm>	 I think that's right, I just don't use git-review
[05:23:12] <niedzielski>	 legoktm: oh, hm. ok, well that gives me some options. i'll figure out what works best on my end. thanks!
[05:23:29] <legoktm>	 :)
[05:33:49] <grrrit-wm>	 (03PS3) 10BearND: Slightly decrease minimum text size on Share a Fact cards. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204835 (https://phabricator.wikimedia.org/T96398) (owner: 10Deskana)
[05:37:36] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1223319 (10bearND) After the latest adjustment (patch set 3) it looks like this: {F125461}.
[06:07:03] <wikibugs>	 10Gather, 3Gather Sprint Forward, 10MediaWiki-Database, 7database: Bug: DB gather_list.gl_id autonumber is always odd - https://phabricator.wikimedia.org/T94512#1223331 (10Yurik) Back burner, swamped at the moment :(
[07:07:58] <joakino>	 morning!
[08:30:18] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Correct error handling for hide/show admin actions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204670 (https://phabricator.wikimedia.org/T96319) (owner: 10Jdlrobson)
[08:33:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correct error handling for hide/show admin actions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204670 (https://phabricator.wikimedia.org/T96319) (owner: 10Jdlrobson)
[08:35:58] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 04-1] Add url Special:Gather/id/{id} number (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204679 (owner: 10Jdlrobson)
[08:36:08] <grrrit-wm>	 (03PS2) 10Jhernandez: Add url Special:Gather/id/{id} number [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204679 (owner: 10Jdlrobson)
[08:36:21] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Add url Special:Gather/id/{id} number [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204679 (owner: 10Jdlrobson)
[08:36:35] <grrrit-wm>	 (03PS4) 10Jhernandez: Write log entries for showlist and hidelist to Special:Log [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204680 (https://phabricator.wikimedia.org/T95250) (owner: 10Jdlrobson)
[08:38:58] <grrrit-wm>	 (03PS2) 10Jhernandez: New collection opens collection editor interface [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204332 (https://phabricator.wikimedia.org/T94803) (owner: 10Jdlrobson)
[08:39:58] <phuedx>	 yo
[08:40:00] <phuedx>	 hey joakino 
[08:40:05] <joakino>	 hi phuedx
[08:40:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add url Special:Gather/id/{id} number [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204679 (owner: 10Jdlrobson)
[09:02:05] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Hygiene: Make it possible to edit a collection from any page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204162 (owner: 10Jdlrobson)
[09:05:28] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 04-1] "Minor issue with FIXME comment reference. +2able when fixed." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204332 (https://phabricator.wikimedia.org/T94803) (owner: 10Jdlrobson)
[09:05:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Make it possible to edit a collection from any page [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204162 (owner: 10Jdlrobson)
[09:06:24] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1223721 (10Jhernandez) @jdlrobson -1d because of confusing reference to this task on FIXME comment, when you fix that FIXME I'll merge it. Ping me!
[09:09:06] <phuedx>	 you 100% joakino ?
[09:09:34] <joakino>	 phuedx: yerp! making more frequent stops to the bathroom but fine enough :P
[09:09:44] <phuedx>	 :/
[09:09:51] <joakino>	 haha
[09:10:03] <joakino>	 i shouldn't probably have drunk coffee this morning
[09:10:31] <joakino>	 phuedx: it seems like yesterday was my 6 month mark in wmf
[09:10:40] <joakino>	 \o/
[09:11:42] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Make the private checkbox to be a public checkbox [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204667 (https://phabricator.wikimedia.org/T93391) (owner: 10Jdlrobson)
[09:13:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make the private checkbox to be a public checkbox [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204667 (https://phabricator.wikimedia.org/T93391) (owner: 10Jdlrobson)
[09:14:48] <phuedx>	 joakino: gratz!
[09:30:59] <grrrit-wm>	 (03PS3) 10Phuedx: Don't pull in watchstar code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205455 (https://phabricator.wikimedia.org/T92657) (owner: 10Jdlrobson)
[09:32:12] <grrrit-wm>	 (03CR) 10Phuedx: "PS3 simply fixes the two JSHint errors." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205455 (https://phabricator.wikimedia.org/T92657) (owner: 10Jdlrobson)
[09:33:20] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] QA: Main menu is now a nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205447 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[09:35:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: Main menu is now a nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205447 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[09:42:54] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Support making collections private [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204668 (https://phabricator.wikimedia.org/T94257) (owner: 10Jdlrobson)
[09:44:31] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] "I've given this a prod locally and it LGTM. However, we shouldn't close T92657 until this has gone out." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205455 (https://phabricator.wikimedia.org/T92657) (owner: 10Jdlrobson)
[09:45:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support making collections private [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204668 (https://phabricator.wikimedia.org/T94257) (owner: 10Jdlrobson)
[09:45:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't pull in watchstar code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205455 (https://phabricator.wikimedia.org/T92657) (owner: 10Jdlrobson)
[09:46:17] <phuedx>	 joakino: which sprint are you in?
[09:46:32] <joakino>	 phuedx: https://phabricator.wikimedia.org/tag/gather_sprint_forward/
[09:47:17] <phuedx>	 ta
[09:47:29] <wikibugs>	 3Gather Sprint Forward, 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1223853 (10phuedx)
[09:49:35] <wikibugs>	 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Special:MobileOptions throwing JS error from mobile.watchstar in stable - https://phabricator.wikimedia.org/T92657#1117484 (10phuedx) As I said on your patch, let's see if this fixes the bug as the bug is hard (impossible?) to reproduc...
[09:50:42] <phuedx>	 brb -- going to see how work's progressing upstairs
[10:00:27] <wikibugs>	 3Gather Sprint Forward: API public/perm inconsistencies - https://phabricator.wikimedia.org/T96665#1223884 (10Jhernandez) 3NEW
[10:02:22] <wikibugs>	 10Gather, 3Gather Sprint Forward: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1223894 (10Jhernandez) Merged the UI patch, it is right, but on my local instance can't change a private collection to public because it always shows private because `public` is an emp...
[10:02:33] <wikibugs>	 10Gather, 3Gather Sprint Forward: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1223896 (10Jhernandez)
[10:02:35] <wikibugs>	 3Gather Sprint Forward: API public/perm inconsistencies - https://phabricator.wikimedia.org/T96665#1223884 (10Jhernandez)
[10:07:53] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Swap X button for arrow for editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204635 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:08:53] <phuedx>	 back
[10:09:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Swap X button for arrow for editor overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204635 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:16:56] <grrrit-wm>	 (03PS3) 10Jhernandez: Make edits to title and description instanenous [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204642 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:16:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make edits to title and description instanenous [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204642 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:17:38] <grrrit-wm>	 (03CR) 10Jhernandez: Make edits to title and description instanenous (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204642 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:19:18] <grrrit-wm>	 (03PS4) 10Jhernandez: Make edits to title and description instanenous [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204642 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:19:46] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "Moved comment and rebased origin/master." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204642 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:20:53] <grrrit-wm>	 (03PS3) 10Jhernandez: Change button label for edit button in edit collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204643 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:21:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make edits to title and description instanenous [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204642 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:22:53] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Change button label for edit button in edit collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204643 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:24:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change button label for edit button in edit collection overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204643 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson)
[10:27:27] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1223970 (10Jhernandez) >>! In T95776#1214091, @gerritbot wrote: > Change 204659 had a related patch set uploaded (by Jdlrobson): > Save changes to members of collection only when do...
[10:28:01] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1223974 (10Jhernandez) cc/ @jdlrobson @jkatzwmf ^  Just to spark some conversation. I'll review the patch in a bit.
[10:28:15] <grrrit-wm>	 (03CR) 10Phuedx: "Should we be writing for tests for features that aren't under our control? The integration might be under our control but that's different" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205448 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[10:29:38] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-1] "Actually, don't the background and first scenario test what you're testing here?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205448 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[10:30:21] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1223975 (10Jhernandez)
[10:31:09] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Don't expose the toggling init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205450 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[10:32:49] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-1] QA: Fix the browser tests to reflect anonymous editing on beta labs (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205451 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[10:33:00] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Adjust messages for empty collections based on user viewing it [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205296 (https://phabricator.wikimedia.org/T95740) (owner: 10Jdlrobson)
[10:34:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adjust messages for empty collections based on user viewing it [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205296 (https://phabricator.wikimedia.org/T95740) (owner: 10Jdlrobson)
[10:40:10] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Adjust input based on available size [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205305 (https://phabricator.wikimedia.org/T93651) (owner: 10Jdlrobson)
[10:41:08] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: new collection entry design tweak - https://phabricator.wikimedia.org/T93651#1223986 (10Jhernandez) Merged. I don't like much the JS solution, is there any way of accomplishing the same with CSS?
[10:41:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adjust input based on available size [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205305 (https://phabricator.wikimedia.org/T93651) (owner: 10Jdlrobson)
[10:42:22] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Correctly identify collections as hidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205411 (https://phabricator.wikimedia.org/T95967) (owner: 10Jdlrobson)
[10:45:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correctly identify collections as hidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205411 (https://phabricator.wikimedia.org/T95967) (owner: 10Jdlrobson)
[10:46:11] <joakino>	 out to gym, bbl
[12:51:40] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1224253 (10dr0ptp4kt) The CI email address has been created, but the permissions have to be updated. I've requested the permissions update.
[14:00:54] <wikibugs>	 10Gather, 10Gather Sprint G: API: Inconsistent response for empty collections - https://phabricator.wikimedia.org/T95741#1224404 (10Anomie)
[14:00:56] <wikibugs>	 6Mobile-Web, 10MediaWiki-API: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - https://phabricator.wikimedia.org/T69054#1224405 (10Anomie)
[14:11:19] <grrrit-wm>	 (03CR) 10Bgerstle: [C: 031] "+1 because i want to keep the version overlay (very informative), but I would like to track some of this as tech debt so we can eventually" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204703 (owner: 10Fjalapeno)
[14:15:27] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Some map images cause the entire webview to be scrollable left to right - https://phabricator.wikimedia.org/T91702#1224474 (10BGerstle-WMF) > In mobile web we force the image to go no bigger than the viewport.  @jdlrobson what selectors do you apply that rule to?...
[14:26:33] <grrrit-wm>	 (03PS5) 10Phuedx: Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) 
[14:27:26] <grrrit-wm>	 (03CR) 10Phuedx: Beta: Add the Tags section (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx)
[14:28:20] <grrrit-wm>	 (03PS6) 10Phuedx: Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) 
[14:28:57] <grrrit-wm>	 (03PS7) 10Phuedx: Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) 
[14:29:38] <grrrit-wm>	 (03CR) 10Phuedx: "Ugh. Gerrit's parsing of Phabricator task links is awful." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx)
[14:29:59] <wikibugs>	 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1224482 (10phuedx)
[14:58:24] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-1] "A couple of really minor points inline. Otherwise this LGTM. I'd like /at least/ one more reviewer to prod this." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) (owner: 10Kaldari)
[15:00:27] <wikibugs>	 10Wikipedia-Android-App, 7I18n: Improve language selection - https://phabricator.wikimedia.org/T73136#1224543 (10AlexLippert) Any ETA when this will be worked on? - In the duplicate ticket https://phabricator.wikimedia.org/T87154 some where considering this to be a topic for the 2015 hackathon in May. - Pau Gi...
[15:14:21] <wikibugs>	 10Gather: Should be possible to add collections to categories - https://phabricator.wikimedia.org/T96691#1224636 (10Jdlrobson) 3NEW
[15:15:25] <wikibugs>	 10Gather: API: Allow sorting of a users collections by last modified - https://phabricator.wikimedia.org/T94762#1224645 (10Jdlrobson)
[15:15:34] <wikibugs>	 10Gather: API: Allow sorting of a users collections by last modified - https://phabricator.wikimedia.org/T94762#1172105 (10Jdlrobson)
[15:15:41] <wikibugs>	 10Gather: Collections should be sorted by modified time not alphabetically. - https://phabricator.wikimedia.org/T95786#1224649 (10Jdlrobson)
[15:16:47] <grrrit-wm>	 (03CR) 10Phuedx: "Jdlrobson: what's the status of the PageBanner extension and how it might be used to replace this?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194777 (https://phabricator.wikimedia.org/T90698) (owner: 10Bmansurov)
[15:17:20] <jdlrobson>	 phuedx: yo.
[15:17:26] <phuedx>	 yo
[15:17:27] <jdlrobson>	 Lead images cannot go live without stopping that api request
[15:17:53] <joakino>	 hellow!
[15:17:57] <jdlrobson>	 \o
[15:17:58] <joakino>	 hi jdlrobson
[15:18:24] <jdlrobson>	 hitting api for a page banner doubles are hits for js users
[15:18:30] <jdlrobson>	 so 200% page views = crash and burn
[15:19:32] <phuedx>	 jdlrobson: i don't disagree with you there
[15:19:35] <phuedx>	 see my earlier review
[15:20:48] <jdlrobson>	 phuedx: so https://gerrit.wikimedia.org/r/#/c/194777/14/javascripts/modules/bannerImage/APIBannerImageRepository.js doesn't move us any closer to that
[15:21:09] <jdlrobson>	 and doesn't solve the bug it links to
[15:21:17] <phuedx>	 that's a renamed file, that module already exists
[15:21:37] <jdlrobson>	 ok will it doesn't link up with the bug - this is not page load
[15:21:48] <jdlrobson>	 what's stopping us from just doing what we do for wikidata descriptions?
[15:22:07] <phuedx>	 jdlrobson: the rest of the patch is related to doing some work on the server side
[15:22:15] <phuedx>	 see configbannerimagewatchamacallit
[15:22:24] <phuedx>	 however, as i've already noted, i'm not happy with the implementation
[15:22:43] <phuedx>	 but there's no other solution forthcoming, so i wanted to pick up the conversation where we left off
[15:22:49] <phuedx>	 by conversation i mean patch
[15:22:53] <phuedx>	 /patch/
[15:23:02] <phuedx>	 fingers are working funny today
[15:23:17] <jdlrobson>	 if there's no other solutin forthcoming we shoudl stop working on it. we're wasting everyone's time
[15:23:30] <jdlrobson>	 we still need to solve image positioning remember
[15:24:58] <grrrit-wm>	 (03CR) 10Bgerstle: [C: 04-1] "not sure I agree w/ some changes made to the generate_git_commit_log function. we also discussed using the ENV variables to set DELIVER pr" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204651 (owner: 10Fjalapeno)
[15:25:24] <phuedx>	 i disagree -- i think lead images are a good feature and working on making them better would put more emphasis on the problem of positioning
[15:26:53] <phuedx>	 which many people, including you, have argued is a thing
[15:29:57] <jhobs>	 jdlrobson: hey jon, I'm trying to remove ZeroBanner's dependency on mobile.template, but I don't see the syntax to replace lines such as mw.template.get() within MF's repo
[15:32:40] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.0.6.3 Expanding Quick facts box and flipping to horizontal position  - the empty space for leading image is preserved. - https://phabricator.wikimedia.org/T91118#1224703 (10BGerstle-WMF) @Deskana @Mhurd just curious, are we going to support lead images in lands...
[15:34:21] <jdlrobson>	 hey jhobs
[15:34:30] <jdlrobson>	 it's all magical now!
[15:34:40] <jdlrobson>	 mw.template.get( moduleName, 'template.suffix' ) is all you need
[15:34:51] <jdlrobson>	 as long as suffix is hogan or mustache you'll get the template you need
[15:35:05] <jhobs>	 so all I need to do is remove ".render()" at the end?
[15:35:15] <jdlrobson>	 phuedx: I think we need a timeline for page banners.
[15:35:28] <jdlrobson>	 is the backend service a week away? a month away? a quarter away?
[15:35:32] <jhobs>	 jdlrobson: I have template data that needs to be applied to the template
[15:35:33] <joakino>	 jhobs: see https://www.mediawiki.org/wiki/Manual:HTML_templates#mw.template_.28client-side.29
[15:35:40] <joakino>	 kaldari did a good job updating those docs
[15:36:26] <jhobs>	 thanks!
[15:37:01] <jhobs>	 looks like we're already doing it the correct way. Not sure why we triggered some kind of test failure
[15:37:19] <jhobs>	 and the log link does not show the correct page anymore
[15:37:53] <phuedx>	 jdlrobson: i'm going to write an epic and maybe a couple of tasks around the getting-the-image-on-the-page side of things
[15:38:24] <phuedx>	 we already have tasks for the service -- i'm just not sure where we're at with 'em
[15:40:04] <jdlrobson>	 phuedx: sounds good. This could be another developer backlog mega task like the VE one
[15:40:40] <jdlrobson>	 but I think until there's that roadmap and we can guarantee we can get it out soon i think we'll just causing more problems for ourselves
[15:41:20] <phuedx>	 you say potato -- i say finding blockers and writing stories
[15:41:23] <wikibugs>	 6Mobile-Web, 5Patch-For-Review: Inconsistent responses for calling render function - https://phabricator.wikimedia.org/T96196#1224721 (10Jdlrobson) 5Open>3Resolved
[15:41:42] <jdlrobson>	 phuedx: in the phab board i've been trying to keep the backlog engineering board as "epics"
[15:41:50] <jdlrobson>	 and creating hidden columns for all the inner details
[15:42:13] <phuedx>	 not sure what i think about that
[15:42:19] <jdlrobson>	 my hope is to kill all the columns
[15:42:28] <phuedx>	 you mean hide them right?
[15:42:48] <jdlrobson>	 yeh
[15:42:51] <phuedx>	 provided that your keeping in sync with jonk and kristenlans, then okie poke
[15:42:52] <phuedx>	 ;)
[15:42:57] <jdlrobson>	 and then pull them into future sprints. we should have a catch up later
[15:44:22] <phuedx>	 gonna nip out and get an inner tube for my bike
[15:44:27] <phuedx>	 bbs
[15:48:05] <wikibugs>	 10Gather, 3Gather Sprint Forward: Pointer to collections should be shown whenever a new user adds a new collection. - https://phabricator.wikimedia.org/T95976#1224727 (10Jhernandez) a:3Jhernandez
[15:56:48] <mholloway>	 bearND: vibha pretty good progress on the higher-res images thing this morning, will send WIP code/screenshots after lunch!
[15:57:02] <bearND>	 mholloway: nice!
[15:57:25] <grrrit-wm>	 (03PS1) 10Jhernandez: Always point to collections menu item when creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205625 (https://phabricator.wikimedia.org/T95976) 
[15:58:09] <wikibugs>	 3Gather Sprint Forward: Deleting a collection should not have an associated route - https://phabricator.wikimedia.org/T96167#1224767 (10Jhernandez) a:3Jhernandez
[16:00:10] <grrrit-wm>	 (03CR) 10Bgerstle: [C: 04-1] "See comment about replacing the shoudlQueueMessages flag. Also, this code really ought to be tested to prevent regressions and at least s" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 (owner: 10Mhurd)
[16:01:58] <grrrit-wm>	 (03CR) 10Bgerstle: "Forgot to mention, this does seem to fix the issue, but I -1'd because I wasn't sure about the approach and whether we should try to simpl" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 (owner: 10Mhurd)
[16:03:41] <grrrit-wm>	 (03CR) 10Bgerstle: "just to be clear, it seems like the diff is doubly large because the added files are duplicated in the bundle.js file. unless we move JS i" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd)
[16:05:08] <grrrit-wm>	 (03CR) 10Bgerstle: "preliminary comments..." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd)
[16:09:40] <grrrit-wm>	 (03CR) 10Bgerstle: [C: 04-1] "consolidate Gruntfile js path variables" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd)
[16:23:35] <wikibugs>	 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 3Mobile-Web-Design, 5Patch-For-Review: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1224829 (10JKatzWMF)
[16:27:08] <wikibugs>	 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 3Mobile-Web-Design, 5Patch-For-Review: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1224833 (10JKatzWMF) @khammerstein i think we talked about putting this below the lead para
[16:27:45] <Technical_13>	 Ahhhh!!! Snakes on a plane!!!
[16:30:41] <grrrit-wm>	 (03CR) 10Bgerstle: "while the approach for injecting localized strings into JS would probably work, I'd like to discuss another approach which might be easier" (037 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd)
[16:34:53] <jhobs>	 yurik: I'm trying to push a change to gerrit and it keeps trying to use the wrong RSA private key (the one for the production server), despite me configuring my ssh config file for gerrit. Any ideas?
[16:35:54] <yurik>	 jhobs, are you using git review or some other way?
[16:36:02] <jhobs>	 git review
[16:36:13] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1224869 (10JKatzWMF) Hi Joaquin-I agree that it is a little suboptimal. Though I am starting to see instant saves on mobile devices, I think people are still used to the ability to...
[16:36:32] <yurik>	 jhobs, what happens if you rename prod key?
[16:36:54] <yurik>	 jhobs, could you copy paste your ssh config file?  use phabricator
[16:36:57] <yurik>	 gist
[16:37:02] <jhobs>	 yurik: I'm guessing it will fail, but I was looking for a more long-term solution
[16:37:14] <jhobs>	 yurik: lemme try renaming prod key and then i'll post config file
[16:37:40] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1224882 (10JKatzWMF) @jhernandez @jdlrobson ^^
[16:41:24] <jhobs>	 yurik: https://phabricator.wikimedia.org/P541
[16:41:33] <jhobs>	 yurik: and changing name of prod key just threw error
[16:41:43] <jhobs>	 (not found)
[16:42:42] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement: Source code review options - https://phabricator.wikimedia.org/T95749#1224893 (10BGerstle-WMF)
[16:43:10] <wikibugs>	 3Gather Sprint Forward: API public/perm inconsistencies - https://phabricator.wikimedia.org/T96665#1224896 (10Jdlrobson) Lets use perm exclusively.
[16:43:12] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1224894 (10BGerstle-WMF)
[16:43:25] <wikibugs>	 10Gather, 3Gather Sprint Forward: Gather pages not indexed by search engines - https://phabricator.wikimedia.org/T96689#1224907 (10Jdlrobson) a:3Jdlrobson
[16:45:30] <grrrit-wm>	 (03PS6) 10BearND: Display server status code & message to user in case of error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway)
[16:45:37] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Display server status code & message to user in case of error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway)
[16:45:48] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1224924 (10BGerstle-WMF)
[16:46:41] <JonKatz>	 rmoen are we deploying latest Gather today?
[16:47:31] <grrrit-wm>	 (03PS1) 10Jdlrobson: Use correct robots tag for Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205633 (https://phabricator.wikimedia.org/T96689) 
[16:48:42] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1224934 (10bearND) Just wanted to mention a way to test this as a dev is to replace the first line with the second one in WikipediaApp:          // Api api =...
[16:49:36] <wikibugs>	 10Gather, 3Gather Sprint Forward: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1224936 (10Jdlrobson) Yup. Not working for me either. Will take a look.
[16:50:40] <wikibugs>	 3Gather Sprint Forward, 6Mobile-Web, 10Analytics, 5Patch-For-Review: Update main menu schema to include collections for limn graphs - https://phabricator.wikimedia.org/T93690#1224938 (10Jdlrobson) @bmansurov could you review this? please pretty please! :)
[16:51:42] <grrrit-wm>	 (03CR) 10Jdlrobson: "@Yurik it was already doing this lookup... This is not introducing any new behaviour... if it's a bug yes we should update the API to do t" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson)
[16:51:43] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: On edit collection overlay, the box is labeled "public" instead of private - https://phabricator.wikimedia.org/T93391#1224942 (10JKatzWMF) @jdlrobson, I don't see this change on wmflabs:  {F147356}
[16:52:42] <grrrit-wm>	 (03CR) 10Jdlrobson: "@Yurik I can't block on API changes - this needs to happen. How can we get this merged on the short term?" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson)
[16:53:45] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1199458 (10bearND) Uh, I don't know how hard this would be for TWN. Gotta check with @Siebrand and @Nikerabbit. Created T96707 for that.
[16:53:54] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1224965 (10Legoktm) Ummm, why?
[16:55:00] <grrrit-wm>	 (03PS2) 10Jdlrobson: Don't expose the toggling init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205450 (https://phabricator.wikimedia.org/T94156) 
[16:55:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Don't expose the toggling init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205450 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[16:55:07] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: new collection entry design tweak - https://phabricator.wikimedia.org/T93651#1224975 (10JKatzWMF) @msyed please review and signoff if you feel its ready
[16:55:26] <grrrit-wm>	 (03CR) 10Jdlrobson: QA: Fix the browser tests to reflect anonymous editing on beta labs (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205451 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[16:56:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Display server status code & message to user in case of error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204308 (https://phabricator.wikimedia.org/T95070) (owner: 10Mholloway)
[16:57:38] <grrrit-wm>	 (03PS2) 10Jdlrobson: QA: Fix the browser tests to reflect anonymous editing on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205451 (https://phabricator.wikimedia.org/T94156) 
[16:59:18] <grrrit-wm>	 (03PS2) 10Jdlrobson: QA: Remove failing VisualEditor test due to toolbar changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205448 (https://phabricator.wikimedia.org/T94156) 
[17:02:50] <grrrit-wm>	 (03PS1) 10Jhobs: Remove mobile.templates dependency [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/205635 
[17:03:09] <jhobs>	 yurik: got it working ^
[17:04:27] <yurik>	 jdlrobson, that thing is a mess from perf perspective (
[17:04:32] <yurik>	 jhobs, what was the issue?
[17:04:42] <jhobs>	 dumb mac problem
[17:05:18] <jhobs>	 password locked the folder for my RSA keys but made it look like it was trying to use the production key specifically
[17:05:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Don't expose the toggling init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205450 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[17:05:25] <jhobs>	 turns out it wasn't
[17:05:57] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Not like this.. not like this. This breaks a bunch of stuff." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) (owner: 10Kaldari)
[17:06:21] <jhobs>	 also if either jdlrobson or yurik want to review that patch, it's a no-brainer
[17:06:44] <jdlrobson>	 yurik: it's already a mess. Help me make the API support it... but it's not going to blow up the server at this stage
[17:07:04] <jdlrobson>	 phuedx: i have some serious problems with kaldari's patch https://gerrit.wikimedia.org/r/#/c/204977/ :/
[17:09:50] <phuedx>	 jdlrobson: then could you put more information in your code review? what does it break? what's a better name for the type of message? info?
[17:10:11] <grrrit-wm>	 (03PS1) 10Jhernandez: Do not use a url for the "delete collection" confirmation dialog [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205637 (https://phabricator.wikimedia.org/T96167) 
[17:11:11] <yurik>	 jdlrobson, it will, the moment there is more than 1 person using gather :D
[17:11:11] <phuedx>	 jdlrobson: so styling and the message is wrong?
[17:11:25] <phuedx>	 ;)
[17:12:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Do not use a url for the "delete collection" confirmation dialog [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205637 (https://phabricator.wikimedia.org/T96167) (owner: 10Jhernandez)
[17:13:01] <yurik>	 jdlrobson, want to take https://gerrit.wikimedia.org/r/205635 ?
[17:13:16] <yurik>	 jhobs, i have no idea what it does )
[17:13:31] <jhobs>	 yurik: just removing an old dependency that isn't used
[17:17:06] <grrrit-wm>	 (03PS3) 10Phuedx: Simplify TOC replacement on desktop Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204454 (https://phabricator.wikimedia.org/T89223) (owner: 10Jdlrobson)
[17:18:30] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "Enabled boolean and added some tags. How do i see them? Seems related to parent categories that match ones in config? Would be good to hav" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx)
[17:19:03] <grrrit-wm>	 (03CR) 10Jdlrobson: Beta: Add the Tags section (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx)
[17:19:33] <grrrit-wm>	 (03CR) 10Phuedx: "PS3 is a rebase." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204454 (https://phabricator.wikimedia.org/T89223) (owner: 10Jdlrobson)
[17:26:54] <wikibugs>	 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1225012 (10Amire80)
[17:29:21] <wikibugs>	 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1225020 (10Amire80) You don't have to be a native English speaker :)  All the above messages have imperative verbs, which tell the users to do something. In some languages the...
[17:34:42] <wikibugs>	 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1225027 (10Jdlrobson) Some examples would help.. Add $1 to a collection of pages you can share with the world!  The imperative is 'add' right - but I assume the $1 is the prob...
[17:36:12] <wikibugs>	 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1225033 (10Amire80) No, just "Add".
[17:37:06] <wikibugs>	 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1225035 (10Jdlrobson) Also what's stopping someone adding a GENDER keyword in another language? Why does it need to be in the English where it doesn't apply?
[17:37:21] <wikibugs>	 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1225037 (10Amire80) The imperatives refer to the user. In (transliterated) Hebrew, if the user is a man, "Add" is "hosef" and for a woman it's "hosifi".
[17:40:02] <wikibugs>	 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1225052 (10Amire80) >>! In T95547#1225035, @Jdlrobson wrote: > Also what's stopping someone adding a GENDER keyword in another language? Why does it need to be in the English...
[17:40:24] <wikibugs>	 10Wikipedia-Android-App: Article Links Unclickable on Bottom of Page - https://phabricator.wikimedia.org/T96246#1225054 (10Etonkovidova) Checked 'George Boole' article on Android 4.4.4 Nexus5 with **2.0-alpha-2015-04-13.** The last sections of the article - External links(with references to Biography portal and...
[17:43:12] <vibha>	 mholloway: thanks
[17:43:54] <wikibugs>	 10Wikipedia-Android-App: Remove "read next" from the beta app - https://phabricator.wikimedia.org/T96709#1225056 (10Deskana) 3NEW
[17:46:53] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx)
[17:48:11] <grrrit-wm>	 (03CR) 10Siebrand: Beta: Add the Tags section (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx)
[17:48:34] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: new collection entry design tweak - https://phabricator.wikimedia.org/T93651#1225067 (10Jdlrobson) Yeh,.. the js kinda blows but Im guessing you'll ned flex box or something for this to work in css only.
[17:48:39] <grrrit-wm>	 (03CR) 10Yurik: [C: 04-1] "ok, do the minor fix for now, and create a HIGH importance task to make sure you never use Title::exists() or any other DB-query causing c" (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson)
[17:48:51] <yurik>	 jdlrobson, ^
[17:49:09] <yurik>	 rmoen, joakino ^
[17:49:22] <grrrit-wm>	 (03CR) 10Phuedx: Beta: Add the Tags section (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx)
[17:50:43] <yurik>	 jdlrobson, not sure if you saw it - https://phabricator.wikimedia.org/T93295
[17:50:55] <yurik>	 jdlrobson, sorry, https://gerrit.wikimedia.org/r/205300
[17:51:00] <jdlrobson>	 yurik: thanks for the constructive suggestion! Will do that and add a comment to bug
[17:51:12] <yurik>	 jdlrobson, you need a new bug for that
[17:51:18] <jdlrobson>	 and never knew about $wgDebugToolbar = true so thanks
[17:51:36] <yurik>	 ))
[17:52:26] * yurik debates pros and cons in making jdlrobson a backend engineer... 
[17:54:32] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1225076 (10Vibhabamba) @bearND @dbrant  In the most current prototype, the actual width of the image area is decreasing with the animation. The image area must...
[17:55:10] <grrrit-wm>	 (03CR) 10Mhurd: Fix for too much whitespace beneath article title on landscape. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 (owner: 10Mhurd)
[17:55:15] <mhurd>	 bgerstle: ^
[17:56:57] <grrrit-wm>	 (03PS3) 10Jdlrobson: QA: Fix the browser tests to reflect anonymous editing on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205451 (https://phabricator.wikimedia.org/T94156) 
[17:57:14] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Don't expose the toggling init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205450 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[17:57:22] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Don't expose the toggling init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205450 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[17:59:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't expose the toggling init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205450 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[18:00:07] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Simplify TOC replacement on desktop Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204454 (https://phabricator.wikimedia.org/T89223) (owner: 10Jdlrobson)
[18:01:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Simplify TOC replacement on desktop Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204454 (https://phabricator.wikimedia.org/T89223) (owner: 10Jdlrobson)
[18:07:10] <grrrit-wm>	 (03CR) 10Bgerstle: Fix for too much whitespace beneath article title on landscape. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 (owner: 10Mhurd)
[18:08:57] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] QA: Fix the browser tests to reflect anonymous editing on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205451 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[18:10:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: Fix the browser tests to reflect anonymous editing on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205451 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson)
[18:38:48] <grrrit-wm>	 (03PS8) 10Phuedx: Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) 
[18:40:34] <grrrit-wm>	 (03CR) 10Phuedx: "Jdlrobson: How you like dem docs?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx)
[18:42:36] <bd808>	 https://etherpad.wikimedia.org/p/Reading
[18:49:45] <grrrit-wm>	 (03CR) 10Mhurd: Fix for too much whitespace beneath article title on landscape. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 (owner: 10Mhurd)
[18:50:06] <mhurd>	 bgerstle: ^
[18:55:53] <JonKatz>	 bgerstle i can't add to hangout, but we will have scrumaster and be agile
[18:56:12] <bgerstle>	 k, thanks JonKatz 
[18:56:55] <jdlrobson>	 i'm agile as f**k
[18:57:01] <wikibugs>	 3Gather Sprint Forward, 6Mobile-Web, 10Analytics, 5Patch-For-Review: Update main menu schema to include collections for limn graphs - https://phabricator.wikimedia.org/T93690#1225143 (10bmansurov) I will once I get limn working locally (hopefully tomorrow).
[18:57:04] <jdlrobson>	 (in joke)
[19:00:32] <phuedx>	 kaldari, bmansurov: running now -- it's /very/ slow
[19:00:38] <phuedx>	 16 seconds between writes
[19:00:52] <kaldari>	 awesome, i’ll keep an eye
[19:01:01] <bmansurov>	 phuedx: cool, maybe we should look into doing a batch update
[19:01:21] <phuedx>	 bmansurov: it's only ~90 writes -- shouldn't be terrible
[19:01:32] <phuedx>	 just something to bear in mind
[19:01:35] <bmansurov>	 phuedx: oh ok, np then
[19:03:59] <phuedx>	 kaldari, bmansurov: exception occurs when trying to remove the album claim
[19:04:19] <bmansurov>	 phuedx: oh shoot
[19:04:23] <phuedx>	   File "/Users/phuedx/Code/pywikibot-core/pywikibot/site.py", line 5772, in removeClaims
[19:04:23] <phuedx>	     params['claim'] = '|'.join(claim.snak for claim in claims)
[19:04:23] <phuedx>	 TypeError: sequence item 0: expected string or Unicode, NoneType found
[19:04:48] <legoktm>	 o.O
[19:06:05] <legoktm>	 phuedx: what claim objects are you passing it?
[19:06:58] <grrrit-wm>	 (03CR) 10Jdlrobson: "What if I request prop=info too and check id?" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson)
[19:07:04] <phuedx>	 legoktm: https://github.com/phuedx/wikigrok-aggregation-test/blob/develop/wikigrok-aggregation-test.py#L99-L106
[19:07:25] <legoktm>	 yeah that won't work
[19:07:42] <legoktm>	 you have to pass the claim object from item.get('claims') (or however) to removeClaims
[19:12:02] <phuedx>	 legoktm: ta
[19:13:55] <legoktm>	 also, all the people in #pywikibot are super helpful :)
[19:16:25] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "> The editor should be closed when user is blocked. The toast could be ignored - so better to bail out of the editor and show the toast to" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow)
[19:26:14] <grrrit-wm>	 (03CR) 10Yurik: "If you are using generator=listpages, you don't need to do anything else - just look at the "missing" key, that should tell you if the pag" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson)
[19:37:39] <phuedx>	 legoktm: thanks for the protip, fixed the bot and it's running nicely
[19:37:46] <legoktm>	 woot
[19:38:35] <bd808>	 bgerstle: https://office.wikimedia.org/w/index.php?title=Ambiguous_names&diff=144835&oldid=144820
[19:38:40] <phuedx>	 kaldari: ^
[19:38:42] <bd808>	 you weren't on there
[19:39:05] <phuedx>	 kaldari: ^^^^ even ;)
[19:40:20] <kaldari>	 looking
[19:44:39] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1225197 (10Mholloway) I've got some WIP code I'll send to Gerrit in a moment.  Below are some screenshots showing...
[19:44:53] <bearND>	 One more big change I forgot to mention is that Dan and Moiz are joining Tomasz and Wes in the Search & Discovery org.
[19:47:53] <grrrit-wm>	 (03PS1) 10Mholloway: [WIP] Use a higher-res image if available and set it to the width of the column text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205649 (https://phabricator.wikimedia.org/T94646) 
[19:55:49] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1225217 (10Vibhabamba) @mholloway screenshots look great.
[19:56:55] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1168946 (10Vibhabamba) An APK would be great so  @Etonkovidova and I can do some edge case t...
[20:11:30] <grrrit-wm>	 (03CR) 10Kaldari: "@jdlrobson: How about I change the color of warning messages from yellow to grey? That way only errors will look like you've done somethin" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) (owner: 10Kaldari)
[20:14:33] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1225289 (10Mholloway) @Vibhabamba I'll probably want @bearND to have a quick look at the cod...
[20:18:14] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Remove mobile.templates dependency [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/205635 (owner: 10Jhobs)
[20:19:18] <wikibugs>	 10Wikipedia-iOS-App: Tapping top of an article in landscape incorrectly presents lead image in gallery - https://phabricator.wikimedia.org/T96715#1225301 (10BGerstle-WMF) 3NEW
[20:19:30] <bgerstle>	 Deskana|Away: mhurd ^
[20:22:31] <phuedx>	 heading off for the night
[20:26:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove mobile.templates dependency [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/205635 (owner: 10Jhobs)
[20:33:55] <bgerstle>	 vibha: where did coreyfloyd leave you on the prototypes?
[20:33:55] <bgerstle>	 is there something we should be doing to try to get them ready for usability testing by end of the sprint?
[20:35:31] <wikibugs>	 10Wikipedia-iOS-App, 7I18n: Update translatewiki to use GitHub instead of Gerrit for iOS message groups - https://phabricator.wikimedia.org/T96707#1225340 (10bearND)
[20:37:59] <bearND>	 mholloway: are you up to do a code review of https://gerrit.wikimedia.org/r/#/c/204835/ ?
[20:38:57] <bgerstle>	 bearND: somehow i knew you'd get involved w/ that ticket
[20:39:07] <bgerstle>	 do you have some kind of spider sense for translation-related things?
[20:39:37] <bearND>	 bgerstle: I just happened to see the phab task notification on IRC
[20:39:48] <bearND>	 pure conincidence
[20:39:49] <bgerstle>	 that was earlier this morning though
[20:40:04] <bgerstle>	 admit it, you're spying on us!
[20:40:36] <marktraceur>	 Anyone seen jdlrobson recently? He's now about ten minutes late for a meeting.
[20:40:54] <bearND>	 yes, that was thi smonring when I first responded to it. And no, I wouldn't call it spying, lol
[20:40:57] <bgerstle>	 marktraceur: i hear he'll magically appear if you say his name 3 times
[20:41:06] <marktraceur>	 jdlrobson jdlrobson jdlrobson
[20:41:24] * bgerstle dramatic pause
[20:42:05] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1225355 (10BGerstle-WMF) a:3BGerstle-WMF
[20:43:04] <marktraceur>	 No dice.
[20:44:37] <bearND>	 bgerstle: I created a blocking task for the TWN stuff because I think it deserves one. I'll let you answer legoktm's question. My spidey senses tell me that he wants to know why you'd want to move from Gerrit to GitHub
[20:44:54] <bgerstle>	 hrm
[20:45:12] <legoktm>	 hi
[20:45:51] <legoktm>	 I can't imagine why you'd want to move to a closed souce platform when we've invested a large amount of effort into gerrit and Phabricator.
[20:46:05] <wikibugs>	 10Wikipedia-Android-App: Android app shows old versions of articles - https://phabricator.wikimedia.org/T94406#1225358 (10Etonkovidova) Yes, the problem is present for 2.0-alpha-2015-04-13. But it looks trickier than I thought. The steps for reproducing the bug are applied **only to couple of first edits**   1....
[20:53:06] <rmoen>	 jdlrobson: hey so any changes that need to be cherry picked? Does https://gerrit.wikimedia.org/r/#/c/205317/1 require the core change? 
[20:53:35] <mhurd>	 bgerstle: hey time for batcave?
[20:55:37] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1225385 (10BGerstle-WMF) @Legoktm I'm assuming that you're asking "why GitHub?"   we tried to lay out the pros/cons in an email thread started by @dr0ptp4kt on mobile-tech with th...
[20:56:00] <bgerstle>	 legoktm: hey, just saw this. i responded ^
[20:56:20] <bgerstle>	 mhurd yeah, brt
[20:58:42] <jdlrobson>	 rmoen: so just replying to your mail now as i;m confused
[20:58:53] <jdlrobson>	 so we are fast forwarding to master right?
[20:59:10] <rmoen>	 I assume so
[20:59:19] <jdlrobson>	 if you do > git log between now and the current commit you can work out dependencies by looking for Dependency: in the commit message
[21:00:13] <jdlrobson>	 Mon 6 was last patch with a dependency so I would hazard a guess that nope nothing needed to be cherry picked
[21:01:09] <rmoen>	 jdlrobson: Yeah i looked and the only thing i'm testing is https://gerrit.wikimedia.org/r/#/c/205317/1
[21:01:37] <rmoen>	 looks like the core change merged on the 17th
[21:01:38] <jdlrobson>	 oh shoot good catch
[21:01:55] <jdlrobson>	 yeh i'd check that doesn't explode things
[21:02:12] <rmoen>	 yeah doing that now, kaldari are you deplying something?  if so plz go first :)
[21:05:00] <rmoen>	 jdlrobson: ok so api changes are in 1.26wmf1 so i think we are good there.
[21:09:17] <Krenair>	 bearND, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8305911
[21:14:15] <bearND>	 Krenair: looks like https://phabricator.wikimedia.org/T76952 to me.
[21:14:53] <jdlrobson>	 rmoen: i was under the understanding that JK wanted https://phabricator.wikimedia.org/T95635 to go out.. but that patch still needs fixing up by you
[21:14:55] <bearND>	 Krenair: wow, that's a lot of occurrences. We should bump it up in priority
[21:15:29] <rmoen>	 jdlrobson: that can be a swat ? 
[21:15:53] <grrrit-wm>	 (03PS8) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) 
[21:16:03] <jdlrobson>	 yeh i'll add that to the email - but yeh it should be super trivial to fix up.
[21:16:08] <wikibugs>	 10Wikipedia-Android-App: Crashes caused by android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#1225411 (10bearND) p:5Normal>3High
[21:16:12] <rmoen>	 jdlrobson: we have from 2-3pm so i'm trying to get master on test wiki
[21:16:17] <jdlrobson>	 k
[21:16:42] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow)
[21:17:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow)
[21:19:12] <grrrit-wm>	 (03PS3) 10Jdlrobson: New collection opens collection editor interface [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204332 (https://phabricator.wikimedia.org/T94803) 
[21:21:39] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1225427 (10Legoktm) It would have been helpful if you had discussed this on a public mailing list so other people who are interested could have commented or even read the discussi...
[21:23:38] <wikibugs>	 3Gather Sprint Forward: API public/perm inconsistencies - https://phabricator.wikimedia.org/T96665#1225429 (10Jdlrobson) a:3Jdlrobson
[21:25:57] <rmoen>	 jdlrobson: master should be on testwiki now
[21:26:26] <Krenair>	 bearND, thanks for prioritising it
[21:26:40] <Krenair>	 bearND, I think the crash reports should in general be prioritised a lot higher
[21:27:42] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Improve error handling for "Editor not available" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) 
[21:29:35] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1225432 (10Krenair) Obviously mobile-tech requires a WMF Google domain account, but that Google Doc does as well. If you're trying to encourage community contributions this is not...
[21:30:14] <jdlrobson>	 rmoen: i may need you to cherry pick a pretty bad bug i've just discovered
[21:30:38] <wikibugs>	 10Wikipedia-Android-App: Margins and default type size on Android need to be increased. - https://phabricator.wikimedia.org/T96719#1225433 (10Vibhabamba) 3NEW a:3bearND
[21:30:46] <grrrit-wm>	 (03PS1) 10Jdlrobson: Editing shouldn't make a collection private [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205724 (https://phabricator.wikimedia.org/T94257) 
[21:30:55] <jdlrobson>	 ^ rmoen this one
[21:30:59] <rmoen>	 looking
[21:31:50] <rmoen>	 jdlrobson: eek
[21:32:23] <FlorianSW>	 jdlrobson: would be great if you could take a look at https://gerrit.wikimedia.org/r/#/c/204716/8/javascripts/modules/editor/EditorOverlay.js (see my comment). I can't find out, why the parameters of the message aren't parsed :/ I'm not sure, if this is a bug or just something i overlook :) I would be happy if you could do it in a free minute, i go to bed now, it's late :D
[21:32:40] <rmoen>	 jdlrobson: so uh, now what?  start deployment over? 
[21:33:20] <wikibugs>	 10Wikipedia-iOS-App: Make web/JS errors cause assertions/exceptions in debug config. - https://phabricator.wikimedia.org/T96720#1225444 (10BGerstle-WMF) 3NEW
[21:34:03] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Remove unused toArray method [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205725 
[21:34:04] <grrrit-wm>	 (03PS1) 10Jdlrobson: Don't surface 'public' property in addition to 'perm' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) 
[21:34:06] <grrrit-wm>	 (03PS4) 10Mhurd: Fix for too much whitespace beneath article title on landscape. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 
[21:34:17] <jdlrobson>	 rmoen: was hoping you could just cherry pick it at the end if time
[21:34:53] <jdlrobson>	 or we can abandon entire deployment or cherry pick it tomorrow. Obviously first would be preferable
[21:35:00] <jdlrobson>	 can ask JK about which of 2nd options is best
[21:36:19] <jdlrobson>	 FlorianSW: will do!
[21:36:38] <FlorianSW>	 jdlrobson: thanks :)
[21:36:42] <jdlrobson>	 FlorianSW: so parsing isn't possible in client on mobile web
[21:36:54] <jdlrobson>	 well.. there's limited parsing from what i remember
[21:37:05] <FlorianSW>	 jdlrobson: :o really? :/
[21:37:23] <jdlrobson>	 FlorianSW: i'm double checking
[21:37:50] <wikibugs>	 10Wikipedia-Android-App, 7I18n, 3Mobile-App-Sprint-56-Android: Special case Traditional and Simplified Chinese in all language handling - https://phabricator.wikimedia.org/T62743#1225480 (10wctaiwan) 5stalled>3Open
[21:39:21] <grrrit-wm>	 (03PS2) 10Jdlrobson: Don't surface 'public' property in addition to 'perm' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) 
[21:39:47] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] Editing shouldn't make a collection private [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205724 (https://phabricator.wikimedia.org/T94257) (owner: 10Jdlrobson)
[21:39:53] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "hold off this for a little bit - it may become useful again if we start to integrate with pages more." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205725 (owner: 10Jdlrobson)
[21:40:57] <grrrit-wm>	 (03CR) 10Bgerstle: [C: 032] Fix for too much whitespace beneath article title on landscape. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 (owner: 10Mhurd)
[21:41:36] <grrrit-wm>	 (03CR) 10Bgerstle: [V: 032] Fix for too much whitespace beneath article title on landscape. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205467 (owner: 10Mhurd)
[21:41:39] <rmoen>	 jdlrobson: pm
[21:44:13] <wikibugs>	 10Wikipedia-Android-App, 7I18n, 3Mobile-App-Sprint-56-Android: Special case Traditional and Simplified Chinese in all language handling - https://phabricator.wikimedia.org/T62743#1225492 (10wctaiwan)
[21:45:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Editing shouldn't make a collection private [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205724 (https://phabricator.wikimedia.org/T94257) (owner: 10Jdlrobson)
[21:45:44] <wikibugs>	 10Wikipedia-Android-App: Margins and default type size on Android need to be increased. - https://phabricator.wikimedia.org/T96719#1225495 (10Vibhabamba) @deskana, This would be a great candidate for Sprint 56 in Android?
[21:46:30] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1225500 (10Vibhabamba) @bearND @dbrant  In the most current prototype, the actual width of the image area is decreasing with the animation. The image area must...
[21:46:57] <wikibugs>	 10Wikipedia-Android-App, 7I18n, 3Mobile-App-Sprint-56-Android: Special case Traditional and Simplified Chinese in all language handling - https://phabricator.wikimedia.org/T62743#1225501 (10wctaiwan) I've edited the task description. Let me know if any additional clarification is needed. (I'm testing this us...
[21:49:10] <wikibugs>	 6Mobile-Web, 10MediaWiki-Authentication-and-authorization: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1225504 (10Jdlrobson) Add the targets and add me as a reviewer and I'll merge  I ran the autologin script on mobile and it doesn't do anythin...
[21:51:20] <grrrit-wm>	 (03PS1) 10Legoktm: Further cleanup for core API change [extensions/MobileFrontend] (REL1_25) - 10https://gerrit.wikimedia.org/r/205745 (https://phabricator.wikimedia.org/T96595) 
[21:51:22] <grrrit-wm>	 (03PS1) 10Legoktm: Further cleanup for core API change [extensions/ZeroPortal] (REL1_25) - 10https://gerrit.wikimedia.org/r/205746 (https://phabricator.wikimedia.org/T96595) 
[21:51:42] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1225524 (10Vibhabamba) - Tapping anywhere within the card needs to go to the article. - Ken burns zoom for preview cards needs to be reduced to 50% of current...
[21:58:51] <grrrit-wm>	 (03PS1) 10Mhurd: Remove run-time css sync so we have more control over css deployment. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205760 
[22:02:05] <grrrit-wm>	 (03PS9) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 
[22:05:18] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Further cleanup for core API change [extensions/MobileFrontend] (REL1_25) - 10https://gerrit.wikimedia.org/r/205745 (https://phabricator.wikimedia.org/T96595) (owner: 10Legoktm)
[22:05:25] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Further cleanup for core API change [extensions/ZeroPortal] (REL1_25) - 10https://gerrit.wikimedia.org/r/205746 (https://phabricator.wikimedia.org/T96595) (owner: 10Legoktm)
[22:06:28] <grrrit-wm>	 (03PS10) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 
[22:06:53] <grrrit-wm>	 (03PS1) 10Jdlrobson: Style mw.notify in the same way as toasts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205763 (https://phabricator.wikimedia.org/T66565) 
[22:06:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Further cleanup for core API change [extensions/MobileFrontend] (REL1_25) - 10https://gerrit.wikimedia.org/r/205745 (https://phabricator.wikimedia.org/T96595) (owner: 10Legoktm)
[22:07:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Further cleanup for core API change [extensions/ZeroPortal] (REL1_25) - 10https://gerrit.wikimedia.org/r/205746 (https://phabricator.wikimedia.org/T96595) (owner: 10Legoktm)
[22:08:36] <grrrit-wm>	 (03PS3) 10Jdlrobson: Don't surface 'public' property in addition to 'perm' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) 
[22:09:30] <grrrit-wm>	 (03PS11) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 
[22:09:36] <grrrit-wm>	 (03PS2) 10Jdlrobson: Do not use a url for the "delete collection" confirmation dialog [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205637 (https://phabricator.wikimedia.org/T96167) (owner: 10Jhernandez)
[22:10:15] <bgerstle>	 mhurd: dr0ptp4kt out for a bit, later!
[22:11:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Do not use a url for the "delete collection" confirmation dialog [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205637 (https://phabricator.wikimedia.org/T96167) (owner: 10Jhernandez)
[22:13:56] <grrrit-wm>	 (03PS12) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 
[22:14:47] <grrrit-wm>	 (03PS8) 10Jdlrobson: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 
[22:15:24] <mhurd>	 bgerstle_afk: i've fixed all the things you pointed out except the lazy NSUrlProtocol bits. totally agree with that - starting on it now
[22:16:01] <Krenair>	 jdlrobson, you created #Reading-admin without going through the process?
[22:16:21] <Krenair>	 Or is search just failing me?
[22:18:02] <Deskana>	 PROCESS
[22:22:38] <grrrit-wm>	 (03CR) 10Mhurd: "Brain, I think fixed all the things you pointed out except the lazy NSURLProtocol bits. Totally agree with that though - starting on it no" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd)
[22:23:01] <grrrit-wm>	 (03PS5) 10Robmoen: Add moderation expectations to Special:GatherLists for admins [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 
[22:26:23] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Simplify PageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 
[22:28:32] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1225822 (10Jdlrobson)
[22:29:00] <wikibugs>	 10Gather, 3Gather Sprint Forward: Use auto-completable URLs for Special:Gather - https://phabricator.wikimedia.org/T94527#1225823 (10Jdlrobson)
[22:29:09] <wikibugs>	 10Gather, 3Gather Sprint Forward: Use auto-completable URLs for Special:Gather - https://phabricator.wikimedia.org/T94527#1165761 (10Jdlrobson) I think this is a good idea and we should do it.
[22:30:47] <wikibugs>	 10Gather: Gather should fail more gracefully if MobileFrontend is not installed - https://phabricator.wikimedia.org/T94969#1225828 (10Jdlrobson) 5Open>3declined a:3Jdlrobson I actually think this is the correct behaviour. Without MobileFrontend it would explode and do far worse damage. Better to make it ob...
[22:30:54] <grrrit-wm>	 (03PS6) 10Robmoen: Add placeholder for admin moderation expectations to Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 
[22:30:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify PageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 (owner: 10Jdlrobson)
[22:31:33] <wikibugs>	 10Gather, 10Continuous-Integration, 7Zuul: Gather should be using its own Gruntfile in Jenkins - https://phabricator.wikimedia.org/T92589#1225831 (10Jdlrobson)
[22:31:50] <wikibugs>	 10Gather, 3Gather Sprint Forward, 10MediaWiki-Vagrant: Create vagrant Gather role - https://phabricator.wikimedia.org/T90814#1225833 (10Jdlrobson)
[22:32:05] <wikibugs>	 10Gather, 3Gather Sprint Forward, 10MediaWiki-Vagrant: Create vagrant Gather role - https://phabricator.wikimedia.org/T90814#1068180 (10Jdlrobson) Probably important for Lyon. @MaxSem who would be a good person to help us to do this?
[22:38:05] <Krenair>	 jdlrobson, if you could document that it was created via a new ticket, that'd be great :)
[22:38:12] <Krenair>	 Deskana, heh. Speaking of search... :)
[22:38:16] <wikibugs>	 10Gather: API: Support user managed sort order - https://phabricator.wikimedia.org/T91017#1225881 (10Jdlrobson)
[22:38:22] <wikibugs>	 10Gather: API: Support user managed sort order - https://phabricator.wikimedia.org/T91017#1072489 (10Jdlrobson)
[22:39:06] <Deskana>	 Krenair: Indeed!
[22:39:10] <wikibugs>	 10Gather: API: support page reordering - https://phabricator.wikimedia.org/T94117#1225892 (10Jdlrobson)
[22:39:12] <wikibugs>	 10Gather: API: Support user managed sort order - https://phabricator.wikimedia.org/T91017#1072489 (10Jdlrobson)
[22:39:23] <wikibugs>	 10Gather: API: Support user managed sort order - https://phabricator.wikimedia.org/T91017#1072489 (10Jdlrobson)
[22:39:31] <wikibugs>	 10Gather: API: Support user managed sort order - https://phabricator.wikimedia.org/T91017#1072489 (10Jdlrobson) a:3Yurik
[22:42:35] <wikibugs>	 10Gather: Gather documentation page needs an update - https://phabricator.wikimedia.org/T93264#1225916 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Click edit! :) https://www.mediawiki.org/w/index.php?title=Extension%3AGather&diff=1561605&oldid=1538686
[22:58:49] <wikibugs>	 10Gather, 3Gather Sprint Forward: Use auto-completable URLs for Special:Gather - https://phabricator.wikimedia.org/T94527#1226097 (10JKatzWMF) @jdlrobson very cool, but lower priority than some other stuff.  I would rather you pulled off the backlog first.
[23:04:48] <JonKatz_>	 rmoen jdlrobson i am trying to sign off on changes in Gather Fwd, but on wmflabs, don't see anything fixed..example: https://phabricator.wikimedia.org/T95967
[23:07:43] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1226314 (10JKatzWMF) @jdlrobson --can we hide this behind a feature flag?  I do not think this should go live yet--and thought we had discussed as much.
[23:09:02] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1226322 (10JKatzWMF) @jdlrobson this was in sprint I and beyond for a reason!  moving it back.
[23:09:11] <wikibugs>	 10Gather, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1226323 (10JKatzWMF)
[23:11:38] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Gather pages not indexed by search engines - https://phabricator.wikimedia.org/T96689#1226329 (10JKatzWMF) @jdlrobson --this should not be in this sprint. We can't surface collections on search engines until we have a number of content issues figured out....
[23:12:41] <wikibugs>	 10Gather: Use auto-completable URLs for Special:Gather - https://phabricator.wikimedia.org/T94527#1226331 (10JKatzWMF)
[23:14:23] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1226333 (10Deskana) 5Open>3Resolved
[23:15:24] <wikibugs>	 10Wikipedia-Android-App: Further refine error handling - https://phabricator.wikimedia.org/T96796#1226337 (10Deskana) 3NEW
[23:16:19] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Make error messages more specific - https://phabricator.wikimedia.org/T95070#1179645 (10Deskana) I've closed this task as resolved as according to its initial scope it is complete.  There was a desire voiced by @vibhabamba et al. to i...
[23:32:11] <wikibugs>	 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Share A Fact images should include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1226376 (10Slaporte) I posted a [note on attribution and CC compliance for this feature on MediaWiki](https://www.mediawiki.org/wiki/Wikimedia_...
[23:59:01] <wikibugs>	 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1226408 (10JKatzWMF) @jdlrobson nevermind we discussed.  let's push forward.
[23:59:45] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1226409 (10BGerstle-WMF) We considered Differential/Arcanist, but @Qgil indicated it wasn't ready for widespread adoption and that it wouldn't support continuous integration.  We...