[00:03:54] 10Gather, 3Gather Sprint Forward, 10Gather Sprint G, 3Mobile-Web-Design: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1226414 (10JKatzWMF) [00:05:36] 10Gather, 3Gather Sprint Forward: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1226418 (10JKatzWMF) [00:09:16] 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1226421 (10greg) Just to be clear: when the WMF migrates from Gerrit to Phab, you'll switch again (to Phab)? [00:11:33] 10Gather: Use auto-completable URLs for Special:Gather - https://phabricator.wikimedia.org/T94527#1226436 (10Jdlrobson) Work involved here is trivial - probably 10 minutes maximum. Agree though it's super low priority. [00:11:46] 10Gather, 3Gather Sprint Forward: Use auto-completable URLs for Special:Gather - https://phabricator.wikimedia.org/T94527#1226437 (10JKatzWMF) [00:12:24] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1226438 (10Jdlrobson) I pointed out a private list is harmless and switching it to public updates modified time making it show up in the list view [00:13:22] 10Gather, 5Patch-For-Review: On collection, clicking anywhere on each article card links to article. - https://phabricator.wikimedia.org/T92664#1226447 (10Jdlrobson) a:5Jhernandez>3JKatzWMF My bad! Sounds like @JKatzWMF and @Msyed are still discussing whether to do this or not. Have updated assignee to poi... [00:13:36] (03CR) 10Jdlrobson: [C: 04-1] "JK asked to hold off on this" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205633 (https://phabricator.wikimedia.org/T96689) (owner: 10Jdlrobson) [00:13:45] jdlrobson: what do you think about my comment at https://gerrit.wikimedia.org/r/#/c/204977/ ? [00:13:55] 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1226450 (10Legoktm) >>! In T95749#1226409, @BGerstle-WMF wrote: > And so, we want to try GitHub to see if it makes managing our repo and doing code review less painful. We contin... [00:14:27] 10Gather, 3Gather Sprint Forward: Use auto-completable URLs for Special:Gather - https://phabricator.wikimedia.org/T94527#1165761 (10Jdlrobson) [00:14:41] 10Gather, 3Gather Sprint Forward, 10MediaWiki-Vagrant: Create vagrant Gather role - https://phabricator.wikimedia.org/T90814#1068180 (10Jdlrobson) [00:18:28] (03PS13) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [00:25:32] 10Gather, 3Gather Sprint Forward, 7I18n: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1226459 (10Jdlrobson) [00:25:33] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Change messaging for blank collections - https://phabricator.wikimedia.org/T95740#1226458 (10Jdlrobson) 5Open>3Resolved [00:27:42] (03PS7) 10Jdlrobson: Add placeholder for admin moderation expectations to Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 (owner: 10Robmoen) [00:36:17] (03CR) 10Mhurd: "Added protocol for making translations visible from javascript. Much cleaner approach - also makes it so we don't have to delay the table " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd) [00:36:57] (03PS14) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [00:38:54] (03CR) 10Jdlrobson: [C: 032] "I changed qqq - i didn't mean optional as being the qqq code - just a note that the message was optional" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 (owner: 10Robmoen) [00:39:41] 3Gather Sprint Forward: Update in WikimediaMessages extension for enwiki - https://phabricator.wikimedia.org/T96805#1226487 (10Jdlrobson) 3NEW a:3rmoen [00:40:41] (03Merged) 10jenkins-bot: Add placeholder for admin moderation expectations to Special:GatherLists [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203949 (owner: 10Robmoen) [00:41:42] 3Gather Sprint Forward: Update in WikimediaMessages extension for enwiki - https://phabricator.wikimedia.org/T96805#1226498 (10Jdlrobson) [00:46:48] 10Wikipedia-Android-App, 3Mobile-App-Sprint-54-Android, 5Patch-For-Review: Text flow is wrong in landscape but not portrait orientation - https://phabricator.wikimedia.org/T94853#1226510 (10bearND) @Rita2008 The issue you mentioned has been fixed and rolled out to the beta app. Production app to follow soon. [00:51:42] 6Mobile-Web: Regression: Noticeable delay when rendering main menu - https://phabricator.wikimedia.org/T96617#1226529 (10Jdlrobson) Maybe animation related? [00:52:57] (03CR) 10Dbrant: [C: 032] Add Event log URL for testing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205336 (owner: 10BearND) [00:53:14] dbrant: thanks [00:53:56] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1226531 (10bearND) @Niedzielski I want to end up dropping the date part eventually. I think we'll keeping the date portion for a transition... [00:54:20] dbrant: Deskana|Away: Thoughts about ? [00:54:23] ^^ [00:55:55] (03Merged) 10jenkins-bot: Add Event log URL for testing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205336 (owner: 10BearND) [01:03:11] (03PS1) 10Jdlrobson: i18n: Gender support for various messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205801 [01:06:02] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1226554 (10Deskana) Channel is super important. We have a number of feature flags in the app which means that the version code is not enoug... [01:06:12] bearND: I gave some feedback on the task. Let me know if you want more input. [01:07:00] Deskana: Thanks. [01:07:00] bearND: My tl;dr is that I trust you. [01:07:03] :-) [01:14:27] Deskana: :) [01:14:47] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1226558 (10Niedzielski) @bearND I personally like the human friendly channel string embedded in the `versionName` and conservative sounds g... [01:28:59] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1226559 (10bearND) @Deskana While this change does not remove the date (yet) you have a good point to remind us about about the alpha build... [01:32:51] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1226560 (10Niedzielski) @BearND +1 for hash. Perhaps a little unrelated, but all this stuff is superb detail to include in the build produc... [01:37:49] (03PS13) 10Dbrant: [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [01:46:38] (03PS4) 10Kaldari: Rewrite mobile login page to be less hacky and closer to core version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) [01:54:41] dbrant: hi, teeth are squeaky clean. [01:55:08] vibha: glad to hear it! :) [01:55:09] Did you want to chat/ have any questions for me? [01:56:42] vibha: i think i've got it covered... I'll be sending you APKs for prototypes 1 and 2 by EOD (local time), ready for user testing. [01:57:41] cc bearND ^ i'll leave comments in gerrit on the patch sets on which the APKs were based. [01:58:12] dbrant: thanks [02:03:54] ok great. [02:04:06] Do you need any more screenshots to analyze text display. [02:04:21] i have a collection of 50 of them between 3-4-5 lines [02:04:36] Just ping if you need anything. [02:17:55] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1226608 (10Deskana) Since the version code is incremented for every beta and prod release, dropping the date there sounds fine. Version cod... [02:18:18] 10Wikipedia-Android-App: Margins and default type size on Android need to be increased. - https://phabricator.wikimedia.org/T96719#1226609 (10bearND) @Vibhabamba Please provide more info/specs. * Margins: Are you talking about the left/right margins? If so, please note that we use different values depending on... [02:26:27] (03CR) 10Yurik: [C: 04-1] i18n: Gender support for various messages (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205801 (owner: 10Jdlrobson) [02:35:19] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1226610 (10bearND) @Niedzielski We include the versionName inside the file name the make-release.py script produces. Initially we tried to... [02:37:17] (03CR) 10Yurik: [C: 04-1] "your trusted unit test runner yuri reports that if you would have ran" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) (owner: 10Jdlrobson) [02:39:35] (03CR) 10Yurik: "Also, while you are at it, rename "public" into "perm" in the api prop parameter - will keep things consistent." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) (owner: 10Jdlrobson) [02:46:25] (03PS1) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205809 [02:53:04] (03PS2) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205809 [02:58:53] (03PS3) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205809 [03:00:04] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1226661 (10Niedzielski) @BearND Great point! At the very least, it would make the builds confusing because you would end up with multiple a... [03:02:30] (03PS4) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205809 [03:13:49] (03PS7) 10Yurik: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) [03:16:10] 10Wikipedia-iOS-App, 7Mobile: Strip navbox html from action mobileView - https://phabricator.wikimedia.org/T96812#1226691 (10Mhurd) [03:19:03] 10Wikipedia-iOS-App, 7Mobile: Strip navbox html from action mobileView - https://phabricator.wikimedia.org/T96812#1226697 (10yuvipanda) @MaxSem why was this removed? IIRC you switched to hiding via CSS in stead of DOM transforms, but why? Perf reasons? [03:19:11] 10Wikipedia-iOS-App, 7Mobile: Strip navbox html from action mobileView - https://phabricator.wikimedia.org/T96812#1226698 (10Mhurd) I'd argue that even if stripping this server-side is slightly less efficient, as long as we have a bit of horsepower to spare it's a good trade-off as it reduces transfer times -... [03:25:03] (03PS2) 10Dbrant: [WIP] Link previews (prototype 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) [03:33:03] (03CR) 10Jdlrobson: "why isn't jenkins complaining..?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) (owner: 10Jdlrobson) [03:39:49] (03PS14) 10Dbrant: [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [03:48:55] (03PS3) 10Dbrant: [WIP] Link previews (prototype 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) [03:59:42] (03CR) 10Yurik: Implements prop=listmembership (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [04:02:37] (03PS8) 10Yurik: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) [04:12:48] (03CR) 10Yurik: "Because Jenkins does not run php unit tests for this project. In theory it should, but last time i tried it, it failed because jenkins use" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) (owner: 10Jdlrobson) [04:55:53] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1226828 (10Sumit) [05:03:29] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1226841 (10Sumit) @Jdlrobson, descoped the "editing of banner image source using UI" part of the proposal as per your suggestion. [05:57:42] 6Mobile-Web, 10MobileFrontend: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1226873 (10Nemo_bis) Data shared by Jon seems to prove the necessity to fix this: https://lists.wikimedia.org/pipermail/mobile-l/2015-April/008996.html 98 % of users visit the w... [06:29:57] 6Mobile-Web, 10MobileFrontend: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1226877 (10Jdlrobson) @Nemo_bis I have no idea how you drew those conclusions from that data. I'm not sure where you get 98% of users from... Less users are using the feed tab. [06:33:41] 6Mobile-Web, 10MobileFrontend: Don't override Special:Watchlist with Special:EditWatchlist - https://phabricator.wikimedia.org/T88270#1226878 (10Jdlrobson) (but we should clearly disentangle the two since early data suggests Gather would hopefully serve this need better) [07:44:40] 10Wikipedia-iOS-App, 3App-Process-Improvement: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1226963 (10Qgil) Let's not forget that the iOS app was among the last Wikimedia projects to move from GitHub to Gerrit, not that long ago. It would be useful to know why @Brion, M... [07:47:53] 10Wikipedia-iOS-App: Scroll event after pressing lock icon triggers an alert twice - https://phabricator.wikimedia.org/T96822#1226966 (10Omersm) 3NEW [08:49:02] 10Gather, 10Continuous-Integration: Gather should be using its own Gruntfile in Jenkins - https://phabricator.wikimedia.org/T92589#1227033 (10hashar) [08:50:11] morning [08:51:28] (03CR) 10Phuedx: [C: 032] QA: Remove failing VisualEditor test due to toolbar changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205448 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson) [08:52:45] (03CR) 10Phuedx: "I'll immediately +2 any patch that points out how right I am." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205448 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson) [08:53:15] (03Merged) 10jenkins-bot: QA: Remove failing VisualEditor test due to toolbar changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205448 (https://phabricator.wikimedia.org/T94156) (owner: 10Jdlrobson) [08:54:27] 3Gather Sprint Forward, 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1227041 (10phuedx) 5Open>3Resolved All yer patches are merged @Jdlrobson. [08:58:06] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1227048 (10phuedx) Ping @KHammerstein. [09:00:03] 10Gather, 10Continuous-Integration: Gather should be using its own Gruntfile in Jenkins - https://phabricator.wikimedia.org/T92589#1227050 (10hashar) @Jdlrobson wrote: > PS. @hashar we really need to make these jobs something that developers get for free when they setup an extension. Maybe this is something we... [09:05:33] I have triggered all the browser tests jobs at https://integration.wikimedia.org/ci/view/BrowserTests/view/MobileFrontend/ [09:05:45] (just need to be logged in jenkins using the labs LDAP account) [09:06:09] morning! [09:06:13] phuedx|zzZ: ^ [09:06:16] good morning :) [09:06:22] oh [09:06:28] i'm ircing in my sleep [09:06:44] hey hashar -- thanks [09:06:51] * hashar waste phuedx dream by wearing a clown mask and screaming [09:07:06] hashar: that's what i imagine jenkins looks like [09:07:19] lol [09:07:25] i shouldn't've closed that task so quickly, but w/e [09:07:27] yeah it is scary [09:07:34] it can be reopened if they're still borked [09:07:46] yup or more specific tasks filled for the failures [09:07:54] at least, it is good to see devs taking care of such tests :) [09:08:09] hashar: moving forward, i think we'd like to write more [09:08:17] but the feedback cycle is broken at the moment [09:08:23] and running them locally is still painful [09:08:40] but these are known problems and we can develop practices whilst they're getting better [09:09:02] if you have any idea to make them better, do poke zeljkof :) [09:09:18] or we can talk about it on the QA mailling list [09:09:45] i phound a picture of jenkins http://media.giphy.com/media/wYb3xiVz8IlDW/giphy.gif [09:09:59] joakino: appropriate :) [09:11:28] 3Gather Sprint Forward, 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1227055 (10hashar) Logged in with my LDAP account, I have manually triggered runs for the three... [09:11:49] bah [09:11:56] the smoke tests fail now :( [09:11:57] https://integration.wikimedia.org/ci/view/BrowserTests/view/MobileFrontend/job/browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce/ [09:12:03] though the previous build passed [09:12:52] starting it again [09:29:40] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Initial banner image should be delivered as part of the initial response - https://phabricator.wikimedia.org/T90698#1227090 (10phuedx) Hrrm. I'm tempted to close this and invalid and have a story writing session with @JKatzWMF and @KHammerstein about lead... [09:36:50] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205801 (owner: 10Jdlrobson) [09:48:35] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [09:50:34] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [09:58:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [10:07:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205473 (owner: 10Kaldari) [10:25:17] (03PS4) 10Jhernandez: New collection opens collection editor interface [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204332 (https://phabricator.wikimedia.org/T94803) (owner: 10Jdlrobson) [10:25:40] (03CR) 10Jhernandez: [C: 032] "Removed weird resources/untitled.txt file" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204332 (https://phabricator.wikimedia.org/T94803) (owner: 10Jdlrobson) [10:27:30] (03Merged) 10jenkins-bot: New collection opens collection editor interface [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204332 (https://phabricator.wikimedia.org/T94803) (owner: 10Jdlrobson) [11:25:29] (03PS1) 10Jhernandez: Design: Improve spacing of content overlay on phones [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205834 (https://phabricator.wikimedia.org/T95628) [11:32:37] 10Gather, 3Gather Sprint Forward: Phone screen improvements on Adding to collection modal - https://phabricator.wikimedia.org/T96837#1227238 (10Jhernandez) 3NEW [11:33:12] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Bug: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1196202 (10Jhernandez) See ⬆️ patch for review. Improved spacing on phones, see screenshots: {F151903} {F151904} Much better that before, but still there is too m... [11:33:26] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Bug: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1227251 (10Jhernandez) a:3Jhernandez [11:36:35] 10Gather, 3Gather Sprint Forward: Phone screen improvements on Adding to collection modal - https://phabricator.wikimedia.org/T96837#1227258 (10Jhernandez) [11:52:05] 3Gather Sprint Forward: Deleting a collection doesn't close editor overlay - https://phabricator.wikimedia.org/T96294#1227292 (10Jhernandez) a:3Jhernandez [11:52:46] 3Gather Sprint Forward, 5Patch-For-Review: Deleting a collection should not have an associated route - https://phabricator.wikimedia.org/T96167#1227301 (10Jhernandez) [11:52:48] 3Gather Sprint Forward: Deleting a collection doesn't close editor overlay - https://phabricator.wikimedia.org/T96294#1213591 (10Jhernandez) [11:53:23] (03PS1) 10Jhernandez: When deleting collection hide dialog when actually finished [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) [11:54:06] 3Gather Sprint Forward, 5Patch-For-Review: Deleting a collection doesn't close editor overlay - https://phabricator.wikimedia.org/T96294#1227305 (10Jhernandez) See blocking task before this one. [11:56:19] (03CR) 10jenkins-bot: [V: 04-1] When deleting collection hide dialog when actually finished [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) (owner: 10Jhernandez) [11:56:58] gonna go out for a boulder [11:57:23] enjoy! [12:01:38] (03PS2) 10Jhernandez: When deleting collection hide dialog when actually finished [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) [12:03:17] (03PS3) 10Jhernandez: When deleting collection hide dialog when actually finished [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) [12:03:19] (03PS3) 10Jhernandez: Do not use a url for the "delete collection" confirmation dialog [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205637 (https://phabricator.wikimedia.org/T96167) [12:40:06] 6Mobile-Web: Hide chrome status bar when overlays are open - https://phabricator.wikimedia.org/T96297#1227336 (10Jhernandez) Seems like vendors don't want people doing these hacks, so it is not possible any more on ios8, etc. There's the fullscreen api on these browsers, maybe we should try it out and see if it... [12:54:57] 3Gather Sprint Forward, 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1227342 (10hashar) 5Resolved>3Open Reopening since the builds I triggered earlier have some... [12:55:30] (03PS2) 10Jhernandez: i18n: Gender support for various messages [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205801 (https://phabricator.wikimedia.org/T95547) (owner: 10Jdlrobson) [12:56:01] (03CR) 10Jhernandez: [C: 04-1] "-1 For attention of previous patchset. Updated commit message with the bug id." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205801 (https://phabricator.wikimedia.org/T95547) (owner: 10Jdlrobson) [12:57:14] 10Gather, 3Gather Sprint Forward, 7I18n, 5Patch-For-Review: imperative messages in Gather need gender support - https://phabricator.wikimedia.org/T95547#1227350 (10Jhernandez) @Amire80 @jdlrobson Seems like the patch has been reviewed and there is some controversy on when to use the GENDER. Linked the patc... [13:00:01] 10Gather, 5Patch-For-Review: Gather pages not indexed by search engines - https://phabricator.wikimedia.org/T96689#1224617 (10Jhernandez) [13:01:42] 10Gather, 5Patch-For-Review: Gather pages not indexed by search engines - https://phabricator.wikimedia.org/T96689#1224617 (10Jhernandez) @jkatzwmf Patch has been marked as hold off. I've removed the current sprint project, and moved it to "Needs triage" on the Gather board. Can you triage it where you want it... [13:29:53] (03CR) 10Anomie: Implements prop=listmembership (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [13:30:56] (03CR) 10Anomie: "Seems ok now except for the missing i18n. If you want to do i18n for all your API modules in a followup that's ok, but I'd want to see tha" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [13:48:26] 10Gather: API: Add help messages to api modules - https://phabricator.wikimedia.org/T96849#1227466 (10Yurik) 3NEW [13:52:36] (03CR) 10Yurik: "To be done shortly - hope someone from Gather team can help out on this one. See T96849" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [14:03:16] (03PS9) 10Yurik: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) [14:03:23] joakino, ^ [14:04:01] joakino, its done and tested, and anomie only wants api documented properly (I created a separate task for that) [14:17:18] 10Gather, 10MediaWiki-API: API: Add help messages to api modules - https://phabricator.wikimedia.org/T96849#1227588 (10Anomie) [14:24:09] 10Gather, 10MediaWiki-API: API: Add help messages to Gather API - https://phabricator.wikimedia.org/T96849#1227652 (10Yurik) [14:29:25] (03CR) 10Bgerstle: [C: 031] "looks good, and fetching seems to work. i'm surprised we're not validating the JSON before writing it to disk though (i.e. we could corrup" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205760 (owner: 10Mhurd) [15:06:16] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1227874 (10Mholloway) With the smaller minimum text size, maxLines should probably go up to 6: {F152498} {F152501} --- {F152499} {F... [15:06:22] 10Gather, 10MediaWiki-API: Update API query continuation usage for future change of default - https://phabricator.wikimedia.org/T96864#1227875 (10Anomie) 3NEW [15:08:32] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1227893 (10bearND) Keep in mind that both title and description could be two lines, and we moved the text slightly lower than before.... [15:08:47] 6Mobile-Web, 10MobileFrontend, 10MediaWiki-API: Update API query continuation usage for future change of default - https://phabricator.wikimedia.org/T96866#1227895 (10Anomie) 3NEW [15:09:04] (03CR) 10Bgerstle: "NSURLProtocol: good start, but let's talk about RESTful API and caching when you're available." (039 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd) [15:10:48] ugh [15:11:00] finally back online [15:11:23] i went to a coffee shop after the boulder sesh [15:11:28] only to find they didn't have wifi [15:11:32] welcome to the future [15:11:40] 10Gather, 10MediaWiki-API: Update API query continuation usage for future change of default - https://phabricator.wikimedia.org/T96864#1227911 (10Anomie) [15:11:43] 6Mobile-Web, 10MobileFrontend, 10MediaWiki-API: Update API query continuation usage for future change of default - https://phabricator.wikimedia.org/T96866#1227910 (10Anomie) [15:11:50] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1227913 (10MSyed) I think the key here is to make the android images look as close as possible to the iOS images. I think the maxim... [15:11:54] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1227914 (10Mholloway) Yeah, you're right. Even without overlap, this looks too crowded. {F152510} [15:13:14] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1227929 (10MSyed) Exactly, 6 lines is too much :( [15:14:11] 10Gather, 3Gather Sprint Forward: Use auto-completable URLs for Special:Gather - https://phabricator.wikimedia.org/T94527#1227932 (10Jdlrobson) a:3Jdlrobson [15:14:58] (03PS1) 10Jdlrobson: Switch URL used for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205868 (https://phabricator.wikimedia.org/T94527) [15:21:53] (03CR) 10Bgerstle: "thoughts on sync vs. async XHR?" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd) [15:25:47] (03PS4) 10Mholloway: Slightly decrease minimum text size on Share a Fact cards. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/204835 (https://phabricator.wikimedia.org/T96398) (owner: 10Deskana) [15:26:09] (03PS3) 10Jdlrobson: Update how deleted pages behave [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) [15:31:37] (03PS3) 10Jdlrobson: i18n: Tweaks [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205801 (https://phabricator.wikimedia.org/T95547) [15:32:27] 10Wikipedia-Android-App: bracket stripping strips inside link targets - https://phabricator.wikimedia.org/T96871#1227986 (10jeremyb-phone) 3NEW [15:34:27] 10Wikipedia-Android-App: bracket stripping strips inside link targets - https://phabricator.wikimedia.org/T96871#1227998 (10jeremyb-phone) [15:34:44] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1228000 (10bearND) Here's the updated apk from @Dbrant: {F152525} and his comments from email: "I was able to implement the sentence manipulation that we dis... [15:43:08] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1228016 (10bearND) I wonder if we should drop the Ken Burns effect for the preview. Having this extra animation in addition to the animation of the dialog itse... [15:51:41] (03PS1) 10Bgerstle: refactor MWKTestCase and fix linting errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205874 [16:02:06] hi yall [16:04:14] 10Gather, 10MediaWiki-API: API: Add help messages to Gather API - https://phabricator.wikimedia.org/T96849#1228093 (10Jhernandez) Related conversation on patch: https://gerrit.wikimedia.org/r/#/c/203003/ [16:04:24] (03PS2) 10Bgerstle: refactor MWKTestCase and fix linting errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205874 [16:08:54] yurik: are you around? [16:11:00] hey joakino [16:11:06] hi phuedx [16:11:49] (03PS9) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [16:12:34] (03CR) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [16:13:42] (03CR) 10jenkins-bot: [V: 04-1] Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [16:13:43] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1228112 (10Jhernandez) I feel it is really weird to return `"listmembership:" ""` when the page is member... [16:14:37] (03CR) 10Florianschmidtwelzow: "Thanks Siebrand! :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [16:14:48] (03PS4) 10Florianschmidtwelzow: Improve error handling for "Editor not available" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) [16:21:43] 6Mobile-Web: Regression: Noticeable delay when rendering main menu - https://phabricator.wikimedia.org/T96617#1228124 (10phuedx) This affects Chrome and Firefox – maybe others – so this ain't browser specific. [16:41:23] (03PS1) 10Phuedx: Fix regression in menu animations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205882 (https://phabricator.wikimedia.org/T96617) [16:43:38] 6Mobile-Web, 5Patch-For-Review: Regression: Noticeable delay when rendering main menu - https://phabricator.wikimedia.org/T96617#1228183 (10phuedx) I'm not sure when this regression was introduced, but the animation selectors were //wrong//. [16:45:07] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Regression: Noticeable delay when rendering main menu - https://phabricator.wikimedia.org/T96617#1228197 (10phuedx) [16:49:42] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Regression: Noticeable delay when rendering main menu - https://phabricator.wikimedia.org/T96617#1228211 (10phuedx) a:3phuedx [16:56:25] y'know what's awesome? [16:56:30] rhubarb and ginger jam [16:59:20] phuedx: sounds sketchy [16:59:48] ori: it could do with a little more ginger [16:59:51] maybe you're right [17:00:01] Reedy: ^^ [17:00:18] Reedy is our source of ginger [17:06:19] bgerstle: running late for standup (on muni - went bouldering). Can you mention the localization and buttoning up of page issues for me? (Will amend based on your comments this morning) [17:06:37] mhurd nice! sure [17:06:53] bgerstle: thx! [17:08:18] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Investigate how users are able to render Share a fact cards with different fonts - https://phabricator.wikimedia.org/T96883#1228246 (10bearND) [17:12:37] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: No icon for search with JS disabled / doesn't look like a button - https://phabricator.wikimedia.org/T96637#1228266 (10KLans_WMF) [17:15:23] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: $wgMFEditorOptions should be updated to reflect production - https://phabricator.wikimedia.org/T96634#1228275 (10KLans_WMF) [17:16:47] phuedx: bmansurov POW! [17:17:45] JonKatz: the developer pow wow is scheduled over the sync but we've got the review and estimation meeting immediately after [17:17:52] mind if we don't sync today [17:18:03] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1228286 (10KHammerstein) @phuedx Cool, can you send screenshot? [17:18:07] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Investigate how users are able to render Share a fact cards with different fonts - https://phabricator.wikimedia.org/T96883#1228288 (10Deskana) Is there some issue being caused by this, other than the ideal that cards be consistent with each other? [17:29:07] Be back in 10-15 minutes [17:33:07] bgerstle: bat filled cave? [17:33:48] jdlrobson: is there anything you want to bring up at sos? [17:34:00] phuedx: nope! [17:34:10] mhurd sure [17:34:12] awesome -- there's nothing on our side too i don't think [17:34:14] \o/ [17:34:41] Hm, the Wikipedia Testflight build expires in five days... [17:42:11] 10Wikipedia-iOS-App: Weird display of a Hebrew UI string on a Russian Wikipedia article - https://phabricator.wikimedia.org/T72490#1228317 (10Amire80) Yes, fixed. [17:43:07] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1228318 (10phuedx) @KHammerstein: Suresies! Have a screenshot of [Claude Monet (beta)](http://en.m.wikipedia.beta.wmflabs.org/wiki/Claude_Monet... [17:43:49] (03PS10) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [17:44:45] (03CR) 10Florianschmidtwelzow: [C: 04-1] Check, if the user is blocked from editing before try to save the edit (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [17:46:28] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Special:MobileOptions throwing JS error from mobile.watchstar in stable - https://phabricator.wikimedia.org/T92657#1228333 (10phuedx) @Jdlrobson: should we SWAT deploy your change? [17:46:54] (03CR) 10jenkins-bot: [V: 04-1] Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [17:49:40] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1228335 (10KHammerstein) @ phuedx looks perfect, thanks! Design sign off :) [17:51:06] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1228341 (10phuedx) 5Open>3Resolved [17:51:19] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: [Beta] Banner image should always have the same gutter as the content - https://phabricator.wikimedia.org/T91743#1095239 (10phuedx) (It looks great!) [17:51:58] 10Wikipedia-iOS-App, 7Mobile: Strip navbox html from action mobileView - https://phabricator.wikimedia.org/T96812#1228345 (10MaxSem) 22 апр. 2015 г. 6:19 пользователь "Mhurd" < no-reply@phabricator.wikimedia.org> написал: > > Mhurd added a comment. > > I'd argue that even if stripping this server-side is sligh... [17:56:47] (03PS11) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [17:58:10] (03PS15) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [17:58:36] (03CR) 10jenkins-bot: [V: 04-1] Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [17:59:24] (03PS12) 10Florianschmidtwelzow: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) [18:02:46] bmansurov: https://en.m.wikipedia.org/wiki/Tree_of_40_Fruit can you go grab us a photo ;-) [18:05:30] brb getting coffee. jdlrobson, i will have a followup to flagging patch soon [18:05:31] 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, and 3 others: Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1228384 (10Jdforrester-WMF) [18:06:17] kristenlans: ping pong [18:06:21] (03PS5) 10Florianschmidtwelzow: Improve error handling for "Editor not available" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) [18:06:26] ah crap [18:06:31] phuedx sorry [18:07:01] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Special:MobileOptions throwing JS error from mobile.watchstar in stable - https://phabricator.wikimedia.org/T92657#1228387 (10Jdlrobson) Nope. It's difficult to reproduce locally and should only impact special pages where javascript is... [18:07:19] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1228388 (10Yurik) According to @anomie, this is being changed globally - if you use formatversion=latest... [18:08:35] hi jdlrobson :) You remember the message parsing problem yesterday? i talked to Krinkle and here we are: https://gerrit.wikimedia.org/r/#/c/204716/12/javascripts/modules/editor/EditorOverlay.js + https://phabricator.wikimedia.org/T96885 :) [18:09:02] kaldari: ping pong story review/estimation [18:09:06] joakino, pong [18:09:24] FlorianSW: good catch :) [18:10:05] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1228399 (10Jdlrobson) Wait formatversion=version ? The API has versioning (see T41592)? [18:10:10] jdlrobson: yeah, but krinkle said, that the module isn't really maintained, so i think, that this hacky solution will be some time there :( But it's working and doesn't look too hacky :) [18:10:14] yurik: the api has versioning? [18:10:36] ok FlorianSW will take a look [18:10:44] having issues with my local instance and editing though - no idea why :/ [18:10:48] jdlrobson, partially - anomie doesn't want per module versions, but rather global per feature version [18:11:02] jdlrobson: whats happening? [18:11:03] so formatting has versioning (will be public shortly) [18:11:33] http://hatjitsu.wmflabs.org/98889 [18:11:41] yurik: i'm leaving for the day 😁 [18:11:44] kaity ^ [18:11:52] joakino, did you need something? [18:13:00] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: $wgMFEditorOptions should be updated to reflect production - https://phabricator.wikimedia.org/T96634#1228415 (10Florian) a:3Florian +1! I would upload a change, if there are no objections :) [18:13:09] yurik: i commented on the list membership bug about the listmember prop being (present and "" or absent) vs (always present; true and false) [18:13:17] comment there, i'll see it later/tomorrow [18:13:28] joakino, i already answered taht [18:13:37] yurik: great! [18:13:46] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1228417 (10Yurik) [18:14:15] http://hatjitsu.wmflabs.org/98889 kaldari [18:14:34] 10Wikipedia-Android-App: Investigate how users are able to render Share a fact cards with different fonts - https://phabricator.wikimedia.org/T96883#1228420 (10Deskana) [18:15:19] 10Wikipedia-Android-App: Further refine error handling - https://phabricator.wikimedia.org/T96796#1228432 (10Deskana) 5Open>3stalled Marking this task as stalled and moving it to open questions until further definition about how to improve it further is provided. [18:16:18] 6Mobile-Web, 3Mobile-Web-Design: Generate mockups of how tags will look on mobile article pages - https://phabricator.wikimedia.org/T94736#1228439 (10KHammerstein) [18:16:36] 6Mobile-Web, 10MobileFrontend, 10MediaWiki-API: (2) Update API query continuation usage for future change of default - https://phabricator.wikimedia.org/T96866#1228446 (10KLans_WMF) [18:16:54] dr0ptp4kt: mhurd hey, i'm going to step out for lunch. i've got a card in doing... and my current thinking about it is that we might be better off revamping all the error handling the data layer [18:17:05] perhaps refactoring some stuff to use protocols to DRY up the code as well [18:17:16] bgerstle: k. see ya this afternoon! [18:17:17] (i.e. get rid of all the saveXXXX: methods) [18:17:19] bgerstle: thx for heads up. let's discuss this afternoon [18:17:20] ah [18:17:38] 6Mobile-Web, 3Mobile-Web-Design: Generate mockups of how tags will look on mobile article pages - https://phabricator.wikimedia.org/T94736#1171432 (10KHammerstein) @JKatzWMF added another mock to show tags after lead section in description ^ [18:17:41] dr0ptp4kt: mhurd it might be riskier, but i'll mull it over some more [18:17:51] bgerstle: sounds good [18:18:04] probably try to do it w/ tests first, try to minimize risk, but i'll probably miss this train [18:18:15] unless i can think of a stop-gap to stop the bleeding in the next release [18:18:59] it basically comes down to adding failure handling for a more specific set of cases, and then expanding that failure handling to include more cases & refactor along the way [18:19:15] i.e. just add failure handling for saving history lists (since that seems to be a common failure point) and section HTML [18:19:24] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1228472 (10Yurik) See T87053 and https://www.mediawiki.org/wiki/API/Architecture_work/Planning#Changes_to... [18:19:26] 10Wikipedia-Android-App: Investigate how users are able to render Share a fact cards with different fonts - https://phabricator.wikimedia.org/T96883#1228474 (10Deskana) p:5Triage>3Normal [18:19:28] mhurd dr0ptp4kt one thing that occurred to me today is that people *might* be running out of disk and/or memory [18:19:32] and that could be what's causing some of these crashes [18:19:32] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1228478 (10Vibhabamba) **Prototype 1:** With the limited text we are generating (per Dmitry's script from yesterday), height of the overall card can reduce by... [18:19:35] jdlrobson, ^^^ [18:19:43] i.e. try to write to disk -> no space left -> error -> exception [18:19:48] also maybe why we can't reproduce stuff [18:19:52] bgerstle: that could be. we should delete the .bak article data file [18:20:08] mhurd that, and show users an alert "hey, you're outta space dude!" [18:20:14] or is it... outer space..? [18:20:22] alright, gotta run for now though. mhurd i [18:20:27] bgerstle: k see ya [18:20:29] i'll be around in a bit to do another review pass on your changes [18:20:47] bgerstle: sounds good. almost have the restful syntax done... [18:21:23] w00t [18:25:28] 6Mobile-Web, 3Mobile-Web-Design: On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1228514 (10KLans_WMF) a:3KHammerstein [18:25:40] (03PS3) 10Jdlrobson: Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 (owner: 10Robmoen) [18:26:01] rmoen_: so i need help getting all your stuff merged [18:26:11] im going to review the echo patch now [18:26:27] if you could fix up your other patch and do the follow up for the moderation link that would be great. [18:26:28] 6Mobile-Web: On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1228523 (10phuedx) a:5KHammerstein>3None [18:26:46] 6Mobile-Web: On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1209865 (10phuedx) [18:28:17] kaity: https://phabricator.wikimedia.org/T96326 [18:28:51] 6Mobile-Web, 3Mobile-Web-Design: On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1228539 (10KLans_WMF) [18:30:47] (03CR) 10Jdlrobson: [C: 032] Fix regression in menu animations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205882 (https://phabricator.wikimedia.org/T96617) (owner: 10Phuedx) [18:32:22] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1228569 (10kaldari) JonK says we should probably reuse the existing schema (with a new field for the mobile mode): https://meta.wikimedia.org/wiki/Schema:Search [18:32:53] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1228571 (10KHammerstein) [18:34:28] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1228577 (10Anomie) >>! In T95516#1228112, @Jhernandez wrote: > I feel it is really weird to return `"list... [18:38:30] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1228597 (10KHammerstein) [18:39:15] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1228599 (10KLans_WMF) Baha will talk to adam about this [18:39:58] Deskana: how much do you know about the 'CSS image crop' template/feature? Is it very commonly used? [18:40:11] mholloway: I've never heard of it. Can you show it to me? [18:40:21] Deskana: https://en.wikipedia.org/wiki/Template:CSS_image_crop [18:40:31] bearND: ^ [18:40:36] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1228624 (10KHammerstein) [18:41:23] * Deskana investigates [18:41:26] Deskana: It seems uncommon, but it messes with our image handling. See the article 'Seated liberty dollar' in the app, for example [18:42:00] At least on my phone, the first image under subheading 'Golbrecht dollar' doesn't display properly in portrait orientation [18:42:17] In landscape it's fine [18:42:24] mholloway: It's used in around 500 articles on the English Wikipedia. [18:43:05] Hmm. [18:43:09] mholloway: So, around 0.01% of articles. :-) [18:44:27] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1228634 (10KHammerstein) [18:44:29] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1228636 (10JKatzWMF) @ phuedx Special:TopicTag should be fine for a prototype [18:44:58] mholloway: you mean it messes with the image width changes you're working on? [18:45:09] mholloway: Do you want me to check out your patch and take a look? [18:45:18] bearND: I noticed it because of those changes, but the problem preexists my changes [18:45:26] precedes? [18:45:27] anyway [18:45:44] bearND: It's also off if you look at it in the current beta (presumably production as well) [18:45:54] TIL https://en.m.wikipedia.org/wiki/Death_march_%28project_management%29 [18:47:59] bearND: /Users/mholloway/Desktop/Gobrecht.png [18:48:11] bearND: Hmm, that didn't work. [18:51:00] mholloway: What is it that actually happens? It deals with the uncropped version? [18:53:07] Deskana: I'd need to look at other examples to generalize, but at least in the Seated liberty dollar article the image in question doesn't show up at all in portrait mode. (After the current version of my changes, the right half of the CSS-cropped image appears on the left side of the screen.) [18:54:25] * Deskana finds you some other examples [18:54:51] 6Mobile-Web: (5) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1228674 (10KLans_WMF) [18:55:12] mholloway: https://en.wikipedia.org/wiki/Abraham_Lincoln#1864_re-election [18:55:21] mholloway: The first image in that uses the same template [18:57:10] 6Mobile-Web: (5) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1228681 (10phuedx) [18:58:06] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1228682 (10kaldari) [18:59:04] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1228688 (10phuedx) [19:00:08] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: (3) Create a special page for tags - https://phabricator.wikimedia.org/T96015#1228691 (10KLans_WMF) [19:01:36] jdlrobson: i didn't track down where that regression came from [19:01:40] (the menu regression) [19:02:00] Deskana: interesting. [19:03:21] Deskana: That one displays OK in production. With my changes it's off-center and I need to fix it. I think why the image in https://en.wikipedia.org/wiki/Seated_Liberty_dollar is messed up is that it's just the right half of a long horizontal image. [19:03:43] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1228697 (10Yurik) Yep, good work on that @anomie! I really wish I foresaw that XML was a mistake back in... [19:04:12] kaldari, bmansurov, JonKatz: i was saying at the end of the meeting that i'll try to put a little more detail in the tasks that i create [19:04:26] phuedx: i heard you and thanks [19:04:47] the cards were written with some knowledge of the work the gather team has already done to make their code lovely [19:04:54] 6Mobile-Web: (5) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1228699 (10kaldari) [19:04:56] and that wasn't reflected in the tasks [19:04:56] mholloway: I'd suggest testing a few more and seeing if they're okay. My general thinking about this is that it's okay if there are one or two edge cases, just make sure that those are noted in a follow-up task that can be handled. [19:05:02] mholloway: Let me find you some more examples. [19:05:11] Deskana: And if I'm reading https://en.wikipedia.org/wiki/Template:CSS_image_crop correctly, it's actually sort of a preview feature that shouldn't make it into committed changes? [19:05:41] 6Mobile-Web: (5) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1190681 (10kaldari) [19:05:56] Deskana: sounds good. [19:06:00] mholloway: https://en.wikipedia.org/wiki/Tomb_Raider#1996.E2.80.932003:_Tomb_Raider_to_The_Angel_of_Darkness [19:06:07] mholloway: This one is funny because it even looks messed up on desktop. [19:06:22] mholloway: https://en.wikipedia.org/wiki/Stone_of_Scone [19:06:22] Deskana: hahaha, indeed it does. [19:06:23] kaldari, bmansurov: should we organise a walkthrough with the gather team? [19:06:25] mholloway: First image in there. [19:06:35] phuedx: that'd be good [19:07:11] mholloway: https://en.wikipedia.org/wiki/Christian_IX_of_Denmark#Reign [19:07:39] mholloway: This might be a good thing to ask Moushira to take care of. You're right that really it shouldn't end up in articles, and that's probably why there are so few usages. [19:07:56] mholloway: "take care of" in the sense that she can spread the word that these should be fixed, that is. [19:08:00] mholloway: Not take care of herself. [19:08:35] mholloway: I'll send her an email about this later. [19:08:38] * Deskana writes that down [19:08:48] (03PS16) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [19:09:09] Deskana: Cool. Should I still create the Phab task? [19:09:52] mholloway: Yeah, if you've caused a slight breakage by introducing your change then I'd still create the task. I think the tradeoff is acceptable, though, for now at least. [19:10:32] (03PS17) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [19:11:50] Deskana: Cool. Will investigate a little bit more and write it up. Thanks for your help looking into it! [19:11:57] mholloway: Happy to assist! [19:12:20] mholloway, bearND: FWIW, I'm still more than happy to assist with random stuff like this even after the transition. :-) [19:12:50] Deskana: Excellent! [19:15:22] ok, invitation sent for a quick walkthrough tomorrow (which looks good for everyone) [19:15:31] am gonna call it a night [19:15:33] g'night folks! [19:16:15] (03PS18) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [19:16:39] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: As a curious apps reader, I'd like a feed of articles/facts/images so that I can learn more about topics I'm interested in. - https://phabricator.wikimedia.org/T93327#1228788 (10KHammerstein) [19:17:09] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Wikimedia-Hackathon-2015-App-Prep: As a curious apps reader, I'd like a feed of articles/facts/images so that I can learn more about topics I'm interested in. - https://phabricator.wikimedia.org/T93327#1134525 (10KHammerstein) [19:18:05] 3Gather Sprint Forward: When editing collection, don't call api and reload if there were no changes - https://phabricator.wikimedia.org/T96897#1228793 (10Jhernandez) 3NEW [19:23:26] 10Gather, 3Gather Sprint Forward: Phone screen improvements on Adding to collection modal - https://phabricator.wikimedia.org/T96837#1228818 (10JKatzWMF) @jhernandez @msyed. Yes! Moiz and I discussed this very issue on monday and came to similar conclusions. Moiz the only thing we discussed differently was r... [19:25:28] 10Gather, 3Gather Sprint Forward: Phone screen improvements on Adding to collection modal - https://phabricator.wikimedia.org/T96837#1228828 (10JKatzWMF) [19:25:56] 10Gather, 3Gather Sprint Forward: Phone screen improvements on Adding to collection modal - https://phabricator.wikimedia.org/T96837#1227238 (10JKatzWMF) @jhernandez edited descriptions (used strikethrough) and added one item [19:29:43] (03PS1) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205918 [19:31:04] (03Abandoned) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205809 (owner: 10Mhurd) [19:36:11] (03PS2) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205918 [19:38:34] Lunch time! [19:38:35] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1228872 (10Jdlrobson) @anomie super cool. So glad this is happening. [19:57:07] 10Gather, 10Continuous-Integration: PHPUnit tests do not get run by Jenkins for Gather commits - https://phabricator.wikimedia.org/T96904#1228924 (10Jdlrobson) 3NEW [19:58:54] (03Merged) 10jenkins-bot: Fix regression in menu animations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/205882 (https://phabricator.wikimedia.org/T96617) (owner: 10Phuedx) [19:59:35] (03PS3) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205918 [20:01:13] (03CR) 10jenkins-bot: [V: 04-1] Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 (owner: 10Robmoen) [20:03:36] (03PS1) 10Jdlrobson: Fix ups [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205959 [20:07:24] food brb [20:09:17] (03CR) 10jenkins-bot: [V: 04-1] Fix ups [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205959 (owner: 10Jdlrobson) [20:10:00] (03CR) 10Jdlrobson: [C: 032] Do not use a url for the "delete collection" confirmation dialog [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205637 (https://phabricator.wikimedia.org/T96167) (owner: 10Jhernandez) [20:13:13] (03CR) 10Jdlrobson: [C: 04-1] "This patch changes nothing on master for me." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) (owner: 10Jhernandez) [20:15:00] (03CR) 10Jdlrobson: [C: 04-1] "should only happen when i create a new collection, not add to an existing collection." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205625 (https://phabricator.wikimedia.org/T95976) (owner: 10Jhernandez) [20:17:51] (03PS8) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [20:18:18] jdlrobson: ^ [20:18:52] jdlrobson: on successful flag, I'm removing the icon rather than disabling it as its an "a" tag. Thoughts? [20:19:50] (03CR) 10Jdlrobson: [C: 04-1] Design: Improve spacing of content overlay on phones (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205834 (https://phabricator.wikimedia.org/T95628) (owner: 10Jhernandez) [20:19:58] (03Merged) 10jenkins-bot: Do not use a url for the "delete collection" confirmation dialog [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205637 (https://phabricator.wikimedia.org/T96167) (owner: 10Jhernandez) [20:20:23] (03CR) 10jenkins-bot: [V: 04-1] Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [20:22:10] (03PS1) 10Jdlrobson: DONOTMERGE: Follow up [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205962 [20:22:34] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Bug: Gather popup doesn't show all the content. - https://phabricator.wikimedia.org/T95628#1229139 (10Jdlrobson) @joakino see my follow up commit and instructions to this: https://gerrit.wikimedia.org/r/205962 [20:23:45] 10Gather, 3Gather Sprint Forward, 7I18n: in Special:Gather the content is shown in the UI language - https://phabricator.wikimedia.org/T96497#1229142 (10Jdlrobson) a:3Jdlrobson [20:24:37] (03PS9) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [20:24:40] (03CR) 10jenkins-bot: [V: 04-1] Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [20:28:37] (03PS10) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [20:29:12] (03PS4) 10Robmoen: Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 [20:29:37] (03PS2) 10Robmoen: Fix ups [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205959 (owner: 10Jdlrobson) [20:31:30] (03CR) 10jenkins-bot: [V: 04-1] Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [20:31:32] dr0ptp4kt: I'm on my way! [20:31:34] dr0ptp4kt: At home today, so joining hangout. [20:31:40] (03CR) 10jenkins-bot: [V: 04-1] Fix ups [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205959 (owner: 10Jdlrobson) [20:31:41] Deskana: cool [20:32:20] (03CR) 10jenkins-bot: [V: 04-1] Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 (owner: 10Robmoen) [20:33:39] (03PS5) 10Yurik: Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 [20:35:07] (03CR) 10jenkins-bot: [V: 04-1] Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 (owner: 10Yurik) [20:36:11] (03PS6) 10Yurik: Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 [20:37:02] (03PS1) 10Jdlrobson: i18n: Specify content language directions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205964 (https://phabricator.wikimedia.org/T96497) [20:37:47] (03CR) 10jenkins-bot: [V: 04-1] Automatically run all phpunit tests [extensions/Gather] - 10https://gerrit.wikimedia.org/r/197442 (owner: 10Yurik) [20:38:20] (03PS5) 10Robmoen: Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 [20:39:19] (03PS6) 10Robmoen: Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 [20:41:04] (03CR) 10jenkins-bot: [V: 04-1] Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 (owner: 10Robmoen) [20:41:14] (03CR) 10jenkins-bot: [V: 04-1] i18n: Specify content language directions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205964 (https://phabricator.wikimedia.org/T96497) (owner: 10Jdlrobson) [20:41:21] (03PS11) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [20:45:37] (03PS7) 10Robmoen: Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 [20:45:37] 3Gather Sprint Forward: When editing collection, don't call api and reload if there were no changes - https://phabricator.wikimedia.org/T96897#1229271 (10Jdlrobson) a:3Jdlrobson [20:47:56] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Create change log for CI builds - https://phabricator.wikimedia.org/T94423#1229281 (10Etonkovidova) In TestFlight, Wikipedia Alpha 4.1.1(85) build does not contain any text. [20:49:43] (03CR) 10Jdlrobson: [C: 032] Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 (owner: 10Robmoen) [20:52:36] (03Merged) 10jenkins-bot: Notify user when their collection is hidden or unhidden [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205443 (owner: 10Robmoen) [20:53:57] (03CR) 10Jdlrobson: Add flag collection button and confirm overlay (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [20:56:10] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add a flag button - https://phabricator.wikimedia.org/T94871#1174892 (10Jdlrobson) [20:56:28] (03CR) 10Jdlrobson: [C: 04-1] "let's fix these quick and merge" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [20:58:29] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add a flag button - https://phabricator.wikimedia.org/T94871#1229331 (10Jdlrobson) @JKatzWMF we haven't been clear on the disabled behaviour. Can you create a separate card about this - what does a disabled flag look like? Does the flag stay disabled if I... [21:05:31] (03PS1) 10BearND: Remove app id from page view requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205976 [21:06:31] (03CR) 10BearND: [C: 04-1] "Don't merge until Nuria and Oliver have +1'd" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205976 (owner: 10BearND) [21:09:43] (03PS9) 10Jdlrobson: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 [21:10:54] (03PS12) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [21:11:34] bgerstle: heya [21:11:41] hey [21:11:48] your patch looks good [21:11:54] bgerstle: yay! [21:12:00] i was getting carried away w/ writing a unit test to verify all localizations are transferrable [21:12:10] i found out how to get a dictionary for all the localized strings for each locale from the bundle [21:12:12] BUT [21:12:28] i can't access the transformer class since browserify scopes everything locally [21:12:29] which is good [21:12:37] ah [21:13:03] so i can do it manually w/ my own NSURLConnect/request if needed, but would've been nice to test the whole system w/ a call to transformer.httpGetSync [21:13:32] bgerstle: ya that'd be great! follow-on patch? [21:13:36] (03CR) 10Bgerstle: [C: 031] "just some assertion comments" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd) [21:13:41] mhurd yeah [21:13:45] meant to send those earlier ^ [21:13:55] bgerstle: checking... [21:13:57] (03CR) 10Jdlrobson: Add flag collection button and confirm overlay (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [21:14:06] minor [21:14:27] bgerstle: lol that second one was a big oops :) [21:14:46] (03PS2) 10Jdlrobson: i18n: Specify content language directions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205964 (https://phabricator.wikimedia.org/T96497) [21:14:49] easy to forget [21:14:57] bgerstle: amending... [21:15:01] (03Abandoned) 10Jdlrobson: Fix ups [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205959 (owner: 10Jdlrobson) [21:15:49] mhurd where do i test the localization stuff in the app [21:15:59] i.e. where do i see localized stuff in the web view [21:16:04] the protocol seems to work, just wanna double check [21:16:05] bgerstle: quick hangout? [21:16:34] can do a quick one, but i'll probably need to step out soon [21:16:54] mhurd to teh cave of flying rodents? [21:16:59] bgerstle: ya [21:17:08] (03PS9) 10Jdlrobson: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) [21:17:22] (03PS7) 10Jdlrobson: Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 [21:17:33] (03PS5) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [21:17:35] (03CR) 10Nuria: "I guess this means that unique report for mobile needs to be updated. I would file a phabricator ticket to analytics for that." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205976 (owner: 10BearND) [21:17:41] (03CR) 10Nuria: [C: 031] Remove app id from page view requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205976 (owner: 10BearND) [21:18:00] dr0ptp4kt: Deskana: ^ [21:19:16] nuria: The unique reports and session reports will need to support both the old way (as a query parameter) *and* the new way (as a X-WMF-UUID header), so that people that don't update their app are counted. [21:19:20] nuria: Is that okay? :-) [21:19:40] * jdlrobson grabs coffee [21:20:11] Deskana: yes, understood, but the uuid header needs to be documented on the xanalytics page in wikitech [21:20:33] nuria: Absolutely. dr0ptp4kt, bearND and I are in a meeting updating the code and the documentation as we speak. :-) [21:20:42] Deskana: there are a lot of things on x-analytics and it is getting harder to know which one is which [21:20:51] Deskana: niceeee [21:26:49] (03PS13) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [21:26:54] kristenlans: wondering about today's design review [21:27:19] Bernd, Corey and Brian are out. [21:27:32] Maybe we could move this one instance to next week? [21:28:27] Deskana: kristenlans [21:28:34] Let me know what you think. [21:28:57] (03PS19) 10Mhurd: Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 [21:29:11] (03PS4) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205918 [21:29:20] (03CR) 10Bgerstle: [C: 032] Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd) [21:29:36] (03CR) 10Bgerstle: [V: 032] Added buttons for toggling similar pages / page issues. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/204433 (owner: 10Mhurd) [21:29:56] (03CR) 10Bgerstle: [C: 032] Remove run-time css sync so we have more control over css deployment. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205760 (owner: 10Mhurd) [21:30:07] (03CR) 10Bgerstle: [V: 032] Remove run-time css sync so we have more control over css deployment. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205760 (owner: 10Mhurd) [21:30:48] vibha: I think we can probably cancel it, given that I don't think we have many designs to review. [21:30:55] kristenlans, dr0ptp4kt, bearND ^ [21:31:14] (03CR) 10Robmoen: [C: 04-1] "Found race condition. fixing now" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [21:33:42] vibha dr0ptp4kt bearND if Deskana and y'all are ok with cancelling, fine w/ me :-) [21:34:44] (03PS5) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205918 [21:35:00] (03PS6) 10Mhurd: Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205918 [21:35:04] (03PS1) 10Dr0ptp4kt: Remove superfluous appInstallID from URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205980 [21:35:21] (03CR) 10Bgerstle: [C: 032] Fix for article centric strings not using article lang localizations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205918 (owner: 10Mhurd) [21:35:49] (03CR) 10Dr0ptp4kt: [C: 04-1] "Do not merge until Analytics has +1'd." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205980 (owner: 10Dr0ptp4kt) [21:36:23] 10Wikipedia-iOS-App: 4.1.1(85) the editing icon(the pencil icon) is displayed twice - https://phabricator.wikimedia.org/T96922#1229412 (10Etonkovidova) 3NEW [21:36:35] (03PS3) 10Mhurd: refactor MWKTestCase and fix linting errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205874 (owner: 10Bgerstle) [21:36:41] (03CR) 10Mhurd: [C: 032] refactor MWKTestCase and fix linting errors [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205874 (owner: 10Bgerstle) [21:37:00] (03PS14) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [21:37:05] kristenlans: I'm ok with cancelling it [21:37:34] (03PS15) 10Robmoen: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 [21:39:41] dr0ptp4kt, bearND|flood, nuria: Making a first pass at documentation now [21:39:43] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add a flag button - https://phabricator.wikimedia.org/T94871#1229427 (10MSyed) @Jdlrobson the flag should never be shown in a disable state. If you're an anon, then you shouldnt seen any flag icon. [21:39:58] kristenlans: Let's cancel then, and catch up asynchronously if needed. [21:40:09] vibha, dr0ptp4kt, bearND|flood ^ [21:44:47] dr0ptp4kt: Looks like you beat me to it with the documentation! I'll merge what I wrote with yours. [21:45:07] Deskana: thanks! [21:45:07] dr0ptp4kt: Although both you and I put your name in the contact person section ;-) [21:45:31] Deskana: :) [21:46:36] Deskana: and this said, i have this sneaking suspicion there will be patchsets submitted to the apps relating to search in the future. [21:46:44] ...from a certain Deskana [21:46:56] dr0ptp4kt: ^_^ [21:47:16] Well, I plan to continue making random contributions to both apps, as well [21:48:02] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: {{main}} template not showing in articles - https://phabricator.wikimedia.org/T96228#1229477 (10Mhurd) a:3Mhurd [21:48:44] Deskana: hey you around? i have quick question about https://phabricator.wikimedia.org/T96228 [21:49:17] mhurd: Can you give me two minutes? [21:49:24] Deskana: ya! [21:49:30] mhurd: Cool, want me to call you when I'm done? [21:49:31] Deskana: ya [21:50:24] (03CR) 10Bmansurov: [C: 032] Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [21:51:16] dr0ptp4kt, bearND|flood, nuria: Documentation done! Please review. https://wikitech.wikimedia.org/wiki/X-Analytics [21:51:22] mhurd: Calling you. [21:51:29] jdlrobson rmoen any idea why betalabs still hasn't updated with this change (and others): https://phabricator.wikimedia.org/T96319 [21:51:55] 3Gather Sprint Forward: Update in WikimediaMessages extension for enwiki - https://phabricator.wikimedia.org/T96805#1229498 (10rmoen) @Jdlrobson, Honestly it seems wrong to add a gather specific message to WikimediaMessages. It looks like the only extension which has added anything here is Flow. Also I'm not en... [21:52:38] Deskana: batcave? [21:52:44] mhurd: Sure, that works. [21:54:16] JonKatz: No idea, will look at that [21:54:29] rmoen thanks, just want to signoff on stuff [21:55:17] kristenlans: I could really use the time for some planning. [21:56:12] mhurd: Er, I closed the tab a bit fast. I did say bye, I hope you heard. :P [21:56:20] Deskana: haha no worry! [21:56:50] dr0ptp4kt: brian and i got our outstanding patches reviewed/merged. should be good to go for testflight [21:57:14] mhurd: cool, i'll be back at my desk pretty soon so we can go over things [21:57:17] (03Merged) 10jenkins-bot: Add button abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204408 (https://phabricator.wikimedia.org/T87254) (owner: 10Jdlrobson) [21:57:18] dr0ptp4kt: yay! [21:57:23] vibha cancelled [21:57:39] kristenlans: Thank you thank you [21:57:47] kristenlans: why would you cancel vibha? ;) [21:58:16] mhurd: For the exact same reason that I fixed that bug before. [21:58:21] Deskana: lol [21:58:36] JonKatz: I'm not an admin on betalabs ;/ [21:58:54] mhurd oh crap!!!! REVERT REVERT!!! [21:58:58] lol [21:59:49] rmoen: Check again. :-) [22:00:11] (03CR) 10Kaldari: "Also changes I374fd141d5 and I5af873b4807a2 will be needed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [22:00:12] Deskana: nice, Ty [22:01:31] JonKatz: hmm i see "Failed to Hide list Hide" :/ [22:03:01] (03CR) 10Bmansurov: [C: 032] Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 (owner: 10Jdlrobson) [22:04:36] rmoen yes, the list is hidden but you get a failure message. The point is that none of the tickets in sign-off (or most of them) are not reflected in wmflabs [22:04:55] rmoen, jdlrobson just told me there is a bug looking into why this is. [22:04:56] (03Merged) 10jenkins-bot: Hygiene: Add button partial support to overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204409 (owner: 10Jdlrobson) [22:05:11] oh [22:06:03] JonKatz: Good to know, I was dissecting the admin hide/show code. [22:06:32] (03PS4) 10Jdlrobson: Hygiene: Simplify PageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 [22:07:19] (03CR) 10Deskana: [C: 04-1] "Should not be merged until T96926 is resolved." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205976 (owner: 10BearND) [22:07:49] (03CR) 10Deskana: [C: 04-1] "Should not be merged until T96926 is resolved." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205980 (owner: 10Dr0ptp4kt) [22:08:08] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify PageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 (owner: 10Jdlrobson) [22:10:31] mhurd: Question for you. I had trouble building the iOS app. [22:10:39] mhurd: It got stuck at custom script 4 of 6. [22:11:03] mhurd: Any thoughts? I've already done a hard reset and pull master, and a pod install. [22:11:28] Deskana: did you run make? [22:11:48] or "make install" rather [22:12:10] mhurd: Oh, I have to do that? From what directory? [22:12:37] Deskana: from wikipedia [22:12:56] Deskana: not sure if you have to, but i think it ensures some bits are in place [22:13:12] Dan-Garry:wikipedia dgarry$ make install [22:13:12] (03CR) 10Jdlrobson: [C: 032] Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [22:13:12] make: *** No rule to make target `install'. Stop. [22:13:14] Hmm. [22:13:36] I see the makefile though. [22:14:31] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add a flag button - https://phabricator.wikimedia.org/T94871#1229566 (10Jdlrobson) @JKatzWMF @Msyed the task asked to show this to anons. When beta labs is back up and running can you review and create a follow up sub task before signing off if you are unh... [22:15:03] (03PS1) 10Mhurd: Only collapse lead section hatnotes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205996 [22:15:23] mhurd: I commented out the scripts and it works now. Oh well. [22:15:24] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: {{main}} template not showing in articles - https://phabricator.wikimedia.org/T96228#1229569 (10Mhurd) https://gerrit.wikimedia.org/r/#/c/205996/ [22:15:38] (03Merged) 10jenkins-bot: Add flag collection button and confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204611 (owner: 10Robmoen) [22:18:57] 6Mobile-Web: Rewrite MobileFrontend frontend code in OOJS UI - https://phabricator.wikimedia.org/T96202#1229580 (10bmansurov) [22:18:58] 6Mobile-Web, 5Patch-For-Review: Create button abstraction - https://phabricator.wikimedia.org/T87254#1229578 (10bmansurov) 5Open>3Resolved a:3bmansurov [22:20:26] (03CR) 10Deskana: [C: 031] "Fixes the relevant issue." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205996 (owner: 10Mhurd) [22:22:01] (03PS4) 10Jdlrobson: Don't surface 'public' property in addition to 'perm' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) [22:24:44] (03CR) 10Kaldari: "Ug, this really feels like over-abstraction to me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [22:25:46] 3Gather Sprint Forward: when a user accidentally swipes left or right on the create collection overlay, the overlay freezes and they cannot scroll anymore - https://phabricator.wikimedia.org/T96445#1229597 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Tried to replicate this with Jon Katz and we couldn't. [22:27:05] Deskana: yay! [22:27:27] (03CR) 10Dr0ptp4kt: [C: 032] Only collapse lead section hatnotes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205996 (owner: 10Mhurd) [22:27:34] (03CR) 10Dr0ptp4kt: [V: 032] Only collapse lead section hatnotes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205996 (owner: 10Mhurd) [22:28:17] Deskana: did "make install" help? [22:28:26] mhurd: No, I get that same error. [22:28:37] Dan-Garry:wikipedia dgarry$ make install [22:28:37] make: *** No rule to make target `install'. Stop. [22:29:01] But... [22:29:03] Dan-Garry:wikipedia dgarry$ ls -l | grep Makefile [22:29:03] -rw-r--r-- 1 dgarry staff 6084 22 Apr 13:43 Makefile [22:29:07] There's a makefile. [22:29:59] mhurd: I didn't actually merge that patch, btw. I just gave it +1. :-) [22:30:29] Deskana: adam merged it after he saw your +1 [22:31:03] Oh, stupid. [22:31:49] Deskana: looks great [22:32:45] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Create anchor abstraction (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [22:33:02] Deskana: try "make build-sim" [22:33:22] Deskana: or "make check-deps" [22:33:54] Deskana: "make bootstrap" will try to install all dependencies [22:40:23] (03PS2) 10Mholloway: [WIP] Use a higher-res image if available and set it to the width of the column text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205649 (https://phabricator.wikimedia.org/T94646) [22:42:15] (03PS6) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [22:42:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [22:46:24] (03PS7) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [22:46:39] (03PS1) 10Mhurd: Remove cruft file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206001 [22:47:29] (03CR) 10Dr0ptp4kt: [C: 032] Remove cruft file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206001 (owner: 10Mhurd) [22:47:41] (03CR) 10Yurik: [C: 032] Don't surface 'public' property in addition to 'perm' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) (owner: 10Jdlrobson) [22:49:04] (03CR) 10Kaldari: [C: 04-1] Beta: Add the Tags section (0311 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [22:49:18] Deskana: ping me if you're still having Xcode issues. can hangout and figure it out [22:49:24] (03Merged) 10jenkins-bot: Don't surface 'public' property in addition to 'perm' [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205726 (https://phabricator.wikimedia.org/T96665) (owner: 10Jdlrobson) [22:50:37] mhurd: Nah, it's okay. I'll figure it out with you on Friday. [22:50:56] Deskana: k. sorry it was troublesome! [22:52:04] (03CR) 10Nuria: [C: 031] Remove superfluous appInstallID from URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/205980 (owner: 10Dr0ptp4kt) [22:55:34] (03CR) 10Jdlrobson: Hygiene: Create anchor abstraction (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [22:56:51] Deskana: did i show you the lead image on enwiki "abstraction"? [22:57:43] 10Gather: better distinguish that collection is a user's perspective on the page itself (no way to mistake that it is W's) - https://phabricator.wikimedia.org/T96931#1229678 (10JKatzWMF) 3NEW a:3MSyed [23:00:39] is florian around? [23:02:06] mhurd: Haha, no. [23:03:00] mhurd: I fixed it. [23:04:23] (03CR) 10Kaldari: Beta: Add the Tags section (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [23:08:59] (03PS1) 10Yurik: Fixed broken SkinMinerva::getLicenseLink() [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/206005 [23:09:06] aude, ^ [23:12:35] yurik, ugh [23:12:54] $a = ...(); $a = $a['stuff']; [23:13:17] I wish we'd update those php 5.3 machines :( [23:13:38] (03PS2) 10Yurik: Fixed broken SkinMinerva::getLicenseLink() [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/206005 [23:13:58] yurik: some of the code looks scary to me [23:14:03] (03PS1) 10Jdlrobson: Hygiene: Kill dead css on diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206007 [23:14:04] especially w/o tests :/ [23:14:22] yet looks reasonable for the mobile change [23:14:37] aude, its already broken :D [23:14:48] yeah [23:14:55] just +2 [23:15:04] will see if it works in prod :) [23:15:14] Krenair, yep [23:15:22] (03PS2) 10Kaldari: Making the Gather login and signup messages work in standard way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205473 [23:15:25] aude, ^ [23:15:30] sorry ^^ [23:15:34] if ( $link ) { [23:15:35] hmm... in that case ^^^^ [23:15:45] vs explicit checks for example [23:16:19] aude, i have no clue what that code does, just updating it to match the change in the func [23:16:32] it won't be any worse ) [23:16:37] and currently prod for all of zero is dead [23:16:42] not good :) [23:17:24] there [23:17:24] (03CR) 10Aude: [C: 032] "based on https://gerrit.wikimedia.org/r/#/c/197693/18/includes/skins/SkinMinerva.php, this looks like it will fix the issue" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/206005 (owner: 10Yurik) [23:17:53] very much would like more tests :) [23:18:02] so jenkins can catch these things [23:18:36] aude, yeah, would be good ) [23:19:00] who wants to deploy/ [23:19:11] it's 1 am [23:19:24] * aude not but think you can get it into swat [23:20:18] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: No icon for search with JS disabled / doesn't look like a button - https://phabricator.wikimedia.org/T96637#1229717 (10bmansurov) a:3bmansurov [23:21:00] (03PS1) 10Alex Monk: Fixed broken SkinMinerva::getLicenseLink() [extensions/ZeroBanner] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/206011 [23:21:52] * yurik wants to yell at florian [23:23:00] (03CR) 10Alex Monk: [C: 032] Fixed broken SkinMinerva::getLicenseLink() [extensions/ZeroBanner] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/206011 (owner: 10Alex Monk) [23:23:00] yurik: No yelling at volunteers, please. :-) [23:23:06] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1229719 (10Mholloway) While testing today, I found that certain images edited with a fairly... [23:23:10] tests test tests :) [23:23:11] (03Merged) 10jenkins-bot: Fixed broken SkinMinerva::getLicenseLink() [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/206005 (owner: 10Yurik) [23:23:48] Deskana, i will yell quietly... as in... production broke, please check out all production extensions when making a change :) [23:24:05] (and yes, we do need unit tests in general) [23:24:10] Quiet, polite yelling is... acceptable. :-) [23:24:26] (03Merged) 10jenkins-bot: Fixed broken SkinMinerva::getLicenseLink() [extensions/ZeroBanner] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/206011 (owner: 10Alex Monk) [23:24:31] jenkins can do that... test extension combinations [23:24:32] yep... and don't you raise your font at me! :D [23:24:52] (03PS1) 10Bmansurov: Make the search button look like a button for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206014 (https://phabricator.wikimedia.org/T96637) [23:25:07] anyway, need sleep :) [23:28:57] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: PLURAL support for MobileFrontend licensing messages - https://phabricator.wikimedia.org/T93058#1229736 (10Yurik) Sigh, production broke because [[ https://gerrit.wikimedia.org/r/#/c/206005/ | ZeroBanner was using getLicenseLink ]]() f... [23:30:00] (03PS1) 10Jdlrobson: Hygiene: Stop using mw-ui-button without abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 [23:31:46] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Stop using mw-ui-button without abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 (owner: 10Jdlrobson) [23:36:09] (03CR) 10Jdlrobson: [C: 04-1] "I think you forgot to update the messages. All the messages change with your patch. Styling looks great though." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) (owner: 10Kaldari) [23:41:00] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1229751 (10Jdlrobson) [23:41:01] 3Gather Sprint Forward, 5Patch-For-Review: API public/perm inconsistencies - https://phabricator.wikimedia.org/T96665#1229750 (10Jdlrobson) 5Open>3Resolved [23:46:28] (03PS5) 10Kaldari: Rewrite mobile login page to be less hacky and closer to core version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) [23:48:52] (03PS6) 10Kaldari: Rewrite mobile login page to be less hacky and closer to core version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) [23:49:48] (03PS1) 10Alex Monk: Fixed broken SkinMinerva::getLicenseLink() [extensions/ZeroBanner] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/206020 [23:51:44] (03CR) 10Alex Monk: [C: 032] Fixed broken SkinMinerva::getLicenseLink() [extensions/ZeroBanner] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/206020 (owner: 10Alex Monk) [23:52:12] (03PS1) 10Deskana: Don't display "read more" suggestions outside main namespace [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206021 (https://phabricator.wikimedia.org/T92787) [23:53:14] (03Merged) 10jenkins-bot: Fixed broken SkinMinerva::getLicenseLink() [extensions/ZeroBanner] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/206020 (owner: 10Alex Monk) [23:53:14] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 5Patch-For-Review: Read more autogenerated? suggestions don't make much sense outside of content namespaces - https://phabricator.wikimedia.org/T92787#1229791 (10Deskana) 5stalled>3Open [23:53:39] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Read more autogenerated? suggestions don't make much sense outside of content namespaces - https://phabricator.wikimedia.org/T92787#1120319 (10Deskana) [23:53:56] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Read more autogenerated? suggestions don't make much sense outside of content namespaces - https://phabricator.wikimedia.org/T92787#1120319 (10Deskana) a:3Deskana [23:59:19] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Create anchor abstraction (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson)