[00:00:46] 10Wikipedia-Android-App: Document how the namespace field works in PageTitle class - https://phabricator.wikimedia.org/T96939#1229814 (10Deskana) 3NEW [00:01:31] (03PS7) 10Kaldari: Rewrite mobile login page to be less hacky and closer to core version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) [00:29:26] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android: Document how the namespace field works in PageTitle class - https://phabricator.wikimedia.org/T96939#1229875 (10Deskana) a:3Deskana [00:29:53] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Slightly decrease minimum text size on Share a Fact cards - https://phabricator.wikimedia.org/T96398#1229880 (10Deskana) 5Open>3Resolved [00:31:02] (03PS1) 10Deskana: Hygiene: Add documentation to namespace field in PageTitle class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206037 (https://phabricator.wikimedia.org/T96939) [00:32:55] 10Wikipedia-Android-App: Fix HistoryEntryPersistenceHelper and SavedPagesPersistenceHelper so they do not inappropriately set the namespace of all pages to null - https://phabricator.wikimedia.org/T96944#1229890 (10Deskana) 3NEW [00:33:46] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Document how the namespace field works in PageTitle class - https://phabricator.wikimedia.org/T96939#1229899 (10Deskana) I added some documentation and uncovered an inconsistency in the way the namespace is set, which is actually note... [00:34:27] 6Mobile-Web: Empty delimiter warning being generated by SkinMinerva.php - https://phabricator.wikimedia.org/T96945#1229901 (10kaldari) 3NEW [00:34:55] 10Wikipedia-Android-App: Fix HistoryEntryPersistenceHelper and SavedPagesPersistenceHelper so they do not inappropriately set the namespace of all pages to null - https://phabricator.wikimedia.org/T96944#1229890 (10Deskana) [00:56:59] rmoen did we deploy? [03:01:00] (03PS2) 10BearND: Remove app id from page view requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205976 [03:54:38] (03PS2) 10Deskana: Hygiene: Add documentation to namespace field in PageTitle class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206037 (https://phabricator.wikimedia.org/T96939) [03:56:57] (03PS3) 10Deskana: Hygiene: Add documentation to namespace field in PageTitle class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206037 (https://phabricator.wikimedia.org/T96939) [04:25:35] 6Mobile-Web, 10MobileFrontend: "Last modified..." text differs between desktop and mobile - https://phabricator.wikimedia.org/T89219#1230157 (10Krinkle) >>! In T89219#1033590, @Jaredzimmerman-WMF wrote: > I'd propose that we merge on a consistant "Last edited 1 month ago by Hafspajen" but have a tooltip on the... [04:28:31] (03PS1) 10Deskana: Hygiene: miscellaneous code quality fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206071 [04:32:15] (03PS2) 10Deskana: Hygiene: miscellaneous code quality fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206071 [04:38:34] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10MediaWiki-extensions-PageImages: Add support to PageImages for finding a freely licensed page image - https://phabricator.wikimedia.org/T95378#1230173 (10Deskana) [04:38:55] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10MediaWiki-extensions-PageImages: Add support to PageImages for finding a freely licensed page image - https://phabricator.wikimedia.org/T95378#1188204 (10Deskana) [04:40:31] 10Wikipedia-Android-App: Find out why app indexing doesn't seem to be working fully - https://phabricator.wikimedia.org/T91521#1230176 (10Deskana) 5Open>3Resolved Our contact said it's working perfectly. In short, I have no reason to not believe him. [04:48:26] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10MediaWiki-extensions-AbuseFilter: AbuseFilter should not let users specify arbitrary error codes which are then emitted over the API - https://phabricator.wikimedia.org/T96956#1230178 (10Deskana) 3NEW [04:48:40] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10MediaWiki-extensions-AbuseFilter: AbuseFilter should not let users specify arbitrary error codes which are then emitted over the API - https://phabricator.wikimedia.org/T96956#1230186 (10Deskana) [05:02:55] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1230314 (10dr0ptp4kt) The permission have been updated. Next I'll need to configure the group. [06:13:57] 10Wikipedia-Android-App, 6Mobile-Apps, 6Scrum-of-Scrums, 6Services: Add proper tests for MobileApps service routes - https://phabricator.wikimedia.org/T96870#1230347 (10bearND) [06:14:45] 10Wikipedia-Android-App, 6Mobile-Apps, 6Scrum-of-Scrums, 6Services, and 2 others: Update the MobileApps service to the latest version of the service template - https://phabricator.wikimedia.org/T96126#1230356 (10bearND) [06:15:21] 10Wikipedia-Android-App, 6Mobile-Apps, 6Scrum-of-Scrums, 6Services, and 3 others: Update the MobileApps service to the latest version of the service template - https://phabricator.wikimedia.org/T96126#1208881 (10bearND) [06:15:46] 10Wikipedia-Android-App, 6Mobile-Apps, 6Scrum-of-Scrums, 6Services, 3Mobile-App-Sprint-56-Android: Add proper tests for MobileApps service routes - https://phabricator.wikimedia.org/T96870#1227972 (10bearND) [06:33:46] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 7Epic: Deploy the latest version of WikiGrok (0.2? 0.3?) - https://phabricator.wikimedia.org/T95874#1202312 (10phuedx) The latest version of WikiGrok rode the train and was enabled as part of T94444. [06:34:08] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 7Epic: Deploy the latest version of WikiGrok (0.2? 0.3?) - https://phabricator.wikimedia.org/T95874#1230384 (10phuedx) 5Open>3Resolved a:3phuedx [06:34:58] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Regression: Noticeable delay when rendering main menu - https://phabricator.wikimedia.org/T96617#1230387 (10phuedx) 5Open>3Resolved [09:01:28] hey hey hey [09:13:47] morning [09:20:10] hey joakino [09:20:26] hi phuedx! [09:20:34] how're you? [09:20:53] fine fine :) and you? [09:22:07] phuedx: clojure west has been going on the last couple of days, lots of cool videos to watch at clojuretv's youtube [09:22:43] yeah i'm good [09:22:55] i've been fiddling with github's electron (previously atom-shell) project [09:23:02] which has been a nice change [09:23:11] joakino: any recs for videos? [09:23:33] also, if you have any strong recommendations, then i'll add you to the list of curators on sometalks.tumblr.com [09:27:48] phuedx: i usually like the ones I like the most https://www.youtube.com/playlist?list=LLj0TyysYrAlbpYIE0USCRTA [09:29:39] phuedx: i have a pretty cool list there :D, I just saw https://www.youtube.com/watch?v=0GzzFeS5cMc&index=38&list=LLj0TyysYrAlbpYIE0USCRTA , not from this conference but I remember I enjoyed it a lot [09:30:40] phuedx: hey do we have anything to show toasts after the page refreshes? like the EL post-render logging but for notices [09:31:30] (03CR) 10Jhernandez: [C: 04-1] "Your instance is too fast lol. I'll fix it." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) (owner: 10Jhernandez) [10:01:41] joakino: nope, but that'd be awesome [10:03:14] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Regression: Noticeable delay when rendering main menu - https://phabricator.wikimedia.org/T96617#1230820 (10phuedx) [10:11:22] phuedx: do you know if there is any way to force debug=true as default? I need to debug something that happens on a JS redirect and the debug=true param is removed :( [10:14:00] joakino: sec -- search my inbox [10:14:57] phuedx: i'm currently putting debuggers on code and using the devtools code prettification and that kind of works but it is cumbersome [10:16:04] joakino: wsResourceLoaderDebug = true [10:18:17] phuedx: localsettings? [10:18:29] yarrrp [10:19:28] phuedx: i'm guessing it's wg not ws [10:19:36] mibad [10:19:38] wg [10:19:39] yurp, ws.. does not exist [10:20:11] thx a lot phuedx [10:22:20] damn JS mutating everything all the time [10:22:36] getToasts() => [] [10:22:36] getToasts().push([msg, className]) => 1 [10:22:47] it get's me every time [10:24:40] i like programming languages that keep me on my toes [10:36:01] (03PS4) 10Jhernandez: When deleting collection hide dialog when actually finished [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) [10:42:24] (03PS5) 10Jhernandez: Deleting collection: hide dialog when finished, toast on refresh [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) [10:42:43] (03PS9) 10Phuedx: Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) [10:43:04] (03CR) 10Phuedx: Beta: Add the Tags section (0313 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [10:44:11] (03PS2) 10Jhernandez: Design: Improve spacing of content overlay on phones [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205834 (https://phabricator.wikimedia.org/T95628) [10:44:40] (03CR) 10Jhernandez: Design: Improve spacing of content overlay on phones (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205834 (https://phabricator.wikimedia.org/T95628) (owner: 10Jhernandez) [10:47:06] (03CR) 10Jhernandez: "Good catch! I missed that." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205625 (https://phabricator.wikimedia.org/T95976) (owner: 10Jhernandez) [10:58:43] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: $wgMFEditorOptions should be updated to reflect production - https://phabricator.wikimedia.org/T96634#1230900 (10phuedx) @Florian: Please do :) Your patches are always welcome. [10:59:05] 6Mobile-Web: (3) Create a special page for tags - https://phabricator.wikimedia.org/T96015#1230901 (10phuedx) [10:59:06] (03PS2) 10Jhernandez: Always point to collections menu item when creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205625 (https://phabricator.wikimedia.org/T95976) [10:59:49] brb -- nipping to the sop [10:59:50] *shop [11:00:04] gonna make george a peanut butter and jam sandwich [11:00:09] i'm interested to see if he likes it [11:02:49] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10MediaWiki-extensions-PageImages: Add support to PageImages for finding a freely licensed page image - https://phabricator.wikimedia.org/T95378#1230904 (10Raymond) All files on Wikimedia Commons are freely licensed. Non-free files are copyright violations and ha... [11:04:07] 3Gather Sprint Forward: When editing collection, don't call api and reload if there were no changes - https://phabricator.wikimedia.org/T96897#1230906 (10Jhernandez) @jdlrobson Can't find the patch at https://gerrit.wikimedia.org/r/#/q/owner:Jdlrobson+status:open+project:mediawiki/extensions/Gather,n,z :s [11:12:47] (03CR) 10Jhernandez: [C: 031] "It looks fine to me, but I'm not sure if how it looks is how rtl readers would expect it to look. Gonna ping people on the bug." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205964 (https://phabricator.wikimedia.org/T96497) (owner: 10Jdlrobson) [11:17:12] 10Gather, 3Gather Sprint Forward, 7I18n, 5Patch-For-Review: in Special:Gather the content is shown in the UI language - https://phabricator.wikimedia.org/T96497#1230910 (10Jhernandez) I don't have much knowledge on this, the current ui with this patch looks like this: {F154275} Is it expected that the bu... [11:24:22] i ahve to buy peanut butter next time i visit other country [11:24:30] i haven't seen it around here in spain [11:30:27] joakino: i have set a reminder for you in my todo list [11:30:56] how's so [11:31:05] what have i done [11:39:35] (03CR) 10Jhernandez: [C: 04-1] "A couple of minor hiccups, and a piece of code that seems from a different patch." (033 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205868 (https://phabricator.wikimedia.org/T94527) (owner: 10Jdlrobson) [11:40:46] (03CR) 10Jhernandez: "Also Yuri suggested adding to the title slug 'whatever-collection-by-Yurik' which also looks very nice in the url. What do you think?" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205868 (https://phabricator.wikimedia.org/T94527) (owner: 10Jdlrobson) [11:43:43] stupid connection [11:43:48] joakino: about the peanut butter [11:45:07] ooh [11:45:12] phuedx: for the hackathon? [11:45:28] yeah, i wonder what french peanut butter is like [11:45:33] phuedx: we can do a french bread toast with peanut butter and good wine [11:45:40] oh [11:45:42] em [11:45:43] gee [11:45:49] xd [11:48:07] http://www.tumblr.com/ [11:48:07] woops [11:48:14] phuedx: http://media.giphy.com/media/R5TrvjquNgYpO/giphy.gif [11:49:04] lolled really hard at https://media3.giphy.com/media/H0iH5If0cRHuU/200.gif [11:52:54] haha [12:20:57] (03CR) 10Florianschmidtwelzow: [C: 04-1] "some questions/suggestions :)" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [12:21:22] (03PS3) 10Florianschmidtwelzow: Add a new Wikitext editor with very basic formatting features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194945 (https://phabricator.wikimedia.org/T91752) [12:27:23] (03CR) 10Jhernandez: [C: 031] "Looks good to me, works fine. Yurik re-review plz" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson) [12:28:39] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Deleted pages in collections behaviour - https://phabricator.wikimedia.org/T93295#1230997 (10Jhernandez) First patch looks good to me and it works good. @yurik plz have a look back again, should be easy to re-review & merge [12:35:07] (03PS10) 10Phuedx: Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) [12:35:49] (03CR) 10Phuedx: Beta: Add the Tags section (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [12:39:47] (03PS3) 10Jhernandez: Save changes to members of collection only when done clicked [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [12:40:38] (03CR) 10Jhernandez: "Rebased on top of master." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [12:45:20] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194945 (https://phabricator.wikimedia.org/T91752) (owner: 10Florianschmidtwelzow) [12:46:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [12:46:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [12:47:22] (03CR) 10Florianschmidtwelzow: "thanks for your review, Siebrand! :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194945 (https://phabricator.wikimedia.org/T91752) (owner: 10Florianschmidtwelzow) [13:05:36] (03CR) 10Florianschmidtwelzow: Beta: Add the Tags section (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [13:06:34] (03PS4) 10Jhernandez: Save changes to members of collection only when done clicked [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [13:07:37] (03CR) 10Jhernandez: "I've changed the ajax calling to be parallel and only do the addition or removal call depending on what happened." (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [13:09:46] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1231058 (10Jhernandez) @jdlrobson Plz review PS3, I've changed how we make the ajax call so that they are parallel and only happen if they actually need to (the add call was always... [13:22:20] 10Wikipedia-Android-App: Only use public domain images for the Share A Fact feature - https://phabricator.wikimedia.org/T95092#1231081 (10MGChecker) 5declined>3Open Using this feature with CC-by-sa 3.0 pictures in Germany is according to aa judical decision of a German court illegal. That´s why it isn´t acce... [13:27:24] (03CR) 10Phuedx: [C: 032] "This LGTM." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206014 (https://phabricator.wikimedia.org/T96637) (owner: 10Bmansurov) [13:29:00] (03Merged) 10jenkins-bot: Make the search button look like a button for non-js users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206014 (https://phabricator.wikimedia.org/T96637) (owner: 10Bmansurov) [13:29:30] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: No icon for search with JS disabled / doesn't look like a button - https://phabricator.wikimedia.org/T96637#1231107 (10phuedx) [13:29:55] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: No icon for search with JS disabled / doesn't look like a button - https://phabricator.wikimedia.org/T96637#1231109 (10phuedx) 5Open>3Resolved [13:35:19] (03CR) 10Phuedx: "I need to test this locally. See inline for a comment about the design of the User public API." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [13:45:51] 6Mobile-Web, 10MobileFrontend, 7Design: Display the categories on the mobile site - https://phabricator.wikimedia.org/T24660#1231134 (10Nemo_bis) [13:47:27] 6Mobile-Web, 6Commons, 10MediaWiki-Parser, 7Design: Display of images in categories on mobile web site present only one image per row starting at some resolution. - https://phabricator.wikimedia.org/T78174#1231139 (10Nemo_bis) [13:48:34] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Category view shows no articles in the mobile app - https://phabricator.wikimedia.org/T71984#1231143 (10Nemo_bis) [13:48:57] 6Mobile-Web, 10MobileFrontend, 7Design: Display the categories on the mobile site - https://phabricator.wikimedia.org/T24660#284774 (10Nemo_bis) [13:49:25] 6Mobile-Web, 10MobileFrontend, 7Design: Display the categories on the mobile site - https://phabricator.wikimedia.org/T24660#1231151 (10Nemo_bis) 5Resolved>3Open Reopen per https://www.mediawiki.org/wiki/Thread:Extension_talk:MobileFrontend/Display_Category%3F [13:49:38] (03CR) 10Phuedx: [C: 04-1] "Trivial issues inline. Otherwise this looks good to me." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [13:49:48] 6Mobile-Web, 10MobileFrontend, 7Design: Display the categories on the mobile site - https://phabricator.wikimedia.org/T24660#1231154 (10Nemo_bis) [14:24:09] 3Gather Sprint Forward: When editing collection, don't call api and reload if there were no changes - https://phabricator.wikimedia.org/T96897#1231219 (10Jdlrobson) Shoot.. I had edited https://gerrit.wikimedia.org/r/#/c/204659/ but some reason it hasn't posted. I'll git reflog in office [14:28:45] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Share A Fact images should include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1231227 (10MartinK) Even if Fair Use is the excuse to ignore the the CC attribution requirements, this feature has to be disabled in all langua... [15:05:02] vibha: you around? [15:07:01] (03CR) 10Florianschmidtwelzow: Improve error handling for "Editor not available" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [15:19:09] hey kristenlans, jdlrobson o/ [15:25:08] phuedx o/ [15:27:48] (03PS6) 10Florianschmidtwelzow: Improve error handling for "Editor not available" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) [15:32:15] (03CR) 10jenkins-bot: [V: 04-1] Improve error handling for "Editor not available" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [15:33:04] (03PS5) 10Jdlrobson: Save changes to members of collection only when done clicked [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) [15:33:37] (03CR) 10jenkins-bot: [V: 04-1] Save changes to members of collection only when done clicked [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [15:38:15] (03CR) 10Phuedx: Improve error handling for "Editor not available" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [15:38:28] (03CR) 10Phuedx: "Ugh. Jerkins." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [15:44:10] (03PS1) 10Florianschmidtwelzow: Move Category button to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206130 [15:47:05] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [15:47:15] * FlorianSW huges Jenkins :D [15:47:58] (03CR) 10Florianschmidtwelzow: Improve error handling for "Editor not available" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [15:51:34] (03PS7) 10Florianschmidtwelzow: Improve error handling for "Editor not available" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) [15:53:45] Deskana: Hey, I have a couple questions for you, do you have time for a quick trip to the batcave before things get busy around the office? [15:57:57] mholloway: Not right now I'm afraid, I'm about to head out of the door. Can you wait until 11am? :-) [15:58:34] Deskana: Sure, nothing urgent! [16:02:51] (03PS9) 10Florianschmidtwelzow: Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) [16:05:29] 6Mobile-Web, 10MobileFrontend, 7Design: Display the categories on the mobile site - https://phabricator.wikimedia.org/T24660#1231418 (10Florian) a:3Florian Already possible in alpha (still in alpha), see https://gerrit.wikimedia.org/r/206130/ (change to move the category overlay to beta) [16:05:32] (03PS2) 10Florianschmidtwelzow: Move Category button to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206130 (https://phabricator.wikimedia.org/T24660) [16:08:31] (03PS1) 10Florianschmidtwelzow: Change default value of anonymousEditing to true [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206134 (https://phabricator.wikimedia.org/T96634) [16:10:45] (03PS4) 10Florianschmidtwelzow: Add a new Wikitext editor with very basic formatting features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194945 (https://phabricator.wikimedia.org/T91752) [16:19:14] (03CR) 10Jdlrobson: "I'm really concerned that the bottom of the page is becoming a dumping ground." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206130 (https://phabricator.wikimedia.org/T24660) (owner: 10Florianschmidtwelzow) [16:26:13] (03CR) 10Jdlrobson: "On another note this will clash with the wikigrok tag experiment being trialed in beta." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206130 (https://phabricator.wikimedia.org/T24660) (owner: 10Florianschmidtwelzow) [16:32:29] 10Wikipedia-iOS-App: 4.1.1(85): Extra white space around commas in collapsing boxes - https://phabricator.wikimedia.org/T97038#1231495 (10Etonkovidova) 3NEW [16:33:08] 10Wikipedia-iOS-App: 4.1.1(85) Extra comma in collapsing boxes - https://phabricator.wikimedia.org/T96288#1231502 (10Etonkovidova) [16:34:25] 10Wikipedia-iOS-App: 4.1.1(85) Extra comma in collapsing boxes - https://phabricator.wikimedia.org/T96288#1213402 (10Etonkovidova) The issue with extra white space before a comma in collapsible boxes was filed separately - https://phabricator.wikimedia.org/T97038 [16:35:30] 10Wikipedia-iOS-App: 4.1.1(85): Extra white space before commas in collapsing boxes - https://phabricator.wikimedia.org/T97038#1231512 (10Etonkovidova) [16:39:59] i'm back [16:41:41] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [16:42:24] (03CR) 10Phuedx: [C: 032] "This LGTM." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [16:42:54] hey joakino_ [16:42:57] wb [16:43:34] phuedx: is toying with emacs a sin? [16:43:43] nope [16:43:50] i do it roughly once a quarter [16:44:45] dropped off [16:44:47] phuedx: i feel better then [16:48:11] (03Merged) 10jenkins-bot: Improve error handling for "Editor not available" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204831 (https://phabricator.wikimedia.org/T96352) (owner: 10Florianschmidtwelzow) [16:50:39] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: MobileFrontend should show the correct reason, why a user can't edit a page - https://phabricator.wikimedia.org/T96352#1231593 (10phuedx) [16:50:49] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: MobileFrontend should show the correct reason, why a user can't edit a page - https://phabricator.wikimedia.org/T96352#1231594 (10phuedx) 5Open>3Resolved [16:50:50] 6Mobile-Web: If a user is blocked from editing a page (due to the false group), there should be a link to the history - https://phabricator.wikimedia.org/T95305#1231595 (10phuedx) [16:52:02] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Make Share a Fact cards only use free images - https://phabricator.wikimedia.org/T95379#1231600 (10Nemo_bis) I disagree that T95378 is a blocker. Where the license and attribution can't be ascertained, the image should simply be discarded (and/or the feature not of... [16:54:23] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Make Share a Fact cards only use free images - https://phabricator.wikimedia.org/T95379#1231616 (10Nemo_bis) [16:54:34] 10Gather, 3Gather Sprint Forward, 10MediaWiki-Vagrant: Create vagrant Gather role - https://phabricator.wikimedia.org/T90814#1231623 (10Jdlrobson) [16:54:42] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10MediaWiki-extensions-PageImages: Add support to PageImages for finding a freely licensed page image - https://phabricator.wikimedia.org/T95378#1231626 (10Nemo_bis) This would be helped by T95026, because all Commons images are free. [16:55:34] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Make Share a Fact cards only use free images - https://phabricator.wikimedia.org/T95379#1188236 (10Nemo_bis) [17:01:53] i think ono/vodafone is fucking with my internet for not accepting their expensive new decoder/router [17:02:27] bath time with the boys [17:02:38] back in time for the gather walkthrough [17:03:54] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Share A Fact images should include license or attribution info about the image - https://phabricator.wikimedia.org/T91811#1231647 (10Nemo_bis) [17:04:11] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10MediaWiki-extensions-PageImages: Add support to PageImages for finding a freely licensed page image - https://phabricator.wikimedia.org/T95378#1231648 (10Deskana) p:5Triage>3Normal [17:06:26] bmansurov: sorry :( I forgot [17:06:37] so let's chat - what trouble are you running into? [17:06:53] milimetric: np, the graph won't load on my local install [17:07:03] 6Mobile-Web: Find another/a better place for secondary actions - https://phabricator.wikimedia.org/T97048#1231656 (10Florian) 3NEW [17:07:08] milimetric: i've double checked the source csv files, they are all present [17:07:13] (03CR) 10Florianschmidtwelzow: "> As soon as buttons spill on to a second line this looks unprofessional" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206130 (https://phabricator.wikimedia.org/T24660) (owner: 10Florianschmidtwelzow) [17:07:57] milimetric: it's not urgent as the bug I was reviewing has been merged [17:08:11] milimetric: I'll bother you the next time I use limn ;) [17:08:57] bmansurov: that error is like a "catch-all", but does your graph have the magical version string? [17:09:20] milimetric: how can I check? [17:09:40] do you have it handy? I'll get it working and send it back [17:10:13] 6Mobile-Web, 10MobileFrontend, 7Wikimedia-log-errors: Empty delimiter in SkinMinerva - https://phabricator.wikimedia.org/T97050#1231671 (10demon) 3NEW [17:10:24] milimetric: the csv file? [17:10:32] bmansurov: no the json file [17:10:36] milimetric: yes [17:10:39] milimetric: 1sec [17:12:01] milimetric: you're asking for the reportcard.json right? [17:12:42] are you making graphs by putting the CSV url in the reportcard.json, or are you making custom json graphs? [17:13:43] milimetric: i'm just trying to get the existing graphs to show [17:13:54] bmansurov: right, but there's two ways to make a graph [17:14:03] one is to put the CSV url in the reportcard.json directly [17:14:18] the second is to put a graph id in the reportcard.json and to implement your own datasource and graph [17:14:35] 6Mobile-Web, 10MobileFrontend, 7Wikimedia-log-errors: Empty delimiter in SkinMinerva - https://phabricator.wikimedia.org/T97050#1231690 (10Florian) a:3Florian Caused by I43cf5dc37f98cae30982945901a7cb6dbe618cab [17:14:35] milimetric: i'm using the CSV urls [17:14:51] bmansurov: oh! are you saying you're just using the limn-mobile-data repository as is? [17:14:58] milimetric: yes [17:15:01] ugh, sorry!! [17:15:10] * milimetric tazers his brain [17:15:24] (03CR) 10Jdlrobson: [C: 04-1] "pending bug discussion" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206130 (https://phabricator.wikimedia.org/T24660) (owner: 10Florianschmidtwelzow) [17:15:33] milimetric: i've emailed you the json in case you need it [17:19:15] bmansurov: ok, so I pulled latest on limn-mobile-data and ran "coke --vardir ./var --data /home/dan/projects/f-limn/limn-mobile-data/ --to mobile link_data" in my limn directory and the graphs show up [17:20:19] in the bug you mentioned you were going to /graphs/sample_graph/edit [17:20:26] are you trying to navigate to each graph individually? [17:20:36] milimetric: i see, ok then I must have done something wrong [17:20:50] vibha: hey! i can get you and Elena an apk so you can get started on testing, but will you be testing on an emulator or physical device? [17:20:56] milimetric: no, I'm just trying to load the other tab to see the mobile graphs [17:21:42] bmansurov: you wanna do a quick hangout? [17:22:04] milimetric: sure [17:22:23] (03PS1) 10Florianschmidtwelzow: Don't pass empty message text to strpos [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206148 (https://phabricator.wikimedia.org/T97050) [17:23:30] jdlrobson: can you quickly cherrypick https://gerrit.wikimedia.org/r/#/c/205440/ on top of master? i'm not sure how to do it myself. It seems like includes/views/Collection.php has a getModerationButtons that is not present in HEAD, but it isn't called anywhere [17:23:50] i'm not sure if I should remove it [17:28:00] joakino: that should be removed [17:28:33] joakino: i removed the getModerationButtons yesterday. Are you doing a rebase ? [17:28:55] rmoen: yurp, trying to get that patch on top of master [17:29:14] because the flag button is already merged so the patch is in a very weird state [17:30:38] Hi Deskana, when can we publish the next prod release? [17:31:17] omg internet [17:31:23] rmoen: i don't know if you said anything else, i dropped off [17:31:55] joakino_: oh ;/ Just was saying to remove the call the the method. And the method should no longer exist. And you should be fine [17:32:09] rmoen: ok! [17:32:22] joakino_: jdlrobson: Gather-codebase hangout? [17:32:36] phuedx|AFK: coming [17:37:28] (03PS2) 10Jhernandez: Show hide button on collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205440 (https://phabricator.wikimedia.org/T94228) (owner: 10Jdlrobson) [17:46:57] rmoen: how do I see the flag button? [17:47:56] joakino_: view another users collection / not watchlist / in minerva [17:48:10] rmoen: with admin i guess [17:48:23] joakino_: no admin needed [17:48:25] can be anon [17:49:13] joakino_: let me know if you want me to take a stab at the rebase [17:50:12] rmoen: can't see it with this patch https://gerrit.wikimedia.org/r/205440 [17:50:19] i'm investigating [17:53:43] bearND: What would be planned to go out? [17:54:00] bearND: Nothing particularly significant in terms of features, right? [17:54:09] bearND: If that's the case, you can go for it whenever you like. [17:56:09] joakino_: are you lookng on beta labs? [17:56:37] jdlrobson: nope, locally, if you mean the flag button [17:56:42] ok. [17:56:48] (03CR) 10Phuedx: [C: 031] "Ping @Jdlrobson." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206134 (https://phabricator.wikimedia.org/T96634) (owner: 10Florianschmidtwelzow) [17:56:49] just wondered cos beta labs had some issues [17:56:53] pong phuedx [17:57:15] jdlrobson: nice small change from florian [17:57:18] phuedx: sweet [17:57:22] just want to make sure that's what you wanted [17:57:23] phuedx: did you see my comment about tags [17:57:26] not obvious how to get them up and running [17:58:09] hrrm -- i can do a little readme [17:58:21] JonKatz: got a sec? [17:58:33] (03CR) 10Jdlrobson: [C: 032] Change default value of anonymousEditing to true [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206134 (https://phabricator.wikimedia.org/T96634) (owner: 10Florianschmidtwelzow) [17:58:36] i'm heading out for a while now, but i'll attack notes this evening [17:59:02] i've finally got coffee beans in the house again [17:59:15] and i've drunk 4 cups of coffee today -- just because of the novelty i guess [17:59:21] now i'm /really/ pooped [17:59:59] alright, heading out [18:00:02] i'll be idling later [18:00:02] WOOO [18:00:04] (03Merged) 10jenkins-bot: Change default value of anonymousEditing to true [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206134 (https://phabricator.wikimedia.org/T96634) (owner: 10Florianschmidtwelzow) [18:00:10] phuedx: i had coffee woes this morning [18:00:17] calcium build up in the old espresso machine [18:00:20] thanks again for the overview jdlrobson, joakino_, rmoen [18:00:23] OH NOES [18:00:32] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: $wgMFEditorOptions should be updated to reflect production - https://phabricator.wikimedia.org/T96634#1231874 (10phuedx) [18:00:39] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: $wgMFEditorOptions should be updated to reflect production - https://phabricator.wikimedia.org/T96634#1231875 (10phuedx) 5Open>3Resolved [18:01:18] jdlrobson: have you cleaned it out? [18:01:27] vaterfuk [18:02:18] dr0ptp4kt sure, whatsup? [18:03:01] JonKatz: was about to ask kristenlans to have jeff and gergo added to web meetings, especially standup, and you to any app meetings you're not already on. ok? [18:03:21] yup! [18:03:30] dr0ptp4kt^ [18:03:30] phuedx: i back flushed it a lot [18:03:37] and it kicked it back into life [18:03:37] (03CR) 10Krinkle: Simplify TOC replacement on desktop Minerva (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204454 (https://phabricator.wikimedia.org/T89223) (owner: 10Jdlrobson) [18:03:39] JonKatz: thx [18:03:41] i have ordered decalcifier though [18:03:46] yeah [18:03:52] then run it /a lot/ [18:03:55] thank you! dr0ptp4kt [18:04:03] to get rid of any declacifying agent [18:04:09] alright [18:04:13] i really am going [18:04:19] (being poked physically) [18:04:26] bye all! [18:04:29] ttylllllls [18:05:53] joakino_: https://gerrit.wikimedia.org/r/#/c/206068/ !!!!! [18:06:06] if i fix up the jscs issues will you merge my Gather patch that i am currently writing [18:06:41] jdlrobson: sure [18:08:07] (03PS1) 10Jdlrobson: Hygiene: Fix jscs issues in Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206154 [18:08:27] ^ joakino_ [18:08:40] is http://en.wikipedia.beta.wmflabs.org down? [18:09:10] 10Gather, 3Gather Sprint Forward, 10Continuous-Integration, 5Patch-For-Review: Gather should be using its own Gruntfile in Jenkins - https://phabricator.wikimedia.org/T92589#1231886 (10Jdlrobson) [18:09:53] (03CR) 10Jhernandez: [C: 032] Hygiene: Fix jscs issues in Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206154 (owner: 10Jdlrobson) [18:11:04] 10Gather, 3Gather Sprint Forward, 10MediaWiki-Vagrant: Create vagrant Gather role - https://phabricator.wikimedia.org/T90814#1231905 (10Jdlrobson) a:3Jdlrobson [18:11:29] 10Gather, 3Gather Sprint Forward: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1231906 (10Jdlrobson) [18:11:36] (03Merged) 10jenkins-bot: Hygiene: Fix jscs issues in Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206154 (owner: 10Jdlrobson) [18:12:06] jdlrobson: greg-g: Could we possibly get a deployment window to update Gather today? [18:13:07] 10Gather: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1231916 (10Jdlrobson) 3NEW a:3Yurik [18:13:13] 10Gather: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1231924 (10Jdlrobson) @Yurik any ideas? [18:13:26] 10Gather: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1231927 (10Jdlrobson) [18:13:28] 10Gather, 3Gather Sprint Forward, 10Gather Sprint G, 3Mobile-Web-Design: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1231926 (10Jdlrobson) [18:14:17] 10Gather, 3Gather Sprint Forward, 3Mobile-Web-Design, 5Patch-For-Review: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1231930 (10Jhernandez) Patch is borked. I don't know what happened with the dependency but it doesn't make sense now. I've tried to rebase it with head (PS2).... [18:14:28] 10Gather, 3Gather Sprint Forward, 10MediaWiki-Vagrant: Create vagrant Gather role - https://phabricator.wikimedia.org/T90814#1231935 (10Jdlrobson) Copying https://gerrit.wikimedia.org/r/#/c/63443/ should help here [18:16:00] (03PS2) 10Krinkle: Hygiene: Kill dead css on diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206007 (owner: 10Jdlrobson) [18:16:37] (03CR) 10Jdlrobson: [C: 032] Always point to collections menu item when creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205625 (https://phabricator.wikimedia.org/T95976) (owner: 10Jhernandez) [18:16:40] (03CR) 10jenkins-bot: [V: 04-1] Always point to collections menu item when creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205625 (https://phabricator.wikimedia.org/T95976) (owner: 10Jhernandez) [18:16:43] joakino_: want me to try to rebase ? [18:17:28] rmoen: i think it is just that the parent patch changed too much and this one doesn't quite make sense as it is now. [18:17:41] joakino_: yeah [18:18:00] hmm well [18:18:32] btw rmoen can't see any flag button, and the .collection-moderation div is before the header on my local instance. I wanted to verify on beta labs but it is borked and breaking on me so I cant [18:19:03] i'd really like to know if it is my problem 😫' [18:19:19] hmmm yeah i'm not sure what is up with beta labs. I think jdlrobson might know why things are not working there. [18:21:00] (03PS6) 10Krinkle: Save changes to members of collection only when done clicked [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204659 (https://phabricator.wikimedia.org/T95776) (owner: 10Jdlrobson) [18:21:10] rmoen: seems to kind of work now, very slow. See http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/by/Diablanco/7?mobileaction=beta [18:21:48] hrm no collection-moderation [18:21:50] div [18:21:58] furk it is too late here [18:22:00] (03CR) 10Bmansurov: [C: 032] Hygiene: Kill dead css on diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206007 (owner: 10Jdlrobson) [18:22:05] i give up for today [18:22:18] Deskana: Ideally, I'd like to publish a beta today, then follow it up with a prod release next week. [18:22:26] joakino_: there is a js error on the page related to EventLogging [18:22:33] joakino_: [ImageMetricsCorsSupport] Missing or empty schema [18:22:34] bearND: Sure, sounds good. Going to build both at the same time again? [18:22:47] Deskana: yes [18:22:52] \o/ [18:23:05] rmoen: i'm calling it for the day [18:23:13] joakino_: ok [18:23:29] All good [18:23:34] bb have a nice day! [18:23:37] (03Merged) 10jenkins-bot: Hygiene: Kill dead css on diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206007 (owner: 10Jdlrobson) [18:23:39] Deskana: No new big features, mainly a ton of bug fixes, and some minor UX changes. incl. your account creation improvement [18:23:59] bearND: Right. Sounds excellent [18:24:29] Deskana: so, we can publish prod next week anytime? [18:24:47] (03CR) 10Bmansurov: [C: 032] Don't pass empty message text to strpos [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206148 (https://phabricator.wikimedia.org/T97050) (owner: 10Florianschmidtwelzow) [18:25:20] vibha: you there? [18:25:23] bearND: Sure. I'd prefer that you pick a specific date/time though, and stick to that. [18:25:31] bearND: Or push back as necessary. [18:25:37] bearND: That way I can put a card in the Roadmap project. [18:25:43] * Deskana makes that card now [18:26:28] (03Merged) 10jenkins-bot: Don't pass empty message text to strpos [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206148 (https://phabricator.wikimedia.org/T97050) (owner: 10Florianschmidtwelzow) [18:26:31] Deskana: Ok, I propose 4/29 [18:26:55] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 3Roadmap, 7notice: Production release for the Android Wikipedia app on 29th April 2015 - https://phabricator.wikimedia.org/T97064#1231975 (10Deskana) 3NEW [18:27:06] Deskana: Thanks! [18:27:30] bearND: Can you add the overview of the release to the card? [18:27:41] bearND: It only needs to be three or four bullet points of the biggest changes [18:28:05] Deskana: mholloway: Sure. Will do that and the builds right after lunch. [18:28:20] bearND, mholloway: Thank you, gentlemen! [18:28:31] Thank you, sir! [18:29:04] (03PS4) 10Deskana: Hygiene: Add documentation to namespace field in PageTitle class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206037 (https://phabricator.wikimedia.org/T96939) [18:29:55] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 3Roadmap, 7notice: Production release for the Android Wikipedia app on 29th April 2015 - https://phabricator.wikimedia.org/T97064#1231987 (10Deskana) [18:32:43] Adam - yea. What's up? [18:33:57] (03PS1) 10Mhurd: Re-added delete all trash can to saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206158 [18:37:37] rmoen: so i think kaldari is away today.. [18:37:39] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1232006 (10Vibhabamba) Is this in the latest alpha? [18:38:00] you might need to find someone else to support you through deployment [18:38:06] jdlrobson: No word from greg-g yet. [18:38:42] I emailed, pm'd, and pinged here. [18:39:06] bearND|away: hey, regarding this https://phabricator.wikimedia.org/T96886, should i get added to releasers-mediawiki or releasers-mobile? [18:40:13] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1232011 (10Mholloway) It should be! [18:40:24] how do you mention someone if they are not online in this tool? [18:40:31] the names don't autocomplete [18:41:16] (03PS3) 10Jdlrobson: Always point to collections menu item when creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205625 (https://phabricator.wikimedia.org/T95976) (owner: 10Jhernandez) [18:41:22] (03CR) 10Jdlrobson: [C: 032] Always point to collections menu item when creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205625 (https://phabricator.wikimedia.org/T95976) (owner: 10Jhernandez) [18:41:56] vibha: I don't think you can do that here as you might in, say, Phabricator. Who are you trying to get a hold of? [18:42:21] vibha: Adam? [18:42:55] (03PS2) 10Mhurd: Re-added delete all trash can to saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206158 [18:43:06] (03Merged) 10jenkins-bot: Always point to collections menu item when creating a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205625 (https://phabricator.wikimedia.org/T95976) (owner: 10Jhernandez) [18:43:58] (03PS6) 10Jdlrobson: Deleting collection: hide dialog when finished, toast on refresh [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) (owner: 10Jhernandez) [18:44:04] I was trying to get a hold of adam and his irc name is a bit difficult to remember [18:44:16] anywaz [18:44:33] (03CR) 10Jdlrobson: [C: 032] "MobileFrontend uses this in some places. Would be great to have this be a method on toast itself. e.g. showLater() method as well as show(" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) (owner: 10Jhernandez) [18:44:37] vibha: dr0ptp4kt [18:44:59] vibha: (He left IRC 15 minutes ago, sorry.) [18:45:38] vibha: i let adam know [18:45:42] 10Gather, 6Mobile-Web: Add support for future toasts - https://phabricator.wikimedia.org/T97067#1232036 (10Jdlrobson) 3NEW [18:45:57] vibha: Did that apk I sent you install OK? I think it should work, but let me know if you run into any problems. I want to give you & Elena plenty of time to test before end of sprint. [18:46:12] (03Merged) 10jenkins-bot: Deleting collection: hide dialog when finished, toast on refresh [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205836 (https://phabricator.wikimedia.org/T96294) (owner: 10Jhernandez) [18:46:37] vibha: (If you can call midday on thursday "plenty of time"...) [18:46:42] dr0ptp4kt: can you review https://gerrit.wikimedia.org/r/#/c/206158/ when you have a chance? [18:46:50] (03PS2) 10Jdlrobson: DONOTMERGE: Follow up [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205962 [18:46:54] (03Abandoned) 10Jdlrobson: DONOTMERGE: Follow up [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205962 (owner: 10Jdlrobson) [18:47:17] (03PS3) 10Jdlrobson: Design: Improve spacing of content overlay on phones [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205834 (https://phabricator.wikimedia.org/T95628) (owner: 10Jhernandez) [18:47:23] (03CR) 10Jdlrobson: [C: 032] Design: Improve spacing of content overlay on phones [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205834 (https://phabricator.wikimedia.org/T95628) (owner: 10Jhernandez) [18:47:50] vibha: hey that patch i just tagged adam on ( https://gerrit.wikimedia.org/r/#/c/206158/ ) brings back the saved pages trash icon ( an app store review had complained iirc ) and makes the initial saved pages alert go away after 5 seconds [18:49:51] (03Merged) 10jenkins-bot: Design: Improve spacing of content overlay on phones [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205834 (https://phabricator.wikimedia.org/T95628) (owner: 10Jhernandez) [18:52:05] vibha: you were looking for me? [18:52:19] vibha: i was just looking for volker's email address [18:56:43] jdlrobson: bah.. investigating the issue on beta labs with ImageMetrics but cannot reproduce locally. Are you seeing error related to ImageMetricsCorsSupport schema also ? [18:56:54] ImageMetrics? [18:57:00] extension [18:57:07] i've not heard of that extension [18:57:09] (03CR) 10Dr0ptp4kt: [C: 032] Re-added delete all trash can to saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206158 (owner: 10Mhurd) [18:57:11] why is that impacting Gather? [18:57:18] Same. js error on the page [18:57:23] stops other js from running [18:57:23] mhurd: lgtm, +2'd [18:57:25] rmoen: is there a bug open for the beta labs issue? [18:57:36] jdlrobson: not sure just discovered it [18:57:40] rmoen: note beta labs is also not up to date [18:57:53] jdlrobson: huh ? why is that [18:58:03] jdlrobson: perhaps why i cannot reproduce locally [18:58:04] dr0ptp4kt: sent it just now to you and toby [18:58:58] https://phabricator.wikimedia.org/T96920 < rmoen [19:00:05] (03CR) 10Jdlrobson: "Some comments. Haven't tested yet." (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [19:02:08] dr0ptp4kt: you may need to V2 that patch [19:02:08] 3Gather Sprint Forward, 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1232110 (10Jdlrobson) [19:02:46] 3Gather Sprint Forward, 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1156443 (10Jdlrobson) @hashar remaining 2 test failures are due to T96920 and the required fron... [19:03:01] (03CR) 10Dr0ptp4kt: [V: 032] Re-added delete all trash can to saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206158 (owner: 10Mhurd) [19:03:07] dr0ptp4kt: yay~ [19:03:09] mhurd: done. in meeting now [19:03:11] yay! [19:03:16] dr0ptp4kt: thanks! [19:04:00] 10Gather: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1232118 (10Yurik) This might be problematic perf wise. We should store the number of items in the list as a separate field in the database, and update it every time an item is added or removed. This could create discrepancie... [19:06:39] (03CR) 10Jdlrobson: Switch URL used for a collection (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205868 (https://phabricator.wikimedia.org/T94527) (owner: 10Jdlrobson) [19:08:39] jdlrobson: should I take this hide button patch ? https://gerrit.wikimedia.org/r/#/c/205440/ ? [19:11:04] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1232150 (10rmoen) All setup to add the namespaced message on en.wiki moving this to ready for signoff. see https://phabricator.wikimedia.org/T96805 [19:13:24] mholloway: large in page images look great. [19:13:43] I am definitely seeing some bugs on science and math articles [19:13:55] vibha: excellent, thanks! [19:14:07] vibha: ah, i didn't test those specifically but probably should have [19:14:25] basically a lot of small images which dont have high res versions are looking super stretched [19:14:32] vibha: do you have some specific articles i can use for testing? [19:15:05] vibha: yeah, will have to account for that better. are they at least scaled proportionally or just stretched lengthwise? [19:19:04] 3Gather Sprint Forward: Update in WikimediaMessages extension for enwiki - https://phabricator.wikimedia.org/T96805#1232182 (10rmoen) As discussed in the standup today. Creating the page https://en.wikipedia.org/wiki/MediaWiki:Gather-lists-hide-protocol should be sufficient for this as I don't think we should p... [19:21:22] 10Gather, 3Gather Sprint Forward: Phone screen improvements on Adding to collection modal - https://phabricator.wikimedia.org/T96837#1232186 (10rmoen) a:3rmoen [19:23:24] mholloway: they looked scaled proportionately [19:23:40] (03PS2) 10Jdlrobson: Switch URL used for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205868 (https://phabricator.wikimedia.org/T94527) [19:23:49] vibha: ok, that's good. how should we treat small images? just leave them as is? [19:25:19] leave them as is, if a high res version isn't available - don't stretch the image [19:25:47] vibha: cool. [19:26:06] vibha: thanks for taking a look. [19:26:06] also too much white-space between bottom image edge and caption [19:26:25] (03PS3) 10Jdlrobson: Switch URL used for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205868 (https://phabricator.wikimedia.org/T94527) [19:26:39] vibha: hmm, yeah, i noticed that, too. will address that as well. [19:28:50] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add a flag button - https://phabricator.wikimedia.org/T94871#1174892 (10Jdlrobson) This doesn't seem to be working. [19:31:14] mholloway: look at the 'Pressure' article [19:31:26] 3Gather Sprint Forward: Visiting a collection triggers an API request on every page load - https://phabricator.wikimedia.org/T97076#1232221 (10Jdlrobson) 3NEW [19:31:35] 3Gather Sprint Forward: Visiting a collection triggers an API request on every page load - https://phabricator.wikimedia.org/T97076#1232229 (10Jdlrobson) a:3Jdlrobson [19:31:45] 3Gather Sprint Forward: Visiting a collection triggers an API request on every page load - https://phabricator.wikimedia.org/T97076#1232221 (10Jdlrobson) [19:31:53] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add a flag button - https://phabricator.wikimedia.org/T94871#1174892 (10Jdlrobson) I have found the culprit.. [19:32:24] 10Gather, 3Gather Sprint Forward, 10MediaWiki-Vagrant: Create vagrant Gather role - https://phabricator.wikimedia.org/T90814#1232236 (10Jdlrobson) a:5Jdlrobson>3None [19:35:15] vibha: hmm, yes, i see what you mean. [19:41:09] 3Gather Sprint Forward: Visiting a collection triggers an API request on every page load - https://phabricator.wikimedia.org/T97076#1232241 (10Jdlrobson) p:5Triage>3High [19:41:45] (03PS1) 10Jdlrobson: Fix flag button, stop unnecessary API request [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206168 (https://phabricator.wikimedia.org/T97076) [19:44:27] (03CR) 10jenkins-bot: [V: 04-1] Fix flag button, stop unnecessary API request [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206168 (https://phabricator.wikimedia.org/T97076) (owner: 10Jdlrobson) [20:00:04] (03PS2) 10Jdlrobson: Fix flag button, stop unnecessary API request [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206168 (https://phabricator.wikimedia.org/T97076) [20:03:04] 10Wikipedia-Android-App: Only use public domain images for the Share A Fact feature - https://phabricator.wikimedia.org/T95092#1232255 (10MGChecker) Here you can see the judical decision: [http://bilderklau.lucan.de/blog/wp-content/uploads/2012/04/LG-M%C3%BCnchen-I-37-O-9798-11-Endurteil.pdf] [20:03:40] mholloway: Do you think your change for tweaking image size will get in to this beta? [20:04:47] Deskana: This is for 4/29? Next Wednesday? [20:05:05] mholloway: Well, the beta is going out soon, right? In a few hours? [20:05:23] mholloway: It's okay if it's not ready, I was just curious. [20:05:46] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: iOS app: Should have a "clear all" button for browsing history - https://phabricator.wikimedia.org/T65970#1232260 (10Mhurd) [20:06:40] Deskana: Ah, I thought we had a beta coming out today but then misinterpreted something from your convo with bearND|away earlier [20:06:53] Deskana: Yeah, I don't think it'll make it into this one. [20:08:45] mholloway: Excellent. [20:08:45] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: iOS app: Should have a "clear all" button for browsing history - https://phabricator.wikimedia.org/T65970#1232267 (10Mhurd) 5Open>3Resolved a:3Mhurd Recent has a trash can for clearing all recent items. [20:09:54] 10Wikipedia-iOS-App: iOS app: Should have a "clear all" button for browsing history - https://phabricator.wikimedia.org/T65970#1232271 (10Mhurd) [20:12:59] 6Mobile-Web: Icons don't behave like Views - https://phabricator.wikimedia.org/T97077#1232273 (10Jdlrobson) 3NEW [20:13:14] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: The introduction for 'Save Pages' does not go away even if you switch articles. - https://phabricator.wikimedia.org/T96606#1232281 (10Mhurd) a:5Deskana>3Mhurd [20:14:20] 6Mobile-Web: Empty delimiter warning being generated by SkinMinerva.php - https://phabricator.wikimedia.org/T96945#1232289 (10Jdlrobson) [20:14:22] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review, 7Wikimedia-log-errors: Empty delimiter in SkinMinerva - https://phabricator.wikimedia.org/T97050#1231671 (10Jdlrobson) [20:17:14] (03PS3) 10Jdlrobson: Show hide button on collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205440 (https://phabricator.wikimedia.org/T94228) [20:17:20] 10Wikipedia-Android-App: Only use public domain images for the Share A Fact feature - https://phabricator.wikimedia.org/T95092#1232296 (10Deskana) 5Open>3stalled Legal blockers obviously supersede almost all other kinds of issues, including product decisions. That said, only #WMF-Legal gets to decide what is... [20:17:50] 10Gather, 3Gather Sprint Forward, 10MediaWiki-Vagrant: Create vagrant Gather role - https://phabricator.wikimedia.org/T90814#1232303 (10Jdlrobson) a:3Jdlrobson [20:19:25] 10Gather, 3Mobile-Web-Design: Desktop beta feature for Gather needs illustration - https://phabricator.wikimedia.org/T95632#1232306 (10MNguyen) @jdlrobson attaching the illustration here. Hope this works! :) {F155197} [20:20:29] (03CR) 10jenkins-bot: [V: 04-1] Show hide button on collection itself [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205440 (https://phabricator.wikimedia.org/T94228) (owner: 10Jdlrobson) [20:20:51] MaxSem, jdlrobson, phuedx|AFK i think we should cherry pick https://gerrit.wikimedia.org/r/#/c/206148/ to wmf2 and wmf3 and plan a swat for it. Can one of you be the contact person for the evening swat today? :] [20:22:09] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: 4.1.0.2 - some symbols displayed as empty squares - https://phabricator.wikimedia.org/T97078#1232309 (10Etonkovidova) 3NEW [20:29:22] (03PS1) 10Bmansurov: Hygiene: Use View events in SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206181 (https://phabricator.wikimedia.org/T96619) [20:29:37] 6Mobile-Web, 5Patch-For-Review: SearchOverlay should use View##events - https://phabricator.wikimedia.org/T96619#1232326 (10bmansurov) a:3bmansurov [20:30:13] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.0.6.3 Expanding Quick facts box and flipping to horizontal position - the empty space for leading image is preserved. - https://phabricator.wikimedia.org/T91118#1232327 (10Mhurd) This was just a bug fix, so moving directly to "ready for sign-off". [20:30:31] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1232328 (10Vibhabamba) Reviewed. Its 98% there. Mholloway - one las... [20:31:06] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: {{main}} template not showing in articles - https://phabricator.wikimedia.org/T96228#1232330 (10Mhurd) This was just a bug fix, so moving directly to "ready for sign-off". [20:32:09] 10Wikipedia-Android-App, 6WMF-Legal: Only use public domain images for the Share A Fact feature - https://phabricator.wikimedia.org/T95092#1232334 (10MGChecker) [20:35:16] 6Mobile-Web, 10WikiGrok, 5Patch-For-Review: Panel shouldn't automatically get added to the DOM - https://phabricator.wikimedia.org/T96176#1232342 (10bmansurov) 5Open>3Resolved a:3bmansurov [20:35:18] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1232344 (10bmansurov) [20:35:52] bearND|away: hey when u get back could you do a twn push for the iOS app strings? we have a couple new ones... [20:36:17] dr0ptp4kt: ^ [20:36:23] 10Gather, 3Mobile-Web-Design: Desktop beta feature for Gather needs illustration - https://phabricator.wikimedia.org/T95632#1232356 (10MNguyen) Also: an RTL version for other languages: {F155217} [20:39:35] mhurd: sure. I was going to do one anyways [20:39:54] bearND: awesome! thanks! [20:40:59] bearND: i think we're going to try to cut a beta build tomorrow... if by chance any translations come through we may ask to pull those in tomorrow [20:43:32] (03CR) 10BearND: [C: 032] Hygiene: Add documentation to namespace field in PageTitle class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206037 (https://phabricator.wikimedia.org/T96939) (owner: 10Deskana) [20:43:34] (03CR) 10Jdlrobson: [C: 032] Hygiene: Use View events in SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206181 (https://phabricator.wikimedia.org/T96619) (owner: 10Bmansurov) [20:44:05] (03Merged) 10jenkins-bot: Hygiene: Add documentation to namespace field in PageTitle class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206037 (https://phabricator.wikimedia.org/T96939) (owner: 10Deskana) [20:44:13] (03CR) 10Robmoen: [C: 04-1] Fix flag button, stop unnecessary API request (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206168 (https://phabricator.wikimedia.org/T97076) (owner: 10Jdlrobson) [20:44:40] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review, 7Wikimedia-log-errors: Empty delimiter in SkinMinerva - https://phabricator.wikimedia.org/T97050#1232387 (10Florian) @MaxSem, @kaldari, @phuedx Can we backport this to 1.26wmf2&wmf3? :) [20:45:10] (03Merged) 10jenkins-bot: Hygiene: Use View events in SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206181 (https://phabricator.wikimedia.org/T96619) (owner: 10Bmansurov) [20:46:34] hmm, kaldari and phuedx aren't here - who can take care of Florian's patch? jdlrobson, rmoen? [20:46:58] FlorianSW, also note I'm not on mobile team anymore:) [20:46:59] (03CR) 10BearND: [C: 04-1] Hygiene: miscellaneous code quality fixes (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206071 (owner: 10Deskana) [20:47:02] 6Mobile-Web, 5Patch-For-Review: SearchOverlay should use View##events - https://phabricator.wikimedia.org/T96619#1232404 (10bmansurov) 5Open>3Resolved [20:47:38] MaxSem: :O Oha, ok, can i ask in which team you're working now? :) [20:47:53] search & discovery [20:48:08] ah, cool, bad for us, but cool :) [20:50:06] (03CR) 10Jdlrobson: [C: 04-1] "* Message for watchlist changes." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) (owner: 10Kaldari) [20:50:20] FlorianSW, MaxSem: what is the patch? Schedule it? https://wikitech.wikimedia.org/wiki/Deployments [20:50:21] (03PS3) 10Deskana: Hygiene: miscellaneous code quality fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206071 [20:50:52] (03CR) 10Jdlrobson: Rewrite mobile login page to be less hacky and closer to core version (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) (owner: 10Kaldari) [20:51:26] rmoen: Fixing a php warning in production: https://gerrit.wikimedia.org/r/#/c/206148/ not yet sheduled, i can't be a contact person for this patch for the todays evening patch, so i hope, that someone else can be :) [20:52:17] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Document how the namespace field works in PageTitle class - https://phabricator.wikimedia.org/T96939#1232459 (10Deskana) 5Open>3Resolved [20:53:15] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: NPE from page.PageActivity$3.run when trying to call page.PageViewFragmentInternal.getTitle - https://phabricator.wikimedia.org/T96532#1232462 (10Deskana) 5Open>3Resolved [20:53:22] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: NPE crash from page.ToCHandler$2.onDrawerOpened when opening the left hamburger (TOC) before page is loaded - https://phabricator.wikimedia.org/T96358#1232464 (10Deskana) 5Open>3Resolved [20:54:28] (03CR) 10Jdlrobson: [C: 031] "Looks good but dependency must be merged first." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205473 (owner: 10Kaldari) [20:54:31] (03PS3) 10BearND: Fix Script Interpreters and Clean Up [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205071 (owner: 10Niedzielski) [20:54:37] (03CR) 10BearND: [C: 032] Fix Script Interpreters and Clean Up [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205071 (owner: 10Niedzielski) [20:55:01] (03PS3) 10Jdlrobson: Making the Gather login and signup messages work in standard way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205473 (https://phabricator.wikimedia.org/T95729) (owner: 10Kaldari) [20:55:28] 3Gather Sprint Forward, 5Patch-For-Review: string replacement for watchstar login page - https://phabricator.wikimedia.org/T95729#1232469 (10Jdlrobson) a:5Jdlrobson>3kaldari [20:56:35] (03CR) 10jenkins-bot: [V: 04-1] Making the Gather login and signup messages work in standard way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205473 (https://phabricator.wikimedia.org/T95729) (owner: 10Kaldari) [20:57:16] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 3Mobile-Web-Design, 5Patch-For-Review: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1232477 (10bmansurov) @JKatzWMF, @phuedx we can create a patch in Mediawiki-Config and populate the $wgMFBrowseTags variable with the list... [20:57:16] (03Merged) 10jenkins-bot: Fix Script Interpreters and Clean Up [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205071 (owner: 10Niedzielski) [20:57:38] FlorianSW: I can schedule it, be contact person and also deploy it. :) [20:58:04] (03PS1) 10Robmoen: Prevent multiple clicks to flag and detach from dom on confirmation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206191 [20:58:18] rmoen: That sounds good, let me cherry pick the chane. If you want, i can plan it, too? :) [20:58:39] FlorianSW: sure that would be awesome. just put my irc handle in the schedule [20:58:39] (03PS1) 10Florianschmidtwelzow: Don't pass empty message text to strpos [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/206193 (https://phabricator.wikimedia.org/T97050) [20:58:48] (03PS1) 10Florianschmidtwelzow: Don't pass empty message text to strpos [extensions/MobileFrontend] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/206194 (https://phabricator.wikimedia.org/T97050) [21:01:09] (03CR) 10BearND: [C: 04-1] "I'd prefer to follow Wiki convention to not title case subsequent words unless they are proper names. See https://en.wikipedia.org/wiki/Wi" (0310 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski) [21:01:33] rmoen: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=155385 thanks :) [21:02:56] FlorianSW: np [21:05:17] (03PS4) 10BearND: Hygiene: miscellaneous code quality fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206071 (owner: 10Deskana) [21:05:21] (03CR) 10BearND: [C: 032] Hygiene: miscellaneous code quality fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206071 (owner: 10Deskana) [21:05:23] bearND: hey, did you get my message about https://phabricator.wikimedia.org/T96886? [21:06:35] mholloway: which message? I see access has been approved [21:07:15] bearND: yeah, RobH just wanted to know whether to add me to releasers-mediawiki or releasers-mobile and I'm not sure what to tell him [21:07:37] (03Merged) 10jenkins-bot: Hygiene: miscellaneous code quality fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206071 (owner: 10Deskana) [21:08:23] mholloway: hmmm, good question. I'm not sure. That's ops speak I'm not so familiar with. [21:08:46] bearND: looks like he went with releasers-mediawiki on the patch [21:09:12] mholloway: I think releasers-mobile is needed for uploading apks to caesium [21:09:27] but I'd have to look at the puppet config [21:10:30] (03CR) 10Robmoen: [C: 04-1] Show hide button on collection itself (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205440 (https://phabricator.wikimedia.org/T94228) (owner: 10Jdlrobson) [21:11:17] mholloway: I'm going to respond. I think you should be on the other line (releasers-mobile), like dbrant and myself [21:11:30] bearND: ok, cool [21:14:50] (03PS4) 10Robmoen: Switch URL used for a collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205868 (https://phabricator.wikimedia.org/T94527) (owner: 10Jdlrobson) [21:16:05] mholloway: Are you up to address vibha's comments for prototype 1 in https://phabricator.wikimedia.org/T96068 [21:16:13] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Provide infastructure for Gather desktop beta feature - https://phabricator.wikimedia.org/T97084#1232569 (10Jdlrobson) 3NEW a:3Jdlrobson [21:16:50] (03PS8) 10Jdlrobson: Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) [21:16:52] (03PS3) 10Jdlrobson: Reflect some upstream changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203229 [21:16:56] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Provide infrastructure for Gather desktop beta feature - https://phabricator.wikimedia.org/T97084#1232578 (10Jdlrobson) [21:17:15] 10Gather, 3Mobile-Web-Design: Desktop beta feature for Gather needs illustration - https://phabricator.wikimedia.org/T95632#1232583 (10Jdlrobson) 5Open>3Resolved perfect! Thanks @MNguyen [21:17:17] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Expose Gather as desktop beta feature - https://phabricator.wikimedia.org/T95227#1232585 (10Jdlrobson) [21:17:28] 10Gather: Expose Gather as desktop beta feature - https://phabricator.wikimedia.org/T95227#1183633 (10Jdlrobson) [21:17:39] bearND: Sure, I could do that [21:18:24] 10Gather, 5Patch-For-Review: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1232589 (10Jdlrobson) [21:18:26] 10Gather: Expose Gather as desktop beta feature - https://phabricator.wikimedia.org/T95227#1183633 (10Jdlrobson) [21:18:51] (03CR) 10jenkins-bot: [V: 04-1] Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) (owner: 10Jdlrobson) [21:19:41] bearND: Mind if I assign it to myself? [21:19:52] (03PS9) 10Jdlrobson: Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) [21:20:02] mholloway: that's cool [21:20:34] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1232593 (10Mholloway) a:5bearND>3Mholloway [21:21:16] (03PS2) 10BearND: Don't display "read more" suggestions outside main namespace [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206021 (https://phabricator.wikimedia.org/T92787) (owner: 10Deskana) [21:21:44] 6Mobile-Web, 10MediaWiki-Authentication-and-authorization, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1232594 (10Jdlrobson) [21:22:20] (03CR) 10jenkins-bot: [V: 04-1] Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) (owner: 10Jdlrobson) [21:22:43] (03CR) 10BearND: [C: 032] Don't display "read more" suggestions outside main namespace [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206021 (https://phabricator.wikimedia.org/T92787) (owner: 10Deskana) [21:23:01] (03Merged) 10jenkins-bot: Don't display "read more" suggestions outside main namespace [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206021 (https://phabricator.wikimedia.org/T92787) (owner: 10Deskana) [21:23:39] mhurd: syncing TWN [21:23:56] bearND: yay! [21:24:27] 3Gather Sprint Forward: Update in WikimediaMessages extension for enwiki - https://phabricator.wikimedia.org/T96805#1232602 (10Jdlrobson) @JKatzWMF @moushira when we launch to other projects how do we expect this to happen - is it okay to let the community set this message and default to 0 or would it be good to... [21:25:16] mhurd: ok, Page issues and Similar pages are the only two new string (+qqq). The other ones were synced a couple of days ago (just exported to TWN) [21:26:10] bearND: what about "saved-pages-clear-delete-all" ? [21:26:41] mhurd: we'll see shortly if that's already in there [21:26:46] 6Mobile-Web: Overlays do not work correctly on non-Minerva skins - https://phabricator.wikimedia.org/T97085#1232611 (10Jdlrobson) 3NEW [21:26:50] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206199 [21:26:59] (03PS1) 10BearND: Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206200 [21:27:06] 6Mobile-Web: Overlays do not work correctly on non-Minerva skins - https://phabricator.wikimedia.org/T97085#1232621 (10Jdlrobson) [21:27:07] bearND: i think we did use it a few months ago [21:27:08] 10Gather: Expose Gather as desktop beta feature - https://phabricator.wikimedia.org/T95227#1232620 (10Jdlrobson) [21:27:15] 10Gather, 5Patch-For-Review: Edit and delete buttons are currently broken on desktop skins - https://phabricator.wikimedia.org/T94063#1232623 (10Jdlrobson) [21:27:16] 6Mobile-Web: Overlays do not work correctly on non-Minerva skins - https://phabricator.wikimedia.org/T97085#1232611 (10Jdlrobson) [21:27:26] mhurd: patch is ready, too [21:27:37] mhurd: https://gerrit.wikimedia.org/r/#/c/206200/ [21:28:09] (03CR) 10Niedzielski: "@bearND -- thank you, these changes just show my ignorance. The link you mentioned is exactly what I was looking for and probably what @Mh" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski) [21:28:10] bearND: reviewing.. [21:28:42] mhurd: yes, saved-pages-clear-delete-all is in there but will need some updated translations (fuzzy) [21:29:16] bearND: cool! [21:33:34] (03CR) 10Mhurd: [C: 032] Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206200 (owner: 10BearND) [21:33:49] (03CR) 10Mhurd: [V: 032] Localisation updates from https://translatewiki.net. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206200 (owner: 10BearND) [21:37:55] (03CR) 10BearND: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206199 (owner: 10BearND) [21:43:09] (03PS1) 10Robmoen: Switch URL used for collection in moderation notification [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206292 [21:44:32] Hey, I'm learning how to use MobileFrontend [21:44:49] I'm injecting content on a SkinAfterContent hook, and it's now showing up in Mobile mode.I used [21:45:05] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206199 (owner: 10BearND) [21:45:18] (03CR) 10Robmoen: "See my followup. I made this change in the Edit api as well for moderation notification. Ideally we should have a centralized place for " [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205868 (https://phabricator.wikimedia.org/T94527) (owner: 10Jdlrobson) [21:45:26] (03PS1) 10BearND: Fix DoEditTask related tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206293 [21:46:16] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Right-align right-to-left languages in Wikipedia language setting menu - https://phabricator.wikimedia.org/T95895#1232690 (10Vibhabamba) @mholloway - I've thought about this quite a bit and examined some patterns. The languages that a... [21:46:54] mholloway: commented on this https://phabricator.wikimedia.org/T95895 [21:47:26] Can I wait for you to left align everything before I can move it to 'Ready for Design Signoff' [21:49:15] vibha: mholloway: Then we should create a patch for this right away. I was about to start the release build [21:49:18] vibha: i have to run quickly for the day but let's talk to bearND about reverting the change tomorrow. [21:49:31] or i could do it quickly now. [21:50:15] bearND: should i just do a new patch? [21:50:40] mholloway: yes, since this is already merged [21:50:54] bearND: ok. one sec. [21:51:19] vibha: does this apply to the 'read in other languages' list as well? [21:51:35] mholloway: awesome, ty [21:53:15] yes - RTL should render right to left but content should be left aligned for all lists [21:53:47] So yes - that would apply to read in other languages. [21:54:17] vibha: ok, i'll address both in the patch [21:54:24] bearND: ^ [21:54:47] Thanks a lot [21:57:37] 3Gather Sprint Forward, 6Mobile-Web, 10Analytics, 5Patch-For-Review: Update main menu schema to include collections for limn graphs - https://phabricator.wikimedia.org/T93690#1232702 (10Jdlrobson) 5Open>3Resolved [22:03:29] 6Mobile-Web, 7Performance: Nearby should be JS only - https://phabricator.wikimedia.org/T88432#1232708 (10Jdlrobson) 5Open>3declined a:3Jdlrobson It's strange but somewhat understandable. Code wise I think if we stopped using the router this may be more acceptable [22:06:05] 6Mobile-Web, 10MobileFrontend, 7Tracking: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#1232713 (10Jdlrobson) [22:06:07] 6Mobile-Web, 10MobileFrontend, 7Design, 5Patch-For-Review: Remove mobile editing "call to registration" CTA - https://phabricator.wikimedia.org/T87508#1232711 (10Jdlrobson) 5Open>3Resolved Anonymous editing is primary action. Create a separate task for interstitial if you think that is still needed wit... [22:08:12] 6Mobile-Web: Log common JavaScript exceptions - https://phabricator.wikimedia.org/T77931#1232718 (10Jdlrobson) 5Open>3declined a:3Jdlrobson [22:12:59] etonkovidova: did you have a chance to look at the 3 iOS cards of mine in QA signed? [22:13:06] *signoff* [22:13:17] (03PS1) 10Mholloway: Undo right-alignment of RTL languages in lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206301 [22:13:24] bearND: ^ [22:13:32] mholloway: awesome. Thanks! [22:13:34] (03CR) 10jenkins-bot: [V: 04-1] Undo right-alignment of RTL languages in lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206301 (owner: 10Mholloway) [22:13:54] mhurd: yup, I am looking at then right now. Our beta cluster is down, so I have time to check those issues [22:14:04] etonkovidova: cool! [22:14:06] thx [22:16:11] (03PS2) 10Mholloway: Undo right-alignment of RTL languages in lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206301 [22:16:35] bearND: one thing to note: Western Panjabi (Shahmukhi Panjabi) still will be right-aligned [22:16:40] but this is how it currently is in production [22:17:14] It's because of the length of the canonical name but I'd have to think about the best way to address it [22:17:17] mholloway: ah, cool. Keeping that similar to production is good [22:17:19] anyway, not caused by my patches [22:17:44] mholloway: I just didn't want to create a back an forth between production releases [22:17:52] Makes sense [22:17:54] mholloway: Thanks you very much! [22:18:53] bearND: No prob, gotta run but I'll keep an eye on email in case a change is needed, talk to you tomorrow! [22:19:19] mholloway: Good. See you tomorrow! [22:25:18] mhurd: git config --global core.ignorecase true [22:29:40] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Right-align right-to-left languages in Wikipedia language setting menu - https://phabricator.wikimedia.org/T95895#1232739 (10Mholloway) @Vibhabamba I uploaded a patch for this and @bearND will merge if there are no issues. [22:38:56] (03CR) 10BearND: [C: 032] Undo right-alignment of RTL languages in lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206301 (owner: 10Mholloway) [22:39:16] (03Merged) 10jenkins-bot: Undo right-alignment of RTL languages in lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206301 (owner: 10Mholloway) [22:41:07] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206309 [22:47:15] rmoen: can you move cards to -1 column when they have issues i completely missed your feedback till now [22:47:33] jdlrobson: yes [22:48:47] jdlrobson: Will work on it. I generally just look in Gerrit. Still not in the habit of moving things to -1 [22:56:55] 6Mobile-Web: Log common JavaScript exceptions - https://phabricator.wikimedia.org/T77931#1232794 (10bmansurov) I think resource loader errors are already being tracked in core [1]. We can use sampled EL to limit the burden. [1] https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki/mediawiki... [22:56:56] 6Mobile-Web: Log common JavaScript exceptions - https://phabricator.wikimedia.org/T77931#1232794 (10bmansurov) I think resource loader errors are already being tracked in core [1]. We can use sampled EL to limit the burden. [1] https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki/mediawiki... [22:58:59] jdlrobson: small issue https://gerrit.wikimedia.org/r/#/c/205440/ [23:01:45] 3Gather Sprint Forward, 5Patch-For-Review: Visiting a collection triggers an API request on every page load - https://phabricator.wikimedia.org/T97076#1232805 (10Jdlrobson) 5Open>3Resolved [23:01:46] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add a flag button - https://phabricator.wikimedia.org/T94871#1232806 (10Jdlrobson) [23:01:46] 3Gather Sprint Forward, 5Patch-For-Review: Visiting a collection triggers an API request on every page load - https://phabricator.wikimedia.org/T97076#1232805 (10Jdlrobson) 5Open>3Resolved [23:01:47] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add a flag button - https://phabricator.wikimedia.org/T94871#1232806 (10Jdlrobson) [23:06:17] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1232822 (10Etonkovidova) Generally, looks good - checked a few articles with Page... [23:06:18] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1232822 (10Etonkovidova) Generally, looks good - checked a few articles with Page... [23:07:33] 6Mobile-Web: Icons don't behave like Views - https://phabricator.wikimedia.org/T97077#1232832 (10bmansurov) You have a typo on the last line before 'on' (comma). If you fix that an element is then inserted into the DOM. Also, currently that's not how event binding works with the View. I think event binding probl... [23:07:34] 6Mobile-Web: Icons don't behave like Views - https://phabricator.wikimedia.org/T97077#1232832 (10bmansurov) You have a typo on the last line before 'on' (comma). If you fix that an element is then inserted into the DOM. Also, currently that's not how event binding works with the View. I think event binding probl... [23:07:40] mhurd: https://phabricator.wikimedia.org/T90250 - can you read my comments there when you have time? [23:08:04] etonkovidova: ya! [23:08:26] mhurd: maybe I am making it more complicated than it is -or I am missing the point completely? [23:10:58] etonkovidova: no those are good points. i believe we'll have to check these as follow-ups on both iOS and android [23:11:07] 6Mobile-Web, 3Mobile-Web-Design: Stop serving menu in the page HTML - https://phabricator.wikimedia.org/T95332#1232836 (10bmansurov) This task can be resolved by working on T96172 and promoting the new design to beta/stable. [23:11:08] 6Mobile-Web, 3Mobile-Web-Design: Stop serving menu in the page HTML - https://phabricator.wikimedia.org/T95332#1232836 (10bmansurov) This task can be resolved by working on T96172 and promoting the new design to beta/stable. [23:11:30] mhurd: thanks! [23:11:46] mhurd: would be interesting to do more intensive testing... [23:44:25] (03Merged) 10jenkins-bot: Beta: Add the Tags section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204490 (https://phabricator.wikimedia.org/T94739) (owner: 10Phuedx) [23:54:38] (03PS3) 10Jdlrobson: Hygiene: Stop using mw-ui-button without abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 [23:54:40] (03PS8) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [23:54:42] (03PS1) 10Jdlrobson: Hygiene: Use Button for category button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206334 [23:54:44] (03PS1) 10Jdlrobson: Hygiene: Drawer uses Icon and Button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206335 [23:57:09] (03PS1) 10Jdlrobson: Hygiene: Use Button in AbuseFilterOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206336 [23:57:18] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Drawer uses Icon and Button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206335 (owner: 10Jdlrobson) [23:57:55] bmansurov you around? [23:58:14] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Stop using mw-ui-button without abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 (owner: 10Jdlrobson) [23:59:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Button in AbuseFilterOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206336 (owner: 10Jdlrobson) [23:59:28] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Button for category button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206334 (owner: 10Jdlrobson) [23:59:46] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 (owner: 10Jdlrobson) [23:59:55] 6Mobile-Web: FontChanger should use Button to construct its buttons - https://phabricator.wikimedia.org/T97094#1232913 (10Jdlrobson) 3NEW [23:59:56] 6Mobile-Web: FontChanger should use Button to construct its buttons - https://phabricator.wikimedia.org/T97094#1232913 (10Jdlrobson) 3NEW