[03:46:22] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1237361 (10JKatzWMF) @msyed @jdlrobson looks good to me! [03:46:52] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Should be clear that collection is personal opinion - https://phabricator.wikimedia.org/T96931#1237362 (10JKatzWMF) @msyed @jdlrobson look good to me. Let's go with #2. [04:10:42] 3Gather Sprint Forward: for edit overlay, change label of done to save - https://phabricator.wikimedia.org/T97266#1237380 (10JKatzWMF) 3NEW [04:11:03] 3Gather Sprint Forward: for edit overlay, change label of done to save - https://phabricator.wikimedia.org/T97266#1237390 (10JKatzWMF) [04:11:04] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1237389 (10JKatzWMF) [04:12:25] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1200018 (10JKatzWMF) "Done" button on first edit overlay still says done can't verify on mobile phone--server seems down [04:13:07] 10Gather, 3Gather Sprint Forward, 3Mobile-Web-Design, 5Patch-For-Review: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1237400 (10JKatzWMF) [04:13:09] 10Gather: Allow autopatrolled users to contribute in list moderation. - https://phabricator.wikimedia.org/T94641#1237401 (10JKatzWMF) [04:13:11] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add a flag button - https://phabricator.wikimedia.org/T94871#1237399 (10JKatzWMF) 5Open>3Resolved [04:14:46] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Use auto-completable URLs for Special:Gather - https://phabricator.wikimedia.org/T94527#1237411 (10JKatzWMF) 5Open>3Resolved [04:15:47] 10Gather, 3Gather Sprint Forward, 3Mobile-Web-Design, 5Patch-For-Review: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1237414 (10JKatzWMF) 5Open>3Resolved [04:17:02] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1237417 (10JKatzWMF) 5Open>3Resolved [04:19:11] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1237424 (10JKatzWMF) @rmoen I can't trigger this on wmflabs. Can you? [04:25:50] 10Gather, 10Gather Sprint G: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1237425 (10JKatzWMF) 3NEW [04:26:02] 10Gather, 3Gather Sprint Forward: for edit overlay, change label of done to save - https://phabricator.wikimedia.org/T97266#1237433 (10JKatzWMF) [04:26:23] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Pointer to collections should be shown whenever a new user adds a new collection. - https://phabricator.wikimedia.org/T95976#1237435 (10JKatzWMF) 5Open>3Resolved [04:28:09] 3Gather Sprint Forward, 5Patch-For-Review: Deleting a collection doesn't close editor overlay - https://phabricator.wikimedia.org/T96294#1237437 (10JKatzWMF) 5Open>3Resolved [04:28:28] 10Gather, 3Gather Sprint Forward, 7Easy, 5Patch-For-Review: Hidden collections show as private in my list of collections - https://phabricator.wikimedia.org/T95967#1237440 (10JKatzWMF) 5Open>3Resolved [04:30:28] 3Gather Sprint Forward: Update in WikimediaMessages extension for enwiki - https://phabricator.wikimedia.org/T96805#1237443 (10JKatzWMF) @jdlrobson @moushira @rmoen sorry, just saw this--think it should be the second option: Add a default that links to a red link where they can define the policy using text""Bef... [04:30:53] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Should be possible to make a public list private. - https://phabricator.wikimedia.org/T94257#1237444 (10JKatzWMF) 5Open>3Resolved [04:33:45] 10Gather, 3Gather Sprint Forward, 3Mobile-Web-Design, 5Patch-For-Review: Add a hide button to collections - https://phabricator.wikimedia.org/T94228#1237449 (10JKatzWMF) [04:33:48] 3Gather Sprint Forward, 5Patch-For-Review: Bug: Show/hide actions not showing correct toast message - https://phabricator.wikimedia.org/T96319#1237447 (10JKatzWMF) 5Open>3Resolved [04:34:49] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Bug: When public user visits another users collections page the Page header says "[usernames] collections" - https://phabricator.wikimedia.org/T93618#1237451 (10JKatzWMF) 5Open>3Resolved [04:35:54] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: A user can add to to a NEW collection using search interface - https://phabricator.wikimedia.org/T94803#1237454 (10JKatzWMF) 5Open>3Resolved [04:40:36] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Meta tags for a users list of collections - https://phabricator.wikimedia.org/T95239#1237457 (10JKatzWMF) 5Open>3Resolved [04:41:06] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Can create collection with non-main namespace pages but they do not show up - https://phabricator.wikimedia.org/T94786#1237459 (10JKatzWMF) 5Open>3Resolved [04:41:36] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Special:Gather/by should go somewhere - https://phabricator.wikimedia.org/T95791#1237461 (10JKatzWMF) 5Open>3Resolved [04:42:52] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: On edit collection overlay, the box is labeled "public" instead of private - https://phabricator.wikimedia.org/T93391#1237463 (10JKatzWMF) 5Open>3Resolved [04:43:02] 3Gather Sprint Forward, 5Patch-For-Review: Deleting a collection doesn't close editor overlay - https://phabricator.wikimedia.org/T96294#1237467 (10JKatzWMF) [04:45:13] 3Gather Sprint Forward, 5Patch-For-Review: Adding/removing to watchlist when new user causes window to reopen - https://phabricator.wikimedia.org/T95744#1237473 (10JKatzWMF) 5Open>3Resolved [04:47:47] 10Gather, 3Gather Sprint Forward: Removing watchlist item from watchlist via Gather overlay does not cause star to change fill anymore... - https://phabricator.wikimedia.org/T97268#1237474 (10JKatzWMF) 3NEW [04:47:58] 3Gather Sprint Forward, 5Patch-For-Review: Adding/removing to watchlist when new user causes window to reopen - https://phabricator.wikimedia.org/T95744#1237484 (10JKatzWMF) @jdlrobson this is resolved, but appears to have caused a new bug: T97268 [04:54:00] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Infinite spinner when editing empty collections - https://phabricator.wikimedia.org/T95637#1237487 (10JKatzWMF) 5Open>3Resolved [04:55:58] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Tweak the search in EditorOverlay behaviour - https://phabricator.wikimedia.org/T95778#1237489 (10JKatzWMF) 5Open>3Resolved [04:56:49] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Bug: Long titles should be clipped in EditorOverlay - https://phabricator.wikimedia.org/T95788#1237491 (10JKatzWMF) 5Open>3Resolved [05:00:45] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: new collection entry design tweak - https://phabricator.wikimedia.org/T93651#1237493 (10JKatzWMF) @msyed if you check in wmflabs, you'll see that this is mostly implemented. The create button does not expand 2x. Now that you can see it, ping me if you thi... [05:03:35] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: new collection entry design tweak - https://phabricator.wikimedia.org/T93651#1237494 (10MSyed) @JKatzWMF looks better. [07:48:59] morning [08:24:26] hey joakino_ [08:24:31] another one bites the dust! http://33.media.tumblr.com/8e4638abbd29b405e650c35c0ca08471/tumblr_nmtcqe1pCt1t3e1w7o1_500.gif [08:24:34] hi phuedx [08:24:44] i was just reading wmfall lol [08:25:16] reorg soundtrack https://www.youtube.com/watch?v=rY0WxgSXdEE lolol [08:34:19] joakino_: which email in particular [08:34:22] * phuedx doesn't see one [08:34:27] oh [08:45:06] (03CR) 10Jhernandez: [C: 032] i18n: Tweaks [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205801 (https://phabricator.wikimedia.org/T95547) (owner: 10Jdlrobson) [08:48:17] (03Merged) 10jenkins-bot: i18n: Tweaks [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205801 (https://phabricator.wikimedia.org/T95547) (owner: 10Jdlrobson) [09:11:38] (03CR) 10Phuedx: [C: 04-1] "Title#getContentModel throws an exception if it can't determine the content model. This'll need to be caught and dealt with." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206651 (https://phabricator.wikimedia.org/T97249) (owner: 10Florianschmidtwelzow) [09:12:14] (03CR) 10Phuedx: "… so we can return something reasonable if Title#getContentModel fails." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206651 (https://phabricator.wikimedia.org/T97249) (owner: 10Florianschmidtwelzow) [09:12:50] (03CR) 10Jhernandez: [C: 032] Rewrite mobile login page to be less hacky and closer to core version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) (owner: 10Kaldari) [09:13:47] joakino_: was just about to review that ^ [09:13:49] ta :D [09:14:14] phuedx: i've been with it for a while [09:14:22] annoying to test [09:14:38] needed it for closing up a couple of gather tasks [09:16:01] (03PS4) 10Jhernandez: Making the Gather login and signup messages work in standard way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205473 (https://phabricator.wikimedia.org/T95729) (owner: 10Kaldari) [09:16:04] (03Merged) 10jenkins-bot: Rewrite mobile login page to be less hacky and closer to core version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204977 (https://phabricator.wikimedia.org/T95065) (owner: 10Kaldari) [09:16:59] joakino_: also completes the readership sprint \o/ [09:17:11] :D [09:17:16] (03CR) 10Florianschmidtwelzow: "@phuedx: Do you really mean, that we should handle this case (i can't think about a case, when this can happen, maybe if an extension chan" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206651 (https://phabricator.wikimedia.org/T97249) (owner: 10Florianschmidtwelzow) [09:17:17] 3Gather Sprint Forward, 6Mobile-Web, 10MobileFrontend, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Email confirmation workflow doesn't work correctly from a Mobile device - https://phabricator.wikimedia.org/T95065#1237680 (10phuedx) 5Open>3Resolved [09:18:10] (03CR) 10Jhernandez: [C: 032] "Looks good. Fixed trailing comma in last PS." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205473 (https://phabricator.wikimedia.org/T95729) (owner: 10Kaldari) [09:18:31] 3Gather Sprint Forward, 5Patch-For-Review: string replacement for watchstar login page - https://phabricator.wikimedia.org/T95729#1237682 (10Jhernandez) All merged. [09:19:48] (03Merged) 10jenkins-bot: Making the Gather login and signup messages work in standard way [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205473 (https://phabricator.wikimedia.org/T95729) (owner: 10Kaldari) [09:21:30] (03CR) 10Florianschmidtwelzow: "I looked at the comment of ContentHandler::getDefaultModelFor() (https://doc.wikimedia.org/mediawiki-core/master/php/classContentHandler.h" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206651 (https://phabricator.wikimedia.org/T97249) (owner: 10Florianschmidtwelzow) [09:23:38] (03CR) 10Phuedx: "> Do you really mean, that we should handle this case (i can't think about a case, when this can happen, maybe if an extension changed the" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206651 (https://phabricator.wikimedia.org/T97249) (owner: 10Florianschmidtwelzow) [09:24:57] (03CR) 10Phuedx: "Okie poke. Then let's remove the throw statement from Title#getContentModel." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206651 (https://phabricator.wikimedia.org/T97249) (owner: 10Florianschmidtwelzow) [09:26:57] (03PS6) 10Jhernandez: Update how deleted pages behave [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson) [09:27:37] (03CR) 10Jhernandez: [C: 032] "Rebase borked item card titles (duplicated). Fixed that. Looks good as before." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson) [09:31:36] (03Merged) 10jenkins-bot: Update how deleted pages behave [extensions/Gather] - 10https://gerrit.wikimedia.org/r/205300 (https://phabricator.wikimedia.org/T93295) (owner: 10Jdlrobson) [09:33:27] (03CR) 10Phuedx: [C: 032] Add contentmodel prop to mobileview Api module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206651 (https://phabricator.wikimedia.org/T97249) (owner: 10Florianschmidtwelzow) [09:35:25] (03Merged) 10jenkins-bot: Add contentmodel prop to mobileview Api module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206651 (https://phabricator.wikimedia.org/T97249) (owner: 10Florianschmidtwelzow) [09:37:59] (03PS7) 10Jhernandez: Write log entries for showlist and hidelist to Special:Log [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204680 (https://phabricator.wikimedia.org/T95250) (owner: 10Jdlrobson) [09:38:14] (03CR) 10Jhernandez: "Rebased master" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204680 (https://phabricator.wikimedia.org/T95250) (owner: 10Jdlrobson) [09:46:00] (03CR) 10Jhernandez: [C: 032] Write log entries for showlist and hidelist to Special:Log [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204680 (https://phabricator.wikimedia.org/T95250) (owner: 10Jdlrobson) [09:46:09] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane: Special:MobileOptions throwing JS error from mobile.watchstar in stable - https://phabricator.wikimedia.org/T92657#1237724 (10phuedx) [09:47:09] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: API: Log when admin hides or unhides collection - https://phabricator.wikimedia.org/T95250#1237726 (10Jhernandez) {F157685} Works fine here. [09:47:36] (03Merged) 10jenkins-bot: Write log entries for showlist and hidelist to Special:Log [extensions/Gather] - 10https://gerrit.wikimedia.org/r/204680 (https://phabricator.wikimedia.org/T95250) (owner: 10Jdlrobson) [09:49:07] 10Gather, 3Gather Sprint Forward: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1237731 (10Jhernandez) a:3Jhernandez [09:55:41] (03CR) 10Florianschmidtwelzow: "You're right, we should handle the exception, if it could be thrown, i missed to explain, why i doesn't do it, sorry :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206651 (https://phabricator.wikimedia.org/T97249) (owner: 10Florianschmidtwelzow) [09:57:02] 6Mobile-Web, 10MobileFrontend, 5Patch-For-Review: Add support for retrieving a page's content model using action=mobileview - https://phabricator.wikimedia.org/T97249#1237737 (10Florian) 5Open>3Resolved [10:02:31] (03CR) 10Phuedx: [C: 04-1] "See inline. This is a good change, but it could be made a little more readable." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [10:03:41] 6Mobile-Web, 10MobileFrontend: Add support for retrieving a page's content model using action=mobileview - https://phabricator.wikimedia.org/T97249#1237738 (10phuedx) [10:07:16] (03CR) 10Florianschmidtwelzow: Remove duplicated code for each prop in mobileview api (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [10:25:51] 10Gather, 3Gather Sprint Forward: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1237762 (10Jhernandez) Been analyzing what this entails: - **For the list of collections** [] Switch CollectionList views and related to templates (so that we can render them the same... [10:27:42] (03CR) 10Phuedx: Remove duplicated code for each prop in mobileview api (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [10:29:50] 6Mobile-Web: "Editing $1" looks bad if word order is changed - https://phabricator.wikimedia.org/T97275#1237780 (10Florian) 3NEW a:3Florian [10:31:36] 10Wikipedia-Android-App: performance: the nearby API query requests info that it doesn't use. - https://phabricator.wikimedia.org/T97276#1237789 (10Spage) 3NEW [10:33:15] 6Mobile-Web: "Editing $1" looks bad if word order is changed - https://phabricator.wikimedia.org/T97275#1237798 (10Florian) [10:37:01] (03PS1) 10Jhernandez: When editing collection: Done -> Save [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206772 (https://phabricator.wikimedia.org/T97266) [10:37:11] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: for edit overlay, change label of done to save - https://phabricator.wikimedia.org/T97266#1237811 (10Jhernandez) a:3Jhernandez [10:38:41] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Edit collection overlay changes - https://phabricator.wikimedia.org/T95776#1237815 (10Jhernandez) [10:39:54] (03PS1) 10Jhernandez: Hygiene: Remove outdated comment [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206773 [10:41:57] (03CR) 10Florianschmidtwelzow: Remove duplicated code for each prop in mobileview api (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [10:46:59] (03CR) 10Phuedx: Remove duplicated code for each prop in mobileview api (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [10:58:56] gonna take george to father's group [10:59:03] g'bye [11:33:21] (03PS1) 10Florianschmidtwelzow: Fix for edit header message format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) [11:34:58] (03CR) 10jenkins-bot: [V: 04-1] Fix for edit header message format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) (owner: 10Florianschmidtwelzow) [11:43:19] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) (owner: 10Florianschmidtwelzow) [11:51:38] (03CR) 10Florianschmidtwelzow: "come on Jenkins :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) (owner: 10Florianschmidtwelzow) [11:51:45] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) (owner: 10Florianschmidtwelzow) [11:52:58] 3Gather Sprint Forward: Render CollectionListItem with templates - https://phabricator.wikimedia.org/T97284#1237903 (10Jhernandez) 3NEW a:3Jhernandez [11:53:25] 3Gather Sprint Forward: Render CollectionListItem with templates - https://phabricator.wikimedia.org/T97284#1237913 (10Jhernandez) [11:53:27] 10Gather, 3Gather Sprint Forward: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1237912 (10Jhernandez) [11:54:00] (03PS1) 10Jhernandez: Render Collection list items with templates. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) [11:54:04] (03CR) 10Florianschmidtwelzow: ":)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) (owner: 10Florianschmidtwelzow) [12:59:25] 10Wikipedia-Android-App: "This page does not exist" on clickthrough from Google search results. - https://phabricator.wikimedia.org/T89734#1238035 (10dahamsta) This is still happening on my Huawei MediaPad X1, just noticed it the other day. Don't do a lot of Wikipediaing on that device. Also, to my mind "Open o... [13:59:37] (03CR) 10Mholloway: "One comment inline, otherwise looks good." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski) [14:11:10] (03CR) 10Niedzielski: Minor Improvements to Readme (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski) [14:13:57] 10Wikipedia-Android-App, 6Mobile-Apps, 6Services, 10service-template-node, 3Mobile-App-Sprint-55-Android: Update the MobileApps service to the latest version of the service template - https://phabricator.wikimedia.org/T96126#1238112 (10mobrovac) [14:14:45] 10Wikipedia-Android-App, 6Mobile-Apps, 6Services, 10service-template-node, 3Mobile-App-Sprint-55-Android: Update the MobileApps service to the latest version of the service template - https://phabricator.wikimedia.org/T96126#1238114 (10mobrovac) 5Open>3Resolved @bearND confirms the content is display... [14:24:08] (03CR) 10Bgerstle: [C: 031] Chsnge hockey key [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206489 (owner: 10Fjalapeno) [14:32:21] hello mobile web folks! do we actively support phones with no JS for MobileFrontend, and if so what maximum level of degraded experience are they subject to? [14:37:24] 6Mobile-Web, 10MobileFrontend, 6Performance-Team: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1238138 (10Gilles) 3NEW a:3Gilles [14:37:43] gilles, no editing, only basic reading and searching [14:38:50] MaxSem: thanks [14:49:02] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1238183 (10BGerstle-WMF) a:5BGerstle-WMF>3None [14:49:14] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when reading incomplete section list from disk - https://phabricator.wikimedia.org/T96597#1238185 (10BGerstle-WMF) a:3BGerstle-WMF [14:54:37] (03CR) 10Phuedx: [C: 032] "I've tested this locally logged in and logged out and it LGTM." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 (owner: 10Jdlrobson) [14:56:13] (03Merged) 10jenkins-bot: Turn PageList into a generic component based on Gather usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203252 (owner: 10Jdlrobson) [14:56:57] (03PS6) 10Phuedx: Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (owner: 10Jdlrobson) [15:01:43] * bearND waves at mholloway and niedzielski [15:01:54] (03PS2) 10Florianschmidtwelzow: Remove duplicated code for each prop in mobileview api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 [15:02:07] hey bearND! [15:02:18] hey niedzielski, welcome aboard (officially)! [15:02:38] hey! [15:02:43] Welcome aboard, niedzielski! [15:02:49] thanks, guys! [15:03:13] (03PS3) 10Florianschmidtwelzow: Remove duplicated code for each prop in mobileview api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 [15:03:37] should i just grab a task from sprint 56 in the todo column? [15:04:41] bearND: mholloway ^ [15:05:12] niedzielski: fine with me, unless bearND had something specific in mind [15:05:18] niedzielski: yes. I'm going to assign a few cards to some people that already have some history with them. [15:06:40] niedzielski: Basically anything starting with "Text selection and sharing does not work with HTC Sense" and below in the ToDo column is probably good to grab [15:07:02] sweet. thanks! bearND mholloway [15:07:05] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 3Roadmap, 7notice: Production release for the Android Wikipedia app on 29th April 2015 - https://phabricator.wikimedia.org/T97064#1238260 (10bearND) a:3bearND [15:07:45] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: EventLogging to evaluate success/failure of link hovering prototype - https://phabricator.wikimedia.org/T95726#1238261 (10bearND) a:3Mholloway [15:08:32] bearND: not sure if you saw but robh put my access to caesium through this morning [15:09:08] mholloway: nice! No, I had not seen it. Congrats! [15:09:20] bearND: thanks! [15:09:32] still wrapping up some some stuff from sprint 55 [15:09:34] (03CR) 10Phuedx: [C: 04-1] "A handful of trivials inline." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [15:11:50] mholloway: I put your name on the EventLogging card. But I guess you have also some cards from sprint 55 left. [15:13:08] bearND: yeah, we kind of underestimated the image manipulation task just because there's so much variety in what gets sent over, but it's coming along. [15:14:12] niedzielski: I think anything that doesn't have a person assigned is open for you to tackle. The first two card without a name may need some explanations. [15:14:12] 6Mobile-Web, 10MobileFrontend, 6Performance-Team: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1238269 (10Gilles) I realize now that the figures I measured above are in no-JS mode. I've identified some low-hanging fruit in that mode, but then I'll have to measure what traffic n... [15:15:07] bearND: thanks, i've started looking at the cards to make sure i understand the tasks. if i can repro, "Imagemap does not fit the screen" (T87066) i'll take it [15:17:39] niedzielski: ok, yes, that's a good one to also coordinate with mholloway. He's working on a similar thing right now: to make smaller images bigger to a 100% width. [15:18:29] bearND: hmm, let me take a quick look at that [15:20:10] 6Mobile-Web, 10MobileFrontend, 6Performance-Team: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1238286 (10phuedx) Other ideas might also include: * moving `` elements to the top of the head so the browser starts fetching it as quickly as possible * inclu... [15:21:47] bearND: mholloway i can repro it. happy to take this one or if it makes more sense for mholloway to work on it, i'll just grab something else. [15:23:45] niedzielski: it might make sense to take another one. this is pretty directly related to what i'm working on and i can just address it there [15:23:56] sounds good [15:24:47] 6Mobile-Web, 10MobileFrontend, 6Performance-Team: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1238302 (10phuedx) Please, please, please reach out to the Mobile Web team on mobile-l or mobile-tech before you start on this kind of improvement. Product, Design, and Engineering sh... [15:26:42] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#1238306 (10Mholloway) a:3Mholloway [15:27:50] (03Abandoned) 10Deskana: Make it possible to edit MediaWiki namespace pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206628 (owner: 10Deskana) [15:28:25] mholloway: how does one obtain access to OTRS (https://ticket.wikimedia.org/otrs/index.pl)? it seems a number of tasks link to tickets in there [15:29:30] niedzielski: talk to Dan (Deskana); the process seems to go through him. (that's what i did.) [15:30:21] niedzielski: we can mention it at standup [15:31:40] mholloway: sounds good, thanks. by the bye, when is stand up? and where is the "Batcave"? [15:32:35] (03CR) 10Florianschmidtwelzow: Remove duplicated code for each prop in mobileview api (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [15:32:35] niedzielski: Yes, OTRS access should be added to the onboarding list. Feel free to ping Deskana whenever he gets online or send him email. [15:33:01] niedzielski: I'm sending you info about the batcave via email. [15:33:32] bearND: gr8, thanks! [15:34:16] niedzielski: i just added you to the standup meeting. (hmm, looks like you're niedzielsky in the system, did you get the invite?) [15:36:09] mholloway: thanks, i've not received access to my wmf account yet and i'm hoping to get a different username as that's a misspelling of my last name [15:36:18] (03CR) 10Phuedx: Remove duplicated code for each prop in mobileview api (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [15:37:50] bearND: mholloway i'll plan to grab "'Tap here to expand' - the label should change when the section is expanded?" (T86860) if there are no objections [15:38:10] niedzielski: sounds good to me [15:38:42] niedzielski: go for it! [15:39:07] niedzielski: as for the incorrect username, maybe you could file a Phabricator ticket for ops? bearND, what do you think? [15:39:09] 10Wikipedia-Android-App, 7Easy, 3Mobile-App-Sprint-56-Android: 'Tap here to expand' - the label should change when the section is expanded? - https://phabricator.wikimedia.org/T86860#1238332 (10Niedzielski) a:3Niedzielski [15:40:39] niedzielski: mholloway: I think this is office IT realm. [15:40:40] mholloway: i think adam was going to look into it. i thought i should probably wait to get access to the account before filing a ticket on it [15:40:55] niedzielski: ah, good [15:41:50] niedzielski: cool. you should get access shortly. i'm looking back at my email to try and remember how that played out. [15:45:01] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Create accounts for Build server - https://phabricator.wikimedia.org/T94426#1238360 (10Fjalapeno) @dr0ptp4kt Do you want to “invite” the new email account to the dev portal and iTunes connect? Or if you want to send the address to me I can do it, let me know. [15:47:02] mholloway: is it possible to send the hangout invite to stephen@niedzielski.com until i get my username sorted? [15:53:55] niedzielski: sent it to you. [15:54:44] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#1238402 (10Mholloway) This is one of the many edge cases I'll have to address as part of T94646. [15:56:01] bearND: mholloway thanks! i'm set [15:57:51] niedzielski: great! i'm off to lunch, will be back a bit before standup (which I believe is at 11:15 your time -- google hangout link is in the calendar entry) [15:59:03] mholloway: woot, see you in a bit [16:03:48] gonna take a small break [16:07:11] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Cannot edit MediaWiki:Common.css - https://phabricator.wikimedia.org/T68320#1238439 (10Deskana) 5Open>3stalled I've abandoned the above patch in favour of using a solution based on this patch, which will be live in production arou... [16:07:16] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Cannot edit MediaWiki:Common.css - https://phabricator.wikimedia.org/T68320#1238441 (10Deskana) [16:07:30] 10Wikipedia-Android-App: Cannot edit MediaWiki:Common.css - https://phabricator.wikimedia.org/T68320#711260 (10Deskana) [16:09:54] (03PS4) 10Florianschmidtwelzow: Remove duplicated code for each prop in mobileview api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 [16:10:57] 10Gather, 10Gather Sprint G: Flag icon shows on watchlist and other private collections - https://phabricator.wikimedia.org/T97300#1238444 (10Jdlrobson) 3NEW [16:11:41] bearND|brb: nuts, it looks like one of my orientation meetings is during stand up. can i get pass today? [16:18:32] niedzielski: sure. no, problem. Happened to mholloway, too [16:20:11] niedzielski: Is there's anything you want me to mention at standup? [16:21:08] bearND: "Hello world! I'm working on T86860, tap to expand. No blockers." [16:23:31] niedzielski: Nice. [16:26:40] i'm back from my break [16:27:00] (03CR) 10Jdlrobson: [C: 032] When editing collection: Done -> Save [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206772 (https://phabricator.wikimedia.org/T97266) (owner: 10Jhernandez) [16:28:09] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove outdated comment [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206773 (owner: 10Jhernandez) [16:28:49] (03Merged) 10jenkins-bot: When editing collection: Done -> Save [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206772 (https://phabricator.wikimedia.org/T97266) (owner: 10Jhernandez) [16:30:27] (03Merged) 10jenkins-bot: Hygiene: Remove outdated comment [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206773 (owner: 10Jhernandez) [16:31:01] joakino: morning! joakino: are you able to replicate https://gerrit.wikimedia.org/r/#/c/202061/ locally? [16:31:05] the jscs error [16:32:26] (03CR) 10Jdlrobson: [C: 031] "looks good but needs testing" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206191 (owner: 10Robmoen) [16:34:27] (03CR) 10Jdlrobson: [C: 04-1] Render Collection list items with templates. (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) (owner: 10Jhernandez) [16:39:14] (03CR) 10Jdlrobson: [C: 032] Prevent multiple clicks to flag and detach from dom on confirmation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206191 (owner: 10Robmoen) [16:40:06] 10Gather: A user who has flagged a collection cannot flag the same collection so that they do not have disproportionate voice. - https://phabricator.wikimedia.org/T95768#1238541 (10Tgr) What happens with the old flags when the collection is edited? Are they just deleted? That sounds a bit like a get out of jail... [16:40:55] 10Gather, 3Gather Sprint Forward: Flag icon doesn't show on desktop - https://phabricator.wikimedia.org/T97301#1238543 (10Jdlrobson) 3NEW [16:42:30] (03Merged) 10jenkins-bot: Prevent multiple clicks to flag and detach from dom on confirmation [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206191 (owner: 10Robmoen) [16:43:29] (03CR) 10Jdlrobson: "This was done on purpose from what I remember. I forget the reasoning - Does anyone remember?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) (owner: 10Florianschmidtwelzow) [16:43:32] 6Mobile-Web, 10Analytics-EventLogging, 6Analytics-Kanban: Follow up with mobile team on instrumentation sampling rate (%50) - https://phabricator.wikimedia.org/T88363#1238560 (10Milimetric) Nothing needs to happen if you guys know the sampling is going on, and are taking that into account when you look at yo... [16:44:17] 6Mobile-Web: Follow up with mobile team on instrumentation sampling rate (%50) - https://phabricator.wikimedia.org/T88363#1238561 (10kevinator) [16:44:36] 6Mobile-Web: Follow up with mobile team on instrumentation sampling rate (%50) - https://phabricator.wikimedia.org/T88363#1010140 (10kevinator) removing from analytics workboard, nothing else for us to do. [16:46:03] joakino: ping pin [16:55:10] 10Gather, 3Gather Sprint Forward: Make collection hidden icon shows on hidden collections - https://phabricator.wikimedia.org/T97178#1238591 (10Jdlrobson) Jon to make this more generic. [16:55:21] 10Gather: Make collection hidden icon shows on hidden collections - https://phabricator.wikimedia.org/T97178#1238592 (10Jdlrobson) [17:00:10] 3Gather Sprint Forward: Public collections appear as private when viewed - https://phabricator.wikimedia.org/T97161#1238633 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Seems to have resolved itself. [17:01:55] 10Gather: Rethink hidden collections - https://phabricator.wikimedia.org/T97178#1238663 (10Jdlrobson) a:3JKatzWMF [17:03:02] (03PS15) 10Jdlrobson: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [17:03:10] (03CR) 10Jdlrobson: [C: 032] Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [17:03:18] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1238678 (10bearND) @Vibhabamba: > "Tapping anywhere on the card takes you to the target article" Was already done. Or where does it not work? Here are a few... [17:03:54] 6Mobile-Web: Can't bind events to Views - https://phabricator.wikimedia.org/T97077#1238681 (10Jdlrobson) [17:04:19] (03CR) 10Jdlrobson: Hygiene: Create anchor abstraction (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [17:05:05] (03Merged) 10jenkins-bot: Check, if the user is blocked from editing before try to save the edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204716 (https://phabricator.wikimedia.org/T96257) (owner: 10Florianschmidtwelzow) [17:08:24] 10Gather: Flow of cards in lists (of collections or items) is top down - https://phabricator.wikimedia.org/T97309#1238696 (10Jhernandez) 3NEW [17:10:21] 6Mobile-Web: Follow up with mobile team on instrumentation sampling rate (%50) - https://phabricator.wikimedia.org/T88363#1238705 (10Jdlrobson) @kaldari @phuedx is this card done? [17:12:56] (03CR) 10Jdlrobson: [C: 031] "It looks a lot cleaner and I prefer this code but pulling in Max to understand why it wasn't done like this in the first place and if ther" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [17:14:20] oh good news joakino - i found a guy in twitter who's gonna let us use opengraph on wikipedia so we don't have to do twitter cards! \o/ [17:14:53] jdlrobson: that's awesome [17:15:45] 10Gather Sprint G, 6Mobile-Web: A logged in user who opts in to mobile web beta is in beta until they opt out. - https://phabricator.wikimedia.org/T97193#1238716 (10phuedx) @JKatzWMF: I think this is a Must Have. What do you think? [17:16:20] ^ checkout out my remote working [17:16:39] i've been near the keyboard for /a long/ time and only now remember to change my name [17:16:42] 10Gather Sprint G, 6Mobile-Web: A logged in user who opts in to mobile web beta is in beta until they opt out. - https://phabricator.wikimedia.org/T97193#1238719 (10Jdlrobson) @phuedx - we're gonna make this happen in Gather next sprint. Boom! [17:17:16] jdlrobson: ^ remember to take cards out of triage on the mobile web board plz plz plz [17:17:49] 6Mobile-Web, 3Mobile-Web-Design: Change in-article images to be full width on phones and larger thumb size on tablets - https://phabricator.wikimedia.org/T97199#1238723 (10bmansurov) We need to decide how this will effect the page load times. We need to check whether images are small because they are styled th... [17:18:07] phuedx: but.. it's a Mobile Web task... it's not strictly Gather [17:18:17] and if someone wants to implement it outside sprint that's awesome [17:18:47] jdlrobson: so you haven't committed to it yet? [17:18:54] we're committing to it in 10 mins [17:18:56] hopefully :) [17:18:57] if you have, then to me it's triaged [17:19:15] i should have put it in a column i guess.. i just never know which [17:19:44] i guess technically you couldn't move it to "in sprint" [17:19:49] maybe in 10 minutes i guess ;) [17:20:04] brb [17:21:27] 6Mobile-Web: Can't bind events to Views - https://phabricator.wikimedia.org/T97077#1238730 (10bmansurov) I suppose the easiest way to solve the problem is not to bind events to the View, but to the View $el. Or maybe we should pass an events map option while instantiating a view, which is a cleaner solution in m... [17:21:41] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1238732 (10Jdlrobson) [17:21:59] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1238734 (10Jdlrobson) a:5MSyed>3None [17:22:28] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1183276 (10Jdlrobson) [17:22:44] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1183276 (10Jdlrobson) [17:23:20] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1183276 (10Jdlrobson) [17:23:40] (03PS4) 10BearND: [WIP] Link previews (prototype 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) (owner: 10Dbrant) [17:23:57] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1238741 (10Jdlrobson) [17:24:06] (03PS16) 10BearND: [WIP] Link previews (prototype 1) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [17:24:29] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1183276 (10Jdlrobson) [17:25:10] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Should be clear that collection is personal opinion - https://phabricator.wikimedia.org/T96931#1238744 (10Jdlrobson) [17:25:58] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Should be clear that collection is personal opinion - https://phabricator.wikimedia.org/T96931#1229678 (10Jdlrobson) [17:26:07] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Should be clear that collection is personal opinion - https://phabricator.wikimedia.org/T96931#1238747 (10Jdlrobson) a:5MSyed>3None [17:28:24] 10Gather, 10Gather Sprint G: If a user has collections, their last 3 collections show up on their mobile user profile - https://phabricator.wikimedia.org/T96226#1238758 (10Jdlrobson) [17:28:41] 10Gather, 10Gather Sprint G: If a user has collections, their last 3 collections show up on their mobile user profile - https://phabricator.wikimedia.org/T96226#1238759 (10Jdlrobson) a:3JKatzWMF [17:28:55] jdlrobson: gonna be a couple of minutes late to kickoff [17:29:03] plz start [17:29:03] joakino: k [17:29:16] 10Gather, 10Gather Sprint G: If a user has collections, their last 3 collections show up on their mobile user profile - https://phabricator.wikimedia.org/T96226#1211471 (10Jdlrobson) Design for this is unclear and needs discussion. Currently we only show last edit, last upload. Showing last 3 collections is a... [17:29:58] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1238771 (10Jdlrobson) Mock still needed.. [17:31:59] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1238785 (10KHammerstein) [17:32:07] 10Gather: Flow of cards in lists (of collections or items) is top down - https://phabricator.wikimedia.org/T97309#1238786 (10Jhernandez) [17:32:07] rmoen: http://hatjitsu.wmflabs.org/62281 < joakino [17:32:23] 10Gather: Discussion: Flow of cards in lists (of collections or items) is top down - https://phabricator.wikimedia.org/T97309#1238791 (10Jhernandez) [17:36:48] (03CR) 10MaxSem: [C: 032] "Umm, because copypasta?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [17:38:33] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1238831 (10bmansurov) > clean up dead rules, if any This is a good point. I think @jdlrobson was experimenting with it. He may be able to share his findings. And... [17:38:54] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1183276 (10Jdlrobson) [17:40:35] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1238841 (10KHammerstein) [17:41:54] 10Gather, 10Gather Sprint G: Collections (beta) invite via mobile panel - https://phabricator.wikimedia.org/T96286#1238844 (10MSyed) [17:45:22] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1238853 (10KHammerstein) [17:46:00] 10Gather, 10Gather Sprint G: Collections (beta) invite via mobile panel - https://phabricator.wikimedia.org/T96286#1238869 (10Jdlrobson) [17:46:36] 10Gather, 10Gather Sprint G, 6Mobile-Web: A logged in user who opts in to mobile web beta is in beta until they opt out. - https://phabricator.wikimedia.org/T97193#1238874 (10JKatzWMF) [17:47:32] 10Gather, 10Gather Sprint G, 6Mobile-Web: A logged in user who opts in to mobile web beta is in beta until they opt out. - https://phabricator.wikimedia.org/T97193#1238882 (10Jdlrobson) [17:47:34] 10Gather, 10Gather Sprint G: Collections (beta) invite via mobile panel - https://phabricator.wikimedia.org/T96286#1213325 (10Jdlrobson) [17:48:22] 10Gather, 10Gather Sprint G, 6Mobile-Web: A logged in user who opts in to mobile web beta is in beta until they opt out. - https://phabricator.wikimedia.org/T97193#1238890 (10Jhernandez) See mobile watchlist preferences. [17:48:33] 6Mobile-Web: Pre and post render functions on View should not take arguments - https://phabricator.wikimedia.org/T96269#1238894 (10bmansurov) a:3bmansurov [17:49:05] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1238910 (10KHammerstein) [17:50:11] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1211394 (10KHammerstein) [17:51:14] 10Gather, 10Gather Sprint G: Phone screen improvements on Adding to collection modal - https://phabricator.wikimedia.org/T96837#1238945 (10Jdlrobson) [17:54:27] (03Merged) 10jenkins-bot: Remove duplicated code for each prop in mobileview api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206654 (owner: 10Florianschmidtwelzow) [17:54:35] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when failing to read HTML for particular section from disk - https://phabricator.wikimedia.org/T96603#1238968 (10Fjalapeno) a:3Fjalapeno [17:56:47] 6Mobile-Web: bug - lead image should only be displayed on tablet when original image is minimum 768 px - https://phabricator.wikimedia.org/T97319#1238992 (10KHammerstein) 3NEW [18:00:18] vibha: heya! have a few minutes for design sign-off? [18:00:42] Hi Monte [18:01:39] Do you want to move anything you need to the design signoff column? [18:02:19] vibha: oh there are 3 cards there now: https://phabricator.wikimedia.org/tag/mobile-app-sprint-55-ios/ you may have to refresh the page [18:03:54] Perfect! [18:04:03] I'll look at this at 11:30 [18:04:44] vibha: perfect! [18:05:56] 10Gather, 10Gather Sprint G: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1239053 (10Jdlrobson) [18:07:13] bearND|food: hey! could you do a TWN sync for iOS after foods? hoping those new keys got a few translations over the weekend... :) [18:12:31] (03PS1) 10Bmansurov: Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) [18:13:39] back [18:13:42] ugh [18:14:26] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1239086 (10Jdlrobson) [18:15:57] 6Mobile-Web: Follow up with mobile team on instrumentation sampling rate (%50) - https://phabricator.wikimedia.org/T88363#1239092 (10phuedx) 5Open>3Resolved Looks that way to me… [18:16:18] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1239096 (10KLans_WMF) @Deskana we're through code review, QA signoff... [18:16:20] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1200176 (10Jdlrobson) [18:17:18] bearND|food: Alpha builds seem to be broken again. :-/ [18:17:22] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1239103 (10Jdlrobson) [18:17:52] Deskana: ok, will check soon [18:18:07] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1200176 (10Jdlrobson) [18:19:06] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1239119 (10KLans_WMF) [18:19:07] Deskana: do you mean downloading the build or some runtime issue? [18:19:07] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1200176 (10Jdlrobson) Maybe start using mw.notify? [18:19:36] niedzielski: We have a web service that builds an alpha APK from master every 30 or so minutes [18:19:36] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: When search returns no results no behaviour defined. - https://phabricator.wikimedia.org/T95966#1239129 (10Jdlrobson) [18:19:37] niedzielski: http://android-builds.wmflabs.org/ [18:19:47] niedzielski: As you can see, it apparently hasn't built one for 4 days. [18:19:51] (03PS1) 10Bgerstle: add assertion macros [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206858 [18:20:28] coreyfloyd: ^ mhurd would 'preciate a review so i can use it in upcoming crash fixes [18:20:34] have 1:1 in a bit so might not respond immediately [18:20:39] Deskana: hm, ok. i was wondering if you meant just the download was busted because i've had a weird issue on at least two devices where the apk cannot be installed. i think it's something with my devices but i'm not sure. in the past, i've had trouble with a similar download via hockeyapp [18:20:46] bgerstle: k checking... [18:21:06] also, TIL how to test that assertions are thrown :-) [18:21:11] Good evening! [18:21:15] (not that you should normally do that) [18:21:43] I have a MediaWiki installation on which I have the Language Extension Bundle + the Mobile Frontend extension. [18:21:50] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: When search returns no results no behaviour defined. - https://phabricator.wikimedia.org/T95966#1239141 (10Jdlrobson) [18:22:02] bmansurov: got a second to chat through the wikigrok thing? [18:22:09] I would like to have a interface language selector within the mobile view of the wiki. Folks over #mediawiki have suggested that this might be a good place to ask about this. [18:22:25] Is there one such thing already available, or do I have to write it from scratch? [18:22:46] 10Gather, 10Gather Sprint G: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1239157 (10Jdlrobson) a:3MSyed [18:22:59] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Limit the filesystem cache size of Picasso library. - https://phabricator.wikimedia.org/T89834#1239159 (10KLans_WMF) [18:23:20] phuedx: 5mins, getting something to eat before the meeting [18:23:28] 10Gather, 10Gather Sprint G: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1237425 (10Jdlrobson) [18:23:50] bmansurov: we can chat after -- but i'm no longer sure about a complete rollback [18:24:07] need to make sure jkatz knows what that means (ui is olde etc) [18:24:40] niedzielski: Strange, I've never had that issue myself. I've had issues where I end up with out-of-date APKs on my device though. [18:26:22] 10Gather, 10Gather Sprint G: If a user has collections, their last 3 collections show up on their mobile user profile - https://phabricator.wikimedia.org/T96226#1239179 (10MSyed) {F157807} [18:26:27] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1239180 (10KLans_WMF) [18:26:55] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Hook app up to experimental content service to test the service's viability - https://phabricator.wikimedia.org/T91798#1239182 (10KLans_WMF) [18:27:46] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 7Epic: EPIC: As a Mobile Apps Team, I would like to be alerted when something is going catastrophically wrong with the app in production, so we can fix it for our users (Monitoring/Alerting) - https://phabricator.wikimedia.org/T95019#1239183 (10KLans_WMF) [18:28:13] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android, 3Mobile-App-Sprint-56-iOS: EPIC: As a mobile reader, I would like links that I tap on to show quick previews so that I can choose whether to navigate to it or not. - https://phabricator.wikimedia.org/T94630#1239184 (10KLans_WMF) [18:28:32] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1239188 (10KLans_WMF) [18:28:56] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: IllegalStateException: Recursive entry to executePendingTransactions from page.gallery.GalleryActivity.onBackPressed - https://phabricator.wikimedia.org/T94726#1239191 (10KLans_WMF) [18:29:14] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1239193 (10KLans_WMF) [18:29:21] 10Gather, 10Gather Sprint G: If a user has collections, their last 3 collections show up on their mobile user profile - https://phabricator.wikimedia.org/T96226#1239194 (10Jdlrobson) [18:29:24] phuedx: ok sure [18:32:01] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1239207 (10Deskana) Works for me! [18:32:09] 10Gather, 10Gather Sprint G: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1239208 (10Jdlrobson) [18:32:18] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Editing block warning appears only after i tried to save (for not-logged-in users) - https://phabricator.wikimedia.org/T96257#1239209 (10phuedx) 5Open>3Resolved [18:32:23] 10Gather Sprint G, 5Patch-For-Review: Render CollectionListItem with templates - https://phabricator.wikimedia.org/T97284#1239211 (10Jdlrobson) [18:32:49] 10Gather, 10Gather Sprint G, 5Patch-For-Review: Provide infrastructure for Gather desktop beta feature - https://phabricator.wikimedia.org/T97084#1239216 (10Jdlrobson) [18:32:57] 10Gather, 10Gather Sprint G, 5Patch-For-Review: API: Provide a way to combine prefixsearch results with knowledge of whether they are in a given collection - https://phabricator.wikimedia.org/T95516#1239217 (10Jdlrobson) [18:33:04] 10Gather, 10Gather Sprint G, 5Patch-For-Review: API: support automatic and manual images - https://phabricator.wikimedia.org/T93912#1239218 (10Jdlrobson) [18:33:32] joakino: rmoen any thoughts on G? [18:33:37] mhurd: hey! [18:33:38] G unit [18:33:55] YuviPanda: yo! [18:33:59] jdlrobson: i can just think of Gonads [18:34:05] lolz [18:34:05] mhurd: did you end up paying for IRCCloud? [18:34:35] 10Gather, 10Gather Sprint G: Discussion: Flow of cards in lists (of collections or items) is top down - https://phabricator.wikimedia.org/T97309#1239224 (10Jdlrobson) [18:34:37] YuviPanda: not yet, still using but just checking it often enough that it doesn't disconnect [18:34:37] mhurd: I just became admin on the wikimedia org account on irccloud and can hand out accounts. wanted to see if you wanted to be ‘onboarded’ so I can document the process as well :) [18:34:44] mhurd: ah! [18:34:58] mhurd: would you like a WMF account? :) Always connected! [18:35:01] YuviPanda: oh yea! [18:35:05] 10Gather, 10MediaWiki-Database, 7database: Bug: DB gather_list.gl_id autonumber is always odd - https://phabricator.wikimedia.org/T94512#1239226 (10Jdlrobson) [18:35:06] jdlrobson: gather giraffes [18:35:13] mhurd: I’m in a meeting, let me do this right after? [18:35:23] 10Gather, 10MediaWiki-Database, 7database: Bug: DB gather_list.gl_id autonumber is always odd - https://phabricator.wikimedia.org/T94512#1165433 (10Jdlrobson) @tgr any ideas around this? [18:35:30] YuviPanda: sounds great! [18:35:32] YuviPanda: thanks! [18:35:37] mhurd: yw [18:35:40] jdlrobson: gather grumpy comments [18:36:00] 10Gather, 10Gather Sprint G: Flag icon shows on watchlist and other private collections - https://phabricator.wikimedia.org/T97300#1239236 (10Jdlrobson) [18:36:09] 10Gather, 10Gather Sprint G: No link to my collection in Echo notification - https://phabricator.wikimedia.org/T97177#1239237 (10Jdlrobson) [18:36:44] JonKatz: https://phabricator.wikimedia.org/tag/gather_sprint_forward/ can you take a look at sign off colum and create tasks for anything that's not done? [18:36:57] Gather Sprint Gather [18:37:02] MINDBLOWN [18:37:27] jdlrobson: lol [18:37:39] gather great gifs [18:37:55] or we could actually come up with a real naming convention [18:38:05] jdlrobson: yea we need a topic [18:38:17] we've done animals and movies [18:38:30] seriously, we already lost background images, that was not fun, we can't not have a topic [18:39:07] jdlrobson: songs? [18:39:32] singers? actors? [18:39:39] fruits? [18:39:51] superheroes [18:39:56] dinosaurs [18:39:59] cities [18:40:08] video game characters [18:40:49] hey! [18:41:50] Deskana: Why do you think the alpha build is broken? The last successful build was on 4/23, which concides with the last merge. [18:41:59] bearND: Oh. My bad. [18:42:27] Deskana: no worries. Was just wondering if I messed anything [18:42:30] missed [18:42:36] lol [18:42:47] jdlrobson: poll? [18:43:12] For fuck sake, I said hi. [18:43:13] joakino: https://en.wikipedia.org/wiki/List_of_Linux_kernel_names [18:43:27] (03CR) 10Jdlrobson: [C: 031] "needs testing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [18:43:38] such as: [18:43:42] Flesh-Eating Bats with Fangs[36][37] [18:43:42] hi kikero? [18:43:53] haha [18:44:00] lol YuviPanda [18:44:12] > Hurr durr I'ma sheep[58] (Internet poll) [18:44:15] YuviPanda: we wouldn't have for all the letters on the abc [18:44:16] 6Mobile-Web, 3Mobile-Web-Sprint-46-T________: Place category tags on pages that have been identified as having that property, per T94732 - https://phabricator.wikimedia.org/T94753#1239256 (10KLans_WMF) [18:44:24] still [18:44:33] ye haha [18:44:37] kikero: Konnichiwa! [18:45:07] hi [18:45:39] Gather Sprint Gonzo [18:45:46] 6Mobile-Web, 10MobileFrontend, 10MediaWiki-API, 3Mobile-Web-Sprint-46-T________: (2) Update API query continuation usage for future change of default - https://phabricator.wikimedia.org/T96866#1239266 (10KLans_WMF) [18:46:03] 6Mobile-Web, 3Mobile-Web-Sprint-46-T________: (5) Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1239268 (10KLans_WMF) [18:46:19] konbanwa, jdlrobson-san [18:46:19] 6Mobile-Web, 3Mobile-Web-Sprint-46-T________: (3) Create a special page for tags - https://phabricator.wikimedia.org/T96015#1239274 (10KLans_WMF) [18:46:29] jdlrobson, did we decide? I feel like we should come up with a good one for this sprint as the potential for amazing illeteration / pun integration is huge. [18:47:12] 6Mobile-Web, 10Analytics: Instrument “tags” and anonymous gather pages to track engagement with browse. - https://phabricator.wikimedia.org/T94744#1239278 (10phuedx) Requires a schema, which requires a list of user actions that we want to track. [18:47:26] i'm so tired of wikibugs... is there any osx irc client that lets you filter messages based on regex/ [18:47:27] ? [18:47:37] I was wondering is there any support for the Extension:UniversalLanguageSelector in the Mobile Frontend interface? [18:47:44] rmoen: jdlrobson: i'm making a poll to choose a topic for sprint names [18:48:07] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: When search returns no results no behaviour defined. - https://phabricator.wikimedia.org/T95966#1239285 (10Jdlrobson) a:5MSyed>3None [18:49:08] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1239291 (10Jdlrobson) a:5KHammerstein>3None [18:49:15] joakino: limechat [18:49:30] ori: that's what I use! [18:49:33] kikero: nothing explicit that i know of. [18:49:53] 6Mobile-Web, 3Mobile-Web-Sprint-46-T________: (1) Link tagged categories (T94739) on article pages to anonymously created gather lists (T94714) for that property. - https://phabricator.wikimedia.org/T94742#1239294 (10KLans_WMF) [18:49:54] the team working on it hasn [18:49:57] ori: any link on how? [18:50:03] 't reached out to us in any way to get it working on mobile [18:50:59] vibha: see my update on https://phabricator.wikimedia.org/T96068 [18:51:15] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#1239298 (10Mholloway) So there are a few different pieces to this and I'm wondering if we should make separate cards or just re-title this one to something like "handle image maps... [18:52:49] 10Gather, 10Gather Sprint G: API: Inconsistent response for empty collections - https://phabricator.wikimedia.org/T95741#1239303 (10Jdlrobson) [18:52:59] 10Gather, 10Gather Sprint G: API: Inconsistent response for empty collections - https://phabricator.wikimedia.org/T95741#1199168 (10Jdlrobson) [18:53:53] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: The introduction for 'Save Pages' does not go away even if you switch articles. - https://phabricator.wikimedia.org/T96606#1239308 (10Vibhabamba) The message dismisses now. thanks. [18:53:57] 10Gather, 10Gather Sprint G: API: Inconsistent response for empty collections - https://phabricator.wikimedia.org/T95741#1239309 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=json&prop=pageimages&piprop=thumbnail&pithumbsize=120&pilimit=50... [18:54:02] 10Gather, 10Gather Sprint G: API: Inconsistent response for empty collections - https://phabricator.wikimedia.org/T95741#1239313 (10Jdlrobson) [18:54:26] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#1239316 (10bearND) @Mholloway Is #1 already handled by T94646? I think if two out of three issues are trivial then it's ok to keep everything in the same card (and no need to make... [18:54:28] rmoen: joakino: anything you need from me before i head into office [18:54:49] jdlrobson: i'm heading out! [18:54:50] 6Mobile-Web, 3Mobile-Web-Design: Find another/a better place for secondary actions - https://phabricator.wikimedia.org/T97048#1239317 (10KHammerstein) Design I've been working on that includes tags, page-secondary actions, and related articles. {F157812} [18:55:06] (03PS1) 10Fjalapeno: Fix T96603 - wrapping section html creation in an exception handler. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206864 [18:55:07] have a nice day jdlrobson rmoen [18:55:19] it was very nice to see all faces and no mothership on the previous meeting [18:55:31] seriously [18:55:52] 6Mobile-Web, 3Mobile-Web-Sprint-46-T________: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1239326 (10KLans_WMF) [18:56:10] joakino: very nice to see your face too. Mothership? [18:56:13] 6Mobile-Web, 3Mobile-Web-Sprint-46-T________: Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1239328 (10KLans_WMF) [18:56:27] 6Mobile-Web, 10MobileFrontend, 10MediaWiki-API, 3Mobile-Web-Sprint-46-T________: Update API query continuation usage for future change of default - https://phabricator.wikimedia.org/T96866#1239332 (10KLans_WMF) [18:56:51] rmoen: you know, SF meeting room vs scattered forgotten remote employees [18:57:27] joakino: ahh right. [18:57:28] 6Mobile-Web, 10Performance-Metrics-Dashboard, 3Mobile-Web-Sprint-46-T________: (3) Create a mobile site speed dashboard - https://phabricator.wikimedia.org/T95300#1239335 (10KLans_WMF) [18:57:29] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1239337 (10Vibhabamba) Agree with @deskana that the first steps are here and it wo... [18:57:45] 6Mobile-Web, 10Performance-Metrics-Dashboard, 3Mobile-Web-Sprint-46-T________: Create a mobile site speed dashboard - https://phabricator.wikimedia.org/T95300#1239338 (10KLans_WMF) [18:57:46] thanks bearND [19:00:13] bearND: Is there a new apk file on that phab task? [19:00:34] vibha: no, but I can upload one if the screenshots look ok to you [19:02:03] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Imagemap does not fit the screen - https://phabricator.wikimedia.org/T87066#1239340 (10Mholloway) @bearND Yes, resizing the image map to fit the screen (the current card title) definitely falls within T94646. #2 and #3 are separate (but I agree, can be h... [19:03:22] 6Mobile-Web, 3Mobile-Web-Design: Find another/a better place for secondary actions - https://phabricator.wikimedia.org/T97048#1239365 (10Florian) But categories and talk/discussion is still missing, and if we add it in the list under "share article" e.g. it still looks too much? [19:03:28] joakino: +1 [19:04:38] bearND: mholloway do you guys use the google talk functionality in gmail or is it safe to turn this off? [19:05:03] niedzielski: no, we just use hangout [19:05:16] bearND: cool thanks [19:05:39] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1239367 (10Jdlrobson) I've made some sub tasks but there are various other problems here : * Non-generalised css rules (I'm working on this) * Styles from desktop... [19:06:04] 6Mobile-Web, 3Mobile-Web-Design, 3Mobile-Web-Sprint-46-T________: (5) On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1239368 (10KHammerstein) [19:06:11] 6Mobile-Web, 3Mobile-Web-Design, 3Mobile-Web-Sprint-46-T________: On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1239369 (10KLans_WMF) [19:06:14] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1239374 (10Fjalapeno) a:3Fjalapeno [19:06:46] (03CR) 10Bgerstle: [C: 031] "see comment about adding an assertion. also, how hard would it be to actually prompt the user w/ an alert that has a button which refreshe" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206864 (owner: 10Fjalapeno) [19:06:48] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1239376 (10bearND) Just uploaded; here: {F157820} [19:06:51] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1239377 (10KLans_WMF) @bmansurov ^^ [19:06:52] vibha: ^ [19:06:59] vibha: https://phabricator.wikimedia.org/T96068 [19:07:28] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Only load mobile.pagelist.styles when necessary - https://phabricator.wikimedia.org/T97326#1239379 (10Jdlrobson) 3NEW a:3Gilles [19:08:37] 6Mobile-Web, 10MobileFrontend, 6Performance-Team: skins.minerva.drawers.styles should be moved into mobile.drawers - https://phabricator.wikimedia.org/T97327#1239388 (10Jdlrobson) 3NEW a:3Gilles [19:12:14] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1239401 (10JKatzWMF) [19:13:50] 6Mobile-Web: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1239404 (10bmansurov) [19:14:43] 6Mobile-Web, 3Mobile-Web-Design, 3Mobile-Web-Sprint-46-T________: On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1239405 (10bmansurov) [19:15:47] mhurd: \o/ welcome [19:16:16] 6Mobile-Web, 3Mobile-Web-Sprint-46-T________: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1214411 (10KLans_WMF) [19:16:34] 6Mobile-Web, 3Mobile-Web-Sprint-46-T________: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1214411 (10KLans_WMF) [19:16:36] YuviPanda: woohoo! [19:20:59] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Crash when reading incomplete section list from disk - https://phabricator.wikimedia.org/T96597#1239416 (10BGerstle-WMF) 5Open>3Resolved This was probably fixed by the patch for T96253 and should be out in 4.1.2. Since it hasn't resurfaced in the latest versi... [19:22:03] 6Mobile-Web, 10MobileFrontend, 10MediaWiki-API: Update API query continuation usage for future change of default - https://phabricator.wikimedia.org/T96866#1239425 (10KLans_WMF) [19:24:29] vibha: i had to delete and re-install the irc cloud app to get it to work with my wikimedia acct... [19:24:51] https://etherpad.wikimedia.org/p/T_movie [19:25:04] yes, jdlrobson I spent a bunch of time a few that I couldn't verify last night, but will try again today. [19:25:57] https://en.wikipedia.org/wiki/List_of_films:_T [19:29:07] kristenlans: hey! I’ve IRCCloud accounts to hand out to WMF staff, so let me know if you / anyone in your team wants one :) [19:31:27] JonKatz: ping pong [19:31:37] phuedx hey [19:34:21] JonKatz: got a sec to hangout? [19:34:54] phuedx literally in meetings until 3pm PT [19:34:57] :/ [19:36:04] Deskana: https://phabricator.wikimedia.org/project/sprint/profile/1215/ [19:36:53] YuviPanda: woohoo! [19:37:33] Haha [19:38:49] I don't know who you are. I don't know what you want. If you are looking for ransom, I can tell you I don't have money. But what I do have are a very particular set of skills, skills I have acquired over a very long career. Skills that make me a nightmare for people like you. If you let my product manager go now, that'll be the end of it. I will not look for you, I will not pursue you. But if you don't, I [19:38:49] will look for you, I will find you, and I -2 your patches. [19:40:12] hey mobile people! Who knows about the redirect at https://m.wikipedia.org? [19:47:00] dr0ptp4kt: do you know where the code for m.wikipedia.org lives? [19:50:59] YuviPanda: i can haz irccloud? [19:52:38] YuviPanda: in meeting. which part? m.wikipedia.org/ webroot? [19:52:46] dr0ptp4kt: ya [19:52:54] joakino: comin up. what’s your @wikimedia email? [19:53:10] look for mobilelanding.php in wmf-config / mediaiwki-config stuff. yurik can fill in on some of the other fun details of that file [19:54:33] ah cool thanks :) [19:54:55] YuviPanda, ta :). We should grab yurik then. [19:54:59] Because this needs a patch :/ [19:55:11] YuviPanda: jhernandez@wikimedia.org [19:55:38] * yurik hides from dr0ptp4kt and Ironholds [19:56:03] * yurik hides from YuviPanda as well [19:56:23] yurik, that's nice. https://m.wikipedia.org [19:56:30] it redirects to the english-language mobile main page. Why? [19:56:40] * yurik was lazy [19:56:41] joakino: sent [19:56:46] thx YuviPanda [19:56:54] joakino: https://office.wikimedia.org/wiki/Office_IT/IRCCloud is nascent documentation. edit as you see fit? [19:56:59] Ironholds, either that, or i simply copy/pasted varnish behaviour :) [19:57:15] yurik, okay. Could you patch that, please? Either (a) adding language detection or (b) pointing to the actual www.wikipedia.org? [19:57:35] Ironholds, i would love to, but no spare cycles at all - 3 projects at the same time :( [19:57:38] because it's pretty problematic to have the platform we talk about as increasing user diversity have a baseline of "we're only interested in diversity that speaks English" [19:57:52] and yes, totally agree [19:57:54] okay. I'll bring it up with Tomasz and Wes in my meeting on Friday and we'll work it into the high-priority early tasks for Search & Discovery [19:57:57] let’s redirect to https://www.wikipedia.org/ - it’s actually quite responsive [19:57:58] it should be fairly easy fix [19:58:04] yeah, exactly [19:58:10] like, we've been talking about low-hanging fruit? [19:58:13] this is low-hanging fruit. [19:58:17] the actual code lives in Zero [19:58:22] it..what? [19:58:33] We have Zero code that hits non-zero users? [19:58:46] (1) fix language pointer, (2) fix up actual www.wikipedia.org. It's a two-step plan. [19:58:47] Ironholds, zero decides if it should be redirected based on zero, and if not, redirect to default [19:58:52] ahhhh [19:58:55] that makes sense [20:00:34] > // Staying consistent with the current behaviour - redirect to en.*.* [20:00:34] $langCode = 'en'; [20:00:36] Ironholds: ^ [20:00:37] :) [20:00:50] YuviPanda, want me to just patch it? :P [20:00:59] Ironholds: sure, but it’s a bit messy... [20:01:03] and shouldn’t break zero [20:01:05] okay. Want to patch it? :D [20:01:15] also does other things like [20:01:16] // For zero.wikipedia.org, remove forceHTTPS cookie and user state [20:01:41] eeee [20:01:45] okay, let's add that to the pile [20:02:25] Ironholds: it’s on Zero’s roadmap, they need to switch providers to IP based whitelisting rather than URL based before they can stop doing that... [20:02:51] YuviPanda, yeah, but I'd rather get it done sooner than later. [20:03:09] and the way I figure it's probably most quickly achieved by having the team that has yurik and is looking for quick fixes do it :D [20:05:30] Ironholds: yeah. I am going to bail on that. [20:06:17] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1239470 (10bmansurov) @dr0ptp4kt, we are trying to track search events on mobile and were wondering whether we should alter the existing Schema:Search [1] that the des... [20:07:48] YuviPanda, okie :). [20:07:56] Ironholds: sorry! [20:08:03] Ironholds, if you tell me that i should simply redirect to www.wikipedia.org instead of m.wikipedia.org, that's at line 956 in file PageRendering.php (zerobanner) [20:08:17] i will have to modify that code, fairyl simple [20:09:02] yurik, that'd be ideal, but I ain't telling anyone anything; I just do research ;p. Like you said, you're busy right now, so let's formally put it on the S&D plate so that you or someone else can pick it up in a few days as a scheduled task. [20:09:20] if you've got the time I'd love to see it patched now but I understand you've got stuff to work on (this transition appears to be a living hell for absolutely everyone) [20:13:17] bearND: so, the current Beta version is the release candidate for Production, correct? [20:14:13] dbrant: yes, (as always minus the feature flagged stuff) [20:14:23] cool, just checking [20:15:09] dbrant: I've built the apk last Thursday and sent it to the testers [20:15:31] heading out for the night [20:15:50] phuedx: are you batman? [20:16:34] dbrant: I've made some more changes to prototype 1, see https://phabricator.wikimedia.org/T96068 [20:17:39] dbrant: not sure what vibha's feedback is. Do you want to take over prototype 2 again, and further changes of prototype 1 if neccessary? [20:18:37] bearND: yep, absolutely. It's back to business for me. [20:21:01] kristenlans: able to talk at 1:50? [20:21:23] kristenlans: i'll also of course be at the 2 pm (5 pm eastern) meeting [20:21:49] kristenlans: wanted to follow up on the previous meeting - i think you were saying you wanted to talk with me a bit more? [20:22:35] 10Wikipedia-Android-App: performance: the nearby API query requests info that it doesn't use. - https://phabricator.wikimedia.org/T97276#1239565 (10bearND) @Spage Thanks! Good point. That looks like an easy fix. [20:22:45] 10Wikipedia-Android-App, 7Easy: performance: the nearby API query requests info that it doesn't use. - https://phabricator.wikimedia.org/T97276#1239566 (10bearND) [20:24:12] joakino: just did a reject on the mobile-tech message. would you please confirm that the autoresponder notifies you on that? basically, it's supposed to say use reading-wmf [20:26:46] 3Gather Sprint Forward, 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1239579 (10Jdlrobson) 5Open>3Resolved \o/ https://integration.wikimedia.org/ci/view/Mobile/... [20:33:04] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: 4.1.1(76) - clicking links in offline mode saved them in Recent - https://phabricator.wikimedia.org/T95585#1239595 (10BGerstle-WMF) a:3BGerstle-WMF [20:34:04] (03Abandoned) 10Fjalapeno: Chsnge hockey key [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206489 (owner: 10Fjalapeno) [20:34:24] (03CR) 10Jdlrobson: [C: 04-1] "In beta whilst anon I get some Gather related errors with this patch. They are not present on master." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [20:37:31] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1239609 (10rmoen) a:3rmoen [20:37:53] (03CR) 10Jdlrobson: [C: 031] Fix for edit header message format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) (owner: 10Florianschmidtwelzow) [20:41:26] (03PS11) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [20:41:28] rmoen I want to sign off on https://phabricator.wikimedia.org/T94802 but can't get it to trigger on wmflabs [20:41:31] (03CR) 10Jdlrobson: Hygiene: Create anchor abstraction (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [20:43:43] 6Mobile-Web, 3Mobile-Web-Design, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1239614 (10bmansurov) a:3bmansurov [20:47:44] jdlrobson: do you have a quick minute to chat about special init? Thinking of ways to refactor this and a couple of questions came up. [20:48:10] 10Wikipedia-Android-App: App Icons Should Use Mipmap Folder Hierarchy - https://phabricator.wikimedia.org/T97239#1239631 (10bearND) p:5Triage>3Normal [20:48:36] JonKatz: Just reading your msg. sorry didn't ping me as I was rmoen_lunch at the time [20:49:38] JonKatz: I will test on beta labs [20:49:49] 10Wikipedia-Android-App: Margins and default type size on Android need to be increased. - https://phabricator.wikimedia.org/T96719#1239650 (10Vibhabamba) @bearND @kaityhammerstein is working on this. Assigning the ticket to her so she can provide details for this on Mobile and Tablet. [20:49:59] 10Wikipedia-Android-App: Margins and default type size on Android need to be increased. - https://phabricator.wikimedia.org/T96719#1239653 (10Vibhabamba) a:5bearND>3KHammerstein [20:50:01] 6Mobile-Web: Menu items should not be underlined on hover - https://phabricator.wikimedia.org/T97336#1239655 (10bmansurov) 3NEW [20:50:24] (03CR) 10Jdlrobson: [C: 04-1] "I'm a bit concerned about introducing bold and italic given VisualEditor doesn't add these anymore...and they probably had good reason not" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194945 (https://phabricator.wikimedia.org/T91752) (owner: 10Florianschmidtwelzow) [20:50:31] rmoen: sure [20:50:42] what's up [20:52:03] so been thinking about ways to make special/init.js better. and with https://phabricator.wikimedia.org/T95214 it may only get more messy [20:52:27] jdlrobson: Was thinking maybe it should be a view. do you have any ideas about how this could be done? [20:53:12] rmoen: ext.gather.special/init.js ? [20:53:16] yeah [20:53:33] yeh you could have new FlagButton({ [20:53:43] and move event binding into it. That would make a lot of sense [20:53:45] Yeah, which brings me to my next question [20:53:59] Do we have a button view ? [20:54:03] yes [20:54:05] besides buttonwithspinner [20:54:07] hot off the press [20:54:11] got merged friday [20:54:12] thanks rmoen! [20:54:12] woot [20:54:24] but obviously if use it set the dependency [20:54:26] JonKatz: getting an error on beta labs while registering a test account [20:54:28] so we can manage deployments [20:54:32] (in commit message) [20:54:41] JonKatz: did you get an echo notification? [20:54:43] jdlrobson: yeah [20:55:11] rmoen huh...that's a bummer. I did not jdlrobson. I hid my own collection and did not receive one. also did same by unhiding another colleciton of mine. [20:55:19] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1239681 (10Vibhabamba) @bearND thank you. [20:55:39] JonKatz: Haven't tested hiding my own collection yet. [20:56:11] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Adjust link preview prototype 1 - https://phabricator.wikimedia.org/T96068#1239688 (10bearND) a:5bearND>3Dbrant [20:56:37] 10Wikipedia-Android-App: Dev Builds Require Dev Launcher Icon and Title Suffix - https://phabricator.wikimedia.org/T97238#1239690 (10bearND) We should also use a different application id if we plan to really use the dev flavor, so that it can be installed in side-by-side with the other flavors. That change would... [20:56:43] JonKatz: though i cannot see why that would be an issue. I guess that could be default echo behavior? ( not to send if you are the invoker ) [20:57:11] just a guess [20:57:16] 10Wikipedia-Android-App: Dev Builds Require Dev Launcher Icon and Title Suffix - https://phabricator.wikimedia.org/T97238#1239694 (10bearND) p:5Triage>3Low [20:58:03] 10Wikipedia-Android-App, 7Easy: performance: the nearby API query requests info that it doesn't use. - https://phabricator.wikimedia.org/T97276#1239705 (10bearND) p:5Low>3Normal [20:58:19] vibha: do you want images enlarged on the main page as well, or only in articles? [21:00:49] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: Reuse image caption from the article in the image gallery, to increase continuity between article and image gallery - https://phabricator.wikimedia.org/T94495#1239710 (10Vibhabamba) @pginer said that Mark Holmquist, Gilles or Gergo... [21:00:50] 10Wikipedia-Android-App: No In-App Feedback Mechanism - https://phabricator.wikimedia.org/T97237#1239712 (10bearND) 5Open>3declined a:3bearND Before we do that we need to make sure we have the capacity to handle the amount of feedback. This is currently done by two volunteers. [21:03:10] 10Gather, 10Gather Sprint G, 3Mobile-Web-Design: Should be clear that collection is personal opinion - https://phabricator.wikimedia.org/T96931#1239719 (10Jdlrobson) a:3Jdlrobson [21:04:57] 10Wikipedia-iOS-App: Testing Page issues and disambiguation templates(T90250) - https://phabricator.wikimedia.org/T97151#1239725 (10Etonkovidova) [21:05:05] 10Gather Sprint G: ContentOverlay interface has changed - https://phabricator.wikimedia.org/T97338#1239729 (10Jdlrobson) 3NEW [21:05:14] 10Gather Sprint G: ContentOverlay interface has changed - https://phabricator.wikimedia.org/T97338#1239737 (10Jdlrobson) a:3Jdlrobson [21:05:21] (03PS5) 10Jdlrobson: Reflect some upstream changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203229 (https://phabricator.wikimedia.org/T97338) [21:07:01] (03CR) 10Jdlrobson: "Also changes urls to" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) (owner: 10Jhernandez) [21:07:57] (03CR) 10Florianschmidtwelzow: "> I'm a bit concerned about introducing bold and italic given VisualEditor doesn't add these anymore...and they probably had good reason n" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/194945 (https://phabricator.wikimedia.org/T91752) (owner: 10Florianschmidtwelzow) [21:09:47] 10Wikipedia-Android-App: Dev Builds Require Dev Launcher Icon and Title Suffix - https://phabricator.wikimedia.org/T97238#1239748 (10Niedzielski) I believe the dev app ID is currently `org.wikipedia.zzz` but it seems to be shared with the customChannel build? It should probably be changed from `.zzz` to `.dev`.... [21:13:57] bearND: I synced up @dbrant and I have your latest proto. [21:13:58] thanks [21:14:09] i have a quick question for you. can we hangout for 2 mts? [21:14:23] 10Wikipedia-Android-App: Page Refresh Icon Is Not Antialiased - https://phabricator.wikimedia.org/T97236#1239766 (10KLans_WMF) p:5Triage>3Low [21:15:05] bearND: (lmk if you need help with triaging anything) [21:17:49] 10Wikipedia-Android-App: Tapping the Username in the Menu Should Go to The User Page - https://phabricator.wikimedia.org/T97234#1239781 (10KLans_WMF) p:5Triage>3Normal [21:18:54] (03CR) 10Dbrant: [C: 04-1] "Technically this works just fine; however, we use URLDecoder.decode() in quite a few places, and in each instance we need to do a useless" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206625 (https://phabricator.wikimedia.org/T97200) (owner: 10Deskana) [21:20:27] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Productize link preview prototype code - https://phabricator.wikimedia.org/T97150#1239790 (10Dbrant) a:3Dbrant [21:23:19] 10Wikipedia-Android-App: Formulas in an img description presented incorrectly in the Image Gallery - https://phabricator.wikimedia.org/T97197#1239801 (10KLans_WMF) [21:23:21] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: Reuse image caption from the article in the image gallery, to increase continuity between article and image gallery - https://phabricator.wikimedia.org/T94495#1165109 (10KLans_WMF) [21:25:26] (03PS1) 10Jdlrobson: Make it clearer collections are personal opinion [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206963 (https://phabricator.wikimedia.org/T96931) [21:27:02] 10Wikipedia-Android-App: Add image ordering to apps content service, and use it in image gallery, so that images are always in order in the gallery - https://phabricator.wikimedia.org/T86954#1239830 (10KLans_WMF) [21:27:03] 10Wikipedia-Android-App: Clicking on File:Stone of scone replica 170609.jpg does not allow to flip forward in the Image Gallery - https://phabricator.wikimedia.org/T97194#1239829 (10KLans_WMF) [21:27:22] 10Wikipedia-Android-App: Clicking on File:Stone of scone replica 170609.jpg does not allow to flip forward in the Image Gallery - https://phabricator.wikimedia.org/T97194#1239831 (10KLans_WMF) p:5Triage>3Low [21:30:36] Hi. Someone please set a start date for the project "Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story" in Phabricator so that https://phabricator.wikimedia.org/project/sprint/ does not break. Thanks. [21:30:59] (03CR) 10Dbrant: [C: 032] Fix DoEditTask related tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206293 (owner: 10BearND) [21:32:46] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: 4.1.0.2 - some symbols displayed as empty squares - https://phabricator.wikimedia.org/T97078#1239849 (10KLans_WMF) [21:32:47] 10Wikipedia-Android-App: Bundle fonts for languages that are not supported natively. - https://phabricator.wikimedia.org/T71184#1239850 (10KLans_WMF) [21:33:15] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: 4.1.0.2 - some symbols displayed as empty squares - https://phabricator.wikimedia.org/T97078#1239852 (10KLans_WMF) p:5Triage>3Normal [21:33:22] 10Wikipedia-Android-App: Bundle fonts for languages that are not supported natively. - https://phabricator.wikimedia.org/T71184#1239854 (10KLans_WMF) p:5Triage>3Normal [21:38:18] 10Wikipedia-Android-App: Margins and default type size on Android need to be increased. - https://phabricator.wikimedia.org/T96719#1239866 (10KLans_WMF) p:5Triage>3Normal [21:38:50] dbrant: hey. stupid question: when debugging the webview via chrome, is there a mechanism for reloading the page for javascript changes? right now i'm doing it manually by pulling down on the top of the app. [21:40:14] niedzielski: hmm, good question actually... not that I'm aware of. ^ bearND? [21:40:41] niedzielski: anything specific you're trying to track down? [21:41:50] 10Wikipedia-Android-App, 10Wikipedia-iOS-App: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1239878 (10bearND) @Vibhabamba Should we have the gray background that desktop has? [21:42:51] dbrant: i can reload on the desktop browser but that just pulls in the unmodified content from file:///android_asset/bundle.js. many articles are long, so the quickest way to see my changes is to slide out the right hand menu, tap the article title, then pull to refresh. it's just a bit of a drag (no pun intended). really just trying to get my workflow down. [21:43:45] niedzielski: yeah, that's the way i've done it [21:43:57] dbrant: ok cool. thanks [21:47:22] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1239890 (10KLans_WMF) p:5Normal>3High [21:48:38] (03PS1) 10Bgerstle: prevent storing article titles that fail to load in history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206970 (https://phabricator.wikimedia.org/T95585) [21:49:04] coreyfloyd: mhurd can haz review plz ^ [21:49:12] i can do unit tests later tonight or tomorrow [21:49:27] i tested it on iPad sim running iOS 7 [21:49:37] bgerstle: sure - will look - let me try and stitch mine up real quick [21:49:39] shouldn't vary based on device/OS though [21:50:23] (03PS2) 10Bgerstle: prevent storing article titles that fail to load in history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206970 (https://phabricator.wikimedia.org/T95585) [21:50:49] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: A user is notified when their collection has been hidden or unhidden - https://phabricator.wikimedia.org/T94802#1239915 (10JKatzWMF) 5Open>3Resolved [21:51:47] (03PS1) 10Robmoen: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 [21:52:17] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Wikimedia-Hackathon-2015, 5Patch-For-Review: Add watchlist to app - https://phabricator.wikimedia.org/T76953#1239921 (10KLans_WMF) p:5Normal>3Low [21:53:31] (03CR) 10jenkins-bot: [V: 04-1] Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen) [21:55:35] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1239934 (10Vibhabamba) @bearND - Thanks for checking. No grey background or bounding boxes are require... [21:56:35] dbrant: Hey! I had a question about your feedback on this: https://gerrit.wikimedia.org/r/#/c/206625/ [21:56:41] gwicke: i'm going to set a meeting for a group of engineers to discuss api and services stuff. just wanted to give you a heads up there will be a meeting coming. i know with timezones it may be hard - but i was hoping that you can make it. [21:56:45] dbrant: We may want to run different snippets of code in the catch statement. Most places that use the URLDecoder do nothing in the catch statement, but I wanted to do something specific. Is the best way to do that to pass the method in Utils a Runnable which is executed in the catch statement? [21:57:20] dr0ptp4kt: sounds good [21:57:25] gwicke: thx [21:57:42] dbrant: Or is there some other recommended practice? I think the Runnable thing is what we've done elsewhere. [21:57:48] bearND: ^ You may be able to answer this for me :-) [21:58:11] Deskana: technically, that catch block is one of those "will never happen" things. But if we really want to put something there, it should just return the original (urlencoded) string. [21:58:11] dr0ptp4kt: mobrovac will be on vacation from Thursday on, in case you planned to include him [21:58:30] dbrant: Good point. That's what mine is doing anyway. [21:58:31] gwicke: it'll need to be next week, so we may miss him this time... [21:58:32] dbrant: Thanks. :-) [21:59:22] dr0ptp4kt: kk, np; I'll handle the app service deploy while he's out [21:59:26] Deskana: also, if you've got too much going on, I can just amend on top of your patch if you like. [21:59:52] dbrant: It's okay. I'll amend it later this evening, once I'm off the clock. :-) [22:00:11] dbrant: And probably ping you for review, since you'll probably be working! [22:00:16] yep! [22:01:25] dbrant: What I might do, actually, is make a new patch, with my patch as its parent, that changes all use of the URL decoder to a method in Utils. Then you can merge them together. [22:01:40] dbrant: That'll keep my change separate from the other change, which is probably good practice since they're actually very different changes. [22:01:47] Deskana: that's fine, too [22:02:02] (03PS2) 10Robmoen: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 [22:04:57] (03PS3) 10Robmoen: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 [22:06:12] JonKatz: http://etherpad.wikimedia.org/p/4.1_launch_post-mortem [22:06:33] 10Wikipedia-Android-App: NPE from android.webkit.WebViewClassic.setBaseLayer? - https://phabricator.wikimedia.org/T75403#1239971 (10bearND) 5Open>3Resolved a:3bearND This one is so old. The latest is from September 2014. One user commented that this happened when he pressed the back button. A lot has chang... [22:12:32] vibha: Do you still want to chat at 3:30pm? [22:26:59] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1240007 (10bearND) BTW, the examples are from the Hebrew version of the Tel Aviv article, in the secti... [22:29:25] dbrant: Is https://phabricator.wikimedia.org/T75751 meant as a stop-gap measure for the missing font issue? [22:34:33] hey Deskana, im on the jangout, this should be super quick [22:34:38] hangout* [22:34:46] Are you busy or have an overlap [22:35:04] ? [22:35:36] vibha: Sorry, I had to stand up. My toe was hurting. [22:35:41] vibha: Joining the hangout. [22:35:55] oh im so sorry, no worries. [22:36:00] vibha: No, it's fine! [22:36:55] bearND: that's absolutely right [22:39:04] dbrant: Would you add more info to the task, e.g. what you had in mind how to do this? [22:39:44] bearND: will do [22:39:54] dbrant: thanks [22:44:10] (03PS1) 10Fjalapeno: Bug T96605 - fixing saves of the history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206987 [22:51:04] (03CR) 10Fjalapeno: "looks good one comment" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206970 (https://phabricator.wikimedia.org/T95585) (owner: 10Bgerstle) [22:53:57] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1221843 (10Fjalapeno) Unreadable sections look like this: {F157879} [23:04:18] etonkovidova: would you have time to review the QA signoff cards in sprint 55? https://phabricator.wikimedia.org/tag/mobile-app-sprint-55-ios/ [23:04:46] mhurd - will do it right now [23:05:20] etonkovidova: cool thanks! [23:06:40] vibha: hey would you have some time today to help with styling tweaks to page issues and disambig? [23:10:36] (03PS1) 10Deskana: Hygiene: create decodeURL method in Utils, and use it everywhere. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206993 [23:11:05] (03PS2) 10Deskana: Hygiene: create decodeURL method in Utils, and use it everywhere. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206993 [23:11:12] dbrant ^ [23:11:24] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: create decodeURL method in Utils, and use it everywhere. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206993 (owner: 10Deskana) [23:11:38] DENIED [23:12:21] :..( [23:12:58] niedzielski: dbrant: Deskana: heading to bed soon. Do you need anything from me today? [23:13:18] bearND: don't think so! [23:13:18] bearND: no, thank you for asking. have a good rest! [23:13:23] bearND: I think I'm good. Sleep well! [23:13:34] (03PS3) 10Deskana: Hygiene: create decodeURL method in Utils, and use it everywhere. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206993 [23:13:49] awesome. Thanks guys! See you tomorrow. [23:14:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: create decodeURL method in Utils, and use it everywhere. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206993 (owner: 10Deskana) [23:14:32] Eugh, unused imports. I thought I got them all. [23:16:08] (03PS4) 10Deskana: Hygiene: create decodeURL method in Utils, and use it everywhere. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206993 [23:16:09] That should be all of them now. [23:16:44] dbrant: Alright, it's ready now. [23:16:54] mhurd: I'm focussing on getting the prototypes to a good place today for iOS and Android , can we target doing this after lunch tomorrow? [23:16:59] Deskana: will do! [23:17:07] vibha: ya! [23:17:19] excellent thank you [23:23:12] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS, 5Patch-For-Review: Select icon file based on build type (alpha, beta, etc) on build server - https://phabricator.wikimedia.org/T94534#1240250 (10Etonkovidova) Checked with Beta 93. Should wait for alpha release? {F157894} Anyway, I am putting it into Design... [23:27:17] 10Gather, 10Gather Sprint G: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1240279 (10Jdlrobson) a:3Jdlrobson [23:28:36] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Header in article history that should display a date instead displays the current time, UTC - https://phabricator.wikimedia.org/T96268#1240296 (10Etonkovidova) Checked with Beta 4.1.3(93) - the timestamp includes a date; the previous edits display their respectiv... [23:32:43] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Some article titles are randomly bolded in read more section - https://phabricator.wikimedia.org/T96263#1240325 (10Etonkovidova) Checked with Beta 4.1.3(93) - all articles' titles in 'Read more' have consistent formatting (not bolded anymore). [23:35:43] (03PS17) 10Dbrant: Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [23:39:18] (03CR) 10Dbrant: [C: 032] Run disambiguation links through URLDecoder [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206625 (https://phabricator.wikimedia.org/T97200) (owner: 10Deskana) [23:43:59] 6Mobile-Web: Hovercards should appear in mobile on desktop - https://phabricator.wikimedia.org/T97370#1240364 (10KHammerstein) 3NEW [23:44:59] (03Merged) 10jenkins-bot: Run disambiguation links through URLDecoder [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206625 (https://phabricator.wikimedia.org/T97200) (owner: 10Deskana) [23:46:49] (03CR) 10Deskana: "Note that dbrant's comments were addressed in a follow-on patch: If2ca604eee35ec9158eb5e7317193122b16bb9f0" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206625 (https://phabricator.wikimedia.org/T97200) (owner: 10Deskana) [23:49:18] 10Gather, 10Gather Sprint G: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1240394 (10Jdlrobson) @yurik query would be like http://localhost:8888/w/api.php?action=query&list=listpages&lspid=18 Current response ``` { "query": { "listpages": [... [23:49:49] 10Gather, 10Gather Sprint G: Collections (beta) invite via mobile panel - https://phabricator.wikimedia.org/T96286#1213325 (10Jdlrobson) @msyed what text do you recommend? [23:50:27] jdlrobson: hey do you have that etherpad about minerva on desktop? [23:53:28] (03PS5) 10Dbrant: Hygiene: create decodeURL method in Utils, and use it everywhere. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206993 (owner: 10Deskana) [23:54:18] (03CR) 10Dbrant: [C: 032] Hygiene: create decodeURL method in Utils, and use it everywhere. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206993 (owner: 10Deskana) [23:54:49] (03Merged) 10jenkins-bot: Hygiene: create decodeURL method in Utils, and use it everywhere. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206993 (owner: 10Deskana) [23:55:59] (03PS1) 10Jdlrobson: Hygiene: Begin restructuring of MobileFrontend frontend code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206997 [23:56:25] Deskana: I always like patches with more lines removed than added. [23:56:32] Me too! [23:56:54] When I submitted the first one, I was a bit disappointed, and Jenkins helped me out by making me remove a ton of unused imports. [23:57:01] JonKatz: do ou have tme to sign off on snakes today?https://phabricator.wikimedia.org/tag/mobile-web-sprint-45-snakes-on-a-plane/board/ [23:57:33] It went from 5 lines removed to 21 lines removed. \o/ [23:57:46] (03PS2) 10Jdlrobson: Hygiene: Begin restructuring of MobileFrontend frontend code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206997 [23:58:00] dbrant: If you're feeling generous, there's also this one: https://gerrit.wikimedia.org/r/#/c/206627/ [23:58:30] Deskana: yep, I'll try to get to it today [23:58:37] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story, 5Patch-For-Review: Window on leave code in editor overlay should be reusable or dropped - https://phabricator.wikimedia.org/T94194#1240459 (10KLans_WMF) [23:58:38] dbrant: Thank you, sir! [23:59:10] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story, 5Patch-For-Review: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1240467 (10KLans_WMF) [23:59:17] kristenlans I will try. [23:59:27] thanks JonKatz :-) [23:59:45] (03PS12) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253)