[00:00:09] (03PS6) 10Jdlrobson: Hygiene: Stop using mw-ui-button without abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 [00:00:29] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: On iOS 8.3 iPhone 5c in Private mode Safari, sometimes dragging/flicking doesn't scroll in modals - https://phabricator.wikimedia.org/T95561#1240477 (10KLans_WMF) [00:01:31] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Initial banner image should be delivered as part of the initial response - https://phabricator.wikimedia.org/T90698#1240485 (10KLans_WMF) [00:01:48] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Stop using mw-ui-button without abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 (owner: 10Jdlrobson) [00:01:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [00:01:55] 6Mobile-Web, 6Collaboration-Team, 10Flow, 7I18n, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages - https://phabricator.wikimedia.org/T91886#1240486 (10KLans_WMF) [00:02:12] (03CR) 10Jdlrobson: [C: 04-1] "drops tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206997 (owner: 10Jdlrobson) [00:10:55] (03PS3) 10Jdlrobson: Hygiene: Begin restructuring of MobileFrontend frontend code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206997 [00:12:04] 10Gather, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Set up qunit Jenkins job for Extension:Gather - https://phabricator.wikimedia.org/T91708#1240549 (10Jdlrobson) @legoktm the failure is due to T97268 [00:13:09] (03CR) 10Fjalapeno: [C: 031] "+1ing, but if you can address the comment that would be whipped cream" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206970 (https://phabricator.wikimedia.org/T95585) (owner: 10Bgerstle) [00:13:18] 10Gather, 10Gather Sprint G: Removing watchlist item from watchlist via Gather overlay does not cause star to change fill anymore... - https://phabricator.wikimedia.org/T97268#1240554 (10Jdlrobson) Sigh looks like our tests should have caught this but they are not running. [00:15:22] (03PS1) 10Robmoen: WIP: Create collection button on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207002 (https://phabricator.wikimedia.org/T95214) [00:17:06] (03CR) 10jenkins-bot: [V: 04-1] WIP: Create collection button on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207002 (https://phabricator.wikimedia.org/T95214) (owner: 10Robmoen) [00:19:57] (03PS18) 10Dbrant: Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [00:19:59] (03CR) 10jenkins-bot: [V: 04-1] Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [00:21:37] (03PS19) 10Dbrant: Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [00:23:14] (03CR) 10jenkins-bot: [V: 04-1] Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [00:27:56] (03PS20) 10Dbrant: Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [00:30:47] (03PS1) 10Bmansurov: Alpha: Show the main menu without a page reload when JavaScript is enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) [00:33:52] (03PS3) 10Bgerstle: prevent storing article titles that fail to load in history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206970 (https://phabricator.wikimedia.org/T95585) [00:50:49] (03PS1) 10Jdlrobson: Correct API inconsistency (module name and response) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) [00:53:11] (03CR) 10jenkins-bot: [V: 04-1] Correct API inconsistency (module name and response) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) (owner: 10Jdlrobson) [00:57:39] (03PS2) 10Jdlrobson: Correct API inconsistency (module name and response) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) [00:57:41] (03PS1) 10Jdlrobson: Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 [00:58:05] (03CR) 10Jdlrobson: [C: 04-1] "I have an item in watchlist that I can't seem to remove with this change." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) (owner: 10Jdlrobson) [00:58:16] (03PS3) 10Jdlrobson: Correct API inconsistency in response [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) [00:59:33] (03PS1) 10Bmansurov: Hygiene: Remove the 'options' argument from preRender and postRender functions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207010 [00:59:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 (owner: 10Jdlrobson) [00:59:42] (03PS2) 10Jdlrobson: Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 [00:59:55] (03PS4) 10Jdlrobson: Correct API inconsistency in response [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) [00:59:59] (03CR) 10Bmansurov: "I've added a relevant patch to Gather: https://gerrit.wikimedia.org/r/207010" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [01:01:18] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 (owner: 10Jdlrobson) [01:01:20] (03PS5) 10Dbrant: Link previews (prototypes 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) [01:02:14] (03PS1) 10Bmansurov: Hygiene: Remove the 'options' argument from preRender and postRender functions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/207011 [01:02:32] (03CR) 10jenkins-bot: [V: 04-1] Correct API inconsistency in response [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) (owner: 10Jdlrobson) [01:02:40] (03CR) 10Bmansurov: "@reviewer, please review https://gerrit.wikimedia.org/r/#/c/207011/ too. Thanks" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [03:05:02] (03PS4) 10Bgerstle: prevent storing article titles that fail to load in history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206970 (https://phabricator.wikimedia.org/T95585) [05:39:18] (03PS1) 10Deskana: Avoid requesting unused information from API in NearbyFetchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207030 [05:40:36] 10Wikipedia-Android-App, 7Easy: performance: the nearby API query requests info that it doesn't use. - https://phabricator.wikimedia.org/T97276#1240819 (10Deskana) https://gerrit.wikimedia.org/r/#/c/207030/ [05:40:55] 10Wikipedia-Android-App, 7Easy, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: performance: the nearby API query requests info that it doesn't use. - https://phabricator.wikimedia.org/T97276#1240820 (10Deskana) a:3Deskana [05:50:14] (03CR) 10Florianschmidtwelzow: [C: 032] "Yeah! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206997 (owner: 10Jdlrobson) [05:52:01] (03Merged) 10jenkins-bot: Hygiene: Begin restructuring of MobileFrontend frontend code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206997 (owner: 10Jdlrobson) [05:56:50] (03PS1) 10Deskana: Hygiene: add some documentation to OnboardingActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207032 [07:45:26] (03PS1) 10Mobrovac: Update service-mobileapp-node to 0268250 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/207044 [07:45:29] 3Gather Sprint Forward, 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1241002 (10zeljkofilipin) Wait, not all MobileFrontend Jenkins jobs are fixed: https://integra... [07:46:34] (03CR) 10Mobrovac: [C: 032 V: 032] Update service-mobileapp-node to 0268250 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/207044 (owner: 10Mobrovac) [09:04:58] morning all [09:05:43] making some coffee [09:12:24] 10Gather, 10Gather Sprint G, 5Patch-For-Review: Removing watchlist item from watchlist via Gather overlay does not cause star to change fill anymore... - https://phabricator.wikimedia.org/T97268#1241074 (10hashar) [09:12:26] 10Gather, 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Set up qunit Jenkins job for Extension:Gather - https://phabricator.wikimedia.org/T91708#1241073 (10hashar) [09:28:59] morning phuedx [09:29:20] phuedx: irccloud is so ugly [09:29:30] darn it is connected lol [09:38:01] irccloud is ugly [09:38:02] ? [09:38:44] phuedx: the website, isn't it? [09:40:34] oh not the actual client [09:50:56] this is so great https://userstyles.org/styles/104692/irccloud-aquamarine-theme [09:57:16] that's pretty great [09:57:20] i'd like a solarized one [10:11:02] phuedx: there is one if you search userstyles.org irccloud [10:11:11] i'm not sure how upt to date it is though [10:11:15] this one is perfectly integrated [10:15:15] kristenlans: are you actually there? [10:33:00] nope [11:02:57] (03CR) 10Jhernandez: "What does the last comment mean? Changes urls?" (032 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) (owner: 10Jhernandez) [11:07:26] (03PS2) 10Jhernandez: Render Collection list items with templates. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) [11:10:01] (03CR) 10Jhernandez: "Oh crap, i saw what you meant. Fixin'" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) (owner: 10Jhernandez) [11:12:09] (03PS3) 10Jhernandez: Render Collection list items with templates. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) [11:12:41] (03CR) 10Jhernandez: [C: 031] "Alright, I think this is solid now." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) (owner: 10Jhernandez) [12:30:49] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1241407 (10phuedx) I think that `skins.minerva.drawers.styles` and `skins.minerva.icons.images` are loaded in the head and shouldn't be. For the latter, only a st... [12:34:38] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1241414 (10Gilles) Getting skins.minerva.icons.images out of the head is what I'm working on at the moment. The changeset currently attached to this task is a pre... [13:12:18] (03CR) 10Phuedx: [C: 04-1] "Observations inline." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) (owner: 10Bmansurov) [13:12:46] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1241467 (10phuedx) a:3phuedx [13:13:46] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1214411 (10phuedx) I'll base my patch off of @bmansurov's patch for T96172. [13:28:39] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Log search type events for new header - https://phabricator.wikimedia.org/T96326#1241502 (10phuedx) I've created the [MobileWebSearch](https://meta.wikimedia.org/wiki/Schema:MobileWebSearch) schema so that we can implement and test this without wai... [13:53:14] 10Wikipedia-Android-App, 10Wikipedia-App-General-or-Unknown: Using “Share a fact” should not take coordinates as the default text (on some pages) - https://phabricator.wikimedia.org/T96493#1241549 (10JeanFred) [13:54:11] (03PS1) 10Gilles: Explicitly define module position [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207085 (https://phabricator.wikimedia.org/T97410) [14:03:17] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1241588 (10Jdlrobson) In theory for the latter we could load all icons at the end at the expense of icons at first appearing unstyled. Trade off we may want to co... [14:17:20] (03PS1) 10Mobrovac: Update service-mobileapp-node to 7075d2e [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/207110 [14:19:16] (03CR) 10Mobrovac: [C: 032 V: 032] Update service-mobileapp-node to 7075d2e [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/207110 (owner: 10Mobrovac) [14:31:23] (03CR) 10Fjalapeno: [C: 031] prevent storing article titles that fail to load in history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206970 (https://phabricator.wikimedia.org/T95585) (owner: 10Bgerstle) [14:44:42] (03PS2) 10Fjalapeno: Fix T96603 - wrapping section html creation in an exception handler. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206864 [14:51:05] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-iOS: Create accounts for Build server and update Fastlane / Jenkins to securely use accounts - https://phabricator.wikimedia.org/T94426#1241690 (10Fjalapeno) a:5dr0ptp4kt>3Fjalapeno [15:06:24] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: As a user I want to get quick context about a link. A combination of text and image will help me learn. (Prototype 1) - https://phabricator.wikimedia.org/T95030#1241714 (10KLans_WMF) [15:06:40] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Create accounts for Build server and update Fastlane / Jenkins to securely use accounts - https://phabricator.wikimedia.org/T94426#1241718 (10KLans_WMF) [15:08:01] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: 4.1.1(76) - clicking links in offline mode saved them in Recent - https://phabricator.wikimedia.org/T95585#1241722 (10KLans_WMF) [15:08:19] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1241723 (10KLans_WMF) [15:08:34] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: As a user, I want to be able to cancel data migration - https://phabricator.wikimedia.org/T96429#1241724 (10KLans_WMF) [15:08:45] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: Crash when failing to read HTML for particular section from disk - https://phabricator.wikimedia.org/T96603#1241725 (10KLans_WMF) [15:10:25] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: As a new user, I'd like article issues and disambiguation wrapped up into a button so that I can see what problems an article might have. - https://phabricator.wikimedia.org/T90250#1241737 (10KLans_WMF) [15:10:32] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Scroll event after pressing lock icon triggers an alert twice - https://phabricator.wikimedia.org/T96822#1241738 (10KLans_WMF) [15:10:43] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Some article titles are randomly bolded in read more section - https://phabricator.wikimedia.org/T96263#1241739 (10KLans_WMF) [15:10:55] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Header in article history that should display a date instead displays the current time, UTC - https://phabricator.wikimedia.org/T96268#1241740 (10KLans_WMF) [15:11:10] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: Select icon file based on build type (alpha, beta, etc) on build server - https://phabricator.wikimedia.org/T94534#1241741 (10KLans_WMF) [15:12:08] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove the 'options' argument from preRender and postRender functions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207010 (owner: 10Bmansurov) [15:13:06] (03CR) 10Jdlrobson: "I'm a bit concerned just like this broke Gather it may break Zero/other things." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [15:14:00] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: [Spike 2hrs] Audit fetchers to enable us to sunset iOS 6 support - https://phabricator.wikimedia.org/T91789#1241749 (10KLans_WMF) [15:14:15] 10Wikipedia-iOS-App: Spike [1 hour]: As a Mobile Apps Team, I would like to be alerted when something is going catastrophically wrong with the app in production, so we can fix it for our users (Monitoring/Alerting) - https://phabricator.wikimedia.org/T95941#1241750 (10KLans_WMF) [15:14:37] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Releasing Sprint 55 Work Product - https://phabricator.wikimedia.org/T95969#1241751 (10KLans_WMF) [15:15:02] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Update localization script so we can move files in the project without breaking importing localized strings - https://phabricator.wikimedia.org/T95733#1241753 (10KLans_WMF) [15:15:31] (03Merged) 10jenkins-bot: Hygiene: Remove the 'options' argument from preRender and postRender functions [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207010 (owner: 10Bmansurov) [15:21:51] (03CR) 10Jdlrobson: [C: 032] Render Collection list items with templates. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) (owner: 10Jhernandez) [15:22:38] (03CR) 10Jdlrobson: [C: 032] Explicitly define module position (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207085 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles) [15:24:14] (03CR) 10Jdlrobson: [C: 04-1] "apart from that looks fine but needs testing" (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen) [15:29:47] (03Merged) 10jenkins-bot: Render Collection list items with templates. [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206784 (https://phabricator.wikimedia.org/T97284) (owner: 10Jhernandez) [15:30:19] (03Merged) 10jenkins-bot: Explicitly define module position [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207085 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles) [15:44:00] (03CR) 10Fjalapeno: "Was thinking about this a little more overnight… I think one of the issues I could vocalize yesterday was the broad nature of the WMFAsser" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206858 (owner: 10Bgerstle) [15:51:27] 10Wikipedia-iOS-App: Incorrect crop for a leading image - https://phabricator.wikimedia.org/T91436#1241843 (10Nemo_bis) Imagine a world where editors are empowered to select relevant image crops. Imagine a world where T9757 is fixed. [15:56:13] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1241856 (10Mholloway) I just sent Vibha & Elena an updated APK for testing. This version co... [15:59:17] mholloway: got it - thx! [15:59:36] (03PS1) 10Gilles: Explicitly define module position [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/207125 (https://phabricator.wikimedia.org/T97410) [15:59:47] halfak: yt? [15:59:55] o/ phuedx [16:00:04] give this a listen: https://www.thisismyjam.com/phuedx [16:00:14] not what we've been chatting about lately [16:00:30] * halfak clicks play [16:00:40] but, after a lot of waiting (they cancelled a european tour two years ago), i finally got to see 'em live on saturday [16:00:53] 'twas an /amazing/ gig [16:00:59] my ears haven't quite recovered [16:01:49] Cool! (not the tinnitis though. That's rough. ) [16:01:50] https://en.wikipedia.org/wiki/Tinnitus [16:03:22] 6Mobile-Web, 10MediaWiki-extensions-UploadWizard, 6Multimedia: UploadWizard should not use jquery ui - https://phabricator.wikimedia.org/T97203#1241920 (10MarkTraceur) [16:05:56] yeah it sucked [16:06:00] it's gone now though [16:06:21] halfak: i would recommend all of their albums [16:06:31] but solace and sines in particular [16:06:50] the former being a lot heavier than the latter [16:06:52] phuedx, jamming now. Seems like this might have been the kinda thing I was looking for :) [16:07:49] phuedx, I'm writing a mountain of javascript right now. [16:07:53] I'm in OOjs UI land. [16:08:01] ooojuicy [16:08:34] halfak: i'm pretty sure there's a fundamental law of the universe that says something like [16:08:38] Isn't it great, halfak? [16:08:49] "the likelihood that you'll write javascript always increases" [16:09:12] second law of programming [16:09:13] marktraceur, I love the UI standardization that comes built in. Everything else -- well, they are design decisions I can live with. [16:09:41] phuedx, lol. Seems about right. [16:09:43] We must have a Firefox OS native app by August. [16:10:16] (it's all JS) [16:10:18] * halfak doesn't get why people want native apps. [16:10:31] Except for notifications, but we don't support those anyway. [16:11:20] eventually the web will support notifications [16:12:52] shared web workers, web sockets, notifications api [16:12:53] oh wait [16:12:58] we have 'em (almost) [16:13:52] halfak: You may find this enlightening: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Why_apps [16:14:29] The biggest one which isn't relevant for us (at least for now!) is that apps are easier to monetise. [16:14:31] Deskana, "Maximum " [16:15:12] We don't take advantage of most of this stuff though. [16:15:28] * halfak waits patiently to be able to read talk pages via the app. [16:15:33] And get notifications. [16:15:57] Right, because right now the app is focussed on readership rather than editorship. [16:16:01] We need a "contributor's app" that will help me manage my wiki stuffs from my phone. [16:16:12] I wish we had a much larger apps team to do stuff like that, but unfortunately we don't. [16:16:39] Deskana, with more OS/devices, we need an increasing amount of engineers. [16:16:45] That's one downside to apps. :\ [16:16:56] Web == theoretically everywhere [16:17:08] practically everywhere as well. [16:17:28] Oh well. Maybe I can go bug the comm tech team when they spin up. [16:17:29] :) [16:20:15] (03PS13) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [16:21:52] does anyone know if it is possible to pass mustache partials on server side mustache templates? [16:22:10] or i need to render the html beforehand [16:24:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [16:24:29] joakino: not off the top of my head [16:24:36] lightncandy doccy docs? [16:24:50] phuedx: what's lightncandy? [16:25:00] joakino: not sure. I know it wasn't implemented in JS https://phabricator.wikimedia.org/T97188 [16:25:11] joakino: https://github.com/zordius/lightncandy [16:25:22] that's the thing we use to render templates je reckon [16:26:15] jdlrobson: then we can't actually share templates because we use partials on JS and that's not possible on php [16:26:17] (03PS3) 10Mholloway: [WIP] Use a higher-res image if available and set it to the width of the column text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205649 (https://phabricator.wikimedia.org/T94646) [16:26:37] well we can, but is not as useful as it coud [16:26:38] could [16:27:05] this is a deep rabbit hole [16:28:56] i guess we can do super dumb templates, and in the js views prerender generate the partials html and put it in the options variable [16:29:01] that may work somehow [16:30:53] 6Mobile-Web: Migrate MobileFrontend templates from hogan to mustache - https://phabricator.wikimedia.org/T94086#1242018 (10Jdlrobson) [16:31:30] joakino: it looks like you have to enable partial support [16:31:58] phuedx: not the fights i can fight now [16:32:09] and then it'll lookup partials like it looks up templates [16:36:04] joakino: yeah -- it's not got partial support enabled [16:36:16] /and that looks like something that'll need a patch proper to do [16:45:07] 6Mobile-Web, 3Mobile-Web-Design: Render main menu via a template - https://phabricator.wikimedia.org/T97431#1242047 (10Jdlrobson) 3NEW a:3Jdlrobson [16:47:03] (03PS1) 10Jdlrobson: Hygiene: Move MainMenu to resources folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207138 [16:47:05] (03PS1) 10Jdlrobson: Render main menu via a server side template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) [16:49:04] (03CR) 10jenkins-bot: [V: 04-1] Render main menu via a server side template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) (owner: 10Jdlrobson) [16:52:18] bath time [16:56:27] (03CR) 10Bmansurov: "And that's where versioning comes in handy. We could have sent an email to interested parties about this breaking change." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [17:06:51] bmansurov: versioning only helps somewhat [17:06:57] we still need better deprecation practices [17:07:03] due to the way our deployment schedule works [17:07:12] if zero breaks on thursday due to a change we made tuesday that's not okay [17:08:24] jdlrobson: yeah, agreed. [17:09:24] i was thinking something like.. still use the options when given but also make a deprecation notice come up [17:10:06] good idea [17:11:16] (but obviously remove all our usages of them) [17:12:23] 10Gather Sprint G: Redirect /by/User/123 to /id/123/My-awesome-collection - https://phabricator.wikimedia.org/T97436#1242142 (10Jhernandez) 3NEW [17:12:36] (03CR) 10Fjalapeno: [C: 032] prevent storing article titles that fail to load in history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206970 (https://phabricator.wikimedia.org/T95585) (owner: 10Bgerstle) [17:13:31] 10Gather Sprint G: Redirect /by/User/123 to /id/123/My-awesome-collection - https://phabricator.wikimedia.org/T97436#1242153 (10Jhernandez) [17:14:03] (03PS3) 10Bgerstle: Fix T96603 - wrapping section html creation in an exception handler. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206864 (owner: 10Fjalapeno) [17:14:13] Someone (with project edit permissions) please set a start date for the project "Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story" in Phabricator so that https://phabricator.wikimedia.org/project/sprint/ does not break. Thank you! :) [17:14:32] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 6Analytics-Engineering, 10MediaWiki-API: Add page_id and namespace to X-Analytics header in App / api requests - https://phabricator.wikimedia.org/T92875#1242164 (10bd808) [17:14:34] (03PS2) 10Fjalapeno: Bug T96605 - fixing saves of the history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206987 [17:16:46] (03CR) 10Bmansurov: "Thanks for the review. Responses to your comments:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) (owner: 10Bmansurov) [17:16:59] (03PS2) 10Bmansurov: Alpha: Show the main menu without a page reload when JavaScript is enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) [17:17:02] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Show the main menu without a page reload when JavaScript is enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) (owner: 10Bmansurov) [17:18:17] 6Mobile-Web, 3Mobile-Web-Design: Stop serving menu and styles in the page HTML - https://phabricator.wikimedia.org/T95332#1242186 (10Jdlrobson) [17:18:19] 6Mobile-Web, 3Mobile-Web-Design, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story, 5Patch-For-Review: On alpha, clicking header launches hamburger menu and search without forcing a page load - https://phabricator.wikimedia.org/T96172#1242185 (10Jdlrobson) [17:20:54] (03CR) 10Robmoen: Refactor collection flag button to be an actual view (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen) [17:22:19] (03PS3) 10Bmansurov: Alpha: Show the main menu without a page reload when JavaScript is enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) [17:24:10] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Show the main menu without a page reload when JavaScript is enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) (owner: 10Bmansurov) [17:24:38] (03PS14) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [17:25:31] (03PS7) 10Jdlrobson: Hygiene: Stop using mw-ui-button without abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 [17:25:35] 10Wikipedia-iOS-App, 3App-Process-Improvement, 3Mobile-App-Sprint-56-iOS: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1242237 (10BGerstle-WMF) [17:25:52] (03Abandoned) 10Jdlrobson: Update Gather messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203835 (https://phabricator.wikimedia.org/T95729) (owner: 10Jdlrobson) [17:27:46] (03PS2) 10Jdlrobson: Render main menu via a server side template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) [17:28:27] dr0ptp4kt: I see you will be at 1:1 with Dmitry at 2:30. Is that still gonna happen while he's in OZ or can I schedule over it? [17:29:22] (03CR) 10jenkins-bot: [V: 04-1] Render main menu via a server side template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) (owner: 10Jdlrobson) [17:31:27] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Handle image maps better - https://phabricator.wikimedia.org/T87066#1242267 (10Mholloway) [17:33:32] joakino you in da house? [17:34:20] mhurd: i heard you were dealing with image maps recently [17:42:24] does git review blow away local uncommitted changes? [17:44:55] i don't see anything in the documentation but the verbose option shows a hard reset. hm, i don't think i'll ever use this tool again :| [17:44:58] phuedx: Just got back from NY. How’s the WikiGrok run going? [17:45:02] (03CR) 10Bmansurov: [C: 032] "In a follow up patch, 'javascripts/modules/mainMenu/init.js' should be moved too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207138 (owner: 10Jdlrobson) [17:45:33] niedzielski: I've never had that happen, but then again I tend to use "git commit -a" [17:46:19] Deskana: i just did a git reset --hard FETCH_HEAD [17:46:35] (03Merged) 10jenkins-bot: Hygiene: Move MainMenu to resources folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207138 (owner: 10Jdlrobson) [17:46:40] niedzielski: Yes, that'll do it. "git reset --hard" is pretty destructive. [17:46:41] Deskana: typo. i just did a git review -v -d and saw that [17:46:48] (03PS4) 10Fjalapeno: Fix T96603 - wrapping section html creation in an exception handler. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206864 [17:47:12] Deskana: obviously i would have stashed the changes if i thought that it was more than checking out [17:47:37] mholloway: ya! sorry in meeting. chat later? [17:47:49] (03CR) 10Bgerstle: [C: 031] Bug T96605 - fixing saves of the history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206987 (owner: 10Fjalapeno) [17:47:51] mhurd: sounds good! [17:48:13] kaldari: you're late for the spretro :) [17:48:19] also, we need to talk rollback after [17:48:19] (03CR) 10Bmansurov: [C: 04-1] Render main menu via a server side template (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) (owner: 10Jdlrobson) [17:48:44] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: Crash when failing to read HTML for particular section from disk - https://phabricator.wikimedia.org/T96603#1242400 (10BGerstle-WMF) 5Open>3Resolved [17:48:46] 10Wikipedia-iOS-App: [EPIC] Replace MWK exceptions with assertions & nil fallbacks - https://phabricator.wikimedia.org/T96599#1242402 (10BGerstle-WMF) [17:51:29] kaldari: you joining us in r37? [17:51:36] kaldari: are you in the office? [17:52:39] kristenlans: Do you have a second? [17:52:54] kristenlans: Oh, no, you don't. Never mind. [18:02:36] 6Mobile-Web, 5Patch-For-Review: Improve trademark code in MobileFrontend - https://phabricator.wikimedia.org/T95007#1242519 (10kaldari) Here's my latest idea... No trademark in the header. The trademark in the footer will be a text trademark symbol controlled by the $wgMFTrademarkSitename global variable. The... [18:29:29] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1242646 (10Vibhabamba) @KHammerstein can you provide guidance for main page images? [18:32:07] Deskana: https://storyboard.openstack.org/#!/story/1096057 the title of this git-review bug is misleading but the description encompasses the git review behavior i saw. beware :| [18:32:52] kaldari: got 5 minutes for a hangout? [18:34:33] 10Gather: 'Add to collection' popup should not show on every page load - https://phabricator.wikimedia.org/T97452#1242685 (10bmansurov) 3NEW [18:34:44] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 3Roadmap, 7notice: Production release for the Android Wikipedia app on 29th April 2015 - https://phabricator.wikimedia.org/T97064#1231975 (10bearND) Going through test report. [18:35:22] 6Mobile-Web, 10MobileFrontend, 6Performance-Team: skins.minerva.drawers.styles should be moved into mobile.drawers - https://phabricator.wikimedia.org/T97327#1242696 (10Jdlrobson) a:5Gilles>3Jdlrobson [18:36:08] (03PS1) 10Jdlrobson: Hygiene: Move drawers to resource folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207167 [18:36:10] (03PS1) 10Jdlrobson: Load drawer styles in mobile.drawers module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207168 (https://phabricator.wikimedia.org/T97327) [18:36:55] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1242718 (10Jdlrobson) @Gilles another problem is MediaWiki:Mobile.css - we have no control over this and currently this (community loaded) is loaded in the head. [18:37:55] (03CR) 10jenkins-bot: [V: 04-1] Load drawer styles in mobile.drawers module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207168 (https://phabricator.wikimedia.org/T97327) (owner: 10Jdlrobson) [18:39:22] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1242729 (10Gilles) @jdlrobson do we have stats about how large that community CSS is in practice across wikis? [18:40:46] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) (owner: 10Bmansurov) [18:41:09] (03PS4) 10Bmansurov: Alpha: Show the main menu without a page reload when JavaScript is enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) [18:42:40] vibha: heya! time to go over design tweaks for page issues /disambig ? [18:42:47] (03PS3) 10Jdlrobson: Render main menu via a server side template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) [18:44:48] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1242752 (10Gilles) >>! In T97289#1241588, @Jdlrobson wrote: > In theory for the latter we could load all icons at the end at the expense of icons at first appeari... [18:44:55] (03CR) 10Jdlrobson: [C: 04-1] "Having issues getting this working on alpha. hmpff" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) (owner: 10Jdlrobson) [18:46:46] (03CR) 10Bmansurov: "Neither does it work on beta or stable." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) (owner: 10Jdlrobson) [18:47:52] jdlrobso_: are you there? [18:47:58] hey codezee! [18:48:11] hi! [18:49:20] jdlrobso_: I just want to have a small discussion regarding starting, my exams have finished and I can start to work, also I had a small doubt on https://phabricator.wikimedia.org/T94772 [18:49:25] (03CR) 10Bmansurov: [C: 032] Hygiene: Move drawers to resource folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207167 (owner: 10Jdlrobson) [18:49:39] (03PS4) 10Niedzielski: Minor Improvements to Readme [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 [18:49:45] jdlrobso_: I've left a comment [18:49:53] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 5Patch-For-Review: Trim down CSS loaded in the head - https://phabricator.wikimedia.org/T97289#1242789 (10Jdlrobson) @Gilles it's not so bad on mobile (right now) - seems we either wrongly or rightly already load it via JavaScript and it is 2.1k gzipped, 4.... [18:49:59] codezee: ok np [18:50:07] codezee: did you get my mail? [18:50:18] oh yes i see you replied :) [18:50:23] jdlrobso_: yes, I did so, and I've replied to it :) [18:50:49] (03CR) 10Niedzielski: "Good to go." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski) [18:51:01] (03Merged) 10jenkins-bot: Hygiene: Move drawers to resource folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207167 (owner: 10Jdlrobson) [18:52:31] codezee: i'll give you a bit of room to breath and then start some daily check ins commencing next week [18:52:59] codezee: https://phabricator.wikimedia.org/T94772 sounds like a good starting point :) [18:54:02] jdlrobso_: ok, as you see fit, also reiterating my mail, I'll go ahead and create phab tasks for the tasks that need discussion and then I'll ask for help :) [18:54:26] codezee: replied :) [18:54:59] jdlrobso_: I see, ok thanks! [18:55:00] codezee: it may even be easier to do the wikidata integration before the magic word [18:55:02] we'll see :) [18:55:40] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207168 (https://phabricator.wikimedia.org/T97327) (owner: 10Jdlrobson) [18:56:22] codezee: i assume the purpose is to set a default placeholder image for pages which do not have a banner [18:56:33] jdlrobso_: rmoen: what's the name of our sprint! [18:56:43] whenever doing anything i always ask myself what is the most simple chunk of work I can do right now that get's me closer to the goal [18:56:50] joakino: i still say G Unnnitttt [18:57:15] or gung ho [18:57:20] jdlrobso_: what is that [18:57:21] jdlrobso_: yes, I had that concern in mind, so I asked ,and yes I'll try that out [18:57:28] jdlrobso_: can we do "G spot" [18:57:59] joakino: lolz [18:58:08] kristenlans: it's best if i attend that meeting [18:58:08] jdlrobso_: joakino does it still have to be somethign collectible? [18:58:12] (03CR) 10Florianschmidtwelzow: [C: 032] "and the next one :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207168 (https://phabricator.wikimedia.org/T97327) (owner: 10Jdlrobson) [18:58:16] (03PS5) 10Niedzielski: Minor improvements to readme [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 [18:58:19] dr0ptp4kt: 10-4 no worries [18:58:23] not sure if phabricator has a policy for project names joakino ;-) [18:58:25] kristenlans: thx [18:58:33] codezee: awesome [18:58:36] 10Gather Sprint G: Split resource loader modules in collections list and collection - https://phabricator.wikimedia.org/T97456#1242832 (10Jhernandez) 3NEW a:3Jhernandez [18:58:38] let me know if you need anything else [18:59:04] 10Gather Sprint G: Split resource loader modules in collections list and collection - https://phabricator.wikimedia.org/T97456#1242844 (10Jhernandez) [18:59:06] 10Gather, 10Gather Sprint G: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1134050 (10Jhernandez) [19:00:00] (03Merged) 10jenkins-bot: Load drawer styles in mobile.drawers module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207168 (https://phabricator.wikimedia.org/T97327) (owner: 10Jdlrobson) [19:00:01] jdlrobso_: of course, without hesiation, mostly I'll ping you at this time around, till you're in UTC-8 [19:00:21] (03CR) 10Niedzielski: "One more commit to add the commit message guideline reference. Have I mentioned that I think the readme should be a wiki? :)" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski) [19:00:25] (03PS1) 10Jhernandez: Split SpecialGather resource loader modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207172 (https://phabricator.wikimedia.org/T97456) [19:01:02] jdlrobso_: go for g unit [19:01:20] if only we had background images http://www.mtv.com/shared/promoimages/bands/g/g_unit/upres/Dave%20Hill/1.jpg [19:01:44] kristenlans: we are in flux, i sent an email with a poll to reading-wmf to see what topic we'll use for sprint names [19:01:52] kristenlans: collectable things is pretty boring [19:02:22] joakino: +1 [19:04:08] jdlrobso_, joakino: we could just name our sprints after gangsta rap groups [19:04:45] rmoen: i'm happy to do bands/singers [19:05:04] jdlrobso_: rmoen that can also set the songs I'll listen that sprint, sounds interesting [19:05:20] we could do albums too [19:05:34] albums +1 [19:05:39] Spotify playlist from a sprint name could be interesting [19:05:41] they're collectables [19:05:53] or bands [19:06:24] Indeed albums are collectables and usually have good names [19:06:25] G could be "Greatest hits" [19:06:39] +1 ^ [19:07:07] (03PS1) 10Florianschmidtwelzow: Move mobile.talk and mobile.talk.overlays to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207176 [19:07:09] Or Giulia Y los Tellarini [19:07:12] in honour of Barcelona [19:08:29] (03PS2) 10Florianschmidtwelzow: Move mobile.talk and mobile.talk.overlays to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207176 [19:09:00] Hello [19:10:10] 10Gather Sprint G: Fully render collections list with shared templates (client/server) - https://phabricator.wikimedia.org/T97459#1242894 (10Jhernandez) 3NEW a:3Jhernandez [19:10:28] 10Gather, 10Gather Sprint G: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1134050 (10Jhernandez) [19:10:30] 10Gather Sprint G: Fully render collections list with shared templates (client/server) - https://phabricator.wikimedia.org/T97459#1242906 (10Jhernandez) [19:11:22] (03PS1) 10Jhernandez: Fully render collections list with templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) [19:12:16] rmoen: jdlrobso_ we're doing albums from now on then! [19:12:32] extra points for listening to such album in the sprint [19:12:35] mhurd: in a re-org concerns meeting till 1:15ish, I will grab lunch and come to your desk at 1:30. We have been in re-org meetings since 9:30 am. [19:12:59] 6Mobile-Web: Update browser tests after login/sign up form warning changes - https://phabricator.wikimedia.org/T97460#1242914 (10Jdlrobson) 3NEW [19:13:04] How do I contact the developers of the mobile applications other than email? [19:13:26] 3Gather Sprint Forward, 6Mobile-Web, 10Browser-Tests, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 5Patch-For-Review: Fix failed MobileFrontend browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94156#1242926 (10Jdlrobson) #627 passed. We'll open more specific bugs from now on e.g. T97460 [19:13:35] SuppliedRelic: hi :) [19:14:22] FlorianSW: Hello. Do any of the developers visit this channel? [19:14:40] joakino: \o/ [19:14:55] SuppliedRelic: some, yes :P No, i don't see all, but the most :D [19:14:57] joakino: so what do we choose? Greatest hits? [19:15:04] (03CR) 10jenkins-bot: [V: 04-1] Fully render collections list with templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) (owner: 10Jhernandez) [19:15:16] jdlrobso_: lets go with it [19:15:28] https://phabricator.wikimedia.org/tag/gather_sprint_greatest_hits/ [19:15:38] How are the developers indicated as such? Being voiced I assume? [19:16:19] Nobody seems to respond to the emails that receive [19:17:45] SuppliedRelic: nope, the developers aren't indicated in any way (except you ask them :)). Which e-mail adress you used? Do we talk about mobile apps or mobile web? [19:18:30] FlorianSW: I'm referring to the developers for the Android applications. [19:18:40] 10Gather, 10Gather Sprint Greatest Hits: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1242931 (10Jhernandez) > Progress update > - **For the list of collections** > [x] T97284 & T97459: Switch CollectionList views and related to templates (so that we can render... [19:18:52] SuppliedRelic: ok, mobile apps :) What e-mail adress you used? [19:19:20] FlorianSW: I used the contact e-mail listed on the Google Play Store. [19:19:42] ok, can you start a private chat please? [19:19:51] Sure [19:20:22] SuppliedRelic: the android devs are here usually (distributed team, may not be here exactly right now) [19:21:04] (03PS1) 10Florianschmidtwelzow: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 [19:21:21] joakino: Ah ok, thank you. [19:21:34] SuppliedRelic: one way to contact is creating a task in phabricator with this project https://phabricator.wikimedia.org/tag/wikipedia-android-app/ [19:21:46] SuppliedRelic: they should notice it when they triage new bugs [19:22:25] joakino: Thank you very much. [19:22:54] (03CR) 10jenkins-bot: [V: 04-1] Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [19:22:58] SuppliedRelic: another option can be emailing mobile-l@lists.wikimedia.org , keep in mind that it is a public list so do not post private information :) [19:23:03] SuppliedRelic: ok i'll stop now hehe [19:23:35] joakino: :D [19:24:22] joakino: That information will come in very handy in the future. Thanks :D [19:29:52] (03PS1) 10Niedzielski: Hide caption on "tap to expand" table when open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207227 (https://phabricator.wikimedia.org/T86860) [19:29:55] hey channel operator, when I joined this channel I got a notice "Home page for #wikimedia-mobile: http://meta.wikimedia.org/wiki/Mobile_Projects", the old wiki page [19:29:59] 10Gather Sprint Greatest Hits: Enhance loading of CollectionsList with infinite scrolling - https://phabricator.wikimedia.org/T97463#1242968 (10Jhernandez) 3NEW a:3Jhernandez [19:31:23] 10Gather Sprint Greatest Hits: Enhance loading of CollectionsList with infinite scrolling - https://phabricator.wikimedia.org/T97463#1242984 (10Jhernandez) [19:31:59] 10Gather, 10Gather Sprint Greatest Hits: infinite scroll for user collections (pagination) - https://phabricator.wikimedia.org/T93309#1134050 (10Jhernandez) Gonna move all these checkboxes to the description [19:32:26] 10Wikipedia-Android-App, 7Easy, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: 'Tap here to expand' - the label should change when the section is expanded? - https://phabricator.wikimedia.org/T86860#1242989 (10Niedzielski) {F158261} {F158260} [19:33:52] 10Gather, 10Gather Sprint Greatest Hits: Infinite scroll for collections (enhanced pagination) - https://phabricator.wikimedia.org/T93309#1242991 (10Jhernandez) [19:34:33] i'm out for the day [19:34:35] too late already [19:34:39] bb! [19:35:14] (03CR) 10Krinkle: [C: 032] Explicitly define module position [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/207125 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles) [19:36:07] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Double-tap search text hides it behind buttons - https://phabricator.wikimedia.org/T88768#1243001 (10Niedzielski) a:3Niedzielski [19:36:15] bb joakino [19:36:19] and god night! [19:36:25] damn *good [19:36:46] (03Merged) 10jenkins-bot: Explicitly define module position [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/207125 (https://phabricator.wikimedia.org/T97410) (owner: 10Gilles) [19:40:05] 10Wikipedia-Android-App, 6Mobile-Apps: Spinning arrow with full width nav drawer looks strange (and isn't standard conform) - https://phabricator.wikimedia.org/T97465#1243024 (10Florian) 3NEW [19:43:09] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:00:30] (03CR) 10Florianschmidtwelzow: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:06:18] 10Gather, 10Gather Sprint Greatest Hits: Spike: Flagging - https://phabricator.wikimedia.org/T96282#1243121 (10Tgr) I can see two options: ==== Create a dedicated table Pro: * can be searched both ways ("my flags") * can be reused for other stuff (e.g. likes/follows would have the same data structure) Con: *... [20:14:20] (03PS2) 10Florianschmidtwelzow: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 [20:16:07] (03PS1) 10Robmoen: hygiene: make resource names consistent with their paths [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207267 [20:26:30] 6Mobile-Web: Menu items should not be underlined on hover - https://phabricator.wikimedia.org/T97336#1243183 (10KLans_WMF) @bmansurov can you give some steps to reproduce/device, etc? [20:27:23] 6Mobile-Web: bug - lead image should only be displayed on tablet when original image is minimum 768 px - https://phabricator.wikimedia.org/T97319#1243184 (10JKatzWMF) @dbrant how did you handle this in apps? [20:29:25] dr0ptp4kt: beta is building now… should be up on test flight soon - I need to wait until it is up to add the release notes. [20:29:38] 6Mobile-Web, 6Search-Team, 10Wikidata-Query-Service: Create test instance of Wikidata Query Service to do user acceptance testing with Readership Team - https://phabricator.wikimedia.org/T97189#1243189 (10JKatzWMF) @phuedx do you know if we have a service in place to test this? [20:30:43] coreyfloyd: thx for heads up [20:30:56] mhurd: trying to gobble as fast as we can [20:31:00] Be there in 5 [20:31:07] vibha: take your time! :) [20:32:59] 6Mobile-Web, 10Wikipedia-iOS-App, 10MediaWiki-extensions-EasyTimeline: tag doesn't render in mobile. - https://phabricator.wikimedia.org/T97182#1243205 (10KLans_WMF) p:5Triage>3Low [20:37:58] 10Wikipedia-Android-App, 6Mobile-Apps: Spinning arrow with full width nav drawer looks strange (and isn't standard conform) - https://phabricator.wikimedia.org/T97465#1243223 (10bearND) [20:38:36] coreyfloyd: installing beta... [20:38:47] coreyfloyd: thanks for working out the icon biz [20:41:07] Deskana I have a momen tnow if you want to chat? [20:41:28] (03CR) 10Jdlrobson: [C: 032] Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:42:12] (03CR) 10Jdlrobson: [C: 04-1] "ohh wait.. tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:42:28] (03CR) 10Jdlrobson: "Please update the tests too!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:43:03] (03CR) 10Jdlrobson: [C: 04-1] "You'll need to restructure the tests as well" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207176 (owner: 10Florianschmidtwelzow) [20:47:11] (03CR) 10Jdlrobson: [C: 04-1] Split SpecialGather resource loader modules (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207172 (https://phabricator.wikimedia.org/T97456) (owner: 10Jhernandez) [20:47:39] 6Mobile-Web: Menu items should not be underlined on hover - https://phabricator.wikimedia.org/T97336#1243260 (10bmansurov) [20:47:49] 6Mobile-Web: Menu items should not be underlined on hover - https://phabricator.wikimedia.org/T97336#1239655 (10bmansurov) Updated the description. [20:48:37] (03CR) 10Jdlrobson: [C: 04-1] "Looks fine but a few minor issues need to be taken care of to keep jenkins happier" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) (owner: 10Jhernandez) [20:49:09] jdlrobson: been doing deployment checks. It seems the only dependency is a core change for the API on 1.26wmf2 https://gerrit.wikimedia.org/r/#/c/182858/27 Not sure if this API change will explode other parts of en.wiki though as it is so huge... [20:50:01] jdlrobson: it also removes a LOT of api methods.. so I have a bad feeling about this. Test wiki is running 1.26wmf3 which doesn't require this cherry pick [20:50:09] (03PS3) 10Florianschmidtwelzow: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 [20:50:16] (03PS2) 10Jdlrobson: Hygiene: make resource names consistent with their paths [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207267 (owner: 10Robmoen) [20:50:23] (03CR) 10Jdlrobson: [C: 032] Hygiene: make resource names consistent with their paths [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207267 (owner: 10Robmoen) [20:51:50] kaldari: 7 minutes before our window. In order for us to update Gather to master on 1.26wmf2 we need a huge API change cherry picked to core and I have a feeling we will explode alot of things if we try to cherry pick the change in [20:52:02] https://gerrit.wikimedia.org/r/#/c/182858/27 [20:52:37] rmoen: why do we need that? [20:52:48] what's the Gather patch that needs it? [20:53:20] Because our api is using the core api methods.. Idk which Gather patch needs it, I just traced down the core dependency [20:53:25] (03CR) 10Jdlrobson: [C: 032] Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:53:31] (03PS4) 10Jdlrobson: Hygiene: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:53:45] rmoen: so are you saying without it gather explodes? [20:53:51] yep [20:53:58] jdlrobson: yep it doesn't work at all [20:54:02] how does it explode? [20:54:14] without that patch you get PHP Fatal error: Call to undefined method ApiResult::addIndexedTagName() in /media/sf_noobu/mediawiki/extensions/Gather/includes/api/ApiQueryLists.php on line 353 [20:54:16] * jdlrobson grumbles about uncoodinated core changes [20:54:16] and a white page [20:54:17] (03PS3) 10Florianschmidtwelzow: Move mobile.talk and mobile.talk.overlays to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207176 [20:54:18] rmoen: You could just update wmf3. wmf2 will be obsolete tomorow. [20:54:35] kaldari: mind blown! [20:54:41] (03CR) 10Jdlrobson: [C: 031] Hygiene: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:54:46] (03CR) 10Jdlrobson: [C: 032] Hygiene: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:54:59] kaldari: will this prevent other things from exploding? [20:55:03] problem solved :) [20:55:19] kaldari: ok care to sit in on this one ? [20:55:24] sure [20:55:29] word [20:55:34] (03CR) 10Florianschmidtwelzow: Hygiene: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:55:39] rmoen: as long as wmf3 core already has the change [20:55:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [20:56:04] kaldari: wmf3 has the change, i've confirmed [20:56:28] I spent my lunch doing a pre-deploy test locally and found those things [20:56:35] cool, I would say just do wmf3 today then, and keep on eye on English Wikipedia during the train deployment tomorrow [20:57:08] (03Merged) 10jenkins-bot: Hygiene: make resource names consistent with their paths [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207267 (owner: 10Robmoen) [20:57:14] rmoen: do you want to do a hang-out again? [20:57:17] kaldari: hangout? i'll need some guidance [20:58:19] (03Merged) 10jenkins-bot: Hygiene: Move mobile.mediaViewer and mobile.mediaViewer.beta to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207181 (owner: 10Florianschmidtwelzow) [21:02:26] 10Gather, 10Gather Sprint Greatest Hits: Spike: Flagging - https://phabricator.wikimedia.org/T96282#1243315 (10Jdlrobson) Thanks for this Gergo. You could also have a mixture of your two options. **Modified option** Dedicated table could record e.g. gather-flagged-lists: *** user id of reporter *** collection... [21:05:32] 10Gather, 10Gather Sprint Greatest Hits: Collections (beta) invite via mobile panel - https://phabricator.wikimedia.org/T96286#1243325 (10Jdlrobson) a:3Jdlrobson [21:05:56] (03CR) 10Jdlrobson: [C: 032] Move mobile.talk and mobile.talk.overlays to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207176 (owner: 10Florianschmidtwelzow) [21:06:07] (03PS4) 10Jdlrobson: Hygiene: Move mobile.talk and mobile.talk.overlays to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207176 (owner: 10Florianschmidtwelzow) [21:06:17] (03CR) 10Jdlrobson: [C: 031] Hygiene: Move mobile.talk and mobile.talk.overlays to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207176 (owner: 10Florianschmidtwelzow) [21:06:45] (03CR) 10Jdlrobson: [C: 032] Hygiene: Move mobile.talk and mobile.talk.overlays to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207176 (owner: 10Florianschmidtwelzow) [21:08:19] 6Mobile-Web: Update browser tests after login/sign up form warning changes - https://phabricator.wikimedia.org/T97460#1243333 (10Jdlrobson) also https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/630/testReport/junit/(root)/Page%20a... [21:09:03] (03Merged) 10jenkins-bot: Hygiene: Move mobile.talk and mobile.talk.overlays to resources/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207176 (owner: 10Florianschmidtwelzow) [21:10:20] looool [21:10:22] phuedx: you there? [21:10:36] also bmansurov [21:10:43] http://en.m.wikipedia.beta.wmflabs.org/wiki/NewPage14302?mobileaction=beta click the hamburger. See anything strange? [21:10:43] yep [21:11:05] 2 things [21:11:20] wrong settings icon, items are underlined on hover [21:11:21] 6Mobile-Web: Unsoliciated settings icon - https://phabricator.wikimedia.org/T97473#1243341 (10Jdlrobson) 3NEW [21:11:30] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Handle image maps better - https://phabricator.wikimedia.org/T87066#1243350 (10Mholloway) [21:11:30] how did this happen!? [21:11:32] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1243351 (10Mholloway) [21:11:47] jdlrobson: not sure about the icon, but i've raised a bug about the underline [21:12:10] jdlrobson: i suppose the resources renaming has something to do with it [21:13:28] 6Mobile-Web: Editor broken on new pages - https://phabricator.wikimedia.org/T97474#1243352 (10Jdlrobson) 3NEW [21:13:37] 6Mobile-Web: Update browser tests after login/sign up form warning changes - https://phabricator.wikimedia.org/T97460#1243361 (10Jdlrobson) See also T97474 [21:15:36] 6Mobile-Web, 6Multimedia: [ImageMetricsCorsSupport] Missing or empty schema - https://phabricator.wikimedia.org/T97475#1243366 (10Jdlrobson) 3NEW [21:16:43] bmansurov: i can look at it a little later but if you have bandwidth to check that out go for it [21:16:47] we should get that fixed asap [21:16:57] jdlrobson: ok [21:17:01] 6Mobile-Web, 3Mobile-Web-Design: Search + menu / navigation - https://phabricator.wikimedia.org/T94922#1243375 (10KHammerstein) [21:17:08] 6Mobile-Web, 10MediaWiki-extensions-ImageMetrics, 6Multimedia: [ImageMetricsCorsSupport] Missing or empty schema - https://phabricator.wikimedia.org/T97475#1243384 (10Tgr) [21:17:49] 10Gather, 10Gather Sprint Greatest Hits: Qunit tests trigger API hits fails locally - https://phabricator.wikimedia.org/T97376#1243387 (10Jdlrobson) a:3Jdlrobson [21:20:14] (03Abandoned) 10Bgerstle: add assertion macros [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/206858 (owner: 10Bgerstle) [21:20:16] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 (owner: 10Jdlrobson) [21:22:21] 6Mobile-Web, 10MediaWiki-extensions-ImageMetrics, 6Multimedia: [ImageMetricsCorsSupport] Missing or empty schema - https://phabricator.wikimedia.org/T97475#1243396 (10Tgr) It should, the goal is to detect broken CORS support across all devices. The schema is added via `EventLoggingRegisterSchemas`, maybe tha... [21:23:37] jdlrobson: we should be live on testwiki xD [21:23:44] rmoen: awesome! checking [21:23:47] same [21:24:23] looks legit [21:25:25] jdlrobson: Yeah! [21:25:50] lg2m [21:29:40] (03PS2) 10Bmansurov: Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) [21:29:43] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [21:30:13] (03PS3) 10Bmansurov: Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) [21:34:06] jdlrobson: Where do I send team emails now? mobile-tech? reading-wmf? [21:34:12] xD [21:36:02] i'm confused about mobile-tech going away, I thought reading-wmf was an internal list ? [21:37:01] (03PS1) 10Bmansurov: Add the missing semicolon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207282 (https://phabricator.wikimedia.org/T97336) [21:37:11] jdlrobson: ^ should fix the issue you mentioned [21:37:47] rmoen: reading-wmf is interal, and mobile-list is external i think [21:38:06] rmoen: mobile-tech is an internal list yes what bmansurov said [21:38:43] ahh but from what I hear mobile-tech is going away.. Re: Adam Baso email [21:39:07] so where to blast team updates / wikitech, mobile-l ? [21:39:14] jdlrobson, bmansurov ^ [21:39:28] rmoen: mobile-l imo [21:39:30] reading-wmf [21:39:36] if it's logistics [21:39:39] lol see there is super confusion [21:39:42] we are always public by default [21:39:47] so mobile-l if in doubt [21:39:55] rmoen: no confusion. [21:40:00] jdlrobson: i thought reading-wmf was for things like "OOM: Brain at capactiy. WFH rest of the day" [21:40:05] rmoen: there is an email from adam i think about this [21:40:06] rmoen: correct [21:40:32] rmoen: we're open source, anything outside the realms of OOM goes to a public mailing list unless you are 100% sure no one cares [21:40:42] yes [21:41:15] so for public blasts. Mobile-l / wikitech-l [21:42:32] yup [21:46:01] (03PS1) 10Mholloway: Handle image maps better [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207284 (https://phabricator.wikimedia.org/T87066) [21:46:39] (03PS3) 10Jdlrobson: Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 [21:46:41] (03PS1) 10Jdlrobson: QUnit tests: Don't hit the API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207285 (https://phabricator.wikimedia.org/T97376) [21:49:37] (03CR) 10Mholloway: "Note that, although I have kept them separate, this change depends on https://gerrit.wikimedia.org/r/#/c/205649/ (see T94646)." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207284 (https://phabricator.wikimedia.org/T87066) (owner: 10Mholloway) [21:49:44] (03CR) 10jenkins-bot: [V: 04-1] QUnit tests: Don't hit the API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207285 (https://phabricator.wikimedia.org/T97376) (owner: 10Jdlrobson) [21:50:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 (owner: 10Jdlrobson) [21:50:22] (03PS4) 10Jdlrobson: Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 [21:50:24] (03PS2) 10Jdlrobson: QUnit tests: Don't hit the API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207285 (https://phabricator.wikimedia.org/T97376) [21:51:12] bearND: dbrant able to hop on the batcave? [21:51:24] dr0ptp4kt: coming [21:51:27] dr0ptp4kt: yep [21:51:37] (03PS5) 10Jdlrobson: Correct API inconsistency in response [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) [21:52:01] (03PS13) 10Jdlrobson: Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) [21:52:03] (03CR) 10jenkins-bot: [V: 04-1] Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) (owner: 10Jdlrobson) [21:52:18] (03CR) 10jenkins-bot: [V: 04-1] QUnit tests: Don't hit the API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207285 (https://phabricator.wikimedia.org/T97376) (owner: 10Jdlrobson) [21:53:05] (03PS2) 10Mholloway: Handle image maps better [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207284 (https://phabricator.wikimedia.org/T87066) [21:53:29] (03PS1) 10Deskana: Handle some more login API errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207287 [21:53:41] bearND: ^ fix for the login thing [21:53:43] (03PS3) 10Jdlrobson: QUnit tests: Don't hit the API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207285 (https://phabricator.wikimedia.org/T97376) [21:53:45] (03CR) 10jenkins-bot: [V: 04-1] Correct API inconsistency in response [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) (owner: 10Jdlrobson) [21:53:57] kristenlans: able to hop on the batcave? [21:54:11] dr0ptp4kt: yerp [21:54:56] bearND: Oh, looks like I might've beaten you to it, judging by that Phab task. [21:55:07] bearND: Sorry! [21:55:26] (03PS14) 10Jdlrobson: Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) [21:55:28] (03PS6) 10Jdlrobson: Reflect some upstream changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203229 (https://phabricator.wikimedia.org/T97338) [21:57:07] (03CR) 10jenkins-bot: [V: 04-1] Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) (owner: 10Jdlrobson) [21:57:08] dbrant: hey! what are your thoughts on https://phabricator.wikimedia.org/T89834? i've had it chilling in the 'doing' column since last sprint but i'm not sure where (if anywhere) to go with it. [21:57:37] (03CR) 10Jdlrobson: [C: 032] "Text seems kinda small but hey.. it's in the code :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207282 (https://phabricator.wikimedia.org/T97336) (owner: 10Bmansurov) [21:57:39] dbrant: bearND and I thought we should talk to you about it [21:59:23] (03CR) 10jenkins-bot: [V: 04-1] Add the missing semicolon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207282 (https://phabricator.wikimedia.org/T97336) (owner: 10Bmansurov) [22:03:37] bgerstle: coreyfloyd kristenlans mhurd - i'm rebooting mac mini. i sense a trend [22:03:46] :( [22:03:48] jdlrobson: Would be happy to get your feedback on deployment email i sent out. I'm thinking for next week I include something like deployment highlights. [22:05:05] brb [22:05:39] Deskana: it's ok. I was about to submit a patch for it when I saw yours come in. But now I can review it, that's fine, too. Mine didn't have the illegal user name handling. So, I prefer yours. [22:06:36] mholloway: I think it would be good for you and dbrant to talk through what you've done and what else he had in mind when he created the task. [22:07:30] Deskana: would you link to the bug from your patch? [22:07:41] bearND: Sure. [22:08:16] (03CR) 10Bmansurov: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207282 (https://phabricator.wikimedia.org/T97336) (owner: 10Bmansurov) [22:08:33] (03PS2) 10Deskana: Handle some more login API errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207287 (https://phabricator.wikimedia.org/T97477) [22:08:53] bearND: Done [22:09:06] Deskana: thanks [22:10:10] Deskana: what's an illegal user name? [22:10:19] how to test it? [22:11:50] bearND: I tested the illegal bit using a username with a forward slash in it. I don't know how to trigger a WrongPluginPass error, though. [22:11:53] (03Merged) 10jenkins-bot: Add the missing semicolon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207282 (https://phabricator.wikimedia.org/T97336) (owner: 10Bmansurov) [22:12:37] Deskana: looks like a space in the user name is also not allowed [22:13:05] Deskana: Trying the TSG account I got WrongPluginPass [22:13:23] bearND: What was their username? [22:15:18] Deskana: pm? [22:15:25] bearND: Sure. [22:19:57] (03PS1) 10Niedzielski: Inline context action bar and fix rotation bugs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207293 (https://phabricator.wikimedia.org/T88768) [22:22:40] (03PS1) 10Jdlrobson: Fix settings icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207294 (https://phabricator.wikimedia.org/T97473) [22:23:20] (03PS15) 10Jdlrobson: Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) [22:23:29] (03PS16) 10Jdlrobson: Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) [22:25:18] (03PS4) 10Mholloway: Use a higher-res image if available and set it to the width of the column text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205649 (https://phabricator.wikimedia.org/T94646) [22:25:34] (03CR) 10jenkins-bot: [V: 04-1] Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) (owner: 10Jdlrobson) [22:28:59] (03PS3) 10Deskana: Handle some more login API errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207287 (https://phabricator.wikimedia.org/T97477) [22:29:46] (03PS17) 10Jdlrobson: Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) [22:31:46] coreyfloyd: in documenting the translatewiki stuff... i'm just curious if that would involve adding a README to the repo [22:31:51] because, apparently, there isn't one :-/ [22:33:44] bgerstle: coreyfloyd: the main doc is on https://translatewiki.net/wiki/Translating:WikimediaMobile [22:34:01] (03CR) 10Niedzielski: "Ready for review." (035 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207293 (https://phabricator.wikimedia.org/T88768) (owner: 10Niedzielski) [22:35:10] (03CR) 10BearND: [C: 032] Handle some more login API errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207287 (https://phabricator.wikimedia.org/T97477) (owner: 10Deskana) [22:35:28] (03Merged) 10jenkins-bot: Handle some more login API errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207287 (https://phabricator.wikimedia.org/T97477) (owner: 10Deskana) [22:35:58] bearND: is there a link to that wiki in the repo somewhere? [22:40:34] bgerstle: Only in the commit messages of the TWN syncs [22:41:09] bearND: hrm. would be nice to have some kind of documentation in the repo, even if it's a reference to somewhere else. [22:41:31] as someone who wants to use (and possibly contribute to) the tool [22:42:30] (03CR) 10Bmansurov: [C: 032] Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [22:42:32] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [22:44:15] (03PS3) 10Bmansurov: Hygiene: Drawer uses Icon and Button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206335 (owner: 10Jdlrobson) [22:44:18] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Drawer uses Icon and Button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206335 (owner: 10Jdlrobson) [22:44:43] (03CR) 10Bmansurov: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [22:46:49] bgerstle: That's a great idea. I'll add something to the Android readme. [22:47:08] bearND: why not the translatewiki README? [22:47:43] bgerstle: The translatewiki page has already links back to the app code [22:47:46] or are you thinking about having android link to translatewiki docs [22:48:18] bgerstle: yes, what did you have in mind? [22:49:02] i guess two things: what you're already doing (linking from the app to translate wiki docs) [22:49:02] (03CR) 10Jdlrobson: [C: 04-1] Alpha: Show the main menu without a page reload when JavaScript is enabled (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) (owner: 10Bmansurov) [22:49:20] but perhaps also having a link to the wiki in translatewiki repo itself [22:49:44] somehow i ended up in the repo w/o knowing where documentation was [22:51:22] bearND: https://gerrit.wikimedia.org/r/207298 [22:51:48] (03PS4) 10Robmoen: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 [22:52:09] as far as "how to update iOS translations" we'll add the iOS-specific portion of the docs to our README/wiki and link to translatewiki's wiki doc for more details [22:52:11] bgerstle: ah, cool [22:52:30] phuedx: Who's the best person on your team to ask about the mobileview API? [22:55:03] (03CR) 10Bmansurov: [C: 04-1] "Blocked on T95332" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207005 (https://phabricator.wikimedia.org/T96172) (owner: 10Bmansurov) [22:55:44] Deskana: phuedx is probably asleep (god i hope he is). We dont really have a mobileview expert [22:55:50] since Max left [22:55:53] i know the code somewhat [22:56:21] I'm noticing an inconsistency in the "editable" key in the response [22:56:29] cache related? [22:56:31] Sometimes it's true, sometimes it's false, which is fine. However, sometimes it's just empty. [22:56:41] That seems weird to me. [22:57:26] (03CR) 10Jdlrobson: "I'm not really sure how best to deprecate this or whether we should just do this and risk the consequences this time..." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [22:58:40] greg-g: hey [23:00:06] greg-g i've got to step out now, but maybe tomorrow we can chat a bit more? [23:01:07] jdlrobson: Do you know if the response being empty means that the page is editable? [23:01:28] jdlrobson: The app interprets empty responses as being uneditable pages, but there are empty responses on editable pages too, which is weird. [23:02:24] (03PS5) 10Robmoen: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 [23:03:59] Deskana: quite possibly [23:04:08] empty string usually means true sadly [23:04:48] Protecting the page removes the "editable" key from the response entirely [23:04:51] This is so confusing [23:05:46] (03PS15) 10Jdlrobson: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) [23:06:14] (03CR) 10Jdlrobson: [C: 032] "Gerrit can't handle rebases with file name changes so this was a straightforward rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [23:06:22] Deskana: :( [23:06:33] on plus side anomie is working on this apparently [23:06:41] making it a boolean when it really is a boolean [23:06:58] (03CR) 10Bmansurov: [C: 032] Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [23:07:15] Deskana: https://phabricator.wikimedia.org/T87053 [23:08:01] bgerstle: sure, I'm open to that, just you and I or ? I'd like to keep it public, of course ;) [23:08:11] (03Merged) 10jenkins-bot: Hygiene: Create anchor abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/204424 (https://phabricator.wikimedia.org/T87253) (owner: 10Jdlrobson) [23:08:18] (03CR) 10Jdlrobson: [C: 032] "Taking silence to be no objection" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) (owner: 10Florianschmidtwelzow) [23:08:26] yeah, i'm trying to find a good trade-off for resolving this and transparency [23:08:39] we want to move forward, and continuing on an email thread or phab ticket will only drag this on [23:08:56] that's a horrible view of collaboration, but I'll let it slide [23:08:58] greg-g i was thinking a "town hall"... but that's a bit crazy [23:09:24] mholloway: Just did a quick test. Leaving comments on phabrictaor [23:09:24] greg-g fair point [23:09:39] greg-g let me mull this over and i'll get back to you tomorrow [23:09:49] (03Merged) 10jenkins-bot: Fix for edit header message format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206782 (https://phabricator.wikimedia.org/T97275) (owner: 10Florianschmidtwelzow) [23:09:58] we were able to compromise on crash reporting, we should be able to come to terms on this as well [23:09:58] I think more than just me (probably mukunda) and a couple from ios [23:10:07] kaldari: uhhh oh [23:10:08] https://commons.m.wikimedia.org/wiki/Main_Page [23:10:09] no icons! [23:10:10] not huge, we can do a hangout, that's fine, just taking good notes :) [23:10:31] greg-g sounds good to me. i'll make a note to schedule something [23:10:36] * greg-g has a hard time typing i)S, see, I always press zero [23:10:41] unfortunately i've gotta run. ttyl [23:10:43] tah! [23:11:15] o/ [23:13:00] coreyfloyd: the beta is working okay for me. the test crash report worked [23:13:19] bearND: I have a hack that fixes the bug, but you won't like it. ;-) [23:13:51] dr0ptp4kt: cool - you want me to submit for review? [23:15:29] Deskana: ;) [23:16:47] Deskana: sorry, I'll have to go to bed now. It's past 1am here. Feel free to submit a patch and I'll check it out tomorrow with the rest of them. [23:16:49] coreyfloyd: i think in the spirit of https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process , yes, go for it. let it rip [23:16:56] bearND: It's fine. See you tomorrow. :- [23:16:57] ) [23:17:18] dr0ptp4kt: cool - ill update the notes and stuff and get it going. [23:18:53] coreyfloyd: for tsg regression testing, i'll need to e-introduce you. they'll in all likelihood need to drop by the office for installation by mhurd onto their ios 6 & 7 devices to do the upgrade path testing [23:19:10] coreyfloyd: mhurd okay for me to email tsg? [23:32:46] dr0ptp4kt: sure [23:34:25] (03CR) 10Bmansurov: [C: 032] Fix settings icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207294 (https://phabricator.wikimedia.org/T97473) (owner: 10Jdlrobson) [23:35:36] coreyfloyd: one minute [23:36:06] (03Merged) 10jenkins-bot: Fix settings icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207294 (https://phabricator.wikimedia.org/T97473) (owner: 10Jdlrobson) [23:36:09] coreyfloyd: mhurd and i would actually like to hold off until tomorrow in order to get the final page issues & disambig styling tweaks incoroprated [23:36:18] coreyfloyd: can you re-cut tomorrow with that? [23:36:22] dr0ptp4kt: sure [23:36:27] coreyfloyd: the thinking is it makes it 'feature complete'. cool, thanks. [23:36:50] works fine for me - mhurd are you coordinating that work? [23:37:02] or dr0ptp4kt are you? [23:37:22] coreyfloyd: mhurd has talked with design already. he's coding it [23:37:22] coreyfloyd: ya been working with katie since just before our kickoff meeting [23:38:43] dr0ptp4kt: also you want to work out hockey issues together? [23:41:01] coreyfloyd: right now? i'm okay with that, just know it's getting late for you [23:51:35] kaity: hey i think i have it all fixed... [23:51:46] (03CR) 10Bmansurov: [C: 031] "Needs testing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206336 (owner: 10Jdlrobson) [23:51:58] kaity: have a minute to check? [23:52:31] (03PS1) 10Kaldari: Improve trademark code in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) [23:52:55] (03CR) 10Bmansurov: [C: 04-1] "needs a rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 (owner: 10Jdlrobson) [23:54:15] (03CR) 10jenkins-bot: [V: 04-1] Improve trademark code in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari) [23:56:04] coreyfloyd: i'm heading out. i set a 15 minute slot tomorrow at 1 pm your time to go over the hockey thing [23:56:07] coreyfloyd: have a good night [23:57:51] (03PS1) 10Mhurd: Styling tweaks from Vibha and Katie. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207321 [23:58:56] (03PS1) 10Deskana: Fix for some pages incorrectly showing as protected [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207322 [23:58:57] * Deskana sighs [23:59:02] That's the most stupid patch I've written in ages [23:59:02] coreyfloyd: ^ if you have a minute to review the page issues style tweaks katie signed off on them [23:59:42] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari) [23:59:54] (03PS2) 10Deskana: Fix for some pages incorrectly showing as protected [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207322 (https://phabricator.wikimedia.org/T97483)