[00:00:45] <coreyfloyd>	 mhurd: yep
[00:01:03] <grrrit-wm>	 (03PS2) 10Kaldari: Improve trademark code in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) 
[00:02:00] <grrrit-wm>	 (03CR) 10Deskana: "This solution is stupid but I have nothing better." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207322 (https://phabricator.wikimedia.org/T97483) (owner: 10Deskana)
[00:02:14] <grrrit-wm>	 (03CR) 10Fjalapeno: [C: 031] Styling tweaks from Vibha and Katie. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207321 (owner: 10Mhurd)
[00:03:03] <grrrit-wm>	 (03CR) 10Deskana: "To test this patch:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207322 (https://phabricator.wikimedia.org/T97483) (owner: 10Deskana)
[00:03:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Improve trademark code in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[00:04:15] <JonKatz>	 jdlrobson rmoen anyone else having trouble accessing wmflabs?
[00:04:18] <grrrit-wm>	 (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[00:04:36] <JonKatz>	 jdlrobson rmoen I am only having trouble from my iphone
[00:07:39] <rmoen>	 JonKatz: its up for me
[00:08:05] <JonKatz>	 rmoen, so strange.  I haven't been able to access from phone for 2 days
[00:08:24] <JonKatz>	 rmoen, works fine from desktop...must be my phone
[00:09:12] <mhurd>	 coreyfloyd: wanna just merge those style tweaks?
[00:11:30] <coreyfloyd>	 mhurd: sure
[00:11:35] <grrrit-wm>	 (03CR) 10Fjalapeno: [C: 032] Styling tweaks from Vibha and Katie. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207321 (owner: 10Mhurd)
[00:12:43] <mhurd>	 coreyfloyd: adam says if you want to cut the build tonight is good to go, but can wait till morn too
[00:14:43] <mhurd>	 kaity: thanks so much!
[00:21:11] <mhurd>	 coreyfloyd: aw crap. i found a stupid bug...
[00:24:41] <grrrit-wm>	 (03PS1) 10Jdlrobson: Add optin to beta panel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207335 (https://phabricator.wikimedia.org/T96286) 
[00:26:14] <grrrit-wm>	 (03CR) 10Bmansurov: "Should the patch not depend on an abandoned patch?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[00:26:35] <grrrit-wm>	 (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[00:28:08] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Avoid requesting unused information from API in NearbyFetchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207030 (owner: 10Deskana)
[00:28:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid requesting unused information from API in NearbyFetchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207030 (owner: 10Deskana)
[00:36:08] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Hygiene: add some documentation to OnboardingActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207032 (owner: 10Deskana)
[00:36:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: add some documentation to OnboardingActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207032 (owner: 10Deskana)
[00:38:07] <coreyfloyd>	 mhurd: was that the only thing we were waiting for?
[00:38:16] <coreyfloyd>	 If so, I can deploy again
[00:38:42] <grrrit-wm>	 (03PS3) 10Kaldari: Improve trademark code in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) 
[00:38:53] <mhurd>	 coreyfloyd: ya. i found a bug in the page issues w eta for fix ~30 min. if you want to wait for that cool. if not, it's a pretty edge case...
[00:47:20] <mhurd>	 coreyfloyd: got the fix working... submitting in just a minute...
[00:47:34] <coreyfloyd>	 mhurd: yeah np
[00:55:29] <grrrit-wm>	 (03PS1) 10Mhurd: Fix for similar pages bug exibited on enwiki page "absidia". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207342 
[00:55:33] <mhurd>	 coreyfloyd: ^
[00:56:57] <grrrit-wm>	 (03PS2) 10Mhurd: Fix for similar pages bug exibited on enwiki page "absidia". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207342 
[00:57:55] <grrrit-wm>	 (03PS3) 10Mhurd: Fix for similar pages bug exibited on enwiki page "absidia". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207342 
[00:58:29] <mhurd>	 dbrant: hey you around?
[00:58:38] <dbrant>	 mhurd: yep!
[00:58:51] <mhurd>	 dbrant: quick batcave?
[00:58:55] <dbrant>	 sure
[01:17:00] <coreyfloyd>	 mhurd: thanks
[01:38:25] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Fix for some pages incorrectly showing as protected [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207322 (https://phabricator.wikimedia.org/T97483) (owner: 10Deskana)
[01:39:26] <mhurd>	 coreyfloyd: the fix is here: https://gerrit.wikimedia.org/r/207342 
[01:39:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix for some pages incorrectly showing as protected [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207322 (https://phabricator.wikimedia.org/T97483) (owner: 10Deskana)
[01:39:54] <coreyfloyd>	 mhurd: sorry ate some dinner real quick - I’m back now
[01:40:10] <mhurd>	 coreyfloyd: oops sorry i didn't see your earlier response
[01:40:29] <coreyfloyd>	 mhurd: yeah i just got distracted with food
[01:40:41] <mhurd>	 coreyfloyd: that's good! :)
[01:41:41] <grrrit-wm>	 (03CR) 10Fjalapeno: [C: 032] Fix for similar pages bug exibited on enwiki page "absidia". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207342 (owner: 10Mhurd)
[01:43:49] <dbrant>	 niedzielski-mobi: around?
[01:44:11] <mhurd>	 coreyfloyd: woohoo!
[01:53:07] <grrrit-wm>	 (03PS1) 10Legoktm: API: 'editable' is a legacy boolean, don't convert it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207358 
[01:53:38] <grrrit-wm>	 (03CR) 10Legoktm: "I didn't check whether any other properties need similar handling..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207358 (owner: 10Legoktm)
[01:54:41] <legoktm>	 Deskana: ^
[02:59:22] <vibha>	 coreyfloyd: please add something to the wikipedia experimental icon if you can. Really hard figuring out which one the exp app is.
[02:59:55] <coreyfloyd>	 vibha: sure
[03:52:36] <niedzielski>	 coreyfloyd: hey. do you happen to know if there a gimp / photoshop file for the app icons? i was looking for the source image recently for a similar problem in the android apps
[03:53:18] <coreyfloyd>	 niedzielski: hmmm… its an svg… just a sec
[03:54:02] <coreyfloyd>	 niedzielski: https://www.dropbox.com/s/55vovt9mem7ojpx/icon-prod.svg?dl=0
[03:54:57] <niedzielski>	 coreyfloyd: ah, ok. the one for android is a bit different :/ i've only been able to find the pngs so far
[04:06:38] <grrrit-wm>	 (03CR) 10Deskana: "Please also backport this change, otherwise when the weekly deploy happens tomorrow every page will show as protected in the Wikipedia app" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207358 (owner: 10Legoktm)
[05:36:39] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] API: 'editable' is a legacy boolean, don't convert it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207358 (owner: 10Legoktm)
[05:38:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: API: 'editable' is a legacy boolean, don't convert it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207358 (owner: 10Legoktm)
[05:42:40] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Add optin to beta panel (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207335 (https://phabricator.wikimedia.org/T96286) (owner: 10Jdlrobson)
[05:50:56] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] "apart from my comment: looks good :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[07:37:03] <grrrit-wm>	 (03CR) 10Alex Monk: "Will this actually work with that space in the wrong place?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207358 (owner: 10Legoktm)
[07:59:32] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Follow up Ia75886c [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207396 
[07:59:50] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "damn..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207358 (owner: 10Legoktm)
[08:10:27] <grrrit-wm>	 (03PS1) 10Dbrant: Eliminate "read next." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207398 (https://phabricator.wikimedia.org/T96709) 
[08:50:50] <phuedx>	 morning
[09:07:00] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Follow up Ia75886c [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207396 (owner: 10Florianschmidtwelzow)
[09:09:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow up Ia75886c [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207396 (owner: 10Florianschmidtwelzow)
[09:12:05] <joakino>	 morning!
[09:14:54] <phuedx>	 hey joakino
[09:15:05] <joakino>	 morning phuedx 
[09:15:17] <joakino>	 phuedx: the backlog of wikimedia-staff is so fun
[09:15:27] <joakino>	 <3 irccloud for that
[09:16:33] <phuedx>	 joakino: i'm taking the backport request right now
[09:16:35] <phuedx>	 just fyi
[09:17:15] <joakino>	 phuedx: i just saw it
[09:17:24] <joakino>	 phuedx: that's a swat deploy right?
[09:17:38] <phuedx>	 nope, just a backport to the deployment branches
[09:17:47] <phuedx>	 so that when they ride the train tomo it'll all be good
[09:17:52] <joakino>	 oh ok
[09:17:56] <phuedx>	 (i think)
[09:18:01] <phuedx>	 i'll clarify once i've merged the changes
[09:18:06] <joakino>	 yep haha
[09:18:12] <joakino>	 not much info on the email
[09:25:28] <grrrit-wm>	 (03PS1) 10Phuedx: API: 'editable' is a legacy boolean, don't convert it [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207403 
[09:25:30] <grrrit-wm>	 (03PS1) 10Phuedx: Follow up Ia75886c [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207404 
[09:28:19] <grrrit-wm>	 (03PS1) 10Phuedx: API: 'editable' is a legacy boolean, don't convert it [extensions/MobileFrontend] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207405 
[09:28:21] <grrrit-wm>	 (03PS1) 10Phuedx: Follow up Ia75886c [extensions/MobileFrontend] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207406 
[09:34:09] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] API: 'editable' is a legacy boolean, don't convert it [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207403 (owner: 10Phuedx)
[09:35:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: API: 'editable' is a legacy boolean, don't convert it [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207403 (owner: 10Phuedx)
[09:36:09] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Follow up Ia75886c [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207404 (owner: 10Phuedx)
[09:36:24] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] API: 'editable' is a legacy boolean, don't convert it [extensions/MobileFrontend] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207405 (owner: 10Phuedx)
[09:38:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow up Ia75886c [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207404 (owner: 10Phuedx)
[09:40:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: API: 'editable' is a legacy boolean, don't convert it [extensions/MobileFrontend] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207405 (owner: 10Phuedx)
[09:40:42] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Follow up Ia75886c [extensions/MobileFrontend] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207406 (owner: 10Phuedx)
[09:41:43] <joakino>	 god the spam
[09:41:53] <joakino>	 i'm really getting tired of this channel
[09:42:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow up Ia75886c [extensions/MobileFrontend] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207406 (owner: 10Phuedx)
[09:48:49] <phuedx>	 good
[09:48:53] <phuedx>	 we don't want you here anyway
[09:51:15] <joakino>	 phuedx: i knew it! (╯°□°）╯︵ ┻━┻)
[09:51:24] <joakino>	 phuedx: do you run iterm2
[09:51:24] <joakino>	 ?
[09:52:23] <joakino>	 ok nothing, i selected alt to Meta the other day, reverting it to Esc+ fixed the alt behavior
[10:02:31] <phuedx>	 joakino: i run iterm2
[10:02:31] <phuedx>	 sorry, was emailing
[10:02:31] <joakino>	 noprob!
[10:31:11] <grrrit-wm>	 (03PS2) 10Jhernandez: Hygiene: Split SpecialGather resource loader modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207172 (https://phabricator.wikimedia.org/T97456) 
[10:31:13] <grrrit-wm>	 (03PS2) 10Jhernandez: Fully render collections list with templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) 
[10:31:22] <grrrit-wm>	 (03CR) 10Jhernandez: Hygiene: Split SpecialGather resource loader modules (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207172 (https://phabricator.wikimedia.org/T97456) (owner: 10Jhernandez)
[10:33:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fully render collections list with templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) (owner: 10Jhernandez)
[10:52:19] <grrrit-wm>	 (03PS3) 10Jhernandez: Fully render collections list with templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) 
[11:04:05] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 04-1] "There's some linting errors and the qunit tests are failing." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) (owner: 10Jdlrobson)
[11:15:06] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Make it clearer collections are personal opinion [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206963 (https://phabricator.wikimedia.org/T96931) (owner: 10Jdlrobson)
[11:16:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make it clearer collections are personal opinion [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206963 (https://phabricator.wikimedia.org/T96931) (owner: 10Jdlrobson)
[11:31:04] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 (owner: 10Jdlrobson)
[11:33:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Correct API module name inconsistency [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207009 (owner: 10Jdlrobson)
[11:37:12] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] QUnit tests: Don't hit the API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207285 (https://phabricator.wikimedia.org/T97376) (owner: 10Jdlrobson)
[11:38:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: QUnit tests: Don't hit the API [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207285 (https://phabricator.wikimedia.org/T97376) (owner: 10Jdlrobson)
[12:07:09] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Reflect some upstream changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203229 (https://phabricator.wikimedia.org/T97338) (owner: 10Jdlrobson)
[12:09:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reflect some upstream changes [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203229 (https://phabricator.wikimedia.org/T97338) (owner: 10Jdlrobson)
[12:35:03] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) (owner: 10Jdlrobson)
[12:36:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Gather as desktop beta feature infrastructure [extensions/Gather] - 10https://gerrit.wikimedia.org/r/202061 (https://phabricator.wikimedia.org/T97084) (owner: 10Jdlrobson)
[14:01:27] <grrrit-wm>	 (03PS5) 10Mholloway: Use a higher-res image if available and set it to the width of the column text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205649 (https://phabricator.wikimedia.org/T94646) 
[14:13:00] <grrrit-wm>	 (03PS10) 10Florianschmidtwelzow: Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) 
[14:42:26] <phuedx>	 ugh
[14:42:52] <phuedx>	 the faux-beacon stuff that we do isn't as neat as i thought it might be
[14:49:27] <FlorianSW>	 phuedx: you deployed https://gerrit.wikimedia.org/r/#/c/207358/ to wmf2 and wmf3, right?
[14:49:59] <phuedx>	 FlorianSW: i merged the backports but they've yet to be deployed
[14:50:20] <FlorianSW>	 phuedx: ah, ok :) is it planned for today's swat?
[14:51:00] <phuedx>	 FlorianSW: i've just received the email saying "deploy 'em!"
[14:51:04] <phuedx>	 so, erm, yes!
[14:51:22] <FlorianSW>	 phuedx: great :D thanks
[14:52:11] * phuedx gets doing the submodule updates
[14:52:13] <FlorianSW>	 would it be ok for you, if i schedule it on https://wikitech.wikimedia.org/wiki/Deployments, just for tracking? :)
[14:53:09] <FlorianSW>	 phuedx: ^
[14:53:20] <phuedx>	 FlorianSW: sure -- i'll line up the submodule updates as the changes are merged
[14:53:33] <FlorianSW>	 phuedx: ok :)
[14:53:59] * phuedx is still fetching core :/
[14:56:08] <FlorianSW>	 phuedx: https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=156430&oldid=156429
[14:56:13] <FlorianSW>	 phuedx: yeah, core :D
[14:56:29] <phuedx>	 96% and counting
[14:57:48] <FlorianSW>	 counting? Really? o.O
[15:10:18] <grrrit-wm>	 (03PS5) 10BearND: Tighten Up Drawer Drag Margins [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205522 (https://phabricator.wikimedia.org/T96341) (owner: 10Niedzielski)
[15:10:26] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Tighten Up Drawer Drag Margins [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205522 (https://phabricator.wikimedia.org/T96341) (owner: 10Niedzielski)
[15:12:14] <grrrit-wm>	 (03PS6) 10BearND: Minor improvements to readme [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski)
[15:12:20] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Minor improvements to readme [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski)
[15:17:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tighten Up Drawer Drag Margins [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205522 (https://phabricator.wikimedia.org/T96341) (owner: 10Niedzielski)
[15:17:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Minor improvements to readme [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205069 (owner: 10Niedzielski)
[15:22:16] <niedzielski>	 bearND: mholloway hey all. it sounds like my account stuff is sorted. my new address is sniedzielski@wikimedia.org. that's with a trailing i not a y. the old y address might stick around for a short bit so please take care to avoid it
[15:22:36] <mholloway>	 niedzielski: great, will do!
[15:22:56] <bgerstle>	 bearND: do you have a feature list for the content service?
[15:23:18] <bgerstle>	 (i mean the prototype you've been working on)
[15:24:05] <bearND>	 niedzielski: great! I'm glad that's resolved. Now we can do some more onboarding stuff
[15:24:21] <bgerstle>	 just trying to get a better idea about API stuff in prep for SOS, and https://phabricator.wikimedia.org/T87824 doesn't tell me much
[15:24:38] <niedzielski>	 bearND: woot!
[15:25:53] <bearND>	 bgerstle: well, it's bascially creating an HTML page, and the goal is to run most of the JS transforms on the server side once, instead of on every client
[15:26:51] <bearND>	 bgerstle: you can see it in action on https://appservice.wmflabs.org/en.m.wikipedia.org/v1/mobile/app/page/html/Dilbert
[15:27:07] <bearND>	 but it still needs some TLC
[15:27:08] <bgerstle>	 bearND: i'm thinking more about how we can clearly communicate what we want to API team(s)
[15:27:21] <bgerstle>	 w/o them having to use it or read the code
[15:27:40] <bgerstle>	 bearND: are there any API docs?
[15:28:59] <bearND>	 bgerstle: The new service is a REST service. You pass in the page title as the last part of the URI. And the site is specified in the middle part of the URI.
[15:30:29] <bearND>	 bgerstle: The payload is basically HTML with some embedded JSON for the metadata. But that still needs to be hooked up from the app.
[15:31:21] <bearND>	 bgerstle: Once we've got it working end to end then we can talk about making it more public and specify more.
[15:37:59] <grrrit-wm>	 (03CR) 10BearND: "The CSS changes should be done also in the MobileApp extension (https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/MobileApp,d" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205649 (https://phabricator.wikimedia.org/T94646) (owner: 10Mholloway)
[15:40:07] <grrrit-wm>	 (03PS1) 10Jdlrobson: Add missing images [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207465 (https://phabricator.wikimedia.org/T97084) 
[16:05:35] <marsje>	 good evening... is this the right place to start to find a solution for the mobile wikipedia site not working on my mobile browser?
[16:07:50] <marsje>	 I have a Nokia N9 (Meego OS) and it used to work fine with m.wikipedia.org until a few weeks ago. Unfortunately I'm automatically redirected to the mobile version and the link to go back to the desktop version has disappeared, as wel as the rest of the content
[16:13:09] <marsje>	 my user agent: Mozilla/5.0 (MeeGo; NokiaN9) AppleWebKit/534.13 (KHTML, like Gecko) NokiaBrowser/8.5.0 Mobile Safari/534.13
[16:13:39] * marsje is AFK
[16:39:58] <joakino>	 hi marsje
[16:41:12] <joakino>	 marsje: would you mind filing a phabricator bug with the mobile-web project?
[16:42:40] <kristenlans>	 niedzielski: it's official :-) https://www.mediawiki.org/wiki/Wikimedia_Apps/Team#Who.27s_on_the_team
[16:43:41] <niedzielski>	 kristenlans: yay!
[16:45:35] <wikibugs>	 6Mobile-Web: Strange behavior of mobile wikipedia - https://phabricator.wikimedia.org/T97546#1245987 (10Jhernandez) 3NEW
[16:46:15] <joakino>	 marsje: ^ opened a bug for you. Please feel free to chime in and provide more information (screenshots and urls would be awesome for reproducing the problem)
[16:46:45] <kristenlans>	 niedzielski: next time you're in SF, we can try to wrangle some time with the staff photographer for your staff photo (if you want one).
[16:47:04] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Spike: Following - https://phabricator.wikimedia.org/T94243#1245996 (10Jdlrobson) Another proposal: We make it possible to add a collection to a collection (mind blown) The way this would work - we reserve a name space e.g. GatherList:<id> which you can visit and add to...
[16:47:27] <niedzielski>	 kristenlans: that'd be great! i'm actually in next week
[16:48:30] <niedzielski>	 kristenlans: if it doesn't pan out, a friend told me about a food stand in denver called "Wikipita". i can just get my picture in front of it instead ;)
[16:49:21] <kristenlans>	 niedzielski: hahaha. That woudl be pretty cool. 
[16:49:25] <niedzielski>	 it looks like this is it: http://www.wikipita.me/
[16:52:48] <kristenlans>	 niedzielski: woah that looks good
[16:55:34] <phuedx|AFK>	 jdlrobson: can you do scrum of scrums today?
[16:57:59] <wikibugs>	 10Gather Sprint Greatest Hits: Redirect /by/User/123 to /id/123/My-awesome-collection - https://phabricator.wikimedia.org/T97436#1246026 (10Jdlrobson) Ping @moushira
[16:58:58] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Discussion: Flow of cards in lists (of collections or items) is top down - https://phabricator.wikimedia.org/T97309#1246031 (10Jdlrobson) a:3Jdlrobson
[16:59:28] <wikibugs>	 10Gather, 3Mobile-Web-Design: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1246032 (10Jdlrobson)
[16:59:39] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] Show "Read in other languages" only if article exists in other languages (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206627 (https://phabricator.wikimedia.org/T68198) (owner: 10Deskana)
[17:00:24] <wikibugs>	 10Gather, 10MediaWiki-Vagrant, 5Patch-For-Review: Vagrant role for Gather not working - https://phabricator.wikimedia.org/T97541#1246034 (10Jdlrobson) Is this working now @tgv ?
[17:01:57] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1246036 (10Mholloway) @Krenair, do you happen to recall when these crashes started showing up in OTRS?    I have...
[17:01:59] <wikibugs>	 10Gather Sprint Greatest Hits: Redirect /by/User/123 to /id/123/My-awesome-collection - https://phabricator.wikimedia.org/T97436#1246038 (10Jdlrobson) Sorry @Moushira wrong bug.  @jhernandez what is the motivation here? Avoiding us showing up twice in search results? Tech debt?  I actually think multiple urls ar...
[17:02:01] <wikibugs>	 10Gather Sprint Greatest Hits: Redirect /by/User/123 to /id/123/My-awesome-collection - https://phabricator.wikimedia.org/T97436#1246040 (10Jhernandez) Sorry I meant to suggest to ping her on T97488 not on this one :S Crappy internet :(
[17:02:36] <grrrit-wm>	 (03PS4) 10Deskana: Show "Read in other languages" only if article exists in other languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206627 (https://phabricator.wikimedia.org/T68198) 
[17:03:02] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1246047 (10Jdlrobson) @khammerstein @msyed can we get a mock for this so we can start working on it?
[17:03:33] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1246049 (10Jdlrobson) @Aaron any ideas about this?
[17:03:43] <grrrit-wm>	 (03PS5) 10Deskana: Show "Read in other languages" only if article exists in other languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206627 (https://phabricator.wikimedia.org/T68198) 
[17:04:10] <wikibugs>	 10Gather Sprint Greatest Hits: Enable Gather on WikiVoyage - https://phabricator.wikimedia.org/T97488#1246051 (10Jdlrobson) @Moushira is fine with this :) Whoever does this just needs to coordinate with her when it happens. Any preference on the when?
[17:04:31] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1246052 (10Krenair) No idea, sorry. You can probably search for it.
[17:06:01] <wikibugs>	 10Gather Sprint Greatest Hits: Redirect /by/User/123 to /id/123/My-awesome-collection - https://phabricator.wikimedia.org/T97436#1246054 (10Jhernandez) @jdlrobson I don't know I feel like it should have a unique url, I guess it is just taste.
[17:07:50] <wikibugs>	 10Gather Sprint Greatest Hits: Enable Gather on WikiVoyage - https://phabricator.wikimedia.org/T97488#1246070 (10Jhernandez) Ping @Moushira, this is on the pipeline so we're going to try to enable it this week or next one and it depends on if we ride the train it may take another week to be actually live.  Have...
[17:08:00] <wikibugs>	 6Mobile-Web: Extremely high amount of errors for anonymous editors - https://phabricator.wikimedia.org/T97494#1246071 (10Jdlrobson) In theory 'http' error should only happen when a user cannot get an edit token (in this.postWithToken the deferred object must be rejected which only seems to happen if this.get( {...
[17:08:23] <wikibugs>	 6Mobile-Web, 10VisualEditor: Extremely high amount of errors for anonymous editors - https://phabricator.wikimedia.org/T97494#1246083 (10Jdlrobson)
[17:11:02] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1246086 (10Yurik) @Tgr, you mean ``` SELECT gli_gl_id FROM gather_list_item gli WHERE EXISTS (SELECT 1 FROM gather_list_item gli2    WHERE gli.gli_gl_id = gli2.gli_gl_id AND NOT (gli.gli_name...
[17:11:44] <wikibugs>	 6Mobile-Web, 6Collaboration-Team, 10Flow, 7I18n: the message mobile-frontend-last-modified-with-user-just-now appears unnecessarily on the top of Flow mobile web pages - https://phabricator.wikimedia.org/T91886#1246087 (10KLans_WMF)
[17:12:50] <wikibugs>	 6Mobile-Web: Initial banner image should be delivered as part of the initial response - https://phabricator.wikimedia.org/T90698#1246091 (10KLans_WMF)
[17:15:45] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Editor broken on new pages - https://phabricator.wikimedia.org/T97474#1243352 (10KLans_WMF)
[17:16:33] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Spike: Following - https://phabricator.wikimedia.org/T94243#1246097 (10JKatzWMF) @jdlrobson  Mind blown.  This seems like a creative solution.  For the sake of simplicity let's assume we don't want to surface the ability to add collections to collections to the user.  I...
[17:16:54] <kristenlans>	 bgerstle: stand@
[17:19:51] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Spike: Following - https://phabricator.wikimedia.org/T94243#1246106 (10Jdlrobson) @tgv would this be sane? It would also allow us to start experimenting with page like features by tying a collection to a page. Cc @yurik
[17:20:06] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Spike: Following - https://phabricator.wikimedia.org/T94243#1246108 (10Jdlrobson) @tgr ^
[17:22:29] <marsje>	 joakino: thanks!
[17:23:21] <marsje>	 I can't login with my wikipedia account there?
[17:23:33] <joakino>	 marsje: yes you can
[17:24:26] <joakino>	 marsje: here https://phabricator.wikimedia.org/auth/start/?next=%2F see the button at the bottom that says Login or Register MediaWiki with the sunflower logo
[17:24:40] <joakino>	 marsje: that should let you login with the wikipedia account
[17:24:59] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Create accounts for Build server and update Fastlane / Jenkins to securely use accounts - https://phabricator.wikimedia.org/T94426#1246122 (10Fjalapeno) a:5Fjalapeno>3BGerstle-WMF
[17:27:31] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Spike: Flagging - https://phabricator.wikimedia.org/T96282#1246137 (10Jdlrobson) Similar to T94243 I wonder if we could have a reserved collection id -2 that means 'reported collections' We could maintain a count in the collection of reported collections it appears in...
[17:28:21] <phuedx>	 jdlrobson: ping?
[17:28:43] <coreyfloyd>	 bgerstle: mhurd dr0ptp4kt will be updating the release cards / wiki in the very near future
[17:30:34] <phuedx>	 JonKatz: i appear to have scrum of scrums and our catchup scheduled at the same time
[17:30:59] <JonKatz>	 phuedx darn, feel like we had a lot to discuss.
[17:31:12] <phuedx>	 i've been trying to ping jdlrobson
[17:31:15] <JonKatz>	 phuedx i'll resched
[17:31:39] <phuedx>	 bgerstle: could you rep mobile web too? i believe there's nothing we want to flag
[17:32:08] <bgerstle>	 phuedx: i'm in the meeting, why don't you add stuff to the etherpad?
[17:32:16] <phuedx>	 ^ i could totally do that
[17:32:26] <phuedx>	 JonKatz: in the hangout
[17:32:47] <bgerstle>	 phuedx: i'll do my best to rep mobile clients in general, i'll follow up w/ you afterwards to see if i missed anything
[17:33:50] <coreyfloyd>	 mhurd: i did not get to your patch this morning - you want to look at anything now together?
[17:34:15] <dr0ptp4kt>	 coreyfloyd: thank you for updating the release cards
[17:34:19] <dr0ptp4kt>	 (thanks in advance)
[17:35:09] <mhurd>	 coreyfloyd: oh sorry i ended up staying a bit late playing w data layer bits. i did get it working. i have a little more hooking up to do but will submit hopefully this morning...
[17:35:32] <coreyfloyd>	 mhurd: ok - just let me know
[17:35:36] <mhurd>	 mholloway: hey sorry i missed chatting yesterday. did you get the image maps bits figured out?
[17:36:14] <mholloway>	 mhurd: hey, no worries.  i was just curious to see if the issue you were working on was similar, but i got it figured out!
[17:36:42] <mhurd>	 mholloway: maybe bat cave later today and step me through it?
[17:37:02] <mhurd>	 mholloway: i'm curious :)
[17:38:01] <mholloway>	 mhurd: sure, let's touch base in a bit
[17:38:20] <mhurd>	 mholloway: cool!
[17:39:18] <kaldari>	 phuedx: can I add you as an annual reviewer for myself?
[17:39:39] <joakino>	 ^ wat?
[17:42:04] <bmansurov>	 phuedx: should we move ahead with https://gerrit.wikimedia.org/r/#/c/207005/ without resolving the "fake" blocker
[17:42:07] <jdlrobson>	 sorry phuedx
[17:43:34] <jdlrobson>	 bmansurov: see [reading-wmf] promoting alpha header to beta thread
[17:43:58] <jdlrobson>	 and sorry for being so hard on all this work. It's no reflection of the effort you've all put into it, i just feel like we're approaching it wrong.
[17:44:16] <jdlrobson>	 bmansurov: do you know what sam wanted to raise in scrum of scrums?
[17:44:42] <bmansurov>	 jdlrobson: no, he hasn't mentioned scrum of scrums to me
[17:45:13] <jdlrobson>	 ok ill wing it
[17:50:22] <phuedx>	 jdlrobson: nothing, there's nothing to mention
[17:50:30] <jdlrobson>	 bmansurov: also -1 relates to other comments not blocking bug
[17:50:30] <phuedx>	 wikigrok went out and will be coming back in again?
[17:50:37] <jdlrobson>	 phuedx: already got you covered ;-)
[17:50:42] <phuedx>	 :D
[17:50:43] <phuedx>	 <3
[17:51:17] <bmansurov>	 jdlrobson: I'd rather wait and see if that work is really needed because the blocker is completely different from what I'm doing
[17:51:37] <jdlrobson>	 yeh i know. i guess/hope email thread will help get everyone on same page.
[17:53:32] <kaldari>	 rmoen, jdlrobson: Don’t forget that (Gather master minus one day) is riding the train to English Wikipedia today. As soon as en.wiki is upgraded to 1.26wmf2 (probably within the next hour), you’ll want to test it.
[17:53:49] <kaldari>	 oops I meant 1.26wmf3
[17:54:03] <wikibugs>	 10Gather Sprint Greatest Hits: Enable Gather on WikiVoyage - https://phabricator.wikimedia.org/T97488#1246213 (10Jdlrobson) https://en.wikivoyage.org/w/index.php?title=Wikivoyage%3ATravellers%27_pub&diff=2766750&oldid=2766692
[17:55:18] <wikibugs>	 10Gather, 10Continuous-Integration-Config: PHPUnit tests do not get run by Jenkins for Gather commits - https://phabricator.wikimedia.org/T96904#1246216 (10Jdlrobson) Really? We submitted a patch causing tests to fail which didn't get picked up by Jenkins. We have some api tests that should be running as well...
[17:56:11] <jdlrobson>	 kaldari: what time?
[17:56:15] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] Eliminate "read next." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207398 (https://phabricator.wikimedia.org/T96709) (owner: 10Dbrant)
[17:56:27] <rmoen>	 kaldari: roger that.  I'm on standby
[17:56:40] <kaldari>	 jdlrobson: the window is between 11 and 1pm I believe. You’ll need to ask on #wikimedia-operations for more details
[17:57:57] <rmoen>	 is this Q4 Reading Web Engineering a tech lead meeting? 
[17:58:56] <jdlrobson>	 rmoen: everyone meeting
[18:00:21] <kristenlans>	 uhoh niedzielski is this what you mentioned at standup: "550 Address sniedzielsky@wikimedia.org does not exist"
[18:01:08] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Sprint 55 Releasing - https://phabricator.wikimedia.org/T95969#1246243 (10Fjalapeno)
[18:01:09] <niedzielski>	 kristenlans: that's the old address. my new one is the super different sniedzielski@wikimedia.org. it's got an i instead of a y
[18:01:19] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Sprint 55 Release - https://phabricator.wikimedia.org/T95969#1205258 (10Fjalapeno)
[18:02:00] <kristenlans>	 niedzielski: IT will make you a forwarder if that helps
[18:02:21] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Remove "read next" from the beta app - https://phabricator.wikimedia.org/T96709#1246262 (10Niedzielski) This might fix T96246 since that's appears to be related to read next functionality.
[18:03:44] <niedzielski>	 kristenlans: thansk but i think since i just started the impact should be minimal. i don't want to encourage any misspellings of my name :)
[18:04:24] <kristenlans>	 niedzielski: totally understandable :-)
[18:28:51] <wikibugs>	 6Mobile-Web: Strange behavior of mobile wikipedia - https://phabricator.wikimedia.org/T97546#1246368 (10Marcelvb) Hi, this is marsje :-)  The page seems to load fine, but after a second or so, it gets messed up. Seems like a loaded css or js file is making half the page disappear.  Top of page: {F158638}  Middle...
[18:29:09] * marsje sees himself
[18:32:29] <coreyfloyd>	 dr0ptp4kt: who to push a tag to gerri again?
[18:32:32] <coreyfloyd>	 how
[18:32:56] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 3Roadmap, 7notice: Production release for the Android Wikipedia app on 29th April 2015 - https://phabricator.wikimedia.org/T97064#1246391 (10bearND) First draft of "What's new": * ShareAFact card design improvements * Detect network connectivity in ca...
[18:33:29] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Sprint 55 Release - https://phabricator.wikimedia.org/T95969#1246392 (10Fjalapeno)
[18:35:35] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Sprint 55 Release - https://phabricator.wikimedia.org/T95969#1246415 (10Fjalapeno)
[18:37:06] <coreyfloyd>	 dr0ptp4kt: mhurd bgerstle owe my dog a walk - bb30
[18:37:19] <dr0ptp4kt>	 coreyfloyd: thx
[18:38:14] <bgerstle>	 o/
[18:38:42] <niedzielski>	 bearND: mholloway so i guess we use ACRA / Google Play / Amazon Appstore / other storefronts for our crash reports? how does one obtain access to view the logs?
[18:40:05] <dr0ptp4kt>	 niedzielski: tfinc has the google play access control for the moment if needed. as for the other places, bearND lemme know if you need me to do anything
[18:40:21] <bearND>	 niedzielski: The ACRA crash reports go to an email address, which leads to OTRS. So, once you get OTRS access you can get both crash reports and written user feedback
[18:40:49] <wikibugs>	 6Mobile-Web, 10VisualEditor: Extremely high amount of errors for anonymous editors - https://phabricator.wikimedia.org/T97494#1246419 (10Anomie) >>! In T97494#1246071, @Jdlrobson wrote: > this.get( { action: 'tokens', type: type, assert: assert } );  What are your values for "type" and "assert" there? In parti...
[18:41:19] <bearND>	 niedzielski: There are two OTRS queues: one for general feedback and another for crash reports. You'll want to sign up for both. (Shift-click)
[18:42:02] <niedzielski>	 bearND: dr0ptp4kt cool, thanks
[18:42:19] <bearND>	 niedzielski: There are basically no crash reports in Google Play since it all goes through ACRA to OTRS.
[18:45:37] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: NPE crashes from android.webkit.AccessibilityInjector$TextToSpeechWrapper$1.onInit - https://phabricator.wikimedia.org/T89077#1246426 (10Niedzielski) 5Open>3stalled
[18:46:21] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: NPE crashes from android.webkit.AccessibilityInjector$TextToSpeechWrapper$1.onInit - https://phabricator.wikimedia.org/T89077#1027028 (10Niedzielski) I cannot repro on 4.2.x stock nor Genymotion emulators with Google Talkback. Waiting for OTRS access for...
[18:48:13] <wikibugs>	 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186#1246432 (10Jdforrester-WMF) p:5Triage>3Normal
[18:58:55] <wikibugs>	 10Wikipedia-iOS-App, 3App-Process-Improvement, 3Mobile-App-Sprint-56-iOS: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1246485 (10mmodell) As for an invite to the beta, this IS the invite ;)
[19:04:40] <vibha>	 coreyfloyd: Got the build. Have 2 meetings for UX debt - I will likely get back to you tomorrow morning.
[19:04:41] <joakino>	 im out!
[19:04:44] <joakino>	 have a nice day
[19:04:45] <vibha>	 Earlier if possible but no promises
[19:06:56] <niedzielski>	 bearND: mholloway i had some misc questions on our unit test and ci goals. do you guys have some time to chat this week to chat about it?
[19:06:57] <jdlrobson>	 \o
[19:08:06] <phuedx>	 gonna take a break until the prioritisation meeting
[19:11:41] <bearND>	 niedzielski: Yes, let's chat about that in a bit. In the meantime there are basically two tasks related to CI for that: https://phabricator.wikimedia.org/T88494 + https://phabricator.wikimedia.org/T62720.
[19:19:07] <niedzielski>	 bearND: thanks, sounds good
[19:21:37] <kaldari>	 mhurd: https://phabricator.wikimedia.org/T97566#1246616
[19:26:02] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 3Roadmap, 7notice: Production release for the Android Wikipedia app on 29th April 2015 - https://phabricator.wikimedia.org/T97064#1246656 (10Deskana) @bearND Here's some suggested improvements to it, to remove language that users might not be familiar...
[19:27:48] <coreyfloyd>	 kristenlans: updated status of tix on process board: https://phabricator.wikimedia.org/project/sprint/profile/1175/
[19:30:57] <wikibugs>	 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, and 2 others: Rewrite the edit summary screen of VisualEditorOverlay in OOjs UI  - https://phabricator.wikimedia.org/T96188#1246675 (10Jdforrester-WMF)
[19:32:42] <wikibugs>	 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, and 2 others: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1246680 (10Jdforrester-WMF)
[19:33:18] <wikibugs>	 6Mobile-Web, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Rewrite VisualEditorOverlay header using OOjs UI - https://phabricator.wikimedia.org/T96187#1246682 (10Jdforrester-WMF)
[19:36:22] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1246708 (10Mholloway) The first such report on OTRS is from Nov 8, 2014 (and the 2.0-r-2014-11-03 production rele...
[19:37:23] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1246725 (10Mholloway) Not to mention that this started before Lollipop was released.
[19:37:49] <wikibugs>	 10Wikipedia-iOS-App: Section title isn't wrapping correctly - https://phabricator.wikimedia.org/T97569#1246731 (10Vibhabamba) 3NEW a:3dr0ptp4kt
[19:38:36] <grrrit-wm>	 (03PS1) 10BearND: Hygiene: fix preview test [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207536 
[19:41:16] <wikibugs>	 10MobileFrontend-Feature-requests, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6WMF-Design-Research, and 2 others: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1246772 (10Jdforrester-WMF)
[19:43:12] <grrrit-wm>	 (03PS2) 10BearND: Hide caption on "tap to expand" table when open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207227 (https://phabricator.wikimedia.org/T86860) (owner: 10Niedzielski)
[19:43:19] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Hide caption on "tap to expand" table when open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207227 (https://phabricator.wikimedia.org/T86860) (owner: 10Niedzielski)
[19:43:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hide caption on "tap to expand" table when open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207227 (https://phabricator.wikimedia.org/T86860) (owner: 10Niedzielski)
[19:44:10] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] Use a higher-res image if available and set it to the width of the column text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205649 (https://phabricator.wikimedia.org/T94646) (owner: 10Mholloway)
[19:45:37] <grrrit-wm>	 (03PS6) 10BearND: Show "Read in other languages" only if article exists in other languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206627 (https://phabricator.wikimedia.org/T68198) (owner: 10Deskana)
[19:45:43] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Show "Read in other languages" only if article exists in other languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206627 (https://phabricator.wikimedia.org/T68198) (owner: 10Deskana)
[19:46:55] <wikibugs>	 10Wikipedia-Android-App, 7I18n, 3Mobile-App-Sprint-56-Android: Special case Traditional and Simplified Chinese in all language handling - https://phabricator.wikimedia.org/T62743#1246804 (10Niedzielski) Hello, please excuse my ignorance in asking some questions. Is this an issue with app wide language settin...
[19:49:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Show "Read in other languages" only if article exists in other languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/206627 (https://phabricator.wikimedia.org/T68198) (owner: 10Deskana)
[19:53:17] <phuedx>	 back
[19:57:54] <wikibugs>	 10Wikipedia-iOS-App: 4.3.1(96)  'External links' do not display Categories - https://phabricator.wikimedia.org/T97573#1246847 (10Etonkovidova) 3NEW
[20:02:43] <kristenlans>	 coreyfloyd: rawk! thanks for that
[20:03:50] <bearND>	 niedzielski: I'm ready to chat with you about tests and ci
[20:04:14] <wikibugs>	 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 3Mobile-Web-Design: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1246860 (10phuedx)
[20:04:37] <bearND>	 niedzielski: batcave is occupied, but you can ping me directly via hangout
[20:04:44] <niedzielski>	 bearND: gr8! omw
[20:06:13] <wikibugs>	 6Mobile-Web, 10MediaWiki-Authentication-and-authorization, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story, 5Patch-For-Review: Authentication sharing between desktop and mobile Commons is broken - https://phabricator.wikimedia.org/T88860#1246863 (10KLans_WMF)
[20:06:22] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Special:MobileOptions throwing JS error from mobile.watchstar in stable - https://phabricator.wikimedia.org/T92657#1246864 (10KLans_WMF)
[20:06:41] <wikibugs>	 6Mobile-Web, 10MediaWiki-General-or-Unknown, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story, 5Patch-For-Review: oojs ui settings icon and MobileFrontend main menu settings icon are clashing - https://phabricator.wikimedia.org/T97473#1246867 (10bmansurov) 5Open>3Resolved
[20:08:16] <coreyfloyd>	 kristenlans: np - need to keep my sanity… lol
[20:11:50] <wikibugs>	 10Wikipedia-iOS-App: Transfer team iOS Dev Portal Team Agent - https://phabricator.wikimedia.org/T97575#1246881 (10Fjalapeno) 3NEW
[20:14:01] <kaity>	 http://etherpad.wikimedia.org/p/TFMQF
[20:18:23] <wikibugs>	 10Wikipedia-iOS-App: 4.3.1(96) Entering incorrect username triggers the generic warning - "The password you provided is incorrect" - https://phabricator.wikimedia.org/T97571#1246910 (10Etonkovidova)
[20:20:10] <wikibugs>	 10Wikipedia-iOS-App: Separate caching from “saved pages” and “recent pages" - https://phabricator.wikimedia.org/T97576#1246912 (10Fjalapeno) 3NEW
[20:22:32] <wikibugs>	 10Wikipedia-iOS-App: Verify that whenever a user explicitly refreshes a page, that we always make a network request. - https://phabricator.wikimedia.org/T97578#1246930 (10Fjalapeno) 3NEW
[20:22:42] <kaity>	 https://phabricator.wikimedia.org/T88633
[20:27:59] <kaity>	 https://phabricator.wikimedia.org/T97377
[20:31:20] <wikibugs>	 10Wikipedia-iOS-App: 4.0.6.3 Image gallery - not all image info is displayed - https://phabricator.wikimedia.org/T91125#1246955 (10Etonkovidova) Just adding another example. In this example the same image is displayed twice - as a lead image and in the 'Quick facts' infobox. A user can clearly see that the red d...
[20:32:01] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Design: Create a sticky footer with access to watch and Read in another language - https://phabricator.wikimedia.org/T97377#1246957 (10KHammerstein)
[20:33:10] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1246966 (10Mholloway) A couple of other suspects: https://github.com/wikimedia/apps-android-wikipedia/commit/c0ed...
[20:35:06] <wikibugs>	 6Mobile-Web, 7Epic, 7Performance: EPIC: Continuously measure mobile site speed - https://phabricator.wikimedia.org/T94752#1246970 (10KLans_WMF)
[20:37:28] <dbrant>	 niedzielski: hey there! do you have +2 rights in gerrit yet?  (cc bearND)
[20:39:43] <wikibugs>	 6Mobile-Web, 10MediaWiki-Internationalization, 10SEO, 7I18n, 5Patch-For-Review: Improve access to local language wikis by fixing bug in generation of hreflang tags in <head> of article pages - https://phabricator.wikimedia.org/T93213#1246985 (10JKatzWMF)
[20:40:01] <wikibugs>	 6Mobile-Web, 10MediaWiki-Internationalization, 7I18n: Fix canonical URL issues - https://phabricator.wikimedia.org/T93550#1246987 (10JKatzWMF)
[20:41:37] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Hygiene: fix preview test [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207536 (owner: 10BearND)
[20:41:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: fix preview test [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207536 (owner: 10BearND)
[20:45:54] <grrrit-wm>	 (03PS2) 10Dbrant: Eliminate "read next." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207398 (https://phabricator.wikimedia.org/T96709) 
[20:49:55] <wikibugs>	 6Mobile-Web: Send regular mobile site speed reports - https://phabricator.wikimedia.org/T95301#1247027 (10phuedx)
[20:51:09] <wikibugs>	 6Mobile-Web: Table of Contents Overlay accessed from Sticky Footer - https://phabricator.wikimedia.org/T97581#1247032 (10KHammerstein) 3NEW
[20:52:09] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Use the WAN cache for caching [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/207630 (https://phabricator.wikimedia.org/T91815) 
[20:53:01] <grrrit-wm>	 (03PS21) 10Dbrant: Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 
[20:53:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use the WAN cache for caching [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/207630 (https://phabricator.wikimedia.org/T91815) (owner: 10Aaron Schulz)
[20:53:18] <bearND>	 niedzielski: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process
[20:54:04] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1247046 (10bmansurov) a:3bmansurov
[20:56:37] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Design: Give header a max-width so that it is more connected to content on tablet + desktop - https://phabricator.wikimedia.org/T96317#1247054 (10phuedx) I'll double check the 893 px width. I thought the current max-width of the content was 1000 px.
[20:57:05] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Design: Give header a max-width so that it is more connected to content on tablet + desktop - https://phabricator.wikimedia.org/T96317#1247056 (10KLans_WMF) @phuedx and @kaity will confirm current page width
[20:58:15] <wikibugs>	 6Mobile-Web: Tapping on lead image should open image in mobile media viewer - https://phabricator.wikimedia.org/T96404#1247059 (10KHammerstein)
[20:59:25] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Design: Change in-article images to be full width on phones and larger thumb size on tablets - https://phabricator.wikimedia.org/T97199#1247072 (10KLans_WMF) @bearnd @dbrant any insights that you can share on this would be welcome
[21:02:47] <wikibugs>	 6Mobile-Web: Tapping on lead image should open image in mobile media viewer - https://phabricator.wikimedia.org/T96404#1247084 (10phuedx) > The lead image should behave like every other image on the page.  The existing MediaViewer integration for images on mobile (see the `mobile.mediaViewer` module) should be r...
[21:03:11] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Editor broken on new pages - https://phabricator.wikimedia.org/T97474#1247085 (10bmansurov) a:3bmansurov
[21:03:20] <grrrit-wm>	 (03PS22) 10Dbrant: Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 
[21:03:27] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Design: Create a sticky footer with access to watch and Read in another language - https://phabricator.wikimedia.org/T97377#1247087 (10KHammerstein)
[21:03:31] <grrrit-wm>	 (03PS1) 10Bmansurov: Check whether the object exists before checking its property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207634 (https://phabricator.wikimedia.org/T97474) 
[21:05:34] <grrrit-wm>	 (03PS23) 10Dbrant: Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 
[21:06:29] <grrrit-wm>	 (03PS6) 10Dbrant: Link previews (prototypes 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) 
[21:09:54] <grrrit-wm>	 (03PS7) 10Dbrant: Link previews (prototype 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) 
[21:13:49] <niedzielski>	 dbrant: hey! sorry, got a nice overview from bearND. right now, i think only my email is setup so all my other account accesses including gerrit are pending
[21:14:33] <niedzielski>	 dbrant: i'm just continuing to use my personal account for contributions until things get sorted
[21:15:08] <phuedx>	 heading off for the night
[21:15:10] <phuedx>	 g'night folks
[21:18:27] <jhobs>	 JonKatz: hey, any chance we can move our 1:1 on thursday earlier? I volunteer as a teacher once a week and tomorrow is my last class of the semester. The meeting currently conflicts with that
[21:20:26] <dr0ptp4kt>	 bgerstle: i cannot make that meeting at 3 eastern / 6 central, but i trust you have it covered
[21:20:45] <bgerstle>	 k, i'll be sure to send around minutes
[21:20:52] <dr0ptp4kt>	 bgerstle: thx.
[21:21:00] <jhobs>	 3 eastern/6 central???
[21:21:06] <jhobs>	 ;)
[21:23:35] <rmoen>	 Yesterday's gather master is live on en.wiki
[21:23:44] <rmoen>	 JonKatz ^ 
[21:24:14] <jhobs>	 rmoen: you guys don't have a vagrant role up for gather, do you?
[21:24:28] <bd808>	 there's a brand new on
[21:24:32] <bd808>	 *one
[21:24:38] <rmoen>	 jhobs: possibly, there is a task for it in phabricator
[21:25:18] <rmoen>	 jhobs:  I'm on a vagrant boycott.  Probably will start using it again at some point but haven't been for the last month or so.
[21:25:47] <bd808>	 jhobs: It landed last week -- https://gerrit.wikimedia.org/r/#/c/206311/
[21:25:59] <bd808>	 and there was a fix for it from gergo today
[21:26:10] <jhobs>	 bd808: ah looks like my vagrant wasn't updating due to a local change in LocalSettings.php
[21:26:18] <jhobs>	 i see it now though, thanks!
[21:26:22] <bd808>	 yuck
[21:26:38] <rmoen>	 jhobs, not sure what the status is: https://phabricator.wikimedia.org/T97541
[21:26:40] <bd808>	 Make config changes in settings.d/*.php
[21:27:01] <jhobs>	 yeah it was probably an accidental change
[21:27:27] <dbrant>	 mholloway: is everything clear about using the MobileApp extension for generating the CSS?  (feel free to ask!)
[21:27:33] <jhobs>	 hmm... thanks rmoen, I'll check it out
[21:27:39] <JonKatz>	 jhobs no worries i'll change it up
[21:27:43] <JonKatz>	 rmoen--awesome!!
[21:28:01] <JonKatz>	 rmoen thanks for the headsup
[21:28:14] <jhobs>	 thanks JonKatz, ideally I'd like to be done by 2:30 SF time, but can push closer to 3 if absolutely necessary
[21:28:21] <rmoen>	 JonKatz: I've been trolling the ops channel and en.wiki for the last several hours waiting 
[21:28:44] <rmoen>	 Everything seems ok
[21:28:54] <wikibugs>	 6Mobile-Web: "Editing $1" looks bad if word order is changed - https://phabricator.wikimedia.org/T97275#1247137 (10Ricordisamoa)
[21:29:01] <mholloway>	 dbrant: i've actually been digging around on https://phabricator.wikimedia.org/T75236 all day and haven't looked at the in-article images task since bearND commented.  
[21:29:24] <rmoen>	 No errors on logstash
[21:29:39] <JonKatz>	 rmoen good.  it broke my statistics script, which means the api changed will start looking at features.  It's still hard for me to get a grasp of knowing whats included without driving around.  is there a way to see associated tasks?
[21:29:47] <dbrant>	 mholloway: ok, no worries
[21:30:42] <rmoen>	 JonKatz: I think so.. .1 sec
[21:32:35] <rmoen>	 JonKatz: hmmm actually this (https://www.mediawiki.org/wiki/MediaWiki_1.26/wmf3#Gather) is from when the wmf3 branch was cut.  I will have to manually generate a report.
[21:32:50] <JonKatz>	 rmoen in a meeting will reply in 30~
[21:33:22] <rmoen>	 JonKatz: I will send an email
[21:35:17] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 3Roadmap, 7notice: Production release for the Android Wikipedia app on 29th April 2015 - https://phabricator.wikimedia.org/T97064#1247164 (10bearND) @Deskana The text is too long. We need to keep it <= 500 characters to be able to submit it to the store.
[21:35:44] <Deskana>	 bearND: I was just going to ask if you had everything you need for the release.
[21:35:48] <Deskana>	 bearND: You beat me to it!
[21:35:51] <Deskana>	 bearND: Let me tweak the text.
[21:37:41] <wikibugs>	 6Mobile-Web, 7Performance: .column-break-inside-avoid rule appearing on every ResourceLoader module that includes mixins file - https://phabricator.wikimedia.org/T97587#1247210 (10Jdlrobson) 3NEW
[21:37:51] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 3Roadmap, 7notice: Production release for the Android Wikipedia app on 29th April 2015 - https://phabricator.wikimedia.org/T97064#1247217 (10Deskana) @bearND This should be under the limit:  * Minor design tweaks to enhanced sharing feature * Fixed a...
[21:38:03] <Deskana>	 bearND ^ That should do it
[21:41:19] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 3Roadmap, 7notice: Production release for the Android Wikipedia app on 29th April 2015 - https://phabricator.wikimedia.org/T97064#1247225 (10bearND) Great! Thank you. After adding some bullet point chars we've got space for 3 more chars. ;)
[21:41:35] <bearND>	 Deskana: ^ Updated it
[21:43:44] <bearND>	 Deskana: dbrant: going to do a staged rollout of 5%
[21:45:14] <dbrant>	 bearND: \o/  (< arms 5% raised)
[21:46:03] <grrrit-wm>	 (03PS2) 10Jdlrobson: Add optin to beta panel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207335 (https://phabricator.wikimedia.org/T96286) 
[21:46:20] <bearND>	 dbrant: feel free to raise it more later
[21:49:41] <bearND>	 dbrant: would you like to send out the email?
[21:50:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Check whether the object exists before checking its property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207634 (https://phabricator.wikimedia.org/T97474) (owner: 10Bmansurov)
[21:50:54] <jdlrobson>	 bmansurov: do you want to get that patch swated?
[21:51:27] <bmansurov>	 jdlrobson: I'd like to but i'm busy with other stuff. Can you do it if you have time?
[21:51:43] <grrrit-wm>	 (03PS4) 10Kaldari: Improve trademark code in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) 
[21:51:56] <dbrant>	 bearND: nope, go ahead with this one
[21:52:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check whether the object exists before checking its property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207634 (https://phabricator.wikimedia.org/T97474) (owner: 10Bmansurov)
[21:52:11] <dbrant>	 bearND: what stage timetable were you thinking of?
[21:52:16] <grrrit-wm>	 (03CR) 10Kaldari: Improve trademark code in MobileFrontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[21:52:19] <jdlrobson>	 bmansurov: can you at least put it on the wiki page? Maybe Kaldari or I can make sure we are around for the window
[21:52:29] <bmansurov>	 ok
[21:53:22] <jdlrobson>	 cool, all you need to do is be around in #wikimedia-operations at time of swat. I guess you can put bmansurov OR jdlrobson as requesting person
[21:53:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Improve trademark code in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[21:53:56] <bearND>	 dbrant: ok. I was thinking 20% sometime tomorrow, and 100% on Monday
[21:54:11] <grrrit-wm>	 (03PS11) 10Jdlrobson: WIP: Use mediawiki.confirmCloseWindow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow)
[21:54:14] <grrrit-wm>	 (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[21:54:19] <dbrant>	 bearND: sounds good
[21:54:24] <Deskana>	 bearND, dbrant: Is there something in particular that you're afraid of?
[21:54:29] <grrrit-wm>	 (03CR) 10Jdlrobson: "Marked as WIP since it's not working without the core change when I click back button" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/200179 (https://phabricator.wikimedia.org/T88949) (owner: 10Florianschmidtwelzow)
[21:54:41] <bearND>	 Deskana: no, just wanted to try out a staged rollout
[21:54:41] <Deskana>	 bearND, dbrant: Or are you just testing the staged rollout thing?
[21:54:53] <dbrant>	 death... :(
[21:54:58] <Deskana>	 bearND, dbrant: Sounds fine, but I'd say we should get to 100% before Monday. There are good bug fixes in there!
[21:55:23] <bearND>	 Deskana: ok, then we go to 100% on Friday
[21:55:30] <jdlrobson>	 bmansurov: so i think we should just risk it and remove https://gerrit.wikimedia.org/r/#/c/206855/3/resources/mobile.startup/init.js and the options call
[21:55:34] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story, 5Patch-For-Review: Editor broken on new pages - https://phabricator.wikimedia.org/T97474#1247258 (10kaldari) 5Open>3Resolved
[21:55:43] <bearND>	 dbrant: ^^
[21:55:52] <Deskana>	 bearND: Works for me. :-)
[21:55:58] <dbrant>	 cool
[21:56:02] <jdlrobson>	 Zero doesn't look like it uses it
[21:56:59] <wikibugs>	 10Wikipedia-iOS-App: Hebrew wikipedia - Main page displayed its table structure as collapsed - https://phabricator.wikimedia.org/T97589#1247264 (10Etonkovidova) 3NEW
[21:57:07] <bmansurov>	 jdlrobson: i added the patch to swat deploy
[21:57:12] <jdlrobson>	 bmansurov: awesome
[21:57:38] <bmansurov>	 jdlrobson: about your comment in the patch, i don't think it's possible
[21:57:47] <bmansurov>	 jdlrobson: because we don't have access to subclasses
[21:58:06] <jdlrobson>	 yeh :-/ i'm having a poke again at it now
[21:58:10] <bmansurov>	 jdlrobson: that's why I used the 'warn' function rather than the deprecate
[21:58:13] <kaldari>	 phuedx|AFK, bmansurov, JonKatz: any idea if I should deploy this config change today: https://gerrit.wikimedia.org/r/#/c/206375/
[21:59:06] <bmansurov>	 kaldari: I don't think you should because it's useless until we work on other bugs. I maybe wrong though
[21:59:19] <jdlrobson>	 bmansurov: hang on i might have an idea.
[21:59:44] <bmansurov>	 kaldari: It will allow rendering tags without a page where the tag should be linked.
[22:01:05] <bmansurov>	 jdlrobson: btw, backport to wmf3?
[22:01:20] <jdlrobson>	 bmansurov: i'm not sure which train it's on if any
[22:04:22] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] "Bingo! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[22:05:16] <wikibugs>	 10Wikipedia-iOS-App: Too little content for 'More information' box?  - https://phabricator.wikimedia.org/T97590#1247285 (10Etonkovidova) 3NEW
[22:05:38] <kaldari>	 bmansurov: so maybe I should make T95446 block T94739?
[22:05:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve trademark code in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[22:06:15] <kaldari>	 jdlrobson rmoen: everything go OK with Gather riding the train?
[22:06:30] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story, 5Patch-For-Review: Improve trademark code in MobileFrontend - https://phabricator.wikimedia.org/T95007#1247303 (10Florian) 5Open>3Resolved
[22:06:33] <rmoen>	 kaldari: yes. I've done some testing and have been monitoring for errors. 
[22:06:39] <kaldari>	 cool
[22:07:20] <bmansurov>	 kaldari: I think https://phabricator.wikimedia.org/T96015 should block the swat patch
[22:07:22] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1247306 (10kaldari)
[22:07:23] <wikibugs>	 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 3Mobile-Web-Design: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1247305 (10kaldari)
[22:07:33] <bmansurov>	 kaldari:  oops swat -> operations patch
[22:07:48] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "I think we should do this instead:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov)
[22:07:53] <jdlrobson>	 ^ bmansurov :)
[22:08:31] <bmansurov>	 jdlrobson: ok thanks
[22:08:40] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1190681 (10kaldari)
[22:08:42] <wikibugs>	 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 3Mobile-Web-Design: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1171571 (10kaldari)
[22:09:40] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Create a special page for tags - https://phabricator.wikimedia.org/T96015#1247315 (10kaldari)
[22:09:41] <wikibugs>	 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 3Mobile-Web-Design: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1247314 (10kaldari)
[22:11:10] <wikibugs>	 10Wikipedia-iOS-App: Too little content for 'More information' box? - https://phabricator.wikimedia.org/T97590#1247318 (10Etonkovidova) Another example - 'Germanic peoples':  {F158736}
[22:13:34] <wikibugs>	 6Mobile-Web: Generalise PageList to take Page as parameter - https://phabricator.wikimedia.org/T97592#1247326 (10Jdlrobson) 3NEW
[22:13:41] <wikibugs>	 6Mobile-Web: Generalise PageList to take Page as parameter - https://phabricator.wikimedia.org/T97592#1247334 (10Jdlrobson) a:3Jdlrobson
[22:14:00] <grrrit-wm>	 (03PS7) 10Jdlrobson: Hygiene: Make PageList take an array of pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/203266 (https://phabricator.wikimedia.org/T97592) 
[22:15:21] <grrrit-wm>	 (03PS1) 10Niedzielski: Fix language picker word wrap [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207651 
[22:15:26] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Simplify PageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 
[22:15:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify PageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 (owner: 10Jdlrobson)
[22:15:45] <grrrit-wm>	 (03CR) 10Kaldari: "We'll want to deploy change Id3baaf5e9ea0e as well when this goes live." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207318 (https://phabricator.wikimedia.org/T95007) (owner: 10Kaldari)
[22:16:43] <wikibugs>	 10Gather Sprint Greatest Hits: Tech debt: Simplify CollectionPageList inheritance model - https://phabricator.wikimedia.org/T97594#1247355 (10Jdlrobson) 3NEW a:3Jdlrobson
[22:16:52] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Simplify CollectionPageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 (https://phabricator.wikimedia.org/T97594) 
[22:16:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify CollectionPageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 (https://phabricator.wikimedia.org/T97594) (owner: 10Jdlrobson)
[22:17:57] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Drawer uses Icon and Button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206335 
[22:18:31] <grrrit-wm>	 (03PS1) 10Dbrant: Fix text directionality consistency in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207653 (https://phabricator.wikimedia.org/T74554) 
[22:19:59] <wikibugs>	 10Wikipedia-Android-App, 7I18n, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Inconsistent directionality in the Android App's nearby screen - https://phabricator.wikimedia.org/T74554#1247373 (10Dbrant)
[22:20:07] <wikibugs>	 10Wikipedia-Android-App, 7I18n, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Inconsistent directionality in the Android App's nearby screen - https://phabricator.wikimedia.org/T74554#1247374 (10Dbrant) a:3Dbrant
[22:20:31] <wikibugs>	 10Wikipedia-iOS-App: The pencil icon looks misplaced on 'More information' box - https://phabricator.wikimedia.org/T97595#1247376 (10Etonkovidova) 3NEW
[22:20:52] <grrrit-wm>	 (03CR) 10Niedzielski: "Ready for review." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207651 (owner: 10Niedzielski)
[22:21:31] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Link tagged categories (T94739) on article pages to anonymously created gather lists (T94714) for that property. - https://phabricator.wikimedia.org/T94742#1247383 (10kaldari)
[22:21:32] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Generate Gather collections from the lists generated in T94732 - https://phabricator.wikimedia.org/T95446#1247384 (10kaldari)
[22:24:06] <wikibugs>	 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1247398 (10kaldari) a:5phuedx>3kaldari
[22:30:26] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "The CAB change is something I still need to get used to. It seems weird to have to action bars. Have you seen other apps do this?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207293 (https://phabricator.wikimedia.org/T88768) (owner: 10Niedzielski)
[22:30:39] <bearND>	 dbrant: would you mind checking out https://gerrit.wikimedia.org/r/#/c/207293/1 as well?
[22:31:52] <grrrit-wm>	 (03PS8) 10Jdlrobson: Hygiene: Stop using mw-ui-button without abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 
[22:32:32] <dbrant>	 bearND: yep!
[22:39:25] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Split SpecialGather resource loader modules (031 comment) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207172 (https://phabricator.wikimedia.org/T97456) (owner: 10Jhernandez)
[22:39:51] <wikibugs>	 10Gather Sprint Greatest Hits, 5Patch-For-Review: ContentOverlay interface has changed - https://phabricator.wikimedia.org/T97338#1247421 (10Jdlrobson) 5Open>3Resolved
[22:40:05] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Infinite scroll for collections (enhanced pagination) - https://phabricator.wikimedia.org/T93309#1247424 (10Jdlrobson)
[22:40:06] <wikibugs>	 10Gather Sprint Greatest Hits, 5Patch-For-Review: Render CollectionListItem with templates - https://phabricator.wikimedia.org/T97284#1247422 (10Jdlrobson) 5Open>3Resolved
[22:40:11] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Infinite scroll for collections (enhanced pagination) - https://phabricator.wikimedia.org/T93309#1134050 (10Jdlrobson)
[22:40:13] <wikibugs>	 10Gather Sprint Greatest Hits, 5Patch-For-Review: Split resource loader modules in collections list and collection - https://phabricator.wikimedia.org/T97456#1247425 (10Jdlrobson) 5Open>3Resolved
[22:40:28] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits, 5Patch-For-Review: Qunit tests trigger API hits fails locally - https://phabricator.wikimedia.org/T97376#1247429 (10Jdlrobson) 5Open>3Resolved
[22:41:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split SpecialGather resource loader modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207172 (https://phabricator.wikimedia.org/T97456) (owner: 10Jhernandez)
[22:42:00] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Notice: Undefined variable: html in /Users/jrobson/git/vagrant/mediawiki/extensions/Gather/includes/views/CollectionsList.php on line 31" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) (owner: 10Jhernandez)
[22:42:30] <wikibugs>	 6Mobile-Web, 10MediaWiki-General-or-Unknown, 5Patch-For-Review, 7Performance: .column-break-inside-avoid rule appearing on every ResourceLoader module that includes mixins file - https://phabricator.wikimedia.org/T97587#1247438 (10matmarex)
[22:43:12] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen)
[22:43:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen)
[22:43:25] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen)
[22:44:25] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen)
[22:44:59] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: No link to my collection in Echo notification - https://phabricator.wikimedia.org/T97177#1247443 (10Jdlrobson) a:3Jdlrobson
[22:49:10] <wikibugs>	 10Gather Sprint Greatest Hits: Hiding throws error - https://phabricator.wikimedia.org/T97600#1247538 (10Jdlrobson) 3NEW
[22:49:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen)
[22:49:20] <wikibugs>	 10Gather Sprint Greatest Hits: Hiding throws error - https://phabricator.wikimedia.org/T97600#1247548 (10Jdlrobson) a:3Jdlrobson
[22:51:22] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: No link to my collection in Echo notification - https://phabricator.wikimedia.org/T97177#1247563 (10Jdlrobson)
[22:51:27] <grrrit-wm>	 (03PS1) 10Jdlrobson: Fix error in API request to hide [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207657 (https://phabricator.wikimedia.org/T97600) 
[22:51:29] <grrrit-wm>	 (03PS1) 10Jdlrobson: i18n: Update i18n message to link to collection [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207658 (https://phabricator.wikimedia.org/T97177) 
[22:52:10] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Flag icon shows on watchlist and other private collections - https://phabricator.wikimedia.org/T97300#1247574 (10Jdlrobson)
[22:52:19] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Flag icon shows on your watchlist and other private collections - https://phabricator.wikimedia.org/T97300#1247576 (10Jdlrobson)
[22:52:38] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Flag icon shows on your watchlist and other private collections - https://phabricator.wikimedia.org/T97300#1238444 (10Jdlrobson)
[22:53:42] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] "All the other tweaks are good and much-needed, but I definitely don't like the non-overlaying CAB. Our current behavior of replacing the " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207293 (https://phabricator.wikimedia.org/T88768) (owner: 10Niedzielski)
[22:54:22] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Update in WikimediaMessages extension for enwiki - https://phabricator.wikimedia.org/T96805#1247599 (10Jdlrobson) FYI @JKatzWMF I enabled the message on https://en.wikipedia.org/wiki/Special:GatherLists for English Wikipedia https://en.wikipedia.org/w/index.php?title=Me...
[22:54:34] <grrrit-wm>	 (03PS1) 10Robmoen: Fix php fatal error on empty collection message [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207660 
[22:54:40] <rmoen>	 jdlrobson: pretty serious fix there ^ 
[22:54:49] <rmoen>	 serious bug
[22:56:06] <rmoen>	 jdlrobson: probably shoudl get that on the swat deployment
[22:56:11] <rmoen>	 today
[22:56:22] <wikibugs>	 6Mobile-Web, 10MediaWiki-General-or-Unknown, 5Patch-For-Review, 7Performance: .column-break-inside-avoid rule appearing on every ResourceLoader module that includes mixins file - https://phabricator.wikimedia.org/T97587#1247607 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson
[22:57:28] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits, 3Mobile-Web-Design: When search returns no results no behaviour defined. - https://phabricator.wikimedia.org/T95966#1205174 (10Jdlrobson) @jhobs this card would be a great way into understanding our codebase. Please assign it to yourself if you are interested in takin...
[22:57:52] <wikibugs>	 10Wikipedia-iOS-App: Search deficiencies - not most relevant results are returned - https://phabricator.wikimedia.org/T97601#1247619 (10Etonkovidova) 3NEW
[22:58:47] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits, 3Mobile-Web-Design: when user adds page to collection, overlay replaces toast with options - https://phabricator.wikimedia.org/T95785#1247631 (10Jdlrobson) a:3Jdlrobson
[22:59:10] <rmoen>	 Can I get someone to merge this ? Then I can add it to the swat for today? https://gerrit.wikimedia.org/r/207660
[22:59:59] <rmoen>	 jdlrobson ^ 
[23:00:10] <rmoen>	 anyone ?
[23:00:43] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits, 3Mobile-Web-Design: When search returns no results no behaviour defined. - https://phabricator.wikimedia.org/T95966#1247633 (10jhobs) a:3jhobs
[23:01:34] <wikibugs>	 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Search-Department-Freezer, 6Services: EPIC: As a search API consumer, I'd like a search service to be created that can surface search results in a more logical and consistent format. - https://phabricator.wikimedia.org/T97602#1247636 (10Deskana) 3NEW
[23:03:13] <grrrit-wm>	 (03CR) 10Niedzielski: "I believe the default behavior is to show the CAB inline. Twitter and the Google Now launcher are a couple examples. But you're right, the" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207293 (https://phabricator.wikimedia.org/T88768) (owner: 10Niedzielski)
[23:03:13] <wikibugs>	 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Search-Department-Freezer, 6Services, 7Epic: EPIC: As a search API consumer, I'd like a search service to be created that can surface search results in a more logical and consistent format. - https://phabricator.wikimedia.org/T97602#1247636 (10Deskana)
[23:03:51] <wikibugs>	 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 10Search-Department-Freezer, 6Services, 7Epic: EPIC: As a search API consumer, I'd like a search service to be created that can surface search results in a more logical and consistent format. - https://phabricator.wikimedia.org/T97602#1247636 (10Deskana) The...
[23:03:57] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Fix php fatal error on empty collection message [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207660 (owner: 10Robmoen)
[23:06:02] <grrrit-wm>	 (03PS1) 10Robmoen: Fix php fatal error on empty collection message [extensions/Gather] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207666 
[23:11:10] <wikibugs>	 6Mobile-Web, 10MediaWiki-General-or-Unknown, 7Performance: .column-break-inside-avoid rule appearing on every ResourceLoader module that includes mixins file - https://phabricator.wikimedia.org/T97587#1247672 (10Ricordisamoa)
[23:11:21] <grrrit-wm>	 (03PS1) 10Jdlrobson: Tools: Run Gruntfile on resources folder as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207668 
[23:11:23] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Move views and object orientated code into resources folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207669 
[23:11:25] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Setup resources/mobile.overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207670 
[23:11:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix php fatal error on empty collection message [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207660 (owner: 10Robmoen)
[23:13:35] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1247675 (10Mholloway) I noticed that when PageActivity moved from subclassing ThemedActionBarActivity to ActionBa...
[23:13:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Tools: Run Gruntfile on resources folder as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207668 (owner: 10Jdlrobson)
[23:14:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Setup resources/mobile.overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207670 (owner: 10Jdlrobson)
[23:14:57] <grrrit-wm>	 (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207668 (owner: 10Jdlrobson)
[23:15:29] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Move views and object orientated code into resources folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207669 
[23:15:40] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Setup resources/mobile.overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207670 
[23:18:07] <grrrit-wm>	 (03CR) 10Robmoen: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207660 (owner: 10Robmoen)
[23:18:13] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Remove erroneously added blank file [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207673 
[23:18:53] <wikibugs>	 10Gather: 'Add to collection' popup should not show on every page load - https://phabricator.wikimedia.org/T97452#1247680 (10Jdlrobson) I think this was the intended behaviour. @msyed @jkatzWmf any thoughts?
[23:18:58] <grrrit-wm>	 (03PS7) 10Robmoen: Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 
[23:18:58] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: 'Add to collection' popup should not show on every page load - https://phabricator.wikimedia.org/T97452#1247682 (10Jdlrobson)
[23:19:09] <wikibugs>	 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: 4.1.1(76) - clicking links in offline mode saved them in Recent - https://phabricator.wikimedia.org/T95585#1247684 (10Etonkovidova) Checked on 4.3.1 (96) -  Recent list will not be updated in offline mode.  It's still possible to add pages to...
[23:19:38] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits, 10MediaWiki-Vagrant, 5Patch-For-Review: Vagrant role for Gather not working - https://phabricator.wikimedia.org/T97541#1245841 (10Jdlrobson)
[23:20:08] <rmoen>	 jdlrobson: rebased https://gerrit.wikimedia.org/r/#/c/206973/, if you could +2 again that would be great and hopefully save me from more rebase hell
[23:20:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Setup resources/mobile.overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207670 (owner: 10Jdlrobson)
[23:21:29] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits, 10MediaWiki-Vagrant, 5Patch-For-Review: Vagrant role for Gather not working - https://phabricator.wikimedia.org/T97541#1247695 (10Tgr) 5Open>3Resolved a:3Tgr Yeah, works with the patch applied. I messed up the DB while trying to run the update manually, that c...
[23:22:13] <rmoen>	 jdlrobson: ping pong
[23:22:25] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "breaks flag button" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen)
[23:22:46] <rmoen>	 ohffs
[23:23:17] <grrrit-wm>	 (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207670 (owner: 10Jdlrobson)
[23:24:58] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1247718 (10Jdlrobson) sigh. Why does the generator not have a concept of sorting? I'd need to do this both on frontend and client and that just sounds horrible.
[23:26:25] <grrrit-wm>	 (03PS1) 10Mholloway: [WIP] Possibly fix IllegalStateExceptions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207677 (https://phabricator.wikimedia.org/T75236) 
[23:26:58] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1247727 (10bearND) Hi @Niedzielski. Great idea getting the versionName or portion of from Jenkins. I think this is out of scope for this ta...
[23:28:02] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix php fatal error on empty collection message [extensions/Gather] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207666 (owner: 10Robmoen)
[23:28:35] <grrrit-wm>	 (03PS2) 10Catrope: Fix php fatal error on empty collection message [extensions/Gather] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207666 (owner: 10Robmoen)
[23:29:22] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix php fatal error on empty collection message [extensions/Gather] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207666 (owner: 10Robmoen)
[23:30:42] <grrrit-wm>	 (03PS3) 10BearND: Change version number format to include versionCode as subminor number [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203156 (https://phabricator.wikimedia.org/T95584) 
[23:30:58] <grrrit-wm>	 (03PS1) 10Catrope: Check whether the object exists before checking its property [extensions/MobileFrontend] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207678 (https://phabricator.wikimedia.org/T97474) 
[23:31:01] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1247733 (10bearND) Sorry for taking some time until picking this up again. I'm thinking of leaving it as is, and just keeping the versionCo...
[23:31:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Check whether the object exists before checking its property [extensions/MobileFrontend] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207678 (https://phabricator.wikimedia.org/T97474) (owner: 10Catrope)
[23:32:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix php fatal error on empty collection message [extensions/Gather] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207666 (owner: 10Robmoen)
[23:37:39] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Fix text directionality consistency in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207653 (https://phabricator.wikimedia.org/T74554) (owner: 10Dbrant)
[23:37:40] <wikibugs>	 6Mobile-Web: In iOS 8 Safari, trying to scroll in the WikiText editor results in content disappearing - https://phabricator.wikimedia.org/T97605#1247747 (10kaldari) 3NEW
[23:38:02] <wikibugs>	 10Wikipedia-Android-App, 7I18n, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Inconsistent directionality in the Android App's nearby screen - https://phabricator.wikimedia.org/T74554#1247757 (10bearND) p:5Triage>3Normal
[23:38:28] <grrrit-wm>	 (03PS8) 10Robmoen: Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 
[23:38:50] <rmoen>	 jdlrobson: did something in overlays change?  Cannot get either flag button to work on master for MF and my patch
[23:38:58] <grrrit-wm>	 (03CR) 10Dbrant: "I looked at some other apps (including Twitter, Facebook, etc), and they do indeed use the inline-style CAB when highlighting text in thei" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207293 (https://phabricator.wikimedia.org/T88768) (owner: 10Niedzielski)
[23:39:09] <jdlrobson>	 rmoen: module name maybe?
[23:39:23] <jdlrobson>	 Module not found: ext.gather.watchstar/CollectionsApi"
[23:39:45] <jdlrobson>	 try ext.gather.api/CollectionsApi
[23:40:14] <rmoen>	 jdlrobson: i did that and i've pushed it
[23:40:26] <rmoen>	 No errors now and the Overlay won't open
[23:40:45] <rmoen>	 ;/
[23:40:59] <grrrit-wm>	 (03PS3) 10BearND: Eliminate "read next." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207398 (https://phabricator.wikimedia.org/T96709) (owner: 10Dbrant)
[23:41:05] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Eliminate "read next." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207398 (https://phabricator.wikimedia.org/T96709) (owner: 10Dbrant)
[23:41:21] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] Fix php fatal error on empty collection message [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207660 (owner: 10Robmoen)
[23:41:26] <wikibugs>	 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Change version string format to include versionCode - https://phabricator.wikimedia.org/T95584#1247774 (10Niedzielski) Thanks! After today's discussion, I think we need to figure out richer CI and release solutions before pursuing the...
[23:42:07] <jdlrobson>	 rmoen: and it worked before?
[23:42:10] <rmoen>	 yes
[23:42:28] <rmoen>	 jdlrobson: it only recently stopped working after the rebase.  It worked on Monday
[23:42:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check whether the object exists before checking its property [extensions/MobileFrontend] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207678 (https://phabricator.wikimedia.org/T97474) (owner: 10Catrope)
[23:42:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix text directionality consistency in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207653 (https://phabricator.wikimedia.org/T74554) (owner: 10Dbrant)
[23:44:21] <rmoen>	 jdlrobson: what i am also saying is the flag overlay won't open on master for me
[23:45:06] <rmoen>	 so there is that
[23:45:17] <bearND>	 dbrant: niedzielski: see you tomorrow
[23:45:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Eliminate "read next." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207398 (https://phabricator.wikimedia.org/T96709) (owner: 10Dbrant)
[23:45:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix php fatal error on empty collection message [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207660 (owner: 10Robmoen)
[23:45:34] <dbrant>	 bearND: later! have a good one
[23:45:42] <niedzielski>	 bearND: thanks man! and thanks for all the help today!
[23:46:40] <jdlrobson>	 rmoen: i'm debugging
[23:46:44] <jdlrobson>	 seems the view is rendering
[23:46:56] <rmoen>	 at least its working on en.wiki
[23:47:02] <jdlrobson>	 it's just hidden
[23:47:12] <rmoen>	 strange.  I'm calling show
[23:47:15] <jdlrobson>	 look in dom
[23:47:16] <jdlrobson>	 it's there
[23:47:42] <rmoen>	 i see it
[23:47:48] <rmoen>	 it even has the class 'visible' 
[23:48:19] <jdlrobson>	 if i delete viewport i see it
[23:48:34] <jdlrobson>	 z-index issues?
[23:48:44] <jdlrobson>	 is the problem on master?
[23:49:05] <jdlrobson>	 yup
[23:49:09] <jdlrobson>	 looks like bug on master Rob
[23:49:17] <jdlrobson>	 so something recent happened
[23:49:40] <rmoen>	 hmmm yea
[23:49:52] <rmoen>	 Ive been saying that
[23:50:03] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Flag overlay obscured - https://phabricator.wikimedia.org/T97609#1247817 (10Jdlrobson) 3NEW
[23:50:19] <jdlrobson>	 ^ rmoen  thought it was just specific with your patch
[23:50:27] <jdlrobson>	 but yeh i don't know what's happened
[23:50:30] <grrrit-wm>	 (03CR) 10Niedzielski: "Hm, ok I guess the behavior we miss is being able to paste over highlighted text. For some reason, I can't bring up the little paste dialo" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207293 (https://phabricator.wikimedia.org/T88768) (owner: 10Niedzielski)
[23:50:32] <rmoen>	 jdlrobson: nope
[23:50:37] <jdlrobson>	 i'm guesing z-index issue
[23:52:06] <jdlrobson>	 rmoen: it needs the overlay class
[23:52:14] <jdlrobson>	 .overlay controls z-inde
[23:52:48] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Flag overlay obscured - https://phabricator.wikimedia.org/T97609#1247838 (10Jdlrobson) Add overlay class to fix this.
[23:52:48] <rmoen>	 well that is strange it must have had it before
[23:53:04] <jdlrobson>	 nope.. it just previously got appended elsewhere in the dom
[23:53:10] <jdlrobson>	 so was relying on html position
[23:54:09] <jdlrobson>	 doh. looks like i'm not gonna get into the opticians before it closes :-/
[23:54:24] <rmoen>	 jdlrobson:  ok i have a fix
[23:54:37] <rmoen>	 testing really quick then pushing
[23:54:54] <wikibugs>	 10Gather, 10Gather Sprint Greatest Hits: Flag overlay obscured - https://phabricator.wikimedia.org/T97609#1247841 (10rmoen) a:3rmoen
[23:55:30] <grrrit-wm>	 (03PS1) 10Robmoen: Add overlay class to confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207684 
[23:56:12] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Add overlay class to confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207684 (owner: 10Robmoen)
[23:57:33] <grrrit-wm>	 (03PS9) 10Robmoen: Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 
[23:57:39] <rmoen>	 jdlrobson: rebased it on the fix and it works
[23:57:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add overlay class to confirm overlay [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207684 (owner: 10Robmoen)