[00:00:28] (03PS10) 10Robmoen: Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 [00:02:03] Going to get a massage, be back later [00:15:56] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: In iOS 8 Safari, trying to scroll in the WikiText editor results in content disappearing - https://phabricator.wikimedia.org/T97605#1247898 (10kaldari) [00:22:39] (03PS1) 10Bmansurov: Create Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) [00:26:21] 10Wikipedia-Android-App, 7I18n: Improve language selection - https://phabricator.wikimedia.org/T73136#1247931 (10Dbrant) [00:26:25] 10Wikipedia-Android-App, 10Wikimania-Hackathon-2015, 10Wikimedia-Hackathon-2015, 7Design: Add an easier and faster way to change the search language - https://phabricator.wikimedia.org/T87154#1247932 (10Dbrant) [00:27:11] (03CR) 10Bmansurov: "Not sure if there is a way to get the information needed from the API in a single request." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [00:28:41] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: In iOS 8 Safari, trying to scroll in the WikiText editor results in content disappearing - https://phabricator.wikimedia.org/T97605#1247937 (10kaldari) It looks like https://gerrit.wikimedia.org/r/#/c/203095/ fixed T95465 (which affected all iOS ve... [00:33:58] (03PS4) 10Bmansurov: Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) [00:36:09] (03CR) 10Bmansurov: [C: 032] Hygiene: Move views and object orientated code into resources folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207669 (owner: 10Jdlrobson) [00:37:08] (03CR) 10Bmansurov: [C: 032] Tools: Run Gruntfile on resources folder as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207668 (owner: 10Jdlrobson) [00:39:04] (03Merged) 10jenkins-bot: Hygiene: Move views and object orientated code into resources folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207669 (owner: 10Jdlrobson) [00:39:07] (03Merged) 10jenkins-bot: Tools: Run Gruntfile on resources folder as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207668 (owner: 10Jdlrobson) [00:40:49] 10Wikipedia-Android-App, 10Wikipedia-App-General-or-Unknown: Using “Share a fact” should not take coordinates as the default text (on some pages) - https://phabricator.wikimedia.org/T96493#1247957 (10Dbrant) Here's an idea for this: When we first fetch the page contents (using the mobileview api), we could als... [00:45:17] 10Wikipedia-Android-App, 7I18n: i18n translations strings for 'yes' and 'no' are used in multiple questions - https://phabricator.wikimedia.org/T69628#1247965 (10Dbrant) @bearnd would you mind commenting on this, and close if it's no longer valid/relevant? [00:47:53] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: In iOS 8 Safari, trying to scroll in the WikiText editor results in content disappearing - https://phabricator.wikimedia.org/T97605#1247969 (10kaldari) a:3kaldari [00:52:44] 10Wikipedia-Android-App, 10Wikipedia-App-General-or-Unknown: Using “Share a fact” should not take coordinates as the default text (on some pages) - https://phabricator.wikimedia.org/T96493#1247973 (10Deskana) Probably related to this on the iOS app: https://phabricator.wikimedia.org/T95476 [00:52:48] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1247974 (10kaldari) It looks like this bug was caused by https://gerrit.wikimedia.org/r/#/c/188673/, which unfortunately was a significant ch... [01:06:57] 10Gather Sprint Greatest Hits: Enable Gather on WikiVoyage - https://phabricator.wikimedia.org/T97488#1247995 (10Moushira) Yup! Jdlrobson happily _and thankfully_started the conversation. Wikivoyagae is an ancient suggestion by @whatamidoing :). It is a great fit for the feature, lets see what happens there! [01:07:16] 10Wikipedia-Android-App: Page Refresh Icon Is Not Antialiased - https://phabricator.wikimedia.org/T97236#1247998 (10Dbrant) @Niedzielski We're using the standard SwipeRefreshLayout provided with the Support library, which is responsible for displaying this element. Perhaps we should file a bug with them? [01:10:35] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Article Links Unclickable on Bottom of Page - https://phabricator.wikimedia.org/T96246#1248002 (10Dbrant) It's likely that this has been fixed when we removed the Read Next functionality. Can we re-test to confirm that this is the case? [01:28:47] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1248021 (10Dbrant) It is related precisely to the code that @Deskana mentioned. The way that we hook into the default context buttons is by searching for th... [01:35:41] (03PS2) 10Aaron Schulz: Use the WAN cache for caching [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/207630 (https://phabricator.wikimedia.org/T93141) [01:50:31] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: In iOS Safari, after opening the hamburger menu, clicking on the greyed-out article doesn't close the hamburger menu - https://phabricator.wikimedia.org/T97621#1248072 (10kaldari) 3NEW [01:53:19] (03PS1) 10Kaldari: Fixing scrolling in the editor in Mobile Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207705 (https://phabricator.wikimedia.org/T95465) [01:57:00] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story, 5Patch-For-Review: In iOS 8 Safari, trying to scroll in the WikiText editor results in content disappearing - https://phabricator.wikimedia.org/T97605#1248087 (10kaldari) Found the root cause, which was pretty trivial to fix. Also removed the pre... [02:02:25] (03PS2) 10Kaldari: Fixing scrolling in the editor in Mobile Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207705 (https://phabricator.wikimedia.org/T95465) [02:04:03] (03CR) 10Jforrester: [C: 032] Update for changes in OOjs UI (Ib40e3477) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206730 (https://phabricator.wikimedia.org/T91152) (owner: 10Bartosz Dziewoński) [02:04:35] (03CR) 10jenkins-bot: [V: 04-1] Fixing scrolling in the editor in Mobile Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207705 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [02:19:26] (03Merged) 10jenkins-bot: Update for changes in OOjs UI (Ib40e3477) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206730 (https://phabricator.wikimedia.org/T91152) (owner: 10Bartosz Dziewoński) [03:01:55] 10Gather, 10Gather Sprint Greatest Hits: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1248167 (10Yurik) Generator does have a concept of sorting - it yields batches of page titles in the given order. The output's xml/JSON element is a dictionary of `... [03:17:20] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Article Links Unclickable on Bottom of Page - https://phabricator.wikimedia.org/T96246#1248172 (10Niedzielski) Repros on an old alpha APK but not on master now. [03:18:46] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Article Links Unclickable on Bottom of Page - https://phabricator.wikimedia.org/T96246#1248173 (10Niedzielski) (I believe this can move to resolved state but will await your advisement.) [04:22:51] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1248202 (10Mholloway) Devices on which this has reportedly occurred: Samsung SM-G386T1 (Gal... [04:32:02] dbrant: I just wrote my first patch touching the DB, and it seems to work! \o/ [04:46:54] 10Wikipedia-Android-App, 5Patch-For-Review: Fix HistoryEntryPersistenceHelper and SavedPagesPersistenceHelper so they do not inappropriately set the namespace of all pages to null - https://phabricator.wikimedia.org/T96944#1248215 (10Deskana) a:3Deskana [04:47:29] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Fix HistoryEntryPersistenceHelper and SavedPagesPersistenceHelper so they do not inappropriately set the namespace of all pages to null - https://phabricator.wikimedia.org/T96944#1229890 (10Deskana) [04:54:50] 10Wikipedia-Android-App: Page Refresh Icon Is Not Antialiased - https://phabricator.wikimedia.org/T97236#1248235 (10Niedzielski) Opened bug [[ https://code.google.com/p/android/issues/detail?id=170739 | bug ]] and [[ https://android-review.googlesource.com/#/c/148852/ | fix ]] on AOSP. [04:56:28] * Deskana sighs [04:56:32] Fuck you, Jerkins [05:00:05] Deskana: lol, jenkins works but it can sure be frustrating at times [05:00:38] Well, really I should be blaming checkstyle, that's where the actual problem is. [05:11:21] Deskana: \o/ well done! [05:11:47] dbrant: Unfortunately Jenkins gave it a -2 because I dared to use a "case 6:" [05:11:55] dbrant: No magic numbers allowed :-( [05:16:52] Deskana: well, Jenkins is an ass :) [05:34:45] have a good night guys :) [05:36:25] 10Gather: In their collection screen, a user can see a list of the collections they are following - https://phabricator.wikimedia.org/T97627#1248264 (10JKatzWMF) 3NEW a:3KHammerstein [07:29:46] 6Mobile-Web, 6Collaboration-Team, 10Flow, 10OOjs-UI, and 4 others: OOjs UI is optimized for font-size of 12.8px (0.8×16px), but sets it inconsistently for windows and toolbars only, requiring CSS counteractions - https://phabricator.wikimedia.org/T91152#1248362 (10matmarex) [07:30:10] 6Mobile-Web, 6Collaboration-Team, 10Flow, 10OOjs-UI, and 4 others: OOjs UI is optimized for font-size of 12.8px (0.8×16px), but sets it inconsistently for windows and toolbars only, requiring CSS counteractions - https://phabricator.wikimedia.org/T91152#1248367 (10matmarex) [08:45:54] 6Mobile-Web, 10MediaWiki-General-or-Unknown, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: oojs ui settings icon and MobileFrontend main menu settings icon are clashing - https://phabricator.wikimedia.org/T97473#1243341 (10phuedx) [08:46:03] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Editor broken on new pages - https://phabricator.wikimedia.org/T97474#1243352 (10phuedx) [08:46:14] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Improve trademark code in MobileFrontend - https://phabricator.wikimedia.org/T95007#1177791 (10phuedx) [08:47:16] 6Mobile-Web, 10MobileFrontend, 6Performance-Team, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: skins.minerva.drawers.styles should be moved into mobile.drawers - https://phabricator.wikimedia.org/T97327#1248419 (10phuedx) [08:54:03] 10Gather, 10Gather Sprint Greatest Hits: BadMethodCallException when removing the last element of a Gather collection - https://phabricator.wikimedia.org/T97633#1248425 (10Tgr) 3NEW [09:01:41] morning [09:03:24] afternoon [09:05:33] 10Gather, 10Gather Sprint Greatest Hits: BadMethodCallException when removing the last element of a Gather collection - https://phabricator.wikimedia.org/T97633#1248446 (10Tgr) 5Open>3Invalid a:3Tgr Duh, do a pull first. Already fixed in https://gerrit.wikimedia.org/r/#/c/207660/ [09:05:57] 10Gather: BadMethodCallException when removing the last element of a Gather collection - https://phabricator.wikimedia.org/T97633#1248450 (10Tgr) [09:07:18] haha hi codezee :) [09:07:28] hello! [09:20:31] yo [09:39:12] hi phuedx [09:39:19] hey joakino, how're you? [09:39:26] phuedx: irccloud when completing your name always says (away) [09:39:37] how about now? [09:39:40] (i'm not away) [09:41:19] phuedx: lol same [09:41:26] :/ [09:41:41] it probably takes some time to update [10:06:40] 6Mobile-Web: Generating release notes automatically - https://phabricator.wikimedia.org/T95324#1248556 (10Jhernandez) @bmansurov having the commit sha allows you to poke the log and see the full commit, and the related `Bug: TXXX` and `Change-Id` to see gerrit and phabricator tasks, that's why I think it is usef... [10:10:12] 6Mobile-Web: Generating release notes automatically - https://phabricator.wikimedia.org/T95324#1248567 (10Jhernandez) Forgot to think about phabricator/wikitext changelogs: `git log --since=1.week --pretty=format:'- %s ([[https://gerrit.wikimedia.org/r/#/q/%h,n,z | Gerrit]] ∙ [[https://github.com/wikimedia/medi... [10:12:15] ^ joakino: those examples are aweomse [10:12:17] *awesome [10:12:37] :D [10:12:48] phuedx: fun stuff is fun [10:16:29] listening to an album from 2002 that i listened to religiously during 2002-2008 [10:18:07] remembering a whole bunch of stuff [10:22:46] phuedx: it is amazing how music makes our brain relive the past [10:23:07] yeah -- that's why i love it so much [10:46:33] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1248658 (10Bene) As I suggested, I'd not try to use the default context menu which Android provides but rather add a context menu in the action bar on top o... [11:21:02] joakino: could we split out hygiene commits using your fancy commands? [11:21:12] like "here's the product work we've done and here's the cleanup"? [11:21:23] 10Wikipedia-iOS-App, 3App-Process-Improvement, 3Mobile-App-Sprint-56-iOS: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1248713 (10mmodell) The task for trying out Differential is: T94167 [11:21:57] phuedx: sure, just execute it with | grep Hygiene at the end or grep -v Hygiene to remove them [11:22:11] i like that we sorta tag commits [11:22:25] and breaking 'em out sorta makes sense to me [12:17:30] (03PS4) 10BearND: Change version number format to include versionCode as subminor number [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203156 (https://phabricator.wikimedia.org/T95584) [12:36:45] (03PS1) 10Phuedx: Add new events to SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207761 (https://phabricator.wikimedia.org/T96326) [12:36:47] (03PS1) 10Phuedx: Hygiene: Generalise the futureLog mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) [12:36:49] (03PS1) 10Phuedx: Log MobileWebSearch events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) [12:38:50] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207705 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [12:39:06] (03PS2) 10BearND: Fix language picker word wrap [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207651 (owner: 10Niedzielski) [12:39:13] (03CR) 10BearND: [C: 032] Fix language picker word wrap [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207651 (owner: 10Niedzielski) [12:39:45] (03CR) 10jenkins-bot: [V: 04-1] Log MobileWebSearch events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [12:40:07] (03Merged) 10jenkins-bot: Fix language picker word wrap [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207651 (owner: 10Niedzielski) [12:42:12] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Generalise the futureLog mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [12:48:25] (03PS3) 10Jhernandez: Hygiene: Split SpecialGather resource loader modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207172 (https://phabricator.wikimedia.org/T97456) [12:48:40] (03PS2) 10Phuedx: Log MobileWebSearch events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) [12:48:42] (03PS2) 10Phuedx: Hygiene: Generalise the futureLog mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) [12:49:16] (03CR) 10Jhernandez: [C: 032] "Rebased master, there were no conflicts. I don't understand. Re+2ing" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207172 (https://phabricator.wikimedia.org/T97456) (owner: 10Jhernandez) [12:49:20] enjoy the spam joakino D: [12:49:35] lol [12:50:22] phuedx: what do you think about moving wikibugs and grrrit-wm to another channel? [12:50:27] (03CR) 10jenkins-bot: [V: 04-1] Log MobileWebSearch events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [12:50:53] i'm for it [12:51:56] i think the benefits of the spam (serendipity, coordination?) are minuscule compared to the disadvantages (NO SIGNAL) [12:53:00] phuedx: i like the notifications, but I'd prefer to have it in a separate opt-in irc channel [12:53:14] #wikimedia-mobile-notifications [12:53:17] something like that [12:53:33] gonna send an email. [12:53:53] (03Merged) 10jenkins-bot: Hygiene: Split SpecialGather resource loader modules [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207172 (https://phabricator.wikimedia.org/T97456) (owner: 10Jhernandez) [12:54:26] i wrote unit tests [12:54:31] they detected a regression [12:54:37] i am happy [12:55:26] \o/ [12:56:54] (03PS4) 10Jhernandez: Fully render collections list with templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) [12:58:26] (03PS3) 10Phuedx: Log MobileWebSearch events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) [12:59:53] (03CR) 10jenkins-bot: [V: 04-1] Log MobileWebSearch events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [12:59:58] oh what the fuck [13:08:41] (03PS5) 10Jhernandez: Fully render collections list with templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) [13:09:14] (03CR) 10Jhernandez: "Sorry, stupid fuckup..." [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) (owner: 10Jhernandez) [13:10:10] out forlunch [13:18:07] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [13:32:36] (03PS3) 10Phuedx: Fixing scrolling in the editor in Mobile Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207705 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [13:33:34] (03CR) 10Phuedx: "PS3 fixes the JSCS error in PS2." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207705 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [13:34:39] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Sprint 55 Release - https://phabricator.wikimedia.org/T95969#1248899 (10BGerstle-WMF) [13:40:08] (03CR) 10Phuedx: [C: 032] "LGTM. Tested locally in the iOS Simulator." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207705 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [13:41:40] (03Merged) 10jenkins-bot: Fixing scrolling in the editor in Mobile Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207705 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [14:00:19] out for lunch [14:04:15] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - https://phabricator.wikimedia.org/T75236#1248971 (10Mholloway) The only other potentially interesting thing I've noticed here is that... [14:16:27] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1249005 (10NiharikaKohli) [14:16:57] 10MobileFrontend-Feature-requests, 10Wikidata, 3Google-Summer-of-Code-2015: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#842120 (10NiharikaKohli) [14:36:08] bearND: hey there! so, for the css assets, it looks like i should make the changes in mediawiki/extensions/MobileApp/styles/enwiki.less and then run make-css-assets.bash? [14:36:40] mholloway: yes, but change the script to use the other URL [14:36:49] mholloway: the commented out one [14:37:00] starts with 127.0. [14:37:01] bearND: yep, i have it pointing to the right place (127.0.0.1:8080/w) [14:37:36] mholloway: ok, that sounds good. This should update styles.css and potentially other css files, too [14:38:56] bearND: my tablet (a nexus 9, which i really like so far!) showed up yesterday, and testing the in-article image feature i'm working on, full-column width is stretching most of the thumbnail images too far, even when grabbing the 2x versions [14:39:26] bearND: so i want to see what kaity and vibha want to do [14:40:33] bearND: it looked better on the emulator, and looks great on the tablet when the images are high-enough resolution, but image quality is kind of a mixed bag [14:43:25] (03PS2) 10Deskana: Make some PersistenceHelpers set the namespace of pages as appropriate [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207727 (https://phabricator.wikimedia.org/T96944) [14:47:06] mholloway: would you add some screenshots from the physical device to the Phab task? I'm wondering, too, what the designers want to do there. [14:48:20] mholloway: do they have the apk so they can try out for themselves? [14:49:11] bearND: sure. it also would be nice to know the image file size rather than just dimensions but that doesn't come over in the initial request and i don't imagine we'd want to re-query the api to get them [14:49:43] bearND: yeah, they have an APK that includes everything except the changes to main page images i started working on yesterday morning [14:53:41] bearND: actually, i should send them a new APK , it's been longer than i remembered (the day before yesterday) [14:56:55] bearND: mholloway what's the best way to add all the android people to a gerrit reviews? is there a group i can use? [14:57:25] niedzielski: that should happen automatically, it may take a bit though [14:59:07] bearND: hm, i think i normally see you, dbrant, Brion VIBBER get auto-added. so i manually add mholloway [15:00:23] 10Gather, 10Gather Sprint Greatest Hits: Spike: Following - https://phabricator.wikimedia.org/T94243#1249084 (10Tgr) > When pages are rendered from the GatherList namespace they get slightly different render treatment. If by different treatment you mean some sort of template-style expansion, with arbitrary de... [15:01:52] niedzielski: yeah, there is a list of people that get automatically added. I currently don't remember where to update it so you two get added as well. [15:03:04] niedzielski: i'm happy to take a look at stuff but i'd imagine bearND and dbrant will be doing most of the reviewing/+2ing for now. i've been seeing your stuff come through but i've been kind of down a rabbit hole trying to chase down this IllegalStateException I can't reproduce. [15:04:52] back from lunch [15:04:58] played in the park with george and harry [15:05:00] mholloway: thanks, i was just mentioning it because i worry about forgetting to add folks to my reviews [15:05:00] best lunch [15:07:20] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: In iOS 8 Safari, trying to scroll in the WikiText editor results in content disappearing - https://phabricator.wikimedia.org/T97605#1247747 (10phuedx) [15:07:26] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1191271 (10phuedx) [15:07:35] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Scrolling disabled when editing using iOS 8.2 and mobile Safari - https://phabricator.wikimedia.org/T95465#1249111 (10phuedx) 5Open>3Resolved [15:07:50] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: In iOS 8 Safari, trying to scroll in the WikiText editor results in content disappearing - https://phabricator.wikimedia.org/T97605#1249114 (10phuedx) 5Open>3Resolved [15:08:57] mholloway: yes, that right for now. But I want to encourage you and niedzielski to review other dev's code as well to get into the habit of reviewing code. It's also a good way to learn from others. [15:09:20] mholloway: if you are not comfortable to +2 then you can still +1 [15:09:59] bearND: yeah, i would like to and i've been meaning to take a look. This IllegalStateException is just so vexing! [15:15:04] mholloway: that's cool. [15:24:25] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 3Mobile-Web-Design: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1249144 (10phuedx) Hey @kaldari, @bmansurov: I don't think this is blocked on T96015. Even with the feature enabled, the "topic tags"/catagrokkies aren't click... [15:25:31] niedzielski: bearND: to show up automatically i think i can add myself here: https://www.mediawiki.org/wiki/Git/Reviewers#apps.2Fandroid.2Fwikipedia [15:25:53] just need to reset my official account password so i can log in :/ [15:26:08] mholloway: good find. /cc: niedzielski [15:26:09] mholloway: that does look promising! [15:26:58] mholloway: i'll update the onboard wiki with a pointer [15:27:09] niedzielski: good. Thanks! [15:27:11] niedzielski: great! [15:28:14] niedzielski: if you're logged in and want to add me (mholloway), that's cool too. this password reset email is taking its time in showing up. [15:29:03] mholloway: sounds good [15:29:22] bearND: should i leave brion vibber on? [15:29:50] niedzielski: cool, thanks [15:30:19] niedzielski: yes, leave him. I'll email him the link. If he wants to be removed he can do so himself. [15:31:49] bearND: okey dokey [15:31:56] mholloway: i think we're good to go! [15:32:14] niedzielski: sweet, thanks! [15:32:23] mholloway: no, thank you! :) [15:32:53] (03PS7) 10Jdlrobson: Hygiene: Simplify CollectionPageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 (https://phabricator.wikimedia.org/T97594) [15:34:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify CollectionPageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 (https://phabricator.wikimedia.org/T97594) (owner: 10Jdlrobson) [15:34:39] (03CR) 10Jdlrobson: [C: 032] Fully render collections list with templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) (owner: 10Jhernandez) [15:35:26] 6Mobile-Web: Should be possible to create a View which does not render a template using enhance - https://phabricator.wikimedia.org/T97648#1249156 (10Jdlrobson) 3NEW [15:36:36] (03Merged) 10jenkins-bot: Fully render collections list with templates [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207177 (https://phabricator.wikimedia.org/T97459) (owner: 10Jhernandez) [15:36:48] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [15:38:23] (03PS4) 10Jdlrobson: Hygiene: Use Button in AbuseFilterOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206336 [15:40:03] (03CR) 10Jdlrobson: [C: 031] Add new events to SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207761 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [15:40:08] (03PS2) 10Jdlrobson: Add new events to SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207761 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [15:40:55] (03CR) 10Jdlrobson: [C: 032] Add new events to SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207761 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [15:41:17] bgerstle: i'm currently straining sloe whiskey through my hario woodneck [15:41:23] because i rarely use the woodneck [15:41:25] (03PS3) 10Jdlrobson: Hygiene: Generalise the futureLog mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [15:41:26] but when i do [15:41:33] boy that's going to be an interesting cup [15:41:51] i've had beans that've been stored in whiskey barrels before and they were /weird/ [15:41:56] phuedx: sounds like you're up to something sinister [15:42:37] (03Merged) 10jenkins-bot: Add new events to SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207761 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [15:42:41] fruit + unrefined sugar + spirit = win [15:42:56] ^ transendental truth [15:43:19] next up is chilli + unrefined sugar + spirit [15:43:45] (03CR) 10Jdlrobson: [C: 031] "Tempted just to +2 this because code looks great and has tests but I guess I should test first. Minor comment if you want to fix that up " (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [15:43:53] (03PS4) 10Jdlrobson: Log MobileWebSearch events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [15:44:28] 10Gather, 10Gather Sprint Greatest Hits: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1249191 (10Tgr) You can do with primary key lookups and a single dependent subquery for pretty much any filtering as far as I can see, e.g. ``` SELECT * FROM gather_list gl JOIN gather_list_i... [15:44:57] jdlrobson: not sure what you mean by that comment [15:45:05] i wanted to use mw.loader.using [15:45:12] but you pass mw down below as well [15:45:22] function(mw){}(mw) [15:45:30] is basically what you're doing. mw is a global [15:45:35] ... [15:45:36] you can just use it [15:45:38] yerrrp [15:45:45] i'm a professional [15:46:12] mid-review atm [15:46:14] jdlrobson: ^ [15:46:34] also, alcohol related background task [15:47:13] mm? [15:47:19] (03CR) 10Jdlrobson: [C: 031] Log MobileWebSearch events (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [15:47:32] we still good for tuesday lunch btw? [15:48:00] also i have to work that evening, could come and hang out with you if that made sense - not sure what last train back / your working hours are like [15:48:11] would be great to go over some of the tech debt and make some evil plans [15:51:17] (03CR) 10Phuedx: Log MobileWebSearch events (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [15:51:49] joakino: definitely good for lunch [15:52:20] i can work until whenever on a tuesday -- if you want to come over to mine or hang around at a nice coffee shop together that's cool too :) [15:55:37] (03CR) 10Phuedx: [C: 04-1] "You can avoid one internal API hit by using the internal API (which is similar, which is good design)." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [15:57:14] (03CR) 10BearND: [C: 04-1] "Needs a manual rebase" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [15:59:21] 10Gather, 10Gather Sprint Greatest Hits: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1249239 (10Jdlrobson) Could we run some performance/stress tests for comparison on some sample data? [16:01:10] jdlrobson: when you're happy with the logBeacon stuff then i'll move the link tracking to it [16:01:21] but i didn't want to change /all the things/ before pushing [16:01:28] (i needed to push, it makes me happy) [16:02:24] 10Gather, 10Gather Sprint Greatest Hits: Spike: Following - https://phabricator.wikimedia.org/T94243#1249243 (10Jdlrobson) Yeh the different rendering is something further down the line. A following page would consist entirely of things that are collections. We'd need to do a query like ( select * from gather_... [16:02:37] phuedx: sounds good :) [16:02:46] gotta go into office now [16:02:47] see ya in a bit [16:03:46] (03PS10) 10Gergő Tisza: Implements prop=listmembership [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203003 (https://phabricator.wikimedia.org/T95516) (owner: 10Yurik) [16:04:04] Deskana: you about? [16:06:16] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1249262 (10Mholloway) Here are a bunch of screenshots from the new tablet (Nexus 9). As you... [16:10:07] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Sprint 55 Release - https://phabricator.wikimedia.org/T95969#1249283 (10Fjalapeno) [16:13:42] (03PS6) 10Mholloway: [WIP - DO NOT REVIEW] Use a higher-res image if available and set it to the width of the column text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205649 (https://phabricator.wikimedia.org/T94646) [16:16:44] tfinc: Hey, what's up? [16:16:56] were just missing you [16:17:06] tfinc: Oh shit, I didn't see this on my calendar. [16:17:09] finishing up about roles [16:20:56] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1168946 (10Mholloway) [16:20:57] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-Android: 4.1.1(85) Gallery in an article displays too much white space above the img's caption - https://phabricator.wikimedia.org/T96311#1214045 (10Mholloway) [16:32:12] (03PS4) 10Phuedx: Hygiene: Generalise the futureLog mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) [16:32:44] (03CR) 10Phuedx: Hygiene: Generalise the futureLog mechanism (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [16:35:58] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1249340 (10KHammerstein) [16:36:07] (03PS3) 10BearND: Make some PersistenceHelpers set the namespace of pages as appropriate [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207727 (https://phabricator.wikimedia.org/T96944) (owner: 10Deskana) [16:36:13] (03CR) 10BearND: [C: 032] Make some PersistenceHelpers set the namespace of pages as appropriate [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207727 (https://phabricator.wikimedia.org/T96944) (owner: 10Deskana) [16:36:18] \o/ [16:37:04] 6Mobile-Web: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1249346 (10Jdlrobson) 3NEW [16:37:16] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1249354 (10Jdlrobson) [16:37:24] ^ phuedx [16:37:46] * phuedx looks [16:38:02] jdlrobson: i have some homemade sloe whiskey for you to try on tuesday [16:38:10] WOOT! [16:38:10] (03CR) 10BearND: [C: 04-1] "Again, wait until Analytics is ready" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/205976 (owner: 10BearND) [16:38:27] phuedx: so should i plan on crashing at yours? :) [16:38:32] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1249357 (10phuedx) Aww!!! Do we have to fix it? [16:38:43] (03PS4) 10Jdlrobson: Render main menu via a server side template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) [16:40:48] dr0ptp4kt: can you permanently cancel the iOS Engineering Backlog meeting? [16:41:03] coreyfloyd: will do. [16:41:10] dr0ptp4kt: dunka [16:41:14] (03Merged) 10jenkins-bot: Make some PersistenceHelpers set the namespace of pages as appropriate [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/207727 (https://phabricator.wikimedia.org/T96944) (owner: 10Deskana) [16:43:35] (03PS11) 10Robmoen: Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 [16:44:26] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1249364 (10phuedx) @Jdlrobson: Could you whack a link in the description? I've yet to see this locally or on en.m. [16:46:53] (03CR) 10Phuedx: Create Special:TopicTag (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [16:50:25] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1249397 (10KHammerstein) [16:51:16] (03CR) 10Phuedx: Create Special:TopicTag (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [16:51:34] (03CR) 10Phuedx: "With the last comment done, this works like a charm. Neato!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [16:51:58] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1249398 (10KHammerstein) a:5MSyed>3KHammerstein [16:54:14] (03CR) 10Legoktm: "Umm, a little confused here. MF now depends on Gather which depends on MF?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [16:55:27] (03CR) 10Phuedx: "The page title is missing, which could be set with the following:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [16:56:02] legoPanda: is that you lego? [16:56:15] phuedx: no you're looking for YuviKTM [16:56:32] * phuedx runs away screaming [16:56:45] 10Gather, 10Gather Sprint Greatest Hits: API: Change default ordering of page titles namespace - https://phabricator.wikimedia.org/T95972#1249426 (10Tgr) a:5Jdlrobson>3Tgr [16:56:46] legoPanda quantum superposition in force phuedx [16:56:58] 10Gather, 10Gather Sprint Greatest Hits: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1249427 (10Tgr) a:5Yurik>3Tgr [16:57:17] and me pinging them on irc collapsed the wavefunction [16:57:25] into the wrong damn state [16:57:25] phuedx: haha jk, I'm the real lego :P [16:57:31] DAMN YOU QUANTUM PHYSICS [16:58:17] legoPanda: yeah the coupling between gather and mf for that prototype is annoying [16:58:23] 10Gather, 3Gather Sprint Forward, 5Patch-For-Review: Add link to moderation expectations draft on Moderation tool - https://phabricator.wikimedia.org/T95635#1249435 (10Jdlrobson) [16:58:24] 10Gather, 10Gather Sprint Greatest Hits: Update in WikimediaMessages extension for enwiki - https://phabricator.wikimedia.org/T96805#1249433 (10Jdlrobson) 5Open>3declined @moushira sent a private e-mail and said that this is the required behaviour so closing. @JKatzWMF if you disagree have a chat with @mou... [16:58:42] but i'd like to stress the word /prototype/ here [16:58:53] phuedx: well right now it's going to cause fatals on most WMF wikis [16:59:02] that's how we roll [16:59:03] 10Gather, 10Gather Sprint Greatest Hits: If a user has collections, their last 3 collections show up on their mobile user profile - https://phabricator.wikimedia.org/T96226#1249438 (10Jdlrobson) a:5JKatzWMF>3None [16:59:12] i don't see why that's a problem? [16:59:22] honestly, most wmf wikis could do with more fatals [16:59:26] keep 'em on their toes [16:59:28] um, what [16:59:44] lolz [16:59:51] can't tell if joking or.... [16:59:55] wait.. did legoktm and yuvipanda have a baby? [17:00:11] we're gonna get so much shit done with these genes! [17:00:17] :P [17:00:23] legoPanda: c -1 it and point that out will ya [17:00:32] /or we could move it to gather/ [17:00:48] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1249440 (10Jdlrobson) [17:00:51] legoPanda: fast iteration at all costs, including taking down the cluster [17:01:08] (03CR) 10Legoktm: [C: 04-1] "Will cause fatals on most wikis that don't have Gather installed. Special page should either go inside Gather (I have no idea what it does" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [17:01:15] :P [17:01:34] ok [17:01:38] phuedx: sounds like Gather would be a good place for it [17:01:44] yeah i know [17:01:50] it's increasingly likely [17:01:55] gotta go give the boy a bath [17:01:56] bbiab [17:01:57] what happens without wikigrok enabled? [17:02:27] but seriously i think fatals are good. the wikimedia movement is very good at reacting to things [17:02:31] not so good when given time to think imo [17:02:37] it's how we get anything done [17:02:52] s/fatals/bugs/regressions [17:02:55] and points out where we need tests [17:04:49] yeah, I raised this problem, but we decided that since it was a prototype we should do it in MF [17:09:04] bearND: hey, i'm struggling a bit trying to get the coveted gerrit +2 permissions. i tried adding my wikimedia email and setting it as a primary address on my current account but that didn't change anything. do i need to make a new account with my wikimedia email? [17:12:08] niedzielski: someone just needs to add you to the wmf ldap group [17:12:43] niedzielski: and by someone I mean ops :P you can just file a bug under operations for it [17:12:59] 6Mobile-Web: Template should be in the View (?) - https://phabricator.wikimedia.org/T97663#1249497 (10Jdlrobson) 3NEW [17:13:58] (03CR) 10Jdlrobson: [C: 032] Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen) [17:14:02] 10Gather, 10Gather Sprint Greatest Hits: Spike: Following - https://phabricator.wikimedia.org/T94243#1249512 (10Tgr) It would be a bit more complicated than that as you need a separate "follow collection" for every user, so instead of a special id you would have to add a type column and then set TYPE_FOLLOW fo... [17:14:04] legoPanda: thanks! i think my ldap access is still in flight so maybe that's why i'm having some strangeness [17:16:36] legoPanda: but your gerrit username is independent of your WMF username? as long as the gerrit account has a WMF email address on it that's tied to ldap, it's good to go? [17:17:17] (03Merged) 10jenkins-bot: Hygiene: Refactor collection flag button to be an actual view [extensions/Gather] - 10https://gerrit.wikimedia.org/r/206973 (owner: 10Robmoen) [17:17:29] yo i'm back [17:18:38] niedzielski: we have two different account systems, SUL is for the production wikis (meta.wm.o, etc.) and ldap, which is gerrit, wikitech.wm.o, and other services [17:19:22] \o joakino [17:19:25] 10Gather, 10Gather Sprint Greatest Hits: API: Allow filtering of collections - https://phabricator.wikimedia.org/T97061#1249518 (10Tgr) I will rather move on with Yuri's suggestion from T97061#1232118. The above query is too rigid - it might work when filtering for >=2 items but would be completely useless whe... [17:20:03] jdlrobson: what do you think of moving wikibugs and grrrit-wm to a different channel [17:20:17] legoPanda: do you know which office.wikimedia.org would fall under? i can't login to office with my personal account but my WMF works there. does that mean it's ldap? [17:20:24] i find them somewhat useful, but i'd like to control the types of notifications that appear here [17:20:37] but yeh a different channel may be better [17:20:47] i do miss messages because of them [17:20:49] team email? [17:20:51] team decision? [17:22:19] jdlrobson: joakino if you move grrrit-wm / wikibugs to a new channel, would it be a good idea to make platform variants like "grrrit-android"? [17:23:39] (03PS1) 10Jdlrobson: Generate menu HTML via JavaScript. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) [17:23:48] ^ phuedx BOYakasha! [17:24:03] jdlrobson: i'll send an email, phuedx agrees. I find them useful too but I miss all the signal in this channel. I'd rather have them on #wikimedia-mobile-notifications or -bots and join there to get the notifications but have the people channel for people [17:24:14] remember to send to mobile-l ! [17:24:23] joakino: +1 [17:24:23] jdlrobson: sure thing [17:25:08] (03CR) 10jenkins-bot: [V: 04-1] Generate menu HTML via JavaScript. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) (owner: 10Jdlrobson) [17:25:16] niedzielski: i think that is configuration, you say grrrit-wm where the gerrit repository notifications go (to which channels). should be easy to change if you guys want notifications somewhere else. i think yuvipanda knows more [17:25:24] (03CR) 10Bmansurov: Create Special:TopicTag (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [17:25:39] niedzielski: oh I over simplified...office.wm.o is a private wiki, so it has its own user database (separate from SUL and ldap)...yay! [17:25:42] (03PS2) 10Jdlrobson: Generate menu HTML via JavaScript. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) [17:26:05] (03PS3) 10Jdlrobson: Generate menu HTML via JavaScript. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) [17:26:40] legoPanda: ok great, then i think the only thing i need to get is ldap access and i'll be set. thanks for all your help [17:27:25] joakino: thanks, i'll have to check with the other droids [17:27:43] (03CR) 10jenkins-bot: [V: 04-1] Generate menu HTML via JavaScript. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) (owner: 10Jdlrobson) [17:28:35] (03PS4) 10Jdlrobson: Generate menu HTML via JavaScript. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) [17:32:02] coreyfloyd: what's the difference between "Proposals" in app process imporvement board and "Needs Triage"? [17:32:05] JonKatz: http://www.amazon.com/Great-Railway-Bazaar-Paul-Theroux/dp/0618658947 [17:32:10] mhurd: hey, sorry i spaced yesterday, want to chat about image maps? can do another time if you're busy now. [17:32:13] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1249558 (10KHammerstein) [17:33:04] mholloway: no worries! i've got some things to wrap up this morning unfortunately - this afternoon perhaps? [17:33:12] kristenlans: not sure really… I mean if I filled out a “proposal” on the card, then I moved it to proposal. But maybe we can collapse them? [17:33:40] maybe we should have a column “ready for discussion” instead [17:33:54] kristenlans: because thats really what it means to me [17:34:16] coreyfloyd: ah OK, that makes sense. Mind if I change the name of that column then? [17:34:25] kristenlans: please do [17:34:30] mhurd: hey, no worries. maybe after 2:30 your time/5:30 mine? [17:35:26] 10Wikipedia-iOS-App: Search deficiencies - not most relevant results are returned - https://phabricator.wikimedia.org/T97601#1249574 (10Fjalapeno) p:5Triage>3Normal [17:35:46] 10Wikipedia-iOS-App: The pencil icon looks misplaced on 'More information' box - https://phabricator.wikimedia.org/T97595#1249583 (10Fjalapeno) p:5Triage>3Low [17:35:59] (03PS1) 10Bgerstle: CI fixes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207848 [17:54:07] 10Gather, 3Mobile-Web-Design: Add a new public collection feed view - https://phabricator.wikimedia.org/T96222#1249750 (10Jdlrobson) [17:54:28] (03CR) 10Bgerstle: "most recent amendment succeeded in jenkins (#102), waiting for build to show up in iTC to verify entitlements." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207848 (https://phabricator.wikimedia.org/T94426) (owner: 10Bgerstle) [17:54:39] 10Gather, 10Gather Sprint Greatest Hits: Spike: Following - https://phabricator.wikimedia.org/T94243#1249753 (10Jdlrobson) [17:54:40] 10Gather: In their collection screen, a user can see a list of the collections they are following - https://phabricator.wikimedia.org/T97627#1249752 (10Jdlrobson) [17:55:02] 10Gather: In their collection screen, a user can see a list of the collections they are following - https://phabricator.wikimedia.org/T97627#1248264 (10Jdlrobson) [17:55:07] (03PS2) 10Bmansurov: Create Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) [17:55:40] 10Gather: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1249764 (10JKatzWMF) 3NEW [17:56:19] 10Gather: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1249779 (10JKatzWMF) [17:56:21] (03PS5) 10Bmansurov: Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) [17:57:24] 10Gather: Implement following backend - https://phabricator.wikimedia.org/T97674#1249790 (10Jdlrobson) 3NEW [17:57:25] (03CR) 10Bgerstle: "entitlements work, but not seeing "What to test"" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207848 (https://phabricator.wikimedia.org/T94426) (owner: 10Bgerstle) [17:57:32] 10Gather: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1249798 (10Jdlrobson) [17:57:38] 10Gather: Implement following backend - https://phabricator.wikimedia.org/T97674#1249800 (10Jdlrobson) [17:57:39] 10Gather: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1249764 (10Jdlrobson) [17:57:53] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [17:58:02] 10Gather: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1249802 (10Jdlrobson) a:3KHammerstein [17:58:12] 10Gather, 3Mobile-Web-Design: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1249803 (10JKatzWMF) [17:58:40] 10Gather: Implement following backend - https://phabricator.wikimedia.org/T97674#1249790 (10Jdlrobson) [17:58:41] 10Gather, 3Mobile-Web-Design: When a user follows a collection, the collection reflects this information - https://phabricator.wikimedia.org/T96225#1249804 (10Jdlrobson) [17:58:56] (03CR) 10Bgerstle: "changelog *should* work when merged to master" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207848 (https://phabricator.wikimedia.org/T94426) (owner: 10Bgerstle) [17:59:07] 10Gather: Implement following backend - https://phabricator.wikimedia.org/T97674#1249790 (10Jdlrobson) [17:59:19] 10Gather, 3Mobile-Web-Design: When a user follows a collection, the collection reflects this information - https://phabricator.wikimedia.org/T96225#1211439 (10Jdlrobson) [17:59:35] 10Gather: Implement following backend - https://phabricator.wikimedia.org/T97674#1249790 (10Jdlrobson) [17:59:36] 10Gather, 10Gather Sprint Greatest Hits: Spike: Following - https://phabricator.wikimedia.org/T94243#1249814 (10Jdlrobson) [17:59:48] (03CR) 10Legoktm: [C: 04-1] Create Special:TopicTag (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [17:59:52] 10Gather: Implement following backend - https://phabricator.wikimedia.org/T97674#1249815 (10Jdlrobson) [18:00:03] (03PS6) 10Bmansurov: Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) [18:02:09] 10Gather: When a collection gets one follower send an Echo notification to the owner of the collection - https://phabricator.wikimedia.org/T96224#1249820 (10Jdlrobson) [18:03:03] 10Gather: When a collection gets one follower send an Echo notification to the owner of the collection - https://phabricator.wikimedia.org/T96224#1211429 (10Jdlrobson) a:3KHammerstein [18:03:03] niedzielski: i just sent you an invite to a meeting happening now! still had your wrong name on it [18:03:36] 10Gather, 3Mobile-Web-Design: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1249827 (10MSyed) {F158989} [18:03:41] 10Gather: Implement following backend - https://phabricator.wikimedia.org/T97674#1249829 (10Jdlrobson) [18:03:42] 10Gather: It should be possible to see most followed collections - https://phabricator.wikimedia.org/T94270#1249828 (10Jdlrobson) [18:04:37] 10Gather, 3Mobile-Web-Design: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1249833 (10MSyed) a:5KHammerstein>3Jdlrobson [18:04:44] 10Gather: Implement following backend - https://phabricator.wikimedia.org/T97674#1249790 (10Jdlrobson) [18:04:59] niedzielski: yeah sorry we're having our team retro right now and it had -y on the invite :-( [18:05:49] thanks mholloway kristenlans [18:06:00] 10Gather: It should be possible to see most followed collections - https://phabricator.wikimedia.org/T94270#1249841 (10Jdlrobson) [18:06:28] https://etherpad.wikimedia.org/p/MobileAppRetrospective [18:06:34] mhurd [18:07:40] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207850 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [18:08:51] 10Gather: Let people create collection before asking them to sign up. - https://phabricator.wikimedia.org/T93233#1249861 (10Jdlrobson) [18:09:00] mhurd https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Team_norms [18:10:01] https://phabricator.wikimedia.org/T97267 [18:10:34] 10Gather: Order collections on creation overlay by last edited - https://phabricator.wikimedia.org/T95600#1249865 (10Jdlrobson) [18:13:27] (03PS3) 10Bmansurov: Create Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) [18:14:08] (03PS4) 10Bmansurov: Create Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) [18:16:32] 10Gather: Creating a collection should not load collection editor - https://phabricator.wikimedia.org/T97677#1249887 (10Jdlrobson) 3NEW a:3JKatzWMF [18:16:49] 10Gather: Creating a collection should not load collection editor - https://phabricator.wikimedia.org/T97677#1249897 (10Jdlrobson) [18:16:51] (03CR) 10jenkins-bot: [V: 04-1] Create Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [18:17:06] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: Create accounts for Build server and update Fastlane / Jenkins to securely use accounts - https://phabricator.wikimedia.org/T94426#1249900 (10BGerstle-WMF) [18:17:25] 10Gather: When a user follows a collection, they receive notifications if updates are made to the collection - https://phabricator.wikimedia.org/T96223#1249902 (10Jdlrobson) This could be really really noisy and not what Echo was designed for.... [18:17:32] 6Mobile-Web, 10Mobile-Web-Sprint-45-Snakes-On-A-Plane, 3Mobile-Web-Design: Implement the mock up in T94736 - https://phabricator.wikimedia.org/T94739#1249903 (10bmansurov) OK, either way T96015 is also done. ;) [18:18:57] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1249907 (10Jdlrobson) [18:20:54] 6Mobile-Web: Generating release notes automatically - https://phabricator.wikimedia.org/T95324#1249916 (10bmansurov) @Jhernandez similar command has already been implemented, the problem is to automatically generate these notes and save it to a file and cut a branch/tag. [18:21:47] mhurd https://phabricator.wikimedia.org/tag/app-process-improvement/ [18:23:37] bmansurov: can't we script thhat? ^ [18:23:58] joakino: we can, that's why we have that task [18:24:08] bmansurov: lol ok [18:24:12] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1249926 (10Jdlrobson) [18:24:39] 10Gather: Changes to edit collection interface - https://phabricator.wikimedia.org/T97679#1249927 (10Jdlrobson) 3NEW [18:24:58] bmansurov: i wont spam the task more with git commands lol [18:25:32] joakino: np, you can if you want, I am sure someone will find them useful in the future. [18:25:58] the future phabricator archeologist will find the true gems in there [18:26:01] 10Gather: Changes to edit collection interface - https://phabricator.wikimedia.org/T97679#1249938 (10Jdlrobson) [18:26:36] 10Gather: Changes to edit collection interface - https://phabricator.wikimedia.org/T97679#1249927 (10Jdlrobson) [18:26:42] jesus christ [18:27:58] 10Gather: Selecting item from search closes it - https://phabricator.wikimedia.org/T97680#1249945 (10Jdlrobson) 3NEW [18:28:04] 10Gather: Selecting item from search closes it - https://phabricator.wikimedia.org/T97680#1249953 (10Jdlrobson) [18:28:34] kaldari__: self ping [18:29:04] nice :) [18:29:05] (03CR) 10Bmansurov: [C: 04-1] Render main menu via a server side template (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) (owner: 10Jdlrobson) [18:29:21] 10Gather: Show search header - https://phabricator.wikimedia.org/T97681#1249961 (10Jdlrobson) 3NEW a:3MSyed [18:29:33] kaldari: ping [18:29:45] 10Gather: Show search header - https://phabricator.wikimedia.org/T97681#1249971 (10Jdlrobson) [18:29:54] bmansurov: just installed IRCCloud :) [18:30:04] 10Gather: Changes to edit collection interface - https://phabricator.wikimedia.org/T97679#1249973 (10Jdlrobson) [18:30:14] kaity: https://phabricator.wikimedia.org/T97681 [18:30:21] kaldari: cool, wanted to test if it was working ;) obviously it is [18:30:37] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1249975 (10KHammerstein) [18:30:57] bmansurov: It has a nice mobile app [18:31:37] kaldari: great, screenshots look awesome [18:32:12] kaldari: So when is more data coming in from wikigrok? [18:32:48] 10Gather: Show search header - https://phabricator.wikimedia.org/T97681#1249978 (10Jdlrobson) @khammerstein is updating this mock [18:33:56] kaity: https://phabricator.wikimedia.org/T97679 [18:34:00] multichill: Good question. The PM, JonKatz, was a bit concerned about all the negative community reaction in the bot discussion, so I think we’re going to hold off on pushing any more data until we have some more features in place (like being able to see all the users who contributed to a submission). [18:34:10] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1249981 (10Jdlrobson) [18:34:16] JonKatz: https://etherpad.wikimedia.org/p/MobileAppRetrospective [18:34:28] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1237425 (10Jdlrobson) [18:35:17] kaldari: If you just include the last n users in the edit summary you're good as far as I'm concerned. What other features do you think are missing? [18:35:32] And of course you should make it almost instant [18:36:27] multichill: we also want to collect more data and do more data analysis on the responses that people submit so that we can tweak the aggregation parameters for maximum accuracy. [18:36:39] ok [18:37:20] multichill: Yes, we want it to be more real-time in the future, rather than manual bot runs. [18:40:29] multichill: Honestly, we were a bit surprised at how negative the initial feedback was, so I’m afraid the entire project has been lowered in priority (compared to other mobile dev work). [18:40:46] 10Gather: Selecting item from search closes it and saves it automatically - https://phabricator.wikimedia.org/T97680#1250000 (10Jdlrobson) [18:40:57] I was supprised too kaldari. Not sure where that came from [18:40:58] multichill: But I’m hoping to keep it going [18:41:03] 10Gather: Selecting item from search closes it and saves it automatically - https://phabricator.wikimedia.org/T97680#1249945 (10Jdlrobson) [18:41:10] 10Gather: Selecting item from search closes it and saves it automatically - https://phabricator.wikimedia.org/T97680#1249945 (10Jdlrobson) [18:41:30] You've been for quite some time. You know that a small group of vocal people to have to represent the general opinion [18:41:41] kaldari: It's more like the other way around [18:42:14] true [18:42:30] 10Gather: Change search header (??) - https://phabricator.wikimedia.org/T97681#1250004 (10Jdlrobson) [18:43:18] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1250014 (10Jdlrobson) [18:43:31] (03CR) 10Bmansurov: [C: 04-1] "Why not use the futureLog function from SchemaMobileWebClickTracking.js?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [18:43:33] 10Gather, 10Gather Sprint Greatest Hits: Prompt for search bar of edit collection overlay - https://phabricator.wikimedia.org/T97267#1250016 (10Jdlrobson) a:5KHammerstein>3None [18:44:29] bmansurov: Did you get a Wikimania approval yet? [18:44:36] kaldari: not yet [18:44:43] :( [18:44:46] did you? [18:44:54] mine was approved ages ago [18:45:05] kaldari: I think I should volunteer a talk to get accepted [18:45:45] kaldari: speaking of the devil, i just got an approval email [18:45:50] Yay!! [18:46:03] see you in mexico, amigo [18:51:57] 10Gather: Implement following backend - https://phabricator.wikimedia.org/T97674#1250041 (10Jdlrobson) [18:52:50] 10Gather, 3Mobile-Web-Design: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1250043 (10Jdlrobson) a:5Jdlrobson>3None [18:53:25] 10Gather, 3Mobile-Web-Design: A user is able to follow a collection - https://phabricator.wikimedia.org/T97673#1249764 (10Jdlrobson) [18:54:26] 10Gather: Collection items should be sorted by modified time not alphabetically. - https://phabricator.wikimedia.org/T95786#1250054 (10Jdlrobson) [18:54:42] 10Gather: Collection items should be sorted by modified time not alphabetically. - https://phabricator.wikimedia.org/T95786#1200184 (10Jdlrobson) @tgr we'd need to add a new column to the gather_list_items table... [18:55:42] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: Crash when attempting to save history entry - https://phabricator.wikimedia.org/T96605#1250060 (10Etonkovidova) Checked with 4.3.1(96) - 'Composing music' section in 'Musical composition' article is fully displayed. When the article is saved... [18:55:43] 10Gather: The user page for a collection contains an explanation of what collections are about. - https://phabricator.wikimedia.org/T97670#1250062 (10Jdlrobson) a:3Jdlrobson We need to work this out in a separate meeting around moderation [18:55:46] 10Gather: When an admin deletes the user page 'child' of a collection, that collection is hidden - https://phabricator.wikimedia.org/T97668#1250065 (10Jdlrobson) a:3Jdlrobson We need to work this out in a separate meeting around moderation [18:55:59] 10Gather: When an admin deletes the user page 'child' of a collection, that collection is hidden - https://phabricator.wikimedia.org/T97668#1250068 (10Jdlrobson) We need to work this out in a separate meeting around moderation [18:58:25] kaldari is stuck in the bathroom! oh nos! [18:59:52] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1250073 (10Deskana) >>! In T96144#1248658, @Bene wrote: > As I suggested, I'd not try to use the default context menu which Android provides but rather add... [19:01:16] bgerstle: sorry to bother you... https://phabricator.wikimedia.org/T96603 mentions test articles where crashes occurred [19:01:26] https://rink.hockeyapp.net/manage/apps/152731/app_versions/5/crash_reasons/32644360 [19:01:27] https://rink.hockeyapp.net/manage/apps/152731/app_versions/13/crash_reasons/32910409 [19:01:54] bgerstle: I do not have an access to HockeyApps - can you tell me which articles were mentioned? [19:02:03] ah sorry, i should give you access [19:02:20] wikipedia.org/en/articles/Supermassive_Black_Hole_(song)/sections/0/Section.html, [19:02:21] is one [19:03:32] (03CR) 10Bmansurov: [C: 04-1] "I started typing a search term, but I don't see any events being sent in the network tab." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [19:03:47] bgerstle: thx! [19:03:51] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [19:07:01] etonkovidova: another is en/articles/Destiny_(video_game) [19:14:29] bgerstle: https://phabricator.wikimedia.org/T88494 + https://phabricator.wikimedia.org/T62720 [19:17:32] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: Crash when failing to read HTML for particular section from disk - https://phabricator.wikimedia.org/T96603#1250121 (10Etonkovidova) Crashes refer to - wikipedia.org/en/articles/Supermassive_Black_Hole_(song)/sections/0/Section.html - en/ar... [19:23:08] 10Wikipedia-iOS-App: Automate Beta Distribution - https://phabricator.wikimedia.org/T96051#1250146 (10Fjalapeno) a:5dr0ptp4kt>3BGerstle-WMF [19:23:20] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Automate Beta Distribution - https://phabricator.wikimedia.org/T96051#1207159 (10Fjalapeno) [19:23:34] mhurd: you coming? [19:23:35] mhurd are you coming to the engineering backlog meeting? do you want to? [19:28:05] (03PS2) 10Robmoen: Create collection button on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207002 (https://phabricator.wikimedia.org/T95214) [19:28:53] (03PS5) 10Bmansurov: Create Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) [19:29:39] (03CR) 10jenkins-bot: [V: 04-1] Create collection button on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207002 (https://phabricator.wikimedia.org/T95214) (owner: 10Robmoen) [19:30:33] jdlrobson: would you mind looking and helping me figure out how to make the + icon inside the button fit better? ^ I feel like there should be an easy way to do this. [19:31:15] (03CR) 10jenkins-bot: [V: 04-1] Create Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [19:35:28] 10Wikipedia-iOS-App: Load first section before loading remaining sections - https://phabricator.wikimedia.org/T92031#1250168 (10BGerstle-WMF) 5Open>3Invalid a:3BGerstle-WMF [19:36:14] (03CR) 10Bmansurov: [C: 04-1] Generate menu HTML via JavaScript. (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) (owner: 10Jdlrobson) [19:37:20] 10Wikipedia-iOS-App, 3Wikimedia-Hackathon-2015-App-Prep: iOS project Makefile's bootstrap goal on a clean OSX machine - https://phabricator.wikimedia.org/T95968#1250176 (10BGerstle-WMF) 5Open>3Resolved a:3BGerstle-WMF [19:37:21] 10Wikipedia-iOS-App, 7Documentation, 3Wikimedia-Hackathon-2015-App-Prep: [EPIC] Make iOS project setup pain free for external contributors - https://phabricator.wikimedia.org/T93249#1250178 (10BGerstle-WMF) [19:39:03] (03PS3) 10Robmoen: Create collection button on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207002 (https://phabricator.wikimedia.org/T95214) [19:44:46] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Use Button in AbuseFilterOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206336 (owner: 10Jdlrobson) [19:47:32] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Drawer uses Icon and Button (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206335 (owner: 10Jdlrobson) [19:47:34] (03CR) 10Phuedx: "Thanks @Bmansurov. Could you please include your browser (including version) as it would help me figure out what's going on." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [19:48:44] (03CR) 10Bmansurov: "@phuedx, Firefox 37.0.2 on Mac OS X 10.10.3." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [19:52:13] (03CR) 10Phuedx: "Because it /only/ works for that schema." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [19:53:55] (03CR) 10Phuedx: "That is to say, I'll be getting rid of futureLog in a follow-up patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [19:57:25] 10Wikipedia-iOS-App: [EPIC] Replace MWK exceptions with assertions & nil fallbacks - https://phabricator.wikimedia.org/T96599#1250223 (10BGerstle-WMF) [19:57:26] 10Wikipedia-iOS-App: Separate caching from “saved pages” and “recent pages" - https://phabricator.wikimedia.org/T97576#1250222 (10BGerstle-WMF) [19:57:28] 10Wikipedia-iOS-App: Standardize image fetch/cache/fallback logic - https://phabricator.wikimedia.org/T95350#1250224 (10BGerstle-WMF) [19:57:30] 10Wikipedia-iOS-App, 7Epic: [EPIC] Data Layer Improvements - https://phabricator.wikimedia.org/T94037#1250221 (10BGerstle-WMF) [20:07:17] 10Gather, 10Gather Sprint Greatest Hits, 3Mobile-Web-Design, 5Patch-For-Review: Make it possible to create a collection from Special:Gather - https://phabricator.wikimedia.org/T95214#1250250 (10rmoen) Patch is there and working. Need some help getting the plus icon to be inline with the text. @Jdlrobson,... [20:08:02] (03CR) 10Bmansurov: "I don't think you should. Instead you should move it Schema.js because it's very simple and does the same thing as beacons. Moreover, ther" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [20:09:44] 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web: A logged in user who opts in to mobile web beta is in beta until they opt out. - https://phabricator.wikimedia.org/T97193#1250260 (10rmoen) @JKatzWMF, @Jdlrobson: Currently for anons this cookie is set. Assuming we want to still use cookies then to keep... [20:10:35] (03CR) 10Phuedx: "It doesn't do the same thing as beacons. It stores schema specific information as three separate entries in local storage. So it'll need t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [20:11:18] 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web: A logged in user who opts in to mobile web beta is in beta until they opt out. - https://phabricator.wikimedia.org/T97193#1250269 (10rmoen) a:3rmoen [20:12:33] (03CR) 10Fjalapeno: [C: 031] CI fixes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207848 (https://phabricator.wikimedia.org/T94426) (owner: 10Bgerstle) [20:12:51] (03CR) 10Fjalapeno: [C: 032] CI fixes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/207848 (https://phabricator.wikimedia.org/T94426) (owner: 10Bgerstle) [20:13:34] bmansurov: i'm fine dropping the the array but i felt it was neater in a separate file -- if you don't think it is then we can merge 'em [20:13:46] as much as i like having conversations in gerrit comments… [20:14:19] phuedx: i prefer we use what we already have. maybe other should join the discussion [20:14:44] bmansurov: but it needs to be made slightly more general in order to handle different types of events [20:15:07] different schemas [20:15:13] sorry -- types is the wrong word [20:15:48] phuedx: yes you're right, but it's a minor change compared to the new change [20:16:28] phuedx: i will remove the -1 and let others decide [20:16:36] no don't remove the -1 [20:16:45] (03CR) 10Bmansurov: Hygiene: Generalise the futureLog mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [20:16:52] already did [20:17:25] i noticed [20:18:04] bmansurov: i'll comment on the change, but out of curiousity, in firefox do you see the mobilewebuiclicktracking events fire? [20:18:19] there's one that fires when the hamburger is clicked, and i don't see it in firefox [20:18:29] phuedx: yes, let me double check [20:18:35] but after a debugging statement, eventlogging seems to be being called [20:20:17] rmoen_: I assume you’re not going to Wikimania, correct? [20:20:28] phuedx: clicking on the search field and the hamburger menu sent 2 events, so yes [20:20:37] kaldari: no. Didn't apply [20:21:17] 6Mobile-Web, 6Collaboration-Team, 10Flow, 10OOjs-UI, and 4 others: OOjs UI is optimized for font-size of 12.8px (0.8×16px), but sets it inconsistently for windows and toolbars only, requiring CSS counteractions - https://phabricator.wikimedia.org/T91152#1250334 (10matmarex) [20:21:19] kaldari: baby is going to run my life [20:22:23] bmansurov: and i see 'em in firefox developer edition (including the search schema ones) [20:22:25] hrrm [20:23:12] phuedx: ok, let me check again [20:23:40] bmansurov: wait a sec -- i'm updating my plain firefox :/ [20:23:57] but in dev edition they show up : [20:24:00] :/ [20:24:29] (03CR) 10Phuedx: [C: 04-1] "@Bmansurov's complexity argument is valid." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [20:24:45] phuedx: sorry about the false alarm, it's working now. [20:24:51] wha?! [20:25:06] ;) [20:25:16] stupid firefox [20:25:50] stupid anything but me :) [20:32:30] 10Wikipedia-iOS-App: [Spike] Explore Count.ly for App analytics - https://phabricator.wikimedia.org/T97699#1250363 (10Fjalapeno) 3NEW [20:36:23] 10Wikipedia-iOS-App: [Spike] Explore Count.ly for App analytics - https://phabricator.wikimedia.org/T97699#1250377 (10Fjalapeno) [20:42:39] 10Gather: The user page for a collection contains an explanation of what collections are about. - https://phabricator.wikimedia.org/T97670#1250386 (10Jdlrobson) 5Open>3Invalid [20:43:01] 10Gather: When an admin deletes the user page 'child' of a collection, that collection is hidden - https://phabricator.wikimedia.org/T97668#1250394 (10Jdlrobson) 5Open>3Invalid [20:45:17] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Stop using mw-ui-button without abstraction (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 (owner: 10Jdlrobson) [20:46:02] bmansurov: i've cut out beacons and moved only the store-a-single event over to schema [20:46:05] just running tests [20:46:11] you were right about unnecessary complexity [20:46:35] 👍 [20:47:16] kaldari: i see you on youtube, fyi ;) [20:47:39] https://www.youtube.com/watch?v=JzS7zD_zwfo&feature=youtu.be for anyone interested [20:48:27] 10Gather, 10Gather Sprint Greatest Hits: Spike: Flagging - https://phabricator.wikimedia.org/T96282#1250428 (10rmoen) I'm in favor of having a gather_list_flags table for individual flags. I'm a little worried about performance in regards to having a flag_count on gather_list. Flagging would involve an inse... [20:48:46] (03PS5) 10Phuedx: Log MobileWebSearch events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) [20:48:48] (03PS5) 10Phuedx: Hygiene: Generalise the futureLog mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) [20:49:35] phuedx: ^ the commit message needs an update too ;) [20:50:17] does it? [20:50:49] although, it keeps cutting of #save for some reason [20:51:12] yeah the last sentence [20:51:51] 10Gather: Implement flagging backend - https://phabricator.wikimedia.org/T97704#1250434 (10Jdlrobson) 3NEW [20:52:01] 10Gather, 10Gather Sprint Greatest Hits: Spike: Flagging - https://phabricator.wikimedia.org/T96282#1250443 (10Jdlrobson) [20:52:02] 10Gather: Implement flagging backend - https://phabricator.wikimedia.org/T97704#1250442 (10Jdlrobson) [20:52:09] 10Gather: Implement flagging backend - https://phabricator.wikimedia.org/T97704#1250434 (10Jdlrobson) [20:52:09] (03PS6) 10Phuedx: Log MobileWebSearch events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) [20:52:11] (03PS6) 10Phuedx: Hygiene: Generalise the futureLog mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) [20:52:15] vim seemed to be cutting off #save :/ [20:52:17] 10Gather: Autohide collections - https://phabricator.wikimedia.org/T97667#1250446 (10Jdlrobson) [20:52:18] maybe [20:52:24] 10Gather: Implement flagging backend - https://phabricator.wikimedia.org/T97704#1250434 (10Jdlrobson) [20:52:25] 10Gather: Autohide collections - https://phabricator.wikimedia.org/T97667#1249616 (10Jdlrobson) [20:52:35] okie poke i gotta go [20:52:47] it's bed time [20:53:27] 10Gather: A user who has flagged a collection cannot flag the same collection so that they do not have disproportionate voice. - https://phabricator.wikimedia.org/T95768#1250452 (10Jdlrobson) [20:53:34] 10Gather: A user who has flagged a collection cannot flag the same collection so that they do not have disproportionate voice. - https://phabricator.wikimedia.org/T95768#1199810 (10Jdlrobson) [20:53:35] 10Gather: Implement flagging backend - https://phabricator.wikimedia.org/T97704#1250434 (10Jdlrobson) [20:53:44] phuedx|zzZ: cya [20:53:45] vibha: kaity|away leaving main page images aside for the moment, how close is the current APK to what you are looking for on a phone? I think it's really on tablets where the image size resolution issues start to make a big difference. [20:54:15] vibha: kaity|away i think the current version looks great on a phone, for the most part. [20:55:29] 10Wikipedia-iOS-App: [EPIC] Improve crash diagnostics - https://phabricator.wikimedia.org/T97705#1250464 (10BGerstle-WMF) 3NEW [20:55:42] 10Wikipedia-iOS-App: [EPIC] Improve crash diagnostics - https://phabricator.wikimedia.org/T97705#1250472 (10BGerstle-WMF) [20:55:43] 10Wikipedia-iOS-App: Organize, filter, and store dev logs - https://phabricator.wikimedia.org/T94044#1250473 (10BGerstle-WMF) [20:56:15] 10Gather: Implement flagging backend - https://phabricator.wikimedia.org/T97704#1250475 (10Jdlrobson) [20:56:38] 10Gather: A user who has flagged a collection cannot flag the same collection so that they do not have disproportionate voice. - https://phabricator.wikimedia.org/T95768#1250477 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Merged into T97704: Implement flagging backend [20:59:01] (03CR) 10Bmansurov: [C: 031] Hygiene: Generalise the futureLog mechanism (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207762 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [20:59:27] 10Wikipedia-iOS-App: Integrate developer logs into HockeyApp crashes - https://phabricator.wikimedia.org/T97707#1250498 (10BGerstle-WMF) 3NEW [20:59:52] 10Gather: Implement flagging backend - https://phabricator.wikimedia.org/T97704#1250505 (10Jdlrobson) [21:01:59] (03PS4) 10Robmoen: Create collection button on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207002 (https://phabricator.wikimedia.org/T95214) [21:02:51] (03CR) 10Bmansurov: [C: 031] "wfm" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207763 (https://phabricator.wikimedia.org/T96326) (owner: 10Phuedx) [21:02:54] 10Wikipedia-iOS-App: Verify that whenever a user explicitly refreshes a page, that we always make a network request. - https://phabricator.wikimedia.org/T97578#1250516 (10BGerstle-WMF) IMO this is something we should address when fixing caching & invalidation logic (including explicit, manual invalidation). [21:05:57] vibha: kaity and actually i think even full-width main page images will be manageable on phones so long as we impose some sort of reasonable height limit [21:07:03] vibha: are we having the meeting? [21:07:55] dbrant: hey Sorry! Didnt realize you were joining so Corey and I were on a different hangout [21:08:09] We are both joining the hangout slated for the meeting [21:14:44] 10Wikipedia-iOS-App: [SPIKE] Try to crash the app using automated tests - https://phabricator.wikimedia.org/T97712#1250566 (10BGerstle-WMF) 3NEW [21:14:54] coreyfloyd: all eng tasks created and at top of backllog [21:15:28] mhurd just missing yoru bug [21:16:27] bgerstle: will file in a bit. sorry in the middle of something [21:16:31] k [21:16:40] no rush, prio meeting isn't until tomorrow [21:17:23] 10Gather: Collection items should be sorted by modified time not alphabetically. - https://phabricator.wikimedia.org/T95786#1250587 (10Tgr) What's the point of having `gli_order`˙if we are going to sort chronologically? [21:17:30] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: As a user, I want to be able to cancel data migration - https://phabricator.wikimedia.org/T96429#1250591 (10BGerstle-WMF) @Fjalapeno @Vibhabamba are we thinking we should abandon this? [21:18:51] 10Wikipedia-iOS-App: Remove legacy data files after migration - https://phabricator.wikimedia.org/T97713#1250595 (10BGerstle-WMF) 3NEW [21:19:26] 10Wikipedia-iOS-App, 7Epic: [EPIC] Data Layer Improvements - https://phabricator.wikimedia.org/T94037#1250606 (10BGerstle-WMF) [21:19:27] 10Wikipedia-iOS-App: Remove legacy data files after migration - https://phabricator.wikimedia.org/T97713#1250607 (10BGerstle-WMF) [21:21:41] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: Create accounts for Build server and update Fastlane / Jenkins to securely use accounts - https://phabricator.wikimedia.org/T94426#1163013 (10BGerstle-WMF) Can be moved to "Done" once another build goes out from gerrit/master. [21:22:02] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: Select icon file based on build type (alpha, beta, etc) on build server - https://phabricator.wikimedia.org/T94534#1250615 (10BGerstle-WMF) 5Open>3Resolved [21:22:51] 10Wikipedia-iOS-App: Process app icons when building from fastlane instead of Xcode - https://phabricator.wikimedia.org/T97714#1250616 (10BGerstle-WMF) 3NEW [21:25:59] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: [EPIC] Provision Mac mini as iOS build server - https://phabricator.wikimedia.org/T91786#1250631 (10BGerstle-WMF) [21:25:59] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Revamp xcode configuration for CI - https://phabricator.wikimedia.org/T92886#1250630 (10BGerstle-WMF) 5Open>3Resolved [21:26:14] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: Create a fastlane configuration file for iOS builds - https://phabricator.wikimedia.org/T92884#1250632 (10BGerstle-WMF) 5Open>3Resolved [21:26:15] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: [EPIC] Provision Mac mini as iOS build server - https://phabricator.wikimedia.org/T91786#1096336 (10BGerstle-WMF) [21:26:27] bmansurov: on YouTube? Are you watching the brown bag? [21:26:29] i promise i'm not doing this intentionally to prove a point on the skynet thread :-P [21:26:50] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: [EPIC] Provision Mac mini as iOS build server - https://phabricator.wikimedia.org/T91786#1096336 (10BGerstle-WMF) [21:26:53] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-53-iOS: Configure Jenkins for iOS builds - https://phabricator.wikimedia.org/T92882#1250637 (10BGerstle-WMF) 5Open>3Resolved [21:27:04] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: [EPIC] Provision Mac mini as iOS build server - https://phabricator.wikimedia.org/T91786#1096336 (10BGerstle-WMF) [21:27:17] kaldari___: what brown bag? I saw you at the https talk [21:27:39] yep, same talk :) [21:27:57] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-54-iOS: [EPIC] Provision Mac mini as iOS build server - https://phabricator.wikimedia.org/T91786#1096336 (10BGerstle-WMF) [21:30:33] 10Gather, 10Gather Sprint Greatest Hits: Spike: Flagging - https://phabricator.wikimedia.org/T96282#1250649 (10Tgr) Joining on the primary key is trivial performance-wise; aggregating the flags not so much. See T97061 for some performance analysis. Adding an update to a insert would not be much difference perf... [21:33:17] 10Wikipedia-iOS-App, 3App-Process-Improvement, 3Mobile-App-Sprint-56-iOS: Use GitHub as main repo for Wikipedia iOS - https://phabricator.wikimedia.org/T95749#1250654 (10BGerstle-WMF) Just want to quickly assure people I haven't forgotten about this and will follow-up soon with our next steps—including a rec... [21:44:21] 10Gather: Collection items should be sorted by modified time not alphabetically. - https://phabricator.wikimedia.org/T95786#1250705 (10Jdlrobson) In future we want to provide an interface was sorting arbitrarily. Right now the sorting seems random/nonexistent - not sure if gli_order or api is to blame for that.... [21:45:08] 10Gather: Collection items should be sorted by modified time not alphabetically. - https://phabricator.wikimedia.org/T95786#1250706 (10Jdlrobson) Gli_order should reflect when added but currently it doesn't seem to unless I'm mistaken? [21:51:11] bgerstle_afk: thanks [21:53:06] (03PS24) 10Dbrant: Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 [21:57:32] (03PS8) 10Dbrant: Link previews (prototype 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) [22:01:13] (03PS5) 10Robmoen: Create collection button on Special:Gather [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207002 (https://phabricator.wikimedia.org/T95214) [22:02:08] bearND: any particular tips/tricks on keeping on top of OTRS emails? that's another task that never seems to make it off my backlog [22:02:25] niedzielski: did you get OTRS access yet? [22:02:54] bearND: niedzielski there are good suggestions in there but the signal-noise ratio is just so low [22:03:07] mholloway: yep, adam got me hooked up [22:03:14] niedzielski: cool [22:03:15] mholloway: i've not had much time to explore it yet [22:04:33] mholloway: niedzielski: I just add a GMail label to them and go through some of them when I have time. Otherwise it seems to distracting [22:05:00] bearND: OK - yeah, that's what i'm doing now as well [22:06:27] bearND: have you and dbrant looked into https://github.com/ACRA/acralyzer at all? i haven't really but it looks potentially useful [22:07:26] mholloway: I haven't looked into it [22:08:42] dbrant: Hi. Are you going to attend the story prioritization meeting tomorrow or do you want me to? [22:09:20] anyway, i'm off to buy some groceries. see you tomorrow! [22:10:50] bearND: If my calculations are correct, I should actually be able to attend tomorrow's meeting, since I'll have a long layover in Dallas on my way home... [22:12:12] dbrant: cool. Ah, going to be upright tomorrow then. [22:12:16] ;) [22:12:40] bearND: yep! can't believe how quickly the time has passed. [22:13:38] dbrant: It goes quickly, esp. when you have fun [22:17:55] 10Gather: API: Support user managed sort order - https://phabricator.wikimedia.org/T91017#1250787 (10Tgr) [22:19:01] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android: Text selection and sharing does not work with HTC Sense - https://phabricator.wikimedia.org/T96144#1250788 (10Dbrant) @Bene Sure, we could entirely override the default context menu and provide our own, but if we do that, then we'd have to re-implement al... [22:24:17] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: On iOS 8.3 iPhone 5c in Private mode Safari, sometimes dragging/flicking doesn't scroll in modals - https://phabricator.wikimedia.org/T95561#1250805 (10kaldari) a:3kaldari [22:28:29] 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web: A logged in user who opts in to mobile web beta is in beta until they opt out. - https://phabricator.wikimedia.org/T97193#1250831 (10JKatzWMF) @rmoen yes! [22:31:27] 10Wikipedia-Android-App, 3Mobile-App-Sprint-55-Android, 5Patch-For-Review: Action bar can retain background treatment (transparent or black), until we know whether destination article has an image. - https://phabricator.wikimedia.org/T95067#1179597 (10Vibhabamba) Signed off by Design. [22:32:32] (03PS9) 10BearND: WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) [22:34:01] 10Wikipedia-Android-App, 10Wikipedia-iOS-App, 3Mobile-App-Sprint-55-Android, 3Mobile-App-Sprint-56-iOS, 5Patch-For-Review: As a user I want to get quick context about a link. A combination of text and image will help me learn. (Prototype 1) - https://phabricator.wikimedia.org/T95030#1250861 (10Vibhabamba... [22:36:47] 10Wikipedia-iOS-App, 3Mobile-App-Sprint-56-iOS: Some article titles are randomly bolded in read more section - https://phabricator.wikimedia.org/T96263#1250876 (10Vibhabamba) Signed off by Design. [22:40:14] @etonkovidova https://phabricator.wikimedia.org/T74554 [22:40:33] Kindly verify by setting keyboard language to hebrew [22:40:39] vibha: thx! [22:43:05] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1250880 (10Vibhabamba) @Niedzielski any way to get a build to test this? [22:44:23] (03CR) 10Jdlrobson: [C: 04-1] "Tried to make a public collection" (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207002 (https://phabricator.wikimedia.org/T95214) (owner: 10Robmoen) [22:44:43] (03CR) 10BearND: [C: 032] Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [22:45:00] (03Merged) 10jenkins-bot: Link previews (prototype 1 + feature flags) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/202615 (owner: 10Dbrant) [22:45:14] (03PS6) 10Jdlrobson: Correct API inconsistency in response [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) [22:45:18] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: Menu Drag Margins Should Match Page Layout Margin - https://phabricator.wikimedia.org/T96341#1250887 (10Niedzielski) @Vibhabamba Since this was merged, it should should be available in alpha. Are you able to download it? If not, I'm h... [22:45:18] (03CR) 10BearND: [C: 032] Link previews (prototype 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) (owner: 10Dbrant) [22:45:27] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Link tagged categories (T94739) on article pages to anonymously created gather lists (T94714) for that property. - https://phabricator.wikimedia.org/T94742#1250889 (10bmansurov) a:3bmansurov [22:45:39] (03Merged) 10jenkins-bot: Link previews (prototype 2) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/203494 (https://phabricator.wikimedia.org/T95723) (owner: 10Dbrant) [22:45:41] 10Wikipedia-Android-App, 7Easy, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: 'Tap here to expand' - the label should change when the section is expanded? - https://phabricator.wikimedia.org/T86860#1250893 (10Vibhabamba) @Niedzielski The tablet screenshots looks great. If it looks exactly like this for... [22:46:03] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [22:46:56] (03PS6) 10Bmansurov: Create Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) [22:47:54] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) (owner: 10Jdlrobson) [22:49:22] (03CR) 10jenkins-bot: [V: 04-1] Create Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [22:49:24] (03PS8) 10Jdlrobson: Hygiene: Simplify CollectionPageList [extensions/Gather] - 10https://gerrit.wikimedia.org/r/203253 (https://phabricator.wikimedia.org/T97594) [22:49:43] (03PS3) 10Jdlrobson: Add optin to beta panel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207335 (https://phabricator.wikimedia.org/T96286) [22:49:50] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: On iOS 8.3 iPhone 5c in Private mode Safari, sometimes dragging/flicking doesn't scroll in modals - https://phabricator.wikimedia.org/T95561#1250921 (10kaldari) 5Open>3Resolved Both of these issues appear to have been fixed by https://gerrit.wi... [22:51:12] 10Wikipedia-Android-App, 7Easy, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: 'Tap here to expand' - the label should change when the section is expanded? - https://phabricator.wikimedia.org/T86860#1250924 (10Niedzielski) @Vibhabamba, yep, it's intended to appear the same on all devices. Here's a shot... [22:51:15] (03CR) 10jenkins-bot: [V: 04-1] Add optin to beta panel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207335 (https://phabricator.wikimedia.org/T96286) (owner: 10Jdlrobson) [22:51:23] (03CR) 10jenkins-bot: [V: 04-1] Correct API inconsistency in response [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) (owner: 10Jdlrobson) [22:52:11] (03CR) 10Legoktm: [C: 04-1] Create Special:TopicTag (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov) [22:52:52] 6Mobile-Web: Search icon in mobile header on alpha is tiny - https://phabricator.wikimedia.org/T97729#1250927 (10kaldari) 3NEW [22:53:09] 10Gather Sprint Greatest Hits, 5Patch-For-Review: Hiding throws error - https://phabricator.wikimedia.org/T97600#1250934 (10Jdlrobson) p:5Triage>3High [22:57:58] coreyfloyd: you around? [22:59:34] (03PS10) 10BearND: WIP: Use experimental page content service [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/201369 (https://phabricator.wikimedia.org/T91798) [23:01:03] (03CR) 10Robmoen: "Thanks for the feedback. I will investigate these issues. I had originally tested this quite thoroughly but this was before quite a few " (034 comments) [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207002 (https://phabricator.wikimedia.org/T95214) (owner: 10Robmoen) [23:02:19] 10Wikipedia-iOS-App: Refactor URLCache bits into a custom NSURLProtocol - https://phabricator.wikimedia.org/T97730#1250964 (10Mhurd) 3NEW a:3Mhurd [23:02:53] bgerstle_afk: ^ coreyfloyd ^ [23:04:46] (03CR) 10Kaldari: [C: 032] Fixing scrolling in the editor in Mobile Safari [extensions/MobileFrontend] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207852 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [23:04:58] (03CR) 10Kaldari: [C: 032] Fixing scrolling in the editor in Mobile Safari [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207850 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [23:05:43] niedzielski: see you tomorrow [23:07:15] Deskana: hey there. do you mind checking out what gerrit groups you're in? https://gerrit.wikimedia.org/r/#/settings/group-memberships [23:07:58] Deskana: i'm trying to get +2 permissions but we can't figure out why i don't have them yet [23:09:37] (03Merged) 10jenkins-bot: Fixing scrolling in the editor in Mobile Safari [extensions/MobileFrontend] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207852 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [23:09:39] (03Merged) 10jenkins-bot: Fixing scrolling in the editor in Mobile Safari [extensions/MobileFrontend] (wmf/1.26wmf3) - 10https://gerrit.wikimedia.org/r/207850 (https://phabricator.wikimedia.org/T95465) (owner: 10Kaldari) [23:09:57] niedzielski: A lot of them! [23:10:49] Deskana: nuts! you're probably not a good person to ask :) i need to find someone slightly more elevated than "Joe Login" [23:11:00] niedzielski: https://i.imgur.com/cml33VI.png [23:11:23] I'm pretty sure "ldap/wmf" is the relevant one [23:11:31] Deskana: i'm in that ldap/project-basion so yeah, i think you're right [23:11:46] I think that gives you +2 in almost every repository [23:12:12] For example, I can seemingly +2 patches in mediawiki/core [23:12:24] Deskana: nice! well, thanks. i'll see where this gets me [23:14:55] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] - 10https://gerrit.wikimedia.org/r/207008 (https://phabricator.wikimedia.org/T97268) (owner: 10Jdlrobson) [23:19:13] (03PS5) 10Jdlrobson: Generate menu HTML via JavaScript. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) [23:19:44] (03CR) 10Jdlrobson: Generate menu HTML via JavaScript. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) (owner: 10Jdlrobson) [23:23:30] (03CR) 10Jdlrobson: [C: 032] Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [23:25:22] 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1251024 (10Jdlrobson) [23:25:22] 6Mobile-Web: Search icon in mobile header on alpha is tiny - https://phabricator.wikimedia.org/T97729#1251023 (10Jdlrobson) [23:25:36] 10Gather, 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1249346 (10Jdlrobson) [23:26:00] (03CR) 10Jdlrobson: [C: 04-2] "shoot seems to break nearby" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [23:26:33] had to slap a -2 on there to stop it merging bmansurov [23:26:39] i think that works :-S [23:26:56] jdlrobson: np, how did you figure out that it breaks nearby? [23:27:03] i just went to nearby [23:27:05] infinite spinner [23:27:09] no errors though [23:27:23] ok, you may need to share your location [23:27:43] 10Wikipedia-Android-App, 3Mobile-App-Sprint-56-Android, 5Patch-For-Review: In article images: Use a higher res image if available and set it to the width of the column text. - https://phabricator.wikimedia.org/T94646#1251028 (10KHammerstein) @Mholloway For images that are less than 100 px, leave small as dis... [23:28:05] mm seems to work in firefox but no chrome [23:28:08] let me debug a bit more [23:28:50] bmansurov: weird. seems to work in incognito mode [23:28:55] could just be an issue with geolocation [23:29:01] prolly [23:29:13] (03CR) 10Jdlrobson: [C: 032] "False alarm" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [23:30:10] 10Gather, 6Mobile-Web, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1251029 (10Jdlrobson) It's being caused by oojs ui. [23:30:16] 10Gather, 6Mobile-Web, 10OOjs-UI, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1251030 (10Jdlrobson) [23:30:43] (03Merged) 10jenkins-bot: Hygiene: Make preRender and postRender functions on View not take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206855 (https://phabricator.wikimedia.org/T96269) (owner: 10Bmansurov) [23:33:33] 10Gather, 6Mobile-Web, 10OOjs-UI, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha - https://phabricator.wikimedia.org/T97654#1251035 (10Jdlrobson) @esanders @Matmarex, this is caused by the same problem that hit the mobile settings link... only this time the icon oojs ui uses is... [23:34:54] 6Mobile-Web, 5Patch-For-Review: Pre and post render functions on View should not take arguments - https://phabricator.wikimedia.org/T96269#1251037 (10Jdlrobson) 5Open>3Resolved [23:41:06] (03PS5) 10Jdlrobson: Render main menu via a server side template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) [23:41:08] (03PS6) 10Jdlrobson: Generate menu HTML via JavaScript. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207844 (https://phabricator.wikimedia.org/T95332) [23:41:21] (03CR) 10Jdlrobson: Render main menu via a server side template (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207139 (https://phabricator.wikimedia.org/T97431) (owner: 10Jdlrobson) [23:43:42] (03PS4) 10Jdlrobson: Add optin to beta panel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207335 (https://phabricator.wikimedia.org/T96286) [23:45:27] 10Gather, 6Mobile-Web, 10OOjs-UI, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha and Gather beta - https://phabricator.wikimedia.org/T97654#1251055 (10Jdlrobson) [23:45:36] 10Gather, 10Gather Sprint Greatest Hits, 6Mobile-Web, 10OOjs-UI, 3Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story: Tiny search icon in alpha and Gather beta - https://phabricator.wikimedia.org/T97654#1249346 (10Jdlrobson) [23:56:22] (03PS9) 10Jdlrobson: Hygiene: Stop using mw-ui-button without abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/206016 [23:58:44] (03CR) 10Kaldari: [C: 04-1] Create Special:TopicTag (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/207688 (https://phabricator.wikimedia.org/T96015) (owner: 10Bmansurov)