[07:31:21] good morning! [08:10:24] morning joakino [08:11:01] hi phuedx ! [08:57:32] hey jdlrobson [08:57:36] you in our timezone yet? [09:05:44] phuedx: i think so [09:10:46] joakino: where did the bots get moved to again? [09:11:15] phuedx: did they get moved? [09:11:34] yeah, florian submitted a patch and it got merged [09:11:46] lol [09:11:56] oh [09:12:01] they're in wikimedia-dev [09:12:27] joakino: https://gerrit.wikimedia.org/r/#/c/208134/ [09:16:15] phuedx: how do you see the channel list on irccloud [09:16:44] joakino: you mean the list of channels you're connected to channel list? [09:17:06] phuedx: the channel list of freenode [09:17:23] i'm doing /list but it is ignoring me [09:18:03] joakino: it's rate limited on freenode [09:27:35] phuedx: in limechat it always worked [09:27:50] phuedx: can you make it to the api meeting or are you gonig to ask for a re-schedule? [09:27:50] good for limechat [09:27:53] timing is pretty bad [09:28:18] 7:05 -> 7:55 pm? [09:28:20] phuedx: now I list channels on limechat and add them copypasting here :p [09:28:41] phuedx: oh, i thought it was later [09:29:04] sorry [09:29:38] \o [09:29:45] phuedx: yup [09:29:52] so what working patterns do you guys have [09:31:52] jdlrobson: I do 9 or 10 to 13 or 14, and 3 hours on the afternoon [09:32:58] jdlrobson: afternoon hours are 18:00+ to grab 9am-11am SF with meetings and stuff [09:33:06] varies depending on meeting and the day [09:33:14] 10 am to 12 pm and then lunch with the fam, then 1 until whenever [09:33:23] with a break in the afternoon because i'm poop in the afternoon [09:33:29] mornings and evenings are my jam [09:33:54] egg estimation meetings are going to be a nightmare over next few weeks [09:33:59] they all need rescheduling yuk [09:35:37] jdlrobson: welcome to europe [09:35:41] xD [09:36:05] heh need to work out my comp days [09:36:13] joakino: so did you want to have a day off in morroco? [09:36:47] jdlrobson: for example? [09:36:57] jdlrobson: thursday? [09:37:06] wed? [09:37:08] or wednesday yeh [09:37:27] screw y'all [09:37:33] actually, i can't complain [09:37:49] am going to spend some time in poole with the fam after the hackathon [09:37:53] 20th may it is [09:38:14] jdlrobson: could be a good idea [09:38:21] do either of you fine pair like death metal? [09:38:34] well, more heavy metal? [09:38:45] joakino: check your email from adam [09:38:59] jdlrobson: i'm actually not sure how i'm going to do it since i've never requested any days off (except illness or holiday) and i'm transitioning from whatever we are to employee [09:39:05] i wish we had our team situation sorted out though [09:39:18] joakino: read [reading-wmf] Reading Team Lyon Hackathon Time Off [09:39:22] fill in spreadsheet. done :) [09:39:25] ok [09:39:29] ^ that [09:39:42] remember 25th is a day off anyway [09:39:43] jdlrobson: yeah, well it's cool that we're all involved in the conversation [09:39:49] rather than having a change forced on us, eh? [09:40:17] crapton of emails [09:40:23] joakino: not sure about you, but the contract/handbook i've received seem like straight copypasta jobs and are creepy [09:40:33] phuedx: i like the conversation, there are good points all around [09:40:43] "The Company/Client reserves the right to stop and search all workers who work for the Company. The searching will normally only be carried out by trained staff and/or security staff. Your immediate line manager will be able to advise you who these staff are for your future reference." [09:41:09] phuedx: wtf is that [09:41:11] neither the contract, nor the handbook reflect the fact that i'm a remote employee [09:41:17] a quote from the handbook [09:41:22] phuedx: lol [09:42:14] joakino: you /may/ have received the same handbook [09:42:15] phuedx: i'm sure safeguard has bouncers on payroll to perform crotch touching to remoties [09:42:16] i'm not sure [09:43:06] brb -- my mum's just arrived [09:43:31] phuedx: at this point I only care about not fuck with my governments taxes dept. and getting paid somehow at the end of the month [09:44:15] yup [09:44:20] which is awful [09:44:48] because, to me, it feels like i'm pressured into signing a contract that is /so/ disconnected from the way i work that it's basically meaningless [09:47:17] phuedx: it is meaningless. The only important part is safeguard's uk related contract... [09:50:56] *ianal [10:05:36] hey phuedx jdlrobson i have vboxheadless taking 250% cpu now [10:05:42] how do I diagnose for opening a bug [10:06:01] joakino, vagrant ssh --> top [10:06:38] jobrunner went bonkers? [10:06:50] MaxSem: shows nothing taking more than 1% [10:07:00] it is now stuck at 100% perpetually [10:10:15] the virtual machine is taking 5% cpu tops, i don't understand... [10:10:33] mm strange. having qunit issues on master [10:25:21] jdlrobson: intermittent test failures? [10:25:38] joakino: is vboxheadless still at 100%? [10:26:05] phuedx: yeh [10:26:17] may I ask why we're writing a new set of special mobile pages, it's frustrating to see such thing being done where the usual page could've been altered by restyling it :-) [10:26:24] anyway i'm done for morning now. I'll be back around 5.30pm UTC [10:26:48] phuedx: i've vagrant reload'ed after 20 minutes, fine now, opened a bug MediaWiki-Vagrant: Maintained 100% cpu usage - https://phabricator.wikimedia.org/T97988#1256421 (Jhernandez) NEW [10:26:51] bb jdlrobson [10:27:57] yowza [10:28:10] there is a Special:UserProfile for example - it mildly inspires me since rearranging the important buttons to prominent places would be useful to all, but I don't think writing a new special page is a good way to approach this [10:28:20] over rewriting, again, the existing theme and existing software [10:29:00] there's plenty of duplicate work I see being done and I think the design is wrong in the root, maybe because someone didn't kick and scream enough to touch it in mediawiki core [10:29:39] hi, phuedx and joakino [10:30:05] in other words I should probably go write a mobile skin myself and get it deployed - will be back later [10:30:22] there's little point in asking you to follow thoughts of a random stranger anyway [10:30:46] hey svetlana [10:30:52] svetlana: the tradeoffs are big in mobile, and some times needs are so different that it justified when it happened writing new special pages. everybody acts on good faith and trying to do their best [10:31:28] svetlana: it is a very interesting conversation and i'm certain the mobile folks are always looking for improvements [10:31:48] what do you mean by big tradeoffs? [10:32:27] the needs are about the same; the software needed a revamp of the interface to something less ancient for years and I'm sure it can be done without splitting the software into two frontends [10:32:34] svetlana: feel free to open a task on https://phabricator.wikimedia.org/ with the project Mobile-Web , we can spark up some conversation there, ping me (jhernandez) and i'll cc/ other folks [10:32:35] svetlana: re special:userprofile, there's a change and associated phab task discussing your points about duplication of efforts: https://gerrit.wikimedia.org/r/#/c/194451/ [10:33:39] generally speaking though, there's always some duplication of efforts when experimenting with new ways of skinning pages, building features etc [10:33:49] but what we haven't seen yet is the consolidation step [10:34:07] (i think these points are also covered in that change and phab task) [10:35:00] svetlana: i agree, but we're not dealing only with technical constraints, there are social constraints in engineering and open source, and decisions are made with certain objectives in mind, and in retrospective they may seem non obvious why such paths were taken. it is usually useful to keep that in mind, and try to help a way forward to the correct place [10:35:26] joakino: the best I'm thinking now (sorry for being a bit dumb) is that one can write a good responsive skin and get it deployed - the mobile web project is too far now to go back to heading the css way [10:35:50] by consolidation do you mean that some of the stuff written for mobile would enter the core (and become available for both desktop and mobile)? [10:35:57] yes [10:36:37] it's just a 'yet another skin' - free to experiment; people'll disable it if they don't like it [10:36:38] I'll probably have a go at making the most out of responsive css and see how that helps things [10:36:51] svetlana: please [10:37:09] one thing left [10:37:27] svetlana: the embedded html in articles and infoboxes is a bit problematic, you'll see. for the rest of the ui it may be possible :D [10:37:28] the consolidation question above :-) I'm just trying to make sure I understood you properly [10:37:47] I have no problem kicking and screaming users to write their infoboxes right :-) [10:38:09] hah! [10:38:25] svetlana: there is work on the pipeline on cleaning mobilefrontend pieces, out to extensions where necessary, and into Minerva as a proper skin where necessary, not sure on dates [10:38:43] svetlana: is definitely under consideration [10:38:50] what does mobile web thing include now? minerva skin, what else? [10:39:13] svetlana: MobileFrontend is the extension, which includes too many things :P [10:39:18] ahh [10:39:19] okay [10:39:39] it just changes too many things at once, some to less intuitive stuff even if I set aside the learning curve [10:39:44] hard to see my own last edit [10:40:00] not intuitive to understand that the star icon is meant for the watchlist (or how to get there) [10:40:14] that would be a rather long list and at some point I even stopped remembering [10:41:33] svetlana: yep, ATM mobile is not the desktop experience, that's how it is designed, there's a dichotomy there on how many features fit in on such small screens [10:42:06] svetlana: the mobile experience is very guided too by the design team at wmf [10:42:08] the desktop version is horribly overloaded right now - I would be glad to see something more compact and intuitive, somewhere inbetween current mobile and current desktop [10:42:52] svetlana: agreed [10:43:05] not familiar with the design team. would give them a kick in the ribs for not using colored (at least 256 color) icons and light grey text which is hard for my aunts and the like to read, but I am moderately ok otherwise and it's accessible design [10:43:50] svetlana: I personally think we need to separate the reader and editor views while keeping them similar. readers love mobile's simplicity [10:44:07] svetlana: but because they are not invested on all the features, which editors need [10:44:24] I disagree with that thought :-) [10:44:57] svetlana: which is fine, iana designer so don't worry :) [10:45:00] there is separate 'edit' and 'read' mode already - should be very easy to toggle [10:48:02] joakino: i mean how much more can you separate them? [10:48:18] other than having a read mode and an edit mode, that is [10:50:39] (again, just trying to jump over the language barrier and the fact that we're not thinking in the same head..) [10:50:43] Playing audio and video should have some priority. [10:50:59] svetlana: I mean, there are parts of the UI for reading, that make a lot of sense for editors or involved users, but that confuse occasional readers (like the list of page issues), so I think that we can style or shape those features depending on who's looking to improve the experience for everybody [10:51:13] I thought some people worked on that, but no progress it seems. [10:51:28] sure svetlana, it is good talking around :D [10:51:56] joakino: oh! that's not very honest i think. hidden categories are meant for administrative purposes but the template purpose was to be visible to readers and i would respect that wish of the template authors. [10:52:18] sjoerddebruin: i'm not sure what's up with that. On mobile audio and video playing is pretty much at mercy of the handset/OS developers [10:52:35] if someone wants to hide the template from readers, it has to be made by editing its wiki markup to make it smaller, {{hat}}ed or somelike. [10:53:17] so i wouldn't mess with the wiki contents. not my field. it's their pile :) --> points to the wiki people/volunteers [10:54:09] svetlana: I agree, there's two faces to shaping up content. one is the intent of the creators and the other ones is it's priority and adequacy on different screens and devices [10:54:28] yes, i'd poke the wiki volunteers about the latter :) [10:54:49] svetlana: on the content side, it'd be great to provide more tools for volunteers to tag content as appropiate or not for different devices [10:54:51] i'm sure with some my effort being put into proof of concept, and after a mobile skin is around, they'd be glad to cooperate [10:55:06] yes, 'this looks ugly' button could be nice [10:56:30] haha [10:56:37] +1 [10:56:44] svetlana: where are you from? [10:56:49] I'm russian [10:57:03] svetlana: are you going to the hackathon? [10:57:38] I'm in sydney atm and I'm not free to travel wherever i like for at least 2 more years. after that, maybe. [10:59:20] pity [10:59:29] svetlana: what time is it down there [10:59:47] late evening. I'm bookmarking a few things and heading to sleep in a little bit [10:59:51] 9pm [11:01:33] great :D, it's past noon in spain, 1pm [11:03:22] you all enjoy your day; won't see me in chan for a while but I'll connect under this nickname (so you can pm) and I'll come back after I did some more thorough css stuff :) [11:04:31] (by the way it's full moon here, I'm thinking you'll see it over there too next night if memory serves) [11:05:36] svetlana: see you soon, thanks for taking the time to get in touch and share your thoughts :) [11:05:45] svetlana: yeah, it's been a beautiful moon the last couple of nights [11:05:52] svetlana: see you around! [11:06:04] \o [11:31:01] that's right [11:31:02] afj [11:44:47] phuedx|AFK: away from Joakino? [11:54:00] love this song https://www.youtube.com/watch?v=1hQ-y5dSarU [12:10:39] hallo [12:11:00] On Wikipedia Zero, is editing free as well? Or only reading? [12:11:31] joakino: ^ do you happen to know? [12:13:59] aharoni: I think it is free too, it makes ip ranges free, which should include the normal servers, not only the caches [12:14:10] aharoni: but I'm not sure [12:14:29] joakino: hmmm - https://twitter.com/thornet/status/594837690778034176 [12:15:21] I'd say that editing definitely should be free. [12:15:44] oh that's sad [12:16:28] aharoni: what a pity [12:16:35] i thought it was free [12:24:02] aharoni: https://wikimediafoundation.org/wiki/Wikipedia_Zero/Development#Zero-rating_traffic it works with ip addresses so i think editing should be free of charge. it may be that some carriers are not allowing certain ips or urls, or charging for upstream data but not for downstream, so editing becomes expensive. i'm not sure, but it seems like something [12:24:02] worth digging up [12:28:06] ^ that [12:28:31] i thought it was just "if a request comes in to this domain from this ip then it's zero rated" [12:28:46] * phuedx|AFK wishes jhobbs was here [14:56:40] jdlrobson: a small doubt regarding $wgPBImageUrl [14:56:45] hey codezee sure [14:57:31] when I'll chage it to use a url like 'File:South_America_Wikivoyage_banner.jpg', ideally I guess first I'll have to make an api request to get the url of actual image? [15:03:47] codezee: i think using a url is fine for the time being but in future you'll have to make the config variable a file page to support different image sizes [15:03:58] you can access the thumbnail url with PHP so don't worry about API requests :) [15:04:40] we can worry about that when we get that far. All i'm suggesting in mean time is you rename the config variable (then in future you can just introduce a new config variable and deprecate it without breaking backwards compatibility if someone has already customised the variable) [15:05:21] jdlrobson: alright, I get it :) [15:06:07] sweet. i'll be back in about an hour if you need to talk some more [15:10:17] mholloway: how are you? Do you want to jump into the batcave for a bit for some translation (L10N) stuff? [15:11:11] dbrant: welcome back! [15:11:50] bearND: thanks! i'm almost fully readjusted :) [15:12:50] great [15:14:21] bgerstle: coreyfloyd: btw, check gerrit merges. L10nbot added + merged new translations today [15:14:36] k, thanks bearND [15:14:44] i just ran our translation test and there were some issues [15:15:07] string format in a new language, but hopefully should be ok on iOS [15:19:23] bearND: sure! [15:19:46] mholloway: cool. see you [15:25:09] mholloway: https://translatewiki.net/w/i.php?title=Special:Translate&group=out-wikimedia-mobile-wikipedia-android-strings&language=or&filter=&action=translate&optional=1 [15:29:07] halfak: if you're there: new nordic giants landed on spotify [15:29:09] <3 <3 <3 [15:29:55] o/ phuedx [15:30:03] * halfak goes to listen [15:30:21] seeing 'em tonight [15:30:24] i am /so/ excited [15:30:26] * halfak clicks play. [15:56:47] coreyfloyd: heading to office in a few. Pre-standup hangout in a bit? [15:59:22] FlorianSW: TOO MANY PINGS [15:59:31] phuedx: sorry :( [15:59:42] phuedx: one more :/ [16:00:06] FlorianSW: cancel it !!! [16:00:11] i think i've spotted a bug [16:00:52] ta [16:00:55] and more pings, ARGHHH!!!!! [16:01:48] FlorianSW: ok, no, i was wrong [16:01:50] it's fine [16:01:51] :) [16:01:51] mhurd: got a meeting with vibha now. I already merged your patch though (if thats what you want to discus?). I’ll ping you when me and vibha are done, [16:01:55] *wipes sweat of brow* [16:02:11] phuedx: and i thought i missed something, you'll get a new ping now :P [16:02:45] coreyfloyd: oh cool. ya can chat after [16:04:07] bgerstle: hey hangout later to chat about some of your feedback on the lead image patch? [16:04:50] coreyfloyd: answered your support request you sent to mobile-ios-wikipedia@wikimedia.org ;) [16:05:03] FlorianSW: thanks [16:07:52] mhurd sure [16:11:40] tgr, why "mixin"? such a weird word [16:28:24] halfak: what did you think of the album? [16:28:45] as well as seeing nordic giants, i'm also going out for big food with my family [16:28:47] phuedx, got distracted :( will need to restart. [16:28:48] tonight will be a good night [16:28:58] :) "big food" [16:29:03] :D [16:29:38] Big food: http://imgur.com/bMDUdzV [16:45:04] joakino: ping [16:45:17] jdlrobson: pong [16:45:23] standup! [16:45:36] (not literally) [16:57:48] coreyfloyd: hey there's a typo in your amendment to the lead image patch - normalized spelled creatively :) [16:58:09] coreyfloyd: want me to patch or do you want to? [17:01:14] yurik: just followed the CR suggestion [17:01:26] mixin is the same thing as traits in PHP [17:03:51] I hope it's a temporary thing anyway, in the long term I would rather see the business logic in separate service classes intead of the API [17:05:24] tgr: so do you think we're in a good place to do reporting/following backend? [17:06:15] yeah, those seem fairly straightforward [17:07:59] tgr: awesome. Can you close out those bugs with a proposed implementation? [17:14:18] bgerstle: coreyfloyd: https://gerrit.wikimedia.org/r/#/c/208673/ [17:14:23] typo fix ^ [17:15:34] jdlrobson: the new patch should be good now [17:17:11] dbrant: standing [17:17:50] codezee: looking [17:20:37] kaldari: if MFIsBrowseEnabled is false, what do you think I should output when the user visits Special:Topictag. Any suggestions? [17:25:00] jdlrobson: you merged a bit too early... :P [17:26:15] benestar: I'd rather we gave codezee fast feedback. Since it's not deployed anywhere, I think it's okay to merge quickly and raise bugs for him to fix up in later patches [17:26:17] i [17:26:28] sure [17:26:45] i've already told him about $wgPBImageUrl but he can do that in a follow up in fact - https://phabricator.wikimedia.org/T98031 :) [17:26:45] he can still read my comments :) [17:26:48] yup [17:26:52] benestar: jdlrobson I've taken note of the issues, I'll fix them up in a follow-up [17:26:57] great :) [17:26:59] np :) [17:27:03] codezee [17:27:11] yes? [17:27:15] but equally benestar if you want to merge stuff go for it - i'm more than happy to work in this way :) [17:27:32] I hope I'm not too critical but I want this extension to be really good ;) [17:27:37] benestar: me too :) [17:27:50] jdlrobson: I need merge rights then... [17:28:06] benestar: oh happy to make that happen. Remind me ho i do that? [17:28:13] gnah, no idea [17:28:16] I'm not a gerrit admin :P [17:28:40] jdlrobson: somewhere in the project settings I assume [17:28:48] There must be a list of users with those rights [17:29:12] codezee: is it ok for you when I suggest some changes or patches as well? :) [17:29:27] * benestar thinks working together is always more fun [17:29:37] benestar: I'd be more than happy to get more feedback :) thats why I'm adding you as well to new tasks [17:30:16] nice ;) [17:30:24] this might be useful http://www.mediawiki.org/wiki/Gerrit/Project_ownership [17:30:35] codezee: especially for Wikidata questions I can help you as the interface is not trivial [17:30:43] etonkovidova: i see you did a lot of the test cases for 4.1.3.96, thanks! [17:30:48] I'm a Wikidata dev mainly you have to know ;) [17:31:04] etonkovidova: do you think you could copy the workflow we've had for TSG where we copy the cases into a new sheet for each version + device pair? [17:31:11] benestar: thanks, thats much appreciated :) [17:31:14] would be great to know which app version + OS version + device have been tested [17:32:21] bgerstle: You're right. will take a look [17:32:56] thanks. ping me if anything's unclear [17:32:59] benestar: feel free to raise bugs/feature requests for codezee on https://phabricator.wikimedia.org/tag/wikidata-page-banner/board/ i'll help codezee triage the ones he needs to finish to complete GSoc [17:35:10] jdlrobson: ok, will do. also did you find the gerrit settings? [17:35:16] benestar: yup doing it now [17:35:23] :D [17:35:23] benestar: which respositories do you currently have +2 on? [17:35:35] only Wikibase Repository afaik [17:35:38] dbrant bearND|food: FYI https://phabricator.wikimedia.org/T98036#1257770 [17:35:46] all other components are on Github still [17:36:28] is your username on phabricator bene ? [17:37:54] jdlrobson: any pointers on how can I generate a url with subpage in JS like we do in php? Like SpecialPage::getTitleFor( 'Gather' )->getSubpage( 'id' )->getSubpage( $this->getId() ) [17:37:58] jdlrobson: yes [17:38:09] email is benestar.wikimedia@gmail.com [17:38:12] joakino: string concatenation. hah and mw.util.getUrl [17:39:08] that'll do [17:58:29] jdlrobson: fleshed out the two spikes a bit more - is that what you had in mind? [18:00:16] thanks tgr [18:00:22] just reading through them now [18:01:20] tgr: instead of ever_followed could it be follow_count ? [18:01:23] it seems more generic [18:02:11] + we will need it for follow count in the lists api [18:02:29] and no special pages needed [18:03:32] etonkovidova: hey, sorry for the confusion [18:03:43] but could you create a new "sheet" in the existing test cases google doc? [18:04:12] etonkovidova: actually, do you think you even need to be doing regressions for 4.1.3.96 given that TSG will go through theirs? [18:04:16] bgrestle: shared with you a specific file for regression test cases for 4.3.1(96) [18:04:33] now that i think about it, it might be more valuable for you to spend that time doing exploratory testing instead [18:05:08] bgrestle: yes, I was thinking about TSG testing and if I need to do my regression testing... [18:05:12] etonkovidova: i saw. if you want to create a file for each version, can you create a folder where they're all stored? [18:05:25] otherwise it will be difficult to keep track of them all [18:05:46] etonkovidova: right, if you agree then, maybe you can just go over the TSG test cases to make sure they're up to date? [18:05:57] i don't know if we've updated them w/ cases for page issues & disambiguations [18:05:58] bgrestle: will create a folder :) [18:06:01] etonkovidova: thanks [18:06:13] * bgerstle marvels at the silence in the room [18:07:28] gotta go to the supermarket [18:07:29] bb [18:07:37] bgrestle: I looked at TSG tests and I added to my regression their Abuse filter testing. My regression tests take a different, more exploratory/post-bug fixes approach [18:07:42] bgrestle: :) [18:08:02] brb dinner [18:09:58] etonkovidova: thanks for updating the TSG cases. do whatever you think is a good balance of regression & exploratory [18:10:14] bgerstle: coreyfloyd I emailed updated release notes [18:10:22] etonkovidova: as long as we have a record of yours & TSG's testing we should have a good idea of the manual verification we've done leading up to release [18:10:59] mhurd do you think all of those are things users will recognize? [18:11:01] e.g. the {main} stuff [18:11:16] IMO a lot of that can be summarized as "bug fixes and performance improvements" [18:11:23] not all, but some [18:11:30] bgerstle: coreyfloyd good point. Let me resend [18:12:02] e.g. mhurd that trash can one might be good to leave on its own, i didn't know it was missing and people might be looking for that fix [18:14:02] mhurd: thanks. I'll look over and send to comms. I can also sanitize as well. [18:16:55] coreyfloyd: ah cool thanks [18:20:03] coreyfloyd: "Form Of Release Note Sanitizer" [18:22:13] dbrant mholloway niedzielski - i just invited you to a discussion around continuous integration, releasing, and source code review stuff with bgerstle: coreyfloyd mhurd . was gonna just meet on the ios side, but bgerstle was curious if androids would be interested. hence the invitation! [18:22:33] i added bearND, but he's not on irc right now, so no message to him [18:23:01] dr0ptp4kt: thanks! yeah, i'd love to see our ci grow and the ios experience would be valuable [18:23:24] dr0ptp4kt: thanks, i am interested! [18:23:36] dr0ptp4kt: sure, I'll drop in [18:28:46] bgerstle: coreyfloyd ok if i merge https://gerrit.wikimedia.org/r/#/c/208464/ ? [18:33:04] mhurd LGTM [18:34:24] bgerstle: merged [18:42:14] kaldari: you there? [18:42:28] i need help looking at server logs for https://phabricator.wikimedia.org/T98050 [18:59:23] jdlrobson: follow_count can go back to 0, ever_followed can't [18:59:58] user 1 follows the collection -> user 1 unfollows -> user2 follows - do you want 1 or 2 notifications? [19:00:35] I imagine there should not be any for user2 [19:01:14] tgr: mmm good point. errgg.. but the field isn't generic enough and useful enough to have its own field [19:01:35] in theory though the Echo notification would still exist [19:01:48] so you could check whether the notification exists as well? [19:22:34] vibha dbrant: Hi (shy tech writer here). Does Link preview share any code with the Popups (Hovercards) extension? Removing stuff in parentheses and dates, determining sentence length seems stuff it should do as well. [19:23:52] spagewmf: it "adapts" code from hovercards, since hovercards is written in Javascript, while the Android app is Java. [19:24:51] dbrant: maybe textextracts API should provide the desired chunk of text to them both [19:24:51] spagewmf: It would be great if we could do controlled display (1/2 sentences) on hovercards as well. [19:25:52] mholloway: Are you showing full width images? You really should! [19:26:33] Picasso's blue period is a good article :) [19:26:47] vibha: wasn't planning on it -- maybe a good candidate for next showcase after it's a bit more finalized? [19:28:02] I would show it, next showcase isn't happening for a month. But upto you :) [19:28:02] vibha: i've been talking with kaity about what to do for configs other than a phone in portrait mode [19:28:10] ah ok [19:31:14] Adam: "Now we're going to talk about Moses." [19:31:18] Baha: "That's me!" [19:31:25] You're Moses? [19:39:16] I wish [19:41:23] jdlrobson: WOMAN HAS BABY [19:41:42] jdlrobson: http://www.thedrum.com/news/2013/07/23/royal-baby-private-eye-front-page-sums-mood-nation [19:47:42] phuedx|AFK: bmansurov there to talk about https://gerrit.wikimedia.org/r/#/c/207139/5/resources/mobile.mainMenu/menu.mustache ? [19:47:58] yep [19:48:07] basically class is generated by mediawiki core but i think it's a horrible attribute name. So could standardise on using the name class [19:48:14] (easy [19:48:25] or i could standardise on className which would require some horrible unset/set hackery [19:48:38] thoughts? [19:48:41] jdlrobson: i was talking about the event name [19:48:53] data-event-name? [19:48:56] mm? [19:48:57] you should rename 'name' to 'data-event-name' as you do below [19:49:26] oh is that what you were talking bout phuedx|AFK ? [19:49:38] lol +1 to weird code review comments [19:49:55] i thought it was clear [19:50:03] the only inconsistent one is 'name' [19:50:13] well no.. class and className are also inconsistent [19:50:18] lol [19:50:20] but ... no .. that just event-name looks like a cock up in the template writing [19:50:24] bb guys, see you tomorrow [19:50:29] see you joakino [19:50:32] jdlrobson: yeah, then both ;) [19:50:39]