[02:35:39] <wctaiwan>	 how does the Wikipedia Android app work? Does it fetch the text content from the API? Or does it just load a webpage from lang.m.wikipedia.org and formats it?
[02:37:26] <dbrant|bbl>	 wctaiwan: it fetches from the API (mobileview)
[02:38:54] <wctaiwan>	 dbrant|bbl: could you please take a look at https://phabricator.wikimedia.org/T62743#1259517 ? I tested and using Accept-Language: zh-Hant does work, but if it's the API maybe it should just do &uselang=zh-hant?
[02:39:15] <wctaiwan>	 (using the header would work if we're just pulling the MobileFrontend page)
[08:41:04] <joakino>	 good morning !
[08:54:19] <joakino>	 jdlrobson: yt?
[08:56:12] <jdlrobson>	 joakino: sure
[08:56:14] <jdlrobson>	 just waiting for sam
[08:56:23] <jdlrobson>	 then gotta rush off to the us embassy
[08:56:24] <jdlrobson>	 what's up?
[08:56:34] <joakino>	 jdlrobson: looking at the reviews emails
[08:56:46] <jdlrobson>	 yeh how many do we need?
[08:56:49] <jdlrobson>	 want to be one of mine?
[08:57:00] <joakino>	 jdlrobson: ATM I have to fill the nominations form only?
[08:57:06] <joakino>	 sure
[08:57:07] <jdlrobson>	 i think so. I haven't looked yet
[08:57:17] <joakino>	 jdlrobson: i read on wiki that 3 or 4 is fine
[08:57:19] <jdlrobson>	 ask me later tonight. i'm probably gonna ask sam about it ;-)
[08:57:29] <joakino>	 https://office.wikimedia.org/wiki/WMF_2014_-_2015_Annual_Review_and_Retrospective
[08:57:31] <joakino>	 k
[08:57:46] <joakino>	 i'll ask around today
[08:57:54] <joakino>	 there seems to be strict deadlines this year
[08:58:07] <joakino>	 jdlrobson: can you review me?
[08:58:15] <jdlrobson>	 sure
[08:58:30] <joakino>	 gr8
[08:58:34] <joakino>	 m8
[09:27:09] <phuedx>	 hey joakino
[09:27:18] <phuedx>	 am now sitting where jdlrobson was sitting
[09:27:21] <phuedx>	 his seat is nice and warm
[09:28:20] <joakino>	 hi phuedx 
[09:28:22] <joakino>	 wat lol
[09:28:31] <joakino>	 oh you guys met
[09:28:31] <phuedx>	 he's gone to the us embassy
[09:28:35] <phuedx>	 i'm looking after his stuff
[09:28:41] <phuedx>	 and drinking /a lot/ of coffee
[09:28:42] <joakino>	 hah cool
[09:28:49] <phuedx>	 and reading the review stuff :/
[09:32:45] <joakino>	 i love how intellij sucks the fuck out of those cores to analyze the project
[09:38:24] <phuedx>	 joakino: rather your cores than your head, eh?
[09:38:33] <phuedx>	 you ever parsed a dynamic language?
[09:38:36] <phuedx>	 hey, hey!?
[09:38:38] <phuedx>	 HEY!?
[09:38:51] <phuedx>	 also, you know how big the project actually is?!
[09:39:01] <phuedx>	 you should be grateful that you've still got ram
[09:39:29] <joakino>	 haha
[09:39:37] <joakino>	 we have a loot of code
[09:39:56] <joakino>	 the other day i run some cloc commands, didn't capture output though
[09:40:54] <joakino>	 phuedx: this one cloc --exclude-dir=vendor,node_modules .
[09:41:14] <phuedx>	 what's the output?
[09:41:18] <joakino>	 i think that excludes all the libs (not sure if there are more folders that shouldn't be counted)
[09:41:35] <joakino>	 phuedx: super scary, i'll run it again 
[09:51:13] <phuedx>	 wondered why i was getting 2 notifications for everything
[09:51:19] <phuedx>	 i have two ircclouds running :/
[10:14:24] <joakino>	 phuedx: https://gist.github.com/joakin/b682d82c7262cf99abbc
[10:16:18] <phuedx>	 joakino: pascal?!
[10:17:25] <joakino>	 phuedx: yeah xD
[10:17:30] <joakino>	 not sure why
[11:49:26] <matanya>	 phuedx: joakino can one of you please advise if STACK_TRACE=java.lang.NullPointerException: Attempt to invoke virtual
[11:49:26] <matanya>	 method 'void org.wikipedia.analytics.ToCInteractionFunnel.logOpen()' on a
[11:49:26] <matanya>	 null object reference
[11:49:26] <matanya>	 at org.wikipedia.page.ToCHandler$2.onDrawerOpened(ToCHandler.java:101) is  known?
[11:50:36] <joakino>	 matanya: java is not my turf, sorry :(
[11:50:52] <phuedx>	 woah
[11:51:10] <phuedx>	 matanya: likewise, the android app (presumably?) isn't my turf
[11:51:41] <matanya>	 yes, android app. what is your toy guys? this why i'll know what to bug you about :)
[11:51:45] <joakino>	 matanya: known or not open a phab task plz! seems like an important crash
[11:52:36] <phuedx>	 matanya: is this the same thing? https://phabricator.wikimedia.org/T96358
[11:52:43] <matanya>	 yes, that is the reason for the question, to know if it was reported. 
[11:53:10] <phuedx>	 nope, you created the task
[11:53:14] <phuedx>	 it can't be the same thing
[11:53:18] * phuedx learns to read frst
[11:53:19] <matanya>	 phuedx: no, thanks. (that one was reported by me :) )
[11:53:20] <phuedx>	 *first
[11:53:44] <phuedx>	 matanya: in that case, i can't find anything in phab related to the exception
[11:53:54] <phuedx>	 i suggest you create a task with high priority
[11:55:37] <matanya>	 thanks much
[14:08:29] <phuedx>	 gonna go for lunch
[15:44:38] <Floriansw>	 hello @all :)
[16:01:57] <Floriansw>	 bearND: can you take a look at https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8338016 ? can't reproduce that, did you hear anything similar? :)
[16:14:45] <bearND>	 Floriansw: Hi, I have not see anything similar. Looks like the status bar is a bit messed up and the navigation bar is transparent
[16:15:30] <Floriansw>	 bearND: ok, i will ask, if he/she uses stock firmware :D
[16:17:15] <bearND>	 Floriansw: And check for any lock screen apps, too
[16:17:42] <Floriansw>	 damn, clicked on send just 2 seconds ago :/ I keep this in mind and ask later :)
[16:17:45] <Floriansw>	 bearND: ^
[16:18:09] <bearND>	 Floriansw: no problem
[16:18:27] <joakino>	 hellow \o
[17:27:43] <joakino>	 so quiet today
[17:29:43] <Deskana>	 joakino: I can spam some gerrit changes if you like.
[17:30:31] <joakino>	 Deskana: no please :p haha
[17:30:38] <Deskana>	 ;-)
[17:31:23] <joakino>	 https://media2.giphy.com/media/sXv0vaA4331Ti/200.gif
[17:34:17] <bgerstle>	 dr0ptp4kt: bearND coreyfloyd mhurd et. al releasing meeting?
[17:34:28] <bmansurov>	 joakino: the side effect of turning off the bots ;)
[17:34:45] <mhurd>	 bgerstle: omw
[17:35:09] <bgerstle>	 sorry dudes, i thought it was 1:30
[17:35:16] <bgerstle>	 I'M SO SORRY WILL YOU EVER FORGIVE ME?!
[17:35:22] <mhurd>	 lol
[17:45:00] <bearND>	 bgerstle: I don't have a meeting for this in my calendar today
[17:45:13] <bgerstle>	 bearND: do you want to come?
[17:45:16] <bgerstle>	 i can invite you
[17:45:35] <bearND>	 not really. Not sure what's it about
[17:45:39] <bgerstle>	 bearND: tried to invite you, it might come from my personal email
[17:45:44] <bgerstle>	 we're talking about VCS & CI requirements for apps
[17:55:23] <jdlrobson>	 \o
[17:55:39] <bmansurov>	 o/
[18:01:12] <joakino>	 enjoying this album https://www.youtube.com/watch?v=_xO2Q0lqUuI 
[18:01:27] <jdlrobson>	 joakino: need a hot fix
[18:01:27] <phuedx>	 ping joakino
[18:01:34] <phuedx>	 stop enjoying the album and join the hangout
[18:02:41] <joakino>	 phuedx: i still have 2  minutes
[18:02:50] <joakino>	 jdlrobson: what do you need
[18:03:01] <jdlrobson>	 joakino https://gerrit.wikimedia.org/r/209015
[18:03:06] <phuedx>	 an emergency merge by the looks of it
[18:04:09] <bgerstle>	 bearND: dbrant what sprint is android on?
[18:04:19] <dbrant>	 bgerstle: 56
[18:04:23] <bgerstle>	 i want to add a phab ticket to your board for updating/reviewing the VCS/CI doc
[18:04:24] <bgerstle>	 thanks!
[18:05:04] <joakino>	 jdlrobson: so it wasn't intended lol
[18:26:28] <Deskana>	 bearND: I threw a meeting on your calendar at quite short notice, for an hour from now. Your calendar said you're free then. Does that work for you?
[18:26:36] <Deskana>	 bearND: You can see your calendar for the agenda.
[18:27:04] <bearND>	 Deskana: I'm in a meeting right now until the end of this hour
[18:28:12] <bearND>	 Deskana: I see it now. Looks like yours is starting another hour later
[18:30:01] <Deskana>	 bearND: Yeah, that's what I meant. Sorry for the confusion.
[18:55:38] <mholloway>	 bearND: question for you about the event logging task when you're free
[19:16:45] <etonkovidova>	 bgerstle: https://phabricator.wikimedia.org/T97810 Fix version in About page - shouldn't we display version numbers as they are displayed in TestFlight - 4.1.3 (105) ?
[19:17:07] <mhurd>	 phuedx: joakino: hey guys have you had a chance to see the output of the experimental apps service bearND has been working on? if not and you're interested, maybe bearND could hangout and show you what it's doing so far?
[19:17:13] <bgerstle>	 etonkovidova: yes, they're in the format 4.1.3.(Z)
[19:17:29] <phuedx>	 mhurd: absolument i'm interested
[19:17:48] <bgerstle>	 mhurd IIRC joakino tried to use it but had some issues w/ how JSON was being returned
[19:17:54] <phuedx>	 but not at 8pm ;) -- bearND: you're in europe right?
[19:17:59] <etonkovidova>	 bgerstle: hmm... I am looking at  Wikipedia 4.1.3 105
[19:18:13] <bgerstle>	 etonkovidova: right, so it should be 4.1.3.105
[19:18:18] <bgerstle>	 sorry if i didn't make that clear in the card
[19:18:36] <joakino>	 mhurd: i've tried it on a side project 
[19:18:45] <bearND>	 phuedx: yes, but i'm working more US hours
[19:18:46] <joakino>	 mhurd: to see how different it was from the mobileview queries
[19:19:06] <joakino>	 mhurd: my issue with it was that it returns html, with the data embedded on JS variables inside the html
[19:19:20] <etonkovidova>	 bgerstle: was it a question? 
[19:19:23] <joakino>	 mhurd: the real deal would be return me some pretty-ly structured JSON
[19:19:31] <bgerstle>	 etonkovidova: do you see 4.1.3.105 or something else?
[19:19:48] <bearND>	 phuedx: joakino: https://appservice.wmflabs.org/en.m.wikipedia.org/v1/mobile/app/page/html/Dilbert is an example, it's deployed on labs
[19:19:54] <bgerstle>	 joakino: don't you mean gzipped JSON, or pretty-printed JSON if a ?pretty=true flag is set? ;-)
[19:20:01] <etonkovidova>	 bgerstle: yes,  I see 4.1.3.105 . But it's inconsistent with TestFlight and the icon display 
[19:20:16] <bgerstle>	 etonkovidova: ah i see
[19:20:20] <bgerstle>	 the icon just says 105?
[19:20:25] <bgerstle>	 and TF says 4.1.3 (105) ?
[19:20:39] <phuedx>	 bearND: thanks -- i'll also be reading over yer codez tomo
[19:20:39] <joakino>	 bgerstle: waterver :p
[19:20:52] <joakino>	 bearND: I tried it but it returns the extra data inside the html :(
[19:20:52] <etonkovidova>	 bgerstle: I am nit picking - I know...
[19:20:56] <bgerstle>	 joakino: what do you mean WHATEVER? this is the most important feature of any api!!
[19:21:12] <bgerstle>	 etonkovidova: not at all, attention to detail is what separates the wheat from the chaff :-P
[19:21:14] <bearND>	 phuedx: joakino: ignore the alert for now. And look at the HTML source. I still need to hook this app completely from the apps side, but you'll see 2 JavaScript blocks with meta data
[19:21:18] <etonkovidova>	 bgerstle: the icon says Alpha (105)
[19:21:28] <joakino>	 bearND: i'd loved a { content: 'htmlcrapppp', images: [ bla, bla ] ...} instead of having those inside the html on a script tag
[19:21:58] <etonkovidova>	 bgerstle: if you say it's ok to have it like that for now - it's totally ok. We can get the input form designers 
[19:22:00] <bearND>	 https://appservice.wmflabs.org/en.m.wikipedia.org/v1/mobile/app/page/html/Cat might be a better example since it has some gallery info at the end of the payload
[19:23:15] <bearND>	 joakino: The idea is for the apps to use just webView.loadUrl() to stream the content in, and for the JS bridge to help us get the metadata out as JSON
[19:23:51] <bearND>	 joakino: Not having to encode HTML inside JSON also helped reduce the payload a bit more
[19:24:40] <Floriansw>	 joakino: does this change https://gerrit.wikimedia.org/r/#/c/209036/ covers your task https://phabricator.wikimedia.org/T95593 (so: could i add it to the change?)?
[19:26:10] <coreyfloyd>	 mhurd: you around?
[19:26:41] <joakino>	 Floriansw: i thought we already supported abuse filter, cc/jdlrobson 
[19:26:51] <jdlrobson>	 joakino: w do..
[19:26:52] <joakino>	 Floriansw: add the bug there, and ping people on the bug :D
[19:27:23] <jdlrobson>	 i'm confused?
[19:27:54] <Floriansw>	 jdlrobson: gather supports abusefilter? Against which fields? How is it implemented? It looks like it passes all user input directly into the database :/
[19:27:57] <jdlrobson>	 Floriansw: we already support abuse filter in gather - that task was about having some sensible default rules
[19:28:23] <jdlrobson>	 AbuseFilter::filterAction( $vars, $title ); in ApiEditList
[19:28:38] <jdlrobson>	 L226
[19:29:29] <Floriansw>	 jdlrobson: :O :((( why i haven't found that! :( Sorry for confusion!
[19:30:14] <mhurd>	 coreyfloyd: ya
[19:30:33] <mhurd>	 coreyfloyd: batcave?
[19:30:41] <joakino>	 Floriansw: sorry florian
[19:30:45] <joakino>	 gotta go, have a nice day
[19:30:56] <Floriansw>	 joakino: you to! :)
[19:32:26] <coreyfloyd>	 mhurd: sure
[19:39:48] <phuedx>	 out for the night
[19:45:32] <jdlrobson>	 Floriansw: it's been one of those days
[19:45:45] <jdlrobson>	 i spent four hours in the us embassy today just to give them a piece of paper
[19:46:56] <Floriansw>	 jdlrobson: lol, for Lyon?
[19:47:05] <jdlrobson>	 Floriansw: nah for going back from Lyon :)
[19:47:23] <Floriansw>	 jdlrobson: ah, you don't want to stay in europe? :D
[19:50:21] <dbrant>	 niedzielski: do you have +2 in gerrit yet?
[19:50:33] <mhurd>	 dbrant: he's afk
[19:50:52] <dbrant>	 rgr
[19:50:58] <mhurd>	 coreyfloyd: ya vibha said ok to not collapse on main page for now.
[19:51:32] <mhurd>	 coreyfloyd: looking at the transforms - lets chat in a few after i have a minute to think about it...
[19:53:37] <bearND>	 mholloway: I'm ready now
[19:54:13] <mholloway>	 bearND: great! batcave?
[19:54:19] <bearND>	 mholloway: yep
[19:54:56] <vibha>	 Yes. Agree with you guys. I didn't realize that the uncollapsing has so many wonky behaviors
[19:57:49] <mhurd>	 coreyfloyd: quick chat?
[19:58:16] <coreyfloyd>	 ya
[19:58:29] <coreyfloyd>	 mhurd: ^
[19:58:50] <mhurd>	 coreyfloyd: bearnd is already in bat cave 
[20:00:01] <niedzielski>	 dbrant: i do!
[20:39:02] <dbrant>	 niedzielski: feel free to +2 this one, then: https://gerrit.wikimedia.org/r/208668
[20:40:17] <niedzielski>	 dbrant: do we have a limit on +2s? i thought i heard someone mention something about one +2 per sprint?
[20:41:14] <dbrant>	 niedzielski: ...not that i'm aware of!
[20:41:29] <niedzielski>	 dbrant: ok, i guess i will go to +2 town then
[20:43:29] <dbrant>	 thx
[20:49:09] <niedzielski>	 dbrant: np!
[20:49:53] <Deskana>	 niedzielski: Every time you +2 a patch you have to -2 another.
[20:50:00] <Deskana>	 niedzielski: The goal is to remain at a net 0 points.
[20:50:27] * niedzielski Writes some real bad code hastily.
[20:50:30] <Deskana>	 niedzielski: Only then can you achieve true balance.
[20:50:57] <Deskana>	 niedzielski: That's the reason that everyone likes to add -1s on patches. If they do it twice on the same patch, when they merge it they don't have to do a -2.
[20:51:32] <niedzielski>	 Deskana: ok that makes sense. I see the truth in it.
[21:24:09] <rmoen>	 kaldari: Any objections to updating MFE to master on wmf3 ? 
[21:25:09] <rmoen>	 Reason being there are at least 3 cherry-picks needed to update gather to master.
[21:25:59] <rmoen>	 phuedx|AFK: ^ 
[21:44:19] <kaldari>	 rmoen: no objection from me
[21:44:36] <rmoen>	 kaldari: ok I was just about to abort.
[21:45:12] <rmoen>	 kaldari: I've tested it locally and cannot find any issues with 1.26wmf3 running both MFE and Gather master's
[21:45:43] <kaldari>	 won't make much difference since wmf3 will be retired tomorrow
[21:46:39] <kaldari>	 but if the Gather folks want it updated, probably won't hurt
[21:48:20] <kaldari>	 rmoen: If you want to do a hangout, let me know. I'm a bit pressed for time today though.
[21:48:35] <rmoen>	 I'm going to try to finish in the window
[21:48:39] <rmoen>	 but might go a little over
[21:48:46] <rmoen>	 I got this
[23:32:33] <yuvipanda>	 mhurd: see https://github.com/wikimedia/mediawiki-extensions-UploadWizard/pull/3 for an example of a pull request bridged via Such A Bot
[23:32:41] <yuvipanda>	 you'll note that comments were moved around 2way
[23:33:15] <yuvipanda>	 mhurd: well, I didn't have github -> gerrit comments working yet :P
[23:33:18] <yuvipanda>	 mhurd: but that was trivial to add.
[23:33:31] <yuvipanda>	 mhurd: but you'll see that marktraceur reviewed using github, and brion reviewed using gerrit
[23:33:37] <yuvipanda>	 mhurd: and I personally could just use github
[23:42:21] <mhurd>	 vibha: hey would you have 5 minutes to sign off on a couple cards?
[23:42:29] <mhurd>	 vibha: no worry if not :)
[23:43:03] <mhurd>	 yuvipanda: whoa no way!
[23:43:51] <yuvipanda>	 mhurd: :)
[23:45:41] <vibha>	 mhurd:  yes
[23:45:51] <vibha>	 are they in sprint 56 column?
[23:51:26] <vibha>	 mhurd: Cleared https://phabricator.wikimedia.org/tag/mobile-app-sprint-56-ios/
[23:51:34] <vibha>	 Lmk is there is anything else
[23:52:08] <yuvipanda>	 niedzielski: hey! was me talking about the chinese problems enough or do you want me to put it on the ticket too?
[23:52:53] <niedzielski>	 yuvipanda: so far i have plenty to go on. just working on implementing it. thanks for your guidance! (+ bearND)
[23:53:01] <yuvipanda>	 niedzielski: sweet :)
[23:53:07] <yuvipanda>	 niedzielski: let me know if there's anything I can do to help :)
[23:53:14] <niedzielski>	 yuvipanda: you can count on it :)
[23:56:49] <mhurd>	 yuvipanda: invite sent
[23:57:01] <mhurd>	 vibha: you're the best!
[23:57:32] <vibha>	 mhurd:  Its ture :)
[23:57:36] <vibha>	 true :)
[23:57:41] <vibha>	 I am the best :)
[23:57:55] <mhurd>	 vibha: lol and humble ;)
[23:58:01] <vibha>	 Thank you for pinging me, i had no idea there were new eggs in there
[23:58:26] <vibha>	 i've been told that Indians don't know how to accept compliments
[23:58:34] <vibha>	 so i'm on the other extreme now :)
[23:58:41] <mhurd>	 vibha: hahah perfect
[23:58:52] <vibha>	 I'm claiming all compliments for 1 month just as a trial
[23:58:59] <mhurd>	 lol