[00:01:01] yuvipanda: sent another invite [08:10:40] morning! [08:23:02] jdlrobson: yo [08:23:11] what's happened with the deployment [09:31:43] hey [09:43:27] joakino: stuff got deployed [09:43:30] there are boogz :/ [09:48:26] phuedx: it seems like it was scap related [09:48:33] phuedx: do you know what that is [09:56:21] joakino: haha [09:56:47] scap is this thing which sync files and for some reason takes forever. every time max did one we used to put https://www.youtube.com/watch?v=y6oXW_YiV6g on loop [09:57:46] lol [09:57:51] jdlrobson: great song btw xd [09:57:56] brings memories back [09:59:42] joakino: it is /not/ a great song [09:59:53] but i also have good memories attached to that song [10:00:01] man it's so quiet in here [10:00:17] phuedx: Ski Ba Bop Ba Dop Bop [10:00:27] :) [10:01:30] jdlrobson phuedx are you attending the lyon meeting later? [10:01:41] there's a meeting later? [10:01:43] do you know what they are going to say? [10:01:45] linky link [10:01:46] ? [10:01:58] ohh no [10:02:00] a lyon meeting? [10:02:25] oh wait is that the one organised by doreen [10:02:34] if you've travelled in europe before it's not really necessary [10:02:55] they just tell you stuff like whether you can drink on the street, logistics about getting to hotel etc [10:03:19] jdlrobson: awesome, i happen to live in europe [10:03:35] jdlrobson: I'm going to need a quick french course [10:04:52] phuedx: i can't get a link from the google calendar, not sure why [10:05:22] phuedx: it's on the staff calendar and we got an email with the invitation [10:06:10] i'll take a look later [10:06:16] gonna take jdlrobson out for breakfast [10:07:43] enjoy :D [10:09:16] joakino: see ya in a bit [10:09:27] have a couple of high priority patches in code review if you have some time :) [10:09:39] joakino: i can teach you all the french i know in morocco in exchange for some spanish :) [10:09:50] 👍 [10:09:52] i'm hoping i can impress you and JK with ma francais [10:09:56] it's been a while [10:09:59] so gonna be super rusty [10:10:10] hah [10:10:26] better than nothing for sure [11:12:36] eh folks [11:12:36] My Samsung 10.1" 32gb tablet is only displaying Geo = {IPv6: true} when I go to wikipedia on it[edit source] [11:12:40] Greetings! My wife was looking something up on Wikipedia and when she followed a link from Google to the page, she encountered this: GEO = {"city" : "Fresno" . . . lots of stuff including our actual latitude and longitude and my tablet's IP! [11:13:23] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#My_Samsung_10.1.22_32gb_tablet_is_only_displaying_Geo_.3D_.7BIPv6:_true.7D_when_I_go_to_wikipedia_on_it [11:13:34] and two sections higher up seems to be another mobile problem [11:26:43] hi thedj [11:26:56] thedj: do you know if there are open bugs for it? i'll search in a minute [11:35:30] already fixed [11:47:37] MaxSem: lel [12:04:56] joakino: can you merge https://gerrit.wikimedia.org/r/208380 [12:05:07] bit worried that it's been causing qunit issues [12:05:12] also https://gerrit.wikimedia.org/r/207673 [12:07:13] jdlrobson: yep, 1 sec [12:14:21] jdlrobson: did you see the error somewhere? -> https://gerrit.wikimedia.org/r/#/c/208380/1/resources/Resources.php or is it old resourceloader black magic intuition xd [12:24:43] * jdlrobson looks [12:25:02] no errors i just know this shit can happen :) [12:25:41] joakino: go to desktop and load mw.loader.load( 'ext.gather.collections.list' ) [12:25:52] should probably load settings too [12:26:49] jdlrobson: mainmenu and browser also fail [12:27:18] fixing now [12:28:24] jdlrobson: manually specifying dependencies is bullshit [12:28:29] sorry [12:28:47] no worries, it is [12:29:00] anyway i'm gonna head home from Sam's now and put in a few hours later [12:29:17] oki! [12:58:16] out for lunch [14:15:04] train delays! [14:15:07] how i've missed you uk! [14:15:45] phabricator is down phuedx joakino but https://gerrit.wikimedia.org/r/209225 should help with the issue that i introduced which was disabling images for everyone who opted into beta through the panl [14:20:10] joakino: do you have some time for a hangout with me? I would like some help with some JS issues from the web page hosted by the nodejs service. [15:27:56] bearND: i think joakino is still afk [15:37:00] i need someone intimately familiar w/ article HTML [15:38:53] phuedx: jdlrobson ? ^ [15:39:43] jdlrobson: as if SF doesn't have train delays :-P [15:43:30] phuedx: would you be able to jump on a hangout with me to help me with some JS stuff? [15:53:55] kaity: quick question for you [15:55:27] kaity: nm, i'll just send an apk. see what you think of the image caption alignment. [15:55:57] kaity: it's probably about time i uploaded some updated screenshots to phab, also. [16:06:29] bgerstle: back, sorry, electrician turned off powers [16:06:46] that fiend [16:07:35] phuedx how comfortable are you w/ wiki page HTML and its many idiosyncrasies? [16:08:04] phuedx: joakino: ok, I think I've got the main issues solved. Still one potential big blocker left, though. What's left is security related (CSP header). [16:08:07] If anyone has some great insight regarding setting proper CSP headers please let me know. [16:08:22] bgerstle: i'm constantly surprised by the article html [16:08:36] hehe well that makes two of us [16:09:03] phuedx: able to hop on a hangout real quick? [16:09:03] hi phuedx bearND jdlrobson [16:09:51] oh HI joakino. no it's OK. you don't have to mention me. [16:10:04] lol [16:10:27] hi bgerstle, just mentioned them bc they mentioned me while afk, irccloud backlog FTW [16:10:34] ^ that [16:10:38] whatever, i get it [16:10:47] joakino: you take bearND [16:10:52] and i'll take bgerstle? [16:10:53] :D [16:11:07] bearND: quick, if we get another native engineer we can overwhelm them! [16:11:15] nah [16:11:16] RALLY THE NATIVE OFFENSIVE [16:11:20] you'll only whelm us [16:11:55] joakino: can i ping you via hangout? [16:12:02] closed source advocates, you'll go to hell http://media.giphy.com/media/XXVYCLbrhlr5m/giphy.gif [16:12:17] bearND: sure [16:12:45] joakino: ty [16:34:58] lol https://40.media.tumblr.com/7a69c1fb277d8d37bd9e84cd453fd28c/tumblr_mxhg13jx4n1sftq6do1_540.png [16:45:26] rmoen: joakino standup! [16:45:45] https://www.youtube.com/watch?v=Ip8h24Ggk0g [16:52:42] dbrant: can you take a look at T74554 "Inconsistent directionality in the Android App's nearby screen"? I am not sure if it's actually resolved... [16:53:09] dbrant: the issue seems bigger than just a bug [16:53:41] etonkovidova: yes, there's still some confusion about whether RTL captions should still be left-aligned... it needs a slightly broader conversation. [16:54:07] dbrandt: right [16:54:10] jdlrobson: do you have anything to report to scrum of scrums btw? [16:54:22] i might as well go and talk about the critical bug fixes we're going to deploy [16:55:36] yehhh [16:55:44] phuedx: would be good to tell ops that beta traffic might be spiking [16:56:29] jdlrobson: so what was the beta opt-in thing for? [16:57:54] phuedx: we needed moar traffic for gather*ing more data [16:58:23] joakino: so asking everyone to opt in is a good strategy :D [16:58:40] joakino: redirect 5% of all mobile traffic to gather \o/ [16:58:51] <- future product manager [16:58:53] phuedx: not everybody, around a 5% of unique tokenized visits haha [16:59:00] lol [16:59:35] phuedx: you've got a future in the non-profit-mega-site business [16:59:39] jdlrobson: re:standup. let me know what patches, I'll make the cherry picks and put them in the schedule. [17:00:39] jdlrobson: regarding https://gerrit.wikimedia.org/r/#/c/209235/2/resources/mobile.betaoptin/init.js how is that lowering the % with just a comment? xD [17:01:01] jdlrobson: did you mean to remove the '3'? [17:01:20] btw phuedx it seems like we're moving it to 3% now [17:05:14] phuedx: jdlrobson meetin'? [17:15:37] joakino: i've got standup and then scrum of scrums [17:15:51] phuedx: k sorry [17:15:57] so you should be [17:16:26] phuedx: yknow passport, chip cards, blah [17:17:12] what's a passport? [17:17:14] joakino: lol your [17:17:25] joakino: yeh comment reductions dont work do they [17:17:33] haha [17:19:02] joakino: i reposted [17:19:19] what exactly jdlrobson [17:19:26] https://gerrit.wikimedia.org/r/#/c/209235/3/resources/mobile.betaoptin/init.js [17:19:44] https://gerrit.wikimedia.org/r/#/c/209235/ rather [17:20:00] jdlrobson: what a mess [17:20:06] i +2d PS3 [17:20:08] boy 40K opt ins so far [17:20:14] 44K [17:20:20] omg [17:20:28] all without images [17:20:41] people be like - opted into experimental wikipedia beta, has no images [17:21:13] shitstorm incoming [17:22:03] haha [17:22:08] 'we are all idiots' [17:22:14] ^ actual lol [17:22:21] george looked at me funny [17:23:04] phuedx: one more patch we should fix too [17:43:10] phuedx: does https://phabricator.wikimedia.org/T98292 need to go on the list of things to lightning deploy? [17:43:50] jdlrobson: not sure what the fix is yet -- in scrum of scrums and then prioritisation meeting [17:48:38] gwicke: to reiterate, we're interested in talking to services, but we aren't blocked [17:49:00] i've subscribed you to the relevant phab tasks so you can see the conversations [17:49:05] (and i think we've got a follow-on meeting) [17:49:13] :) [17:51:59] phuedx: cool, thx! [17:52:29] phuedx: sorry if i gave the wrong impression [17:52:35] seemed like you were blocked from yesterday's meeting [17:53:13] gwicke: bearND as far as blocking our apps service deployment due to test coverage... would our service impact any other services? [17:53:16] bgerstle: yeah, i thought so to, but i think we should actually be upstreaming some work in mobileview to the pageimages api [17:53:20] or critical infrastructure [17:53:47] brb -- tea time! [17:53:55] bgerstle: it won't for now, and the end point will be marked as experimental initially [17:54:30] bearND: were we planning on using the endpoint in the "production" android app? i don't know of any plans to do so w/ iOS [17:54:43] bearND: if it's too late your time, we can sync tomorrow [17:54:45] so I see your POV that you don't need them *right now*, but imho it's easy enough to add two or three smoke tests [17:55:31] there are already examples in the service template [17:55:46] gwicke: normally, i would happily agree, but AFAICT the service is too experimental to justify tests. any tests we add will just add extra work to development/prototyping [17:56:04] besides, AFAIK we're more interested in learning how to deploy than the service itself [17:56:22] the service has some interesting ideas, but it's very experimental [17:56:40] we are talking about something as simple as https://github.com/wikimedia/service-template-node/blob/master/test/features/app/app.js [17:57:16] gwicke: if the tests you're interested in are so abstract, could they be refactored into shared behaviors? [17:57:22] that'll be enough to catch snafus before rolling things out [17:57:43] so we can more easily write "describe("apps service", function () { itBehavesLike("a good WMF service"); })" [17:57:49] so i worked out the toast issue phuedx [17:57:53] just don't know how to fix yet [17:57:55] jdlrobson: yeah!? [17:58:28] bgerstle: there is some work on that ongoing at https://phabricator.wikimedia.org/T94821, but it's not there yet [17:58:40] phuedx: css animations.. [17:58:56] gwicke: i'm talking about something more simple than that [17:59:02] bgerstle: in the meantime, it's really easy to add a couple of lines to perform an HTTP request to the main entry points [17:59:08] https://github.com/mochajs/mocha/wiki/Shared-Behaviours [17:59:15] gwicke: ^ [17:59:40] gwicke: ok, we'll go ahead and add them, since it doesn't seem to be coupled the part of the service that will change the most [17:59:47] (i.e. basic sanity checks that every service should have) [18:00:02] yeah, we normally start by exercising the API only [18:00:02] in which case, shared behaviors that are included w/ the service template would be great [18:00:22] which is really integration tests with very low effort per coverage [18:00:45] sure, but do you understand what i mean by shared behaviors? they're agnostic to the kind of test [18:01:01] i.e. you write the tests once (as you pasted earlier) [18:01:14] but package them as shared behaviors so that reusing them is a one-line thing [18:01:16] the basic info we need is request examples and response assertions [18:01:23] i see [18:01:41] the spec work I linked to reuses swagger specs for much of that info [18:02:01] but as I said, it's not fully implemented yet [18:02:49] gwicke: right. i'll talk to bearND about it. maybe we can upstream some of the more generic tests as shared behaviors [18:03:11] sure [18:03:11] for now, i need to get some lunch. ttyl o/ [18:03:25] ttyl! [18:06:32] bgerstle: gwicke: Still working on getting the end-to-end functionality going. Made some good progress on getting the JSON metadata that I embed inside the HTML payload. Still feels a bit hacky, though. [18:07:04] bgerstle: gwicke: Once I got that wrapped up I was planning to add some tests. [18:07:26] phuedx: kaldari bmansurov > https://gerrit.wikimedia.org/r/209284 [18:07:36] bearND: makes sense [18:08:29] finally gave up on BART and had to walk from Embaradero [18:12:29] Deskana|Away: phuedx jdlrobson check out today's xkcd.. ZING!! 😝 [18:14:11] * niedzielski takes note to allow extra time for BART ride to airport [18:14:22] grabbing dinner now. bgerstle haha [18:26:24] dbrant: is it fine to +1 a largish review just to get a second set of eyes on it? [18:26:42] niedzielski: yep, sure [18:28:52] dbrant: ok, cook. thanks [18:32:47] sigh, i need to get this checkstyle plugin working again [18:33:49] installing java 8 didn't seem to placate it [18:43:07] @phuedx sorry to interrupt mtg attention but search schema is crushing EL [18:43:19] we should talk as soon as mtg is over [18:47:31] kaldari, bmansurov, jdlrobson, joakino: could one of you review https://gerrit.wikimedia.org/r/209291 asap? [18:47:40] /cc JonKatz ^ [18:56:49] niedzielski: when are you leaving SF? [19:00:20] mhurd: bgerstle bb 1 hour [19:01:29] phuedx what is "issampled rate"? [19:04:00] JonKatz: actually, it's quite high [19:04:10] it's 50% :o (i wasn't aware of that) [19:04:33] pheudx, dgarry suggested 1% [19:04:46] phuedx ^ [19:05:11] phuedx I think 10% will get us past 'the danger zone' [19:06:51] JonKatz: ok, well fiddling the sample rate might take some time because it's not schema dependent [19:07:23] kaldari, bmansurov: i think we should turn off the logging temporarily and then re-deploy when we've sorted the sampling proper [19:07:25] agree? [19:07:34] phuedx right..I agree [19:13:32] kaldari, bmansurov: https://gerrit.wikimedia.org/r/209296 [19:27:27] bearND: i'm having trouble logging on to eventlogging02... [19:27:46] bearND: (i haven't done it yet) did you have to make any changes to ssh .config? [19:28:08] dbrant: that might be because mobilefrontend is hammering eventlogging atm [19:28:30] dbrant: i did not add any changes to ssh config [19:28:52] are you able to log on? [19:29:05] dbrant: i just logged on, no issues [19:29:29] dbrant: ah, unreachable just now [19:30:05] dbrant: seems intermittent [19:30:05] dbrant: does not work for me right now [19:30:19] maybe mholloway got lucky [19:30:24] hmm, ok [19:31:11] etonkovidova: how are you feeling about 4.1.3.96? [19:31:48] bgerstle: I was just reading now the test report... [19:35:14] bgrestle: "Upgrading the app from Wikipedia 4.1.2.0 to Wikipedia 96..." [19:36:32] etonkovidova: i'm *pretty* sure that's just an issue w/ different app versions [19:36:37] i.e. "App Store" vs. "Beta" [19:36:49] would like to talk w/ Andy/Nicholas today to be absolutely sure [19:37:04] etonkovidova: what about your testing? [19:37:34] bgrestle: yeah... I am trying to find any references to 4.1.2.0 testing [19:38:09] bgrestle: cause it's the first thing I check - the Saved/Recent etc after an upgrade [19:38:24] kaldari: is the quickest way of getting https://gerrit.wikimedia.org/r/#/c/209296/ out requesting an ld? [19:40:37] Upgrading the app from Wikipedia 4.1.2.0 to Wikipedia 96 Beta through TestFlight, [19:40:37] saved pages were not preserved after the upgrade and the previous Wikipedia app [19:40:37] was not uninstalled. [19:41:03] bgrestle: they did a clean installation? [19:41:34] rmoen: did you get the deployment slot later today [19:44:38] jdlrobson3: i don't have a slot but there is an empty swat window. I'll make the cherry-picks from the changes in the email you sent out and add it to the schedule? I'll need to verify them once the swat is done [19:45:15] rmoen: awesome. do we need to reserve a slot to make sure? [19:45:23] rmoen: that would be awesome [19:45:28] jdlrobson3: we don't, there is a swat window at 4pm pst [19:45:35] and its empty [19:45:45] yes, that's why i joined here [19:45:54] to say "the swat is still empty, grab it" [19:45:57] basically :) [19:46:15] jdlrobson3: can you indicate how i can verify these fixes in the email as well jdlrobson3 ? [19:46:19] lol double ping :) [19:46:48] Special:Version should show that extension Gather is installed [19:46:51] right [19:47:00] re: how to verify [19:47:35] rmoen: sure. [19:47:52] rmoen: if you have space would be great to deploy Wikivoyage too [19:47:52] etonkovidova: yeah, need to double check w/ them. i still think it's that they downloaded the beta which doesn't override the app store intentionally [19:48:10] but i guess that's too miuch [19:51:39] bgerstle: right. [19:53:14] bgrestle: also about #2 - the back arrow is supposed to bring to the Main page? I thought there should be just normal logical navigation [19:54:29] JonKatz: the patch to temporarily disable search logging is going out with the train now [19:54:36] thanks to bmansurov for merging it [19:54:43] np [19:54:54] we've got some breathing room to tweak the sampling [19:55:49] haha this is a funny week [19:56:12] this has been a bad week [19:56:55] it's been a hard week [19:57:03] we should retro at the end of it [19:57:53] phuedx thanks and agree on the week. rough more often than not. [19:59:11] yeah -- i'm really not sure why this week has been so hard but i feel like we should try and figure out why [20:00:23] bgrestle: "are we not supposed to show TOC on main pages?" I do not recall if I ever saw one [20:06:05] etonkovidova: do you think we should? [20:06:09] i guess we can discuss at standup [20:06:35] bgrestle: I do not think we should - but we can talk in the standup [20:16:02] having trouble connecting to the hangout for standup [20:16:09] 'tis odd [20:16:30] niedzielski: dbrant|brb [20:17:19] standup [20:25:19] ok rmoen prep work for deploy - navigate to https://en.m.wikipedia.org/wiki/David_Bowie?mobileaction=stable&debug=true [20:25:29] scroll to beta panel and click opt in [20:25:31] "okay" [20:27:37] rmoen: instrutions sent [20:27:43] i'm wrapping up now so please let me know if any questions [20:27:55] JonKatz: you need anything from me this evening? [20:28:33] jdlrobson3: ok. I'm making the cherry-picks. Unfortunately i have to manually create them for 1.26wmf5 as there are conflicts ;/ [20:28:48] jdlrobson3 i think we're good. is the toast flickr getting addressed and do you have someone managing deployment? [20:28:50] the 1.26wmf4 ones are made though [20:29:06] phuedx: yt? [20:29:28] there's a fix for it want me to add it to rmoen's never ending list? [20:29:37] i think he'll need kaldari's help though to test [20:29:41] or bmansurov [20:29:44] it's a lot of stuff [20:30:08] ? [20:30:33] kaldari: swat deploy today is out of control - see mail "SWAT deploy today needed" [20:30:37] would be great if you could support rmoen [20:30:40] with testing [20:30:53] yeah [20:30:55] i need to go to sleep soon otherwise i'd do it [20:30:59] uh we have a max of 8 patches on swat [20:31:10] bmansurov: yes [20:31:13] think we have 6 so far rmoen [20:31:14] not sure if same patch cherry picked to both branches on prod counts as 2 [20:31:16] or do you count more? [20:31:24] yeah, it's going to be a doozy [20:31:24] phuedx: about the article_click action [20:31:33] phuedx: where is the list of tagged articles? [20:31:46] phuedx: Is your EventLogging fix deployed now? [20:31:47] dbrant|brb: vibha: am i supposed to attend the design review meeting today? [20:31:52] just pile them on i'll schedule it [20:32:05] bmansurov: both in config and on the page [20:32:13] rmoen: all in the mail. if it didn't happen on the mailing list it didn't happen. [20:32:26] kaldari: i'm waiting for the wikipedias version bump [20:32:31] but it looks good on testing [20:32:41] yep, just keep sending mails [20:32:44] phuedx: on what page? [20:32:51] is thinking [20:32:51] bmansurov: the topictags page, right? [20:33:05] phuedx: well, that's automatically generated from categories too [20:33:14] bearND: between you and dbrant? We are ok eitherways. [20:33:23] bmansurov: not sure how that changes anything? [20:33:26] phuedx: doesn't fit this definition "article click - the user clicked an article in the list of tagged articles [20:33:56] phuedx: ok i see now, so doesn't matter [20:34:02] phuedx: thanks [20:34:05] eh? [20:34:11] i don't know if i said anything [20:34:23] rmoen: this illustrates the beta optin bug so nicely http://mobile-reportcard.wmflabs.org/#other-graphs-tab [20:34:26] lol [20:34:32] phuedx: telepathy [20:34:36] wikigrok panels kick arse [20:34:43] i think this is a good conclusion to draw [20:34:47] wow [20:35:01] but disabling all those images not so good hah [20:35:06] bgerstle: re: separate standups...I wonder if a win-win would be to do separate standups M/T/Th/F and do one megastnadup on W. That would at least streamline things a bit more, but give one explicit touchpoint for people who want it. [20:35:06] images turned off 50k ;/ [20:35:21] bearND: I think you would be optional... (but welcome to attend, of course) [20:35:39] kristenlans___: might be worth trying, but i still think making cross-platform concerns explicit would be even more efficient [20:35:48] dbrant: then i'll skip. It would be until 1:00 am my time [20:35:51] instead of making everyone sit through all the tasks of each platform and hoping something sounds interesting to someone [20:35:58] bearND: ah, that's right! ouch [20:36:19] if anything, we could at least limit x-platform sync to tech leads [20:36:43] JonKatz, kaldari, bmansurov: the fix has been deployed [20:36:53] we shouldn't be melting eventlogging now [20:37:11] yay! [20:37:15] 🎌 [20:37:19] dbrant: sorry for the late response. i had back friday [20:38:03] niedzielski: cool; i wanted to make sure whether you've gotten the signing key for the app? [20:38:31] dbrant: yep, yuvi hooked me up [20:38:38] niedzielski: awesome [20:38:51] hello mobilers! [20:38:55] https://gerrit.wikimedia.org/r/#/c/208315/ for your consideration [20:39:01] is still -2’d as ops deliberates the appropriate URL [20:39:09] dbrant: ^ [20:39:25] phuedx awesome! thanks for the quick turnaround [20:39:31] not me [20:39:43] all twentyafterfour [20:39:47] right [20:39:52] i'm going to bed now [20:42:15] rmoen: have you already verified that all the patches on the SWAT schedule made the wmf5 cut? If not, I can do that now. [20:42:26] kaldari: yes [20:42:36] i just verified all patches on swat made the wmf5 cut [20:42:40] kaldari: ^ [20:42:42] cool [20:42:48] whew [20:43:02] so logging one is deployed [20:43:18] so i'm counting 5 [20:43:24] only one remains is https://gerrit.wikimedia.org/r/#/c/205986/ [20:44:30] ? That one looks old [20:45:20] eah [20:45:38] Yeah jdlrobson added it to the list [20:46:03] it looks like it should already be in 1.26wmf4 [20:46:09] kaldari: it didnt get cherry picked [20:46:12] check the bug [20:46:26] unless there is another patch i missed? [20:46:42] no bug linked to https://gerrit.wikimedia.org/r/#/c/205986/ [20:46:56] I'm so lost [20:47:05] same [20:47:15] That patch should have ridden the train to en.wiki by now [20:47:33] or gone out with Rob's deployment yesterday at the least [20:47:58] kaldari: so why wouldnt it parse [20:48:02] actually strike that last comment - I see it's core [20:48:24]