[00:13:27] bgerstle_afk: https://phabricator.wikimedia.org/T95476 [00:13:31] I commented ^ [06:49:05] morning! [08:25:37] \o here for 8 mins then voting phuedx|zzZ and joakino [08:25:52] hey jdlrobson [08:25:56] how are you [08:26:11] joakino: good :) happy to see rob and kaldari sorted out beta opt in [08:26:22] \o/ [08:26:23] did you get my whatsapp? also feeling more positive around that tweet now [08:26:27] just fires me up for lyon [08:27:43] lol just saw it [08:28:09] joakino: it's really sad took it really personally :-/ [08:28:35] jdlrobson: yea, just don't [08:28:51] i found a pretty serious bug though [08:28:56] all image modules default to top [08:29:01] so it's basically icons that are causing that lag [08:30:14] jdlrobson: is that new? [08:31:16] when we applied mw-ui-icon [08:31:20] so pretty recent [08:31:27] we need to get some tools that monitor first paint [08:31:34] and let us know when we screw up [08:31:43] this should have been caught using navigation timing data we're collecting [08:32:23] jdlrobson: yeah :( [08:32:33] joakino: bunch of problems here - https://phabricator.wikimedia.org/T97289 [08:33:27] gotta go [08:33:29] talk alter [08:50:54] jdlrobson: joakino which tweet [08:51:07] yo go to sleep [08:51:44] yuvipanda: https://mobile.twitter.com/jaffathecake/status/595637850286206976 [09:09:53] yo [09:10:51] * phuedx notes that jdlrobson has missed the set of stories around measuring time to first render [09:11:07] that are in our next sprint commitment [09:40:45] awesome phuedx [09:40:58] phuedx: btw, wanna be my reviewer, the time limit is tomorrow [09:41:10] to nominate, that is [09:41:14] joakino: sure [10:42:44] going for an early, quick lunch with the fam [14:06:32] bearND: good morning! any guidance on https://phabricator.wikimedia.org/T95035? as far as i can tell it's mostly moot, with the exception of some (or all) main page links. [14:07:37] joakino: around? i thought i'd put an hour in now [14:12:33] bearND: also, i'm done with https://phabricator.wikimedia.org/T87066 and but have waited to move it to code review since it depends on https://phabricator.wikimedia.org/T94646, which is waiting on comment from design. do you want to have a look at the code even though it's not ready for testing yet, or should i keep waiting and move them over all together when the time comes? [14:13:49] dbrant: ^ your input is also welcome [14:17:21] mholloway: check out [[wikipedia:Help desk]] for help links [14:18:40] mholloway: if the code is working the way you want, then by all means put it in code review. Design tweaks can be made at any time afterwards. [14:24:25] bearND: ahh, i see. [14:26:34] dbrant: bearND ok, i've been holding off since T94646 is essentially a design feature (as opposed to a feature with incidental design effects) but i'm going run the less scripts and move the lot over to code review this morning since we're getting down to the point of tweaking on the design end, i think. [14:39:27] bearND: hmm. i see what you mean in your email about making some new less files of our own [14:40:30] mholloway: ah, good. :) [14:40:30] bearND: can i get some feedback on the OTRS bugs i open? are they useful at all ? does it help or bother? [14:41:15] matanya: sorry, haven't checked them during the last couple of days. Still behind some code review, but then I'll take a peek [14:41:37] bearND: no worries, at your free time [15:02:36] yo [15:02:43] hey jdlrobson [15:02:48] hey phuedx [15:03:04] * phuedx has just been out to vote [15:03:14] took george into the hall and he helped me [15:03:34] there were audible coos from the helpers [15:13:00] :D [15:13:05] so weird [15:13:09] they didn't need my id or anything [15:13:13] and i used a pencil [15:13:19] what's that all about phuedx [15:13:43] future innit [15:17:02] lolz [15:21:51] jdlrobson: hi :) Short question: are you traveling? I often see you in irc very early? :) [15:21:56] ghey FlorianSW [15:22:01] yeh i'm in the UK right now :) [15:22:07] jdlrobson: hey, cool! :D [15:22:11] will be on europe time for the month [15:22:17] but mostly working european evenings [15:22:43] yeah, to overlap with SF time a little bit more, right :) [15:22:54] yup [15:23:22] FlorianSW: are you tracking https://phabricator.wikimedia.org/T97289 ? [15:23:27] i think it's our biggest bug right now :-/ [15:23:37] it's got really bad - we're worst than desktop for stuff in the head [15:24:07] jdlrobson: :o i missed that bug :( [15:28:34] jdlrobson: your opinion might be somewhat skewed at the moment [15:28:40] have you calmed down yet? [15:28:48] ^ not meant as patronising [15:28:53] ^^ probably was though [15:28:59] phuedx: haha. i'm calmer but i do think it's more important than anything else right now [15:29:07] even Gather [15:29:12] it has our most users after all [15:29:15] jdlrobson: that's fine, what about yer team? [15:29:43] we're struggling this sprint. We're not gonna hit our normal velocity [15:29:47] and we've had a crazy amount of bugs [15:30:32] jdlrobson: abandoning your commitment for other work is doable, you just have to communicate that you're doing it [15:30:59] i haven't abandoned my commitments [15:31:28] i'm just doing insanely more than i should be :-/ [15:31:35] yeah [15:31:37] that's healthy [15:31:45] :P [15:31:52] i'm never healthy hah [15:32:01] ^ that's not healthy either [16:13:40] bearND: am i going crazy, or are the extensions no longer in mediawiki-vagrant? [16:14:26] mholloway: they should be. Did you just update? [16:15:33] no, i downloaded it the wrong way apparently when i started (i.e., not via ssh) and so i had the same git-review problems as i had then with the main repository [16:15:53] bearND: so now re-downloaded but apparently i'm downloading the wrong repo [16:18:08] bearND: the problem is the "Problems encountered installing commit-msg hook" issue, if you recall [16:19:05] mholloway: ah, i see. you'll want to add a gerrit remote to the extension repos you plan to contribute to [16:19:59] bearND: batcave? [16:20:13] mholloway: exampe for MobileApp: git remote add gerrit ssh://mholloway@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileApp.git [16:20:29] mholloway: omw [16:20:39] one sec, grabbing headphones from downstairs [16:23:02] mholloway: https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Quick_start [16:46:01] rmoen: ping [17:03:21] coreyfloyd: I do not see the fix in 4.1.3 106 for T97589 "Hebrew wikipedia - Main page displayed its table structure as collapsed" [17:04:53] etonkovidova: hmmm… [17:04:56] lemme look [17:05:04] coreyfloyd: ok [17:05:52] etonkovidova: it should be in a new build from today… 106 was yesterday [17:05:58] bgerstle: did the build fail? [17:06:08] good question.. [17:06:18] coreyfloyd: understood :) thx! [17:07:07] looks like something failed [17:07:19] ah haaaa [17:07:21] a failed test! [17:07:40] not because something's broken, though [17:07:57] but didn't catch it because i didn't re-run the tests before pushing and they're not run as part of code review [17:08:11] coreyfloyd: etonkovidova i can push a patch to fix it and a re-run the build once it's merged [17:08:47] bgrestle: well, if it's not too much trouble ... [17:08:54] no, should take 2 seconds [17:08:55] bgerstle: guess we need to be running tests on all branches we push… if only there was an easy way to do that [17:09:08] coreyfloyd: there is, but there's no notification for when builds fail [17:09:22] bgerstle: i mean pre-merge of course [17:09:22] coreyfloyd: just update the git config to poll the repo on master & any review branches [17:11:15] we could do the same for beta/release jobs (run a build on pushes to release/* branches) [17:12:16] rmoen: so not really sure what was happening with the add collection workflow - it just freezes. [17:12:46] jdlrobson: yeah i noticed that last night. Not sure what changed there [17:13:32] i thought about merging it and fixing it after just to keep it moving but when i realised it was also search workflow i figured that would be a bad idea [17:15:20] jdlrobson: you're saying the search is broken too ? [17:16:00] when clicking save it just freezes [17:16:12] not sure why - api request goes through [17:16:16] not calling callback i guess [17:16:23] or not having a callback bound [17:16:35] jdlrobson: hmm ok. working on it right now [17:22:19] coreyfloyd: standup? [17:30:39] jdlrobson: a quick question, I'm taking user input such as image-url, if the entered url is wrong, is throwing Exception the standard practice or should I attempt graceful recovery? [17:30:59] codezee: what kind of exception codezee ? [17:31:01] php? js? [17:31:16] and what do you mean by user input - updating config file or using form on site? [17:31:54] I mean I'm taking a file name through a parser function, what if the file with that name does not exist? [17:33:16] you should not allow it [17:33:19] so graceful recovery [17:33:53] jdlrobson: alright :) [17:37:36] coreyfloyd: thanks for the merge. running build now [17:41:55] jdlrobson: needed to set reloadOnSave: true; Right now it takes you back to Special:Gather. Not sure where it should take you at this point. [17:45:24] coreyfloyd: build 108 succeeded. should be out soon [18:20:15] Deskana: i can totally swipe cupcakes from my seat... [18:20:37] mhurd: Will there be any left by the time that the meeting is over!? [18:21:11] rmoen: sorry for delayed reply but awesome :) [18:21:20] will take a look in a bit [18:21:51] Deskana: 2 down... [18:30:40] gonna go for a boulder [18:36:12] mhurd: this is fixed right? https://phabricator.wikimedia.org/T96922 [18:38:06] coreyfloyd: ^ I don't think so. It's actually pretty tricky. Recommend chatting more about it before doing any work [18:38:32] mhurd: ok - just thought i remembered hearing about that recently [18:38:47] coreyfloyd: I'll double check this afternoon [18:39:23] bmansurov: hey Baha I think I remember you worked on title wrapping issues before [18:39:33] bmansurov: https://www.dropbox.com/s/nprnuffj1dkheah/IMG_8153.jpg?dl=0 [18:39:55] kaity: yes [18:40:05] bmansurov: just noticed this page - I thought it was resolved? [18:40:25] kaity: not quite, because the browser support isn't good [18:40:47] kaity: is that mobile safari? [18:40:58] bmansurov: yes iphone 4s safari [18:41:11] bmansurov: weird, I've never seen it happen on another website [18:41:33] bmansurov: I thought default behavior was not to hyphenate words [18:41:45] kaity: let me find the related task [18:43:34] kaity: https://phabricator.wikimedia.org/T93826 [18:44:19] kaity: it's tricky because long words that don't fit in one line will have to be hyphenated [18:44:41] bmansurov: yes [18:45:13] kaity: ok, i'll re-open the task and see if I can fix the issue [18:45:23] bmansurov: What happened before? Is hyphenating very long words not a default behaviour? [18:45:53] bmansurov: ok thank you! [18:46:01] bmansurov: I think its a pretty important bug [18:46:41] kaity: I don't think it's easy to find if a word fits in a line. So we just had to hyphenate all words. But most browsers don't support hyphenation anyway. [18:47:20] bmansurov: what happens if we don't hyphenate very long words [18:47:37] do they get cut off to the right? or wrap without a hyphen? [18:47:47] kaity: either [18:48:04] or can be visible with a horizontal scroll [18:48:16] whichever we decide to implement [18:49:30] in private irc rooms, my outgoing messages are not being received, so ping me on hangout if you need a response. someone type 'roger' if this was received [18:49:43] roger ;) [18:49:55] thanks bmansurov [18:49:59] np [18:50:33] bmansurov: its most important to not hyphenate all words [18:50:49] bmansurov: I think wrapping without a hyphen is ok [18:51:12] kaity: ok, and wrapping should only happen when a word by itself doesn't fit in a line, right? [18:51:18] bmansurov: yes [18:51:37] kaity: ok, so on your screenshot the word 'National' should be brought down to the next line? [18:51:43] bmansurov: I looked up antidisestablismentarianism on dictionary.com [18:51:55] bmansurov: they have it working with a hyphen, not sure how [18:52:08] bmansurov: yes national should go to the next line [18:52:37] kaity: with the current code that long word will be hyphenated too on wiki [18:53:30] bmansurov: maybe check out how dictionary.com did it? maybe they used a different method [18:53:50] kaity: ok, i'll look into it [18:58:27] kaity: http://imgur.com/RtmDyXV is what I see. Can you share your screenshot too? [19:00:26] bmansurov: https://www.dropbox.com/s/0bj9fprqw9jmbi6/IMG_8155.jpg?dl=0 [19:00:54] kaity: thanks [19:01:08] bgerstle: coreyfloyd hey I'll be a few minutes late - headed downstairs [19:01:18] ok [19:01:22] bmansurov: sure, thanks for working on this again! [19:05:20] kaity: so what they are doing is that they are showing a list of syllables, which makes it easy to add a hyphen. Not sure if I should explore ways to breaking a word into syllables to fix this bug. [19:05:38] of [19:06:19] bmansurov: but the title is also hyphenated, and its not broken into syllables [19:06:31] kaity: yes, I can remove the hyphen ;) [19:08:28] kaldari: thanks for the review [19:10:51] NP [19:11:07] jdlrobson: I forget, are you going to Wikimania? [19:14:27] bearND: for the event logging patch, can i assume you're in agreement with dbrant about not needing to separately log both linkclick and navigate where we're not showing a link preview? [19:24:37] jdlrobson: I forget, are you going to Wikimania? [19:25:36] mholloway: hmm, I think Deskana mentioned that he wanted both events for when we don't have link previews, but since that's really PM realm I'll defer to dbrant for final decision. [19:26:04] dbrant: do you have a plan on how you would like to evaluate the link preview prototypes events? [19:27:13] kaldari: as of last week yes [19:27:16] joakino too [19:27:24] yay [19:28:21] bearND: regardless of the plan, I think that logging two events for a single action is unnecessary (when we can infer that the first event implies the second)... [19:29:14] dbrant: cool [19:30:00] mholloway: dbrant: shouldn't we send the navigate event in that case? [19:31:47] bearND: dbrant either one seems fine to me, but i agree that logging both seems redundant [19:32:33] dbrant: With my data analyst hat on, I suggested logging both because it makes the analysis easier. [19:32:49] dbrant: That way you can use the same queries to compare versions A and B with the default. [19:33:11] dbrant: If you're not sending the extra event then that's harder because the query will return 0. [19:33:47] dbrant: But yeah, it's up to you. There's nothing that you can't do if you log the extra event, it just makes the analysis more annoying. [19:34:04] *can't do if you DON'T log the extra event [19:35:15] Remember to talk scale / sampling with analytics :) [19:37:56] jdlrobson, kaldari would you like to review https://gerrit.wikimedia.org/r/#/c/209610/ ? :) This fixes the load of mobile.editor.common on every page load. [19:38:08] :-O [19:38:09] Deskana: yep, I was just thinking that the savings of event packets will be worth the minor annoyance... [19:38:11] good catch FlorianSW [19:38:15] you have my attention [19:38:19] bearND: mholloway: hmm, that's a fair point. For consistency's sake, we could go with the Navigate event in that case. [19:38:32] jdlrobson: great :D [19:38:32] oh FlorianSW it's only a problem in alpha? [19:39:00] dbrant: bearND: Deskana: i'll put it back then if that's the consensus [19:39:01] jdlrobson: yes, in alpha, sorry, i should mention this :) [19:39:05] less concerned now but it looks good. [19:39:06] i'll test it later [19:39:10] bearND: one other question about your comments on that [19:39:18] jdlrobson: great, thanks :) [19:39:26] bearND: https://gerrit.wikimedia.org/r/#/c/209138/11/wikipedia/src/main/java/org/wikipedia/analytics/LinkPreviewFunnel.java [19:39:44] bearND: for the second comment, i think we need the int to do the % 4 calculation [19:40:01] (whereas getAppInstallID returns a string) [19:40:03] mholloway: I meant send the Navigate event *instead* of the LinkClick event [19:40:10] bearND: or did I misunderstand the comment? [19:40:23] dbrant: ahh, sorry [19:41:09] dbrant: Sounds sensible. Remember to update the schema on meta to note this, for the data analyst's sake. [19:41:10] dbrant: i thought Deskana was arguing in favor of both, not in favor of logging navigate instead of linkclick [19:41:50] mholloway: ah, I see now. You're right. I confused the appID variables. Sorry, ignore that comment then. [19:41:57] bearND: ok cool [19:42:36] kristenlans coreyfloyd dbrant - Sprint 56 Design Signoff is now complete. [19:43:02] is there anything else that needs design signoff? [19:45:58] vibha: kaity: please respond to my question on https://phabricator.wikimedia.org/T97819 [19:48:23] bearND: LOOKING [19:48:32] argh sorry - didnt mean to All caps on you [19:48:44] phuedx|AFK: kaldari: bmansurov alpha new menu looks much nicer. good work :) [19:48:53] i'm so happy to have a js menu again :) [19:49:23] jdlrobson: glad you like it [19:49:32] done [19:49:59] bgerstle: Did you want me to look at the ref superscript stuff? I needed at least one more screenshot. [19:50:38] vibha yes please! everything's been deployed in the latest alpha (108) [19:50:44] vibha are you on the alphas? [19:51:39] yes I am. Give me a moment sir! [19:52:13] vibha great [19:54:40] vibha: thanks. There's more followup on https://phabricator.wikimedia.org/T97819 ;) [19:55:59] is testing new aplha [19:57:20] Very Good, no superscripts for the most part. I saw one or two edge cases _ but I really was trying to break your feature :) [19:57:40] vibha that's what you should be doing? if it's worthwhile we can talk about the edge cases [19:57:53] are they issues w/ partial superscripts? "like this.[2" [19:58:07] yes! How did you know [19:58:13] because i hit the same problem ;-) [19:58:16] were you trying to get away with it? :) [19:58:21] shhh [19:58:25] jk [19:58:34] looks good for now. I'll signoff. [19:58:35] rmoen: "Please review" in your inbox. want to get that swat deploy scheduled [19:58:46] vibha thanks. unless android has a magic regex that gets those as well [19:58:49] then i can patch it [19:58:55] jdlrobson: right :) [19:59:38] dbrant: know of any issues w/ partial superscripts when sharing? ^ [20:00:00] tah :) [20:02:55] bgerstle: hmm, is there an example article? [20:03:14] https://phabricator.wikimedia.org/T95476 [20:03:18] dbrant try to share text w/ a partial citation on any article [20:03:25] dbrant: You can look at the time article [20:03:33] I attached a screenshot from it on this phab task - https://phabricator.wikimedia.org/T95476 [20:03:50] so go to an article -> select text "with a partial citatation.[1" -> see if citation is stripped [20:03:58] bgerstle: Signed off by design, throw it into any column as needed. [20:04:25] App kids - Design sign off is closed for now. I'm switching gears to production stuff. I'll look at the 56 boards eod now. [20:04:34] bgerstle: vibha: yep, we've got the same behavior [20:04:59] vibha: thanks! [20:06:13] dbrant same behavior as in: the partial citation is or isn't stripped? [20:06:31] bgerstle: is not. [20:07:49] dbrant: http://img3.wikia.nocookie.net/__cb20130929182255/gtawiki/images/b/b3/Grumpy_Cat-Good.jpg [20:08:00] lol [20:12:49] http://newsfeed.time.com/2013/03/22/grumpy-cat-is-not-impressed-by-times-photoshoot/ [20:13:14] kaity: i fixed the iPad lead image height. do you want to move the card from "design signoff" to "ready for signoff" based on what i showed you before you left yesterday? [20:13:58] mholloway: done [20:14:07] oops i mean mhurd [20:14:16] kaity: awwww [20:14:22] kaity: i was so happy for a second! [20:14:26] kaity: haha "mh" autocomplete :) [20:14:28] vibha a former colleague of my got to meet grumpycat! [20:14:31] so jealous [20:14:34] lol [20:14:57] mholloway: sorry ! [20:15:05] kaity: yeah, i've considered changing to mdholloway for that reason [20:15:25] kaity: mhurd mholloway you know my thoughts on this subject [20:15:27] kaity: but i wonder if that would be inconvenient since all my other accounts are mholloway [20:15:32] sorry mholloway it's been great working with you.. but.. [20:15:37] lol [20:15:40] bgerstle: hahaha yes i do [20:16:02] vibha did you get my note about signing off for the 4.1.3.96 release? [20:16:07] mholloway: if your name had weird spelling like mine you could go by michael? [20:16:08] i can hangout if you want to talk it over [20:16:26] mholloway: mikle? [20:16:34] mikkel [20:16:38] mikal? [20:16:46] that sounds real [20:16:55] i knew swedes who spelled it mikael [20:17:03] how does mikal cronin pronounce it? [20:17:14] bgerstle: meyakel [20:17:24] mhurd that's an interesting one [20:17:25] mhurd: good one [20:18:00] cheers rmoen [20:19:28] Im going to buy a Llama and make an internet celebrity out of him. [20:19:50] BGerstle - you have first dibs on a photo with him. Promise. [20:19:53] \o/ [20:20:01] bgerstle: done -- it just makes sense [20:20:11] no other md*'s on here [20:20:22] rmoen: https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=158073&oldid=158046 [20:20:28] mdholloway: THERE CAN BE ONLY ONE! [20:20:32] ;) [20:20:41] mdholloway: now i'm confused. is your name markdown holloway? [20:20:46] hahah [20:21:10] ^^ i'm sitting next to mhurd and that's a legit laugh. [20:21:11] bgerstle: i'll keep that in mind if i have a kid [20:21:15] Mark Down Holloway [20:21:38] he's been giggling for the past few minutes. now i know why [20:21:45] lolol [20:21:54] niedzielski: he's had too much coffee. don't make any sudden movements [20:22:02] he can't see you if you hold still [20:22:11] niedzielski: mhurd ha, i'm glad to know that the lols are legit :) [20:22:17] that last one might be for dinosaurs, but better safe than sorry [20:22:20] * niedzielski sits very still and is invisible to mhurd [20:28:47] bgerstle: 4.1.3.96 release is signed off. [20:29:08] I did add notes that interface items have been individually tested. We have not tested one build which has all the features in it. [20:29:12] That is ok. [20:30:38] vibha you should have a release candidate for 4.1.3.96 as well.. let me get back to you on that [20:33:44] MaxSem: hey you around? [20:35:32] mhurd, yup [20:37:01] mhurd: going to be late for our meeting. Just leaving home - had to do a 3am firefight yesterday. Small, but still.. [20:37:21] MaxSem: hey i noticed what may be a bug (regression?) with the "thumbwidth" parameter. on enwiki article for "wikipedia" asking for a thumbnail of width 640 returns url for 103px wide thumb. https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=wikipedia&prop=image%7Cthumb&thumbwidth=640 [20:37:30] yuvipanda: no worry! [20:44:15] bearND: ah, i just got your comments. agreed on the first change (stripping down android-specific less files to where they diverge from MFE) [20:44:20] mobile web guys (e.g. joakino, kaldari, ...) or yuvipanda: any opinion on how to best override less files from MFE in out MobileApp extension? See https://gerrit.wikimedia.org/r/#/c/209588/ for details [20:45:04] bearND: i talked with dbrant about the second issue around lunch/monthly meeting time, while i was having a hard time catching you [20:45:41] mdholloway: ^ also checking for a second opinion on this since the web guys know more about this, I think. [20:46:30] mdholloway: sorry about that. I think theoretically stripping it down should work since our LESS files come after the MFE LESS files [20:48:48] bearND: I was chatting with mdholloway earlier about the implications of possibly diverging our CSS from MFE entirely... [20:49:08] bearND: ...and also, no longer downloading CSS from within the app. [20:49:33] (and having a discussion about all this in the next sprint) [20:51:12] dbrant: great. I saw a hint about that in the Gerrit comment. That's interesting. What's the reason for that? [20:51:44] dbrant: agree with not trying to download CSS files, even after 2019 ;) btw [20:52:12] dbrant: just wondering about diverging from MFE styles more [20:53:05] * jdlrobson takes break [20:53:24] bearND: well, the biggest issue is that the MFE folks can make changes to the CSS without syncing with us, and we wouldn't know about it until we notice some visual quirks in the app... [20:55:20] mhurd, can you create a bug please? [20:55:25] dbrant: ok, that's a valid concern. [20:56:21] jdlrobson: Can I nominate you for my annual review? [20:56:49] MaxSem: for sure! [21:30:35] MaxSem: does this look ok? https://phabricator.wikimedia.org/T98528 [21:31:19] нгз [21:31:21] yup [21:31:37] MaxSem: cool! [21:31:45] bgerstle_afk: coreyfloyd ^ [21:49:46] MaxSem: i added a couple more comments to https://phabricator.wikimedia.org/T98528 [21:49:52] MaxSem: i suspect it [21:50:12] MaxSem: it's only an issue with getting thumb urls for images which are svgs... [22:00:50] jdlrobson: does the overlay that points to the hamburger menu only show for users who havent created any collections yet? [22:13:07] jdlrobson: /cc bearND: your points are good ones. to be honest i know a lot more now about how all of this fits together than i did when i picked up this task two weeks ago. it seems like there's a broader convo about code convergence/divergence that needs to happen. [22:14:19] mdholloway: agreed. I'd like to see the mobile web team taking more of your styling content bugs so you can focus on native app dev [22:14:29] and doing stuff like push notifications [22:22:18] mdholloway: jdlrobson: I agree. We should have a conversation how we best do this. And I'd also like to understand more why some of our styles are different from MFE's. /cc dbrant|bbl [22:22:48] bearND: they shouldn't be. The other day mhurd brought a bug to my attention that was causing problems to MobileFrontend as well and hadn't been reported there [22:23:02] whilst you're using a web view you'll unlikely to hit any bugs that we don't have. [22:23:05] i was just going to ping mhurd since we've talked about this also [22:24:42] yes, this is for both iOS and Android apps. I think dbrant|bbl had planned to talk about something similar next week [22:32:46] legoktm: yuvi made me do it! ;) [22:33:07] :P [22:33:09] * legoktm slaps yuvipanda [22:33:49] * yuvipanda wears anti-trout armor [22:36:09] bearND: i'm noticing it's really easy to run into merge conflicts over PageViewFragmentInternal. Kind of a lot going on there. [22:37:10] bearND: i think it's time for me to slowly back away from the computer now but i'll resubmit the event logging patch first thing in the a.m. [22:37:58] mdholloway: yes. The patch I'm working on suffers as well from that. It would spin off some functionality into new classes, though. That should make it easier in the future. May need to do some more refactoring later, tho [22:40:01] cool. well, i'm off to fire up the grill. g'night, all! [22:40:09] mdholloway: see ya! [22:40:59] dr0ptp4kt, bmansurov: James and I got search EL running on my laptop. \o/ [22:41:25] Deskana: party time! [22:43:22] Unfortunately James fell at the first hurdle: vagrant up [22:43:49] Deskana: yay [22:44:01] yeah, how terrible a vital part of the developer experience with no actual owners is doing badly. [22:44:08] bmansurov: Thank you for your work on it. :-) [22:44:12] we're working on it. Looks like his git clone of MediaWiki may be incomplete/corrupt [22:44:27] Deskana: np, it was a good learning experience for myself [22:44:41] bd808: Thank you. You go above and beyond with vagrant stuff. [22:44:42] yuvipanda: I own that! I just don't get paid to own it or something ;) [22:45:14]