[08:06:00] 50 emails [08:51:43] hi phuedx! [08:51:54] hey joakino [08:53:21] phuedx: how was the weekend [08:53:39] stressful [08:53:44] buying stuff for the new room [08:54:00] having to make decisions bearing in mind timing [08:54:05] it was like work all over again [08:54:22] joakino: yours? [08:54:46] haha [08:54:58] phuedx: nothing special, just relaxing [09:55:00] wtf jenkins [09:55:11] phuedx: do you know if we're havng qunit issues on MF? [09:55:43] joakino: yeah -- there's an asynctest failure i think [09:55:45] see https://gerrit.wikimedia.org/r/#/c/209544/ [09:56:09] phuedx: fixable? is it a qunit test badly written? [09:57:44] joakino: https://phabricator.wikimedia.org/T98377 [09:58:43] grr [10:02:05] joakino: need to go through the async tests [10:02:10] for me, it's the router one [10:02:18] i've also seen the infinite scroll one failing [10:03:33] phuedx: so any advice? should i just recheck relentlessly? [10:04:07] joakino: help me fix the async tests? :/ [10:06:43] phuedx: that too lol [10:07:21] joakino: there are three modules that use asyncTest [10:07:29] infinite scroll [10:07:29] router [10:08:06] watchlist api [10:08:34] phuedx: ohm, so Qunit.start is being called later so that's why it reports a random test each time saying "Called start() while already started (test's semaphore was 0 already)" [10:08:51] yeah, afaict [10:09:00] the test that it reports as failing might be the last one to process [10:09:00] phuedx: so are we missusing the asynctests? has the qunit version changed and deprecated something? [10:09:08] joakino: maybe [10:09:16] joakino: it might be prudent to make them /not/ async [10:11:03] joakino: https://gerrit.wikimedia.org/r/210015 [10:11:06] ^ frinstance [10:13:41] phuedx: i see, but i don't like the library conditioning how we test our code, for example i wrote that one and I feel more confidente testing the user behaviour (scrolling) and observing the event rather than calling internal implementation methods [10:13:50] phuedx: i'm having a look at the qunit docs [10:14:19] joakino: agreed -- i'm looking for a nicer way of doing it [10:14:37] but scrolling the body and waiting for an event? [10:14:53] joakino: maybe manually constructing the scroll events might be an option? [10:16:21] phuedx: triggering jquery events may be one [10:17:09] joakino: don't get me wrong, i agree that manipulating the internal state of the object in order to get it to work isn't /the/ solution [10:17:27] joakino: infinitescroll seems to take an element but always reads the state of the body element? [10:17:34] phuedx: can you help me finding out which qunit version we are using? in Special:JavascriptTest I see QUnit 1.17.1 from the js files loaded [10:17:43] * phuedx checks [10:17:55] phuedx: which is the one in resources/lib/qunitjs/qunit.js [10:19:38] joakino: agreed -- 1.17.1 [10:19:45] that's also mentioned in the main resources.php [10:19:56] phuedx: k so almost the last one [10:20:25] phuedx: maybe we should migrate the async tests to assert.async and see if that fixes it? [10:20:26] https://api.qunitjs.com/QUnit.asyncTest/ [10:20:42] https://api.qunitjs.com/async/ [10:21:18] nice [10:23:16] joakino: you want to take the infinitescroll one? [10:24:00] phuedx: lol customs want me to pay 47€ for receiving the wikimedia bag [10:24:09] wtf [10:24:33] zomg [10:25:08] joakino: watchlistapi tests really, really don't need to be async [10:25:21] all promises have been stubbed to return immediately [10:25:25] so i'm just going to drop 'em [10:25:46] phuedx: yep [10:26:23] phuedx: gonna take over your infinite scrolling patch [10:27:22] joakino: dropped it [10:27:35] let's ignore that patch and do it proper [10:27:47] ok [10:31:09] joakino: we're going to have to do it in one patch anyway ;) (fix the tests all at once!) [10:31:41] phuedx: i'm onto something [10:31:58] joakino: i will shut up then [10:54:18] joakino: any joy? [10:54:26] norp [10:55:07] phuedx: the problem is QUnit.stop and start is braking on the router's tests on teardown [10:55:19] because it is doing some nasty nasty things with the browser's hash [10:55:20] joakino: i'm looking at the router tests right now [10:55:24] inorite? [10:55:30] want to hangout real quick? [10:56:16] sure [11:05:34] ok -- heading out to a father's group [12:30:53] hey [12:31:08] hi kikero [12:31:11] :-) [12:31:26] I would like to have basic support of UniversalLanguageSelector in MobileFrontend [12:31:37] i.e. have a dropdown with three languages in the menu [12:31:48] any suggestions on how I could do that? [12:31:56] I'm not familiar with the code base [12:33:35] kikero: may I suggest opening a task on https://phabricator.wikimedia.org/tag/mobile-web/ ? I'm sure they can give you some better advice in there [12:33:50] kikero: or also show up in a few hours when SF is awake [12:45:29] joakino: thanks [12:45:34] well, I guess I'll do both [14:33:45] kaity: good morning! did you get a chance to look at the latest apk after i shipped out for the weekend? [15:21:09] bgerstle: looking at your patch now, you also want to check mine out? [15:21:15] sure [15:38:21] bgerstle: i can't stop listening to too many zooz [15:38:28] phuedx: hehe nice [15:38:30] glad you like 'em [15:48:43] coreyfloyd: dbrant bearND we don't log what search results users click on? [15:48:45] just that they clicked something? [15:57:19] bgerstle: that is correct [15:57:59] dbrant: hrm, i guess getting anonymized data on reading/searching patterns is out of scope atm [15:59:58] joakino: phuedx cheers for investigating the qunit errors [16:00:27] jd are you james douglas? if so, i can't find your userpage to check [16:00:49] just curious if search & disco is thinking about data mining yet [16:00:58] (anonymized ofc) [16:03:44] jdlrobson: joakino did the hard work [16:03:56] is he recovering now phuedx ;-) [16:03:56] but i think minimising the use of async stuff is probably a good general approach [16:04:00] hah [16:04:03] probably! [16:06:35] phuedx: +1 [16:06:47] got my visa back ! :D [16:06:53] :D!!! [16:07:04] all good? [16:30:54] i'm back [16:31:06] hey jdlrobson phuedx bgerstle [16:31:15] o/ joakino [16:32:01] hey joakino [16:32:34] how are you doing [16:33:27] has anybody been in nicaragua? [16:34:36] joakino: yup [16:34:38] love it [16:35:04] jdlrobson: we're planning to go on september, but i'm not sure about the weather [16:35:07] when did you go [16:35:31] february [16:35:56] turns out the best places to go in september are europe & north america mostly [16:36:03] rainy season in a crapton of places [16:36:16] jdlrobson: so i'm guessing you caught dry season [16:36:42] yeh.. i've not been down there that time of year [16:36:49] i always go in february to central america [16:37:35] k thx [16:37:48] jdlrobson: have you been in indonesia? [16:38:10] nope. i've been to SE asia though that time of year (ish) it's wet but warm [16:38:15] i imagine central america is kinda the same [16:38:32] https://en.m.wikipedia.org/wiki/San_Juan_del_Sur [16:38:48] yej it's the wettest month but still 22-27C [16:39:15] i'm too hipster for indonesia ;-) [16:39:59] yea, weather seems acceptable, but hot and rainy all the time [16:40:12] jdlrobson: what's up with indonesia? [16:40:25] it is huge, i'm guessing outside bali it's mostly unexplored [16:40:30] i dunno just everyone i know seems to go to bali and rave about it. Plus Bali has lots of aussies in it. [16:40:39] i'm sure it's lovely [16:40:53] yeah bali sounds ultra-touristy [16:41:04] yeh outside bali is probably v. cool [16:46:42] joakino: are you able to join hangout? [17:15:30] gonna get the boy to bed [17:32:15] bearND: just to confirm before i dive back in: i should take out the appInstallID refactoring and resubmit, correct? [17:32:34] mdholloway: yes. [17:32:46] bearND: ok1 [17:32:50] bearND: ok! [17:36:17] https://phabricator.wikimedia.org/project/sprint/board/1249/ < JonKatz [17:50:24] dbrant mdholloway bearND any preference on the next phabricator i pick up? [17:51:30] niedzielski: they're ordered in roughly top-to-bottom priority, so something near the top (e.g. appcompat library) [17:51:53] dbrant: sounds good, thanks [17:52:17] niedzielski: you have API10 device(s), right? [17:52:26] i have one api 10 device [17:53:49] dbrant: can you describe the rendering issues you were seeing previously? [17:54:51] niedzielski: this was the original issue: https://phabricator.wikimedia.org/T92850 [17:55:54] dbrant: ok cool. thanks [18:33:58] What's up with the spam on mobile-i? [18:35:44] sjoerddebruin: which spam are you seeing? [18:35:59] oh the big data? [18:36:31] Yes, three mails or something. [18:36:50] mhurd: gotta patch up for review: https://gerrit.wikimedia.org/r/210114 [18:37:03] coreyfloyd: k [18:37:06] :-/ same person from look of it. dr0ptp4kt do you have access to the list? Can you ban the sender? [18:37:23] JonKatz: need any help signing off? [18:37:28] sooner i can announce new iteration the better :) [18:37:45] mhurd: most of the lines are a enum rename… let me know if yo need me to walk you though though [18:38:11] coreyfloyd: k. will review in ~10 min [18:39:53] jdlrobson in a kickoff until 12:30. [18:40:00] JonKatz: got it :) [18:40:22] jdlrobson but should be able to hit a bunch starting then. feel free to sign off without me ;( [18:47:10] jdlrobson: i think that email was let through the moderation queue in the past. do we want to *not* have that type of email come through in the future? i'm sure i can ask the individual to stop sending to us [18:47:48] oh really? we can keep an eye on it. I've not read it - i just assumed it was spam dr0ptp4kt [18:48:24] maybe leave it then [18:52:28] yeah, from what i can infer (i.e., moderation is turned on and such messagess have previously been delivered). jdlrobson: i asked grace to please remove mobile-l from the distribution list as it seems a bit off topic. cc sjoerddebruin [18:52:49] Okay ,thanks. [18:52:50] thanks dr0ptp4kt [18:53:18] sjoerddebruin jdlrobson: sure thing, thanks for flagging the concern [18:53:31] dr0ptp4kt: i've sent you a pm (Admin stuff) :-) [18:54:08] jdlrobson: oh, ha, one moment [18:57:46] jdlrobson: whenever you get time, let me know the feedback on the new patch at https://gerrit.wikimedia.org/r/#/c/209432/ [18:59:10] bb! [19:00:28] codezee: will do! currently catching up with the weekend [19:00:32] should be able to look at it today [19:01:15] Was hoping Max could take a look before merging but if it makes sense i'll pull him in afterwards :) [19:01:23] coreyfloyd: quik hangout? [19:01:40] jdlrobson: ok! just a small question though,should I send a reminder mail to nicolas for this wednesday's meet,so that all 3 of us can catch up? [19:02:31] kaity kaldari https://etherpad.wikimedia.org/p/U [19:03:04] http://en.wikipedia.org/wiki/List_of_films:_U–W [19:07:49] kristenlans: please don't let them choose u571 [19:08:54] jdlrobson: Undercover brother! [19:10:42] ok, I just read the premise and now I want to watch Undercover Brother immediately phuedx, bmansurov, kristenlans, kaldari [19:11:10] 👍jhobs [19:11:54] coreyfloyd: fyi, I'm able to login to the event logging test instance again [19:12:15] jhobs: looks kind of amazing... [19:12:22] bearND: oh thanks… i meant to tell you that i was able to get in today [19:12:24] viewing party? ;) [19:12:44] Undercover brother viewign party in Lyon!! What coudl eb more french? [19:13:14] haha I was thinking next time we're all in SF [19:13:32] jdlrobson finished sign off on non-eng Greatest Hits tasks [19:13:40] jhobs, kristenlans, bmansurov, kaldari: i'm not sure i can be your tech lead any more [19:13:46] JonKatz: perfect thanks! are you able to talk now? [19:13:52] "Black Reel - Best Film Song for 'Undercova Brother (We Got the Funk)'" [19:13:52] how could you not vote for unbreakable? [19:13:56] IT WOULD HAVE BEEN PERFECT [19:13:57] I did vote for it! [19:14:09] jdlrobson yes pinging on hangout [19:14:13] (just not as much as the other) [19:14:28] plus that would've just been asking for trouble [19:15:30] I can see it now: "'T999280: Mobile Web is completely broken' has been added to Sprint 47 - Unbreakable" phuedx [19:16:03] it wouldn't be the first time that task has been written [19:16:12] what would've been better was if sprint 46 was Titanic [19:16:20] follow THAT up with Unbreakable [19:17:29] HAHAHA [19:17:46] hindsight's a bitch [19:17:47] the long game of lining up sprint names [19:18:21] Let me just go produce "Vince: Undercover Brother 2" real quick [19:18:53] https://phabricator.wikimedia.org/T98770 [19:20:50] phuedx: i did [19:21:33] "phuedx changed Story Points from 100 to 85" [19:21:40] lulz [19:28:14] dbrant: bearND: why is BottomContentHandlerOld old? [19:29:01] mholloway: ah, so that was when we thought that "Read Next" would replace "Read More". [19:29:28] mholloway: "read next" became BottomContentHandler, and "read more" became BottomContentHandlerOld... [19:29:47] mholloway: but then we removed "read next" :( [19:30:43] dbrant: I see. I was reading about the sad fate of "read next" in the commit messages and figured that had something to do with it. [19:30:56] dbrant: not just Good Old BottomContentHandler [19:31:30] dbrant: should I change the name back? [19:33:06] mholloway: yep, go for it [19:54:48] dbrant: niedzielski bearND https://gerrit.wikimedia.org/r/#/c/208315/ has now been blessed by ops involved in the bits change [19:54:55] mholloway: ^ [19:55:22] dr0ptp4kt: ^ iOS needs an equivalent patch too. outside of the CSS updating, the EL end point is changing, so you might want to get it out for older devices as well [19:55:41] yuvipanda: :D [19:56:07] yuvipanda: so, the new endpoint works as of now? [19:56:08] bgerstle: coreyfloyd mhurd ^^ [19:56:23] bgerstle: coreyfloyd mhurd you guys got it covered on ios? [19:57:04] yuvipanda: what do you mean about older devices? [19:57:11] dbrant: yes, they [19:57:12] do [19:57:21] bgerstle: I saw a comment about this being the last release for iOS6? [19:57:28] or something to that effect. [19:57:50] dbrant: all the desktop / mobile web sites have been using the new endpoints for a week now, so fairly stable [19:58:02] very good [19:58:06] yuvipanda: i see. so when will the new EL endpoint be broken? [19:58:19] new or old? [20:01:04] bgerstle: dbrant the old endpoint still will work, but at some point when usage drops below some threshold we’ll kill it [20:01:23] yuvipanda: sorry i meant old [20:01:49] yuvipanda: will you remove your -2 on https://gerrit.wikimedia.org/r/#/c/209371/ then? [20:01:53] right. so they won’t break now, but apps are basically the major holdovers :) so we’d want to kill them sooner than later, [20:02:33] bgerstle: done. is that the only reference to bits.wikimedia.org? If you look at the android patch there are 2 other references too [20:02:46] yuvipanda: lemme grep [20:13:17] hey, everyone! joakino recommended me asking about this some hours later, so I'm repasting the same question again [20:13:31] I would like to have basic support of UniversalLanguageSelector in MobileFrontend. (i.e. have a dropdown with three languages in the menu) [20:13:47] Any suggestions on how I could do that? I'm not familiar with the code base. [20:13:50] hey kikero! [20:14:15] kikero: which menu are you talking about and how does this differ from the language button we currently have? [20:15:05] jdlrobson2: as far as I now, when it comes to multilingual wikis and mobile frontend [20:15:14] the only support is for the set up we've got on, say, wikipedia [20:15:19] i.e. wiki farms [20:15:38] I don't have that, I only have one wiki and the UniversalLanguageSelector (or the Language Bundle) set up [20:15:44] I'd like to be able to change the language of the interface [20:15:48] While in mobile view [20:16:03] ohh the interface. I see. [20:16:24] the obvious place to try that out would be to integrate it into the mobile LanguageOverlay in some way [20:16:30] the problem we have is space on mobile [20:16:41] the left menu for instance is already pretty cluttered [20:17:20] https://en.m.wikipedia.org/wiki/Languages#/languages < LanguageOverlay [20:17:39] it's really a design problem :-/ [20:18:21] Is there a phabricator task open? If not I'd recommend opening one and get Pau and kaity opinion [20:25:21] ^ kikero in case you missed [20:25:49] hmm [20:25:54] I'd want something quick and dirty [20:26:02] I only need it for three languages, not for all of them [20:26:20] Now, I guess it would be nice to have such a functionality full blown [20:26:21] :-) [20:29:13] kikero: you know there is user js? [20:29:19] e.g. User:kikero/minerva.js [20:29:25] you could explore using that [20:29:43] hmm [20:29:45] good point [20:30:58] yuvipanda: the only other reference to bits.wikimedia.org is some static content we have up there [20:31:09] yup, that needs to switch too, I think [20:31:10] i think its a mapping of main pages to languages..? [20:31:28] I think it’s the CSS from Extension:MobileApp [20:31:40] languages to mainpages mapping should come from somewhere else, not bits, IIRC [20:31:47] yuvipanda: hrm, IIRC we're not updating that in the app anymore [20:31:59] bgerstle: oh, in that case sure, you don’t need it. [20:32:19] yuvipanda: actually, it's not CSS [20:32:24] hey FlorianSW :) [20:32:29] the full URL is: https://bits.wikimedia.org/static-current/extensions/MobileApp/config/ios.json [20:32:32] getting excited about Lyon? :) [20:32:36] something about a config? [20:32:47] yes, that’s a config [20:32:51] the config [20:33:06] look at the android patch to see how it was replaced. [20:33:59] kaity: hey, what do you think about my comment at https://phabricator.wikimedia.org/T96317? [20:34:08] yuvipanda: have a link? [20:34:25] yuvipanda: this one? https://gerrit.wikimedia.org/r/#/c/208315/ [20:34:47] bgerstle: yep: RemoteConfigRefreshTask.java [20:35:01] bmansurov: i'm not sure i understand that comment... why can't you do the icon like that? [20:35:17] jdlrobson2: because there is a requirement for icons to be tappable [20:35:29] tappable? [20:35:51] jdlrobson2: the tapping area needs to be no less than certain pixels [20:36:00] (and i don't see that in the description so it's hard to follow) [20:36:00] yuvipanda: looks like the JSON's up there [20:36:04] will amend.. [20:36:12] jdlrobson2: what don't you see in description? [20:36:24] bmansurov: anything about 'tappable' [20:36:45] but you can create a div of any size that has a click behaviour bound to it no? [20:36:46] jdlrobson2: oh, there is a conversation about somewhere [20:36:49] the icon can be inside that div [20:36:58] bgerstle: cool [20:37:24] jdlrobson2: i'm not worried about implementation, i'm worried about the icon having large enough width [20:38:27] i'm still confused.. :-/ [20:39:13] kaldari: what's that new apple styleguide called? it's for icons to be at least a certain width and height. [20:39:44] Apple Human Interface Guidelines [20:40:23] yes, thanks [20:40:30] jdlrobson2: ^ [20:40:36] i'm not sure how that helps.. [20:40:54] jdlrobson2: ok, so right now there is some space on the left of the hamburger right? [20:41:00] i'm still as lost as i was at the beginning of this conversation :) [20:41:02] yeh... [20:41:02] jdlrobson2: which allows users to tap [20:41:14] jdlrobson2: the new design suggests we remove it [20:41:22] jdlrobson2: which will leave less space to tap on [20:41:34] jdlrobson2: makes sense? [20:41:36] nope. [20:41:46] but
{{>icon}}
$('.clickable').on( 'click' [20:41:54] bearND: if you are around, I am going to deploy a dummy jenkins job for the android app :D [20:42:28] jdlrobson2: i don't quite follow, why are we talking JS here? [20:43:30] i guess i just dont understand what you are trying to do and why you think you can't do it. but to me a tappable area is just using box model css [20:43:38] whether it's via JS or a link you style to be bigger [20:43:56] our icons don't come with any restrictions other than they have to be in svg and be consistent in their size [20:44:04] and be built in the same way [20:44:32] jdlrobson2: hmm, I'm not sure how to explain it better [20:44:50] jdlrobson2: less space = less tappable area [20:45:09] what does less space mean though? [20:45:19] padding gives you space but doesn't take away tappable area [20:45:27] is the icon shrinking? [20:45:29] jdlrobson2: maybe you're not looking at the new design, let me get the link [20:45:37] jdlrobson2: https://phabricator.wikimedia.org/T96317 [20:45:46] jdlrobson2: 2nd screenshot [20:45:56] yeh that's what im looking at.. [20:46:10] the hamburger is exactly the same size to me [20:46:15] it's just got a margin now [20:46:21] that's what i'm not understanding [20:46:30] jdlrobson2: you're missing the padding [20:46:40] jdlrobson2: in the first screenshot, there is padding too [20:46:53] jdlrobson2: in the new design there is padding on all sides but the left [20:47:01] jdlrobson2: in the old design there is padding on all sides [20:47:22] i'm lost.. i don't see any issues with either of these designs... do you understand the problem kaldari ? [20:48:15] jdlrobson2: http://6f1f7eb0.ngrok.com/w/index.php?title=1&mobileaction=toggle_view_mobile [20:48:23] jdlrobson2: do you see the issue on that page? [20:48:51] jdlrobson2: look at the position of the hamburger icon relative to the edge of the page [20:49:21] move it left(?) [20:49:31] change the svg [20:49:41] it's an implementation detail. you've got plenty of options [20:49:46] jdlrobson2: to what? [20:49:52] jdlrobson2: we're keeping the icon size the same [20:50:33] niedzielski: i heard you were having issues with the Checkstyle-IDEA plugin like I was. Did you ever get it working? I ended up just going back to the previous version. [20:51:01] why can't just give .header padding-left of 2.2em? [20:51:14] hmm [20:51:15] also [20:51:17] mholloway: now you're mholloway? quit playing games with my heart! [20:51:21] I asked this yesterday, I think. [20:51:26] niedzielski: It's Complicated [20:51:34] kristenlans, joakino: dear phabricator power users, there is a button in each Phab ticket that says 'Flag for later'. After you flag a task for later, how do you actually find it? i.e. how do you pull up your flagged tasks?? [20:51:38] jdlrobson2: it's not about the header, it's about the hamburger icon losing tappable area [20:51:46] So, I'd like to have a mobile app for one of the wikis I run. [20:52:14] i still don't see the problem.. but you'll work it out. [20:52:30] I've been able to find a fork of the PhoneGap app on github that documented the use of another mediawiki server [20:52:33] but that's 2012 [20:52:40] jdlrobson2: wait, you suggested plenty of options, please give me one [20:52:51] and I couldn't make that run after cloud building it [20:53:04] mholloway: no, i'm on the beta or dev / alpha channel of android studio and checkstyle seems to be forcefully keyed to the prod version :/ i didn't look into it much [20:53:14] well you can put the icon inside a link for one [20:53:19] and style the link however the heck you want to [20:53:21] niedzielski: actually i got dropped off earlier as mdholloway, have yet to sign back in with that nick since it timed out [20:53:38] jdlrobson2: so much for standardization, also that doesn't solve the problem [20:53:50] mholloway: i run ./gradlew checkstyle manually (before i push to gerrit when i remember) [20:53:55] how is that not standardisation? [20:54:08] rather what has that got to do with standardisation? [20:54:15] it's just an icon. [20:54:26] niedzielski: cool, thanks, just wanted to see if you had any neater solution since I was thinking about it. [20:54:31] jdlrobson2: all I'm saying is that the design is not following the guidelines, and we shouldn't be creating specific solutions [20:54:32] the icon is the same size as every other icon and built in the same way [20:54:39] it's a lego block [20:54:56] mholloway: the only weirdness i've seen running from command line is that it only seems to work from the project root. i can't be in the wikipedia subdir, for example [20:55:03] jdlrobson2: yes, but there is a 1em padding on the sides of the icon, which makes it tappable outside the image [20:55:15] jdlrobson2: removing that tappable area isn't good [20:55:20] niedzielski: makes sense [20:55:24] i'm not saying removing that tappable area [20:55:27] mholloway: if you end up getting it working on the "more eager" versions of android studio, i'd love to hear about it [20:55:36] jdlrobson2: but the design says to remove it [20:55:50] sorry.. i've got other stuff to do... i'm still really confused but maybe talk to Sam about it tomorrow [20:56:19] jdlrobson2: ok thanks [20:56:30] and it would help if the bug was clearer because i don't see anything about removing tap area so it's making this conversation more confusing then it needs to be [20:56:55] jdlrobson2: it's clear on the screenshot, not sure how it can get clearer. [20:57:21] bearND: and the first ever build succeeded! https://integration.wikimedia.org/ci/job/apps-android-wikipedia-gradlew/1/console [20:57:52] kaldari that is a great question. I have NFI. I just cruised around Phab a bit to see if I could find where I woudl see "flagged" stuff, and I foudn nothing. Not even an advacned search filed. I can ask Quim adn Andre abotu it. [20:59:16] hashar: bearND: nice! [20:59:47] hashar: \o/; excellent! :) You can archive the resulting apk: wikipedia/build/outputs/apk/wikipedia-alpha-debug.apk [20:59:57] kristenlans: I'll try asking Quim [21:00:25] kaldari cool, let me knwo if you discover that it's some rad feature! [21:00:34] bearND: woah, awesome :) does this mean we can get rid of the server hosting the alpha builds? [21:01:27] jdlrobson2, bmansurov I'm confused about what's confusing :) Aren't we just confining the header to a certain width? [21:01:59] yuvipanda: not until we've got the equivalent way of static URL to download the latest apk [21:02:12] yuvipanda: but it's getting closer [21:02:14] kaldari: yes we are but there is a nuance, which is the hamburger icon's left padding is gone in the new design [21:02:20] bearND: :) sweet [21:03:34] kaldari: i thought icons should be large enough to be tappable, it looks like this is an exception [21:03:54] hashar: I'm super excited about this. hehe :) [21:04:51] bearND: since the job pass should we just add it to run on patch proposal and +2 ? [21:05:51] bearND: the CI config is quite simple https://gerrit.wikimedia.org/r/210197 :D [21:06:07] bmansurov: Ah, I see what you mean [21:06:51] bmansurov: that seems like it might be a bad idea [21:06:59] Yes. It would be great to split both commands into their own Jenkins build tasks and do the proper results archiving. The checktyle task should replace the current apps-android-wikipedia-maven-checkstyle task. The other command is a new one that should be hooked up, and provide the apk as result. [21:07:06] kaldari: i know ;) [21:07:16] kaity: ^ [21:07:58] hashar: So, for the checkstyle task it should hook into Jenkins reports, or whatever it's called (like in https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/4286/checkstyleResult/) [21:08:33] kaldari: whatsup? you guys talking about humburger icon? [21:09:09] kaity: yeah... [21:10:01] bearND: any idea where the checkstyle Junit xml file is generated to ? [21:10:06] uhh, jdlrobson2, haven't seen your ping :/ hi! :) [21:10:12] bearND: for maven we had to pass -Dcheckstyle.config.location=$WORKSPACE/checkstyle.xml [21:10:37] hashar: should be under wikipedia/build/outputs somewhere. [21:10:41] bmansurov: kaldari is there any way to keep tappable area while visually aligning the icon to content below? [21:10:42] kaity: So I was initially thinking that the new max-width header was a simple matter of setting the max-width to the same width as the content, but there is a question of whether we are cutting off the whitespace on the left side of the hamburger button or not. [21:10:46] bearND: looking [21:11:16] kaity: yes, we can do that [21:11:35] we were thinking it might be a bad idea to cut off the whitespace because it will make the tappable area even smaller than it already is [21:12:08] hashar: I don't think we need the env var anymore for the Gradle checkstyle task [21:12:14] kaity: yes, we could do that [21:12:52] kaldari: bmansurov cool [21:12:55] kaity: Should we also do that with the notifications bell? [21:13:01] kaldari: yes [21:13:13] kaity: great, thanks! [21:13:22] thank kaldari ;) [21:13:23] s [21:13:27] bmansurov: thanks! you guys are awesome [21:13:59] kaity: Thanks for being so responsive on IRC, unlike certain people who won't be named ;) [21:14:21] hashar: checkstyle report is in wikipedia/build/reports/checkstyle/checkstyle.xml [21:15:36] hashar: BTW, I would recommend to use a variable for the "wikipedia" subfolder. I think we might change it in the future to "app" to be more consistent to the standard Gradle layout [21:16:33] bearND: I am going for a wildcard :) [21:16:47] hashar: great [21:23:41] bearND: I made it to run 'clean', then 'checkstyle' and finally 'assembleAlphaDebug' [21:23:50] https://integration.wikimedia.org/ci/job/apps-android-wikipedia-gradlew/2/console [21:27:32] bearND: too late for me, will let you review it overnight and merge it in tomorrow :} https://gerrit.wikimedia.org/r/#/c/210197/ [21:27:38] bearND: congratulations! [21:27:58] hashar: Sounds good. Thank you very much! That's a great start. [21:29:26] bearND: make sure to review my copy paste of your good findings :} [21:29:55] this way I can follow up when I wake up tomorrow [21:30:44] hashar: Thanks. I'll add my comments to the Phab task [21:39:27] have a good afternoon :) [21:42:28] bearND: did you guys change your event logging URL? [21:43:24] coreyfloyd: we have a patch for this from yuvipanda (https://gerrit.wikimedia.org/r/#/c/208315/) , but it's not merged yet [21:43:45] bearND: how do you verify that it goes into the production DB? [21:43:46] coreyfloyd: last time I checked the iOS patch pointed to a different URL [21:43:53] can you log into another labs instance? [21:44:49] bearND: looks like they are the same URL now [21:44:58] coreyfloyd: that's a great question I currently don't know the answer to. I hope nuria, yuvipanda, and/or ori might have some answers [21:45:05] coreyfloyd: ah, good [21:45:20] bearND: so can we use the same instructions to verify events in the production db? [21:45:44] bearND: i didn’t want to merge unless we knew it worked [21:46:21] coreyfloyd: you mean as the one I send out a while ago? I doubt it. I believe this is a test instance only [21:46:24] bearND: or do we kinda just switch it out on faith™? [21:46:31] coreyfloyd: nooo [21:46:40] bearND: lol [21:46:56] bearND: so hmmm… ok - we need to see whats in the prod db then… thinking… [21:47:09] * bearND summons the great yuvipanda [21:47:30] maybe that'll work ;) [21:50:59] coreyfloyd: i'll check in analytics [21:52:53] lol [21:53:09] bearND: thanks… i’m also pinging ori int he other room… [22:00:43] bearND: do you have access to the production DB? [22:03:12] jdlrobson2: i saw the note that making the meeting tomorrow is going to be tricky for you... [22:03:33] kristenlans: i think i've worked it out :-/ [22:03:37] (the "Q4 Reading Web Engineering, Part 3", that is) [22:03:42] got myself a friends office in London [22:03:43] jdlrobson2: oh cool! [22:03:48] so should be okay for that but may need to leave early [22:03:48] high five [22:03:51] and not sure what wifi will be like [22:03:55] can't make retro though [22:03:56] will send notes [22:04:14] 10-4 sounds good. Can't wait until we're all together IRL! [22:06:40] coreyfloyd: looks like leila might have some information when she's done with her meeting in about an hour, but that'll probably be too late for me (already past midnight for me). IT would be good for you to join the analytics channel. [22:10:52] bearND: i got adam to help for now… will let you know how it goes, thanks [22:11:14] mhurd: link me to the bug when done? [22:11:21] bearND: was in a meeting with mhurd [22:11:25] looks like you guys have it covered [22:11:33] yuvipanda: will do! [22:11:38] yuvipanda: thanks [22:11:56] mhurd: it could be a nice hackathon project if you can nerdsnipe someone, btw [22:12:10] yuvipanda: ooh good idea :) [22:12:46] jdlrobson2: Would be good for you to double-check this before it is merged: https://gerrit.wikimedia.org/r/#/c/209849/ [22:14:36] btw that #mw-mf-main-menu-button, .alpha .header a.header icon, .alpha .header .header-title a selector is nasty [22:14:52] and also shouldn't be in stable.. [22:15:53] mhurd: good luck :) I would suggest FlorianSW but I bet jdlrobson2 already has him covered :) [22:16:31] kaldari haven't tested but it looks fine apart from the alpha selector messiness [22:16:48] (We really need to be more vigilant about this sort of thing) [22:17:25] yuvipanda: what what what what what? :D (i haven't read all messages here, i suspect) :) mhurd [22:18:31] kristenlans: are you the owner of the story prioritization meetings for gather and/or mobile web? [22:19:37] Not gather, mobile web yes [22:19:55] jhobs: ^ [22:20:54] kristenlans could you add me to the next one? Part of my yearly goals involves learning more about the design process and kaity suggested I attend one or more of the prioritization meetings [22:24:34] jhobs: nice goal! You are now added to the invite [22:24:50] kristenlans: thanks! [22:25:58] kaity: was the gap always that big? http://imgur.com/OkOT7BZ [22:26:04] between menu items? [22:31:44] coreyfloyd: wanna join #wikimedia-analytics? [23:08:40] dr0ptp4kt: did we say we're going to unstructure sprints during the hackathon period? [23:11:57] kristenlans: i don't recall. but that seems like a good idea to me. that first week of the sprint is going to be pretty hard for scheduling. [23:13:25] Yeah, I'm looking at the time off spreadsheet and it's feeling like unstructuredness is the right thing to do. [23:13:30] dr0ptp4kt: ^ [23:13:48] dr0ptp4kt: I can communicate that to various techpros and propros [23:14:54] kristenlans: sounds good [23:22:03] \o night all [23:40:28] mhurd: when that phab task on image info is created, would you please add it to https://www.mediawiki.org/wiki/Wikimedia_Reading/Mobile_needs_from_MediaWiki_API ? cc coreyfloyd [23:40:42] dr0ptp4kt: ya [23:40:46] mhurd: thx [23:59:13] JonKatz: http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:TopicTag/San_Francisco_landmarks