[08:55:58] morning [08:56:49] morning [08:58:29] phedx: you ate a U? [08:58:30] xD [08:58:43] * phedx sighs [08:58:58] * phuedx wonders if jdlrobson is about [10:24:46] phuedx: yer there? [10:25:15] joakino: yeah [10:26:03] phuedx: so, i've been testing testwiki, and found a bug [10:26:14] congratulations! [10:26:48] phuedx: and i've a patch, what are the next steps to avoid it getting into enwiki, email reading asking for halp? https://phabricator.wikimedia.org/T98947 [10:26:50] lol [10:27:29] phuedx: i mean, okay, we've got that day on test wiki, what's next when we find a bug and want to fix it [10:28:17] joakino: escalate its review and backport it [10:28:48] phuedx: that'd be an email to the appropiate fellas [10:28:53] i guess [10:29:07] joakino: i guess -- but shout out on reading-l if necessary [10:32:10] phuedx: have you seen this? https://github.com/cirla/vim-giphy so awesome [10:32:29] oh [10:32:31] my [10:32:32] god [10:36:56] brr seems like giphy has blocked google bots and now you can't embed the image from their url on gmail messages [10:50:49] i /sincerely/ recommend that you take 11 minutes out of your day to watch this: http://www.theverge.com/tldr/2015/5/11/8587941/jetpacks-yves-rossy-dubai-balloon-boy [12:01:59] out for lunch [13:09:46] dbrant: Morning! Have you given any thought to the page metadata classes re: the "read more" task, or should I grab a different card for now? [13:10:52] mdholloway: so, is the EL patch ready to go? [13:11:04] dbrant: yep! [13:11:39] dbrant: did you see the discussion last night about the EL server being out of commission? [13:11:48] yep, i did [13:16:57] \o/ [13:17:27] like passing a kidney stone, right? [13:17:47] ha! luckily that is one experience i've not had [13:23:00] bearND: is this ready to merge, then: https://gerrit.wikimedia.org/r/205976 [13:28:07] mdholloway: standby on the Page classes for a bit... I'd like to get bearND's opinion on this before we commit to it. [13:28:36] dbrant: sounds good [13:46:06] mdholloway: in the meantime, there's an interesting bug that I just found... [13:47:58] mdholloway: make sure link previews are enabled, and then: go to any page, then turn off the screen, then turn it back on. You'll see multiple link-preview dialogs on top of each other, corresponding to every link that's currently on the screen. [13:48:51] dbrant: huh. i'll check it out. [13:53:57] dbrant: the behavior on my tablet is a little different. [13:54:19] mdholloway: I think I know what's going on: [13:54:26] when i go to a page via a link preview, turn off the screen, and turn it back on, the link preview for the page will appear every time [13:54:35] but if i change the screen orientation , this no longer happens [13:55:09] mdholloway: when you overrode the onDismiss function, you forgot to call super.onDismiss(). [13:55:24] aha. [13:55:56] mdholloway: let's patch that up real quick [13:56:03] dbrant: i'm on it. [13:59:05] dbrant: https://gerrit.wikimedia.org/r/#/c/210689/ [14:39:25] FlorianSW: so the closewindow patch is now merged in all the repos ? [14:41:35] dbrant: yes, https://gerrit.wikimedia.org/r/#/c/205976/ is ready to be merged [14:44:05] thedj unfortunately no :/ I left a comment on https://gerrit.wikimedia.org/r/#/c/207445/ (UploadWizard) [14:44:34] thedj: and MF isn't merged, too (https://gerrit.wikimedia.org/r/#/c/200179/), but allowCloseWindow is introduced in that patch, so this wouldn't need a cherry pick [14:45:25] ah. [14:46:54] thedj: can you take a look at the UW change? It's relatively small patch :] [14:49:30] FlorianSW: assert.ok( !acwStub.called ); [14:49:34] that doesn't seem right. [14:49:42] since acwStub is now an object... [14:50:03] * thedj not entirely sure how the stubs work though. [14:50:27] thedj: argh, you're right, i missed that one :] [14:50:49] that's why we have review :) [14:51:34] seems a bit dangerious to replace the stub with an object btw. [14:51:58] thedj: why? [14:52:16] thedj: * why is it dangerious ;) Code-Review is goo :) [14:52:32] because the code can now in tehory also trigger [14:52:42] and you don't have a stub for trigger. [14:53:24] that shouldn't be a problem, because we don't extend the originally returned object, we replace it with the one, which only have release? [14:53:32] but probably not too bad. shouldn't affect behavior [14:55:12] dbrant: you mentioned earlier that you wanted my opinion about something but i don't know what it was [14:56:23] bearND: would you want to get on batcave for a minute? [14:56:45] dbrant: owm [14:56:55] mdholloway ^ [14:57:00] omw! [15:03:41] hashar: ah, you're on wikimedia-mobile :D [15:03:57] ah great :} [15:04:26] FlorianSW: come to #wikimedia-releng and we can finish up the npm/composer stuff together :} [15:18:45] hey joakino phuedx [15:22:49] hey FlorianSW [15:22:55] FlorianSW: +2'ed [15:23:23] jdlrobson: hi! :) thedj: great, thanks! :D [15:23:34] hey thedj :) [15:23:42] looking forward to seeing you in Lyon! :) [15:25:45] hey jdlrobson [15:25:58] jdlrobson: yup. gonna be nice. [15:26:10] dbrant: bearND: PageTitle/PageQueryTask refactoring patch: https://gerrit.wikimedia.org/r/#/c/210700/ [15:29:58] phuedx: I'm en route to Europe with my Aeropress packed. Let the coffee games begin! [15:30:12] jdlrobson: also. gonna have to be my fix this year, because no Wikimania :( [15:30:17] kristenlans: i will be bringing my v60 and my aeropress [15:30:30] i shall also be bringing beans roasted in london and germany [15:30:37] the board is set… [15:32:32] phuedx I do not have my beans selected, but I will be scanning Stockholm for somethign to give me the competitive edge. [15:42:07] thedj: :( [15:42:14] we're get some beers [15:42:20] kristenlans: i'm gonna have to steal that aeropress [15:42:23] left mine at home [15:42:31] very foolishly [15:43:36] kristenlans: http://www.ozonecoffee.co.uk/shop/kenya-githiga-aa/ are going to blow your mind [15:45:45] jdlrobson: we can totally share aeropress [15:46:17] we may want to consider asking aeropress to sponsor the next hackathon :P [15:51:48] jdlrobson: love you "If you want them to go away, rather then setting up a gmail filter/ignoring [15:51:51] it, for the good of everyone on this list let's fix these bugs:" [15:51:55] :) [15:52:11] greg-g: i thought i'd get that in before people do.. [15:52:16] :) [15:52:31] we should probably split the builds up at some point but getting them passing would be a good first step [15:53:04] * greg-g nods [16:16:50] jdlrobson: I can pack my aeropress as well. Who is packing a grinder? [16:17:36] phuedx: I'm sure you have a hand crank, right? [16:17:48] i've got two [16:17:51] want me to pack 'em both? [16:17:55] actually, three [16:17:59] all of 'em? [16:18:13] ping jdlrobson [16:18:16] meetinz [16:34:01] hallo [16:34:14] phuedx: lol. Of course you do. [16:35:21] phuedx: is anyone bring while beans? [16:35:31] While = fresh [16:35:32] whole [16:35:34] ? [16:35:38] fresh [16:35:38] Whole [16:35:49] yeah -- i'll be bringing ~1kg [16:35:57] Fresh whole beans. All thumbs [16:36:09] Whoa! [16:36:12] that should be enough for a day and maybe a day and a half [16:36:43] Lol. For the entire conference? [16:38:02] 24 hours, 1 cup every 4 hours, 18~19g a cup = 108-114g of coffee per day -- how many people are in? :D [16:38:16] how many people /need/ sleep? [16:38:18] be careful with war in europe, i read it in the slides of the lyon preparation [16:38:30] i mean /really/ need sleep [16:39:49] https://media1.giphy.com/media/11JcW2YJ36the/200.gif [16:41:55] greg-g: iOS app is approved. Going to flip the switch. Should trickle out over the next 4 hours or so. [16:43:55] JonKatz: iOS app is approved. Flipping switch to release. [16:50:04] coreyfloyd: coolio [16:50:13] coreyfloyd awesome! [17:04:29] yo jdlrobson regarding https://gerrit.wikimedia.org/r/#/c/210668/1/resources/ext.gather.init/init.js [17:04:44] yup [17:04:51] jdlrobson: that selector was used in the appendTo before, i just moved it up. i agree it is brittle [17:05:00] but didn't introduce it, it was there [17:05:27] sure, what do you think about using once though? [17:05:31] jdlrobson: the once doesn't seem good, since if you click anywhere the CTA disappears, i think it should reappear if you create another collection [17:05:58] is that a problem though? do we need reminding each time? seems kinda spammy no? [17:06:01] i'm fine either way though [17:06:12] happy to merge it just seemed like it would be more straightforward [17:06:37] jdlrobson: we could target just the class of the menu item .collection-menu- [17:06:37] item without the #mw-mf-page-left [17:06:48] you can also use mainMenu [17:07:04] jdlrobson: module? [17:07:18] M.require( 'mainMenu' ).$( '.collection-menu-item' ) [17:07:34] but as you said you didnt add that :) [17:07:40] i think i did [17:07:43] the main menu is a pain [17:07:51] anyway should i merge as is? [17:09:00] jdlrobson: i think for the purposes of the fix it is good enough, i didn't want to change behaviour (about the spammy cta) [17:09:30] jdlrobson: I can change it however you want though, i just want the brokenness to not appear [17:09:41] the once could work, yep [17:09:54] i'll merge we'll resolve it later [17:10:55] jdlrobson: about the other comment, I agree, using a global event is the only way I found for the content overlay and the edit overlay to comunicate (since we trigger the edit overlay via URL change) [17:10:58] https://gerrit.wikimedia.org/r/#/c/210668/1/resources/ext.gather.watchstar/CollectionsContentOverlay.js [17:11:36] i'd love to not use the url for that and open the edit overlay from the content overlay and listen to an event of it, or something more direct like that [17:12:11] bearND: are you going to SOS? [17:12:54] phuedx: are you going? ^ [17:13:07] would be nice if adam could just rep us at SOS and save the 3 of us the trouble [17:13:14] seeing as we just had that other meeting [17:14:21] bgerstle: i wasn't planning on it. [17:14:35] bgerstle: but we have our standup coming up now [17:14:49] yep [17:16:30] yeah [17:20:18] bgerstle: i dunno -- should we ping adam? [17:21:30] i'd like to [17:21:39] i don't see him online, and i have standup right now [17:21:47] phuedx: would you mind hunting him down? [17:25:23] bgerstle: emailed him -- not sure what his nick is [17:25:34] dr0ptp4kt [17:25:37] he's not online [17:29:13] bgerstle: could just email in an update [17:29:24] phuedx: maybe? [17:29:28] i'll go [17:29:40] phuedx: you can also just edit the etherpad [17:30:19] bgerstle: if you do, then there ain't much to report: gather has been released to hebrew wikipedia and wikivoyage [17:30:29] cool [17:30:47] the browse prototype is enabled on beta and being signed off and tested [17:31:16] we'll be looking at our testing infrastructure and developer happiness more hopefully [17:31:18] eom [17:32:19] best captcha ever: http://jonrobson.me.uk/watttt.mov [17:32:35] phuedx hey! i'm here on european time now too [17:32:44] kaity: woo! [17:32:54] \o kaity [17:32:58] so europe is now firmly in the majority [17:33:00] kaity: where are you [17:33:04] so meetings at 10 am gmt!? [17:33:11] you gonna fly and meet joakino and i in Barcelona? [17:33:19] Im in Paris early for the hackathon! [17:33:32] jdlrobson: when are you in barcelona? [17:34:18] phuedx: ya its weird to have meetings at 10pm [17:34:52] kaity: tomorrow [17:36:18] phuedx: we still meeting for story prioritization? [17:36:59] jdlrobson: oooh I wana go! How long are you there for? [17:37:06] until sunday [17:38:43] kaity: at 9 apparently :/ [17:38:56] jdlrobson: are you staying with joakino? or airbnb? [17:41:44] kaity: staying with my friend who lives there [17:42:21] meeting joakino there and he's staying too [17:42:43] wohoo [17:48:34] jdlrobson: aw wish I could join you guys! probably too last minute now [17:53:45] it's around 300 bucks friday to sunday right now [17:54:34] only if she flies back sunday.. :) [17:55:04] 36GBP to fly on Friday kaity :) [17:55:20] with ryanair [17:55:28] just don't get a return [17:56:30] jdlrobson: im meeting moiz in Paris sunday and then Nirzar n Vibha arrive a couple days after [17:56:57] hmm but I dont know anyone here now and Ive always wanted to see Barcelona [18:00:16] is the wikigrok meeting happening? am i in right room? [18:00:24] paris sucks kaity [18:00:33] :P [18:00:41] barcelona is much cooler [18:00:59] (playing devil on your shoulder) [18:02:56] JonKatz: stuck in customer service hell [18:05:01] mdholloway: hey could you point me toward the relevant image width commit(s)? [18:05:25] kaldari I'm stuck in something too. 11:10? [18:06:34] mhurd: sure, one sec [18:07:28] mhurd: https://gerrit.wikimedia.org/r/#/c/209588/ [18:07:46] jdlrobson: hmmmm is there any space where you're staying? [18:07:53] mhurd: https://gerrit.wikimedia.org/r/#/c/205649/ [18:08:14] mhurd: ^ bearND|food is currently reviewing [18:08:21] mdholloway: ah thanks!!! [18:08:58] mhurd: happy to chat anytime if you have ideas, suggestions, etc.! [18:09:08] kaity: i can let you know tomorrow [18:09:16] i have another friend in barca who might have space too [18:09:26] mhurd: or questions, or just want to talk something over [18:09:55] http://etherpad.wikimedia.org/p/wikigroknextsteps [18:12:02] mdholloway: could i suggest you not name these files with "-android" in case we on iOS want to use them too? [18:12:44] mhurd: sure, easy enough to change [18:26:05] mdholloway: dbrant|food niedzielski : I'm thinking we should postpone merging https://gerrit.wikimedia.org/r/#/c/205649/ until after a release build is cut. I'd like to give it some time in alpha, mainly because it also modifies the images on the main page. [18:26:21] yo i'm leaving [18:26:40] bearND: +1 [18:27:06] jdlrobson: rmoen: can we get this https://phabricator.wikimedia.org/T98947 backported so that the bug doesn't end up on enwiki? [18:27:08] somehow? [18:27:13] joakino: looking [18:27:27] otherwise i'm going to have to ask why do we have the testing day on test wiki now xD [18:27:39] :) [18:27:52] jdlrobson: anyway it's probably an old bug just recently noticed [18:28:02] (old being a week or 2 [18:28:04] joakino: yeh it's not the end of the day if it gets on there [18:28:16] i suspect few people will hit it [18:28:21] yerp [18:28:28] bearND: i think this was started before i had my accounts all setup. but that sounds good. just added myself to ye old review but can't imagine i'd hold any objections [18:29:00] alright i'm leaving [18:29:11] have a nice day! [18:30:11] bearND: dbrant|food: no objection here. [18:32:20] jdlrobson: if you don't publish the data, then how can we help? [18:44:07] jdlrobson, we can schedule https://gerrit.wikimedia.org/r/#/c/210668/ for swat if it is not already in wmf5 [18:44:12] going afk until next meeting [18:44:18] cooking and chores and whatnot [18:46:35] niedzielski: do you know of a device on which the 180 degree rotation works? [18:48:06] bearND: it seems to work on all my api 18+ devices. does Photos / twitter / g+ work in upside down for you? [18:51:12] niedzielski: no, it doesn't (Nexus 4) [18:51:28] niedzielski: what's one of the devices? [18:51:43] bearND: LG Ultimate 2 [18:53:01] bearND: hm, sorry i seriously misspoke. none of those apps seem to be working in upside down mode on this device :/ that said, the wikipedia patch works fine on it [18:53:38] bearND: let me check my Note 2 too [18:55:29] Australian mode [18:55:37] Dmitry can test, with his experience [18:57:27] bearND: note 2 works fine with patched apk but not with photos [18:58:07] bearND: i think my nexus 7 with cyanogenmod must be augmenting app support [18:58:50] bearND: unfortunately, AFAIK, you can't test this in the emulators [18:59:00] Deskana: lol [19:05:44] vibha: hey! do you recall what page this is in your screenshot here: https://phabricator.wikimedia.org/T95365 [19:27:31] phuedx: sorry was at dinner. yeh i'll post something to mailing list by end of day [19:27:35] (US day) [19:28:02] rmoen: ok awesome. We should check with JK if he wants us to [19:28:15] and FYI I don't really want to hang around post 4pm PST since i have to get up early tomorrow [19:59:53] etonkovidova: hi! [20:00:03] bgerstle: hello! [20:00:19] so, we just cut a build for another app update. 4.1.4.1232 [20:00:22] 4.1.4.123* [20:00:36] do you want to sync quickly about test cases before i send to TSG for regression testing? [20:01:00] mainly, i want to make sure we have documented cases for lead image & share a fact [20:01:54] bgerstle: you want TSG test specific test cases that are on our spreadsheet? [20:02:07] i want to make sure that the tests cases we send to TSG have what we want [20:02:15] which, IMO, should include regressions for lead image & share a fact [20:02:33] i want to make sure everything you think should be there is documented, and that it fits nicely w/ the tests you'll run yourself [20:02:43] bgrestle: right - can you give me a link to it so I can take a look? [20:03:55] sorry just saw this message, but i see you found it [20:03:56] bgrestle: I have this one: https://docs.google.com/spreadsheets/d/1BEZ8WZm9mtHmozsk9aQ1s5c7mmjgntkmuBnx8tA1Q_A/edit#gid=0 [20:05:31] etonkovidova: that's right [20:07:29] bgrestle: TSG have general test cases for Image Gallery. Hmm.. should we add references to specific articles? let me think [20:07:49] etonkovidova: probably? might be better for consistency and to make sure certain edge cases are covered [20:08:12] bgerstle: right right [20:08:17] also, etonkovidova you can get the app here: https://rink.hockeyapp.net/apps/78e94cb597309a55d5bb99c839aa18a8/app_versions/1 [20:08:38] should be the same as the alpha, but you can use that to overwrite the app store version for migration testing [20:11:14] bgerstle: good -will try that. [20:12:01] kaity: while you're here i want to ping you about T94646. Do you have any feedback on the apk I sent last friday? Hopefully most or all of the miscellaneous issues are ironed out by now. [20:14:40] bgerstle: And RTL test case 18 "... table with images is on the left." - is true only for 'Read more' section [20:15:02] bgerstle: hmm... the above - looks like a bug for RTL [20:15:33] i think the tester should set their device language/region for this case [20:15:38] not the reading language [20:16:01] dbrant: mdholloway: fyi, I'm planning to pull the image-width patch into this release after all; sine I've learned that it doesn't affect the main page [20:16:35] bgerstle: ok [20:16:57] bearND: cool. [20:17:00] bgerstle: test case 18 should be corrected [20:19:09] bgerstle; I would rather delete "and table with images is on the left." OR apply to the Main page [20:19:20] etonkovidova: do whichever you think is best [20:19:25] kaity can you provide a mock for how people can close this overlay? (my gut is a button in top right...) https://phabricator.wikimedia.org/T98293 [20:19:43] bgerstle: ok [20:20:03] JonKatz: ya upper right makes sense, i'l add mock [20:20:09] mdholloway: oh, wait. There's an outstanding question from niedzielski in that patch that probably should be answered first. [20:22:28] bearND|brb: on the boolean thing in writeToParcel? Seems fine to me unless there's some reason isMainPage (which I was following) was done as writeInt instead (cc niedzielski) [20:23:18] etonkovidova: i'm also having trouble writing test cases for offline mode [20:23:19] in a way that would also apply to isDisambigutationPage [20:23:49] bgerstle: such cases should be added too? I can do it [20:23:53] I guess I'll dig a bit since you'll brb [20:23:53] mdholloway: my mistake-- there is no Parcel.writeBoolean() [20:24:01] bgerstle: when do you need them? [20:24:02] ah, ok [20:24:21] cool [20:24:29] etonkovidova: i'd like to send to TSG asap, the build is ready to go [20:25:04] etonkovidova: we can send the build now and they can start on the cases that are already defined, but i figured it would be simpler if we prepared everything up front [20:25:09] mdholloway: but i think bearND|brb is actually talking about this patch: https://gerrit.wikimedia.org/r/#/c/205649/17/wikipedia/assets/bundle.js [20:25:15] niedzielski: i'm not sure whether bearND|brb was favoring or disfavoring your suggested change [20:25:38] niedzielski: ah, didn't see that one, thanks [20:25:54] bgerstle: sigh... I have a 30-min meeting right now [20:25:57] mdholloway: for the JSONObject? that wasn't quite clear to me either but i think he recommends your approach [20:26:16] etonkovidova: ok, what do you think we should do? [20:26:39] the app is already waiting for review from apple [20:26:45] niedzielski: yeah, i was referring to the JSONObject issue [20:26:54] bgerstle: what about 2:30? It should take not more than 30 min to write them [20:27:10] etonkovidova: i'll send you the email w/ the link to the app [20:27:23] nevermind [20:27:28] bgerstle: :) [20:27:30] etonkovidova: just let me know when the test cases are aready [20:27:37] and i'll take it from there [20:27:44] bgerstle: sure [20:28:29] dbrant: did you work on the share a fact implementation? i hadn't really played around with it too much before working on this tutorial task but thought i should mention, now that i know it a bit better that, it's a really great feature! [20:30:50] niedzielski: bearND did the bulk of the implementation on that one. And I agree it's pretty cool! [20:34:04] * bgerstle etonkovidova: i'll just send the TSG email tomorrow. we can talk later about how to make this process smoother in the future. you have until EOD to update the iOS test cases. let me know if you think you need more time. [20:34:26] dbrant: in general, i find the sharing experience in android apps a pretty awesome feature. i wish chrome for desktop had a nice one click sharing workflow [20:34:27] bgerstle: thanks! [20:35:24] dbrant: the google+ desktop site share a link via email workflow is atrocious [20:35:45] niedzielski: yep, agreed [20:40:13] mdholloway: niedzielski: sorry for the ambiguity. Yes, niedzielski is right. I was referring to https://gerrit.wikimedia.org/r/#/c/205649/17/wikipedia/assets/bundle.js [20:40:20] dr0ptp4kt: hey adam, I've been looking through the FFOS code and have come up with a solution, but while trying to test my solution I was unable to open my local version in the simulator (it has some error about not being able to load the starting file). So far I've just been using the hosted version while debugging and learning the codebase. Any ideas? The process I tried [20:40:20] using was New->Open Packaged App->Select local ffos folder [20:41:23] jhobs: cd into the weboot and do a [20:41:30] jhobs: python -m SimpleHTTPServer 8000 [20:41:37] jhobs: er...webroot [20:42:07] jhobs: actually, hang on, able to talk on hangout? [20:42:55] jhobs: if not...you want to start it that way [20:43:09] jhobs: then you will want to point it at the manifest.webapp on localhost:8000 [20:43:36] mdholloway: also just added another question to the latest version of this file of the same patch [20:45:24] jhobs_: i.e., http://localhost:8000/WikipediaMobileFirefoxOS/manifest.webapp [20:45:31] bearND: got it. [20:45:43] jhobs_: so the trick is to start your python webserver a level above the direcotry containing the manifest.webapp [20:45:56] dr0ptp4kt: i might have missed some of your message, connection hiccup [20:46:07] first message i got was "i.e., ..." [20:46:11] jhobs_: k, we need to get you a satellite connection [20:46:20] haha the problem isn't the connection [20:46:20] jhobs_: kidding! [20:46:24] it's the wifi on the macbook [20:46:36] jhobs_: that's unpossible, that would never happen [20:46:42] jhobs_: python -m SimpleHTTPServer 8000 [20:46:55] jhobs_: you do that at the directory above WikipediaMobileFirefoxOS [20:47:05] bearND: is there a way to respond to a comment on an earlier patch set? i want to address niedzielski's questions on the js but i'm not seeing a way to save the draft comments except on the latest version. (which works well enough, just wondering if there's a way to do it.) [20:47:12] ah, and then add it as a hosted file in localhost? [20:47:14] hosted app* [20:47:15] jhobs_: then you should be able to aim the package url at http://localhost:8000/WikipediaMobileFirefoxOS/manifest.webapp [20:47:26] great, I'll try that, thanks [20:47:55] jhobs_: one nice thing is you can just access http://localhost:8000/WikipediaMobileFirefoxOS even without the app-ified version and it mostly Just Works...which is what i would usually do until i *had* to get to the app-ification part [20:48:35] jhobs_: don't hesitate to hit me up if you need a hand... [20:48:35] mdholloway: yes. Make you comment, then open the earlier PS (click the arrow). Then you should see another review button [20:48:48] your [20:48:51] dr0ptp4kt: will do, in a meeting atm [20:48:56] jhobs_: k [20:49:27] jhobs_: also, re: the bad connection - i guess yuvipanda could line you up with irccloud no prob [20:49:31] bearND: ah, i see, thanks! [20:49:51] jhobs_: not that you need to be connected 24/7/365, just that you'd have the scrollback for @mentions [20:50:01] dr0ptp4kt: yeah, I should probably d/l a client for my desktop as well since that's always connected [20:51:26] jdlrobson: yt? [20:52:18] bearND: you are awesome. Thank you ! [20:52:47] hashar: ? What did I do? [20:53:07] hashar: But thank you. :) [20:53:29] bearND: agh I have poked the wrong mobile eng :] Regardless you must be awesome anyway hehe [20:53:42] hehe [20:54:25] lots of awesome people here :) [20:55:17] dr0ptp4kt: hmm... I'm getting an empty MobileFrontend folder and git submodule update is doing nothing [20:55:50] phuedx: hey still there? [20:55:59] see my email :) [20:56:51] phuedx: yup i'm around uk hours tomorrow [20:56:57] cool.io [20:57:01] so provided we can omg a 10am UTC meeting [20:57:05] OMG [20:57:12] NEVER HAD ONE OF THOSE BEFORE!?11! [20:57:14] kaldari can skype in (2am his time) [20:57:19] (jokes) [20:57:47] nice [20:57:58] jhobs_: you talking about in js/lib/MobileFrontend? [20:58:03] yeah [20:58:08] ok [20:58:14] i'm off for the night [20:58:23] dr0ptp4kt: I assume it's a submodule since git pull doesn't pull anything for it [20:58:23] have a lovely weekend y'all [20:58:30] but git submodule update doesn't either [20:58:43] ^ wrong braincells fired there [20:58:46] g'night folks [20:59:31] phuedx|AFK: you hear that everyone? Tech lead said to take a 4 day weekend [20:59:43] ;) [21:00:20] phuedx|AFK: see you dude [21:00:22] got that mail in [21:00:27] challenge completed ;-) [21:02:31] jhobs_: shaking cobwebs from brain [21:02:46] jhobs_: my old copy of it has the files, but after git clone i see what you're saying. 404s [21:03:23] dr0ptp4kt: I don't even get 404s, I just get no output [21:03:35] I get 404s when I try to run though since it's missing a bunch of styles/js from MFE [21:03:46] jhobs_: that is, the python web server barks 404s...because the files aren't there. so, yeah, just the searchbar at the top of the screen [21:03:55] (surprisingly enough, none of my changes needed to happen in MFE so this is the first I'm noticing of this haha) [21:04:04] dr0ptp4kt: yeah same problem here [21:04:34] dr0ptp4kt: tried manually adding MFE extension as a submodule but it said the js/lib/MobileFrontend folder is already in the index [21:04:47] dr0ptp4kt: although I assume that would've copied a lot of unnecessary stuff anyways [21:08:58] jhobs_: oh, right. do a git submodule init before you do the git submodule update [21:09:01] jhobs_: so... [21:09:10] jhobs_: starting from fresh dir [21:09:14] jhobs_: git clone [21:09:27] jhobs_: mv wikipedia WikipediaMobileFirefoxOS [21:09:29] dr0ptp4kt: yep, it's cloning now, thanks! [21:09:39] jhobs_: "oh git" [21:09:47] (didn't even have to start from fresh directory) [21:09:50] jhobs_: wee [21:10:05] jhobs_: k, gotta step away for a few minutes, lemme know if you hit more fun [21:10:16] dr0ptp4kt: will do [21:13:19] mdholloway: https://gerrit.wikimedia.org/r/#/c/205649/19/wikipedia/assets/bundle.js [21:16:38] bgerstle: do I have read-only permission to 'iOS Test Cases'? Or it's locked cause you're editing it? [21:19:31] bearND: thanks, i saw that -- will write it up shortly [21:19:47] mdholloway: cool [21:21:52] etonkovi_: you should be able to edit [21:21:53] let m see [21:22:20] etonkovi_: there you should be able to edit [21:22:58] bgerstle: yup - I can [21:23:08] bearND: dbrant: i'm having one issue on the disambiguation task, though, which is that FullSearchArticlesTask performs an api request with action=query, while a PageProperties object is populated with the result of an action=mobileview request. So I'm wondering if this approach will require two separate requests [21:23:45] mdholloway: nope, all you need to do is the following: [21:24:55] dr0ptp4kt: is there some version number I might have to update to force changes to apply or something? Even trying to add the simplest change (e.g. "console.log()") does not appear to be applying. Could it be possible it's pulling from master, despite having a different branch checked out? [21:25:48] mdholloway: where it says .param("prop", "pageterms|pageimages"), simply add "|pageprops"... [21:26:36] mdholloway: and then add another line with .param("ppprop", "mainpage|disambiguation") [21:28:01] Ah, so we would be creating a PageProperties object, just a minimally populated one [21:28:04] it's coming back to me now [21:28:28] thank you! [21:29:09] jhobs_: webapps use an AppCache. for best results: (1) kill ff, (2) restart browser, wipe all persisted data for browser, kill browser, restart browser, (3) in your local branch, update js/lib/menu.js and manifest.webapp, (4) at the command line for the repo run the command make (this will touch app.appcache (see Makefile for how), (5) relaunch the webapp [21:29:19] jhobs_: git diff 197eb243543e88827401ee47f69cf98bdbfd0cf9^ 197eb243543e88827401ee47f69cf98bdbfd0cf9 shows the effect of the process [21:29:55] jhobs_: nothing wrong with having your actual code changes bundled in with the version # and app.appcache changes. i just happened to forget to do that, and hence that particular commit [21:31:36] thanks, i'll try that [21:32:48] jhobs_: do note how the app.appcache.template file contains a listing of the files for the app.appcache. you would want to add files that need to be cached into that file. may be a good idea for you to update the README to help future self. [22:30:33] bgerstle: I saw your comment on "Set iOS device language & region preferences to a RTL language (e.g. Arabic or Hebrew). Go to the image gallery for any article with more than one image." [22:30:59] let me take another look.. [22:31:32] bgerstle: my point is: the images in Image Gallery are not always ordered according to their appearance in the article [22:32:01] etonkovi_: i see... that's probably a bug, then? [22:32:22] bgerstle: I filed that bug long time ago :) [22:33:23] bgerstle: hmm... just thinking whch test cases will be most representative for device language switch [22:34:22] etonkovi_: oh really? [22:34:32] etonkovi_: we should've fixed it a long time ago then :-P [22:34:46] etonkovi_: IMO, the test cases should be the true desired behavior [22:34:51] any known issues are up to us to sort out [22:34:58] and maybe warn TSG somehow in the spreadsheet [22:35:09] but the description should state the expected behavior, no more, no less [22:35:26] maybe a comment saying "we have a known issue w/ this where images are sometimes out order. please let us know if you find any articles where this is the case" [22:35:29] sound reasonable? [22:35:49] bgerstle: sounds complicated :) [22:36:14] bgerstle: I've already found couple of regression bugs... [22:36:32] etonkovi_: in 4.1.4? [22:36:53] bgerstle: I am not sure that we should put put such transitory issues into a persistent - test cases - document [22:36:58] dbrant: bearND: niedzielski i don't see michael online - just fyi i added a comment to https://gerrit.wikimedia.org/r/#/c/205649/ [22:37:11] bgerstle; 4.1.4? hold on [22:37:16] etonkovi_: that makes sense [22:37:28] etonkovi_: sorry, we can talk about any regressiosn you find later [22:37:43] i'm actually heading out for the day [22:37:52] bgerstle: of course -I am about to be done with test cases [22:37:53] etonkovi_: i agree with you about the test cases [22:38:04] great, take your time [22:38:13] i'd prefer thoroughness over speed for this :-) [22:38:53] mhurd: thanks. it's weird, i can't seem to spot it. [22:39:23] bgerslte: thanks! [22:39:57] etonkovi_: ok, i'll be around intermittently tomorrow. please send an email when you're done w/ the test cases so i know it's ok to start the conversation w/ TSG [22:41:40] dbrant: bearND: niedzielski: ah it's on patchset 19: https://gerrit.wikimedia.org/r/#/c/205649/19/wikipedia/assets/bundle.js [22:42:48] mhurd: ah, thanks! [22:54:48] bgerstle: ok