[13:17:24] mdholloway: happy monday [13:17:33] dbrant: happy monday! [13:17:43] mdholloway: manual rebase, pls: https://gerrit.wikimedia.org/r/210180 [13:18:15] dbrant: k [13:35:23] ^ that's the best monday chat i've seen so far [13:35:25] HAPPY MONDAY [13:35:27] REBASE PLZ [13:36:13] phuedx: lol [13:36:21] phuedx: all business here on the Android team [13:48:18] dbrant: at your service :) [13:51:54] matanya: that's really great! So, to be clear, were all the users presented with the same prototype? (i.e. link preview with text overlaid on top of the image)) [13:52:26] dbrant: yes, the same article, same link [13:52:39] matanya: excellent [13:52:58] dbrant: just one point on a smaller test scale i did [13:53:24] when the preview is scrollable it confuses users much more [13:54:10] hmm, very interesting. probably not surprising... [13:54:15] they expect to be able to scroll more and then when there is no more scrolling they lose the context and don't know how to continue [13:54:21] i didn't include that info [13:55:19] since the scale was around 20 people, and not that significant [13:55:35] good to know, still. [13:55:36] in terms of the survey size [13:56:23] dbrant: if you want me to do anything else, please let me know, though no i have access to less people :) [13:56:29] *now [13:56:56] matanya: i'll be sure to! thanks again [13:58:29] sure dbrant, if i'll continue to be useful, you can add me to the credits on the app :P [13:58:45] * matanya is in kiding mode [13:58:51] ;) [14:57:03] hi folks [14:57:20] hey phuedx [14:59:52] hey joakino [14:59:54] how're you? [15:00:10] phuedx: here in a nice terrace in morocco :D [15:00:20] phuedx: did you ask me to review me? [15:00:34] phuedx: i mean, to review you [15:00:45] kaldari: you there? did you ask me to review you? [15:01:00] joakino: yes -- just after you asked me [15:01:10] phuedx: i imagined xD, oki [15:01:15] heh [15:09:31] http://i.imgur.com/nZLFarX.gif [16:50:43] niedzielski: so, I agree with bearND that we should probably estimate a point value for the Chinese traditional/simplified task. [16:51:28] niedzielski: having completed the task, what estimate would you give it? :) [16:51:52] dbrant: that's fine with me. unfortunately, i don't think i yet have a great handle on the value of our points :/ [16:52:35] dbrant: i would *guess* that it was in the ballpark of 3 to 5 [16:54:26] anyone else noticed that styles on wmflabs aren't loading [16:54:30] address unreachable [16:54:55] niedzielski: and I would agree with that, based on the complexity and the time spent. I would have given it a 3, not having seen any of the code. [16:55:15] phuedx: a labs server just went down [16:55:17] see -labs [16:55:22] ^ that'll do it [16:55:24] thanks legoktm [16:55:57] dbrant: ok sounds good [17:01:21] phuedx: also, could you confirm greg's assumption on https://phabricator.wikimedia.org/T98142 ? [17:01:53] legoktm: i'll get round to that [17:02:02] i'm still sorta gobsmacked about the anon token thing [17:02:05] i had /no/ idea [17:02:21] and invalidates a few assumptions we'd made while talking about turning it off [17:02:22] okay [18:20:44] dr0ptp4kt: You're about to get a veeeeeeery long email from me. Brace yourself. [18:21:10] Deskana: no! [18:21:12] Deskana: okay [18:21:24] Deskana: thx [18:21:30] dr0ptp4kt: It's one of those ones that's very long and you just need to read it and go "Oh, okay. Nice." [18:21:41] Deskana: wee [18:28:28] niedzielski: hey, did you have to follow up and bug someone to get a cloak after submitting the web form? [18:28:57] niedzielski: i'm trying to get cloaked for mdholloway as well but haven't seen much action on that front since i submitted the form [18:29:17] mdholloway: oh, i never requested one. it wasn't clear to me i had met the prerequisites [18:29:41] niedzielski: ah, i see. [18:30:24] Deskana: thx for sending the context [18:30:36] Deskana: wanna get some mexican food? [18:31:58] niedzielski: ah, i think you get a cloak if you work here regardless of those. i haven't met all of those prereqs either. [18:32:14] niedzielski: and you'll want one, among other things, for access to #wikimedia-staff [18:32:38] dr0ptp4kt: I had a craving for fried chicken, but I couldn't find anywhere that suited me. Mexican works. [18:32:51] Deskana: you hungry enough right now? [18:32:58] mdholloway: ok neat. actually, i was able to get on #wikimedia-staff. there was an email about cleaning up the accounts and i just asked to be added [18:33:12] dr0ptp4kt: Absolutely. Let me finish this email. I'll meet you at your desk in 5. [18:33:27] Deskana: ok, see you soon [18:34:08] niedzielski: ah, cool [18:40:33] mdholloway: by the byte, what did you think of your cowork space? [18:41:15] dr0ptp4kt: omw [18:43:28] niedzielski: it was nice to get out of the house. people were friendly. wifi not great. [18:44:38] niedzielski: they have a 4 day/month membership that i might take advantage of for days when i don't have any meetings scheduled [18:44:53] niedzielski: are you thinking about finding a coworking space? [18:44:57] mdholloway: bummer about the wifi [18:45:26] mdholloway: i'm curious about coworking spaces but currently have no plans [18:56:33] mhurd: hey, quick question, for the *.less files in your image width patch, did you plan for some or all of those to ultimately land in the MobileApp extension, or to stay within the iOS repo? [18:57:26] mhurd: i'm looking at this https://phabricator.wikimedia.org/T96311 and i could get in a quick android-only fix but if it's a problem on iOS too it might be nice to knock it out with shared code [19:00:31] mdholloway: hmm not sure. we're no longer live-syncing the css (i think you just did the same on android) so i wonder about the utility of adding the extra step up putting less up on the server just so we can re-download it at build time [19:01:07] mdholloway: that ticket isn't very informative - do you know what page it's even talking about? [19:01:32] mdholloway: i'd like to check it w my patch [19:01:57] yeah, the first pic is from the Tel Aviv article in Hebrew [19:02:18] but the problem also exists in the gallery for Picasso's Blue Period (at least on Android) [19:02:31] mhurd: not sure about the other pics on the ticket [19:02:48] mdholloway: i think it [19:02:55] it's claude monet [19:04:42] mhurd: yep [19:05:02] mhurd: sigh, i've forgotten all my art facts [19:07:07] mdholloway: i'm guessing you guys may have more restrictions about what css media selectors you can use because if 2.3 compatibility requirements... [19:07:18] *because of* [19:07:31] mhurd: yeah, looking into that is on the agenda for this afternoon [19:09:50] SO MANY PHABRICATOR THINGS [19:21:51] dbrant: so, at least on Android, it looks like we are going to continue to pull CSS from the Mobile Frontend and MobileApp extensions via the .less files, we're just not providing for downloading them on the fly in the field anymore. Or did I misunderstand that change? [19:22:16] mdholloway: that is accurate. [21:00:50] dbrant|brb: mdholloway do you guys know if a page is not a main page nor a file, is it an article? [21:03:45] dbrant|brb: mdholloway maybe i can word that better. i'm trying to add an isArticle() method to the Page class. it looks something like: return !isMainPage() && !isFilePage() && !getTitle().isSpecial() && getTitle().getNamespace() == null; [21:04:51] Article is vague :) [21:04:51] we have a global that makes other namespaces be "content" [21:04:59] niedzielski: i think those are two among many namespaces: https://meta.wikimedia.org/wiki/Help:Namespace [21:09:33] mdholloway: thanks! so if i understand correctly, maybe what i need is just !isMainPage() && getTitle().getNamespace() == null? [21:09:54] niedzielski: you're probably better off waiting for dbrant|brb to return than to have me try to come up with an answer on the fly :) but yes, what you just said is about what i had in mind [21:10:27] mdholloway: thanks :) [21:11:40] It's important to remember what this app we're making is. [21:11:43] It's a Wikipedia app. [21:12:14] Although wikis can theoretically have many content namespaces, that just isn't really the case on Wikipedia. [21:12:35] So the whole content namespace vs article thing is somewhat of a theoretical argument. [21:13:36] To my knowledge there are only two ways that the namespace can be null in the app presently: [21:13:43] 1) The page is in the mainspace (i.e. it's an article) [21:14:14] 2) Older versions of the app didn't store namespaces correctly, so saved page and history entries were all incorrectly set to have null namespaces. [21:14:31] In the second case, even after an update, that'll continue to happen for *old* entries from before the update, but not new ones [21:14:54] niedzielski: So, basically, yes, what you've proposed is fine. [21:15:59] Deskana: thanks! [21:19:12] niedzielski: Although, yeah, bear in mind that that assumption only holds because we're dealing with Wikipedias. Just saying that in case you ever end up working on other WMF projects. :-) [21:22:23] Deskana: i guess one thing i'm still struggling with is that the mediawiki api feels pretty html heavy. i'm not quite sure if this is true as the android app is also quite html heavy and perhaps we're just asking for content that way, but i'm used to json responses that have fields like is_article or is_main_page [21:23:26] html heavy? [21:23:31] Deskana: right now it feels like there's a lot of places where we have more of heuristics for scraping than something more absolute [21:24:43] niedzielski: If there are shortcomings in the API then I'd encourage you to file Phabricator tasks for them. :-) [21:24:48] "If" [21:24:48] Hah [21:24:50] legoktm: we have pretty heavy reliance on a webview that and pass messages via a javascript bridge back and forth from native java [21:25:20] I have no idea what that means :P [21:25:58] I'm just trying to figure out what you meant by " the mediawiki api feels pretty html heavy" [21:26:00] legoktm: ah, i'm probably just not understanding what's really going on. there's a bit there that i'm still coming up to speed on. not trying to complain, just struggling to grok [21:27:05] legoktm: by that i mean, i'm more accustomed to having distinct fields for all the data than one large payload. i *think* this is a product of how it was entered more than anything [21:27:10] legoktm: In short, apps hate HTML and would prefer that articles not be HTML-based at all. [21:27:19] legoktm: Obviously that's not a very realistic world-view for us. [21:27:23] Deskana: they're not! they're based on wikitext! ;-) [21:27:39] legoktm: I should've known you would say that ;-) [21:27:44] niedzielski: example API request that feels heavy? [21:27:46] lol [21:29:17] legoktm: https://en.m.wikipedia.org/w/api.php?action=mobileview&format=json&page=Food&prop=text%7Csections%7Clanguagecount&onlyrequestedsections=1§ions=0§ionprop=toclevel%7Cline%7Canchor&noheadings=true [21:29:37] oh, action=mobileview [21:29:38] lol [21:30:01] I stopped considering that to be part of the "API" a long time ago >.> [21:30:43] API supremacy [21:30:53] Well, it's what the app needs to work. [21:30:57] legoktm: as i understand it, that's one of our primary actions. the format parameter at least claims json [21:31:18] it ...is json? [21:31:43] I think you two are talking past each other. :-) [21:31:46] legoktm: yes, but it's not really broken apart at all. maybe that's intentional or a bug on our side [21:32:09] I think weare [21:32:23] are you talking about the giant blob of stuff in "text"? [21:32:32] or that it's under the "mobileview" key? [21:33:16] legoktm: the text blob in this case [21:33:47] how would you like it to be represented? like what would your ideal API response look like? [21:33:51] legoktm: maybe we're just not asking for things to be broken apart. like i said, i'm still coming up to speed on what's currently in the app [21:34:10] ok :) [21:34:34] well I'm always around if you have API questions or stuff [21:36:41] legoktm: thanks [21:37:21] niedzielski: Have you chatted to Bernd about the content service work he's doing? [21:38:27] Deskana: i think not. it's possible he showed me and i just didn't realize what it was [21:38:40] niedzielski: It's meant to alleviate this pain, amongst other things. [21:38:42] Deskana: i'll bug him about it when he gets back [23:25:06] dr0ptp4kt: Hey, guess what? [23:25:11] dr0ptp4kt: We also arrive in Lyon at the same time. ;-) [23:25:17] Deskana: party [23:25:17] dr0ptp4kt: We could share a cab if you like. [23:25:24] Deskana: cool. mhurd too [23:26:02] Sucheta is on my flight from Heathrow, so she'll be sharing with me too. I'll look out for you guys at baggage claim. [23:26:23] Deskana: thx. mhurd ^ [23:32:17] That's so weird. We're both leaving and arriving at the same time, but going totally different ways. [23:32:23] Can't quite get my head around that at all. [23:44:14] Air Neutrality! [23:45:11] legoktm: No aeronautical fast lanes? :-p