[09:30:54] yo [09:31:03] * phuedx is just finishing cooking soup [09:31:09] then email gets my undivided attention :/ [10:31:14] hey jdlrobson, didn't see you reply [10:31:22] \o phuedx [10:31:24] which reply? [10:31:36] to me and krenair on the dupe bug [10:31:47] oh was it helpful? [10:32:38] yeah [10:32:40] i dunno [10:32:45] i was just thinking out loud [10:32:45] haha [10:32:59] felt like there was something missing [10:33:04] maybe not [10:33:05] i dunno [10:33:08] need more coffee [10:35:45] today is code review day [10:35:54] i'm definitely going to need more coffee [10:36:18] jdlrobson: i thought the pow wow was good [10:57:56] phuedx: https://phabricator.wikimedia.org/T99667 [10:57:58] ^ joakino [11:05:58] jdlrobson: possible dupe -- i know i've seen that before [11:06:17] phuedx: found it [11:06:57] i tracked down the change that git thinks caused it iirc [11:07:26] not sure why i moved it to must have though :/ [11:09:52] ugh [11:09:53] rain [11:10:02] was going to go on a coffee purchasing trip over lunch :( [11:10:27] my bag is going to be full of coffee when i fly over [11:20:24] jdlrobso_: yt? [11:20:30] yup [11:21:36] so bmansurov has a load of html/style changes for different parts of the page around max-width on tablets [11:21:40] all work we commited to [11:21:54] yup i saw [11:21:56] is it going to get borked by caching for anons? [11:22:11] i assume it's going into beta first? [11:22:20] we've used that previously to manage this sort of thing [11:22:31] but yes it is more than likely to get borked for anons [11:22:56] doing it in beta first will allow you to think about this separately - beta doesn't have caching problems [11:23:07] (and push all style changes together) [11:23:13] special pages should be fine though [11:24:40] ok, i thought as much [11:25:14] because for the most part it looks good, but we're going to have to sort this situation out :/ [11:25:40] alright [11:25:48] going for lunch, shall have a ponder about the patches [12:10:39] https://gerrit.wikimedia.org/r/211969 [12:11:00] ^ joakino [12:33:50] back [12:33:54] sies [15:16:16] joakino: yt? [15:56:26] yo phuedx|AFK [15:56:33] we're back [16:24:13] joakino: https://gerrit.wikimedia.org/r/212007 [16:36:45] * phuedx should really join -labs [16:40:37] phuedx: it looks like the log-out button has disappeared on en.wiki [16:42:03] kaldari: https://phabricator.wikimedia.org/T98759 -- fix and follow-on to support cached menu data patches on that task [16:42:36] m. on wmflabs doesn't load for me but the browser tests appear to be working now [16:42:40] kaldari: phuedx are you having problems with jenkins verifying tests? [16:42:50] i spoke too soon [16:42:59] joakino: example? i haven't recently [16:43:33] kaldari: last week was a bit of a nightmare and i didn't ping anyone on the task to swat 'em [16:43:36] that was mibad [16:43:46] phuedx: https://gerrit.wikimedia.org/r/#/c/211967/ [16:43:56] phuedx: jdlrobson is on it [16:43:57] phuedx: I can swat them today [16:44:28] kaldari: just make double sure that everything's alright before you do -- i don't want to keep having to fix that fucking menu [16:44:39] mainly because i'm the idiot that keeps breaking the damn thing [16:44:45] bleh [16:44:47] MaxSem: How long is HTML and CSS cached for anonymous users? [16:44:48] meetinz!!! [16:49:55] kaldari: iirc 30 days [16:50:56] that sounds right [16:53:44] yeah, looks like it's 30 days [16:57:41] kaldari, FlorianSW: so is the cached css invalidated when we push a new change but the html isn't? [16:58:33] phuedx|MEETINZ: correct, RL resources are cached for 15 minutes, html for 30 days, so you need to implement a compatibility and remove it after 30-35 days [16:58:36] kaldari: ^ [16:58:58] ok -- i sorta had that in my head but i'm glad i /know/ now [17:00:05] phuedx|MEETINZ: great :) [17:04:02] phuedx|MEETINZ kaldari if you have a second: can you take a look at https://gerrit.wikimedia.org/r/#/c/212017 i'm not sure, if wikidatawiki still needs to have WikiGrok installed to keep the already recorded data? :/ [17:04:46] FlorianSW: That should be fine. I'll +1 [17:04:48] FlorianSW: i believe all the data should be on enwiki [17:04:58] oh actually no [17:05:03] wikidatawiki will have some data too [17:05:14] The data won't disappear though [17:05:19] yeah i was about to ask [17:05:32] we shouldn't remove it if an extension is underployed [17:05:36] :o [17:10:24] benestar: there? [17:17:43] niedzielski: consider T89989 up for grabs if you want it [17:18:35] hey codezee how's it going [17:20:09] jdlrobson: presently I'm kind of blocked by setting up of wikidata, somehow I'm unable to bring the wikibase client and repo on my repo to communicate, [17:20:48] regarding loading of variable size image from the client depending upon browser size, I've written the basic code, I'll upload for you to see soon [17:22:23] I meant "*on my local wiki to communicate" [17:24:34] jdlrobson: I was just not sure what browser sizes to check for , so let me know that in the patch when I upload [17:25:27] codezee: have you set up the vagrant role? [17:26:22] jdlrobson: I've setup the vagrant role, and the wikibase repo, so far I can create new items and add statements, only issue is my repo is not appearing in the sitelinks section [17:26:32] basic setup of the extension is done [17:26:41] oh so confusingly there is a wikidata.localhost [17:26:49] and an enwiki.localhost or something akin to that [17:26:58] only the enwiki localhost can communicate with the wikidata one [17:27:06] does that make sense? [17:27:19] yes, my local wiki is meant to act as both wikidata.localhost and enwiki client [17:27:37] for testing purposes [17:28:55] yes, according to the docs thats possible, I'm going to get help from wikidata channel, got some yesterday too, which solved a few issues before that [17:41:40] mdholloway: which task is that associated with, again? [17:41:54] dbrant: niedzielski: also, i'm not sure whether this would be the case for android but monte says that CSS can sometimes work differently on a physical iOS device vs a simulator [17:41:59] dbrant: T94646 [17:42:43] dbrant: sorry, i think i started off in the wrong channel [17:43:21] mdholloway: how would it look if the @media query doesn't work? [17:43:30] mdholloway niedzielski: ya on iOS if you simulate a retina device the web view doesn't seem to get the message. it still thinks it's non-retina, and seems to use lower res item from img srcset [17:43:35] mdholloway: dbrant i don't have a whole of experience wit that. the 2.3 emulators are kind of a pain point for us. afaik, both the gingerbread stock emulator and genymotion emulators crash right away with the app [17:44:11] niedzielski: oh yeah, that's right. and my 2.3 device is a tiny phone where this would kind of be moot anyway [17:44:27] dbrant: one sec [17:44:48] mdholloway: i have a gb galaxy note 1 if there's a quick test you want me to try [17:45:22] dbrant: mhurd's css: https://gerrit.wikimedia.org/r/#/c/211068/5/www/less/widenImages.less [17:46:07] niedzielski: cool, not just yet but i'll probably take you up on it later! [17:46:51] mdholloway: in case it doesn't work in 2.3, if it doesn't look *terrible*, I would be ok with simply not having this feature in 2.3... [17:47:18] dbrant: fair enough [17:47:35] dbrant: come to think of it, i haven't yet taken a look to see what the interwebs have to say about this issue [17:48:45] isbetalabsdownforeveryoneorjust.me [17:48:55] derp [17:50:45] joakino: seems to be down for me [17:52:20] mdholloway: added comments to: https://gerrit.wikimedia.org/r/#/c/211068/5/www/less/widenImages.less [17:55:10] bgerstle: hangout? [17:57:11] mhurd: thx. ha, that last bit is kind of wacky! [17:57:35] mdholloway: haha i know right! [17:58:24] mhurd lemme wrap up lunch [17:58:26] be done in a minute [17:58:32] bgerstle: take your time! [17:59:48] mhurd: mdholloway no wonder facebook wrote their own flexbox implementation... [17:59:59] bgerstle: haha [18:00:03] https://github.com/facebook/css-layout [18:00:53] bgerstle: mhurd: oh, interesting [18:01:09] bgerstle: fancy! [18:01:55] bgerstle: first time i've seen the word "transpiled"... what a clunky word. [18:02:19] bmansurov: phuedx|BATHTIME we are seeing some issues with ButtonWithSpinner on ios - it sometimes takes 2 clicks [18:02:47] mhurd not sure if it's used in https://github.com/facebook/componentkit [18:02:54] considering rewriting as a mobile View [18:02:58] jdlrobson: yeah i noticed a regression with the spinner too. I think this happens as a result of file moves, not sure though. [18:03:25] bmansurov: what issue did you see? [18:03:35] and did you raise a bug? [18:04:07] jdlrobson: in alpha, click on the 'report an error' button and close the overlay that opens, then look at the button that you just clicked [18:04:13] jdlrobson: not yet [18:04:24] oh report an error.. we still have that ;-) [18:04:37] jdlrobson: i suppose that happens with any button with spinner [18:04:39] how is that working? are we getting usage on it? [18:04:57] jdlrobson: not sure, it's in alpha, we need to promote it to beta [18:05:00] to get more usage [18:08:13] codezee_: wikidata is not my expertise so sorry i'm not being much hope right now. Will chat tomorrow [18:08:53] jdlrobson: yes, thats alright, I'll get it through soon, I'm sure :) [18:09:32] codezee_: maybe I can help. What are you trying to achieve? [18:09:54] phuedx|BATHTIME: yes, that's correct. The CSS is cache-invalidated via RL, but the HTML isn't. [18:10:29] bmansurov: I'm trying to setup a wikibase repo and client both on my same local wiki so that I can create items and properties and use them [18:10:53] so far I've been able to setup dedicated item and property namespace [18:11:01] codezee_: oh, I can surely help you if you're using vagrant, because I know how to do it in vagrant [18:11:15] yes, I'm using vagrant [18:11:24] I've enabled the roles [18:11:35] codezee_: are you able to visit wikidata.wiki.local.wmftest.net:8080 ? [18:11:53] dbrant: do you manually create a new schema article or is there a generator of some kind? [18:12:26] codezee_: if yes, you can create items by visiting http://wikidata.wiki.local.wmftest.net:8080/wiki/Special:NewItem [18:12:38] codezee_: and properties by visiting http://wikidata.wiki.local.wmftest.net:8080/wiki/Special:NewProperty [18:12:44] let you know in a moment, my vagrant has become slow in response so might take a while [18:12:51] niedzielski: manually. I usually copy&paste the content from another schema, and start from that. [18:12:52] codezee_: np [18:13:09] dbrant: sounds good, thanks [18:14:17] bmansurov: my wiki is at localhost:8080/wiki/ and I can create items at localhost:8080/wiki/Special:NewItem [18:14:53] codezee_: are you using localhost for both wiki and wikidata? [18:15:21] bmansurov: yes, is that not right? [18:15:48] codezee_: if you use the above url and use http://en.wiki.local.wmftest.net:8080 for enwiki then you can link wikibase with enwiki when creating items [18:15:55] mhurd http://pouchdb.com/2015/05/18/we-have-a-problem-with-promises.html [18:16:55] codezee_: for example, let's say you have Q5 and there is a page in your enwiki that is related to Q5, then on http://wikidata.wiki.local.wmftest.net:8080/wiki/Q5 you can see Wikipedia at the bottom of the page. [18:17:10] codezee_: you can link wikipedia pages to your wikidata repo this way. [18:18:44] bmansurov: I'm tryint to access the above url, but it says service unavailable [18:18:55] status code 503 [18:19:03] dbrant: how do we decide when the app ID is sufficient or when to generate a new UUID? [18:19:30] codezee_: how did you enable the wikibase role?