[01:40:27] Anyone from the mobile team with an apple developer account about? [08:01:13] hey codezee [08:02:03] jdlrobson: hello! [08:02:30] codezee: do you want to join the hangout from yesterday and chat? [08:02:48] oh you are already there :) [08:07:50] sumit i could hear you no idea why you couldn't hear me :-/ [08:08:04] So we should chat here [08:08:21] yes, there was some issue I wasn't able to figure out too :P [08:08:46] yes, I had already talked to Nicolas over irc yesterday [08:08:48] So you are currently working on https://phabricator.wikimedia.org/T98044 and https://phabricator.wikimedia.org/T98031 [08:09:04] i've seen you got the labs instance running and the wikivoyage message out [08:09:21] what did you and nicolas talk about yesterday? i guess that's a good place to start :) [08:09:51] yes, I'm working on https://phabricator.wikimedia.org/T98044, and I was having a issues with setting up the repository and vagrant, but now they're resolved [08:10:10] wait, I'll just show the logs [08:11:00] so I can move on to write the code for fetching the banner from wikidata this week [08:11:28] here are the logs https://dpaste.de/4rgE [08:11:43] mostly he suggested me to write the same message on https://meta.wikimedia.org/wiki/Wikivoyage/Lounge [08:11:52] and also on traveller's pub of russian wikivoyage [08:11:56] excellent have you got a task tracking those things? [08:12:40] the task tracking the announcement was https://phabricator.wikimedia.org/T98944 and was closed by Nicolas, considering I had made the announcement [08:13:40] you had asked me to also think about https://phabricator.wikimedia.org/T98031 , so in that respect [08:14:16] here's a js module that I wrote to get variable size image, however I do not intend to finish this before finishing the other task [08:14:17] https://gerrit.wikimedia.org/r/#/c/212512/2/resources/ext.WikidataPageBanner.loadImage/ext.WikidataPageBanner.loadImage.js [08:14:22] okay will take a look now [08:14:28] you can have a look to see if thats the right track [08:15:03] codezee: so this should work but it would need some tweaking to scale on a big project [08:15:40] jdlrobson: yes, thats in no way final, I'll make it deployable and error-free after I finish the other task [08:15:44] it would be wise to avoid the API request and simply use an image in the DOM [08:16:19]

that kinda idea (so your script would just read off attributes in the element) [08:16:53] jdlrobson: but I'm making an api request to get the image of smaller size and save bandwidth? [08:17:31] like if we're on mobile, I thought it would be good to load an image of width only 768px? [08:18:12] so you can calculate the urls of images on the server side with no impact on the user's bandwidth [08:18:27] however the API request will slow down the time the user sees the image [08:18:53] so if you calculate it on the server and then choose the image in JS you get the best of both worlds [08:19:42] ok so I have to load the original image in all cases I guess? [08:19:49] not necessarily [08:19:54] that's up to you to decide. [08:20:12] you could load an img with a mobile image that gets enhanced on desktop [08:20:17] jdlrobson: yes, my idea is to load an image through api request only after I've detected user's browser size, but yes regarding the api-request, it might take time, as you've pointed out [08:20:27] or you could load a div with the urls in data attributes and only load the image with JS [08:20:36] yes that is the idea [08:20:48] getBannerUrl already calculates the url [08:21:01] so you should make use of this to pre-prepare all the other urls [08:21:15] mobileUrl, tabletUrl, desktopUrl should be enough to start with [08:21:33] you may want to add more in future [08:21:41] yes, that is the original plan, to load the image only through js once the size is detected, I intend to leave the src attribute empty before that [08:21:58] but remember this is on every page, so triggering an API request on every page for every user is costly [08:22:56] codezee: note that an img requires a src attribute to be valid html [08:23:21] no I meant I'll leave it with "" [08:23:45] and the banner here is actually a background property [08:23:50] that's also not valid html codezee :) [08:24:12] but you can use a div element or simply use the mobile image (which would also make it work for non-js browsers) [08:24:51] by mobile image you mean a medium size image I guess? [08:25:51] small size [08:26:05] so assume 320px screen [08:26:40] so that means I load a small(320px) image by default and then if the browser is large, I request a bigger one? [08:27:24] exactly [08:27:30] and you choose one based on the browser size [08:27:53] that looks good, only problem will arise if browser is big and js is disabled? [08:28:55] is anything needed to be done about that? [08:30:23] it's not essentially functionality to a user so i'd say no [08:30:45] you may choose to not show a banner in that case or to show the mobile banner [08:30:49] whichever you think gives more value [08:30:52] okay [08:31:01] user's data charges are much more important :) [08:31:19] also a last thing, you said api request could slow down things, so can I use network profiling of dev-tools to compare the time in both cases? [08:31:23] so what do you plan to do this week aside from this? [08:31:43] codezee: i'm recommending not using an API request at all [08:31:57] okay [08:32:09] no need to profile since without one you're not adding any slowdown [08:32:29] alright, I get the point [08:33:08] I'll complete https://phabricator.wikimedia.org/T98044, had a small talk with Bene last night about this [08:34:07] I wanted to know how could one fetch the property from php, since I'm not much familiar with wikibase [08:34:35] and after this I'll finish complete https://phabricator.wikimedia.org/T98031 [08:34:43] the task we were discussing [08:35:30] okay excellent [08:35:43] do you feel like you are getting close to completion on pulling from wikidata [08:35:49] also [08:36:49] regarding https://phabricator.wikimedia.org/T99876, I'll complete it with T98044 [08:37:08] and then go to T98031, since the above two are related [08:38:44] jdlrobson: I think thats about it what I'll be able to do this week [08:38:58] okay i don't think https://phabricator.wikimedia.org/T99876 is high priority right now [08:39:07] it's just a nice to have, i'd concentrate on perfecting the pulling from wikidata [08:39:20] hopefully the community will give you ideas on how to continue [08:39:49] ok, then I'll leave that aside for now, and continue on the original path [08:40:40] anything i can help you with? [08:40:44] I'll edit https://phabricator.wikimedia.org/T98031 to what we've just discussed [08:40:46] anything i can do better? [08:41:17] Will you be starting conversations about TOC soon? [08:41:25] Since in your chat with Nicolas you said that was on the horizon [08:43:54] regarding TOC, yes,immediately after this I was thinking of implementing the custom options in pagebanner, and then move to TOC [08:44:14] so discussion should start soon, though I'm a bit unclear how to start them off? [08:44:55] can you suggest something, I mean the basic idea is clear, but in case the community needs to suggest any modifications, I should be able to get them before implementing [08:45:39] so I think I'll need to put another notification on traveller's pub by this week, about the TOC [08:45:43] what do you say? [08:47:40] or we can decide this in the immediate next meeting on wednesday? [08:49:22] sounds like a plan [08:49:50] ^ codezee personally i would just mimic what they are currently doing and let them resolve that discussion [08:50:02] (and then update the extension accordingly) [08:50:40] jdlrobson: yes, I'd go with that by default :) so in any case, I'll implement the default thing [08:51:35] yo [08:51:47] hey phuedx [08:52:32] hey jdlrobson [08:54:10] jdlrobson: thanks, I think thats about it, I've got the advice I needed on things. [08:54:16] ok excellent [08:54:22] be sure to email me about anything else during the week [08:54:28] jdlrobson: sure! [08:54:33] i will be at the lyon hackathon friday-sunday [08:54:41] so my availability might not be as good as normal! [08:55:12] I'm aware of that, so I'll remember [09:00:28] okay speak soon! :) [09:03:27] phuedx: we need to get our hackathon topics up on mediawiki.org [09:05:03] bleh -- we need to do an awful lot of things [09:05:12] jdlrobson: you're not at the hackathon on monday? [09:05:38] i was confused - is monday the travel day? [09:08:53] monday -- all day hacking, closing [09:09:04] i'm flying out early tuesday morning [09:09:06] :/ [09:09:58] ^ rage quit [09:29:09] hey again jdlrobson [09:29:19] :) [09:29:33] just had breakfast. catching up with my email backlog [09:36:53] jdlrobson: have packed three bags of beans, grinders and brewers [09:36:59] \o/ [09:37:02] i just hope they have a friggin' kettle this time [09:37:05] i was just thinking the coffee in marrakesh sucks [09:37:13] it's europe [09:37:16] they'll have a kettle [09:40:29] we need a wikipediaforcats [09:41:53] http://jsforcats.com/ [09:47:46] joakino: lolol [09:49:26] joakino: send it to a community mailing list and see what happens [09:49:27] :/ [11:52:08] hey kaity [11:52:23] phuedx: hey [11:53:02] thanks for getting back on that task [11:54:35] phuedx: sure, does that make sense? [11:54:54] yeah -- the patch that baha submitted does exactly that [11:54:58] phuedx: oh actually [11:55:11] * phuedx takes his finger off of the MERGE button ;) [11:55:15] i wonder if we can have the text align with the content text in the article [11:56:22] right now its this: https://www.dropbox.com/s/aevt4pcx8zranwm/Screenshot%202015-05-21%2013.56.02.png?dl=0 [11:57:51] kaity: so the patch that's uploaded aligns the text /and the grey box/ to the content of the article [11:58:06] either when the last edited is at the top or at the bottom of the article [11:58:10] (stable, or alpha/beta) [11:58:16] phuedx: in beta and stable? [11:58:21] oh ok [11:58:36] phuedx: yea thats fine [11:58:51] however, i was wondering if you wanted the grey box to extend to the full width of the page when it's at the top of the page [11:58:55] (immediately under the header) [11:59:09] and have the content aligned with the article content [13:01:53] okie poke -- gonna nip out to get some things sorted for travelling tomo [13:40:13] dr0ptp4kt_h: yt? [13:40:35] mdholloway: yes. whatup? [13:40:52] quick security ? for you, will PM [13:41:11] mdholloway: hangout? [13:41:22] sure [13:41:50] mdholloway: i reimaged my machine and the one thing i failed to backup was the bookmarks file. argh [13:42:01] mdholloway: calling you directly [13:42:03] ah, need batcave link? [14:05:51] joakino: http://www.bath.ac.uk/news/2013/09/04/lanyrd-eventbrite/ [14:06:15] http://blog.natbat.net/post/61658401806/lanyrd-from-idea-to-exit-the-story-of-our [14:32:11] phuedx: so looking at florian's patch to lazy load tablet styles [14:32:57] it results in the styling visibly changing- do you think this is a problem ? [14:33:06] it seems to only be adjusting so doesn't seem so bad to me but unsure [14:33:26] jdlrobson2: what are the visible changes? [14:33:33] it just centers [14:33:57] so it starts off full screen and then adjusts -thus it also results in a repaint [14:35:10] (tablet only though) [14:35:12] mobile just benefits [14:35:20] (tablets are a thing) [14:35:24] yeah, i get it [14:35:46] how heavy are the tablet styles that aren't loaded in by js in the first place? [14:36:02] brb -- getting shouted for by a builder [14:37:52] gilles: you there? [14:38:05] phuedx: i'd have to check [14:38:15] tablets are more likely to have wifi though i'd hope but citation needed etc [14:41:19] moizsyed: you made it to france? [14:55:08] jdlrobson2: needs thought [14:55:15] phuedx: yup [14:56:43] we should design an experiment complete with ui to opt in so that we can measure bandwidth on devices [14:56:50] or to crib other people's data [14:57:02] or to wait, with baited breath, for this: https://developer.mozilla.org/en-US/docs/Web/API/Connection [14:57:27] jdlrobson2: thanks for that c+2, it's been hanging around for a while [14:58:39] trying to play with my ideas, a la kent beck: https://gerrit.wikimedia.org/r/#/c/212522/ [14:58:44] no problem phuedx see also https://phabricator.wikimedia.org/T99912 [14:58:56] phuedx: good news! gilles is in for bear grillz during hackathon [14:59:07] cool.io [14:59:14] crap -- i haven't added that to mw.org yet [14:59:15] joakino had some good ideas for a mobile web app not using mediawiki that i'm keen to explore [14:59:19] specifically for offline capabilities [14:59:38] i'm going to harass hashar about browser tests [14:59:41] or how to fake 'em [14:59:44] :D [14:59:58] phuedx: so mobile.experiments [15:00:02] so [15:00:04] mobile [15:00:05] dot [15:00:07] it seems VisualEditor have a kill switch for VE for anons using the same hook [15:00:08] experiments [15:00:18] the rl hook ting? [15:00:20] so I'm guessing if it's good enough to kill VE it should be good enough for us [15:00:21] yeh [15:00:26] yeah absolutely [15:00:42] the only way you could do it faster would be with that on-wiki js thang [15:00:48] but it's like 5 minutes, right? [15:01:23] i think the turnaround time for killing the mobilewebsearch schema thing was ~20 minutes and everyone was /way/ cool with that [15:01:29] (we nearly melted eventlogging) [15:01:49] jdlrobson2: if you do it, then you'll help this team with some upcoming work, so i'm in if you need a reviewer [15:02:01] ++ [15:02:11] yeh 20 mins should be fine [15:02:44] in fact our feature has no problems for anons [15:02:52] the only side effect is that the CTA shows a different message [15:02:56] since collections is logged in only :) [15:03:11] jdlrobson2: no, sorry, 20 mins was creating a patch to kill it, and getting that patch swatted :) [15:03:27] actually it was more like 40 [15:03:31] thinking about it [15:03:35] but it required some sync [15:03:41] the rl hook makes things pretty darn easy [15:03:54] (and means you only have to change the config) [15:03:59] (we had to change code) [15:04:04] phuedx: i'm gonna do a bit more moving code to resources [15:04:16] jdlrobson2: have you done the rl hook thing? [15:04:17] i really don't like the inconsistency right now of having to check both javascripts and resources [15:04:25] phuedx: yeh patch is in gerrit [15:04:28] yeah, it's hella annoying [15:04:29] oh right [15:04:32] i'll take a look [15:04:42] /after/ i go and shout at some people for taking my money twice [15:04:45] :/ [15:04:54] back in ~20 [15:04:57] * phuedx *sighs* [15:09:12] joakino: https://gerrit.wikimedia.org/r/#/c/212522/ [15:09:17] we should chat [15:09:19] also, yolo [15:09:21] ok [15:09:24] really really gone now [15:09:27] *poof* [15:17:13] phuedx: joakino is out for late lunch [15:18:56] back [15:19:06] jdlrobson2: looking at your patch now [15:27:09] phuedx: craaazy patch [15:54:40] jdlrobson2, joakino: could you confirm that the future toast thing is working for you [15:54:51] (it's working for me, but the browser tests are failing mentioning toasts) [15:54:55] phuedx: it is. I closed the bug [15:55:05] oohh browser test selector probably didnt get updated [15:55:09] this is a recurring problem.. [15:55:14] jdlrobson2: init.js is not on resources.php? https://gerrit.wikimedia.org/r/#/c/212561/1/includes/Resources.php [15:55:35] selector? the toast class remains the same, right? [16:04:17] JonKatz: airport wifi having issues... trying to join now. [16:04:39] dbrant me too...think its the hangout [16:04:44] grace is also having trouble [16:05:13] dbrant_ g^^ and grace is sending new link [16:05:37] JonKatz: dbrant_ - coreyfloyd and i are on, although it seems kind of laggy or something. [16:07:06] dr0ptp4kt_h ok thanks, will keep trying [16:07:58] JonKatz: new link received. theoretically, it's connecting. cc dbrant_ coreyfloyd [16:08:36] dr0ptp4kt_h i'm in the new one! [16:39:00] jdlrobson2: https://gerrit.wikimedia.org/r/#/c/211919/ [16:39:52] phuedx: jdlrobson2: have a look at https://github.com/lukehoban/es6features when you have some time, will be interesting for then hackathon [16:52:54] joakino: \o/ [16:53:08] generally speaking, that's my opinion [16:58:52] joakino: what's the name of the es6 ~> es5 compiler? [16:58:59] wait [16:59:06] let me google that for myself [16:59:32] https://babeljs.io/ [17:01:08] phuedx having trouble logging into our hangout.. [17:01:36] phuedx but want to do a status check before hackathon tsunami drowns us [17:01:43] (in happiness) [17:02:05] * phuedx waits patiently [17:02:29] phuedx this happened to everyone in my meeting an hour ago...sending new link in a sec [17:02:57] phuedx https://plus.google.com/hangouts/_/g52t6brr53tqsz2ud74ehkarwma [17:04:25] topless JonKatz [17:04:32] phuedx: just watch out for the call for prayer [17:04:36] makes meetings interesting [17:12:14] FlorianSW: how do i deprecate modules? [17:13:26] bmansurov FlorianSW see https://gerrit.wikimedia.org/r/#/c/210868/ [17:13:30] jdlrobson2: Use M.define( 'newmodulename' ).deprecate( 'oldmodulename' ); :) [17:13:38] that works now? :) [17:13:40] awesome [17:14:00] jdlrobson2: yeah, we finally merged it :D [17:14:05] i missed that patch :) [17:14:25] jdlrobson2: see https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/8fc4b1e29e5b7750242658ce6ec6aae54fd2225e/resources/mobile.modules/modules.js#L61 for doc :) [17:14:40] or https://gerrit.wikimedia.org/r/#/c/202069/ [17:43:57] phuedx: see my comment on https://phabricator.wikimedia.org/T90867 i'm gonna stick this on mediawiki.org for you along with mine if that's cool [17:46:17] how can we tell if a session has been confirmed? [17:48:44] jdlrobson2: thanks -- sorry, getting the family out of the door has been… trying [17:48:58] okay np i'll suggest some timeslots then let you know and change if necessary [17:54:22] jdlrobson2: https://gerrit.wikimedia.org/r/211919 [17:57:35] phuedx: do you remember which bug has the discussion about the caching issues? [17:57:46] joakino: phuedx https://www.mediawiki.org/w/index.php?title=Wikimedia_Hackathon_2015/Program [18:04:00] kaldari: the max-width stuff kaldari? [18:04:06] yeah [18:04:14] I seem to have lost the bug [18:04:29] there are so many now :P [18:05:04] if you don't know off-hand, don't sweat it [18:05:11] kaldari: ready for sign off column in the current sprint board [18:05:23] which caching issues are we talking about here? [18:07:43] phuedx: Doesn't seem to be any of those. The bug that I pinged Max on about the HTML changing in beta. [18:08:02] was it a spike maybe? [18:08:13] phuedx: so we have a last minute session idea if you are interested.. [18:08:14] oh [18:08:28] shit, nevermind, that was for the infobox [18:08:39] https://phabricator.wikimedia.org/T91712 [18:08:43] found it [18:08:53] https://phabricator.wikimedia.org/T91712 [18:08:57] you've already found it [18:09:08] jdlrobson2: shoot [18:09:12] nothing is too crazy [18:09:30] https://phabricator.wikimedia.org/T99933 < phuedx [18:09:42] i'm scheduling all our sessions for us [18:09:47] phuedx: see https://www.mediawiki.org/w/index.php?title=Wikimedia_Hackathon_2015/Program [18:09:56] yes!!! [18:10:03] jdlrobson2, joakino: in [18:10:07] :D [18:10:08] zom [18:10:09] *g [18:10:13] there are too many cool things :/ [18:10:42] sunday or saturday phuedx ? [18:10:54] phuedx: good news giles is hacking with us to make beer grillz forgot if you saw my note [18:11:13] or monday :) [18:11:31] gilles: what time are you leaving Lyon on Monday? [18:11:37] phuedx: joaquin doesn't really care [18:12:04] phuedx: i feel like Saturday is best [18:12:06] to get all the newbies [18:12:09] saturday [18:12:16] attract some folk and then we can buddy up [18:12:37] i'd do 2pm [18:12:49] there are sessions before i think we should all go for [18:15:58] hello, is this the right place to ask about our native app functionaly? [18:16:42] SVentura: indeed it is. What's up? [18:16:52] super [18:17:04] i'm new to this so hope this makes sense [18:17:38] would it be possible to have a "listen to" along the side with the "share to" functionality [18:18:18] does this makes sense? [18:18:52] Hmm, maybe, say more? Are you thinking of voice search? [18:19:08] (Also, are you talking specifically about iOS or Android, or both?) [18:19:35] What would be listened to in this instance? [18:20:23] I am on wikipedia's BB King page, select some text to share -- window pops up offering "share with" (IM, Twitter, Evernote...what ever app is installed) or "listen to" [18:20:39] talking about both IOS/Androis [18:20:42] android [18:21:32] If have Spotify installed, could that "listen to" option launch the Sopitfy all? - much the same way the "Share to Evernote" lanches the Evernote app? [18:21:35] Sure, I see what you have in mind. Let me take a quick look in the app, too. [18:21:52] ok [18:23:23] While I'm pulling it up, in principle I see what you mean and I think it's a cool potential feature. [18:23:23] bmansurov: I'm always one patch behind you :P [18:24:00] mdholloway: :) [18:24:02] kaldari: ;) [18:24:41] SVentura: If you're comfortable filing a feature request ticket in Phabricator, our project tracking software, you could write it up, otherwise I can create one with the substance of this conversation. [18:25:33] SVentura: I'm not sure we'd want to integrate that tightly with Spotify; if we were going to provide direct links to audio content, we'd almost certainly prefer free content hosted on a Wikimedia project or another free source like the Free Music Archive [18:26:34] mdholloway: sure, whatever is easier. this is a questions that came up a couple of times - since people do way more on their phone than share content - when we start talkingabout deeplinking they could potentially "listen to" - "watch" etc.... I am just curious if that woudl be above and beyond the current scope of our app [18:27:10] phuedx: all done. [18:27:22] mails sent [18:27:23] mdholloway: yes - agree. any content/media we would 'link to' would *have to be* freely licenced. aything else is a non starter :) [18:27:58] jdlrobson2: cool :) [18:31:38] SVentura: If you'd like to create a feature request ticket, you can do so here: https://phabricator.wikimedia.org/maniphest/task/create/ [18:32:03] SVentura: and I'd be happy to answer any questions about filling out the forms [18:32:08] *form [18:34:21] : mdholloway: cool. I'm getting a quick intro to phabricator by Caitlyn C - will add it later today. Thanks mdholloway: ! [18:34:26] bmansurov: In the latest patch, the 'active' functionality won't work on cached pages, but I don't think that's very important personally. I'm willing to merge it how it is unless you feel like that needs to be fixed. [18:34:43] SVentura: No problem, thanks for the feedback! [18:34:55] kaldari: yeah, let me fix it [18:36:03] mdholloway: you're welcome! [18:36:47] bmansurov: and I'm not really convinced you need that other cache-related code. Does it have any practical effect (other than accidently killing the active state)? [18:37:29] kaldari: I don't think so. OK, you can merge it if you want. [18:41:30] bmansurov: the active state of cached pages won't matter after 24 hours anyway, since pages are only marked as active if they've been edited recently (which clears the cache) [18:41:52] which is a nice accident [18:41:59] 👍 [18:52:49] bmansurov: one more little thing [19:29:36] kaldari: how do I get the page action? $skin->getRequest()->getVal( 'action' ) ? [19:29:43] kaldari: any other way? [19:43:38] bmansurov: you want to get it from wgAction [19:43:53] thanks [19:59:24] The historylink code in MinervaTemplate is kind of a mess. I might do a follow-up patch after yours to clean it up. [19:59:49] The existing code I mean, not the new code [20:02:05] dr0ptp4kt_h: I'm planning to get to your house at around 3:30pm. Is that a good time, or should I come earlier/later? [20:03:09] Deskana: that's perfect. you may see me jogging the streets within the next 10 mins. need to get brain and body ready for this flight [20:16:40] kaldari: MaxSem bd808 bearND|away bgerstle_brb bmansurov coreyfloyd Deskana joakino mdholloway mhurd niedzielski phuedx i'm going for a run, then will check back online, then get ready for heading out to the airport. hit me on my mobile # in case something urgent comes up [20:16:59] dr0ptp4kt_h: thanks man. have a great trip! [20:17:02] Cya! [20:17:27] dr0ptp4kt_h: will do! have a good run/flight! [20:40:05] benestar: I was able to fetch the value of statement with the code that you gave me, however it requires the item id. Is it possible to fetch the item id of an article page that has a valid item link in wikibase repo? [20:42:32] bmansurov: Actually I told you the wrong thing. wgAction only exists on the client-side (strangely). But I tweaked it to work correctly. [20:42:54] great [21:11:08] bmansurov: Don't you need to set the data format in https://gerrit.wikimedia.org/r/#/c/211884/5/javascripts/modules/ForeignApi.js ? [21:11:29] kaldari: no, the default is json [21:12:34] kaldari: can you hold on reviewing that patch for now, I need to push something [21:12:35] ? [21:13:29] I thought the default was jsonfm, i.e. HTML formatted JSON [21:15:14] anyway, seems risky not to specify, but maybe I'm just paranoid :) [21:15:15] kaldari: it says json in /mediawiki/resources/src/mediawiki.api/mediawiki.api.json [21:15:25] kaldari: i had it before, jon wanted me to remove it [21:15:57] kaldari: i've updated the patch, you may review it now [21:16:15] bmansurov: Ah, I didn't know it was specified higher up. Looks fine then