[00:04:24] kristenlans: hey! [00:04:42] Just FYI, Im waiting on QA signoff for everything in Sprint 58Board [00:04:52] iOS and Android [00:05:12] Hey vibha! Thanks for the update. [00:05:42] mhurd: hey! are you around [00:05:45] have a super qq [00:06:27] vibha: ya! [00:06:53] what's the wikidata description task number? I'm going through the cards to add notes [00:10:03] vibha: https://phabricator.wikimedia.org/T90765 [00:10:11] thank you thank you! [00:10:18] vibha: np! [00:12:44] bmansurov: looks like the change to the history link is also breaking our tests [00:12:51] https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce/137/testReport/(root)/Check%20UI%20components/Check_existence_of_important_UI_components_on_the_main_page/ [00:15:20] https://phabricator.wikimedia.org/T101070 < bmansurov [00:16:36] vibha: i added a couple notes to the phab ticket too [08:44:57] good morning [10:03:37] prff kanban talk will be at 22UTC [10:03:51] very convenient 3pm SF, fuck the rest of the world [10:23:30] yo [10:25:04] hey joakino [10:25:23] i'm going to be tidying up the epics prior to prioritisation meeting earlier [10:25:40] jon's done a good job on detailing the browser tests work [10:25:48] so i think we can commit to working on that [10:25:53] but i'm just going to make sure [10:32:57] phuedx: i've been reading those tasks, they seem just fine and actionable, so 👍 on me [10:33:10] phuedx: be sure to give them plenty of time :) [10:33:16] oh fo sho [10:33:25] anyway, we don't commit to them until friday [10:33:28] (when i'm away [10:34:10] haha [13:14:49] a few small jobs and then the loft conversion is done with a d [13:14:51] \o/ [13:16:22] pics? [13:17:21] soonish [13:17:40] only of finished project [13:17:54] haven't got a good enough camera to photo document the 11 week journey [14:09:40] phuedx: Where do you live? [14:09:55] Deskana: london [14:10:02] phuedx: Where in London? [14:10:19] rotherhithe [14:10:23] I knew it was London, and you've probably told me more than that before, but I have no idea about London's geography. [14:10:31] ah [14:10:39] that isn't a bad thing [14:10:52] Yana once told me she lived somewhere, and I said "Where's that?" [14:11:02] She looked confused, and told me somewhere else, and I replied "Where's that?" [14:11:05] Repeat two or three more times [14:11:09] Then she eventually said "London" [14:11:16] ^ that :D [15:34:56] dbrant: do we have a sprint 59 board? I wanted to take a peek at it since I won't be able to make prioritization meeting today. [15:38:33] bearND: no, we don't yet. I'll see about creating it... [15:38:56] i got email lost [15:39:03] i have a grinder with beans half ground in it [15:39:10] sitting on my desk next to my mac [15:39:14] what have i become? [15:39:52] Less of a coffee maniac? :-) [15:47:34] i'm so ashamed [16:03:22] phuedx [16:03:25] it is time [16:07:51] kristenlans: would you mind creating the sprint-59 board, so i can start plopping stuff into it? [16:12:23] *flopping [16:24:01] dbrant: in a meeting right now, but will do at 1 PM ET! [16:47:17] jdlrobson: phuedx able to hop on the leads meeting? [16:47:41] yeah -- sorry just finishing up prioritisation meeting [16:51:18] dbrant: https://phabricator.wikimedia.org/project/board/1281/ [16:53:37] kristenlans: thanks! [16:54:05] dbrant: np! looking forward to catching up later today... [17:09:45] bgerstle_meeting: dbrant so yeh let me know if there's a task you want to pair on today or tomorrow [17:10:05] bearND: bgerstle_meeting dbrant jdlrobso_ phuedx|BATHTIME would you please tag any release cards for the roadmap board? https://phabricator.wikimedia.org/tag/roadmap/ [17:10:10] jdlrobso_: ok 👍🏻 [17:10:15] that is, for the upcoming week or two [17:10:19] ok [17:10:36] dr0ptp4kt: actually iOS release was already tagged [17:13:50] bmansurov: shoot just saw you claimed the task :-) [17:14:24] jdlrobso_: if you've already done the task, I can un-claim it. I haven't gone too far yet. [17:14:32] ok i've got the fix yeh :) [17:14:36] ok [17:18:44] coreyfloyd: we are in hangout, are you having a hard time connecting? (we all did) [17:21:20] jdlrobso_: hi! [17:21:25] hey :D [17:22:14] jdlrobso_: it seems like ext.gather.styles are not loaded on the article page? I need them b/c you can edit a collection there and the new editing header is the normal collection header [17:22:42] ext.gather.styles probably needs to get split up into sub modules then [17:22:54] what should I do? if I declare it as a dependency of ext.gather.collection.editor it will load them twice on the collection page right? [17:23:18] derpp [17:23:28] if you use addModuleStyles and then load via JS dependency yup they will load twice [17:23:38] but that's a a known accepted bug/trade off [17:24:11] jdlrobso_: ok, i'll figure something out [17:24:20] phuedx|BATHTIME, bmansurov: Is this already deployed: https://gerrit.wikimedia.org/r/#/c/215109/ It's merged, but didn't see on deployment schedule [17:24:53] kaldari: I'm not sure, phuedx|BATHTIME? [17:27:17] Interesting how beta opts in are trailing http://mobile-reportcard.wmflabs.org/#other-graphs-tab [17:27:26] is that because everyone who could see the banner opted in [17:36:09] bmansurov: do you know where those static images live/ [17:36:12] e.g. which repository? [17:36:48] jdlrobson: i was about to find out ;) i'd just copy from the website [17:37:29] sounds good. you want to take that over? [17:37:36] you seem further ahead then me :) [17:39:53] jdlrobson: I'm onto something else. I'll take it over later if it's not urgent [17:40:14] bmansurov: np. i'm still dealing with a bunch of emails and code review :) [17:40:21] k [17:48:17] bearND: how close is aude's OSM patch to being complete? (i.e. can it be done in the next sprint?) [17:48:57] kaldari: nope, it's not deployed -- i should've added it to the schedule but forgot -- meetings [17:49:27] i was confused by the patch though, i thought it was already disabled everywhere? [17:57:51] dbrant: It needs a feature flag to be alpha only. We can't move it to production until the server side OSM maps are figured out, though, which could be a long time. [17:59:14] bearND: ok, i see [17:59:57] dbrant: MaxSem and Yuri would probably know more about when the OSM server side would be available [18:01:03] dbrant: On the app side we need only a few minor things + design review. I've started working on refactoring it a little bit. It then also needs to remember to go back to the map view when rotating the device. [18:02:05] dbrant: A cool future improvement would be to add more results when one pans around, but that could be in a later iteration [18:05:13] bearND: so, do you think it's worthy of a story in the next sprint for implementing the base functionality, at least in alpha? [18:12:54] phuedx: I added it to the schedule [18:14:09] dbrant: yes, i think it would be good to at least wrap it so far that it can be merged. I don't like having a ton of WIP patches [18:14:24] bearND: cool [18:15:23] * aude waves [18:15:59] dbrant: i would like to improve the design of the markers on the map [18:16:16] and how they are handled depending on zoom level [18:18:32] aude: absolutely; we'll have the designers take a look at it, and give us feedback. [18:19:01] great [18:19:17] Hi aude :) [18:19:43] totally not in scope of the patch but would be cool to know (e.g. from wikidata), if it's instance of = school [18:19:54] then have a school icon, etc [18:20:08] for now, keep it simple ;) [18:21:31] bearND: and for editing descriptions, suppose i could poke at that also [18:23:50] leaving for the day [18:23:56] bb! o/ [18:24:01] adios joakino [18:25:03] kristenlans: the kanban session has been planned for midnight CEST... so awesome [18:25:21] anyways... :p [18:25:30] adios kristenlans! [18:31:21] * mdholloway notes bearND's point about a ton of WIP patches floating around (sorry!) [18:31:48] mdholloway: not your fault, it's rather mine [18:33:11] aude: that would be awesome. I sent you mhurd's patch for the same thing on iOS [18:33:39] thanks :) [18:34:15] we have some time on thursday and friday to work on "whatever we want" :) [18:34:31] so maybe can be these things [18:34:41] that's very nice [18:50:05] Android folks - Any idea how to reach Stephen Niedzielsky on email? [18:51:06] All my emails and cal invites to him are bouncing [18:52:06] Vibha he is sniedzielski@wikimedia.org [18:52:12] (with an 'i') [18:52:18] I learned it the hard way ;-) [18:52:37] I tried that one also [18:52:41] both are bouncing [18:52:47] Are you sure this works? [18:52:49] oh no [18:53:05] I knwo he is OOO for most of this week also. [18:57:53] kristenlans: Ok I messaged him on Phabricator. Thank you for the correction. My email must be wonky. Everything is bouncing. [19:17:58] bearND, these are Marko's slides: https://docs.google.com/presentation/d/1wzpd5CkkMhb7IrAXa-R3VVYi3ZNWU16ko1OeDsiSKF8/edit?usp=sharing [19:32:11] gwicke: Thank you. Do you happen to have a link to some good node service tests I could model mine after? [19:32:30] bearND: the template has a couple of example tests [19:32:56] and https://github.com/wikimedia/restbase/tree/master/test/features has a lot more of the same [19:40:17] gwicke: ok, thanks [19:42:32] dbrant|brb: question about this change whenever you get back: https://github.com/wikimedia/mediawiki-extensions-MobileApp/commit/1d6107be2f237f38019f4e9d0653d1c9aca1dfcb [19:43:06] mdholloway: back! [19:43:11] dbrant: sweet [19:43:33] dbrant: so, it looks like we're losing a lot of css unless we're pulling it in from somewhere else now [19:44:05] dbrant: i think stephen had a question about this too [19:45:07] mdholloway: yep, we're pulling it from somewhere else. This is in conjunction with this patch in the app: https://gerrit.wikimedia.org/r/213465 [19:45:29] dbrant: i see [19:46:50] dbrant: i've been working on a pretty substantial rewrite of that image widening patch based on mhurd's approach, so i just regenerated the css with make-css-assets.bash, but the changes looked... more drastic than i expected. so, i'm relieved now. [19:48:48] mdholloway: we should probably update the bundled CSS as part of the patch I mentioned (as Stephen suggested), so then you could base your change on top of it, and it wouldn't look so drastic. [19:57:16] dbrant: hi there, can I help with creating a list of all merged commites between alpha releases ? [20:07:12] away! [20:07:17] have a good week y'all [20:32:03] legoktm: have a second for questions about displaytitle? [20:36:23] bgerstle: probably, what's up? [20:36:46] legoktm: was just wondering where the docs are on it. not sure how to get it into search results [20:36:58] also, does it always come back as HTML? [20:37:22] it's a page property [20:37:33] under "displaytitle"? [20:37:42] i tried that on a hunch, but wasn't seeing anything [20:37:44] i can try again [20:37:58] https://en.wikipedia.org/w/api.php?action=query&titles=IOS&prop=pageprops [20:38:00] ? [20:38:31] where is it returning html? [20:38:56] oh... i thought it was for certain titles [20:39:08] like in italics [20:39:12] https://en.wikipedia.org/w/api.php?action=query&titles=IOS|Nyctereutes&prop=pageprops [20:39:13] hmm yeah [20:39:31] legoktm: https://en.wikipedia.org/w/api.php?action=query&titles=Fight_Club&prop=pageprops [20:39:43] so we can support it in plaintext [20:39:46] at least [20:39:48] for search results [20:39:54] dbrant: hopefully it won't, since the js is where most of the action is. (also gives me hope that rebasing won't be too painful.) [20:41:36] bgerstle: it's a limited set of html [20:43:57] bgerstle: might just be italics? [20:44:16] it's going through the Sanitizer and I'm not really familiar with that class [20:44:26] legoktm: hrmmm [20:45:16] I *think* all Wikipedias have $wgRestrictDisplayTitle = true; [20:45:39] nope, a few wikipedias have it false: https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php [20:45:47] in that case I think there's a bunch more stuff it could be [20:49:36] legoktm: in either case we'd want plain text for more lightweight display [20:50:04] we could parse out the text, but i'd rather let the API do that [20:50:10] since it already knows how to do text extraction [20:50:25] bgerstle: what if the point of the display title is to use italics? [20:51:30] legoktm: then we need to figure out a good trade-off [20:51:55] scrolling performance vs. title styling in search results [20:52:17] since the search results are all native atm it's not a simple thing [20:52:37] I'm not really familiar with iOS dev, but is making text in italics hard? [20:53:30] legoktm: no, but we need to decide whether or not to parse a limited subset of HTML [20:54:32] it could be a slippery slope to reimplementing a browser. again it's a question of how we do things & why. what's native, what isn't [20:55:28] legoktm: there are libraries, though: https://github.com/Cocoanetics/DTCoreText [20:57:45] but, i don't know how much those support CSS etc. [20:58:05] okay [20:58:08] j/k maybe it does https://github.com/Cocoanetics/DTCoreText/blob/develop/Test/Source/DTCSSStylesheetTest.m [20:58:24] but, it's a fair chunk of code down a path we might want to tread in the first place [20:58:33] might not want* [20:59:01] we need to do a better job of toeing the web/native line [21:18:08] bgerstle: I left a suggestion on the bug [21:40:39] vibha: hey do you have time to take a look at https://phabricator.wikimedia.org/T101175 with me? [22:06:55] mhurd - back to back meetings today [22:07:02] half hour tomorow? [22:13:12] vibha: ya! [22:13:32] vibha: want me to schedule? [22:19:56] please do! i'll be a happy kid [22:28:09] vibha: invite sent [22:34:22] ios team - full width images in the latest version are super. I can see all the details of van gogh's paintings [22:34:28] Great work here! thank you [22:34:59] Design Signoff columns for Sprint 58 for ios, android are clear [22:35:53] a few minor minor things came up for iOS, i'm working with Monte and Corey tomorrow to tackle these. [22:36:22] vibha: yay! [22:45:03] marxarelli: https://phabricator.wikimedia.org/T101190 [22:51:34] dbrant|bbl: you around? [22:51:45] mhurd: yep [22:52:25] dbrant: hey how do you get the url for the lead image you show on android? thumb and thumbwidth param in mobileview? [22:53:21] mhurd: yes, through mobileview. And we actually haven't yet switched to using thumbwidth instead of thumbsize [22:54:00] dbrant: gotcha. what thumbsize are you requesting? [22:56:28] mhurd: 640 [22:56:59] dbrant: literally the second you posted that i found it in the android code :) [23:16:12] hey jdlrobson2 [23:17:16] what if when a user was on an article, then clicked on a link in that article, we had a pop-up that suggested they add those 2 articles into a new collection [23:17:30] would that be possible?