[00:04:13] jdlrobson so i'm stepping out for a bit to eat my dinner. If you have a minute could you take a look at my regexg problem ? I'll be back to check on my patch afterwards. [00:04:36] also.. been trying to get into the cluster and my key is being denied, have to sort that out still [00:06:23] rmoen|afk: sure which patch? [00:30:22] rmoen|afk: gonna have to check tomorrow morning. Just wrapping up now [01:29:46] niedzielski: i added a question to your css patch [01:30:11] mdholloway|afk: couple comments on your js patch [01:33:44] mhurd: thanks. will review [01:34:23] niedzielski: cool! Sorry it took so long! I have to run [01:34:38] mhurd: np, appreciate the effort! see ya! [01:34:51] niedzielski: touch base tomorrow [01:34:58] mhurd_afk: sounds good [02:50:30] kaity|away: i got the icon - thanks [09:05:16] hullo [10:07:24] hi phuedx|ILL [10:07:30] are you ill ? haha [10:51:24] gonna destroy & up my vagrant, wish me luck [11:03:33] that's a bummer, what happened this time? [11:13:34] bmansurov: https://phabricator.wikimedia.org/T97988 I'm getting 60% cpu usage all the time [11:13:42] makes the macbook air a toaster [11:14:11] bmansurov: good thing is `destroy -f` and `up` take a lot less than clean start since the sources are there [11:14:17] cloning the repo is what usually takes longer [11:14:44] ohh, air [11:19:50] joakino: that's a powersafe bug in vmware + nfs vagrant [11:20:43] basically every time you suspend your mac, this will start happening [11:20:45] thedj: is there any solution? i tried disabling nfs but cpu usage was even worse [11:20:55] oh really [11:21:14] lemme check. [11:22:51] i remember i recently changed something to attempt to fix this, and i only now realize it's actually no longer happening... [11:24:07] in Vagrantfile, i changed: root_share_options[:mount_options] = ['noatime','rsize=32767','wsize=32767','async'] [11:24:15] to root_share_options[:mount_options] = ['nolock','noatime','rsize=32767','wsize=32767','async'] [11:24:44] i'm not sure if i have been using vagrant less than before, or if it fixed it :) [11:26:20] thedj: thanks, i'll try it out soon! [11:26:35] i'll test also if it only happens after suspending [12:04:21] phuedx|ILL: are you ok? [12:17:40] bmansurov: are we sure https://gerrit.wikimedia.org/r/#/c/220103/2 won't cause more visual regressions? Seems like this one could wait to after the train cut, just in case. what do you think? [12:18:35] joakino: it's used only in two special pages, both of which looked OK to me [12:23:55] bmansurov: i'm seeing this with that patch (beta) https://i.imgur.com/UWJbYLN.png, looks normal in beta cluster https://i.imgur.com/wIGWJqN.png [12:24:39] joakino: can you hard refresh the browser? [12:24:44] bmansurov: stable seems broken too https://i.imgur.com/lBzZHSn.png, works fine on beta labs https://i.imgur.com/lBzZHSn.png [12:24:46] sure [12:25:13] bmansurov: same thing, and i have dev tools open with [x] disable cache checked [12:25:20] joakino: i sec [12:27:02] joakino: something is wrong on your end, they both look ok on my machine. Can we try a different browser maybe? [12:27:22] joakino: just to double check, you applied this patch, right? https://gerrit.wikimedia.org/r/#/c/220103/2 [12:28:21] joakino: oh isee ar you talking about the title, which is bigger? [12:28:38] bmansurov: 219972 applied this one which is the follow up [12:28:39] joakino: i thought you were talking about the alignment [12:29:05] bmansurov: alignment and size on beta, alignment and extra borderbottom on title on stable [12:29:15] checking [12:29:26] css is a bitch [12:30:03] so you're currently seeing 219972? [12:34:30] bmansurov: https://gerrit.wikimedia.org/r/#/c/219972 is the one i've checked out, and i'm seeing beta: https://i.imgur.com/UWJbYLN.png, stable: https://i.imgur.com/lBzZHSn.png, but in beta cluster I see beta: https://i.imgur.com/wIGWJqN.png and stable: https://i.imgur.com/lBzZHSn.png [12:34:50] joakino: thanks, I found the issue. the fix is coming [12:34:55] ok [12:35:35] bmansurov: can you try to reproduce https://phabricator.wikimedia.org/T103500 in beta cluster? [12:48:12] joakino: yes, i see the issue ^ [12:48:24] crap [12:49:24] bmansurov: oki, i'll send an email pointing it out to see if we can get it fixed and cherry picked into 1.26wmf11 today [12:50:53] bmansurov: looks good now [12:51:11] bmansurov: do you want me to merge it? i'm sensible about the release :p [12:52:00] joakino: I think the patch fixes more regressions than it introduces (if any) [12:52:56] bmansurov: oki, gonna merge but plz keep a designer eye today and tomorrow and if they bring more problems we'll revert them [12:53:03] **designer** eye hah [12:53:07] k [12:54:44] joakino: https://gerrit.wikimedia.org/r/#/c/220107/ too [12:55:08] joakino: nm, it's another set of patches [12:55:22] bmansurov: yep, gotta go to lunch also [12:55:37] joakino: i'm off too until later [12:55:47] k see you later! [12:55:50] cya [14:23:30] joakino: hey you still having iOS simulator issues? [14:55:38] Now that everyone is awake I can ask my question. You know how the app takes the page image as defined by the page props and creates a nice square icon? Are those square icons cached anywhere? I would like to use them for something I am working on and would rather not re-invent the wheel [14:59:05] harej: The app creates the square thumbnails locally. It requests a thumbnail of a certain width (96px), regardless of aspect ratio, and crops it to a square at runtime. [15:00:34] Hmm. Does it employ any strategies in cropping? [15:02:33] harej: no, it simply crops from the center of the thumbnail, up to the width or height, whichever is smaller. [15:09:05] Hmm. Seems like something that could be recreated in CSS. Thanks! [15:18:01] coreyfloyd: i'm seeing an update to xcode now [15:18:09] coreyfloyd: i've had to upgrade to yosemite :p [15:18:15] I was on mavericks [15:18:21] i'll report later when I install it :D [15:42:15] milimetric: hey! i saw your phab update. i can schedule a meeting or now works too. whichever you prefer [15:44:39] niedzielski: i'm crazy busy until after the lightning talks [15:44:51] what time zone are you in? [15:44:52] milimetric: ok meeting it is! :) [15:46:00] milimetric: i'm on mountain time [15:46:57] milimetric: GMT-6 [15:48:18] cool, good, so my calendar's up to date, so anytime after the big block of little meetings I have just now [15:48:26] niedzielski: ^ [15:50:28] milimetric: how about 1p mountain / 3p eastern? [15:50:34] niedzielski: works [15:50:44] milimetric: ok cool [15:51:06] thanks for the help! If things were less crazy I'd probably have time to sit with it myself, but this will accelerate the solution I hope [15:53:08] milimetric: no, thank you! [16:11:34] joakino: dbrant bearND bgerstle BART delays. may not make leads meeting. joakino you able to make it, with phuedx|ILL being unavailable? also, would you guys please post notes on mobile-l? [16:19:02] coreyfloyd: mhurd_afk bgerstle bart got stuck then went the wrong way so I'm headed home for morning meetings. Should make stand up but FYI just in case. [16:19:48] mbinder: k [16:20:00] dr0ptp4kt: sorry -- i've just sent an update [16:36:21] rmoen: meeettttinggzz [16:44:25] dbrant: what's missing before we push out another release? [16:55:47] mbinder: i think we can cancel standup… both Brian and myself are in meetings at 1pm today [16:56:07] joakino: you know you want some hot yosemite action… [16:56:35] OK by me. mhurd anything you wanna discuss now or later? [16:57:19] mbinder: just had a quick hangout w corey so i'm good for now and ok w cancel [16:59:35] dbrant: i see your concern about doubling the number of event listeners on that image widening follow-up. monte raises a good point about code clarity, but it's also worth bearing in mind that unlike iOS we're not effectively running only on high-end devices with plenty of RAM. [16:59:54] dr0ptp4kt: bgerstle : that's the docker script issue: https://phabricator.wikimedia.org/T103490 [17:00:26] dbrant: i suppose i could add some profiling code, make the changes, and see [17:01:16] dbrant: i do like the way iOS have their js/less code organized, but if we wanted to do a refactor that would be for a separate patch, i think [17:15:03] dr0ptp4kt: is it OK if i miss the Reading/API services sync? i don't have anything to report [17:15:42] dr0ptp4kt: need to focus on some other stuff today, and i'm going to the "modernizing our content platform" meeting later [17:17:42] mhurd: mbinder coreylfoyd are we delaying standup? [17:17:45] coreyfloyd ^ [17:18:15] bgerstle: ya i think so [17:18:37] mhurd: ok. is it an iOS-only day? [17:18:45] bgerstle: ya [17:18:47] if so, i don't have much to add [17:19:00] we're trying to get stuff through code review and continue sprint work [17:19:14] coreyfloyd: skip standup, yay or nay? [17:19:29] one less meeting, you know you wanna! [17:19:34] bgerstle: yeah in another meeting [17:19:42] during standup? lol [17:19:53] bgerstle: yeah. actually, i'm just going to cancel it, seeing as we have the modernizing meeting with gwicke (and i think marko? if it's timezone ok?) like you said. bearND bd808 phuedx|ILL ^^^^^^ [17:19:55] alright, mhurd mbinder i'm calling it: no standup today [17:20:08] dr0ptp4kt: 👍🏻 [17:21:22] bgerstle: yep, no standup today [17:24:45] bgerstle: are you in Gabriel's meeting? [17:24:53] coreyfloyd: huh? [17:25:05] i thought that was 4pm EDT [17:25:22] ohhhhhhhhh… lol I forget the world is not on EDT [17:25:31] PDT… duh [17:25:35] what meeting are *you* in? [17:25:44] jeez i panicked for a second there [17:25:51] i just got out of a meeting with Jon/Dimitri [17:26:33] mdholloway: hmm... for the purposes of this patch, i'm inclined to say let's just keep it the way they have it on iOS (I didn't realize that this was also a direct import). The importance of maintaining consistency outweighs the (negligible) performance concern, especially if one day we hope to share JS code between our two platforms. [17:27:32] mdholloway: and yes, refactor js/less code in a future patch. [17:27:54] dbrant: sounds good. should i just make the change on the other issue you raised here (https://gerrit.wikimedia.org/r/#/c/219776/3/www/js/util.js), then, and resubmit? [17:28:03] Does anyone have time to work on https://phabricator.wikimedia.org/T96864 (Update API query continuation usage in Gather)? [17:29:11] The default will change in master later today [17:29:30] bd808: i'll pull it to the sprint board to give it visibility and we'll prioritize it [17:29:37] thanks for bringing it up [17:29:40] bd808: thanks. joakino ^ you guys got this covered? [17:30:00] bd808: yep, just answered there ^ [17:30:00] mdholloway: yes, assuming it works [17:30:17] also, bgerstle and bearND for the apps are we ready for the continuation change in the api? i'm not concerned about old versions at this point, but rather what's out there. ^^ [17:30:18] dbrant: all right, i'm on it! [17:30:19] The trivial fix would just be to explicitly use the old continuation style [17:32:45] dr0ptp4kt: AFAIK we're using "rawcontinue=" to suppress the warning [17:33:15] dr0ptp4kt: i don't even know if we're using continuation in the apps yet [17:33:28] i'll have to investigate [17:35:32] jdlrobson: meetingssszzzuuuu [17:46:00] mhurd: hey monte! i just realized my comment on https://gerrit.wikimedia.org/r/#/c/219421/ has been in draft since last night :/ i just published it. if it doesn't make sense or you'd like to chat about it, please give me a shout [18:31:54] i'm gonna go take a nap now [18:32:01] phuedx|ILL: classic x files or The X-Files: I Want to Believe [18:32:08] classic x-files [18:32:09] taking a moment to stretch my legs [18:32:12] bb phuedx|ILL [18:32:18] ugh [18:32:19] feel better phuedx|ILL [18:32:26] my joints ache all over [18:32:28] phuedx|healthy [18:32:37] i'm feeling better -- i just need to rest up for tomo [18:32:39] joakino: i wrote you a patch for the gather bug you wanted fixed [18:32:41] it has tests!! [18:32:48] then i'll be all like "woo sign off!" [18:32:52] phuedx|ILL: you deserve a hot bath and a nap friend. Take a load off :) [18:32:57] jdlrobson: \o/ [18:33:06] a bath!? [18:33:11] i hadn't even considered [18:33:14] oh my… [18:33:14] yeah [18:33:21] baths are great for achey joints and whatnot [18:33:34] jdlrobson: do you have people to help you with that patch? I'm going to head out to try and attend the content service talks later [18:33:35] i just steal everyone else's ideas [18:33:40] alright -- gone [18:33:43] see y'all tomorrow [18:33:50] maybe some epsom salt [18:33:54] see ya [18:34:14] see you phuedx|BATH [18:34:19] later [18:34:35] joakino: i guess rmoen or bmansurov can look at it :) https://gerrit.wikimedia.org/r/220169 [18:34:42] FlorianSW: how are you? [18:36:59] jdlrobson: fine, thanks, and you? :) [18:37:07] mobileweb: could someone kindly direct me to the wiki page where retro notes are added? I'd ask Kristen but she is training. :) [18:37:57] mbinder: isn't that the etherpad? [18:38:04] idk :/ [18:38:13] joakino: yes, though I'm simply trying to archive it [18:38:24] FlorianSW: i'm good :) mbinder https://www.mediawiki.org/wiki/Mobile_Web/Team/Retrospectives [18:39:05] jdlrobson: how are we going to handle the renaming? should we rename mobile_web to reading_web and all its subpages or should we put a banner of deprecated and create new pages? [18:39:41] jdlrobson: hmm? :? [18:41:05] jdlrobson: what happened there? -> https://gerrit.wikimedia.org/r/#/c/220169 [18:41:09] gonna test it locally, looks great [18:41:24] joakino: what do you mean what happened? [18:41:39] FlorianSW: sorry i was combining two responses hehe [18:41:50] jdlrobson: how did that break? we removed that code in a previous patch? [18:41:52] jdlrobson: :D [18:42:01] FlorianSW: i reached out to the editing team around editing in mobile. It seems like they might want to rebuild it rather than refactor it. This is why I haven't merged the toolbar patch yet [18:42:07] I'm waiting to hear back from them. [18:42:16] joakino: i guess it was when we refactored PageList to use Page [18:42:24] FlorianSW: so sorry it's taking ages to merge :-/ [18:42:52] jdlrobson: ah, ok, yeah, unfortunately :( I hope, that the rebuild doesn't take toooooo long :) [18:43:07] kaity: can you provide some thoughts on https://phabricator.wikimedia.org/T102210 ? [18:43:25] FlorianSW: i suspect when desktop VE launches there will be a lot of movement :) [18:44:12] jdlrobson: I hope, i hope ;) VE in current state isn't really useable on mobile phones (have you seen my comment on the task?) [18:45:05] which task FlorianSW ? [18:45:21] jdlrobson: https://phabricator.wikimedia.org/T85630 [18:45:27] it's not as easy as mentioned :D [18:45:41] if we look at the design ;) [18:46:12] yeh i think edsanders and nizar ( nzr ?) is working on that as we speak from what i understand (but not 100% sure) [18:48:38] jdlrobson: i think your patch always puts all the results as ☑️ [18:48:52] jdlrobson: when i search to add another item it appears checked on [18:48:57] jdlrobson: and i can't add it [18:49:01] joakino: really... oh doh. Needs more tests then I guess ) [18:49:03] FlorianSW: there's https://phabricator.wikimedia.org/T93325 for new design. [18:49:05] jdlrobson: haha [18:49:06] lemme take a look [18:49:14] jdlrobson: gonna disappear now [18:49:21] did you -1 it joakino ? [18:49:25] on it [18:51:39] k now [18:51:44] gonna go to the pool quickly [18:51:48] it's so hot here [18:53:18] nzr: thanks for the task! I'm happy to see this happen :) [18:53:56] FlorianSW: yeah, i have more things in the works. which i will post today or tomorrow [18:54:14] btw thanks bd808 for the suggestions on the vagrant cpu usage task, i'm not sure if it was the upgrade to yosemite, the destroy and up, or all together but it's more than awesome compared to the last 6 months [18:54:42] nzr: subscribed :) [18:54:48] maybe i can help in some way. [18:54:57] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Help:Wiki_markup&useskin=minerva#Text_formatting [18:55:10] syntaxhighlighting for mobile [18:55:12] :) [18:55:25] thedj: yeah! \o/ [18:56:13] thedj: do you have the task in your head? I suspect, that the user-notice tag is missing and this is definitly something for Tech news :) [18:56:48] https://phabricator.wikimedia.org/T100563 [18:57:15] there will be one for all the pygments changes i assume. but perhaps we an extra note on mobile is a good idea. [18:59:54] thx thedj! Added a comment and tag :) [19:03:27] jdlrobson: thanks for the link. Team: do you use the readership internal mailing list for retro discussion, or another list? [19:12:07] bearND: i would like to get this into next beta, if possible: https://gerrit.wikimedia.org/r/220133 [19:13:02] dbrant|brb: ok, I'm checking it out [19:13:41] (approved by design) [19:23:38] dbrant|brb: check out my comment [19:35:43] jdlrobson: does the wikidata role also enable the 404 handler? [19:35:56] tgr: i have no idea.. [19:37:10] at a glance it does not, in which case it would be a different issue [19:37:36] jdlrobson: anyway there is a workaround towards the beginning of that ticket [19:37:47] basically just disable thumbnail caching [19:39:04] jdlrobson: can you verify whether instantcommons is broken in the default wiki (127.0.0.1:...) or just some non-default wiki like mobile.wiki.local...? [19:41:49] bgerstle: when you have a min - can you take a look at my comment on https://phabricator.wikimedia.org/T97780#1393885 ? [19:47:11] etonkovidova: responded, good catch on the titles [19:47:14] should be an easy fix [19:50:39] bgerstle: ok, good :) [19:52:10] coreyfloyd: I was told that I need to verify with you if we totally nixed testing/support for iOS 6? True? [19:55:51] etonkovidova: going forward, yes [19:55:55] we're no longer supporting iOS 6 [19:56:02] 4.1.5 is the last one that *supports* iOS 6 [19:56:10] bgerstle: hurray! thx [19:56:51] etonkovidova: we're going to release a "lite" app that goes all the way back to iOS 3 though [19:56:59] just because i know you love to do legacy OS regression testing [19:57:02] (j/k ;-P) [20:04:29] > tgr it's just for non default wikis for me [20:04:38] wow where's Deskana ;-) [20:05:00] jdlrobson: East Bay! [20:05:03] jdlrobson: heading off to lunch, need anything before I go? [20:05:08] hah it looks so sunny [20:05:17] rmoen: nope. will take a look at your patches this afternoon [20:05:21] just in a meeting [20:05:21] jdlrobson: We get that in the East Bay. ;-) [20:05:24] ok [20:05:46] jdlrobson: if you can help with the regex that would be rad. I spent an hour fiddling with it yesterday [20:05:54] see you in a bit [20:07:39] etonkovidova: yes, as of the this release, iOS 6 is unsupported [20:08:16] bgerstle: is there a youtube stream for the content talk? can't join the hangout [20:08:18] coreyfloyd: as bgerstle told me too - it's good :) [20:09:19] joakino: they're putting it "on air" now [20:09:29] ok thx bgerstle [20:09:56] bd808: gwicke is there a new link yet? [20:10:34] It's supposed to show up in the etherpad when they have it [20:10:51] I don't see it yet [20:10:55] assuming the etherpad doesn't blow up [20:11:25] bgerstle: i joined the hangout lol [20:11:38] wat [20:12:00] * bgerstle that moment when you realize you haven't brushed your teeth yet today #wfhlife [20:12:15] joakino: what hangout? [20:12:27] bgerstle: content platform [20:12:35] that's the old one, IIRC [20:12:50] the link has landed! http://youtu.be/RcE2kecrsIk [20:13:02] wat [20:13:17] i only have video when i go to the G+ hangout via the YT page [20:14:05] bgerstle: ok on the youtube stream now [20:14:12] i'll watch while i make dinner [20:14:18] 'modernizing' links: https://plus.google.com/hangouts/_/hoaevent/AP36tYdub-Rs4mI_4UjTEzTgU7GKBkgjV5s0kXASoA9Tno4gJK34_Q or http://youtu.be/RcE2kecrsIk [20:14:22] joakino: watchya making [20:14:35] bgerstle: pizza :D [20:14:41] tuning in... [20:14:50] + redwine (double :D) [20:14:56] dr0ptp4kt: such human readable, much URL [20:15:03] very URL* [20:15:05] i'm bad at doge speak [20:15:19] joakino: 🍕🍷 [20:15:42] emoji level: Master [20:16:08] 💪🏻 [20:16:30] joakino: i thought all you ate was paella and patatas bravas [20:17:08] bgerstle: hahah [20:17:11] real lol [20:19:26] jdlrobson: the calls were changed from self:: to static:: because on stubbing static functions, mock funtions were not being called with self:: [20:19:33] From here http://php.net/manual/en/language.oop5.late-static-bindings.php [20:19:43] in the tests [20:20:29] dr0ptp4kt: is there an IRC room for people not in the hangout? [20:23:10] dbrant: hey dmitry. apologies if this was already asked and i missed it, but what's the intended logic for the page icons in the webview tabs? they don't seem to match up on the main page [20:24:44] dbrant: for example, the main (en) page shows a honeybee for the icon. i think the featured article image would be more intuitive [20:25:59] niedzielski: that's actually an issue in the mobileview api (or rather the pageimages api)... it returns the wrong image for the Main Page. [20:26:32] niedzielski: i believe there's a phab ticket open for this... but i'll check [20:26:36] joakino: you joining this hangout in the end? [20:26:50] codezee: will take a look shortly [20:26:57] niedzielski: you'll notice the same behavior in History, as well [20:27:46] dbrant: i see. thanks! [20:33:04] jdlrobson: i'm looking at the stream while i make dinner [20:33:11] ok cool :) [20:33:20] lemme know if you want me to speak up about anything [20:33:30] jdlrobson: is there an irc channel? [20:33:41] jdlrobson: why html or wikitext and not structured data types [20:33:57] jdlrobson: why not xml instead of html if we want to be really semantic [20:35:14] bgerstle: ^? is there an irc channel for this? [20:35:39] joakino: some people are apparently chatting on -staff (and potentially -office)? [20:35:45] ok [20:35:45] no idea which one is actually being monitored [20:43:00] joakino: not that i know of [20:54:56] jdlrobson: how do you triage things in phab? [20:55:25] jdlrobson: do you mostly go be emails, or do you go to your open tasks? [20:55:36] jdlrobson: or the mobile web workboard? [20:56:05] kaity: generally the mobile web sprint and i look for my face but i also use emails for where my name is mentioned [20:56:44] jdlrobson: im looking at my open tasks now, noticing a lot of new stuff [20:56:44] kaity: also https://phabricator.wikimedia.org/search/query/yOjQYvlGvYMV/#R [20:56:58] these are all assigned to you [20:57:09] jdlrobson: notifications suck :( I dont think I get an email unless im mentioned [20:57:21] cant figure out how to turn on emails for assigned to me [20:57:22] you don't seem to be getting those e-mails... :) [21:00:25] jdlrobson: I get them, I think its just so many and I have to figure out which ones actually have to do with me [21:02:18] dbrant bearND mdholloway: anyone else seeing the translations tests failing on master? [21:18:37] kaity: also what works nice is being in #wikimedia-feed, when someone mentions you in a phab task it will ping you on irc. If your phab name differs from your irc nick, you can add your phab name to your irc highlights [21:20:18] thanks rmoen [21:20:59] bmansurov: you don't have to ping design, just ping me [21:21:15] kaity: will do [21:21:30] bmansurov: if pinging design worked I think it would email everyone on the design team, but I think it doesn't email anyone [21:21:52] kaity: isn't there a design board where a task shows up when I ping it? [21:23:17] bmansurov: Yes, I see a few people using it, but no one is in charge or triaging it [21:44:48] rmoen: Cool I tried out the wikimedia-feed [21:45:31] rmoen: does it bother you that it pings whenever you make a comment? I think I'll get used to it though [21:45:44] kaity: its especially helpful if people mention you in phab tasks during the day. . But then with irc-cloud, you'll never miss a ping so you basically don't need the emails from phab then [21:46:04] unless people are assigning you tasks [21:46:46] rmoen: good idea :) [21:46:52] kaity: pings from wikimedia-feed don't bother me because I know they are not urgent irc pings. they are just alerts that things have changed in phab [21:46:57] or on patches [21:47:18] i just go to them when i have a free moment [21:47:59] hey bmansurov [21:48:07] yes [21:48:11] jdlrobson: if you want to test the new flagging patch without reinstalling the database you can run this snippet: https://gerrit.wikimedia.org/r/#/c/212593/24..25/schema/archive/add-gl_list-flag-columns.sql [21:48:12] do you want to work over hangout for https://phabricator.wikimedia.org/T101044 [21:48:33] sure [21:48:38] bmansurov: you can screenshare and we can look at the edge cases live [21:48:48] ok [21:49:34] bmansurov: i can in like 5 min [21:49:51] kaity: ok, but my day ends in 10mins [21:50:04] kaity: i think we can manage in 5-10 mins [21:50:15] niedzielski: thank you. I see the test failure, too. I'll fix it. [21:50:57] bearND: thanks! let me know if you want me to take a look at it. i'm just putting a closing comment on the wikipedia zero test [22:01:02] bgerstle: sorry, just saw your question about an irc channel. looks like you guys started talking on the staff channel [22:01:10] yeah [22:23:32] jdlrobson: is there another script beyond Barry and CLI gerrit that actually reads a feed from gerrit and decides what to run? or are you doing that manually [22:26:27] (maybe you can just add CirrusSearch to some list instead of me setting up a BarryII? :) [22:35:49] jdlrobson can you confirm if red links are enabled now? [22:40:45] ebernhardson: currently manually due to a url encoding issue on https://gerrit.wikimedia.org/r/changes/?q=project:" + project +"+AND+status:open+AND+-label:Code-Review%3D-1,user%3Dself&O=1 [22:41:13] (that url should retrieve all patches that Barry hasn't yet reviewed -1 or +1 [22:41:31] ebernhardson: i'm working on generalising the script and writing up where i'm at if you are interested in using it elsewhere [22:46:59] dbrant|bbl: hey are you around? [22:47:18] dbrant|bbl: I have the android build from yesterday but I don't see link preview [22:52:17] kaity: hey kaity. i might be able to help you out if you're in a bind [22:52:29] niedzielski: oh cool thanks [22:52:34] its not urgent [22:52:41] kaity: are you using the alpha build? [22:57:15] niedzielski: yes [22:57:37] 2.0 103-alpha-2015-06-22 [22:58:22] kaity: the link previews are enabled randomly at install time. the easiest way to flip them back on is to wipe your app data or uninstall and reinstall. i can detail the former if you'd like to take that approach [22:58:42] niedzielski: oh [22:59:02] for a/b testing? [22:59:11] kaity: yep! [23:00:44] niedzielski: i reinstalled and still don't get it, should i keep trying? [23:01:08] kaity: yeah. i think the odds are 25%, 25%, and 50% for style 1, 2, and none [23:01:50] kaity: it might be faster to clear data. it's under app settings -> wikipedia alpha [23:03:04] niedzielski: i uninstalled but i now i get a message that it can't open file [23:03:37] kaity: the downloaded apk file? :/ i've seen that before but i thought it was just my device [23:03:57] ya [23:04:06] kaity: is there a particular style you want? i can email you an apk that's hardcoded [23:04:21] niedzielski: sure, the one with image thumbnail [23:04:28] thankyou! [23:05:15] kaity: np, i'll send one over shortly [23:16:18] niedzielski: got it working, thanks! [23:16:30] kaity: sweet! [23:18:12] Great construction next door. bang bang bang with a hammer... [23:26:35] mhurd: image widening breaks the first image under "counties of england" even in the iOS app, the one with all the overlaid links. just checked on the production version on a friend's iPad. [23:27:55] mdholloway: hey would you mind throwing an invite my way for maybe tomorrow to chat about it? been waaay bogged down this week so far... [23:28:22] mdholloway: in middle of review marathon :) [23:28:30] mhurd: sure thing, i think i have an easy fix but a sanity check would be welcome [23:28:40] mdholloway: cool thanks! :) [23:28:44]