[00:50:39] <niedzielski>	 bearND dbrant|bbl: sent out some prelim release notes. i'll push the beta, r alpha, and send out the beta mail once you've had a chance to review
[00:51:03] <bearND>	 niedzielski: just sent a reply
[01:10:00] <mhurd>	 niedzielski: ya it looks like https://gerrit.wikimedia.org/r/#/c/219421/1/styles/editlinks.less will break on iOS :(
[01:10:25] <niedzielski>	 mhurd: :(
[01:10:53] <niedzielski>	 mhurd: just a moment. wrapping up an email
[01:11:34] <mhurd>	 niedzielski: i could be wrong. also, if i can repro the bug, we could try adding the same wrapper and see if that fixes it on iOS too
[01:13:01] <niedzielski>	 bearND: thanks! reply sent!
[01:13:35] <niedzielski>	 mhurd: hm, did you see the corresponding javascript changes?
[01:15:45] <mhurd>	 niedzielski: ya, we don't have that same edit_section_button_wrapper bit on iOS. in fact, that part is build with native code not js on iOS... trying to repro bug based on the phab ticket report atm...
[01:15:55] <mhurd>	 *is built*
[01:27:48] <dbrant>	 niedzielski: bearND: has the eagle landed?
[01:28:26] <bearND>	 dbrant: just hashing out the what's news section, see email
[01:28:57] <niedzielski>	 dbrant bearND mhurd: oop, dinner has arrived. be back in an hour
[02:07:55] <niedzielski>	 dbrant: just responded. can i use the interim prod release notes for the "r" alpha release?
[02:08:09] <dbrant>	 niedzielski: yep, sure
[02:09:16] <niedzielski>	 dbrant: okey dokey.  i'll push the beta, r alpha, and send out the beta mail unless there's any objections. /cc bearND|afk mdholloway|afk 
[02:10:06] <dbrant>	 niedzielski: vaya con dios
[02:21:40] <niedzielski>	 dbrant bearND|afk mdholloway|afk: ok all buttons have been pressed! thanks everyone for all the help!
[02:22:17] <niedzielski>	 mhurd_afk: i'll touch base with you tomorrow
[02:22:26] <dbrant>	 niedzielski: thanks for pushing it through!
[02:22:40] <niedzielski>	 my pleasure!
[02:42:30] <bearND>	 niedzielski: \o/ thank you!
[02:42:56] <niedzielski>	 :)
[08:39:27] <joakino>	 morning!
[08:58:52] <phuedx|AFK>	 hey joakino 
[08:59:00] <joakino>	 sup phuedx 
[08:59:07] <phuedx>	 oh y'know
[08:59:08] <phuedx>	 the usual
[08:59:31] <phuedx>	 did you know that linkin park's "hybrid theory" was released in 2000?
[08:59:54] <phuedx>	 i listened to that album obsessively for most of that year
[09:01:25] <joakino>	 god i'm old
[09:01:33] <phuedx>	 it's aged pretty well
[09:01:36] * phuedx is listening to it now
[09:01:42] <phuedx>	 joakino: i hear you
[09:01:48] <phuedx>	 aren't you like 40 or something?
[09:01:51] <joakino>	 phuedx: damn you i'm gonna have to listen to it now
[09:03:36] <joakino>	 dude hybrid theory was my adolescent time ihateallofyouandtheworldfuckyou OST
[09:07:13] <phuedx>	 for me it was dark days by coal chamber
[09:07:30] <phuedx>	 and sinch's eponymous album
[09:23:53] <phuedx>	 joakino: dude, what's up with the styles on: http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Gather/all/public&lstcontinue=20150623112529%7C451&continue=-%7C%7C
[09:24:22] <phuedx>	 (view on mobile)
[09:24:58] <phuedx>	 after clicking the view more collections button at the bottom of /all/recent
[09:27:23] <joakino>	 phuedx: what should I see?
[09:27:40] <joakino>	 ohhh
[09:27:45] <joakino>	 phuedx: i know what's up
[09:27:59] <phuedx>	 s/public/recent in the url, right?
[09:28:22] <joakino>	 phuedx: the no-js pagination button is showing as in /all/public, because it was never adapted to the new view /all/recent (and we havent tested without JS)
[09:28:46] <phuedx>	 you'll find that i'm a real shit (sometimes) when it comes to technical sign off
[09:28:55] <joakino>	 that's good
[09:29:39] <joakino>	 the problem is we didn't roll the feature properly and with all the template kerfluffle and the continuous releasing it's been rushed out
[09:33:59] <phuedx>	 i understand
[09:34:13] <phuedx>	 i think we all do on this one
[09:34:27] <phuedx>	 no post-mortem required -- let's just fix the bug and let it roll out
[09:54:25] <joakino>	 phuedx: gonna have "breakfast" with the lady
[09:54:27] <joakino>	 bbiab
[09:54:33] <phuedx>	 cool
[09:54:42] <bmansurov>	 hello guys
[10:04:27] <phuedx>	 hey bmansurov 
[10:07:33] <joakino>	 i'm back
[10:07:44] <joakino>	 hi bmansurov 
[10:08:06] <bmansurov>	 we shouldn't have closed https://phabricator.wikimedia.org/T103213 as fixed
[10:08:07] <bmansurov>	 it's not
[10:08:18] <bmansurov>	 writing a comment on it
[10:08:29] <joakino>	 bmansurov: phuedx: what do you guys think about moving friday's standup somewhere else? i hate it
[10:08:41] <bmansurov>	 fine by me
[10:08:45] <phuedx>	 joakino: that was a fast lunch
[10:09:02] <phuedx>	 bmansurov: it's not?
[10:09:11] <joakino>	 phuedx: not lunch you brit, here is late breakfast time (noon) haha
[10:09:11] <phuedx>	 i couldn't reproduce the bug on bc
[10:09:12] <bmansurov>	 nope
[10:09:24] <bmansurov>	 phuedx: they're just masking it
[10:09:31] <bmansurov>	 they haven't fixed it
[10:11:40] * phuedx can't help but feel that this is going to turn into a philosophical argument
[10:11:52] <phuedx>	 bmansurov: to what end?
[10:11:59] <phuedx>	 moving the standup that is
[10:12:00] <bmansurov>	 phuedx: updated the task
[10:15:12] <phuedx>	 ta
[10:15:55] <joakino>	 phuedx: to what end moving the standup?
[10:16:02] <phuedx>	 bmansurov: by the way, i signed it off because i was satisfied that the visual bug was fixed
[10:16:23] <phuedx>	 but discussions about the implementation are always welcome
[10:16:26] <bmansurov>	 phuedx: sure, not blaming you
[10:16:31] <phuedx>	 i know
[10:16:34] <phuedx>	 but you asked why
[10:16:37] <joakino>	 phuedx: do you want me to update https://phabricator.wikimedia.org/T103496 with the js-disabled pagination problem as i did last time? or do we have a new one
[10:17:01] <joakino>	 a new task that is
[10:17:13] <phuedx>	 joakino: we don't have a new task yet
[10:17:23] <phuedx>	 just trying to write down a bug with https://phabricator.wikimedia.org/T101202
[10:17:25] <phuedx>	 then i'll create one
[10:17:30] <phuedx>	 unless you've got time? ;)
[10:18:01] <joakino>	 i'll make a new one then
[10:19:43] <joakino>	 phuedx: can you rename https://phabricator.wikimedia.org/tag/readership-web-next-sprint-50-x/ to reading-web-50-x-files and send an email? I don't have phab powers
[10:20:00] <phuedx>	 joakino: sure
[10:23:12] <joakino>	 thx!!
[10:32:35] <phuedx>	 joakino: you should ask aklapper to add you to the triagers project
[10:32:43] <phuedx>	 since you're po
[10:32:55] <phuedx>	 honestly most people should be in it
[10:33:06] <phuedx>	 (i feel)
[10:39:04] <joakino>	 phuedx: i'll send him an email
[10:39:13] <joakino>	 been testing me some phabricating https://phabricator.wikimedia.org/T103975
[10:40:08] <phuedx>	 joakino: haha
[10:41:55] <bmansurov>	 phuedx:  do you think I should move https://phabricator.wikimedia.org/T103213 to the -1 column? or should it still stay on the ready for signoff column?
[10:42:04] <bmansurov>	 phuedx: to me it needs more work
[10:42:13] <phuedx>	 bmansurov: to others it might not
[10:42:18] <phuedx>	 it's under discussion
[10:42:25] <phuedx>	 i'm happy to have it in the sign off column
[10:42:38] <phuedx>	 jon and rob both check their phabricator pings as religiously as the rest of us
[10:42:58] <bmansurov>	 ok as long as the main issue doesn't get ignored, i'm fine
[10:44:32] <joakino>	 phuedx: can you explain what's up with #roadmap on phabricator? (eg: https://phabricator.wikimedia.org/T94713)
[10:44:37] <joakino>	 is that something new?
[10:44:47] <joakino>	 i've just started seeing it poop in several places
[10:48:54] <phuedx>	 ?
[10:49:22] <phuedx>	 joakino: define "poop in several places"
[10:50:11] <joakino>	 phuedx: i've seen it mentioned in an email and a couple of phab tasks, but i'm not sure what its purpose is, and if it is something new we do and how it works
[10:50:53] <phuedx>	 it's for notifying releng (and possibly other stakeholders) of bigish changes that are going out, i think
[10:51:29] <phuedx>	 adam manages it with greg during scrum of scrums
[10:51:35] <joakino>	 aah ok
[10:51:44] <joakino>	 thx!
[11:58:19] <phuedx>	 gonna take a break for lunch
[12:04:10] <phuedx|NOM>	 running browser tests while i'm away :)
[12:27:29] <joakino>	 phuedx|NOM: I just saw from the alpha-beta header task from a jdlrobson comment this  https://phabricator.wikimedia.org/p/pizzzacat/ haha
[12:27:37] <joakino>	 such awesome nickname and avatar
[13:22:42] <phuedx>	 lol
[13:40:33] <bgerstle>	 coreyfloyd: you around?
[15:26:15] <dr0ptp4kt>	 joakino: phuedx the #roadmap board is a board for 'changes of note' / 'releases'. yeah, greg-g and i and some others go over it on thursday mornings sf time; the basis for it is to alert people of potential issues so that we can put the brakes on if needed. there's also a scrum of scrums board, https://phabricator.wikimedia.org/tag/sos/board/ , which
[15:26:15] <dr0ptp4kt>	 engineering leads / managers (depending on the team) go over somewhat, although in practice for the scrum of scrums most of the time is spent looking at the scrum of scrums etherpad - the scrum of scrums is on wednesday mornings sf time. for me, it's most helpful if the eng product owner and tech lead add stuff to the scrum of scrums etherpad plus the
[15:26:15] <dr0ptp4kt>	 phabricator #roadmap board; i prefer if we get this stuff entered on tuesday morning sf time when we do the reading eng leads meeting just to make it predictable
[15:31:11] <greg-g>	 #roadmap == used by chickens (like me), #sos == used by pigs :)
[15:33:54] <phuedx>	 lol
[16:08:36] <kristenlans>	 coreyfloyd: jonkatz https://etherpad.wikimedia.org/p/Q1_Epic_and_story_creation
[16:12:46] <niedzielski>	 kristenlans: hey! can you remind on the guidelines for reading showcase? for example, would i expect dmitry to demo browser tabs because it's neat or not to demo it because it's prominent?
[16:15:17] <mdholloway>	 niedzielski: hey stephen, is the latest patch set here just a rebase or are there other changes? https://gerrit.wikimedia.org/r/#/c/219239/
[16:15:58] <niedzielski>	 mdholloway: hey! rebase
[16:17:15] <mdholloway>	 cool, i'm fine with +2'ing then.
[16:19:41] <niedzielski>	 mdholloway: sweet! i've been trying to leave a comment when a change is a rebase
[16:20:49] <mdholloway>	 niedzielski: yeah, i saw that -- so if you say "rebased" then it's only a rebase with no other changes?  if that's the case than i'll use that understanding going forward
[16:22:03] <niedzielski>	 mdholloway: that's what i've been trying to do. i've probably slipped up before but i endeavor to keep the comments accurate
[16:36:27] <joakino>	 dr0ptp4kt: ok noted, thanks!
[16:44:42] <jdlrobson>	 phuedx: can we talk about vhttps://gerrit.wikimedia.org/r/#/c/217757/7/resources/ext.gather.collection.contentOverlay/CollectionsContentOverlay.js super quick?
[16:45:11] <jdlrobson>	 we use .options method in MobileFrontend all over the place. Is the issue just with the consistency (i.e. should port the other icons over too) or with the approach in general?
[16:57:59] <rmoen>	 jdlrobson, phuedx: I'm interested in following the discussion around icons.
[17:00:16] <phuedx>	 jdlrobson: Icon.template is non-standard though, right?
[17:01:43] <jdlrobson>	 phuedx: joakino ping standup
[17:01:55] <phuedx>	 we know we know!
[17:27:42] <phuedx|AFK>	 BATHTIME
[17:27:56] <rmoen>	 +1
[17:28:53] <rmoen|coffeetime>	 brb 5 min
[17:34:24] <niedzielski>	 mhurd_afk: open most of the day so just ping me whenever you're free
[17:41:25] <joakino>	 phuedx|AFK: I'm not sure why but I think the Readership term creeping in everybody's emails originated on you're emails when we were still split haha
[18:00:33] <vibha>	 etonkovidova: Apologies for cancelling our QA meeting today. I'm out sick. There are 2 iOS stories in Sprint 59. can you sync up with kaity|away at some point please?
[18:01:23] <etonkovidova>	 vibha: no worries :) will chat with kaity. Take care! 
[18:01:34] <vibha>	 thank you Elena :)
[18:05:19] <mhurd>	 niedzielski: thanks will do!
[18:12:00] <joakino>	 heading out
[18:12:06] <joakino>	 have a nice weekend yall
[18:15:21] <aharoni>	 Hallo.
[18:15:22] <aharoni>	 Gather-collection-content-tutorial-heading.
[18:15:35] <aharoni>	 Does it support {{GENDER}}?
[18:16:34] <aharoni>	 jdlrobson, tgr|away ^
[18:16:49] <rmoen>	 joakino: c-ya
[18:16:56] <aharoni>	 and for that matter,
[18:17:21] <aharoni>	 Gather-collection-content-tutorial-subheading, Gather-overlay-search-tutorial-heading, and Gather-overlay-search-tutorial-text
[18:19:01] <jdlrobson>	 aharoni: not sure we're still working on this right now, it's a new feature. @rmoen would have the best idea
[18:19:23] <jdlrobson>	 @aharoni we are still waiting for feedback from you on a bug https://phabricator.wikimedia.org/T102413
[18:19:48] <aharoni>	 "not sure we're still working" kinda contradicts "it's a new feature" :)
[18:19:58] <aharoni>	 looking at that flow thing
[18:21:13] <aharoni>	 is the fix to https://phabricator.wikimedia.org/T103158 live anywhere?
[18:22:27] <rmoen>	 aharoni: I'm not sure I fully understand how the messages could better support gender.   Could you please put feedback on the change or the task?   New feature / still working on it means it was merged yesterday and there are still possibly some things to work out.
[18:23:31] <aharoni>	 rmoen: messages that have imperative verbs should support gender, because in some languages imperative verbs are different for men and women
[18:23:48] <aharoni>	 And all these messages have imperative verbs.
[18:24:43] <aharoni>	 Usually in MediaWiki messages JavaScript are aware of the current user's gender, but this is supposed to run in mobile context, and I'm never wure whether the usual JavaScript/ResourceLoader conventions apply there.
[18:25:00] <aharoni>	 s/wure/sure/
[18:27:21] <rmoen>	 admittedly, I'm (we) are no experts on language.  I assumed that the i18n messages that needed gender support would just have them in the messages themselves ?  AFAIK resourceLoader conventions apply to mobile
[18:27:45] <rmoen>	 as we are using RL
[18:28:53] <ebernhardson>	 rmoen: the gender of the user isn't handled transparently, it needs to be passed as a parameter to each message that uses gender
[18:29:26] <aharoni>	 ebernhardson, rmoen - in JavaScript there's a shortcut - {{GENDER:|he|she}}
[18:29:44] <aharoni>	 if you just don't pass anything, it will use the current user's gender
[18:29:52] <ebernhardson>	 ahh, thats awsome didn't know that
[18:30:25] <rmoen>	 I'm confused as {{GENDER:|he|she}} looks like wikitext not javascript
[18:30:39] <rmoen>	 sorry maybe i'm missing something but i thought that goes in the i18n msg
[18:30:53] <aharoni>	 in English "you" doesn't have gender, and neither does "Please enter a name for this collection", and second person is much more frequent in messages than third,
[18:31:00] <aharoni>	 but in some languages second person has gender.
[18:31:15] <aharoni>	 "he" and "she" can be common in logs, for example.
[18:31:31] <aharoni>	 rmoen: it's neither wikitext nor JavaScript, it's message syntax.
[18:31:47] <rmoen>	 ahh but this to me looks like a template  {{GENDER:|he|she}} no  
[18:31:50] <Krenair>	 rmoen, JavaScript as in the message is parsed by MediaWiki's javascript code for messages
[18:32:03] <Krenair>	 That's not a template
[18:32:10] <aharoni>	 it's probably inspired by MediaWiki's frequent use of {{}}
[18:32:13] <Krenair>	 it's more like a magic word
[18:32:16] <rmoen>	 Yes but it looks like one
[18:32:17] <aharoni>	 yeah
[18:32:18] <Krenair>	 but definitely not a template
[18:32:38] <rmoen>	 I'm not arguing that it is a template.  I'm attempting explaining my confusion 
[18:32:41] <rmoen>	 to ^
[18:32:50] <aharoni>	 message syntax as used in JavaScript and PHP is mostly the same, but the parsers are implemented separately and there are subtle differences.
[18:33:06] <aharoni>	 AFAIK {{GENDER:|he|she}} can't be used on the PHP side.
[18:33:20] <aharoni>	 I might be wrong. Even I don't know all the subtelties :)
[18:33:36] <Krenair>	 I seem to recall something like {{int:}} only dealing with lowercase messages on one side
[18:34:12] <aharoni>	 In any case... I guess I'll try using {{GENDER:|}} in Gather and hope for the best.
[18:34:15] <aharoni>	 It's beta ;)
[18:34:26] <rmoen>	 It seems that tasks need to be created to provide gender support AFAIK we aren't doing it anywhere in Gather.
[18:34:42] <rmoen>	 Yeah its beta and on a handful of wikis, english primarily
[18:34:46] <aharoni>	 Maybe it just happens to work by magic :)
[18:34:54] <aharoni>	 And more importantly, Hebrew \o/
[18:36:11] <rmoen>	 aharoni: correct.  could you please file bugs for the messages that need fixed ? 
[18:36:24] <rmoen>	 or that need gender support
[18:36:32] <aharoni>	 ok
[18:39:14] <phuedx|AFK>	 yo
[18:39:28] <phuedx|AFK>	 joakino: i think so too!
[18:39:38] <phuedx>	 i started calling it the good ship readership
[18:39:42] <aharoni>	 jdlrobson: can I test https://phabricator.wikimedia.org/T103158 live with my phone anywhere?
[18:39:45] <phuedx>	 then klans picked it up too
[18:54:32] <phuedx>	 joakino: readership was the name given to the team that was wikigrok!
[18:54:35] <phuedx>	 it wasn't me!
[18:54:36] <phuedx>	 woo!
[19:50:14] <jdlrobson>	 aharoni: sorry for the late reply - that should be fixed
[19:50:37] <jdlrobson>	 aharoni: you just have to try multiple urls from google or the url in the description
[19:53:49] <jdlrobson>	 tgr|away: "GatherAutohideFlagLimit" can we make it so that -1 turns it off?
[19:54:00] <jdlrobson>	 i don't want us autohiding collections until the interface aspects are sorted
[19:54:12] <jdlrobson>	 (or false turns it off)
[19:54:19] <jdlrobson>	 or 0
[19:54:22] <jdlrobson>	 i guess 0 makes the most sense
[19:54:30] <jdlrobson>	 because you wouldn't want to autohide everything
[20:05:33] <jdlrobson>	 rmoen|nomnoms: let me know when you are back from nom noms
[20:05:35] <jdlrobson>	 keen to wrap up gather stuff
[20:08:38] <etonkovidova>	 kaity|away: when you have time -just let me know
[20:12:10] <tgr>	 jdlrobson: just set it to 999999? :)
[20:12:32] <jdlrobson>	 tgr: that's another approach yes lol but it seems weird
[20:12:51] <jdlrobson>	 I suppose you might want to use 0 to turn off all collections momentarily
[20:12:57] <jdlrobson>	 so there is use to it i guess
[20:13:27] <jdlrobson>	 $wgGatherAutoFlaggingEnabled ?
[20:13:51] <tgr>	 null or false is usually used to turn a setting of
[20:14:08] <rmoen>	 jdlrobson: back
[20:14:15] <tgr>	 I just wanted to avoid making the queries even more complicated
[20:14:30] <jdlrobson>	 tgr: i know.. :-/
[20:14:42] <jdlrobson>	 i guess 999 etc is good enough if it is the default :)
[20:16:31] <jdlrobson>	 rmoen: cool. Which Gather patch are you working on fixing up right now? I'm thinking about the tipsy one, but I can pick your other patch up if you want
[20:16:34] <jdlrobson>	 *other card
[20:16:53] <jdlrobson>	 my goal is for phuedx / joakino to wake up to lots of sign off lol ;-)
[20:17:04] <rmoen>	 i have cards assigned to me? 
[20:17:19] <rmoen>	 I dont see any at the moment 
[20:17:50] <rmoen>	 I'll take the page-actions if it is the highest priority 
[20:18:31] <rmoen>	 jdlrobson: but i'm unsure of cache implications 
[20:18:44] <jdlrobson>	 MaxSem: https://gerrit.wikimedia.org/r/#/c/219272/6
[20:19:36] <jdlrobson>	 ebernhardson: did you see my feedback on your patch?
[20:19:45] <tgr>	 jdlrobson: what's the whitespace issue in https://gerrit.wikimedia.org/r/#/c/212593/32/schema/gather_list.sql ?
[20:19:47] <jdlrobson>	 rmoen: the cards we merged yesterday need more work
[20:20:03] <rmoen>	 jdlrobson: https://phabricator.wikimedia.org/T101721 So it says in card to be careful with html so the changes should be done with JS ?  
[20:20:03] <jdlrobson>	 https://phabricator.wikimedia.org/T99109 and https://phabricator.wikimedia.org/T101202
[20:20:12] <rmoen>	 ok
[20:20:14] <jdlrobson>	 rmoen: ignore that one for time being :)
[20:21:27] <tgr>	 jdlrobson: re https://gerrit.wikimedia.org/r/#/c/212593/32/includes/api/ApiQueryLists.php there are two ways something can get into the review queue
[20:21:32] <jdlrobson>	 rmoen: that said i can't replicate the reload issue that phuedx talks about...
[20:21:41] <tgr>	 autoflagging, or owner editing a hidden collection
[20:22:54] <rmoen>	 jdlrobson:  https://phabricator.wikimedia.org/T99109 I assume jonkatz is testing on a mobile device ? 
[20:23:53] <JonKat___>	 rmoen jdlrobson  I couldn't as wmflabs wasn't loading on my phone...is it just desktop?
[20:24:29] <rmoen>	 JonKat___: just trying to confirm, what environment were you testing on ? 
[20:30:20] <JonKat___>	 rmoen sorry: it was desktop, will see if I can recreate on phone
[20:31:16] <ebernhardson>	 jdlrobson: hadn't seen it, will update
[20:32:11] <rmoen>	 Ok.  I'm unable to reproduce in chrome on desktop or firefox.  I'm in ubuntu though not sure if that matters. . I'm going to try to replicate the issues on https://phabricator.wikimedia.org/T101202 on my mac.. 
[20:32:14] <ebernhardson>	 jdlrobson: the mockups moiz put together are blue links, but i'll double check with him
[20:47:59] <rmoen>	 JonKat___: http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page loads for me
[20:48:23] <rmoen>	 JonKat___: woops that was old sry
[20:50:41] <rmoen>	 JonKat___: are you talking about this tipy ? http://imgur.com/Cp6cZyI
[20:52:40] <JonKat___>	 rmoen no it was this one, but the search problem isn't there anymore
[20:52:54] <rmoen>	 JonKat___: yeah i suspect the search problem was cache relatd
[20:53:07] <JonKat___>	 rmoen its just the height (must be a desktop thing).  I thought I included screenshots..
[20:53:18] <JonKat___>	 this one: https://www.dropbox.com/s/kquzrudgoi767zp/Screenshot%202015-06-26%2013.52.25.png?dl=0
[20:53:32] <rmoen>	 JonKat___: yeah you did it was the comments that were confusing
[20:53:39] <rmoen>	 I can make the height minimum 
[20:54:11] <JonKat___>	 aah, sorry.  @kaity what do you think about the image I just linked to? shrink the height?
[20:54:33] <JonKat___>	 rmoen, want to check with kaity as it might be covering the other content purposefully
[20:55:03] <rmoen>	 JonKat___: Well in her mock the height is limited 
[20:55:07] <rmoen>	 I can do that
[20:55:30] <kaity>	 JonKat___:  rmoen Yes I wanted to cover up the other content on the page so that you're focused on the search box
[20:55:48] <rmoen>	 oh ok
[20:55:52] <rmoen>	 then its good as is
[20:55:58] <kaity>	 rmoen: thanks!
[20:56:07] <rmoen>	 So there are no issues with the onboarding patch.. moving it back to ready for sign off
[20:56:18] <JonKat___>	 rmoen yes, sorry for the false alarm...we can clean up the chrome view later (though it might just be my caching
[21:00:45] <etonkovidova>	 kaity: do you have a moment?
[21:00:51] <kaity>	 etonkovidova: sure
[21:01:08] <etonkovidova>	 kaity: should I come to you? 
[21:01:23] <kaity>	 etonkovidova: sure either way! im on 3rd floor
[21:01:42] <etonkovidova>	 kaity: coming...
[21:05:17] <rmoen>	 phuedx: trying to grok your comment on https://phabricator.wikimedia.org/T101202. The issue is that it redirects with the old name ? 
[21:08:21] <kaity>	 bgerstle: hey are you around?
[21:08:29] <bgerstle>	 kaity: yep
[21:11:54] <kaity>	 bgerstle: What do we use for text sizes on the app?
[21:12:01] <kaity>	 px? em?
[21:12:05] <bgerstle>	 points
[21:12:12] <bgerstle>	 kaity: all iOS apps use points
[21:12:27] <bgerstle>	 which, IIRC are roughly equivalent to px * screen scale
[21:12:31] <bgerstle>	 (e.g. 2x for retina)
[21:12:35] <kaity>	 bgerstle: is there a standard minimum size?
[21:12:52] <bgerstle>	 kaity: there are "system" sizes defined for various scenarios (buttons, labels, etc.)
[21:13:16] <bgerstle>	 label/button/small/system
[21:13:30] <kaity>	 bgerstle: ok cool. you mentioned you could increase the size of the "language filter" text?
[21:13:34] <bgerstle>	 i can't tell you exactly what they are though
[21:13:42] <bgerstle>	 kaity: i can look into it, yeah
[21:14:01] <kaity>	 bgerstle: it looks legible on the phone but too small on tablet
[21:14:21] <bgerstle>	 kaity: gotchya
[21:15:11] <rmoen>	 jdlrobson: ok so turns out there were no issues with the changes to the edit overlay yesterday.  Created a task for the existing reload bug.  https://phabricator.wikimedia.org/T104025  I'm going to work on that unless you have something higher priority 
[21:15:41] <kaity>	 bgerstle: it seems like there are many different sizes - I want to look into standardizing
[21:15:59] <bgerstle>	 kaity: i could hug you
[21:16:15] <kaity>	 bgerstle: haha you feel the same
[21:16:31] <bgerstle>	 kaity: yes, the more we can standardize and widget-ize our UI stuff the easier it is to make stuff
[21:16:58] <bgerstle>	 (using standard components, i mean)
[21:17:12] <bgerstle>	 but also providing our own standard styling
[21:17:17] <bgerstle>	 limiting special cases
[21:17:27] <kaity>	 bgerstle: yes it would make it easier for everyone!
[21:19:13] <jdlrobson>	 rmoen: cool :) happy to hear it
[21:21:49] <kaity>	 bgerstle: is the "language filter" text same size as the main "search wikipedia" text?
[21:22:13] <bgerstle>	 kaity: "Search Wikipedia" that appears where?
[21:22:27] <kaity>	 bgerstle: when you tap into search
[21:22:36] <kaity>	 just the main search
[21:22:41] <bgerstle>	 oh oh
[21:22:44] <bgerstle>	 kaity: probably not
[22:29:07] <bearND>	 niedzielski: are you still up for a hangout to chat about the unit test stuff?
[22:31:26] <niedzielski>	 bearND: i am but i don't suppose you can wait a half hour?
[22:31:39] <bearND>	 niedzielski: sure i can
[22:31:59] <niedzielski>	 bearND: thanks! i will ping you shortly
[22:32:09] <bearND>	 niedzielski: sounds good
[22:33:13] <mdholloway>	 bearND: if you've got a free minute, the search bar language selector is about done except for one side issue i'm trying to figure out
[22:33:41] <bearND>	 mdholloway: woaw, cewl.
[22:34:06] <mdholloway>	 bearND: namely, that it doesn't seem to be consistently registering the SharedPreference change and reloading the main page when the language is changed from the preferences menu
[22:35:13] <bearND>	 mdholloway: ok, i'll take a look
[22:35:24] <mdholloway>	 bearND: thanks!
[22:38:13] <dannyh>	 dr0ptp4kt I need to get Wikipedia Beta for a research session... I've got Testflight, but Dan says I need to get added to the WP Beta list. Can you help me?
[22:38:23] <dannyh>	 dr0ptp4kt the AppleID is dannyhornmail@gmail
[22:42:22] <bearND>	 mdholloway: hmm, not sure I understand the problem. I don't think it should load the main page. It would be good, though, if it rerun the search query without having to change the searchTerm.
[22:43:33] <mdholloway>	 bearND: ah, i'll take a look at that.  what i'm worried about is that, when the language is changed the old way, the main page is no longer reloaded automatically in the new language when the nav drawer is closed.
[22:43:48] <mdholloway>	 bearND: i agree it shouldn't reload when changed from the search bar
[22:44:10] <bearND>	 oh, i understand now. checking...
[22:44:38] <bearND>	 mdholloway: ok, i can repro the issue
[22:45:00] <mdholloway>	 bearND: actually, unless i'm going crazy it does reload in the new language occasionally, but only like 5% of the time
[22:56:34] <niedzielski>	 bearND: ok, my workspace is ready whenever you are
[22:56:41] <niedzielski>	 thanks for your patience!
[22:57:14] <bearND>	 niedzielski: np, just a sec
[22:58:59] <bearND>	 mdholloway: my hunch is that it's not setting the result code to SettingsActivity.ACTIVITY_RESULT_LANGUAGE_CHANGED. But I haven't looked at it very thorougly
[23:01:10] <mdholloway>	 bearND: ok, i'll focus there.  thanks for looking!
[23:31:24] <dr0ptp4kt>	 bgerstle_afk: would you be able to help dannyh on the above tf beta access request please? scroll up about 15
[23:31:49] <dannyh>	 dr0ptp4kt sorry, I think Corey must have put it through -- I've got it now, thank you
[23:32:08] <dr0ptp4kt>	 dannyh: excellent. thanks coreyfloyd  ^ bgerstle_afk 
[23:45:22] <tgr>	 jdlrobson: fixed, hopefully - can you re-run the tests?