[09:05:33] hullo [09:20:52] sorry for just leaving last night y'all [09:21:44] i crashed hard [09:29:25] phuedx: hey, im at the doctor, its taking longer than expected [09:29:36] joakino: cool -- i'm getting some code review done [09:30:05] i've got to take a slightly longer lunch today because i've got to get my bike fixed [09:30:15] but i've got nothing urgent getting in the way of writing stories when you're free [09:30:27] i'm going to try and get some review done in the meantime [09:37:14] joakino: sorry, s/cool/not cool/ [09:49:07] phuedx: don't worry. I'll be writing epics today and I'll ping you this afternoon [09:49:12] okie poke [09:49:29] also, channelling my inner human: i hope you're ok! [10:12:52] phuedx, joakino: morning [10:13:07] bmansurov: yo [10:13:23] phuedx, joakino: any suggestions on what I should work on next? I still have 4 patches pending review and I don't want to work on something new. Or should i? [10:13:49] bmansurov: i noted that you'd picked up the promotions [10:14:31] phuedx: no more promotions left [10:14:55] bmansurov: i'm currently going through the max-width stuff [10:15:33] phuedx: https://phabricator.wikimedia.org/T103728 what do you say? [10:15:36] bmansurov: https://gerrit.wikimedia.org/r/#/c/219272/ is pending review [10:15:42] it has a +1 from florian [10:15:52] it would be good to have a functional review (testing) [10:16:00] phuedx: i did +1 earlier too, will do it again [10:16:06] ta [10:16:24] bmansurov: out of curiousity, what would it take for you to give a +2 [10:16:28] ? [10:16:54] phuedx: that I'm aware of all side effects and pretty certain that i'm not screwing up something else [10:17:01] welcome to the club [10:17:07] ;) [10:17:37] bmansurov: why isn't that the case now? is it something wrong with the patch? [10:18:25] phuedx: i'm not sure if i'm screwing up somehting else, alghouth it's just a re-arrangement of the same code [10:18:35] phuedx: better safe than sorry [10:19:57] ok, well do you think it's on you, as a reviewer, to read around the change a little more or is it something that the commit is lacking? [10:20:09] i ask because the commit is awaiting review and you're asking for work to do ;) [10:20:23] sorry, you're asking what work /should/ be done [10:20:28] you're not asking for work to be handed for you [10:20:56] sure, it's not the change per se i'm worried about, it's the code around it that i'm not aware of [10:22:32] phuedx: if you read floarian's comments, you'll notice that he brings up some good points which you can't gather by reading code [10:22:42] phuedx: it's just you need to have more experience with everything else [10:26:30] bmansurov: sure, and you bring experience with other things, i get it [10:27:54] so maybe you want to defer to someone else to merge it [10:28:00] i was just curious is all [10:28:44] phuedx: yes, that patch is only getting +1 from me, nothing more ;) [10:28:54] bmansurov: understood [10:29:10] bmansurov: but know that you learn from mistakes too :) [10:29:18] and there's /nothing/ wrong with making 'em [10:29:42] <- this guy is still employed [10:30:06] phuedx: yes, you just learn another way that doesn't make something work [10:30:16] phuedx: also the branch is being cut soon [10:31:38] bmansurov: 1. disagree, 2. okay [10:31:56] bmansurov: 1. … well, agree sorta, but i think you'd learn a whole lot more [10:33:05] oh one more thing, if I merge the patch too soon, I won't benefit from others' comments [10:34:01] then don't merge any patches ever again [10:34:16] lol [10:34:22] please take away my +2 rights [10:35:50] are you serious? that was a joke [10:36:36] i know [10:36:42] but does everyone else?! dun dun duuuuuuh [10:36:57] :P [10:39:14] joakino is silent today [10:39:28] has he come back from that pool visit last night? [10:39:52] he's at the doctor [10:40:00] oh ok [10:40:11] i think he was supposed to be back for work started [10:40:16] but he got delayed [10:40:23] hope he's ok [10:40:53] bmansurov: i've moved https://phabricator.wikimedia.org/T103742 into todo [10:41:08] phuedx: cool [10:41:22] seems like we need to revisit watchstars in search bar anyway [10:41:26] but that's another thing [10:42:16] phuedx: why should we? [10:47:09] apparently it's not used a whole bunch [10:47:13] i can't remember who said that [10:47:30] just want to see [10:47:43] but these days i need a phab task to remind me to do something ;) [10:48:14] i hear you [10:48:52] t12321130: chew your food [10:55:57] yoyo i'm back [10:56:26] i was at the international healthcare for getting vaccines [10:56:46] they're super slow, and I only got a paper to actually go to the doctor and get the vaccine [10:56:49] prf [10:58:10] joakino: where you travelling to? [10:58:29] phuedx: nicaragua on september [10:58:35] nice! [10:59:20] i really need holidays [10:59:42] joakino: yeah [11:00:04] i've taken 6 days this year, all of which were in the last three weeks [11:00:47] lol @ phabricator [11:01:05] go to http://phabricator.org/ and find "bulba" in page [11:01:07] WTF [11:02:22] phuedx: seems like differential is the same as gerrit [11:02:29] woo [11:02:48] joakino: i've stopped caring about that now [11:02:52] i've just been paid [11:02:59] so it's music shopping time [11:24:47] joakino, bmansurov: i've documented a few bugs around the last-modified bar but i've yet to write 'em up: https://gerrit.wikimedia.org/r/#/c/220627/ [11:24:52] just so you're ware [11:24:54] *aware [11:25:16] 👍 [11:33:00] right -- i'm going for lunch [11:33:14] i've got to get my bike fixed and then cycle it home so i'll be out for a little while [11:33:22] (i'll make up the difference this evening) [11:33:50] joakino: ^ [11:33:56] back in a bit [11:36:26] sure [11:36:29] have fun phuedx|NOM [12:49:27] back [13:40:04] iOS 8.4 today! [13:40:59] more safari issues to look forward to! [13:41:17] lol [13:45:55] Already on the 8.4 betas on my ipad due to apple breaking external gps support in 8.3 [14:00:34] joakino: tool for capturing screen and exporting gifs? [14:00:39] want to add gifs to my bug reports [14:01:22] gif or jif? [14:02:02] Reedy: jgif [14:38:41] phuedx: licecap [14:44:47] phuedx: or QuickTime for videos [14:50:27] joakino: found licecap [14:50:27] it's awesome [14:50:41] fuck yeah! [14:52:35] yeah, it's super cool [14:52:50] scaffolders have just left [14:52:50] all the scaffolding has been disassembled [14:52:50] i'm outside in my hammock [14:53:52] i feel so much better now [14:54:03] huge load off of my mind now that the building works have /ended/ [15:01:34] srsly apple [15:01:45] how is ios 8.4 1.5GB to download when I'm already on the beta? [16:09:22] dbrant: Oops, that merge was a bit premature. When rotating the device on the search screen it loses this information. We need to add it to the savedInstanceState as well. Do you want to add that one as well? [16:10:37] bearND: sure. (but that's a separate issue, isn't it?) [16:12:05] dbrant: yes, but they are related. A user who rotates the device would not understand why suddenly some results get dropped [16:16:33] dbrant: niedzielski mdholloway|afk : fyi, I think https://gerrit.wikimedia.org/r/#/c/221824 is also a good candidate to be merged before the next release. Do you agree? [16:16:50] bearND: definitely [16:17:00] bearND: yeah, that'd be great [16:17:25] bearND: i +1d it be but can +2 if everyone is satisfied [16:18:04] niedzielski: i'll +2 it [16:19:57] bearND dbrant mdholloway|afk: on the load strategy crash bug, i haven't been able to repro either. it's painful looking at the activity docs because the lifecycle is so nuts. this line in particular stood out: Note that it is important to save persistent data in onPause() instead of onSaveInstanceState(Bundle) because the latter is not part of the lifecycle callbacks, so will not be called in every [16:19:59] situation as described in its documentation. [16:21:05] bearND dbrant mdholloway|afk: looking at the code, i think the issue is that JsonPageLoadStrategy.backStack should be initialized to an empty list [16:22:01] bearND dbrant mdholloway|afk: i believe everywhere else the list is set to a nonnull value [16:26:05] Why does the mobile view of my wiki @ https://wiki.gamepaduniverse.com/wiki/PadPedia have the localNotice up top? I have the latest version of Mantle and MobileFrontend? [16:48:46] bgerstle: coming to engineering leads meeting? [16:48:56] I'm heading down to the pool for 20 min, i'll be back for the next meeting [16:51:15] +1 pool [16:51:51] Our AC just went out ;/ [16:53:59] rmoen: I heard that it's super hot in PDX [16:57:32] i want to be in portland :/ [16:57:43] holy shit1 91F!? [16:57:44] jdlrobson: me too :-( [16:57:51] heaven! [16:57:56] i didnt realise portland could get that warm [16:57:59] jdlrobson: inorite [16:58:07] i heard it was like the uk [16:58:17] thirdtimesneeze_: hey are you still there? [16:58:35] still sneezing... [16:59:13] thirdtimesneeze_: the local notice will show at the top of the mobile skin by default [16:59:23] if you want to turn it off you can add a css rule to MediaWiki:Mobile.css [16:59:36] damn it joakino|POOL is in a pool [16:59:41] i'm just super jealous now [16:59:55] is that a recent change? thought the value in mobilefront end was false [17:00:05] * kristenlans wonders if joakino is smoking a cigarette in the pool... [17:00:06] * kristenlans wonders if joakino is smoking a cigarette in the pool... [17:00:17] this occured when i upgraded to 1.25 [17:00:23] thirdtimesneeze_: the latest version of MobileFrontend doesn't require Mantle so I'm not sure which version you are using [17:00:59] phuedx: yey for no more builders! [17:01:44] is that what happened? k [17:01:52] i just updated both since i had the previously [17:02:29] what css rule exactly, i am not so good graphically [17:03:09] kristenlans: he probably also has a ice cold beer [17:03:20] an [17:04:25] kristenlans, jdlrobson its been 90s everyday [17:04:37] the dream of the 90s... [17:04:47] aha [17:04:55] rmoen: that's what the washougal is for!!! [17:05:10] kristenlans: i love the washougal. The sandy is pretty good too. [17:05:17] yeah the sandy!!! [17:05:18] but.. computers [17:05:48] rmoen: yeah the beach is a mile from my house...and it's sunny today. Damn computers ;-) [17:06:32] phuedx: do you feel cositutionally capable of takign a whirl through the in alnalysis column? [17:06:49] #together, if that helps [17:07:48] anyone know why my mw-vagrant is complaining about cookies for login ? My cookies are enabled.. jeez [17:08:51] kristenlans: in a meeting right now and then it's the boy's bedtime [17:08:55] so an hour-ish? [17:09:40] phuedx: hmm today might be a wash, I have a load of meetings. Let's try for tomorro? [17:12:47] I also have no edit bar like before in 1.25, so... how do i fix that? [17:13:15] @ https://wiki.gamepaduniverse.com/wiki/PadPedia in mobile view [17:14:56] thirdtimesneeze_: no edit bar?! :-O looking [17:15:04] Service Temporarily Unavailable :-S [17:15:16] site backup [17:15:25] scheduled it will just be a minute [17:16:22] look now [17:17:36] kristenlans: suresies, i'd do it now, but the boys have to sleep downstairs tonight because it's too damned hot upstairs [17:17:39] thirdtimesneeze_: so i'm seeing an error Uncaught Error: Unknown dependency: jquery.json [17:17:42] so they're a little unsettled [17:17:45] i think one of your extensions has a problem [17:18:13] #localNotice { display: none; } should hide your local notice [17:18:30] how did you find that error, i am very bad at this type of troubleshooting and would like to be more self-sufficient [17:19:09] phuedx: no worries [17:19:09] phuedx: no worries [17:20:08] kristenlans: how about 30 minutes before the beta -> stable checkin? [17:20:11] (tomo) [17:20:19] thirdtimesneeze_: i'm just using the JavaScript developer console [17:20:22] thanks for the css change [17:20:37] phuedx: works for me :-) [17:20:44] thirdtimesneeze_: i'm not sure what's causing it but i would suggest making sure core is up to date and disabling extensions one by one until the edit icon returns [17:21:35] thanks, what am i suppose to make out of this error? [17:21:38] kristenlans: invite sent [17:21:58] haha phuedx I just did same :-) [17:22:21] phuedx: let's both accept both invites :PPPPPP [17:22:28] thirdtimesneeze_: basically something is using jquery.json - when it shouldn't be. You can do a search for 'jquery.json' in your mediawiki folder to find the culprit [17:22:52] we're so cool [17:25:17] jquery.json [17:25:31] accident^ [17:25:38] thirdtimesneeze_: where is that? [17:25:42] which folder? [17:25:45] when's the new deployment branch cut again? [17:25:56] my brain isn't working today [17:26:17] phuedx: today sometime [17:26:37] there are two files that come up jquery.json and jquery.json-deprecate [17:26:38] phuedx: i don't think the exact time is fixed [17:26:49] C:\Inetpub\vhosts\gamepaduniverse.com\wiki.gamepaduniverse.com\w\resources\lib\jquery [17:27:02] C:\Inetpub\vhosts\gamepaduniverse.com\wiki.gamepaduniverse.com\w\resources\src [17:27:05] respectively [17:28:37] niedzielski: hey would have time this afternoon to chat about the css bit again? [17:29:10] mhurd: yeah, i'm from now to this evening [17:29:16] i'm free* [17:29:38] niedzielski: cool! i'll schedule a hangout [17:29:46] mhurd: sounds good! thanks! [17:31:15] niedzielski: invite sent. let me know if that time is inconvenient [17:31:50] mhurd: looks good to me! [17:36:08] jonkatz, hi! Are you around? I'd like to ask you something about our EventLogging meeting [17:44:20] jdlrobson: you still there? [17:44:54] thirdtimesneeze_: sure. sorry ping me when i'm not responding :) [17:45:15] so... it sounds like you are using an incompatible version of mediawiki and need to update it [17:45:37] i have no respect for authority, don't take it personally :_+{) [17:45:55] 1.25.1 is incompatible? [17:46:49] jdlrobson: need +2 on this https://gerrit.wikimedia.org/r/#/c/221881/2 a follow up on files removed recently [17:47:14] codezee: done :) [17:47:31] thirdtimesneeze_: mmm it seems that way. [17:47:35] You should be able to patch it though [17:48:07] thirdtimesneeze_: try this.. $wgResourceModules['jquery.json] = array( 'targets' => array( 'desktop', 'mobile' ), ); [17:48:15] ^ put it in your LocalSettings.php [17:49:41] dbrant: hey dmitry, do you have time today to meet today about q1 android goals? i'd like to discuss what my upcoming dept goals should be [17:50:31] niedzielski: sure, feel free to schedule. [17:52:27] dbrant: thanks! i've sent an invite. happy to reschedule if another time works better [17:53:22] Parse error: syntax error, unexpected 'targets' (T_STRING), expecting ']' in C:\Inetpub\vhosts\gamepaduniverse.com\wiki.gamepaduniverse.com\w\LocalSettings.php on line 251 [17:54:33] thirdtimesneeze_: $wgResourceModules['jquery.json] missing ' at the end [17:54:49] before ] [17:55:54] HURRAY!!!!!!!!! [17:55:59] stuff appears to actually work now!!!! [17:56:55] mforns hi! just got out of a meeting [17:57:38] oh no! [17:57:48] JonKat___, hi! [17:57:50] editing still doesn't work. [17:58:23] it loads #/editor/1 but you can't actually edit anything [17:58:28] I just wanted to ask you if you set up our EL meeting on Monday at 20:00 CET, because you saw I work from Spain [17:58:40] TypeError: $.toJSON is not a function load.php:4:77 "Exception in load-callback in module mobile.editor.overlay:" load.php:175:555 "TypeError: $.toJSON is not a function" TypeError: $.toJSON is not a function Stack trace: [object Object] [17:58:57] mforns is that too late? [17:59:00] JonKat___, just to let you know that I work in east coast times, in case you want to have the meeting later (until 00:00h CET) [17:59:14] mforns ah, okay. this time is fine for me [17:59:38] mforns, do you want to meet earlier? if so, knowing you are on EST would make that possible [17:59:50] JonKat___, I was thinking maybe we could meet on thursday this week between 2200 and 0000 CET [18:00:01] if that's OK with you :] [18:00:10] if not, no problem at all [18:00:35] mforns okay, if i'm free I'm cool with that. have to run to a meeting, can you edit [18:03:25] bd808: got your message. phew, now i can have lunch today :) [18:04:58] jdlrobson: long lost mediawiki pal [18:05:12] sorry thirdtimesneeze_ i'm terrible at multi tasking :) [18:05:22] darn [18:06:18] at least it's give the appearance of being correct :) that matters a lot in real life you know [18:09:51] bearND: would you be able to attend the SoS tomorrow in my absence? [18:10:24] dr0ptp4kt: yes [18:10:29] bearND: thanks! [18:11:44] thirdtimesneeze_: so getting a code snippet for you [18:12:06] put this in MediaWiki:Mobile.css $.toJSON = JSON.stringify [18:12:10] i hope that will do it [18:12:14] $.toJSON = JSON.stringify; [18:12:20] (untested) [18:13:51] i did not apply that change it gives error when typed [18:14:12] the css file? [18:15:32] ineffective my friend [18:15:46] $.toJSON = .stringify; also failed [18:16:17] jdlrobson:any other ideas? [18:16:27] what error does it give you now? [18:17:00] the easiest thing would be to update to MobileFrontend latest master version I think :-/ [18:19:42] same thing as before in the console, "TypeError: $.toJSON is not a function" TypeError: $.toJSON is not a function Stack trace: [object Object] [18:19:46] in the mobile.css [18:19:54] hold on [18:20:21] unexpected token $ [18:20:30] LBRACE [18:20:38] sorry i am typing based on a tooltop [18:20:45] dont know how to copy tooltips [18:21:50] basically i think the '$' is screwing things up? [18:24:27] thirdtimesneeze_: mmmm [18:24:32] try jQuery instead of $ [18:24:42] jQuery.toJSON = JSON.stringify; [18:28:27] it seems like everything in front of .toJSON will result in error, according to the css editor [18:30:38] jdlrobson:this syntax seems really bizarre for css [18:30:49] this is javascript [18:30:54] you need to put it in MediaWiki:Mobile.js [18:31:01] sorry about that :) [18:31:04] my typo :) [18:32:21] haha, i knew something was up :_+P [18:33:06] yo [18:34:09] jdlrobson:"TypeError: $.toJSON is not a function" TypeError: $.toJSON is not a function Stack trace: [object Object] .... still returns [18:35:12] ok change of plan thirdtimesneeze_ search for $.toJSON in MobileFrontend and replace that with JSON.stringify [18:35:21] coreyfloyd: we lost you in hangout [18:35:23] lost you coreyfloyd [18:35:24] if that doesn't work i really don't know whaat to suggest :/ [18:35:31] coming back [18:35:34] sorry [18:35:36] apart from upgrading .. :/ [18:36:58] jdlrobson: give me a hint on the file name? [18:38:59] hey kristenlans can we talk about the phab reorg? [18:39:10] (or not-reorg :p) [18:40:36] joakino sure [18:40:53] I'm not out of meetings until 4PM ET [18:42:35] oh dam [18:43:05] kristenlans: that's too late here :( [18:43:39] joakino|MEETING: shold we try email? [18:44:22] sure, would you mind sending me one later trying to articulate the problems of the workflow we talked about? <- kristenlans [18:44:55] that way I can try to understand the problems and maybe explain solutions [18:47:08] jdlrobsonLwhich file? [18:47:21] jdlrobson:which file? [18:48:25] will third time be the sneeze? [18:48:27] vibha: https://meta.wikimedia.org/w/index.php?title=Special%3APrefixIndex&prefix=Mobile&namespace=470 [19:02:09] thirdtimesneeze_: i'm not sure which file that line is in [19:02:16] but do a find and replace :) [19:03:14] jdlrobson:noooooo!!!! I am using windows server so the search only locates file names. Is there some way I can search through each file? [19:03:44] thirdtimesneeze_: well which file names do you find jquery.json ? [19:03:52] you should open up those files and edit them [19:04:11] thirdtimesneeze_: i have to go in a bit to lunch so would be good to get this working for you before i go :) [19:04:14] ahhh that clears the matter up [19:04:21] on it sir [19:07:59] jdlrobson:made two changes in the jquery.json but does not seem to have an impact [19:09:00] wait!!! [19:09:02] it works now [19:09:43] jdlrobson:god bless your eternal soul, friend [19:13:30] yay! happy to hear it :) [19:14:26] jdlrobson: have a minute to help me get un-stumped ? [19:14:47] rmoen: just about to head to lunch but can help you around 1.30ish ? [19:14:54] if you want to set something up in my calendar [19:15:00] unless it's super straightforward [19:15:05] i think its qucik [19:15:07] quick [19:15:11] ok cool hit me [19:15:31] CollectionSearchPanel.js, when you hit the input, what makes it expand to the top [19:15:42] hit/click [19:16:53] is my question too vague ? [19:17:20] jdlrobson ^ [19:17:38] rmoen: no i understand [19:17:40] just thinking [19:17:42] ok [19:18:51] rmoen: i think its's just css switchToSearchPane [19:19:19] jdlrobson: ahh ok there we go [19:19:26] Thought i was going crazy there [19:19:30] thanks boss [19:19:31] :) [19:25:37] g'night folks [19:25:43] phuedx|zzZ: gn [19:28:04] rmoen: most of that interaction happens in resources/ext.gather.collection.editor/CollectionEditOverlay.js [19:28:11] it's fairly tangled ATM [19:28:24] i'm gonna head out too [19:28:27] joakino|MEETING: got it now [19:28:32] have a nice day! [19:34:54] ok now i'm really gone :/ [19:44:49] dbrant: niedzielski mdholloway : I think we could just do this https://gerrit.wikimedia.org/r/#/c/221970/ [19:52:01] bearND: seems sensible [20:09:38] bearND: sorry, was in meeting with dbrant. lookinh now [20:28:53] dbrant you around? [20:29:17] bearND: yep [20:30:18] dbrant: have you looked at https://gerrit.wikimedia.org/r/#/c/221970/? [20:31:03] oh, just realized that niedzielski left a comment [20:32:51] bearND: yes, i think that it's a good fix. I kind of agree with stephen's comment; just initialize it to an empty list. [20:33:05] dbrant bearND: sorry in meeting [20:46:57] dbrant: niedzielski : mdholloway|afk ok; amended [20:47:15] bearND: thanks! looking real quick [20:48:32] bearND: LGTM! [20:51:23] niedzielski: are you still in meetings? [20:51:54] bearND: yes, meeting with monte right now [20:52:20] niedzielski: k [20:59:51] bearND: ok we're out! [21:00:03] mhurd: ready when you are (hangout) [21:01:56] mhurd: I'm connectd to your hangout but the image is a grey screen (I heat signs of life) [21:01:58] hear [21:02:10] bearND: niedzielski: happy to +2 unless anyone else (i.e., dbrant) wants to have a look [21:02:38] mdholloway: it just got merged [21:02:40] never mind [21:02:44] just saw [21:13:22] niedzielski: wow, the test artifact setting threw me for a loop. I was running the translation tests but had it set to Unit test. So, it didn't run against the latest code and I got a weird failure. Switching to "Android Instrumentation Tests" fixed it. [21:13:43] bearND: that areas of the ide needs some improvement :/ [21:14:03] bearND: i'm seeing some non-lang test errors i'm currently looking into [21:14:35] niedzielski: I'm fixing the signature issues in FullSearchTaskTests [21:15:09] bearND: thanks! i'm also seeing FetchUserContribsTaskTest failing for some reason [21:15:45] niedzielski: my patch is pushed: https://gerrit.wikimedia.org/r/221996 [21:17:52] bearND: thanks! i can +2 this guy but only one question: should emulate old test behavior and set morelike to false or does it not matter in this case? [21:22:07] niedzielski: oh wait, you're right. false is more appropriate here [21:23:04] bearND: great! i'll +2 the revision when it comes in [21:23:20] niedzielski: ideally we have both cases covered but I'll leave that for later [21:23:30] bearND: makes sense [21:23:38] niedzielski: amended [21:24:46] bearND: nice! ok, LGTMA [21:25:45]