[00:00:50] <kaity>	 jdlrobson: hey we spoke about the icon
[00:01:16] <kaity>	 jdlrobson: thats why I asked how you would do the dot. I'll update icon today
[07:19:41] <joakino>	 morning!
[08:32:24] <joakino>	 phuedx|zzZ: awesome how you tagged the bug on github and it appeared there https://github.com/facebook/hhvm/pull/5502#event-343694250
[08:32:42] <joakino>	 for a moment I dreamed we used github haha
[08:57:03] <phuedx>	 yo
[08:57:05] <phuedx>	 hey joakino 
[08:57:55] <phuedx>	 joakino: lol
[08:58:19] <joakino>	 morning!
[10:19:00] <benestar>	 jdlrobson: around?
[10:26:08] <bmansurov>	 i doubt it, but he'll be in about 6 hours
[10:45:25] <joakino>	 yep probably sleeping
[10:45:29] <joakino>	 hi bmansurov :)
[10:46:08] <bmansurov>	 joakino: howdy
[10:49:08] <Ainali>	 Does anyone know if there is a way to do a URL that "forces" desktop view? I.e. does not redirect to the mobile site even for people on mobile devices.
[10:52:41] <phuedx>	 Ainali: if you click the "Desktop" link at the bottom of any page, then you'll be redirected to the desktop site and you won't see the mobile site (until you clear your cookies)
[10:53:00] <phuedx>	 Ainali: however, is there some behaviour of the mobile site that you're trying to avoid?
[10:54:46] <Ainali>	 phuedx: I want to send a URL on twitter that takes the reader directly to the desktop site
[10:56:00] <Ainali>	 I found it: &mobileaction=toggle_view_desktop
[10:58:04] <phuedx>	 Ainali: exactly right
[11:18:33] <phuedx>	 gonna go get some food
[11:18:56] <phuedx>	 and go out on the unicycle for a bit
[11:22:06] <bmansurov>	 phuedx|UNI: juggle and unicycle?
[11:27:58] <joakino>	 Ainali: I would suggest using useformat=desktop instead of mobileaction=toggle_view_desktop since this last one will actually set the browser of the visitor to use the desktop version instead of the mobile always, and that seems kind of evil to me
[11:28:27] <joakino>	 cc/ phuedx|UNI ^
[11:28:35] <Ainali>	 joakino: Ok, thanks!
[11:28:48] <joakino>	 :D
[11:30:10] <Ainali>	 How do one specify a gadget to also work in the mobileview? They are trying to do it on svwiki but it does not seem to work.
[11:30:27] <Ainali>	 (Hence my temporary workaround)
[11:31:05] <Ainali>	 This does not seem to be enough: https://sv.wikipedia.org/w/index.php?title=MediaWiki%3AGadgets-definition&type=revision&diff=30156902&oldid=30133810
[11:34:58] <joakino>	 I don't know about that Ainali, try asking in 4 or 5 hours when more SF'ers are around
[11:35:15] <joakino>	 maybe phuedx|UNI or bmansurov know about that ^
[11:36:28] <Ainali>	 Ok, I'll try that if someone else don't resolve it before that :)
[11:37:19] <bmansurov>	 Ainali: sorry, I don't know either.
[12:04:52] <phuedx>	 i'm not familiar with mobile gadgets
[13:02:33] <phuedx>	 joakino: where do you dump images on phabricator to host 'em?
[13:04:51] <joakino>	 phuedx: what do you mean
[13:04:57] <phuedx>	 nm
[13:05:00] <joakino>	 if you drag an image it'll upload it to phab
[13:05:08] <phuedx>	 was wondering if i could use phab as an image host
[13:05:10] <phuedx>	 which i can
[13:05:13] <joakino>	 yerp
[13:06:25] <joakino>	 ok lunch time
[15:00:57] <phuedx>	 weird
[15:05:35] <niedzielski>	 bearND|bbl: hey! question for you when you return. i'm looking at our q1 roadmap and thinking on what my department goal should be. is "Offload DOM transforms to Content Service" something you would do or want to do as part of your content service work?
[15:29:51] <phuedx>	 kristenlans: i'm in my hangout i think
[15:32:30] <kristenlans>	 oh nap
[15:32:33] <kristenlans>	 BRT
[15:33:17] <phuedx>	 ^ excellent keyboarding
[16:00:15] <phuedx>	 kristenlans: not standup yet
[16:00:38] <kristenlans>	 haha i just realized that phuedx
[16:16:46] <mdholloway>	 niedzielski: bearND: i've been meaning to chat with you guys about that as well, i still need to do goals too
[16:26:11] <Deskana>	 niedzielski: Here's a challenge: make the objective of your goal user-facing.
[16:26:25] <Deskana>	 niedzielski: "Offload DOM transforms to Content Service" sounds more like a key result than an objective.
[16:28:20] <niedzielski>	 Deskana: so for this example, "improve performance, quality, and reliability of html content by offloading..."
[16:28:22] <niedzielski>	 ?
[16:29:54] <Deskana>	 niedzielski: I'm not sure what format your personal goals are in, but if it's in the OKR format we're using for Engineering Goals, then the objective would be "Improve performance, quality, and reliability of HTML content" and (one of) the key results would be "Offload DOM..."
[16:30:30] <Deskana>	 niedzielski: Although, if I were your sceptical PM, I would ask the open-ended question "Why do we want to improve performance?"
[16:32:14] <Deskana>	 "Does it get us more users?"
[16:32:21] <Deskana>	 "Will they browse more? Stay longer?"
[16:32:21] <Deskana>	 etc
[16:32:31] <niedzielski>	 Deskana: i've been having some discussions on "why" but they're ongoing
[16:32:48] <Deskana>	 Sure, I don't necessarily expect you'd have all the answers :-)
[16:34:18] <niedzielski>	 Deskana: so wanting to see a perfect example, i was looking for your 2014-15 goals but i didn't find them. do product fellows not have these the same way engs do?
[16:34:33] <Deskana>	 Apparently not. I've never actually had to do it.
[16:34:44] <Deskana>	 I think that's a double-standard.
[16:34:59] <Deskana>	 And I think it's a triple-standard that I think it's a double-standard but still never bothered to do it. :-p
[16:35:31] <Deskana>	 niedzielski: Try looking at this: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2015-16_Q1_Goals#Analysis
[16:35:49] <Deskana>	 niedzielski: That's one that I wrote. But, like I say, I'm not sure what format is expected for personal goals.
[16:35:59] <Deskana>	 niedzielski: OKR (like the example) seems sensible enough to me.
[16:37:21] <niedzielski>	 Deskana: thanks! and thanks for the tips! i always value your feedback
[16:37:49] <Deskana>	 niedzielski: To be self-reflective, I actually think my objective isn't the best there. It gets a bit too much into the details about how we're going to solve.
[16:38:04] <Deskana>	 niedzielski: I'd say objective should be the problem you'll solve, and the key results how you're going to solve it.
[16:38:13] * Deskana shrugs
[16:38:19] <Deskana>	 It's all hand-wavy stuff
[16:38:28] <Deskana>	 It doesn't need to be perfect, just good enough to communicate your intent
[16:38:35] <Deskana>	 niedzielski: And, I am always happy to provide feedback. :-)
[16:46:15] <dr0ptp4kt>	 bgerstle: you coming?
[16:46:24] <bgerstle>	 yeah sorry, was talking w/ corey
[17:18:10] <jdlrobson>	 codezee: still there?
[17:18:24] <codezee>	 jdlrobson: yes, I'm working on adding test for icons
[17:18:47] <jdlrobson>	 codezee: be sure to read through this - https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment
[17:19:18] <jdlrobson>	 codezee: specifically Review for deployment
[17:19:26] <codezee>	 jdlrobson: alright, I'll go through it :)
[17:24:54] <dr0ptp4kt>	 etonkovidova: i finally found it: https://en.wikipedia.org/wiki/Gramophone_record
[17:25:13] <dr0ptp4kt>	 mhurd: want to get a head start on the 1:1 or need a few minutes to collect thoughts?
[17:26:15] <mhurd>	 dr0ptp4kt: ya!
[17:26:25] <dr0ptp4kt>	 mhurd: okay, i'll join the link that's on there
[17:26:30] <dr0ptp4kt>	 thar meeting invite
[17:28:28] <jdlrobson>	 phuedx: https://gerrit.wikimedia.org/r/#/c/221754/3
[17:32:50] <codezee>	 jdlrobson: added tests for icons, you can look at https://gerrit.wikimedia.org/r/#/c/215029/ whenever possible for feedback :)
[17:54:57] <joakino>	 hey does anybody know why most of mychannels in irc cloud have an umbrella to the right?
[18:04:35] <phuedx>	 joakino: latest update -- not sure
[18:08:17] <rmoen>	 phuedx: that inline display:block is driving me nuts!   Can't figure out what is causing it.  Using the hidden class was masking this issue.  
[18:08:37] <phuedx>	 rmoen: yeah -- looks like a jquery show /somewhere/
[18:08:42] <rmoen>	 yeah ;/
[18:09:23] <rmoen>	 i've changed the classname with no luck, so something is diving into the template and showing the first element i suppose
[18:10:58] <rmoen>	 oh ew!
[18:11:16] <rmoen>	 this.$('overlay-content').children().show();
[18:12:11] <rmoen>	 ^ in hideSpinner()
[18:20:00] <kaity>	 jdlrobson: hey are you free to look at the dot?
[18:20:09] <kaity>	 jdlrobson: for https://phabricator.wikimedia.org/T101201
[18:20:41] <jdlrobson>	 kaity: i will be later after lunch. I've got to grab some food before an interview
[18:20:49] <kaity>	 jdlrobson: ok cool
[18:25:41] <phuedx>	 rmoen: nice find!
[18:29:24] <rmoen>	 phuedx:   I now know why the class "hidden" is being applied in the overlays.. its a hack around that.
[18:35:28] <jdlrobson>	 grabbing food
[18:36:07] <rmoen>	 jdlrobson: have good interviews :)
[19:22:30] <joakino>	 heading out
[19:22:34] <joakino>	 bb! o/
[20:12:14] <phuedx>	 gn y'all
[20:12:18] <phuedx>	 o/
[20:43:56] <dbrant>	 bearND: got a minute for batcave?
[20:44:08] <bearND>	 dbrant: yes
[20:45:36] <dbrant>	 bearND: whoops, it's occupied. i'll just call via hangouts
[20:45:51] <bearND>	 dbrant: yep, notced that
[21:29:05] <jdlrobson>	 rmoen|foods: hey am here when needed
[21:29:24] <rmoen|foods>	 jdlrobson: hey, i'm half eating and half running these tests..  
[21:29:41] <jdlrobson>	 so what's not working with https://gerrit.wikimedia.org/r/#/c/222033/3/extension.json ?
[21:29:46] <rmoen|foods>	 oh
[21:29:56] <rmoen|foods>	 jdlrobson: its parsing wikitext into escaped html
[21:30:06] <jdlrobson>	 ohhh in which case
[21:30:06] <rmoen|foods>	 meaning, not actual html
[21:30:26] <jdlrobson>	 tutorialSubheading: mw.msg( 'gather-collection-content-tutorial-subheading' )
[21:30:29] <jdlrobson>	 {{tutorialSubheading}}
[21:30:40] <jdlrobson>	 s/{{tutorialSubheading}}/{{{tutorialSubheading}}}
[21:30:50] <jdlrobson>	 the template is escaping it
[21:30:59] <rmoen|foods>	 OH my
[21:31:08] <rmoen|foods>	 triple brackets ;)
[21:31:11] <rmoen|foods>	 thanks!
[21:32:08] <rmoen|foods>	 jdlrobson: so hey, my property management is coming by for the bi-annual inspection 
[21:32:26] <jdlrobson>	 just distract them with your cute baby!
[21:32:39] <rmoen|foods>	 i'll be afk a while around 3pm.  But I plan on coming back and finishing the edit tests.  Then I have plans to write more browser tests :)
[21:33:16] <rmoen|foods>	 Its sorta fun.  The only problems i'm having so far is random failures for things that don't really make sense.  But i'm powering through
[21:33:33] <rmoen|foods>	 brb
[22:35:46] <jdlrobson>	 rmoen|foods: around?
[22:36:03] <jdlrobson>	 having issues with reviewing your patch
[22:43:26] <jdlrobson>	 rmoen|foods: I'm visiting #/edit-collection-tutorial/394 but tutorial is not showing
[22:49:19] <jdlrobson>	 kaity: there?
[22:49:22] <jdlrobson>	 did you see the comment here https://phabricator.wikimedia.org/T99103
[22:50:51] <kaity>	 jdlrobson: ya got it
[22:50:58] <kaity>	 jdlrobson: want to look at dot?
[22:51:02] <jdlrobson>	 thx kaity 
[22:51:16] <jdlrobson>	 yeh we can talk about the dot. Annoyingly patch isn't merged which makes this diffuclt
[22:51:21] <jdlrobson>	 how do you want to do this?
[22:54:22] <jdlrobson>	 https://usercontent.irccloud-cdn.com/file/7xUj6WQV/Screen%20Shot%202015-07-01%20at%203.54.06%20PM.png
[22:54:33] <jdlrobson>	 ^ kaity  (ps. irc cloud is awesome how you can drag and drop images :))
[22:54:40] <kaity>	 jdlrobson: oh your out of office
[22:54:48] <jdlrobson>	 *you're ;P
[22:56:09] <kaity>	 :) jdlrobson increase white outline around dot
[22:56:15] <kaity>	 jdlrobson: and dot smaller
[22:58:20] <kaity>	 jdlrobson: what size are you using now?
[22:58:55] <jdlrobson>	 lemme see
[23:00:20] <jdlrobson>	 border 1px and it's inside a 14.4px square
[23:09:17] <jdlrobson>	 ^ kaity 
[23:10:03] <jdlrobson>	 rmoen|foods: also ping me when back. Keen to get this Gather stuff wrapped up before the end of today!
[23:11:25] <kaity>	 jdlrobson: what size is hamburger icon?
[23:12:35] <kaity>	 jdlrobson: is it resized from the 24x24 asset?
[23:12:37] <jdlrobson>	 22 height
[23:12:43] <kaity>	 ok
[23:12:44] <jdlrobson>	 yeh it's the standard size of all icons
[23:12:50] <jdlrobson>	 for whateeeeverr reason
[23:13:28] <jdlrobson>	 it looks like it should be 24x24 but i'm too tired to debug right now :)
[23:13:54] <kaity>	 jdlrobson: try a white border of 3 px
[23:14:26] <kaity>	 jdlrobson: and dot in a box of 13 px
[23:15:44] <jdlrobson>	 kaity: yeh it's 24px by 24px now i found a bug
[23:20:42] <jdlrobson>	 @kaity https://usercontent.irccloud-cdn.com/file/Y8ph8Hzb/Screen%20Shot%202015-07-01%20at%204.20.32%20PM.png
[23:21:47] <kaity>	 jdlrobson: white border looks good. can you make dot in a box of 10px?
[23:22:40] <jdlrobson>	 fun times https://usercontent.irccloud-cdn.com/file/BQmANHVP/Screen%20Shot%202015-07-01%20at%204.22.26%20PM.png
[23:23:47] <jdlrobson>	 ^ kaity 
[23:24:09] <kaity>	 jdlrobson: looks great!
[23:24:25] <jdlrobson>	 ok great i'll push a patch
[23:24:42] <kaity>	 jdlrobson: thanks
[23:25:22] <jdlrobson>	 np
[23:32:35] <rmoen>	 jdlrobson: sorry, wasn't around when you pinged.  As I said earlier, afk touring the property management folks through the place
[23:33:04] <rmoen>	 I'm kinda stuck on the tests... I will push what I have and you can see maybe?
[23:33:27] <rmoen>	 While writing new tests, some steps are failing that were not before so idk
[23:33:55] <rmoen>	 i will look into the issue you pinged about
[23:45:46] <jdlrobson>	 rmoen: yeh i think fixing the broken 2nd interstitial should take priority
[23:45:59] <jdlrobson>	 i mean we could merge the patch you've got and do tests in a follow up
[23:46:45] <rmoen>	 jdlrobson: yeah, thats fine with me
[23:47:45] <rmoen>	 jdlrobson: so i'm seeing the tutorial just fine
[23:47:53] <jdlrobson>	 rmoen: update MobileFrontend
[23:47:57] <rmoen>	 ok
[23:48:36] <rmoen>	 jdlrobson: PageActionOverlay was moved
[23:48:39] <rmoen>	 i suppose ? 
[23:48:47] <jdlrobson>	 i put a fix in the task
[23:48:54] <jdlrobson>	 it just needs a new argument
[23:49:09] <rmoen>	 ok
[23:49:13] <rmoen>	 reading the task