[09:00:38] good morning! [09:06:30] hey joakino [09:07:39] good morning phuedx :D [09:08:19] joakino: why are you so fucking chipper? [09:11:43] phuedx: it is necessary to express mood on online conversations or people will assume the worst [09:11:58] good morning phuedx >:( [09:12:01] :D [09:12:02] better [09:12:13] haha [09:12:19] fucking taxes >:( [09:12:36] don't get me started [09:12:48] are you counting it as work? [09:12:50] i feel like it is [09:14:20] phuedx: today I am [09:14:55] thankfully this is the last paperwork crap until end of year chaos [09:15:13] it's going to be fun to figure out wtf is going on in december with all the fun stuff from this year [09:17:40] joakino: december stuff? [09:21:38] phuedx: freelance + ltd + employee finances of 2015 [09:22:42] bleh [10:58:46] ahah [10:58:50] welcome joakino :-D [10:59:05] my LTD ends its accounting year on June 30th [10:59:09] very handy [11:01:15] yep, very appropiate [11:03:07] let you shift personal incomes between fiscal years [11:03:31] i.e. stuff you earned on jan-june 2015 can be moved to 2014 [11:05:00] lunch time [11:22:06] out for lunch! [11:40:54] lunch! [12:42:41] back [12:42:43] sies [15:02:58] phuedx: "Access Denied: Restricted File" when i click your phabricator file link on https://gerrit.wikimedia.org/r/#/c/223176/ :/ [15:11:46] thx phuedx :) [15:15:59] niedzielski: mornin' [15:16:08] dbrant: hey hey! [15:17:07] niedzielski: it might be a good idea to set up a meeting with vibha and etonkovidova (and the rest of our team), and show them the developer screen. [15:18:12] niedzielski: (that's probably why vibha wasn't able to see the tooltips; she's not Chosen) [15:18:34] morning, guys [15:19:17] niedzielski: oh wait, alpha builds are down anyway. But still. [15:19:21] bearND: hey! [15:19:30] dbrant: i was thinking i'd mention it at the developer showcase if there's time. i have a little meeting with vibha today so i can show her then but i think the issue she was having is that the alpha build hasn't been updated since last month. etonkovidova and i will likely be finishing emulator setup today and can take a look. sound good? [15:19:39] hey! [15:20:02] niedzielski: yep, that's fine then [15:33:19] bearND: fyi I've rolled out 5% to production. [15:34:53] nice [15:53:31] dbrant: \o/ [15:54:18] dbrant: wanna add your name to the card? [16:01:38] kristenlans: google hangout error ? [16:02:47] ok now i'm in [16:03:00] there's a meeting? [16:04:00] phuedx: lol, oops [16:04:10] my alarm went off so i thought it was retro time [16:04:38] i thought for a moment that there was a meeting i hadn't been invited to [16:04:43] there was about 10 seconds of panic [16:04:51] my bad, sorry [16:04:58] and then FREEEEEEDDDOOOOOOOOMMMMM!!!1 [16:05:50] http://www.outsidethebeltway.com/wp-content/uploads/2010/04/braveheart-freedom.jpg [16:06:18] that's what i looked like when i had hair [16:06:29] huh? no pictures on ircloud [16:07:09] rmoen: disabled by default i think [16:07:19] click options -> embed images and video [16:08:43] "Embed uploaded files, doesn’t include images from other sites" wahh? [16:09:03] oh ok [16:09:26] Didn't see options for a second [16:10:19] @android app developers: How often the alpha app get's built? https://android-builds.wmflabs.org/ mentioned the last successful build at 1.7.2015 :( [16:12:37] rmoen: phew [16:12:56] kristenlans: :) [16:15:48] FlorianSW bearND dbrant|brb mdholloway: I noticed that too. The alpha builds have been flaky since the labs outage. They should be built every half an hour or so I think [16:29:20] niedzielski: FlorianSW : ohoh, yuvi said that the VM on that labs machine had issues and he wanted to rebuilt that. Here's the Phab ticket: https://phabricator.wikimedia.org/T104190 [16:31:09] bearND: :( So we can only wait until the task is resolved? [16:34:20] FlorianSW: etonkovidova niedzielski : If you don't want to build it yourself then you can download the latest apk from Jenkins. Look for the latest (first) entry in https://gerrit.wikimedia.org/r/#/q/status:merged+project:apps/android/wikipedia,n,z, go to the end of the page and click the "apps-android-wikipedia-gradlew" link, then go to "Status". [16:34:52] The certs are different so, updating from the old alpha apk does not work, BTW [16:36:27] bearND: hmm, ok, thanks for that way! :) [16:37:23] FlorianSW: and because the certs are different, keep in mind that you'll have to uninstall the alpha and lose any settings and history [16:39:11] niedzielski: yeah, i know, bearND mentioned the cert problem :) I'm using the alpha version only for testing of new featues and how they look, so no really "important" data is saved there. I uninstall the alpha version i have installed already and logging in with the new install isn't a big deal. Nevertheless: thanks for pointing this out :) [16:43:03] bearND dbrant|brb mdholloway|afk: are you guys having trouble getting images to load on master? it seems to work ok on my build from yesterday [16:45:11] bearND dbrant|brb mdholloway|afk: false alarm. i guess my emulator is acting funky. seems to work fine on a physical device [16:48:44] hey mobile ppl, is anyoneregularly using android 5.1? is it buggy? I know 5.0 is [16:58:18] MaxSem: i use the 5.1 emulator pretty regularly but just for wikipedia app development [17:01:23] MaxSem: i would vouch that the 5.1 emulator was working pretty well for me but this morning it stopped loading images in the gallery and restarting doesn't fix it. [17:01:38] heh [17:02:11] thanks, but emulator use is not what I'm looking for:) [17:02:33] rmoen: sorry no labs instances for sprints named yolo [17:02:36] cuz my phone is annoying me with suggestions to upgrade [17:02:38] Please ask next sprint! [17:02:48] guess I'll have to resist for now [17:03:15] YuviPanda|brb: ... [17:03:24] MaxSem: android 5.0 is buggy on your phone? In what way? *huh* [17:03:49] I've heard multiple complaints from other people [17:03:54] my phone is 4.4 [17:04:17] hmm, i'm using 5.0.2 and it's really stable [17:04:48] YuviPanda|brb: ok. Just rename this one then :) https://phabricator.wikimedia.org/T105038#1434962 [17:05:31] rmoen: :) I'm on a train, I think I'll have a sustainable solution in a few hours. [17:05:47] YuviPanda|brb: I need to setup an instance... [17:06:02] like before a few hours [17:06:14] I'm on a train and my phone anyway and I can't create one for you now [17:06:19] rmoen: what's the instance gonna do? [17:06:26] ... [17:06:46] YuviPanda|brb: Automated testing on Reading projects [17:06:55] So I can scope the project name appropriately? [17:06:56] YuviPanda|brb: https://phabricator.wikimedia.org/T104842 [17:07:08] Sure [17:07:18] YuviPanda|brb: so https://phabricator.wikimedia.org/T104559 is a no go too then? ;) [17:07:27] (no sprints named yolo constraint) [17:07:33] rmoen: alright. I'll call it reading-smoketest? [17:08:06] YuviPanda|brb: Sure.. I'm not sure why the project names have to be so specific as they are high level.. [17:08:09] bmansurov: what's the problem with rebasing [17:08:18] you are able to rebase locally? [17:08:35] jdlrobson: haven't checked, let me see, but on the site I don't have enough permission [17:08:39] rmoen: I explained on the ticket - editor engagement is a nightmare because it has lots of unrelated instances with unclear ownership [17:08:51] YuviPanda|brb: I guess I just don't understand, seems like you want to limit the amount of projects and then you want them to be overly specific [17:08:54] So I'm trying to prevent a recurrence :) [17:09:22] YuviPanda|brb: I see.. The problem IMO with editor-engagement is that nobody knew they could create scoped projects. .:) [17:09:26] jdlrobson: it says current branch is up to date, so no problem rebasing locally [17:09:44] you're pushing to your local branch [17:09:57] rmoen: no I don't want to limit the number of projects - quite the opposite, I want to expand them. [17:10:04] so if you don't care about history you can simply do `git push bmansurov mybranch --force" [17:10:12] ok [17:10:14] YuviPanda|brb: ok. Let there be more projects :) [17:10:19] alternatively you can push a separate branch [17:10:32] YuviPanda|brb: name it how you see fit :) [17:10:48] Will do [17:11:07] :) [17:11:14] YuviPanda|brb: <3 <3 <3 [17:19:52] YuviPanda|brb: looking at android-builder right now. I see the android app repo under /srv but where is the build tool stuff (https://gerrit.wikimedia.org/r/#/admin/projects/labs/tools/wikipedia-android-builds) cloned to? [17:23:52] YuviPanda|brb: do you have a build user for this? [17:29:12] bearND: for twn stuff, i had tried to get an account in the past but was denied. do i need to transfer yours to me? [17:30:39] niedzielski: no, when the time comes I'll talk to the TWN guys, so they get you on there. When that happens I'll most likely lose my access. That's what happened when I took over from Yuvi last year. [17:31:20] bmansurov: just a minor talking point on your patch then i think we are good to merge. [17:31:25] bearND: ok cool. thanks! [17:31:29] jdlrobson: meeting? [17:31:47] jdlrobson: i mean another meeting now! [17:31:51] yup i know :) [17:31:58] but yeh ^ [17:32:20] phuedx|bath: joakino retro [18:01:57] rmoen: I'm walking bd808 through creating your project now. [18:02:22] YuviPanda|brb: bd808 :) [18:02:53] https://wikitech.wikimedia.org/wiki/Nova_Resource:Reading-smoketest [18:16:54] bearND|afk: I was just doing it as root, and haven't setup the build tool stuff at all. [18:17:00] was going to get it to build an apk first [18:21:46] niedzielski: not seeing the inline comments... [18:22:08] dbrant: i promise you i wanted to publish them so bad! [18:22:18] must have had the wrong patchset [18:22:20] just a moment [18:24:43] dbrant: ok there we go. i think a new patch came through between when i commented and when i went "up to change" [18:24:57] thx! [18:34:51] np, sorry for the delay! [18:35:22] dbrant: hey, quick question: for the app language picker funnel, we only want that turned on for pick events originating from the search bar, not language settings, right? [18:36:30] niedzielski: we do want both. If you look at the schema, there's a "source" parameter that tells whether it was launched from the More menu vs. the Search bar. [18:36:52] dbrant: ah, you're right. thanks! [18:41:25] niedzielski: good comments; you may want to base yours on this now: https://gerrit.wikimedia.org/r/223361 [18:41:46] niedzielski: since i've added a TimedFunnel(tm) [18:41:47] dbrant: yeah, i think so. there were a couple other fields i was thinking might be appropriate. namely, session id and install id [18:43:43] niedzielski: actually, there's no reason the base Funnel class can't just create a session ID itself, and then any child class can use the session ID if they want... [18:44:29] dbrant: i'm nervous changing that class though! the backend is pretty strict about added / missing fields [18:45:44] niedzielski: oh, i'm not saying the base Funnel class would insert the session ID into the data; it would just create the session ID and make it available for descendants to get. [18:46:32] niedzielski: and in any case, the session ID actually doesn't always have the same name in the various schemas :( [18:47:18] dbrant: i'll see what i can do. maybe i can make overridable method, getAppIdFieldName() or something, that is used to log in preprocessData [18:52:01] hey joakino and phuedx [18:52:17] kaity: yup? [18:52:24] yo kaity ! irccloud? [18:52:28] did you see my email in response to "Phab workflows follow-up"? [18:52:34] just wondering if you had thoughts [18:52:49] joakino: oops no still using limechat [18:53:06] YuviPanda: I see. I still think the build script might be useful, at least for setting required env vars [18:53:26] bearND: oh sure, but the gradlebuild should work without it because we're using it to setup android env too [18:53:51] bearND: the upstream bug seems like the cause... [18:54:05] kaity: let me find that [18:54:34] YuviPanda: Well, it does seem to need at least ANDROID_HOME set, and from what I remember there were a few other env vars needed as well to run this on a headless machine [18:56:02] YuviPanda: see https://git.wikimedia.org/blob/labs%2Ftools%2Fwikipedia-android-builds/03ceee755fdea4a172244b037d51b27dd657723d/src%2Fbuild.py lines 11-14 [18:56:20] I can try that out tomorrow (or you can try it out!) [18:56:23] kaity: i remember now, you have very interesting thoughts about our "product" but sadly we can't only focus on that, we have a bunch of things to maintain too with a small team [18:56:43] kaity: I agree that'd be a good focus for a pm to take on [18:57:04] YuviPanda: ok, will do. Just not sure what info you need for puppetizing [18:57:13] kaity: also content presentation is something that editors want to have control over [18:57:31] * regarding the wiki articles [18:57:58] bearND: I think thing to do is: 1. set it up manually, see if it works, 2. if so, create a new project named android-builds and set up there with some puppetization [18:58:06] joakino: oh true I didn't mean the only product, i meant for a PM to take on, and work on for a certain amount of time - similar to gather [18:59:27] yeap, i think jonk was accurate in his response to you, even though a bit abstract. i'll find some time to answer the email [18:59:32] kaity: ^ [18:59:39] YuviPanda: or maybe we just do 1. I still have hope that we can switch to being able to better use the Jenkins apks, depends on CI team, though. [18:59:47] sure [18:59:56] joakino: thanks [19:02:16] i rediscovered ze frank's "an invocation for beginnings" in our spretro: https://vimeo.com/40029641 [19:04:56] gonna head out [19:05:11] i;ll see you folks tomorrow, have a nice day [19:05:25] joakino: you too! [19:15:44] phuedx: setting up one.wmflabs.org :) [19:15:55] rmoen: lololol [19:16:38] terrible name, rmoen :P [19:16:48] lol YuviPanda I knew you would bark [19:17:33] but the instance is really.. one.reading-smoketest.eqiad.wmflabs , so its at least intuitive [19:18:26] YuviPanda: has highlights for wmflabs ? [19:18:36] no I'm just omniscient. [19:18:39] :) [19:18:45] I love that word [19:18:46] rmoen: unfortunatley that's not true - instance names are still global [19:18:53] yeah yeah [19:18:54] rmoen: and not project-restricted... [19:19:20] vibha: it seems alpha builds are down, not sure if the alpha version you have has the search language button or not. if it doesn't, let me know and i'll email you an apk [19:19:23] YuviPanda: what would you rather it be ? reading-smoketest.reading-smoketest.wmflabs.org? [19:19:35] yes, but that's just the fqdn [19:19:38] err [19:19:41] for .wmflabs.org? [19:19:44] but that is just silly [19:19:44] just reading-smoketests? [19:19:48] or reading-smokes.wmflabs.org! [19:19:55] reading-nicotine.wmflabs.org [19:20:50] YuviPanda: is this going to be an issue or can i continue on with my labs-vagrant provision ? [19:21:00] rmoen: nah, you can keep going :) [19:21:12] if anything i can rename the proxy [19:21:19] yeah, tha'tll be nice. reading-one maybe? [19:21:37] jdlrobson: did you received my message? [19:22:03] rmoen: hmm, there's also a mobile-smoketests project that jdlrobson has [19:22:06] yeah maybe. . i'll never understand why so much bikeshed over names in labs projects ;) [19:22:17] eh [19:22:51] rmoen: it's because, see https://wikitech.wikimedia.org/wiki/Nova_Resource:editor-engagement - a team with that name hasn't existed in ages, and it has a lot of instances, about 60% of which we do not know if anyone is using at all and hence can not clear out... [19:23:00] its not like it needs to be explicitly clear to everyone. [19:23:11] it does need to be scoped and clear to us labs admins :) [19:23:20] and there's only 3 of us and soooo many projects. [19:23:48] if it is called 'reading-smoketests' I know fairly quickly whom to ask about problems in that project / whom to notify for maintenance... [19:23:49] YuviPanda a simple solution: kill off the editor-engagement project [19:24:00] rmoen: we can't, because we don't know if people are using them. I"d love to. [19:24:07] I tried as well :P [19:24:14] YuviPanda: is there an undo for the kill all action? [19:24:16] ;) [19:24:19] phuedx: nope :P [19:24:26] YuviPanda: lesson learned from retrospective today, don't ask for permission :) [19:24:32] rmoen: heh :) [19:25:44] brb lunch [19:27:54] bearND: dbrant mdholloway|brb niedzielski Krenair what do you think about https://phabricator.wikimedia.org/T73959 ???? :/ [19:29:49] FlorianSW: I kind of doubt that adding "supported languages" will actually stop people from sending feedback in their language... [19:30:24] dbrant: ok, but what if they sent us feedback we don't read/answer or take any beenfit from...? [19:33:43] dbrant FlorianSW: what if we showed a warning, "Currently only feedback in German or English is supported"? [19:34:18] dbrant FlorianSW: i'm not sure that solves any problems. users can miss the message and still send feedback in an alternate language [19:34:56] niedzielski: in this case, we can't do anything, i know, but i hope that our users aren't so ignorant ;) [19:35:18] gn y'all [19:35:53] phuedx|afk: good night :) [19:39:03] FlorianSW: Google Translate usually does an acceptable job for letting us understand the gist of the feedback. We can still benefit from this. [20:15:47] YuviPanda: Do you still have the old keystore file for the alpha builds? [20:17:54] Yup [20:18:00] Am off for the day tho :( [20:18:05] I'll recover it tomorrow? [20:27:33] coreyfloyd: dbrant Do you guys know the status of the Apps section on this page? Q4 goals. Jon K is the owner but he is out. https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals#Mobile_Apps [20:30:45] mbinder: hmmm… i thought he updated… lemme see [20:45:56] YuviPanda: ok, ty. Will send out email about temporary build location, ... again [20:55:04] jdlrobson: hey, how does ResourceLoaderImageModule know what color to invert? I'm having a hard time changing the magnifying glass color to white. Do I need to change anything in the svg itself? [21:13:14] bmansurov: hey dude [21:13:20] lemme remind myself [21:13:32] i think the svg itself needs to have a fixed color [21:13:40] jdlrobson: https://gerrit.wikimedia.org/r/#/c/223446/ [21:13:40] but it's just via image magic [21:13:54] jdlrobson: can you take a look plz [21:14:40] bmansurov: sure. i just need to help Rob with something first though. IN mean time have a look at includes/resourceloader/ResourceLoaderImageModule for clues [21:14:52] jdlrobson: ok thanks [21:27:05] jdlrobson: I think I found what I was looking for. includes/resourceloader/ResourceLoaderImage.php has a function called variantize, which just changes the fill [21:29:50] joakino: ping :) [21:31:24] bmansurov: heyso did you work it out [21:31:32] FlorianSW: i think joakino is asleep now :) [21:31:50] jdlrobson: hmm, I was wondering, why he is still online :P [21:31:50] jdlrobson: not quite, because i need to change the icon color, not the fill. [21:32:05] bmansurov: mmm. might be worth seeing if matmarex is in wikimedia-dev [21:32:09] he wrote that he'd know best [21:32:23] jdlrobson: ok [21:32:27] bmansurov: so you need to change the stroke? [21:33:02] maybe someone else can help me :D I switched my gerrit e-mail to a gmail address to get rid of some spam ;) Now, filtering is very easy, but i haven't found a way to tag e-mails like Code-Review+1 or -1, because the minus and plus signs are used for some special regex functions in gmail. Does anyone know, how i can search for a plus or minus sign? :) [21:33:30] jdlrobson: yes [21:33:32] bmansurov: so images/icons/magnifying-glass.svg has a fill of #555 [21:33:42] are you not just trying to change that to white? [21:33:54] i'll check out the patch in a bit [21:34:00] FlorianSW: i have loadsss lemme check [21:34:14] jdlrobson: yes I am [21:34:57] jdlrobson: https://doc.wikimedia.org/mediawiki-core/master/php/classResourceLoaderImage.html#a1ed336d3c1d48e0bf49e552e2605d31a [21:34:58] FlorianSW: the problem with the gerrit mails is they appear as replies [21:36:21] jdlrobson: hmm, but a search should be possible, or not? (to be clear: It would be "just" a nice gimmick to see a red label for all code review -1 and a green for all +1 to get an overview which one can be marked as read in a batch operation :D [21:36:52] one thing i keep meaning to do is write a bot that gives me proper notifications lol [21:37:28] haha open since 2011 - https://code.google.com/p/gerrit/issues/detail?id=1097 [21:38:55] :D [21:39:24] "has posted comments on this change." NOT "jenkins-bot has posted comments on this change." < FlorianSW [21:39:29] maybe something like that would help? [21:39:29] I really like gerrit (and I know, that some of you can't understand that :P), but the e-mail spam is a real critic point :D [21:39:51] jdlrobson: that's a good one, thanks :) [21:41:20] bmansurov am looking closely at your issue [21:42:01] jdlrobson: ok, in the meantime i pushed an alternative solution [21:45:54] bmansurov: i think we should work out what's up with the inverting [21:46:40] jdlrobson: is there any issue with it? I think it does something that I cannot use. have you seen the code? https://doc.wikimedia.org/mediawiki-core/master/php/ResourceLoaderImage_8php_source.html#l00273 [21:50:33] i'm looking at the svg it was probably generated prior to standardisation [21:51:45] bmansurov: what happens if you just remove the fill? [21:51:52] from the svg [21:52:07] jdlrobson: i think i'll see some thin line around the icon [21:52:21] you 'think' ? [21:53:41] wait i'm confused.. where can i see this white magnifying glass? [21:53:50] seems invisible on beta labs [21:58:18] jdlrobson: yeah you can only see it as a file at /images/icons/search-white.svg [21:58:25] jdlrobson: when I remove the fill, the fill becomes black [21:58:49] bmansurov: yeh black is the default. That makes sense [21:58:57] i'm still confused though - why do we serve an icon you cannot see? [21:59:28] jdlrobson: i know, right: https://phabricator.wikimedia.org/T101145 [22:00:56] jdlrobson: thanks for looking into it jon. I'll take a look at it tomorrow [22:01:00] later [22:01:12] oh so it's only when js is disabled? [22:01:31] oh i think this is because it's a input[type=submit] [22:01:41] jdlrobson: yeah, but the icon is applied to the enclosing div [22:51:11] niedzielski: thank you. got the apk [22:51:21] vibha: gr8!