[04:47:23] hi mvdan. Not sure if now is a good time for you to chat but we can share some info also asynchronously. I've added some thoughts as comments at the end of https://phabricator.wikimedia.org/T67460. Feel free to comment there or ping me here. [05:43:55] hey guys. sorry not available today in the end. yeah, I'll reply asynchronously. [05:57:59] mvdan: no problem. [08:44:52] morning [08:59:02] morning [12:40:57] phuedx|afk, joakino: howdy, it sure is quiet today [12:41:09] bmansurov: yo [12:41:11] yup [14:39:58] dbrant: good morning! quick question for you about the floating action button/toc button styles [14:40:10] mdholloway: yes! [14:40:18] dbrant: i thought a separate style was needed because of this acceptance criteria in the phab task: [14:40:31] Styling: 16dp minimum from the edge on mobile, 24dp minimum on tablet/desktop. [14:40:49] *criterion [14:41:16] dbrant: but if the generic FAB style you had is what we want, i'll happily take the one i added out [14:42:30] does anyone know how to create new response templates in OTRS? [14:42:33] Deskana: ^ ? [14:42:52] bgerstle: I think you need to get an OTRS admin to do it. [14:43:11] and where would i find one of these magical creatures? [14:43:29] as a stop-gap, is there at least an easy way to have a personal signature? [14:43:41] e.g. linking to the iOS team page instead of mobile web? [14:43:44] I think you can change your signature in your settings. [14:43:59] i odn't see anything tha tlooks like that... [14:44:12] i can see my queues, skins & themes.. [14:44:24] mdholloway: hmm, vibha wrote that bullet point; I must have glossed over it... [14:44:31] mdholloway: really, all we want is for the positioning of the button to be consistent with other Google apps, and the style with 8dp seems to be correct. [14:44:35] bgerstle: #wikimedia-otrs is a good starting point. [14:44:46] ah [14:45:10] thanks [14:45:13] bgerstle: I've found RD to be the most responsive admin in the past. [14:45:19] awesome, thanks for the tips! [14:45:25] bgerstle: Failing that, otrs-admins@lists.wikimedia.org should get you a response eventually, but it is slower [14:45:50] dbrant: cool. i'll take out the special style definition and we can always revisit at the design review phase if necessary. [14:45:55] Glad to be of assistance. :) [14:46:50] dbrant: also, for the record, i think i like the larger button size better, though that's probably just because i'm more used to seeing it [14:51:30] mdholloway: yeah, actually that's still to be decided. it's true that very few of the Google apps actually use the "mini" style... but we'll be able to change it easily. (it's one line of code)) [14:52:38] mdholloway: on a small handset display, i just felt like the button obstructs a little too much article content. [14:59:07] dbrant: hey! i was hoping to solicit your advice for "app retention stats." which of the following would you recommend? A) create DailyStatFunnel or equivalent that we can grow as needed. B) create InstallAgeFunnel or equivalent. C) create ArticleFunnel that we can grow as needed. the install age would only be added once a day on a "logLoadComplete". D) something else :) [14:59:50] dbrant: looks like google recommends 16dp from edge on handsets, 24dp on tablet/desktop, as vibha specified: http://www.google.com/design/spec/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button [15:00:28] dbrant: i was actually looking for the button dimensions but didn't see them; in any case, the smaller size is not difficult to hit. [15:02:05] niedzielski: i suppose i was thinking of InstallAgeFunnel. How would you see DailyStatFunnel or ArticleFunnel growing? [15:03:59] mdholloway: hmm, yet again it's futile to look to the Google apps for any consistency... the Gmail app has the margins at 8dp, but the Drive app has 16dp. [15:04:13] dbrant: lol, classic google [15:05:02] mdholloway: let's keep it at 8dp, since i think it's more important to have the button interfere as little as possible with article content. [15:05:06] dbrant: either could include more data fields such as data sent or average time to load a page. ArticleFunnel would still be applicable for sending install age since it happens on some page loads [15:07:03] dbrant: yeah, we're definitely a more text-heavy app than most; i think that's sound. [15:12:27] niedzielski: then let's go with DailyStatFunnel, since it sounds a little more tightly scoped. [15:13:00] dbrant: will do. thanks! [15:24:45] hey folks [15:24:49] good afternoon [15:34:10] dbrant: looking at the custom error view patch, is this eventually going to be used for all error displays in the app? [15:36:52] mdholloway: i'm doing a little more work on it... the custom view itself will probably be used only in the Search fragment and the main Page fragment. But the patch will also contain functions to get well-formed error messages that can be used in Toasts and SnackBars. [15:38:22] dbrant: ok, cool. i was just wondering because i noticed that the old error view(s) are still used, for instance, when a network error is encountered while loading an artilcle [15:38:50] dbrant: and yet the commit message had to do with displaying errors consistently [15:45:56] mdholloway: well, the patch adds *functionality* to display errors consistently, with hooking it up to the Search fragment as a bonus. Hooking it up everywhere else will be a subsequent patch. [15:46:33] dbrant: got it. [15:48:52] joakino: good day(but not afternoon here) :) [15:49:05] :D [15:52:58] bearND: something like this? https://gerrit.wikimedia.org/r/221821 [16:15:41] dbrant: updated comments for that patch [16:22:41] dr0ptp4kt: are you working? [17:15:27] phuedx|afk: about the barry script, in the repo I only see two files: the script and readme. Where can I find the files you mention in your comment? [17:19:48] phuedx|afk: oh they are functions [17:20:59] dbrant|brb: bearND: do guys anticipate having any use for a developer preference setting for the old knowsToc shared pref? if not, I'll scuttle it as niedzielski suggested [17:21:31] i didn't have any particular use case in mind for it [17:23:14] bearND: just went through these issues that you linked to [17:23:40] regarding timestamps in version name, the problem is that it's hard for us to get the same versionname/code that you guys got when you built [17:24:08] so I'd suggest either hardcode that at each release commit, or use something slightly different that doens't change over time like that [17:24:18] regarding the custom repo, yeah, that's a blocker [17:24:26] so perhaps ping me again once the maven thing is solved [17:29:34] mvdan: are those all the issues or are there more? [17:30:08] well, the version part we can override [17:30:39] I think the maven repo is the last issue, yes [17:30:43] we'll have to see [17:31:06] mvdan: great. I hope we get this resolved soon. I'll ping you then. Thank you! [17:42:30] mdholloway: scuttle it [17:43:01] dbrant: cool. actually just took it out and was about to offer in a gerrit comment to put it back if anyone complained [18:01:17] l/nick phuedx [18:09:05] hullo [18:17:39] s'up phuedx [18:23:03] kaity do you have any agenda items fro reading web design review? [18:23:14] kristenlans: no [18:24:34] kaity think we shoudl cancel? [18:24:49] ^^ phuedx joakino [18:24:54] kristenlans: sure unless joakino has anything to discuss? [18:25:54] i dont think so atm [18:26:09] kristenlans: kaity ^ [18:28:02] kristenlans: +1 to cancel [18:28:41] vibha: ping! looking forward to your comments on the language selection button. [18:28:53] joakino: kaity this might be a light quarter for web design review meetings :-) [18:29:23] true [18:29:24] yerp [19:12:15] dbrant: should i create a new phab task for the "delete recent searches" floating action button or just tack the patch to your existing task (https://phabricator.wikimedia.org/T101726)? [19:14:23] mdholloway: yep, tack it on that one. (reopen it & put it in this sprint) [19:14:39] dbrant: cool, thx [19:52:17] mdholloway: sending them right now [19:54:41] vibha: great! thank you! [20:29:57] kaldari: hi :) Can I kindly ask you to take a look at https://gerrit.wikimedia.org/r/#/c/223349/1 again? :) [20:32:53] niedzielski: it looks like i can't actually get the share-a-fact tooltip to show up, no matter what I do... [20:33:30] dbrant: that's no good. want to hop in the batcave? [20:33:53] niedzielski: yep [20:34:07] dbrant: ow [20:34:09] omw [21:55:49] dbrant mdholloway|bbl bearND: hey devs! i'm still wrapping up my work on install time but i was curious what i should work on next and thought i should ask sooner rather than later. there's some recent maven discussions but there's one story left on the board unclaimed, "Use TextInputLayout where appropriate." [21:56:53] niedzielski: there's a crash that needs investigating... (refresh the Next Sprint column) [21:58:13] niedzielski: what's left to be done on the maven stuff? if not much, then go for it! would be kind of awesome to sweep the whole board in the first week of the sprint... [21:58:27] dbrant: should we pull this into the sprint? and, if so, is it higher priority than the story? [21:58:50] mdholloway: I made some comments on this ticket [21:58:50] https://phabricator.wikimedia.org/T73136 [21:59:11] vibha: oh yeah, i saw that email come through, looking now... [21:59:24] Happy to get on a hangout so we can tweak it together [21:59:54] mdholloway: i tried to document everything i knew was left in that email. i think any jenkins job changes would be my biggest concern because we have to work with other parties and sometimes need new access rights [22:00:11] niedzielski: yeah, i think crashing bugs should always take precedence, if we have time to spare. [22:00:18] vibha: yeah, one sec and then let's hop on a hangout if now is good [22:00:42] dbrant: should we always move crash bugs into the current sprint then? [22:01:37] mdholloway: yeah sure, give me 5 mts. Need to retrieve my eye glasses from the 6th floor [22:01:52] vibha: ok, give me a call whenever you're ready. just want to talk through your comments so i don't miss or misinterpret anything. [22:02:15] niedzielski: i think so; at least if they haven't yet been investigated, and if they're happening in the current production build. [22:05:54] dbrant: ok, i beach boy'd that bogey [22:06:26] dbrant: i'll pick up when i close app stats [22:06:35] niedzielski: great [22:41:05] mdholloway|afk: toc looks great btw [22:48:44] Hi YuviPanda any words of wisdom for https://phabricator.wikimedia.org/T104190?