[16:23:03] bearND: should we do a a new version of java-mwapi and promote it? [16:24:02] niedzielski: yes, please. It would be also good to document the steps if they are non-trivial. I don't know what Gradle has that is similar to a mvn release plugin [16:24:26] bearND: i think we upload archives as per usual and promote through web gui [16:24:31] bearND: i'll keep notes [16:24:42] niedzielski: i mean the bumping of the version numbers [16:24:58] bearND: do we tag versions in the java-mwapi like we do in app? [16:25:04] niedzielski: maybe add a bump script to the java-mwapi lib [16:25:26] niedzielski: we have not done that in the past but it wouldn't hurt [16:26:07] bearND: i'll dig in shortly and sync up with you later. thanks [16:27:34] niedzielski dbrant : great! Thank you. Once we got a release version then I don't see any blockers of making a beta release. I think since there are some outstanding design questions we may just want to do just a beta release and not prod release candidates. [16:29:03] bearND: nice! i can take on beta release responsibilities if it's not too late in the day (tomorrow is moving day so i can't work late) [16:29:22] bearND: niedzielski: awesome work! yes, beta should be good to go. [16:56:17] bearND dbrant do you guys mind if i go through a java-mwapi release and promotion manually this first time around, release the beta, then work on automating the java-mwapi process? i'm worried it will take me a little time to complete the scripts [16:58:04] niedzielski: that sounds reasonable. Just take good notes. [16:58:20] bearND: gr8, will do [17:11:02] niedzielski: bearND: i've got a slight issue: the latest master fails to build under Windows. It has a problem with settings.gradle line 6 [17:11:09] "String index out of range: 1" [17:12:07] dbrant: i think i know what the issue is. i can submit a fix candidate. would you be willing to test on windows on my behalf? [17:12:15] niedzielski: of course [17:12:22] dbrant: thank you, sorry for the hassle [17:12:47] dbrant: a quick hack to avoid this issue would be to comment out the last line (19) [17:15:43] bearND: coreyfloyd bgerstle standup [17:29:02] dbrant: i'm not sure what would stimulate the issue you described in the current codebase but would you mind trying this fix? https://gerrit.wikimedia.org/r/225341 [17:30:41] niedzielski: tried it; same error... [17:30:57] dbrant: thanks [18:01:55] dr0ptp4kt: vibha bearND niedzielski dbrant kaity|away Time to Android retro [18:46:12] niedzielski: I got it to build by replacing File.separator with '/'. My guess is that, since the file separator in Windows is '\', it might somehow be interpreting it as an unescaped escape character... [18:47:01] dbrant: ok, i was miles away from that conclusion. let me see if there's anything online about that [18:49:04] dbrant: ok, i think i've found the appropriate way to replace file separators. thanks for finding this issue and sorry it didn't come up sooner [18:53:57] niedzielski: "Could not find property 'Matcher' on settings 'wikipedia'"... [18:54:21] dbrant: ;( [18:54:29] dbrant: the import doesn't work? [18:55:11] niedzielski: hang on, when i ran it a second time, it worked [18:55:31] dbrant: phew [18:57:05] niedzielski: alright! let me just confirm that I can build it on my Mac as well, and then i'll merge [18:57:18] setting up jdk 7... [18:57:20] dbrant: sounds good! [18:57:55] dbrant: i like to say "js" sometimes for "just saying". i also like to think of the jdk as the "just developing kit" [18:59:07] niedzielski: do we know why it doesn't work with jdk 8? [18:59:33] dbrant: i do not know but i suspect the issue lies in the nexus plugin. we can open a task to investigate [19:00:05] dbrant: there were other nexus plugins but i chose this one because i noted that jake wharton used in his sdk-manager project which we use [19:17:07] niedzielski: bearND|afk: I'm having a lot of trouble setting up jdk 7 on osx... [19:17:34] dbrant: i do not have os x. what is the issue you're seeing? [19:22:44] niedzielski: the instructions that bearND emailed don't seem to work... my /usr/bin/java points to a location that these instructions don't address. [19:23:17] dbrant: is /usr/bin/java a sym link? if so, where does it link to? [19:24:54] niedzielski: it points to /System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands/java [19:25:58] dbrant: is "Current" a sym link? [19:26:52] it points to /System/Library/Frameworks/JavaVM.framework/Versions/A [19:27:46] the "A" directory contains the "Commands" directory that has all the binaries [19:30:40] dbrant: :( [19:31:10] dbrant: so you have multiple jdks installed? [19:31:42] niedzielski: i didn't, until i installed jdk 7 just now. [19:31:58] dbrant: ok, and java --version currently says 1.8, right? [19:32:02] right [19:32:12] dbrant: where did jdk7 get installed? [19:33:01] niedzielski: in the directory bearND mentioned in the email: /Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk [19:34:43] dbrant: hm, i might be able to help in the batcave or we can wait for bernd [19:35:08] dbrant: would it be possible for me to move your 1:1 to 5 pm eastern / 2 pm pacific today? [19:36:21] dr0ptp4kt: hmm, actually could we have it on Monday? [19:36:39] dbrant: yep, will do [19:36:55] dr0ptp4kt: thx! [19:42:19] dbrant bearND|afk: do you guys know why this won't merge? i +2d it: https://gerrit.wikimedia.org/r/#/c/225339/ [19:46:18] niedzielski: the java-mwapi [19:46:18] project doesn't have the gate-and-submit triggers. You have to +2 for both Verify and Code Review. [19:46:54] dbrant: i'm going to throw so many +2s on this [19:46:59] dbrant: thanks! [19:49:26] niedzielski: did you click "publish and submit"? [19:50:28] dbrant: ah, no. i only clicked "publish" [19:50:52] dbrant: it seems that's just for comments then? [19:51:29] niedzielski: dbrant: yeah, we should add those CI triggers to it. [19:54:39] dbrant: re: JDK 7: I had to create a sym link: /System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK -> /Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/ [19:55:22] bearND: yes I've done that... but my /usr/bin/java doesn't point to CurrentJDK [19:57:43] dbrant: ah, ok. Mine is /usr/bin/java -> /System/Library/Frameworks/JavaVM.framework/Versions/Current/Commands/java [19:58:28] bearND: that's what mine is, too. So how is yours working? [20:01:45] dbrant: not sure why. I think I just followed some steps I found on StackOverflow a while ago. [20:13:43] dbrant: if my proposed link doesn't work on your Mac then you can also uninstall JDK 8. If that still doesn't do the trick then I would reinstall JDK 7. [20:15:06] bearND: what proposed link are you referring to? [20:17:07] dbrant bearND: would one of you mind giving this a quick review? the promotion process requires devs appear in the POM file. https://gerrit.wikimedia.org/r/#/c/225387/ [20:18:25] dbrant: I've added a paste for this: https://phabricator.wikimedia.org/P1009 [20:18:54] dbrant: /System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK should point to /Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/ [20:19:08] dbrant: but it's probably good to write down what it pointed to before [20:20:59] bearND: right; that's what you had in your email (and it's not working for me). But the thing is, /usr/bin/java actually points to the "Current" folder, not the "CurrentJDK" folder. [20:21:20] bearND: so I'm still not clear why it's working on your machine at all [20:24:16] dbrant: what is $JAVA_HOME set to on your machine? (I've got echo $JAVA_HOME [20:24:16] /Library/Java/Home) [20:24:31] minus the trailing ) [20:24:48] bearND: hmm, i don't have a JAVA_HOME [20:31:06] bearND: ok, with JAVA_HOME set, it's working! [20:31:30] cool. I'll add that to the paste [20:31:38] thx [20:40:11] dbrant|brb: can i get a review on this guy? he's holding up the beta. https://gerrit.wikimedia.org/r/#/c/225387/ [20:40:24] bearND: any twn commits to get in? [20:42:22] niedzielski: will check. In the meantime you could do a commit with only us two listed, then you could have another one later when dbrant|brb and mdholloway|afk get back online [20:42:55] bearND: if i do the promotion, i was hoping to have all devs listed for that. what do you think? [20:44:24] niedzielski: well, it depends on how long you want to wait. [20:45:24] niedzielski: but ok, i guess I can +2 the patch [20:45:26] bearND: i was thinking the information is likely correct. the usernames were copied from the original jira ticket, the emails and names from gmail. i would prefer to make amendments after the fact if there really is an error. what do you think? [20:46:00] niedzielski: ok [20:46:10] niedzielski: merged it [20:46:19] bearND: sweet! thanks! [20:46:46] niedzielski: you may want to send them email so they can check it later [20:46:53] bearND: will do [21:12:28] bearND dbrant|bbl: any preference on java-mwapi tag format? i was going to go with "r/1.3.2-2015-07-17". /cc mdholloway|afk [21:13:22] niedzielski: That would be ok with me, but "r/1.3.2" would be sufficient, too. [21:13:59] bearND: since we don't include the date in the version of the jar, r/1.3.2 sounds good [21:14:19] niedzielski: the bump script for java-mwapi should also add another commit to increase the version number and add -SNAPSHOT back, similarly to the mvn release plugin [21:15:01] bearND: will do [21:15:06] bearND: (post-release) [21:19:16] niedzielski: thanks [21:31:14] niedzielski: i don't see any patch to be reviewed for https://phabricator.wikimedia.org/T89988. Why did you move it to Needs Code review? [21:31:43] bearND: it's this guy: https://gerrit.wikimedia.org/r/#/c/224528/ [21:32:00] niedzielski: oh, doh, got it. Thanks [21:32:08] bearND: np, thanks for keeping me honest [21:36:16] niedzielski: ok, merged this one and moved the two cards to QA. Someone else can moved them to Done on Monday [21:36:56] bearND: cool, thanks! [21:37:16] bearND dbrant|bbl: I think we're ready for beta building then? [21:38:25] niedzielski: I'm wondering if we should merge https://gerrit.wikimedia.org/r/#/c/224512/1 anyways. The comments probably don't warrant to not include it [21:39:18] bearND: i don't object but i do worry a little about needlessly posting a runnable (if that is the case) [21:40:25] niedzielski: good point. Maybe you want to expand on your comment some more to make it clear to mdholloway|afk [21:40:45] bearND: sure i can do that [21:41:22] niedzielski: just checked out the patch again, and am not too crazy about the background color. So, let's skip that patch for today [21:41:46] bearND: ok, then nothing else pending, right? [21:41:46] niedzielski: so, it's all good from my end for a beta [21:41:55] bearND: gr8! [21:42:08] niedzielski: I don't know when dbrant|bbl is back, but I think you can just go ahead. [21:42:42] niedzielski: for a beta we don't need approval from the tech pro [21:43:07] bearND: it'll take me a bit to get through the testing and release notes. do you want me to ping you guys before publishing? [21:44:19] niedzielski: yeah, let me know when you have a compilation of release notes [21:44:26] bearND: ok will do [21:58:17] bearND dbrant|bbl mdholloway|afk: hm, i was able to stimulate the blank screen issue on the last beta release by rotating the device as it was loading during boot up [22:07:47] hmmm [22:17:07] MaxSem: hey can u send me that query? For article summary - want to double check we're using best one [22:17:55] you're already usig it [22:17:59] ? [22:18:30] MaxSem: is param on mobileview? [22:18:47] action=query&prop=extracts [22:19:00] MaxSem: ah gotcha that's right [22:19:52] bearND: hey u still online? [22:19:59] mhurd: yes [22:20:18] bearND: cool! Have a minute for quick hangout? [22:20:41] sure [22:21:20] bearND: one min gotta find a quiet spot... [22:21:32] mhurd: ok, i'm in the batcave [22:27:42] bearND mdholloway|afk dbrant|bbl: on GB, the table of contents FAB scrolls with the article. is this a blocker? [22:28:14] mhurd: https://phabricator.wikimedia.org/tag/mobile_content_service/ [23:03:03] niedzielski: hmm, that does look quite funky. Good catch! [23:03:14] niedzielski: i think we can wait until monday [23:03:44] bearND: ok cool, i finished testing and everything else looked good to me