[00:26:59] rmoen: sorry i didnt get round to testing out your docs [00:27:02] i'll do it first thing tomorrow [00:27:20] how goes the vagrant stock data? [01:41:28] It's time for the percolator. [16:00:03] hi! [16:30:55] hey joakino :) [16:36:56] hi jdlrobson ! :D [16:37:12] joakino: how is tulum? [16:38:02] jdlrobson: hot and humid, still havent done much [16:38:16] plenty of street dogs that dont give a fuck [16:39:50] haha [16:40:06] yuvipanda and i came up with an app in India called "is that dog dead" [16:40:14] you point your phone at the dog and it tells you if the dog is dead [16:43:26] jdlrobson: you could also have "does that dog give a fuck", it would be a fairly easy app [16:48:15] niedzielski: just to let you know - no more errors "expected 1.7 but found 1.8" Android sdk - thx! [16:48:29] joakino: spin off app! :D [16:48:31] etonkovidova: yay! [17:11:42] joakino: dbrant bearND bgerstle would you please add items to https://etherpad.wikimedia.org/p/Scrum-of-Scrums ? [17:12:04] oh whoops sorry totally missed the lead meeting [17:12:19] dr0ptp4kt: nothing to report this week, no upcoming releases [17:12:30] bgerstle: mind adding that? [17:12:33] ;) [17:13:29] dr0ptp4kt: done! [17:20:40] dr0ptp4kt: done [17:26:55] etonkovidova: would be great to have your input on https://www.mediawiki.org/wiki/Reading/QA/Sample_articles about which pages you test regularly on for apps! [17:29:40] jdlrobson: a good idea! will do [18:37:27] kristenlans_: able to spare a few minutes in the batcave? [18:40:11] sure thing [18:40:57] I'm in dr0ptp4kt [18:41:24] kristenlans_: k one moment [19:04:47] * jdlrobson lunch [19:12:25] * bmansurov lunch [19:13:43] * rmoen lunch [20:04:21] rmoen|lunch: having issues getting a new labs instance up and running but for the most part your script seems to work beautifully :) [20:19:49] jdlrobson: Thats good. I'm struggling with wether we should include templates in the dumps or manually dump each template for import. It seems that to avoid template duplication, we would need to manually select each template and not include templates when exporting articles. Thoughts? [20:23:18] jdlrobson: also, I can add you to project reading-smoketest [20:23:26] you should be able to fire up an instance in there [20:23:50] rmoen: i'm hitting `Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Resource type mw-extension doesn't exist on node mf-browser-tests.mobile-smoketests.eqiad.wmflabs` for some reason [20:24:11] ew [20:24:18] labs-vagrant doesn't work [20:24:21] i added you to the project [20:24:27] rmoen: this is on an instance i setup [20:24:32] i wanted to go from start to finish [20:25:01] hmm might be a recent thing as labs-vagrant was working last week [20:25:44] Added you, i'm going to add bmansurov, and joakino to the project as well. [20:43:09] kristenlans_: can you share the link to the current mobile web sprint? thanks [20:50:26] jdlrobson: ^? [20:52:52] rmoen: ^> [20:52:53] ? [20:57:14] bmansurov: yeah [20:57:28] rmoen: do you have the url to the current sprint board? [20:57:31] bmansurov: https://phabricator.wikimedia.org/tag/reading-web-sprint-52-zoolander/ [20:57:36] rmoen: thanks [20:57:40] sorry making coffee [20:57:46] ah thnaks rmoen sorry bmansurov was in a meeting [20:57:54] kristenlans_: np, thanks [20:58:09] bmansurov: whenever i can't find it, i just type "reading" in the search box and it autocompletes with our boards [20:58:37] rmoen: cool tip, i used to get them during sprint kick-off, which i missed yesterday [20:59:07] oh yeah you missed Zoolander bmansurov. I hope you approve :-) [20:59:24] kristenlans_: sounds good to me [21:19:48] bmansurov: i'm confused - we pushed the max width to stable? [21:20:07] which card did this? [21:20:47] * jdlrobson really can't keep up with all these padding/width changes [21:20:49] jdlrobson: wasn't it already there? https://en.m.wikipedia.org/w/index.php?title=Eid_al-Fitr&mobileaction=toggle_view_mobile [21:21:02] bmansurov: i'm seeing that but i'm curious if that's an accident [21:21:08] i don't remember us intentionally pushing this out to stable [21:21:51] jdlrobson: hmm, i think in beta/alpha we are just centering the everything, but in stable the main content already had a max-width and was centered [21:22:04] since when? [21:22:14] jdlrobson: let me check [21:22:33] bmansurov: it seems to have been introduced in https://phabricator.wikimedia.org/T103307 [21:22:59] jdlrobson: re-introduced [21:23:01] unfortunately the task doesn't indicate when this issue was introduced [21:23:26] jdlrobson: the patch does [21:23:47] bmansurov: the description says "We used to have this rule" [21:23:56] but it doesn't say the task that introduced it or point at a patch that broke it [21:24:02] that's what i want to know [21:24:06] jdlrobson: https://gerrit.wikimedia.org/r/#/c/219990/ [21:24:27] bmansurov: you are misunderstanding [21:25:18] i can see that patch added it but i'm not seeing where it got broken (and if it indeed got broken - we might be working on a false assumption) [21:25:28] jdlrobson: see the commit message [21:25:36] jdlrobson: it links to the patch that removed the max width [21:31:31] i did a git bisect and it seems to have been introduced back in the Mantle days [21:31:35] that's why i can't remember it i guess :) [21:35:23] jdlrobson: I see the rule was deleted in this file: https://gerrit.wikimedia.org/r/#/c/218781/8/resources/skins.minerva.tablet.styles/common.less [21:37:14] bmansurov: yeh i know, i did that intentionally. I didn't think it was meant to be in stable [21:37:17] i'm fixing up as we speak [21:37:36] causes lots more problems though unfortunately [21:45:08] bmansurov: okay pushed a new patch [21:45:31] rmoen: i'm gonna grab Krinkle_ if i can since he's in the office and complete https://phabricator.wikimedia.org/T105361 :) [21:45:50] my brain is too fried up to get frustrated with vagrant any more today [21:46:08] i'm pretty sure your script is pretty much done though minus the 2 issues i raised. [21:46:19] i'm gonna try again first thing tomorrow when i'm more functional [21:47:05] bmansurov: in case it's not clear i'm using ems rather than 1000 pixels since we need to do calculations involving padding and width and less doesn't allow you to add/subtract values with different units [21:47:10] jdlrobson: re:barry should the --tags be optional parameter ? [21:47:19] rmoen: yup tags should be optional :) [21:47:28] ok [21:47:30] empty string for no tags :) [21:48:47] dbrant|bbl: and bgerstle i'm interested if you can shed any light on https://phabricator.wikimedia.org/T105314 [21:49:06] jdlrobson: none whatsoever? [21:49:27] AFAIK we have our own extension [21:49:34] yeh but that proxies this module i think [21:49:35] that's the extent of my familiarity w/ the issue [21:49:39] sorry :-/ [21:49:45] who understands that extension [21:49:51] android, mostly [21:49:56] ok so dbrant|bbl :) [21:49:57] and mhurd who's on vacation today [21:50:00] doh [21:50:09] do you know how you use css from the app? [21:50:10] perhaps yuvi & brion too [21:50:30] jdlrobson: it's a bit dodgy, what do you want to know? [21:50:42] do you access production servers live in the app or do you generate a static file that you serve locally? [21:50:52] jdlrobson: used to be the former, now iOS does the latter [21:51:03] and we only do it when running a specific make goal [21:51:08] the former could be causing problems them [21:51:10] *then [21:51:14] i.e. we don't run it on every build like we used to [21:51:20] jdlrobson: it should be _very_ infrequent [21:51:38] we commit the grunt-generated files to the repo so we don't need to run it [21:51:55] (including files we pull from, IIRC, the production server hosting the extension) [21:52:11] but i think that would only effect the load on the server, not the problem you're experiencing (IIUC) [21:52:22] and like i said, our load on the server should be negligible [21:52:24] "should" [21:52:25] mmm [21:52:34] jdlrobson: show me the logs, baby [21:52:55] but, as far as what exactly the MobileAppExtension does.. i'm not sure [21:53:09] AFAIK it serves some files to us [21:53:15] how those files are formed.. i'm not entirely sure [21:53:18] some JSON, some styles [21:53:25] haven't delved too deeply into that [21:54:45] i'll debug some more i've only got https://phabricator.wikimedia.org/T105314 to go on [21:55:04] the graph confused me as i would expect the module to be the same as another module that web uses [21:55:40] https://grafana.wikimedia.org/#/dashboard/db/resourceloader?panelId=17&fullscreen&from=now-12h&to=now-5m is what im loking at [21:57:55] jdlrobson: we package the CSS into the Android app; we don't fetch it from production. [21:58:35] jdlrobson: and even when we rebuild the CSS for the app, we generally get it from vagrant locally. [21:58:42] dbrant: thanks. [21:58:45] so weird [22:02:23] rmoen: https://www.mediawiki.org/wiki/Talk:Reading/Setting_up_a_browser_test_instance#MediaWiki-Vagrant_role.3F [22:03:30] bd808, jdlrobson: I think we are close [22:04:01] bd808: I'm making a change right now based on jdlrobson latest feedback. [22:05:06] cool. let me know when I can help [22:05:27] bd808: aye will do [22:08:40] jerkins y u no merge mah patches >:( [22:13:11] bearND: hi there [22:13:31] matanya: hello [22:13:36] is there a bug about the fact videos haave no indication they are playable ? [22:13:50] if this is not known, i'll open one [22:14:00] couldn't find one in phab [22:14:07] matanya: https://phabricator.wikimedia.org/T105643 [22:14:24] matanya: i just look in https://phabricator.wikimedia.org/tag/wikipedia-android-app/ [22:14:41] yes, that. Thanks! [22:36:09] rmoen: do I need to be an admin to create an instance at https://wikitech.wikimedia.org/wiki/Nova_Resource:Reading-smoketest ? [22:42:29] bmansurov: yes but you already are :) [22:42:39] bmansurov: I added you to the project this afternoon [22:42:39] rmoen: am I? I'm a member [22:42:51] I think that means you can spin up instances [22:43:15] same level of access as myself, and i can spin them up [22:43:28] rmoen: you're also listed as an admin [22:43:30] rmoen: and a member [22:43:34] rmoen: i'm just a member [22:44:00] ok.. thanks for clarification. Can you spin up instances though ? Have you tried ? [22:44:41] rmoen: I don't see a button or a link to do so [22:44:44] adding youo [22:44:46] you [22:45:20] thanks [22:45:42] Added the team [22:45:47] bmansurov: done [22:45:55] mdholloway|afk dbrant bearND: i'm waiting feedback on the jenkins stuff. any preference on what i should pull from the backlog to work on? [22:46:01] awaiting* [22:46:42] rmoen: thanks, i still don't see it, maybe it needs some time to update. I see the following: |Admins=User:novaadmin,User:Robmoen,User:BryanDavis [22:47:14] you are a project-admin on reading-smoketest [22:47:35] you should refresh and see a link "Manage Projects" on the left nav [22:47:36] bmansurov: [22:49:44] oh man, i just realized with irccloud i can be logged into the same irc user on multiple things ;) awesome [22:49:54] niedzielski: I would first look at the tasks under Current Sprint in https://phabricator.wikimedia.org/tag/wikipedia-android-app/ which have not yet been pulled into sprint 62. One example is https://phabricator.wikimedia.org/T106332. [22:50:18] dbrant: any reason why those tasks are not added to sprint 62? [22:50:29] bearND: oh, i was wondering why this sprint seemed so light [22:51:16] rmoen: thanks, it's working now [22:51:28] bmansurov: np [22:51:29] niedzielski: my personal favorite is https://phabricator.wikimedia.org/T104746 [22:51:59] i mean i'm not claiming it for myself, but i would like to see that fixed [22:52:03] bd808: Could you advise on the approach for importing articles / templates ? https://gerrit.wikimedia.org/r/#/c/226230/ [22:52:42] niedzielski: and https://phabricator.wikimedia.org/T106392 (from the triage column), which i submitted this morning [22:53:58] bearND: ok, i'll grab that one since it sounds quick ish