[00:30:32] rmoen: it's cached html [00:30:45] best thing to do is to use the tool in dev-scripts/cachedpage.sh [00:31:01] or even simple.. take the html in the task [00:31:07] and replace the html of a page for the last modified bar with it [00:39:48] jdlrobson: that's exactly what i did. Copied the html in the task and pasted it in to the last modified bar [00:40:27] "i've tried using the html for the last edited bar locally and experienced no issue. " not sure if you saw that bit. [00:54:43] rmoen: in a mobile screen? [00:56:57] jdlrobson: Now i've reproduced it :) [00:57:01] Ty [01:01:22] jdlrobson: seems its the pre-content being applied to id="mw-mf-last-modified", this is normally on the parent class. Think the class is being applied from cache? [01:01:28] .pre-content [01:06:18] possibly.. i have no idea :) if it's a cache fix we'll need to work out whether that one still needs to be applied too :-s [01:06:32] did you identify which patch introduced it using git bisect ? [10:11:48] hullo [10:35:41] catching up on email before i get back into it tomorrow [14:57:27] phuedx|afk: hey! [14:57:31] phuedx|afk: long time no see [14:57:34] (it feels like) [15:24:12] dbrant: ...and sure enough, that was it. thanks! [15:24:23] mdholloway: np [15:31:14] "and you tap this W seven times" Anyone is laughing :D [15:35:32] niedzielski: thank you. https://gerrit.wikimedia.org/r/#/c/226673 is rebased and should go next /cc:mdholloway [15:38:37] dbrant: i figured checked was the default; i guessed wrong (and wasn't finding a lot of good info on menu item states in the Android docs) [15:41:10] bearND: it's raining page load strategy code! [15:41:55] mdholloway: lol [15:53:29] niedzielski: mdholloway: ok, now the for now final patch [15:53:42] https://gerrit.wikimedia.org/r/#/c/226675/ [15:56:13] bgerstle: Morning! a little confusion with version numbers.. For testing there are 4.1.7.168 beta and 4.1.7.170 alpha [15:56:58] etonkovidova: focus on 168, 170 is just a new alpha for what we've been devleoping in the meantime [15:57:48] niedzielski: are you interested to experience W0 on your device [15:57:53] ? [15:58:10] bgerstle: so when in T106106 there is a reference to Release version: 4.1.7 and Release tag: 4.1.7.168 -- I should use 4.1.7.168 beta-correct? [15:58:38] bearND: is this IP based or device based? i'm hesitant to enable an IP based solution since i want to use android like most folks do [15:59:46] bearND: regarding patch, it looks good to me but sounds like michael has a comment to check up on [16:00:08] etonkovidova: correct [16:00:47] niedzielski: It's IP based. I'm going to hook up mdholloway with it. and Once he's is done I'll turn it off. I'll show him how I do it in the batcave. [16:00:51] bgerstle: thx! [16:01:09] np! [16:01:21] bearND: if it would be easy for me to turn on / off, sign me up! [16:01:42] mdholloway: are you ready for the batcave? [16:01:49] bearND: sure [16:02:01] niedzielski: there is roughly a 15 min. delay to get changes effective [16:02:09] bearND: nice [16:02:39] niedzielski: we're in the cave right now [16:02:45] bearND: oh! omw [16:23:04] bearND: should I create a tracking task in phab for reviewing design of W0 status indicators in the app? [16:23:27] bearND: seems like a fairly distinct issue [16:24:53] mdholloway: sounds good to me [16:25:02] bearND: cool, will do [16:49:13] James_F|Away: do you want to take a look at https://gerrit.wikimedia.org/r/#/c/194945/ / https://phabricator.wikimedia.org/T91752 ? (repost, sorry, wrong channel :)) [17:14:23] mdholloway bearND dbrant: dang, i was looking at our play stats and i was thinking "hm, 7% for < ICS devices. that's not too bad" but then i see that 7% is a million devices [17:17:16] niedzielski: most of that 7% is Gingerbread, which is what baffles me. [17:21:36] dbrant: in the past year we've gone from 1.2 milli to 950k :/ [17:21:54] dbrant: i wonder if the drop off will be more step in the next year [17:25:32] dbrant: another interesting point is that we still have 100k active froyo users. so this would be people who haven't seen an app update in a long time [17:26:15] niedzielski: yes, that's still the old phonegap app [17:26:35] dbrant: and that decline has been pretty slow this past year. 125k to 100k [17:27:35] there's nothing we can do for those users :( [17:46:21] hey FlorianSW bmansurov what exactly needs to be fixed in https://gerrit.wikimedia.org/r/227344 ? [17:49:07] EditorOverlayBase runs postRender of Overlay so invokes the hasFixedHeader code [17:49:30] note hasFixedHeader is whether the overlay and browser support fixed headers, the defaults.fixedHeader option is a request to use a fixed header where possible [17:51:05] jdlrobson: yes, sure, but look at the template used for EditorOverlayBase (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.editor.common/EditorOverlayBase.hogan). The "position-fixed" is hardcoded and not conditionally :) [17:51:24] not true.. [17:51:40] the position-fixed class only works with supports-position-fied [17:51:47] this code is confusing :/ [17:51:59] if you look in the postRender the property has side effects [17:52:02] and these are what are causing the problems [17:52:07] it disables scrolling [17:53:28] so, the header is still fixed in the editor? very confusing... [17:53:56] jdlrobson: your code looks good, i'm just not able to fix because of vagrant [17:53:57] jdlrobson: are you guys talking about https://phabricator.wikimedia.org/T98505 ? [17:54:10] kaity yup [17:54:14] bmansurov: what happened to vagrant? [17:54:33] FlorianSW: yeh all that code is confusing and we should probably revisit it [17:54:40] jdlrobson: cpu is at max, I can't even open a page. I created a task on phab last night, haven't heard back [17:54:47] jdlrobson: I just saw tried to edit on my phone - iphone 4s iOS 8.1 and got the bug [17:54:50] bmansurov: did you upgrade? [17:54:56] if you wana check it on my phone [17:55:06] kaity: i can reproduce. I have a fix for it we're just discussing the fix. [17:55:08] jdlrobson: yes, this is a fresh install, trying to install a local MW [17:55:19] bmansurov: :-/ can you setup a non-vagrant instance? [17:55:26] in theory shouldn't take more than 30 mins [17:55:33] jdlrobson: yep, doing that now [17:55:39] bmansurov: how will you test? [17:55:42] do you have an ios simulator? [17:55:44] yes [17:55:49] xcode has it [17:56:44] FlorianSW or rmoen are welcome to merge if they can test before me [17:56:44] bmansurov, jdlrobson removing my -1, i can't test it and it is confusing, that the header is still fixed :) [17:56:58] unfortunately, not an iOS device :D [17:57:03] oh ok [17:57:15] bmansurov: i can look in a few minutes [17:59:36] we need to catch the cut off [17:59:51] i'm concerned a large amount of ios 8 editors cannot edit because of these bugs [17:59:59] i can't verify though as the graphs are broken on mobile-reportcard [18:01:21] i'm guessing we missed cut off though (i always forget when it is) [18:02:12] kaity can replicate it on beta labs btw [18:06:26] jdlrobson: i can pickup another bug. I think i have resolved https://phabricator.wikimedia.org/T107104 [18:06:58] bmansurov: what patch for review? [18:07:18] rmoen: https://gerrit.wikimedia.org/r/#/c/227344/1 needs testing [18:07:18] oh the saving bit [18:07:45] bmansurov: hmm i think i can test in ios8 [18:07:48] in the simulator [18:08:07] that'd be great, my vagrant isn't working so i cannot test myself [18:25:23] bmansurov: taking me a minute, i have to configure squid to proxy my ipad into my dev env [18:25:35] rmoen: no problem, i was able to test it [18:31:48] jdlrobson: what's the url for the page in the screenshot? https://phabricator.wikimedia.org/T107104 [18:32:43] bmansurov: looking [18:33:02] oh i just merged that. You could replicte via ./dev-scripts/cachedpage.sh 992c7c103a1d7d0d232a325d7115c47baa8afe5a Headings [18:33:33] Bug is no longer present on http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings i think cache got purged for it [18:35:04] dbrant: since i can't seem to find it in the docs, what is the difference between state_pressed and state_checked? [18:35:50] mdholloway: state_pressed is when you're holding it down, whereas state_checked is when it's highlighted regardless of pressing. [18:36:08] jdlrobson: ok np [18:36:19] mdholloway: niedzielski: FYI, the W0 banner on mobile web stays around usually. It only gets dismissed right away if I had it manually dismissed before. Going to a fresh browser or in incognito mode the banner stays. [18:36:52] bearND: but does it overstay its stay? [18:36:58] good to know! thanks! [18:37:29] dbrant: ok, thanks [18:37:59] niedzielski: leading by example while exhorting you to overstay your stay? [18:38:39] it's got real staying power [18:38:49] :) [18:44:56] kaity: may be worth weighing in on https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Suggestions_for_banners_on_small_screens ? [19:10:32] dbrant: did the ripple effect look ok when you looked at the navigationview patch or did you not test that piece? [19:11:02] dbrant: i'm debating whether i should run to best buy to buy a new lollipop device while the nexus 9 is out for repairs [19:11:35] dbrant: not having a real one makes it difficult to do material design-oriented development [19:11:52] dbrant: and frankly i am not optimistic about the prospects for repairing the damaged tablet [19:12:17] mdholloway: it looks correct with the changes i proposed [19:12:49] dbrant: cool. i addressed all of your comments and it's looking good on my end; i'll have another look at stephen's from last patch set and then push for review [19:13:28] mdholloway: genymotion has been fine for me (i don't have a lollipop device)... but I do have several physical devices with API 19 and 18. [19:17:00] dbrant: hmm, so you can see the ripple effect on genymotion, then. i'll look again. [19:17:26] mdholloway: fo sho' [19:52:33] ah, i'm seeing the ripple effect now. i just need a heavier touch. [19:59:05] bearND: please take me off W0 testing at your convenience :) [20:00:44] mdholloway: done. Should be effective in ~15 min. [20:01:00] bearND: thanks! [20:22:28] @android app team: If I move the app to the sd card (using the option in system settings), does this work for saved pages, too? There is a user in OTRS complaining, that the settings affects only the cache, but not saved pages? [20:22:41] bearND, dbrant ^^ [22:08:44] coreyfloyd: are you still around? [22:09:05] kaity: yeah [22:09:20] coreyfloyd: can you chat for a few min? [22:09:38] kaity: yeah - can you give me 5? on another hangout [22:10:01] coreyfloyd: sure, thanks! [22:28:27] coreyfloyd: let me know when youre free [22:29:01] kaity: sorry… running long - will ping you in a few [22:29:35] ok cool [23:18:35] rmoen: there is an issue with your script [23:18:45] jdlrobson: ok [23:18:49] :( [23:19:01] rmoen: basically the git review will not work until the public key has been setup [23:19:11] but i can't get the public key to put in https://gerrit.wikimedia.org/r/login/settings/ssh-keys [23:20:36] rmoen: they key also gets generated for frankiebotlocal rather than frankiebot which is the gerrit account :/ [23:20:39] jdlrobson: wait what? you mean the ssh key has to be setup in gerrit before running the git-review command? [23:20:58] rmoen: yup cos git review requires authentication [23:21:05] jdlrobson: keys are not specific to the username in gerrit [23:21:20] wait, what i mean is [23:21:51] you can have the key associated with the gerrit account on another linux system with a different username [23:21:52] i'm not sure what happened but my mf-browser-tests.wmflabs.org labs instance completely broke so MobileFrontend has no browser test coverage currently from Frankiebot [23:21:59] so good opportunity to start from scratch again [23:22:53] I see. I will setup a test instance [23:23:14] from scratch. I could use something else to work on [23:24:48] https://www.irccloud.com/pastebin/6SdyNqCQ/ [23:24:52] ^ rmoen [23:26:26] i manually copied the public key from frankiebotlocal and ran again [23:26:28] and it seems to work [23:27:42] ahoy quiddity! What's the best IRC channel in which to find community liasons? cep? [23:30:10] kristenlans, aloha! we're planning on closing that channel soon, because nobody ever uses it, and we already have too many communication vectors. The best way to reach all of us, is the mailing list (cep @ lists.wikimedia.org). The best way to reach selected individuals, depends on the question-topic :> [23:30:40] (and depends on the timezone) [23:31:02] quiddity ah OK. I'm trying to figure out if this team health check is going down tomorrow or not, mainly need to find Rachel. [23:31:41] kristenlans, it is, at the slightly ungodly hour of 7:30am. But Rachel is on vacation till Friday. [23:32:21] (7:30am pacific that is. I grok it is a better time for most of the rest of the team.. >.> ) [23:33:12] RSA host key for IP address '208.80.154.81' not in list of known hosts. Permission denied (publickey). < rmoen :/ [23:35:15] Quiddity OK, I was not aware that Rachel was on vacation. There's an option to move it to the slightly more godly hour of 8:30 PT early next week. Does that sound like a better option to you? [23:35:44] rmoen: git review seems to be using barry username for some reason rather than frankiebot [23:35:46] jdlrobson: is it complaining about the entry in known_hosts ? [23:36:11] jdlrobson: hmm [23:36:30] what is in run.sh for username / [23:36:31] ? [23:38:41] kristenlans, next wednesday? then it would interfere with moushira's attendance of the Q2 planning meeting. I'm ok with doing it tomorrow. Grumbling about mornings is just instinctual ;-) [23:40:45] quiddity OK probably best to keep it scheduled for tomorrow this late in the game. Your grumblings were heard and there was an attempt to address them, but I think the scheduling tide is against you :-) [23:40:59] ty! [23:44:40] rmoen username doesn't currently get passed on git review -d [23:44:54] i'm not sure wtf is going on though ... ~/.ssh/config tells it to use frankiebot [23:47:06] jdlrobson: not sure, i'll keep looking [23:48:10] jdlrobson: did you restart your instance and install with the script and then had these issues? or did all of the sudden the one we setup stopped working ? [23:48:58] Not sure what happened but git/config had barry's username in it [23:49:18] it could just be an unclean instance [23:49:43] but it might be worth re-running the setup script as someone other than barry username [23:51:04] agreed [23:52:00] mm i don't have permission to bundle install either [23:58:29] errg also wtf The program 'arc' is currently not installed. To run 'arc' please ask your administrator to install the package 'arc' [23:58:38] i think i'm gonna tear this down and we can start again