[00:01:40] jdlrobson: are you sure you're running this on the instance ? [00:01:40] mm i can't seem to delete or add instances on https://wikitech.wikimedia.org/wiki/Nova_Resource:Mf-browser-tests.mobile-smoketests.eqiad.wmflabs [00:01:57] You're an admin on reading-smoketest project [00:02:17] and most likely mobile-smoketests [00:02:50] jdlrobson: i have to step away but i'll be back later tonight to look at this [00:03:13] yeh let's move it back to -1 and give it another install tomorrow [00:03:18] ok [08:00:48] morning! [15:38:30] hey joakino [16:11:49] hi phuedx! [16:16:36] hola phuedx, glad you're back. [16:32:41] phuedx: joakino: meeting? [16:32:44] phuedx: want to join our pairing is caring hangout ? [16:55:15] gah, sorry i missed the invites folks [17:02:49] joakino: ? [17:16:39] mdholloway|afk: coreyfloyd standup [17:17:40] hey joakino [17:18:37] sup jdlrobson [17:18:42] sooooo [17:18:46] want to look at the dashboard stuff [17:18:57] i didnt know that jonkatz had created one [17:19:59] i guess it's a question of do we prefer the screen without toggle controls or not? [17:20:46] it's interesting that first paint is lower for logged in users... [17:21:50] yerp [17:21:54] is that just because of sheer numbers involved? [17:21:58] want to hangout? [17:23:05] jdlrobson: ^ [17:23:30] joakino: sre [17:23:36] to the... [17:23:40] "tracy island?" [17:24:14] jdlrobson: i still have to read that email haha [17:24:25] just skimmed it [17:24:31] the heman one sounded cool [17:28:36] etonkovidova: so you noticed the face detection problem? [17:28:55] did you file an issue for it or ping any of us? [17:38:10] bgerstle: https://phabricator.wikimedia.org/T107110-[4.1.7.170 alpha] Regression: lead images not positioned correctly [17:38:20] bgerstle: or it's something else? [17:38:26] etonkovidova: ah, i didn't know about that ticket [17:38:42] etonkovidova: i should've been clearer that any potential blockers should have been raised ASAP [17:38:56] bgerstle: which brings me to another problem :) - does anyone triage my bugs? [17:39:05] etonkovidova: not as timely as we should be [17:39:17] bgerstle: sigh... [17:39:26] signal-to-noise ratio means we often don't respond to phab notifications [17:39:46] i don't know how often coreyfloyd sweeps the "needs triage" column, but PM is a full-time job [17:40:10] etonkovidova: i think you should assume that we don't look very often, and any high priority things, especially during release, should be mentioned during standup or on IRC [17:40:32] bgerstle: I was not sure about the priority about this one -- seems that it's only on 4.1.7.170 alpha [17:40:48] etonkovidova: ah right [17:40:56] etonkovidova: it's on 4.1.7.168 too (the release candidate) [17:40:58] bgerstle: and you said that I should concentrate on 168 :) [17:41:02] etonkovidova: yeah [17:41:07] bgerstle: hmm... [17:41:46] etonkovidova: so when you tested 168 you didn't see it? [17:42:29] bgerstle: not for Obama article and no regression for my usual set of mis-positioned lead images [17:42:53] etonkovidova: were you testing on a clean install? [17:43:48] bgerstle: just update from TestFlight Should I always use clean? [17:44:01] etonkovidova: ideally, we need both [17:44:16] bgerstle: agree... [17:44:24] etonkovidova: but the clean install can be left for more rigorous regression testing [17:44:31] etonkovidova: so you did the right thing [17:44:47] etonkovidova: i'm going to add regression test cases for this if there aren't any [17:56:36] bgerstle: coreyfloyd mhurd dr0ptp4kt kristenlans see you in a few min for thc :) [18:05:50] mhurd: https://docs.google.com/a/wikimedia.org/document/d/1p4FyQg4VepXZ50rsTM-3iXCW-gTIf4Rkz-_qHoF_Y5M/edit?usp=sharing [18:06:14] mhurd: https://docs.google.com/spreadsheets/d/1w68UX3VgZm_vKsYUNdB7AygumVoi84jGntc2DzHyE8Q/edit?usp=sharing [18:46:23] joakino: not sure if this was the bug you meant : https://phabricator.wikimedia.org/T107331 [18:47:44] jdlrobson: is that one new? [18:47:53] that's what i was saying [18:58:29] yeh i just made it off back of your mail [18:58:40] the screenshots you gave were confusing [19:02:32] * jdlrobson off for lunch see ya in a bit [19:14:05] bmansurov: I just added you to the reading-web-staging project [19:15:27] bd808: thanks [19:22:20] jdlrobson: ok so browsertestbot is running smoke tests on MF. :) I figured out the issues with the script and the missing documentation [19:22:25] going to let this run and goto lunch [19:23:06] dr0ptp4kt: do you have a sense of whether the Reading mgmt mtgis happening today? [19:25:59] also a heads up, i might be returning a little later than normal, riding my bike to meet a friend in town for lunch. be back as soon as possible. [19:27:47] kristenlans: i'd say let's cancel it this time. what do you think? vibha and bd808 that ok with you? or does anyone have topics they'd like to cover? [19:29:58] dr0ptp4kt: my only topic would be strategy check-in to see if anyone has any questions or concerns; personally I feel that the schedule is under control and near term next steps are clear. [19:33:26] kristenlans: i think i'm good on that point. how about we provide an email status update to the normal attendees and ask them to review the existing webpage? [19:33:49] dr0ptp4kt: that sounds good, link to the phab trackign ticket would be rad [19:34:06] kristenlans: ok. shall i compose the email? [19:34:14] kristenlans: or you? [19:34:22] dr0ptp4kt: if you have some bandwidth that woudl be radical [19:34:30] kristenlans: will do [19:34:51] * kristenlans gives dr0ptp4kt the gnarly surfer hang loose hand signal [19:35:22] kristenlans: cowabunga [19:36:23] ^ vibha bd808 i'm going to cancel the mgr meeting for today [19:42:26] dbrant: (moving to correct channel) hey! just saw your morelike mail. is that something that should also be sent to the disco dept? [19:43:15] and the columns are number of clicks for approximately equal division of search types? [19:44:57] rmoen|unch: sweet. do you want me to go through the install process one last time for good luck? [20:01:59] niedzielski: done, and yes. [20:02:11] dbrant: cool, thanks [20:28:19] vibha: hey! are you around? [20:44:05] bgerstle: Is the migration complete? [20:44:09] To GitHub for ios/wikipedia? [20:44:25] I see the gerrit ACL still has most (if not all) rights enabled as before [20:45:48] There's also a .gitreview file in the repo [20:48:59] Krinkle yep [20:49:13] bgerstle: Hm.. so you want to sync to Gerrit? [20:50:09] Krinkle: we planned to manually [20:50:12] OK [20:50:20] bgerstle: Right. Push but not Submit. [20:50:21] Cool [20:50:25] What about l10nbot [20:50:34] Krinkle: that's the idea, anyway, not sure if that was what i accomplished [20:50:54] Krinkle: we've been having bearND submit localizaiton patches and reviewing them manualy [20:51:03] so i don't think i10nbot has been working w/ us [20:51:11] Right, so it doesn't need exclusive submit access [20:51:18] we have a eng backlog ticket to revisit how we do localization [20:51:32] automating it might be part of that [20:53:17] bgerstle: you could have the l10n-bot automation if you wanted to. It would mean though that those changes automatically get merged (at least that was the behavior with Gerrit, I assume it's the same for GH) [20:53:33] jdlrobson: there is an issue with bundle install. Working on that [20:54:00] bearND: yeah, might not mind having it push directly to the repo [20:54:02] or to a branch [20:54:07] rmoen: only thing that is not working for me is language setup [20:54:08] and we can manually create pull-requests for review [20:55:45] bgerstle: OK. I've simplified it a bit. [20:55:49] https://gerrit.wikimedia.org/r/#/c/215074/ is a good example [20:56:01] Jenkins can't vote. [20:56:06] and nobody can CR2 or submit [20:56:22] Krinkle: awesome, thanks! [20:56:34] https://gerrit.wikimedia.org/r/#/admin/projects/apps/ios/wikipedia,access [20:56:36] yw :) [20:56:46] Krinkle: would you be so (very) kind as to write a quick Markdown blurb on this? [20:56:56] just so we have knowledge of how our gerrit repo is configured in the repo? [20:57:34] and i can link to it from the README [20:57:42] Hm.. not sure what you mean. [20:57:56] we have a "docs" folder https://github.com/wikimedia/wikipedia-ios/tree/master/docs [20:58:07] where supplemental stuff goes that doesn't belong directly in the README [20:58:11] or potentially on a wiki [20:58:41] i just know i'll forget how this should be configured or why it was configured a certain way [20:59:03] Krinkle: there's also https://office.wikimedia.org/wiki/Engineering/Mobile [20:59:24] we can create a "gerrit" page there, but that's mostly for things that should be kept private [21:01:36] bgerstle: Maybe you can write it and I'll review? Or ask me on IRC specifically and write based on that [21:02:04] Basically, I removed everthing except refs/* because the rest wouldbe redundant (refs/heads/* and refs/tags/* inherits from refs/*) [21:02:07] Krinkle: sure, i'll give it a go [21:02:13] ok [21:02:29] thanks, i'll ping you to review the pull request ;-) [21:02:34] Then I made Submit exclusive with no entries [21:02:54] Which overwrites any inherited Submit rights from apps/ or apps/ios/ [21:03:16] And then grant an exclusive push for your user group [21:03:30] The CR and Verified exclusive aren't really needed, but just avoids UI clutter. [21:03:51] Let me know if this works, too. I haven't used it like this before [21:04:05] Eg. you can still git push gerrit origin/master:master [21:04:06] Krinkle: i'll ping you if it comes up (i don't expect it will) [21:04:15] ah right, i guess next time we try to sync [21:04:27] Also try a tag [21:04:30] yeah [21:04:37] will be doing that soon, unfortunately [21:04:46] That should be allowed without issue but if it somehow gets blocked we'll need to add back the exclusive allow for push tag [21:04:49] need to hot-fix a release (before it went to app store, fortunately) [21:04:51] but I think Owner provides that [21:04:57] OK :) [21:04:57] ok [21:05:05] https://gerrit.wikimedia.org/r/#/admin/projects/apps/ios/wikipedia,access only contains 4 rules now [21:05:31] ok [21:05:37] Owner is non-exclusive so that gerrit admins can modify it without having to add themselves to the apps-ios-wikipedia gruop [21:06:22] ok... [21:06:45] e.g. me :D [21:07:07] gotchya [21:08:15] jdlrobson: language setup also ;) Bundle install fails after a few successful patch sets. [21:10:48] jdlrobson: The site module (Common.js/css .js/css) in core is changing. It will no longer have a cache fragmentation group, but instead ride the bottom queue like other modules. This should be live in beta in a minute. Let me know if this causes issues in Mobile, which extends the module as MobileSite [21:11:05] w00t [21:11:16] yeh sure ping me when you need me to check [21:11:37] rmoen: pasting isn't working either.. :( [21:11:38] It's live now. [21:11:42] But existing pages are cached [21:11:58] but if you ?bust it, you'll see load( .... , "site", .... ); [21:12:00] on beta [21:14:01] Krinkle: not seeing anything suspect [21:22:47] jdlrobson: k working on it. As you can see it was working when the tests pass. on https://gerrit.wikimedia.org/r/#/c/227698/, https://gerrit.wikimedia.org/r/#/c/227759/ and https://gerrit.wikimedia.org/r/#/c/227748/ [21:59:25] dbrant: design review today is going to focus on iOS navigation. Wanna be a part of that, or bow out today? [22:00:34] mbinder: hmm.... i might join as an observer. i'd like to see what the goings-on are. [22:00:45] cool [22:04:04] what is frankiebot? [22:04:10] and why is rmoen browsertestbot? [22:06:08] coreyfloyd: you around for design review? [22:06:19] Krenair: frankiebot is the bot that jdlrobson setup to run browser tests on mobilefrontend. browsertestbot is the account i'm using to automate the bot setupi [22:21:45] bearND: just a heads up, this design review meeting is iOS-focused today. You're, of course, welcome to stay, but just wanted to give a heads up in case you wanted to bow out. [22:21:59] mbinder: just noticed that. Thanks [22:22:17] bearND: (sorry for the short notice, found out myself a few min prior) [22:22:34] mbinder: no worries [22:24:17] as long as design doesn't want the Android app to have disclosure arrows I'm fine [22:30:35] bearND: disclosure arrows? [22:31:07] mdholloway: nm, it's an iOS thing [22:31:15] bearND: ah