[15:01:56] jdlrobson: joakino we have THC [15:03:37] jdlrobson: joakino THC=team health check [15:04:44] ^ lol [15:06:05] JOAKINO JDLROBSON [15:07:32] kristenlans: i'm coming [15:07:32] 1m [15:20:39] dbrant: if the NavigationView patch is close to getting merged I'll wait and rebase over it, otherwise I'll make this depend on that patch. Doesn't make sense wiring it up on current master [15:21:45] dbrant: Also, what server are we testing EL on these days? [15:22:24] niedzielski: ^ I think you've done some EL patches recently and may know this [15:23:09] mdholloway: just a sec. my ssh config has all the answers [15:23:15] mdholloway: yep, i think making it depend on the NavigationView patch is the way to go. [15:23:52] mdholloway: deployment-eventlogging02.eqiad.wmflabs [15:24:03] niedzielski: thx [15:24:21] and then just tail -f /var/log/eventlogging/all-events.log [16:52:30] dbrant|brb bearND mdholloway|brb: would you mind if we didn't catch json parsing exceptions for the tab storage? this way if there is a real issue, we can see it in beta [17:03:17] niedzielski: I guess it be ok with it, assuming we'll take at least a week after beta before we publish prod, now that dbrant|brb wants to promote tabs to prod as well. [17:03:17] ah bmansurov joakino jdlrobson rmoen am I in the wrong hangout? [17:03:25] kristenlans: seems it. [17:03:26] kristenlans: probably [17:03:27] kristenlans: definitely [17:19:49] etonkovi_: hi elena! can you let me know when you're in the office? [17:20:39] bgerstle: I am in a meeting - will be free, say, 11:30 :( [17:20:52] bgerstle: what's up? [17:21:08] etonkovi_: we have a new build for the 4.1.7 release that fixes face detection regression [17:21:46] etonkovi_: would like to know your availability to QA this new build and whether the iOS QA column has been reviewed [17:21:55] if you're not available we'll take care of it [17:21:56] bgerstle: yes, I saw that there is another build [17:22:41] bgerstle: I will have time today in early afternoon - no worries [17:23:51] etonkovi_: ok, thanks! ping me when you're available and we can sync the board and clear up any ambiguities [17:34:45] mdholloway|lunch bearND dbrant: so apparently you can use camelCase completion in for the gradle tasks... i've got a pretty dirty couple words now that does a clean build [18:36:41] bgerstle_munch: I've started checking 4.1.7(171) :( [18:36:49] bgerstle_munch: I meant :) [18:42:01] etonkovi_: ok thanks [19:29:57] mdholloway bearND: would you devs mind reviewing these two patches from dbrant when you can? https://gerrit.wikimedia.org/r/#/c/228043/ and https://gerrit.wikimedia.org/r/#/c/228037/ [19:30:15] i *think* this is all we know we're waiting on for beta. i've started testing [19:31:06] i think that's accurate. i'm testing, as well... [19:31:09] niedzielski: sure, i'll look shortly. [19:33:27] thanks! [19:44:26] coreyfloyd: I can do pngs or pdfs [19:44:30] which do you prefer? [19:55:16] kaity: hey [19:55:21] um pdfs are fine [19:55:42] kaity: i just sent one more email… i don't think it was clear in the instructions… but they need to be in half sizes [19:56:04] coreyfloyd: ok so I need to send 25x25s [19:56:09] yeah [19:56:11] sorry [19:56:30] kaity: whether you want to send me PNGs or PDFs is up to you. If you send PDFs, then the OS will scale them using its own algorithm, so you lose control of what the final product looks like. [19:56:41] but its is easier most of the time and fine [19:56:57] if you have anything detailed that you want to raster out for complete control then you can send PNGs [19:56:58] coreyfloyd: ok, that sounds good [19:57:17] but note that when you do that we will need to get several sizes from you for each image [19:57:19] kaity: ^ [20:39:01] dbrant mdholloway bearND: things are looking good so far to me [20:40:17] niedzielski: mdholloway dbrant Good. When you test please test a release build type: either betaRelease or prodRelease. Testing on 2.3 is preferred as well. [20:41:11] bearND: i've been using a devRelease build and have tested on 2.3. i'll flip to betaRelease [20:41:42] thank you [20:45:05] niedzielski: bearND: dbrant: it would be nice if, when the second-to-last tab was closed, the only remaining tab would automatically come to the foreground rather than have to be explicitly selected [20:47:01] mdholloway: hm, i'm not sure how that would feel without trying it. in tab overview mode i feel like a tab commander and may choose to open a new tab after closing the second to last tab. i do wonder if we should have the concept of "empty tabs". it feels kind of silly when i open up multiple main apges [20:48:26] niedzielski: hmm, good point. [20:50:45] mdholloway: niedzielski: dbrant: I could probably go for it but I think there's no rush for that. BTW, I've submitted a new task: https://phabricator.wikimedia.org/T107487 what do you think of that? [20:50:50] mdholloway bearND dbrant: do we want to try to squeeze some of michael's patches. it looks like they're firming up [20:51:07] bearND: definitely +1 for that [20:52:03] niedzielski: mdholloway dbrant : looking at some of mdholloway's patches [20:52:06] bearND: agreed [20:54:30] bearND: actually the solution to https://phabricator.wikimedia.org/T107487 might be pretty simple, and would kill another bird... give me a few minutes [20:54:50] bearND mdholloway dbrant: nuts, it looks like tapping the featured widget shows an empty page :| [20:54:56] dbrant: :D [20:55:25] niedzielski: good find. That's a blocker [20:55:53] bearND: i'll look into it as soon as i fill out an unrelated bug report [20:57:43] niedzielski: thank you [20:58:28] niedzielski: i'm liking your empty tab idea more the longer i think about it. [20:59:10] mdholloway: i was thinking something along the lines of what we have for empty saved pages. maybe light grey W or something [20:59:26] niedzielski: would it confuse people? that would be my only concern. [21:00:07] mdholloway: maybe we have text there begging people to search for something? [21:00:42] niedzielski: yeah, that would help [21:02:05] niedzielski: the widget bug is due to line 410 in https://gerrit.wikimedia.org/r/#/c/227633/5/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java [21:06:49] bearND: dbrant: niedzielski: looks like our first paragraph JS transform isn't working correctly on today's featured page. [21:06:55] niedzielski: mdholloway : I thought when the list of tabs ie empty we close the app. What's wrong with that? [21:07:35] bearND: i think what niedzielski had in mind is that when a new tab is created with the + button, it would be an empty tab rather than the main page. [21:07:36] bearND mdholloway: regarding the current build or empty tab discussions? [21:08:03] mdholloway: on today's enwiki featured page, that is... [21:08:13] bearND mdholloway: i actually would like to keep the app open if you press the tab dismiss button (not the back button) [21:08:32] mdholloway: ah, i see. I thought niedzielski talked about what happens when the last tab is closed [21:11:32] not sure about the empty tab thing yet. It might grow on me when I think more about it but I think that should be after this release round [21:11:41] having the last remaining tab in overview mode not automatically come into focus was striking me as odd while testing dbrant's patches. i'm not sure how i feel either way about what should happen when the last tab is closed. [21:13:33] mdholloway: what's wrong with the featured page? [21:13:52] dbrant: infobox on top, not first para [21:14:08] dbrant: actual edit button, then infobox, then first para [21:14:12] *actually [21:14:15] bgerstle: 4.1.7.171 looks good as far as I can see [21:14:25] etonkovidova: awesome, thanks! [21:14:51] etonkovidova: any chance we could shuffle some cards on the board? https://phabricator.wikimedia.org/tag/wikipedia-ios-app-development/board/ [21:15:00] probably into "needs reviewed by apple" if you're done [21:15:39] mdholloway: try now [21:15:48] bgerstle: yes, will do. redis is down, so I have time for some nice tasks :) [21:15:51] dbrant: better [21:15:56] ;-) [21:16:23] dbrant: what was the issue? bad edit? [21:16:28] mdholloway: yep [21:17:05] mdholloway: extra
tag at the beginning [21:17:30] it's supposed to be wikitext anyways [21:17:57] mdholloway: the featured page is often a target of vandalism and first-time edits. Feel free to dig in and undo those edits when you see them. [21:18:12] dbrant: makes sense. will do. [21:19:00] dbrant: mdholloway niedzielski : are you cool with me merging https://gerrit.wikimedia.org/r/#/c/226721/? [21:19:14] bearND: +1 [21:19:59] rmoen: let us know how you get on with https://phabricator.wikimedia.org/T104559 [21:20:09] rmoen: i'm just running through another install of barry [21:20:16] bearND: yep! [21:20:46] jdlrobson: ok [21:20:49] sounds goo [21:20:51] bmansuro_: have you got bandwidth to look at the sample articles task? [21:20:56] some new eyes might help [21:21:11] when i'm done with test driving rmoen 's patch i'll take a look at the perf card again [21:21:18] ok [21:22:15] bearND: ohhhh, why not! [21:22:23] rmoen: really hope this works seamlessly.. fingers crossed! [21:22:36] jdlrobson: it worked for me yesterday so hopefully it does :) [21:22:57] mdholloway: dbrant niedzielski : done [21:24:48] bearND: awesome [21:25:24] bearND dbrant mdholloway: fix is up https://gerrit.wikimedia.org/r/#/c/228149/ [21:35:33] bmansuro_: bueller! :) [21:35:42] or has bmansuro_ finished for the day? [21:35:51] jdlrobson: not yet [21:35:59] jdlrobson: i'm looking into the articles task [21:36:06] sweet thanks bmansuro_ [21:36:11] np [21:38:50] rmoen: `Don't run Bundler as root. Bundler can ask for sudo if it is needed, and installing your bundle as root will break this application for all non-root users on this machine` < i'm not hopeful.. :-S [21:40:19] jdlrobson: this says this because it detects that the user is sudo when running install.sh as root. This should probably be removed, but doesn't actually break anything as bundle install runs for the user in run.sh with --path configured which downloads gems to ~/.gem [21:40:36] ok fingers crossed! [21:40:39] i'm running him [21:40:52] run.sh does a bundle install that works and once you flag with --path it remembers to put them there for that user going forward [21:41:16] i tried to get this going before but there was an actual upstream bug for this that was thankfully fixed :) [21:41:35] rmoen i think it is frozen.. :( [21:41:43] oh no.. it's bundle installing! [21:41:46] it's alive!!! [21:41:52] ... have some faith plz [21:44:07] jdlrobson: my fingers are crossed for a paste :) [21:44:48] rmoen: bad news :( [21:45:01] * rmoen shoots self in foot [21:45:02] it ran through the process but for some reason it hasn't reviewed it [21:45:27] oh wait.. [21:45:43] i think it reviewed https://gerrit.wikimedia.org/r/#/c/228082/ < so the review happened [21:45:46] but on the wrong thing [21:45:55] * rmoen has the popcorn out [21:46:09] so wait, what is happening? [21:46:30] i'm trying to work out [21:46:34] so it told me it was reviewing "Testing Move ImageGalleryNew to stable..." [21:47:08] i see what failed [21:47:11] `cd /vagrant/mediawiki/extensions/MobileFrontend/ && git stash && git checkout master && git review -d 223039` [21:47:17] We don't know where your gerrit is. Please manually create a remote named "gerrit" and try again. [21:47:40] so the gerrit username is not setup apart from that it all worked [21:47:45] so it should be running git-review in the project directory which should setup up gerrit [21:47:49] basically what happened is it failed on that step so reviewed the current patch on master [21:47:57] now if i do `cd /vagrant/mediawiki/extensions/MobileFrontend/ && git stash && git checkout master && git review -d 223039` manually [21:48:00] and enter frankiebot [21:48:02] all is good [21:48:45] so it's basically all working seamlessly apart from that [21:49:56] this is strange because before this happens there should already be a record in ~/.gitreview for user.name and gitreview.name [21:50:15] the run.sh script does this before starting up barry [21:51:21] https://github.com/rmoen/Barry-the-Browser-Test-Bot-Installer/blob/master/install.sh#L156 < is that running under root account? [21:51:35] install.sh is [21:51:39] run.sh should be run as the user [21:51:57] perhaps this is worth noting [21:51:59] in the docs [21:52:15] jdlrobson: did you sudo su barry? [21:52:21] err frankie [21:52:25] sudo su frankiebotlocal [21:52:27] yeh [21:52:48] I'm going to set up another instance [21:52:52] with the manual step - https://gerrit.wikimedia.org/r/#/c/223039/ worked fine [21:53:04] i don't think you need to setup another instance, let's just work out why this went wrong [21:53:08] jdlrobson: i wonder about paste [21:53:25] rmoen: git config --global user.name yields nothing for frankiebotlocal [21:54:10] jdlrobson: doh [21:54:14] forgot --add [21:54:16] :/ [21:55:22] `git config --global user.name frankiebot` should add the username [21:55:26] no need for --add [21:55:41] oh? [21:57:07] jdlrobson: it makes no sense then because in the run.sh it is setting the user.name [21:57:16] in this way [21:58:32] it doesn't get passed to git review [21:58:39] the script assumes you are setup locally with git review [22:00:39] jdlrobson: i dont understand its also doing this for gitreview [22:02:33] i see the problem rmoen [22:02:33] git config --global gitreview.username frankiebot [22:03:07] don't pass --add [22:03:07] don't pass --add parameter [22:03:20] ok [22:04:40] jdlrobson: removed [22:04:41] seems to work for me [22:04:56] --add was causing it to not add ? [22:05:31] it seems so [22:05:55] strange because --add is totally valid afaik [22:08:00] jdlrobson: i'm testing this out again [22:08:26] also the staging instance instructions [22:09:43] rmoen: yeh i don't get it `git config --global --add gitreview.username jdlrobson` should work [22:09:48] no idea why it isn't [22:11:03] rmoen: anyway don't tear your hair out i think it's seamless enough. I think just adding a step to check it setup correctly is a good idea [22:11:14] e.g. Go to /vagrant/mediawiki/extensions/MobileFrontend and run git review [22:11:15] ok [22:11:26] enter username if prompted [22:11:30] if not you are good to go [22:11:36] yeah, i agree [22:12:17] I must have added the --add by mistake and thats why it stopped working. thanks jdlrobson [22:31:30] bearND dbrant mdholloway: i think we should have called this sprint "tabula" (like dracula but with tabs instead of fangs?) [22:31:55] not bad! [22:31:57] niedzielski: lol. good one. I like it [22:32:19] and the next one will be tabula rasa. [22:32:42] nice. And, dbrant, I was just thinking that [22:36:03] the one useful thing i neglected to retrieve from the other laptop's HD is my ssh config file. niedzielski, did the logging itself look fine when you were looking at my EL patch earlier? i've got my new ssh key swapped in but still not having much luck getting access to deployment-eventlogging02.eqiad.wmflabs. [22:37:09] mdholloway: i spot checked the event selection types and they looked good. i will do full confirmation now and email you a copy of my ssh config later. [22:37:41] niedzielski: cool, thanks so much. why don't i push a new patchset now so you can try the latest. [22:37:47] niedzielski: i updated based on your comments. [22:37:52] mdholloway: np, that'd be gr8 [22:41:00] niedzielski: was it not working when extending TimedFunnel? I can switch it to extend vanilla Funnel for now and then figure out the time aspect when I'm back into the EL server... [22:41:26] mdholloway: it wasn't working with TimedFunnel because the schema didn't have any timing parameters IIRC [22:42:01] mdholloway: i'm not sure what the requirements are, but i can wait a bit to test with timing if you like [22:42:33] niedzielski: You're right, I was confusing it with a different schema I was looking at for reference. [22:42:39] niedzielski: Easy enough! [22:43:27] niedzielski: I'll keep it at SAMPLE_LOG_ALL now and then adjust the sample rate when it's otherwise ready to go [22:43:44] mdholloway: up to you. easy for me to change on my end [22:43:53] mdholloway: plus dev builds always log [22:45:03] niedzielski: oh, that's right. [22:47:46] bearND: mdholloway: niedzielski: i've g2g for the day :( let's regroup tomorrow, and try to push a beta by EOD? [22:48:21] dbrant: bearND: niedzielski: sounds good, let's do it! [22:48:29] i'm about to head off myself [22:48:42] dbrant bearND mdholloway: works 4 me. i'm putting together the release notes now [22:50:38] coreyfloyd: hey you around? [22:58:55] bmansuro_: are you looking in beta? [22:59:00] jdlrobson: yes [22:59:05] dbrant|bbl: mdholloway niedzielski : I'm hoping for beta in the AM, at least to be pushed as a draft, pending testing [22:59:49] bearND: niedzielski: dbrant|bbl: cool. I just +2'd that last patch a few minutes ago (missed niedzielski's comments earlier) [22:59:53] bearND mdholloway dbrant|bbl: it looks like the last patch merged. i can do the builds once i finish testing michael's el stuff [23:00:04] bmansuro_: can you take a screenshot, it's working fine for me [23:00:11] jdlrobson: ok [23:00:17] niedzielski: mind testing https://gerrit.wikimedia.org/r/#/c/227068/? Would be nice to get that one in as well. [23:00:45] bearND: yeah i can hit that up next [23:01:15] niedzielski: great. Look at my comments in there. Would be great to get another set of eyes on this. [23:01:31] jdlrobson: http://i.imgur.com/HNFS9FF.png [23:01:33] bearND: sounds good [23:01:47] i have to go now but can look first thing tomorrow if it's still pending [23:03:02] mdholloway: have a nice evening! [23:03:06] jdlrobson: gotta go, will take another look at it tomorrow [23:03:14] thanks, have a good evening, all! [23:03:28] mdholloway: night! [23:14:57] bearND: i've not spent much time in app saving talk pages. are there known issues when refreshing pages? [23:15:47] bearND: when i refresh one or the other it creates duplicates and sometimes destroys the talk or non-talk saved page [23:16:04] niedzielski: with this patch or on master? [23:16:31] bearND: i'm looking at this patch specifically but i didn't know where we were at in robustness on the saved pages in general. i'm switching to master now [23:18:13] niedzielski: On second thought I suspect you'll get the same behavior on master since this patch only affects History [23:18:41] bearND: :| sorry about that [23:28:24] bearND: results are not favorable. i can't seem to actually delete anything on this patch. if i go to main page and tap on Cley Marshes, then back to main page and finally to history. deleting a single entry works on master but not on new patch [23:33:26] bearND: nuts, i just noticed some regression on master. 1) the back button doesn't dismiss the menu. 2) pressing the back button on nearby / history / etc, doesn't update the checked state for the main menu [23:35:19] bearND: correction on #1, i can't seem to repro this now [23:37:38] niedzielski: weird. I'll try that as well shortly. Let's tackle the history patch after this release. I am now seeing some weird behavior with main space articles in History. [23:38:20] bearND: ok cool. i'll into the checked state issue [23:38:46] niedzielski: I'm merging the TWN sync patch [23:38:53] bearND: sounds good [23:40:15] niedzielski: Chrome just drove me nuts when I was looking at the changes. It translated the strings, and showed res/values-en instead of res/values-fr and such. Crazy. Moved to incognito mode and it seems saner now. [23:40:26] I mena the TWN changes [23:40:46] bearND: that's bizarre. i haven't seen that one [23:42:38] niedzielski: Ok, deleted a bunch of extensions seems to have helped [23:43:32] bearND: i'm really excited about the prospect of switching to phabricator differential. i think that'll be a lot of fun to work with based on how nice phabricator bug tracking is [23:48:56] niedzielski: I like the integration aspect, but Phab still has a way to go in other areas, like proj mgmt. I'm still missing the reactivity of Trello. [23:49:46] bearND: trello is pretty outstanding but phab definitely has one of the most pleasing UIs i've seen in an oss project [23:50:06] Not sure when we'll get Differential. Just sad when I go to https://android-review.googlesource.com and then back our Gerrit instance and realize that it hasn't been updated in ages. [23:51:52] niedzielski: If I were my grandmother, I'd wash your mouth out with soap. [23:51:57] Phabricator. Pleasing UI!? [23:52:14] Deskana: lol [23:52:25] Deskana: what kind of standards do you have?? have you seen gerrit?? [23:52:37] Fair point. [23:52:56] Deskana: i'm not saying it can't be improved but it looks reasonably modern [23:53:28] Deskana: and why are we passing the buck to my grandmother? shouldn't my mom be ready with soap? [23:54:07] niedzielski: According to my grandmother she should be, but according to my mum, no. ;-) [23:55:29] Deskana: niedzielski https://en.m.wikipedia.org/wiki/Washing_out_mouth_with_soap [23:57:32] dr0ptp4kt Deskana: i'm glad to see a reference to christmas story in there