[09:03:57] morning [15:07:30] jdlrobson: ping :) [15:34:30] heading out a bit early for appt, will stay later in the eve. see you at standup! [15:40:31] niedzielski: so, what do you say? https://gerrit.wikimedia.org/r/228191 [15:41:35] dbrant: test well :) [15:42:19] dbrant: i don't object to it and think / hope the change works out well for us [16:03:02] phuedx: you joining kickoff today or not yet? [16:15:18] dbrant, niedzielski, bearND Do you, ad hoc, know, why the Cache of the Wikipedia app can't be cleared to 0 Kb? [16:16:14] hey FlorianSW what's up? [16:16:34] FlorianSW: i do not but i don't think that issue is limited to the Wikipedia app [16:17:30] jdlrobson: I thought about the swipe library for the "ImageGallery" functionality. Do you have any specific library in mind? Most of them would require to change our layout, how we load the next and previous image :/ [16:17:51] i don't.. i just don't think we should block on it. [16:17:52] niedzielski: hmm, ok :) There is one user who asked that in a ticket :D [16:17:59] we can always fix our library [16:18:46] FlorianSW: it's a good question. i don't know the answer offhandedly but have seen the issue on unrelated apps [16:19:02] niedzielski: would be interesting :) [16:19:26] FlorianSW: i think if you "clear data" for the app, you'll get down to 0B [16:19:50] jdlrobson: but the structure of other libraries makes sense to create a "smoother" animation (showing the new image, while swiping, instead of swipe and load the next image) :) [16:19:58] niedzielski: testing ;) [16:21:31] niedzielski: hah, that's interesting, now I get 0B when using clear data [17:01:43] niedzielski: in that case, mind merging? https://gerrit.wikimedia.org/r/228191 [17:01:51] ^ cc bearND [17:02:06] dbrant: here comes the merge [17:06:03] niedzielski: dbrant bearND mdholloway|afk name for sprint 63? [17:07:04] mbinder: i got nothing this time around [17:09:05] mbinder: i have nothing more original than to name the sprints according to atomic number. (63 = europium) [17:09:41] +1 [17:12:37] dbrant: coreyfloyd I'd love to chat with you both after standup if you have a moment [17:13:01] sure thing [17:21:09] kaity: kaity|away: can you have a look https://phabricator.wikimedia.org/T107603 ? For design of the surveys on desktop [17:28:45] niedzielski: https://gerrit.wikimedia.org/r/#/c/227771/ needs a rebase; https://gerrit.wikimedia.org/r/#/c/227393/ only needs a minor change to be ready. Do you want to tackle those before the release? [17:30:23] bearND: since are changes have grown a little bit anyway, i wouldn't mind sneaking these in too [17:30:25] just a moment [17:36:50] mbinder: thanks for getting that phab epic together and coordinating this… really awesome [17:37:01] ^ +1 [17:37:55] mdholloway: if you need a workable ssh config, I have one on my goodies page: https://www.mediawiki.org/wiki/User:DBrant_(WMF)/Goodies#.ssh_config [17:38:28] coreyfloyd: dbrant word, hopefully we find out that either we can get an MVP done or move in a direction tools-wise that is actually useful. Defining what that MVP is is the next step. [17:40:03] dbrant: thanks, let me make some changes based on yours and see if that does the trick. i looked at stephen's earlier, too, but no luck... [17:44:37] if you having index problems i feel bad for you, son [17:50:05] mdholloway: manual rebase plz: https://gerrit.wikimedia.org/r/228012 [17:55:29] dbrant: done [18:07:49] dbrant: FYI: https://phabricator.wikimedia.org/T107783 [18:08:09] Deskana: nice! thx [18:09:53] joakino: sure thing [18:10:53] joakino: for next sprint, starting in 2 weeks right? [18:18:20] niedzielski: nope! [18:24:28] dbrant: any issue with me moving the 62 tasks to 63, per our convo this morning? Or do you want to handle it? [18:25:12] mbinder: go for it! [18:26:03] niedzielski: on that CAB patch, I'm not sure what to do about the keyboard shortcuts. I think I'd actually lean toward disabling as well as hiding them for consistency's sake. What about you? /cc dbrant bearND|afk [18:26:47] especially for select all, for which i can't imagine any use in the context of our app [18:27:07] mdholloway: i have mixed feelings :) part of me says, if you know about them and have a keyboard, go for it. the other part says it's asking for problems since it's an unsupported use case [18:27:49] mdholloway bearND|afk dbrant: if you haven't had a chance to look at the beta release notes, please do [18:28:15] niedzielski: will do, thx for the reminder [18:28:27] looking... [18:35:10] brion: ? [19:03:23] niedzielski: release notes look good [19:03:43] dbrant: thanks. some good improvements from team [19:15:59] bearND|afk: dbrant mdholloway: testing looks good to me. any objections to posting the beta? [19:16:29] niedzielski: ship it! [19:17:52] SHIP IT [19:21:31] dbrant bearND mdholloway: nuts, we ran out of room on the release notes. i'm going to trim it down a bit [19:22:06] dbrant bearND mdholloway: if i remove the last bullet that puts us at 500 chars [19:22:47] niedzielski: i'd say remove it [19:25:33] wfm [19:25:56] me too [19:26:56] ship it [19:27:42] will do, thanks [19:27:54] Hi [19:28:15] it seems like there is a regression in the behaviour of random [19:28:35] there used to be a green round loading thing when you clicked random [19:28:58] now it is gone, and there is no feedback for your click, is that by design, or a bug ? [19:31:25] matanya: file it! [19:31:39] thanks dbrant will do [19:37:08] dbrant: https://phabricator.wikimedia.org/T107791 [19:37:16] matanya: thx [19:37:31] :) [19:47:20] etonkovidova: do you happen to know any pages that have funky lead sections? [19:47:50] bgerslte: in what sense - funky? [20:00:02] dbrant: just for background, what was the problem that was solved by stripping the background colors of table elements, rather than inverting them like everything else? [20:01:25] dbrant: (i don't want to reintroduce that problem in my patch) [20:02:24] mdholloway: i really... don't know. i think this was done right around the time i joined. [20:02:54] mdholloway: i'd really like to see what happens if we simply halve the rgb values. [20:03:17] dbrant: cool, i'll give that a whirl [20:03:38] Are you talking about night mode? [20:03:45] Deskana: yep [20:04:04] Wasn't it those tables that have tons of colour in them going all wonky? [20:04:23] "Strip it all and work on something else" sounds like something I'd say ;-) [20:04:42] :) [20:07:10] niedzielski: \o/ [20:07:18] niedzielski: are you building the prod/partner variants? [20:07:32] everything's all ready and uploaded \o/ [20:08:11] well dip me in butter and call me a buiscuit. [20:08:29] dbrant: i can do just one of those things [20:27:37] Deskana: Off the top of your head, do you remember any particular articles where table element background colors in night mode displayed that problem? [20:28:31] mdholloway: I seem to remember articles about military battles as being particularly bad offenders. [20:28:58] mdholloway: Nothing specific, unfortunately. [20:29:46] mdholloway: the colors in your screenshot don't appear to be halved... [20:32:01] dbrant: on second look, you're right. [20:37:09] niedzielski: our first crash from unmarshal(): https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8546773 [20:38:12] dbrant: that's a bummer :( [20:40:38] looks similar to what bearND saw. [21:04:44] dbrant: it's similar but it's not a "JsonSyntaxException" [21:21:17] dbrant: OK, RGB values are actually halved now, not just my eyes playing tricks. if the screenshot looks like what you had in mind, the patch is ready. [21:37:41] jdlrobson: thanks for the tip with the docs :P [21:38:03] FlorianSW: np. Would be great to poke S Page actually to get those documented [21:39:11] i looked in the docs generated by doxygen, but this module is so powerful and has so much options, it's a bit confusing without having examples for a wide range of use cases somewhere bundled :( [21:40:02] setup https://phabricator.wikimedia.org/T107804 [21:40:06] not sure if that will help :) [21:41:02] jdlrobson: great, thanks :) if you don't try, you can't win :P [21:42:50] dbrant mdholloway bearND: what's the reason we keep the javascript files in tabs instead of spaces? gerrit doesn't seem to do too well with it [21:54:09] nick dbrant|bbl [21:54:55] niedzielski: no idea. for me, inertia. :) [21:55:15] niedzielski: probably because they were originally copy-pasted from other projects. when we make changes to them, we've been making sure to use spaces. [21:55:37] dbrant mdholloway bearND: i was wondering if converting them to spaces would be a good idea [21:55:52] dbrant: this is good to know -- i prefer spaces myself [21:56:35] niedzielski: sounds like a good idea to me! [21:59:33] niedzielski: mdholloway: i could go either way... but we definitely shouldn't have any mixed tab/space intented files. [22:00:06] niedzielski: mdholloway: note - MW core and MobileFrontend uses tabs. [22:02:23] dbrant mdholloway bearND: maybe differential will handle tabs more gracefully [22:08:57] dbrant|bbl: niedzielski: still no luck getting on deployment-eventlogging02, btw. something other than my ssh config has to be the problem. [22:09:27] mdholloway: do you need to check something? i can login if you like [22:09:42] niedzielski: nothing at the moment, it's just bugging me. [22:09:46] niedzielski: thanks, though. [22:10:14] mdholloway: when you got a new laptop, did you transfer your public key? [22:10:22] and private key [22:11:16] niedzielski: no, i ended up generating a new keypair and having robh switch out my old public key for the new one [22:12:16] (and doing the same for myself for gerrit) [22:12:58] mdholloway: what's the error you're seeing? [22:13:32] just the standard Permission denied (publickey). [22:14:36] niedzielski: dbrant|bbl mdholloway : I think the tabs in js files are because of https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions#Indenting [22:14:38] mdholloway: you might trying doing an ssh -v eventlogging to make sure the right public key is being used [22:18:10] niedzielski: thanks, gotta run to appointment now, but will talk to you later! [22:18:20] mdholloway: seeya! [22:53:01] bmansurov: rmoen found a bug [22:53:10] gonna need a merge before 5pm if one of you can be on standby [22:53:20] jdlrobson: i'm around [22:53:25] sweet [22:53:30] what's the bug? [22:53:38] firefox - can't search within pages [22:53:57] https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/771/ [22:54:58] what a bummer [22:57:40] https://bugzilla.mozilla.org/show_bug.cgi?id=245859 < doh [22:58:01] but that's a super old bug.. [22:59:30] arggg i see why [23:04:02] coreyfloyd: did you say a 5.0 update was going out today> [23:05:22] marxarelli: https://gerrit.wikimedia.org/r/#/c/229007/ [23:06:42] jdlrobson: https://gerrit.wikimedia.org/r/#/c/227584/ [23:08:12] bmansurov: so basically the form is not in the DOM so cannot be submitted :-S [23:10:39] i see [23:19:22] bmansurov: got it! :) https://gerrit.wikimedia.org/r/#/c/229023/ [23:19:26] with minimum test case \o/ [23:24:36] marxarelli: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/772/testReport/junit/(root)/Manage%20Watchlist/Switching_to_Feed_view/ [23:24:44] rmoen: bmansurov https://gerrit.wikimedia.org/r/#/c/229023/ < testing needed [23:26:35] kaity: i did - but I am a liar… [23:26:38] i am behind [23:26:54] working on some stuff now… but just taking forever [23:27:19] jdlrobson: k looking now [23:27:36] kaity: i'll le you know when we get closer… sorry for the delay [23:30:25] coreyfloyd: no rush! just wondering if I had missed it [23:32:22] jdlrobson: confirmed fix in FF [23:32:48] want to double check on chrome? :) [23:32:53] and then merge :) [23:33:05] done [23:33:41] jdlrobson: tested on chrome as well. All good.. [23:37:14] marxarelli: > /var/lib/gems/2.0.0/gems/bundler-1.10.6/lib/bundler/shared_helpers.rb:78: warning: Insecure world writable dir /vagrant/mediawiki/vendor/bin in PATH, mode 042777