[02:49:34] coreyfloyd: sorry, just saw your irc message. thanks for joining and waiting and joining :) i'm gonna wrap up soon [13:42:38] joakino: yt? [13:45:46] phuedx: i'm about to leave to lunch [13:45:54] is it quick? [13:46:14] joakino: nope [13:46:17] have a good lunch [13:46:20] lol [13:46:29] k i'll ping you later phuedx [13:46:35] later [15:33:15] romen we have a meet [15:34:32] rmoen: we have a meet [16:14:32] dbrant: (correct channel) hey! i had a quick question on some copy for the long press context menu. do you think we should use an ellipsis style to indicate that an action will require further workflow in another screen? for example, tapping "Share page…" would close the current screen and open an activity chooser. it's not something i feel strongly about but i thought it was worthing asking [16:17:02] dbrant: the next question i has was whether the wording in the overflow menu should match that used in the context window [16:19:12] niedzielski: i don't feel strongly either way myself, but probably leaning more against the ellipsis. Because then, it would raise more questions like, should we use an ellipsis with the "More" item? or "Login"? etc... [16:20:41] dbrant: ok, i'll leave it out. i didn't know if it was a good windows-ism to bring over or not [16:22:11] niedzielski: but i do agree with making it consistent with the overflow menu. I think it should be "Save page" in both cases... and I'm not sure whether it should be "Share" or "Share page"... [16:23:52] dbrant: i was struggling with that too. for example, we have "open page" and "open in new tab". if we're being blockheaded consistent, wouldn't it be "open page in current tab" and "open page in new tab"? far too verbose. i think we always want the shortest one that makes sense [16:24:15] in this case i was wondering if "share page" added a little more context that might make folks feel more comfortable [16:27:36] niedzielski: let's go with "Share page" in both cases, and then let Vibha cast the deciding vote at design signoff. [16:27:54] dbrant: will do, thanks [17:04:46] jdlrobson: standup? [17:08:38] bearND: i'm going to +2 this guy if that's cool with you https://gerrit.wikimedia.org/r/#/c/229263/1 [17:08:59] niedzielski: thank you [17:09:54] bearND: er, i was but actually i don't have +2 access on either of my accounts for this repo [17:10:58] i can... [17:11:34] niedzielski: ohh, not good. We should get you and mdholloway access somehow [17:11:54] dbrant: Did you create this repo? [17:12:28] would be good if we gave the same +2 list as for the other android repos [17:12:52] bearND: I think I asked for it to be created... I don't recall setting any permissions on it myself [17:14:15] dbrant: do you remember who you asked or who one would ask nowadays? [17:14:54] bearND: since i just got twn access, do you mind if i try to do a sync now? [17:15:35] niedzielski: wow, congrats! I didn't know. Please go ahead [17:15:47] sync away [17:16:03] bearND: sounds good, thnaks [17:16:12] niedzielski: first you need to run the one time setup piece [17:16:39] niedzielski: let me know if anything is unclear in the doc, and we'll update it [17:16:45] bearND: will do, thanks [17:17:10] bearND: iirc, there was a Wiki page where you sign up your project to receive its own repo, then someone sets it up for you, and you get a notification. [17:17:23] bearND: but that was almost a year ago [17:19:34] fyi joakino new bug - https://phabricator.wikimedia.org/T108204 [17:20:16] niedzielski: can you see if you have access to merge it now? [17:21:37] dbrant: no change :| [17:22:35] jdlrobson, kristenlans, joakino, bmansurov: Sorry guys for missing the meeting this morning. I totally misunderstood the meeting title [17:25:37] thanks jdlrobson, added unbreak prio [17:31:27] niedzielski: now? [17:31:39] dbrant: yep! [17:33:55] niedzielski: i think you need to Verify+2 on that repo, too [17:34:25] dbrant: Thank you. Let us know how you did it. [17:34:49] dbrant: ok, hopefully good 2 go [17:35:19] bearND|afk: niedzielski: I added the ldap group to have +2 access. [17:36:19] phuedx: when is a good time to chat about the continuation parameter? https://phabricator.wikimedia.org/T101453 [17:36:23] niedzielski: did you click "Submit"? ;) [17:37:20] details, details [17:37:25] when i was a kid, a green checkbox meant something [17:38:09] dbrant: ok, it is written that the change has been merged [17:38:21] niedzielski: o/ [17:50:34] bearND|afk: it looks like the twn sync still expects the output to drop into wikipedia/res/values. i poked around in some of the scripts and hit a deadend in /home/betawiki/config/bin/repoexport. should i ping nikerabbit? [17:52:09] bearND|afk: it could also be my setup. none of the initialization steps worked for me. i ended up copying REPOCONF from your home directory and running repoupdate wikipedia-android and so forth from my home which seems to work properly. [18:03:21] jdlrobson: there? [18:03:54] codezee: yup [18:03:57] how are you [18:04:33] jdlrobson: Good! I've left a comment on https://gerrit.wikimedia.org/r/#/c/228813/ Let me know the final word on that. [18:05:16] codezee: let me take a look now [18:05:53] codezee: I see. [18:05:57] mm [18:07:34] codezee: okay that makes sense with min-height i guess for time being - we'll have to think that some more. Definitely worth talking to Nicolas about to see if it's worth reconsidering those banner resolutions with mobile in mind [18:08:09] codezee: just optimise it for banners such as Albert Einstein to optimise for the general use case (even though they are not using them now it will be good to showcase what we can do if they do) [18:09:39] codezee: sound good? [18:10:11] jdlrobson: I guess you mean keep the min-height at 100px and add some js to manipulate it for images with a different aspect ratio? [18:10:55] codezee: "define a max-height or a height to .wpb-topbanner (the container) as well." [18:11:09] try Einstein_1921_by_F_Schmutzer_-_restoration.jpg as an example [18:11:57] ok [18:15:19] jdlrobson: how do I reproduce https://phabricator.wikimedia.org/T108204 ? [18:15:54] Visit beta labs, see that the last modified bar is just a history link. Run that code, see that the message updates and it has a profile and history link [18:17:00] ah ok [18:17:02] ty [18:18:09] jdlrobson: interesting seems to be working locally. [18:18:20] I do see the issue on beta labs [18:18:49] it's broken for me locally. Stable running latest core code [18:19:19] Hmm yeah i'm fully updated. There are js errors on the beta page http://en.m.wikipedia.beta.wmflabs.org/wiki/Alcatraz_Island [18:21:55] jdlrobson: oh ok there we go. [18:24:07] bmansurov: you said that i might be able to help with something? [18:24:11] sorry, my brain's fuzzy [18:25:39] phuedx: yes, let me find the code [18:26:20] phuedx: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.watchlist/WatchListApi.js#L25 [18:26:30] phuedx: where can I read up on '-||' ? [18:28:11] bmansurov: sec -- tracking down the ticet [18:28:13] task [18:29:17] phuedx: https://gerrit.wikimedia.org/r/#/c/210679/ [18:29:52] bmansurov: associated epic: https://phabricator.wikimedia.org/T96858, new continue format: https://www.mediawiki.org/wiki/API:Query#Continuing_queries, old continue format: https://www.mediawiki.org/wiki/API:Raw_query_continue [18:29:53] rmoen: i'd suggest talking to Krinkle_ to understand how the async js broke it. I have a feeling global inline events will not work anymore [18:31:29] jdlrobson: so i see the issue, in MinervaTemplate.php we are inline emitting history-link-loaded which is before the module is loaded. Can't we just initHistoryLink in the mobile.head/init.js ? Doing it this way there is a split second where the original text is visible. Are we trying to avoid this ? [18:31:31] phuedx: thanks [18:32:03] rmoen: the purpose is to minimise flash of unstyled content to our user [18:32:08] bmansurov: don't thank me, i should've at least included a link in the comment [18:32:10] as the change can be jarring (it can go green for example) [18:32:22] it's an innocuous little string that means quite a lot [18:32:23] jdlrobson: i see [18:32:25] ;) [18:32:31] and split second is much longer on 2g connection :) [18:32:45] Can we top load the mobile.head module ? [18:33:23] it __is__ top loaded but now not blocking [18:33:38] the script is async now [18:35:19] Right. Well, Since its loading async i'm not quite sure how to avoid the noticeable style changes [18:36:11] what's the difference between the dom without the script executing and with? [18:37:29] wait… maybe i'm confused [18:37:36] phuedx: with the inline script there is no difference in the dom as the emit is happening prior to the module. If I'm understanding your question correctly [18:37:38] yep… i'm confused [18:38:02] rmoen: yup -- i got there eventually ;) [18:38:08] it would be *nice* if our event emitter would re-emit once a module is present... [18:38:40] but the way we are doing it in MinervaTemplate.php is a total hack and shouldn't be the solution [18:39:29] I'm suggesting we tear that part out, and just run the last modified behavior when the module is loaded. Flashing or not, at least its modified [18:40:46] jdlrobson: rmoen: Inline scripts, while discouraged for awhile now, are still supported. However it was never supported to manually construct