[00:01:57] <James_F>	 legoktm: Out of interest, how far away are we from switching over for WMF production? Your massive list of shame covers 600 extensions not in production, about which I care a bit less. :-)
[00:07:06] <legoktm>	 James_F: https://phabricator.wikimedia.org/T87875 looks like a little under half ?
[00:09:57] <kaity>	 jdlrobson: hey is there a wiki voyage beta labs?
[00:10:08] <kaity>	 jdlrobson: where can I see the banners?
[00:10:21] <James_F>	 legoktm: Meh. Will do some more.
[00:11:17] <jdlrobson>	 kaity: there is no wikivoyage beta labs but a recent(ish) version is on http://pagebanner.wmflabs.org/wiki/Agra
[00:11:50] <jdlrobson>	 the mobile experience still needs fine tuning but you'll be able to notice the image repositions itself on mobile
[00:13:17] <jdlrobson>	 and it's not live there yet but you can do origin=0,0.5 to define an image focus area
[00:13:37] <kaity>	 jdlrobson: cool good work
[00:14:35] <kaity>	 jdlrobson: the image should be above the page icons
[00:14:55] <kaity>	 jdlrobson: edit and watch can wrap at right end of text like on mobile web
[00:15:12] <jdlrobson>	 yeh it's not as straight forward as that though. Wikivoyage have icons in banners already
[00:15:58] <jdlrobson>	 like featured articles.
[00:16:31] <kaity>	 jdlrobson: oh i see
[00:16:43] <kaity>	 jdlrobson: so why do edit and watch need to be above it?
[00:16:53] <kaity>	 jdlrobson: its fine either way just a suggestions
[00:22:12] <jdlrobson>	 they don't, we just haven't worked out a nice way to display them yet which 1) isn't hacky and 2) doesn't clash with their existing icons such as featured article
[00:26:01] <kaity>	 hey bearND 
[00:27:54] <bearND>	 kaity: hi
[00:28:14] <kaity>	 do you know where i can get a build that has link preview?
[00:28:35] <kaity>	 the alpha build i have doesn't have it
[00:29:44] <bearND>	 kaity it does have it. It may not be enabled for you. It's random. But in the developer settings you can override this.
[00:30:44] <bearND>	 kaity: To enable the setting you need to first enable Developer mode: on the about screen you tap 7 times on the W logo
[00:31:13] <kaity>	 bearND: oh right
[00:31:36] <bearND>	 kaity: Then back to the more menu, you should see now a new item in the toolbar (top right)
[00:32:18] <bearND>	 kaity: the item called linkPreviewVersion controls it. You can set it to 0, 1, or 2.
[00:32:30] <bearND>	 0 disables it, which is probably what you've got
[00:32:42] <bearND>	 1 gives you the first prototype
[00:32:44] <kaity>	 1 has image?
[00:32:52] <bearND>	 2 gives you the secons prototype
[00:32:55] <bearND>	 second
[00:33:14] <kaity>	 bearND: got it working, thanks!
[00:34:04] <bearND>	 both have images. I think the 2nd one has the image in the background
[00:34:19] <bearND>	 ok, cool
[00:34:24] <kaity>	 bearND: and the latest with more information is coming in a build soon?
[00:37:12] <bearND>	 kaity: you are probably talking about https://gerrit.wikimedia.org/r/#/c/227451/. It's not merged yet. I don't know when this will happen. You could find the apk from there though. The link to it is https://integration.wikimedia.org/ci/job/apps-android-wikipedia-gradlew/1093/artifact/app/build/outputs/apk/app-alpha-debug.apk
[00:37:39] <bearND>	 you'd have to uninstall the old alpha first
[00:37:52] <bearND>	 or use a different device that doesn't have it
[11:40:23] <phuedx|afk>	 joakino: yt?
[11:40:33] * phuedx completely forgot to update his irc nick
[11:41:33] <joakino>	 yo phuedx !
[11:41:53] <phuedx>	 hey
[11:42:01] <phuedx>	 got 15 minutes for a chat?
[11:42:35] <joakino>	 sure
[11:42:41] <joakino>	 let me find the headphones
[11:47:12] <phuedx>	 lmk
[11:50:05] <joakino>	 phuedx: reaxy
[11:50:07] <joakino>	 ready
[12:20:35] <phuedx>	 well that was lovely
[16:56:24] <dbrant>	 bearND: would you have a minute or two for batcave?
[16:57:12] <bearND>	 dbrant: omw
[17:27:08] <jdlrobson>	 hey phuedx wanna chat about https://phabricator.wikimedia.org/T101108 ?
[17:27:11] <jdlrobson>	 my brains hurting
[17:28:10] <jdlrobson>	 basically in my mental model you have a card such as 'push the lead images to stable' and then you add blocking tasks to it which basically say 'this task cannot be done until the blocking tasks are carried out.' having a sub task 'push lead images to stable' just confuses me - as it suggests it can be done without the others being done as nothing blocks it.
[17:31:36] <bgerstle>	 etonkovidova: so you have an account in iTunesConnect already
[17:31:43] <bgerstle>	 etonkovidova: go to itunesconnect.apple.com
[17:31:48] <bgerstle>	 log in with your apple ID
[17:32:14] <bgerstle>	 then go to Analytics
[17:32:21] <bgerstle>	 "App Analytics"
[17:32:25] <bgerstle>	 mhurd: ^
[17:32:36] <etonkovidova>	 bgerstle: thx - will do after Collaboration standup
[17:32:39] <bgerstle>	 ok
[17:35:05] <mhurd>	 bgerstle: hmm i only see my personal apps
[17:35:15] <bgerstle>	 mhurd: wrong Apple ID then
[17:35:31] <mhurd>	 bgerstle: only one i have
[17:48:22] <FlorianSW>	 hi kaldari :) I hope you're fine? Can I persuade you to take a look at https://gerrit.wikimedia.org/r/#/c/194945/ again? :)
[17:56:42] <jdlrobson>	 phuedx: joakino i'm jealous of your intimate 4.50am 'lovely' chat ;-) hope you all had a great weekend :)
[17:56:51] <jdlrobson>	 (or have depending on when you read this ;-))
[18:02:21] <phuedx>	 oh
[18:03:17] <jdlrobson>	 phuedx: i'm heading to grab lunch with mozilla. Was gonna talk to them about technologies they are working on that we could make use of
[18:03:30] <phuedx>	 jdlrobson: cool! :)
[18:03:37] <phuedx>	 jdlrobson: i see what you mean about that task now
[18:04:09] <jdlrobson>	 my view of the world might be wrong it's just confused me twice now :)
[18:04:44] <phuedx>	 i guess it needs to be blocked on everything else or removed
[18:04:56] <phuedx>	 but it's a change that needs to happen to the codebase in order for the epic to be "done"
[18:05:52] <phuedx>	 brb -- getting kids to sleep
[18:12:13] <jdlrobson>	 heading out
[18:12:19] <jdlrobson>	 maybe see you after lunch
[18:22:23] <phuedx>	 ok, well the boys went down quickly
[18:24:24] <niedzielski>	 bearND dbrant mdholloway|afk: why are some mailing lists on lists.wikimedia.org and some only in google? for instance, mobile-tech
[18:33:07] <Krenair>	 lists.wikimedia.org is normal, google groups only when you want to restrict access to people with wikimedia.org google accounts etc.
[19:28:10] <kaldari>	 FlorianSW: You around?
[19:29:14] <FlorianSW>	 kaldari: here :)
[19:29:26] <kaldari>	 I'm reviewing your patch...
[19:29:41] <FlorianSW>	 great, thanks :)
[19:29:52] <kaldari>	 For some reason, it's not showing me the new editor now though. Does it use the mf_format cookie?
[19:31:37] <kaldari>	 FlorianSW: Also, what do you think about me reopening https://phabricator.wikimedia.org/T95041?
[19:32:32] <kaldari>	 or is it just based on your UserID number?
[19:32:49] <FlorianSW>	 kaldari: you need to be in a group of user, called "BucketA" :)
[19:32:52] <FlorianSW>	 exact
[19:33:26] <FlorianSW>	 kaldari: you can change L148 in https://gerrit.wikimedia.org/r/#/c/194945/19/resources/mobile.editor/init.js to be true
[19:33:30] <FlorianSW>	 and you should see the new editor :)
[19:34:42] <kaldari>	 FlorianSW: Thanks, it's working for me now
[19:35:51] <FlorianSW>	 great :) To your comment on the task: I would welcome to reopen it, but the editing team should respond, too, which (actually) wasn't the case iirc :( James_F: ping :)
[19:36:40] <James_F>	 Sorry, in meetings.
[19:52:24] <bmansurov>	 phuedx|afk: any ideas why getting the next page won't work? https://gerrit.wikimedia.org/r/#/c/229951/
[20:29:08] <niedzielski>	 dbrant bearND: would one of you mind +2ing this guy? https://gerrit.wikimedia.org/r/#/c/230004/
[20:31:56] <bearND>	 niedzielski: looking
[20:32:02] <niedzielski>	 bearND: thanks!
[20:35:58] <bearND>	 niedzielski: done
[20:36:13] <niedzielski>	 \o/
[20:48:42] <FlorianSW>	 big thanks kaldari and jdlrobson! :)
[21:25:39] <niedzielski>	 bearND: hey! i think we normally just +2 twn patches after running the testAllDevDebug but since this is my first, would you mind taking a look? https://gerrit.wikimedia.org/r/#/c/230231/
[21:26:28] <bearND>	 niedzielski: with pleasure. So, things started working?
[21:26:37] <niedzielski>	 bearND: i think so!
[21:27:12] <bearND>	 niedzielski: have you run the translation tests?
[21:29:46] <niedzielski>	 bearND: yes, i executed all tests (testAllDevDebug)
[21:32:02] <bearND>	 niedzielski: looks great. Excellent! :)
[21:32:02] <codezee>	 jdlrobson: there?
[21:32:09] <jdlrobson>	 hey codezee yup
[21:32:29] <jdlrobson>	 just deploying your extension to http://en.m.wikipedia.beta.wmflabs.org
[21:32:32] <niedzielski>	 bearND: \o/ so i'll just sync these once a week and before a release from now on?
[21:33:23] <bearND>	 niedzielski: \o/ yup, would be great. I've got a weekly meeting set up as a reminder. I'll add you to it. How's the CI stuff coming along?
[21:33:24] <codezee>	 jdlrobson: Great! I want to know, whenever we need to add an open-source library to our code, what is the standard practice? add it to package.json or just add the script file to libs/ folder?
[21:33:40] <niedzielski>	 bearND: thanks
[21:34:19] <jdlrobson>	 ummm depends what you are using it for. If you are using it in a ResourceLoader module just copy the file into a folder obviously ensuring you make it clear it's external and keeping the license in tact
[21:34:45] <niedzielski>	 bearND: ci stuff is coming. the recent timeout change seems to be working but the test results generated by instrumentation tests are in html format which kills the jenkins plugin. i'm currently looking for a solution
[21:34:49] <codezee>	 hmm, ok I get the idea
[21:35:56] <bearND>	 niedzielski: cool. Do  you have any links to test runs in Jenkins?
[21:36:15] <niedzielski>	 bearND: here's the latest: https://integration.wikimedia.org/ci/job/test-T62720-android-emulator/76/console
[21:39:13] <niedzielski>	 bearND: one thing that the emulator plugin gives us that i really like, as opposed to physical devices, is we *should* be able to run test jobs in parallel. e.g., if we have a release job that runs tests and a gate job that runs tests and they happen to run at the same time, both *should* complete successfully, albeit slowly. there will be no competition for devices. whereas a physical device can only support one ins
[21:39:13] <niedzielski>	 tallation of the package at a time and cannot run ui tests from multiple packages simultaneously
[21:40:14] <niedzielski>	 niedzielski: in the past i've used physical devices and avoiding device management and single executors is really great
[21:41:30] <bearND>	 niedzielski: this looks very promising. :)
[21:41:48] <bearND>	 happy to see some tracking on the test automation front
[21:41:53] <bearND>	 traction
[21:41:53] <niedzielski>	 me too!
[21:53:11] <niedzielski>	 bearND: https://integration.wikimedia.org/ci/job/test-T62720-android-emulator/78/testReport/
[21:53:19] <niedzielski>	 had the wrong file set :)
[21:55:19] <bearND>	 niedzielski: yeahhh ☺
[22:07:15] <jdlrobson>	 kaldari: http://en.m.wikipedia.beta.wmflabs.org/wiki/Wikidata_example_1
[22:11:15] <jdlrobson>	 http://en.wikipedia.beta.wmflabs.org/w/index.php?title=WikidataPageBanner_example_2&mobileaction=toggle_view_desktop < kaldari 
[22:26:54] <niedzielski>	 bearND: any objections to collapsing some gate checks into one jenkins job? so run android lint, checkstyle, a dev debug build, and all the tests in one job
[22:28:25] <bearND>	 niedzielski: lint has to be separate since its non voting
[22:28:50] <niedzielski>	 bearND: very good point. any concerns on collapsing the others?
[22:29:27] <niedzielski>	 bearND: hm, and actually i think i'll stick with alphaDebug so we can cut alpha builds off that sucker sometime soon
[22:29:46] <bearND>	 niedzielski: not really
[22:33:37] <bearND>	 niedzielski: should be alpha build. Ideally alphaRelease but that can be switched from debug to release as a searate task
[22:35:29] <niedzielski>	 bearND: sounds good
[22:37:47] <niedzielski>	 bearND: what kind of artifacts were you thinking? apk, mapping, checkstyle, test results, anything else?
[22:41:09] <bearND>	 niedzielski: That list looks good to me. (mapping would be added when we switch to release build type)
[22:41:35] <niedzielski>	 bearND: right, i think release build will be easy given that recent release test patch
[22:41:53] <bearND>	 nice
[22:43:13] <bearND>	 niedzielski: i guess the main difficulty is a alpha release keystore, to be shared with the Jenkins build machine(s)
[22:43:25] <bearND>	 without exposing it to the public
[22:43:47] <niedzielski>	 bearND: i was thinking we could keep debug keystore for alpha and dev builds committed to the repo
[22:44:46] <niedzielski>	 bearND: https://twitter.com/jakewharton/status/554242089236828160
[22:46:28] <bearND>	 niedzielski: hmm, ok. That would make it a lot easier.
[23:08:46] <mdholloway>	 have a great weekend, everyone!
[23:09:09] <niedzielski>	 mdholloway: hagw!]
[23:45:07] <kaity>	 jdlrobson: https://phabricator.wikimedia.org/T98029