[00:30:43] Brb [13:02:54] hullo [13:03:13] i have to dash to the doctors to register for temporary treatment about my ears [13:03:22] i shall be online in about 30 minutes [15:21:21] dbrant: howdy! a question for you: what color should do you think we make the page image backgrounds for transparent images in dark mode? white for consistency with light mode, or gray so we don't hurt people's eyes? [15:43:24] \o [15:43:58] phuedx|afk: little confused with your comment - i run `grunt ` too what am i missing? [15:44:53] whoops [15:45:13] i misread the commit message jdlrobson [15:45:42] ah okay. I just want us to get in the habit of using the preset and upstreaming changes so all of wikimedia devs develop to the same conventions [15:45:46] it makes life easier [15:46:19] hangout guys? [15:47:27] jdlrobson: feel free to use that test in your patch [15:47:47] phuedx: joakino you joining hangout [15:47:52] phuedx: already on it [15:47:54] + rmoen ^ [16:30:52] Jdl [16:39:00] Sorry guys I just woke up. Not a lot of sleep last night, baby just got immunizations yesterday and she's not very happy about it. [17:45:13] thanks for merging the task dbrant. Sometimes I wonder if my search queries are too bad or the search function doesn't understand what I mean :D [17:49:50] FlorianSW: no worries! Better to file a duplicate, than to not file at all. [17:51:00] dbrant: yeah! Do you plan to work on https://phabricator.wikimedia.org/T105471 in the next time? It's really annoying :P [18:01:03] niedzielski: can you confirm that this is still an issue? https://phabricator.wikimedia.org/T107469 [18:01:22] dbrant: on it [18:03:12] dbrant: yeah, still an issue on stock AOSP API 15 emulator [18:03:49] niedzielski: is it the case for all external links? [18:04:02] niedzielski: oh wait, nm [18:04:04] dbrant: no, just the last updated links AFAIK [18:28:59] our sprint board has so many columns. when i need to move something to the far right, i start feel like i'm on the "boardwalk" [18:47:12] niedzielski: just followed https://twitter.com/minSdkVersion [18:47:25] mdholloway: :) [18:47:31] i was surprised when they bumped it to 16 the other day! [19:49:28] bmansurov: i agree `new` is confusing :-/ [19:49:33] but that's what red links use in mediawiki core [19:49:41] ok [20:22:34] jdlrobson: should todos be based off your wip? [20:41:47] bmansurov: sure. Create a sub task though so i know you are working on it [20:42:09] jdlrobson: you mean a blocking task on phab? [20:43:35] click `create subtask` on https://phabricator.wikimedia.org/T107592#1528666 [20:43:53] adds a `blocked by` [20:44:00] ok [21:05:25] jdlrobson: I'm getting a 404 for this file http://127.0.0.1:8080/w/extensions/QuickSurvey/resources/ext.quicksurveys.init/styles.css Do you know why? [21:05:34] also for init.js too [21:08:26] nm, remoteExtPath has a missing 's' [21:12:10] spagewmf: there? [21:12:38] jdlrobson: sure, what up? [21:13:06] i'm trying to understand what i'm supposed to do to add simply click events to buttons and i'm not seeing examples on https://www.mediawiki.org/wiki/OOjs_UI/Widgets/Buttons_and_Switches [21:14:22] (i know to use `on` but i figure that should be covered in docs) [21:16:15] jdlrobson: ah, I was going to say there's an 'on' event handler. Let me look for it. There's a tracking task "pain points developing with OOjs UI (tracking)", I"ll add to that if I can't find it [21:16:33] https://phabricator.wikimedia.org/T97264 [21:20:19] spagewmf: also where can i find documentation on connect/disconnect ? [21:21:21] jdlrobson: https://www.mediawiki.org/wiki/OOjs/Events , and it mentions 'on' as well [21:22:26] jdlrobson: I'm curious, what are you doing with OOjs UI? [21:23:00] i'm trying to build a simple quick survey - https://phabricator.wikimedia.org/T107592#1528666 - but in a way that is more similar to how we use MobileFrontend. [21:23:46] "Attached event handlers are called with arguments provided to the emit method." :-( Doubled passive voice, completely obscuring who is doing what. [21:25:51] https://www.mediawiki.org/wiki/Talk:OOjs/Events < spagewmf question for you [21:26:16] i always find the oojs ui documentation frustratingly simplified [21:32:10] jdlrobson: Trevor wrote that one. It sounds like you could get the ButtonGroupWidget to emit an event to the buttons within it [21:32:43] spagewmf: also I'm not sure how to best use bind to make a click handler able to access its owner element [21:42:15] jdlrobson: ButtonGroupWidget mixes in https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.mixin.GroupElement , and that has an intriguing "aggregate" method that might do what you want [21:42:32] the key word being `might` :) [21:49:28] i need a walk. brb [22:10:33] jdlrobson: I responded on talk page [22:11:55] thanks spagewmf