[04:50:35] <asadpsalman>	 hi
[04:50:38] <asadpsalman>	 the scripts mentioned here
[04:50:39] <asadpsalman>	 https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Wikipedia_Android_app_hacking#Scripts_.28not_needed_to_build_the_app.29
[04:50:49] <asadpsalman>	 i realize that they aren't needed to build the app
[04:51:01] <asadpsalman>	 but they do dictate the content of the app itself, right?
[04:51:36] <asadpsalman>	 so, I am going to perform these steps to get the app functioning fully, right?
[04:52:30] <asadpsalman>	 and, aren't there already compiled/built versions of these css/js/svg/png files that I can add to the project directly? without needing compile myself?
[04:56:16] <asadpsalman>	 any help would really be appreciated
[05:02:51] <Deskana>	 Aww, just as I was about to respond.
[05:14:55] <asadpsalman>	 well, i'm back!
[05:16:39] <Deskana>	 asadpsalman: Yay!
[05:16:59] <Deskana>	 asadpsalman: You can skip all of those steps. There are versions of them in the repository.
[05:17:37] <asadpsalman>	 already packaged with the android studio project that i downloaded?
[05:18:56] <Deskana>	 asadpsalman: Yes, if you've run the "git clone" command higher up in the instructions then they're all there.
[05:19:19] <asadpsalman>	 great
[05:19:36] <asadpsalman>	 also, when i do a gradle build, i get an error
[05:19:40] <asadpsalman>	 wait, let me reproduce it for you
[05:22:04] <Deskana>	 asadpsalman: Sure.
[08:36:05] <asadpsalman>	 folks
[08:36:11] <asadpsalman>	 i'm trying to solve this bug
[08:36:11] <asadpsalman>	 https://phabricator.wikimedia.org/T107890
[08:36:26] <asadpsalman>	 it is the imageview that is clicking
[08:37:04] <asadpsalman>	 when I attach an OnClickListener to it then it stops showing the click animation
[08:37:11] <asadpsalman>	 even if the onClick method is empty
[08:37:15] <asadpsalman>	 it still makes the clicking noise
[08:37:27] <asadpsalman>	 but the animation disappears
[08:37:43] <asadpsalman>	 i know this kinda solves the problem
[08:37:51] <asadpsalman>	 but does anyone know what's causing this?
[10:10:32] <phuedx>	 damn -- i wish i could've told asadpsalman to comment on the phabricator ticket
[10:10:42] <phuedx>	 not sure when the first android app developer comes online
[10:27:35] <phuedx>	 i reached out to asad on twitter -- hopefully he'll sign up to phabricator and comment on the task
[10:40:16] <joakino>	 hi phuedx 
[10:40:21] <joakino>	 asadpsalman yt?
[10:40:38] <asadpsalman>	 hi!
[10:40:46] <phuedx>	 hey joakino
[10:40:59] <joakino>	 phuedx: asadpsalman is here :D
[10:41:01] <joakino>	 hi phuedx 
[10:41:18] <phuedx>	 i know -- i'm chatting with him at the moment :D
[10:42:50] <joakino>	 haha ok
[10:45:59] <phuedx>	 joakino: he's just subscribed to the task
[10:54:01] <phuedx>	 back to blocking twitter
[10:54:28] <phuedx>	 my hosts file is full of 127.0.0.1 site-that-saps-my-productivity.com
[11:41:53] <joakino>	 gonna go rest, i have a huge headache
[11:52:32] <phuedx>	 feel better soon joakino 
[16:01:15] <jdlrobson>	 kaldari: there?
[16:02:38] <jdlrobson>	 codezee: hey
[16:02:48] <jdlrobson>	 we are in wikimedia-operations if you are available getting your code on wikivoyage :)
[16:02:58] <codezee>	 jdlrobson: hello! yes I'm here
[16:06:09] <codezee>	 jdlrobson: Nicolas is also here :)
[16:06:35] <Nicolas>	 Hello everyone! Looking forward to banners deployment on Wikivoyage English :-)
[16:06:47] <jdlrobson>	 -> #wikimedia-operations :)
[16:06:57] <codezee>	 ohh
[16:16:29] <jdlrobson>	 codezee: Nicolas so provided no explosions today, we could try and aim for switching the other globals and using it exclusively either later today/tomorrow or Monday (we don't do deployments Friday or weekends)
[16:16:56] <jdlrobson>	 Monday would be the more careful day to switchover :)
[16:17:03] <jdlrobson>	 but let's see how this goes first!
[16:17:15] <codezee>	 jdlrobson: Yes, Moday would be better
[16:17:20] <jdlrobson>	 codezee: btw the origin stuff is awesome
[16:17:25] <jdlrobson>	 it's showing lots of promise
[16:17:30] <codezee>	 thanks :)
[16:18:04] <jdlrobson>	 in theory editors could rethink the dimensions for suitable banners - i notice lots of existing images get cropped to correct size but this takes that away which is huge :)
[16:20:15] <codezee>	 yes, images would no longer need to rely on screen dimensions
[16:22:18] <jdlrobson>	 codezee: i pings some apps guys on the bug so we can get more thoughts around this
[16:22:30] <jdlrobson>	 Nicolas: https://phabricator.wikimedia.org/T108785 you may also be interested as an editor who would have to use this :)
[16:22:31] <codezee>	 great!
[16:25:11] <Nicolas>	 jdlrobson, that would be great! One of the greatest pains of creating banners is to upload them to Commons and copy all of the derivative rights (DerivativeFX used to be great for that but it is broken now)
[16:25:59] <Nicolas>	 the numbers would need to be on Wikidata too, I guess
[16:27:02] <jdlrobson>	 Nicolas: yup we can tackle that separately. Right now the work codezee is doing is showing lots of promise :) works great for mobile too! :)
[16:27:22] <jdlrobson>	 (in many ways not using a panoramic image is better for mobile)
[16:27:41] <jdlrobson>	 one of the things code can do that templates cannot :)
[16:38:16] <Nicolas>	 I might have misunderstood https://phabricator.wikimedia.org/T108785 ... centering happens on client-side (JavaScript)? Why not server-side?
[16:40:51] <codezee>	 Nicolas: focusing at points other than centre happens only after determining screen dimensions(client side). However centering is already done on server side by using css
[16:41:55] <codezee>	 also currently, server side centering is only done horizontally
[16:43:08] <codezee>	 Nicolas: http://pagebanner.wmflabs.org/wiki/Agra below 400px is centered from server side
[16:46:20] <rmoen>	 phuedx|afk: thanks for helping move my patches along :)
[16:47:17] <phuedx>	 rmoen: no worries -- the requested change didn't seem too big so i figured i'd get it done if it could move it along
[16:49:28] <joakino>	 isn't that lovely when it happens
[16:51:14] <matanya>	 Deskana: did you get my email ?
[16:59:38] <jdlrobson>	 Nicolas: codezee seems like there were problems with the deployment :(
[16:59:54] <Nicolas>	 oh
[16:59:54] <jdlrobson>	 nothing to do with the extension
[17:00:21] <jdlrobson>	 a security patch made us run out of time
[17:00:43] <jdlrobson>	 sorry about the disappointment :(
[17:00:50] <jdlrobson>	 i'm seeing if i can reschedule for tomorrow
[17:01:51] <phuedx>	 jdlrobson: standup!
[17:01:59] <codezee>	 jdlrobson: can it be rescheduled on Monday, tomorrow night I'll be travelling and will not be able to be around?
[17:02:26] <codezee>	 with no connection :(
[17:04:33] <jdlrobson>	 codezee: i'll see what i can do !
[17:13:31] <dr0ptp4kt>	 joakino: dbrant bgerstle would you please add items to https://etherpad.wikimedia.org/p/Scrum-of-Scrums ?
[17:33:31] <joakino>	 dr0ptp4kt: i've added a thing
[17:33:46] <joakino>	 if you need more details ping me and we can talk about it
[17:33:58] <joakino>	 not sure if that's where we say those things
[17:57:21] <dr0ptp4kt>	 joakino: thx. yes, it was a good note.
[18:39:27] <niedzielski>	 laugh, live, code review
[18:53:03] <mdholloway>	 hooray, my tablet is fixed and getting shipped back!
[19:31:39] <FloroanSW>	 oops, jdlrobson :) Do you want to look at https://phabricator.wikimedia.org/T87256 ?
[19:31:59] <FloroanSW>	 I accidently claimed it after you claimed it already (I opened it some time ago in my browser) :)
[19:38:52] <mhurd>	 mdholloway: hey just saw you email - i'd recommend trying to see if things work w just one transform to start with - maybe the redlinks one, then, one by one, add the new ones so you can see exactly which one is being weird.
[19:38:52] <mdholloway>	 niedzielski (and dbrant): following up from standup, just to be clear, this patch is ready for review: https://gerrit.wikimedia.org/r/#/c/230129/.  the other one associated with the bug, having to do with the options menu and page saved state is on hold.  niedzielski, I'm not sure what can be done about the WikipediaApp references but I addressed all of your
[19:38:53] <mdholloway>	 other points.
[19:39:22] <niedzielski>	 mdholloway: thanks! i'm looking through that at the moment
[19:39:45] <mdholloway>	 mhurd: cool, i'll give that a try, thanks!
[19:40:13] <mdholloway>	 niedzielski: excellent, thank you!
[19:52:02] <niedzielski>	 mdholloway: it seems like most of the preexisting code interacts with the database through a cursor via the adapter. for example, the HistoryFragment implements LoaderManager.LoaderCallbacks<Cursor> so that it can interact with the database via cursor once it's been loaded rather than trying to load it on the ui thread on demand. is something like that doable?
[19:55:06] <mdholloway>	 niedzielski: i think that should be doable.  i'll rework it after i'm done looking at dbrant's link previews: TNG patch.
[19:55:26] <jdlrobson>	 FloroanSW: go for it
[19:55:28] <niedzielski>	 mdholloway: thanks (and thanks for bearing with me) :)
[19:55:33] <jdlrobson>	 it will probably get done quicker :)
[19:55:43] <niedzielski>	 mdholloway: when i reviewed the TNG patch, i said ENGAGE!
[19:56:15] <FloroanSW>	 jdlrobson: https://phab.wmfusercontent.org/file/data/ble75agxge5hzzf4fd23/PHID-FILE-odmy4pgqnc5tmknpj5rt/ps2p4zi4g6lsiwqo/Unbenannt.PNG :)
[19:56:20] <mdholloway>	 niedzielski: :)  thanks for the feedback!  
[19:56:32] <dbrant>	 -/\-
[19:56:44] <jdlrobson>	 FloroanSW: why is it a red link for create an accont?
[19:57:27] <FloroanSW>	 that's the "request an account" link. It's not the "create an account". It links to a wiki page and is red in desktop, too. iirc not in production, let me check it
[19:57:49] <FloroanSW>	 jdlrobson: see e.g. https://de.wikipedia.org/w/index.php?title=Spezial:Anmelden&returnto=Spezial%3AVersion&type=signup
[19:57:58] <FloroanSW>	 It links to https://de.wikipedia.org/wiki/Spezial:Captcha/help
[19:58:44] <jdlrobson>	 why is it red though?
[19:59:04] <FloroanSW>	 I haven't created that wiki page in my local environment :P
[20:00:07] <jdlrobson>	 ok
[20:00:44] <FloroanSW>	 jdlrobson: I can hide it, too, if you want, but it's pretty useful in my opinion :)
[20:01:04] <jdlrobson>	 which captcha do you have enabled FloroanSW ?
[20:01:08] <jdlrobson>	 am trying to replicate locally
[20:01:58] <FloroanSW>	 jdlrobson: FancyCaptcha, what we have in prod, too. It's the only one which has this link ;)
[20:02:28] <FloroanSW>	 it needs a bit more steps to setup
[20:04:25] <jdlrobson>	 FloroanSW: was using vagrant and hoped it was easy peasy..
[20:05:01] <FloroanSW>	 jdlrobson: I don't think so? I'm sure, you need to create a new set of CAPTCHAs, too
[20:05:26] <FloroanSW>	 if not, you'll get an exception with "Ran out of CAPTCHAs" or something
[20:11:10] <FloroanSW>	 jdlrobson: do you has FancyCaptcha setup?
[20:14:16] <jdlrobson>	 FloroanSW: a few changes necessary!
[20:16:14] <FloroanSW>	 jdlrobson: looking
[20:24:00] <FloroanSW>	 jdlrobson: do you know, where the refresh icon is? https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/skins.minerva.special.userlogin.styles/userlogin.less#L75
[20:26:22] <jdlrobson>	 FloroanSW: not sure
[20:26:42] <jdlrobson>	 try nearby
[20:26:59] <jdlrobson>	 yeh
[20:27:08] <jdlrobson>	 oh wait that's the different icon
[20:27:11] <FloroanSW>	 this is the icon to use? that doesn't look correct :/
[20:27:14] <jdlrobson>	 i guess it got removed at some point mistakedly
[20:27:28] <FloroanSW>	 ok, I go through the git history, yeah :D
[20:27:35] <jdlrobson>	 FloroanSW: https://gerrit.wikimedia.org/r/#/c/106473/
[20:27:47] <FloroanSW>	 damn, blame :D
[20:31:06] <jdlrobson>	 argg can't install captachas `This script requires the Python Imaging Library - http://www.pythonware.com/products/pil/`
[20:31:10] <jdlrobson>	 although that's instlled
[20:32:53] <jdlrobson>	 ahh got it
[20:39:11] <FloroanSW>	 jdlrobson: argh, how can I add a background image without repeat and with a fixed size in ResourceLoaderImageModule?
[20:39:58] <jdlrobson>	 .background-image-quick
[20:43:13] <FloroanSW>	 jdlrobson: ??? not used in MF or any other WMF project so far? (haven't found any example, or any doc)
[20:45:36] <jdlrobson>	 dbrant: how are apps doing hovercards? on click?
[20:45:49] <jdlrobson>	 FloroanSW: are you trying to do in MobileFrontend or core?
[20:45:53] <dbrant>	 jdlrobson: yep!
[20:46:11] <jdlrobson>	 FloroanSW: cos i'd suggest just doing the styling change in MobileFrontend using background-image-click
[20:46:19] <jdlrobson>	 it's good enough for now
[20:47:15] <FloroanSW>	 jdlrobson: in MF, for the refresh icon. Ok :)
[20:58:08] <jdlrobson>	 FloroanSW: ping me when you need a review :)
[20:58:21] <etonkovidova>	 niedzielski: I was wondering about https://phabricator.wikimedia.org/T106332 "inconsistent behavior with API<19...'
[20:58:45] <FloroanSW>	 ok!
[20:58:49] <etonkovidova>	 niedzielski: do you think it's gonna work if I change buildToolsVersion '22.0.1' to <19? 
[20:59:06] <niedzielski>	 etonkovidova: hey!
[20:59:16] <niedzielski>	 etonkovidova: hm, just a moment, digging in
[20:59:25] <etonkovidova>	 niedzielski: ok
[21:00:22] <niedzielski>	 etonkovidova: you're talking about making an emulator for an older device, right?
[21:00:56] <etonkovidova>	 niedzielski: right
[21:02:36] <niedzielski>	 etonkovidova: API 10 emulators do not work with the wikipedia app. API 15 works very well (seems to be quite a bit more performant than the API 21). i have had reasonable experiences with most everything abovee API 15 too
[21:03:01] <niedzielski>	 etonkovidova: for Gingerbread (API 15), you need physical device to test
[21:04:07] <niedzielski>	 oops! API 10
[21:04:10] <niedzielski>	 not 15
[21:04:19] <niedzielski>	 etonkovidova: ^^
[21:04:31] <niedzielski>	 etonkovidova: for Gingerbread (API 10), you need physical device to test
[21:05:15] <etonkovidova>	 niedzielski: hmm... understood. Don't we have some API limitations for wiki apps? sorry if it's a lame question...
[21:05:40] <niedzielski>	 etonkovidova: no, good question. app support everything from Gingerbread (API 10) to latest
[21:06:01] <etonkovidova>	 niedzielski: I see. thx!
[21:06:09] <mbinder>	 dbrant: sent you an invite for a triage party tomorrow morning, flexible on time and day, just thought it would be good to do before Friday
[21:06:15] <niedzielski>	 etonkovidova: np, thanks for qa-ing!
[21:06:27] <dbrant>	 mbinder: that's a good time. thanks!
[21:06:38] <etonkovidova>	 niedzielski: :) np
[21:08:11] <FloroanSW>	 jdlrobson: ping :P
[21:11:53] <jdlrobson>	 FloroanSW: looks like the box needs some padding
[21:12:21] <FloroanSW>	 you mean the entire box? why?
[21:13:46] <jdlrobson>	 FloroanSW: i'm just comparing stable to alpha
[21:14:06] <jdlrobson>	 it needs to look exactly the same otherwise we are not making the login form flexible enough to styling changes
[21:15:05] <FloroanSW>	 jdlrobson: then I think you mean the forced with of the image? that is introduced with my change, if you remove the width: 100% it should look like you want? :)
[21:15:18] <jdlrobson>	 feedback coming FloroanSW  :)
[21:25:42] <jdlrobson>	 FloroanSW: done :) it's close!
[21:26:47] <FloroanSW>	 jdlrobson: looking :)
[21:32:19] <mbinder>	 coreyfloyd: Need Triage looking a little beefy. Wanna set up a timebox to work though together? Dmitry and I do the same from time to time
[21:40:08] <jdlrobson>	 lolz this bug is ridiculous bmansurov . I wish @kaity would just step in.
[21:40:21] <jdlrobson>	 but bmansurov yes that was on purpose
[21:40:39] <jdlrobson>	 i figured it made more sense for the content of the user info to be in line with the rest of the content (this is what phuedx suggested)
[21:40:45] <jdlrobson>	 this is why we shouldn't design :P
[21:41:07] <bmansurov>	 hmm, isn't everything should be inside the predefined content box?
[21:41:39] <bmansurov>	 not should be, supposed to be?
[21:41:39] <FloroanSW>	 jdlrobson: what do you mean with "This is more specific then the padding rule below."?
[21:41:44] <mdholloway>	 niedzielski: does it mitigate your concerns that the database i/o methods I wrote are all getting called in descendants of SaneAsyncTask (SaveHistoryTask, SavePageTask, DeleteSavedPageTask) rather than on the UI thread?  i'm still playing with the loader approach but wanted to put that out there. 
[21:42:51] <jdlrobson>	 FloroanSW: the padding rule with the %s gets overriden
[21:42:55] <jdlrobson>	 as it is less specific
[21:43:49] <jdlrobson>	 should say above FloroanSW sorry
[21:44:00] <niedzielski>	 mdholloway: that's a good point. now i'm a little worried about that. is it safe to multithread access the database?
[21:44:05] <FloroanSW>	 jdlrobson: ah, now I know, what you mean :P Thanks
[21:46:36] <niedzielski>	 mdholloway: what's weird to me is EditSummaryContentProvider extends from SQLiteContentProvider but HistoryEntryPersister doesn't. does that make sense to you?
[21:48:09] <niedzielski>	 mdholloway: the SO consensus seems to be multithread access is fine as long as you only have one connection (via SQLiteOpenHelper)
[21:48:14] <niedzielski>	 mdholloway: http://stackoverflow.com/questions/2493331/what-are-the-best-practices-for-sqlite-on-android
[21:48:41] <mdholloway>	 niedzielski: cool, was just looking there myself.  not sure about EditSummaryContentProvider...
[21:49:59] <niedzielski>	 mdholloway: did you see the override in EditSummaryContentProvider? getDbOpenHelper() is basically the same thing you're doing
[21:50:10] <kaity>	 jdlrobson: bmansurov you're talking about the diff page?
[21:50:23] <mdholloway>	 niedzielski: no, i'll take a look
[21:50:24] <jdlrobson>	 yeh the albatross around my neck
[21:50:36] <jdlrobson>	 we are all guessing how it should look and not making any progress
[21:50:48] <jdlrobson>	 currently looks like http://i.imgur.com/fd8CNLu.png
[21:51:22] <kaity>	 jdlrobson: looking at it now
[21:51:32] <kaity>	 jdlrobson: i'll make a mock
[21:51:38] <jdlrobson>	 bmansurov is not a fan of the padding in the user info but it looks silly without it
[21:51:54] <jdlrobson>	 thanks kaity 
[21:52:04] <bmansurov>	 jdlrobson, just to be clear the padding should be inside the content area, and I'm not against it
[21:52:48] <kaity>	 jdlrobson: hard to tell what it looks like with stuff selected and dev tools open
[21:53:31] <bmansurov>	 kaity, should the selected part be there? or should it align with the box above?
[21:55:11] <mdholloway>	 niedzielski: looks like both {HistoryEntry, SavedPage}ContentProvider have getDbOpenHelper() too, they just also have a bunch of other things. 
[21:55:29] <kaity>	 jdlrobson: you mean the information about the editor?
[21:55:52] <jdlrobson>	 bmansurov: yeh but you disagree with sam :)
[21:56:11] <jdlrobson>	 anyway, kaity maybe best thing is to show me what's wrong with the url  http://i.imgur.com/fd8CNLu.png
[21:56:15] <jdlrobson>	 and we can all move on with our lives :)
[21:56:40] <FloroanSW>	 jdlrobson: I'm keen to merge https://gerrit.wikimedia.org/r/#/c/231157/1 but my python knowledge is very limited ;) Why import Image does not work anymore for newer PIL versions?
[21:57:22] <bmansurov>	 jdlrobson, I think sam is right, all I'm saying is that the padding should align with the box above.
[21:59:24] <mdholloway>	 niedzielski: but in any case, it looks like whether I go through app.getInstance().getDbOpenHelper() or app.getPersister(Whatever.class).getDbOpenHelper, it's going through the same SQLiteOpenHelper instance and therefore (probably) safe?
[22:00:22] <mdholloway>	 niedzielski: better yet, the same DBOpenHelper instance
[22:00:44] <kaity>	 jdlrobson: https://www.dropbox.com/s/cesqfxfuyy038j3/diff-width-19.png?dl=0
[22:00:55] <kaity>	 gray bg at bottom should stretch full width
[22:01:06] <kaity>	 jdlrobson: everything else constrained width
[22:01:48] <kaity>	 jdlrobson: i updated the card
[22:01:55] <kaity>	 jdlrobson: sorry that caused so much trouble
[22:03:48] <jdlrobson>	 heh. so basically the first version lol
[22:06:33] <niedzielski>	 mdholloway: sorry, was going through the docs. so if i understand correctly, getReadable/WritableDatabase() can be called from any thread (except main) at any time before or after the onOpen callback is received
[22:06:58] <niedzielski>	 mdholloway: agree on the getDbOpenHelper() analysis
[22:09:15] <mdholloway>	 niedzielski: I think that's right.  I'm going to take a peek at the source. 
[22:18:56] <niedzielski>	 mdholloway: (i'm still digging in over here. trying to make sense of the interactions between the DBOpenHelper, "PersistenceHelper" and subclasses, and the content providers
[22:19:40] <niedzielski>	 mdholloway: PersistenceHelper does have a lot of database stuff in it. it just asks for the database as a parameter but is only called by DBOpenHelper
[22:22:37] <niedzielski>	 mdholloway: all the preexisting code goes through the content provider which is the only other guy who operates on the database directly AFAIK
[22:23:21] <mdholloway>	 niedzielski: those methods asking for the db as a param struck me as odd, which is why I was just using getDbOpenHelper() in the early versions of this patch. 
[22:23:56] <niedzielski>	 mdholloway: SavedPageContentProvider does extend SQLiteContentProvider which already has the getDbOpenHelper() we need
[22:24:32] <niedzielski>	 can the SavePagePersistenceHelper delegate to SavedPageContentProvider if you moved your methods tehre?
[22:24:34] <niedzielski>	 mdholloway: ^
[22:28:43] <mdholloway>	 niedzielski: that could work.  actually there's another approach brewing in the back of my mind that (hopefully) could go through the existing content provider structure and avoid all of this. 
[22:28:57] <mdholloway>	 niedzielski: let me play with both of these...
[22:30:20] <niedzielski>	 mdholloway: to me, based on the current codebase (and my limited knowledge of this part of it), it looks the meat of database functionality is currently packed into SQLiteContentProvider and that's my bet for where the meat of your database code should live (and a tiny bit in the subclasses of it as needed)
[22:33:21] <mdholloway>	 niedzielski: cool.  I think i'm going to call it a day and attack this with fresh eyes in the morning.  thanks for digging through all of this with me. 
[22:34:26] <niedzielski>	 mdholloway: sounds good. thanks for taking the time too! i'm glad to see this investment in the codebase and definitely no expert in this part
[22:34:51] <mdholloway>	 niedzielski: have a good night!
[22:34:56] <niedzielski>	 mdholloway: hagn!
[23:02:44] <kaity>	 hey dbrant|bbl lemme know when you're back
[23:03:02] <spagewmf>	 jdlrobson: 1) did you end up using ButtonGroupWidget->aggregate() for clicks?  I added https://www.mediawiki.org/wiki/OOjs_UI/Elements/Groups#Aggregate_events and will talk to Roan about improving the OOjs/Events page.
[23:04:03] <spagewmf>	 jdlrobson: 2) I started https://www.mediawiki.org/wiki/ResourceLoader/Images but need some explanation or pointers for ResourceLoaderImage
[23:04:17] <spagewmf>	 *ResourceLoaderImageModule
[23:04:56] <James_F>	 spagewmf: MatmaRex is probably the expert for RLIM?
[23:06:21] <spagewmf>	 James_F: true.  Jon asked me to write it up.  ( /me misses kma500 :) )
[23:07:11] <James_F>	 spagewmf: Me too.
[23:07:42] <spagewmf>	 James_F: BTW, I added OOjs and its stewards to https://www.mediawiki.org/wiki/Developers/Maintainers#MediaWiki_libraries
[23:09:42] <James_F>	 spagewmf: Yes, did you not see my comments in -tech saying that was probably not the best place for them?
[23:10:15] * James_F adjusts.
[23:11:35] <spagewmf>	 James_F: ah, I thought you were saying that OOjs/Events was too fine-grained
[23:11:42] <James_F>	 spagewmf: I said that too.
[23:11:44] <James_F>	 :-)
[23:14:24] <niedzielski>	 bearND: hey! is it a correct summary of T99115 to say: builds should trigger on Jenkin merges and be uploaded to android-builds.wmflabs.org (currently down) and preferably archived on caesium?
[23:18:19] <bearND>	 niedzielski: It doesn't have to be directly android-builds.wmflabs.org. As long as it is accessible from there that is fine. Or it could be somewhere else, too, if that makes it a lot easier. This machine is a bit tricky. If you try to ssh into it it won't work, but Yuvi set up an nginx proxy so that if you access this web page it'll actually use
[23:18:19] <bearND>	 android-builder instead of android-build. Note the added "er" at the end. That's our new build machine.
[23:19:00] <bearND>	 "tricky" = the machine is somewhat hosed, hence the need to build a new machine
[23:19:31] <niedzielski>	 bearND: https://android-builder.wmflabs.org/ seems down too
[23:20:44] <niedzielski>	 bearND: so there's this build.py script which makes sense but it looks like it's just executed as a cron job, is that right?
[23:21:34] <bearND>	 niedzielski: yes, the build script is just executed by cron on the builder machine
[23:22:02] <niedzielski>	 bearND: who owns this machine and how was it made?
[23:22:27] <niedzielski>	 bearND: i want a reproducible build environment as well as a reproducible build
[23:22:29] <bearND>	 niedzielski: It's a labs machine. Yuvi set it up: https://phabricator.wikimedia.org/T104190
[23:24:08] <niedzielski>	 bearND: looks like http://android-builds.wmflabs.org/ is back up
[23:24:29] <bearND>	 niedzielski: from the topic message in labs channel I see there are some issues with ssh ATM
[23:24:41] <dr0ptp4kt>	 bearND: moment for batcave?
[23:24:48] <niedzielski>	 i guess this is what ac/dc was talking about when they said they'd been thunderstruck
[23:24:50] <dr0ptp4kt>	 bearND: er, moments?
[23:25:19] <bearND>	 dr0ptp4kt: coming
[23:25:25] <dr0ptp4kt>	 bearND: c u in a minute
[23:25:33] <bearND>	 niedzielski: I guess I should have said was having problems. Looks ok now, as you said
[23:26:02] <bearND>	 dr0ptp4kt: iOS guys are in there
[23:26:34] <dr0ptp4kt>	 bearND: ambush!
[23:34:21] <niedzielski>	 to me, this feels like exactly the same concerns as our release jobs :|
[23:44:54] <niedzielski>	 i recommend that, at least in the short term, we use the lastSuccessfulBuild/artifact/ from a JJB job since we have no key concerns for alpha now