[00:27:17] <jdlrobson>	 good job apps guys - https://twitter.com/YusTuaYus/status/631727424628215808
[00:32:40] <Deskana>	 https://twitter.com/danjgarry/status/631986643541475328
[01:06:56] <FlorianSW>	 jdlrobson: "Removing existing messages: also remove qqq, or banana checker will complain (https://integration.wikimedia.org/ci/job/mwext-Flow-npm/13/console)" -> https://www.mediawiki.org/w/index.php?title=Localisation&diff=1300467&oldid=1281751 :)
[01:22:49] <James_F>	 Deskana: Oh dear.
[09:09:12] <phuedx>	 morning
[09:48:10] <joakino>	 hi phuedx 
[09:48:15] <joakino>	 about 1h later hehe
[09:48:26] <phuedx>	 hey joakino, how're you?
[09:48:59] <joakino>	 phuedx: fine! didn't get much sleep, i watched a lot of true detective
[09:49:09] <joakino>	 2nd season is crap compared to the 1st one
[09:49:45] * phuedx hasn't seen it
[09:49:46] <phuedx>	 wellp
[09:49:52] <phuedx>	 as long as you weren't working, that's fine :)
[09:50:14] <joakino>	 1st season is a piece of art
[09:50:35] <joakino>	 8 chapters, matthew mcconaughey, great story
[09:50:59] <joakino>	 gonna catch up to my signoff duties, i'm a bit behind
[10:03:13] <phuedx>	 joakino: need a hand?
[10:03:23] <phuedx>	 or should it just be you?
[10:03:46] <joakino>	 phuedx: i got it covered, I ping people when needed :D
[10:15:21] <joakino>	 phuedx: can you shed some light on this https://phabricator.wikimedia.org/T107583#1538878 ?
[10:15:44] <joakino>	 not sure if those two are signoffable b/c the i18n stuff
[10:17:05] <phuedx>	 joakino: good point well made
[10:18:26] <phuedx>	 joakino: if we localised the messages on the server-side, then they'd be the same language as the rest of the ui
[10:18:47] <phuedx>	 don't try and do anything clever, just msg( $key )->parse()
[10:18:52] <joakino>	 phuedx: that's fine, right?
[10:18:59] <phuedx>	 joakino: that's what i'd expect
[10:19:14] <joakino>	 phuedx: i'm lacking domain knowledge on weird corner cases on this one
[10:19:28] <phuedx>	 if we wanted to use 'em on the client side, we'd have to create a module for the messages to be loaded via rl :/
[10:19:35] <joakino>	 BTW IANAPD but couldn't we use here https://gerrit.wikimedia.org/r/#/c/229989/10/includes/QuickSurveys.hooks.php on the for loop an array_filter($configuredSurveys, function ( $survey ) { return $survey['enabled'] === true; })?
[10:19:45] <joakino>	 or is it my JS-side screwing with me
[10:20:02] <phuedx>	 so that'd be an ajax call to load the messages in order to translate 'em
[10:20:17] <joakino>	 phuedx: blerbh
[10:20:20] <phuedx>	 joakino: stick it in todo as there's more work
[10:20:30] <joakino>	 phuedx: both of them? external and quick?
[10:20:33] <phuedx>	 i think server-side makes sense
[10:20:35] <phuedx>	 erm
[10:20:38] <phuedx>	 just quick
[10:20:42] <phuedx>	 external is done by design
[10:20:43] <joakino>	 oki
[10:20:49] <joakino>	 can you comment on it?
[10:20:59] <phuedx>	 no
[10:21:24] <phuedx>	 joakino: also, you could cut it down to: array_filter($configuredSurveys, function ( $survey ) { return $survey['enabled']; });
[10:21:34] <phuedx>	 if you could trust your config author to be sensible
[10:22:08] <phuedx>	 in hack you could write: array_filter( $configuredSurveys, $survey ==> $survey['enabled'] );
[10:22:36] <joakino>	 nice
[10:22:44] <joakino>	 it's like es2015 of php lol
[10:22:56] <joakino>	 if they make optional $ then it's javascript
[13:20:02] <phuedx>	 joakino: https://github.com/phuedx/MobileView
[14:46:30] <ragesoss>	 Gah. Search on iOS is so frustrating. Redirects just don't come up, ever. Even if you put in the exact name. 
[14:46:50] <ragesoss>	 Deskana^
[14:47:26] <Deskana>	 That's odd.
[14:47:55] <Deskana>	 ragesoss: Can you file a Phab task with a few example search queries?
[14:48:30] <ragesoss>	 Sure
[14:49:31] <ragesoss>	 Mobile web gives good results, but "bad guy" on the app sends me to "B", about the letter. 
[14:53:50] <ragesoss>	 Deskana: Should I tag it with something besides the iOS app? I'm searching for a general Search project on Phabricator, but that search is also broken.
[14:53:55] <ragesoss>	 (obviously this is all your fault)
[14:54:26] <Deskana>	 ragesoss: Ironically, typing "sad" into the search box will find you the "Discovery" project.
[14:54:40] <Deskana>	 ragesoss: You can tag it with that too. :-)
[14:54:51] <ragesoss>	 hahaha
[14:56:59] <ragesoss>	 Okay, on second evaluation, this was a problem of no additional search results loading after the ones for the first letter of my query.
[14:57:56] <ragesoss>	 So I got through the whole thing, and end up still with B as the top result, and even typing in the exact page name I wanted, it didn't send me there when I pressed Go.
[15:14:52] <coreyfloyd>	 ragesoss: here is the backlog for the iOS app: https://phabricator.wikimedia.org/project/sprint/profile/782/
[15:15:46] <ragesoss>	 coreyfloyd: you've got your work cut out for you!
[15:18:34] <codezee>	 jdlrobson: there?
[15:18:58] <coreyfloyd>	 ragesoss: if you only knew…
[15:19:20] <niedzielski>	 bearND|afk dbrant mdholloway: hello! do we have like a big M todo list? a list of things we need to change or check when updating the target api. I think bearND|afk may have been putting one together? things like the new CAB view, disabling auto-backup of shared prefs and such
[15:19:42] <niedzielski>	 well, certain shared prefs like cookies
[15:20:28] <dbrant>	 niedzielski: hmm, i wasn't aware of such a list
[15:20:35] <mdholloway>	 niedzielski: not that i know of, but it's a great idea
[15:22:10] <niedzielski>	 dbrant mdholloway bearND|afk: if that's the case, i think i'll start an etherpad a little later and we can phab stuff once we get a little definition
[15:22:56] <mdholloway>	 niedzielski: awesome
[15:23:46] <mdholloway>	 dbrant: what do you think about vibha's request on https://phabricator.wikimedia.org/T103948 to flip the "copy" and "share" CAB items?
[15:24:33] <mdholloway>	 dbrant: i've been looking to see if we could just fiddle with the indices somehow or if that would mean just creating our own menu
[15:25:11] <dbrant>	 mdholloway: it's not at all clear to me that Share is more important than Copy...
[15:25:18] <mdholloway>	 dbrant: agreed
[15:26:52] <dbrant>	 mdholloway: let's keep it the way it is; i'll chat with vibha about it
[15:27:02] <mdholloway>	 dbrant: sounds good to me
[15:40:17] <mdholloway>	 thumbnails are looking way better on TNG link previews
[15:42:17] <mdholloway>	 on my phone, when rotating with a link preview open, it's keeping the size from the old orientation
[15:43:15] <mdholloway>	 anyway, off to get my haircut, wish me luck, back in a bit
[15:54:32] <bearND>	 mdholloway|afk: niedzielski dbrant: https://www.mediawiki.org/wiki/Notes_from_Google_I/O_15#Action_Items is a list of todos for M. I've marked the done items. Would be good if we added links to Phab tasks for outstanding items.
[15:55:07] <dbrant>	 ah, there it is
[15:55:11] <niedzielski>	 bearND: thanks!
[16:48:36] <niedzielski>	 @mdholloway|afk @dbrant @bearND: i forgot to mention this in my last gerrit comment but signatures just changed on debug, dev, and alpha builds. for local builds too, you will have to uninstall the app
[17:16:24] <mbinder>	 mdholloway: mhurd_afk coreyfloyd standup
[17:28:19] <bearND>	 dbrant: fyi, I've added a small task to the next sprint column: https://phabricator.wikimedia.org/T109105
[17:28:39] <dbrant>	 bearND: ah, cool
[17:39:29] <bmansurov>	 jdlrobson, hey, do you know how to easily detect the platform: mobile or desktop with javascript?
[17:46:10] <dr0ptp4kt>	 quiddity: say, on https://www.mediawiki.org/w/index.php?title=Reading%2FStrategy%2FKickoff&type=revision&diff=1846553&oldid=1846502 the verbiage changed "what role" instead of "where". the role to play is implicit in the "where" style verbiage, isn't it? an implicit part of this strategy framework is that the where-to-play question should be asked earlier.
[17:46:10] <dr0ptp4kt>	 is the point of this rewording to reduce management-speak or does it fundamentally alter the nature of the question in a manner where the responses will focus on roles as opposed to ideal locations for WMF to play? obviously, the two things are tied to each other in a way.
[17:47:12] <dr0ptp4kt>	 quiddity: i may be overanalyzing this, though. just thought i better ask!
[17:49:22] <quiddity>	 dr0ptp4kt, the way it was phrased previously (" Where should the WMF Reading department play in order to [...]"), made it sound (to my mind at least) like "where should the dept frolic and experiment" !  Changing the ambiguous verb "play" would be ideal.
[17:49:56] <quiddity>	 (especially given that it is intended to be translated.  Unambiguous language is crucial.)
[18:09:14] <mbinder>	 coreyfloyd: I'm trying to calculate velocity since the kanban move. Are "Released" and "5.0 Beta Staging" viable candidates for combined completed points?
[18:10:09] <coreyfloyd>	 mbinder: yeah - thats about right - 5.0 beta staging is done… but not released to public
[18:10:31] <coreyfloyd>	 mbinder: only problem is that 5.0 beta staging has also not gone through QA - so there is something there to think about
[18:10:54] <coreyfloyd>	 mbinder: also - did go through some of the triage for iOS today… sorry for not getting back to you
[18:11:22] <mbinder>	 coreyfloyd: thanks. Let's talk about 5.0 QA (and QA generally) at retro today
[18:16:48] <etonkovidova>	 dbrant: I cannot update to the "Last successful build Fri Aug 14 2015 10:01:47..." - Application not installed. Package with that name and different signature already installed.
[18:16:55] <etonkovidova>	 dbrant: is it a known issue?
[18:22:42] <bearND>	 etonkovidova: Yes, that is expected. You will need to uninstall the old app. We switched digital signatures for alpha and dev builds. I think niedzielski was going to send out an email about that to mobile-l
[18:23:04] <mdholloway>	 dbrant: i'll merge https://gerrit.wikimedia.org/r/#/c/231584/ unless you wanna do a dimen per niedzielski's suggestion
[18:23:15] <etonkovidova>	 bearND: ok - thx!
[18:23:39] <niedzielski>	 bearND|afk: sorry, forgot i meant to do that after standup
[18:23:43] <niedzielski>	 sending now
[18:25:44] <niedzielski>	 etonkovidova: thanks for reporting this discrepancy. under normal circumstances, this would have been a bad bug!
[18:26:05] <etonkovidova>	 niedzielski: np :)
[18:29:56] <mbinder>	 mhurd: coreyfloyd bgerstle etonkovidova dr0ptp4kt vibha let's (iOS) retro
[18:30:42] <mbinder>	 jonkatz: JonKatz_ (not sure which you are) you are welcome, too, but I know you've been away
[18:35:11] <mbinder>	 https://etherpad.wikimedia.org/p/MobileAppRetrospective
[18:43:47] <jdlrobson>	 bmansurov: why do you want to detect the platform?
[18:43:52] <jdlrobson>	 you should be device agnostic :)
[18:44:06] <jdlrobson>	 there isssss no mobile
[18:44:06] <bmansurov>	 jdlrobson, it's needed for logging events
[18:44:27] <jdlrobson>	 we need to seriously stop doing that
[18:44:30] <jdlrobson>	 we should log skin instead
[18:45:01] <jdlrobson>	 (possibly register minerva beta as a real skin if we want to distinguish between stable/beta)
[18:46:20] <dbrant>	 mdholloway: go ahead & merge that one :)
[18:47:08] <jdlrobson>	 bmansurov: thoughts?
[18:48:53] <bmansurov>	 jdlrobson, could you please add your concerns to https://phabricator.wikimedia.org/T107747 ? 
[18:49:19] <jdlrobson>	 Sure although i'm not sure they are concerns.. :)
[18:49:50] <bmansurov>	 jdlrobson, yes, thoughts
[18:53:15] <jdlrobson>	 bmansurov: added
[18:53:20] <bmansurov>	 thanks
[19:10:43] <mbinder>	 http://hatjitsu.wmflabs.org/
[19:10:50] <mbinder>	 http://hatjitsu.wmflabs.org/03681
[19:17:00] <JonKatz>	 bd808 sorry my last thing ran late.  are you around now?
[19:17:26] <bd808>	 JonKatz: yeah I can join the hangout
[19:17:35] <JonKatz>	 excellent, thanks bd808 
[19:18:23] <dr0ptp4kt>	 quiddity: would it make sense to change "where to play" to "where to focus"? that way we still maintain the notion of this being about channel/segment/geo/category.
[19:19:21] <quiddity>	 dr0ptp4kt, sounds good.  (I'm just heading out for a few hours. Lunch and AFK stuff)
[19:20:45] <dr0ptp4kt>	 quiddity: thanks, will make the update
[19:25:14] <dr0ptp4kt>	 quiddity: done.
[19:26:16] <dr0ptp4kt>	 James_F: would the about this board piece in https://www.mediawiki.org/wiki/Talk:Reading/Strategy/Kickoff support translations? is that advisable with the current tech? the page itself has actually been updated to have the translation markers, just wasn't sure if that would be possible for the flow about this board box.
[19:26:28] <mbinder>	 http://hatjitsu.wmflabs.org/66985
[19:26:36] <James_F>	 dr0ptp4kt: Probably not.
[19:27:00] <dr0ptp4kt>	 James_F: ok. thx!
[19:27:13] <James_F>	 dr0ptp4kt: Roan or Matt might know for sure.
[19:29:12] <quiddity>	 dr0ptp4kt, Re: language, there are some good notes about simplifying/clarifying for ease of translation, at https://meta.wikimedia.org/wiki/Tech/News/Manual#Guidelines - I'm not at all familiar with the patterns/skills needed, but any simplifications will help to make it easier (and thus more likely) to be translated.  (ttfn :)
[19:51:25] <mdholloway|brb>	 have to go find a less loud place to park myself for retrospective...
[19:51:48] <dbrant>	 niedzielski: i think, for purely tech-debt tasks (things that don't touch the app code per se), you can move them directly to Signoff, instead of QA, so as not to confuse etonkovidova
[19:53:55] <niedzielski>	 dbrant: ok, i'm going to do a little bit of dev qa on the update link one now that it's merged
[19:59:36] <mbinder>	 niedzielski: dbrant bearND|afk mdholloway|brb dr0ptp4kt JonKatz vibha etonkovidova  reminder for android retro :)
[20:00:41] <dr0ptp4kt>	 mbinder: thx. androids dbrant bearND mdholloway|brb niedzielski apologies for missing the ios one
[20:00:47] <dr0ptp4kt>	 er...
[20:00:53] <dr0ptp4kt>	 apple peopel
[20:01:03] <dr0ptp4kt>	 disregard! system_abort!
[20:01:31] <dr0ptp4kt>	 need moar coffee
[20:04:00] <dr0ptp4kt>	   bgerstle coreyfloyd mhurd etonkovidova vibha kaity apologies for missing the ios retro
[20:04:30] <dr0ptp4kt>	 got wrapped up in a meeting
[20:21:27] <mhurd>	 dr0ptp4kt: oh no worry!
[20:43:28] <coreyfloyd>	 no problemo
[20:53:05] <MatmaRex>	 jdlrobson: hey, i'm working on upstreaming ForeignApi and i'm looking for thoughts on something
[20:53:54] <MatmaRex>	 so, any API request with 'centralauthtoken' is actually two requests, one local (to get the token) and one foreign (using this token)
[20:54:42] <MatmaRex>	 jdlrobson: seems that MF's ForeignApi goes to great lengths to avoid getting and using centralauthtoken whenever possible, i'm assuming this was dictated by mobile connectivity/bandwidth/etc.
[20:55:05] <jdlrobson>	 MatmaRex: what do you mean?
[20:55:23] <jdlrobson>	 A centralauthtoken is only valid for one query
[20:55:26] <MatmaRex>	 yes
[20:55:31] <jdlrobson>	 hence why two requests per query
[20:55:38] <MatmaRex>	 yes
[20:55:59] <MatmaRex>	 jdlrobson: but 'centralauthtoken=foo' option "should" be used for all queries. ForeignApi only uses it for requests that go through postWithToken().
[20:56:19] <MatmaRex>	 all other requests will potentially be not correctly authenticated
[20:56:21] <jdlrobson>	 Depends... if you don't need authentication it's unnecessary
[20:56:30] <MatmaRex>	 yes
[20:56:35] <MatmaRex>	 so, it's a trade-off
[20:57:15] <jdlrobson>	 i guess we didn't have any usecases where we needed to be authenticated..
[20:57:19] <jdlrobson>	 (for gets i mean)
[20:57:29] <MatmaRex>	 jdlrobson: since i'd want the upstreamed ForeignApi to be fully featured, i'd like to use centralauthtoken for all requests. i'm wondering if you guys need that not to happen.
[20:57:54] <MatmaRex>	 and i'm also wondering what kind of an interface would be sane to allow that.
[20:58:09] <jdlrobson>	 i'm not strongly against it. It will definitely complicate basic queries however.
[20:58:41] <jdlrobson>	 If our API didn't vary per user.... would be a lot simpler :/
[20:59:03] <MatmaRex>	 from a library user's perspective, it will be the same. some .get()/.post() calls will just magically fire off two requests before completing.
[20:59:18] <MatmaRex>	 but turning every request into two feels a big heavy.
[20:59:50] <MatmaRex>	 jdlrobson: meh, that would limit the functionality pretty badly.
[21:00:46] <jdlrobson>	 no.. you'd just require parameters
[21:00:49] <MatmaRex>	 jdlrobson: use cases i have in mind is getting the list of all category members (where the increased API limits for sysops/bots increase the speed a lot), or getting inherently private data (like list=alldeletedrevisions)
[21:01:20] <jdlrobson>	 yeh an alternative api for that kind of query would just expect you to be more explicit and deal with permissioning errors
[21:01:24] <jdlrobson>	 anyway that's tangential :)
[21:01:32] <jdlrobson>	 but yeh it's a trade off as you say
[21:01:44] <jdlrobson>	 and it's actually 4 requests MatmaRex 
[21:01:59] <MatmaRex>	 jdlrobson: only for requests that require a token already, but yes
[21:02:27] <jdlrobson>	 anyway it gets complicated fast :)
[21:02:44] <MatmaRex>	 not that awful if you abstract it away with some promises ;)
[21:02:47] <MatmaRex>	 anyway
[21:02:57] <MatmaRex>	 jdlrobson: so. i'm wondering if we need a switch for this behavior in the new ForeignApi.
[21:03:15] <jdlrobson>	 do you know you are going to need it? (YAGNI etc?)
[21:03:27] <jdlrobson>	 as in you are definitely going to do the category stuff
[21:03:36] <jdlrobson>	 i wonder if such things could be deferred till you work on them
[21:03:53] <MatmaRex>	 my intuition is that probably we could do without it, and we could always send the additional centralauthtoken request.
[21:04:13] <jdlrobson>	 i think do the simplest thing to start of with, document the caveats
[21:04:15] <MatmaRex>	 i'm wondering if there are any mobile-specific requirements, where the additional request would actually be a problem.
[21:04:36] <MatmaRex>	 but if you think it's okay from this angle, i'll go with the simple version for now.
[21:05:02] <jdlrobson>	 As long as documented I think it's fine. Just as a general rule i don't like to complicate code unless i know it's needed
[21:05:42] <MatmaRex>	 right. let's make it simple, then.
[21:05:51] <jdlrobson>	 The only place we're using it right now is https://en.m.wikipedia.org/wiki/Special:Uploads/Jdlrobson
[21:05:56] <MatmaRex>	 thanks!
[21:06:16] <jdlrobson>	 (wikidata stuff has sadly been turned off but i would like to experiment again with that with some gadgets so having it in core will make things a lot easier!)
[21:06:33] <jdlrobson>	 MatmaRex: also are you free Monday to talk about pre-parsed messages being shipped to the client?
[21:06:45] <jdlrobson>	 I'd like to work on upstreaming that
[21:07:45] <MatmaRex>	 jdlrobson: i am, but i'm not sure if i'm the best person to talk to about that :) VE people also have some sort of solution for it, i believe
[21:08:03] <jdlrobson>	 who would you recommend so i can talk to them? Ed?
[21:08:29] <jdlrobson>	 Roan?
[21:08:49] <MatmaRex>	 jdlrobson: i think it might have been Krenair's work? i'm not sure. you can always get James_F to point you to someone
[21:09:09] <Krenair>	 ?
[21:09:40] <Krenair>	 pre-parsed messages?
[21:09:47] <MatmaRex>	 Krenair: jdlrobson wants to talk to someone about pre-parsed messages being shipped to the client, and IIRC you're a good person to talk to?
[21:10:05] <Krenair>	 oh, so you want to parse wikitext on the server into html so you can actually handle it properly?
[21:10:17] <Krenair>	 We do some stuff like that in the VE APIs
[21:10:47] <Krenair>	 And a lot of it is likely my fault, yeah
[21:11:50] <jdlrobson>	 Krenair: cool :) Yeh we have something similar in MobileFrontend
[21:11:57] <jdlrobson>	 we use 'message-key' => 'parse'
[21:12:01] <Krenair>	 Oh.
[21:12:10] <Krenair>	 Wait, what?
[21:13:42] <Krenair>	 I had no idea you could do that.
[21:13:48] <Krenair>	 HISTORY.mediawiki:* (72839) Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule
[21:13:48] <jdlrobson>	 So we have a ResourceLoaderModule that parses before shipping them to the user. So for an example message"key" => "Welcome to {{SITENAME}}." then on the client mw.msg( 'key' ) would return 'Welcome to Wikipedia'
[21:14:01] <jdlrobson>	 yeh so ResourceLoaderParsedMessageModule is the relevant class
[21:14:06] <jdlrobson>	 it doesn't work for parameters such as $1
[21:14:09] <Krenair>	 includes/modules/MFResourceLoaderParsedMessageModule.php:class MFResourceLoaderParsedMessageModule extends ResourceLoaderFileModule {
[21:14:10] <Krenair>	 that?
[21:14:39] <jdlrobson>	 but it saves us loading javascript code to do basic things like parse messages with html/magic words in
[21:15:03] <Krenair>	 Interesting.
[21:15:04] <jdlrobson>	 So how are you doing things?
[21:15:11] <Krenair>	 Nothing that fancy.
[21:15:31] <jdlrobson>	 css styles allow 'foo.css' => 'media query'
[21:15:36] <jdlrobson>	 so we followed their pattern
[21:16:19] <Krenair>	 As this is RL stuff you'll want to CC Catrope+Krinkle
[21:17:31] <Krenair>	 https://gerrit.wikimedia.org/r/#/c/221867/3/ApiVisualEditorEdit.php :(
[21:18:20] <jdlrobson>	 CONTENTLANG, SITENAME and int:mobile-frontend-search-content are the only things we parse
[21:25:36] <bearND>	 dbrant: ready to merge the TNG patch (https://gerrit.wikimedia.org/r/#/c/227451/)?
[21:34:27] <dbrant>	 bearND: ready!
[21:35:14] <bearND>	 dbrant: ok, will do so shortly
[21:36:57] <jdlrobson>	 bmansurov: can you clarify? My goal is to use the wikimedia preset :) if there are particular bits of code you do not like please point them out :)
[21:37:08] <bmansurov>	 ok
[21:37:08] <jdlrobson>	 in terms of the assertMode I think these should only be in initialisation scripts
[21:37:11] <jdlrobson>	 not in modules
[21:37:37] <bmansurov>	 what about this? https://gerrit.wikimedia.org/r/#/c/231414/1/resources/mobile.watchlist/WatchListApi.js
[21:40:40] <jdlrobson>	 what about it bmansurov ?
[21:41:21] <bmansurov>	 jdlrobson, doesn't it seem inefficient?
[21:41:56] <dbrant>	 bearND: \o/ ^100
[21:45:49] <bearND>	 dbrant|bbl: are there any tasks associated with Lin Previews TNG in the current sprint?
[21:45:58] <jdlrobson>	 bmansurov: i'd be surprised if declaring variables had any significant performance impact, especially given all the optimisations browsers do to their js
[21:46:00] <bearND>	 s/Lin/Link/
[21:46:32] <bmansurov>	 jdlrobson, ok. i'll merge it
[21:46:46] <jdlrobson>	 declaring variables is cheap (but citation needed..)
[21:47:31] <bearND>	 niedzielski: can https://phabricator.wikimedia.org/T107478 be moved to the QA column? It's still in To Do.
[21:48:18] <niedzielski>	 bearND: yes, but i'll note that in some cases we ended up choosing to call them "links" after all
[21:50:55] <bmansurov>	 declaring undefined variables is cheap
[22:30:33] <yurik>	 yurik
[22:30:55] <yurik>	 sorry, talking to myself
[22:36:32] <asadpsalman>	 phabricator not loading on my side
[22:36:58] <asadpsalman>	 stuck on waiting for phab.wmfusercontet.org
[22:37:05] <asadpsalman>	 is it just me or something?
[22:48:45] <SVentura>	 Hello all, does anyone know why the Commons App is no longer available on the App Store? :(
[22:54:27] <dr0ptp4kt>	 SVentura: https://lists.wikimedia.org/pipermail/wikimedia-l/2015-May/077843.html
[22:58:56] <SVentura>	  @dr0ptp4kt: thanks! that's a real bummer.... not sure what the problem is, didn't read thru all but this puts a big *block* on a program
[22:59:25] <SVentura>	 is there a way to upload images to Commons otherwise? 
[23:00:11] <SVentura>	 I was able to upload an image to Commons just now... from my iPhone. 
[23:20:44] <MatmaRex>	 jdlrobson: https://phabricator.wikimedia.org/T66636#1541786 :o
[23:21:46] <MatmaRex>	 jdlrobson: i didn't check all the bazillion cases it is handling yet, but it seemed to work correctly when i tried it. reviews welcome :) i'll get some CentralAuth gurus to review it, too.
[23:22:47] <jdlrobson>	 MatmaRex: :D awesome. Will take a look first thing Monday. THat's super sweet.
[23:23:56] <MatmaRex>	 whee
[23:52:29] <asadpsalman>	 guys?
[23:52:37] <asadpsalman>	 i've managed to solve a bug in the app
[23:52:43] <asadpsalman>	 https://phabricator.wikimedia.org/T104528
[23:53:05] <asadpsalman>	 very confused on how to add it to the original repository
[23:53:18] <asadpsalman>	 any direction or link to a guideline would be appreciated
[23:59:07] <dr0ptp4kt>	 asadpsalman: i think the README.md file includes instructions. probably best to use the 'how to become a mediawiki hacker' article on mediawiki.org to get your gerrit access setup so that you can submit patches to the gerrit (git) server. cc niedzielski 
[23:59:42] <dr0ptp4kt>	 ^ bearND dbrant|bbl mdholloway|afk not sure if you guys are wrapping up. i saw niedzielski on ops channel so i know he's h4x0ring