[08:52:33] morning [11:09:30] hullo [15:45:36] joakino: can you invite me to the reading spring kickoff? home with a cold but not on the invite, so I can't join the video call... [15:50:55] thanks :) [15:57:33] ;) mbinder [16:48:10] bearND: it looks like i got my first twn sync that requires processing changes. do you have time today to help me review? [16:51:23] niedzielski: Wow, that's a really long list of changes since some string resource keys got renamed. [16:52:35] niedzielski: Hmm, next time we should do the sync of these things shortly after those big changes are merged. I usually avoid importing translation changes into TWN as not to cause any conflicts [16:55:06] bearND: ah, so when key names change, do a sync promptly? [16:56:27] niedzielski: Yeah, I think it's best to do one before the merge, and the one right after the merge. It's still not 100% safe but you can better judge which changes are from the refactor and which ones are not [16:58:13] niedzielski: do you want to do a quick hangout about the TWN sync? [16:58:37] bearND: that'd be helpful! now or later is fine with me [17:01:16] niedzielski: we can do some right now since I'll have meetings right after standup as well [17:01:34] bearND: sounds good. i'll msg you [17:01:42] oh noes, what happened rmoen jdlrobson phuedx [17:01:54] joakino: standup hangout [17:02:01] joakino: standup! [17:02:09] i voted 2001 [17:02:09] https://etherpad.wikimedia.org/p/Reading_web_sprint_2_names [17:02:12] dammit [17:02:14] fucking iinternet [17:05:18] jshint by default throws a mediaWiki not defined in javascript modules. How can we supress that? [17:30:08] bearnd can u stay on the hangout for a minute when we're done? [17:42:55] dbrant mdholloway|afk bearND: i was kind of curious what's expected in patch review. should we always be testing patches locally? [17:56:12] codezee: you can add it to jshintrc as a global [17:56:31] "globals": { "mediaWiki": true } [17:58:08] jdlrobson: yes solved! also do you have a moment, I have a small question? [18:00:23] atgo_: sorry about cutting off [18:03:05] niedzielski: I usually test it locally unless it was a trivial change [18:03:14] no worries joakino [18:03:18] your internet = the terrible [18:03:27] ye, it's so bad [18:26:57] dbrant: i'll +1 bearND|afk's request that link preview titles be clickable :) [18:50:21] codezee: sure [18:54:01] jdlrobson: You answered on phabricator :) [18:57:04] jdlrobson: i updated https://phabricator.wikimedia.org/T107747#1546773 to specify the conditions for apps so that it sort of mirrors the web use case [18:57:46] jdlrobson: should i update the main task? i don't know if the norm is for people to look at the comments or at the main task's description field when there are changes of this nature [18:57:55] dr0ptp4kt: yeh you can update the main task [18:57:57] np [18:58:00] jdlrobson: will do [18:58:02] it's better - keeps things clearer [19:40:15] @dbrant|brb: hey! you want me to reassign T108967 to "MediaWiki-API"? [19:44:35] niedzielski: yep! [20:22:17] mdholloway bearND dbrant: a friend of mine just sent this to me: http://android-developers.blogspot.com/2015/08/m-developer-preview-3-final-sdk.html [20:22:53] niedzielski: nice! [20:23:04] mdholloway bearND dbrant: (i haven't been on the news sites today so maybe this is old news.) i was personally hoping for milkshake but this was my second choice! [20:23:35] niedzielski: dang, new major version and everything [20:23:38] i thought they were going to commercial route and do M&Ms [20:23:46] niedzielski: i suppose "milk duds" is copyrighted [20:23:58] like for Kitkat [20:24:12] niedzielski: er, a trademark? whatever. [20:24:15] hm, maybe that was a one time thing? [20:24:29] could be [20:24:35] S'mores [20:24:49] yeah, that's interesting, i wonder. [20:27:39] i wasn't really thinking about it before but i am slightly surprised to see the version jump to 6 [20:29:49] niedzielski: yeah, i'm not sure i have any particular reason why, but same here [21:23:27] coreyfloyd: hey! [21:23:54] coreyfloyd: downloaded the latest build today but it keeps crashing [21:24:58] coreyfloyd: is there anything i can do? [21:43:04] joakino: thx for sharing jake's talk. It another piece of awesome [22:19:11] bearND: i confirm the translation tests aren't working for me either :| this is because snackbar_saved_page_format was changed to a format string. what is the proper course of action? delete all translations of the string? [22:20:42] niedzielski: when was that change made (Gerrit link)? [22:21:49] bearND: https://gerrit.wikimedia.org/r/#/c/229582/9/app/src/main/res/values/strings.xml#38 [22:25:03] niedzielski: thanks. I would mark those as fuzzy. [22:25:05] bearND: if i understand correctly, removing a string parameter is always ok and adding one is fine so long as it's done fully for a language. that is, both the parameter and the format string are updated in one go. i think the tests just need to be updated to reflect that [22:26:19] niedzielski: Yeah, the tests would fail until all the languages are updated to have the parameter. [22:26:29] bearND: i will mark these as fuzzy when the revert patch gets merged [22:26:49] bearND: is it worth phabbing an update to the tests? [22:27:36] niedzielski: You can then either ignore them or add code in the LanguageTests class to ignore failures for toast_saved_page. I don't think it's worth phabbing that [22:31:09] bearND: i guess what i mean is that i'm not sure checkTranslationHasParameter() is a valid test. we can automatically detect whether a translation is a format string or not but have no easy way of automating whether a parameter is supplied or not. [22:33:11] niedzielski: Well, I assume that if the English string has a parameter the translated string should have the same kind of parameter. I'm not really testing if our Java code provides the parameter. I think that's outside of the scope and much harder to do in bulk. [22:33:50] kaity: a new less crashy build will be coming tonight, but in the mean time there were instructions on the release notes on how to work around the crashes. [22:34:01] kaity: sorry for the delay! [22:37:21] bearND: ah, agreed. actually, i guess removing a parameter is the dangerous case because we would probably change the java code so that it no longer supplied the parameter. all the translation strings _must_ be deleted in this case. for other cases, like today's, we just need to mark fuzzy [22:38:56] niedzielski: I guess you're right. I would merge the deleting of the translation after you ran the TWN sync, so they don't get removed in TWN [22:39:42] dr0ptp4kt: over the past couple weeks i've seen about 20 mails illegitimately marked as spam by gmail. is this worth emailing a list about? [22:40:38] niedzielski: maybe email techsupport [22:41:12] bearND: that's only for _removing_ a parameter. for _adding_ a parameter, like today, it's ok because the javacode supplies an argument whether it's used or not and we'll just mark it fuzzy during a sync [22:42:00] dr0ptp4kt: ok will do [22:48:42] niedzielski: ok, I'm going to +2 https://gerrit.wikimedia.org/r/#/c/232212 [22:48:54] unless you want me to hold off [22:49:02] bearND: no, sounds good \o/ [22:58:18] bearND: ok that guy merged so i should sync now, right? [22:58:45] niedzielski: yes [22:58:59] * niedzielski syncs now or forever holds his peace [22:59:06] bearND: will do, thanks [22:59:18] niedzielski: let me know when you're at the stage where you go to the web page [23:00:31] bearND: i'm there. https://translatewiki.net/wiki/Special:ManageMessageGroups [23:02:20] dbrant|bbl: it looks like i missed a couple of your phab responses due to bad spam filtering. i think i got them all but if i'm remiss, please ping again [23:07:30] niedzielski: hmm, the first part (most of the english strings) looks good. Did we delete "menu_save_page_popup"? Or is that one that got moved to the strings-no-translate.xml file? Also I'm surprised to see that some translations get removed. Instead they should just get marked as fuzzy [23:10:16] bearND: deleting a string is the same as moving to no-translate as far as TWN knows, and yes, that string was deleted. [23:12:27] bearND: some of the other strings moved to no-translate which is why they appear to be deleted [23:12:33] (missing translations) [23:12:48] bearND: https://gerrit.wikimedia.org/r/#/c/229582/9/app/src/main/res/values/strings-no-translate.xml [23:14:58] niedzielski: ok, menu_save_page_popup is fine. I see now that it was deleted. But others like menu_open_in_new_tab are not in the strings-no-translate.xml file [23:18:21] the latter was brought back in your latest patch, and we had not synced since https://gerrit.wikimedia.org/r/#/c/229582 got merged [23:18:41] bearND: hm, i see that i'm on the right commit in twn and some sanity greps look ok [23:19:44] bearND: let me try a git clean i guess [23:21:01] bearND: i just ran through the steps again and the special page looks about the same [23:24:15] niedzielski: oh well. At least the list of changes is smaller now. There is one change that still worries me: Wikimedia:Wikipedia-android-strings-snippet share intro/ko [23:24:45] This removes the \ which is needed to quote the @ [23:25:10] bearND: agreed [23:25:21] bearND: does "ignore" reject the change? [23:25:27] I don't know where that comes from. [23:25:36] Yes, I would mark this as ignore [23:25:38] bearND: is that from a user? [23:26:19] niedzielski: Maybe. The question is why did we change this translated string on our side as well [23:26:49] else the sync should no pick this up as part of the TWN import [23:28:05] bearND: hm, i'm not sure [23:28:13] niedzielski: I would tend to check the ignore box for the translations unless you know we made this translation change for a good reason [23:32:04] bearND: sorry, i didn't quite follow that :/ by default i should check ignore? [23:33:23] niedzielski: for translations only [23:33:33] for english the default should be unchecked [23:34:08] bearND: for example, Wikimedia:Wikipedia-android-strings-error network error/te, why wouldn't we want that change? [23:34:14] probably would be a good enhancement request for TWN sync, or at least a good discussion to have [23:35:36] niedzielski: because it would undo what the translator did: https://translatewiki.net/w/i.php?title=Wikimedia%3AWikipedia-android-strings-error_network_error%2Fte&type=revision&diff=6396670&oldid=6069200 [23:36:09] bearND: who marked it fuzzy in the first place? [23:37:01] niedzielski: Most likely it was marked fuzzy when we change the English string for it [23:37:10] changed [23:37:37] bearND: hm, i think i've been reading this diff wrong. i was thinking that the changes that would be kept are on the right unless you check ignore, then the changes on the left are used [23:38:05] bearND: it sounds like what you're saying is i have to check ignore to get the changes on the right [23:39:13] niedzielski: Your first statement is actually correct. If you check ignore the it should keep the left side. If you don't check ignore it will use the right side [23:39:34] s/the/then/ [23:40:39] niedzielski: I would not override any translations unless you are really really sure [23:41:28] bearND: hm, i guess i'm not sure why Wikimedia:Wikipedia-android-strings-saved pages search list hint/mn is FUZZY on the left then [23:41:33] niedzielski: The ones I've overwritten in the past were wher the parameter syntax was horked or something simple in German [23:45:00] niedzielski: I'm not sure why the fuzzy flag got removed, but again, I would check ignore in this case. Maybe TWN got a bit confused after your previous try [23:46:04] I would think that the next time you run this again, it should not list this item as a potential change anymore [23:46:24] ** run this again ** after you finish this sync [23:46:54] bearND: hm, ok, so i have the first 3 guys set to "import and fuzzy". login success toast/ko, snippet share intro/ko, and error network error/te set to ignore. saved pages search list hint/mn, login success toast/mn, and menu save page/qqq unchecked (not ignored). [23:48:42] niedzielski: ok, the last one is good since it's a qqq. I forgot to add that to the rules, usually qqq should be changed only by us along with the English strings. [23:48:56] niedzielski: I would still check the "mn" ones [23:50:11] i mean ignore the "mn" ones [23:50:36] bearND: the first 3 guys set to "import and fuzzy". login success toast/ko, snippet share intro/ko, error network error/te, saved pages search list hint/mn, and login success toast/mn set to ignore. menu save page/qqq unchecked (not ignored). [23:51:00] niedzielski: looks good. [23:51:07] +2 [23:53:04] niedzielski: once that is done you can run the runJobs.php command and then the export commands [23:53:20] bearND: ugh, i can't login to the wiki. i have an ssh login but not a wiki one it seems