[09:43:33] hi! [10:04:07] howdy, phuedx and joakino [10:04:15] hey bmansurov [10:04:17] hey joakino [10:05:48] hi phuedx bmansurov [10:06:12] beta cluster is borked http://en.m.wikipedia.beta.wmflabs.org/wiki/Cat [10:09:14] maybe it's undergoing a scheduled maintenance? [10:12:55] just spent twenty minutes how we figure out the resource loader target [10:13:11] to find out that we don't figure it out, which is great :) [10:15:42] why would we need to figure it out? [10:18:02] i was interested which bit did the figuring, if any [10:18:29] i see [10:18:40] by bit i meant the skin or the resource loader [10:18:51] if there was anything in outputpage that did anything funny [10:18:55] but it's just a value [10:19:20] ok [10:19:29] which is what i'd hoped for [10:26:34] i'm going through the wiki and I've found a couple of pages that I loved reading before joining the team https://www.mediawiki.org/wiki/Reading/Web/Team/Team_values and https://www.mediawiki.org/wiki/Reading%2FWeb%2FTeam%2FTeam_norms [10:26:41] thought i'd re-share [11:17:09] phuedx: bmansurov: i'm signing off this, https://phabricator.wikimedia.org/T107586 i can see the surveys fine on the console but i see i18n keys instead of the values, is that expected? [11:17:40] i think that's expected behaviour -- we're deferring to the rl to load the survey and its messages [11:18:12] so there's an additional hit [11:18:35] sorry, there's no "additional" hit [11:18:39] derp [11:18:58] it's one hit to load the survey and its messages, which is what was expected (i think) [11:20:04] we need to document the assumptions we've made while developing this [11:20:18] ok [11:20:41] i.e. on a low bandwidth conn, the assumption that an additional http request is less costly than an upfront hit to load all surveys and messages might be bogus [11:21:27] yep [11:21:44] i thought we we're ging to send the translated values on that config object [11:22:14] that seemed the easiest to me, just a msg(key) on the server and furk it [11:22:17] but whatever [11:32:54] yeah, we could do your way too [11:38:12] bmansurov: whatever you guys decide, I trust you with the implementation detail [11:41:26] i think we mentioned this on the ticket [11:41:38] requires that the server has a good idea of the user's language [11:41:58] (which it probably does?) [11:42:58] phuedx: i thought it did, there's $this->msg on views and wfMessage or something like that too [11:43:36] joakino: sure, i know [11:43:59] as long as the messages are displayed in the same language as the interface i'm good :P [11:44:14] yerp [11:44:20] anyway we'll discuss this afternoon i guess [11:59:17] out to get a vaccine [11:59:21] i'll be back later [12:09:40] breaking for lunch [13:23:13] backsies [13:52:28] hrrm [13:52:34] problems with jenkins causing blocked merges [14:06:38] no surprises [14:23:38] darn i think i closed a task about that today [14:23:57] joakino: nope, this is different [14:24:01] sec [14:24:21] phuedx: is it https://phabricator.wikimedia.org/T109593 ? [14:24:26] example from krenair in -releng: https://integration.wikimedia.org/ci/job/operations-mw-config-phplint/1083/console [14:24:39] joakino: nope, this is a new problem :D [14:25:44] damn [14:38:09] taking the kids out for a walk before the meeting [14:49:14] meetings everywhere [14:51:03] http://cdn.meme.am/instances/63736930.jpg [15:51:42] joakino: phuedx|afk waiting for ya! [15:56:07] Hello, I would like to help, I have a iphone 6, blocked, it is blocked to the network at Sprint, does anyone know how I can unlock it for free? [16:04:17] mediawiki is fun https://i.imgur.com/fuh3ML2.gif [16:09:12] dbrant bearND: yo! i am seeing a weird issue trying to run the tests on master this morning. i'm getting a class not found exception for android.support.v4.media.TransportMediatorJellybeanMR2 [16:09:46] niedzielski: which device are you running the tests on? [16:10:15] bearND: it's an api 15 device but they used to run on it (i even have the jenkins job using this device) [16:13:02] bearND dbrant: hm, i guess that's an expected error and not the real problem http://stackoverflow.com/q/23931388/970346 [16:14:10] ah, cool [16:37:23] bath time [17:09:34] brb 5 min [17:17:14] mbinder: if each phab ticket is a sin, today is judgment day for my inbox :) [17:18:26] oof, sorry guys, POs and I are adding tags, shoulda warned you first! Gmail filters and Phab notification settings FTW... [17:54:12] rmoen: bmansurov am writing a browser test for internal surveys [17:54:19] if you want to write one for external that would be great [17:55:01] jdlrobson, do you want me to write one for external or internal surveys? [18:10:17] bearND dbrant: do you guys know if spec.js in the mobileapps repo is something marko invented, based on some other implementation, or generated by swagger? [18:11:50] niedzielski: i don't know for sure. One place to look for is the Git log of the service template (https://github.com/wikimedia/service-template-node) or ask him in the #wikimedia-services channel. [18:12:31] niedzielski: the template repo has a spec.template.yaml [18:13:32] I don't see a lot of comments there [18:14:32] jdlrobson, bmansurov I've got the bucketing bit in gerrit: https://gerrit.wikimedia.org/r/233763. just need to rebase my patches [18:16:16] rmoen: bmansurov first browser test patch submitted [18:16:23] bearND dbrant|brb: this is helpful. i didn't know where this project structure was coming from and was having some trouble with it [18:16:55] bearND: do you know why we're using "x-amples" instead of actually building out models? [18:17:47] niedzielski: i don't. I just followed Marko's example [18:19:21] bearND: i can see the spec.js is verbatim from this repo: https://raw.githubusercontent.com/wikimedia/service-template-node/master/test/features/app/spec.js [18:19:55] bearND: i'm not sure if it was conceived here, but i think it's from here [18:26:11] rmoen: bmansurov heading for lunch but feel free to work off my qa branch for the other tests [18:26:38] jdlrobson, bmansurov: cool, i'm also heading out for lunch [18:26:46] jdlrobson, i'll call it a day. will pick it up later when you guys are leaving for the day. [18:37:41] bearND|afk: able to make the api/services meeting? niedzielski or mdholloway|afk or dbrant|brb any interest in attending? [18:37:50] bgerstle: ^ you? [18:38:01] ah [18:38:07] dr0ptp4kt: i'm not sure i'm on that invite [18:38:16] niedzielski: interested to be added? [18:38:22] dr0ptp4kt: sure! i'll give it a psin [18:38:24] spin [18:39:20] niedzielski: one moment [19:06:49] bearND: does anyone read/comment on the user comments on google play ? [19:07:03] (a.ka. reviews) [19:27:51] matanya: there is no assigned person who's job is to read them, but some of us look at them occasionally. Why are you asking? [19:28:08] I am willing to do that [19:31:19] matanya: Nice. I think I should get you in touch with dbrant for this then. We have two main ways for people to send us feedback: Google Play Store reviews and via email, which goes to an OTRS queue. [19:38:09] bearND: i read the OTRS [19:38:33] i can help out if you wish with play too. [19:41:04] matanya: Very nice. Thank you for your willingness to help. I don't know how to open this up to you. I think that's really up to dbrant or dr0ptp4kt. [19:41:24] matanya: btw, on a different subject, mvdan got the build stuff figured out, and we have an updated build :) Thanks for the ping yesterday about it! [19:42:29] bearND: yes, i followed thanks for pushing it forward :) [19:58:13] matanya: Was it my imagination or did you ping me asking me to answer an email you sent me? [19:58:33] matanya: I've been off work for a week and I've built up quite a big email backlog, sorry about that. [19:58:44] matanya: And now that I've written this message, I know exactly what email you're referring to, actually. [20:09:44] Deskana: thanks, i hope you enjoyed your vacation, in your spare, time. please reply :) [20:37:56] Deskana: hey dan! is there by chance any way to get search results to include a parameter indicating whether a result is a disambig page? played w sandbox a bit... [20:39:25] mhurd: I think so, I don't know what it is off the top of my head. [20:39:30] mhurd: dbrant might. [20:39:55] * Deskana is looking. [20:40:05] * dbrant looks, too... [20:40:52] Got it [20:41:12] mhurd: http://pastebin.com/HDxB5paW [20:41:14] me too! [20:41:17] .param("ppprop", "mainpage|disambiguation") [20:41:29] Deskana: whaaaaaa!!! [20:41:41] Deskana: looking... [20:42:19] Deskana: so does that exclude main pages and disambigs? [20:43:12] mhurd: No, it adds a bit to the response that tells you if something is a disambig page. [20:43:31] Deskana: oh ppprop - makes sense [20:43:38] Deskana: thanks so much! [20:43:50] dbrant: thanks for checking too! :) [20:44:43] Deskana: oh i recall having to formerly check against a list of mainpages names to determine if a page was a main page - did both of these updates land recently? [20:45:06] mhurd: No, they've been around for a while. [20:45:15] Deskana: sweet! [20:45:17] mhurd: Turns out there's tons of stuff lying around in our poorly documented API. [20:45:20] lol [20:45:21] mhurd: Who knew?! [20:45:25] :) [21:04:52] atgo: got a minute? [21:08:48] not at this exact moment... on a call, but after? [21:08:54] call shouldn't take the full hour scheduled [21:09:12] dr0ptp4kt: ^ [21:09:48] atgo: just wanted to check that i'm correct in saying 'the mock for interstitial is done'. fair to say that? [21:10:26] yep! i think that's fair [21:10:40] you might want to say "exit interstitial" - we're just trying to be consistent to minimize confusion [21:17:04] hey mhurd coreyfloyd bgerstle I moved the ios retro for the week when monte is on vacation, to the following monday [21:17:21] estimation too [21:17:23] mbinder: ah cool [21:29:42] etonkovidova: i think this was the page jon's proof-of-concept referenced: https://developers.google.com/web/updates/2015/03/push-notificatons-on-the-open-web [21:30:50] mhurd: thanks a lot! [21:34:04] atgo: thanks! [21:35:44] jhobs: everything looking good on the marketing pages stuff or any snags? [21:45:07] dr0ptp4kt: looking good! Just a few spots where we need text decided, but other than that no snags [22:04:20] thanks for the response Deskana|Away [22:17:17] niedzielski: have you seen my comments on https://gerrit.wikimedia.org/r/#/c/232853/? [22:18:05] bearND: yeah i thought we wanted feedback from dbrant|bbl? [22:19:14] niedzielski: I'm fairly confident that we want to keep the infobox in the section text [22:19:36] bearND: ok, i'll make the amendments then. thanks for the follow-up [23:01:29] jhobs: cool. have a good night! [23:06:12] coreyfloyd: downloaded the latest [23:06:15] coreyfloyd: yay!! [23:07:12] kaity: thanks for being patient. Tried to do a lot of cleanup [23:07:17] coreyfloyd: who is focused on building the feed? [23:07:23] Me [23:07:28] coreyfloyd: cool [23:07:32] It's not all there [23:07:41] We have to decide how to get the summaries [23:07:55] coreyfloyd: do you want to spend time fine-tuning? once you get everything in place [23:08:48] Yeah we have a few bigger things this week. But then we should really be tweaking for the next month. [23:08:57] coreyfloyd: sounds good [23:09:16] coreyfloyd: yea I think spacing, shadows, sizes can wait [23:09:16] kaity: we are getting answers in the today pages and disambiguation pages right now [23:09:37] So we can get those to you for design. [23:10:15] coreyfloyd: though I would like to get some of the structure in place soon. like repeating more suggestions based on recent further back in history [23:10:27] coreyfloyd: so i can keep seeing more suggestions if i scroll [23:10:46] Yeah. I wanted to talk to you about that as well. [23:10:46] coreyfloyd: great those spike results will be really helpful [23:10:59] That's one of the bigger things we have to do. [23:11:37] kaity: so let me know if you think we need any other tweaks before this goes to everyone in reading. [23:12:27] coreyfloyd: Yes the summaries and the structure - going back further in history - those are the main 2 things [23:13:09] coreyfloyd: oh also the "more like this" buttons aren't working for me [23:13:49] Ok, make a list and play with it more tonight let's talk tomorrow and review. [23:13:54] kaity: ^ [23:14:11] coreyfloyd: will do [23:14:23] coreyfloyd: very exciting to see it coming together! [23:14:47] Yeah me too [23:15:07] kaity: also if you can get feedback from vibha or just have her in on the talk. [23:15:17] sure [23:15:20] Whichever works best