[12:57:39] hey.. [12:58:32] Iam working on https://phabricator.wikimedia.org/T98829 and I want to discuss a little about it. [15:39:05] bearND: hello! this morning is the last translation i will bug you about before your leave. as you know, we merged about a dozen symbol renames friday-ish. there's a large list of add / removes in processing now with no ignore option. it looks good to me but i wanted to double check with you whenever you have time. https://translatewiki.net/wiki/Special:ManageMessageGroups [15:39:56] Iam working on https://phabricator.wikimedia.org/T98829 [15:40:15] I want to add javascript for the bug [15:41:07] Should I add it on skins.minerva.scripts/init.js? [15:41:36] niedzielski: the list looks good to me [15:42:09] FlorianSW [15:42:14] niedzielski: in the future we should be very careful about renaming those keys [15:43:04] adisha: what about https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.search/init.js ? :) [15:44:49] bearND: i had no idea how expensive changing strings could be. i don't want to be afraid to change the code but i think you're right that we should try to be as accurate as possible at inception [15:45:09] FlorianSW: yes. It will be better [15:45:11] \o [15:45:14] hey adisha [15:45:16] hey FlorianSW [15:45:18] I thought [15:45:21] hi [15:45:28] hey jdlrobson :D How are you? [15:45:41] happy to see russian wikivoyage want the banners too :) [15:47:52] niedzielski: mhurd_afk mdholloway|afk bearND bgerstle Reminder that Corey, Dmitry, and I will miss standup for all day meetings :) [15:48:25] mbinder: i believe it was bob marley who said, "get up, stand up. stand up for your stand up" [15:48:33] mbinder: good to know [15:50:20] I am thinking to implement the following: whenever javascript is enabled it will remove class 'mw-ui-input' from id 'SearchInput' and placeholder value for MinervaTemplate,MinervaTemplateAlpha and MinervaTemplateBeta. [15:51:27] mbinder: i'm scheduled to be there as well. is that right? [15:51:44] will change from ' ' to $searchPlaceHolderMsg [16:00:27] FlorianSW , Jldrobson :Am I going in correct direction? [16:01:10] adisha: correct :) [16:04:58] adisha: FlorianSW: so what is the plan? do you want to catch me up? [16:07:13] jdlrobson, adisha the plan is to 1) in the php implementation: remove the placeholder from the search form and add mw-ui-input as a class to make the form input visible in nojs browsers and 2) implement a JavaScript, that removes the mw-ui-input class and adds the placeholder message to the input, so the JS-variant looks like it should (like it looks now) :) [16:11:09] bgerstle: how's the audio for you? [16:11:24] joakino: so-so, a bit distant, and actually a bit bass heavy [16:11:29] i have to crank it up a bit [16:11:37] ye me too bgerstle [16:23:17] Not sure about adding placeholder in js... is there any reason we can't shrink the font-size and make it bigger on larger screens? [16:23:36] e.g. media query at 320px makes the input bigger [16:24:01] adding mw-ui-input makes sense though. [16:28:32] jdlrobson: I think if we change font size for bigger screen their may be a possiblity that it may show different behaviour on different screen sizes [16:28:48] jldroboson ,FlorianSW : [16:28:56] what you guys suggest? [16:29:46] adisha: i think you should just go with what you are currently doing. Sometimes it's good to have a tangible object in front of us to decide if it's right. [16:30:34] If we decide it needs tweaking, that's good and no reflection on you. :-) [16:31:06] :-) [16:48:41] FlorianSw , jldrobson : I want a little suggestion? [16:58:26] Can anyone help with how can send Php data to javascript [17:02:46] hey FlorianSW i was wondering if you were interested in having +2 rights on wikidatapagebanner. It would be good to have more +2ers on that extension and you've proven to test things on both mobile and desktop :). [17:08:30] jdlrobson: sure, why not :) But I haven't setup the extension yet :) [17:09:18] jdlrobson: how would you feel about pairing with me on revamping an interstitial/overlay for Zero during PiC tomorrow? [17:09:58] we're moving from an OOjs UI ProcessDialog to using MFE stuff [17:12:33] jhobs: one interjection without really knowing what you mean, but is this really a good idea? MFE has an epic to move to OOJs UI (https://phabricator.wikimedia.org/T96202) so I'm wondering, if it's a really good idea for you to move back from it :] [17:13:50] FlorianSW , jldrobson : I have removed class 'mw-ui-input' [17:14:15] adisha: hmm, why? :/ It seems I missed something? [17:14:16] but facing issues in changing placeholder using javascript [17:14:43] you may want to checkout at http://198.199.96.81/core/index.php/Main_Page [17:15:40] secondly if we make placeholder = ' ' that is we remove default 'Search also' [17:15:43] how can we possibly detect if the page is a diff page? [17:16:30] codezee: php or api? [17:16:39] FlorianSW: php [17:16:57] FlorianSW: unfortunately it's due to design differences in the global south from what I've been told. The standard ProcessDialog layout doesn't meet our needs for a custom Wikipedia Zero charge warning interstitial [17:17:25] check the title :) $context->getTitle()->isSpecial( $nameOfThePage ); https://doc.wikimedia.org/mediawiki-core/master/php/classTitle.html#a9e06426da1d4af530e565123fdb3b895 [17:17:30] codezee: ^ [17:17:35] FlorianSW: I agree in a perfect world we should stick with oojsui and just work on patching the library for what we need, but it's a time-sensitive thing :/ [17:17:36] it will be difficult to detect where is input type in UI for screen size >320 px and disabled javascript [17:18:14] jhobs: ok, that I count to the part "without really knowing what you mean" :) That makes sense :/ [17:18:29] jdlrobson: regarding pairing, rmoen said he'll also be there and happy to pair, so either way I'll be getting some awesome help :) [17:18:46] adisha: nojs is a class on the html tag which will be removed, if JS is enabled, so you can use that in css/less :) [17:18:48] FlorianSW: thanks! [17:19:10] codezee: np ;) [17:20:27] FlorianSW: I am bit confused. [17:20:53] I think I am not clear. [17:21:23] sorry, I mixed two different topics :( Forget what I said about the nojs css class :) [17:22:27] jdlrobson: can I help you understanding the code in change https://gerrit.wikimedia.org/r/#/c/232064/ ? It would be great to get this merged :) [17:23:26] mhurd: https://phabricator.wikimedia.org/T110702 [17:38:38] when js enabled [17:41:49] very interesting http://googleblog.blogspot.de/2015/08/android-wear-now-works-with-iphones.html :) So there is no reason for Apples Watch anymore :P [17:42:54] :D [17:44:37] so you will be saying "Ok Google" and communicating with your iphone? xD [17:46:22] rmoen, how did you get the tokens for bucketing in your tests? i'm having a hard time getting my tests passed and I could do with your explanation. [17:46:50] bmansurov: 1 min [17:50:05] bmansurov: i got them from the console. When you find one that is bucketed for that experiment, save the token then remove it. [17:50:12] then repeat [17:50:40] rmoen, ok thanks [17:51:30] any chance dbrant will be around today ? [18:28:01] FlorianSW , jdlroboson : I want to change the placeholder text on javascript enabled or disabled.I am unable to do it.. [18:30:01] addshore: what is the exact problem? :) [18:30:16] I mean: Can you add text as a placeholder and it's just not the message you want? [18:30:42] *hides away from the ping that was not meant to be* [18:32:13] addshore: damn, sorry :) [18:42:38] FlorianSW: sure. will have to wait till wednesday though i'm in 2 day meeting :/ [18:42:52] rmoen: could you help me clear out the board to make kick off as easy as possible? [18:42:59] gotta go back to meetinz eek [18:43:09] jdlrobson: have fun :P [18:43:26] jdlrobson: sure thing [18:49:40] jdlrobson: btw how did you intend to replace the api call to the search api? [18:50:28] defining a config variable in javascript? how will we inject the search term? [19:24:24] matanya: I'd say chances are pretty low today and tomorrow [19:24:51] thanks [19:49:01] rmoen: thanks dude. Keen to do next sprint with minimal quick survey stuff. [19:49:08] benestar: ? context? [19:50:48] gonna get some lunch really quick. brb [19:56:11] bearND: i had a question on T108347. i don't seem to be able to add the excerpt request to the gallery collection request because it uses the images generator, which doesn't support excerpts AFAIK. is it fine to make a separate request for excerpts? [19:57:47] niedzielski: isn't that the same that we do in the app? [19:58:10] bearND: we make a separate request for the excerpts, yes [19:58:59] niedzielski: yes, I think it's fine to do the same in the service. Ideally you could run the both in parallel. [19:59:05] them both [20:15:46] niedzielski: the query example you mentioned uses full-text search (generator=search); you want generator=prefixsearch. [21:38:46] bearND: i found T110946 but it's not a regression. everything looks good to me [21:52:42] niedzielski: thanks. Doesn't sound like a blocker to me. [21:53:46] bearND: sounds good. are you cool with the release notes? i was going to finish cutting and send the mail [21:55:39] niedzielski: looks good to me. Thanks [21:55:53] bearND: ok great! [22:33:02] bearND: for tsg, is it fine to just send them over the link to the appropriate folder in the gdrive? [22:33:50] niedzielski: I usually copy the prod apk and move the copy to the TSG folder [22:35:33] bearND: ah, so you would just add the "-r-" apk to the TSG/apks folder and send them a link to that? [22:38:18] niedzielski: yes [22:38:32] niedzielski: see my email with subject "Wikipedia Android app 109 testing" [22:42:34] bearND: okey dokey. i think we're all set. thanks! [22:43:15] niedzielski: cool. It doesn't hurt to cc the mailing list for this so we're all in the loop [22:43:47] bearND: i did but i only just sent it so it should be coming your way shortly [22:43:49] nm, just took a bit until it showed up in my inbox [22:46:52] niedzielski: i usually send the link to the whole folder, so it also includes the test report sheet. Speaking of which, I think it would be good if you added a few test cases for loading images from saved pages (in offline mode) to the template. You could leave the TC number blank. [22:53:42] bearND: ok, will follow up [22:54:11] thanks [22:59:00] bearND: do you renumber the other test cases when adding a new case in the middle? [23:11:19] niedzielski: no, I just either leave the new ones blank or do something like 45a, 45b, 45c. I think TSG does the renumbering. [23:17:40] bearND: ok cool, thanks [23:35:57] niedzielski: fyi, I've updated your new test cases slightly [23:36:08] bearND: ok thanks for the heads up